From def9a4b6bcca64009858d82db137d0ae21696e40 Mon Sep 17 00:00:00 2001 From: Simon Marchi Date: Fri, 25 Oct 2019 17:29:57 -0400 Subject: [PATCH] Fix -Wsuggest-attribute warnings MIME-Version: 1.0 Content-Type: text/plain; charset=utf8 Content-Transfer-Encoding: 8bit plan_skip_all unconditionally exits, so it can be marked as noreturn. Fixes: CC tap.lo /home/smarchi/src/babeltrace/tests/utils/tap/tap.c: In function ‘plan_skip_all’: /home/smarchi/src/babeltrace/tests/utils/tap/tap.c:231:1: error: function might be candidate for attribute ‘noreturn’ [-Werror=suggest-attribute=noreturn] plan_skip_all(const char *reason) ^~~~~~~~~~~~~ Change-Id: I740aa065c888c53a7be880a9e6e68e6f12b1d42d Signed-off-by: Simon Marchi Reviewed-on: https://review.lttng.org/c/babeltrace/+/2259 Tested-by: jenkins Reviewed-by: Francis Deslauriers --- configure.ac | 1 - tests/utils/tap/tap.h | 1 + 2 files changed, 1 insertion(+), 1 deletion(-) diff --git a/configure.ac b/configure.ac index 9f4f27d1..7c687523 100644 --- a/configure.ac +++ b/configure.ac @@ -682,7 +682,6 @@ AX_COMPILER_FLAGS( -Wno-missing-include-dirs dnl -Wno-duplicated-cond dnl -Wno-double-promotion dnl - -Wno-suggest-attribute=noreturn dnl -Wno-cast-align dnl ]) diff --git a/tests/utils/tap/tap.h b/tests/utils/tap/tap.h index c653076d..0d6e6687 100644 --- a/tests/utils/tap/tap.h +++ b/tests/utils/tap/tap.h @@ -84,6 +84,7 @@ __attribute__((format(TAP_PRINTF_FORMAT, 5, 6))) unsigned int _gen_result(int, const char *, const char *, unsigned int, const char *, ...); int plan_no_plan(void); +__attribute__((noreturn)) int plan_skip_all(const char *); int plan_tests(unsigned int); -- 2.34.1