From ee0d92f7ace5fdcb8f9405eb8abec9d623218e79 Mon Sep 17 00:00:00 2001 From: Michael Jeanson Date: Thu, 2 Feb 2017 17:03:08 -0500 Subject: [PATCH] Port: replace strerror_r() with glib g_strerror() MIME-Version: 1.0 Content-Type: text/plain; charset=utf8 Content-Transfer-Encoding: 8bit Signed-off-by: Michael Jeanson Acked-by: Mathieu Desnoyers Signed-off-by: Jérémie Galarneau --- configure.ac | 1 - include/babeltrace/babeltrace-internal.h | 12 +++++------ include/babeltrace/compat/string.h | 26 ------------------------ 3 files changed, 6 insertions(+), 33 deletions(-) diff --git a/configure.ac b/configure.ac index 56255d0a..6d097bb6 100644 --- a/configure.ac +++ b/configure.ac @@ -97,7 +97,6 @@ AC_FUNC_MALLOC AC_FUNC_MKTIME AC_FUNC_MMAP AC_FUNC_REALLOC -AC_FUNC_STRERROR_R AC_CHECK_FUNCS([ \ atexit \ dirfd \ diff --git a/include/babeltrace/babeltrace-internal.h b/include/babeltrace/babeltrace-internal.h index a903c686..0e73cdbf 100644 --- a/include/babeltrace/babeltrace-internal.h +++ b/include/babeltrace/babeltrace-internal.h @@ -83,16 +83,16 @@ extern int babeltrace_verbose, babeltrace_debug; #define _bt_printf_perror(fp, fmt, args...) \ ({ \ - char buf[PERROR_BUFLEN] = "Error in strerror_r()"; \ - compat_strerror_r(errno, buf, sizeof(buf)); \ - _bt_printfe(fp, "error", buf, fmt, ## args); \ + const char *errstr; \ + errstr = g_strerror(errno); \ + _bt_printfe(fp, "error", errstr, fmt, ## args); \ }) #define _bt_printfl_perror(fp, lineno, fmt, args...) \ ({ \ - char buf[PERROR_BUFLEN] = "Error in strerror_r()"; \ - compat_strerror_r(errno, buf, sizeof(buf)); \ - _bt_printfle(fp, "error", lineno, buf, fmt, ## args); \ + const char *errstr; \ + errstr = g_strerror(errno); \ + _bt_printfle(fp, "error", lineno, errstr, fmt, ## args);\ }) /* printf without lineno information */ diff --git a/include/babeltrace/compat/string.h b/include/babeltrace/compat/string.h index 60926161..c3325a3b 100644 --- a/include/babeltrace/compat/string.h +++ b/include/babeltrace/compat/string.h @@ -26,32 +26,6 @@ #include #include -#if !defined(__GLIBC__) || ((_POSIX_C_SOURCE >= 200112L || _XOPEN_SOURCE >= 600) && !defined(_GNU_SOURCE)) - -/* XSI-compliant strerror_r */ -static inline -int compat_strerror_r(int errnum, char *buf, size_t buflen) -{ - return strerror_r(errnum, buf, buflen); -} - -#else - -/* GNU-compliant strerror_r */ -static inline -int compat_strerror_r(int errnum, char *buf, size_t buflen) -{ - char *retbuf; - - retbuf = strerror_r(errnum, buf, buflen); - if (retbuf != buf) - strncpy(buf, retbuf, buflen); - buf[buflen - 1] = '\0'; - return 0; -} - -#endif - #ifdef HAVE_STRNLEN static inline size_t bt_strnlen(const char *str, size_t max) -- 2.34.1