From 1a543dc4a5c9f1f4dcb940f1622fbf1c283e6047 Mon Sep 17 00:00:00 2001 From: Simon Marchi Date: Thu, 8 Feb 2024 14:31:13 -0500 Subject: [PATCH] bt2/setup.py.in: don't call get_cflags/get_ldshared unnecessarily In our_get_config_vars(), we call get_cflags() and get_ldshared() even if their result is not going to be used. Make the `overridden_config_vars` dict hold references to the functions, and invoke them as needed. Change-Id: Ibad179b84fb06c4d7ae9bf1160ec38e903210f79 Signed-off-by: Simon Marchi --- src/bindings/python/bt2/setup.py.in | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/src/bindings/python/bt2/setup.py.in b/src/bindings/python/bt2/setup.py.in index e256e42e..0d1ca724 100644 --- a/src/bindings/python/bt2/setup.py.in +++ b/src/bindings/python/bt2/setup.py.in @@ -87,24 +87,24 @@ def get_ldshared(): def our_get_config_vars(*args): - overridden_config_vars = { - "CFLAGS": get_cflags(), - "LDSHARED": get_ldshared(), + overridden_config_vars_funcs = { + "CFLAGS": get_cflags, + "LDSHARED": get_ldshared, } if len(args) == 0: # Return a dict with all config vars. all_config_vars = original_get_config_vars() - for name in overridden_config_vars: - all_config_vars[name] = overridden_config_vars[name] + for name in overridden_config_vars_funcs: + all_config_vars[name] = overridden_config_vars_funcs[name]() return all_config_vars else: # Return a list with the requested config vars. subset_config_vars = [] for name in args: - if name in overridden_config_vars: - subset_config_vars.append(overridden_config_vars[name]) + if name in overridden_config_vars_funcs: + subset_config_vars.append(overridden_config_vars_funcs[name]()) else: subset_config_vars.append(original_get_config_vars(name)[0]) -- 2.34.1