projects / deliverable / binutils-gdb.git / blame
? search:
summary | shortlog | log | commit | commitdiff | tree
blob | blame (incremental) | history | HEAD
Silence maybe-uninitialized warning in dwarf2read.c
[deliverable/binutils-gdb.git] / gdb / ChangeLog
CommitLineData
feee869b
TT		 12019-12-04 Tom Tromey <tromey@adacore.com>
2
3 * dwarf2read.c (process_structure_scope): Initialize
4 "discr_offset".
5
c2512106
AB		 62019-12-04 Andrew Burgess <andrew.burgess@embecosm.com>
7
8 * mi/mi-symbol-cmds.c (mi_symbol_info): Take extra parameter, and
9 add it into the search spec.
10 (parse_max_results_option): New function.
11 (mi_info_functions_or_variables): Parse -max-results flag and pass
12 it to mi_symbol_info.
13 (mi_cmd_symbol_info_modules): Likewise.
14 (mi_cmd_symbol_info_types): Likewise.
15 * symtab.c (global_symbol_searcher::add_matching_symbols): Change
16 return type to bool, change result container into a set, and don't
17 add new results if we have enough already.
18 (global_symbol_searcher::add_matching_msymbols): Change return
19 type to bool, and don't add new results if we have enough already.
20 (sort_search_symbols_remove_dups): Delete.
21 (global_symbol_searcher::search): Early exit from search loop when
22 we have enough results. Use a std::set to collect the results
23 from calling add_matching_symbols.
24 * symtab.h (global_symbol_searcher) <set_max_seach_results>: New
25 member function.
26 (global_symbol_searcher) <m_max_search_results>: New member
27 variable.
28 (global_symbol_searcher) <add_matching_symbols>: Update header
29 comment and change return type to bool.
30 (global_symbol_searcher) <add_matching_msymbols>: Update header
31 comment and change return type to bool.
32
f97a63c5
AB		 332019-12-04 Andrew Burgess <andrew.burgess@embecosm.com>
34
35 * symtab.c (symbol_search::compare_search_syms): Update header
36 comment.
37 (global_symbol_searcher::is_suitable_msymbol): New function.
38 (global_symbol_searcher::expand_symtabs): New function.
39 (global_symbol_searcher::add_matching_symbols): New function.
40 (global_symbol_searcher::add_matching_msymbols): New function.
41 (global_symbol_searcher::search): Move most of the content
42 into the new functions above, and call them as needed.
43 * symtab.h (global_symbol_searcher) <expand_symtabs>: New member
44 function.
45 (global_symbol_searcher) <add_matching_symbols>: New member
46 function.
47 (global_symbol_searcher) <add_matching_msymbols>: New member
48 function.
49 (global_symbol_searcher) <is_suitable_msymbol>: New member
50 function.
51
293b38d6
AB		 522019-12-04 Andrew Burgess <andrew.burgess@embecosm.com>
53
54 * mi/mi-cmds.c (mi_cmds): Add -symbol-info-module-functions and
55 -symbol-info-module-variables entries.
56 * mi/mi-cmds.h (mi_cmd_symbol_info_module_functions): Declare.
57 (mi_cmd_symbol_info_module_variables): Declare.
58 * mi/mi-symbol-cmds.c
59 (module_symbol_search_iterator): New typedef.
60 (output_module_symbols_in_single_module_and_file): New function.
61 (output_module_symbols_in_single_module): New function.
62 (mi_info_module_functions_or_variables): New function.
63 (mi_cmd_symbol_info_module_functions): New function.
64 (mi_cmd_symbol_info_module_variables): New function.
65 * NEWS: Mention new MI command.
66
4cbd39b2
CB		 672019-12-03 Christian Biesinger <cbiesinger@google.com>
68
69 * bcache.c (hash): Remove.
70 (hash_continue): Remove.
71 * bcache.h (hash): Remove.
72 (hash_continue): Remove.
73 (struct bcache) <ctor>: Update.
74 * psymtab.c (psymbol_hash): Update.
75 * stabsread.c (hashname): Update.
76 * utils.h (fast_hash): Add an argument for a start value,
77 defaulting to zero.
78
82f910ea
PW		 792019-12-03 Philippe Waroquiers <philippe.waroquiers@skynet.be>
80 * symtab.c (symbol_cache_clear_slot): Move close to cleared type.
81 (destroy_block_symbol_cache): New function.
82 (symbol_cache:~symbol_cache) Call destroy_block_symbol_cache.
83 (resize_symbol_cache): Likewise.
84
de2396d0
TT		 852019-12-02 Tom Tromey <tom@tromey.com>
86
87 * unittests/tui-selftests.c (run_tests): Make conditional.
88 (_initialize_tui_selftest): Make conditional.
89
638d85bc
CB		 902019-12-02 Christian Biesinger <cbiesinger@google.com>
91
92 * aix-thread.c (debug_aix_thread): Change type to bool.
93
7532a164
LM		 942019-12-02 Luis Machado <luis.machado@linaro.org>
95
96 * infrun.c (follow_fork_inferior): Remove outdated FIXME comment.
97
216a7e6b
AB		 982019-12-01 Andrew Burgess <andrew.burgess@embecosm.com>
99
100 * dwarf2read.c (read_tag_string_type): Read the fields required to
101 make a dynamic string, and possibly create a dynamic range for the
102 string.
103 (attr_to_dynamic_prop): Setup is_reference based on the type of
104 attribute being processed.
105 * gdbtypes.c (is_dynamic_type_internal): Handle TYPE_CODE_STRING.
106 (resolve_dynamic_array): Rename to...
107 (resolve_dynamic_array_or_string): ...this, update header comment,
108 and accept TYPE_CODE_STRING.
109 (resolve_dynamic_type_internal): Handle TYPE_CODE_STRING.
110
11a8b164
AB		 1112019-12-01 Andrew Burgess <andrew.burgess@embecosm.com>
112
113 * dwarf2read.c (dwarf2_per_cu_int_type): New function, takes most
114 of its implementation from...
115 (dwarf2_per_cu_addr_sized_int_type): ...here, which now just calls
116 the new function.
117
5bbd8269
AB		 1182019-12-01 Andrew Burgess <andrew.burgess@embecosm.com>
119
120 * dwarf2read.c (read_subrange_type): Read bit and byte stride and
121 create a range with stride where appropriate.
122 * f-valprint.c: Include 'gdbarch.h'.
123 (f77_print_array_1): Take the stride into account when walking the
124 array. Also convert the stride into addressable units.
125 * gdbtypes.c (create_range_type): Initialise the stride to
126 constant zero.
127 (create_range_type_with_stride): New function, initialise the
128 range as normal, and then setup the stride.
129 (has_static_range): Include the stride here. Also change the
130 return type to bool.
131 (create_array_type_with_stride): Consider the range stride if the
132 array isn't given its own stride.
133 (resolve_dynamic_range): Resolve the stride if needed.
134 * gdbtypes.h (struct range_bounds) <stride>: New member variable.
135 (struct range_bounds) <flag_is_byte_stride>: New member variable.
136 (TYPE_BIT_STRIDE): Define.
137 (TYPE_ARRAY_BIT_STRIDE): Define.
138 (create_range_type_with_stride): Declare.
139 * valarith.c (value_subscripted_rvalue): Take range stride into
140 account when walking the array.
141
82e3b564
TT		 1422019-12-01 Tom Tromey <tom@tromey.com>
143
144 * tui/tui-win.c (tui_all_windows_info): Treat inactive TUI
145 specially.
146
517d261d
TT		 1472019-12-01 Tom Tromey <tom@tromey.com>
148
149 * tui/tui-winsource.c (tui_copy_source_line): Don't advance past
150 \0.
151 * unittests/tui-selftests.c: New file.
152 * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add tui-selftests.c.
153
484c9b64
TT		 1542019-12-01 Tom Tromey <tom@tromey.com>
155
156 * tui/tui.c (tui_enable): Call tui_update_variables earlier.
157
a2a7af0c
TT		 1582019-12-01 Tom Tromey <tom@tromey.com>
159
160 * NEWS: Document new settings.
161 * tui/tui-wingeneral.c (box_win): Apply appropriate border style.
162 * tui/tui-win.c (_initialize_tui_win): Add border style
163 observers.
164 * tui/tui-io.h (tui_apply_style): Declare.
165 * tui/tui-io.c (tui_apply_style): Rename from apply_style. No
166 longer static.
167 (apply_ansi_escape, tui_set_reverse_mode): Update.
168 * cli/cli-style.h (class cli_style_option) <add_setshow_commands>:
169 Add "skip_intensity" parameter.
170 <changed>: New member.
171 <do_set_value>: Declare.
172 (tui_border_style, tui_active_border_style): Declare.
173 * cli/cli-style.c (tui_border_style, tui_active_border_style): New
174 globals.
175 (cli_style_option): Initialize "changed".
176 (cli_style_option::do_set_value): New function.
177 (cli_style_option::add_setshow_commands): Add "skip_intensity"
178 parameter. Update.
179 (STYLE_ADD_SETSHOW_COMMANDS): Add "SKIP" parameter.
180 (_initialize_cli_style): Update. Create TUI border style
181 commands.
182
d1da6b01
TT		 1832019-12-01 Tom Tromey <tom@tromey.com>
184
185 * tui/tui-winsource.h (tui_copy_source_line): Add "ndigits"
186 parameter.
187 * tui/tui-winsource.c (tui_copy_source_line): Add "ndigits"
188 parameter.
189 * tui/tui-win.h (compact_source): Declare.
190 * tui/tui-win.c (compact_source): New global.
191 (tui_set_compact_source, tui_show_compact_source): New functions.
192 (_initialize_tui_win): Add "compact-source" setting.
193 * tui/tui-source.c (tui_source_window::set_contents): Handle
194 compact_source setting.
195 * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
196 * NEWS: Document new setting.
197
489dbda6
TT		 1982019-11-30 Tom Tromey <tom@tromey.com>
199
200 * dwarf2read.c (dwarf2_add_field): Include field offset when
201 computing variant part length.
202
bf498525
PW		 2032019-11-30 Philippe Waroquiers <philippe.waroquiers@skynet.be>
204 * NEWS: Mention define-prefix. Tell that command names can now
205 contain a . character.
206
be09caf1
PW		 2072019-11-30 Philippe Waroquiers <philippe.waroquiers@skynet.be>
208
209 * command.h (valid_cmd_char_p): Declare.
210 * cli/cli-decode.c (valid_cmd_char_p): New function factorizing
211 the check of valid command char.
212 (find_command_name_length, valid_user_defined_cmd_name_p): Use
213 valid_cmd_char_p.
214 * cli/cli-script.c (validate_comname): Likewise.
215 * completer.c (gdb_completer_command_word_break_characters):
216 Do not remove . from the word break char, update comments.
217 (complete_line_internal_1): Use valid_cmd_char_p.
218 * guile/scm-cmd.c (gdbscm_parse_command_name): Likewise.
219 * python/py-cmd.c (gdbpy_parse_command_name): Likewise.
220
c6ac7fc9
PW		 2212019-11-30 Philippe Waroquiers <philippe.waroquiers@skynet.be>
222
223 * cli/cli-script.c (do_define_command): Ensure a redefined
224 prefix command is kept as a prefix command.
225 (define_prefix_command): New function.
226 (show_user_1): Report user defined prefixes.
227 (_initialize_cli_script): Create the new 'define-prefix' command.
228 Add completers for 'define' and 'document'.
229 * top.c (execute_command): If command is a user-defined prefix only
230 command, report the list of commands for this prefix command.
231
a992a3b0
TBA		 2322019-11-29 Tankut Baris Aktemur <tankut.baris.aktemur@intel.com>
233
234 * valops.c (find_oload_champ): Improve debug output.
235
e9194a1a
TBA		 2362019-11-29 Tankut Baris Aktemur <tankut.baris.aktemur@intel.com>
237
238 * valops.c (find_oload_champ): Print part of debug messages
239 before the badness vector is std::move'd.
240
53a008a6
TT		 2412019-11-28 Tom Tromey <tom@tromey.com>
242
243 * value.c (creal_internal_fn): Fix comment.
244
bab05c83
TT		 2452019-11-28 Tom Tromey <tom@tromey.com>
246
247 * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count,
248 flag_bound_evaluated>: Now unsigned.
249
2522f049
TT		 2502019-11-28 Tom Tromey <tom@tromey.com>
251
252 * guile/guile-internal.h (vlscm_scm_from_value_unsafe): Don't
253 declare.
254
38b49e22
MS		 2552019-11-28 Mihails Strasuns <mihails.strasuns@intel.com>
256
257 * jit.c (jit_bfd_try_read_symtab): Fix printed function name in the
258 debug output.
259 * jit.c (jit_unregister_code): Add debug print to match
260 `jit_register_code`.
261
35125921
CB		 2622019-11-27 Christian Biesinger <cbiesinger@google.com>
263
264 * NEWS: Mention the new multithreaded symbol loading.
265
62e77f56
CB		 2662019-11-27 Christian Biesinger <cbiesinger@google.com>
267
268 * maint.c (n_worker_threads): Default to 0.
269 (worker_threads_disabled): New function.
270 * maint.h (worker_threads_disabled): New function.
271 * minsyms.c (minimal_symbol_reader::record_full): Call symbol_set_names
272 here if worker_threads_disabled () is true.
273 (minimal_symbol_reader::install): Skip all threading if
274 worker_threads_disabled () is true.
275
f29d7f6b
CB		 2762019-11-27 Christian Biesinger <cbiesinger@google.com>
277
278 * minsyms.c (add_minsym_to_hash_table): Use a previously computed
279 hash code if possible.
280 (add_minsym_to_demangled_hash_table): Likewise.
281 (minimal_symbol_reader::install): Compute the hash codes for msymbol
282 on the background thread.
283 * symtab.h (struct minimal_symbol) <hash_value, demangled_hash_value>:
284 Add these fields.
285
e76b2246
CB		 2862019-11-27 Christian Biesinger <cbiesinger@google.com>
287
288 * minsyms.c (minimal_symbol_reader::install): Also compute the hash
289 of the mangled name on the background thread.
290 * symtab.c (symbol_set_names): Allow passing in the hash of the
291 linkage_name.
292 * symtab.h (symbol_set_names): Likewise.
293
8d9a2568
KB		 2942019-11-27 Kevin Buettner <kevinb@redhat.com>
295
296 * dwarf2read.c (inherit_abstract_dies): Ensure that delayed
297 physnames are computed for inherited DIEs.
298
fad03f6e
TT		 2992019-11-27 Tom Tromey <tromey@adacore.com>
300
301 * dwarf2read.h (struct dwarf2_per_objfile): Remove unnecessary
302 backslashes.
303 * cp-support.c: Remove unnecessary backslashes.
304
43678b0a
CB		 3052019-11-27 Christian Biesinger <cbiesinger@google.com>
306
307 * ada-exp.y (write_ambiguous_var): Replace SYMBOL_SET_LINKAGE_NAME
308 with sym->set_linkage_name.
309 * coffread.c (coff_read_enum_type): Likewise.
310 * mdebugread.c (parse_symbol): Likewise.
311 * stabsread.c (patch_block_stabs): Likewise.
312 (define_symbol): Likewise.
313 (read_enum_type): Likewise.
314 (common_block_end): Likewise.
315 * symtab.h (struct general_symbol_info) <set_linkage_name>: New
316 function.
317 (SYMBOL_SET_LINKAGE_NAME): Remove.
318 * xcoffread.c (process_xcoff_symbol): Replace SYMBOL_SET_LINKAGE_NAME
319 with sym->set_linkage_name.
320
db5960b4
AB		 3212019-11-27 Andrew Burgess <andrew.burgess@embecosm.com>
322
323 * mi/mi-cmds.c (mi_cmds): Add 'symbol-info-modules' entry.
324 * mi/mi-cmds.h (mi_cmd_symbol_info_modules): Declare.
325 * mi/mi-symbol-cmds.c (mi_cmd_symbol_info_modules): New function.
326 * NEWS: Mention new MI command.
327
7dc42066
AB		 3282019-11-27 Andrew Burgess <andrew.burgess@embecosm.com>
329
330 * mi/mi-cmds.c (mi_cmds): Add '-symbol-info-functions',
331 '-symbol-info-types', and '-symbol-info-variables'.
332 * mi/mi-cmds.h (mi_cmd_symbol_info_functions): Declare.
333 (mi_cmd_symbol_info_types): Declare.
334 (mi_cmd_symbol_info_variables): Declare.
335 * mi/mi-symbol-cmds.c: Add 'source.h' and 'mi-getopt.h' includes.
336 (output_debug_symbol): New function.
337 (output_nondebug_symbol): New function.
338 (mi_symbol_info): New function.
339 (mi_info_functions_or_variables): New function.
340 (mi_cmd_symbol_info_functions): New function.
341 (mi_cmd_symbol_info_types): New function.
342 (mi_cmd_symbol_info_variables): New function.
343 * NEWS: Mention new commands.
344
5f512a7d
AB		 3452019-11-27 Andrew Burgess <andrew.burgess@embecosm.com>
346
347 * symtab.c (symbol_to_info_string): New function, most content
348 moved from print_symbol_info, but updated to return a std::string.
349 (print_symbol_info): Update to use symbol_to_info_string and print
350 returned string.
351 * symtab.h (symbol_to_info_string): Declare new function.
352
470c0b1c
AB		 3532019-11-27 Andrew Burgess <andrew.burgess@embecosm.com>
354
355 * python/python.c (gdbpy_rbreak): Convert to using
356 global_symbol_searcher.
357 * symtab.c (file_matches): Convert return type to bool, change
358 file list to std::vector, update header comment.
359 (search_symbols): Rename to...
360 (global_symbol_searcher::search): ...this and update now its
361 a member function of global_symbol_searcher. Take account of the
362 changes to file_matches.
363 (symtab_symbol_info): Convert to using global_symbol_searcher.
364 (rbreak_command): Likewise.
365 (search_module_symbols): Likewise.
366 * symtab.h (enum symbol_search): Update comment.
367 (search_symbols): Remove declaration.
368 (class global_symbol_searcher): New class.
369
57357d9d
TT		 3702019-11-26 Tom Tromey <tromey@adacore.com>
371
372 * cp-support.c (_initialize_cp_support): Conditionally initialize
373 gdb_demangle_attempt_core_dump.
374
3ea16160
TT		 3752019-11-26 Tom Tromey <tom@tromey.com>
376
377 * python/py-function.c (fnpy_init): Update.
378 * value.h (add_internal_function): Adjust declaration.
379 * value.c (function_destroyer): Remove.
380 (do_add_internal_function): Don't set destroyer or copy name.
381 (add_internal_function): Take unique_xmalloc_ptr<char> for name.
382 Set name_allocated.
383 * python/py-cmd.c (cmdpy_destroyer): Don't free "name".
384 (cmdpy_init): Set name_allocated.
385 * cli/cli-decode.h (struct cmd_list_element) <name_allocated>: New
386 member.
387 (~cmd_list_element): Free "name" if needed.
388
1a6d41c6
TT		 3892019-11-26 Tom Tromey <tom@tromey.com>
390
391 * value.h (add_internal_function): Add new overload. Move
392 documentation from value.h.
393 * value.c (do_add_internal_function): New function.
394 (add_internal_function): Use it. Add new overload.
395 (function_destroyer): Don't free doc.
396 * python/py-function.c (fnpy_init): Update.
397
8318f3c3
TT		 3982019-11-26 Tom Tromey <tom@tromey.com>
399
400 * python/py-cmd.c (cmdpy_destroyer): Don't free "doc".
401 (cmdpy_init): Set "doc_allocated".
402
4da8c3a8
TT		 4032019-11-26 Tom Tromey <tom@tromey.com>
404
405 * gdbsupport/thread-pool.c (thread_pool::set_thread_count): Set
406 name of worker thread.
407 * gdbsupport/common.m4 (GDB_AC_COMMON): Check for
408 pthread_setname_np.
409 * configure, config.in: Rebuild.
410
971db5e2
TT		 4112019-11-26 Tom Tromey <tom@tromey.com>
412
413 * python/python.c (class gdbpy_gil): New.
414 (struct gdbpy_event): Add constructor, destructor, operator().
415 (gdbpy_post_event): Use run_on_main_thread.
416 (gdbpy_initialize_events): Remove.
417 (do_start_initialization): Update.
418
22138db6
TT		 4192019-11-26 Tom Tromey <tom@tromey.com>
420
421 * NEWS: Add entry.
422 * maint.c (_initialize_maint_cmds): Add "worker-threads" maint
423 commands. Call update_thread_pool_size.
424 (update_thread_pool_size, maintenance_set_worker_threads): New
425 functions.
426 (n_worker_threads): New global.
427
d55c9a68
TT		 4282019-11-26 Christian Biesinger <cbiesinger@google.com>
429 Tom Tromey <tom@tromey.com>
430
431 * minsyms.c (minimal_symbol_reader::install): Use
432 parallel_for_each.
433 * gdbsupport/parallel-for.h: New file.
434 * Makefile.in (HFILES_NO_SRCDIR): Add gdbsupport/parallel-for.h.
435
a0b57563
CB		 4362019-11-26 Christian Biesinger <cbiesinger@google.com>
437 Tom Tromey <tom@tromey.com>
438
439 * gdbsupport/thread-pool.h: New file.
440 * gdbsupport/thread-pool.c: New file.
441 * Makefile.in (COMMON_SFILES): Add thread-pool.c.
442 (HFILES_NO_SRCDIR): Add thread-pool.h.
443
3b3978bc
TT		 4442019-11-26 Tom Tromey <tom@tromey.com>
445
446 * event-top.h (thread_local_segv_handler): Declare.
447 * event-top.c (thread_local_segv_handler): New global.
448 (install_handle_sigsegv, handle_sigsegv): New functions.
449 (async_init_signals): Install SIGSEGV handler.
450 * cp-support.c (gdb_demangle_jmp_buf): Change type. Now
451 thread-local.
452 (report_failed_demangle): New function.
453 (gdb_demangle): Make core_dump_allowed atomic. Remove signal
454 handler-setting code, instead use segv_handler. Run warning code
455 on main thread.
456
9411c49e
TT		 4572019-11-26 Tom Tromey <tom@tromey.com>
458
459 * run-on-main-thread.c: New file.
460 * run-on-main-thread.h: New file.
461 * unittests/main-thread-selftests.c: New file.
462 * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
463 main-thread-selftests.c.
464 (HFILES_NO_SRCDIR): Add run-on-main-thread.h.
465 (COMMON_SFILES): Add run-on-main-thread.c.
466
c3efb965
TT		 4672019-11-26 Tom Tromey <tom@tromey.com>
468
469 * main.c (setup_alternate_signal_stack): Remove.
470 (captured_main_1): Use gdb::alternate_signal_stack.
471 * gdbsupport/alt-stack.h: New file.
472
21987b9c
TT		 4732019-11-26 Tom Tromey <tom@tromey.com>
474
475 * gdbsupport/signals-state-save-restore.c (original_signal_mask):
476 Remove comment.
477 (save_original_signals_state, restore_original_signals_state): Use
478 gdb_sigmask.
479 * linux-nat.c (block_child_signals, restore_child_signals_mask)
480 (_initialize_linux_nat): Use gdb_sigmask.
481 * guile/guile.c (_initialize_guile): Use block_signals.
482 * Makefile.in (HFILES_NO_SRCDIR): Add gdb-sigmask.h.
483 * gdbsupport/gdb-sigmask.h: New file.
484 * event-top.c (async_sigtstp_handler): Use gdb_sigmask.
485 * cp-support.c (gdb_demangle): Use gdb_sigmask.
486 * gdbsupport/common.m4 (GDB_AC_COMMON): Check for
487 pthread_sigmask.
488 * configure, config.in: Rebuild.
489 * gdbsupport/block-signals.h: New file.
490
5e030278
TT		 4912019-11-26 Tom Tromey <tom@tromey.com>
492
493 * acinclude.m4: Include ax_pthread.m4.
494 * Makefile.in (PTHREAD_CFLAGS, PTHREAD_LIBS): New variables.
495 (INTERNAL_CFLAGS_BASE): Use PTHREAD_CFLAGS.
496 (CLIBS): Use PTHREAD_LIBS.
497 (aclocal_m4_deps): Add ax_pthread.m4.
498 * config.in, configure: Rebuild.
499 * gdbsupport/common.m4 (GDB_AC_COMMON): Check for std::thread.
500
5a79c107
TT		 5012019-11-26 Tom Tromey <tom@tromey.com>
502
503 * symtab.h (struct minimal_symbol) <name_set>: New member.
504 * minsyms.c (minimal_symbol_reader::record_full): Copy name.
505 Don't call symbol_set_names.
506 (minimal_symbol_reader::install): Call symbol_set_names.
507
aa369509
PW		 5082019-11-26 Philippe Waroquiers <philippe.waroquiers@skynet.be>
509
510 * python/python.c (gdbpy_enter::~gdbpy_enter): Release GIL after
511 restore_active_ext_lang, as GIL is needed for (indirectly)
512 called PyOS_InterruptOccurred.
513
cadc9cb8
SM		 5142019-11-26 Simon Marchi <simon.marchi@efficios.com>
515
516 * sparc-nat.c (sparc_xfer_wcookie): Sync declaration with
517 definition.
518
d04afd58
SM		 5192019-11-26 Simon Marchi <simon.marchi@efficios.com>
520
521 * remote-sim.c (simulator_command): Make static, remove
522 declaration.
523
dd694d77
SM		 5242019-11-26 Simon Marchi <simon.marchi@efficios.com>
525
526 * unittests/array-view-selftests.c (check_ptr_size_ctor2): Make
527 static.
528 * unittests/basic_string_view/capacity/1.cc (test01): Likewise.
529 * unittests/basic_string_view/cons/char/1.cc (test01): Likewise.
530 (main): Likewise.
531 * unittests/basic_string_view/cons/char/2.cc (test03): Likewise.
532 (main): Likewise.
533 * unittests/basic_string_view/cons/char/3.cc (test05): Likewise.
534 (main): Likewise.
535 * unittests/basic_string_view/element_access/char/1.cc (test01):
536 Likewise.
537 (main): Likewise.
538 * unittests/basic_string_view/element_access/char/empty.cc (main):
539 Likewise.
540 * unittests/basic_string_view/element_access/char/front_back.cc
541 (test01): Likewise.
542 (main): Likewise.
543 * unittests/basic_string_view/inserters/char/2.cc (test05):
544 Likewise.
545 (main): Likewise.
546 * unittests/basic_string_view/modifiers/remove_prefix/char/1.cc
547 (test01): Likewise.
548 (main): Likewise.
549 * unittests/basic_string_view/modifiers/remove_suffix/char/1.cc
550 (test01): Likewise.
551 (main): Likewise.
552 * unittests/basic_string_view/modifiers/swap/char/1.cc (test01):
553 Likewise.
554 * unittests/basic_string_view/operations/compare/char/1.cc
555 (test01): Likewise.
556 (main): Likewise.
557 * unittests/basic_string_view/operations/compare/char/13650.cc
558 (test01): Likewise.
559 * unittests/basic_string_view/operations/copy/char/1.cc (test01):
560 Likewise.
561 (main): Likewise.
562 * unittests/basic_string_view/operations/data/char/1.cc (test01):
563 Likewise.
564 (main): Likewise.
565 * unittests/basic_string_view/operations/find/char/1.cc (test01):
566 Likewise.
567 (main): Likewise.
568 * unittests/basic_string_view/operations/find/char/2.cc (test02):
569 Likewise.
570 (main): Likewise.
571 * unittests/basic_string_view/operations/find/char/3.cc (test03):
572 Likewise.
573 (main): Likewise.
574 * unittests/basic_string_view/operations/find/char/4.cc (main):
575 Likewise.
576 * unittests/basic_string_view/operations/rfind/char/1.cc (test01):
577 Likewise.
578 (main): Likewise.
579 * unittests/basic_string_view/operations/rfind/char/2.cc (test02):
580 Likewise.
581 (main): Likewise.
582 * unittests/basic_string_view/operations/rfind/char/3.cc (test03):
583 Likewise.
584 (main): Likewise.
585 * unittests/basic_string_view/operations/substr/char/1.cc
586 (test01): Likewise.
587 (main): Likewise.
588 * unittests/basic_string_view/operators/char/2.cc (main):
589 Likewise.
590 * unittests/optional/assignment/1.cc (test): Likewise.
591 * unittests/optional/assignment/2.cc (test): Likewise.
592 * unittests/optional/assignment/3.cc (test): Likewise.
593 * unittests/optional/assignment/4.cc (test): Likewise.
594 * unittests/optional/assignment/5.cc (test): Likewise.
595 * unittests/optional/assignment/6.cc (test): Likewise.
596 * unittests/optional/assignment/7.cc (test): Likewise.
597 * unittests/optional/cons/copy.cc (test): Likewise.
598 * unittests/optional/cons/default.cc (test): Likewise.
599 * unittests/optional/cons/move.cc (test): Likewise.
600 * unittests/optional/cons/value.cc (test): Likewise.
601 * unittests/optional/in_place.cc (test): Likewise.
602 * unittests/optional/observers/1.cc (test): Likewise.
603 * unittests/optional/observers/2.cc (test): Likewise.
604
3b5c1d49
SM		 6052019-11-26 Simon Marchi <simon.marchi@efficios.com>
606
607 * tui-win.h (tui_set_var_cmd): Remove.
608 * tui-win.c (tui_set_var_cmd): Make static.
609
adce99fe
SM		 6102019-11-26 Simon Marchi <simon.marchi@efficios.com>
611
612 * breakpoint.h (hbreak_command_wrapper, thbreak_command_wrapper,
613 rbreak_command_wrapper): Remove.
614 * symtab.c (rbreak_command_wrapper): Remove.
615
fe3adccf
SM		 6162019-11-26 Simon Marchi <simon.marchi@efficios.com>
617
618 * inferior.h (info_terminal_command): Remove declaration.
619 * inflow.c (info_terminal_command): Make static.
620
b926335f
SM		 6212019-11-26 Simon Marchi <simon.marchi@efficios.com>
622
623 * inferior.c (exit_inferior_silent): Remove.
624
b62f6f54
SM		 6252019-11-26 Simon Marchi <simon.marchi@efficios.com>
626
627 * dictionary.c (dict_empty, mdict_empty): Remove.
628 * dictionary.c (mdict_empty): Remove.
629
cb8c24b6
SM		 6302019-11-26 Simon Marchi <simon.marchi@efficios.com>
631
632 * arc-tdep.c (arc_insn_get_memory_base_reg): Make static.
633 (arc_insn_get_memory_offset): Likewise.
634 (arc_insn_dump): Likewise.
635 * cp-support.c (test_cp_symbol_name_matches): Likewise.
636 * csky-linux-tdep.c (csky_supply_fregset): Likewise.
637 * dictionary.c (dict_iterator_next): Likewise.
638 (dict_iter_match_first): Likewise.
639 (dict_iter_match_next): Likewise.
640 * f-lang.c (evaluate_subexp_f): Likewise.
641 * hppa-tdep.c (hppa_read_pc): Likewise.
642 * i386-tdep.c (i386_floatformat_for_type): Likewise.
643 * parse.c (write_exp_elt_msym): Likewise.
644 * ppc-linux-tdep.c (ppc_floatformat_for_type): Likewise.
645 * remote.c (remote_packet_size): Likewise.
646 (remote_notif_stop_parse): Likewise.
647 * rs6000-aix-tdep.c (aix_sighandle_frame_sniffer): Likewise.
648 * s12z-tdep.c (s12z_disassemble_info): Likewise.
649 * source.c (prepare_path_for_appending): Likewise.
650 * sparc64-linux-tdep.c
651 (sparc64_linux_handle_segmentation_fault); Likewise.
652 * stack.c (frame_selection_by_function_completer): Likewise.
653
781597ff
SM		 6542019-11-26 Simon Marchi <simon.marchi@efficios.com>
655
656 * completer.c (set_gdb_completion_word_break_characters):
657 Remove.
658
23baa4cc
SM		 6592019-11-26 Simon Marchi <simon.marchi@efficios.com>
660
661 * dwarf-index-write.c: Include dwarf-index-write.h.
662 * mi/mi-interp.c: Include mi/mi-interp.h.
663
23767560
SM		 6642019-11-26 Simon Marchi <simon.marchi@efficios.com>
665
666 * aarch32-tdep.c: Include aarch32-tdep.h.
667 * aarch32-tdep.h: Forward-declare struct target_desc.
668
6d91ce9a
CB		 6692019-11-26 Christian Biesinger <cbiesinger@google.com>
670
671 * linux-nat.c (detach_one_lwp): Call safe_strerror instead of
672 strerror.
673 * nto-procfs.c (nto_procfs_target::create_inferior): Likewise.
674 * windows-nat.c (windows_nat_target::create_inferior): Likewise.
675
3cf2f237
TV		 6762019-11-25 Tom de Vries <tdevries@suse.de>
677
678 * contrib/words.sh: Add -c option.
679
5b89c67a
CB		 6802019-11-25 Christian Biesinger <cbiesinger@google.com>
681
682 * solib.c (solib_find_1): Change int to bool.
683 (exec_file_find): Change int to bool.
684 (solib_find): Change int to bool.
685 (solib_read_symbols): Change int to bool.
686 (solib_used): Change int to bool.
687 (solib_add): Change int to bool.
688 (info_sharedlibrary_command): Change int to bool.
689 (solib_contains_address_p): Change int to bool.
690 (solib_keep_data_in_core): Change int to bool.
691 (in_solib_dynsym_resolve_code): Change int to bool.
692 (reload_shared_libraries_1): Change int to bool.
693 (gdb_sysroot_changed): Change int to bool.
694 * solib.h (solib_read_symbols): Change int to bool.
695 (solib_contains_address_p): Change int to bool.
696 (solib_keep_data_in_core): Change int to bool.
697 (in_solib_dynsym_resolve_code): Change int to bool.
698 (libpthread_name_p): Change int to bool.
699
6cc8564b
LM		 7002019-11-25 Luis Machado <luis.machado@linaro.org>
701
702 * NEWS (New Commands): Mention "set debug remote-packet-max-chars".
703 * remote.c (REMOTE_DEBUG_MAX_CHAR): Remove.
704 (remote_packet_max_chars): New static global.
705 (show_remote_packet_max_chars): New function.
706 (remote_target::putpkt_binary): Adjust to use new
707 remote_packet_max_chars option.
708 (remote_target::getpkt_or_notif_sane_1): Likewise.
709 (_initialize_remote): Register new remote-packet-max-chars option.
710
a7cdaa91
SM		 7112019-11-24 Simon Marchi <simon.marchi@efficios.com>
712
713 * m68k-linux-nat.c: Include gdbarch.h.
714
26abc753
TT		 7152019-11-24 Tom Tromey <tom@tromey.com>
716
717 * symfile.c (read_symbols): Update.
718 * psymtab.c (require_partial_symbols): Change type of "verbose" to
719 bool.
720 (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
721 (psym_lookup_symbol, psym_find_last_source_symtab)
722 (psym_forget_cached_source_info, psym_print_stats)
723 (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
724 (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
725 (psym_map_matching_symbols, psym_expand_symtabs_matching)
726 (psym_find_compunit_symtab_by_address)
727 (maintenance_print_psymbols, maintenance_info_psymtabs)
728 (maintenance_check_psymtabs): Update.
729 * psymtab.h (require_partial_symbols): Change type of "verbose" to
730 bool.
731
012fc909
TT		 7322019-11-22 Tom Tromey <tom@tromey.com>
733
734 * observable.h: Update comments.
735
c83d8d32
TT		 7362019-11-22 Tom Tromey <tromey@adacore.com>
737
738 * ada-tasks.c (ada_task_is_alive): Make parameter const.
739 (print_ada_task_info): Don't try to fetch thread id if task is not
740 alive.
741
987012b8
CB		 7422019-11-22 Christian Biesinger <cbiesinger@google.com>
743
744 * ada-exp.y: Update.
745 * ada-lang.c (sort_choices): Update.
746 (ada_print_symbol_signature): Update.
747 (resolve_subexp): Update.
748 (ada_parse_renaming): Update.
749 (ada_read_renaming_var_value): Update.
750 (lesseq_defined_than): Update.
751 (remove_extra_symbols): Update.
752 (remove_irrelevant_renamings): Update.
753 (ada_add_block_symbols): Update.
754 (ada_collect_symbol_completion_matches): Update.
755 (ada_is_renaming_symbol): Update.
756 (aggregate_assign_from_choices): Update.
757 (ada_evaluate_subexp): Update.
758 (ada_has_this_exception_support): Update.
759 (ada_is_non_standard_exception_sym): Update.
760 (ada_add_exceptions_from_frame): Update.
761 (ada_add_global_exceptions): Update.
762 (ada_print_subexp): Update.
763 * ax-gdb.c (gen_var_ref): Update.
764 (gen_maybe_namespace_elt): Update.
765 (gen_expr_for_cast): Update.
766 (gen_expr): Update.
767 * block.h: Update.
768 * blockframe.c (find_pc_partial_function): Update.
769 * breakpoint.c (print_breakpoint_location): Update.
770 (update_static_tracepoint): Update.
771 * btrace.c (ftrace_print_function_name): Update.
772 (ftrace_function_switched): Update.
773 * buildsym.c (find_symbol_in_list): Update.
774 * c-exp.y: Update.
775 * c-typeprint.c (c_print_typedef): Update.
776 (c_type_print_template_args): Update.
777 * cli/cli-cmds.c (edit_command): Update.
778 (list_command): Update.
779 (print_sal_location): Update.
780 * coffread.c (patch_opaque_types): Update.
781 (process_coff_symbol): Update.
782 (coff_read_enum_type): Update.
783 * compile/compile-c-symbols.c (c_symbol_substitution_name): Update.
784 (convert_one_symbol): Update.
785 (hash_symname): Update.
786 (eq_symname): Update.
787 * compile/compile-cplus-symbols.c (convert_one_symbol): Update.
788 * compile/compile-cplus-types.c (debug_print_scope): Update.
789 * compile/compile-loc2c.c (do_compile_dwarf_expr_to_c): Update.
790 * compile/compile-object-load.c (get_out_value_type): Update.
791 * cp-namespace.c (cp_scan_for_anonymous_namespaces): Update.
792 (search_symbol_list): Update.
793 (cp_lookup_symbol_imports_or_template): Update.
794 * cp-support.c (overload_list_add_symbol): Update.
795 * ctfread.c (psymtab_to_symtab): Update.
796 * dbxread.c (cp_set_block_scope): Update.
797 * dictionary.c (iter_match_first_hashed): Update.
798 (iter_match_next_hashed): Update.
799 (insert_symbol_hashed): Update.
800 (iter_match_next_linear): Update.
801 * dictionary.h: Update.
802 * dwarf2loc.c (func_get_frame_base_dwarf_block): Update.
803 (locexpr_describe_location_piece): Update.
804 (locexpr_describe_location_1): Update.
805 (locexpr_generate_c_location): Update.
806 (loclist_describe_location): Update.
807 (loclist_generate_c_location): Update.
808 * dwarf2read.c (dw2_debug_names_lookup_symbol): Update.
809 (read_func_scope): Update.
810 (process_enumeration_scope): Update.
811 (new_symbol): Update.
812 (dwarf2_const_value): Update.
813 (dwarf2_symbol_mark_computed): Update.
814 * eval.c (evaluate_funcall): Update.
815 (evaluate_subexp_standard): Update.
816 * expprint.c (print_subexp_standard): Update.
817 (dump_subexp_body_standard): Update.
818 * f-valprint.c (info_common_command_for_block): Update.
819 * findvar.c (get_hosting_frame): Update.
820 (default_read_var_value): Update.
821 * go-lang.c (go_symbol_package_name): Update.
822 * guile/scm-block.c (bkscm_print_block_smob): Update.
823 * guile/scm-symbol.c (syscm_print_symbol_smob): Update.
824 (gdbscm_symbol_name): Update.
825 (gdbscm_symbol_linkage_name): Update.
826 (gdbscm_symbol_print_name): Update.
827 * infcall.c (get_function_name): Update.
828 * infcmd.c (jump_command): Update.
829 (finish_command): Update.
830 * infrun.c (insert_exception_resume_breakpoint): Update.
831 * linespec.c (canonicalize_linespec): Update.
832 (create_sals_line_offset): Update.
833 (convert_linespec_to_sals): Update.
834 (complete_label): Update.
835 (find_label_symbols_in_block): Update.
836 * m2-typeprint.c (m2_print_typedef): Update.
837 * mdebugread.c (mdebug_reg_to_regnum): Update.
838 (parse_symbol): Update.
839 (mylookup_symbol): Update.
840 * mi/mi-cmd-stack.c (list_arg_or_local): Update.
841 (list_args_or_locals): Update.
842 * objc-lang.c (compare_selectors): Update.
843 (info_selectors_command): Update.
844 (compare_classes): Update.
845 (info_classes_command): Update.
846 (find_imps): Update.
847 * p-typeprint.c (pascal_print_typedef): Update.
848 * printcmd.c (build_address_symbolic): Update.
849 (info_address_command): Update.
850 (print_variable_and_value): Update.
851 * python/py-framefilter.c (extract_sym): Update.
852 (py_print_single_arg): Update.
853 * python/py-symbol.c (sympy_str): Update.
854 (sympy_get_name): Update.
855 (sympy_get_linkage_name): Update.
856 * python/python.c (gdbpy_rbreak): Update.
857 * record-btrace.c (btrace_get_bfun_name): Update.
858 (btrace_call_history): Update.
859 * rust-lang.c (rust_print_typedef): Update.
860 * solib-frv.c (frv_fdpic_find_canonical_descriptor): Update.
861 * stabsread.c (stab_reg_to_regnum): Update.
862 (define_symbol): Update.
863 (read_enum_type): Update.
864 (common_block_end): Update.
865 (cleanup_undefined_types_1): Update.
866 (scan_file_globals): Update.
867 * stack.c (print_frame_arg): Update.
868 (print_frame_args): Update.
869 (find_frame_funname): Update.
870 (info_frame_command_core): Update.
871 (iterate_over_block_locals): Update.
872 (print_block_frame_labels): Update.
873 (do_print_variable_and_value): Update.
874 (iterate_over_block_arg_vars): Update.
875 (return_command): Update.
876 * symmisc.c (dump_symtab_1): Update.
877 (print_symbol): Update.
878 * symtab.c (eq_symbol_entry): Update.
879 (symbol_cache_dump): Update.
880 (lookup_language_this): Update.
881 (find_pc_sect_line): Update.
882 (skip_prologue_sal): Update.
883 (symbol_search::compare_search_syms): Update.
884 (treg_matches_sym_type_name): Update.
885 (search_symbols): Update.
886 (print_symbol_info): Update.
887 (rbreak_command): Update.
888 (completion_list_add_symbol): Update.
889 (find_gnu_ifunc): Update.
890 (get_symbol_address): Update.
891 (search_module_symbols): Update.
892 (info_module_subcommand): Update.
893 * symtab.h (SYMBOL_NATURAL_NAME): Remove.
894 (SYMBOL_LINKAGE_NAME): Remove.
895 (SYMBOL_DEMANGLED_NAME): Remove.
896 (SYMBOL_PRINT_NAME): Remove.
897 (SYMBOL_SEARCH_NAME): Remove.
898 * tracepoint.c (set_traceframe_context): Update.
899 (validate_actionline): Update.
900 (collection_list::collect_symbol): Update.
901 (encode_actions_1): Update.
902 (info_scope_command): Update.
903 (print_one_static_tracepoint_marker): Update.
904 * typeprint.c (typedef_hash_table::add_template_parameters): Update.
905 * valops.c (address_of_variable): Update.
906 (find_overload_match): Update.
907 (find_oload_champ): Update.
908
c9d95fa3
CB		 9092019-11-22 Christian Biesinger <cbiesinger@google.com>
910
911 * ada-lang.c (ada_lookup_simple_minsym): Update.
912 (ada_collect_symbol_completion_matches): Update.
913 * ada-tasks.c (read_atcb): Update.
914 * amd64-windows-tdep.c (amd64_skip_main_prologue): Update.
915 (amd64_windows_skip_trampoline_code): Update.
916 * arm-tdep.c (skip_prologue_function): Update.
917 (arm_skip_stack_protector): Update.
918 * arm-wince-tdep.c (arm_pe_skip_trampoline_code): Update.
919 (arm_wince_skip_main_prologue): Update.
920 * ax-gdb.c (gen_expr): Update.
921 * block.c (call_site_for_pc): Update.
922 * blockframe.c (find_pc_partial_function): Update.
923 * breakpoint.c (set_breakpoint_location_function): Update.
924 * btrace.c (ftrace_print_function_name): Update.
925 (ftrace_function_switched): Update.
926 * c-valprint.c (print_unpacked_pointer): Update.
927 * coffread.c (coff_symfile_read): Update.
928 * compile/compile-c-symbols.c (convert_symbol_bmsym): Update.
929 * compile/compile-cplus-symbols.c (convert_symbol_bmsym): Update.
930 * dwarf-index-write.c (write_psymbols): Update.
931 * dwarf2loc.c (call_site_to_target_addr): Update.
932 (func_verify_no_selftailcall): Update.
933 (tailcall_dump): Update.
934 (call_site_find_chain_1): Update.
935 (dwarf_expr_reg_to_entry_parameter): Update.
936 * elfread.c (elf_gnu_ifunc_record_cache): Update.
937 * eval.c (evaluate_funcall): Update.
938 (evaluate_subexp_standard): Update.
939 (evaluate_subexp_for_sizeof): Update.
940 * expprint.c (print_subexp_standard): Update.
941 (dump_subexp_body_standard): Update.
942 * frame.c (get_prev_frame_always_1): Update.
943 * frv-tdep.c (frv_skip_main_prologue): Update.
944 * gnu-v2-abi.c (gnuv2_value_rtti_type): Update.
945 * gnu-v3-abi.c (gnuv3_rtti_type): Update.
946 (gnuv3_get_typename_from_type_info): Update.
947 (gnuv3_skip_trampoline): Update.
948 * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
949 * i386-tdep.c (i386_skip_main_prologue): Update.
950 (i386_pe_skip_trampoline_code): Update.
951 * ia64-tdep.c (ia64_convert_from_func_ptr_addr): Update.
952 * infcall.c (get_function_name): Update.
953 * linespec.c (minsym_found): Update.
954 * linux-fork.c (info_checkpoints_command): Update.
955 * m32c-tdep.c (m32c_m16c_address_to_pointer): Update.
956 (m32c_m16c_pointer_to_address): Update.
957 * maint.c (maintenance_translate_address): Update.
958 * minsyms.c (add_minsym_to_hash_table): Update.
959 (add_minsym_to_demangled_hash_table): Update.
960 (lookup_minimal_symbol_mangled): Update.
961 (lookup_minimal_symbol_demangled): Update.
962 (lookup_minimal_symbol_linkage): Update.
963 (lookup_minimal_symbol_text): Update.
964 (lookup_minimal_symbol_by_pc_name): Update.
965 (minimal_symbol_is_less_than): Update.
966 (compact_minimal_symbols): Update.
967 (build_minimal_symbol_hash_tables): Update.
968 (find_solib_trampoline_target): Update.
969 * mips-tdep.c (mips_stub_frame_sniffer): Update.
970 (mips_skip_pic_trampoline_code): Update.
971 * msp430-tdep.c (msp430_skip_trampoline_code): Update.
972 * objc-lang.c (info_selectors_command): Update.
973 (info_classes_command): Update.
974 (find_methods): Update.
975 (find_imps): Update.
976 * p-valprint.c (pascal_val_print): Update.
977 * ppc-linux-tdep.c (powerpc_linux_in_dynsym_resolve_code): Update.
978 * ppc-sysv-tdep.c (convert_code_addr_to_desc_addr): Update.
979 * printcmd.c (build_address_symbolic): Update.
980 (info_symbol_command): Update.
981 * psymtab.c (psymbol_name_matches): Update.
982 (match_partial_symbol): Update.
983 (lookup_partial_symbol): Update.
984 (print_partial_symbols): Update.
985 (sort_pst_symbols): Update.
986 (maintenance_check_psymtabs): Update.
987 * python/py-framefilter.c (py_print_frame): Update.
988 * python/python.c (gdbpy_rbreak): Update.
989 * record-btrace.c (btrace_get_bfun_name): Update.
990 (btrace_call_history): Update.
991 * rs6000-tdep.c (rs6000_skip_main_prologue): Update.
992 (rs6000_skip_trampoline_code): Update.
993 * sol-thread.c (info_cb): Update.
994 * stabsread.c (scan_file_globals): Update.
995 * stack.c (find_frame_funname): Update.
996 (info_frame_command_core): Update.
997 * symmisc.c (dump_msymbols): Update.
998 * symtab.c (symbol_natural_name): Rename to..,
999 (general_symbol_info::natural_name): ...this.
1000 (symbol_demangled_name): Rename to...
1001 (general_symbol_info::demangled_name): ...this.
1002 (symbol_search_name): Rename to...
1003 (general_symbol_info::search_name): ...this.
1004 (symbol_matches_search_name): Update.
1005 (find_pc_sect_line): Update.
1006 (skip_prologue_sal): Update.
1007 (search_symbols): Update.
1008 (print_msymbol_info): Update.
1009 (rbreak_command): Update.
1010 (completion_list_add_msymbol): Update.
1011 (completion_list_objc_symbol): Update.
1012 (get_msymbol_address): Update.
1013 * symtab.h (struct general_symbol_info): Add member functions
1014 natural_name (), linkage_name (), print_name (), demangled_name (),
1015 and search_name ().
1016 (SYMBOL_NATURAL_NAME): Update.
1017 (symbol_natural_name): Move to a member function on general_symbol_info.
1018 (SYMBOL_DEMANGLED_NAME): Update.
1019 (symbol_demangled_name): Move to a member function on
1020 general_symbol_info.
1021 (SYMBOL_SEARCH_NAME): Update.
1022 (symbol_search_name): Move to a member function on general_symbol_info.
1023 (MSYMBOL_NATURAL_NAME): Remove.
1024 (MSYMBOL_LINKAGE_NAME): Remove.
1025 (MSYMBOL_PRINT_NAME): Remove.
1026 (MSYMBOL_DEMANGLED_NAME): Remove.
1027 (MSYMBOL_SEARCH_NAME): Remove.
1028 * x86-tdep.c (x86_in_indirect_branch_thunk): Update.
1029
f8bab2d6
CB		 10302019-11-22 Christian Biesinger <cbiesinger@google.com>
1031
1032 * symtab.c (create_demangled_names_hash): Use per_bfd->
1033 minimal_symbol_count for computing the initial size, if greater
1034 than our default size.
1035
85e7588d
TV		 10362019-11-22 Tom de Vries <tdevries@suse.de>
1037
1038 * contrib/words.sh: Improve words extraction.
1039
f6180073
TV		 10402019-11-22 Tom de Vries <tdevries@suse.de>
1041
1042 * contrib/words.sh: Combine sed invocations.
1043
f10ffa41
CB		 10442019-11-21 Christian Biesinger <cbiesinger@google.com>
1045
1046 * Makefile.in: Update.
1047 * demangle.c: Rename to...
1048 * gdb-demangle.c: ..this.
1049 (is_cplus_marker): Change return type to bool.
1050 (_initialize_demangler): Rename to...
1051 (_initialize_gdb_demangle): ...this.
1052 * gdb-demangle.h (is_cplus_marker): Change return type to bool.
1053 * symtab.h (demangle): Remove declaration; instead include
1054 gdb-demangle.h.
1055
6ba18521
TT		 10562019-11-21 Tom Tromey <tromey@adacore.com>
1057
1058 * gdbsupport/format.c (format_pieces): Parse %I64d.
1059 * unittests/format_pieces-selftests.c (test_windows_formats): New
1060 function.
1061 (run_tests): Call it.
1062
34877895
PJ		 10632019-11-21 Peeter Joot <peeter.joot@lzlabs.com>
1064
1065 Byte reverse display of variables with DW_END_big, DW_END_little
1066 (DW_AT_endianity) dwarf attributes if different than the native
1067 byte order.
1068 * ada-lang.c (ada_value_binop):
1069 Use type_byte_order instead of gdbarch_byte_order.
1070 * ada-valprint.c (printstr):
1071 (ada_val_print_string):
1072 * ada-lang.c (value_pointer):
1073 (ada_value_binop):
1074 Use type_byte_order instead of gdbarch_byte_order.
1075 * c-lang.c (c_get_string):
1076 Use type_byte_order instead of gdbarch_byte_order.
1077 * c-valprint.c (c_val_print_array):
1078 Use type_byte_order instead of gdbarch_byte_order.
1079 * cp-valprint.c (cp_print_class_member):
1080 Use type_byte_order instead of gdbarch_byte_order.
1081 * dwarf2loc.c (rw_pieced_value):
1082 Use type_byte_order instead of gdbarch_byte_order.
1083 * dwarf2read.c (read_base_type): Handle DW_END_big,
1084 DW_END_little
1085 * f-lang.c (f_get_encoding):
1086 Use type_byte_order instead of gdbarch_byte_order.
1087 * findvar.c (default_read_var_value):
1088 Use type_byte_order instead of gdbarch_byte_order.
1089 * gdbtypes.c (check_types_equal):
1090 Require matching TYPE_ENDIANITY_NOT_DEFAULT if set.
1091 (recursive_dump_type): Print TYPE_ENDIANITY_BIG,
1092 and TYPE_ENDIANITY_LITTLE if set.
1093 (type_byte_order): new function.
1094 * gdbtypes.h (TYPE_ENDIANITY_NOT_DEFAULT): New macro.
1095 (struct main_type) <flag_endianity_not_default>:
1096 New field.
1097 (type_byte_order): New function.
1098 * infcmd.c (default_print_one_register_info):
1099 Use type_byte_order instead of gdbarch_byte_order.
1100 * p-lang.c (pascal_printstr):
1101 Use type_byte_order instead of gdbarch_byte_order.
1102 * p-valprint.c (pascal_val_print):
1103 Use type_byte_order instead of gdbarch_byte_order.
1104 * printcmd.c (print_scalar_formatted):
1105 Use type_byte_order instead of gdbarch_byte_order.
1106 * solib-darwin.c (darwin_current_sos):
1107 Use type_byte_order instead of gdbarch_byte_order.
1108 * solib-svr4.c (solib_svr4_r_ldsomap):
1109 Use type_byte_order instead of gdbarch_byte_order.
1110 * stap-probe.c (stap_modify_semaphore):
1111 Use type_byte_order instead of gdbarch_byte_order.
1112 * target-float.c (target_float_same_format_p):
1113 Use type_byte_order instead of gdbarch_byte_order.
1114 * valarith.c (scalar_binop):
1115 (value_bit_index):
1116 Use type_byte_order instead of gdbarch_byte_order.
1117 * valops.c (value_cast):
1118 Use type_byte_order instead of gdbarch_byte_order.
1119 * valprint.c (generic_emit_char):
1120 (generic_printstr):
1121 (val_print_string):
1122 Use type_byte_order instead of gdbarch_byte_order.
1123 * value.c (unpack_long):
1124 (unpack_bits_as_long):
1125 (unpack_value_bitfield):
1126 (modify_field):
1127 (pack_long):
1128 (pack_unsigned_long):
1129 Use type_byte_order instead of gdbarch_byte_order.
1130 * findvar.c (unsigned_pointer_to_address):
1131 (signed_pointer_to_address):
1132 (unsigned_address_to_pointer):
1133 (address_to_signed_pointer):
1134 (default_read_var_value):
1135 (default_value_from_register):
1136 Use type_byte_order instead of gdbarch_byte_order.
1137 * gnu-v3-abi.c (gnuv3_make_method_ptr):
1138 Use type_byte_order instead of gdbarch_byte_order.
1139 * riscv-tdep.c (riscv_print_one_register_info):
1140 Use type_byte_order instead of gdbarch_byte_order.
1141
87fb00ea
SM		 11422019-11-21 Simon Marchi <simon.marchi@polymtl.ca>
1143
1144 * top.c (current_ui_gdb_stdout_ptr): Spell out by hand.
1145 (current_ui_gdb_stdin_ptr): Likewise.
1146 (current_ui_gdb_stderr_ptr): Likewise.
1147 (current_ui_gdb_stdlog_ptr): Likewise.
1148 (current_ui_current_uiout_ptr): Likewise.
1149 (gen_ret_current_ui_field_ptr): Remove.
1150
65d1cd5f
TV		 11512019-11-21 Tom de Vries <tdevries@suse.de>
1152
1153 PR gdb/24956
1154 * cli/cli-script.c (execute_control_command): Only switch to
1155 INTERP_CONSOLE's ui_out when INTERP_MI is active.
1156
9f6ad286
TT		 11572019-11-19 Tom Tromey <tom@tromey.com>
1158
1159 * tui/tui-win.c (tui_partial_win_by_name): Move from tui-data.c.
1160 Now static. Change type of "name".
1161 (tui_set_win_height_command): Don't copy "arg".
1162 * tui/tui-data.h (tui_partial_win_by_name): Don't declare.
1163 * tui/tui-data.c (tui_partial_win_by_name): Move to tui-win.c.
1164
435d3d88
AT		 11652019-11-19 Ali Tamur <tamur@google.com>
1166
1167 * dwarf2read.c (dw2_get_file_names_reader): Replace "if (attr)" with
1168 "if (attr != nullptr)".
1169 (dwarf2_find_base_address): Likewise.
1170 (dwarf2_build_include_psymtabs): Likewise.
1171 (read_cutu_die_from_dwo): Likewise.
1172 (read_func_scope): Likewise.
1173 (read_call_site_scope): Likewise.
1174 (dwarf2_get_pc_bounds): Likewise.
1175 (dwarf2_record_block_ranges): Likewise.
1176 (dwarf2_add_field): Likewise.
1177 (dwarf2_add_member_fn): Likewise.
1178 (read_structure_type): Likewise.
1179 (read_enumeration_type): Likewise.
1180 (read_array_type): Likewise.
1181 (read_array_order): Likewise.
1182 (read_set_type): Likewise.
1183 (read_common_block): Likewise.
1184 (read_tag_reference_type): Likewise.
1185 (read_tag_string_type): Likewise.
1186 (read_subroutine_type): Likewise.
1187 (read_base_type): Likewise.
1188 (read_subrange_type): Likewise.
1189 (new_symbol): Likewise.
1190 (prepare_one_comp_unit): Likewise.
1191
c9739b6a
TT		 11922019-11-19 Tom Tromey <tromey@adacore.com>
1193
1194 * windows-nat.c (windows_nat_target::attach): Include GetLastError
1195 result in error when DebugActiveProcess fails.
1196
494409bb
SDJ		 11972019-11-18 Sergio Durigan Junior <sergiodj@redhat.com>
1198 Pedro Alves <palves@redhat.com>
1199
1200 https://bugzilla.redhat.com/show_bug.cgi?id=1765117
1201 * target.c (target_stack::push): Call 'unpush' if there's a
1202 target on top of the stack.
1203
2e953aca
PW		 12042019-11-18 Philippe Waroquiers <philippe.waroquiers@skynet.be>
1205
1206 * python/py-block.c (blpy_dealloc): Call tp_free.
1207 (blpy_block_syms_dealloc): Likewise.
1208 * python/py-finishbreakpoint.c (bpfinishpy_dealloc): Likewise.
1209 * python/py-inferior.c (infpy_dealloc): Likewise.
1210 * python/py-lazy-string.c (stpy_dealloc): Likewise.
1211 * python/py-linetable.c (ltpy_iterator_dealloc): Likewise.
1212 * python/py-symbol.c (sympy_dealloc): Likewise.
1213 * python/py-symtab.c (stpy_dealloc): Likewise.
1214 * python/py-type.c (typy_iterator_dealloc): Likewise.
1215
6edc43ec
CB		 12162019-11-18 Christian Biesinger <cbiesinger@google.com>
1217
1218 * symtab.h (struct symbol) <owner>: Initialize explicitly in the
1219 constructor instead of using a class initializer.
1220
cd850b40
CB		 12212019-11-15 Christian Biesinger <cbiesinger@google.com>
1222
1223 * Makefile.in: Replace {posix,mingw}-strerror.c with safe-strerror.c.
1224 * configure: Regenerate.
1225 * configure.ac: Don't source common.host.
1226 * gdbsupport/common.host: Remove.
1227 * gdbsupport/mingw-strerror.c: Remove.
1228 * gdbsupport/posix-strerror.c: Rename to...
1229 * gdbsupport/safe-strerror.c: ...this.
1230
53fea9c7
CB		 12312019-11-15 Christian Biesinger <cbiesinger@google.com>
1232
1233 * maint.c (scoped_command_stats::print_time): Use localtime_r
1234 instead of localtime (provided through gnulib if necessary).
1235 * nat/linux-osdata.c (time_from_time_t): Use ctime_r instead
1236 of ctime.
1237
f8e27d88
CB		 12382019-11-15 Christian Biesinger <cbiesinger@google.com>
1239
1240 * gdbsupport/common-defs.h: Include time.h before pathmax.h to
1241 avoid compile errors.
1242
5abebf3c
CB		 12432019-11-15 Christian Biesinger <cbiesinger@google.com>
1244
1245 * config.in: Regenerate.
1246 * configure: Regenerate.
1247 * gdbsupport/common.m4: No longer check for strerror_r.
1248 * gdbsupport/posix-strerror.c (safe_strerror): Always call the
1249 POSIX version of strerror_r, now that gnulib provides it if
1250 necessary.
1251
9a351667
CB		 12522019-11-14 Christian Biesinger <cbiesinger@google.com>
1253
1254 * README (`configure' options): Update.
1255
55708e99
TT		 12562019-11-14 Tom Tromey <tromey@adacore.com>
1257
1258 * eval.c (evaluate_subexp_standard) <BINOP_ASSIGN>: Do not pass an
1259 expected type for the RHS if the LHS is a convenience variable.
1260
4b09bb2e
SM		 12612019-11-14 Simon Marchi <simon.marchi@polymtl.ca>
1262
1263 * unittests/vec-utils-selftests.c (unordered_remove_tests::obj):
1264 Provide explicit default and copy constructor.
1265
bd454f8b
PW		 12662019-11-14 Philippe Waroquiers <philippe.waroquiers@skynet.be>
1267
1268 * python/py-finishbreakpoint.c (gdbpy_breakpoint_created):
1269 only call Py_INCREF (newbp) in the bppy_pending_object case.
1270
d1aa3cf0
TT		 12712019-11-13 Tom Tromey <tromey@adacore.com>
1272
1273 PR build/25182:
1274 * psympriv.h (partial_symbol): Remove static assert.
1275 * symtab.h (general_symbol_info, symbol): Remove static assert.
1276
e06f3d6e
AB		 12772019-11-12 Andrew Burgess <andrew.burgess@embecosm.com>
1278
1279 * gdbsupport/format.c (format_pieces::format_pieces): Support
1280 printf 'z' size modifier.
1281 * gdbsupport/format.h (enum argclass): Add size_t_arg.
1282 * printcmd.c (ui_printf): Handle size_t_arg.
1283 * ui-out.c (ui_out::vmessage): Likewise.
1284 * unittests/format_pieces-selftests.c (test_format_int_sizes): New
1285 function.
1286 (run_tests): Call test_format_int_sizes.
1287
468c0cbb
CB		 12882019-11-12 Christian Biesinger <cbiesinger@google.com>
1289
1290 * ada-exp.y (write_ambiguous_var): Update.
1291 * buildsym.c (add_symbol_to_list): Update.
1292 * dwarf2read.c (read_variable): Update.
1293 (new_symbol): Update.
1294 * jit.c (finalize_symtab): Update.
1295 * language.c (language_alloc_type_symbol): Update.
1296 * symtab.c (fixup_symbol_section): Update.
1297 (initialize_objfile_symbol_1): Move code to...
1298 (initialize_objfile_symbol): ...here. Remove now-unnecessary memset.
1299 (allocate_symbol): Update.
1300 (allocate_template_symbol): Update.
1301 (get_symbol_address): Update.
1302 * symtab.h (struct symbol): Inherit from general_symbol_info instead
1303 of having as a field, and add a constructor.
1304 (SYMBOL_VALUE): Update.
1305 (SYMBOL_VALUE_ADDRESS): Update.
1306 (SET_SYMBOL_VALUE_ADDRESS): Update.
1307 (SYMBOL_VALUE_BYTES): Update.
1308 (SYMBOL_VALUE_COMMON_BLOCK): Update.
1309 (SYMBOL_BLOCK_VALUE): Update.
1310 (SYMBOL_VALUE_CHAIN): Update.
1311 (SYMBOL_LANGUAGE): Update.
1312 (SYMBOL_SECTION): Update.
1313 (SYMBOL_OBJ_SECTION): Update.
1314 (SYMBOL_SET_LANGUAGE): Update.
1315 (SYMBOL_SET_LINKAGE_NAME): Update.
1316 (SYMBOL_SET_NAMES): Update.
1317 (SYMBOL_NATURAL_NAME): Update.
1318 (SYMBOL_LINKAGE_NAME): Update.
1319 (SYMBOL_DEMANGLED_NAME): Update.
1320 (SYMBOL_SEARCH_NAME): Update.
1321 (SYMBOL_MATCHES_SEARCH_NAME): Update.
1322 (struct symbol): Update.
1323 (struct template_symbol): Update.
1324 (struct rust_vtable_symbol): Update.
1325 * xcoffread.c (SYMBOL_DUP): Update.
1326
ed2c82c3
TT		 13272019-11-12 Tom Tromey <tom@tromey.com>
1328
1329 * tui/tui-layout.c (show_layout): Set current_layout.
1330 (show_source_disasm_command, show_data)
1331 (show_source_or_disasm_and_command): Don't set current_layout.
1332
d9fcefd5
TT		 13332019-11-12 Tom Tromey <tom@tromey.com>
1334
1335 * tui/tui-layout.c (_initialize_tui_layout): Move to end.
1336
45e42163
TT		 13372019-11-12 Tom Tromey <tom@tromey.com>
1338
1339 * tui/tui-win.c (resize_message): New global.
1340 (show_tui_resize_message): New function.
1341 (tui_async_resize_screen): Print message if requested.
1342 (_initialize_tui_win): Add tui-resize-message setting.
1343 * NEWS: Add entry for new commands.
1344
c86d74cc
TT		 13452019-11-11 Tom Tromey <tom@tromey.com>
1346
1347 * tui/tui.c (tui_initialize_readline): Add new bindable readline
1348 functions.
1349
7b7b9424
CB		 13502019-11-11 Christian Biesinger <cbiesinger@google.com>
1351
1352 * nat/linux-osdata.c (user_from_uid): Use getpwuid_r.
1353
086baaf1
AB		 13542019-11-10 Andrew Burgess <andrew.burgess@embecosm.com>
1355
1356 * python/py-symbol.c (gdbpy_lookup_static_symbols): New
1357 function.
1358 * python/python-internal.h (gdbpy_lookup_static_symbols):
1359 Declare new function.
1360 * python/python.c (python_GdbMethods): Add
1361 gdb.lookup_static_symbols method.
1362 * NEWS: Mention gdb.lookup_static_symbols.
1363
09ff83af
AB		 13642019-11-10 Andrew Burgess <andrew.burgess@embecosm.com>
1365
1366 * python/py-symbol.c (gdbpy_lookup_static_symbol): Lookup in
1367 static block of current object file first. Also fix typo in
1368 header comment.
1369
eb2dd8df
AB		 13702019-11-10 Andrew Burgess <andrew.burgess@embecosm.com>
1371
1372 * stack.c (set_last_displayed_sal): Delete.
1373 (last_displayed_sal_valid): Delete.
1374 (last_displayed_pspace): Delete.
1375 (last_displayed_addr): Delete.
1376 (last_displayed_symtab): Delete.
1377 (last_displayed_line): Delete.
1378 (class last_displayed_symtab_info_type): New.
1379 (last_displayed_symtab_info): New static global variable.
1380 (print_frame_info): Call methods on last_displayed_symtab_info.
1381 (clear_last_displayed_sal): Update header comment, and make use of
1382 last_displayed_symtab_info.
1383 (last_displayed_sal_is_valid): Likewise.
1384 (get_last_displayed_pspace): Likewise.
1385 (get_last_displayed_addr): Likewise.
1386 (get_last_displayed_symtab): Likewise.
1387 (get_last_displayed_line): Likewise.
1388 (get_last_displayed_sal): Likewise.
1389 * stack.h (clear_last_displayed_sal): Update header comment.
1390 (last_displayed_sal_is_valid): Likewise.
1391 (get_last_displayed_pspace): Likewise.
1392 (get_last_displayed_addr): Likewise.
1393 (get_last_displayed_symtab): Likewise.
1394 (get_last_displayed_line): Likewise.
1395 (get_last_displayed_sal): Likewise.
1396
62137775
AB		 13972019-11-10 Andrew Burgess <andrew.burgess@embecosm.com>
1398
1399 * stack.c (frame_show_address): Convert return type to bool.
1400 * stack.h (frame_show_address): Likewise, and update header
1401 comment.
1402
cf57ad6d
AB		 14032019-11-10 Andrew Burgess <andrew.burgess@embecosm.com>
1404
1405 * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add new file to the list.
1406 * unittests/vec-utils-selftests.c: New file.
1407 * gdbsupport/gdb_vecs.h (unordered_remove): Avoid self move assign.
1408
0b026263
TT		 14092019-11-10 Tom Tromey <tom@tromey.com>
1410
1411 * tui/tui-wingeneral.c (tui_unhighlight_win): Use can_box.
1412 (tui_highlight_win): Likewise.
1413 (tui_win_info::check_and_display_highlight_if_needed): Likewise.
1414 * tui/tui-data.h (struct tui_win_info) <can_highlight>: Remove.
1415 * tui/tui-command.h (struct tui_cmd_window) <tui_cmd_window>:
1416 Don't set can_highlight.
1417
b049ce2d
TT		 14182019-11-10 Tom Tromey <tom@tromey.com>
1419
1420 * cli/cli-style.h (class cli_style_option) <cli_style_option>:
1421 Remove unused declaration.
1422
992a7040
TT		 14232019-11-08 Tom Tromey <tromey@adacore.com>
1424
1425 * top.c (read_command_file): Update.
1426 (command_line_input): Make return type const.
1427 * python/py-gdb-readline.c: Update.
1428 * linespec.c (decode_line_2): Update.
1429 * defs.h (command_line_input): Make return type const.
1430 * cli/cli-script.c (read_next_line): Make return type const.
1431 * ada-lang.c (get_selections): Update.
1432
ca3a04f6
CB		 14332019-11-06 Christian Biesinger <cbiesinger@google.com>
1434
1435 * linux-tdep.c (linux_info_proc): Use strtok_r instead of strtok.
1436 * mi/mi-main.c (output_cores): Likewise.
1437 * nat/linux-osdata.c (linux_xfer_osdata_cpus): Likewise.
1438 (linux_xfer_osdata_modules): Likewise.
1439 * remote.c (register_remote_support_xml): Likewise.
1440 * sparc64-tdep.c (adi_is_addr_mapped): Likewise.
1441 * xml-syscall.c (syscall_create_syscall_desc): Likewise.
1442
e0eac551
TT		 14432019-11-06 Tom Tromey <tom@tromey.com>
1444
1445 * tui/tui-interp.c: Don't include readline.h.
1446 * tui/tui-hooks.c: Don't include readline.h.
1447 * symmisc.c: Include tilde.h, not readline.h.
1448 * symfile.c: Include tilde.h, not readline.h.
1449 * source.c: Include tilde.h, not readline.h.
1450 * solib.c: Include tilde.h, not readline.h.
1451 * psymtab.c: Include tilde.h, not readline.h.
1452 * exec.c: Include tilde.h, not readline.h.
1453 * corelow.c: Include tilde.h, not readline.h.
1454 * cli/cli-dump.c: Include tilde.h, not readline.h.
1455 * cli/cli-cmds.c: Don't include readline.h.
1456
825165c5
TT		 14572019-11-05 Tom Tromey <tom@tromey.com>
1458
1459 * tui/tui-disasm.c (struct tui_asm_line) <addr_size>: New member.
1460 (tui_disassemble): Set addr_size.
1461 (tui_disasm_window::set_contents): Use addr_size.
1462
91ae903f
TT		 14632019-11-05 Tom Tromey <tom@tromey.com>
1464
1465 * rust-lang.c (rust_language_defn): Update.
1466 * python/py-value.c (valpy_string): Call c_get_string.
1467 * p-lang.c (pascal_language_defn): Update.
1468 * opencl-lang.c (opencl_language_defn): Update.
1469 * objc-lang.c (objc_language_defn): Update.
1470 * m2-lang.c (m2_language_defn): Update.
1471 * language.c (unknown_language_defn, auto_language_defn): Update.
1472 (default_get_string): Remove.
1473 * guile/scm-value.c (gdbscm_value_to_string): Use c_get_string.
1474 * go-lang.c (go_language_defn): Update.
1475 * f-lang.c (f_language_defn): Update.
1476 * d-lang.c (d_language_defn): Update.
1477 * c-lang.c (c_language_defn, cplus_language_defn)
1478 (asm_language_defn, minimal_language_defn): Update.
1479 * ada-lang.c (ada_language_defn): Update.
1480 * language.h (struct language_defn) <la_get_string>: Remove.
1481 (LA_GET_STRING): Remove.
1482 (default_get_string): Don't declare.
1483
1df2f9ef
TT		 14842019-11-05 Tom Tromey <tom@tromey.com>
1485
1486 * tui/tui-source.h (struct tui_source_window): Inline
1487 constructor. Remove destructor.
1488 <style_changed, m_observable>: Move to superclass.
1489 * tui/tui-winsource.h (tui_copy_source_line): Declare.
1490 (struct tui_source_window_base): Move private members to end.
1491 <style_changed, m_observable>: Move from tui_source_window.
1492 * tui/tui-winsource.c (tui_copy_source_line): Move from
1493 tui-source.c. Rename from copy_source_line. Add special handling
1494 for negative line number.
1495 (tui_source_window_base::style_changed): Move from
1496 tui_source_window.
1497 (tui_source_window_base): Register observer.
1498 (~tui_source_window_base): New.
1499 * tui/tui-source.c (copy_source_line): Move to tui-winsource.c;
1500 rename.
1501 (tui_source_window::set_contents): Use tui_copy_source_line.
1502 (tui_source_window::tui_source_window): Move to tui-source.h.
1503 (tui_source_window::~tui_source_window): Remove.
1504 (tui_source_window::style_changed): Move to superclass.
1505 * tui/tui-disasm.c (tui_disassemble): Create string file with
1506 styling, when possible. Add "addr_size" parameter.
1507 (tui_disasm_window::set_contents): Use tui_copy_source_line.
1508 Don't compute maximum size.
1509 (len_without_escapes): New function
1510
5d051055
TT		 15112019-11-05 Tom Tromey <tom@tromey.com>
1512
1513 * tui/tui-winsource.h (struct tui_source_element) <line>: Now a
1514 std::string.
1515 * tui/tui-winsource.c (tui_show_source_line): Update.
1516 * tui/tui-source.c (tui_source_window::set_contents): Update.
1517 * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
1518
ade7beea
CB		 15192019-11-05 Christian Biesinger <cbiesinger@google.com>
1520
1521 * symtab.h (gdb_static_assert): Put && operator at the beginning
1522 of the line instead of the end.
1523
3573abe1
CB		 15242019-11-04 Christian Biesinger <cbiesinger@google.com>
1525
1526 * psympriv.h: Add static_asserts for sizeof (general_symbol_info)
1527 and sizeof (symbol).
1528 * symtab.h: Add a static_assert for sizeof (partial_symbol).
1529
dae8b3eb
RO		 15302019-11-04 Rainer Orth <ro@CeBiTec.Uni-Bielefeld.DE>
1531
1532 * NEWS (Changes since GDB 8.3): Document Solaris 10 removal.
1533 * configure.host: Mark *-*-solaris2.10* obsolete.
1534 * configure.tgt: Mark Solaris < 11 obsolete.
1535 * MAINTAINERS (Target Instruction Set Architectures) <sparc>:
1536 Update target triplet.
1537
5df96a4e
TT		 15382019-11-01 Tom Tromey <tromey@adacore.com>
1539
1540 * utils.c (print_sys_errmsg): Simplify.
1541
b7481649
TT		 15422019-11-01 Tom Tromey <tromey@adacore.com>
1543
1544 * gdbsupport/mingw-strerror.c (safe_strerror): Constify result.
1545
e48f6033
CB		 15462019-11-01 Christian Biesinger <cbiesinger@google.com>
1547
1548 * configure: Regenerate.
1549 * configure.ac: Remove check for strerror_r.
1550 * gdbsupport/common.m4: Check for strerror_r.
1551
bd5766ec
LM		 15522019-11-01 Luis Machado <luis.machado@linaro.org>
1553
1554 PR gdb/25124
1555
1556 * arm-tdep.c (arm_per_objfile): Rename to ...
1557 (arm_per_bfd): ... this.
1558 (arm_objfile_data_key): Rename to ...
1559 (arm_bfd_data_key): ... this.
1560 (arm_find_mapping_symbol): Adjust access to new bfd_key-based
1561 data.
1562 (arm_record_special_symbol): Likewise.
1563
e1709896
AB		 15642019-10-31 Andrew Burgess <andrew.burgess@embecosm.com>
1565
1566 * ada-typeprint.c (ada_print_typedef): Don't print newline at the
1567 end.
1568 * c-typeprint.c (c_print_typedef): Likewise.
1569 * f-typeprint.c (f_print_typedef): Likewise.
1570 * m2-typeprint.c (m2_print_typedef): Likewise.
1571 * p-typeprint.c (pascal_print_typedef): Likewise.
1572 * rust-lang.c (rust_print_typedef): Likewise.
1573 * symtab.c (print_symbol_info): Print a newline after calling
1574 typedef_print.
1575
165f8965
AB		 15762019-10-31 Andrew Burgess <andrew.burgess@embecosm.com>
1577
1578 * symtab.c (info_module_cmdlist): New variable.
1579 (info_module_command): New function.
1580 (search_module_symbols): New function.
1581 (info_module_subcommand): New function.
1582 (struct info_modules_var_func_options): New struct.
1583 (info_modules_var_func_options_defs): New variable.
1584 (make_info_modules_var_func_options_def_group): New function.
1585 (info_module_functions_command): New function.
1586 (info_module_variables_command): New function.
1587 (info_module_var_func_command_completer): New function.
1588 (_initialize_symtab): Register new 'info module functions' and
1589 'info module variables' commands.
1590 * symtab.h (typedef symbol_search_in_module): New typedef.
1591 (search_module_symbols): Declare new function.
1592 * NEWS: Mention new commands.
1593
59c35742
AB		 15942019-10-31 Andrew Burgess <andrew.burgess@embecosm.com>
1595
1596 * dwarf2read.c (dw2_symtab_iter_next): Handle MODULE_DOMAIN.
1597 (dw2_expand_marked_cus): Handle MODULES_DOMAIN.
1598 (dw2_debug_names_iterator::next): Handle MODULE_DOMAIN and
1599 MODULES_DOMAIN.
1600 (scan_partial_symbols): Only create partial module symbols for non
1601 declarations.
1602 * psymtab.c (recursively_search_psymtabs): Handle MODULE_DOMAIN
1603 and MODULES_DOMAIN.
1604 * symtab.c (search_domain_name): Likewise.
1605 (search_symbols): Likewise.
1606 (print_symbol_info): Likewise.
1607 (symtab_symbol_info): Likewise.
1608 (info_modules_command): New function.
1609 (_initialize_symtab): Register 'info modules' command.
1610 * symtab.h (enum search_domain): Add MODULES_DOMAIN.
1611 * NEWS: Mention new 'info modules' command.
1612
aed61d02
PW		 16132019-10-31 Philippe Waroquiers <philippe.waroquiers@skynet.be>
1614
1615 * NEWS: Mention $_gdb_setting, $_gdb_setting_str, $_gdb_maint_setting
1616 and $_gdb_maint_setting_str.
1617
9ad9b77d
PW		 16182019-10-31 Philippe Waroquiers <philippe.waroquiers@skynet.be>
1619
1620 * cli/cli-cmds.c (setting_cmd, value_from_setting)
1621 (gdb_setting_internal_fn, gdb_maint_setting_internal_fn)
1622 (str_value_from_setting, gdb_setting_str_internal_fn)
1623 (gdb_maint_setting_str_internal_fn): New functions.
1624 (_initialize_cli_cmds): Define the new convenience functions.
1625 * gdb/cli/cli-setshow.h (get_setshow_command_value_string): Constify.
1626 * gdb/cli/cli-setshow.c (get_setshow_command_value_string): Constify.
1627
8d6efaa2
CB		 16282019-10-31 Christian Biesinger <cbiesinger@google.com>
1629
1630 * agent.c (set_can_use_agent): When the setting is turned on,
1631 look up agent symbols if we don't have them yet.
1632 (agent_new_objfile): Don't look up agent symbols when the agent
1633 setting is off.
1634
33cb1647
CB		 16352019-10-31 Christian Biesinger <cbiesinger@google.com>
1636
1637 * config.in: Regenerate.
1638
b231e86a
CB		 16392019-10-31 Christian Biesinger <cbiesinger@google.com>
1640
1641 * configure: Regenerate.
1642 * configure.ac: Check for strerror_r.
1643 * gdbsupport/common-utils.h (safe_strerror): Change return value
1644 to const char * and document that this function is now threadsafe.
1645 * gdbsupport/posix-strerror.c (safe_strerror): Make buf
1646 thread_local and call strerror_r, if available.
1647 * utils.c (perror_string): Update.
1648 (print_sys_errmsg): Update.
1649
a2726d4f
LM		 16502019-10-31 Luis Machado <luis.machado@linaro.org>
1651
1652 * arm-tdep.c (arm_exidx_data_key): Use bfd_key instead of
1653 objfile_key.
1654 (arm_exidx_new_objfile): Adjust to use objfile->obfd instead of
1655 objfile to fetch per-bfd data.
1656 (arm_find_exidx_entry): Likewise.
1657
75cafaa6
CB		 16582019-10-31 Christian Biesinger <cbiesinger@google.com>
1659
1660 * gdbsupport/agent.c (debug_agent): Change type to bool.
1661 (use_agent): Likewise.
1662 (all_agent_symbols_look_up): Likewise.
1663 (agent_loaded_p): Change return value to bool.
1664 (agent_look_up_symbols): Update.
1665 (agent_capability_check): Change return value to bool.
1666 * gdbsupport/agent.h (agent_loaded_p): Likewise.
1667 (debug_agent): Change type to bool.
1668 (use_agent): Likewise.
1669 (agent_capability_check): Change return value to bool.
1670
808590ec
CB		 16712019-10-30 Christian Biesinger <cbiesinger@google.com>
1672
1673 * minsyms.c (clear_minimal_symbol_hash_tables): New function.
1674 (build_minimal_symbol_hash_tables): Code to clear the table moved
1675 to clear_minimal_symbol_hash_tables.
1676 (minimal_symbol_reader::install): Call clear_minimal_symbol_hash_tables
1677 when needed.
1678
f18ad8a1
SM		 16792019-10-29 Simon Marchi <simon.marchi@polymtl.ca>
1680
1681 * infcmd.c: Remove includes.
1682 * infrun.c: Remove includes.
1683
de93309a
SM		 16842019-10-29 Simon Marchi <simon.marchi@polymtl.ca>
1685
1686 * ada-lang.h (GROW_VECT): Move to ada-lang.c.
1687 (grow_vect): Remove declaration.
1688 (ada_type_of_array): Remove declaration.
1689 (ada_update_initial_language): Remove declaration.
1690 (ada_fold_name): Remove declaration.
1691 (ada_fill_in_ada_prototype): Remove declaration.
1692 (user_select_syms): Remove declaration.
1693 (get_selections): Remove declaration.
1694 (ada_tag_type): Remove declaration.
1695 (ada_value_tag): Remove declaration.
1696 (ada_is_others_clause): Remove declaration.
1697 (ada_in_variant): Remove declaration.
1698 (ada_value_struct_elt): Remove declaration.
1699 (ada_attribute_name): Remove declaration.
1700 (ada_system_address_type): Remove declaration.
1701 * ada-lang.c (ada_watch_location_expression): Make static.
1702 (GROW_VECT): Move here from ada-lang.h.
1703 (grow_vect): Make static.
1704 (ada_update_initial_language): Make static.
1705 (ada_fold_name): Make static.
1706 (ada_type_of_array): Make static.
1707 (encoded_ordered_before): Move up.
1708 (sort_choices): Move up.
1709 (print_signatures): Move up.
1710 (ada_print_symbol_signature): Move up.
1711 (get_selections): Move up and make static.
1712 (user_select_syms): Move up and make static.
1713 (ada_value_struct_elt): Move up and make static.
1714 (ada_tag_type): Make static.
1715 (ada_value_tag): Make static.
1716 (ada_is_others_clause): Make static.
1717 (ada_in_variant): Make static.
1718 (ada_attribute_name): Make static.
1719
cdc46a9f
SM		 17202019-10-29 Simon Marchi <simon.marchi@polymtl.ca>
1721
1722 * ada-lang.c: Remove includes.
1723 * ada-typeprint.c: Remove includes.
1724 * ada-valprint.c: Remove includes.
1725
90421c56
SM		 17262019-10-29 Simon Marchi <simon.marchi@efficios.com>
1727
1728 * addrmap.c: Add static assertions of type size, moved from
1729 _initialize_addrmap.
1730 (_initialize_addrmap): Remove.
1731
31edb802
CB		 17322019-10-29 Christian Biesinger <cbiesinger@google.com>
1733
1734 * coffread.c (record_minimal_symbol): Update.
1735 (process_coff_symbol): Update.
1736 * dbxread.c (read_dbx_symtab): Update.
1737 * dwarf2read.c (add_partial_symbol): Update.
1738 (fixup_go_packaging): Update.
1739 (load_partial_dies): Update.
1740 (new_symbol): Update.
1741 * elfread.c (record_minimal_symbol): Change signature to use
1742 gdb::string_view instead of name+len.
1743 (elf_symtab_read): Update.
1744 (elf_rel_plt_read): Update.
1745 * mdebugread.c (parse_partial_symbols): Update.
1746 (handle_psymbol_enumerators): Update.
1747 (new_symbol): Update.
1748 * minsyms.c (minimal_symbol_reader::record_full): Change signature
1749 to use gdb::string_view instead of name+len.
1750 * minsyms.h (class minimal_symbol_reader) <record_full>: Likewise.
1751 * psympriv.h (add_psymbol_to_list): Likewise.
1752 * psymtab.c (add_psymbol_to_bcache): Likewise.
1753 (add_psymbol_to_list): Likewise.
1754 * stabsread.c (define_symbol): Update.
1755 * symtab.c (symbol_set_names): Change signature to use gdb::string_view.
1756 * symtab.h (SYMBOL_SET_NAMES): Likewise.
1757 (symbol_set_names): Likewise.
1758 * xcoffread.c (scan_xcoff_symtab): Update.
1759
0c921b21
CB		 17602019-10-29 Christian Biesinger <cbiesinger@google.com>
1761
1762 * symtab.h (symbol_set_names): Document that copy_name must be
1763 set to true for non-nullterminated strings.
1764 * symtab.c (symbol_set_names): Only make a nullterminated copy of
1765 linkage_name if the entry was not found and we need to demangle.
1766
35e65c49
CB		 17672019-10-29 Christian Biesinger <cbiesinger@google.com>
1768
1769 * Makefile.in (HFILES_NO_SRCDIR): Add gdb_binary_search.h.
1770 * dwarf2-frame.c (bsearch_fde_cmp): Update.
1771 (dwarf2_frame_find_fde): Replace bsearch with gdb::binary_search.
1772 * gdbsupport/gdb_binary_search.h: New file.
1773
ed2a2229
CB		 17742019-10-29 Christian Biesinger <cbiesinger@google.com>
1775
1776 * NEWS: Mention new --with-system-gdbinit-dir option.
1777 * config.in: Regenerate.
1778 * configure: Regenerate.
1779 * configure.ac: Add new option --with-system-gdbinit-dir.
1780 * extension.c (get_ext_lang_of_file): Return extension_language_gdb
1781 for a ".gdb" suffix.
1782 * main.c (get_init_files): Change system_gdbinit argument to
1783 a vector and return the files in SYSTEM_GDBINIT_DIR in
1784 addition to SYSTEM_GDBINIT.
1785 (captured_main_1): Update.
1786 (print_gdb_help): Update.
1787 * top.c (print_gdb_configuration): Also print the value of
1788 SYSTEM_GDBINIT_DIR.
1789
87f34879
CB		 17902019-10-28 Christian Biesinger <cbiesinger@google.com>
1791
1792 * gdbsupport/common-utils.h (startswith): Add an overloaded version
1793 that takes gdb::string_view arguments.
1794
30baf67b
TV		 17952019-10-26 Tom de Vries <tdevries@suse.de>
1796
1797 * aarch64-linux-tdep.c: Fix typos in comments.
1798 * aarch64-tdep.c: Same.
1799 * ada-lang.c: Same.
1800 * amd64-nat.c: Same.
1801 * arc-tdep.c: Same.
1802 * arch/aarch64-insn.c: Same.
1803 * block.c: Same.
1804 * breakpoint.h: Same.
1805 * btrace.h: Same.
1806 * c-varobj.c: Same.
1807 * cli/cli-decode.c: Same.
1808 * cli/cli-script.c: Same.
1809 * cli/cli-utils.h: Same.
1810 * coff-pe-read.c: Same.
1811 * coffread.c: Same.
1812 * compile/compile-cplus-symbols.c: Same.
1813 * compile/compile-object-run.c: Same.
1814 * completer.c: Same.
1815 * corelow.c: Same.
1816 * cp-support.c: Same.
1817 * demangle.c: Same.
1818 * dwarf-index-write.c: Same.
1819 * dwarf2-frame.c: Same.
1820 * dwarf2-frame.h: Same.
1821 * eval.c: Same.
1822 * frame-base.h: Same.
1823 * frame.h: Same.
1824 * gdbcmd.h: Same.
1825 * gdbtypes.h: Same.
1826 * gnu-nat.c: Same.
1827 * guile/scm-objfile.c: Same.
1828 * i386-tdep.c: Same.
1829 * i386-tdep.h: Same.
1830 * infcall.c: Same.
1831 * infcall.h: Same.
1832 * linux-nat.c: Same.
1833 * m68k-tdep.c: Same.
1834 * macroexp.c: Same.
1835 * memattr.c: Same.
1836 * mi/mi-cmd-disas.c: Same.
1837 * mi/mi-getopt.h: Same.
1838 * mi/mi-main.c: Same.
1839 * minsyms.c: Same.
1840 * nat/aarch64-sve-linux-sigcontext.h: Same.
1841 * objfiles.h: Same.
1842 * ppc-linux-nat.c: Same.
1843 * ppc-linux-tdep.c: Same.
1844 * ppc-tdep.h: Same.
1845 * progspace.h: Same.
1846 * prologue-value.h: Same.
1847 * python/py-evtregistry.c: Same.
1848 * python/py-instruction.h: Same.
1849 * record-btrace.c: Same.
1850 * record-full.c: Same.
1851 * remote.c: Same.
1852 * rs6000-tdep.c: Same.
1853 * ser-tcp.c: Same.
1854 * sol-thread.c: Same.
1855 * sparc-sol2-tdep.c: Same.
1856 * sparc64-tdep.c: Same.
1857 * stabsread.c: Same.
1858 * symfile.c: Same.
1859 * symtab.h: Same.
1860 * target.c: Same.
1861 * tracepoint.c: Same.
1862 * tui/tui-data.h: Same.
1863 * tui/tui-io.c: Same.
1864 * tui/tui-win.c: Same.
1865 * tui/tui.c: Same.
1866 * unittests/rsp-low-selftests.c: Same.
1867 * user-regs.h: Same.
1868 * utils.c: Same.
1869 * utils.h: Same.
1870 * valarith.c: Same.
1871 * valops.c: Same.
1872 * valprint.c: Same.
1873 * valprint.h: Same.
1874 * value.c: Same.
1875 * value.h: Same.
1876 * varobj.c: Same.
1877 * x86-nat.h: Same.
1878 * xtensa-tdep.c: Same.
1879
1834d45f
AT		 18802019-10-25 Ali Tamur <tamur@google.com>
1881
1882 * charset.c (find_charset_names): Reflect API change.
1883
5396ae17
CB		 18842019-10-25 Christian Biesinger <cbiesinger@google.com>
1885
1886 * symtab.c (struct demangled_name_entry): Change demangled name
1887 to a unique_xmalloc_ptr<char>, now that we don't allocate it as
1888 part of the struct anymore.
1889 (symbol_set_names): No longer obstack allocate + copy the demangled
1890 name, just store the allocated name from bfd.
1891
93878f47
TT		 18922019-10-25 Tom Tromey <tromey@adacore.com>
1893
1894 * dwarf2-frame.c (dwarf2_cie_table): Now a typedef.
1895 (bsearch_cie_cmp, add_cie): Remove.
1896 (find_cie): Reimplement.
1897 (decode_frame_entry_1, decode_frame_entry): Change type. Update.
1898 (dwarf2_build_frame_info): Update.
1899
7b71fc97
L		 19002019-10-24 H.J. Lu <hongjiu.lu@intel.com>
1901
1902 PR gdb/25126
1903 * symfile.c (reread_symbols): Call forget_cached_source_info to
1904 clear the stale source cache.
1905
cbb5a2ea
CB		 19062019-10-24 Christian Biesinger <cbiesinger@google.com>
1907
1908 * configure: Regenerate.
1909 * configure.ac: Remove code that sets python_has_threads.
1910
71737c43
CB		 19112019-10-24 Christian Biesinger <cbiesinger@google.com>
1912
1913 * config.in: Regenerate.
1914 * configure: Regenerate.
1915 * configure.ac: Remove the code that uses sed to get the python
1916 version and defines HAVE_LIBPYTHON2_6 / HAVE_LIBPYTHON2_7.
1917
33d569b7
AB		 19182019-10-24 Andrew Burgess <andrew.burgess@embecosm.com>
1919
1920 * python/py-progspace.c (pspy_block_for_pc): Return None for all
1921 error paths.
1922
f16f7b7c
TT		 19232019-10-23 Tom Tromey <tom@tromey.com>
1924
1925 * arc-tdep.c: Remove ".." from include.
1926 * frv-tdep.c: Remove ".." from include.
1927 * lm32-tdep.c: Remove ".." from include.
1928 * microblaze-tdep.c: Remove ".." from include.
1929 * or1k-tdep.h: Remove ".." from include.
1930 * s12z-tdep.c: Remove ".." from include.
1931 * Makefile.in (OPCODES_CFLAGS): Add comment.
1932 (TOP_CFLAGS): New variable.
1933 (INTERNAL_CFLAGS_BASE): Add TOP_CFLAGS.
1934
6999161a
TT		 19352019-10-23 Tom Tromey <tom@tromey.com>
1936
1937 * Makefile.in (READLINE_DIR): Update.
1938
12e7c35e
TBA		 19392019-10-23 Tankut Baris Aktemur <tankut.baris.aktemur@intel.com>
1940
1941 * infcall.c (call_function_by_hand_dummy): Fix the function
1942 comment. And extract out a code section into...
1943 (reserve_stack_space): ...this new function.
1944
37055cad
TBA		 19452019-10-23 Tankut Baris Aktemur <tankut.baris.aktemur@intel.com>
1946
1947 * infcall.c (value_arg_coerce): Remove an unused parameter.
1948 (call_function_by_hand_dummy): Update the call to
1949 'value_arg_coerce'.
1950
39bcc47c
TBA		 19512019-10-23 Tankut Baris Aktemur <tankut.baris.aktemur@intel.com>
1952
1953 * infcall.c (call_function_by_hand_dummy): Refactor.
1954
bd888c0f
TBA		 19552019-10-23 Tankut Baris Aktemur <tankut.baris.aktemur@intel.com>
1956
1957 * MAINTAINERS (Write After Approval): Add Tankut Baris Aktemur.
1958
c12d372d
TT		 19592019-10-23 Tom Tromey <tom@tromey.com>
1960
1961 * configure: Rebuild.
1962 * configure.ac: Don't check for sigprocmask.
1963 * gdbsupport/common.m4 (GDB_AC_COMMON): Check for sigprocmask.
1964
4d0b984b
TT		 19652019-10-23 Tom Tromey <tom@tromey.com>
1966
1967 * configure: Rebuild.
1968 * acinclude.m4: Use m4_include, not sinclude.
1969
7e785608
TV		 19702019-10-23 Tom de Vries <tdevries@suse.de>
1971
1972 PR breakpoints/24687
1973 * symtab.c (iterate_over_some_symtabs): Apply gdb_realpath on fullname.
1974
403772ef
CB		 19752019-10-22 Christian Biesinger <cbiesinger@google.com>
1976
1977 * symtab.c (struct demangled_name_entry) <language>: Change from
1978 bitfield to regular variable.
1979
3a494279
CB		 19802019-10-22 Christian Biesinger <cbiesinger@google.com>
1981
1982 * symtab.c (struct demangled_name_entry): Add a constructor.
1983 (free_demangled_name_entry): New function to call the destructor
1984 for demangled_name_entry.
1985 (create_demangled_names_hash): Pass free_demangled_name_entry to
1986 htab_create_alloc.
1987 (symbol_set_names): Call placement new for demangled_name_entry.
1988 * utils.c: No longer include xxhash.h here, now that fast_hash
1989 is inlined in the header.
1990 * utils.h: Instead, include it here.
1991
ccb1ba62
CB		 19922019-10-22 Christian Biesinger <cbiesinger@google.com>
1993
1994 * Makefile.in: Link with libxxhash.
1995 * config.in: Regenerate.
1996 * configure: Regenerate.
1997 * configure.ac: Search for libxxhash.
1998 * utils.c (fast_hash): Use xxhash if present.
1999
1a6ff1a9
CB		 20002019-10-22 Christian Biesinger <cbiesinger@google.com>
2001
2002 * utils.h (fast_hash): New function.
2003 * symtab.c (hash_demangled_name_entry): Call new function
2004 fast_hash.
2005
7bb43059
CB		 20062019-10-22 Christian Biesinger <cbiesinger@google.com>
2007
2008 * symtab.c (struct demangled_name_entry): Change type of mangled
2009 to gdb::string_view. Also adds a constructor that takes the
2010 mangled name.
2011 (hash_demangled_name_entry): Update.
2012 (eq_demangled_name_entry): Update.
2013 (free_demangled_name_entry): New function to call the destructor
2014 now that this is not a POD anymore.
2015 (create_demangled_names_hash): Pass free_demangled_name_entry to
2016 htab_create_alloc.
2017 (symbol_set_names): Update.
2018
7ba99d21
AT		 20192019-10-21 Ali Tamur <tamu@google.com>
2020
2021 * dwarf2read.c (dir_index): Change type.
2022 (file_name_index): Likewise.
2023 (line_header::include_dir_at): Change comment and implementation on
2024 whether it is DWARF 5.
2025 (line_header::is_valid_file_index): New function.
2026 (line_header::file_name_at): Change comment and implementation on
2027 whether it is DWARF 5.
2028 (line_header::file_names): Change to private field renamed as
2029 m_file_names and introduce a new accessor method.
2030 (line_header::file_names_size): New method.
2031 (line_header::include_dirs): Change to private field and rename as
2032 m_include_dirs.
2033 (dw2_get_file_names_reader): Define local var at a smaller scope and
2034 reflect API change.
2035 (dwarf2_cu::setup_type_unit_groups): Reflect API change.
2036 (process_structure_scope): Likewise.
2037 (line_header::add_include_dir): Change message and reflect renaming.
2038 (line_header::add_file_name): Likewise.
2039 (read_formatted_entries): Handle DW_FORM_data16.
2040 (dwarf_decode_line_header): Fix line header length calculation.
2041 (psymtab_include_file_name): Change comment and API.
2042 (lnp_state_machine::m_file): Update comment and reflect type change.
2043 (lnp_state_machine::record_line): Reflect type change.
2044 (dwarf_decode_lines): Reflect API change.
2045 (file_file_name): Likewise.
2046 (file_full_name): Likewise.
2047
45f47c3a
AB		 20482019-10-21 Andrew Burgess <andrew.burgess@embecosm.com>
2049
2050 * objfiles.c (sort_cmp): Ensure that !(a < a) holds true.
2051
e5f3c0e3
TT		 20522019-10-21 Tom Tromey <tom@tromey.com>
2053
2054 * tui/tui-winsource.h (tui_exec_info_content): Remove typedef.
2055
a0a461e5
TT		 20562019-10-21 Tom Tromey <tom@tromey.com>
2057
2058 * configure.ac (nm.h): Conditionally create nm.h link. Subst
2059 NM_H. Use AC_CONFIG_LINKS.
2060 * configure: Rebuild.
2061 * Makefile.in (NM_H): New variable.
2062 (generated_files): Add NM_H. Remove gcore.
2063 (nm.h, stamp-nmh): New targets.
2064
54d83b8d
TT		 20652019-10-20 Tom Tromey <tom@tromey.com>
2066
2067 * objfiles.h (unlink_objfile, put_objfile_before): Don't declare.
2068 * objfiles.c (unlink_objfile): Move earlier. Now static. Remove
2069 obsolete comment.
2070 (put_objfile_before): Now static.
2071
23771117
SM		 20722019-10-19 Simon Marchi <simon.marchi@polymtl.ca>
2073
2074 * gdbsupport/common-utils.h (startswith): Change return type to
2075 bool.
2076
39ef2f62
CB		 20772019-10-19 Christian Biesinger <cbiesinger@google.com>
2078
2079 * bcache.c (bcache::print_statistics): Use std::sort instead of qsort.
2080 * breakpoint.c (bp_locations_compare): Rename to...
2081 (bp_location_is_less_than): ...this, and change to std::sort semantics.
2082 (update_global_location_list): Use std::sort instead of qsort.
2083 * buildsym.c (compare_line_numbers): Rename to...
2084 (lte_is_less_than): ...this, and change to std::sort semantics.
2085 (buildsym_compunit::end_symtab_with_blockvector): Use std::sort
2086 instead of qsort.
2087 * disasm.c (compare_lines): Rename to...
2088 (line_is_less_than): ...this, and change to std::sort semantics.
2089 (do_mixed_source_and_assembly_deprecated): Call std::sort instead
2090 of qsort.
2091 * dwarf2-frame.c (qsort_fde_cmp): Rename to...
2092 (fde_is_less_than): ...this, and change to std::sort semantics.
2093 (dwarf2_build_frame_info): Call std::sort instead of qsort.
2094 * mdebugread.c (compare_blocks):
2095 (block_is_less_than): ...this, and change to std::sort semantics.
2096 (sort_blocks): Call std::sort instead of qsort.
2097 * objfiles.c (qsort_cmp): Rename to...
2098 (sort_cmp): ...this, and change to std::sort semantics.
2099 (update_section_map): Call std::sort instead of qsort.
2100 * remote.c (compare_pnums): Remove.
2101 (map_regcache_remote_table): Call std::sort instead of qsort.
2102 * utils.c (compare_positive_ints): Remove.
2103 * utils.h (compare_positive_ints): Remove.
2104 * xcoffread.c (compare_lte): Remove.
2105 (arrange_linetable): Call std::sort instead of qsort.
2106
f71433ee
SDJ		 21072019-10-19 Sergio Durigan Junior <sergiodj@redhat.com>
2108
2109 * symfile.c (init_entry_point_info): Fix typo.
2110 * i386-darwin-tdep.c (darwin_dwarf_signal_frame_p): Fix typo.
2111
85102364
TV		 21122019-10-18 Tom de Vries <tdevries@suse.de>
2113
2114 * aarch64-tdep.c: Fix typos in comments.
2115 * ada-lang.c: Same.
2116 * ada-tasks.c: Same.
2117 * alpha-tdep.c: Same.
2118 * alpha-tdep.h: Same.
2119 * amd64-nat.c: Same.
2120 * amd64-windows-tdep.c: Same.
2121 * arc-tdep.c: Same.
2122 * arc-tdep.h: Same.
2123 * arch-utils.c: Same.
2124 * arm-nbsd-tdep.c: Same.
2125 * arm-tdep.c: Same.
2126 * ax-gdb.c: Same.
2127 * blockframe.c: Same.
2128 * btrace.c: Same.
2129 * c-varobj.c: Same.
2130 * coff-pe-read.c: Same.
2131 * coffread.c: Same.
2132 * cris-tdep.c: Same.
2133 * darwin-nat.c: Same.
2134 * dbxread.c: Same.
2135 * dcache.c: Same.
2136 * disasm.c: Same.
2137 * dtrace-probe.c: Same.
2138 * dwarf-index-write.c: Same.
2139 * dwarf2-frame-tailcall.c: Same.
2140 * dwarf2-frame.c: Same.
2141 * dwarf2read.c: Same.
2142 * eval.c: Same.
2143 * exceptions.c: Same.
2144 * fbsd-tdep.c: Same.
2145 * findvar.c: Same.
2146 * frame.c: Same.
2147 * frv-tdep.c: Same.
2148 * gnu-v3-abi.c: Same.
2149 * go32-nat.c: Same.
2150 * h8300-tdep.c: Same.
2151 * hppa-tdep.c: Same.
2152 * i386-linux-tdep.c: Same.
2153 * i386-tdep.c: Same.
2154 * ia64-libunwind-tdep.c: Same.
2155 * ia64-tdep.c: Same.
2156 * infcmd.c: Same.
2157 * infrun.c: Same.
2158 * linespec.c: Same.
2159 * linux-nat.c: Same.
2160 * linux-thread-db.c: Same.
2161 * machoread.c: Same.
2162 * mdebugread.c: Same.
2163 * mep-tdep.c: Same.
2164 * mn10300-tdep.c: Same.
2165 * namespace.c: Same.
2166 * objfiles.c: Same.
2167 * opencl-lang.c: Same.
2168 * or1k-tdep.c: Same.
2169 * osabi.c: Same.
2170 * ppc-linux-nat.c: Same.
2171 * ppc-linux-tdep.c: Same.
2172 * ppc-sysv-tdep.c: Same.
2173 * printcmd.c: Same.
2174 * procfs.c: Same.
2175 * record-btrace.c: Same.
2176 * record-full.c: Same.
2177 * remote-fileio.c: Same.
2178 * remote.c: Same.
2179 * rs6000-tdep.c: Same.
2180 * s12z-tdep.c: Same.
2181 * score-tdep.c: Same.
2182 * ser-base.c: Same.
2183 * ser-go32.c: Same.
2184 * skip.c: Same.
2185 * sol-thread.c: Same.
2186 * solib-svr4.c: Same.
2187 * solib.c: Same.
2188 * source.c: Same.
2189 * sparc-nat.c: Same.
2190 * sparc-sol2-tdep.c: Same.
2191 * sparc-tdep.c: Same.
2192 * sparc64-tdep.c: Same.
2193 * stabsread.c: Same.
2194 * stack.c: Same.
2195 * symfile.c: Same.
2196 * symtab.c: Same.
2197 * target-descriptions.c: Same.
2198 * target-float.c: Same.
2199 * thread.c: Same.
2200 * utils.c: Same.
2201 * valops.c: Same.
2202 * valprint.c: Same.
2203 * value.c: Same.
2204 * varobj.c: Same.
2205 * windows-nat.c: Same.
2206 * xcoffread.c: Same.
2207 * xstormy16-tdep.c: Same.
2208 * xtensa-tdep.c: Same.
2209
c5adaa19
TT		 22102019-10-17 Tom Tromey <tromey@adacore.com>
2211
2212 * configure: Rebuild.
2213 * configure.ac: Use AC_CONFIG_HEADERS. Create stamp-h there, not
2214 in AC_CONFIG_FILES invocation.
2215 * Makefile.in (Makefile, data-directory/Makefile, stamp-h): Use
2216 new-style config.status invocation.
2217
405feb71
TV		 22182019-10-17 Tom de Vries <tdevries@suse.de>
2219
2220 * arm-nbsd-nat.c: Fix typos in comments.
2221 * arm-tdep.c: Same.
2222 * darwin-nat-info.c: Same.
2223 * dwarf2read.c: Same.
2224 * elfread.c: Same.
2225 * event-top.c: Same.
2226 * findvar.c: Same.
2227 * gdbtypes.c: Same.
2228 * hppa-tdep.c: Same.
2229 * i386-tdep.c: Same.
2230 * jit.c: Same.
2231 * main.c: Same.
2232 * mdebugread.c: Same.
2233 * moxie-tdep.c: Same.
2234 * nto-procfs.c: Same.
2235 * osabi.c: Same.
2236 * ppc-linux-tdep.c: Same.
2237 * remote.c: Same.
2238 * riscv-tdep.c: Same.
2239 * s390-tdep.c: Same.
2240 * sh-tdep.c: Same.
2241 * sparc-linux-tdep.c: Same.
2242 * sparc-nat.c: Same.
2243 * stack.c: Same.
2244 * target-descriptions.c: Same.
2245 * top.c: Same.
2246 * varobj.c: Same.
2247
befcd486
TT		 22482019-10-16 Tom Tromey <tom@tromey.com>
2249
2250 * objfiles.h (struct objfile) <original_name>: Now const.
2251
17bfe554
CB		 22522019-10-16 Christian Biesinger <cbiesinger@google.com>
2253
2254 * gdbsupport/gdb_setjmp.h (SIGSETJMP): Allow passing in the value to
2255 pass on to sigsetjmp's second argument.
2256 * cp-support.c (gdb_demangle): Unblock SIGSEGV if we caught a crash.
2257
950b7495
KS		 22582019-10-16 Keith Seitz <keiths@redhat.com>
2259
2260 PR gdb/23567
2261 * dwarf2read.c (dwarf2_per_objfile::locate_sections): Discard
2262 sections whose size is greater than the file size.
2263
ff371ec9
JW		 22642019-10-16 Jim Wilson <jimw@sifive.com>
2265
2266 * riscv-tdep.c (riscv_gcc_target_options): New.
2267 (riscv_gnu_triplet_regexp): New.
2268 (riscv_gdbarch_init): Call set_gdbarch_gcc_triplet_options and
2269 set_gdbarch_gnu_triplet_regexp.
2270
fec4e896
CB		 22712019-10-16 Christian Biesinger <cbiesinger@google.com>
2272
2273 * Makefile.in: Add xml-builtin.h.
2274 * features/feature_to_c.sh: Add an include for xml-builtin.h
2275 to ensure that the compiler checks that the types match.
2276 * xml-builtin.h: New file.
2277 * xml-support.c (fetch_xml_builtin): Add missing const.
2278 * xml-support.h: Remove declaration of xml_builtins.
2279
d10eccaa
TV		 22802019-10-16 Tom de Vries <tdevries@suse.de>
2281
2282 PR tdep/25096
2283 * amd64-tdep.c (amd64_classify_aggregate_field): Factor out of ...
2284 (amd64_classify_aggregate): ... here.
2285 (amd64_classify_aggregate_field): Handled fiels of nested structs
2286 recursively.
2287
745ff14e
TV		 22882019-10-16 Tom de Vries <tdevries@suse.de>
2289
2290 PR tdep/24104
2291 * amd64-tdep.c (amd64_push_arguments): Handle AMD64_NO_CLASS in loop
2292 that handles 'theclass'.
2293
791b7405
AB		 22942019-10-15 Andrew Burgess <andrew.burgess@embecosm.com>
2295
2296 * linespec.c (decode_digits_ordinary): Update comment.
2297 * make-target-delegates: No longer need to handle VEC case.
2298 * memrange.c (normalize_mem_ranges): Update comment.
2299 * namespace.c (add_using_directive): Update comment.
2300 * objc-lang.c (uniquify_strings): Update comment.
2301 * ppc-linux-nat.c (struct thread_points): Update comment.
2302 * probe.h (find_probes_in_objfile): Update comment.
2303 * target.h (enum flash_preserve_mode): Update comment.
2304 * varobj.c (varobj_restrict_range): Update comment.
2305 * varobj.h (varobj_list_children): Update comment.
2306
0dc32745
AB		 23072019-10-15 Andrew Burgess <andrew.burgess@embecosm.com>
2308
2309 * Makefile.in: Remove references to vec.h and vec.c.
2310 * aarch64-tdep.c: No longer include vec.h.
2311 * ada-lang.c: Likewise.
2312 * ada-lang.h: Likewise.
2313 * arm-tdep.c: Likewise.
2314 * ax.h: Likewise.
2315 * breakpoint.h: Likewise.
2316 * charset.c: Likewise.
2317 * cp-support.h: Likewise.
2318 * dtrace-probe.c: Likewise.
2319 * dwarf2read.c: Likewise.
2320 * extension.h: Likewise.
2321 * gdb_bfd.c: Likewise.
2322 * gdbsupport/gdb_vecs.h: Likewise.
2323 * gdbsupport/vec.c: Remove.
2324 * gdbsupport/vec.h: Remove.
2325 * gdbthread.h: Likewise.
2326 * guile/scm-type.c: Likewise.
2327 * inline-frame.c: Likewise.
2328 * machoread.c: Likewise.
2329 * memattr.c: Likewise.
2330 * memrange.h: Likewise.
2331 * namespace.h: Likewise.
2332 * nat/linux-btrace.h: Likewise.
2333 * osdata.c: Likewise.
2334 * parser-defs.h: Likewise.
2335 * progspace.h: Likewise.
2336 * python/py-type.c: Likewise.
2337 * record-btrace.c: Likewise.
2338 * rust-exp.y: Likewise.
2339 * solib-target.c: Likewise.
2340 * stap-probe.c: Likewise.
2341 * target-descriptions.c: Likewise.
2342 * target-memory.c: Likewise.
2343 * target.h: Likewise.
2344 * varobj.c: Likewise.
2345 * varobj.h: Likewise.
2346 * xml-support.h: Likewise.
2347
ae640021
AB		 23482019-10-15 Andrew Burgess <andrew.burgess@embecosm.com>
2349
2350 * gdb/dwarf2read.c (dwarf2_per_objfile::~dwarf2_per_objfile):
2351 Update for new std::vector based implementation.
2352 (process_psymtab_comp_unit_reader): Likewise.
2353 (scan_partial_symbols): Likewise.
2354 (recursively_compute_inclusions): Likewise.
2355 (compute_compunit_symtab_includes): Likewise.
2356 (process_imported_unit_die): Likewise.
2357 (queue_and_load_dwo_tu): Likewise.
2358 (follow_die_sig_1): Likewise.
2359 * gdb/dwarf2read.h: Remove DEF_VEC_P.
2360 (typedef dwarf2_per_cu_ptr): Remove.
2361 (struct dwarf2_per_cu_data) <imported_symtabs_empty>: New
2362 function.
2363 (struct dwarf2_per_cu_data) <imported_symtabs_push>: New function.
2364 (struct dwarf2_per_cu_data) <imported_symtabs_size>: New function.
2365 (struct dwarf2_per_cu_data) <imported_symtabs_free>: New function.
2366 (struct dwarf2_per_cu_data) <imported_symtabs>: Change to
2367 std::vector.
2368
55dfc88f
TT		 23692019-10-15 Tom Tromey <tromey@adacore.com>
2370
2371 * windows-nat.c (windows_nat_target::resume): Use %x when logging
2372 TID.
2373
96b49c5e
TT		 23742019-10-15 Tom Tromey <tromey@adacore.com>
2375
2376 * windows-nat.c (windows_nat_target::fetch_registers)
2377 (windows_nat_target::store_registers): Rename "pid" to "tid".
2378
953cff56
TT		 23792019-10-15 Tom Tromey <tromey@adacore.com>
2380
2381 * gdbarch.h, gdbarch.c: Rebuild.
2382 * gdbarch.sh (gcc_target_options): Change return type to
2383 std::string.
2384 * compile/compile.c (get_args): Update.
2385 * nios2-tdep.c (nios2_gcc_target_options): Return std::string.
2386 * arm-linux-tdep.c (arm_linux_gcc_target_options): Return
2387 std::string.
2388 * aarch64-linux-tdep.c (aarch64_linux_gcc_target_options): Return
2389 std::string.
2390 * arch-utils.c (default_gcc_target_options): Return std::string.
2391 * arch-utils.h (default_gcc_target_options): Return std::string.
2392 * s390-tdep.c (s390_gcc_target_options): Return std::string.
2393
81e6b8eb
CB		 23942019-10-15 Christian Biesinger <cbiesinger@google.com>
2395
2396 * breakpoint.c (breakpoint_chain): Make static.
2397 * tui/tui-winsource.c: Call iterate_over_breakpoints instead
2398 of accessing breakpoint_chain.
2399
95da600f
CB		 24002019-10-15 Christian Biesinger <cbiesinger@google.com>
2401
2402 * breakpoint.c (iterate_over_breakpoints): Change function pointer
2403 to a gdb::function_view and return value to bool.
2404 * breakpoint.h (iterate_over_breakpoints): Likewise.
2405 * dummy-frame.c (pop_dummy_frame_bpt): Update.
2406 (pop_dummy_frame): Update.
2407 * guile/scm-breakpoint.c (bpscm_build_bp_list): Update.
2408 (gdbscm_breakpoints): Update.
2409 * python/py-breakpoint.c (build_bp_list): Update.
2410 (gdbpy_breakpoints): Update.
2411 * python/py-finishbreakpoint.c (bpfinishpy_detect_out_scope_cb):
2412 Update.
2413 (bpfinishpy_handle_stop): Update.
2414 (bpfinishpy_handle_exit): Update.
2415 * solib-svr4.c (svr4_update_solib_event_breakpoint): Update.
2416 (svr4_update_solib_event_breakpoints): Update.
2417
ba18312d
AA		 24182019-10-15 Andreas Arnez <arnez@linux.ibm.com>
2419
2420 * s390-tdep.c (s390_effective_inner_type): Ignore static fields
2421 when unwrapping single-field structs.
2422
6acc1a0b
SM		 24232019-10-14 Simon Marchi <simon.marchi@polymtl.ca>
2424
2425 * dwarf2read.c: Remove includes.
2426
284782de
SM		 24272019-10-13 Simon Marchi <simon.marchi@polymtl.ca>
2428
2429 * ui-out.c (ui_out::call_do_message): Silence
2430 -Wformat-nonliteral warning.
2431
073bbbb0
SM		 24322019-10-12 Simon Marchi <simon.marchi@polymtl.ca>
2433
2434 * breakpoint.c: Remove some includes: continuations.h, skip.h,
2435 mi/mi-main.h, readline/readline.h, readline/history.h. Add
2436 include: readline/tilde.h.
2437
7b9a15e1
CB		 24382019-10-12 Christian Biesinger <cbiesinger@google.com>
2439
2440 * remote.c (remote_target::get_trace_status): Remove declaration of
2441 trace_regblock_size.
2442
cc8dee1f
CB		 24432019-10-12 Christian Biesinger <cbiesinger@google.com>
2444
2445 * cli/cli-cmds.c (max_user_call_depth): Move comment to header.
2446 (show_user): Remove declaration of cmdlist.
2447 * cli/cli-cmds.h (max_user_call_depth): Declare.
2448 * cli/cli-script.c (execute_user_command): Remove declaration
2449 of max_user_call_depth.
2450
a83d4ef6
JW		 24512019-10-11 Jim Wilson <jimw@sifive.com>
2452
5f93c5a6
JW		 2453 * gdbsupport/print-utils.h (pulongest): Fix comment.
2454 (plongest): Likewise.
2455 (phex): Add missing comment, mention leading zeros.
2456 (phex_nz): Add mention of no leading zeros to comment.
2457
a83d4ef6
JW		 2458 * riscv-tdep.c (riscv_push_dummy_code): Change %lld to %s and use
2459 plongest instead of unsigned long long cast.
2460
26344e0c
CB		 24612019-10-10 Christian Biesinger <cbiesinger@google.com>
2462
2463 * main.c (captured_main_1): Include gdbtk.h and remove declarations
2464 for external_editor_command and gdbtk_test.
2465
c2c440a9
CB		 24662019-10-10 Christian Biesinger <cbiesinger@google.com>
2467
2468 * mi/mi-cmd-var.c (varobjdebug): Remove declaration.
2469 * varobj.c (varobjdebug): Move comment to...
2470 * varobj.h (varobjdebug): ...here, and declare.
2471
a31bff9d
TT		 24722019-10-09 Tom Tromey <tom@tromey.com>
2473
2474 * tui/tui-regs.c (tui_data_window::show_registers): Don't call
2475 erase_data_content.
2476
7523da63
TT		 24772019-10-09 Tom Tromey <tom@tromey.com>
2478
2479 * tui/tui-wingeneral.h (tui_delete_win): Don't declare.
2480 * tui/tui-stack.c (tui_locator_window::rerender): Update.
2481 * tui/tui-command.c (tui_cmd_window::resize)
2482 (tui_refresh_cmd_win): Update.
2483 * tui/tui-win.c (tui_resize_all, tui_set_focus_command): Update.
2484 * tui/tui.c (tui_rl_other_window, tui_enable): Update.
2485 * tui/tui-data.c (~tui_gen_win_info): Remove.
2486 * tui/tui-layout.c (tui_gen_win_info::resize): Update.
2487 * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
2488 (tui_redisplay_readline, tui_mld_flush)
2489 (tui_mld_erase_entire_line, tui_mld_getc, tui_getc): Update.
2490 * tui/tui-regs.c (tui_data_window::delete_data_content_windows)
2491 (tui_data_window::erase_data_content)
2492 (tui_data_item_window::rerender)
2493 (tui_data_item_window::refresh_window): Update.
2494 * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window)
2495 (box_win, tui_gen_win_info::make_window)
2496 (tui_gen_win_info::make_visible): Update.
2497 (tui_delete_win): Remove.
2498 * tui/tui-winsource.c
2499 (tui_source_window_base::do_erase_source_content): Update.
2500 (tui_show_source_line, tui_source_window_base::update_tab_width)
2501 (tui_source_window_base::update_exec_info): Update.
2502 * tui/tui-data.h (struct curses_deleter): New.
2503 (struct tui_gen_win_info) <handle>: Now a unique_ptr.
2504 (struct tui_gen_win_info) <~tui_gen_win_info>: Define.
2505
a7798e7f
TT		 25062019-10-09 Tom Tromey <tom@tromey.com>
2507
2508 * tui/tui-wingeneral.h (struct tui_gen_win_info): Don't declare.
2509
5c45899e
TT		 25102019-10-09 Tom Tromey <tom@tromey.com>
2511
2512 * tui/tui-data.c (tui_win_is_auxiliary): Remove.
2513 * tui/tui-data.h (tui_win_is_auxiliary): Don't declare.
2514
6d7fd9aa
TT		 25152019-10-09 Tom Tromey <tom@tromey.com>
2516
2517 * tui/tui-disasm.c (tui_get_low_disassembly_address): Compute
2518 window height directly.
2519 * tui/tui-layout.h (tui_default_win_viewport_height): Don't
2520 declare.
2521 * tui/tui-layout.c (tui_default_win_height): Remove.
2522 (tui_default_win_viewport_height): Remove.
2523
d2dd1084
TT		 25242019-10-09 Tom Tromey <tom@tromey.com>
2525
2526 * tui/tui.h: Remove comments.
2527
cff32449
TV		 25282019-10-09 Tom de Vries <tdevries@suse.de>
2529
2530 * python/lib/gdb/printer/bound_registers.py: Use
2531 '^builtin_type_bound128' as regexp argument for
2532 add_builtin_pretty_printer.
2533
6a25e8a2
CB		 25342019-10-09 Christian Biesinger <cbiesinger@google.com>
2535
2536 * guile/guile.c (guile_extension_script_ops): Remove forward
2537 declaration and mark as static.
2538 (guile_script_ops): Likewise.
2539 (extension_language_guile): Move further down in the file so
2540 it can reference the definitions for guile_{extension_,}script_ops.
2541
6d9d6da4
AA		 25422019-10-09 Andreas Arnez <arnez@linux.ibm.com>
2543
2544 * s390-tdep.c (390_process_record): Handle new arch13 instructions
2545 except SORTL, DFLTCC, and KDSA.
2546
3abea05d
TT		 25472019-10-08 Tom Tromey <tromey@adacore.com>
2548
2549 * windows-nat.c (struct windows_thread_info_struct) <sf>: Remove.
2550 (struct safe_symbol_file_add_args): Remove.
2551
dde996e2
TT		 25522019-10-08 Tom Tromey <tromey@adacore.com>
2553
2554 * windows-nat.c: Don't include buildsym-legacy.h.
2555
cd6fdaa1
TT		 25562019-10-08 Tom Tromey <tromey@adacore.com>
2557
2558 * contrib/ari/gdb_ari.sh (%p): Allow gdb-specific %p extensions.
2559
79bb1944
CB		 25602019-10-08 Christian Biesinger <cbiesinger@google.com>
2561
2562 * gdbtypes.c (overload_debug): Move comment to header.
2563 * gdbtypes.h (overload_debug): Declare.
2564 * valops.c: Remove declaration of overload_debug, instead
2565 include gdbtypes.h.
2566
34916edc
CB		 25672019-10-08 Christian Biesinger <cbiesinger@google.com>
2568
2569 * language.c (show_language_command): Pass lang_frame_mismatch_warn
2570 through _().
2571 (lang_frame_mismatch_warn): Make const, mark with N_(), and
2572 move comment...
2573 * language.h (lang_frame_mismatch_warn): ... here. Also add
2574 declaration.
2575 * top.c (lang_frame_mismatch_warn): Remove declaration.
2576 (check_frame_language_change): Pass lang_frame_mismatch_warn
2577 through _().
2578
bad5c026
CB		 25792019-10-07 Christian Biesinger <cbiesinger@google.com>
2580
2581 * c-lang.h (vtbl_ptr_name): Declare.
2582 * cp-valprint.c (vtbl_ptr_name): Remove "extern" now that we get
2583 it from the header.
2584 * stabsread.c (define_symbol): Remove declaration of vtbl_ptr_name.
2585
51f1fdc3
CB		 25862019-10-07 Christian Biesinger <cbiesinger@google.com>
2587
2588 * charset.c (your_gdb_wchar_t_is_bogus): Replace with a
2589 gdb_static_assert.
2590
30d1f018
WP		 25912019-10-07 Weimin Pan <weimin.pan@oracle.com>
2592
606813d5
WP		 2593 * ../Makefile.def (dependencies): Add all-libctf to all-gdb
2594 * ../Makefile.in: Add "all-gdb: maybe-all-libctf"
30d1f018
WP		 2595 * ctfread.c: New file.
2596 * ctfread.h: New file.
2597 * elfread.c: Include ctfread.h.
2598 (struct elfinfo text_p): New member ctfsect.
2599 (elf_locate_sections): Mark CTF section.
2600 (elf_symfile_read): Call elfctf_build_psymtabs.
2601 * Makefile.in (LIBCTF): Add.
2602 (CLIBS): Use it.
2603 (CDEPS): Likewise.
2604 (DIST): Add ctfread.c.
606813d5
WP		 2605
26062019-10-07 Andrew Burgess <andrew.burgess@embecosm.com>
2607
2608 * ctfread.c (struct nextfield): Renamed to ...
2609 (struct ctf_nextfield): ... this.
2610 (struct field_info): Renamed to ...
2611 (strut ctf_field_info): ... this.
2612 (attach_fields_to_type): Update for renamed structures.
2613 (ctf_add_member_cb): Likewise.
2614 (ctf_add_enum_member_cb): Likewise.
2615 (process_struct_members): Likewise.
2616 (process_enum_type): Likewise.
30d1f018 2617
518fe38c
WP		 26182019-10-07 Weimin Pan <weimin.pan@oracle.com>
2619
2620 * tracectf.h: Rename, was ctf.h.
2621 * tracectf.c: Rename, was ctf.c, replace ctf.h with tracectf.h.
2622 * tracefile.c: Likewise.
2623 * tracepoint.c: Remove unused include ctf.h.
2624 * mi/mi-main.c: Likewise.
2625 * Makefile.in Replace ctf.c with tracectf.c.
2626
225f296a
JB		 26272019-10-06 Joel Brobecker <brobecker@adacore.com>
2628
2629 * version.in: Change version number to "9.0.50.DATE-git".
2630
77c2dba3
TT		 26312019-10-03 Tom Tromey <tom@tromey.com>
2632
2633 PR rust/24976:
2634 * dwarf2read.c (quirk_rust_enum): Handle single-element unions.
2635
179aed7f
AB		 26362019-10-03 Andrew Burgess <andrew.burgess@embecosm.com>
2637
2638 * f-lang.c (f_language_defn): Use cp_get_symbol_name_matcher and
2639 cp_search_name_hash.
2640 * NEWS: Add entry about nested function support.
2641
0a4b0913
AB		 26422019-10-03 Bernhard Heckel <bernhard.heckel@intel.com>
2643 Andrew Burgess <andrew.burgess@embecosm.com>
2644
2645 * cp-namespace.c (cp_search_static_and_baseclasses): Only search
2646 for nested static variables when searchin VAR_DOMAIN.
2647 * dwarf2read.c (add_partial_symbol): Add nested subroutines to the
2648 global scope, update comment.
2649 (add_partial_subprogram): Call add_partial_subprogram recursively
2650 for nested subroutines when processinng Fortran.
2651 (load_partial_dies): Process the child entities of a subprogram
2652 when processing Fortran.
2653 (partial_die_parent_scope): Handle building scope
2654 for Fortran nested functions.
2655 (process_die): Record that nested functions have a scope.
2656 (new_symbol): Always record Fortran subprograms on the global
2657 symbol list.
2658 (determine_prefix): How to build the prefix for Fortran
2659 subprograms.
2660
d8c06f22
AB		 26612019-10-03 Andrew Burgess <andrew.burgess@embecosm.com>
2662
2663 * linux-nat.c (linux_nat_filter_event): Don't ignore SIGSTOP if we
2664 have just sent the thread a SIGSTOP and are waiting for it to
2665 arrive.
2666
a8b3b8e9
AB		 26672019-10-03 Andrew Burgess <andrew.burgess@embecosm.com>
2668
2669 * btrace.c (btrace_add_pc): Remove whitespace before the template
2670 parameter in 'std::vector <...>'.
2671 (parse_xml_btrace_block): Likewise.
2672 (btrace_maint_decode_pt): Likewise.
2673 (btrace_maint_update_packets): Likewise.
2674 (btrace_maint_print_packets): Likewise.
2675 * btrace.h (struct btrace_maint_info): Likewise.
2676 * dwarf2read.c (struct type_unit_group): Likewise.
2677 (build_type_psymtabs_reader): Likewise.
2678 * gdbsupport/btrace-common.c (btrace_data_append): Likewise.
2679 * gdbsupport/btrace-common.h (struct btrace_data_bts): Likewise.
2680 * nat/linux-btrace.c (perf_event_read_bts): Likewise.
2681
4d825eab
TV		 26822019-10-03 Tom de Vries <tdevries@suse.de>
2683
2684 * cli/cli-style.c (_initialize_cli_style): Adding a '.' at the end of
2685 the first line of the help text for set/show style metadata.
2686
80fd2826
TT		 26872019-10-02 Tom Tromey <tromey@adacore.com>
2688
2689 * Makefile.in (COMMON_SFILES): Add common-inferior.c.
2690 * gdbsupport/common-inferior.c: New file.
2691 * infcmd.c (startup_with_shell): Don't define.
2692 * nat/fork-inferior.h (startup_with_shell): Don't declare.
2693 * gdbsupport/common-inferior.h (startup_with_shell): Declare.
2694 * inferior.h (startup_with_shell): Don't declare.
2695
70054538
CB		 26962019-10-02 Christian Biesinger <cbiesinger@google.com>
2697
2698 * gdbsupport/gdb_assert.h: Include errors.h.
2699 * gdbsupport/gdb_string_view.h: Include gdb_assert.h.
2700
37f6a7f4
TT		 27012019-10-02 Tom Tromey <tromey@adacore.com>
2702
2703 * NEWS: Add $_ada_exception entry.
2704 * ada-lang.c (struct ada_catchpoint): Add constructor.
2705 <m_kind>: New member.
2706 (allocate_location_exception, re_set_exception): Remove
2707 "ex" parameter.
2708 (should_stop_exception): Compute $_ada_exception.
2709 (check_status_exception, print_it_exception)
2710 (print_one_exception, print_mention_exception): Remove
2711 "ex" parameter.
2712 (allocate_location_catch_exception, re_set_catch_exception)
2713 (check_status_exception, print_it_catch_exception)
2714 (print_one_catch_exception, print_mention_catch_exception)
2715 (print_recreate_catch_exception)
2716 (allocate_location_catch_exception_unhandled)
2717 (re_set_catch_exception_unhandled)
2718 (check_status_exception, print_it_catch_exception_unhandled)
2719 (print_one_catch_exception_unhandled)
2720 (print_mention_catch_exception_unhandled)
2721 (print_recreate_catch_exception_unhandled)
2722 (allocate_location_catch_assert, re_set_catch_assert)
2723 (check_status_assert, print_it_catch_assert)
2724 (print_one_catch_assert, print_mention_catch_assert)
2725 (print_recreate_catch_assert)
2726 (allocate_location_catch_handlers, re_set_catch_handlers)
2727 (check_status_handlers, print_it_catch_handlers)
2728 (print_one_catch_handlers, print_mention_catch_handlers)
2729 (print_recreate_catch_handlers): Remove.
2730 (create_ada_exception_catchpoint): Update.
2731 (initialize_ada_catchpoint_ops): Update.
2732
fccf9de1
TT		 27332019-10-02 Tom Tromey <tromey@adacore.com>
2734
2735 * ada-lang.c (ada_lookup_simple_minsyms): Remove.
2736 (create_excep_cond_exprs): Simplify exception string computation.
2737 (ada_exception_catchpoint_cond_string): Likewise.
2738
4b610737
TT		 27392019-10-02 Tom Tromey <tromey@adacore.com>
2740
2741 * symmisc.c (dump_msymbols): Don't use MSYMBOL_VALUE_ADDRESS.
2742 * ada-lang.c (lesseq_defined_than): Handle
2743 LOC_STATIC.
2744 * dwarf2read.c (dwarf2_per_objfile): Add can_copy
2745 parameter.
2746 (dwarf2_has_info): Likewise.
2747 (new_symbol): Set maybe_copied on symbol when
2748 appropriate.
2749 * dwarf2read.h (dwarf2_per_objfile): Add can_copy
2750 parameter.
2751 <can_copy>: New member.
2752 * elfread.c (record_minimal_symbol): Set maybe_copied
2753 on symbol when appropriate.
2754 (elf_symfile_read): Update call to dwarf2_has_info.
2755 * minsyms.c (lookup_minimal_symbol_linkage): New
2756 function.
2757 * minsyms.h (lookup_minimal_symbol_linkage): Declare.
2758 * symtab.c (get_symbol_address, get_msymbol_address):
2759 New functions.
2760 * symtab.h (get_symbol_address, get_msymbol_address):
2761 Declare.
2762 (SYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_ADDRESS): Handle
2763 maybe_copied.
2764 (struct symbol, struct minimal_symbol) <maybe_copied>:
2765 New member.
2766
1dd58850
TT		 27672019-10-02 Tom Tromey <tromey@adacore.com>
2768
2769 * source.c (struct current_source_location): New.
2770 (current_source_key): New global.
2771 (current_source_symtab, current_source_line)
2772 (current_source_pspace): Remove.
2773 (get_source_location): New function.
2774 (get_current_source_symtab_and_line)
2775 (set_default_source_symtab_and_line)
2776 (set_current_source_symtab_and_line)
2777 (clear_current_source_symtab_and_line, select_source_symtab)
2778 (info_source_command, print_source_lines_base)
2779 (info_line_command, search_command_helper, _initialize_source):
2780 Update.
2781
5c281dbb
TT		 27822019-10-02 Tom Tromey <tromey@adacore.com>
2783
2784 * source.c (select_source_symtab): Don't call
2785 decode_line_with_current_source.
2786
d3d32391
AB		 27872019-10-02 Andrew Burgess <andrew.burgess@embecosm.com>
2788
2789 * symtab.c (lookup_global_symbol): Search global block.
2790
38583298
TT		 27912019-10-02 Tom Tromey <tromey@adacore.com>
2792
2793 * coffread.c (process_coff_symbol): Update.
2794 * dwarf2read.c (var_decode_location, new_symbol): Update.
2795 * mdebugread.c (parse_symbol): Update.
2796 * objfiles.c (relocate_one_symbol): Update.
2797 * stabsread.c (define_symbol, fix_common_block)
2798 (scan_file_globals): Update.
2799 * symtab.h (SYMBOL_VALUE_ADDRESS): Expand to an rvalue.
2800 (SET_SYMBOL_VALUE_ADDRESS): New macro.
2801 * xcoffread.c (process_xcoff_symbol): Update.
2802
9344c18f
AA		 28032019-10-02 Andreas Arnez <arnez@linux.ibm.com>
2804
2805 * MAINTAINERS: Update my email address.
2806
df07e2c7
AB		 28072019-10-02 Andrew Burgess <andrew.burgess@embecosm.com>
2808
2809 * dwarf2read.c (struct type_unit_group) <tus>: Convert to
2810 std::vector.
2811 (build_type_psymtabs_reader): Update for std::vector.
2812 (build_type_psymtab_dependencies): Likewise.
2813 * dwarf2read.h: Remove use of DEF_VEC_P.
2814 (typedef sig_type_ptr): Delete.
2815
554ac434
AB		 28162019-10-02 Andrew Burgess <andrew.burgess@embecosm.com>
2817
2818 * btrace.c (btrace_maint_clear): Update to handle change from VEC
2819 to std::vector.
2820 (btrace_maint_decode_pt): Likewise, and move allocation of the
2821 vector outside of the loop.
2822 (btrace_maint_update_packets): Update to handle change from VEC to
2823 std::vector.
2824 (btrace_maint_print_packets): Likewise.
2825 (maint_info_btrace_cmd): Likewise.
2826 * btrace.h: Remove use of DEF_VEC_O.
2827 (typedef btrace_pt_packet_s): Delete.
2828 (struct btrace_maint_info) <packets>: Change fromm VEC to
2829 std::vector.
2830 * gdbsupport/btrace-common.h: Remove 'vec.h' include.
2831
46f29a9a
AB		 28322019-10-02 Andrew Burgess <andrew.burgess@embecosm.com>
2833
2834 * btrace.c (btrace_compute_ftrace_bts): Update for std::vector,
2835 make accesses into the vector constant references.
2836 (btrace_add_pc): Update for std::vector.
2837 (btrace_stitch_bts): Likewise.
2838 (parse_xml_btrace_block): Likewise.
2839 (btrace_maint_update_packets): Likewise.
2840 (btrace_maint_print_packets): Likewise.
2841 (maint_info_btrace_cmd): Likewise.
2842 * gdbsupport/btrace-common.c (btrace_data::fini): Update for
2843 std::vector.
2844 (btrace_data::empty): Likewise.
2845 (btrace_data_append): Likewise.
2846 * gdbsupport/btrace-common.h: Remove use of DEF_VEC_O.
2847 (typedef btrace_block_s): Delete.
2848 (struct btrace_block): Add constructor.
2849 (struct btrace_data_bts) <blocks>: Change to std::vector.
2850 * nat/linux-btrace.c (perf_event_read_bts): Update for
2851 std::vector.
2852 (linux_read_bts): Likewise.
2853
d770d56f
TT		 28542019-10-01 Tom Tromey <tom@tromey.com>
2855
2856 * cli/cli-logging.c (show_logging_filename): Use styled_string.
2857
9d636d67
TT		 28582019-10-01 Tom Tromey <tom@tromey.com>
2859
2860 * stack.c (print_frame, info_frame_command_core): Use
2861 styled_string.
2862 * linux-thread-db.c (try_thread_db_load_1)
2863 (try_thread_db_load_from_pdir_1): Use styled_string.
2864 * auto-load.c (file_is_auto_load_safe, execute_script_contents)
2865 (auto_load_section_scripts, info_auto_load_local_gdbinit)
2866 (maybe_print_unsupported_script_warning)
2867 (maybe_print_script_not_found_warning): Use styled_string.
2868 * ada-lang.c (user_select_syms): Use styled_string.
2869
7f6aba03
TT		 28702019-10-01 Tom Tromey <tom@tromey.com>
2871
2872 * p-lang.c (pascal_printstr): Use metadata style.
2873 * value.c (show_convenience): Use metadata style.
2874 * valprint.c (valprint_check_validity, val_print_optimized_out)
2875 (val_print_not_saved, val_print_unavailable)
2876 (val_print_invalid_address, generic_val_print, val_print)
2877 (value_check_printable, val_print_array_elements): Use metadata
2878 style.
2879 * ui-out.h (class ui_out) <field_fmt>: New overload.
2880 <do_field_fmt>: Add style parameter.
2881 * ui-out.c (ui_out::field_fmt): New overload.
2882 * typeprint.c (type_print_unknown_return_type)
2883 (val_print_not_allocated, val_print_not_associated): Use metadata
2884 style.
2885 * tui/tui-out.h (class tui_ui_out) <do_field_fmt>: Add style
2886 parameter.
2887 * tui/tui-out.c (tui_ui_out::do_field_fmt): Update.
2888 * tracepoint.c (tvariables_info_1): Use metadata style.
2889 * stack.c (print_frame_arg, print_frame_info, print_frame)
2890 (info_frame_command_core): Use metadata style.
2891 * skip.c (info_skip_command): Use metadata style.
2892 * rust-lang.c (rust_print_enum): Use metadata style.
2893 * python/py-prettyprint.c (print_stack_unless_memory_error): Use
2894 metadata style.
2895 * python/py-framefilter.c (py_print_single_arg): Use metadata
2896 style.
2897 * printcmd.c (do_one_display, print_variable_and_value): Use
2898 metadata style.
2899 * p-valprint.c (pascal_val_print)
2900 (pascal_object_print_value_fields): Use metadata style.
2901 * p-typeprint.c (pascal_type_print_base): Use metadata style.
2902 * mi/mi-out.h (class mi_ui_out) <do_field_fmt>: Add style
2903 parameter.
2904 * mi/mi-out.c (mi_ui_out::do_field_fmt): Update.
2905 * m2-valprint.c (m2_print_long_set): Use metadata style.
2906 * m2-typeprint.c (m2_print_type): Use metadata style.
2907 * infcmd.c (print_return_value_1): Use metadata style.
2908 * gnu-v3-abi.c (print_one_vtable): Use metadata style.
2909 * f-valprint.c (info_common_command_for_block): Use metadata
2910 style.
2911 * f-typeprint.c (f_type_print_base): Use metadata style.
2912 * expprint.c (print_subexp_standard): Use metadata style.
2913 * cp-valprint.c (cp_print_value_fields): Use metadata style.
2914 * cli/cli-style.h (class cli_style_option): Add constructor.
2915 (metadata_style): Declare.
2916 * cli/cli-style.c (metadata_style): New global.
2917 (_initialize_cli_style): Register metadata style.
2918 * cli-out.h (class cli_ui_out) <do_field_fmt>: Add style
2919 parameter.
2920 * cli-out.c (cli_ui_out::do_field_fmt): Update.
2921 * c-typeprint.c (c_type_print_base_struct_union)
2922 (c_type_print_base_1): Use metadata style.
2923 * breakpoint.c (watchpoint_value_print)
2924 (print_one_breakpoint_location): Use metadata style.
2925 * break-catch-syscall.c (print_one_catch_syscall): Use metadata
2926 style.
2927 * break-catch-sig.c (signal_catchpoint_print_one): Use metadata
2928 style.
2929 * ada-valprint.c (val_print_packed_array_elements, printstr)
2930 (print_field_values, ada_val_print_ref, ada_val_print): Use
2931 metadata style.
2932 * ada-typeprint.c (print_array_type, ada_print_type): Use metadata
2933 style.
2934 * ada-tasks.c (print_ada_task_info, info_task): Use metadata
2935 style.
2936 * ada-lang.c (user_select_syms): Use metadata style.
2937
14309bb6
TT		 29382019-10-01 Tom Tromey <tom@tromey.com>
2939
2940 * cli/cli-cmds.c (pwd_command): Style output.
2941
6a831f06
PA		 29422019-10-01 Pedro Alves <palves@redhat.com>
2943 Tom Tromey <tom@tromey.com>
2944
2945 * symtab.c (print_symbol_info): Use %ps.
2946 (print_msymbol_info): Use %ps.
2947 * symfile.c (symbol_file_add_with_addrs): Use %ps.
2948 * printcmd.c (print_variable_and_value): Use %ps.
2949 * macrocmd.c (show_pp_source_pos): Use %ps.
2950 * infrun.c (print_exited_reason): Use ui_out::message.
2951 * breakpoint.c (watchpoint_check, print_one_breakpoint_location)
2952 (describe_other_breakpoints): Use ui_out::message and new
2953 formats.
2954 (say_where): Use new formats.
2955 (bkpt_print_it, tracepoint_print_one_detail): Use ui_out::message
2956 and new formats.
2957
2a3c1174
PA		 29582019-10-01 Pedro Alves <palves@redhat.com>
2959 Tom Tromey <tom@tromey.com>
2960
2961 * unittests/format_pieces-selftests.c: Add gdb_format parameter.
2962 (test_gdb_formats): New function.
2963 (run_tests): Call it.
2964 (test_format_specifier): Update.
2965 * utils.h (fputs_filtered): Update comment.
2966 (vfprintf_styled, vfprintf_styled_no_gdbfmt)
2967 (fputs_styled_unfiltered): Declare.
2968 * utils.c (fputs_styled_unfiltered): New function.
2969 (vfprintf_maybe_filtered): Add gdbfmt parameter.
2970 (vfprintf_filtered): Update.
2971 (vfprintf_unfiltered, vprintf_filtered): Update.
2972 (vfprintf_styled, vfprintf_styled_no_gdbfmt): New functions.
2973 * ui-out.h (enum ui_out_flag) <unfiltered_output,
2974 disallow_ui_out_field>: New constants.
2975 (enum class field_kind): New.
2976 (struct base_field_s, struct signed_field_s): New.
2977 (signed_field): New function.
2978 (struct string_field_s): New.
2979 (string_field): New function.
2980 (struct styled_string_s): New.
2981 (styled_string): New function.
2982 (class ui_out) <message>: Add comment.
2983 <vmessage, call_do_message>: New methods.
2984 <do_message>: Add style parameter.
2985 * ui-out.c (ui_out::call_do_message, ui_out::vmessage): New
2986 methods.
2987 (ui_out::message): Rewrite.
2988 * mi/mi-out.h (class mi_ui_out) <do_message>: Add style
2989 parameter.
2990 * mi/mi-out.c (mi_ui_out::do_message): Add style parameter.
2991 * gdbsupport/format.h (class format_pieces) <format_pieces>: Add
2992 gdb_extensions parameter.
2993 (class format_piece): Add parameter to constructor.
2994 (n_int_args): New field.
2995 * gdbsupport/format.c (format_pieces::format_pieces): Add
2996 gdb_extensions parameter. Handle '*'.
2997 * cli-out.h (class cli_ui_out) <do_message>: Add style parameter.
2998 * cli-out.c (cli_ui_out::do_message): Add style parameter. Call
2999 vfprintf_styled_no_gdbfmt.
3000 (cli_ui_out::do_field_string, cli_ui_out::do_spaces)
3001 (cli_ui_out::do_text, cli_ui_out::field_separator): Allow
3002 unfiltered output.
3003 * ui-style.h (struct ui_file_style) <ptr>: New method.
3004
0dfe5bfb
TT		 30052019-10-01 Tom Tromey <tom@tromey.com>
3006
3007 * unittests/format_pieces-selftests.c: Update. Add final format.
3008 * gdbsupport/format.c (format_pieces::format_pieces): Don't add
3009 empty literal pieces.
3010
e43b10e1
TT		 30112019-10-01 Tom Tromey <tom@tromey.com>
3012
3013 * ui-out.h (enum class ui_out_style_kind): Remove.
3014 (class ui_out) <field_string, field_stsream, do_field_string>:
3015 Change type of "style".
3016 * ui-out.c (ui_out::field_core_addr, ui_out::field_stream)
3017 (ui_out::field_string): Update.
3018 * tui/tui-out.h (class tui_ui_out) <do_field_string>: Change type
3019 of "style".
3020 * tui/tui-out.c (tui_ui_out::do_field_string): Update.
3021 * tracepoint.c (print_one_static_tracepoint_marker): Update.
3022 * stack.c (print_frame_arg, print_frame_info, print_frame):
3023 Update.
3024 * source.c (print_source_lines_base): Update.
3025 * solib.c (info_sharedlibrary_command): Update.
3026 * skip.c (info_skip_command): Update.
3027 * record-btrace.c (btrace_call_history_src_line)
3028 (btrace_call_history): Update.
3029 * python/py-framefilter.c (py_print_frame): Update.
3030 * mi/mi-out.h (class mi_ui_out) <do_field_string>: Change type of
3031 "style".
3032 * mi/mi-out.c (mi_ui_out::do_table_header)
3033 (mi_ui_out::do_field_signed, mi_ui_out::do_field_unsigned)
3034 (mi_ui_out::do_field_string): Update.
3035 * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
3036 Update.
3037 * cli-out.h (class cli_ui_out) <do_field_string>: Change type of
3038 "style".
3039 * cli-out.c (cli_ui_out::do_table_header)
3040 (cli_ui_out::do_field_signed, cli_ui_out::do_field_unsigned)
3041 (cli_ui_out::do_field_skip, cli_ui_out::do_field_string)
3042 (cli_ui_out::do_field_fmt): Update.
3043 * breakpoint.c (print_breakpoint_location): Update.
3044 (update_static_tracepoint): Update.
3045
cd7c32c3
PW		 30462019-10-01 Philippe Waroquiers <philippe.waroquiers@skynet.be>
3047
3048 * main.c (relocate_gdbinit_path_maybe_in_datadir): Remove std::string
3049 conversion of gdb_datadir.
3050 (captured_main_1): Remove xstrdup when assigning to gdb_datadir,
3051 remove not needed c_str ().
3052
8fe0f950
AT		 30532019-09-30 Ali Tamur <tamur@google.com>
3054
3055 * dwarf2read.c (skip_one_die): Handle DW_FORM_strx forms.
3056 (dwarf2_string_attr): Likewise.
3057
5f48f8f3
AT		 30582019-09-30 Ali Tamur <tamur@google.com>
3059
3060 * dwarf2read.c (process_full_comp_unit): Remove whitespace at the EOL.
3061 (process_full_type_unit): Likewise.
3062 (dump_die_shallow): Likewise.
3063 (cu_debug_loc_section): Likewise.
3064
6fb08628
CB		 30652019-09-28 Christian Biesinger <cbiesinger@google.com>
3066
3067 * minsyms.c (compare_minimal_symbols): Rename to...
3068 (minimal_symbol_is_less_than): ...this, and adjust to STL
3069 conventions (return bool, take arguments as references)
3070 (minimal_symbol_reader::install): Call std::sort instead
3071 of qsort.
3072
c7ee338a
CB		 30732019-09-29 Christian Biesinger <cbiesinger@google.com>
3074
3075 * minsyms.h (msymbol_hash): Document that this is a case-insensitive
3076 hash and why.
3077 * objfiles.h (struct objfile_per_bfd_storage) <demangled_names_hash,
3078 msymbol_hash, msymbol_demangled_hash>: Improve comments.
3079
703a86c2
SM		 30802019-09-30 Simon Marchi <simon.marchi@polymtl.ca>
3081
3082 * psymtab.c (add_psymbol_to_list): Move comment to psympriv.h.
3083 * psympriv.h (add_psymbol_to_list): Move comment here and update
3084 it.
3085
0df0352a
TV		 30862019-09-29 Tom de Vries <tdevries@suse.de>
3087
3088 * contrib/cc-with-tweaks.sh (get_tmpdir): New function.
3089 Use $tmpdir/$(basename "$output_file").dwz instead of
3090 "${output_file}.dwz".
3091
ad75efa6
SM		 30922019-09-28 Simon Marchi <simon.marchi@polymtl.ca>
3093
3094 PR gdb/25045
3095 * hppa-linux-nat.c: Include gdbarch.h.
3096
ececd218
CB		 30972019-09-26 Christian Biesinger <cbiesinger@google.com>
3098
3099 * blockframe.c (find_pc_partial_function): Change return type to bool.
3100 * elfread.c (elf_gnu_ifunc_resolve_name): Likewise.
3101 * minsyms.c (in_gnu_ifunc_stub): Likewise.
3102 (stub_gnu_ifunc_resolve_name): Likewise.
3103 * symtab.c (compare_filenames_for_search): Likewise.
3104 (compare_glob_filenames_for_search): Likewise.
3105 (matching_obj_sections): Likewise.
3106 (symbol_matches_domain): Likewise.
3107 (find_line_symtab): Change out param EXACT_MATCH to bool *.
3108 (find_line_pc): Change return type to bool.
3109 (find_line_pc_range): Likewise.
3110 (producer_is_realview): Likewise.
3111 * symtab.h (symbol_matches_domain): Likewise.
3112 (find_pc_partial_function): Likewise.
3113 (find_pc_line_pc_range): Likewise.
3114 (in_gnu_ifunc_stub): Likewise.
3115 (struct gnu_ifunc_fns) <gnu_ifunc_resolve_name>: Likewise.
3116 (find_line_pc): Likewise.
3117 (find_line_pc_range): Likewise.
3118 (matching_obj_sections): Likewise.
3119 (find_line_symtab): Change out parameter to bool.
3120 (producer_is_realview): Change return type to bool.
3121 (compare_filenames_for_search): Likewise.
3122 (compare_glob_filenames_for_search): Likewise.
3123
27a900b8
TT		 31242019-09-26 Tom Tromey <tom@tromey.com>
3125
3126 * Makefile.in (COMMON_SFILES): Remove gdb_usleep.c.
3127 (HFILES_NO_SRCDIR): Remove gdb_usleep.h.
3128 * gdb_usleep.h: Remove.
3129 * gdb_usleep.c: Remove.
3130 * utils.c: Don't include gdb_usleep.h.
3131
5d63b30a
TT		 31322019-09-26 Tom Tromey <tromey@adacore.com>
3133
3134 * python/py-type.c (type_to_type_object): Call check_typedef
3135 for stub types.
3136
12904d37
TT		 31372019-09-26 Tom Tromey <tom@tromey.com>
3138
3139 * utils.h (initialize_utils): Don't declare.
3140 * top.c (gdb_init): Don't call initialize_utils.
3141 * utils.c (initialize_utils): Remove. Move contents...
3142 (_initialize_utils): ... here.
3143
858f25f0
TT		 31442019-09-25 Tom Tromey <tom@tromey.com>
3145
3146 * python/py-objfile.c (objfpy_get_build_id): Use bin2hex.
3147 * utils.h (make_hex_string): Don't declare.
3148 * utils.c (make_hex_string): Remove.
3149
3d435220
TV		 31502019-09-24 Tom de Vries <tdevries@suse.de>
3151
3152 PR gdb/23815
3153 * amd64-linux-nat.c (amd64_linux_nat_target::fetch_registers):
3154 Initialize xstateregs before ptrace PTRACE_GETREGSET call.
3155
ddd44b70
DD		 31562019-09-23 Dimitar Dimitrov <dimitar@dinux.eu>
3157
3158 * NEWS: Mention new simulator port for PRU.
3159
f945dedf
CB		 31602019-09-23 Christian Biesinger <cbiesinger@google.com>
3161
3162 * ada-exp.y (write_object_remaining): Update.
3163 * ada-lang.c (ada_decode): Return a std::string instead of a char*
3164 and eliminate the static buffer.
3165 (ada_decode_symbol): Update.
3166 (ada_la_decode): Update.
3167 (ada_sniff_from_mangled_name): Update.
3168 (is_valid_name_for_wild_match): Update.
3169 (ada_lookup_name_info::matches): Update and simplify.
3170 (name_matches_regex): Update.
3171 (ada_add_global_exceptions): Update.
3172 * ada-lang.h (ada_decode): Update signature.
3173 * ada-varobj.c (ada_varobj_describe_simple_array_child): Update.
3174 * dwarf-index-write.c (debug_names::insert): Update.
3175
7ab78ccb
SM		 31762019-09-21 Simon Marchi <simon.marchi@polymtl.ca>
3177
3178 * solib-svr4.c (svr4_iterate_over_objfiles_in_search_order): Fix
3179 formatting.
3180
9252448b
SM		 31812019-09-21 Simon Marchi <simon.marchi@polymtl.ca>
3182
3183 * breakpoint.h (bp_location) <inserted, permanent, duplicate>:
3184 Change "nonzero" to "true" in documentation.
3185
626ca2c0
CB		 31862019-09-20 Christian Biesinger <cbiesinger@google.com>
3187
3188 * solib-darwin.c (darwin_lookup_lib_symbol): Remove.
3189 (_initialize_darwin_solib): Don't set
3190 darwin_so_ops.lookup_lib_global_symbol.
3191 * solib-svr4.c (set_solib_svr4_fetch_link_map_offsets): Call
3192 set_gdbarch_iterate_over_objfiles_in_search_order.
3193 (elf_lookup_lib_symbol): Rename to...
3194 (svr4_iterate_over_objfiles_in_search_order): this, and update
3195 to iterate semantics.
3196 (_initialize_svr4_solib): Don't set lookup_lib_global_symbol.
3197 * solib.c (solib_global_lookup): Remove.
3198 * solist.h (struct target_so_ops): Remove lookup_lib_global_symbol.
3199 (solib_global_lookup): Remove.
3200 * symtab.c (lookup_global_or_static_symbol): Remove call to
3201 solib_global_lookup.
3202
5a3a0d63
JB		 32032019-09-20 Joel Brobecker <brobecker@adacore.com>
3204
3205 * NEWS: Move entries about default MI version now being
3206 version 3, and about the GDB/MI fix for multi-location
3207 breakpoints to the "since GDB 8.3" section.
3208
ffea1427
JB		 32092019-09-20 Joel Brobecker <brobecker@adacore.com>
3210
3211 GDB 8.3.1 released.
3212
abf516c6
UW		 32132019-09-20 Ulrich Weigand <uweigand@de.ibm.com>
3214
3215 * NEWS: Mention that Cell/B.E. debugging support was removed.
3216 * MAINTAINERS: Remove spu target.
3217
3218 * config/djgpp/fnchange.lst: Remove entries for removed files.
3219
3220 * Makefile.in (ALL_TARGET_OBS): Remove solib-spu.o,
3221 spu-multiarch.o, and spu-tdep.o.
3222 (HFILES_NO_SRCDIR): Remove solib-spu.h and spu-tdep.h.
3223 (ALLDEPFILES): Remove solib-spu.c, spu-linux-nat.c,
3224 spu-multiarch.c, and spu-tdep.c.
3225 * spu-linux-nat.c: Remove file.
3226 * spu-multiarch.c: Remove file.
3227 * spu-tdep.c: Remove file.
3228 * spu-tdep.h: Remove file.
3229 * solib-spu.c: Remove file.
3230 * solib-spu.h: Remove file.
3231
3232 * configure.host (powerpc64*-*-linux*): Remove Cell/B.E. support.
3233 * configure.nat (spu-linux): Remove.
3234 * configure.tgt (powerpc*-*-linux*): Remove solib-spu.o and
3235 solib-multiarch.o from gdb_target_obs.
3236 (spu*-*-*): Remove.
3237
3238 * arch/ppc-linux-common.h (struct ppc_linux_features): Remove "cell"
3239 feature flag.
3240 (ppc_linux_no_features): Update.
3241 * arch/ppc-linux-common.c (ppc_linux_match_description): Remove
3242 Cell/B.E. support.
3243 * arch/ppc-linux-tdesc.h (tdesc_powerpc_cell32l): Remove declaration.
3244 (tdesc_powerpc_cell64l): Likewise.
3245 * nat/ppc-linux.h (PPC_FEATURE_CELL): Remove.
3246 * ppc-linux-nat.c (ppc_linux_nat_target::read_description): Remove
3247 Cell/B.E. support.
3248 * ppc-linux-tdep.h: Do not include "solib-spu.h" or "spu-tdep.h".
3249 Do not include "features/rs6000/powerpc-cell32l.c" or
3250 "features/rs6000/powerpc-cell64l.c".
3251 (ppc_linux_spu_section): Remove.
3252 (ppc_linux_core_read_description): Remove Cell/B.E. support.
3253 (spe_context_objfile, spe_context_lm_addr, spe_context_offset,
3254 spe_context_cache_ptid, spe_context_cache_ptid): Remove.
3255 (ppc_linux_spe_context_lookup): Remove.
3256 (ppc_linux_spe_context_inferior_created): Remove.
3257 (ppc_linux_spe_context_solib_loaded): Remove.
3258 (ppc_linux_spe_context_solib_unloaded): Remove.
3259 (ppc_linux_spe_context): Remove.
3260 (struct ppu2spu_cache): Remove.
3261 (ppu2spu_prev_arch, ppu2spu_this_id, ppu2spu_prev_register): Remove.
3262 (struct ppu2spu_data): Remove.
3263 (ppu2spu_unwind_register, ppu2spu_sniffer, ppu2spu_dealloc_cache,
3264 ppu2spu_unwind): Remove.
3265 (ppc_linux_init_abi): Remove Cell/B.E. support.
3266 * rs6000-tdep.h (rs6000_gdbarch_init): Remove Cell/B.E. support.
3267
3268 * features/Makefile (rs6000/powerpc-cell32l-expedite): Remove.
3269 (rs6000/powerpc-cell64l-expedite): Likewise
3270 (WHICH): Remove rs6000/powerpc-cell32l and rs6000/powerpc-cell64l.
3271 (XMLTOC): Remove rs6000/powerpc-cell32l.xml and
3272 rs6000/powerpc-cell64l.xml.
3273 * features/rs6000/powerpc-cell32l.xml: Remove.
3274 * features/rs6000/powerpc-cell64l.xml: Likewise.
3275 * features/rs6000/powerpc-cell32l.c: Remove generated file.
3276 * features/rs6000/powerpc-cell64l.c: Likewise.
3277 * regformats/rs6000/powerpc-cell32l.dat: Remove generated file.
3278 * regformats/rs6000/powerpc-cell64l.dat: Likewise.
3279 * regformats/reg-spu.dat: Remove.
3280
3281 * target.h (enum target_object): Remove TARGET_OBJECT_SPU.
3282 * corelow.c (struct spuid_list): Remove.
3283 (add_to_spuid_list): Remove.
3284 (core_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
3285 * remote.c (PACKET_qXfer_spu_read, PACKET_qXfer_spu_write): Remove.
3286 (remote_protocol_features): Remove associated entries.
3287 (_initialize_remote): No longer initialize them.
3288 (remote_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
3289 * linux-nat.c (SPUFS_MAGIC): Remove.
3290 (linux_proc_xfer_spu): Remove.
3291 (spu_enumerate_spu_ids): Remove.
3292 (linux_nat_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
3293 * linux-tdep.c (-linux_spu_make_corefile_notes): Remove.
3294 (linux_make_corefile_notes): No longer call it.
3295
3296 * regcache.c (cooked_read_test): Remove bfd_arch_spu special case.
3297 (cooked_write_test): Likewise.
3298
78e8cb91
TT		 32992019-09-20 Tom Tromey <tom@tromey.com>
3300
3301 * NEWS: Mention case-sensitivity of TUI commands.
3302 * tui/tui-win.c (tui_set_focus_command): Now case-sensitive.
3303 (tui_set_win_height_command, parse_scrolling_args): Likewise.
3304 * tui/tui-layout.c (tui_layout_command): Now case-sensitive.
3305
f074b67e
TT		 33062019-09-20 Tom Tromey <tom@tromey.com>
3307
3308 * tui/tui-source.c (tui_source_window::set_contents): Use
3309 make_unique_xstrdup.
3310 * tui/tui-disasm.c (tui_disasm_window::set_contents): Use
3311 make_unique_xstrdup.
3312
63c4bf19
TT		 33132019-09-20 Tom Tromey <tom@tromey.com>
3314
3315 * tui/tui-data.c: Remove separator comments.
3316 * tui/tui-layout.c: Remove separator comments.
3317 * tui/tui-win.c: Remove separator comments.
3318 * tui/tui-wingeneral.c: Remove separator comments.
3319
43df9b2f
TT		 33202019-09-20 Tom Tromey <tom@tromey.com>
3321
3322 * tui/tui.h (strcat_to_buf): Don't declare.
3323 * tui/tui.c (strcat_to_buf): Remove.
3324
7226433c
TT		 33252019-09-20 Tom Tromey <tom@tromey.com>
3326
3327 * tui/tui-source.h (struct tui_source_window) <m_fullname>: Rename
3328 from "fullname".
3329 * tui/tui-source.c (tui_source_window::set_contents)
3330 (tui_source_window::location_matches_p)
3331 (tui_source_window::maybe_update): Update.
3332
80df3337
TT		 33332019-09-20 Tom Tromey <tom@tromey.com>
3334
3335 * tui/tui-regs.h (struct tui_data_window) <get_current_group>:
3336 Update.
3337 <m_regs_content, m_regs_column_count, m_current_group>: Add "m_"
3338 prefix.
3339 * tui/tui-regs.c (tui_data_window::last_regs_line_no)
3340 (tui_data_window::line_from_reg_element_no)
3341 (tui_data_window::first_reg_element_no_inline)
3342 (tui_data_window::show_registers)
3343 (tui_data_window::show_register_group)
3344 (tui_data_window::display_registers_from)
3345 (tui_data_window::display_registers_from_line)
3346 (tui_data_window::first_data_item_displayed)
3347 (tui_data_window::delete_data_content_windows)
3348 (tui_data_window::erase_data_content)
3349 (tui_data_window::do_scroll_vertical)
3350 (tui_data_window::refresh_window)
3351 (tui_data_window::check_register_values): Update.
3352
9923f347
TT		 33532019-09-20 Tom Tromey <tom@tromey.com>
3354
3355 * tui/tui-stack.h (MAX_LOCATOR_ELEMENT_LEN): Remove define.
3356 (struct tui_locator_window) <full_name, proc_name>: Now
3357 std::string.
3358 * tui/tui-stack.c (tui_locator_window::make_status_line)
3359 (tui_locator_window::set_locator_fullname)
3360 (tui_locator_window::set_locator_info): Update.
3361 * tui/tui-source.c (tui_source_window::set_contents)
3362 (tui_source_window::showing_source_p): Update.
3363
b76251ab
TT		 33642019-09-20 Tom Tromey <tom@tromey.com>
3365
3366 * tui/tui-stack.c (tui_locator_window::set_locator_fullname):
3367 Don't call tui_locator_win_info_ptr.
3368
0891be08
TT		 33692019-09-20 Tom Tromey <tom@tromey.com>
3370
3371 * tui/tui-win.c (tui_resize_all): Don't call refresh.
3372
1b935acf
TT		 33732019-09-20 Tom Tromey <tom@tromey.com>
3374
3375 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Use 1 as
3376 height for locator.
3377 * tui/tui-stack.c (tui_locator_window::rerender): Call scrollok.
3378 * tui/tui-layout.c (show_source_disasm_command, show_data)
3379 (show_source_or_disasm_and_command): Use 1 as height for locator.
3380
9abd8a65
TT		 33812019-09-20 Tom Tromey <tom@tromey.com>
3382
3383 * tui/tui.c (tui_enable): Update.
3384 * tui/tui-win.c (tui_sigwinch_handler, tui_async_resize_screen):
3385 Update.
3386 * tui/tui-data.h (tui_win_resized, tui_set_win_resized_to):
3387 Update.
3388 * tui/tui-data.c (win_resized): Now bool.
3389 (tui_win_resized): Return bool.
3390 (tui_set_win_resized_to): Accept a bool.
3391
b5457826
TT		 33922019-09-20 Tom Tromey <tom@tromey.com>
3393
3394 * tui/tui-regs.h (struct tui_data_window) <show_register_group>:
3395 Change type of "refresh_values_only".
3396 * tui/tui-regs.c (tui_data_window::show_register_group): Change
3397 type of "refresh_values_only".
3398
6b915f7d
TT		 33992019-09-20 Tom Tromey <tom@tromey.com>
3400
3401 * tui/tui-disasm.c (struct tui_asm_line) <addr_string, insn>: Now
3402 std::string.
3403 (tui_disassemble): Add "pos" parameter.
3404 (tui_disasm_window::set_contents): Simplify.
3405
2ad52f6f
TT		 34062019-09-20 Tom Tromey <tom@tromey.com>
3407
3408 * tui/tui-winsource.h (struct tui_source_window_base)
3409 <show_source_content>: Now private.
3410 * tui/tui-winsource.c
3411 (tui_source_window_base::show_source_content): Don't handle empty
3412 content case.
3413
b3b1bde6
TT		 34142019-09-20 Tom Tromey <tom@tromey.com>
3415
3416 * tui/tui-layout.c (show_source_disasm_command)
3417 (show_source_or_disasm_and_command): Don't call
3418 show_source_content.
3419
71a25ed2
TT		 34202019-09-20 Tom Tromey <tom@tromey.com>
3421
3422 * tui/tui-stack.h (struct tui_locator_window) <make_status_line>:
3423 Declare.
3424 * tui/tui-stack.c (tui_locator_window::make_status_line): Rename
3425 from tui_make_status_line.
3426 (tui_locator_window::rerender): Update.
3427
f8532154
TT		 34282019-09-20 Tom Tromey <tom@tromey.com>
3429
3430 * tui/tui-stack.c (tui_make_status_line): Return std::string.
3431 (tui_locator_window::rerender): Update.
3432
2d81b349
TT		 34332019-09-20 Tom Tromey <tom@tromey.com>
3434
3435 * tui/tui-winsource.h (struct tui_source_window_base)
3436 <~tui_source_window_base>: Don't declare.
3437 <fullname>: Remove.
3438 * tui/tui-winsource.c (~tui_source_window_base): Remove.
3439 * tui/tui-source.h (struct tui_source_window) <fullname>: New
3440 member.
3441 * tui/tui-source.c (tui_source_window::set_contents): Update.
3442 (tui_source_window::location_matches_p)
3443 (tui_source_window::maybe_update): Update.
3444
f14bec58
TT		 34452019-09-20 Tom Tromey <tom@tromey.com>
3446
3447 * tui/tui-winsource.h (~tui_source_element): Remove.
3448 (tui_source_element): Update.
3449 (struct tui_source_element) <line>: Now a unique_xmalloc_ptr.
3450 * tui/tui-winsource.c (tui_show_source_line): Update.
3451 * tui/tui-source.c (tui_source_window::set_contents): Update.
3452 * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
3453
78d5933a
TT		 34542019-09-20 Tom Tromey <tom@tromey.com>
3455
3456 * tui/tui-data.h (tui_clear_source_windows_detail): Don't
3457 declare.
3458 * tui/tui-layout.c (tui_add_win_to_layout): Don't call
3459 tui_clear_source_windows_detail.
3460 * tui/tui-winsource.h (struct tui_source_window_base)
3461 <clear_detail>: Don't declare.
3462 * tui/tui-winsource.c (tui_source_window_base::clear_detail):
3463 Remove.
3464 * tui/tui-data.c (tui_clear_source_windows_detail): Remove.
3465
d4207696
TT		 34662019-09-20 Tom Tromey <tromey@adacore.com>
3467
3468 PR ada/24919:
3469 * block.c (contained_in): Fix final return value.
3470
00f93c44
AM		 34712019-09-20 Alan Modra <amodra@gmail.com>
3472
3473 * gdb_bfd.c (gdb_bfd_ref, gdb_bfd_unref): Use bfd_set_usrdata.
3474 * dwarf2read.c (dwarf2_read_gdb_index, dwarf2_read_debug_names),
3475 (read_indirect_string_from_dwz): Use bfd accessor.
3476 * dwarf2read.h (struct dwz_file <filename>): Likewise.
3477 * machoread.c (macho_symfile_read_all_oso): Likewise.
3478 * solib.c (solib_bfd_open): Likewise.
3479
e4153ae6
CB		 34802019-09-19 Christian Biesinger <cbiesinger@google.com>
3481
3482 * eval.c: Move declaration of overload_resolution to...
3483 * value.h: ...here.
3484
c7ae7675
CB		 34852019-09-19 Christian Biesinger <cbiesinger@google.com>
3486
3487 * arm-linux-nat.c: Remove extern declaration for arm_apcs_32.
3488 * arm-linux-tdep.c: Likewise.
3489 * arm-nbsd-nat.c: Likewise.
3490 * arm-tdep.h: Declare arm_apcs_32.
3491 * arm-tdep.c: Move documentation for arm_apcs_32 to arm-tdep.h.
3492
e86f08d2
CB		 34932019-09-19 Christian Biesinger <cbiesinger@google.com>
3494
3495 * dwarf2loc.c: Remove extern declaration of dwarf_always_disassemble.
3496 * dwarf2read.h: Declare dwarf_always_disassemble.
3497
f64e2f40
TV		 34982019-09-19 Tom de Vries <tdevries@suse.de>
3499
3500 PR gdb/25009
3501 * source-cache.c (source_cache::ensure): Catch exception thrown during
3502 construction of the highlighter.
3503
fd361982
AM		 35042019-09-18 Alan Modra <amodra@gmail.com>
3505
3506 * aarch64-linux-tdep.c, * arm-tdep.c, * auto-load.c,
3507 * coff-pe-read.c, * coffread.c, * corelow.c, * dbxread.c,
3508 * dicos-tdep.c, * dwarf2-frame.c, * dwarf2read.c, * elfread.c,
3509 * exec.c, * fbsd-tdep.c, * gcore.c, * gdb_bfd.c, * gdb_bfd.h,
3510 * hppa-tdep.c, * i386-cygwin-tdep.c, * i386-fbsd-tdep.c,
3511 * i386-linux-tdep.c, * jit.c, * linux-tdep.c, * machoread.c,
3512 * maint.c, * mdebugread.c, * minidebug.c, * mips-linux-tdep.c,
3513 * mips-sde-tdep.c, * mips-tdep.c, * mipsread.c, * nto-tdep.c,
3514 * objfiles.c, * objfiles.h, * osabi.c, * ppc-linux-tdep.c,
3515 * ppc64-tdep.c, * record-btrace.c, * record-full.c, * remote.c,
3516 * rs6000-aix-tdep.c, * rs6000-tdep.c, * s390-linux-tdep.c,
3517 * s390-tdep.c, * solib-aix.c, * solib-dsbt.c, * solib-frv.c,
3518 * solib-spu.c, * solib-svr4.c, * solib-target.c,
3519 * spu-linux-nat.c, * spu-tdep.c, * symfile-mem.c, * symfile.c,
3520 * symmisc.c, * symtab.c, * target.c, * windows-nat.c,
3521 * xcoffread.c, * cli/cli-dump.c, * compile/compile-object-load.c,
3522 * mi/mi-interp.c: Update throughout for bfd section macro and
3523 function changes.
3524 * gcore (gcore_create_callback): Use bfd_set_section_lma.
3525 * spu-tdep.c (spu_overlay_new_objfile): Likewise.
3526
11061048
TT		 35272019-09-18 Tom Tromey <tom@tromey.com>
3528
3529 * NEWS: Add entry.
3530 * tui/tui.c (tui_initialize_readline): Set name of keymap. Do not
3531 call rl_initialize.
3532 (tui_enable): Do not call rl_initialize.
3533
7a27b85f
CG		 35342019-09-18 Christian Groessler <chris@groessler.org>
3535
3536 * alpha-linux-nat.c: Include gdbarch.h.
3537
f64eea3a
SM		 35382019-09-18 Simon Marchi <simon.marchi@polymtl.ca>
3539
3540 * ui-file.c: Include cli/cli-style.h.
3541 (term_cli_styling): Remove cli_styling declaration.
3542
e6f7f6d1
AM		 35432019-09-18 Alan Modra <amodra@gmail.com>
3544
3545 * arm-tdep.c (arm_record_special_symbol): Update bfd_get_section
3546 to bfd_asymbol_section.
3547
1d38e9d1
AM		 35482019-09-18 Alan Modra <amodra@gmail.com>
3549
3550 * amd64-dicos-tdep.c (amd64_dicos_osabi_sniffer): Constify target.
3551 * i386-cygwin-tdep.c (i386_cygwin_init_abi): Likewise.
3552 * i386-dicos-tdep.c (i386_dicos_osabi_sniffer): Likewise.
3553
90d92a63
AM		 35542019-09-18 Alan Modra <amodra@gmail.com>
3555
3556 * solib-spu.c (spu_bfd_open): Use bfd_set_filename.
3557 * spu-linux-nat.c (spu_bfd_open): Likewise.
3558
a3d181d2
CB		 35592019-09-18 Christian Biesinger <cbiesinger@google.com>
3560
3561 * dwarf2loc.c: Change extern declaration of dwarf_always_disassemble
3562 to bool to match definition in dwarf2read.c.
3563
491144b5
CB		 35642019-09-17 Christian Biesinger <cbiesinger@google.com>
3565
3566 * ada-lang.c (ada_ignore_descriptive_types_p): Change to bool.
3567 (print_signatures): Likewise.
3568 (trust_pad_over_xvs): Likewise.
3569 * arch/aarch64-insn.c (aarch64_debug): Likewise.
3570 * arch/aarch64-insn.h (aarch64_debug): Likewise.
3571 * arm-linux-nat.c (arm_apcs_32): Likewise.
3572 * arm-linux-tdep.c (arm_apcs_32): Likewise.
3573 * arm-nbsd-nat.c (arm_apcs_32): Likewise.
3574 * arm-tdep.c (arm_debug): Likewise.
3575 (arm_apcs_32): Likewise.
3576 * auto-load.c (debug_auto_load): Likewise.
3577 (auto_load_gdb_scripts): Likewise.
3578 (global_auto_load): Likewise.
3579 (auto_load_local_gdbinit): Likewise.
3580 (auto_load_local_gdbinit_loaded): Likewise.
3581 * auto-load.h (global_auto_load): Likewise.
3582 (auto_load_local_gdbinit): Likewise.
3583 (auto_load_local_gdbinit_loaded): Likewise.
3584 * breakpoint.c (disconnected_dprintf): Likewise.
3585 (breakpoint_proceeded): Likewise.
3586 (automatic_hardware_breakpoints): Likewise.
3587 (always_inserted_mode): Likewise.
3588 (target_exact_watchpoints): Likewise.
3589 (_initialize_breakpoint): Update.
3590 * breakpoint.h (target_exact_watchpoints): Change to bool.
3591 * btrace.c (maint_btrace_pt_skip_pad): Likewise.
3592 * cli/cli-cmds.c (trace_commands): Likewise.
3593 * cli/cli-cmds.h (trace_commands): Likewise.
3594 * cli/cli-decode.c (add_setshow_boolean_cmd): Change int* argument
3595 to bool*.
3596 * cli/cli-logging.c (logging_overwrite): Change to bool.
3597 (logging_redirect): Likewise.
3598 (debug_redirect): Likewise.
3599 * cli/cli-option.h (option_def) <boolean>: Change return type to bool*.
3600 (struct boolean_option_def) <get_var_address_cb_>: Change return type
3601 to bool.
3602 <boolean_option_def>: Update.
3603 (struct flag_option_def): Change default type of Context to bool
3604 from int.
3605 <flag_option_def>: Change return type of var_address_cb_ to bool*.
3606 * cli/cli-setshow.c (do_set_command): Cast to bool* instead of int*.
3607 (get_setshow_command_value_string): Likewise.
3608 * cli/cli-style.c (cli_styling): Change to bool.
3609 (source_styling): Likewise.
3610 * cli/cli-style.h (source_styling): Likewise.
3611 (cli_styling): Likewise.
3612 * cli/cli-utils.h (struct qcs_flags) <quiet, cont, silent>: Change
3613 to bool.
3614 * command.h (var_types): Update comment.
3615 (add_setshow_boolean_cmd): Change int* var argument to bool*.
3616 * compile/compile-cplus-types.c (debug_compile_cplus_types): Change to
3617 bool.
3618 (debug_compile_cplus_scopes): Likewise.
3619 * compile/compile-internal.h (compile_debug): Likewise.
3620 * compile/compile.c (compile_debug): Likewise.
3621 (struct compile_options) <raw>: Likewise.
3622 * cp-support.c (catch_demangler_crashes): Likewise.
3623 * cris-tdep.c (usr_cmd_cris_version_valid): Likewise.
3624 (usr_cmd_cris_dwarf2_cfi): Likewise.
3625 * csky-tdep.c (csky_debug): Likewise.
3626 * darwin-nat.c (enable_mach_exceptions): Likewise.
3627 * dcache.c (dcache_enabled_p): Likewise.
3628 * defs.h (info_verbose): Likewise.
3629 * demangle.c (demangle): Likewise.
3630 (asm_demangle): Likewise.
3631 * dwarf-index-cache.c (debug_index_cache): Likewise.
3632 * dwarf2-frame.c (dwarf2_frame_unwinders_enabled_p): Likewise.
3633 * dwarf2-frame.h (dwarf2_frame_unwinders_enabled_p): Likewise.
3634 * dwarf2read.c (check_physname): Likewise.
3635 (use_deprecated_index_sections): Likewise.
3636 (dwarf_always_disassemble): Likewise.
3637 * eval.c (overload_resolution): Likewise.
3638 * event-top.c (set_editing_cmd_var): Likewise.
3639 (exec_done_display_p): Likewise.
3640 * event-top.h (set_editing_cmd_var): Likewise.
3641 (exec_done_display_p): Likewise.
3642 * exec.c (write_files): Likewise.
3643 * fbsd-nat.c (debug_fbsd_lwp): Likewise
3644 (debug_fbsd_nat): Likewise.
3645 * frame.h (struct frame_print_options) <print_raw_frame_arguments>:
3646 Likewise.
3647 (struct set_backtrace_options) <backtrace_past_main>: Likewise.
3648 <backtrace_past_entry> Likewise.
3649 * gdb-demangle.h (demangle): Likewise.
3650 (asm_demangle): Likewise.
3651 * gdb_bfd.c (bfd_sharing): Likewise.
3652 * gdbcore.h (write_files): Likewise.
3653 * gdbsupport/common-debug.c (show_debug_regs): Likewise.
3654 * gdbsupport/common-debug.h (show_debug_regs): Likewise.
3655 * gdbthread.h (print_thread_events): Likewise.
3656 * gdbtypes.c (opaque_type_resolution): Likewise.
3657 (strict_type_checking): Likewise.
3658 * gnu-nat.c (gnu_debug_flag): Likewise.
3659 * guile/scm-auto-load.c (auto_load_guile_scripts): Likewise.
3660 * guile/scm-param.c (pascm_variable): Add boolval.
3661 (add_setshow_generic): Update.
3662 (pascm_param_value): Update.
3663 (pascm_set_param_value_x): Update.
3664 * hppa-tdep.c (hppa_debug): Change to bool..
3665 * infcall.c (may_call_functions_p): Likewise.
3666 (coerce_float_to_double_p): Likewise.
3667 (unwind_on_signal_p): Likewise.
3668 (unwind_on_terminating_exception_p): Likewise.
3669 * infcmd.c (startup_with_shell): Likewise.
3670 * inferior.c (print_inferior_events): Likewise.
3671 * inferior.h (startup_with_shell): Likewise.
3672 (print_inferior_events): Likewise.
3673 * infrun.c (step_stop_if_no_debug): Likewise.
3674 (detach_fork): Likewise.
3675 (debug_displaced): Likewise.
3676 (disable_randomization): Likewise.
3677 (non_stop): Likewise.
3678 (non_stop_1): Likewise.
3679 (observer_mode): Likewise.
3680 (observer_mode_1): Likewise.
3681 (set_observer_mode): Update.
3682 (sched_multi): Change to bool.
3683 * infrun.h (debug_displaced): Likewise.
3684 (sched_multi): Likewise.
3685 (step_stop_if_no_debug): Likewise.
3686 (non_stop): Likewise.
3687 (disable_randomization): Likewise.
3688 * linux-tdep.c (use_coredump_filter): Likewise.
3689 (dump_excluded_mappings): Likewise.
3690 * linux-thread-db.c (auto_load_thread_db): Likewise.
3691 (check_thread_db_on_load): Likewise.
3692 * main.c (captured_main_1): Update.
3693 * maint-test-options.c (struct test_options_opts) <flag_opt, xx1_opt,
3694 xx2_opt, boolean_opt>: Change to bool.
3695 * maint-test-settings.c (maintenance_test_settings_boolean): Likewise.
3696 * maint.c (maintenance_profile_p): Likewise.
3697 (per_command_time): Likewise.
3698 (per_command_space): Likewise.
3699 (per_command_symtab): Likewise.
3700 * memattr.c (inaccessible_by_default): Likewise.
3701 * mi/mi-main.c (mi_async): Likewise.
3702 (mi_async_1): Likewise.
3703 * mips-tdep.c (mips64_transfers_32bit_regs_p): Likewise.
3704 * nat/fork-inferior.h (startup_with_shell): Likewise.
3705 * nat/linux-namespaces.c (debug_linux_namespaces): Likewise.
3706 * nat/linux-namespaces.h (debug_linux_namespaces): Likewise.
3707 * nios2-tdep.c (nios2_debug): Likewise.
3708 * or1k-tdep.c (or1k_debug): Likewise.
3709 * parse.c (parser_debug): Likewise.
3710 * parser-defs.h (parser_debug): Likewise.
3711 * printcmd.c (print_symbol_filename): Likewise.
3712 * proc-api.c (procfs_trace): Likewise.
3713 * python/py-auto-load.c (auto_load_python_scripts): Likewise.
3714 * python/py-param.c (union parmpy_variable): Add "bool boolval" field.
3715 (set_parameter_value): Update.
3716 (add_setshow_generic): Update.
3717 * python/py-value.c (copy_py_bool_obj): Change argument from int*
3718 to bool*.
3719 * python/python.c (gdbpy_parameter_value): Cast to bool* instead of
3720 int*.
3721 * ravenscar-thread.c (ravenscar_task_support): Change to bool.
3722 * record-btrace.c (record_btrace_target::store_registers): Update.
3723 * record-full.c (record_full_memory_query): Change to bool.
3724 (record_full_stop_at_limit): Likewise.
3725 * record-full.h (record_full_memory_query): Likewise.
3726 * remote-notif.c (notif_debug): Likewise.
3727 * remote-notif.h (notif_debug): Likewise.
3728 * remote.c (use_range_stepping): Likewise.
3729 (interrupt_on_connect): Likewise.
3730 (remote_break): Likewise.
3731 * ser-tcp.c (tcp_auto_retry): Likewise.
3732 * ser-unix.c (serial_hwflow): Likewise.
3733 * skip.c (debug_skip): Likewise.
3734 * solib-aix.c (solib_aix_debug): Likewise.
3735 * spu-tdep.c (spu_stop_on_load_p): Likewise.
3736 (spu_auto_flush_cache_p): Likewise.
3737 * stack.c (struct backtrace_cmd_options) <full, no_filters, hide>:
3738 Likewise.
3739 (struct info_print_options) <quiet>: Likewise.
3740 * symfile-debug.c (debug_symfile): Likewise.
3741 * symfile.c (auto_solib_add): Likewise.
3742 (separate_debug_file_debug): Likewise.
3743 * symfile.h (auto_solib_add): Likewise.
3744 (separate_debug_file_debug): Likewise.
3745 * symtab.c (basenames_may_differ): Likewise.
3746 (struct filename_partial_match_opts) <dirname, basename>: Likewise.
3747 (struct info_print_options) <quiet, exclude_minsyms>: Likewise.
3748 (struct info_types_options) <quiet>: Likewise.
3749 * symtab.h (demangle): Likewise.
3750 (basenames_may_differ): Likewise.
3751 * target-dcache.c (stack_cache_enabled_1): Likewise.
3752 (code_cache_enabled_1): Likewise.
3753 * target.c (trust_readonly): Likewise.
3754 (may_write_registers): Likewise.
3755 (may_write_memory): Likewise.
3756 (may_insert_breakpoints): Likewise.
3757 (may_insert_tracepoints): Likewise.
3758 (may_insert_fast_tracepoints): Likewise.
3759 (may_stop): Likewise.
3760 (auto_connect_native_target): Likewise.
3761 (target_stop_and_wait): Update.
3762 (target_async_permitted): Change to bool.
3763 (target_async_permitted_1): Likewise.
3764 (may_write_registers_1): Likewise.
3765 (may_write_memory_1): Likewise.
3766 (may_insert_breakpoints_1): Likewise.
3767 (may_insert_tracepoints_1): Likewise.
3768 (may_insert_fast_tracepoints_1): Likewise.
3769 (may_stop_1): Likewise.
3770 * target.h (target_async_permitted): Likewise.
3771 (may_write_registers): Likewise.
3772 (may_write_memory): Likewise.
3773 (may_insert_breakpoints): Likewise.
3774 (may_insert_tracepoints): Likewise.
3775 (may_insert_fast_tracepoints): Likewise.
3776 (may_stop): Likewise.
3777 * thread.c (struct info_threads_opts) <show_global_ids>: Likewise.
3778 (make_thread_apply_all_options_def_group): Change argument from int*
3779 to bool*.
3780 (thread_apply_all_command): Update.
3781 (print_thread_events): Change to bool.
3782 * top.c (confirm): Likewise.
3783 (command_editing_p): Likewise.
3784 (history_expansion_p): Likewise.
3785 (write_history_p): Likewise.
3786 (info_verbose): Likewise.
3787 * top.h (confirm): Likewise.
3788 (history_expansion_p): Likewise.
3789 * tracepoint.c (disconnected_tracing): Likewise.
3790 (circular_trace_buffer): Likewise.
3791 * typeprint.c (print_methods): Likewise.
3792 (print_typedefs): Likewise.
3793 * utils.c (debug_timestamp): Likewise.
3794 (sevenbit_strings): Likewise.
3795 (pagination_enabled): Likewise.
3796 * utils.h (sevenbit_strings): Likewise.
3797 (pagination_enabled): Likewise.
3798 * valops.c (overload_resolution): Likewise.
3799 * valprint.h (struct value_print_options) <prettyformat_arrays,
3800 prettyformat_structs, vtblprint, unionprint, addressprint, objectprint,
3801 stop_print_at_null, print_array_indexes, deref_ref, static_field_print,
3802 pascal_static_field_print, raw, summary, symbol_print, finish_print>:
3803 Likewise.
3804 * windows-nat.c (new_console): Likewise.
3805 (cygwin_exceptions): Likewise.
3806 (new_group): Likewise.
3807 (debug_exec): Likewise.
3808 (debug_events): Likewise.
3809 (debug_memory): Likewise.
3810 (debug_exceptions): Likewise.
3811 (useshell): Likewise.
3812 * windows-tdep.c (maint_display_all_tib): Likewise.
3813 * xml-support.c (debug_xml): Likewise.
3814
f1b620e9
MG		 38152019-09-17 Mike Gulick <mgulick@mathworks.com>
3816
3817 * source.c (prepare_path_for_appending): New function.
3818 (openp): Make use of new function.
3819 (find_and_open_source): Search for the compilation directory and
3820 source file as a relative path beneath the directory search path.
3821
67f3ed6a
AB		 38222019-09-17 Andrew Burgess <andrew.burgess@embecosm.com>
3823
3824 * source-cache.c (source_cache::get_line_charpos): Catch
3825 exceptions and return false, this matches the behaviour documented
3826 in the header file.
3827
74332189
JB		 38282019-09-17 Joel Brobecker <brobecker@adacore.com>
3829
3830 * ada-tasks.c (info_task): Remove quoting of the task's name.
3831
f2f24aa9
CB		 38322019-09-16 Christian Biesinger <cbiesinger@google.com>
3833
3834 * symfile.c (auto_solib_add): Replace comment with a reference
3835 to the header file.
3836
6a062a93
CB		 38372019-09-14 Christian Biesinger <cbiesinger@google.com>
3838
3839 * NEWS: Mention that gdb can now be compiled with Python 3
3840 on Windows.
3841
ec6c8338
AB		 38422019-09-12 Andrew Burgess <andrew.burgess@embecosm.com>
3843
3844 * maint.c (maint_print_section_data::maint_print_section_data):
3845 Force use of 'float log10 (float)' by casting the argument to
3846 float.
3847
aa17805f
AB		 38482019-09-12 Andrew Burgess <andrew.burgess@embecosm.com>
3849
3850 * maint.c: Add 'cmath' include.
3851 (struct maint_print_section_data): New structure.
3852 (print_section_index): New function.
3853 (print_bfd_section_info): Add header comment, small whitespace
3854 cleanup, and update to call new print_section_index function.
3855 (print_objfile_section_info): Likewise.
3856 (maint_obj_section_from_bfd_section): New function.
3857 (print_bfd_section_info_maybe_relocated): New function.
3858 (maintenance_info_sections): Add header comment, always use
3859 bfd_map_over_sections instead of ALL_OBJFILE_OSECTIONS.
3860
3dd9bb46
AB		 38612019-09-12 Andrew Burgess <andrew.burgess@embecosm.com>
3862
3863 * psymtab.c (find_pc_sect_psymtab): Move baseaddr local into more
3864 inner scope, add check that the objfile has psymtabs before
3865 checking psymtabs_addrmap.
3866 * psymtab.h (psymtab_storage) <psymtabs_addrmap>: Extend comment.
3867
4993045d
PW		 38682019-09-12 Philippe Waroquiers <philippe.waroquiers@skynet.be>
3869
3870 * NEWS: Announce that Ada task names are now shown at more places,
3871 and between quotes (except in info task output).
3872 * gdb/ada-tasks.c (task_to_str): New function.
3873 (display_current_task_id): Call task_to_str.
3874 (task_command_1): Likewise.
3875 (print_ada_task_info): In non-mi mode, Properly align headers and data
3876 when task-id length is > 9 (9 is the default for a 32 bits CORE_ADDR).
3877
7a289707
RO		 38782019-09-12 Rainer Orth <ro@CeBiTec.Uni-Bielefeld.DE>
3879
3880 * procfs.c (procfs_target::wait) <PR_FAULTED>: Get signal from
3881 prstatus.pr_lwp.pr_info instead of making it up.
3882
f2aec7f6
CB		 38832019-09-11 Christian Biesinger <cbiesinger@google.com>
3884
3885 * auto-load.c (auto_load_expand_dir_vars): Update.
3886 * defs.h (gdb_datadir): Change to std::string.
3887 (python_libdir): Likewise.
3888 (relocate_gdb_directory): Change return type to std::string.
3889 * guile/guile.c (gdbscm_data_directory): Update.
3890 (initialize_scheme_side): Update.
3891 * jit.c (jit_reader_dir): Change to std::string.
3892 (jit_reader_load_command): Update.
3893 * main.c (gdb_datadir): Change to std::string.
3894 (python_libdir): Likewise.
3895 (set_gdb_data_directory): Update.
3896 (relocate_path): Change to return std::string.
3897 (relocate_gdb_directory): Change to return std::string.
3898 (relocate_gdbinit_path_maybe_in_datadir): Update.
3899 (captured_main_1): Update.
3900 * python/python.c (do_start_initialization): Update.
3901 * top.c (show_gdb_datadir): Update.
3902 * xml-syscall.c (xml_init_syscalls_info): Update.
3903 (init_syscalls_info): Update.
3904
9224a013
CB		 39052019-09-11 Christian Biesinger <cbiesinger@google.com>
3906
3907 * main.c (relocate_gdbinit_path_maybe_in_datadir): Factor this code
3908 out of get_init_files.
3909 (get_init_files): Update.
3910
f48cd836
CB		 39112019-09-11 Christian Biesinger <cbiesinger@google.com>
3912
3913 * main.c (get_init_files): Change to use std::string.
3914 (captured_main_1): Update.
3915 (print_gdb_help): Update.
3916
9cab7ecd
AT		 39172019-09-11 Ali Tamur <tamur@google.com>
3918
3919 *gdb/target-float.c (host_float_ops<T>::to_longest): Update
3920 implementation.
3921
67547d89
CB		 39222019-09-11 Christian Biesinger <cbiesinger@google.com>
3923
3924 * dbxread.c (read_dbx_symtab): Update.
3925 * dwarf2read.c (load_partial_dies): Update.
3926 * mdebugread.c (parse_partial_symbols): Update.
3927 (handle_psymbol_enumerators): Update.
3928 * psympriv.h (add_psymbol_to_list): Change type of copy_names to bool.
3929 * psymtab.c (add_psymbol_to_bcache): Likewise.
3930 (add_psymbol_to_list): Likewise.
3931 * symtab.c (symbol_set_names): Likewise.
3932 * symtab.h (symbol_set_names): Likewise.
3933 * xcoffread.c (scan_xcoff_symtab): Update.
3934
64b2d4a0
TT		 39352019-09-11 Tom Tromey <tom@tromey.com>
3936
3937 * symfile-mem.c (symbol_file_add_from_memory): Use
3938 bfd_set_filename.
3939 * solib-darwin.c (darwin_bfd_open): Use bfd_set_filename.
3940 * solib-aix.c (solib_aix_bfd_open): Use bfd_set_filename.
3941
3b00ef10
TT		 39422019-09-10 Tom Tromey <tromey@adacore.com>
3943
3944 * dwarf-index-write.c (write_psymbols): Extend error message.
3945 (debug_names::insert): Add Ada code.
3946 (debug_names::write_psymbols): Remove Ada check.
3947 (debug_names) <m_string_obstack>: New member.
3948 * dwarf2read.c (gdb_index_symbol_name_matcher): Remove.
3949 (gdb_index_symbol_name_matcher::matches): Remove.
3950 (mapped_index_base::find_name_components_bounds): Add "lang"
3951 parameter.
3952 (mapped_index_base::build_name_components): Also split names
3953 according to Ada syntax.
3954 (dw2_expand_symtabs_matching_symbol): Loop over languages. Change
3955 type of "match_callback".
3956 (check_match, check_find_bounds_finds)
3957 (dw2_expand_symtabs_matching): Update.
3958 (dw2_debug_names_iterator): Add new constructor.
3959 (dw2_debug_names_map_matching_symbols): New function.
3960 (dw2_debug_names_expand_symtabs_matching): Update.
3961 (dwarf2_debug_names_functions): Use
3962 dw2_debug_names_map_matching_symbols.
3963
aa391654
TT		 39642019-09-10 Tom Tromey <tromey@adacore.com>
3965
3966 * dwarf2read.c (dw2_get_file_names_reader): Add the
3967 CU's file name to the results.
3968
b054970d
TT		 39692019-09-10 Tom Tromey <tromey@adacore.com>
3970
3971 * ada-lang.c (add_nonlocal_symbols): Combine calls to
3972 map_matching_symbols. Update.
3973 * dwarf2read.c (dw2_map_matching_symbols): Update.
3974 * psymtab.c (match_partial_symbol): Change type; update.
3975 (psym_map_matching_symbols): Likewise.
3976 * symfile-debug.c (debug_qf_map_matching_symbols): Change
3977 type; update.
3978 * symfile.h (struct quick_symbol_functions)
3979 <map_matching_symbols>: Change "name" to be a lookup_name_info.
3980 Remove "match".
3981
6a3dbf1b
TT		 39822019-09-10 Tom Tromey <tromey@adacore.com>
3983
3984 * psymtab.c (map_block): Remove.
3985 (psym_map_matching_symbols): Use iterate_over_symbols_terminated.
3986 * symtab.c (iterate_over_symbols_terminated): New function.
3987 * symtab.c (iterate_over_symbols_terminated): Declare.
3988
6969f124
TT		 39892019-09-10 Tom Tromey <tromey@adacore.com>
3990
3991 * ada-lang.c (ada_iterate_over_symbols): Return bool.
3992 * language.h (struct language_defn) <la_iterate_over_symbols>:
3993 Return bool.
3994 * symtab.c (iterate_over_symbols): Return bool.
3995 * symtab.h (iterate_over_symbols): Return bool.
3996
199b4314
TT		 39972019-09-10 Tom Tromey <tromey@adacore.com>
3998
3999 * ada-lang.c (aux_add_nonlocal_symbols): Change type.
4000 (add_nonlocal_symbols): Update.
4001 * dwarf2read.c (dw2_map_matching_symbols): Change type.
4002 * psymtab.c (map_block, psym_map_matching_symbols): Change type.
4003 * symfile-debug.c (debug_qf_map_matching_symbols): Change type.
4004 * symfile.h (struct quick_symbol_functions) <map_matching_symbols>:
4005 Change type of "callback". Remove "data".
4006
a084a2a6
AT		 4007
40082019-09-09 Ali Tamur <tamur@google.com>
4009
4010 * dwarf2read.c (comp_unit_head): Update comment.
4011 (dwarf2_dwo_name): New function declaration.
4012 (dwarf_unit_type_name): New function declaration.
4013 (read_comp_unit_head): Add support for new compilation units,
4014 DW_UT_partial, DW_UT_skeleton, DW_UT_split_compile, DW_UT_split_type.
4015 Particularly, DW_UT_skeleton and DW_UT_split_compile have dwo_id
4016 (currently named as "signature") in their header. Also clarify error
4017 messages.
4018 (lookup_dwo_id): New function. Returns the dwo id of the given
4019 compile unit.
4020 (lookup_dwo_unit): Use the new lookup_dwo_id function.
4021 (init_cutu_and_read_dies): Use the new dwarf2_dwo_name and lookup_dwo_id
4022 functions.
4023 (create_dwo_cu_reader): Use the added lookup_dwo_id function.
4024 (dwarf2_dwo_name): Get the dwo name if present.
4025 (dwarf_unit_type_name): Convert DW_UT_* types to string for diagnostic
4026 purposes.
4027
25a2915e
TT		 40282019-09-09 Tom Tromey <tom@tromey.com>
4029
4030 * tui/tui-win.c (tui_all_windows_info): Use ui_out.
4031
e4df0874
PW		 40322019-09-09 Philippe Waroquiers <philippe.waroquiers@skynet.be>
4033
4034 * python/python.c (do_start_initialization): Make progname_copy static,
4035 to avoid a leak report.
4036
8634b462
TT		 40372019-09-08 Tom Tromey <tom@tromey.com>
4038
4039 * tui/tui-wingeneral.c (box_win): Truncate long window titles.
4040
c7f839cb
SM		 40412019-09-07 Simon Marchi <simon.marchi@efficios.com>
4042
4043 * dwarf2read.c (struct dw2_symtab_iterator) <block_index>:
4044 Change type to gdb::optional<block_enum>.
4045 (dw2_symtab_iter_init): Change block_index parameter type
4046 to gdb::optional<block_enum>.
4047 (dw2_lookup_symbol): Change block_index parameter
4048 type to block_enum.c
4049 (dw2_debug_names_lookup_symbol): Likewise.
4050 * psymtab.c (psym_lookup_symbol): Likewise.
4051 * symfile-debug.c (debug_qf_lookup_symbol): Likewise.
4052 * symfile.h (struct quick_symbol_functions) <lookup_symbol>:
4053 Likewise.
4054
ead0e69a
CB		 40552019-09-06 Christian Biesinger <cbiesinger@google.com>
4056
4057 * defs.h (relocate_gdb_directory): Change int to bool in
4058 signature and rename flag to relocatable.
4059 * main.c (relocate_path): Likewise.
4060 (relocate_gdb_directory): Likewise.
4061
b16c44de
AM		 40622019-09-06 Alan Modra <amodra@gmail.com>
4063
4064 * coffread.c (coff_symfile_read): Constify filename variable.
4065 * dbxread.c (dbx_symfile_init, coffstab_build_psymtabs),
4066 (elfstab_build_psymtabs, stabsect_build_psymtabs): Likewise.
4067 * gdb_bfd.c (gdb_bfd_close_or_warn): Likewise.
4068 * solib.c (reload_shared_libraries_1): Likewise.
4069 * symfile.c (reread_symbols): Likewise.
4070 * solib-aix.c (solib_aix_bfd_open): Add cast for xfree of filename.
4071 * solib-darwin.c (darwin_bfd_open): Likewise.
4072 * symfile-mem.c (symbol_file_add_from_memory): Likewise.
4073
06ff036e
AB		 40742019-09-03 Andrew Burgess <andrew.burgess@embecosm.com>
4075
4076 * psymtab.c (print_partial_symbols): Handle missing domain_enum
4077 values MODULE_DOMAIN and COMMON_BLOCK_DOMAIN.
4078
4e962e74
TT		 40792019-09-03 Tom Tromey <tromey@adacore.com>
4080
4081 * ada-valprint.c (ada_val_print_num): Don't recurse for range
4082 types.
4083 (has_negatives): Unbias a range type bound.
4084 * dwarf2read.c (read_subrange_type): Handle DW_AT_GNU_bias.
4085 * gdbtypes.c (operator==): Handle new field.
4086 (create_range_type): Add "bias" parameter.
4087 (create_static_range_type, resolve_dynamic_range): Update.
4088 * gdbtypes.h (struct range_bounds) <bias>: New member.
4089 (create_range_type): Add bias parameter.
4090 * printcmd.c (print_scalar_formatted): Unbias range types.
4091 * value.c (unpack_long): Unbias range types.
4092 (pack_long): Bias range types.
4093
d90b8f26
AH		 40942019-09-02 Alan Hayward <alan.hayward@arm.com>
4095
4096 * solib-svr4.c (svr4_find_and_create_probe_breakpoints): Check all
4097 probe arguments.
4098
fe01123e
AH		 40992019-09-02 Alan Hayward <alan.hayward@arm.com>
4100
4101 * break-catch-throw.c (fetch_probe_arguments): Use gdbarch.
4102 * dtrace-probe.c (dtrace_probe::get_argument_count): Likewise.
4103 * probe.c (probe_safe_evaluate_at_pc) (compute_probe_arg)
4104 (compile_probe_arg): Likewise.
4105 * probe.h (get_argument_count): Likewise.
4106 * solib-svr4.c (solib_event_probe_action): Likewise.
4107 * stap-probe.c (stap_probe::get_argument_count): Likewise.
4108
e661ef01
AH		 41092019-09-02 Alan Hayward <alan.hayward@arm.com>
4110
4111 * solib-svr4.c (svr4_find_and_create_probe_breakpoints): Move
4112 code to here...
4113 (svr4_create_solib_event_breakpoints): ...from here.
4114
47a536d9
SDJ		 41152019-08-30 Sergio Durigan Junior <sergiodj@redhat.com>
4116
4117 * nat/fork-inferior.c (trace_start_error): Remove "\nError: "
4118 suffix from warning message.
4119
d6a00eba
TT		 41202019-08-30 Tom Tromey <tom@tromey.com>
4121
4122 * tui/tui-winsource.h (struct tui_source_window_base)
4123 <refresh_all>: Don't declare.
4124 * tui/tui-winsource.c (tui_source_window_base::refresh_all):
4125 Remove.
4126 * tui/tui-win.c (tui_refresh_all_win): Don't call refresh_all or
4127 tui_show_locator_content.
4128 * tui/tui-regs.h (struct tui_data_window) <refresh_all>: Don't
4129 declare.
4130 * tui/tui-regs.c (tui_data_window::refresh_all): Remove.
4131 * tui/tui-data.h (struct tui_win_info) <refresh_all>: Don't
4132 declare.
4133
55b2657b
TT		 41342019-08-30 Tom Tromey <tom@tromey.com>
4135
4136 * tui/tui-io.c (tui_cont_sig): Don't call wrefresh.
4137
12a8555a
TT		 41382019-08-30 Tom Tromey <tom@tromey.com>
4139
4140 * tui/tui-stack.c (_initialize_tui_stack): Move later.
4141 Remove unnecessary forward declarations.
4142
900ac242
TT		 41432019-08-30 Tom Tromey <tom@tromey.com>
4144
4145 * tui/tui-stack.c (tui_locator_window::set_locator_fullname): Call
4146 rerender.
4147 (tui_update_locator_fullname, tui_show_frame_info): Don't call
4148 tui_show_locator_content.
4149
99ab33fb
TT		 41502019-08-30 Tom Tromey <tom@tromey.com>
4151
4152 * tui/tui-stack.c (tui_show_locator_content): Move lower. Rewrite.
4153 (tui_locator_window::rerender): Rewrite using body of previous
4154 tui_show_locator_content.
4155
e594a5d1
TT		 41562019-08-30 Tom Tromey <tom@tromey.com>
4157
4158 * tui/tui-stack.h (struct tui_locator_window) <set_locator_info,
4159 set_locator_fullname>: New methods.
4160 * tui/tui-stack.c (tui_locator_window::set_locator_fullname):
4161 Rename from tui_set_locator_fullname.
4162 (tui_locator_window::set_locator_info): Rename from
4163 tui_set_locator_info. Return bool.
4164 (tui_update_locator_fullname, tui_show_frame_info): Update.
4165
715bb467
TT		 41662019-08-30 Tom Tromey <tom@tromey.com>
4167
4168 * tui/tui-layout.c (show_layout): Don't call tui_refresh_all.
4169
772f3f03
TT		 41702019-08-30 Tom Tromey <tom@tromey.com>
4171
4172 * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Don't
4173 call touchwin.
4174
108e13ab
TT		 41752019-08-30 Tom Tromey <tom@tromey.com>
4176
4177 * tui/tui-wingeneral.c (box_win): Assume win_info and
4178 win_info->handle cannot be NULL.
4179
cdaa6eb4
TT		 41802019-08-30 Tom Tromey <tom@tromey.com>
4181
4182 * tui/tui-regs.h (struct tui_data_item_window) <rerender,
4183 refresh_window>: Declare.
4184 * tui/tui-regs.c (tui_data_window::display_registers_from): Call
4185 resize.
4186 (tui_data_item_window::rerender): Rename from
4187 tui_display_register.
4188 (tui_data_item_window::refresh_window): New method.
4189 * tui/tui-layout.c (tui_gen_win_info::resize): Do nothing on
4190 no-op.
4191
89df7f90
TT		 41922019-08-30 Tom Tromey <tom@tromey.com>
4193
4194 * tui/tui-regs.h (struct tui_data_window) <regs_content,
4195 regs_column_count, current_group>: Move later. Now private.
4196 <get_current_group>: New method.
4197 * tui/tui-regs.c (tui_reg_command): Update.
4198 * tui/tui-layout.c (tui_set_layout): Update.
4199
1bf2866a
TT		 42002019-08-30 Tom Tromey <tom@tromey.com>
4201
4202 * tui/tui-regs.c (tui_data_window::display_registers_from_line)
4203 (tui_data_window::rerender): Don't call
4204 check_and_display_highlight_if_needed.
4205 (tui_data_window::refresh_all): Remove call to
4206 erase_data_content.
4207
0670413d
TT		 42082019-08-30 Tom Tromey <tom@tromey.com>
4209
4210 * tui/tui-regs.c (tui_data_window::last_regs_line_no)
4211 (tui_data_window::display_registers_from)
4212 (tui_data_window::display_reg_element_at_line)
4213 (tui_data_window::display_registers_from_line): Remove checks of
4214 "empty".
4215
18bb55c7
TT		 42162019-08-30 Tom Tromey <tom@tromey.com>
4217
4218 * tui/tui-regs.h (struct tui_data_window) <display_all_data>:
4219 Don't declare.
4220 * tui/tui-regs.c (tui_data_window::show_registers): Call
4221 rerender.
4222 (tui_data_window::rerender): Rename from display_all_data.
4223 (tui_data_window::rerender): Remove old implementation.
4224
1f6d2f10
TT		 42252019-08-30 Tom Tromey <tom@tromey.com>
4226
4227 * tui/tui-regs.c (tui_data_window::display_all_data): Change
4228 text.
4229 * tui/tui-data.h (NO_DATA_STRING): Remove define.
4230
16d01f9c
BW		 42312019-08-29 Bernhard Wodok <barto@gmx.net>
4232 Sergio Durigan Junior <sergiodj@redhat.com>
4233
4234 PR win32/24284
4235 * mingw-hdep.c (gdb_select): Handle case when 'n' is zero.
4236
d8f27c60
AB		 42372019-08-28 Andrew Burgess <andrew.burgess@embecosm.com>
4238
4239 * symtab.c (search_symbols): Don't include MODULE_DOMAIN symbols
4240 when searching for types.
4241
1f20c35e
AB		 42422019-08-28 Andrew Burgess <andrew.burgess@embecosm.com>
4243
4244 * f-lang.c (f_language_defn): Use f_print_typedef.
4245 * f-lang.h (f_print_typedef): Declare.
4246 * f-typeprint.c (f_print_typedef): Define.
4247
550105b7
CB		 42482019-08-27 Christian Biesinger <cbiesinger@google.com>
4249
4250 * nat/linux-namespaces.c (mnsh_main): Initialize fd (to -1).
4251
4acfdd20
AB		 42522019-08-27 Andrew Burgess <andrew.burgess@embecosm.com>
4253
4254 * cli/cli-utils.c (info_print_options_defs): Delete.
4255 (make_info_print_options_def_group): Delete.
4256 (extract_info_print_options): Delete.
4257 (info_print_command_completer): Delete.
4258 (info_print_args_help): Add extra parameter, and optionally
4259 include text about -n flag.
4260 * cli/cli-utils.h (struct info_print_options): Delete.
4261 (extract_info_print_options): Delete declaration.
4262 (info_print_command_completer): Delete declaration.
4263 (info_print_args_help): Add extra parameter, extend header
4264 comment.
4265 * python/python.c (gdbpy_rbreak): Pass additional parameter to
4266 search_symbols.
4267 * stack.c (struct info_print_options): New type.
4268 (info_print_options_defs): New file scoped variable.
4269 (make_info_print_options_def_group): New static function.
4270 (info_print_command_completer): New static function.
4271 (info_locals_command): Update to use new local functions.
4272 (info_args_command): Likewise.
4273 (_initialize_stack): Add extra parameter to calls to
4274 info_print_args_help.
4275 * symtab.c (search_symbols): Add extra parameter, use this to
4276 possibly excluse non-debug symbols.
4277 (symtab_symbol_info): Add extra parameter, which is passed on to
4278 search_symbols.
4279 (struct info_print_options): New type.
4280 (info_print_options_defs): New file scoped variable.
4281 (make_info_print_options_def_group): New static function.
4282 (info_print_command_completer): New static function.
4283 (info_variables_command): Update to use local functions, and pass
4284 extra parameter through to symtab_symbol_info.
4285 (info_functions_command): Likewise.
4286 (info_types_command): Pass additional argument through to
4287 symtab_symbol_info.
4288 (rbreak_command): Pass extra argument to search_symbols.
4289 (_initialize_symtab): Add extra arguments for calls to
4290 info_print_args_help, and update help text for 'info variables',
4291 'whereis', and 'info functions' commands.
4292 * symtab.h (search_symbols): Add extra argument to declaration.
4293 * NEWS: Mention new flags.
4294
9aa55206
CB		 42952019-08-26 Christian Biesinger <cbiesinger@google.com>
4296
4297 * symtab.c (lookup_static_symbol): Call the new function (and move
4298 it down to be next to lookup_global_symbol).
4299 (struct global_sym_lookup_data): Add block_enum member and rename to...
4300 (struct global_or_static_sym_lookup_data): ...this.
4301 (lookup_symbol_global_iterator_cb): Pass block_index instead of
4302 GLOBAL_BLOCK to lookup_symbol_in_objfile and rename to...
4303 (lookup_symbol_global_or_static_iterator_cb): ...this.
4304 (lookup_global_or_static_symbol): New function.
4305 (lookup_global_symbol): Call new function.
4306
5c31b358
TV		 43072019-08-26 Tom de Vries <tdevries@suse.de>
4308
4309 PR c++/24852
4310 * break-catch-throw.c (fetch_probe_arguments): Improve error mesage
4311 when pc_probe.prob == NULL.
4312
23c13d42
SM		 43132019-08-25 Simon Marchi <simon.marchi@efficios.com>
4314
4315 * dwarf2read.c (dw2_debug_names_iterator::next): Rename local
4316 variable symbol_linkage to symbol_linkage_.
4317
beadd3e8
SM		 43182019-08-25 Simon Marchi <simon.marchi@efficios.com>
4319
4320 * dwarf2read.c (dw2_debug_names_iterator::next): Use enum to
4321 represent whether the symbol is static, dynamic, or we don't
4322 know.
4323
e3ec872f
YS		 43242019-08-25 Yoshinori Sato <ysato@users.sourceforge.jp>
4325
4326 * gdb/rx-tdep.c (rx_register_names): New.
4327 (rx_register_name): Delete.
4328 (rx_psw_type): Delete.
4329 (rx_fpsw_type): Delete.
4330 (rx_register_type): Delete.
4331 (rx_gdbarch_init): Convert target-descriptions.
4332 (_initialize_rx_tdep): Add initialize_tdesc_rx.
4333 * gdb/features/Makefile: Add rx.xml.
4334 * gdb/features/rx.xml: New.
4335 * gdb/features/rx.c: Generated.
4336 * gdb/NEWS: Mention target description support.
4337
d0509ba4
CB		 43382019-08-22 Christian Biesinger <cbiesinger@google.com>
4339
4340 * symtab.c (symbol_cache_lookup): Always initialize *bsc_ptr and
4341 *slot_ptr.
4342
2d41fa11
SDJ		 43432019-08-23 Sergio Durigan Junior <sergiodj@redhat.com>
4344
4345 * configure.ac: Don't check for 'dlfcn.h' (moved to
4346 gdbsupport/common.m4).
4347 * Makefile.in (COMMON_SFILES): Move 'gdb-dlfcn.c' to
4348 'gdbsupport/'.
4349 (HFILES_NO_SRCDIR): Likewise, for 'gdb-dlfcn.h'.
4350 * compile/compile-c-support.c: Include
4351 'gdbsupport/gdb-dlfcn.h'.
4352 * gdbsupport/common.m4: Check for 'dlfcn.h'.
4353 * gdb-dlfcn.c: Move to...
4354 * gdbsupport/gdb-dlfcn.c: ... here.
4355 * gdb-dlfcn.h: Move to...
4356 * gdbsupport/gdb-dlfcn.h: ... here.
4357
de8af808
SL		 43582019-08-23 Sandra Loosemore <sandra@codesourcery.com>
4359
4360 * nios2-tdep.c (struct reg_value): Improve comments. Make
4361 the offset field signed.
4362
27204489
CB		 43632019-08-22 Christian Biesinger <cbiesinger@google.com>
4364
4365 * python/lib/gdb/__init__.py (_execute_file): New function.
4366 * python/python.c (python_run_simple_file): Call gdb._execute_file
4367 on Windows.
4368
43771869
AB		 43692019-08-22 Andrew Burgess <andrew.burgess@embecosm.com>
4370
4371 * f-exp.y (yylex): Remove is_a_field_of_this local variable, and
4372 all uses as this was never set to anything but a zero value.
4373
26c957f1
PA		 43742019-08-21 Bogdan Harjoc <harjoc@gmail.com>
4375
4376 * cli/cli-cmds.c (with_command_1): Error out if no arguments.
4377
c07aae6e
CB		 43782019-08-21 Christian Biesinger <cbiesinger@google.com>
4379
4380 * tui/tui-data.h (tui_gen_win_info): Add an =default
4381 move constructor, required by some GCC versions.
4382
3960cb7a
JF		 43832019-08-21 Jinke Fan <fanjinke51@yeah.net>
4384
4385 * go32-nat.c (go32_sysinfo): Add hygon_p.
4386
04c72a68
TT		 43872019-08-20 Tom Tromey <tom@tromey.com>
4388
4389 * tui/tui-regs.h (struct tui_data_window) <last_regs_line_no,
4390 line_from_reg_element_no, first_reg_element_no_inline,
4391 display_all_data, delete_data_content_windows,
4392 erase_data_content>: Now private.
4393
072272ce
TT		 43942019-08-20 Tom Tromey <tom@tromey.com>
4395
4396 * tui/tui-wingeneral.c (box_win): Change type of highlight_flag.
4397 (tui_unhighlight_win, tui_highlight_win)
4398 (tui_win_info::make_window): Update.
4399 * tui/tui-data.h (HILITE, NO_HILITE): Remove.
4400
973961bd
TT		 44012019-08-20 Tom Tromey <tom@tromey.com>
4402
4403 * tui/tui-data.h (PROC_PREFIX, LINE_PREFIX, PC_PREFIX)
4404 (MIN_LINE_WIDTH, MIN_PROC_WIDTH, MAX_TARGET_WIDTH)
4405 (MAX_PID_WIDTH): Move to tui-stack.c.
4406 * tui/tui-stack.c (PROC_PREFIX, LINE_PREFIX, PC_PREFIX)
4407 (MIN_LINE_WIDTH, MIN_PROC_WIDTH, MAX_TARGET_WIDTH)
4408 (MAX_PID_WIDTH): Move from tui-data.h.
4409
ab0e1f1a
TT		 44102019-08-20 Tom Tromey <tom@tromey.com>
4411
4412 * tui/tui-wingeneral.h (tui_make_window): Don't declare.
4413 * tui/tui-wingeneral.c (box_win): Change type of win_info.
4414 (box_win): Update.
4415 (tui_gen_win_info::make_window): Rename from tui_make_window.
4416 (tui_win_info::make_window): New method.
4417 (tui_gen_win_info::make_visible): Update.
4418 * tui/tui-source.c (tui_source_window::set_contents): Update.
4419 * tui/tui-regs.c (tui_data_window::show_register_group): Update.
4420 (tui_data_window::display_registers_from): Update.
4421 * tui/tui-layout.c (tui_gen_win_info::resize): Update.
4422 * tui/tui-data.h (struct tui_gen_win_info) <make_window>:
4423 Declare.
4424 <can_box>: Remove.
4425 <title>: Remove.
4426 (struct tui_win_info) <make_window>: Declare.
4427 <can_box>: Now virtual.
4428 <title>: New member.
4429 * tui/tui-data.c (~tui_gen_win_info): Don't free title.
4430 * tui/tui-command.c (tui_cmd_window::resize): Update.
4431
100c2bf3
TT		 44322019-08-20 Tom Tromey <tom@tromey.com>
4433
4434 * tui/tui-regs.h (struct tui_data_window) <display_regs>: Remove.
4435 * tui/tui-regs.c (tui_data_window::show_registers): Update.
4436 (tui_data_window::check_register_values): Update.
4437
fa4dc567
TT		 44382019-08-20 Tom Tromey <tom@tromey.com>
4439
4440 * tui/tui-regs.h (struct tui_data_window): Use
4441 DISABLE_COPY_AND_ASSIGN.
4442 <regs_content>: Change type, removing unique_ptr.
4443 <tui_data_window>: Add move constructor.
4444 * tui/tui-regs.c (tui_data_window::show_registers)
4445 (tui_data_window::show_register_group)
4446 (tui_data_window::display_registers_from)
4447 (tui_data_window::display_registers_from)
4448 (tui_data_window::first_data_item_displayed)
4449 (tui_data_window::delete_data_content_windows)
4450 (tui_data_window::rerender, tui_data_window::refresh_window)
4451 (tui_data_window::check_register_values): Update.
4452
ca02d7c8
TT		 44532019-08-20 Tom Tromey <tom@tromey.com>
4454
4455 * tui/tui-regs.h (struct tui_data_window) <show_registers,
4456 show_register_group>: Declare.
4457 (tui_show_register_group): Don't declare.
4458 * tui/tui-regs.c (tui_data_window::show_registers): Rename from
4459 tui_show_registers.
4460 (tui_data_window::show_register_group): Rename from
4461 tui_show_register_group.
4462 (tui_data_window::check_register_values, tui_reg_command):
4463 Update.
4464 * tui/tui-layout.c (tui_set_layout): Update.
4465
63356bfd
TT		 44662019-08-20 Tom Tromey <tom@tromey.com>
4467
4468 * tui/tui-regs.h (struct tui_data_window) <check_register_values>:
4469 Declare.
4470 (tui_check_register_values): Don't declare.
4471 * tui/tui-regs.c (tui_data_window::check_register_values): Rename
4472 from tui_check_register_values.
4473 * tui/tui-hooks.c (tui_register_changed): Update.
4474
42cc14a7
TT		 44752019-08-20 Tom Tromey <tom@tromey.com>
4476
4477 * tui/tui-regs.c (tui_reg_layout): Move later.
4478 (tui_show_registers): Don't enable TUI mode or change layout.
4479
b9ad3686
TT		 44802019-08-20 Tom Tromey <tom@tromey.com>
4481
4482 * tui/tui-regs.h (struct tui_data_item_window)
4483 <~tui_data_item_window>: Remove.
4484 <content>: Now a unique_xmalloc_ptr.
4485 * tui/tui-regs.c (tui_register_format): Return a
4486 unique_xmalloc_ptr.
4487 (tui_get_register): Update.
4488 (~tui_data_item_window): Remove.
4489 (tui_data_window::display_registers_from, tui_display_register):
4490 Update.
4491 * tui/tui-io.h (tui_expand_tabs): Update.
4492 * tui/tui-io.c (tui_expand_tabs): Return a unique_xmalloc_ptr.
4493 Remove "col" parameter.
4494
8e114aab
TT		 44952019-08-20 Tom Tromey <tom@tromey.com>
4496
4497 * tui/tui-regs.h (struct tui_data_item_window) <value>: Remove
4498 field.
4499 * tui/tui-regs.c (~tui_data_item_window): Update.
4500
1a4f81dd
TT		 45012019-08-20 Tom Tromey <tom@tromey.com>
4502
4503 * tui/tui-regs.c (tui_register_format, tui_get_register): Move
4504 earlier.
4505
0f8d8876
TT		 45062019-08-20 Tom Tromey <tom@tromey.com>
4507
4508 * tui/tui-regs.c (tui_reg_command): Remove NULL check.
4509
605dc2c2
TT		 45102019-08-20 Tom Tromey <tom@tromey.com>
4511
4512 * tui/tui-source.h (struct tui_source_window): Update.
4513 * tui/tui-regs.c (tui_show_registers): Update.
4514 * tui/tui-disasm.h (struct tui_disasm_window): Update.
4515 * tui/tui-data.h (NO_SRC_STRING, NO_DISASSEM_STRING)
4516 (NO_REGS_STRING): Remove defines.
4517
aedbe3bb
CM		 45182019-08-20 Conrad Meyer <cem@FreeBSD.org>
4519
4520 * remote.c (remote_target::remote_btrace_maybe_reopen): Avoid
4521 unnecessary thread walk if remote doesn't support the packet.
4522
7ce8f214
TT		 45232019-08-19 Tom Tromey <tromey@adacore.com>
4524
4525 * python/py-value.c (value_has_field): Fix indentation.
4526
f21c2bd7
TT		 45272019-08-19 Tom Tromey <tromey@adacore.com>
4528
4529 * printcmd.c (do_one_display, info_display_command): Update.
4530 * block.h (contained_in): Return bool. Add allow_nested
4531 parameter.
4532 * block.c (contained_in): Return bool. Add allow_nested
4533 parameter.
4534
d806ea2d
TT		 45352019-08-19 Tom Tromey <tom@tromey.com>
4536
4537 * configure: Rebuild.
4538 * configure.ac: Disallow the combination of -static-libstdc++ and
4539 source highlight.
4540 * source-cache.c (get_language_name): Handle rust.
4541 (source_cache::get_source_lines): Ignore highlighting exceptions.
4542
398fdd60
TT		 45432019-08-16 Tom Tromey <tom@tromey.com>
4544
4545 * tui/tui.h (enum tui_win_type) <EXEC_INFO_WIN>: Remove.
4546 * tui/tui-winsource.h (struct tui_exec_info_window): Remove.
4547 (struct tui_source_window_base) <make_visible, refresh_window,
4548 resize>: Remove methods.
4549 <execution_info>: Remove field.
4550 * tui/tui-winsource.c (tui_source_window_base::do_erase_source_content)
4551 (tui_show_source_line, tui_source_window_base)
4552 (~tui_source_window_base): Update.
4553 (tui_source_window_base::resize)
4554 (tui_source_window_base::make_visible)
4555 (tui_source_window_base::refresh_window): Remove.
4556 (tui_source_window_base::update_exec_info): Update.
4557 * tui/tui-source.c (tui_source_window::set_contents): Update.
4558 * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
4559
e699d331
TT		 45602019-08-16 Tom Tromey <tom@tromey.com>
4561
4562 * tui/tui-hooks.c (tui_remove_hooks): Don't set
4563 deprecated_query_hook.
4564
bb01dbfc
TT		 45652019-08-16 Tom Tromey <tom@tromey.com>
4566
4567 * tui/tui-winsource.c (tui_update_source_windows_with_addr)
4568 (tui_update_source_windows_with_line): Update.
4569 * tui/tui-source.h (struct tui_source_window)
4570 <show_symtab_source>: Declare.
4571 (tui_show_symtab_source): Don't declare.
4572 * tui/tui-source.c (tui_show_symtab_source): Rename from
4573 tui_show_symtab_source.
4574
81c82c4b
TT		 45752019-08-16 Tom Tromey <tom@tromey.com>
4576
4577 * tui/tui-winsource.h (struct tui_source_window_base)
4578 <set_contents>: Declare.
4579 * tui/tui-winsource.c
4580 (tui_source_window_base::update_source_window_as_is): Update.
4581 * tui/tui-source.h (struct tui_source_window) <set_contents>:
4582 Declare.
4583 (tui_set_source_content): Don't declare.
4584 * tui/tui-source.c (tui_source_window::set_contents): Rename from
4585 tui_set_source_content.
4586 * tui/tui-disasm.h (struct tui_disasm_window) <set_contents>:
4587 Declare.
4588 (tui_set_disassem_content): Don't declare.
4589 * tui/tui-disasm.c (tui_disasm_window::set_contents): Rename from
4590 tui_set_disassem_content.
4591
2ddaf614
TT		 45922019-08-16 Tom Tromey <tom@tromey.com>
4593
4594 * tui/tui-winsource.h (struct tui_source_window_base)
4595 <update_breakpoint_info>: Declare.
4596 (tui_update_breakpoint_info): Don't declare.
4597 * tui/tui-winsource.c (tui_source_window_base::update_source_window_as_is)
4598 (tui_update_all_breakpoint_info): Update.
4599 (tui_source_window_base::update_breakpoint_info): Rename from
4600 tui_update_breakpoint_info.
4601 (tui_source_window_base::update_exec_info): Update.
4602
017f9828
TT		 46032019-08-16 Tom Tromey <tom@tromey.com>
4604
4605 * tui/tui-winsource.h (struct tui_source_window_base)
4606 <update_source_window>: Declare.
4607 (tui_update_source_window): Don't declare.
4608 * tui/tui-winsource.c
4609 (tui_source_window_base::update_source_window): Rename from
4610 tui_update_source_window.
4611 (tui_source_window_base::rerender): Update.
4612 * tui/tui-source.c (tui_source_window::maybe_update): Update.
4613 * tui/tui-disasm.c (tui_show_disassem)
4614 (tui_show_disassem_and_update_source)
4615 (tui_disasm_window::maybe_update): Update.
4616
ed8358e9
TT		 46172019-08-16 Tom Tromey <tom@tromey.com>
4618
4619 * tui/tui-winsource.h (struct tui_source_window_base)
4620 <update_source_window_as_is>: Declare.
4621 (tui_update_source_window_as_is): Don't declare.
4622 * tui/tui-winsource.c (tui_update_source_window): Update
4623 (tui_source_window_base::update_source_window_as_is): Rename from
4624 tui_update_source_window_as_is.
4625 (tui_source_window_base::refill): Update.
4626 * tui/tui-source.c (tui_show_symtab_source): Update.
4627 * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical):
4628 Update.
4629
20149b6b
TT		 46302019-08-16 Tom Tromey <tom@tromey.com>
4631
4632 * tui/tui-winsource.h (tui_update_source_window)
4633 (tui_update_source_window_as_is): Remove "noerror" parameter.
4634 * tui/tui-winsource.c (tui_update_source_window)
4635 (tui_update_source_window_as_is): Remove "noerror" parameter.
4636 (tui_update_source_windows_with_addr)
4637 (tui_update_source_windows_with_line)
4638 (tui_source_window_base::rerender)
4639 (tui_source_window_base::refill): Update.
4640 * tui/tui-source.h (tui_set_source_content)
4641 (tui_show_symtab_source): Remove "noerror" parameter.
4642 * tui/tui-source.c (tui_set_source_content): Remove "noerror"
4643 parameter.
4644 (tui_show_symtab_source): Likewise.
4645 (tui_source_window::maybe_update): Update.
4646 * tui/tui-disasm.c (tui_show_disassem)
4647 (tui_show_disassem_and_update_source)
4648 (tui_disasm_window::do_scroll_vertical)
4649 (tui_disasm_window::maybe_update): Update.
4650
2d83e710
TT		 46512019-08-16 Tom Tromey <tom@tromey.com>
4652
4653 * tui/tui.c (tui_is_window_visible): Update.
4654 * tui/tui-wingeneral.c (tui_make_window)
4655 (tui_gen_win_info::make_visible, tui_refresh_all): Update.
4656 * tui/tui-win.c (window_name_completer, tui_refresh_all_win)
4657 (tui_set_focus_command, tui_all_windows_info, update_tab_width)
4658 (tui_set_win_height_command, parse_scrolling_args): Update.
4659 * tui/tui-source.c (tui_source_window::style_changed): Update.
4660 * tui/tui-regs.c (tui_show_registers)
4661 (tui_data_window::first_data_item_displayed)
4662 (tui_data_window::delete_data_content_windows)
4663 (tui_check_register_values, tui_reg_command): Update.
4664 * tui/tui-disasm.c (tui_show_disassem): Update.
4665 * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: New
4666 method.
4667 <is_visible>: Remove field.
4668 * tui/tui-data.c (tui_next_win, tui_prev_win)
4669 (tui_delete_invisible_windows): Update.
4670
d4ab829a
TT		 46712019-08-16 Tom Tromey <tom@tromey.com>
4672
4673 * tui/tui-winsource.h (struct tui_source_window_base)
4674 <m_has_locator>: Remove.
4675 * tui/tui-layout.c (show_source_disasm_command, show_data)
4676 (show_source_or_disasm_and_command): Update.
4677
aa7ca1bb
AH		 46782019-08-16 Alan Hayward <alan.hayward@arm.com>
4679
4680 * NEWS (Other MI changes): New subsection.
4681 * aarch64-tdep.c (aarch64_get_pc_address_flags): New function.
4682 (aarch64_gdbarch_init): Add aarch64_get_pc_address_flags.
4683 * arch-utils.c (default_get_pc_address_flags): New function.
4684 * arch-utils.h (default_get_pc_address_flags): New declaration.
4685 * gdbarch.sh: Add get_pc_address_flags.
4686 * gdbarch.c: Regenerate.
4687 * gdbarch.h: Likewise.
4688 * stack.c (print_pc): New function.
4689 (print_frame_info) (print_frame): Call print_pc.
4690
6eac171f
TV		 46912019-08-16 Tom de Vries <tdevries@suse.de>
4692
4693 * maint.c (maintenance_info_sections): Also handle !ALLOBJ case using
4694 print_objfile_section_info.
4695
3df505f6
TT		 46962019-08-15 Tom Tromey <tom@tromey.com>
4697
4698 * tui/tui-io.c (tui_puts_internal): Check TUI_CMD_WIN before
4699 calling update_cmdwin_start_line.
4700 * tui/tui-winsource.h (struct tui_source_window_base)
4701 <do_make_visible_with_new_height, set_new_height>: Don't declare.
4702 <rerender>: Declare.
4703 * tui/tui-winsource.c (tui_source_window_base::update_tab_width):
4704 Call rerender.
4705 (tui_source_window_base::set_new_height): Remove.
4706 (tui_source_window_base::rerender): Rename from
4707 do_make_visible_with_new_height.
4708 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Use
4709 resize method.
4710 (tui_win_info::make_invisible_and_set_new_height)
4711 (tui_win_info::make_visible_with_new_height): Remove.
4712 * tui/tui-stack.h (struct tui_locator_window) <rerender>:
4713 Declare.
4714 * tui/tui-stack.c (tui_locator_window::rerender): New method.
4715 * tui/tui-regs.h (struct tui_data_window) <set_new_height,
4716 do_make_visible_with_new_height>: Don't declare.
4717 <rerender>: Declare.
4718 * tui/tui-regs.c (tui_data_window::rerender): Rename from
4719 set_new_height.
4720 (tui_data_window::do_make_visible_with_new_height): Remove.
4721 * tui/tui-layout.c (show_source_disasm_command, show_data): Don't
4722 call tui_show_locator_content.
4723 (tui_gen_win_info::resize): Call rerender.
4724 (show_source_or_disasm_and_command): Don't call
4725 tui_show_locator_content.
4726 * tui/tui-data.h (struct tui_gen_win_info) <rerender>: New
4727 method.
4728 (struct tui_win_info) <rerender>: Declare.
4729 <set_new_height, make_invisible_and_set_new_height,
4730 make_visible_with_new_height>: Don't declare.
4731 * tui/tui-data.c (tui_win_list::rerender): New method.
4732 * tui/tui-command.h (struct tui_cmd_window)
4733 <do_make_visible_with_new_height>: Don't declare.
4734 * tui/tui-command.c
4735 (tui_cmd_window::do_make_visible_with_new_height): Remove.
4736
272560b5
TT		 47372019-08-15 Tom Tromey <tromey@adacore.com>
4738
4739 * ada-exp.y (convert_char_literal): Handle "Q%c" encoding.
4740 * ada-lang.c (ada_enum_name): Likewise.
4741
08235187
CB		 47422019-08-15 Christian Biesinger <cbiesinger@google.com>
4743
4744 * python/lib/gdb/__init__.py (GdbOutputFile): Rename to have a
4745 leading underscore.
4746 (GdbOutputErrorFile): Likewise.
4747 (global scope): Adjust constructor calls to GdbOutput{,Error}File
4748 accordingly.
4749 (execute_unwinders): Rename to have a leading underscore.
4750 (auto_load_packages): Likewise.
4751 (global scope): Adjust call to auto_load_packages accordingly.
4752 (GdbSetPythonDirectory): Likewise.
4753 * python/py-unwind.c (pyuw_sniffer): Call _execute_unwinders
4754 instead of execute_unwinders.
4755
db502012
TT		 47562019-08-15 Tom Tromey <tom@tromey.com>
4757
4758 * tui/tui-layout.c (show_layout, show_source_disasm_command)
4759 (show_data): Don't change window visibility.
4760 (tui_gen_win_info::resize): Remove special case for command
4761 window. Use wresize, when available.
4762 (show_source_or_disasm_and_command): Don't change window
4763 visibility.
4764 * tui/tui-command.h (struct tui_cmd_window) <resize>: Declare.
4765 <make_visible>: New method.
4766 * tui/tui-command.c (tui_cmd_window::resize): New method.
4767
3891b65e
TT		 47682019-08-15 Tom Tromey <tom@tromey.com>
4769
4770 * tui/tui-winsource.h (struct tui_source_window_iterator): New.
4771 (struct tui_source_windows): New.
4772 * tui/tui-winsource.c (tui_display_main): Update.
4773 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
4774 (new_height_ok, parse_scrolling_args): Update.
4775 * tui/tui-layout.c (show_layout, show_data): Update.
4776 * tui/tui-data.h (tui_source_windows, tui_clear_source_windows)
4777 (tui_add_to_source_windows): Don't declare.
4778 * tui/tui-data.c (source_windows, tui_source_windows)
4779 (tui_clear_source_windows, tui_add_to_source_windows): Remove.
4780
ee556432
TT		 47812019-08-15 Tom Tromey <tom@tromey.com>
4782
4783 * tui/tui-winsource.h (struct tui_source_window_base) <resize>:
4784 Rename from reset.
4785 * tui/tui-winsource.c (tui_source_window_base::resize): Rename.
4786 * tui/tui-layout.c (show_source_disasm_command, show_data):
4787 Update.
4788 (tui_gen_win_info::resize): Rename.
4789 (show_source_or_disasm_and_command): Update.
4790 * tui/tui-data.h (struct tui_gen_win_info) <resize>: Rename from
4791 reset.
4792
46f438e3
TT		 47932019-08-15 Tom Tromey <tom@tromey.com>
4794
4795 * tui/tui-stack.c (tui_initialize_static_data): Remove.
4796 * tui/tui-interp.c (tui_interp::init): Don't call
4797 tui_initialize_static_data.
4798 * tui/tui-data.h (tui_initialize_static_data): Don't declare.
4799
f4ce562c
TT		 48002019-08-15 Tom Tromey <tom@tromey.com>
4801
4802 * tui/tui-layout.c (tui_default_win_viewport_height): Don't
4803 examine tui_win_list.
4804
c398c3d0
TT		 48052019-08-15 Tom Tromey <tom@tromey.com>
4806
4807 * tui/tui-winsource.h (tui_clear_source_content): Don't declare.
4808 * tui/tui-winsource.c (tui_update_source_window_as_is): Don't call
4809 tui_clear_source_content.
4810 (tui_clear_source_content): Remove.
4811 (tui_source_window_base::do_erase_source_content): Hoist call to
4812 content.clear().
4813 * tui/tui-stack.c (tui_show_frame_info): Don't call
4814 tui_clear_source_content.
4815
e25d2004
TT		 48162019-08-15 Tom Tromey <tom@tromey.com>
4817
4818 * tui/tui-winsource.h (struct tui_source_window_base)
4819 <do_erase_source_content>: New method.
4820 <erase_source_content>: New method.
4821 (tui_erase_source_content): Don't declare.
4822 * tui/tui-winsource.c (tui_clear_source_content): Update.
4823 (tui_source_window_base::do_erase_source_content): Rename from
4824 tui_erase_source_content.
4825 (tui_source_window_base::show_source_content): Update.
4826 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
4827 * tui/tui-source.h (struct tui_source_window)
4828 <erase_source_content>: New method.
4829 * tui/tui-disasm.h (struct tui_disasm_window)
4830 <erase_source_content>: New method.
4831
002f15c2
TT		 48322019-08-15 Tom Tromey <tom@tromey.com>
4833
4834 * tui/tui-winsource.h (tui_alloc_source_buffer): Don't declare.
4835 (struct tui_source_element): Add DISABLE_COPY_AND_ASSIGN, and move
4836 constructor.
4837 * tui/tui-winsource.c (tui_alloc_source_buffer): Remove.
4838 * tui/tui-source.c (tui_set_source_content): Update.
4839 * tui/tui-disasm.c (tui_set_disassem_content): Update.
4840
c9033fe8
TT		 48412019-08-15 Tom Tromey <tom@tromey.com>
4842
4843 * tui/tui-winsource.h (tui_line_is_displayed): Don't declare.
4844 * tui/tui-winsource.c (tui_line_is_displayed): Move to
4845 tui-source.c.
4846 * tui/tui-source.h (struct tui_source_window) <line_is_displayed>:
4847 Declare.
4848 * tui/tui-source.c (tui_source_window::line_is_displayed): New
4849 method.
4850 (tui_source_window::maybe_update): Update.
4851
088f37dd
TT		 48522019-08-15 Tom Tromey <tom@tromey.com>
4853
4854 * tui/tui-winsource.h (tui_addr_is_displayed): Don't declare.
4855 * tui/tui-winsource.c (tui_addr_is_displayed): Move to
4856 tui-disasm.c.
4857 * tui/tui-disasm.h (struct tui_disasm_window) <addr_is_displayed>:
4858 Declare.
4859 * tui/tui-disasm.c (tui_disasm_window::addr_is_displayed): New
4860 method.
4861 (tui_disasm_window::maybe_update): Update.
4862
a54700c6
TT		 48632019-08-15 Tom Tromey <tom@tromey.com>
4864
4865 * tui/tui-winsource.h (struct tui_source_window_base)
4866 <maybe_update>: Declare.
4867 * tui/tui-stack.c (tui_show_frame_info): Call maybe_update
4868 method.
4869 * tui/tui-source.h (struct tui_source_window) <maybe_update>:
4870 Declare.
4871 * tui/tui-source.c (tui_source_window::maybe_update): New method.
4872 * tui/tui-disasm.h (struct tui_disasm_window) <maybe_update>:
4873 Declare.
4874 * tui/tui-disasm.c (tui_disasm_window::maybe_update): New method.
4875
e2a678a5
TT		 48762019-08-15 Tom Tromey <tom@tromey.com>
4877
4878 * tui/tui-stack.c (tui_make_status_line): Use string constructor.
4879
f2dda477
TT		 48802019-08-15 Tom Tromey <tom@tromey.com>
4881
4882 * tui/tui-wingeneral.c: Include tui-stack.h.
4883 * tui/tui-stack.h (MAX_LOCATOR_ELEMENT_LEN)
4884 (struct tui_locator_window): Move from tui-data.h.
4885 * tui/tui-stack.c (_locator, tui_locator_win_info_ptr)
4886 (tui_initialize_static_data): Move from tui-data.c.
4887 * tui/tui-data.h (MAX_LOCATOR_ELEMENT_LEN)
4888 (struct tui_locator_window): Move to tui-stack.c.
4889 * tui/tui-data.c (_locator, tui_locator_win_info_ptr)
4890 (tui_initialize_static_data): Move to tui-stack.c.
4891
ed4a1084
TT		 48922019-08-15 Tom Tromey <tom@tromey.com>
4893
4894 * tui/tui-layout.c (show_source_disasm_command)
4895 (show_source_or_disasm_and_command): Use make_visible method, not
4896 tui_make_window.
4897 * tui/tui-command.h (struct tui_cmd_window) <make_visible>:
4898 Remove.
4899
65962b20
TT		 49002019-08-15 Tom Tromey <tom@tromey.com>
4901
4902 * tui/tui-wingeneral.h (tui_make_window): Update.
4903 * tui/tui-wingeneral.c (tui_make_window): Remove "box_it"
4904 parameter.
4905 (tui_gen_win_info::make_visible): Update.
4906 * tui/tui-regs.c (tui_data_window::display_registers_from):
4907 Update.
4908 * tui/tui-layout.c (show_source_disasm_command)
4909 (show_source_or_disasm_and_command): Update.
4910 * tui/tui-data.h (struct tui_gen_win_info) <can_box>: New method.
4911 (enum tui_box): Remove.
4912 (struct tui_win_info) <can_box>: New method.
4913 * tui/tui-command.h (struct tui_cmd_window) <can_box>: New
4914 method.
4915
2208ee91
TV		 49162019-08-15 Tom de Vries <tdevries@suse.de>
4917
4918 * linux-nat-trad.c: Include gdbarch.h.
4919
75faf5c4
AH		 49202019-08-14 Alan Hayward <alan.hayward@arm.com>
4921
4922 * aarch64-tdep.c (aarch64_analyze_prologue): Allow any valid
4923 register sizes.
4924
b1c896b3
TT		 49252019-08-14 Tom Tromey <tromey@adacore.com>
4926
4927 * darwin-nat.c: Include gdbarch.h.
4928 * darwin-nat-info.c: Include gdbarch.h.
4929
6405cd73
TT		 49302019-08-13 Tom Tromey <tom@tromey.com>
4931
4932 * tui/tui-data.h (struct tui_gen_win_info) <last_visible_line>:
4933 Remove.
4934 * tui/tui-data.c (tui_initialize_static_data): Update.
4935
5216580d
TT		 49362019-08-13 Tom Tromey <tom@tromey.com>
4937
4938 * tui/tui-winsource.h (struct tui_exec_info_window)
4939 <~tui_exec_info_window, maybe_allocate_content, get_content,
4940 m_content>: Remove.
4941 (struct tui_source_window_base) <set_exec_info_content,
4942 show_exec_info_content>: Don't declare.
4943 * tui/tui-winsource.c
4944 (tui_exec_info_window::maybe_allocate_content): Remove.
4945 (tui_source_window_base::update_exec_info): Rename from
4946 set_exec_info_content.
4947 (tui_source_window_base::show_exec_info_content)
4948 (tui_source_window_base::update_exec_info): Remove.
4949
93858ad3
TT		 49502019-08-13 Tom Tromey <tom@tromey.com>
4951
4952 * tui/tui-winsource.h (tui_clear_exec_info_content): Don't
4953 declare.
4954 * tui/tui-winsource.c (tui_update_source_window_as_is)
4955 (tui_update_source_windows_with_addr, tui_erase_source_content):
4956 Update.
4957 (tui_clear_exec_info_content): Remove.
4958
e321e7ce
TT		 49592019-08-13 Tom Tromey <tom@tromey.com>
4960
4961 * tui/tui-winsource.h (tui_erase_exec_info_content): Don't
4962 declare.
4963 * tui/tui-winsource.c (tui_source_window_base::refresh_all): Don't
4964 call tui_erase_exec_info_content.
4965 (tui_clear_exec_info_content): Rename from
4966 tui_erase_exec_info_content.
4967 (tui_clear_exec_info_content): Delete.
4968
8270ac62
TT		 49692019-08-13 Tom Tromey <tom@tromey.com>
4970
4971 * tui/tui-winsource.h (struct tui_source_window_base)
4972 <show_exec_info_content>: Declare.
4973 (tui_show_exec_info_content): Don't declare.
4974 * tui/tui-winsource.c
4975 (tui_source_window_base::show_exec_info_content): Rename from
4976 tui_show_exec_info_content.
4977 (tui_source_window_base::update_exec_info): Update.
4978
7b56485d
TT		 49792019-08-13 Tom Tromey <tom@tromey.com>
4980
4981 * tui/tui-data.h (enum tui_bp_flag, tui_bp_flags, struct tui_source_element)
4982 (TUI_BP_HIT_POS, TUI_BP_BREAK_POS, TUI_EXEC_POS)
4983 (TUI_EXECINFO_SIZE, tui_exec_info_content): Move ...
4984 * tui/tui-winsource.h (enum tui_bp_flag, tui_bp_flags, struct
4985 tui_source_element, TUI_BP_HIT_POS, TUI_BP_BREAK_POS)
4986 (TUI_EXEC_POS, TUI_EXECINFO_SIZE, tui_exec_info_content):
4987 ... here.
4988
7ba913dc
TT		 49892019-08-13 Tom Tromey <tom@tromey.com>
4990
4991 * tui/tui-winsource.h (struct tui_source_window_base)
4992 <update_exec_info>: Declare.
4993 (tui_update_exec_info): Don't declare.
4994 * tui/tui-winsource.c (tui_update_source_window_as_is)
4995 (tui_source_window_base::refresh_all)
4996 (tui_update_all_breakpoint_info): Update.
4997 (tui_source_window_base::update_exec_info): Rename from
4998 tui_update_exec_info.
4999 * tui/tui-stack.c (tui_show_frame_info): Update.
5000
37a4a131
TT		 50012019-08-13 Tom Tromey <tom@tromey.com>
5002
5003 * tui/tui-winsource.h (struct tui_source_window_base)
5004 <set_exec_info_content>: Declare.
5005 (tui_set_exec_info_content): Don't declare.
5006 * tui/tui-winsource.c
5007 (tui_source_window_base::set_exec_info_content): Rename from
5008 tui_set_exec_info_content.
5009 (tui_update_exec_info): Update.
5010
0bd27e07
TT		 50112019-08-13 Tom Tromey <tom@tromey.com>
5012
5013 * tui/tui-winsource.h (struct tui_source_window_base)
5014 <show_source_content>: Declare.
5015 (tui_show_source_content): Don't declare.
5016 * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
5017 (tui_source_window_base::show_source_content): Rename from
5018 tui_show_source_content.
5019 (tui_source_window_base::refresh_all): Update.
5020 * tui/tui-layout.c (show_source_disasm_command)
5021 (show_source_or_disasm_and_command): Update.
5022
b4ef5aeb
TT		 50232019-08-13 Tom Tromey <tom@tromey.com>
5024
5025 * tui/tui-winsource.c (tui_erase_source_content)
5026 (tui_show_source_content, tui_source_window_base::refresh_all):
5027 Update.
5028 * tui/tui-wingeneral.h
5029 (tui_check_and_display_highlight_if_needed): Don't declare.
5030 * tui/tui-wingeneral.c
5031 (tui_win_info::check_and_display_highlight_if_needed): Rename from
5032 check_and_display_highlight_if_needed.
5033 * tui/tui-win.c (tui_rehighlight_all)
5034 (tui_win_info::make_visible_with_new_height): Update.
5035 * tui/tui-regs.c (tui_data_window::display_registers_from_line)
5036 (tui_data_window::erase_data_content)
5037 (tui_data_window::display_all_data): Update.
5038 * tui/tui-data.h (struct tui_win_info)
5039 <check_and_display_highlight_if_needed>: Declare.
5040
fede5273
TT		 50412019-08-13 Tom Tromey <tom@tromey.com>
5042
5043 * tui/tui-win.c (tui_resize_all): Call
5044 tui_delete_invisible_windows.
5045 * tui/tui-layout.c (show_layout): Call
5046 tui_delete_invisible_windows.
5047 * tui/tui-data.h (tui_delete_invisible_windows): Declare.
5048 * tui/tui-data.c (tui_delete_invisible_windows): New function.
5049
22c3f490
TT		 50502019-08-13 Tom Tromey <tom@tromey.com>
5051
5052 * tui/tui-disasm.c (tui_show_disassem): Add assertion. Don't call
5053 tui_add_win_to_layout.
5054
16cb7910
TT		 50552019-08-13 Tom Tromey <tom@tromey.com>
5056
5057 * tui/tui-layout.h (tui_default_win_height): Don't declare.
5058 * tui/tui-layout.c (tui_default_win_height): Now static.
5059
cc0c3ffb
TT		 50602019-08-13 Tom Tromey <tom@tromey.com>
5061
5062 * tui/tui-layout.c (show_layout): Unify all layout cases into a
5063 single switch.
5064 (show_source_disasm_command, show_source_or_disasm_and_command):
5065 Don't check current layout.
5066
3f3ffe54
TT		 50672019-08-13 Tom Tromey <tom@tromey.com>
5068
5069 * tui/tui-wingeneral.c (make_all_visible): Remove.
5070 (tui_make_all_invisible): Simplify.
5071 * tui/tui-layout.c (tui_make_all_invisible): Move from
5072 tui-wingeneral.c; simplify.
5073 (show_layout): Hoist call to tui_make_all_invisible.
5074 (show_data): Don't call tui_make_all_invisible.
5075
69258091
TT		 50762019-08-13 Tom Tromey <tom@tromey.com>
5077
5078 * tui/tui-wingeneral.h (tui_make_all_visible): Don't declare.
5079 * tui/tui-wingeneral.c (tui_make_all_visible): Remove.
5080
62cf57fe
TT		 50812019-08-13 Tom Tromey <tom@tromey.com>
5082
5083 * tui/tui-layout.c (current_layout, tui_current_layout): Move from
5084 tui-data.c.
5085 (show_source_disasm_command, show_data)
5086 (show_source_or_disasm_and_command): Don't use
5087 tui_set_current_layout_to.
5088 * tui/tui-data.h (tui_set_current_layout_to): Don't declare.
5089 * tui/tui-data.c (current_layout, tui_current_layout): Move to
5090 tui-layout.c.
5091 (tui_set_current_layout_to): Remove.
5092
2afade5d
TT		 50932019-08-13 Tom Tromey <tom@tromey.com>
5094
5095 * tui/tui-layout.c (tui_set_layout): Update.
5096 * tui/tui-data.h (struct tui_layout_def): Remove.
5097 (tui_layout_def): Don't declare.
5098 * tui/tui-data.c (layout_def): Remove.
5099 (tui_layout_def): Remove.
5100
a3504e96
TT		 51012019-08-13 Tom Tromey <tom@tromey.com>
5102
5103 * tui/tui-winsource.h (struct tui_source_window_base)
5104 <clear_detail>: No longer "override".
5105 * tui/tui-regs.h (struct tui_data_window) <clear_detail>: Remove.
5106 * tui/tui-regs.c (tui_data_window::clear_detail): Remove.
5107 * tui/tui-data.h (struct tui_win_info) <clear_detail>: Remove.
5108 * tui/tui-command.h (struct tui_cmd_window) <clear_detail>:
5109 Remove.
5110 * tui/tui-command.c (tui_cmd_window::clear_detail): Remove.
5111
29c92911
TT		 51122019-08-13 Tom Tromey <tromey@adacore.com>
5113
5114 * tracepoint.c: Don't include readline.h or history.h.
5115
86c6b807
TT		 51162019-08-12 Tom Tromey <tom@tromey.com>
5117
5118 * configure: Rebuild.
5119 * configure.ac: Check for readline 7.
5120 * NEWS: Mention readline 7 requirement.
5121 * README: Update.
5122
5db2718c
TT		 51232019-08-12 Tom Tromey <tom@tromey.com>
5124
5125 * mingw-hdep.c (gdb_select): Remove readline hack.
5126
dac36daf
PFC		 51272019-08-09 Pedro Franco de Carvalho <pedromfc@linux.ibm.com>
5128
5129 * blockframe.c (find_pc_partial_function): Set *block to nullptr
5130 when the function fails.
5131
1022c627
AA		 51322019-08-09 Andreas Arnez <arnez@linux.ibm.com>
5133
5134 * s390-tdep.c (s390_type_align): New function.
5135 (s390_gdbarch_init): Set it as type_align gdbarch method.
5136
eba4caf2
TV		 51372019-08-09 Tom de Vries <tdevries@suse.de>
5138
5139 PR gdb/24591
5140 * dwarf2read.c (dwarf2_fetch_die_loc_sect_off): Adjust pc_high and
5141 pc_low with relocation offset.
5142
123cd851
TT		 51432019-08-07 Tom Tromey <tromey@adacore.com>
5144
5145 * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
5146 (print_frame_args): Update.
5147 * python/py-framefilter.c (py_print_single_arg, enumerate_args):
5148 Update.
5149 * mi/mi-cmd-stack.c (list_arg_or_local): Update.
5150 * frame.h (struct frame_arg): Add initializers.
5151 <error>: Now a unique_xmalloc_ptr.
5152
3d31bc39
AH		 51532019-08-07 Alan Hayward <alan.hayward@arm.com>
5154
5155 * NEWS: Expand the Pointer Authentication entry.
5156 * aarch64-tdep.c (aarch64_frame_unmask_address): Rename from this.
5157 (aarch64_frame_unmask_lr): ... to this.
5158 (aarch64_prologue_prev_register, aarch64_dwarf2_prev_register):
5159 Call aarch64_frame_unmask_lr.
5160 * frame.c (struct frame_info): Add "masked" variable.
5161 (frame_set_previous_pc_masked) (frame_get_pc_masked): New functions.
5162 (fprint_frame): Check for masked pc.
5163 * frame.h (frame_set_previous_pc_masked) (frame_get_pc_masked): New
5164 declarations.
5165 * python/py-framefilter.c (py_print_frame): Check for masked pc.
5166 * stack.c (print_frame): Check for masked pc.
5167
0cf9feb9
TT		 51682019-08-06 Tom Tromey <tom@tromey.com>
5169
5170 * stabsread.c (patch_block_stabs, read_one_struct_field)
5171 (read_enum_type): Use obstack_strndup.
5172 * rust-exp.y (rust_parser::copy_name): Use obstack_strndup.
5173 * gdb_obstack.h (obstack_strndup): Use obstack_strndup.
5174 * dwarf2read.c (guess_full_die_structure_name)
5175 (anonymous_struct_prefix): Use obstack_strndup.
5176 * dbxread.c (cp_set_block_scope): Use obstack_strndup.
5177 * c-exp.y (yylex): Use obstack_strndup.
5178 * ada-exp.y (write_object_renaming, write_ambiguous_var)
5179 (write_var_or_type): Use obstack_strndup.
5180
efba19b0
TT		 51812019-08-06 Tom Tromey <tom@tromey.com>
5182
5183 * symfile.c (reread_symbols): Use obstack_strdup.
5184 * stabsread.c (read_type): Use obstack_strdup.
5185 * gdb_obstack.h (obstack_strdup): New overload.
5186 * dwarf2read.c (dwarf2_compute_name, create_dwo_unit_in_dwp_v1)
5187 (create_dwo_unit_in_dwp_v2, build_error_marker_type)
5188 (dwarf2_canonicalize_name): Use obstack_strdup.
5189 * dbxread.c (read_dbx_symtab): Use obstack_strdup.
5190 * cp-support.c (inspect_type, replace_typedefs_qualified_name):
5191 Use obstack_strdup.
5192
f25102f7
TT		 51932019-08-06 Tom Tromey <tom@tromey.com>
5194
5195 * gdb_obstack.h (obstack_strdup): Define.
5196 * gdb_obstack.c (obstack_strdup): Don't define.
5197
021887d8
TT		 51982019-08-06 Tom Tromey <tom@tromey.com>
5199
5200 * xcoffread.c (SYMNAME_ALLOC, process_xcoff_symbol): Use
5201 obstack_strdup.
5202 * typeprint.c (typedef_hash_table::find_global_typedef): Use
5203 obstack_strdup.
5204 * symfile.c (allocate_compunit_symtab): Use obstack_strdup.
5205 * stabsread.c (common_block_start): Use obstack_strdup.
5206 * objfiles.c (set_objfile_main_name, objfile): Use
5207 obstack_strdup.
5208 * namespace.c (add_using_directive): Use obstack_strdup.
5209 * mdebugread.c (parse_symbol, parse_type): Use obstack_strdup.
5210 * jit.c (finalize_symtab): Use obstack_strdup.
5211 * dwarf2read.c (fixup_go_packaging, dwarf2_physname)
5212 (guess_partial_die_structure_name, partial_die_info::fixup)
5213 (dwarf2_name): Use obstack_strdup.
5214 * coffread.c (coff_read_struct_type, coff_read_enum_type): Use
5215 obstack_strdup.
5216 * c-exp.y (scan_macro_expansion): Use obstack_strdup.
5217 * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
5218 obstack_strdup.
5219 * ada-lang.c (ada_decode_symbol): Use obstack_strdup.
5220
d2834edc
PW		 52212019-08-07 Philippe Waroquiers <philippe.waroquiers@skynet.be>
5222
5223 * unittests/help-doc-selftests.c: New file.
5224 * Makefile.in: Add the new file.
5225
590042fc
PW		 52262019-08-07 Philippe Waroquiers <philippe.waroquiers@skynet.be>
5227
5228 * cli/cli-decode.h (print_doc_line): Add for_value_prefix argument.
5229 * cli/cli-decode.c (print_doc_line): Likewise. It now prints
5230 the full first line, except when FOR_VALUE_PREFIX. In this case,
5231 the trailing '.' is not output, and the first character is uppercased.
5232 (print_help_for_command): Update call to print_doc_line.
5233 (print_doc_of_command): Likewise.
5234 * cli/cli-setshow.c (deprecated_show_value_hack): Likewise.
5235 * cli/cli-option.c (append_indented_doc): Do not append newline.
5236 (build_help_option): Append newline after first appended_indented_doc
5237 only if a second call is done.
5238 (build_help): Append 2 new lines before each option, except the first
5239 one.
5240 * compile/compile.c (_initialize_compile): Add new lines after
5241 %OPTIONS%, when not at the end of the help.
5242 Change help doc or code
5243 producing the help doc to respect the invariants.
5244 * maint-test-options.c (_initialize_maint_test_options): Likewise.
5245 Also removed the new line after 'Options:', as all other commands
5246 do not put an empty line between 'Options:' and the first option.
5247 * printcmd.c (_initialize_printcmd): Likewise.
5248 * stack.c (_initialize_stack): Likewise.
5249 * interps.c (interpreter_exec_cmd): Fix "Usage:" line that was
5250 incorrectly telling COMMAND is optional.
5251 * ada-lang.c (_initialize_ada_language): Change help doc or code
5252 producing the help doc to respect the invariants.
5253 * ada-tasks.c (_initialize_ada_tasks): Likewise.
5254 * breakpoint.c (_initialize_breakpoint): Likewise.
5255 * cli/cli-cmds.c (_initialize_cli_cmds): Likewise.
5256 * cli/cli-logging.c (_initialize_cli_logging): Likewise.
5257 * cli/cli-setshow.c (_initialize_cli_setshow): Likewise.
5258 * cli/cli-style.c (cli_style_option::add_setshow_commands,
5259 _initialize_cli_style): Likewise.
5260 * corelow.c (core_target_info): Likewise.
5261 * dwarf-index-cache.c (_initialize_index_cache): Likewise.
5262 * dwarf2read.c (_initialize_dwarf2_read): Likewise.
5263 * filesystem.c (_initialize_filesystem): Likewise.
5264 * frame.c (_initialize_frame): Likewise.
5265 * gnu-nat.c (add_task_commands): Likewise.
5266 * infcall.c (_initialize_infcall): Likewise.
5267 * infcmd.c (_initialize_infcmd): Likewise.
5268 * interps.c (_initialize_interpreter): Likewise.
5269 * language.c (_initialize_language): Likewise.
5270 * linux-fork.c (_initialize_linux_fork): Likewise.
5271 * maint-test-settings.c (_initialize_maint_test_settings): Likewise.
5272 * maint.c (_initialize_maint_cmds): Likewise.
5273 * memattr.c (_initialize_mem): Likewise.
5274 * printcmd.c (_initialize_printcmd): Likewise.
5275 * python/lib/gdb/function/strfns.py (_MemEq, _StrLen, _StrEq,
5276 _RegEx): Likewise.
5277 * ravenscar-thread.c (_initialize_ravenscar): Likewise.
5278 * record-btrace.c (_initialize_record_btrace): Likewise.
5279 * record-full.c (_initialize_record_full): Likewise.
5280 * record.c (_initialize_record): Likewise.
5281 * regcache-dump.c (_initialize_regcache_dump): Likewise.
5282 * regcache.c (_initialize_regcache): Likewise.
5283 * remote.c (add_packet_config_cmd, init_remote_threadtests,
5284 _initialize_remote): Likewise.
5285 * ser-tcp.c (_initialize_ser_tcp): Likewise.
5286 * serial.c (_initialize_serial): Likewise.
5287 * skip.c (_initialize_step_skip): Likewise.
5288 * source.c (_initialize_source): Likewise.
5289 * stack.c (_initialize_stack): Likewise.
5290 * symfile.c (_initialize_symfile): Likewise.
5291 * symtab.c (_initialize_symtab): Likewise.
5292 * target-descriptions.c (_initialize_target_descriptions): Likewise.
5293 * top.c (init_main): Likewise.
5294 * tracefile-tfile.c (tfile_target_info): Likewise.
5295 * tracepoint.c (_initialize_tracepoint): Likewise.
5296 * tui/tui-win.c (_initialize_tui_win): Likewise.
5297 * utils.c (add_internal_problem_command): Likewise.
5298 * valprint.c (value_print_option_defs): Likewise.
5299
404f2902
FCE		 53002019-08-06 Frank Ch. Eigler <fche@redhat.com>
5301
5302 PR build/24886
5303 * configure.ac: Drop enable-libmcheck support.
5304 * configure, config.in: Rebuild.
5305 * libmcheck.m4: Remove.
5306 * acinclude.m4: Don't include it.
5307 * Makefile.in: Don't distribute it.
5308 * top.c (print_gdb_configuration): Don't mention it.
5309
046bebe1
TT		 53102019-08-06 Tom Tromey <tom@tromey.com>
5311
5312 * utils.c (set_output_style): Sometimes pass stream to
5313 emit_style_escape.
5314 * ui-out.h (class ui_out) <can_emit_style_escape>: Declare.
5315 * record-btrace.c (btrace_insn_history): Update.
5316 * mi/mi-out.h (class mi_ui_out) <can_emit_style_escape>: New
5317 method.
5318 * disasm.h (gdb_pretty_print_disassembler): Add uiout parameter.
5319 Update initializers.
5320 <m_uiout>: New field.
5321 <m_di>: Move lower.
5322 * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
5323 Remove "uiout" parameter.
5324 (dump_insns): Update.
5325 * cli-out.h (class cli_ui_out) <can_emit_style_escape>: Declare.
5326 * cli-out.c (cli_ui_out::can_emit_style_escape): New method.
5327
ddbcedf5
CB		 53282019-08-06 Christian Biesinger <cbiesinger@google.com>
5329
5330 * symtab.c (symbol_cache_lookup): Change int to enum block_enum.
5331 (error_in_psymtab_expansion): Likewise.
5332 (lookup_symbol_via_quick_fns): Likewise.
5333 (basic_lookup_transparent_type_quick): Likewise.
5334 (basic_lookup_transparent_type_1): Likewise.
5335
b08b16c8
TT		 53362019-08-06 Tom Tromey <tromey@adacore.com>
5337
5338 * source.c (last_source_error): Now bool.
5339 (print_source_lines_base): Make "noprint" bool. Only open
5340 source file when last_source_visited changes.
5341
cb44333d
TT		 53422019-08-06 Tom Tromey <tromey@adacore.com>
5343
5344 * annotate.c (annotate_source_line): Use g_source_cache.
5345 * source-cache.c (source_cache::get_plain_source_lines): Change
5346 parameters. Populate m_offset_cache.
5347 (source_cache::ensure): New method.
5348 (source_cache::get_line_charpos): New method.
5349 (extract_lines): Move lower. Change parameters.
5350 (source_cache::get_source_lines): Move lower.
5351 * source-cache.h (class source_cache): Update comment.
5352 <get_line_charpos>: New method.
5353 <get_source_lines>: Update comment.
5354 <clear>: Clear m_offset_cache.
5355 <get_plain_source_lines>: Change parameters.
5356 <ensure>: New method
5357 <m_offset_cache>: New member.
5358 * source.c (forget_cached_source_info_for_objfile): Update.
5359 (info_source_command): Use g_source_cache.
5360 (find_source_lines, open_source_file_with_line_charpos): Remove.
5361 (print_source_lines_base, search_command_helper): Use g_source_cache.
5362 * source.h (open_source_file_with_line_charpos): Don't declare.
5363 * symtab.h (struct symtab) <nlines, line_charpos>: Remove.
5364 * tui/tui-source.c (tui_source_window::do_scroll_vertical):
5365 Use g_source_cache.
5366
872dceaa
TT		 53672019-08-06 Tom Tromey <tromey@adacore.com>
5368
5369 * source-cache.c (source_cache::get_plain_source_lines):
5370 Remove "first_line" and "last_line" parameters.
5371 (source_cache::get_source_lines): Cache plain text.
5372 * source-cache.h (class source_cache)
5373 <get_plain_source_lines>: Update.
5374
269249d9
TT		 53752019-08-06 Tom Tromey <tromey@adacore.com>
5376
5377 * source-cache.c (extract_lines): No longer a method.
5378 Changed type of parameter. Include final newline.
5379 (selftests::extract_lines_test): New function.
5380 (_initialize_source_cache): Likewise.
5381 * source-cache.h (class source_cache)
5382 <extract_lines>: Don't declare.
5383
c0e8dcd8
TT		 53842019-08-06 Tom Tromey <tromey@adacore.com>
5385
5386 * breakpoint.c (init_breakpoint_sal): Update.
5387 (breakpoint): Update.
5388 * breakpoint.h (struct breakpoint) <filter>: Now a
5389 unique_xmalloc_ptr.
5390
0b27c27d
CB		 53912019-08-05 Christian Biesinger <cbiesinger@google.com>
5392
5393 * NEWS: Mention dictionary access on blocks.
5394 * python/py-block.c (blpy_getitem): New function.
5395 (block_object_as_mapping): New struct.
5396 (block_object_type): Use new struct for tp_as_mapping field.
5397
4ee94178
CB		 53982019-08-05 Christian Biesinger <cbiesinger@google.com>
5399
5400 * objfiles.h (objfile): Add a comment describing partial symbols.
5401
8abfcabc
TT		 54022019-08-05 Tom Tromey <tromey@adacore.com>
5403
5404 * compile/compile.c (_initialize_compile): Use _(), not N_().
5405 * thread.c (_initialize_thread): Use _(), not N_().
5406 * stack.c (_initialize_stack): Use _(), not N_().
5407 * printcmd.c (_initialize_printcmd): Use _(), not N_().
5408
2b79f376
SM		 54092019-08-04 Simon Marchi <simon.marchi@polymtl.ca>
5410
5411 * dwarf2read.c (struct dw2_symtab_iterator):
5412 <want_specific_block>: Remove.
5413 <block_index>: Change type to gdb::optional.
5414 (dw2_symtab_iter_init): Remove WANT_SPECIFIC_BLOCK parameter,
5415 change type of BLOCK_INDEX parameter to gdb::optional.
5416 (dw2_symtab_iter_next): Re-write in function of gdb::optional.
5417 (dw2_lookup_symbol): Don't pass argument for
5418 WANT_SPECIFIC_BLOCK.
5419 (dw2_expand_symtabs_for_function): Don't pass argument for
5420 WANT_SPECIFIC_BLOCK, pass empty optional for BLOCK_INDEX.
5421 (class dw2_debug_names_iterator)
5422 <dw2_debug_names_iterator>: Remove WANT_SPECIFIC_BLOCK
5423 parameter, change BLOCK_INDEX type to gdb::optional.
5424 <m_want_specific_block>: Remove.
5425 <m_block_index>: Change type to gdb::optional.
5426 (dw2_debug_names_iterator::next): Change type of IS_STATIC to
5427 gdb::optional. Re-write in function of gdb::optional.
5428 (dw2_debug_names_lookup_symbol): Don't pass argument for
5429 WANT_SPECIFIC_BLOCK.
5430 (dw2_debug_names_expand_symtabs_for_function): Don't pass
5431 argument for WANT_SPECIFIC_BLOCK, pass empty optional for
5432 BLOCK_INDEX.
5433
ae60f04e
PW		 54342019-08-03 Philippe Waroquiers <philippe.waroquiers@skynet.be>
5435
5436 * NEWS: Mention changes to "info sources" command.
5437
28cd9371
PW		 54382019-08-03 Philippe Waroquiers <philippe.waroquiers@skynet.be>
5439
5440 * symtab.c (filename_partial_match_opts): New struct type.
5441 (struct output_source_filename_data): New members
5442 regexp, c_regexp, partial_match.
5443 (output_source_filename): Use new members to decide to print file.
5444 (info_sources_option_defs): New variable.
5445 (make_info_sources_options_def_group, print_info_sources_header,
5446 info_sources_command_completer):
5447 New functions.
5448 (info_sources_command): Read new optional arguments.
5449 (_initialize_symtab): Update info sources help.
5450
ca683e3a
AO		 54512019-08-02 Alexandre Oliva <oliva@adacore.com>
5452
5453 * ada-lang.c (exception_support_info_v0): Renamed from...
5454 (default_exception_support_info): ... this. Create new
5455 definition for v1.
5456 (ada_has_this_exception_support): Look up catch_handlers_sym.
5457 (ada_exception_support_info_sniffer): Try v0 after default.
5458
f1264162
TT		 54592019-08-01 Tom Tromey <tromey@adacore.com>
5460
5461 * ia64-libunwind-tdep.h (struct libunwind_descr): Include
5462 gdbarch.h.
5463
0a7b2485
CB		 54642019-08-01 Christian Biesinger <cbiesinger@google.com>
5465
5466 * s12z-tdep.c: Fix include path for s12z-opc.h.
5467
c6bdbeb7
AH		 54682019-08-01 Alan Hayward <alan.hayward@arm.com>
5469
5470 * NEWS: Require GNU make 3.82.
5471
a2bd7b82
TT		 54722019-07-16 Tom Tromey <tom@tromey.com>
5473
5474 * tui/tui-wingeneral.h (tui_copy_win, tui_box_win): Don't
5475 declare.
5476
aa3b6533
TT		 54772019-07-30 Tom Tromey <tromey@adacore.com>
5478
5479 * block.c (contained_in): Remove BLOCK_FUNCTION check.
5480
a1530dc7
KB		 54812019-07-30 Kevin Buettner <kevinb@redhat.com>
5482
5483 * printcmd.c (print_address_symbolic): Print negative offsets.
5484 (build_address_symbolic): Force signed arithmetic when computing
5485 offset.
5486
2906593f
CB		 54872019-07-30 Christian Biesinger <cbiesinger@google.com>
5488
5489 PR/24474: Add a function to lookup static variables.
5490 * NEWS: Mention this new function.
5491 * python/py-symbol.c (gdbpy_lookup_static_symbol): New function.
5492 * python/python-internal.h (gdbpy_lookup_static_symbol): New function.
5493 * python/python.c (python_GdbMethods): Add new function.
5494
c620ed88
CB		 54952019-07-29 Christian Biesinger <cbiesinger@google.com>
5496
5497 * NEWS: Mention new functions Objfile.lookup_{global,static}_symbol.
5498 * python/py-objfile.c (objfpy_lookup_global_symbol): New function.
5499 (objfpy_lookup_static_symbol): New function.
5500 (objfile_object_methods): Add new functions.
5501
bc4268a5
PW		 55022019-07-29 Philippe Waroquiers <philippe.waroquiers@skynet.be>
5503
5504 * NEWS: Mention 'set|show print frame-info'. Mention new
5505 'presence' value for 'frame-arguments'. Mention new '-frame-info'
5506 backtrace argument. Mention that python frame filtering code
5507 is now consistent with what 'backtrace' command prints.
5508
4b5e8d19
PW		 55092019-07-29 Philippe Waroquiers <philippe.waroquiers@skynet.be>
5510
5511 * frame.h (enum print_what): New value 'SHORT_LOCATION', update
5512 comments.
5513 (print_frame_info_auto, print_frame_info_source_line,
5514 print_frame_info_location, print_frame_info_source_and_location,
5515 print_frame_info_location_and_address, print_frame_info_short_location):
5516 New declarations.
5517 (struct frame_print_options): New member print_frame_info.
5518 * extension.h (enum ext_lang_frame_args): New value CLI_PRESENCE.
5519 * stack.h (get_user_print_what_frame_info): New declaration.
5520 (frame_show_address): New declaration.
5521 * stack.c (print_frame_arguments_choices): New value 'presence'.
5522 (print_frame_info_auto, print_frame_info_source_line,
5523 print_frame_info_location, print_frame_info_source_and_location,
5524 print_frame_info_location_and_address, print_frame_info_short_location,
5525 print_frame_info_choices, print_frame_info_print_what): New definitions.
5526 (print_frame_args): Only print dots for args if print frame-arguments
5527 is 'presence'.
5528 (frame_print_option_defs): New element for "frame-info".
5529 (get_user_print_what_frame_info): New function.
5530 (frame_show_address): Make non static. Move comment to stack.h.
5531 (print_frame_info_to_print_what): New function.
5532 (print_frame_info): Update comment. Use fp_opts.print_frame_info
5533 to decide what to print.
5534 (backtrace_command_1): Handle the new print_frame_arguments_presence
5535 value.
5536 (_initialize_stack): Call add_setshow_enum_cmd for frame-info.
5537 * python/py-framefilter.c (py_print_args): Handle CLI_PRESENCE.
5538 (py_print_frame): In non-mi mode, use LOCATION as default for
5539 print_what, similarly to frame information printed directly by
5540 backtrace command. Handle frame-info user option in non MI mode.
5541
6bdfee81
KB		 55422019-07-27 Kevin Buettner <kevinb@redhat.com>
5543
5544 * linux-thread-db.c (thread_db_target::thread_handle_to_thread_info):
5545 Add case for debugging 32-bit target on 64-bit host. Revise
5546 comment.
5547
98a617f8
KB		 55482019-07-27 Kevin Buettner <kevinb@redhat.com>
5549
5550 * infrun.c (fill_in_stop_func): Use find_pc_partial_function
5551 instead of find_function_entry_range_from_pc.
5552
567238c9
KB		 55532019-07-27 Kevin Buettner <kevinb@redhat.com>
5554
5555 * stack.c (find_frame_funname): Remove code which preferred
5556 minsym over symtab sym in "certain pathological cases".
5557
2dc80cf8
KB		 5558 * valprint.h (build_address_symbolic): Add "prefer_sym_over_minsym"
5559 parameter. Change type of "do_demangle" to bool.
5560 * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
5561 Pass suitable "prefer_sym_over_minsym" flag to
5562 build_address_symbolic(). Don't output "+" for negative offsets.
5563 * printcmd.c (print_address_symbolic): Update invocation of
5564 build_address_symbolic to include a "prefer_sym_over_minsym"
5565 flag.
5566 (build_address_symbolic): Add "prefer_sym_over_minsym" parameter.
5567 Restrict cases in which use of minimal symbol is preferred to that
5568 of a found symbol. Update comments.
5569
1aff7173
KB		 5570 * dwarf2-frame.c (dwarf2_frame_cache): Don't decode FDE instructions
5571 for entry pc when entry pc is out of range for that FDE.
5572
89b085ac
BC		 55732019-07-26 Brian Callahan <bcallah@openbsd.org>
5574
5575 PR gdb/24839:
5576 * gdb/obsd-nat.c (obsd_nat_target::pid_to_str): Fix typo in return
5577 type.
5578
f32feb4a
CB		 55792019-07-25 Christian Biesinger <cbiesinger@google.com>
5580
5581 * python/py-objfile.c (add_separate_debug_file): Fix comment about
5582 this function's Python signature.
5583
5584
55852019-07-24 Christian Biesinger <cbiesinger@google.com>
442853af
CB		 5586
5587 * compile/compile-object-load.c (compile_object_load): Pass GLOBAL_SCOPE.
5588 * solib-spu.c (spu_lookup_lib_symbol): Pass GLOBAL_SCOPE.
5589 * solib-svr4.c (elf_lookup_lib_symbol): Pass GLOBAL_SCOPE.
5590 * symtab.c (lookup_global_symbol_from_objfile): Add a scope parameter.
5591 * symtab.h (lookup_global_symbol_from_objfile): Likewise.
5592
5593
c54e4253
YS		 55942019-07-24 Yoshinori Sato <ysato@users.sourceforge.jp>
5595
5596 * h8300-tdep.c (h8300_register_name_common): New.
5597 h8300_register_name): Use h8300_register_name_common.
5598 (h8300s_register_name): Likewise.
5599 (h8300sx_register_name): Likewise.
5600 (h8300h_register_nam): New.
5601 (h8300_gdbarch_init): Use h8300h_register_name in h8300h machine.
5602
5603
40eadf04
SP		 56042019-07-23 Srinath Parvathaneni <srinath.parvathaneni@arm.com>
5605
5606 * arm-tdep.c (arm_skip_cmse_entry): New function.
5607 (arm_is_sgstubs_section): New function.
5608 (arm_skip_stub): Add call to arm_skip_cmse_entry function.
5609
bfa2a36d
TT		 56102019-07-22 Tom Tromey <tom@tromey.com>
5611
5612 * tui/tui-win.c (tui_win_info::make_invisible_and_set_new_height):
5613 Don't self-assign.
5614
a8e9d247
AB		 56152019-07-22 Andrew Burgess <andrew.burgess@embecosm.com>
5616
5617 * c-typeprint.c (c_print_typedef): Pass -1 instead of 0 to
5618 type_print.
5619
eb86c5e2
AB		 56202019-07-22 Andrew Burgess <andrew.burgess@embecosm.com>
5621
5622 * symtab.c (search_symbols): Adjust msymbol matching type arrays
5623 so that GDB doesn't match any msymbols when searching in the
5624 TYPES_DOMAIN.
5625 (print_symbol_info): Print using typedef_print or type_print based
5626 on the type of the symbol. Add updated FIXME comment moved from...
5627 (_initialize_symtab): ... move and update FIXME comment to above.
5628
a8eab7c6
AB		 56292019-07-22 Andrew Burgess <andrew.burgess@embecosm.com>
5630
5631 * NEWS: Mention adding -q option to "info types".
5632 * symtab.c (struct info_types_options): New struct.
5633 (info_types_options_defs): New variable.
5634 (make_info_types_options_def_group): New function.
5635 (info_types_command): Use gdb::option framework to parse options.
5636 (info_types_command_completer): New function.
5637 (_initialize_symtab): Extend the help text on "info types" and
5638 register command completer.
5639
b4603c34
CB		 56402019-07-21 Christian Biesinger <cbiesinger@google.com>
5641
5642 * symtab.c (lookup_symbol_in_objfile_symtabs): Change int to block_enum.
5643 (lookup_symbol_in_objfile): Change int to block_enum and add a
5644 gdb_assert to make sure block_index is GLOBAL_BLOCK or STATIC_BLOCK.
5645
c8cdc1e0
CB		 56462019-07-20 Christian Biesinger <cbiesinger@google.com>
5647
5648 * MAINTAINERS (Write After Approval): Add self.
5649
01e175fe
AB		 56502019-07-19 Andrew Burgess <andrew.burgess@embecosm.com>
5651
5652 * riscv-tdep.c (riscv_push_dummy_code): Write a 4-byte nop
5653 instruction to the dummy code region.
5654
56f79b63
TT		 56552019-07-19 Tom Tromey <tromey@adacore.com>
5656
5657 * contrib/ari/gdb_ari.sh: Mention C++11, not ISO C 90.
5658 (ARGSUSED, PARAMS, __func__): Remove rules.
5659
4c5aa8e0
AH		 56602019-07-19 Alan Hayward <alan.hayward@arm.com>
5661
5662 * arm-tdep.c (_initialize_arm_tdep): Remove xml tests.
5663 * features/arm/arm-with-iwmmxt.c: Remove.
5664 * features/arm/arm-with-iwmmxt.xml: Remove.
5665 * features/arm/arm-with-m-fpa-layout.c: Remove.
5666 * features/arm/arm-with-m-fpa-layout.xml: Remove.
5667 * features/arm/arm-with-m-vfp-d16.c: Remove.
5668 * features/arm/arm-with-m-vfp-d16.xml: Remove.
5669 * features/arm/arm-with-m.c: Remove.
5670 * features/arm/arm-with-m.xml: Remove.
5671 * features/arm/arm-with-neon.c: Remove.
5672 * features/arm/arm-with-neon.xml: Remove.
5673 * features/arm/arm-with-vfpv2.c: Remove.
5674 * features/arm/arm-with-vfpv2.xml: Remove.
5675 * features/arm/arm-with-vfpv3.c: Remove.
5676 * features/arm/arm-with-vfpv3.xml: Remove.
5677
f42b2617
AH		 56782019-07-19 Alan Hayward <alan.hayward@arm.com>
5679
5680 * arm-tdep.c (_initialize_arm_tdep): Add xml regression tests.
5681
f29ec966
AH		 56822019-07-19 Alan Hayward <alan.hayward@arm.com>
5683
5684 * arch/aarch32.c (aarch32_create_target_description): Create
5685 target descriptions using features.
5686 * arch/arm.c (arm_create_target_description)
5687 (arm_create_mprofile_target_description): Likewise.
5688 * arm-tdep.c (_initialize_arm_tdep): Remove tdesc init calls.
5689
d105cce5
AH		 56902019-07-19 Alan Hayward <alan.hayward@arm.com>
5691
5692 * Makefile.in: Add new files.
5693 * aarch32-tdep.c: New file.
5694 * aarch32-tdep.h: New file.
5695 * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
5696 Call aarch32_read_description.
5697 * arch/aarch32.c: New file.
5698 * arch/aarch32.h: New file.
5699 * arch/arm.c (arm_create_target_description)
5700 (arm_create_mprofile_target_description): New function.
5701 * arch/arm.h (arm_fp_type, arm_m_profile_type): New enum.
5702 (arm_create_target_description)
5703 (arm_create_mprofile_target_description): New declaration.
5704 * arm-fbsd-tdep.c (arm_fbsd_read_description_auxv): Call
5705 read_description functions.
5706 * arm-linux-nat.c (arm_linux_nat_target::read_description):
5707 Likewise.
5708 * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
5709 * arm-tdep.c (tdesc_arm_list): New variable.
5710 (arm_register_g_packet_guesses): Call create description functions.
5711 (arm_read_description) (arm_read_mprofile_description): New
5712 function.
5713 * arm-tdep.h (arm_read_description)
5714 (arm_read_mprofile_description): Add declaration.
5715 * configure.tgt: Add new files.
5716
afe09f0b
GL		 57172019-07-18 Guillaume LABARTHE <guillaume.labarthe@gmail.com>
5718
5719 * top.c (new_ui_command): Open specified terminal just once.
5720
cd215b2e
TT		 57212019-07-18 Tom Tromey <tromey@adacore.com>
5722
5723 * symtab.c (main_name): Constify return type.
5724 * symfile.c (set_initial_language): Update.
5725 * symtab.h (main_name): Constify return type.
5726
d8f68fcb
TT		 57272019-07-17 Tom Tromey <tom@tromey.com>
5728
5729 * tui/tui-winsource.c (tui_update_source_window)
5730 (tui_update_source_window_as_is)
5731 (tui_update_source_windows_with_line): Remove return.
5732 * tui/tui-disasm.c (tui_show_disassem)
5733 (tui_show_disassem_and_update_source): Remove return.
5734 * tui/tui.c (tui_reset): Remove return.
5735 * tui/tui-wingeneral.c
5736 (tui_check_and_display_highlight_if_needed): Remove return.
5737
ca5af91e
TT		 57382019-07-17 Tom Tromey <tom@tromey.com>
5739
5740 * tui/tui-win.c (parse_scrolling_args): Throw separate errors.
5741
5104fe36
TT		 57422019-07-17 Tom Tromey <tom@tromey.com>
5743
5744 * tui/tui-winsource.h (struct tui_exec_info_window)
5745 (struct tui_source_window_base): Move from tui-data.h.
5746 * tui/tui-winsource.c: Move many method definitions from
5747 elsewhere. Remove "structuring" comments.
5748 * tui/tui-wingeneral.c (tui_source_window_base::make_visible)
5749 (tui_source_window_base::refresh_window): Move to
5750 tui-winsource.c.
5751 * tui/tui-win.c (tui_source_window_base::refresh_all)
5752 (tui_source_window_base::update_tab_width)
5753 (tui_source_window_base::set_new_height)
5754 (tui_source_window_base::do_make_visible_with_new_height): Move to
5755 tui-winsource.c.
5756 * tui/tui-source.h: Update.
5757 * tui/tui-source.c (tui_source_window_base::reset): Move to
5758 tui-winsource.c.
5759 * tui/tui-disasm.h: Update.
5760 * tui/tui-data.h (struct tui_exec_info_window): Move to
5761 tui-winsource.h.
5762 (struct tui_source_window_base): Likewise.
5763 * tui/tui-data.c (tui_source_window_base::clear_detail)
5764 (tui_source_window_base, ~tui_source_window_base): Move to
5765 tui-winsource.c.
5766
daa15dde
TT		 57672019-07-17 Tom Tromey <tom@tromey.com>
5768
5769 * tui/tui-win.c (tui_resize_all)
5770 (tui_source_window_base::update_tab_width)
5771 (tui_adjust_win_heights): Update.
5772 (tui_win_info::make_invisible_and_set_new_height): Rename from
5773 make_invisible_and_set_new_height.
5774 * tui/tui-data.h (struct tui_win_info)
5775 <make_invisible_and_set_new_height>: New method.
5776
bfad4537
TT		 57772019-07-17 Tom Tromey <tom@tromey.com>
5778
5779 * tui/tui.c: Update.
5780 * tui/tui-source.h (struct tui_source_window): Move from
5781 tui-data.h.
5782 * tui/tui-layout.c: Update.
5783 * tui/tui-disasm.c: Update.
5784 * tui/tui-data.h (struct tui_source_window): Move to
5785 tui-source.h.
5786
88f7e873
TT		 57872019-07-17 Tom Tromey <tom@tromey.com>
5788
5789 * tui/tui-disasm.h (struct tui_disasm_window): Move from
5790 tui-data.h.
5791 * tui/tui-data.h (struct tui_disasm_window): Move to
5792 tui-disasm.h.
5793
96bd6233
TT		 57942019-07-17 Tom Tromey <tom@tromey.com>
5795
5796 * tui/tui-regs.h (struct tui_data_item_window): Move from
5797 tui-data.h.
5798 * tui/tui-regs.c (tui_data_item_window): Move from tui-data.c.
5799 * tui/tui-data.h (struct tui_data_item_window): Move to
5800 tui-regs.h.
5801 * tui/tui-data.c (~tui_data_item_window): Move to tui-regs.c.
5802
ce38393b
TT		 58032019-07-17 Tom Tromey <tom@tromey.com>
5804
5805 * tui/tui.c: Update.
5806 * tui/tui-win.c (tui_cmd_window::do_make_visible_with_new_height)
5807 (tui_cmd_window::max_height): Move to tui-command.c.
5808 * tui/tui-layout.c: Update.
5809 * tui/tui-data.h (struct tui_cmd_window): Move to tui-command.h.
5810 * tui/tui-data.c (tui_cmd_window::clear_detail): Move to
5811 tui-command.c.
5812 * tui/tui-command.h (struct tui_cmd_window): Move from
5813 tui-data.h.
5814 * tui/tui-command.c: Remove "structuring" comments.
5815 (tui_cmd_window::clear_detail)
5816 (tui_cmd_window::do_make_visible_with_new_height)
5817 (tui_cmd_window::max_height): Move from elsewhere.
5818
2d8b51cb
TT		 58192019-07-17 Tom Tromey <tom@tromey.com>
5820
5821 * tui/tui-io.c (tui_dispatch_ctrl_char): Move from tui-command.c.
5822 Now static.
5823 * tui/tui-command.h (tui_dispatch_ctrl_char): Don't declare.
5824 * tui/tui-command.c (tui_dispatch_ctrl_char): Move to tui-io.c.
5825
18ab23af
TT		 58262019-07-17 Tom Tromey <tom@tromey.com>
5827
5828 * tui/tui.c: Update.
5829 * tui/tui-wingeneral.c (tui_data_window::refresh_window): Move to
5830 tui-regs.c.
5831 * tui/tui-windata.h: Remove file.
5832 * tui/tui-windata.c: Remove file.
5833 * tui/tui-win.c (tui_data_window::set_new_height)
5834 (tui_data_window::do_make_visible_with_new_height): Move to
5835 tui-regs.c.
5836 * tui/tui-regs.h (struct tui_data_window): Move from tui-data.h.
5837 * tui/tui-regs.c: Remove "structuring" comments.
5838 (tui_data_window::first_data_item_displayed)
5839 (tui_data_window::delete_data_content_windows)
5840 (tui_data_window::erase_data_content)
5841 (tui_data_window::display_all_data)
5842 (tui_data_window::refresh_all)
5843 (tui_data_window::do_scroll_vertical)
5844 (tui_data_window::clear_detail, tui_data_window::set_new_height)
5845 (tui_data_window::do_make_visible_with_new_height)
5846 (tui_data_window::refresh_window): Move from elsewhere.
5847 (_initialize_tui_regs): Move to end of file.
5848 * tui/tui-layout.c: Update.
5849 * tui/tui-hooks.c: Update.
5850 * tui/tui-data.h (struct tui_data_window): Move to tui-regs.h.
5851 * tui/tui-data.c (tui_data_window::clear_detail): Move to
5852 tui-regs.c.
5853 * Makefile.in (SUBDIR_TUI_SRCS): Remove tui-windata.c.
5854
88b7e7cc
TT		 58552019-07-17 Tom Tromey <tom@tromey.com>
5856
5857 * tui/tui-io.c (tui_puts_internal): Call wrefresh if newline is
5858 seen.
5859
0fcd3711
TT		 58602019-07-17 Tom Tromey <tom@tromey.com>
5861
5862 * tui/tui-win.c (tui_source_window_base::set_new_height)
5863 (tui_source_window_base::do_make_visible_with_new_height): Use
5864 m_has_locator field directly.
5865 * tui/tui-data.h (struct tui_win_info) <has_locator>: Remove
5866 method.
5867 (struct tui_source_window_base) <has_locator>: Likewise.
5868
4a38112d
TT		 58692019-07-17 Tom Tromey <tom@tromey.com>
5870
5871 * tui/tui-wingeneral.h (tui_make_visible, tui_make_invisible):
5872 Don't declare.
5873 * tui/tui-wingeneral.c (tui_make_visible, tui_make_invisible):
5874 Remove.
5875 * tui/tui-win.c (tui_source_window_base::set_new_height)
5876 (tui_source_window_base::set_new_height)
5877 (make_invisible_and_set_new_height)
5878 (tui_source_window_base::do_make_visible_with_new_height)
5879 (tui_source_window_base::do_make_visible_with_new_height):
5880 Update.
5881 * tui/tui-layout.c (show_source_disasm_command, show_data)
5882 (show_source_or_disasm_and_command): Update.
5883 * tui/tui-layout.c (show_layout): Update.
5884
09129226
TT		 58852019-07-17 Tom Tromey <tom@tromey.com>
5886
5887 * tui/tui-layout.c (make_data_window): Remove.
5888 (show_data): Unify creation and re-initialization cases.
5889
4a8a5e84
TT		 58902019-07-17 Tom Tromey <tom@tromey.com>
5891
5892 * tui/tui-layout.c (make_source_window, make_disasm_window):
5893 Remove.
5894 (show_data): Unify creation and re-initialization cases.
5895
76d2be8e
TT		 58962019-07-17 Tom Tromey <tom@tromey.com>
5897
5898 * tui/tui-layout.c (make_command_window): Remove.
5899 (show_source_disasm_command, show_source_or_disasm_and_command):
5900 Unify creation and re-initialization cases.
5901
890b8bde
TT		 59022019-07-17 Tom Tromey <tom@tromey.com>
5903
5904 * tui/tui-layout.c (show_source_or_disasm_and_command): Unify
5905 creation and re-initialization cases.
5906
2cdfa113
TT		 59072019-07-17 Tom Tromey <tom@tromey.com>
5908
5909 * tui/tui-regs.c (tui_get_register): Return void.
5910
8e3cfd09
TT		 59112019-07-17 Tom Tromey <tom@tromey.com>
5912
5913 * tui/tui-wingeneral.c (tui_gen_win_info::make_visible):
5914 Simplify.
5915
f4e04977
TT		 59162019-07-17 Tom Tromey <tom@tromey.com>
5917
5918 * tui/tui-layout.c (show_source_disasm_command): Simplify window
5919 resetting.
5920
0379b883
TT		 59212019-07-17 Tom Tromey <tom@tromey.com>
5922
5923 * tui/tui.h (tui_set_layout_by_name): Don't declare.
5924 * tui/tui-regs.c (tui_reg_layout): New function.
5925 (tui_show_registers, tui_reg_command): Use it.
5926 * tui/tui-layout.c (LAYOUT_USAGE): Remove.
5927 (tui_layout_command): Rename from tui_set_layout_by_name. Change
5928 parameters.
5929 (tui_layout_command): Remove.
5930
b7fbad91
TT		 59312019-07-17 Tom Tromey <tom@tromey.com>
5932
5933 * tui/tui-layout.h (tui/tui-layout): Return void.
5934 * tui/tui-layout.c (tui_set_layout): Return void. Add assert.
5935
4e1e56b9
TT		 59362019-07-17 Tom Tromey <tom@tromey.com>
5937
5938 * tui/tui-layout.c (show_source_disasm_command, show_data):
5939 Update.
5940 (reset_locator): Remove.
5941 (show_source_or_disasm_and_command): Update.
5942
1e0c09ba
TT		 59432019-07-17 Tom Tromey <tom@tromey.com>
5944
5945 * tui/tui-source.c (tui_source_window_base::reset): Remove
5946 win_type parameter.
5947 * tui/tui-layout.c (make_command_window, make_source_window)
5948 (make_disasm_window, make_data_window)
5949 (show_source_disasm_command, show_data, tui_gen_win_info::reset)
5950 (reset_locator, show_source_or_disasm_and_command): Update.
5951 * tui/tui-data.h (struct tui_gen_win_info) <reset>: Remove
5952 win_type parameter.
5953 (struct tui_source_window_base) <reset>: Likewise.
5954
1bf605de
TT		 59552019-07-17 Tom Tromey <tom@tromey.com>
5956
5957 * tui/tui-layout.c (show_source_disasm_command): Use
5958 reset_locator.
5959 (reset_locator): New function.
5960 (init_and_make_win): Remove.
5961 (show_source_or_disasm_and_command): Use reset_locator.
5962
098f9ed4
TT		 59632019-07-17 Tom Tromey <tom@tromey.com>
5964
5965 * tui/tui-winsource.c (tui_set_exec_info_content): Remove
5966 condition.
5967 * tui/tui-wingeneral.c (tui_source_window_base::make_visible):
5968 Remove condition.
5969 * tui/tui-source.c (tui_source_window_base::reset): New method.
5970 * tui/tui-layout.c (make_command_window): Don't call
5971 init_and_make_win.
5972 (make_source_window, make_disasm_window): Don't call
5973 make_source_or_disasm_window.
5974 (make_data_window): Don't call init_and_make_win. Change calling
5975 convention.
5976 (show_source_disasm_command, show_data): Simplify.
5977 (make_source_or_disasm_window): Remove.
5978 (show_source_or_disasm_and_command): Simplify.
5979 * tui/tui-data.h (struct tui_gen_win_info) <reset>: Now virtual.
5980 (struct tui_source_window_base) <reset>: Likewise.
5981 <execution_info>: Remove initializer.
5982 * tui/tui-data.c (tui_source_window_base): Initialize
5983 execution_info.
5984
80110957
TT		 59852019-07-17 Tom Tromey <tom@tromey.com>
5986
5987 * tui/tui-layout.c (tui_set_layout): Remove regs_populate
5988 variable.
5989
cf82af05
TT		 59902019-07-17 Tom Tromey <tom@tromey.com>
5991
5992 * tui/tui.c (tui_rl_other_window): Update.
5993 * tui/tui-wingeneral.c (tui_data_window::refresh_window): Call
5994 superclass method first. Always iterate over regs_content.
5995 (tui_unhighlight_win, tui_highlight_win): Use refresh_window
5996 method.
5997 * tui/tui-win.c (tui_set_focus_command): Update.
5998
01aeb396
TT		 59992019-07-17 Tom Tromey <tom@tromey.com>
6000
6001 * tui/tui-win.c (tui_set_focus_command): Rename from
6002 tui_set_focus. Call tui_enable.
6003 (tui_set_focus_command): Remove.
6004
fd6c75ee
TT		 60052019-07-17 Tom Tromey <tom@tromey.com>
6006
6007 * tui/tui-winsource.c (tui_show_exec_info_content): Don't call
6008 refresh_window.
6009 * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Call
6010 touchwin.
6011 (tui_data_window::refresh_window): Call refresh_window on data
6012 items. Always call superclass refresh_window.
6013 (tui_win_info::refresh): Remove.
6014 (tui_source_window_base::refresh_window): Update.
6015 (tui_refresh_all): Update.
6016 * tui/tui-layout.c (show_source_disasm_command): Remove call to
6017 refresh_window.
6018 (show_source_or_disasm_and_command): Likewise.
6019 * tui/tui-data.h (struct tui_win_info) <refresh>: Remove.
6020 (struct tui_source_window_base) <refresh>: Likewise.
6021
f6cc34a9
TT		 60222019-07-17 Tom Tromey <tom@tromey.com>
6023
6024 * tui/tui-winsource.c (tui_clear_source_content)
6025 (tui_show_source_content): Update.
6026 * tui/tui-source.c (tui_source_window::showing_source_p): Check
6027 whether content is empty.
6028 * tui/tui-data.h (struct tui_source_window_base) <content_in_use>:
6029 Remove.
6030
f31ec9af
TT		 60312019-07-17 Tom Tromey <tom@tromey.com>
6032
6033 * tui/tui-winsource.c (tui_erase_source_content): Clear the
6034 window's contents.
6035 * tui/tui-source.h (tui_set_source_content_nil): Don't declare.
6036 * tui/tui-source.c (tui_set_source_content_nil): Remove.
6037
d1b6f1e5
TT		 60382019-07-17 Tom Tromey <tom@tromey.com>
6039
6040 * tui/tui-data.h (UNDEFINED_ITEM): Remove define.
6041 (struct tui_data_item_window): Update.
6042
d9743a13
TT		 60432019-07-17 Tom Tromey <tom@tromey.com>
6044
6045 * tui/tui-data.h (MAX_CONTENT_COUNT, TUI_NULL_STR)
6046 (DEFAULT_HISTORY_COUNT, WITH_LOCATOR, NO_LOCATOR): Remove
6047 defines.
6048
caf0bc4e
TT		 60492019-07-17 Tom Tromey <tom@tromey.com>
6050
6051 * tui/tui-winsource.h (tui_erase_source_content)
6052 (tui_clear_source_content): Remove "display_prompt" parameter.
6053 * tui/tui-winsource.c (tui_update_source_window_as_is)
6054 (tui_update_source_windows_with_addr): Update.
6055 (tui_clear_source_content): Remove "display_prompt" parameter.
6056 (tui_erase_source_content): Likewise. Simplify.
6057 (tui_show_source_content): Update.
6058 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
6059 * tui/tui-stack.c (tui_show_frame_info): Update.
6060 * tui/tui-data.h (EMPTY_SOURCE_PROMPT, NO_EMPTY_SOURCE_PROMPT):
6061 Remove defines.
6062
9d391078
TT		 60632019-07-17 Tom Tromey <tom@tromey.com>
6064
6065 * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
6066 * tui/tui-disasm.h (tui_set_disassem_content): Add win_info
6067 parameter.
6068 * tui/tui-disasm.c (tui_set_disassem_content): Add win_info
6069 parameter.
6070
a38da35d
TT		 60712019-07-17 Tom Tromey <tom@tromey.com>
6072
6073 * tui/tui-winsource.c (tui_clear_source_content)
6074 (tui_show_source_content, tui_show_exec_info_content)
6075 (tui_clear_exec_info_content): Update.
6076 * tui/tui-stack.c (tui_show_locator_content): Update.
6077 (tui_show_frame_info): Update.
6078 * tui/tui-source.h (tui_source_window): Don't declare.
6079 * tui/tui-source.c (tui_source_window::showing_source_p): Rename
6080 from tui_source_is_displayed.
6081 * tui/tui-data.h (struct tui_gen_win_info) <content_in_use>:
6082 Remove field.
6083 (struct tui_source_window_base) <content_in_use>: New field. Now
6084 bool.
6085 (struct tui_source_window) <showing_source_p>: New method.
6086 (TUI_SRC_WIN): Change cast.
6087 * tui/tui-data.c (tui_initialize_static_data): Update.
6088
c2cd8994
TT		 60892019-07-17 Tom Tromey <tom@tromey.com>
6090
6091 * tui/tui-winsource.c (tui_update_breakpoint_info): Use
6092 location_matches_p.
6093 * tui/tui-source.c (tui_source_window::location_matches_p): New
6094 method.
6095 * tui/tui-disasm.c (tui_disasm_window::location_matches_p): New
6096 method.
6097 * tui/tui-data.h (struct tui_source_window_base)
6098 <location_matches_p>: New method.
6099 (struct tui_source_window, struct tui_disasm_window)
6100 <location_matches_p>: Likewise.
6101
4dde7b34
TT		 61022019-07-17 Tom Tromey <tom@tromey.com>
6103
6104 * tui/tui-win.c (tui_set_win_height_command): Rename from
6105 tui_set_win_height.
6106 (tui_set_win_height_command): Remove.
6107
b73dd877
TT		 61082019-07-17 Tom Tromey <tom@tromey.com>
6109
6110 * tui/tui-source.c (tui_source_window): New constructor. Add
6111 observer.
6112 (~tui_source_window): New destructor.
6113 (tui_source_window::style_changed): New method.
6114 * tui/tui-hooks.c (tui_redisplay_source): Remove.
6115 (tui_attach_detach_observers): Update.
6116 * tui/tui-data.h (struct tui_source_window): Make constructor not
6117 inline. Add destructor.
6118 (struct tui_source_window) <style_changed>: New method.
6119 <m_observable>: New member.
6120
ae2b5380
TT		 61212019-07-17 Tom Tromey <tom@tromey.com>
6122
6123 * tui/tui-data.c (tui_clear_source_windows_detail): Fix typo.
6124 * tui/tui-win.c (tui_resize_all): Fix typo.
6125
1ce3e844
TT		 61262019-07-17 Tom Tromey <tom@tromey.com>
6127
6128 * tui/tui-wingeneral.h (tui_refresh_all): Update.
6129 * tui/tui-wingeneral.c (make_all_visible): Use foreach.
6130 (tui_refresh_all): Remove "list" parameter. Use foreach.
6131 * tui/tui-win.c (window_name_completer): Use foreach.
6132 (tui_refresh_all_win, tui_rehighlight_all, tui_all_windows_info)
6133 (update_tab_width): Likewise.
6134 * tui/tui-layout.c (show_layout): Update.
6135 * tui/tui-data.h (class tui_window_iterator): New.
6136 (struct all_tui_windows): New.
6137 * tui/tui-data.c (tui_partial_win_by_name): Use foreach.
6138
fe3eaf1c
TT		 61392019-07-17 Tom Tromey <tom@tromey.com>
6140
6141 * tui/tui-regs.c (tui_reg_next, tui_reg_prev): Add "current_group"
6142 parameter. Don't reference globals.
6143 (tui_reg_command): Update.
6144
368c1354
TT		 61452019-07-17 Tom Tromey <tom@tromey.com>
6146
6147 * tui/tui-regs.c (tui_show_registers): Simplify.
6148
e80cd204
TT		 61492019-07-17 Tom Tromey <tom@tromey.com>
6150
6151 * tui/tui-regs.c (tui_show_registers): Update.
6152 (tui_show_register_group): Add win_info parameter.
6153
aca2dd16
TT		 61542019-07-17 Tom Tromey <tom@tromey.com>
6155
6156 * tui/tui-regs.c (tui_data_window::display_reg_element_at_line):
6157 Rename from tui_display_reg_element_at_line.
6158 (tui_data_window::display_registers_from_line): Update.
6159 * tui/tui-data.h (struct tui_data_window)
6160 <display_reg_element_at_line>: New method.
6161
517e9505
TT		 61622019-07-17 Tom Tromey <tom@tromey.com>
6163
6164 * tui/tui-regs.h (tui_display_registers_from)
6165 (tui_display_registers_from_line): Don't declare.
6166 * tui/tui-windata.c (tui_data_window::display_all_data)
6167 (tui_data_window::refresh_all)
6168 (tui_data_window::do_scroll_vertical): Update.
6169 * tui/tui-regs.c (tui_data_window::display_registers_from): Rename
6170 from tui_display_registers_from.
6171 (tui_display_reg_element_at_line): Update.
6172 (tui_data_window::display_registers_from_line): Rename from
6173 tui_display_registers_from_line.
6174 * tui/tui-data.h (struct tui_data_window) <display_registers_from,
6175 display_registers_from_line>: New methods.
6176
f76d8b19
TT		 61772019-07-17 Tom Tromey <tom@tromey.com>
6178
6179 * tui/tui-windata.h (tui_erase_data_content): Don't declare.
6180 * tui/tui-windata.c (tui_data_window::erase_data_content): Rename
6181 from tui_erase_data_content.
6182 (tui_data_window::display_all_data)
6183 (tui_data_window::refresh_all)
6184 (tui_data_window::do_scroll_vertical): Update.
6185 * tui/tui-regs.c (tui_show_registers): Update.
6186 * tui/tui-data.h (struct tui_data_window) <erase_data_content>:
6187 New method.
6188
b4094625
TT		 61892019-07-17 Tom Tromey <tom@tromey.com>
6190
6191 * tui/tui-windata.h (tui_delete_data_content_windows): Don't
6192 declare.
6193 * tui/tui-windata.c
6194 (tui_data_window::delete_data_content_windows): Rename from
6195 tui_delete_data_content_windows.
6196 (tui_data_window::display_all_data)
6197 (tui_data_window::do_scroll_vertical): Update.
6198 * tui/tui-data.h (struct tui_data_window)
6199 <delete_data_content_windows>: New method.
6200
c223a729
TT		 62012019-07-17 Tom Tromey <tom@tromey.com>
6202
6203 * tui/tui-windata.h (tui_refresh_data_win): Don't declare.
6204 * tui/tui-regs.h (tui_first_reg_element_inline): Don't declare.
6205
50daf268
TT		 62062019-07-17 Tom Tromey <tom@tromey.com>
6207
6208 * tui/tui-windata.h (tui_display_all_data): Don't declare.
6209 * tui/tui-windata.c (tui_data_window::display_all_data): Rename
6210 from tui_display_all_data.
6211 * tui/tui-win.c
6212 (tui_data_window::do_make_visible_with_new_height): Update.
6213 * tui/tui-regs.c (tui_show_registers): Update.
6214 * tui/tui-layout.c (tui_set_layout): Update.
6215 * tui/tui-data.h (struct tui_data_window) <display_all_data>: New
6216 method.
6217
df5f8cab
TT		 62182019-07-17 Tom Tromey <tom@tromey.com>
6219
6220 * tui/tui-windata.h (tui_display_data_from): Don't declare.
6221 * tui/tui-windata.c (tui_display_data_from): Remove.
6222 (tui_data_window::refresh_all): Update.
6223
80cb6c27
TT		 62242019-07-17 Tom Tromey <tom@tromey.com>
6225
6226 * tui/tui-windata.h (tui_display_data_from_line): Don't declare.
6227 * tui/tui-windata.c (tui_display_data_from_line): Remove.
6228 (tui_display_data_from, tui_data_window::do_scroll_vertical): Call
6229 tui_display_registers_from_line.
6230 * tui/tui-regs.h (tui_display_registers_from_line): Update.
6231 * tui/tui-regs.c (tui_display_registers_from_line): Remove
6232 "force_display" parameter.
6233
baff0c28
TT		 62342019-07-17 Tom Tromey <tom@tromey.com>
6235
6236 * tui/tui-regs.h (tui_first_reg_element_no_inline): Don't
6237 declare.
6238 * tui/tui-regs.c (tui_data_window::first_reg_element_no_inline):
6239 Rename from tui_first_reg_element_no_inline.
6240 (tui_display_reg_element_at_line)
6241 (tui_display_registers_from_line): Update.
6242 * tui/tui-data.h (struct tui_data_window)
6243 <first_reg_element_no_inline>: New method.
6244
3b23c5f2
TT		 62452019-07-17 Tom Tromey <tom@tromey.com>
6246
6247 * tui/tui-windata.c (tui_display_data_from)
6248 (tui_data_window::do_scroll_vertical): Update.
6249 * tui/tui-regs.h (tui_line_from_reg_element_no): Don't declare.
6250 * tui/tui-regs.c (tui_data_window::line_from_reg_element_no):
6251 Rename from tui_line_from_reg_element_no.
6252 (tui_display_registers_from_line): Update.
6253 * tui/tui-data.h (struct tui_data_window)
6254 <line_from_reg_element_no>: New method.
6255
0b5ec218
TT		 62562019-07-17 Tom Tromey <tom@tromey.com>
6257
6258 * tui/tui-regs.h (tui_last_regs_line_no): Don't declare.
6259 * tui/tui-regs.c (tui_data_window::last_regs_line_no): Rename from
6260 tui_last_regs_line_no.
6261 (tui_display_reg_element_at_line)
6262 (tui_display_registers_from_line): Update.
6263 * tui/tui-data.h (struct tui_data_window) <last_regs_line_no>: New
6264 method.
6265
0807ab7b
TT		 62662019-07-17 Tom Tromey <tom@tromey.com>
6267
6268 PR tui/24722:
6269 * tui/tui-winsource.h (tui_update_all_breakpoint_info)
6270 (tui_update_breakpoint_info): Add "being_deleted" parameter.
6271 * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
6272 (tui_update_all_breakpoint_info): Add "being_deleted" parameter.
6273 (tui_update_breakpoint_info): Likewise.
6274 * tui/tui-hooks.c (tui_event_create_breakpoint)
6275 (tui_event_delete_breakpoint, tui_event_modify_breakpoint):
6276 Update.
6277
9ad7fdef
TT		 62782019-07-17 Tom Tromey <tom@tromey.com>
6279
6280 * tui/tui-stack.c (tui_show_frame_info): Consolidate "if"s.
6281
5813316f
TT		 62822019-07-17 Tom Tromey <tom@tromey.com>
6283
6284 * tui/tui-winsource.c (tui_update_source_window_as_is)
6285 (tui_update_source_windows_with_addr): Update.
6286 * tui/tui-source.h (tui_set_source_content)
6287 (tui_show_symtab_source): Add "win_info" parameter.
6288 * tui/tui-source.c (tui_set_source_content): Add "win_info"
6289 parameter.
6290 (tui_show_symtab_source): Likewise.
6291
00e264e7
TT		 62922019-07-17 Tom Tromey <tom@tromey.com>
6293
6294 * tui/tui-wingeneral.c
6295 (tui_check_and_display_highlight_if_needed): Check can_highlight.
6296
06210ce4
TT		 62972019-07-17 Tom Tromey <tom@tromey.com>
6298
6299 * tui/tui-data.h (struct tui_win_info) <can_scroll>: New method.
6300 (struct tui_cmd_window) <can_scroll>: New method.
6301 * tui/tui-command.c (tui_dispatch_ctrl_char): Use can_scroll
6302 method.
6303
381befee
TT		 63042019-07-17 Tom Tromey <tromey@adacore.com>
6305
6306 * ui-out.h (class ui_out) <field_signed, field_fmt_signed,
6307 do_field_signed>: Rename. Change type of "value".
6308 * ui-out.c (ui_out::field_signed): Rename from field_int.
6309 Change type of "value".
6310 (ui_out::field_fmt_signed): Rename from field_fmt_int. Change
6311 type of "value".
6312 * tui/tui-out.h (class tui_ui_out) <do_field_signed>: Rename from
6313 do_field_int. Change type of "value".
6314 * tui/tui-out.c (tui_ui_out::do_field_signed): Rename from
6315 do_field_int. Change type of "value".
6316 * tracepoint.c (trace_status_mi, tfind_1)
6317 (print_one_static_tracepoint_marker): Update.
6318 * thread.c (print_thread_info_1, print_selected_thread_frame):
6319 Update.
6320 * stack.c (print_frame, print_frame_info): Update.
6321 * spu-tdep.c (info_spu_signal_command, info_spu_dma_cmdlist):
6322 Update.
6323 * source.c (print_source_lines_base): Update.
6324 * skip.c (info_skip_command): Update.
6325 * record-btrace.c (btrace_ui_out_decode_error)
6326 (btrace_call_history_src_line): Update.
6327 * python/py-framefilter.c (py_print_single_arg, py_print_frame):
6328 Update.
6329 * progspace.c (print_program_space): Update.
6330 * mi/mi-symbol-cmds.c (mi_cmd_symbol_list_lines): Update.
6331 * mi/mi-out.h (class mi_ui_out) <do_field_signed>: Rename from
6332 do_field_int. Change type of "value".
6333 * mi/mi-out.c (mi_ui_out::do_table_begin)
6334 (mi_ui_out::do_table_header): Update.
6335 (mi_ui_out::do_field_signed): Rename from do_field_int. Change
6336 type of "value".
6337 * mi/mi-main.c (mi_cmd_thread_list_ids, print_one_inferior)
6338 (mi_cmd_data_list_changed_registers, output_register)
6339 (mi_cmd_data_read_memory, mi_load_progress)
6340 (mi_cmd_trace_frame_collected): Update.
6341 * mi/mi-interp.c (mi_on_normal_stop_1, mi_output_solib_attribs):
6342 Update.
6343 * mi/mi-cmd-var.c (print_varobj, mi_cmd_var_create)
6344 (mi_cmd_var_delete, mi_cmd_var_info_num_children)
6345 (mi_cmd_var_list_children, varobj_update_one): Update.
6346 * mi/mi-cmd-stack.c (mi_cmd_stack_info_depth)
6347 (mi_cmd_stack_list_args, list_arg_or_local): Update.
6348 * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_file): Update.
6349 * inferior.c (print_inferior): Update.
6350 * gdb_bfd.c (print_one_bfd): Update.
6351 * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
6352 Update.
6353 * darwin-nat-info.c (darwin_debug_regions_recurse): Update.
6354 * cli-out.h (class cli_ui_out) <do_field_signed>: Rename from
6355 do_field_int. Change type of "value".
6356 * cli-out.c (cli_ui_out::do_field_signed): Rename from
6357 do_field_int. Change type of "value".
6358 * breakpoint.c (watchpoint_check, print_breakpoint_location)
6359 (print_one_breakpoint_location, print_it_catch_fork)
6360 (print_one_catch_fork, print_it_catch_vfork)
6361 (print_one_catch_vfork, print_it_catch_solib)
6362 (print_it_catch_exec, print_it_ranged_breakpoint)
6363 (print_mention_watchpoint, print_mention_masked_watchpoint)
6364 (bkpt_print_it, update_static_tracepoint): Update.
6365 * break-catch-throw.c (print_it_exception_catchpoint): Update.
6366 * break-catch-syscall.c (print_it_catch_syscall): Update.
6367 * ada-tasks.c (print_ada_task_info): Update.
6368 * ada-lang.c (print_it_exception, print_mention_exception):
6369 Update.
6370
6b78c3f8
AB		 63712019-07-17 Andrew Burgess <andrew.burgess@embecosm.com>
6372
6373 PR breakpoints/24541
6374 * gdbarch.c: Regenerate.
6375 * gdbarch.h: Regenerate.
6376 * gdbarch.sh: Adjust return type and parameter types for
6377 'stap_adjust_register'.
6378 (i386_stap_adjust_register): Adjust signature and return new
6379 register name.
6380 * stap-probe.c (stap_parse_register_operand): Adjust use of
6381 'gdbarch_stap_adjust_register'.
6382
d72a9b85
TT		 63832019-07-17 Tom Tromey <tromey@adacore.com>
6384
6385 * s390-linux-nat.c (s390_watch_area): Remove typedef. Don't
6386 declare VEC.
6387 (struct s390_debug_reg_state) <watch_areas, break_areas>: Now
6388 std::vector.
6389 (struct s390_process_info): Add initializers.
6390 (s390_add_process): Use new.
6391 (s390_linux_nat_target::low_forget_process): Use delete.
6392 (s390_linux_nat_target::low_new_fork)
6393 (s390_linux_nat_target::stopped_by_watchpoint)
6394 (s390_linux_nat_target::low_prepare_to_resume)
6395 (s390_linux_nat_target::insert_watchpoint)
6396 (s390_linux_nat_target::insert_hw_breakpoint)
6397 (s390_linux_nat_target::remove_watchpoint)
6398 (s390_linux_nat_target::remove_hw_breakpoint): Update.
6399
206e6c58
JB		 64002019-07-16 John Baldwin <jhb@FreeBSD.org>
6401
6402 * aarch64-fbsd-nat.c: Include regcache.h.
6403 (getregs_supplies, getfpregs_supplies): Remove unused gdbarch
6404 argument.
6405 (aarch64_fbsd_nat_target::fetch_registers)
6406 (aarch64_fbsd_nat_target::store_registers): Remove gdbarch
6407 variable.
6408 * arm-fbsd-nat.c, riscv-fbsd-nat.c: Likewise.
6409
cbde90f2
JB		 64102019-07-16 John Baldwin <jhb@FreeBSD.org>
6411
6412 * fbsd-nat.c: Include gdbarch.h.
6413
07128006
TT		 64142019-07-15 Tom Tromey <tromey@adacore.com>
6415
6416 * mi/mi-out.c (mi_ui_out::do_field_int): Use plongest.
6417
1f77b012
TT		 64182019-07-15 Tom Tromey <tromey@adacore.com>
6419
6420 * mi/mi-out.h (class mi_ui_out) <do_field_unsigned>: Declare.
6421 * mi/mi-out.c (mi_ui_out::do_field_unsigned): New method.
6422 * cli-out.h (class cli_ui_out) <do_field_unsigned>: Declare.
6423 * cli-out.c (cli_ui_out::do_field_int): New method.
6424 * ui-out.c (ui_out::field_unsigned): New method.
6425 * symfile.c (generic_load): Use field_unsigned.
6426 (print_transfer_performance): Likewise.
6427 * record-btrace.c (ui_out_field_uint): Remove.
6428 (btrace_call_history_insn_range, btrace_call_history): Use
6429 field_unsigned.
6430 * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn): Use
6431 field_unsigned.
6432 * ui-out.h (class ui_out) <field_unsigned>: New method.
6433 <do_field_unsigned>: Likewise.
6434
33eca680
TT		 64352019-07-15 Tom Tromey <tromey@adacore.com>
6436
6437 * mi/mi-main.c (list_available_thread_groups): Use field_string.
6438 * mi/mi-interp.c (mi_memory_changed): Use field_string.
6439 * target.c (flash_erase_command): Use field_string.
6440 * infrun.c (print_signal_received_reason): Use field_string.
6441 * i386-tdep.c (i386_mpx_print_bounds): Use field_string.
6442 * breakpoint.c (maybe_print_thread_hit_breakpoint): Use
6443 field_string.
6444 * ada-tasks.c (print_ada_task_info): Use field_string.
6445
ca8d69be
TT		 64462019-07-15 Tom Tromey <tromey@adacore.com>
6447
6448 * target.c (flash_erase_command): Use field_core_addr.
6449 * symfile.c (generic_load): Use field_core_addr.
6450 * sparc64-linux-tdep.c (sparc64_linux_handle_segmentation_fault):
6451 Use field_core_addr.
6452 * i386-linux-tdep.c (i386_linux_handle_segmentation_fault): Use
6453 field_core_addr.
6454
0d4e84ed
AB		 64552019-07-12 Andrew Burgess <andrew.burgess@embecosm.com>
6456
6457 * dwarf2loc.c (dwarf2_evaluate_property): Sign extend property
6458 value if its desired type is smaller than a CORE_ADDR and signed.
6459
9a49df9d
AB		 64602019-07-12 Andrew Burgess <andrew.burgess@embecosm.com>
6461
6462 * dwarf2loc.c (dwarf2_evaluate_property): Update to take account
6463 of changes to field names, and use new is_reference field to
6464 decide if a property is a reference or not.
6465 * dwarf2loc.h (struct dwarf2_locexpr_baton): Add 'is_reference'
6466 field.
6467 (struct dwarf2_property_baton): Update header comment, rename
6468 'referenced_type' to 'property_type' and update comments.
6469 * dwarf2read.c (attr_to_dynamic_prop): Add extra parameter to hold
6470 default property type, store in property baton, update to take
6471 accound of renamed field.
6472 (read_func_scope): Update call to attr_to_dynamic_prop.
6473 (read_array_type): Likewise.
6474 (dwarf2_per_cu_addr_sized_int_type): New function.
6475 (read_subrange_index_type): Move type finding code to
6476 dwarf2_per_cu_addr_sized_int_type.
6477 (read_subrange_type): Update calls to attr_to_dynamic_prop.
6478 (dwarf2_per_cu_addr_type): New function.
6479 (set_die_type): Update calls to attr_to_dynamic_prop.
6480
b86352cf
AB		 64812019-07-12 Andrew Burgess <andrew.burgess@embecosm.com>
6482
6483 * dwarf2read.c (read_subrange_index_type): New function.
6484 (read_subrange_type): Move code into new function and call it.
6485 * gdbtypes.c (create_range_type): Add some asserts.
6486
603490bf
AB		 64872019-07-12 Andrew Burgess <andrew.burgess@embecosm.com>
6488
6489 * dwarf2loc.c (dwarf2_evaluate_property): Change return type, and
6490 update return statements.
6491 * dwarf2loc.h (dwarf2_evaluate_property): Update return type on
6492 declaration, and update comment to match.
6493 * gdbtypes.c (resolve_dynamic_array): Update call to
6494 dwarf2_evaluate_property to match new return type.
6495
592f9d27
AB		 64962019-07-12 Andrew Burgess <andrew.burgess@embecosm.com>
6497
6498 * valarith.c (value_subscripted_rvalue): Change lowerbound
6499 parameter type from int to LONGEST.
6500 * value.h (value_subscripted_rvalue): Likewise in declaration.
6501
60cfcb20
AB		 65022019-07-11 Andrew Burgess <andrew.burgess@embecosm.com>
6503
6504 * cli/cli-utils.c (info_print_command_completer): New function.
6505 * cli/cli-utils.h: Add 'completer.h' include, and forward
6506 declaration for 'struct cmd_list_element'.
6507 (info_print_command_completer): Declare.
6508 * stack.c (_initialize_stack): Add completer for 'info locals' and
6509 'info args'.
6510 * symtab.c (_initialize_symtab): Add completer for 'info
6511 variables' and 'info functions'.
6512 * NEWS: Mention completion for additional info commands.
6513
b16507e0
AB		 65142019-07-11 Andrew Burgess <andrew.burgess@embecosm.com>
6515
6516 * cli/cli-utils.c (extract_info_print_args): Delete.
6517 (extract_arg_maybe_quoted): Delete.
6518 (info_print_options_defs): New variable.
6519 (make_info_print_options_def_group): New function.
6520 (extract_info_print_options): Define new function.
6521 * cli/cli-utils.h (extract_info_print_args): Delete.
6522 (struct info_print_options): New structure.
6523 (extract_info_print_options): Declare new function.
6524 * stack.c (info_locals_command): Update to use new
6525 extract_info_print_options, also add a header comment.
6526 (info_args_command): Likewise.
6527 * symtab.c (info_variables_command): Likewise.
6528 (info_functions_command): Likewise.
6529
021d8588
AB		 65302019-07-11 Andrew Burgess <andrew.burgess@embecosm.com>
6531
6532 * cli/cli-option.c (parse_option): Use extract_string_maybe_quoted
6533 to extract string arguments.
6534 * common/common-utils.c (extract_string_maybe_quoted): New function.
6535 * common/common-utils.h (extract_string_maybe_quoted): Declare.
6536
b777eb6d
TT		 65372019-07-11 Tom Tromey <tromey@adacore.com>
6538
6539 * main.c (get_init_files): Use GDBINIT, not gdbinit.
6540 * auto-load.c (file_is_auto_load_safe): Use GDBINIT, not gdbinit.
6541 * top.h (gdbinit): Don't declare.
6542 * cli/cli-cmds.c (init_cli_cmds): Remove, merging contents
6543 into...
6544 (_initialize_cli_cmds): ...here. Use GDBINIT, not gdbinit.
6545 * top.c (gdb_init): Don't call init_cli_cmds.
6546 (gdbinit): Remove.
6547 * cli/cli-cmds.h (init_cli_cmds): Don't declare.
6548
72ee03ff
TT		 65492019-07-11 Tom Tromey <tromey@adacore.com>
6550
6551 * python/py-inferior.c (add_thread_object): Don't use thread_obj
6552 after it has been moved.
6553
00db9531
SM		 65542019-07-10 Simon Marchi <simon.marchi@polymtl.ca>
6555
6556 * valops.c (value_must_coerce_to_target): Change return type to
6557 bool.
6558 * value.h (value_must_coerce_to_target): Likewise.
6559
f2478a7e
SM		 65602019-07-10 Simon Marchi <simon.marchi@efficios.com>
6561
6562 * breakpoint.c (is_hardware_watchpoint): Remove
6563 forward-declaration.
6564 (is_masked_watchpoint): Change return type to bool.
6565 (is_tracepoint): Likewise.
6566 (is_breakpoint): Likewise.
6567 (is_hardware_watchpoint): Likewise.
6568 (is_watchpoint): Likewise.
6569 (is_no_memory_software_watchpoint): Likewise.
6570 (is_catchpoint): Likewise.
6571 (breakpoint_1): Make FILTER parameter's return type bool.
6572 is_masked_watchpoint): Change return type to bool.
6573 (save_breakpoints): Make FILTER parameter's return type bool.
6574 * breakpoint.h (is_breakpoint): Change return type to bool.
6575 (is_watchpoint): Likewise.
6576 (is_catchpoint): Likewise.
6577 (is_tracepoint): Likewise.
6578
0d12e84c
TT		 65792019-07-10 Tom Tromey <tom@tromey.com>
6580
6581 * defs.h: Don't include gdbarch.h.
6582 * aarch64-ravenscar-thread.c, aarch64-tdep.c, alpha-bsd-tdep.h,
6583 alpha-linux-tdep.c, alpha-mdebug-tdep.c, arch-utils.h, arm-tdep.h,
6584 ax-general.c, btrace.c, buildsym-legacy.c, buildsym.h, c-lang.c,
6585 cli/cli-decode.h, cli/cli-dump.c, cli/cli-script.h,
6586 cli/cli-style.h, coff-pe-read.h, compile/compile-c-support.c,
6587 compile/compile-cplus.h, compile/compile-loc2c.c, corefile.c,
6588 cp-valprint.c, cris-linux-tdep.c, ctf.c, d-lang.c, d-namespace.c,
6589 dcache.c, dicos-tdep.c, dictionary.c, disasm-selftests.c,
6590 dummy-frame.c, dummy-frame.h, dwarf2-frame-tailcall.c,
6591 dwarf2expr.c, expression.h, f-lang.c, frame-base.c,
6592 frame-unwind.c, frv-linux-tdep.c, gdbarch-selftests.c, gdbtypes.h,
6593 go-lang.c, hppa-nbsd-tdep.c, hppa-obsd-tdep.c, i386-dicos-tdep.c,
6594 i386-tdep.h, ia64-vms-tdep.c, interps.h, language.c,
6595 linux-record.c, location.h, m2-lang.c, m32r-linux-tdep.c,
6596 mem-break.c, memattr.c, mn10300-linux-tdep.c, nios2-linux-tdep.c,
6597 objfiles.h, opencl-lang.c, or1k-linux-tdep.c, p-lang.c,
6598 parser-defs.h, ppc-tdep.h, probe.h, python/py-record-btrace.c,
6599 record-btrace.c, record.h, regcache-dump.c, regcache.h,
6600 riscv-fbsd-tdep.c, riscv-linux-tdep.c, rust-exp.y,
6601 sh-linux-tdep.c, sh-nbsd-tdep.c, source-cache.c,
6602 sparc-nbsd-tdep.c, sparc-obsd-tdep.c, sparc-ravenscar-thread.c,
6603 sparc64-fbsd-tdep.c, std-regs.c, target-descriptions.h,
6604 target-float.c, tic6x-linux-tdep.c, tilegx-linux-tdep.c, top.c,
6605 tracefile.c, trad-frame.c, type-stack.h, ui-style.c, utils.c,
6606 utils.h, valarith.c, valprint.c, varobj.c, x86-tdep.c,
6607 xml-support.h, xtensa-linux-tdep.c, cli/cli-cmds.h: Update.
6608 * s390-linux-nat.c, procfs.c, inf-ptrace.c: Likewise.
6609
f06f1252
TT		 66102019-07-10 Tom Tromey <tromey@adacore.com>
6611
6612 * ada-lang.h (is_ada_exception_catchpoint): Declare.
6613 * breakpoint.c (init_ada_exception_breakpoint): Register as
6614 bp_catchpoint.
6615 (print_one_breakpoint_location, print_one_breakpoint): Use
6616 is_ada_exception_catchpoint.
6617 * ada-lang.c (class ada_catchpoint_location): Pass
6618 bp_loc_software_breakpoint to bp_location constructor.
6619 (is_ada_exception_catchpoint): New function.
6620
7a5d944b
TT		 66212019-07-10 Tom Tromey <tromey@adacore.com>
6622
6623 * arm-tdep.c (arm_exidx_entry_s): Remove typedef. Don't define
6624 VEC.
6625 (struct arm_exidx_entry): New method operator<.
6626 (struct arm_exidx_data) <section_maps>: Change type.
6627 (arm_exidx_data_free): Remove.
6628 (arm_exidx_data_key): Change type. Move lower.
6629 (arm_exidx_new_objfile): Update.
6630 (arm_compare_exidx_entries): Remove.
6631 (arm_find_exidx_entry, _initialize_arm_tdep)
6632
48c66e1d
TT		 66332019-07-10 Tom Tromey <tromey@adacore.com>
6634
6635 * solib-spu.c (ocl_program_data_key): Change type.
6636 (append_ocl_sos, ocl_enable_break, _initialize_spu_solib):
6637 Update.
6638
a269fbf1
TT		 66392019-07-10 Tom Tromey <tromey@adacore.com>
6640
6641 * solib-aix.c (lm_info_aix_p): Remove typedef. Don't define VEC.
6642 (struct solib_aix_inferior_data) <library_list>: Change type.
6643 (solib_aix_inferior_data_handle): Change type.
6644 (get_solib_aix_inferior_data): Update.
6645 (solib_aix_free_library_list): Remove.
6646 (library_list_start_library): Update.
6647 (solib_aix_parse_libraries, solib_aix_get_library_list): Change
6648 return type.
6649 (solib_aix_get_library_list)
6650 (solib_aix_solib_create_inferior_hook, solib_aix_current_sos)
6651 (solib_aix_normal_stop_observer, _initialize_solib_aix): Update.
6652
c294730c
TT		 66532019-07-10 Tom Tromey <tromey@adacore.com>
6654
6655 * solib-dsbt.c (struct dsbt_info): Add initializers.
6656 (solib_dsbt_pspace_data): Change type.
6657 (dsbt_pspace_data_cleanup): Remove.
6658 (get_dsbt_info, _initialize_dsbt_solib): Update.
6659
9d52077d
TT		 66602019-07-10 Tom Tromey <tromey@adacore.com>
6661
6662 * spu-tdep.c (spu_overlay_data): Change type.
6663 (spu_get_overlay_table, spu_overlay_new_objfile)
6664 (_initialize_spu_tdep): Update.
6665
22a20dca
TT		 66662019-07-10 Tom Tromey <tromey@adacore.com>
6667
6668 * gdb-stabs.h (struct dbx_symfile_info): Add initializers and
6669 destructor.
6670 (dbx_objfile_data_key): Change type and declare later.
6671 (DBX_SYMFILE_INFO): Rewrite.
6672 * dbxread.c (dbx_objfile_data_key): Change type.
6673 (dbx_symfile_init): Update.
6674 (~dbx_symfile_info): Rename from dbx_free_symfile_info. Update.
6675 (coffstab_build_psymtabs, elfstab_build_psymtabs)
6676 (stabsect_build_psymtabs, _initialize_dbxread): Update.
6677
cb60f420
TT		 66782019-07-10 Tom Tromey <tromey@adacore.com>
6679
6680 * jit.c (jit_program_space_key): Change type. Move lower.
6681 (get_jit_program_space_data): Update.
6682 (jit_program_space_data_cleanup): Remove.
6683 (jit_breakpoint_deleted, free_objfile_data, _initialize_jit):
6684 Update.
6685 (struct jit_program_space_data): Add initializers.
6686
51df2ae3
TT		 66872019-07-10 Tom Tromey <tromey@adacore.com>
6688
6689 * solib-darwin.c (struct darwin_info): Add initializers.
6690 (solib_darwin_pspace_data): Change type.
6691 (darwin_pspace_data_cleanup): Remove.
6692 (get_darwin_info, _initialize_darwin_solib): Update.
6693
18101a35
TT		 66942019-07-10 Tom Tromey <tromey@adacore.com>
6695
6696 * remote-sim.c (struct sim_inferior_data): Add initializers,
6697 constructor, and destructor.
6698 (sim_inferior_data_key): Change type. Move lower.
6699 (check_for_duplicate_sim_descriptor): Update.
6700 (get_sim_inferior_data): Use new. Update.
6701 (~sim_inferior_data_cleanup): Rename from
6702 sim_inferior_data_cleanup. Simplify.
6703 (gdbsim_close_inferior, simulator_command)
6704 (sim_command_completer, _initialize_remote_sim): Update.
6705 (next_pid, INITIAL_PID): Move earlier.
6706
05b08ac1
TT		 67072019-07-10 Tom Tromey <tromey@adacore.com>
6708
6709 * python/python-internal.h (create_thread_object): Return
6710 gdbpy_ref.
6711 * python/py-infthread.c (create_thread_object): Return gdbpy_ref.
6712 * python/py-inferior.c (struct threadlist_entry): Add
6713 constructor.
6714 <thread_obj>: Now a gdbpy_ref.
6715 (thread_to_thread_object): Update.
6716 (add_thread_object): Use new.
6717 (delete_thread_object): Use delete.
6718 (infpy_threads): Update.
6719 (py_free_inferior): Update. Construct "inf_obj" after acquiring
6720 GIL.
6721
32372d80
TT		 67222019-07-10 Tom Tromey <tromey@adacore.com>
6723
6724 * valops.c (value_cast): Specialize error message for Ada.
6725
5c458ae8
SM		 67262019-07-10 Simon Marchi <simon.marchi@polymtl.ca>
6727
6728 * breakpoint.c (breakpoint_1): Update doc and parameter names.
6729
4c462cb0
SM		 67302019-07-10 Simon Marchi <simon.marchi@polymtl.ca>
6731
6732 * breakpoint.h (bpstat_explains_signal, bpstat_causes_stop,
6733 bpstat_should_step): Return bool, adjust comments.
6734 * breakpoint.c (bpstat_explains_signal, bpstat_causes_stop,
6735 bpstat_should_step): Likewise.
6736
89abbcc2
AH		 67372019-07-10 Alan Hayward <alan.hayward@arm.com>
6738
6739 * features/Makefile: Use feature target descriptions for Arm.
6740 * features/arm/arm-core.c: Generate new file.
6741 * features/arm/arm-fpa.c: Likewise.
6742 * features/arm/arm-m-profile-with-fpa.xml: Likewise.
6743 * features/arm/arm-m-profile.c: Likewise.
6744 * features/arm/arm-vfpv2.c: Likewise.
6745 * features/arm/arm-vfpv3.c: Likewise.
6746 * features/arm/xscale-iwmmxt.c: Likewise.
6747 * target-descriptions.c (maint_print_c_tdesc_cmd): Add Arm.
6748
166a82be
AH		 67492019-07-10 Alan Hayward <alan.hayward@arm.com>
6750
6751 * arm-linux-nat.c (arm_linux_nat_target::read_description): Check
6752 ptrace earlier.
6753
9fb4c7e9
AH		 67542019-07-10 Alan Hayward <alan.hayward@arm.com>
6755
6756 * features/aarch64-pauth.c: Regenerate.
6757
e2d0f980
SM		 67582019-07-09 Simon Marchi <simon.marchi@polymtl.ca>
6759
6760 * breakpoint.h (struct bpstat_what) <is_longjmp>: Change type to
6761 bool.
6762 (bpstat_what): Use false instead of 0.
6763
a38118e5
PA		 67642019-07-09 Pedro Alves <palves@redhat.com>
6765
6766 * break-catch-throw.c (is_exception_catchpoint): New.
6767 * breakpoint.c (print_one_breakpoint_location): New parameter
6768 'raw_loc'. Handle it. Use
6769 is_watchpoint/is_catchpoint/is_exception_catchpoint instead of
6770 looking at the breakpoint's type.
6771 (print_one_breakpoint): If handling "maint info breakpoints", also
6772 print locations of exception catchpoints.
6773 * breakpoint.h (is_exception_catchpoint): Declare.
6774
cb1e4e32
PA		 67752019-07-09 Pedro Alves <palves@redhat.com>
6776
6777 * break-catch-throw.c (print_one_exception_catchpoint): Skip the
6778 "addr" field.
6779 (allocate_location_exception_catchpoint): New.
6780 (handle_gnu_v3_exceptions): Don't reset 'type' to bp_breakpoint.
6781 (initialize_throw_catchpoint_ops): Install
6782 allocate_location_exception_catchpoint as allocate_location
6783 method.
6784 * breakpoint.c (bpstat_what) <bp_catch>: Set action to
6785 BPSTAT_WHAT_SINGLE if not stopping and the location's type is not
6786 bp_loc_other.
6787 (breakpoint_address_is_meaningful): Delete.
6788 (bl_address_is_meaningful): New.
6789 (breakpoint_locations_match): Adjust comment.
6790 (bp_location_from_bp_type): New, factored out of...
6791 (bp_location::bp_location(breakpoint *)): ... this.
6792 (bp_location::bp_location(breakpoint *, bp_loc_type)): New,
6793 factored out of...
6794 (bp_location::bp_location(breakpoint *)): ... this. Reimplement.
6795 (bp_loc_is_permanent): Use bl_address_is_meaningful instead of
6796 breakpoint_address_is_meaningful.
6797 (bp_locations_compare): Adjust comment.
6798 (update_global_location_list): Use bl_address_is_meaningful
6799 instead of breakpoint_address_is_meaningful.
6800 * breakpoint.h (bp_location::bp_location(breakpoint *)): New
6801 explicit.
6802 (bp_location::bp_location(breakpoint *, bp_loc_type)): Declare.
6803 * python/py-breakpoint.c (bppy_get_location): No longer check
6804 whether location is null.
6805
b58a68fe
PA		 68062019-07-09 Pedro Alves <palves@redhat.com>
6807
6808 PR c++/15468
6809 * breakpoint.c (print_one_breakpoint_location): Remove
6810 single-location assert.
6811
268a13a5
TT		 68122019-07-09 Tom Tromey <tom@tromey.com>
6813
6814 * contrib/ari/gdb_ari.sh: Change common to gdbsupport.
6815 * configure: Rebuild.
6816 * configure.ac: Change common to gdbsupport.
6817 * gdbsupport: Rename from common.
6818 * acinclude.m4: Change common to gdbsupport.
6819 * Makefile.in (CONFIG_SRC_SUBDIR, COMMON_SFILES)
6820 (HFILES_NO_SRCDIR, stamp-version, ALLDEPFILES): Change common to
6821 gdbsupport.
6822 * aarch64-tdep.c, ada-lang.c, ada-lang.h, agent.c, alloc.c,
6823 amd64-darwin-tdep.c, amd64-dicos-tdep.c, amd64-fbsd-nat.c,
6824 amd64-fbsd-tdep.c, amd64-linux-nat.c, amd64-linux-tdep.c,
6825 amd64-nbsd-tdep.c, amd64-obsd-tdep.c, amd64-sol2-tdep.c,
6826 amd64-tdep.c, amd64-windows-tdep.c, arch-utils.c,
6827 arch/aarch64-insn.c, arch/aarch64.c, arch/aarch64.h, arch/amd64.c,
6828 arch/amd64.h, arch/arm-get-next-pcs.c, arch/arm-linux.c,
6829 arch/arm.c, arch/i386.c, arch/i386.h, arch/ppc-linux-common.c,
6830 arch/riscv.c, arch/riscv.h, arch/tic6x.c, arm-tdep.c, auto-load.c,
6831 auxv.c, ax-gdb.c, ax-general.c, ax.h, breakpoint.c, breakpoint.h,
6832 btrace.c, btrace.h, build-id.c, build-id.h, c-lang.h, charset.c,
6833 charset.h, cli/cli-cmds.c, cli/cli-cmds.h, cli/cli-decode.c,
6834 cli/cli-dump.c, cli/cli-option.h, cli/cli-script.c,
6835 coff-pe-read.c, command.h, compile/compile-c-support.c,
6836 compile/compile-c.h, compile/compile-cplus-symbols.c,
6837 compile/compile-cplus-types.c, compile/compile-cplus.h,
6838 compile/compile-loc2c.c, compile/compile.c, completer.c,
6839 completer.h, contrib/ari/gdb_ari.sh, corefile.c, corelow.c,
6840 cp-support.c, cp-support.h, cp-valprint.c, csky-tdep.c, ctf.c,
6841 darwin-nat.c, debug.c, defs.h, disasm-selftests.c, disasm.c,
6842 disasm.h, dtrace-probe.c, dwarf-index-cache.c,
6843 dwarf-index-cache.h, dwarf-index-write.c, dwarf2-frame.c,
6844 dwarf2expr.c, dwarf2loc.c, dwarf2read.c, event-loop.c,
6845 event-top.c, exceptions.c, exec.c, extension.h, fbsd-nat.c,
6846 features/aarch64-core.c, features/aarch64-fpu.c,
6847 features/aarch64-pauth.c, features/aarch64-sve.c,
6848 features/i386/32bit-avx.c, features/i386/32bit-avx512.c,
6849 features/i386/32bit-core.c, features/i386/32bit-linux.c,
6850 features/i386/32bit-mpx.c, features/i386/32bit-pkeys.c,
6851 features/i386/32bit-segments.c, features/i386/32bit-sse.c,
6852 features/i386/64bit-avx.c, features/i386/64bit-avx512.c,
6853 features/i386/64bit-core.c, features/i386/64bit-linux.c,
6854 features/i386/64bit-mpx.c, features/i386/64bit-pkeys.c,
6855 features/i386/64bit-segments.c, features/i386/64bit-sse.c,
6856 features/i386/x32-core.c, features/riscv/32bit-cpu.c,
6857 features/riscv/32bit-csr.c, features/riscv/32bit-fpu.c,
6858 features/riscv/64bit-cpu.c, features/riscv/64bit-csr.c,
6859 features/riscv/64bit-fpu.c, features/tic6x-c6xp.c,
6860 features/tic6x-core.c, features/tic6x-gp.c, filename-seen-cache.h,
6861 findcmd.c, findvar.c, fork-child.c, gcore.c, gdb_bfd.c, gdb_bfd.h,
6862 gdb_proc_service.h, gdb_regex.c, gdb_select.h, gdb_usleep.c,
6863 gdbarch-selftests.c, gdbthread.h, gdbtypes.h, gnu-nat.c,
6864 go32-nat.c, guile/guile.c, guile/scm-ports.c,
6865 guile/scm-safe-call.c, guile/scm-type.c, i386-fbsd-nat.c,
6866 i386-fbsd-tdep.c, i386-go32-tdep.c, i386-linux-nat.c,
6867 i386-linux-tdep.c, i386-tdep.c, i387-tdep.c,
6868 ia64-libunwind-tdep.c, ia64-linux-nat.c, inf-child.c,
6869 inf-ptrace.c, infcall.c, infcall.h, infcmd.c, inferior-iter.h,
6870 inferior.c, inferior.h, inflow.c, inflow.h, infrun.c, infrun.h,
6871 inline-frame.c, language.h, linespec.c, linux-fork.c, linux-nat.c,
6872 linux-tdep.c, linux-thread-db.c, location.c, machoread.c,
6873 macrotab.h, main.c, maint.c, maint.h, memattr.c, memrange.h,
6874 mi/mi-cmd-break.h, mi/mi-cmd-env.c, mi/mi-cmd-stack.c,
6875 mi/mi-cmd-var.c, mi/mi-interp.c, mi/mi-main.c, mi/mi-parse.h,
6876 minsyms.c, mips-linux-tdep.c, namespace.h,
6877 nat/aarch64-linux-hw-point.c, nat/aarch64-linux-hw-point.h,
6878 nat/aarch64-linux.c, nat/aarch64-sve-linux-ptrace.c,
6879 nat/amd64-linux-siginfo.c, nat/fork-inferior.c,
6880 nat/linux-btrace.c, nat/linux-btrace.h, nat/linux-namespaces.c,
6881 nat/linux-nat.h, nat/linux-osdata.c, nat/linux-personality.c,
6882 nat/linux-procfs.c, nat/linux-ptrace.c, nat/linux-ptrace.h,
6883 nat/linux-waitpid.c, nat/mips-linux-watch.c,
6884 nat/mips-linux-watch.h, nat/ppc-linux.c, nat/x86-dregs.c,
6885 nat/x86-dregs.h, nat/x86-linux-dregs.c, nat/x86-linux.c,
6886 nto-procfs.c, nto-tdep.c, objfile-flags.h, objfiles.c, objfiles.h,
6887 obsd-nat.c, observable.h, osdata.c, p-valprint.c, parse.c,
6888 parser-defs.h, ppc-linux-nat.c, printcmd.c, probe.c, proc-api.c,
6889 procfs.c, producer.c, progspace.h, psymtab.h,
6890 python/py-framefilter.c, python/py-inferior.c, python/py-ref.h,
6891 python/py-type.c, python/python.c, record-btrace.c, record-full.c,
6892 record.c, record.h, regcache-dump.c, regcache.c, regcache.h,
6893 remote-fileio.c, remote-fileio.h, remote-sim.c, remote.c,
6894 riscv-tdep.c, rs6000-aix-tdep.c, rust-exp.y, s12z-tdep.c,
6895 selftest-arch.c, ser-base.c, ser-event.c, ser-pipe.c, ser-tcp.c,
6896 ser-unix.c, skip.c, solib-aix.c, solib-target.c, solib.c,
6897 source-cache.c, source.c, source.h, sparc-nat.c, spu-linux-nat.c,
6898 stack.c, stap-probe.c, symfile-add-flags.h, symfile.c, symfile.h,
6899 symtab.c, symtab.h, target-descriptions.c, target-descriptions.h,
6900 target-memory.c, target.c, target.h, target/waitstatus.c,
6901 target/waitstatus.h, thread-iter.h, thread.c, tilegx-tdep.c,
6902 top.c, top.h, tracefile-tfile.c, tracefile.c, tracepoint.c,
6903 tracepoint.h, tui/tui-io.c, ui-file.c, ui-out.h,
6904 unittests/array-view-selftests.c,
6905 unittests/child-path-selftests.c, unittests/cli-utils-selftests.c,
6906 unittests/common-utils-selftests.c,
6907 unittests/copy_bitwise-selftests.c, unittests/environ-selftests.c,
6908 unittests/format_pieces-selftests.c,
6909 unittests/function-view-selftests.c,
6910 unittests/lookup_name_info-selftests.c,
6911 unittests/memory-map-selftests.c, unittests/memrange-selftests.c,
6912 unittests/mkdir-recursive-selftests.c,
6913 unittests/observable-selftests.c,
6914 unittests/offset-type-selftests.c, unittests/optional-selftests.c,
6915 unittests/parse-connection-spec-selftests.c,
6916 unittests/ptid-selftests.c, unittests/rsp-low-selftests.c,
6917 unittests/scoped_fd-selftests.c,
6918 unittests/scoped_mmap-selftests.c,
6919 unittests/scoped_restore-selftests.c,
6920 unittests/string_view-selftests.c, unittests/style-selftests.c,
6921 unittests/tracepoint-selftests.c, unittests/unpack-selftests.c,
6922 unittests/utils-selftests.c, unittests/xml-utils-selftests.c,
6923 utils.c, utils.h, valarith.c, valops.c, valprint.c, value.c,
6924 value.h, varobj.c, varobj.h, windows-nat.c, x86-linux-nat.c,
6925 xml-support.c, xml-support.h, xml-tdesc.h, xstormy16-tdep.c,
6926 xtensa-linux-nat.c, dwarf2read.h: Change common to gdbsupport.
6927
5b0e2db4
AB		 69282019-07-09 Andrew Burgess <andrew.burgess@embecosm.com>
6929
6930 * linespec.c (decode_digits_list_mode): Set explicit_line to a
6931 bool value.
6932 (decode_digits_ordinary): Set explicit_line field in sal.
6933 * symtab.c (skip_prologue_sal): Don't skip prologue for a
6934 symtab_and_line that was set on an explicit line number in
6935 assembler code. Do always update the recorded symtab and line if
6936 we do skip the prologue.
6937
0ba852ab
AB		 69382019-07-09 Andrew Burgess <andrew.burgess@embecosm.com>
6939
6940 * breakpoint.c (set_breakpoint_location_function): Remove
6941 explicit_loc parameter.
6942 (momentary_breakpoint_from_master): Update call to
6943 set_breakpoint_location_function.
6944 (add_location_to_breakpoint): Likewise.
6945
b3a7d171
AB		 69462019-07-09 Andrew Burgess <andrew.burgess@embecosm.com>
6947
6948 * riscv-tdep.c (riscv_features_from_gdbarch_info): Don't modify
6949 required features based on default bfd type when no specific bfd
6950 is present.
6951
1f6f6e21
PW		 69522019-07-08 Philippe Waroquiers <philippe.waroquiers@skynet.be>
6953
6954 * NEWS: Mention that GDB printf and eval commands can now print
6955 C-style and Ada-style convenience var strings without
6956 calling the inferior.
6957 * printcmd.c (printf_c_string): Locally print GDB internal var
6958 instead of transiting via the inferior.
6959 (printf_wide_c_string): Likewise.
6960
69612019-07-04 Alan Hayward <alan.hayward@arm.com>
ea142fbf 6962
5862c886 6963 PR breakpoints/25011
ea142fbf
AH		 6964 * symfile.c (symbol_file_command): Call solib_create_inferior_hook.
6965
0598af48
TT		 69662019-07-04 Tom Tromey <tom@tromey.com>
6967
6968 PR tui/24724:
6969 * tui/tui-winsource.c (tui_clear_source_content): Update.
6970 (tui_source_window_base::set_is_exec_point_at): Fix comment.
6971 (tui_update_breakpoint_info): Update.
6972 (tui_set_exec_info_content): Update.
6973 * tui/tui-source.c (tui_set_source_content_nil): Update.
6974 * tui/tui-disasm.c (tui_set_disassem_content): Don't set
6975 has_break.
6976 * tui/tui-data.h (enum tui_bp_flag): New.
6977 (tui_bp_flags): New enum flags type.
6978 (struct tui_source_element) <break_mode>: Change type. Rename
6979 from has_break.
6980 (TUI_BP_ENABLED, TUI_BP_DISABLED, TUI_BP_HIT)
6981 (TUI_BP_CONDITIONAL, TUI_BP_HARDWARE): Don't define. Now enum
6982 constants.
6983 * tui/tui-winsource.h: Fix comment.
6984
350fab54
AH		 69852019-07-04 Alan Hayward <alan.hayward@arm.com>
6986
6987 * aarch32-linux-nat.h (VFP_REGS_SIZE): Remove define.
6988 * aarch64-linux-nat.c (fetch_fpregs_from_thread)
6989 (store_fpregs_to_thread)
6990 (aarch64_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
6991 * arch/arm.h (IWMMXT_VEC_REGISTER_SIZE, ARM_CORE_REGS_SIZE)
6992 (ARM_FP_REGS_SIZE, ARM_VFP2_REGS_SIZE, ARM_VFP3_REGS_SIZE)
6993 (IWMMXT_REGS_SIZE): Add define.
6994 * arm-linux-nat.c (IWMMXT_REGS_SIZE): Remove define.
6995 (fetch_vfp_regs, store_vfp_regs)
6996 (arm_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
6997 * arm-tdep.c (arm_register_g_packet_guesses): Use new defines.
6998
f0452268
AH		 69992019-07-04 Alan Hayward <alan.hayward@arm.com>
7000
7001 * arch/arm-get-next-pcs.c (thumb_get_next_pcs_raw): Use ARM_
7002 defines.
7003 * arch/arm-linux.c (arm_linux_sigreturn_next_pc_offset): Likewise.
7004 * arch/arm.h (INT_REGISTER_SIZE) Rename from...
7005 (ARM_INT_REGISTER_SIZE): ...to this.
7006 (ARM_FP_REGISTER_SIZE) (ARM_VFP_REGISTER_SIZE): Add define.
7007 * arm-linux-tdep.c (ARM_LINUX_JB_ELEMENT_SIZE)
7008 (ARM_LINUX_SIZEOF_GREGSET, arm_linux_supply_gregset)
7009 (arm_linux_collect_gregset, supply_nwfpe_register)
7010 (collect_nwfpe_register, arm_linux_collect_nwfpe): Use ARM_
7011 defines.
7012 * arm-linux-tdep.h (ARM_LINUX_SIZEOF_NWFPE, NWFPE_FPSR_OFFSET)
7013 (NWFPE_FPCR_OFFSET, NWFPE_TAGS_OFFSET): Likewise
7014 * arm-nbsd-tdep.c (ARM_NBSD_JB_ELEMENT_SIZE): Likewise.
7015 * arm-tdep.c (arm_push_dummy_call, arm_extract_return_value)
7016 (arm_return_in_memory, arm_store_return_value)
7017 (arm_get_longjmp_target, arm_register_g_packet_guesses)
7018 (arm_record_ld_st_multiple): Likewise.
7019 * arm-tdep.h (FP_REGISTER_SIZE, VFP_REGISTER_SIZE): Remove.
7020 * arm-wince-tdep.c (ARM_WINCE_JB_ELEMENT_SIZE): Use ARM_ defines.
7021
e935475c
AH		 70222019-07-04 Alan Hayward <alan.hayward@arm.com>
7023
7024 * aarch64-linux-tdep.c (aarch64_linux_init_abi): Use
7025 AARCH64_DISPLACED_MODIFIED_INSNS.
7026 * aarch64-tdep.c (struct aarch64_displaced_step_data)
7027 (aarch64_displaced_step_copy_insn): Likewise.
7028 * aarch64-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
7029 (AARCH64_DISPLACED_MODIFIED_INSNS): ...to this.
7030 * arm-linux-tdep.c (arm_linux_cleanup_svc): Use
7031 ARM_DISPLACED_MODIFIED_INSNS.
7032 * arm-tdep.c (arm_gdbarch_init): Likewise.
7033 * arm-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
7034 (ARM_DISPLACED_MODIFIED_INSNS): ...to this.
7035 (struct arm_displaced_step_closure): Use
7036 ARM_DISPLACED_MODIFIED_INSNS.
7037
df0bb381
AH		 70382019-07-04 Alan Hayward <alan.hayward@arm.com>
7039
7040 * features/Makefile: Remove unused xml files.
7041 * features/aarch64.xml: Remove.
7042 * features/i386/amd64-avx-avx512-linux.xml: Remove.
7043 * features/i386/amd64-avx-avx512.xml: Remove.
7044 * features/i386/amd64-avx-linux.xml: Remove.
7045 * features/i386/amd64-avx-mpx-avx512-pku-linux.xml: Remove.
7046 * features/i386/amd64-avx-mpx-avx512-pku.xml: Remove.
7047 * features/i386/amd64-avx-mpx-linux.xml: Remove.
7048 * features/i386/amd64-avx-mpx.xml: Remove.
7049 * features/i386/amd64-avx.xml: Remove.
7050 * features/i386/amd64-linux.xml: Remove.
7051 * features/i386/amd64-mpx-linux.xml: Remove.
7052 * features/i386/amd64-mpx.xml: Remove.
7053 * features/i386/amd64.xml: Remove.
7054 * features/i386/i386-avx-avx512-linux.xml: Remove.
7055 * features/i386/i386-avx-avx512.xml: Remove.
7056 * features/i386/i386-avx-linux.xml: Remove.
7057 * features/i386/i386-avx-mpx-avx512-pku-linux.xml: Remove.
7058 * features/i386/i386-avx-mpx-avx512-pku.xml: Remove.
7059 * features/i386/i386-avx-mpx-linux.xml: Remove.
7060 * features/i386/i386-avx-mpx.xml: Remove.
7061 * features/i386/i386-avx.xml: Remove.
7062 * features/i386/i386-linux.xml: Remove.
7063 * features/i386/i386-mmx-linux.xml: Remove.
7064 * features/i386/i386-mmx.xml: Remove.
7065 * features/i386/i386-mpx-linux.xml: Remove.
7066 * features/i386/i386-mpx.xml: Remove.
7067 * features/i386/i386.xml: Remove.
7068 * features/i386/x32-avx-avx512-linux.xml: Remove.
7069 * features/i386/x32-avx-linux.xml: Remove.
7070 * features/i386/x32-linux.xml: Remove.
7071
edd6266a
AH		 70722019-07-04 Alan Hayward <alan.hayward@arm.com>
7073
7074 * regformats/aarch64.dat: Remove.
7075 * regformats/i386/amd64-avx-avx512-linux.dat: Remove.
7076 * regformats/i386/amd64-avx-linux.dat: Remove.
7077 * regformats/i386/amd64-avx-mpx-avx512-pku-linux.dat: Remove.
7078 * regformats/i386/amd64-avx-mpx-linux.dat: Remove.
7079 * regformats/i386/amd64-linux.dat: Remove.
7080 * regformats/i386/amd64-mpx-linux.dat: Remove.
7081 * regformats/i386/amd64.dat: Remove.
7082 * regformats/i386/i386-avx-avx512-linux.dat: Remove.
7083 * regformats/i386/i386-avx-linux.dat: Remove.
7084 * regformats/i386/i386-avx-mpx-avx512-pku-linux.dat: Remove.
7085 * regformats/i386/i386-avx-mpx-linux.dat: Remove.
7086 * regformats/i386/i386-linux.dat: Remove.
7087 * regformats/i386/i386-mmx-linux.dat: Remove.
7088 * regformats/i386/i386-mpx-linux.dat: Remove.
7089 * regformats/i386/i386.dat: Remove.
7090 * regformats/i386/x32-avx-avx512-linux.dat: Remove.
7091 * regformats/i386/x32-avx-linux.dat: Remove.
7092 * regformats/i386/x32-linux.dat: Remove.
7093
2b40fda7
AH		 70942019-07-04 Alan Hayward <alan.hayward@arm.com>
7095
7096 * aarch64-tdep.c: Remove xml self tests.
7097 * amd64-linux-tdep.c: Likewise.
7098 * amd64-tdep.c: Likewise.
7099 * i386-linux-tdep.c: Likewise.
7100 * i386-tdep.c: Likewise.
7101
5f4ba3e7
PA		 71022019-07-03 Pedro Alves <palves@redhat.com>
7103
7104 PR cli/24732
7105 * cli/cli-cmds.c (struct pipe_cmd_opts): New.
7106 (pipe_cmd_option_defs): New.
7107 (make_pipe_cmd_options_def_group): New.
7108 (pipe_command): Use gdb::option::process_options.
7109 (pipe_command_completer): New function.
7110 (_initialize_cli_cmds): Install completer for "pipe" command.
7111
3d9be6f5
PA		 71122019-07-03 Pedro Alves <palves@redhat.com>
7113
7114 * cli/cli-option.c (union option_value) <string>: New field.
7115 (struct option_def_and_value): Add ctor, move ctor, dtor and
7116 use DISABLE_COPY_AND_ASSIGN.
7117 (option_def_and_value::clear_value): New.
7118 (parse_option, save_option_value_in_ctx, get_val_type_str)
7119 (add_setshow_cmds_for_options): Handle var_string.
7120 * cli-option.h (union option_def::var_address) <string>: New
7121 field.
7122 (struct string_option_def): New.
7123 * maint-test-options.c (struct test_options_opts): Add default
7124 ctor and use DISABLE_COPY_AND_ASSIGN.
7125 <string_opt>: New field.
7126 (test_options_opts::~test_options_opts): New.
7127 (test_options_opts::dump): Also dump "-string".
7128 (test_options_option_defs): Install "string.
7129
41fc454c
PA		 71302019-07-03 Pedro Alves <palves@redhat.com>
7131
7132 * cli/cli-option.c (parse_option) <var_enum>: Don't return an
7133 option_value with a null enumeration.
7134 (complete_options): Save the option values in the context.
7135 (save_option_value_in_ctx): New, factored out from ...
7136 (process_options): ... here.
7137 * cli/cli-utils.c (get_ulongest): Don't advance PP until the end
7138 of the function.
7139 * maint-test-options.c (test_options_opts::dump): New, factored
7140 out from ...
7141 (maintenance_test_options_command_mode): ... here.
7142 (maintenance_test_options_command_completion_result): Delete.
7143 (maintenance_test_options_command_completion_text): Update
7144 comment.
7145 (maintenance_show_test_options_completion_result): Change
7146 prototype. Just print
7147 maintenance_test_options_command_completion_text.
7148 (save_completion_result): New.
7149 (maintenance_test_options_completer_mode): Pass options context to
7150 complete_options, and then save a dump.
7151 (_initialize_maint_test_options): Use add_cmd to install "maint
7152 show test-options-completion-result".
7153
fdbc9870
PA		 71542019-07-03 Pedro Alves <palves@redhat.com>
7155
7156 * NEWS (New commands): Mention "with" and "maint with".
7157 * cli/cli-cmds.c (with_command_1, with_command_completer_1)
7158 (with_command, with_command_completer): New.
7159 (pipe_command): Adjust to new repeat_previous
7160 interface.
7161 (_initialize_cli_cmds): Install the "with" command and its "w"
7162 alias.
7163 * cli/cli-cmds.h (with_command_1, with_command_completer_1): New
7164 declarations.
7165 * cli/cli-setshow.c (parse_cli_var_uinteger)
7166 (parse_cli_var_zuinteger_unlimited, do_set_command): Handle empty
7167 argument strings for all var_types.
7168 (get_setshow_command_value_string): New, factored out from ...
7169 (do_show_command): ... this.
7170 * cli/cli-setshow.h: Include <string>.
7171 (get_setshow_command_value_string): Declare.
7172 * command.h (repeat_previous): Now returns const char *. Adjust
7173 comment.
7174 * maint.c: Include "cli/cli-cmds.h".
7175 (maintenance_with_cmd, maintenance_with_cmd_completer): New.
7176 (_initialize_maint_cmds): Register the "maintenance with" command.
7177 * top.c (repeat_previous): Move bits from pipe_command here:
7178 Return the saved command line, if any; error out if there's no
7179 command to relaunch.
7180
c6ac8931
PA		 71812019-07-03 Pedro Alves <palves@redhat.com>
7182
7183 * NEWS (New commands): Mention "maint set/show test-settings"
7184 instead of "maint test-settings".
7185 * maint-test-settings.c (maintenance_test_settings_list): Delete.
7186 (maintenance_test_settings_set_list): Rename to ...
7187 (maintenance_set_test_settings_list): ... this.
7188 (maintenance_test_settings_show_list): Rename to ...
7189 (maintenance_show_test_settings_list): ... this.
7190 (maintenance_test_settings_cmd): Delete.
7191 (maintenance_test_settings_set_cmd): ...
7192 (maintenance_set_test_settings_cmd): ... this.
7193 (maintenance_test_settings_show_cmd): ...
7194 (maintenance_show_test_settings_cmd): ... this.
7195 (maintenance_test_settings_show_value_cmd):
7196 (maintenance_show_test_settings_value_cmd): ... this.
7197 (_initialize_maint_test_settings): No longer install the "maint
7198 test-settings" prefix command. Rename "maint test-settings set"
7199 to "maint set test-settings", and "maint test-settings show" to
7200 "maint show test-settings". Adjust all subcommands.
7201
d1fcf2fd
PA		 72022019-07-03 Pedro Alves <palves@redhat.com>
7203
7204 * maint-test-settings.c: Fix file's intro comment. Replace all
7205 references to "test-options" with references to "test-settings",
7206 in comments.
7207
970f9d09
PA		 72082019-07-03 Pedro Alves <palves@redhat.com>
7209
7210 * maint-test-settings.c (maintenance_test_settings_xxx)
7211 (maintenance_test_settings_yyy, maintenance_test_settings_zzz):
7212 New.
7213 (maintenance_test_settings_enums): Use them.
7214 (maintenance_test_settings_enum): Default to
7215 maintenance_test_settings_xxx.
7216 (_initialize_maint_test_settings): Initialize
7217 MAINTENANCE_TEST_SETTINGS_FILENAME.
7218
f3869b1a
SM		 72192019-07-02 Simon Marchi <simon.marchi@polymtl.ca>
7220
7221 * breakpoint.h (remove_breakpoints_inf): Change return type to
7222 void, move function documentation here.
7223 * breakpoint.c (remove_breakpoints_inf): Change return type to
7224 void, move function documentation to header.
7225
54d66006
PA		 72262019-07-02 Pedro Alves <palves@redhat.com>
7227
7228 * NEWS (Completion improvements): Mention "info threads".
7229 * thread.c (struct info_threads_opts, info_threads_option_defs)
7230 (make_info_threads_options_def_group): New.
7231 (info_threads_command): Use gdb::option::process_options.
7232 (info_threads_command_completer): New.
7233 (_initialize_thread): Use gdb::option::build_help to build the
7234 help text for "info threads".
7235
854f6088
SM		 72362019-07-02 Simon Marchi <simon.marchi@polymtl.ca>
7237
7238 * defs.h (generic_load): Move from here...
7239 * symfile.h (generic_load): ... to here. Rename name parameter
7240 to args.
7241 * symfile.c (generic_load): Add comment.
7242
54ee4252
TT		 72432019-07-01 Tom Tromey <tromey@adacore.com>
7244
7245 * dwarf2read.c
7246 (dw2_debug_names_iterator::find_vec_in_debug_names): Hoist
7247 declaration of without_params. Fix formatting.
7248
65392b3e
TT		 72492019-07-01 Tom Tromey <tromey@adacore.com>
7250
7251 * ada-exp.y (find_primitive_type): Update.
7252 * ada-lang.h (ada_lookup_symbol): Update.
7253 * ada-lang.c (ada_lookup_symbol): Remove "is_a_field_of_this"
7254 parameter.
7255 (ada_lookup_encoded_symbol, ada_lookup_symbol_nonlocal): Update.
7256
7d7571f0
SDJ		 72572019-06-28 Sergio Durigan Junior <sergiodj@redhat.com>
7258
7259 PR breakpoints/24541
7260 * gdbarch.c: Regenerate.
7261 * gdbarch.h: Regenerate.
7262 * gdbarch.sh: Add 'stap_adjust_register'.
7263 * i386-tdep.c: Include '<unordered_set>'.
7264 (i386_stap_adjust_register): New function.
7265 (i386_elf_init_abi): Register 'i386_stap_adjust_register'.
7266 * stap-probe.c (stap_parse_register_operand): Call
7267 'gdbarch_stap_adjust_register'.
7268
5af5392a
SDJ		 72692019-06-28 Sergio Durigan Junior <sergiodj@redhat.com>
7270
7271 PR python/24742
7272 https://bugzilla.redhat.com/show_bug.cgi?id=1723564
7273 * python/python.c (do_start_initialization): Use 'xmalloc'
7274 instead of 'PyMem_Malloc'.
7275
10d06d82
TT		 72762019-06-28 Tom Tromey <tromey@adacore.com>
7277
7278 * dwarf2read.c (partial_die_info::read): Prefer the linkage name
7279 for Ada.
7280
1b7f24cd
TT		 72812019-06-27 Tom Tromey <tromey@adacore.com>
7282
7283 * arm-tdep.c (arm_objfile_data_key): Move lower. Change type to
7284 objfile_key.
7285 (arm_find_mapping_symbol, arm_record_special_symbol)
7286 (_initialize_arm_tdep): Update.
7287 (arm_objfile_data_free): Remove.
7288
3d507ff2
TT		 72892019-06-27 Tom Tromey <tromey@adacore.com>
7290
7291 * cp-valprint.c (cp_print_value_fields): Pass opts, not options,
7292 to cp_print_static_field.
7293
762c164d
TT		 72942019-06-26 Tom Tromey <tromey@adacore.com>
7295
7296 * minsyms.c (lookup_minimal_symbol_solib_trampoline): Remove.
7297 * minsyms.h (lookup_minimal_symbol_solib_trampoline): Don't
7298 declare.
7299
aa2f9bcf
AH		 73002019-06-26 Alan Hayward <alan.hayward@arm.com>
7301
7302 * features/aarch64-core.c (create_feature_aarch64_core):
7303 Regenerate.
7304 * features/aarch64-core.xml: Add cpsr flags.
7305
3426ae57
AH		 73062019-06-26 Alan Hayward <alan.hayward@arm.com>
7307
7308 * arm-tdep.c (arm_gnu_triplet_regexp): New function.
7309 (arm_gdbarch_init): Add arm_gnu_triplet_regexp.
7310
4838e44c
SM		 73112019-06-25 Simon Marchi <simon.marchi@polymtl.ca>
7312
7313 * arm-tdep.c (struct arm_per_objfile) <section_maps_sorted>: New
7314 field.
7315 (arm_find_mapping_symbol): Sort mapping symbol vectors on first
7316 use.
7317 (arm_record_special_symbol): Don't insert new symbol in sorted
7318 position, push it at the end.
7319
54cc7474
SM		 73202019-06-25 Simon Marchi <simon.marchi@polymtl.ca>
7321
7322 * arm-tdep.c (struct arm_mapping_symbol) (operator <): New.
7323 (arm_mapping_symbol_s): Remove.
7324 (DEF_VEC_O(arm_mapping_symbol_s)): Remove.
7325 (arm_mapping_symbol_vec): New typedef.
7326 (struct arm_per_objfile): Add constructor.
7327 <section_maps>: Change type to
7328 std::unique_ptr<arm_mapping_symbol_vec[]>.
7329 (arm_compare_mapping_symbols): Remove.
7330 (arm_find_mapping_symbol): Adjust to section_maps type change.
7331 (arm_objfile_data_free): Call delete on arm_per_objfile.
7332 (arm_record_special_symbol): Adjust to section_maps type change.
7333 Allocate arm_per_objfile with new.
7334
b65b566c
PW		 73352019-06-25 Philippe Waroquiers <philippe.waroquiers@skynet.be>
7336
7337 * cli/cli-cmds.c (alias_command): Compare the alias prefix
7338 with the command prefix.
7339
c2fc64f5
TT		 73402019-06-25 Tom Tromey <tom@tromey.com>
7341
7342 * tui/tui-wingeneral.c (tui_delete_win): Remove "return".
7343 * tui/tui-data.c (~tui_gen_win_info): Remove "if".
7344
fb54fa76
TT		 73452019-06-25 Tom Tromey <tom@tromey.com>
7346
7347 * tui/tui-layout.c (init_and_make_win): Assert on unrecognized
7348 type.
7349 * tui/tui-data.h (struct tui_gen_win_info): Make constructor
7350 protected.
7351
f7952c57
TT		 73522019-06-25 Tom Tromey <tom@tromey.com>
7353
7354 * tui/tui-winsource.c
7355 (tui_source_window_base::set_is_exec_point_at): Add check against
7356 LOA_ADDRESS.
7357
17568d78
TT		 73582019-06-25 Tom Tromey <tom@tromey.com>
7359
7360 * tui/tui-source.c (tui_set_source_content): Don't check before
7361 xfree.
7362 * tui/tui-disasm.c (tui_disassemble): Don't check before xfree.
7363
53e7cdba
TT		 73642019-06-25 Tom Tromey <tom@tromey.com>
7365
7366 * tui/tui-winsource.h (tui_update_source_window_as_is)
7367 (tui_alloc_source_buffer, tui_line_is_displayed)
7368 (tui_addr_is_displayed): Change type of win_info.
7369 * tui/tui-winsource.c (tui_update_source_window_as_is)
7370 (tui_clear_source_content, tui_show_source_line)
7371 (tui_show_source_content, tui_source_window_base::refill)
7372 (tui_source_window_base::set_is_exec_point_at)
7373 (tui_source_window_base::set_is_exec_point_at)
7374 (tui_update_breakpoint_info, tui_set_exec_info_content): Update.
7375 (tui_alloc_source_buffer, tui_line_is_displayed)
7376 (tui_addr_is_displayed): Change type of win_info. Update.
7377 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
7378 (tui_source_window_base::do_make_visible_with_new_height):
7379 Update.
7380 * tui/tui-source.c (tui_set_source_content)
7381 (tui_set_source_content_nil)
7382 (tui_source_window::do_scroll_vertical): Update.
7383 * tui/tui-layout.c (show_layout): Update.
7384 * tui/tui-disasm.c (tui_set_disassem_content)
7385 (tui_disasm_window::do_scroll_vertical): Update.
7386 * tui/tui-data.h (tui_win_content): Remove.
7387 (struct tui_gen_win_info) <content, content_size>: Remove.
7388 (struct tui_source_element): Add initializers and destructor.
7389 (union tui_which_element, struct tui_win_element): Remove.
7390 (struct tui_source_window_base) <content>: New field.
7391 (struct tui_data_window): Remove destructor.
7392 (tui_alloc_content, tui_free_win_content)
7393 (tui_free_all_source_wins_content): Don't declare.
7394 * tui/tui-data.c (tui_initialize_static_data): Update.
7395 (init_content_element, tui_alloc_content): Remove.
7396 (~tui_gen_win_info): Update.
7397 (~tui_data_window, tui_free_all_source_wins_content)
7398 (tui_free_win_content, free_content, free_content_elements):
7399 Remove.
7400
7908abbf
TT		 74012019-06-25 Tom Tromey <tom@tromey.com>
7402
7403 * tui/tui-winsource.h (tui_clear_source_content)
7404 (tui_erase_source_content, tui_show_source_content): Change type
7405 of win_info.
7406 * tui/tui-winsource.c (tui_clear_source_content)
7407 (tui_erase_source_content, tui_show_source_content): Change type
7408 of win_info.
7409 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
7410 * tui/tui-source.h (tui_set_source_content_nil): Change type of
7411 win_info.
7412 * tui/tui-source.c (tui_set_source_content_nil): Change type of
7413 win_info.
7414 * tui/tui-layout.c (show_source_or_disasm_and_command): Update.
7415
02c28df0
TT		 74162019-06-25 Tom Tromey <tom@tromey.com>
7417
7418 * tui/tui-winsource.c (tui_clear_source_content)
7419 (tui_source_window_base::set_is_exec_point_at): Update.
7420 * tui/tui-source.c (tui_set_source_content_nil): Update.
7421 * tui/tui-data.h (struct tui_source_element) <is_exec_point>: Now
7422 a bool.
7423 * tui/tui-data.c (init_content_element): Update.
7424
6658b1bf
TT		 74252019-06-25 Tom Tromey <tom@tromey.com>
7426
7427 * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Update.
7428 * tui/tui-win.c (make_invisible_and_set_new_height): Update.
7429 * tui/tui-layout.c (init_and_make_win): Update.
7430 * tui/tui.h (enum tui_win_type): Update.
7431 * tui/tui-data.h (tui_win_is_auxiliary): Rename from
7432 tui_win_is_auxillary.
7433 * tui/tui-data.c (tui_win_is_auxiliary): Rename from
7434 tui_win_is_auxillary.
7435
21e1c91e
TT		 74362019-06-25 Tom Tromey <tom@tromey.com>
7437
7438 * tui/tui-wingeneral.c (tui_data_window::refresh_window): Update.
7439 * tui/tui-windata.c (tui_data_window::first_data_item_displayed)
7440 (tui_delete_data_content_windows, tui_display_all_data)
7441 (tui_data_window::do_scroll_vertical, tui_display_data_from):
7442 Update.
7443 * tui/tui-win.c (tui_data_window::set_new_height): Simplify.
7444 * tui/tui-regs.c (tui_last_regs_line_no)
7445 (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
7446 (tui_show_registers): Update.
7447 (tui_show_register_group): Return void. Update.
7448 (tui_display_registers_from, tui_display_reg_element_at_line)
7449 (tui_display_registers_from_line, tui_check_register_values):
7450 Update.
7451 * tui/tui-data.h (union tui_which_element) <data_window>: Remove
7452 member.
7453 (struct tui_data_window) <regs_content>: Now a std::vector.
7454 <regs_content_count>: Remove.
7455 (tui_add_content_elements, tui_free_data_content): Don't declare.
7456 * tui/tui-data.c (tui_data_window::clear_detail): Update.
7457 (init_content_element): Remove DATA_WIN case. Add assert.
7458 (tui_add_content_elements): Remove.
7459 (tui_data_window): Update.
7460 (tui_free_data_content): Remove.
7461 (free_content_elements): Remove DATA_WIN case.
7462
115ac53b
TT		 74632019-06-25 Tom Tromey <tom@tromey.com>
7464
7465 * tui/tui-data.c (tui_data_item_window): Update.
7466 * tui/tui-windata.h (tui_check_data_values): Don't declare.
7467 * tui/tui-windata.c (tui_display_all_data)
7468 (tui_display_data_from_line): Update.
7469 (tui_check_data_values): Remove.
7470 * tui/tui-regs.c (tui_show_register_group)
7471 (tui_display_reg_element_at_line): Update.
7472 * tui/tui-hooks.c (tui_register_changed)
7473 (tui_refresh_frame_and_register_information): Call
7474 tui_check_register_values.
7475 * tui/tui-data.h (struct tui_data_window) <data_content,
7476 data_content_count, data_type>: Remove.
7477 (enum tui_data_type): Remove.
7478
7479 * tui/tui-data.c (tui_data_window::clear_detail)
7480 (~tui_data_window): Update.
7481
eaf9738b
TT		 74822019-06-25 Tom Tromey <tom@tromey.com>
7483
7484 * tui/tui-windata.h (tui_first_data_item_displayed): Don't
7485 declare.
7486 * tui/tui-windata.c (tui_data_window::first_data_item_displayed):
7487 Rename from tui_first_data_item_displayed. Update.
7488 (tui_data_window::refresh_all)
7489 (tui_data_window::do_scroll_vertical): Update.
7490 * tui/tui-data.h (struct tui_data_window)
7491 <first_data_item_displayed>: Declare new method.
7492
31ca4723
TT		 74932019-06-25 Tom Tromey <tom@tromey.com>
7494
7495 * tui/tui-data.h (tui_init_generic_part): Don't declare.
7496 * tui/tui-data.c (tui_init_generic_part): Remove, moving
7497 contents...
7498 (tui_initialize_static_data): ...here.
7499
41bcff7f
TT		 75002019-06-25 Tom Tromey <tom@tromey.com>
7501
7502 * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
7503 (tui_display_registers_from, tui_check_register_values): Update.
7504 (tui_display_register): Remove win_info parameter; update.
7505 (tui_get_register): Change type of parameters.
7506 * tui/tui-data.h (struct tui_data_element): Remove.
7507 (union tui_which_element) <data>: Remove.
7508 <data_window>: Change type.
7509 (struct tui_data_item_window): New.
7510 * tui/tui-data.c (init_content_element): Remove DATA_ITEM_WIN
7511 case. Add assert.
7512 (~tui_data_item_window): New destructor.
7513 (free_content_elements): Remove DATA_ITEM_WIN case.
7514
d2802c33
TT		 75152019-06-25 Tom Tromey <tom@tromey.com>
7516
7517 * tui/tui.h (enum tui_win_type) <MAX_WINDOWS, UNDEFINED_WIN>:
7518 Remove.
7519
dd835f8b
TT		 75202019-06-25 Tom Tromey <tom@tromey.com>
7521
7522 * tui/tui-data.h (struct tui_command_element): Remove.
7523 (union tui_which_element) <command>: Remove.
7524 * tui/tui-data.c (init_content_element): Remove CMD_WIN case. Add
7525 assert.
7526 (free_content_elements): Remove CMD_WIN case.
7527
bd7db367
TT		 75282019-06-25 Tom Tromey <tom@tromey.com>
7529
7530 * tui/tui-layout.c (tui_set_layout): Update.
7531 * tui/tui-data.h (struct tui_layout_def) <split>: Remove.
7532 * tui/tui-data.c (layout_def): Update.
7533
3add462f
TT		 75342019-06-25 Tom Tromey <tom@tromey.com>
7535
7536 * tui/tui-wingeneral.c (tui_refresh_all): Update.
7537 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
7538 (tui_source_window_base::set_new_height): Update.
7539 * tui/tui-stack.c (tui_make_status_line): Change parameter type.
7540 Update.
7541 (tui_set_locator_fullname, tui_set_locator_info)
7542 (tui_show_frame_info): Update.
7543 * tui/tui-source.c (tui_set_source_content)
7544 (tui_source_is_displayed): Update.
7545 * tui/tui-layout.c (show_source_disasm_command, show_data)
7546 (show_source_or_disasm_and_command): Update.
7547 * tui/tui-disasm.c (tui_set_disassem_content)
7548 (tui_get_begin_asm_address): Update.
7549 * tui/tui-data.h (struct tui_locator_element): Remove.
7550 (union tui_which_element) <locator>: Remove.
7551 (struct tui_locator_window): New.
7552 (tui_locator_win_info_ptr): Change return type.
7553 * tui/tui-data.c (_locator): Change type.
7554 (tui_locator_win_info_ptr): Change return type.
7555 (init_content_element): Remove LOCATOR_WIN case. Add assert.
7556 (tui_alloc_content): Add assert.
7557
489e9d8b
TT		 75582019-06-25 Tom Tromey <tom@tromey.com>
7559
7560 * tui/tui-winsource.c
7561 (tui_exec_info_window::maybe_allocate_content): New method.
7562 (tui_set_exec_info_content, tui_show_exec_info_content): Update.
7563 * tui/tui-layout.c (init_and_make_win): Add EXEC_INFO_WIN case.
7564 (make_source_or_disasm_window): Add cast.
7565 * tui/tui-data.h (union tui_which_element) <simple_string>:
7566 Remove.
7567 (struct tui_source_info): New.
7568 (struct tui_source_window_base) <execution_info>: Change type.
7569 * tui/tui-data.c (init_content_element): Remove EXEC_INFO_WIN
7570 case, and add assert.
7571 (tui_alloc_content): Add assert.
7572
c3fabb7d
TT		 75732019-06-25 Tom Tromey <tom@tromey.com>
7574
7575 * tui/tui-data.h (tui_alloc_win_info): Don't declare.
7576 * tui/tui-layout.c (init_and_make_win): Use "new" directly.
7577 * tui/tui-data.c (tui_alloc_win_info): Remove.
7578
bbc228ee
TT		 75792019-06-25 Tom Tromey <tom@tromey.com>
7580
7581 * tui/tui-win.c (tui_set_win_focus_to): Don't check window type.
7582 * tui/tui-wingeneral.c (tui_unhighlight_win): Check
7583 can_highlight.
7584
5fcee43a
TT		 75852019-06-25 Tom Tromey <tom@tromey.com>
7586
7587 * tui/tui-win.c (tui_source_window_base::update_tab_width): Call
7588 make_visible_with_new_height method.
7589 (tui_win_info::make_visible_with_new_height): New method.
7590 (tui_source_window_base::do_make_visible_with_new_height)
7591 (tui_data_window::do_make_visible_with_new_height)
7592 (tui_cmd_window::do_make_visible_with_new_height): New methods.
7593 (make_visible_with_new_height): Remove.
7594 (tui_resize_all, tui_adjust_win_heights): Use
7595 make_visible_with_new_height method.
7596 * tui/tui-data.h (struct tui_win_info)
7597 <do_make_visible_with_new_height, make_visible_with_new_height>:
7598 New methods.
7599 (struct tui_source_window_base, struct tui_data_window)
7600 (struct tui_cmd_window) <do_make_visible_with_new_height>: New
7601 methods.
7602
d83f1fe6
TT		 76032019-06-25 Tom Tromey <tom@tromey.com>
7604
7605 * tui/tui-win.c (tui_source_window_base::update_tab_width): New
7606 method.
7607 (update_tab_width): Call update_tab_width method.
7608 * tui/tui-data.h (struct tui_win_info)
7609 (struct tui_source_window_base) <update_tab_width>: New methods.
7610
17374de4
TT		 76112019-06-25 Tom Tromey <tom@tromey.com>
7612
7613 * tui/tui-wingeneral.h (tui_make_window): Change type of "box_it"
7614 parameter.
7615 * tui/tui-wingeneral.c (tui_make_window): Change type of "box_it"
7616 parameter.
7617 (tui_gen_win_info::make_visible): Update.
7618 * tui/tui-layout.c (init_and_make_win): Change type of "box_it"
7619 parameter.
7620 * tui/tui-data.h (enum tui_box): New enum.
7621 (BOX_WINDOW, DONT_BOX_WINDOW): Remove defines.
7622
f936bca2
TT		 76232019-06-25 Tom Tromey <tom@tromey.com>
7624
7625 * tui/tui-layout.c (make_source_or_disasm_window): Always use
7626 init_and_make_win for EXEC_INFO_WIN.
7627 * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>: No
7628 longer inline.
7629 (struct tui_win_info) <~tui_win_info>: Inline.
7630 (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
7631 Don't declare.
7632 * tui/tui-data.c (source_win, disasm_win): Remove globals.
7633 (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
7634 Remove.
7635 (tui_initialize_static_data): Update.
7636 (~tui_gen_win_info): Handle more cleanup here.
7637 (~tui_source_window_base): Delete "execution_info".
7638 (~tui_win_info): Move code to ~tui_gen_win_info; remove.
7639
d6ba6a11
TT		 76402019-06-25 Tom Tromey <tom@tromey.com>
7641
7642 * tui/tui-layout.c (make_command_window): Don't set
7643 can_highlight.
7644 (show_source_disasm_command): Call the reset method.
7645 (show_data): Don't set can_highlight. Call the reset method.
7646 (tui_gen_win_info::reset): Rename from init_gen_win_info
7647 (init_and_make_win): Simplify. Return tui_gen_win_info.
7648 (show_source_or_disasm_and_command): Call the reset method.
7649 * tui/tui-data.h (struct tui_gen_win_info) <reset>: New method.
7650 (struct tui_cmd_window): Set can_highlight.
7651
48a3bd16
TT		 76522019-06-25 Tom Tromey <tom@tromey.com>
7653
7654 * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Rename
7655 from make_visible.
7656 (tui_make_visible, tui_make_invisible): Rewrite.
7657 (tui_win_info::make_visible): Remove.
7658 (tui_source_window_base::make_visible): Update.
7659 * tui/tui-data.h (struct tui_gen_win_info) <make_visible>: New
7660 method. Moved from...
7661 (struct tui_win_info) <make_visible>: ...here.
7662
c3bd716f
TT		 76632019-06-25 Tom Tromey <tom@tromey.com>
7664
7665 * tui/tui-winsource.c
7666 (tui_source_window_base::do_scroll_horizontal): Remove direction
7667 parameter.
7668 * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Remove
7669 direction parameter.
7670 * tui/tui-win.c (tui_win_info::forward_scroll)
7671 (tui_win_info::backward_scroll, tui_win_info::left_scroll)
7672 (tui_win_info::right_scroll): Update.
7673 * tui/tui-source.c (tui_source_window::do_scroll_vertical): Remove
7674 direction parameter.
7675 * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Remove
7676 direction parameter.
7677 * tui/tui-data.h (enum tui_scroll_direction): Remove.
7678 (struct tui_win_info) <do_scroll_vertical, do_scroll_horizontal>:
7679 Remove direction parameter.
7680 (struct tui_source_window_base, struct tui_source_window)
7681 (struct tui_disasm_window, struct tui_data_window)
7682 (struct tui_cmd_window): Update.
7683
21c32dca
TT		 76842019-06-25 Tom Tromey <tom@tromey.com>
7685
7686 * tui/tui-winsource.h (tui_set_exec_info_content)
7687 (tui_show_exec_info_content, tui_erase_exec_info_content)
7688 (tui_clear_exec_info_content, tui_update_exec_info): Change
7689 argument to tui_source_window_base.
7690 * tui/tui-winsource.c (tui_set_exec_info_content)
7691 (tui_show_exec_info_content, tui_erase_exec_info_content)
7692 (tui_clear_exec_info_content, tui_update_exec_info): Change
7693 argument to tui_source_window_base.
7694
73fbdc65
TT		 76952019-06-25 Tom Tromey <tom@tromey.com>
7696
7697 * tui/tui-winsource.h (tui_set_exec_info_content): Return void.
7698 * tui/tui-winsource.c (tui_set_exec_info_content): Return void.
7699
33325343
TT		 77002019-06-25 Tom Tromey <tom@tromey.com>
7701
7702 * tui/tui-winsource.c (tui_set_exec_info_content): Remove NULL
7703 check.
7704
29d2c474
TT		 77052019-06-25 Tom Tromey <tom@tromey.com>
7706
7707 * tui/tui-winsource.h (tui_alloc_source_buffer): Change return
7708 type to void.
7709 * tui/tui-winsource.c (tui_alloc_source_buffer): Change return
7710 type to void.
7711 * tui/tui-source.c (tui_set_source_content): Update.
7712 * tui/tui-disasm.c (tui_set_disassem_content): Update.
7713
152f3f4b
TT		 77142019-06-25 Tom Tromey <tom@tromey.com>
7715
7716 * tui/tui-win.c (window_name_completer, tui_set_focus)
7717 (tui_all_windows_info): Use name method.
7718 * tui/tui-data.h (struct tui_gen_win_info)
7719 (struct tui_source_window, struct tui_disasm_window)
7720 (struct tui_data_window, struct tui_cmd_window) <name>: New
7721 method.
7722 (tui_win_name): Don't declare.
7723 * tui/tui-data.c (tui_partial_win_by_name): Use name method.
7724 (tui_win_name): Remove.
7725
be4da588
TT		 77262019-06-25 Tom Tromey <tom@tromey.com>
7727
7728 * tui/tui-winsource.h (tui_update_source_window)
7729 (tui_update_source_window_as_is): Change parameter type.
7730 * tui/tui-winsource.c (tui_update_source_window): Change win_info
7731 to be a tui_source_window_base.
7732 (tui_update_source_window_as_is): Likewise.
7733 * tui/tui-win.c (make_visible_with_new_height): Update.
7734
5b81daba
TT		 77352019-06-25 Tom Tromey <tom@tromey.com>
7736
7737 * tui/tui-winsource.c (tui_erase_source_content)
7738 (tui_show_source_content, tui_show_exec_info_content)
7739 (tui_erase_exec_info_content): Use refresh_window method.
7740 * tui/tui-wingeneral.h (tui_refresh_win): Don't declare.
7741 * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Rename
7742 from tui_refresh_win.
7743 (tui_data_window::refresh_window): New method.
7744 (tui_win_info::refresh, tui_source_window_base::refresh)
7745 (tui_refresh_all): Use refresh_window method.
7746 * tui/tui-stack.c (tui_show_locator_content): Call refresh_window
7747 method.
7748 * tui/tui-regs.c (tui_display_register): Call refresh_window
7749 method.
7750 * tui/tui-layout.c (show_source_disasm_command)
7751 (show_source_or_disasm_and_command): Call refresh_window method.
7752 * tui/tui-data.h (struct tui_gen_win_info)
7753 (struct tui_data_window, struct tui_cmd_window) <refresh_window>:
7754 New method.
7755
cb2ce893
TT		 77562019-06-25 Tom Tromey <tom@tromey.com>
7757
7758 * tui/tui.c (tui_rl_other_window, tui_enable)
7759 (tui_is_window_visible, tui_get_command_dimension): Update.
7760 * tui/tui-winsource.c (tui_update_source_window_as_is)
7761 (tui_clear_source_content, tui_erase_source_content)
7762 (tui_show_source_line, tui_source_window_base::refill)
7763 (tui_source_window_base::do_scroll_horizontal)
7764 (tui_source_window_base::set_is_exec_point_at)
7765 (tui_update_breakpoint_info, tui_set_exec_info_content)
7766 (tui_alloc_source_buffer, tui_line_is_displayed)
7767 (tui_addr_is_displayed): Update.
7768 * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
7769 (tui_check_and_display_highlight_if_needed)
7770 (tui_win_info::make_visible, tui_win_info::refresh)
7771 (tui_refresh_all): Update.
7772 * tui/tui-windata.c (tui_first_data_item_displayed)
7773 (tui_delete_data_content_windows, tui_erase_data_content)
7774 (tui_display_all_data, tui_data_window::refresh_all)
7775 (tui_check_data_values): Update.
7776 * tui/tui-win.c (window_name_completer, tui_update_gdb_sizes)
7777 (tui_set_win_focus_to, tui_win_info::forward_scroll)
7778 (tui_win_info::backward_scroll, tui_refresh_all_win)
7779 (tui_resize_all, tui_set_focus, tui_all_windows_info)
7780 (update_tab_width, tui_set_win_height, tui_adjust_win_heights)
7781 (tui_source_window_base::set_new_height)
7782 (tui_data_window::set_new_height)
7783 (make_invisible_and_set_new_height)
7784 (make_visible_with_new_height, new_height_ok)
7785 (parse_scrolling_args): Update.
7786 * tui/tui-stack.c (tui_show_frame_info): Update.
7787 * tui/tui-source.c (tui_set_source_content)
7788 (tui_set_source_content_nil, tui_source_is_displayed)
7789 (tui_source_window::do_scroll_vertical): Update.
7790 * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
7791 (tui_display_registers_from, tui_display_reg_element_at_line)
7792 (tui_check_register_values, tui_reg_command): Update.
7793 * tui/tui-layout.c (tui_default_win_height)
7794 (show_source_disasm_command, show_data, init_and_make_win)
7795 (show_source_or_disasm_and_command): Update.
7796 * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
7797 (tui_redisplay_readline, tui_mld_flush)
7798 (tui_mld_erase_entire_line, tui_mld_getc, tui_cont_sig)
7799 (tui_getc): Update.
7800 * tui/tui-disasm.c (tui_set_disassem_content)
7801 (tui_disasm_window::do_scroll_vertical): Update.
7802 * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>:
7803 Now virtual.
7804 (struct tui_win_info): Derive from tui_gen_win_info.
7805 <~tui_win_info>: Mark as override.
7806 <generic>: Remove member.
7807 * tui/tui-data.c (tui_cmd_window::clear_detail, tui_next_win)
7808 (tui_prev_win, tui_partial_win_by_name, tui_win_info)
7809 (~tui_data_window, ~tui_win_info)
7810 (tui_free_all_source_wins_content): Update.
7811 * tui/tui-command.c (tui_refresh_cmd_win): Update.
7812
ab313b35
TT		 78132019-06-25 Tom Tromey <tom@tromey.com>
7814
7815 * tui/tui-layout.c (init_and_make_win): Use new.
7816 * tui/tui-data.h (struct tui_gen_win_info): Add constructor,
7817 destructor, initializers.
7818 (tui_alloc_generic_win_info): Don't declare.
7819 * tui/tui-data.c (_locator): Add argument to constructor.
7820 (source_win, disasm_win): New globals.
7821 (exec_info): Remove.
7822 (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
7823 Update.
7824 (tui_alloc_generic_win_info): Remove.
7825 (init_content_element): Use new.
7826 (tui_win_info::tui_win_info): Update.
7827 (free_content_elements) <case DATA_WIN>: Use delete.
7828
dc2c33e4
TT		 78292019-06-25 Tom Tromey <tom@tromey.com>
7830
7831 * tui/tui-wingeneral.c (tui_refresh_win): Update.
7832 * tui/tui-windata.c (tui_first_data_item_displayed)
7833 (tui_delete_data_content_windows): Update.
7834 * tui/tui-win.c (tui_data_window::set_new_height): Update.
7835 * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
7836 (tui_display_registers_from, tui_check_register_values): Update.
7837 * tui/tui-data.h (union tui_which_element) <data_window>: Now a
7838 pointer.
7839 * tui/tui-data.c (init_content_element): Update. Allocate the new
7840 window.
7841 (tui_free_data_content): Update.
7842 (free_content_elements) <case DATA_WIN>: Free the window.
7843
214a5cbe
TT		 78442019-06-25 Tom Tromey <tom@tromey.com>
7845
7846 * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win):
7847 Update.
7848 * tui/tui-layout.c (make_command_window)
7849 (show_source_disasm_command, show_data, init_and_make_win)
7850 (show_source_or_disasm_and_command): Update.
7851 * tui/tui-data.h (struct tui_win_info) <set_highlight>: New
7852 method.
7853 <can_highight, is_highlighted>: Now bool.
7854 (tui_set_win_highlight): Don't declare.
7855 * tui/tui-data.c (tui_set_win_highlight): Remove.
7856
8e2daf15
TT		 78572019-06-25 Tom Tromey <tom@tromey.com>
7858
7859 * tui/tui-wingeneral.c (make_visible): Remove check of window
7860 type.
7861
8903bd8a
TT		 78622019-06-25 Tom Tromey <tom@tromey.com>
7863
7864 * tui/tui-win.c (tui_win_info::max_height)
7865 (tui_cmd_window::max_height): New methods.
7866 (new_height_ok): Call max_height.
7867 * tui/tui-data.h (struct tui_win_info, struct tui_cmd_window)
7868 <max_height>: New method.
7869
3f02ce1e
TT		 78702019-06-25 Tom Tromey <tom@tromey.com>
7871
7872 * tui/tui-win.c (tui_source_window_base::set_new_height)
7873 (tui_data_window::set_new_height): New methods.
7874 (make_invisible_and_set_new_height): Call set_new_height method.
7875 * tui/tui-data.h (struct tui_win_info)
7876 (struct tui_source_window_base, struct tui_data_window)
7877 <set_new_height>: New method.
7878
1825f487
TT		 78792019-06-25 Tom Tromey <tom@tromey.com>
7880
7881 * tui/tui.c (tui_rl_other_window): Call the refresh_all method.
7882 * tui/tui-windata.c (tui_data_window::refresh_all): Rename from
7883 tui_refresh_data_win.
7884 * tui/tui-win.c (tui_source_window_base::refresh_all): New
7885 method.
7886 (tui_refresh_all_win): Call the refresh_all method.
7887 (tui_set_focus): Likewise.
7888 * tui/tui-data.h (struct tui_win_info) <refresh_all>: New method.
7889 (struct tui_source_window_base, struct tui_data_window) <refresh>:
7890 Likewise.
7891
ad54d15b
TT		 78922019-06-25 Tom Tromey <tom@tromey.com>
7893
7894 * tui/tui-winsource.h (tui_refill_source_window)
7895 (tui_set_is_exec_point_at): Don't declare.
7896 * tui/tui-winsource.c (tui_update_source_windows_with_addr)
7897 (tui_source_window_base::refill): Rename from
7898 tui_refill_source_window.
7899 (tui_source_window_base::do_scroll_horizontal): Update.
7900 (tui_source_window_base::set_is_exec_point_at): Rename from
7901 tui_set_is_exec_point_at.
7902 (tui_update_all_breakpoint_info): Update.
7903 * tui/tui-stack.c (tui_show_frame_info): Update.
7904 * tui/tui-layout.c (show_data): Add cast.
7905 * tui/tui-hooks.c (tui_redisplay_source): Call refill method.
7906 * tui/tui-data.h (struct tui_source_window_base) <refill,
7907 set_is_exec_point_at>: New methods.
7908 (tui_source_windows, tui_add_to_source_windows): Update types.
7909 (tui_add_to_source_windows): Remove redundant declaration.
7910 * tui/tui-data.c (source_windows): Store tui_source_window_base.
7911 (tui_source_windows): Change return type.
7912 (tui_clear_source_windows_detail): Update.
7913 (tui_add_to_source_windows): Change type of parameter.
7914 (tui_free_all_source_wins_content): Update.
7915
2042b506
TT		 79162019-06-25 Tom Tromey <tom@tromey.com>
7917
7918 * tui/tui-wingeneral.c (tui_win_info::refresh)
7919 (tui_source_window_base::refresh): New methods.
7920 (tui_refresh_all): Call the refresh method.
7921 * tui/tui-data.h (struct tui_win_info)
7922 (struct tui_source_window_base) <refresh>: New method.
7923
56122977
TT		 79242019-06-25 Tom Tromey <tom@tromey.com>
7925
7926 * tui/tui.h (tui_is_window_visible): Return bool.
7927 * tui/tui.c (tui_is_window_visible): Return bool.
7928 * tui/tui-wingeneral.c (tui_make_window, make_visible)
7929 (tui_make_visible, tui_make_invisible)
7930 (tui_win_info::make_visible)
7931 (tui_source_window_base::make_visible, make_all_visible)
7932 (tui_make_all_visible, tui_make_all_invisible): Update.
7933 * tui/tui-windata.c (tui_delete_data_content_windows): Update.
7934 * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: Now
7935 bool.
7936 (struct tui_win_info, struct tui_source_window_base)
7937 (struct tui_cmd_window) <make_visible>: Change parameter to bool.
7938 * tui/tui-data.c (tui_init_generic_part): Update.
7939
cda37efb
TT		 79402019-06-25 Tom Tromey <tom@tromey.com>
7941
7942 * tui/tui-wingeneral.c (tui_win_info::make_visible)
7943 (tui_source_window_base::make_visible): New methods.
7944 (make_all_visible): Make method call.
7945 * tui/tui-data.h (struct tui_win_info) <make_visible>: New method.
7946 (struct tui_source_window_base, struct tui_cmd_window): Override
7947 make_visible.
7948 (tui_win_is_source_type): Don't declare.
7949 * tui/tui-data.c (tui_win_is_source_type): Remove.
7950
6a0ee02c
TT		 79512019-06-25 Tom Tromey <tom@tromey.com>
7952
7953 * tui/tui-layout.c (show_source_or_disasm_and_command): Remove
7954 NULL check.
7955
63901aec
TT		 79562019-06-25 Tom Tromey <tom@tromey.com>
7957
7958 * tui/tui-data.h (struct tui_data_window, struct tui_cmd_window):
7959 Inline constructor. Add initializers for members.
7960 * tui/tui-data.c (tui_data_window, tui_cmd_window): Remove
7961 constructors; now inline in class.
7962
ceb13a13
TT		 79632019-06-25 Tom Tromey <tom@tromey.com>
7964
7965 * tui/tui-regs.c (tui_show_registers): Update.
7966 * tui/tui-data.h (struct tui_data_window) <display_regs>: Now
7967 bool.
7968 * tui/tui-data.c (tui_data_window::clear_detail)
7969 (tui_data_window): Update.
7970
238eb706
TT		 79712019-06-25 Tom Tromey <tom@tromey.com>
7972
7973 * tui/tui-windata.c (tui_display_all_data)
7974 (tui_display_data_from_line, tui_display_data_from)
7975 (tui_check_data_values, tui_data_window::do_scroll_vertical):
7976 Update.
7977 * tui/tui-regs.c (tui_last_regs_line_no)
7978 (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
7979 (tui_show_registers, tui_show_register_group)
7980 (tui_display_registers_from, tui_display_reg_element_at_line)
7981 (tui_display_registers_from_line, tui_check_register_values)
7982 (tui_reg_next, tui_reg_prev): Update.
7983 * tui/tui-layout.c (tui_set_layout, show_data): Update.
7984 * tui/tui-data.h (struct tui_data_info): Remove. Move contents to
7985 tui_data_window.
7986 (struct tui_win_info) <detail>: Remove. Add new fields from
7987 tui_data_info.
7988 (TUI_DATA_WIN): Add cast.
7989 * tui/tui-data.c (tui_data_window::clear_detail, tui_data_window)
7990 (~tui_data_window): Simplify.
7991
81491aa0
TT		 79922019-06-25 Tom Tromey <tom@tromey.com>
7993
7994 * tui/tui-layout.c (show_source_disasm_command)
7995 (show_source_or_disasm_and_command): Update.
7996 * tui/tui-io.c (update_cmdwin_start_line)
7997 (tui_redisplay_readline): Update.
7998 * tui/tui-data.h (struct tui_command_info): Remove.
7999 (struct tui_win_info) <detail>: Remove command_info member.
8000 (struct tui_data_window) <start_line>: New member, from
8001 tui_command_info.
8002 (TUI_CMD_WIN): Add casts.
8003
e6e41501
TT		 80042019-06-25 Tom Tromey <tom@tromey.com>
8005
8006 * tui/tui-winsource.c (tui_update_source_window)
8007 (tui_refill_source_window)
8008 (tui_source_window_base::do_scroll_horizontal)
8009 (tui_update_breakpoint_info, tui_set_exec_info_content)
8010 (tui_show_exec_info_content, tui_erase_exec_info_content)
8011 (tui_clear_exec_info_content): Update.
8012 * tui/tui-wingeneral.c (make_all_visible, tui_refresh_all):
8013 Update.
8014 * tui/tui-win.c (make_invisible_and_set_new_height)
8015 (make_visible_with_new_height): Update.
8016 * tui/tui-source.c (tui_set_source_content)
8017 (tui_show_symtab_source): Update.
8018 * tui/tui-layout.c (extract_display_start_addr)
8019 (show_source_disasm_command, show_data)
8020 (make_source_or_disasm_window)
8021 (show_source_or_disasm_and_command): Update.
8022 * tui/tui-disasm.c (tui_set_disassem_content): Simplify.
8023 (tui_disasm_window::do_scroll_vertical): Remove shadowing
8024 "gdbarch".
8025 * tui/tui-data.h (struct tui_source_info): Remove. Move contents
8026 to tui_source_window_base.
8027 (struct tui_win_info) <detail>: Remove source_info member.
8028 (struct tui_source_window_base) <has_locator>: Inline.
8029 Move contents from tui_source_info; rename has_locator member to
8030 m_has_locator.
8031 (TUI_SRC_WIN, TUI_DISASM_WIN): Add casts.
8032 * tui/tui-data.c (tui_source_window_base::has_locator): Move to
8033 header file.
8034 (tui_source_window_base::clear_detail, ~tui_source_window_base):
8035 Simplify.
8036 (tui_free_all_source_wins_content): Cast to
8037 tui_source_window_base.
8038
44f0e208
TT		 80392019-06-25 Tom Tromey <tom@tromey.com>
8040
8041 * tui/tui-win.c (make_invisible_and_set_new_height)
8042 (make_visible_with_new_height): Call has_locator method.
8043 * tui/tui-layout.c (show_source_disasm_command, show_data)
8044 (show_source_or_disasm_and_command): Update for bool change.
8045 * tui/tui-data.h (struct tui_source_info) <has_locator>: Now bool.
8046 (tui_win_info) <has_locator>: New method.
8047 (struct tui_source_window_base) <has_locator>: New method.
8048 (tui_win_has_locator): Don't declare.
8049 * tui/tui-data.c (tui_source_window_base::has_locator): Rename
8050 from tui_win_has_locator.
8051 (tui_source_window_base): Use false, not FALSE.
8052
7778b912
TT		 80532019-06-25 Tom Tromey <tom@tromey.com>
8054
8055 * tui/tui-data.h (tui_clear_win_detail): Don't declare.
8056 * tui/tui-data.c (tui_clear_source_windows_detail): Call the
8057 clear_detail method directly.
8058 (tui_clear_win_detail): Remove.
8059
f83d391c
TT		 80602019-06-25 Tom Tromey <tom@tromey.com>
8061
8062 * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Use
8063 "this", not TUI_DISASM_WIN.
8064
13446e05
TT		 80652019-06-25 Tom Tromey <tom@tromey.com>
8066
8067 * tui/tui-winsource.h (tui_horizontal_source_scroll): Don't
8068 declare.
8069 * tui/tui-winsource.c
8070 (tui_source_window_base::do_scroll_horizontal): Rename from
8071 tui_horizontal_source_scroll.
8072 * tui/tui-windata.h (tui_vertical_data_scroll): Don't declare.
8073 * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Rename
8074 from tui_vertical_data_scroll.
8075 * tui/tui-win.h (tui_scroll): Don't declare.
8076 * tui/tui-win.c (tui_win_info::forward_scroll)
8077 (tui_win_info::backward_scroll, tui_win_info::left_scroll)
8078 (tui_win_info::right_scroll): Rename and update.
8079 (tui_scroll_forward_command, tui_scroll_backward_command)
8080 (tui_scroll_left_command, tui_scroll_right_command): Update.
8081 (tui_scroll): Remove.
8082 * tui/tui-source.h: Don't declare tui_vertical_source_scroll.
8083 * tui/tui-source.c (tui_source_window::do_scroll_vertical): Rename
8084 from tui_vertical_source_scroll.
8085 * tui/tui-disasm.h (tui_vertical_disassem_scroll): Don't declare.
8086 * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Rename
8087 from tui_vertical_disassem_scroll.
8088 * tui/tui-data.h (struct tui_win_info) <do_scroll_vertical,
8089 do_scroll_horizontal>: New methods.
8090 <forward_scroll, backward_scroll, left_scroll, right_scroll>:
8091 Likewise.
8092 (struct tui_source_window_base): Add do_scroll_horizontal.
8093 (struct tui_source_window, struct tui_disasm_window): Add
8094 do_scroll_vertical.
8095 (struct tui_data_window, struct tui_cmd_window): Add
8096 do_scroll_horizontal and do_scroll_vertical.
8097 * tui/tui-command.c (tui_dispatch_ctrl_char): Use method calls.
8098
5cf82909
TT		 80992019-06-25 Tom Tromey <tom@tromey.com>
8100
8101 * tui/tui-data.h (struct tui_source_window_base): New struct.
8102 (struct tui_source_window): Derive from tui_source_window_base.
8103 (struct tui_disasm_window): New struct.
8104 * tui/tui-data.c (tui_source_window_base::clear_detail): Rename
8105 from tui_source_window::clear_detail.
8106 (tui_source_window_base): Rename from tui_source_window.
8107 (~tui_source_window_base): Rename from ~tui_source_window.
8108 (tui_alloc_win_info): Create a tui_disasm_window.
8109
ee1d42d6
TT		 81102019-06-25 Tom Tromey <tom@tromey.com>
8111
8112 * tui/tui-data.h (struct tui_source_window)
8113 (struct tui_data_window): Declare destructors.
8114 * tui/tui-data.c (~tui_source_window, ~tui_data_window): New
8115 destructors.
8116 (tui_win_info): Simplify.
8117
b4eb2452
TT		 81182019-06-25 Tom Tromey <tom@tromey.com>
8119
8120 * tui/tui-winsource.c (tui_display_main)
8121 (tui_update_source_windows_with_addr)
8122 (tui_update_all_breakpoint_info): Update.
8123 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
8124 (new_height_ok, parse_scrolling_args): Update.
8125 * tui/tui-stack.c (tui_show_frame_info): Update.
8126 * tui/tui-data.h (struct tui_list): Remove.
8127 (tui_source_windows): Return a reference to a std::vector.
8128 * tui/tui-data.c (source_windows): Now a std::vector.
8129 (tui_source_windows): Change return type.
8130 (tui_clear_source_windows): Rewrite.
8131 (tui_clear_source_windows_detail, tui_add_to_source_windows)
8132 (tui_free_all_source_wins_content): Rewrite.
8133
8761a91b
TT		 81342019-06-25 Tom Tromey <tom@tromey.com>
8135
8136 * tui/tui-data.h (struct tui_win_info, struct tui_source_window)
8137 (struct tui_data_window, struct tui_cmd_window): Declare
8138 clear_detail method.
8139 * tui/tui-data.c (tui_source_window::clear_detail)
8140 (tui_cmd_window::clear_detail, tui_data_window::clear_detail): New
8141 methods.
8142 (tui_clear_win_detail): Simplify.
8143
0ed69eda
TT		 81442019-06-25 Tom Tromey <tom@tromey.com>
8145
8146 * tui/tui-layout.c (make_source_window, make_disasm_window)
8147 (make_source_or_disasm_window): Remove win_info_ptr parameter.
8148 Return the new window.
8149 (show_source_disasm_command, show_data)
8150 (show_source_or_disasm_and_command): Update.
8151
82432e10
TT		 81522019-06-25 Tom Tromey <tom@tromey.com>
8153
8154 * tui/tui-layout.c (make_command_window): Remove win_info_ptr
8155 parameter. Return the new window.
8156 (show_source_disasm_command): Update and remove NULL check.
8157 (show_source_or_disasm_and_command): Update.
8158
ec328aa5
TT		 81592019-06-25 Tom Tromey <tom@tromey.com>
8160
8161 * tui/tui-layout.c (init_and_make_win): Remove NULL check.
8162
33b906ab
TT		 81632019-06-25 Tom Tromey <tom@tromey.com>
8164
8165 * tui/tui-data.h (struct tui_win_info): Make constructor
8166 protected. Make destructor virtual. Add initializers.
8167 (tui_source_window, tui_data_window, tui_cmd_window): New
8168 classes.
8169 * tui/tui-data.c (tui_win_info): Rename from init_win_info. Now a
8170 constructor. Add "type" parameter.
8171 (tui_source_window, tui_data_window, tui_cmd_window): New
8172 constructors.
8173 (tui_alloc_win_info): Instantiate the appropriate subclass.
8174
e7e11af4
TT		 81752019-06-25 Tom Tromey <tom@tromey.com>
8176
8177 * tui/tui-win.c (tui_resize_all): Use delete.
8178 * tui/tui-data.h (struct tui_win_info) <~tui_win_info>: Declare
8179 destructor.
8180 (tui_free_window): Don't declare.
8181 * tui/tui-data.c (~tui_win_info): Rename from tui_free_window.
8182 Update.
8183
6792b55e
TT		 81842019-06-25 Tom Tromey <tom@tromey.com>
8185
8186 * tui/tui-data.h (struct tui_win_info): Add constructor.
8187 * tui/tui-data.c (tui_alloc_win_info): Use new.
8188 (tui_free_window): Use delete.
8189
f95675e1
TT		 81902019-06-22 Tom Tromey <tom@tromey.com>
8191
8192 * tui/tui-windata.h (tui_first_data_element_no_in_line): Don't
8193 declare.
8194 * tui/tui-windata.c (tui_first_data_element_no_in_line): Remove.
8195
5bff081c
TT		 81962019-06-22 Tom Tromey <tom@tromey.com>
8197
8198 * tui/tui-data.h (tui_del_window, tui_del_data_windows): Don't
8199 declare.
8200 * tui/tui-data.c (tui_del_window, tui_del_data_windows): Remove.
8201
47e3f474
TV		 82022019-06-22 Tom de Vries <tdevries@suse.de>
8203
8204 * dwarf2read.c (create_addrmap_from_aranges)
8205 (read_debug_names_from_section): Print ptrdiff_t using '%s' and plongest
8206 instead of '%zu'.
8207
fd5866f6
SM		 82082019-06-21 Simon Marchi <simon.marchi@efficios.com>
8209
8210 * dwarf2read.h (dwarf2_section_info_def): Remove.
8211 (DEF_VEC_O (dwarf2_section_info_def)): Remove.
8212 * dwarf2read.c (struct dwo_sections) <types>: Change type to
8213 std::vector<dwarf2_section_info>.
8214 (struct dwo_file) <~dwo_file>: Remove.
8215 (dwarf2_per_objfile::~dwarf2_per_objfile): Don't manually free
8216 types field.
8217 (dwarf2_per_objfile::locate_sections): Adjust to std::vector.
8218 (dwarf2_read_debug_names): Likewise.
8219 (create_debug_types_hash_table): Change parameter type to
8220 array_view, adjust code accordingly.
8221 (dwarf2_locate_dwo_sections): Adjust to std::vector.
8222 (partial_die_info::fixup): Likewise.
8223 (determine_prefix): Likewise.
8224 * dwarf-index-write.c (write_psymtabs_to_index): Adjust.
8225
fb1eb2f9
SM		 82262019-06-21 Simon Marchi <simon.marchi@polymtl.ca>
8227
8228 * dwarf2read.c (struct dwo_file) <dbfd>: Change type to
8229 gdb_bfd_ref_ptr.
8230 <~dwo_file>: Remove call to gdb_bfd_unref.
8231 (open_and_init_dwo_file): Move gdb_bfd_ref_ptr into dbfd field. Call
8232 gdb_bfd_ref_ptr::get.
8233
51ac9db5
SM		 82342019-06-21 Simon Marchi <simon.marchi@polymtl.ca>
8235
8236 * dwarf2read.h (struct dwarf2_per_objfile) <dwo_files>: Change
8237 type to htab_up.
8238 * dwarf2read.c (struct dwo_file): Initialize fields.
8239 <~dwo_file>: New.
8240 (free_dwo_file): Remove, move content to ~dwo_file.
8241 (struct dwo_file_deleter): Remove.
8242 (dwo_file_up>: Remove custom deleter.
8243 (free_dwo_files): Remove.
8244 (dwarf2_per_objfile::~dwarf2_per_objfile): Don't explicitly free
8245 dwo_files.
8246 (process_skeletonless_type_units): Call unique_ptr::get.
8247 (allocate_dwo_file_hash_table): Add deleter to created hash
8248 table. Change return type to htab_up.
8249 (lookup_dwo_file_slot): Don't memset dwo_file, call
8250 unique_ptr::get.
8251 (create_dwo_unit_in_dwp_v1): Allocate dwo_file with new.
8252 (create_dwo_unit_in_dwp_v2): Likewise.
8253 (open_and_init_dwo_file): Likewise.
8254 (free_dwo_file_from_slot): Remove.
8255
dc4ccb6f
SM		 82562019-06-21 Simon Marchi <simon.marchi@polymtl.ca>
8257
8258 * dwarf2read.h (struct dwarf2_section_info) <readin,
8259 is_virtual>: Change type to bool.
8260 * dwarf2read.c (dwarf2_read_section, create_dwp_v2_section): Use
8261 true instead of 1.
8262
e6a1c5cb
TT		 82632019-06-19 Tom Tromey <tom@tromey.com>
8264
8265 * tui/tui-data.h (tui_init_content_element): Don't declare.
8266
6f6ffbeb
TT		 82672019-06-19 Tom Tromey <tom@tromey.com>
8268
8269 * tui/tui-data.h (tui_init_win_info): Don't declare.
8270
f23f598e
TV		 82712019-06-19 Tom de Vries <tdevries@suse.de>
8272
8273 * dwarf2read.h (abstract_to_concrete): Change type to
8274 std::unordered_map<sect_offset, std::vector<sect_offset>,
8275 gdb::hash_enum<sect_offset>>.
8276
680e1bee
TT		 82772019-06-19 Tom Tromey <tromey@adacore.com>
8278
8279 * ada-lang.c (ada_evaluate_subexp) <case OP_ATR_FIRST>: Handle
8280 EVAL_AVOID_SIDE_EFFECTS specially.
8281
dcf37923
TT		 82822019-06-19 Tom Tromey <tromey@adacore.com>
8283
8284 * source-cache.c (highlighter): New global.
8285 (source_cache::get_source_lines): Create a highlighter on demand.
8286
494986d5
AB		 82872019-06-18 Andrew Burgess <andrew.burgess@embecosm.com>
8288
8289 * defs.h (deprecated_interactive_hook): Delete declaration.
8290 * interps.c (clear_interpreter_hooks): Remove use of
8291 deprecated_interactive_hook.
8292 * top.c (deprecated_interactive_hook): Delete definition.
8293 * utils.c (maybe_quit): Remove use of deprecated_interactive_hook.
8294
3360b6e7
TV		 82952019-06-18 Tom de Vries <tdevries@suse.de>
8296
8297 PR gdb/24515
8298 * dwarf2read.h (abstract_to_concrete): Change type from
8299 std::unordered_map<die_info_ptr, std::vector<die_info_ptr>> to
8300 std::unordered_map<sect_offset, std::vector<sect_offset>>.
8301 * dwarf2read.c (read_variable): Update.
8302 (dwarf2_fetch_die_loc_sect_off): Update.
8303
310b3441
TV		 83042019-06-17 Tom de Vries <tdevries@suse.de>
8305
8306 PR gdb/24617
8307 * common/pathstuff.c (child_path): Make sure parent_len > 0 before
8308 accessing parent[parent_len - 1].
8309
ba9777be
PP		 83102019-06-17 Paul Pluzhnikov <ppluzhnikov@google.com>
8311
8312 PR gdb/24364
8313 * gdb/dtrace-probe.c (dtrace_static_probe_ops::get_probe): Don't
8314 call dtrace_process_dof with NULL dof.
8315
2b9f6e89
TV		 83162019-06-16 Tom de Vries <tdevries@suse.de>
8317
8318 PR gdb/24445
8319 * contrib/gdb-add-index.sh: Update to handle dwz-m-ed executable.
8320
431b3ead
TT		 83212019-06-16 Tom Tromey <tom@tromey.com>
8322
8323 * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
8324 (make_all_visible): Use address of member.
8325
d04b44a1
TT		 83262019-06-16 Tom Tromey <tom@tromey.com>
8327
8328 * tui/tui-data.c (tui_clear_win_detail, init_win_info)
8329 (tui_free_window, free_content, free_content_elements): Remove
8330 unnecessary cast.
8331 * tui/tui-windata.c (tui_display_all_data): Remove unnecessary
8332 cast.
8333 * tui/tui-regs.c (tui_show_register_group)
8334 (tui_display_registers_from, tui_display_reg_element_at_line):
8335 Remove unnecessary cast.
8336
bf5142e7
AB		 83372019-06-16 Andrew Burgess <andrew.burgess@embecosm.com>
8338
8339 * linux-nat.c (normal_mask): Delete.
8340 (_initialize_linux_nat): Don't initialise normal_mask.
8341
c4973306
SM		 83422019-06-16 Simon Marchi <simon.marchi@polymtl.ca>
8343
8344 PR gdb/24445
8345 * dwarf-index-write.h (write_psymtabs_to_index): Add
8346 dwz_basename parameter.
8347 * dwarf-index-write.c (write_gdbindex): Move file writing to
8348 write_gdbindex_1. Change return type void.
8349 (assert_file_size): Move up, remove filename parameter.
8350 (write_gdbindex_1): New function.
8351 (write_debug_names): Change return type to void, call
8352 assert_file_size.
8353 (struct index_wip_file): New struct.
8354 (write_psymtabs_to_index): Add dwz_basename parameter. Move
8355 file logic to index_wip_file. Write index for dwz file if
8356 needed.
8357 (save_gdb_index_command): Pass basename of dwz file, if present.
8358 * dwarf-index-cache.c (index_cache::store): Obtain and pass
8359 build-id of dwz file, if present.
8360 * dwarf2read.c (struct dwz_file): Move to dwarf2read.h.
8361 (dwarf2_get_dwz_file): Likewise.
8362 * dwarf2read.h (struct dwz_file): Move from dwarf2read.c.
8363 (dwarf2_get_dwz_file): Likewise.
8364
395f9c91
TT		 83652019-06-16 Tom Tromey <tom@tromey.com>
8366
8367 * coffread.c (process_coff_symbol): Use xstrdup.
8368 * value.c (create_internalvar): Use xstrdup.
8369
cafb3438
TT		 83702019-06-16 Tom Tromey <tom@tromey.com>
8371
8372 * valops.c (value_cast, value_slice): Remove unnecessary cast.
8373 * breakpoint.c (stopin_command, stopat_command)
8374 (until_break_command, decode_location_default): Remove unnecessary
8375 cast.
8376 * utils.c (subset_compare): Remove unnecessary cast.
8377 * ada-lang.c (ada_update_initial_language): Remove unnecessary
8378 cast.
8379 * linespec.c (decode_line_with_last_displayed): Remove unnecessary
8380 cast.
8381 * infcmd.c (path_command): Remove unnecessary cast.
8382 * coffread.c (decode_type): Remove unnecessary cast.
8383 * xcoffread.c (read_xcoff_symtab): Remove unnecessary cast.
8384 * mipsread.c (mipscoff_symfile_read): Remove unnecessary cast.
8385 * tui/tui-stack.c (tui_show_locator_content)
8386 (tui_show_frame_info): Remove unnecessary cast.
8387 * tui/tui-win.c (tui_scroll_forward_command)
8388 (tui_scroll_backward_command, tui_set_focus, tui_set_win_height)
8389 (parse_scrolling_args): Remove unnecessary cast.
8390 * tui/tui-data.c (init_win_info, tui_del_window)
8391 (tui_free_window, tui_del_data_windows, tui_free_data_content)
8392 (free_content_elements): Remove unnecessary cast.
8393 * tui/tui-windata.c (tui_first_data_item_displayed): Remove
8394 unnecessary cast.
8395 * tui/tui-source.c (tui_set_source_content)
8396 (tui_vertical_source_scroll): Remove unnecessary cast.
8397 * tui/tui-layout.c (tui_default_win_height): Remove unnecessary
8398 cast.
8399 * tui/tui-io.c (tui_initialize_io): Remove unnecessary cast.
8400 * tui/tui-regs.c (tui_display_registers_from)
8401 (tui_display_register): Remove unnecessary cast.
8402 * tui/tui-wingeneral.c (tui_refresh_win, tui_delete_win)
8403 (tui_unhighlight_win, tui_highlight_win, tui_make_window)
8404 (make_visible): Remove unnecessary cast.
8405 * tui/tui-winsource.c (tui_erase_source_content)
8406 (tui_update_breakpoint_info, tui_set_exec_info_content): Remove
8407 unnecessary cast.
8408 * ax-gdb.c (agent_command_1): Remove unnecessary cast.
8409 * cli/cli-setshow.c (cmd_show_list): Remove unnecessary cast.
8410 * stabsread.c (read_type, read_array_type, read_range_type):
8411 Remove unnecessary cast.
8412 * mdebugread.c (mdebug_build_psymtabs): Remove unnecessary cast.
8413 (parse_symbol, parse_type, upgrade_type, parse_external)
8414 (parse_partial_symbols, psymtab_to_symtab_1, cross_ref): Remove
8415 unnecessary cast.
8416 * gdb_bfd.c (gdb_bfd_map_section): Remove unnecessary cast.
8417
730ead81
TT		 84182019-06-16 Tom Tromey <tom@tromey.com>
8419
8420 * tui/tui-data.c (tui_alloc_generic_win_info)
8421 (tui_alloc_win_info, tui_add_content_elements): Remove NULL
8422 checks.
8423
584a927c
AB		 84242019-06-16 Bernhard Heckel <bernhard.heckel@intel.com>
8425 Andrew Burgess <andrew.burgess@embecosm.com>
8426
8427 * f-typeprint.c (f_print_type): Don't return early for not
8428 associated or not allocated types.
8429 (f_type_print_varspec_suffix): Add print_rank parameter and print
8430 ranks of array types in case they dangling.
8431 (f_type_print_base): Add print_rank parameter.
8432
30056ea0
AB		 84332019-06-15 Andrew Burgess <andrew.burgess@embecosm.com>
8434
8435 * NEWS: Mention new MI commands.
8436 * break-catch-throw.c (enum exception_event_kind): Move to
8437 breakpoint.h.
8438 (print_mention_exception_catchpoint): Output text as a single
8439 message.
8440 (catch_exception_command_1): Rename to...
8441 (catch_exception_event): ...this, make non-static, update header
8442 command, and change some parameter types.
8443 (catch_catch_command): Update for changes to
8444 catch_exception_command_1.
8445 (catch_throw_command): Likewise.
8446 (catch_rethrow_command): Likewise.
8447 * breakpoint.c (enum exception_event_kind): Delete.
8448 * breakpoint.h (enum exception_event_kind): Moved here from
8449 break-catch-throw.c.
8450 (catch_exception_event): Declare.
8451 * mi/mi-cmd-catch.c (mi_cmd_catch_exception_event): New function.
8452 (mi_cmd_catch_throw): New function.
8453 (mi_cmd_catch_rethrow): New function.
8454 (mi_cmd_catch_catch): New function.
8455 * mi/mi-cmds.c (mi_cmds): Add 'catch-throw', 'catch-rethrow', and
8456 'catch-catch' entries.
8457 * mi/mi-cmds.h (mi_cmd_catch_throw): Declare.
8458 (mi_cmd_catch_rethrow): Declare.
8459 (mi_cmd_catch_catch): Declare.
8460
ec8e2b6d
AB		 84612019-06-15 Andrew Burgess <andrew.burgess@embecosm.com>
8462
8463 * annotate.c (annotate_source_line): Change return type to void,
8464 update implementation to match.
8465 * annotate.h (annotate_source_line): Change return type to void,
8466 update header comment.
8467 * stack.c (print_frame_info): Don't change what frame information
8468 is printed based on whether annotations are on or not.
8469
0d3abd8c
AB		 84702019-06-15 Andrew Burgess <andrew.burgess@embecosm.com>
8471
8472 * annotate.c: Add 'source.h' and 'objfiles.h' includes.
8473 (annotate_source): Make static.
8474 (annotate_source_line): Moved from source.c and renamed from
8475 identify_source_line. Update the return type.
8476 * annotate.h (annotate_source): Delete declaration.
8477 (annotate_source_line): Declaration moved from source.h, and
8478 renamed from identify_source_line. Return type updated.
8479 * source.c (identify_source_line): Moved to annotate.c and renamed
8480 to annotate_source_line.
8481 (info_line_command): Remove check of annotation_level.
8482 * source.h (identify_source_line): Move declaration to annotate.h
8483 and rename to annotate_source_line.
8484 * stack.c: Add 'annotate.h' include.
8485 (print_frame_info): Remove check of annotation_level before
8486 calling annotate_source_line.
8487
00df30ae
AB		 84882019-06-15 Andrew Burgess <andrew.burgess@embecosm.com>
8489
8490 * source-cache.c (source_cache::get_plain_source_lines): Use
8491 open_source_file_with_line_charpos instead of just
8492 open_source_file, remove call to find_source_lines.
8493 (source_cache::get_source_lines): Likewise.
8494 * source.c (find_source_lines): Make static.
8495 (get_filename_and_charpos): Renamed into...
8496 (open_source_file_with_line_charpos): ..this along with changes to
8497 return a scoped_fd, and some other minor clean ups.
8498 (identify_source_line): Use open_source_file_with_line_charpos.
8499 (search_command_helper): Use open_source_file_with_line_charpos
8500 instead of just open_source_file, remove call to
8501 find_source_lines.
8502 * source.h (open_source_file_with_line_charpos): Declare new
8503 function.
8504 (find_source_lines): Delete declaration.
8505
afda45a2
AB		 85062019-06-15 Andrew Burgess <andrew.burgess@embecosm.com>
8507
8508 * source.c (get_filename_and_charpos): Remove fullname
8509 parameter.
8510 (identify_source_line): Update call to get_filename_and_charpos.
8511
0735b091
TT		 85122019-06-14 Tom Tromey <tromey@adacore.com>
8513
8514 PR gdb/24502:
8515 * ui-style.h (skip_ansi_escape): Update comment.
8516 * ui-file.h (class no_terminal_escape_file): New class.
8517 * ui-file.c (no_terminal_escape_file::write)
8518 (no_terminal_escape_file::puts): New methods.
8519 * cli/cli-logging.c (handle_redirections): Use
8520 no_terminal_escape_file.
8521
52ce35e2
TT		 85222019-06-14 Tom Tromey <tromey@adacore.com>
8523
8524 * NEWS: Move convenience variable news above Python news.
8525
73cc7272
TT		 85262019-06-14 Tom Tromey <tom@tromey.com>
8527
8528 * gnulib: Move directory to top-level.
8529 * configure.ac: Don't configure gnulib.
8530 * configure: Rebuild.
8531 * common/common-defs.h: Use new path to gnulib.
8532 * Makefile.in (GNULIB_BUILDDIR): Now ../gnulib.
8533 (GNULIB_H): Remove.
8534 (INCGNU): Look in new gnulib location.
8535 (HFILES_NO_SRCDIR): Remove gnulib files.
8536 (SUBDIR, REQUIRED_SUBDIRS): Remove gnulib.
8537 (generated_files): Remove GNULIB_H.
8538 ($(LIBGNU), all-lib): Remove targets.
8539 (distclean): Don't mention GNULIB_BUILDDIR.
8540 ($(GNULIB_BUILDDIR)/Makefile): Remove target.
8541
f5686554
TT		 85422019-06-14 Tom Tromey <tromey@adacore.com>
8543
8544 * symfile.c (add_symbol_file_command): Remove obsolete comment.
8545 Warn if symbol file does not provide any symbols.
8546
a0c1ffed
TT		 85472019-06-14 Tom Tromey <tromey@adacore.com>
8548
8549 * source.c (find_and_open_source): Respect basenames_may_differ.
8550
7c39e397
AB		 85512019-06-14 Andrew Burgess <andrew.burgess@embecosm.com>
8552
8553 * annotate.c (annotate_breakpoints_invalid): Make use of
8554 scoped_restore_terminal_state.
8555 (annotate_frames_invalid): Likewise.
8556
f411722c
TT		 85572019-06-14 Tom Tromey <tromey@adacore.com>
8558
8559 * ada-lang.c (ada_evaluate_subexp) <case BINOP_ASSIGN>: Always
8560 allow assignment to an internalvar.
8561
4268ec18
TT		 85622019-06-14 Tom Tromey <tromey@adacore.com>
8563
8564 * ada-lex.l: Allow "_" in attribute names.
8565
abdb711e
TT		 85662019-06-14 Tom Tromey <tromey@adacore.com>
8567
8568 PR gdb/24653:
8569 * regcache.c (registers_changed): Don't call alloca.
8570 * top.c (execute_command): Don't call alloca.
8571
4c048731
PA		 85722019-06-13 Pedro Alves <palves@redhat.com>
8573
8574 * cli/cli-setshow.c (cli/cli-setshow.c): New parameter
8575 'expression'. When parsing an expression, error out if there's
8576 junk after "unlimited".
8577 (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
8578 (do_set_command): Adjust calls to is_unlimited_literal.
8579
66eb1ed3
PA		 85802019-06-13 Pedro Alves <palves@redhat.com>
8581
8582 * compile/compile.c (make_compile_options_def_group): Add braces
8583 around array_view initializer.
8584 * thread.c (make_thread_apply_all_options_def_group)
8585 (make_thread_apply_all_options_def_group): Likewise.
8586
3345721a
PA		 85872019-06-13 Pedro Alves <palves@redhat.com>
8588
8589 * NEWS (New commands): Mention "maint test-options
8590 require-delimiter", "maint test-options unknown-is-error", "maint
8591 test-options unknown-is-operand" and "maint show
8592 test-options-completion-result".
8593 (New command options, command completion): New section.
8594 (Completion improvements): New section.
8595 Mention that you can abbreviate "unlimited".
8596
6206060d
PA		 85972019-06-13 Pedro Alves <palves@redhat.com>
8598
8599 * cli/cli-utils.c (parse_flags, parse_flags_qcs): Delete.
8600 * cli/cli-utils.h (parse_flags, parse_flags_qcs): Delete.
8601 * unittests/cli-utils-selftests.c (test_parse_flags)
8602 (test_parse_flags_qcs): Delete.
8603 (test_cli_utils): Don't call deleted functions.
8604
6665660a
PA		 86052019-06-13 Pedro Alves <palves@redhat.com>
8606
8607 * thread.c: Include "cli/cli-option.h".
8608 (tp_array_compar_ascending): Global.
8609 (tp_array_compar): Delete function.
8610 (tp_array_compar_ascending, tp_array_compar_descending): New
8611 functions.
8612 (ascending_option_def, qcs_flag_option_def)
8613 (thr_qcs_flags_option_defs)
8614 (make_thread_apply_all_options_def_group)
8615 (make_thread_apply_options_def_group): New.
8616 (thread_apply_all_command): Use gdb::option::process_options.
8617 (thread_apply_command_completer)
8618 (thread_apply_all_command_completer): New.
8619 (thread_apply_command): Use gdb::option::process_options.
8620 (_initialize_thread): Delete THREAD_APPLY_FLAGS_HELP, replace it
8621 with a new THREAD_APPLY_OPTION_HELP. Use gdb::option::build_help
8622 to generate help text of "thread apply". Adjust "taas"'s help.
8623 * tid-parse.c (tid_range_parser::in_thread_range): New method.
8624 * tid-parse.h (tid_range_parser::in_thread_range): New method.
8625
f7e13587
PA		 86262019-06-13 Pedro Alves <palves@redhat.com>
8627
8628 * thread.c (thread_apply_command): Check for invalid TID with
8629 isdigit instead of !isalpha.
8630
5d707134
PA		 86312019-06-13 Pedro Alves <palves@redhat.com>
8632
8633 * cli/cli-utils.c (parse_flags_qcs): Use validate_flags_qcs.
8634 (validate_flags_qcs): New.
8635 * cli/cli-utils.h (struct qcs_flags): Change field types to int.
8636 (validate_flags_qcs): Declare.
8637 * stack.c (qcs_flag_option_def, fr_qcs_flags_option_defs): New.
8638 (make_frame_apply_options_def_group): New.
8639 (frame_apply_command_count): Process options with
8640 gdb::option::process_options.
8641 (frame_apply_completer): New.
8642 (frame_apply_level_completer, frame_apply_all_completer)
8643 (frame_apply_completer): New.
8644 (_initialize_stack): Update help of "frame apply", "frame apply
8645 level", "frame apply all" and "faas" to mention supported options
8646 and install command completers.
8647 * stack.h (frame_apply_all_completer): Declare.
8648 * thread.c: Include "stack.h".
8649 (tfaas_command): Add "--".
8650 (_initialize_thread): Update help "tfaas" to mention supported
8651 options and install command completer.
8652
272d4594
PA		 86532019-06-13 Pedro Alves <palves@redhat.com>
8654
8655 * completer.c (complete_nested_command_line): New.
8656 (gdb_completion_word_break_characters_throw): Add assertion.
8657 * completer.h (complete_nested_command_line): Declare.
8658
90a1ef87
PA		 86592019-06-13 Pedro Alves <palves@redhat.com>
8660
8661 * stack.c (parse_backtrace_qualifiers): New.
8662 (backtrace_command): Use it.
8663 (backtrace_command_completer): Complete on qualifiers.
8664
d4c16835
PA		 86652019-06-13 Pedro Alves <palves@redhat.com>
8666
8667 * frame.c: Include "cli/cli-option.h.
8668 (user_set_backtrace_options): New.
8669 (backtrace_past_main, backtrace_past_entry, backtrace_limit):
8670 Delete.
8671 (get_prev_frame): Adjust.
8672 (boolean_option_def, uinteger_option_def)
8673 (set_backtrace_option_defs): New.
8674 (_initialize_frame): Adjust and use
8675 gdb::option::add_setshow_cmds_for_options to install "set
8676 backtrace past-main" and "set backtrace past-entry".
8677 * frame.h: Include "cli/cli-option.h".
8678 (struct frame_print_options): Forward declare.
8679 (print_frame_arguments_all, print_frame_arguments_scalars)
8680 (print_frame_arguments_none): Declare.
8681 (print_entry_values): Delete declaration.
8682 (struct frame_print_options, user_frame_print_options): New.
8683 (struct set_backtrace_options): New.
8684 (set_backtrace_option_defs, user_set_backtrace_options): Declare.
8685 * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
8686 (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
8687 (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
8688 (list_args_or_locals): Add frame_print_options parameter.
8689 (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
8690 * python/py-framefilter.c (enumerate_args): Pass down
8691 USER_FRAME_PRINT_OPTIONS.
8692 * stack.c: Include "cli/cli-option.h".
8693 (print_frame_arguments_all, print_frame_arguments_scalars)
8694 (print_frame_arguments_none): Declare.
8695 (print_raw_frame_arguments, print_entry_values): Delete.
8696 (user_frame_print_options): New.
8697 (boolean_option_def, enum_option_def, frame_print_option_defs):
8698 New.
8699 (struct backtrace_cmd_options): New.
8700 (bt_flag_option_def): New.
8701 (backtrace_command_option_defs): New.
8702 (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
8703 (print_frame_arg, read_frame_arg, print_frame_args)
8704 (print_frame_info, print_frame): Add frame_print_options parameter
8705 and use it.
8706 (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
8707 (backtrace_command_1): Add frame_print_options and
8708 backtrace_cmd_options parameters and use them.
8709 (make_backtrace_options_def_group): New.
8710 (backtrace_command): Process command options with
8711 gdb::option::process_options.
8712 (backtrace_command_completer): New.
8713 (_initialize_stack): Extend "backtrace"'s help to mention
8714 supported options. Install completer for "backtrace".
8715 Install some settings commands with add_setshow_cmds_for_options.
8716
2daf894e
PA		 87172019-06-13 Pedro Alves <palves@redhat.com>
8718
8719 * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
8720 and that "set/show print raw frame-arguments" are now deprecated.
8721
8722 * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
8723 command.
8724 * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
8725 * stack.c (_initialize_stack): Install "set/show print
8726 raw-frame-arguments", and deprecate "set/show print raw
8727 frame-arguments".
8728 * valprint.c (_initialize_valprint): Deprecate "set/show print
8729 raw".
8730
e6ed716c
PA		 87312019-06-13 Pedro Alves <palves@redhat.com>
8732
8733 * compile/compile.c (struct compile_options): New.
8734 (compile_flag_option_def, compile_command_option_defs)
8735 (make_compile_options_def_group): New.
8736 (compile_file_command): Handle options with
8737 gdb::option::process_options.
8738 (compile_file_command_completer): New function.
8739 (compile_code_command): Handle options with
8740 gdb::option::process_options.
8741 (compile_code_command_completer): New function.
8742 (_initialize_compiler): Install completers for "compile code" and
8743 "compile file". Mention available options in "compile code" and
8744 "compile code"'s help.
8745 * completer.c (advance_to_completion_word): New, factored out from
8746 ...
8747 (advance_to_expression_complete_word_point): ... this.
8748 (advance_to_filename_complete_word_point): New.
8749 * completer.h (advance_to_filename_complete_word_point): New
8750 declaration.
8751
7d8062de
PA		 87522019-06-13 Pedro Alves <palves@redhat.com>
8753
8754 * compile/compile.c: Include "cli/cli-option.h".
8755 (compile_print_value): Scope data pointer is now a
8756 value_print_options pointer; adjust.
8757 (compile_print_command): Process options. Scope data pointer is
8758 now a value_print_options pointer; adjust.
8759 (_initialize_compile): Update "compile print"'s help to include
8760 supported options. Install a completer for "compile print".
8761 * cp-valprint.c (show_vtblprint, show_objectprint)
8762 (show_static_field_print): Delete.
8763 (_initialize_cp_valprint): Don't install "set print
8764 static-members", "set print vtbl", "set print object" here.
8765 * printcmd.c: Include "cli/cli-option.h" and
8766 "common/gdb_optional.h".
8767 (print_command_parse_format): Rework to fill in a
8768 value_print_options instead of a format_data.
8769 (print_value): Change parameter type from format_data pointer to
8770 value_print_options reference. Adjust.
8771 (print_command_1): Process options. Adjust to pass down a
8772 value_print_options.
8773 (print_command_completer): New.
8774 (_initialize_printcmd): Install print_command_completer as
8775 handle_brkchars completer for the "print" command. Update
8776 "print"'s help to include supported options.
8777 * valprint.c: Include "cli/cli-option.h".
8778 (show_vtblprint, show_objectprint, show_static_field_print): Moved
8779 here from cp-valprint.c.
8780 (boolean_option_def, uinteger_option_def)
8781 (value_print_option_defs, make_value_print_options_def_group):
8782 New. Use gdb::option::add_setshow_cmds_for_options to install
8783 "set print elements", "set print null-stop", "set print repeats",
8784 "set print pretty", "set print union", "set print array", "set
8785 print address", "set print symbol", "set print array-indexes".
8786 * valprint.h: Include <string> and "cli/cli-option.h".
8787 (make_value_print_options_def_group): Declare.
8788 (print_value): Change parameter type from format_data pointer to
8789 value_print_options reference.
8790 (print_command_completer): Declare.
8791
9d0faba9
PA		 87922019-06-13 Pedro Alves <palves@redhat.com>
8793
8794 * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
8795 (COMMON_SFILES): Add maint-test-settings.c.
8796 * cli/cli-decode.c (boolean_enums): New global, factored out from
8797 ...
8798 (add_setshow_boolean_cmd): ... here.
8799 * cli/cli-decode.h (boolean_enums): Declare.
8800 * cli/cli-option.c: New file.
8801 * cli/cli-option.h: New file.
8802 * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
8803 factored out from ...
8804 (parse_cli_boolean_value(const char *)): ... this.
8805 (is_unlimited_literal): Change parameter type to pointer to
8806 pointer. Adjust and advance ARG pointer.
8807 (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
8808 (parse_cli_var_enum): New, factored out from ...
8809 (do_set_command): ... this. Adjust.
8810 * cli/cli-setshow.h (parse_cli_boolean_value)
8811 (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
8812 (parse_cli_var_enum): Declare.
8813 * cli/cli-utils.c: Include "cli/cli-option.h".
8814 (get_ulongest): New.
8815 * cli/cli-utils.h (get_ulongest): Declare.
8816 (check_for_argument): New overloads.
8817 * maint-test-options.c: New file.
8818
2c722807
PA		 88192019-06-13 Pedro Alves <palves@redhat.com>
8820
8821 * cli/cli-utils.c (number_or_range_parser::get_number): Do not
8822 parse a range if "-" is at the end of the string.
8823
dee7b4c8
PA		 88242019-06-13 Pedro Alves <palves@redhat.com>
8825
8826 * cli/cli-setshow.c (parse_auto_binary_operation)
8827 (parse_cli_boolean_value): Don't allow "o".
8828
dca0f6c0
PA		 88292019-06-13 Pedro Alves <palves@redhat.com>
8830
8831 * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
8832 * NEWS: Mention maint test-settings KIND.
8833 * maint-test-settings.c: New file.
8834
597bf39d
PA		 88352019-06-13 Pedro Alves <palves@redhat.com>
8836
8837 * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
8838 completer.
8839 (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
8840 "set" completers.
8841
48c410fb
PA		 88422019-06-13 Pedro Alves <palves@redhat.com>
8843
8844 * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
8845 after item.
8846
93bcb043
PA		 88472019-06-13 Pedro Alves <palves@redhat.com>
8848
8849 * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
8850
cbba3ecd
PA		 88512019-06-13 Pedro Alves <palves@redhat.com>
8852
8853 * ax-gdb.c (agent_command_1): Remove skip_spaces call.
8854 * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
8855 call.
8856 * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
8857 * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
8858 calls.
8859 (check_for_argument): Skip spaces after argument.
8860
b9a3f842
PA		 88612019-06-13 Pedro Alves <palves@redhat.com>
8862
8863 * thread.c (thread_apply_command): Adjust TID parsing.
8864 * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
8865 detected before end of string.
8866 (tid_is_in_list): Error out if LIST is invalid.
8867
3844e605
PA		 88682019-06-13 Pedro Alves <palves@redhat.com>
8869
8870 * completer.c (complete_line_internal_1): Rewind completion word
8871 point.
8872 (completion_tracker::advance_custom_word_point_by): Change
8873 parameter type to int.
8874 * completer.h (completion_tracker::advance_custom_word_point_by):
8875 Likewise.
8876
00b56dbe
PA		 88772019-06-13 Pedro Alves <palves@redhat.com>
8878
8879 * completer.c (advance_to_completion_word): Handle delimiters.
8880
d106773e
PA		 88812019-06-11 Bernhard Heckel <bernhard.heckel@intel.com>
8882
8883 * dwarf2read.c (add_partial_symbol): Skip nameless modules.
8884
08f10e02
TT		 88852019-06-11 Tom Tromey <tom@tromey.com>
8886
8887 * common/common-utils.c (xmalloc, xrealloc, xcalloc)
8888 (xmalloc_failed): Move to alloc.c.
8889 * alloc.c: New file.
8890 * Makefile.in (COMMON_SFILES): Add alloc.c.
8891
1c7fe951
TT		 88922019-06-11 Tom Tromey <tom@tromey.com>
8893
8894 * nat/linux-waitpid.c: Don't include server.h.
8895 (linux_debug): Remove.
8896 (my_waitpid): Update.
8897
89549d7f
TT		 88982019-06-11 Tom Tromey <tromey@adacore.com>
8899
8900 * infcall.c (_initialize_infcall): Remove trailing newline from
8901 help.
8902 * user-regs.c (_initialize_user_regs): Remove trailing newline
8903 from help.
8904 * typeprint.c (_initialize_typeprint): Remove trailing newline
8905 from help.
8906 * reverse.c (_initialize_reverse): Remove trailing newlines from
8907 help.
8908 * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
8909 from help.
8910 * language.c (add_set_language_command): Remove trailing newline
8911 from help.
8912 * infcmd.c (_initialize_infcmd): Remove trailing newlines from
8913 help.
8914 * disasm.c (_initialize_disasm): Remove trailing newline from
8915 help.
8916 * top.c (init_main): Remove trailing newline from help.
8917 * interps.c (_initialize_interpreter): Remove trailing newline
8918 from help.
8919 * btrace.c (_initialize_btrace): Remove trailing newlines from
8920 help.
8921 * breakpoint.c (_initialize_breakpoint): Remove trailing newline
8922 from help.
8923 * python/python.c (_initialize_python): Remove trailing newline
8924 from help.
8925 * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
8926 help.
8927 * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
8928 from help. Reformat some text.
8929 * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
8930 from help.
8931 * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
8932 newline from help.
8933
86108c13
TT		 89342019-06-11 Tom Tromey <tromey@adacore.com>
8935
8936 * darwin-nat.c (darwin_decode_exception_message)
8937 (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
8938
a7067863
AB		 89392019-06-10 Andrew Burgess <andrew.burgess@embecosm.com>
8940
8941 * valops.c (value_slice): Check for not allocated or not
8942 associated values.
8943
9ab08412
TV		 89442019-06-10 Tom de Vries <tdevries@suse.de>
8945
8946 PR gdb/24618
8947 * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
8948 sure an empty slot (defined by a 32-bit zero pair) is recognized as
8949 invalid.
8950
f19e22e9
TV		 89512019-06-10 Tom de Vries <tdevries@suse.de>
8952
8953 PR gdb/24611
8954 * linespec.c (linespec_lexer_lex_string): Remove incorrect
8955 "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon. Add assert.
8956
e99f9db0
TV		 89572019-06-10 Tom de Vries <tdevries@suse.de>
8958
8959 PR symtab/24545
8960 * symtab.c (struct demangled_name_entry): Add language field.
8961 (symbol_set_names): Revert "[gdb/symtab] Fix language of duplicate
8962 static minimal symbol". Set and use language field.
8963
9bf7038b
TT		 89642019-06-10 Tom Tromey <tromey@adacore.com>
8965
8966 * ada-lang.c (_initialize_ada_language): Update help text.
8967
422186a9
TT		 89682019-06-10 Tom Tromey <tromey@adacore.com>
8969
8970 * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
8971 with a newline.
8972 * guile/guile.c (handle_boot_error): Don't end warning with a
8973 newline.
8974 * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
8975 warning with a newline.
8976 * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
8977 newline.
8978 (s12z_frame_cache): Likewise.
8979 * dwarf-index-cache.c (index_cache::store): Don't end warning with
8980 a newline.
8981 * solib-svr4.c (disable_probes_interface): Don't end warning with
8982 a newline.
8983 * nat/fork-inferior.c (fork_inferior): Don't end warning with a
8984 newline.
8985 * python/python.c (do_finish_initialization): Don't end warning
8986 with a newline.
8987
25ce02ee
TT		 89882019-06-10 Tom Tromey <tom@tromey.com>
8989
8990 * python/py-breakpoint.c (gdbpy_breakpoint_created)
8991 (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
8992 gdbpy_enter.
8993
caa429d8
TT		 89942019-06-10 Tom Tromey <tromey@adacore.com>
8995
8996 * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
8997 data.
8998 (elf_new_init): Don't call stabsread_new_init.
8999 * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
9000 (elfstab_build_psymtabs): Likewise. Call stabsread_new_init.
9001 * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
9002
81873cc8
TV		 90032019-06-10 Tom de Vries <tdevries@suse.de>
9004
9005 PR symtab/16264
9006 PR symtab/24517
9007 * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
9008
4fa0265e
РИ		 90092019-06-06 Руслан Ижбулатов <lrn1986@gmail.com>
9010
9011 * source.c (find_and_open_source): Also rewrite relative file
9012 names.
9013
1a3da2cd
AB		 90142019-04-26 Amos Bird <amosbird@gmail.com>
9015
9016 * annotate.c (annotate_thread_exited): Add "thread-exited"
9017 annotation.
9018
3847a7bf
TT		 90192019-06-06 Tom Tromey <tromey@adacore.com>
9020
9021 * maint.h (class scoped_command_stats): Use
9022 DISABLE_COPY_AND_ASSIGN.
9023 <print_time>: New method.
9024 * maint.c (scoped_command_stats, ~scoped_command_stats): Call
9025 print_time.
9026 (scoped_command_stats::print_time): New method.
9027
312617a3
AB		 90282019-06-05 Andrew Burgess <andrew.burgess@embecosm.com>
9029
9030 * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
9031 instructions of lengths 6 or 8 bytes.
9032
b02f78f9
PA		 90332019-06-04 Pedro Alves <palves@redhat.com>
9034
9035 * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
9036
9037 * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
9038 * breakpoint.c (condition_completer): Likewise.
9039 * cli/cli-dump.c (scan_expression): Likewise.
9040 * common/filestuff.c (mkdir_recursive): Likewise.
9041 * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
9042 * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
9043 (gdb_abspath): Likewise.
9044 * compile/compile-cplus-types.c
9045 (compile_cplus_instance::decl_name): Likewise.
9046 * completer.c (complete_explicit_location):
9047 (signal_completer, reg_or_group_completer_1): Likewise.
9048 * cp-support.c (cp_remove_params_if_any): Likewise.
9049 * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
9050 * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
9051 * infcmd.c (strip_bg_char): Likewise.
9052 * linespec.c (copy_token_string): Likewise.
9053 * mi/mi-main.c (output_cores): Likewise.
9054 * psymtab.c (psymtab_search_name):
9055 * symfile.c (test_set_ext_lang_command): Likewise.
9056 * target.c (target_fileio_read_stralloc): Likewise.
9057 * tui/tui-regs.c (tui_reggroup_completer): Likewise.
9058 * value.c (complete_internalvar): Likewise.
9059
e1f2e1a2
CB		 90602019-06-04 Christian Biesinger <cbiesinger@google.com>
9061
9062 Add objfile property to gdb.Type.
d3238f7d
PA		 9063 * NEWS: Mention Python API addition.
9064 * python/py-type.c (typy_get_objfile): New method.
e1f2e1a2 9065
e664d728
PW		 90662019-06-03 Philippe Waroquiers <philippe.waroquiers@skynet.be>
9067
9068 * NEWS: Mention the new set|show style [title|highlight].
9069 Mention changes to "show style", "help" and "apropos".
9070
66d8c862
PW		 90712019-06-03 Philippe Waroquiers <philippe.waroquiers@skynet.be>
9072
9073 * cli/cli-decode.h (apropos_cmd): Add verbose argument.
9074 * cli/cli-decode.c (apropos_cmd): Likewise. Use print_doc_of_command
9075 instead of print_help_for_command.
9076 (print_doc_of_command): New function.
9077 (help_list): Add 'apropos -v word' suggestion.
9078 (print_help_for_command): Style the command name using title style.
9079 * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
9080 (_initialize_cli_cmds): Describe -v in apropos_command help.
9081
9303eb2f
PW		 90822019-06-03 Philippe Waroquiers <philippe.waroquiers@skynet.be>
9083
9084 * cli/cli-style.h (cli_style_option): Add name in constructor,
9085 add m_name class member, add constructor with intensity,
9086 add name class function.
9087 (cli_style_option::add_setshow_commands): Remove name argument.
9088 (highlight_style, title_style): New styles.
9089 * cli/cli-style.c (do_show): New function that shows a style
9090 characteristic styling the style name with itself.
9091 (set_style_name): New function.
9092 (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
9093 Update all callers according to the changes in cli/cli-style.h.
9094 * utils.h (fputs_highlighted): New function.
9095 * utils.c (fputs_highlighted): Likewise.
9096
e2c52041
PW		 90972019-05-31 Philippe Waroquiers <philippe.waroquiers@skynet.be>
9098
9099 * NEWS: Mention new pipe command and new convenience variables.
9100
947d3946
PW		 91012019-05-31 Philippe Waroquiers <philippe.waroquiers@skynet.be>
9102
9103 * cli/cli-cmds.c (pipe_command): New function.
9104 (_initialize_cli_cmds): Call add_com for pipe_command.
9105 Define | as an alias for pipe.
9106 (exit_status_set_internal_vars): New function.
9107 (shell_escape): Call exit_status_set_internal_vars.
9108 cli/cli-decode.c (find_command_name_length): Recognize | as
9109 a single character command.
9110
b8fd0918
PW		 91112019-05-31 Philippe Waroquiers <philippe.waroquiers@skynet.be>
9112
9113 * gdbcmd.h (execute_command_to_ui_file): New declaration.
9114 top.c (execute_command_to_ui_file): New function, mostly a copy
9115 of execute_command_to_string.
9116 (execute_command_to_string): Implement by calling
9117 execute_command_to_ui_file.
9118
68bb5386
PW		 91192019-05-31 Philippe Waroquiers <philippe.waroquiers@skynet.be>
9120
9121 * top.h (saved_command_line): Remove declaration.
9122 * top.c (previous_saved_command_line, previous_repeat_arguments):
9123 New variables.
9124 (saved_command_line): Make static, define together with other
9125 'repeat variables'.
9126 (dont_repeat): Clear repeat_arguments.
9127 (repeat_previous, get_saved_command_line, save_command_line):
9128 New functions.
9129 (gdb_init): Initialize saved_command_line
9130 and previous_saved_command_line.
9131 * main.c (captured_main_1): Remove saved_command_line initialization.
9132 * event-top.c (handle_line_of_input): Update to use
9133 the new 'repeat' related functions instead of direct access to
9134 saved_command_line.
9135 * command.h (repeat_previous, get_saved_command_line,
9136 save_command_line): New declarations.
9137 (dont_repeat): Add comment.
9138
bfcdb852
TT		 91392019-05-30 Tom Tromey <tromey@adacore.com>
9140
9141 * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
9142 Fix comment.
9143 (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
9144
0ef209f2
JV		 91452019-05-30 Jan Vrany <jan.vrany@fit.cvut.cz>
9146
9147 PR cli/24587
9148 * completer.c (complete): Initialize variable word.
9149
955b06fa
SDJ		 91502019-05-29 Sergio Durigan Junior <sergiodj@redhat.com>
9151
9152 Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
9153 Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
9154 * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
9155 'body' is NULL to the outter 'if', protecting the '!is_define'
9156 situation as well.
9157
fa9c3fa0
TT		 91582019-05-29 Tom Tromey <tromey@adacore.com>
9159
9160 * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
9161 (dwarf_unknown): New function.
9162 (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
9163 (dwarf_type_encoding_name): Use dwarf_unknown.
9164
4330d61d
TT		 91652019-05-29 Tom Tromey <tromey@adacore.com>
9166
9167 PR c++/20020:
9168 * cp-valprint.c (cp_print_value_fields): Call
9169 cp_print_static_field inside "try".
9170
33a6bc35
TT		 91712019-05-29 Tom Tromey <tromey@adacore.com>
9172
9173 * inflow.c (struct terminal_info): Add default operator=.
9174 * configure: Rebuild.
9175 * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
9176 -Wdeprecated-copy-dtor, -Wredundant-move.
9177
000439d5
TT		 91782019-05-29 Tom Tromey <tromey@adacore.com>
9179
9180 * NEWS: Add entry.
9181 * infcmd.c (print_return_value_1): Handle finish_print
9182 option.
9183 (show_print_finish): New function.
9184 (_initialize_infcmd): Add "set/show print finish" commands.
9185 * valprint.c (user_print_options): Initialize new member.
9186 * valprint.h (struct value_print_options) <finish_print>: New
9187 member.
9188
c0e70c62
TT		 91892019-05-28 Tom Tromey <tromey@adacore.com>
9190
9191 * ada-lang.c (ada_remove_Xbn_suffix)
9192 (find_old_style_renaming_symbol)
9193 (parse_old_style_renaming): Remove.
9194 (ada_find_renaming_symbol): Don't call
9195 find_old_style_renaming_symbol.
9196 (ada_is_renaming_symbol): Rename from
9197 ada_find_renaming_symbol. Remove "block" parameter. Return
9198 bool. Now static.
9199 (ada_read_var_value): Update and simplify.
9200 * ada-exp.y (write_var_or_type): Remove old code.
9201
766f8836
AH		 92022019-05-28 Alan Hayward <alan.hayward@arm.com>
9203
68255adc 9204 PR gdb/25010
766f8836
AH		 9205 * event-top.c: Remove include comment.
9206 * inflow.c (class scoped_ignore_sigttou): Move from here...
9207 * inflow.h (class scoped_ignore_sigttou): ...to here.
9208 * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
9209 * top.c: Remove include comment.
9210
eb41253a
TT		 92112019-05-27 Tom Tromey <tom@tromey.com>
9212
9213 * NEWS: Fix typo.
9214
4ca51187
TT		 92152019-05-22 Tom Tromey <tromey@adacore.com>
9216
9217 * target.c (target_follow_exec): Constify parameter.
9218 * target-delegates.c: Rebuild.
9219 * remote.c (remote_target::follow_exec): Constify parameter.
9220 * infrun.c (follow_exec): Constify parameter.
9221 * target.h (struct target_ops) <follow_exec>: Constify parameter.
9222 (target_follow_exec): Likewise.
9223
8fca4da0
AH		 92242019-05-22 Alan Hayward <alan.hayward@arm.com>
9225
9226 * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
9227 DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
9228
b7060614
AH		 92292019-05-22 Alan Hayward <alan.hayward@arm.com>
9230
9231 * NEWS: Add debugredirect and testsuite sections.
9232
0a5954bd
SC		 92332019-05-22 Simon Cook <simon.cook@embecosm.com>
9234
9235 * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
9236 target descriptions using exclusively floating point register name
9237 aliases.
9238
dc42e902
AB		 92392019-05-21 Andrew Burgess <andrew.burgess@embecosm.com>
9240
9241 PR gdb/18644:
9242 * f-lang.c (build_fortran_types): Handle the case where
9243 gdbarch_floatformat_for_type returns a nullptr.
9244
fb7806c7
TV		 92452019-05-21 Tom de Vries <tdevries@suse.de>
9246
9247 PR cli/24587
9248 * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
9249
34d11c68
AB		 92502019-05-18 Andrew Burgess <andrew.burgess@embecosm.com>
9251
9252 PR gdb/18644:
9253 * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
9254 16-byte floats.
9255 * i386-tdep.c (i386_floatformat_for_type): Use
9256 floatformats_ia64_quad for the 16-byte floating point component
9257 within a fortran 32-byte complex number.
9258
122cf0f2
AB		 92592019-05-18 Andrew Burgess <andrew.burgess@embecosm.com>
9260
9261 * dwarf2read.c (struct cu_partial_die_info): Add constructor,
9262 delete default constructor.
9263 (find_partial_die): Update to return const struct.
9264 (partial_die_parent_scope): Move variable declaration into scope
9265 of its use and change its type to auto.
9266 (guess_partial_die_structure_name): Likewise.
9267 (partial_die_info::fixup): Likewise.
9268
33d0e35a
TT		 92692019-05-17 Tom Tromey <tromey@adacore.com>
9270
9271 * source.c (find_and_open_source): Remove cast.
9272
a45575b0
TT		 92732019-05-17 Tom Tromey <tromey@adacore.com>
9274
9275 * annotate.c (annotate_source): Make "filename" const.
9276 * annotate.h (annotate_source): Use const.
9277
81f47ac2
AH		 92782019-05-17 Alan Hayward <alan.hayward@arm.com>
9279
9280 * disasm.c (set_disassembler_options): Send errors to stderr.
9281
ca1285d1
AH		 92822019-05-17 Alan Hayward <alan.hayward@arm.com>
9283
9284 * cli/cli-interp.c (struct saved_output_files): Add saved entry.
9285 (cli_interp_base::set_logging): Check debug_redirect.
9286 * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
9287 * cli/cli-logging.c (debug_redirect): Add static variable.
9288 (pop_output_files): Add default param.
9289 (handle_redirections): Print debug setting.
9290 (show_logging_command): Likewise.
9291 (_initialize_cli_logging): Add debugredirect command.
9292 * interps.c (current_interp_set_logging): Add debug_redirect
9293 parameter.
9294 * interps.h (set_logging): Add debug_redirect parameter.
9295 (current_interp_set_logging): Likewise.
9296 * mi/mi-common.h: Likewise.
9297 * mi/mi-interp.c (mi_interp::set_logging): Likewise.
9298
92992019-05-17 Alan Hayward <alan.hayward@arm.com>
f3a09c80
AH		 9300 Tom Tromey <tromey@adacore.com>
9301
9302 * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
9303 directly.
9304 * cli/cli-interp.h (make_logging_output): Remove declaration.
9305 * cli/cli-logging.c (make_logging_output): Remove function.
9306 * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
9307 directly.
9308 * ui-file.c (tee_file::tee_file): Remove bools.
9309 (tee_file::~tee_file): Remove deletes.
9310 * ui-file.h (tee_file): Remove bools.
9311
26648588
JV		 93122019-01-28 Jan Vrany <jan.vrany@fit.cvut.cz>
9313
9314 * mi/mi-cmds.h (mi_cmd_complete): New function.
9315 * mi/mi-main.c (mi_cmd_complete): Likewise.
9316 * mi/mi-cmds.c: Define new MI command -complete.
9317 * NEWS: Mention new -complete command.
9318
6e035501
JV		 93192019-01-24 Jan Vrany <jan.vrany@fit.cvut.cz>
9320
9321 * completer.h (complete): New function.
9322 * completer.c (complete): Likewise.
9323 * cli/cli-cmds.c: (complete_command): Update to use new complete()
9324 function defined in completer.h.
9325
7d0e2ece
JV		 93262019-05-17 Jan Vrany <jan.vrany@fit.cvut.cz>
9327
e79be6e5 9328 * MAINTAINERS (Write After Approval): Add myself.
7d0e2ece 9329
fb816e8b
TV		 93302019-05-17 Tom de Vries <tdevries@suse.de>
9331
9332 PR gdb/24094
9333 * dwarf2read.c (struct cu_partial_die_info): New struct.
9334 (find_partial_die): Return cu_partial_die_info.
9335 (partial_die_parent_scope, guess_partial_die_structure_name)
9336 (partial_die_info::fixup): Handle new return type of find_partial_die.
9337
677052f2
SDJ		 93382019-05-16 Sergio Durigan Junior <sergiodj@redhat.com>
9339
a1726c38 9340 PR breakpoints/24541
677052f2
SDJ		 9341 * stap-probe.c (stap_parse_register_operand): Make "regname" an
9342 "std::string", simplifying the algorithm.
9343
f3da9116
SDJ		 93442019-05-16 Sergio Durigan Junior <sergiodj@redhat.com>
9345
9346 * stap-probe.c (handle_stap_probe): Fix complaint formatting.
9347 (stap_static_probe_ops::get_probes): Likewise.
9348
f1bb75ab
SDJ		 93492019-05-16 Sergio Durigan Junior <sergiodj@redhat.com>
9350
9351 * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
9352 '-')" and "else if".
9353 (stap_parse_single_operand): Join checks for
9354 "gdbarch_stap_parse_special_token_p" and
9355 "gdbarch_stap_parse_special_token" in the same "if" statement.
9356 Invert check when verifying for operation on register
9357 displacement.
9358
3ca58cde
SDJ		 93592019-05-16 Sergio Durigan Junior <sergiodj@redhat.com>
9360
9361 * stap-probe.c (stap_get_opcode): Update comment.
9362 (stap_get_expected_argument_type): Likewise.
9363 (handle_stap_probe): Likewise.
9364
af2d9bee
SDJ		 93652019-05-16 Sergio Durigan Junior <sergiodj@redhat.com>
9366
9367 * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
9368 return type to 'bool'. Adjust comment. Use 'bool' when
9369 appropriate.
9370 (i386_stap_parse_special_token_three_arg_disp): Likewise.
9371 * stap-probe.c (stap_parse_argument_1): Likewise.
9372 (stap_is_operator): Likewise.
9373 (stap_is_generic_prefix): Likewise.
9374 (stap_is_register_prefix): Likewise.
9375 (stap_is_register_indirection_prefix): Likewise.
9376 (stap_is_integer_prefix): Likewise.
9377 (stap_generic_check_suffix): Likewise.
9378 (stap_check_integer_suffix): Likewise.
9379 (stap_check_register_suffix): Likewise.
9380 (stap_check_register_indirection_suffix): Likewise.
9381 (stap_parse_register_operand): Likewise.
9382 (stap_parse_single_operand): Likewise.
9383 (stap_parse_argument_1): Likewise.
9384 (stap_probe::get_argument_count): Likewise.
9385 (stap_is_operator): Likewise.
9386
61c9c421
TT		 93872019-05-16 Tom Tromey <tromey@adacore.com>
9388
9389 * darwin-nat.c (thread_info_from_private_thread_info): Add struct
9390 keyword to foreach.
9391
9ddc1af1
SM		 93922019-05-15 Simon Marchi <simon.marchi@efficios.com>
9393
9394 * linux-thread-db.c (try_thread_db_load_1): Change return type
9395 to bool.
9396 (try_thread_db_load): Likewise.
9397 (try_thread_db_load_from_pdir_1): Likewise.
9398 (try_thread_db_load_from_pdir): Likewise.
9399 (try_thread_db_load_from_sdir): Likewise.
9400 (try_thread_db_load_from_dir): Likewise.
9401 (thread_db_load_search): Likewise.
9402 (has_libpthread): Likewise.
9403 (thread_db_load): Likewise.
9404
7bede828
SDJ		 94052019-05-15 Sergio Durigan Junior <sergiodj@redhat.com>
9406
9407 Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
9408 * dwarf2read.c (parse_macro_definition): Check whether 'body' is
9409 NULL, and complain/return if that's the case.
9410
c5358db4
JD		 94112019-05-15 John Darrington <john@darrington.wattle.id.au>
9412
9413 * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
9414 (advance, posn, abstract_read_memory): New functions.
9415 [struct mem_read_abstraction]: New struct.
9416 (s12z_frame_cache): Use opcodes API to interpret stack frame code.
9417
c408a94f
TT		 94182019-05-14 Tom Tromey <tromey@adacore.com>
9419
9420 * ada-lang.c (coerce_unspec_val_to_type): Only set address when
9421 value is not lval_memory.
9422
e7bd7fba
TT		 94232019-05-14 Tom Tromey <tromey@adacore.com>
9424
9425 * solib.c (info_sharedlibrary_command): Style the file name.
9426
a6d0f249
AH		 94272019-05-14 Alan Hayward <alan.hayward@arm.com>
9428
9429 * aarch64-tdep.c (aarch64_vnh_type): Add half view.
9430 (aarch64_vnv_type): Likewise.
9431 * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
9432 * common/tdesc.c: Likewise.
9433 * common/tdesc.h (enum tdesc_type_kind): Likewise.
9434 * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
9435 * features/aarch64-fpu.xml: Add ieee half view.
9436 * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
9437 * gdbtypes.c (gdbtypes_post_init): Add builtin_half
9438 * gdbtypes.h (struct builtin_type): Likewise.
9439 (struct objfile_type): Likewise.
9440
66b8bb74
SM		 94412019-05-12 Paul Naert <paul.naert@polymtl.ca>
9442
9443 * language.c (language_sniff_from_mangled_name): Fix "langauge"
9444 typo.
9445 * location.h (string_to_event_location): Likewise.
9446
21c219fd
JB		 94472019-05-11 Joel Brobecker <brobecker@adacore.com>
9448
9449 GDB 8.3 released.
9450
13674803
SM		 94512019-05-10 Simon Marchi <simon.marchi@efficios.com>
9452
9453 * breakpoint.h (fix_multi_location_breakpoint_output_globally):
9454 New variable declaration.
9455 * breakpoint.c (fix_multi_location_breakpoint_output_globally):
9456 New variable.
9457 (print_one_breakpoint): Use ui_out::test_flags and new global
9458 variable to compute use_fixed_output.
9459 * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
9460 Remove.
9461 * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
9462 (mi_multi_location_breakpoint_output_fixed): Remove.
9463 (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
9464 new variable.
9465 * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
9466 fix_multi_location_breakpoint_output flag if version >= 3.
9467 * ui-out.h (enum ui_out_flag)
9468 <fix_multi_location_breakpoint_output>: New enumerator.
9469
a9eac7f9
SM		 94702019-05-10 Simon Marchi <simon.marchi@efficios.com>
9471
9472 * contrib/cc-with-tweaks.sh: Validate dwz's work.
9473
71bed2db
TT		 94742019-05-10 Tom Tromey <tromey@adacore.com>
9475
9476 * ada-lang.c (catch_ada_completer): New function.
9477 (_initialize_ada_language): Use it.
9478
24c54127
TT		 94792019-05-10 Tom Tromey <tromey@adacore.com>
9480
9481 * thread.c (print_thread_info): Make "requested_threads" const.
9482 * gdbthread.h (print_thread_info): Make "requested_threads"
9483 const.
9484 * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
9485 * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
9486
7a102139
TT		 94872019-05-08 Tom Tromey <tom@tromey.com>
9488
9489 * gdbtypes.c (objfile_type_data): Change type.
9490 (objfile_type, _initialize_gdbtypes): Update.
9491
924d79e2
TT		 94922019-05-08 Tom Tromey <tom@tromey.com>
9493
9494 * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
9495 (dwarf2_frame_find_fde, dwarf2_build_frame_info)
9496 (_initialize_dwarf2_frame): Update.
9497
4c58e337
TT		 94982019-05-08 Tom Tromey <tom@tromey.com>
9499
9500 * objc-lang.c (objc_objfile_data): Change type.
9501 (find_methods): Update.
9502 (_initialize_objc_lang): Remove.
9503
d772d2ab
TT		 95042019-05-08 Tom Tromey <tom@tromey.com>
9505
9506 * stabsread.c (rs6000_builtin_type_data): Change type.
9507 (rs6000_builtin_type, _initialize_stabsread): Update.
9508
d11d83f4
TT		 95092019-05-08 Tom Tromey <tom@tromey.com>
9510
9511 * mips-tdep.c (mips_pdr_data): Remove.
9512 (_initialize_mips_tdep): Update.
9513
9a73f0ad
TT		 95142019-05-08 Tom Tromey <tom@tromey.com>
9515
9516 * hppa-tdep.c (hppa_objfile_priv_data): Change type.
9517 (hppa_init_objfile_priv_data, read_unwind_info)
9518 (find_unwind_entry, _initialize_hppa_tdep): Update.
9519
8127a2fa
TT		 95202019-05-08 Tom Tromey <tom@tromey.com>
9521
9522 * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
9523 (elf_gnu_ifunc_record_cache): Update. Don't allocate hash table
9524 on obstack.
9525 (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
9526
91d3055d
TT		 95272019-05-08 Tom Tromey <tom@tromey.com>
9528
9529 * mdebugread.c (basic_type_data): Change type.
9530 (basic_type, _initialize_mdebugread): Update.
9531
31930bd3
TT		 95322019-05-08 Tom Tromey <tom@tromey.com>
9533
9534 * common/gdb_unique_ptr.h (struct noop_deleter): New.
9535
bdb3ed9e
TT		 95362019-05-08 Tom Tromey <tom@tromey.com>
9537
9538 * nto-tdep.c (nto_inferior_data_reg): Change type.
9539 (nto_inferior_data): Update.
9540 (nto_inferior_data_cleanup, nto_new_inferior_data)
9541 (_initialize_nto_tdep): Remove.
9542 * nto-tdep.h (struct nto_inferior_data): Add initializers.
9543
f37b313d
TT		 95442019-05-08 Tom Tromey <tom@tromey.com>
9545
9546 * ada-lang.c (struct ada_inferior_data): Add initializers.
9547 (ada_inferior_data): Change type.
9548 (ada_inferior_data_cleanup): Remove.
9549 (get_ada_inferior_data, ada_inferior_exit)
9550 (struct ada_pspace_data): Add initializers, destructor.
9551 (ada_pspace_data_handle): Change type.
9552 (get_ada_pspace_data): Update.
9553 (ada_pspace_data_cleanup): Remove.
9554
24699405
TT		 95552019-05-08 Tom Tromey <tom@tromey.com>
9556
9557 * coffread.c (struct coff_symfile_info): Add initializers.
9558 (coff_objfile_data_key): Move lower. Change type.
9559 (coff_symfile_init, coff_symfile_read, _initialize_coffread):
9560 Update.
9561 (coff_free_info): Remove.
9562
d4e05d2f
TT		 95632019-05-08 Tom Tromey <tom@tromey.com>
9564
9565 * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
9566 (fbsd_pspace_data_handle): Move lower. Change type.
9567 (get_fbsd_pspace_data): Update.
9568 (fbsd_pspace_data_cleanup): Remove.
9569 (_initialize_fbsd_tdep): Update.
9570
14ef6690
TT		 95712019-05-08 Tom Tromey <tom@tromey.com>
9572
9573 * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
9574 (get_ada_tasks_pspace_data): Update.
9575 (ada_tasks_pspace_data_cleanup): Remove.
9576 (_initialize_tasks): Update.
9577 (ada_tasks_inferior_data_handle): Change type.
9578 (get_ada_tasks_inferior_data): Update.
9579 (ada_tasks_inferior_data_cleanup): Remove.
9580 (struct ada_tasks_pspace_data): Add initializers.
9581
814cf43a
TT		 95822019-05-08 Tom Tromey <tom@tromey.com>
9583
9584 * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
9585 * symfile-debug.c (debug_sym_get_probes): Change type.
9586 * stap-probe.c (handle_stap_probe):
9587 (stap_static_probe_ops::get_probes): Change type.
9588 * probe.h (class static_probe_ops) <get_probes>: Change type.
9589 * probe.c (class any_static_probe_ops) <get_probes>: Change type.
9590 (parse_probes_in_pspace): Update.
9591 (find_probes_in_objfile, find_probe_by_pc, collect_probes):
9592 Update.
9593 (any_static_probe_ops::get_probes): Change type.
9594 * elfread.c (elfread_data): New typedef.
9595 (probe_key): Change type.
9596 (elf_get_probes): Likewise. Update.
9597 (probe_key_free): Remove.
9598 (_initialize_elfread): Update.
9599 * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
9600 Change type.
9601 (dtrace_process_dof_probe, dtrace_process_dof)
9602 (dtrace_static_probe_ops::get_probe): Change type.
9603
02dc647e
TT		 96042019-05-08 Tom Tromey <tom@tromey.com>
9605
9606 * xcoffread.c (struct xcoff_symfile_info): Rename from
9607 coff_symfile_info. Add initializers.
9608 (xcoff_objfile_data_key): Move lower. Change type.
9609 (XCOFF_DATA): Rewrite.
9610 (xcoff_free_info): Remove.
9611 (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
9612 (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
9613 (xcoff_initial_scan): Update.
9614
09232438
TT		 96152019-05-08 Tom Tromey <tom@tromey.com>
9616
9617 * solib-svr4.c (struct svr4_info): Add initializers and
9618 destructor.
9619 <probes_table>: Now an htab_up.
9620 (solib_svr4_pspace_data): Change type.
9621 (free_probes_table): Simplify.
9622 (~svr4_info): Rename from svr4_pspace_data_cleanup.
9623 (get_svr4_info, probes_table_htab_remove_objfile_probes)
9624 (probes_table_remove_objfile_probes, register_solib_event_probe)
9625 (solib_event_probe_at, svr4_update_solib_event_breakpoint)
9626 (_initialize_svr4_solib): Update.
9627
7b4a314f
TT		 96282019-05-08 Tom Tromey <tom@tromey.com>
9629
9630 * remote.c (remote_pspace_data): Change type.
9631 (remote_pspace_data_cleanup): Remove.
9632 (get_remote_exec_file, set_pspace_remote_exec_file)
9633 (_initialize_remote): Update.
9634
51d3063a
TT		 96352019-05-08 Tom Tromey <tom@tromey.com>
9636
9637 * breakpoint.c (breakpoint_objfile_key): Change type.
9638 (get_breakpoint_objfile_data): Update.
9639 (free_breakpoint_objfile_data): Remove.
9640 (_initialize_breakpoint): Update.
9641
89fb8848
TT		 96422019-05-08 Tom Tromey <tom@tromey.com>
9643
9644 * linux-tdep.c (struct linux_info): Add initializers.
9645 (linux_inferior_data): Move. Change type.
9646 (invalidate_linux_cache_inf): Update.
9647 (linux_inferior_data_cleanup): Remove.
9648 (get_linux_inferior_data, _initialize_linux_tdep): Update.
9649
e9b89e2d
TT		 96502019-05-08 Tom Tromey <tom@tromey.com>
9651
9652 * auxv.c (auxv_inferior_data): Move. Change type.
9653 (auxv_inferior_data_cleanup): Remove.
9654 (invalidate_auxv_cache_inf): Rewrite.
9655 (get_auxv_inferior_data, _initialize_auxv): Update.
9656
8c42777c
TT		 96572019-05-08 Tom Tromey <tom@tromey.com>
9658
9659 * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
9660 (symfile_debug_objfile_data_key): Change type.
9661 (symfile_debug_installed, debug_qf_has_symbols)
9662 (debug_qf_find_last_source_symtab)
9663 (debug_qf_forget_cached_source_info)
9664 (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
9665 (debug_qf_print_stats, debug_qf_dump)
9666 (debug_qf_expand_symtabs_for_function)
9667 (debug_qf_expand_all_symtabs)
9668 (debug_qf_expand_symtabs_with_fullname)
9669 (debug_qf_map_matching_symbols)
9670 (debug_qf_expand_symtabs_matching)
9671 (debug_qf_find_pc_sect_compunit_symtab)
9672 (debug_qf_map_symbol_filenames)
9673 (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
9674 (debug_sym_new_init, debug_sym_init, debug_sym_read)
9675 (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
9676 (debug_sym_read_linetable, debug_sym_relocate): Update.
9677 (symfile_debug_free_objfile): Remove.
9678 (install_symfile_debug_logging, _initialize_symfile_debug):
9679 Update.
9680
5bfd760d
TT		 96812019-05-08 Tom Tromey <tom@tromey.com>
9682
9683 * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
9684 allocate_on_obstack.
9685 * dwarf2read.c (dwarf2_objfile_data_key): Change type.
9686 (get_dwarf2_per_objfile): Update.
9687 (set_dwarf2_per_objfile): Remove.
9688 (dwarf2_has_info, dwarf2_get_section_info): Update.
9689 (dwarf2_free_objfile): Remove.
9690 (_initialize_dwarf2_read): Update.
9691
e85e19b4
TT		 96922019-05-08 Tom Tromey <tom@tromey.com>
9693
9694 * auto-load.c (struct auto_load_pspace_info): Add destructor and
9695 initializers.
9696 <unsupported_script_warning_printed,
9697 script_not_found_warning_printed>: Now bool.
9698 (auto_load_pspace_data): Change type.
9699 (~auto_load_pspace_info): Rename from
9700 auto_load_pspace_data_cleanup.
9701 (get_auto_load_pspace_data, init_loaded_scripts_info)
9702 (clear_section_scripts, maybe_print_unsupported_script_warning)
9703 (maybe_print_script_not_found_warning, _initialize_auto_load):
9704 Update.
9705
f6aa7436
TT		 97062019-05-08 Tom Tromey <tom@tromey.com>
9707
9708 * objfiles.c (objfile_pspace_info): Add destructor and
9709 initializers.
9710 (objfiles_pspace_data): Change type.
9711 (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
9712 (get_objfile_pspace_data): Update.
9713 (objfiles_bfd_data): Change type.
9714 (get_objfile_bfd_data): Update.
9715 (objfile_bfd_data_free, _initialize_objfiles): Remove.
9716
6ae614f6
TT		 97172019-05-08 Tom Tromey <tom@tromey.com>
9718
9719 * break-catch-syscall.c (catch_syscall_inferior_data): Move.
9720 Change type.
9721 (get_catch_syscall_inferior_data): Update.
9722 (catch_syscall_inferior_data_cleanup): Remove.
9723 (_initialize_break_catch_syscall): Update.
9724
6509b8eb
TT		 97252019-05-08 Tom Tromey <tom@tromey.com>
9726
9727 * inflow.c (struct terminal_info): Add destructor and
9728 initializers.
9729 (inflow_inferior_data): Change type.
9730 (~terminal_info): Rename from inflow_inferior_data_cleanup.
9731 (get_inflow_inferior_data, inflow_inferior_exit)
9732 (swap_terminal_info, _initialize_inflow): Update.
9733
35632941
TT		 97342019-05-08 Tom Tromey <tom@tromey.com>
9735
9736 * target-dcache.c (target_dcache_cleanup): Remove.
9737 (target_dcache_aspace_key): Change type.
9738 (target_dcache_init_p, target_dcache_invalidate)
9739 (target_dcache_get, target_dcache_get_or_init)
9740 (_initialize_target_dcache): Update.
9741 * dcache.h (struct dcache_deleter): New.
9742
3017b94d
TT		 97432019-05-08 Tom Tromey <tom@tromey.com>
9744
9745 * symtab.c (struct symbol_cache): Add destructor and
9746 initializers.
9747 (symbol_cache_key): Move. Change type.
9748 (make_symbol_cache, free_symbol_cache): Remove.
9749 (get_symbol_cache): Update.
9750 (symbol_cache_cleanup): Remove.
9751 (ALL_PSPACES, symbol_cache_flush)
9752 (maintenance_print_symbol_cache)
9753 (maintenance_print_symbol_cache_statistics, _initialize_symtab):
9754 Update.
9755
a32ad8c5
TT		 97562019-05-08 Tom Tromey <tom@tromey.com>
9757
9758 * symtab.c (struct main_info): Add destructor and initializers.
9759 (main_progspace_key): Move. Change type.
9760 (get_main_info): Update.
9761 (main_info_cleanup): Remove.
9762 (_initialize_symtab): Update.
9763
5f6e90a0
TT		 97642019-05-08 Tom Tromey <tom@tromey.com>
9765
9766 * registry.h (DECLARE_REGISTRY): Define the _key class.
9767
1bd0c6e4
AB		 97682019-05-08 Andrew Burgess <andrew.burgess@embecosm.com>
9769
9770 * NEWS: Merge two 'New commands' sections.
9771
2228ef77
XR		 97722019-05-08 Joel Brobecker <brobecker@adacore.com>
9773
9774 * ada-valprint.c (ada_val_print_gnat_array): Remove language
9775 parameter and use Ada language definition instead.
9776 (ada_val_print_ptr): Remove unused language parameter.
9777 (ada_val_print_num): Remove language parameter and use Ada language
9778 definition instead.
9779 (ada_val_print_enum, ada_val_print_flt): Remove unused language
9780 parameter.
9781 (ada_val_print_struct_union, ada_val_print_ref): Remove language
9782 parameter and use Ada language definition instead.
9783 (ada_val_print_1): Update all ada_val_print_xxx calls.
9784 Remove language parameter.
9785 (ada_val_print): Update ada_val_print_1 call.
9786
60fcc1c3
TT		 97872019-05-08 Tom Tromey <tromey@adacore.com>
9788
9789 * remote.c (remote_hw_watchpoint_limit)
9790 (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
9791 Now static.
9792
ed2b7c17
TT		 97932019-05-08 Tom Tromey <tromey@adacore.com>
9794
9795 * maint.c (_initialize_maint_cmds): Move initialization code to
9796 remote.c.
9797 (watchdog, show_watchdog): Move to remote.c.
9798 * remote.c (watchdog, show_watchdog): Move from maint.c. Make
9799 "watchdog" static.
9800 (_initialize_remote): Move initialization code from maint.c.
9801 * defs.h (watchdog): Don't declare.
9802
b0be6c91
TT		 98032019-05-08 Tom Tromey <tromey@adacore.com>
9804
9805 * tui/tui-interp.c: Include main.h.
9806 * interps.c: Include main.h.
9807 * main.h (interpreter_p): Declare.
9808 * defs.h (interpreter_p): Don't declare.
9809
587ee17b
TT		 98102019-05-08 Tom Tromey <tromey@adacore.com>
9811
9812 * dwarf2loc.c: Include dwarf2read.h.
9813 * defs.h (read_unsigned_leb128): Don't declare.
9814 * dwarf2read.h (read_unsigned_leb128): Declare.
9815
ca1df239
TT		 98162019-05-08 Tom Tromey <tromey@adacore.com>
9817
9818 * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
9819 method.
9820
99f20f08
TT		 98212019-05-08 Tom Tromey <tromey@adacore.com>
9822
9823 * utils.c (fputs_maybe_filtered): Reset style after paging, even
9824 when no wrap column is set.
9825
80e55b13
TT		 98262019-05-08 Tom Tromey <tromey@adacore.com>
9827
9828 * c-lang.c (c_get_string): Handle non-C-style arrays.
9829
9d3421af
TT		 98302019-05-08 Tom Tromey <tromey@adacore.com>
9831
9832 * typeprint.c (print_offset_data::update): Print the bit offset,
9833 not the number of bits remaining.
9834
844333e2
TT		 98352019-05-08 Tom Tromey <tromey@adacore.com>
9836
9837 * typeprint.c (print_offset_data::maybe_print_hole): Add extra
9838 padding at end of comment.
9839
988915ee
TT		 98402019-05-08 Tom Tromey <tromey@adacore.com>
9841
9842 * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
9843 Compare main types.
9844
26bfd823
TT		 98452019-05-06 Tom Tromey <tom@tromey.com>
9846
9847 * common/scoped_mmap.c: Include common-defs.h.
9848 * common/scoped_mmap.h: Don't include config.h.
9849
89055eaa
TT		 98502019-05-04 Tom Tromey <tom@tromey.com>
9851
9852 * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
9853 (struct aarch64_call_info): Add initializers.
9854 <si>: Now a std::vector.
9855 (pass_on_stack, aarch64_push_dummy_call): Update.
9856
5da01df5
TT		 98572019-05-04 Simon Marchi <simon.marchi@efficios.com>
9858 Tom Tromey <tom@tromey.com>
9859
9860 * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
9861 (ppc_threads): Now a std::vector. Now static.
9862 (hwdebug_find_thread_points_by_tid)
9863 (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
9864 Update.
9865
fbdf05a1
TT		 98662019-05-04 Tom Tromey <tom@tromey.com>
9867
9868 * arc-tdep.c (arc_tdesc_init): Return bool.
9869
06d16ec9
TT		 98702019-05-04 Tom Tromey <tom@tromey.com>
9871
9872 * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
9873 Use gdb_assert_not_reached.
9874
9c056022
TT		 98752019-05-04 Tom Tromey <tom@tromey.com>
9876
9877 * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
9878 "false".
9879
fa9c2a59
TT		 98802019-05-04 Tom Tromey <tom@tromey.com>
9881
9882 * arc-tdep.c (arc_tdesc_init): Use bool.
9883
e2eb806a
TT		 98842019-05-04 Tom Tromey <tom@tromey.com>
9885
9886 * stack.c (select_frame_for_mi): Use "false", not "FALSE".
9887
6fe87677
TT		 98882019-05-04 Tom Tromey <tom@tromey.com>
9889
9890 * cli/cli-cmds.c (valid_command_p): Return bool.
9891
7f008c9e
TT		 98922019-05-04 Tom Tromey <tom@tromey.com>
9893
9894 * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
9895 * command.h (valid_user_defined_cmd_name_p): Channge return type.
9896
b6484282
RT		 98972019-05-04 Raul Tambre <raul@tambre.ee>
9898
9899 * python/lib/gdb/prompt.py (_ExtendedPrompt)
9900 <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
9901 operator for comparison.
9902
af97b416
TT		 99032019-05-04 Tom Tromey <tom@tromey.com>
9904
9905 * psymtab.c (psymbol_name_matches, match_partial_symbol)
9906 (lookup_partial_symbol, print_partial_symbols)
9907 (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
9908 (psymbol_compare): Update.
9909 (add_psymbol_to_bcache): Clear the entire psymbol.
9910 (maintenance_check_psymtabs): Update.
9911 * psympriv.h (struct partial_symbol): Don't derive from
9912 general_symbol_info.
9913 <obj_section, unrelocated_address, address,
9914 set_unrelocated_address>: Update.
9915 <ginfo>: New member.
9916 * dwarf-index-write.c (write_psymbols, debug_names::insert)
9917 (debug_names::write_psymbols): Update.
9918
9d6d4be8
TV		 99192019-05-04 Tom de Vries <tdevries@suse.de>
9920
9921 * contrib/cc-with-tweaks.sh: Support -n arg.
9922
66452beb
PW		 99232019-05-04 Philippe Waroquiers <philippe.waroquiers@skynet.be>
9924
9925 * corelow.c (core_target::detach): Ensure frame cache and
9926 register caches are cleared.
9927 inferior.c (exit_inferior_1): Likewise.
9928
bde09ab7
TT		 99292019-05-03 Sandra Loosemore <sandra@codesourcery.com>
9930 Tom Tromey <tom@tromey.com>
9931
9932 * dictionary.c (collate_pending_symbols_by_language): Remove
9933 "struct" from foreach.
9934 * symtab.c (lookup_global_symbol_from_objfile)
9935 (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
9936 foreach.
9937 * ser-tcp.c (net_open): Remove "struct" from foreach.
9938 * objfiles.c (objfile_relocate, objfile_rebase)
9939 (objfile_has_symbols): Remove "struct" from foreach.
9940 * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
9941 from foreach.
9942 * dwarf2read.c (handle_struct_member_die): Remove "struct" from
9943 foreach.
9944 * darwin-nat.c (thread_info_from_private_thread_info): Remove
9945 "struct" from foreach.
9946 * ada-lang.c (create_excep_cond_exprs)
9947 (ada_exception_catchpoint_cond_string): Remove "struct" from
9948 foreach.
9949
222a8d25
TT		 99502019-05-03 Tom Tromey <tromey@adacore.com>
9951
9952 * ada-exp.y (convert_char_literal): Check suffix of each
9953 enumerator.
9954
fcd60b84
DP		 99552019-05-03 Dilyan Palauzov <dilyan.palauzov@aegee.org>
9956
9957 PR ada/21406:
9958 * ada-exp.y (yywrap): Don't define.
9959 * ada-lex.l (%option): Add noyywrap
9960 (yywrap): Remove.
9961
5f2459c2
EZ		 99622019-05-03 Eli Zaretskii <eliz@gnu.org>
9963
353ea2d1
EZ		 9964 * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
9965 _WIN32_WINNT to the XP level, unless already defined to a higher
9966 level.
9967
9968 * unittests/parse-connection-spec-selftests.c:
9969 * ser-tcp.c:
9970 * common/netstuff.c [USE_WIN32API]: Remove the _WIN32_WINNT
9971 override.
9972
5f2459c2
EZ		 9973 * symfile.c (find_separate_debug_file): Remove colon from the
9974 drive spec of DOS/Windows file names of the target, so that the
9975 file name produced from DEBUGDIR and the target's directory will
9976 be valid on DOS/Windows systems.
9977
80062eb9
AB		 99782019-05-02 Andrew Burgess <andrew.burgess@embecosm.com>
9979
9980 * rust-lang.c (val_print_struct): Handle printing structures
9981 containing strings.
9982
b8c05e85
TT		 99832019-05-02 Tom Tromey <tromey@adacore.com>
9984
9985 * valarith.c (_initialize_valarith): Remove.
9986
4504bbde
TT		 99872019-05-01 Tom Tromey <tromey@adacore.com>
9988
9989 * ada-lang.c (ada_value_primitive_field): Treat more fields as
9990 bitfields.
9991
d48e62f4
TT		 99922019-05-01 Tom Tromey <tromey@adacore.com>
9993
9994 * ada-lang.c (ada_value_assign): Correctly compute starting offset
9995 for big-endian copies.
9996
15f18d14
AT		 99972019-04-30 Ali Tamur <tamur@google.com>
9998 * gdb/dwarf2read.c (read_3_bytes): New declaration.
9999 (read_attribute_value): Added DW_FORM_strx1-4 cases.
10000 (read_3_bytes): New function.
10001
ab4ee614
JB		 100022019-04-30 Joel Brobecker <brobecker@adacore.com>
10003
10004 * windows-nat.c (main_thread_id): Delete.
10005 (handle_output_debug_string): Replace main_thread_id by
10006 current_event.dwThreadId.
10007 (fake_create_process): Likewise.
10008 (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
10009 Do not set main_thread_id.
10010 <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
10011 current_event.dwThreadId.
10012 <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
10013
8ed5b76e
JB		 100142019-04-30 Joel Brobecker <brobecker@adacore.com>
10015
10016 * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
10017 Use current_event.dwThreadId instead of main_thread_id.
10018
2ff0a947
TT		 100192019-04-30 Tom Tromey <tromey@adacore.com>
10020
10021 * ada-lang.c (ada_lookup_simple_minsyms): New function.
10022 (create_excep_cond_exprs): Iterate over program spaces.
10023 (ada_exception_catchpoint_cond_string): Examine all minimal
10024 symbols for exception types.
10025
a776957c
TT		 100262019-04-30 Tom Tromey <tromey@adacore.com>
10027
10028 PR c++/24470:
10029 * dwarf2read.c (process_structure_scope): Handle case where type
10030 has template parameters but no symbol was created.
10031
bc68014d
AB		 100322019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
10033 Chris January <chris.january@arm.com>
10034
10035 * f-typeprint.c (f_type_print_base): Print 'allocatable' type
10036 qualifier.
10037 * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
10038
f1fdc960
AB		 100392019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
10040
10041 * f-typeprint.c (f_print_type): Update rules for printing
10042 whitespace.
10043 (f_type_print_varspec_suffix): Likewise.
10044
bf7a4de1
AB		 100452019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
10046 Chris January <chris.january@arm.com>
10047
10048 * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
10049 function arguments.
10050
bbe75b9d
AB		 100512019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
10052
10053 * f-lang.c (build_fortran_types): Change name of void type to
10054 lower case.
10055 * f-typeprint.c (f_type_print_base): Print the name of the void
10056 type, rather than a fixed string.
10057 * f-valprint.c (f_decorations): Use lower case void string.
10058
1db455a7
AB		 100592019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
10060 Chris January <chris.january@arm.com>
10061
10062 * dwarf2read.c (dwarf2_init_complex_target_type): Use different
10063 types for Fortran.
10064
b6d03bb2
AB		 100652019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
10066 Chris January <chris.january@arm.com>
10067 David Lecomber <david.lecomber@arm.com>
10068
10069 * f-exp.y (BINOP_INTRINSIC): New token.
10070 (exp): New parser rule handling BINOP_INTRINSIC.
10071 (f77_keywords): Add new builtin procedures.
10072 * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
10073 UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
10074 (operator_length_f): Handle UNOP_FORTRAN_CEILING,
10075 UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
10076 (print_unop_subexp_f): New function.
10077 (print_binop_subexp_f): New function.
10078 (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
10079 BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
10080 (dump_subexp_body_f): Likewise.
10081 (operator_check_f): Likewise.
10082 * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
10083 BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
10084
83228e93
AB		 100852019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
10086
10087 * gdb/expprint.c (dump_subexp_body_standard): Remove use of
10088 UNOP_KIND.
10089 * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
10090 * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
10091 * gdb/f-lang.c (evaluate_subexp_f): Likewise.
10092 (operator_length_f): New fuction.
10093 (print_subexp_f): New function.
10094 (op_name_f): New function.
10095 (dump_subexp_body_f): New function.
10096 (operator_check_f): New function.
10097 (exp_descriptor_f): Replace standard expression handling functions
10098 with new functions.
10099 * gdb/fortran-operator.def: New file.
10100 * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
10101 * gdb/std-operator.def: Remove UNOP_KIND.
10102
6fdcd7cc
AB		 101032019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
10104
10105 * std-operator.def: Remove unbalanced, stray double quote
10106 character.
10107
2e62ab40
AB		 101082019-04-29 Andrew Burgess <andrew.burgess@embecosm.com>
10109 Chris January <chris.january@arm.com>
10110 Daniel Everett <daniel.everett@arm.com>
10111 Nick Forrington <nick.forrington@arm.com>
10112 Richard Bunt <richard.bunt@arm.com>
10113
10114 * cp-valprint.c (cp_print_value_fields): Allow an additional level
10115 of depth when printing anonymous structs or unions.
10116 * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
10117 Don't print either the top-level value, or the children if the
10118 max-depth is exceeded.
10119 (ppscm_print_children): When printing the key of a map, allow one
10120 extra level of depth.
10121 * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
10122 print either the top-level value, or the children if the max-depth
10123 is exceeded.
10124 (print_children): When printing the key of a map, allow one extra
10125 level of depth.
10126 * python/py-value.c (valpy_format_string): Add max_depth keyword.
10127 * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
10128 (user_print_options): Initialise max_depth field.
10129 (val_print_scalar_or_string_type_p): New function.
10130 (val_print): Check to see if the max depth has been reached.
10131 (val_print_check_max_depth): Define new function.
10132 (show_print_max_depth): New function.
10133 (_initialize_valprint): Add 'print max-depth' option.
10134 * valprint.h (struct value_print_options) <max_depth>: New field.
10135 (val_print_check_max_depth): Declare new function.
10136 * NEWS: Document new feature.
10137
4be290b2
AB		 101382019-04-29 Andrew Burgess <andrew.burgess@embecosm.com>
10139
10140 * ada-lang.c (ada_language_defn): Initialise new field.
10141 * c-lang.c (c_is_string_type_p): New function.
10142 (c_language_defn): Initialise new field.
10143 (cplus_language_defn): Initialise new field.
10144 (asm_language_defn): Initialise new field.
10145 (minimal_language_defn): Initialise new field.
10146 * c-lang.h (c_is_string_type_p): Declare new function.
10147 * d-lang.c (d_language_defn): Initialise new field.
10148 * f-lang.c (f_is_string_type_p): New function.
10149 (f_language_defn): Initialise new field.
10150 * go-lang.c (go_is_string_type_p): New function.
10151 (go_language_defn): Initialise new field.
10152 * language.c (default_is_string_type_p): New function.
10153 (unknown_language_defn): Initialise new field.
10154 (auto_language_defn): Initialise new field.
10155 * language.h (struct language_defn) <la_is_string_type_p>: New
10156 member variable.
10157 (default_is_string_type_p): Declare new function.
10158 * m2-lang.c (m2_language_defn): Initialise new field.
10159 * objc-lang.c (objc_language_defn): Initialise new field.
10160 * opencl-lang.c (opencl_language_defn): Initialise new field.
10161 * p-lang.c (pascal_is_string_type_p): New function.
10162 (pascal_language_defn): Initialise new field.
10163 * rust-lang.c (rust_is_string_type_p): New function.
10164 (rust_language_defn): Initialise new field.
10165
721b08c6
AB		 101662019-04-29 Andrew Burgess <andrew.burgess@embecosm.com>
10167
10168 * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
10169 New field.
10170 * ada-lang.c (ada_language_defn): Initialise new field.
10171 * c-lang.c (c_language_defn): Likewise.
10172 (cplus_language_defn): Likewise.
10173 (asm_language_defn): Likewise.
10174 (minimal_language_defn): Likewise.
10175 * d-lang.c (d_language_defn): Likewise.
10176 * f-lang.c (f_language_defn): Likewise.
10177 * go-lang.c (go_language_defn): Likewise.
10178 * language.c (unknown_language_defn): Likewise.
10179 (auto_language_defn): Likewise.
10180 * m2-lang.c (m2_language_defn): Likewise.
10181 * objc-lang.c (objc_language_defn): Likewise.
10182 * opencl-lang.c (opencl_language_defn): Likewise.
10183 * p-lang.c (pascal_language_defn): Likewise.
10184 * rust-lang.c (rust_language_defn): Likewise.
10185
fc913e53
AB		 101862019-04-29 Andrew Burgess <andrew.burgess@embecosm.com>
10187
10188 * ada-lang.c (ada_is_character_type): Change return type to bool.
10189 (ada_is_string_type): Likewise.
10190 * ada-lang.h (ada_is_character_type): Update declaration
10191 (ada_is_string_type): Likewise.
10192
fa731fa0
PW		 101932019-04-27 Philippe Waroquiers <philippe.waroquiers@skynet.be>
10194
10195 Support style in 'frame|thread apply'
10196
10197 * gdbcmd.h (execute_command_to_string): New term_out parameter.
10198 * record.c (record_start, record_stop): Update callers of
10199 execute_command_to_string with false.
10200 * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
10201 * ui-file.h (class ui_file): New term_out and can_emit_style_escape
10202 methods.
10203 (class string_file): New constructor with term_out parameter.
10204 Override methods term_out and can_emit_style_escape. New member
10205 term_out.
10206 (class stdio_file): Override can_emit_style_escape.
10207 (class tee_file): Override term_out and can_emit_style_escape.
10208 * utils.h (can_emit_style_escape): Remove.
10209 * utils.c (can_emit_style_escape): Likewise.
10210 Update all callers of can_emit_style_escape (SOMESTREAM) to
10211 SOMESTREAM->can_emit_style_escape.
10212 * source-cache.c (source_cache::get_source_lines): Likewise.
10213 * stack.c (frame_apply_command_count): Call execute_command_to_string
10214 passing the term_out characteristic of the current gdb_stdout.
10215 * thread.c (thr_try_catch_cmd): Likewise.
10216 * top.c (execute_command_to_string): pass term_out parameter
10217 to construct the string_file for the command output.
10218 * ui-file.c (term_cli_styling): New function (most code moved
10219 from utils.c can_emit_style_escape).
10220 (string_file::string_file, string_file::can_emit_style_escape,
10221 stdio_file::can_emit_style_escape, tee_file::term_out,
10222 tee_file::can_emit_style_escape): New functions.
10223
136afab8
PW		 102242019-04-27 Philippe Waroquiers <philippe.waroquiers@skynet.be>
10225
10226 * NEWS: Mention the new set|show may-call-functions.
10227 * infcall.c (may_call_functions_p): New variable.
10228 (show_may_call_functions_p): New function.
10229 (call_function_by_hand_dummy): Throws an error if not
10230 may-call-functions.
10231 (_initialize_infcall): Call add_setshow_boolean_cmd for
10232 may-call-functions.
10233
725cbb63
KS		 102342019-04-25 Keith Seitz <keiths@redhat.com>
10235
10236 PR c++/24367
10237 * cp-support.c (inspect_type): Don't attempt substitutions
10238 of symbol with the same name.
10239
3d1cbb78
TT		 102402019-04-25 Tom Tromey <tromey@adacore.com>
10241
10242 PR gdb/24475:
10243 * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
10244 static.
10245
94aeb44b
TT		 102462019-04-25 Tom Tromey <tromey@adacore.com>
10247
10248 * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
10249 rvalue reference.
10250 (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
10251 (gdb_xml_parser::parse): Use std::move.
10252 * python/python-internal.h (gdbpy_convert_exception): Take a const
10253 reference.
10254 * python/py-value.c (valpy_getitem, valpy_nonzero): Use
10255 std::move.
10256 * python/py-utils.c (gdbpy_convert_exception): Take a const
10257 reference.
10258 * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
10259 Use std::move.
10260 * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
10261 Use std::move.
10262 * mi/mi-main.c (mi_print_exception): Take a const reference.
10263 * main.c (handle_command_errors): Take a const reference.
10264 * linespec.c (parse_linespec): Use std::move.
10265 * infcall.c (run_inferior_call): Use std::move.
10266 (call_function_by_hand_dummy): Use std::move.
10267 * exec.c (try_open_exec_file): Use std::move.
10268 * exceptions.h (exception_print, exception_fprintf)
10269 (exception_print_same): Update.
10270 * exceptions.c (print_exception, exception_print)
10271 (exception_fprintf, exception_print_same): Change parameters to
10272 const reference.
10273 * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
10274 * common/new-op.c: Use std::move.
10275 * common/common-exceptions.h (struct gdb_exception): Add move
10276 constructor.
10277 (struct gdb_exception_error, struct gdb_exception_quit, struct
10278 gdb_quit_bad_alloc): Change constructor to move constructor.
10279 (throw_exception): Change parameter to rvalue reference.
10280 * common/common-exceptions.c (throw_exception): Take rvalue
10281 reference.
10282 * cli/cli-interp.c (safe_execute_command): Use std::move.
10283 * breakpoint.c (insert_bp_location, location_to_sals): Use
10284 std::move.
10285
680d7fd5
TT		 102862019-04-25 Tom Tromey <tromey@adacore.com>
10287
10288 * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
10289 (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
10290 * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
10291 guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
10292 guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
10293 guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
10294 guile/scm-value.c: Use unpack.
10295 * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
10296 gdbscm_gdb_exception.
10297 (gdbscm_throw_gdb_exception): Likewise.
10298 (struct gdbscm_gdb_exception): New.
10299 (unpack): New function.
10300 (gdbscm_wrap): Use unpack.
10301
c6fdd8b2
TT		 103022019-04-25 Tom Tromey <tromey@adacore.com>
10303
10304 * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
10305 (gdb_rl_callback_handler): Use std::move.
10306 * common/common-exceptions.h (struct gdb_exception): Add move
10307 assignment operator.
10308 (throw_exception_sjlj): Change "exception" to const reference.
10309 * common/common-exceptions.c (exceptions_state_mc_catch): Update.
10310 (throw_exception_sjlj): Change "exception" to const reference.
10311
cc06b668
TT		 103122019-04-25 Tom Tromey <tromey@adacore.com>
10313
10314 * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
10315 * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
10316 * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
10317 Update.
10318 * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
10319 Update.
10320 * mi/mi-interp.c (mi_interp::exec): Update.
10321 * linespec.c (parse_linespec): Update.
10322 * infcall.c (run_inferior_call): Update.
10323 * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
10324 * guile/scm-symbol.c (gdbscm_lookup_symbol)
10325 (gdbscm_lookup_global_symbol): Update.
10326 * guile/scm-param.c (gdbscm_parameter_value): Update.
10327 * guile/scm-frame.c (gdbscm_frame_read_register)
10328 (gdbscm_frame_read_var): Update.
10329 * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
10330 * exec.c (try_open_exec_file): Update.
10331 * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
10332 (gdb_rl_callback_handler): Update.
10333 * common/common-exceptions.h (exception_none): Don't declare.
10334 * common/common-exceptions.c (exception_none): Don't define.
10335 (struct catcher) <exception>: Update.
10336 * cli/cli-interp.c (safe_execute_command): Update.
10337 * breakpoint.c (insert_bp_location, location_to_sals): Update.
10338
cf532bd1
AT		 103392019-04-25 Ali Tamur <tamur@google.com>
10340
10341 * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
10342 (read_attribute_value): Likewise.
10343 (dwarf2_read_addr_index): Update comment.
10344 (read_str_index): Add DW_FORM_strx.
10345 (dwarf2_string_attr): Likewise.
10346 (dwarf2_const_value_attr): Likewise.
10347 (dump_die_shallow): Likewise.
10348 (dwarf2_fetch_constant_bytes): Likewise.
10349 (skip_form_bytes): Likewise.
10350 * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
10351
82433e3e
SDJ		 103522019-04-25 Sergio Durigan Junior <sergiodj@redhat.com>
10353
10354 PR corefiles/11608
10355 PR corefiles/18187
10356 * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
10357 OFFSET. Verify if current mapping contains an ELF header.
10358 (linux_find_memory_regions_full): Adjust call to
10359 dump_mapping_p.
10360
723adb65
SL		 103612019-04-25 Sandra Loosemore <sandra@codesourcery.com>
10362 Kang Li <kanglictf@gmail.com>
10363
10364 PR gdb/21600
10365
10366 * dwarf2-frame.c (read_initial_length): Be consistent about using
10367 unsigned representation of length.
10368 (decode_frame_entry_1): Likewise. Check for wraparound of
10369 end pointer as well as buffer overflow.
10370
596179f7
SDJ		 103712019-04-24 Sergio Durigan Junior <sergiodj@redhat.com>
10372
10373 * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
10374 "vq".
10375
a59240a4
TT		 103762019-04-24 Tom Tromey <tromey@adacore.com>
10377
10378 * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
10379
f872fdbb
AB		 103802019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10381
10382 * s12z-tdep.c (s12z_unwind_pc): Delete.
10383 (s12z_unwind_sp): Delete.
10384 (s12z_gdbarch_init): Don't register deleted functions with
10385 gdbarch.
10386
b614e6f3
AB		 103872019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10388
10389 * rl78-tdep.c (rl78_unwind_sp): Delete.
10390 (rl78_gdbarch_init): Don't register deleted function with gdbarch.
10391
14faed38
AB		 103922019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10393
10394 * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
10395 (xstormy16_unwind_pc): Delete.
10396 (xstormy16_dummy_id): Delete.
10397 (xstormy16_gdbarch_init): Don't register deleted functions with
10398 gdbarch.
10399
541aad8a
AB		 104002019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10401
10402 * vax-tdep.c (vax_unwind_pc): Delete.
10403 (vax_gdbarch_init): Don't register deleted function with gdbarch.
10404
29222070
AB		 104052019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10406
10407 * v850-tdep.c (v850_unwind_sp): Delete.
10408 (v850_unwind_pc): Delete.
10409 (v850_dummy_id): Delete.
10410 (v850_gdbarch_init): Don't register deleted functions with
10411 gdbarch.
10412
0f534d76
AB		 104132019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10414
10415 * tilegx-tdep.c (tilegx_unwind_sp): Delete.
10416 (tilegx_unwind_pc): Delete.
10417 (tilegx_unwind_dummy_id): Delete.
10418 (tilegx_gdbarch_init): Don't register deleted functions with
10419 gdbarch.
10420
1ba7b7f9
AB		 104212019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10422
10423 * tic6x-tdep.c (tic6x_unwind_sp): Delete.
10424 (tic6x_dummy_id): Delete.
10425 (tic6x_gdbarch_init): Don't register deleted functions with
10426 gdbarch.
10427
d31f262c
AB		 104282019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10429
10430 * sparc-tdep.c (sparc_unwind_pc): Delete.
10431 (sparc32_gdbarch_init): Don't register deleted function with
10432 gdbarch.
10433
6d14d64d
AB		 104342019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10435
10436 * sh-tdep.c (sh_unwind_sp): Delete.
10437 (sh_unwind_pc): Delete.
10438 (sh_dummy_id): Delete.
10439 (sh_gdbarch_init): Don't register deleted functions with
10440 gdbarch.
10441
a40dde9d
AB		 104422019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10443
10444 * score-tdep.c (score_unwind_sp): Delete.
10445 (score_unwind_pc): Delete.
10446 (score_dummy_id): Delete.
10447 (score_gdbarch_init): Don't register deleted functions with
10448 gdbarch.
10449
47c47d69
AB		 104502019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10451
10452 * rx-tdep.c (rx_unwind_pc): Delete.
10453 (rx_unwind_sp): Delete.
10454 (rx_dummy_id): Delete.
10455 (rx_gdbarch_init): Don't register deleted functions with
10456 gdbarch. Update comment.
10457
833a4480
AB		 104582019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10459
10460 * rs6000-tdep.c (rs6000_unwind_pc): Delete.
10461 (rs6000_dummy_id): Delete.
10462 (rs6000_gdbarch_init): Don't register deleted functions with
10463 gdbarch.
10464
3f2cef49
AB		 104652019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10466
10467 * or1k-tdep.c (or1k_dummy_id): Delete.
10468 (or1k_gdbarch_init): Don't register deleted function with gdbarch.
10469
96acf884
AB		 104702019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10471
10472 * nios2-tdep.c (nios2_dummy_id): Delete.
10473 (nios2_unwind_sp): Delete.
10474 (nios2_gdbarch_init): Don't register deleted functions with
10475 gdbarch.
10476
ca0ab0aa
AB		 104772019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10478
10479 * nds32-tdep.c (nds32_dummy_id): Delete.
10480 (nds32_unwind_pc): Delete.
10481 (nds32_unwind_sp): Delete.
10482 (nds32_gdbarch_init): Don't register deleted functions with
10483 gdbarch.
10484
c8259044
AB		 104852019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10486
10487 * msp430-tdep.c (msp430_unwind_pc): Delete.
10488 (msp430_unwind_sp): Delete.
10489 (msp430_dummy_id): Delete.
10490 (msp430_gdbarch_init): Don't register deleted functions with
10491 gdbarch.
10492
27f113c8
AB		 104932019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10494
10495 * moxie-tdep.c (moxie_unwind_sp): Delete.
10496 (moxie_unwind_pc): Delete.
10497 (moxie_dummy_id): Delete.
10498 (moxie_gdbarch_init): Don't register deleted functions with
10499 gdbarch.
10500
aee6c3cd
AB		 105012019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10502
10503 * mn10300-tdep.c (mn10300_dummy_id): Delete.
10504 (mn10300_unwind_pc): Delete.
10505 (mn10300_unwind_sp): Delete.
10506 (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
10507 mn10300_unwind_sp.
10508 (mn10300_frame_unwind_init): Don't register deleted functions with
10509 gdbarch.
10510
8e2b5aea
AB		 105112019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10512
10513 * mep-tdep.c (mep_unwind_pc): Delete.
10514 (mep_unwind_sp): Delete.
10515 (mep_dummy_id): Delete.
10516 (mep_gdbarch_init): Don't register deleted functions with
10517 gdbarch.
10518
43cf3ede
AB		 105192019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10520
10521 * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
10522 (m68hc11_unwind_sp): Delete.
10523 (m68hc11_gdbarch_init): Don't register deleted functions with
10524 gdbarch.
10525
5e79b7bb
AB		 105262019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10527
10528 * m32r-tdep.c (m32r_unwind_sp): Delete.
10529 (m32r_unwind_pc): Delete.
10530 (m32r_dummy_id): Delete.
10531 (m32r_gdbarch_init): Don't register deleted functions with
10532 gdbarch.
10533
89b268d8
AB		 105342019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10535
10536 * m32c-tdep.c (m32c_unwind_pc): Delete.
10537 (m32c_unwind_sp): Delete.
10538 (m32c_dummy_id): Delete.
10539 (m32c_gdbarch_init): Don't register deleted functions with
10540 gdbarch.
10541
946c28d2
AB		 105422019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10543
10544 * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
10545 (lm32_unwind_pc): Delete.
10546 (lm32_dummy_id): Delete.
10547 (lm32_gdbarch_init): Don't register deleted functions with
10548 gdbarch.
10549
bf12844a
AB		 105502019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10551
10552 * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
10553 (iq2000_unwind_pc): Delete.
10554 (iq2000_dummy_id): Delete.
10555 (iq2000_gdbarch_init): Don't register deleted functions with
10556 gdbarch.
10557
ecbc06d2
AB		 105582019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10559
10560 * nds32-tdep.c (nds32_type_align): Delete.
10561 (nds32_push_dummy_call): Use type_align instead.
10562
030197b4
AB		 105632019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10564
10565 * arm-tdep.c (arm_type_align): Only handle vector override case.
10566 (arm_push_dummy_call): Use type_align.
10567 (arm_gdbarch_init): Register arm_type_align gdbarch function.
10568
b907456c
AB		 105692019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10570
10571 * aarch64-tdep.c (aarch64_type_align): Only handle vector override
10572 case.
10573 (pass_on_stack): Use type_align.
10574 (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
10575 function.
10576
9e97ba43
TT		 105772019-04-23 Tom Tromey <tromey@adacore.com>
10578
10579 * dwarf2read.c (line_header::file_name_at): Remove unused
10580 overload.
10581
6892f601
TV		 105822019-04-23 Tom de Vries <tdevries@suse.de>
10583
10584 PR gdb/24438
10585 * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
10586 invocation.
10587
336d760d
AT		 10588
105892019-03-27 Ali Tamur <tamur@google.com>
10590
10591 * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
10592 * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
10593 * dwarf2expr.h(dwarf_expr_context::offset): Update comment
10594 (dwarf_expr_context::get_addr_index): Likewise
10595 * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
10596 (symbol_needs_eval_context::get_addr_index): Likewise
10597 (disassemble_dwarf_expression): Add DW_OP_addrx
10598 * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
10599 (read_cutu_die_from_dwo): Update comment
10600 (skip_one_die): Add DW_FORM_addrx
10601 (read_attribute_value): Likewise
10602 (var_decode_location): Add DW_OP_addrx
10603 (dwarf2_const_value_attr): Add DW_FORM_addrx
10604 (dump_die_shallow): Likewise
10605 (dwarf2_fetch_constant_bytes): Likewise
10606 (decode_locdesc): Add DW_OP_addrx
10607 (skip_form_bytes): Add DW_FORM_addrx
10608
ad9d13f8
AT		 106092019-04-22 Ali Tamur <tamur@google.com>
10610
10611 * MAINTAINERS (Write After Approval): Add self.
10612
d70cc3ba
SM		 106132019-04-22 Simon Marchi <simon.marchi@efficios.com>
10614
10615 * solib-svr4.c (get_svr4_info): Add pspace parameter.
10616 (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
10617 (open_symbol_file_object): Likewise.
10618 (svr4_default_sos): Add info parameter.
10619 (svr4_read_so_list): Likewise.
10620 (svr4_current_sos_direct): Adjust functions calls to pass down
10621 info.
10622 (svr4_current_sos_1): Add info parameter.
10623 (svr4_current_sos): Call get_svr4_info, pass info down to
10624 svr4_current_sos_1.
10625 (svr4_fetch_objfile_link_map): Pass objfile->pspace to
10626 get_svr4_info.
10627 (svr4_in_dynsym_resolve_code): Pass current_program_space to
10628 get_svr4_info.
10629 (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
10630 to get_svr4_info.
10631 (probes_table_remove_objfile_probes): Likewise.
10632 (register_solib_event_probe): Add info parameter.
10633 (solist_update_incremental): Pass info parameter down to
10634 svr4_read_so_list.
10635 (disable_probes_interface): Add info parameter.
10636 (svr4_handle_solib_event): Pass current_program_space to
10637 get_svr4_info. Adjust disable_probes_interface cleanup.
10638 (svr4_create_probe_breakpoints): Add info parameter, pass it
10639 down to register_solib_event_probe.
10640 (svr4_create_solib_event_breakpoints): Add info parameter,
10641 pass it down to svr4_create_probe_breakpoints.
10642 (enable_break): Pass info down to
10643 svr4_create_solib_event_breakpoints.
10644 (svr4_solib_create_inferior_hook): Pass current_program_space to
10645 get_svr4_info.
10646 (svr4_clear_solib): Likewise.
10647
7905fc35
PA		 106482019-04-22 Pedro Alves <palves@redhat.com>
10649
10650 * solib-svr4.c (svr4_free_objfile_observer): New.
10651 (probe_and_action::objfile): New field.
10652 (probes_table_htab_remove_objfile_probes)
10653 (probes_table_remove_objfile_probes): New functions.
10654 (register_solib_event_probe): Add 'objfile' parameter. Store it
10655 in the new probe_and_action. Don't store the probe in 'lookup'.
10656 (svr4_create_probe_breakpoints): Pass objfile to
10657 register_solib_event_probe.
10658 (_initialize_svr4_solib): Register a free_objfile observer.
10659
fb881986
TT		 106602019-04-19 Tom Tromey <tom@tromey.com>
10661
10662 * common/queue.h: Remove.
10663
8732db6c
TT		 106642019-04-19 Tom Tromey <tom@tromey.com>
10665
10666 * event-loop.c: Don't include "common/queue.h".
10667
97dfbadd
TT		 106682019-04-19 Tom Tromey <tom@tromey.com>
10669
10670 * remote.c (remote_target): Use delete.
10671 * remote-notif.h: Include <list>, not "common/queue.h".
10672 (notif_client_p): Remove typedef.
10673 (remote_notif_state): Add constructor, destructor, initializer.
10674 <notif_queue>: Now a std::list.
10675 (remote_notif_state_xfree): Don't declare.
10676 * remote-notif.c (remote_notif_process, handle_notification)
10677 (remote_notif_state_allocate): Update.
10678 (~remote_notif_state): Rename from remote_notif_state_xfree.
10679
cf250e36
TT		 106802019-04-19 Tom Tromey <tom@tromey.com>
10681
10682 * symfile.c (reread_symbols): Update.
10683 * objfiles.c (objfile_register_static_link)
10684 (objfile_lookup_static_link): Update
10685 (~objfile) Don't delete static_links.
10686 * objfiles.h (struct objfile) <static_links>: Now an htab_up.
10687
61f4b350
TT		 106882019-04-19 Tom Tromey <tom@tromey.com>
10689
10690 * type-stack.h (struct type_stack) <insert>: Constify string.
10691 * type-stack.c (type_stack::insert): Constify string.
10692 * gdbtypes.h (lookup_template_type): Update.
10693 (address_space_name_to_int): Update.
10694 * gdbtypes.c (address_space_name_to_int): Make space_identifier
10695 const.
10696 (lookup_template_type): Make name const.
10697 * c-exp.y: Update rules.
10698 (lex_one_token, classify_name, classify_inner_name)
10699 (c_print_token): Update.
10700 * p-exp.y: Update rules.
10701 (yylex): Update.
10702 * f-exp.y: Update rules.
10703 (yylex): Update.
10704 * d-exp.y: Update rules.
10705 (lex_one_token, classify_name, classify_inner_name): Update.
10706 * parse.c (write_dollar_variable, copy_name): Return std::string.
10707 * parser-defs.h (copy_name): Change return type.
10708 * m2-exp.y: Update rules.
10709 (yylex): Update.
10710 * go-exp.y (lex_one_token): Update.
10711 Update rules.
10712 (classify_unsafe_function, classify_packaged_name)
10713 (classify_name, yylex): Update.
10714
189b8c2e
ST		 107152019-04-19 Sergei Trofimovich <siarheit@google.com>
10716
10717 * configure.ac: add --enable-source-highlight switch.
10718 * configure: Regenerate.
10719 * top.c (print_gdb_version): plumb --enable-source-highlight
10720 status to "show configuration".
10721
8ecb59f8
TT		 107222019-04-19 Tom Tromey <tromey@adacore.com>
10723
10724 * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
10725 Check ADA_TYPE_P.
10726 (empty_record, ada_template_to_fixed_record_type_1)
10727 (template_to_static_fixed_type)
10728 (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
10729 * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
10730 * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
10731 macros.
10732
62160ec9
TT		 107332019-04-19 Ilya Yu. Malakhov <malakhov@mcst.ru>
10734
10735 PR symtab/24423:
10736 * source.c (print_source_lines_base): Advance "iter" when a
10737 control character is seen.
10738
f2ae8bc8
PW		 107392019-04-19 Philippe Waroquiers <philippe.waroquiers@skynet.be>
10740
10741 * inferior.h (struct infcall_suspend_state_deleter):
10742 Catch exception in destructor to avoid crash.
10743
d563b953
PW		 107442019-04-19 Philippe Waroquiers <philippe.waroquiers@skynet.be>
10745
10746 * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
10747 close to the add_com "shell".
10748
dc34c897
TT		 107492019-04-18 Tom Tromey <tromey@adacore.com>
10750
10751 * process-stratum-target.h (class process_stratum_target)
10752 <stratum>: Add "final".
10753
a12e5744
TT		 107542019-04-17 Tom Tromey <tromey@adacore.com>
10755
10756 * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
10757 against nullptr before use.
10758
a7e559cc
AH		 107592019-04-17 Alan Hayward <alan.hayward@arm.com>
10760
10761 * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
10762
c01660c6
AB		 107632019-04-17 Jim Wilson <jimw@sifive.com>
10764 Andrew Burgess <andrew.burgess@embecosm.com>
10765
10766 * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
10767 code read might fail, assume 4-byte breakpoint in that case.
10768
4aa866af
LS		 107692019-04-15 Leszek Swirski <leszeks@google.com>
10770
10771 * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
10772 rather than a hand-rolled POD check when checking for forced MEMORY
10773 classification.
10774
48574d91
AH		 107752019-04-15 Alan Hayward <alan.hayward@arm.com>
10776
10777 * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
10778 * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
10779 function.
10780 (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
10781 (aarch64_sve_regs_copy_from_reg_buf): Likewise.
10782 * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
10783 declaration.
10784
4da037ef
AH		 107852019-04-15 Alan Hayward <alan.hayward@arm.com>
10786
10787 * aarch64-linux-nat.c
10788 (aarch64_linux_nat_target::thread_architecture): Add override.
10789 * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
10790 each VQ.
10791
ccb8d7e8
AH		 107922019-04-15 Alan Hayward <alan.hayward@arm.com>
10793
10794 * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
10795
35add35e
AB		 107962019-04-13 Andrew Burgess <andrew.burgess@embecosm.com>
10797
10798 * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
10799 target types of size 96-bits, add some additional comments, and
10800 check that the builtin type we found was the correct size.
10801
51196bbc
EZ		 108022019-04-12 Eli Zaretskii <eliz@gnu.org>
10803
10804 * utils.c (prompt_for_continue): Don't restore the styling at the
10805 end, as applied_style has the wrong value. This fixes styling in
10806 long lists of file names that are interrupted by the "Continue?"
10807 prompt.
10808
62253a61
AB		 108092019-04-12 Andrew Burgess <andrew.burgess@embecosm.com>
10810
10811 * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
10812 * c-lang.c (c_language_defn): Likewise.
10813 (cplus_language_defn): Likewise.
10814 (asm_language_defn): Likewise.
10815 (minimal_language_defn): Likewise.
10816 * d-lang.c (d_language_defn): Likewise.
10817 * f-lang.c (f_language_defn): Likewise.
10818 * go-lang.c (go_language_defn): Likewise.
10819 * language.c (unknown_language_defn): Likewise.
10820 (auto_language_defn): Likewise.
10821 * language.h (struct language_defn): Remove la_magic field.
10822 (LANG_MAGIC): Delete.
10823 * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
10824 * objc-lang.c (objc_language_defn): Likewise.
10825 * opencl-lang.c (opencl_language_defn): Likewise.
10826 * p-lang.c (pascal_language_defn): Likewise.
10827 * rust-lang.c (rust_language_defn): Likewise.
10828
a9158a86
AB		 108292019-04-11 Andrew Burgess <andrew.burgess@embecosm.com>
10830
10831 * riscv-tdep.c (riscv_type_align): New function.
10832 (riscv_type_alignment): Delete.
10833 (riscv_arg_location): Use 'type_align'.
10834 (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
10835
41077b66
AB		 108362019-04-11 Andrew Burgess <andrew.burgess@embecosm.com>
10837
10838 * gdbtypes.c (type_align): A struct with no non-static fields also
10839 has alignment of 1.
10840
9f0272f8
AB		 108412019-04-11 Andrew Burgess <andrew.burgess@embecosm.com>
10842
10843 * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
10844 component to 0.
10845 (riscv_struct_info::riscv_struct_info): Initialise m_offsets
10846 member.
10847 (riscv_struct_info::analyse): New implementation using new
10848 analyse_inner member function.
10849 (riscv_struct_info::field_offset): New member function.
10850 (riscv_struct_info::m_offsets): New member variable.
10851 (riscv_struct_info::analyse_inner): New private member function,
10852 takes the old implementation of riscv_struct_info::analyse but
10853 extended to track field offsets.
10854 (riscv_call_arg_struct): Update the struct folding special cases
10855 to handle cases where empty C++ structs, which are non-zero
10856 length, are found.
10857 (riscv_arg_location): Initialise the length of each location, a
10858 non-zero length now indicates the location is in use.
10859 (riscv_push_dummy_call): Allow for the first location having a
10860 non-zero offset when setting up arguments.
10861 (riscv_return_value): Likewise, but for return values.
10862
02cf60c7
TT		 108632019-04-11 Tom Tromey <tromey@adacore.com>
10864
10865 * utils.c (internal_vproblem): Make "msg" const.
10866
68811f8f
AH		 108672019-04-11 Alan Hayward <alan.hayward@arm.com>
10868
10869 * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
10870 * trad-frame.c (trad_frame_reset_saved_regs): New function.
10871 (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
10872 * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
10873
3f52fdbc
KB		 108742019-04-10 Kevin Buettner <kevinb@redhat.com>
10875
10876 * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
10877 function.
10878 (fill_gregset): Call amd64_linux_collect_native_gregset instead
10879 of amd64_collect_native_gregset.
10880 (amd64_linux_nat_target::store_registers): Likewise.
10881
e9ad22ee
TT		 108822019-04-10 Tom Tromey <tom@tromey.com>
10883
10884 * symtab.c (lookup_global_symbol_from_objfile)
10885 (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
10886 * objfiles.h (class separate_debug_iterator): New.
10887 (class separate_debug_range): New.
10888 (struct objfile) <separate_debug_objfiles>: New method.
10889 (objfile_separate_debug_iterate): Don't declare.
10890 * objfiles.c (separate_debug_iterator::operator++): Rename from
10891 objfile_separate_debug_iterate.
10892 (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
10893 iterator.
10894 * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
10895 iterator.
10896
ee371134
TT		 108972019-04-10 Tom Tromey <tom@tromey.com>
10898
10899 * symfile.c (reread_symbols): Remove old comment.
10900 * objfiles.c (free_all_objfiles): Fix a typo.
10901
bf227d61
TT		 109022019-04-10 Tom Tromey <tom@tromey.com>
10903
10904 * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
10905 * minsyms.c (lookup_minimal_symbol): Use foreach.
10906 (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
10907 (lookup_minimal_symbol_solib_trampoline): Likewise.
10908 * symfile.c (reread_symbols): Use foreach.
10909
8dc433a0
TT		 109102019-04-09 Ivan Begert <ivanbegert@gmail.com>
10911 Tom Tromey <tromey@adacore.com>
10912
10913 PR rust/24414:
10914 * rust-exp.y (rust_parser::lex_number): Use strtoulst.
10915 (rust_lex_int_test): Change "value" to be LONGEST.
10916 (rust_lex_tests): Add test for long integer literal.
10917
9ab8741a
TT		 109182019-04-09 Tom Tromey <tromey@adacore.com>
10919
10920 * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
10921 to bool.
10922 (extended_remote_target::attach): Update.
10923 (remote_target::remote_notice_new_inferior): Update.
10924 (remote_target::add_current_inferior_and_thread): Update.
10925 * inferior.c (exit_inferior_1): Use "false".
10926 * corelow.c (add_to_thread_list): Make fake_pid_p bool.
10927
e242fd12
SM		 109282019-04-09 Simon Marchi <simon.marchi@efficios.com>
10929
9ca1957f 10930 * infcmd.c (run_command_1): Pass -qualified to tbreak when using
e242fd12
SM		 10931 the "start" command.
10932
2b0c8b01
KB		 109332019-04-08 Kevin Buettner <kevinb@redhat.com>
10934
10935 * python/py-inferior.c (infpy_thread_from_thread_handle):
10936 Adjust comments to reflect renaming of thread_from_thread_handle
10937 to thread_from_handle. Adjust keywords. Fix type error message.
10938 (inferior_object_methods): Add thread_from_handle. Retain
10939 thread_from_thread_handle, but mark it as deprecated.
10940
50a82723
KB		 109412019-04-08 Kevin Buettner <kevinb@redhat.com>
10942
10943 * gdbthread.h (find_thread_by_handle): Revise declaration.
10944 * thread.c (find_thread_by_handle): Likewise. Adjust
10945 implementation too.
10946 * python/py-inferior.c (infpy_thread_from_thread_handle): Add
10947 support for buffer objects as handles.
10948
cf63b016
KB		 109492019-04-08 Kevin Buettner <kevinb@redhat.com>
10950
10951 * python/py-infthread.c (thpy_thread_handle): New function.
10952 (thread_object_methods): Register thpy_thread_handle.
10953
3d6c6204
KB		 109542019-04-08 Kevin Buettner <kevinb@redhat.com>
10955
10956 * gdbthread.h (thread_to_thread_handle): Declare.
10957 * thread.c (gdbtypes.h): Include.
10958 (thread_to_thread_handle): New function.
10959
10960 * target.h (struct target_ops): Add thread_info_to_thread_handle.
10961 (target_thread_info_to_thread_handle): Declare.
10962 * target.c (target_thread_info_to_thread_handle): New function.
10963 * target-debug.h (target_debug_print_gdb_byte_vector): Define.
10964 * target-delegates.c: Regenerate.
10965
10966 * linux-thread-db.c (class thread_db_target): Add method
10967 thread_info_to_thread_handle.
10968 (thread_db_target::thread_info_to_thread_handle): Define.
10969 * remote.c (class remote_target): Add new method
10970 thread_info_to_thread_handle.
10971 (remote_target::thread_info_to_thread_handle): Define.
10972
56be6ea8
PA		 109732019-04-08 Pedro Alves <palves@redhat.com>
10974
10975 * common/common-exceptions.c (throw_exception): Don't create
10976 named object to throw; throw directly.
10977 (throw_it): Likewise. Don't initialize gdb_exception::message
10978 here, with new; pass FMT and AP to the ctor instead.
10979 * common/common-exceptions.h: Include <string>.
10980 (gdb_exception::gdb_exception(enum return_reason, enum errors,
10981 const char *, va_list)): New ctor. Use std::make_shared.
10982 (gdb_exception_error::gdb_exception_error(enum return_reason, enum
10983 errors)): Delete.
10984 (gdb_exception_error::gdb_exception_error(enum errors, const char
10985 *, va_list)): New.
10986 (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
10987 Add assertion.
10988 (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
10989 errors)): Delete.
10990 (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
10991 (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
10992 Add assertion.
10993
eedc3f4f
TT		 109942019-04-08 Tom Tromey <tom@tromey.com>
10995
10996 * valops.c (value_rtti_indirect_type): Replace throw_exception
10997 with throw.
10998 * tracefile-tfile.c (tfile_target_open): Replace throw_exception
10999 with throw.
11000 * thread.c (thr_try_catch_cmd): Replace throw_exception with
11001 throw.
11002 * target.c (target_translate_tls_address): Replace throw_exception
11003 with throw.
11004 * stack.c (frame_apply_command_count): Replace throw_exception
11005 with throw.
11006 * solib-spu.c (append_ocl_sos): Replace throw_exception with
11007 throw.
11008 * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
11009 with throw.
11010 * rs6000-tdep.c (rs6000_frame_cache)
11011 (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
11012 * remote.c: Replace throw_exception with throw.
11013 * record-full.c (record_full_message, record_full_wait_1)
11014 (record_full_restore): Replace throw_exception with throw.
11015 * record-btrace.c:
11016 (get_thread_current_frame_id, record_btrace_start_replaying)
11017 (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
11018 (cmd_record_btrace_start): Replace throw_exception with throw.
11019 * parse.c (parse_exp_in_context_1): Replace throw_exception with
11020 throw.
11021 * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
11022 (resume_stopped_resumed_lwps): Replace throw_exception with throw.
11023 * linespec.c:
11024 (find_linespec_symbols): Replace throw_exception with throw.
11025 * infrun.c (displaced_step_prepare, resume): Replace
11026 throw_exception with throw.
11027 * infcmd.c (post_create_inferior): Replace throw_exception with
11028 throw.
11029 * inf-loop.c (inferior_event_handler): Replace throw_exception
11030 with throw.
11031 * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
11032 (i386_sigtramp_frame_cache): Replace throw_exception with throw.
11033 * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
11034 (get_prev_frame_always, get_frame_pc_if_available)
11035 (get_frame_address_in_block_if_available, get_frame_language):
11036 Replace throw_exception with throw.
11037 * frame-unwind.c (frame_unwind_try_unwinder): Replace
11038 throw_exception with throw.
11039 * eval.c (fetch_subexp_value, evaluate_var_value)
11040 (evaluate_funcall, evaluate_subexp_standard): Replace
11041 throw_exception with throw.
11042 * dwarf2loc.c (call_site_find_chain)
11043 (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
11044 Replace throw_exception with throw.
11045 * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
11046 with throw.
11047 * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
11048 throw.
11049 * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
11050 * completer.c (complete_line_internal): Replace throw_exception
11051 with throw.
11052 * compile/compile-object-run.c (compile_object_run): Replace
11053 throw_exception with throw.
11054 * cli/cli-script.c (process_next_line): Replace throw_exception
11055 with throw.
11056 * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
11057 (btrace_enable, btrace_maint_update_pt_packets): Replace
11058 throw_exception with throw.
11059 * breakpoint.c (create_breakpoint, save_breakpoints): Replace
11060 throw_exception with throw.
11061 * break-catch-throw.c (re_set_exception_catchpoint): Replace
11062 throw_exception with throw.
11063 * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
11064 (amd64_epilogue_frame_cache): Replace throw_exception with throw.
11065 * aarch64-tdep.c (aarch64_make_prologue_cache)
11066 (aarch64_make_stub_cache): Replace throw_exception with throw.
11067
26003a20
TT		 110682019-04-08 Tom Tromey <tom@tromey.com>
11069
11070 * common/common-exceptions.c (throw_exception): Rename from
11071 throw_exception_cxx. Remove old copy. Make argument const.
11072 (throw_it): Create and throw exception objects directly.
11073 * common/common-exceptions.h (throw_exception): Make argument
11074 const.
11075 (struct gdb_exception_error): Add constructor.
11076 (struct gdb_exception_quit): Add constructor.
11077
d272eb37
TT		 110782019-04-08 Tom Tromey <tom@tromey.com>
11079
11080 * common/common-exceptions.h (exception_rethrow): Don't declare.
11081 (TRY_SJLJ): Update comment.
11082 (TRY, CATCH, END_CATCH): Remove.
11083 * common/common-exceptions.c (exception_rethrow): Remove.
11084
230d2906
TT		 110852019-04-08 Tom Tromey <tom@tromey.com>
11086
11087 * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
11088 Remove.
11089 (gdb_exception_error): Rename from
11090 gdb_exception_RETURN_MASK_ERROR.
11091 (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
11092 (gdb_quit_bad_alloc): Update.
11093 * aarch64-tdep.c: Update.
11094 * ada-lang.c: Update.
11095 * ada-typeprint.c: Update.
11096 * ada-valprint.c: Update.
11097 * amd64-tdep.c: Update.
11098 * arch-utils.c: Update.
11099 * break-catch-throw.c: Update.
11100 * breakpoint.c: Update.
11101 * btrace.c: Update.
11102 * c-varobj.c: Update.
11103 * cli/cli-cmds.c: Update.
11104 * cli/cli-interp.c: Update.
11105 * cli/cli-script.c: Update.
11106 * common/common-exceptions.c: Update.
11107 * common/new-op.c: Update.
11108 * common/selftest.c: Update.
11109 * compile/compile-c-symbols.c: Update.
11110 * compile/compile-cplus-symbols.c: Update.
11111 * compile/compile-object-load.c: Update.
11112 * compile/compile-object-run.c: Update.
11113 * completer.c: Update.
11114 * corelow.c: Update.
11115 * cp-abi.c: Update.
11116 * cp-support.c: Update.
11117 * cp-valprint.c: Update.
11118 * darwin-nat.c: Update.
11119 * disasm-selftests.c: Update.
11120 * dtrace-probe.c: Update.
11121 * dwarf-index-cache.c: Update.
11122 * dwarf-index-write.c: Update.
11123 * dwarf2-frame-tailcall.c: Update.
11124 * dwarf2-frame.c: Update.
11125 * dwarf2loc.c: Update.
11126 * dwarf2read.c: Update.
11127 * eval.c: Update.
11128 * event-loop.c: Update.
11129 * event-top.c: Update.
11130 * exec.c: Update.
11131 * f-valprint.c: Update.
11132 * fbsd-tdep.c: Update.
11133 * frame-unwind.c: Update.
11134 * frame.c: Update.
11135 * gdbtypes.c: Update.
11136 * gnu-v3-abi.c: Update.
11137 * guile/guile-internal.h: Update.
11138 * guile/scm-block.c: Update.
11139 * guile/scm-breakpoint.c: Update.
11140 * guile/scm-cmd.c: Update.
11141 * guile/scm-disasm.c: Update.
11142 * guile/scm-frame.c: Update.
11143 * guile/scm-lazy-string.c: Update.
11144 * guile/scm-math.c: Update.
11145 * guile/scm-param.c: Update.
11146 * guile/scm-ports.c: Update.
11147 * guile/scm-pretty-print.c: Update.
11148 * guile/scm-symbol.c: Update.
11149 * guile/scm-symtab.c: Update.
11150 * guile/scm-type.c: Update.
11151 * guile/scm-value.c: Update.
11152 * i386-linux-tdep.c: Update.
11153 * i386-tdep.c: Update.
11154 * inf-loop.c: Update.
11155 * infcall.c: Update.
11156 * infcmd.c: Update.
11157 * infrun.c: Update.
11158 * jit.c: Update.
11159 * language.c: Update.
11160 * linespec.c: Update.
11161 * linux-fork.c: Update.
11162 * linux-nat.c: Update.
11163 * linux-tdep.c: Update.
11164 * linux-thread-db.c: Update.
11165 * main.c: Update.
11166 * mi/mi-cmd-break.c: Update.
11167 * mi/mi-cmd-stack.c: Update.
11168 * mi/mi-interp.c: Update.
11169 * mi/mi-main.c: Update.
11170 * objc-lang.c: Update.
11171 * p-valprint.c: Update.
11172 * parse.c: Update.
11173 * ppc-linux-tdep.c: Update.
11174 * printcmd.c: Update.
11175 * python/py-arch.c: Update.
11176 * python/py-breakpoint.c: Update.
11177 * python/py-cmd.c: Update.
11178 * python/py-finishbreakpoint.c: Update.
11179 * python/py-frame.c: Update.
11180 * python/py-framefilter.c: Update.
11181 * python/py-gdb-readline.c: Update.
11182 * python/py-inferior.c: Update.
11183 * python/py-infthread.c: Update.
11184 * python/py-lazy-string.c: Update.
11185 * python/py-linetable.c: Update.
11186 * python/py-objfile.c: Update.
11187 * python/py-param.c: Update.
11188 * python/py-prettyprint.c: Update.
11189 * python/py-progspace.c: Update.
11190 * python/py-record-btrace.c: Update.
11191 * python/py-record.c: Update.
11192 * python/py-symbol.c: Update.
11193 * python/py-type.c: Update.
11194 * python/py-unwind.c: Update.
11195 * python/py-utils.c: Update.
11196 * python/py-value.c: Update.
11197 * python/python.c: Update.
11198 * record-btrace.c: Update.
11199 * record-full.c: Update.
11200 * remote-fileio.c: Update.
11201 * remote.c: Update.
11202 * riscv-tdep.c: Update.
11203 * rs6000-aix-tdep.c: Update.
11204 * rs6000-tdep.c: Update.
11205 * rust-exp.y: Update.
11206 * rust-lang.c: Update.
11207 * s390-tdep.c: Update.
11208 * selftest-arch.c: Update.
11209 * solib-dsbt.c: Update.
11210 * solib-frv.c: Update.
11211 * solib-spu.c: Update.
11212 * solib-svr4.c: Update.
11213 * solib.c: Update.
11214 * sparc64-linux-tdep.c: Update.
11215 * stack.c: Update.
11216 * symfile-mem.c: Update.
11217 * symmisc.c: Update.
11218 * target.c: Update.
11219 * thread.c: Update.
11220 * top.c: Update.
11221 * tracefile-tfile.c: Update.
11222 * tui/tui.c: Update.
11223 * typeprint.c: Update.
11224 * unittests/cli-utils-selftests.c: Update.
11225 * unittests/parse-connection-spec-selftests.c: Update.
11226 * valops.c: Update.
11227 * valprint.c: Update.
11228 * value.c: Update.
11229 * varobj.c: Update.
11230 * windows-nat.c: Update.
11231 * x86-linux-nat.c: Update.
11232 * xml-support.c: Update.
11233
a70b8144
TT		 112342019-04-08 Tom Tromey <tom@tromey.com>
11235
11236 * xml-support.c: Use C++ exception handling.
11237 * x86-linux-nat.c: Use C++ exception handling.
11238 * windows-nat.c: Use C++ exception handling.
11239 * varobj.c: Use C++ exception handling.
11240 * value.c: Use C++ exception handling.
11241 * valprint.c: Use C++ exception handling.
11242 * valops.c: Use C++ exception handling.
11243 * unittests/parse-connection-spec-selftests.c: Use C++ exception
11244 handling.
11245 * unittests/cli-utils-selftests.c: Use C++ exception handling.
11246 * typeprint.c: Use C++ exception handling.
11247 * tui/tui.c: Use C++ exception handling.
11248 * tracefile-tfile.c: Use C++ exception handling.
11249 * top.c: Use C++ exception handling.
11250 * thread.c: Use C++ exception handling.
11251 * target.c: Use C++ exception handling.
11252 * symmisc.c: Use C++ exception handling.
11253 * symfile-mem.c: Use C++ exception handling.
11254 * stack.c: Use C++ exception handling.
11255 * sparc64-linux-tdep.c: Use C++ exception handling.
11256 * solib.c: Use C++ exception handling.
11257 * solib-svr4.c: Use C++ exception handling.
11258 * solib-spu.c: Use C++ exception handling.
11259 * solib-frv.c: Use C++ exception handling.
11260 * solib-dsbt.c: Use C++ exception handling.
11261 * selftest-arch.c: Use C++ exception handling.
11262 * s390-tdep.c: Use C++ exception handling.
11263 * rust-lang.c: Use C++ exception handling.
11264 * rust-exp.y: Use C++ exception handling.
11265 * rs6000-tdep.c: Use C++ exception handling.
11266 * rs6000-aix-tdep.c: Use C++ exception handling.
11267 * riscv-tdep.c: Use C++ exception handling.
11268 * remote.c: Use C++ exception handling.
11269 * remote-fileio.c: Use C++ exception handling.
11270 * record-full.c: Use C++ exception handling.
11271 * record-btrace.c: Use C++ exception handling.
11272 * python/python.c: Use C++ exception handling.
11273 * python/py-value.c: Use C++ exception handling.
11274 * python/py-utils.c: Use C++ exception handling.
11275 * python/py-unwind.c: Use C++ exception handling.
11276 * python/py-type.c: Use C++ exception handling.
11277 * python/py-symbol.c: Use C++ exception handling.
11278 * python/py-record.c: Use C++ exception handling.
11279 * python/py-record-btrace.c: Use C++ exception handling.
11280 * python/py-progspace.c: Use C++ exception handling.
11281 * python/py-prettyprint.c: Use C++ exception handling.
11282 * python/py-param.c: Use C++ exception handling.
11283 * python/py-objfile.c: Use C++ exception handling.
11284 * python/py-linetable.c: Use C++ exception handling.
11285 * python/py-lazy-string.c: Use C++ exception handling.
11286 * python/py-infthread.c: Use C++ exception handling.
11287 * python/py-inferior.c: Use C++ exception handling.
11288 * python/py-gdb-readline.c: Use C++ exception handling.
11289 * python/py-framefilter.c: Use C++ exception handling.
11290 * python/py-frame.c: Use C++ exception handling.
11291 * python/py-finishbreakpoint.c: Use C++ exception handling.
11292 * python/py-cmd.c: Use C++ exception handling.
11293 * python/py-breakpoint.c: Use C++ exception handling.
11294 * python/py-arch.c: Use C++ exception handling.
11295 * printcmd.c: Use C++ exception handling.
11296 * ppc-linux-tdep.c: Use C++ exception handling.
11297 * parse.c: Use C++ exception handling.
11298 * p-valprint.c: Use C++ exception handling.
11299 * objc-lang.c: Use C++ exception handling.
11300 * mi/mi-main.c: Use C++ exception handling.
11301 * mi/mi-interp.c: Use C++ exception handling.
11302 * mi/mi-cmd-stack.c: Use C++ exception handling.
11303 * mi/mi-cmd-break.c: Use C++ exception handling.
11304 * main.c: Use C++ exception handling.
11305 * linux-thread-db.c: Use C++ exception handling.
11306 * linux-tdep.c: Use C++ exception handling.
11307 * linux-nat.c: Use C++ exception handling.
11308 * linux-fork.c: Use C++ exception handling.
11309 * linespec.c: Use C++ exception handling.
11310 * language.c: Use C++ exception handling.
11311 * jit.c: Use C++ exception handling.
11312 * infrun.c: Use C++ exception handling.
11313 * infcmd.c: Use C++ exception handling.
11314 * infcall.c: Use C++ exception handling.
11315 * inf-loop.c: Use C++ exception handling.
11316 * i386-tdep.c: Use C++ exception handling.
11317 * i386-linux-tdep.c: Use C++ exception handling.
11318 * guile/scm-value.c: Use C++ exception handling.
11319 * guile/scm-type.c: Use C++ exception handling.
11320 * guile/scm-symtab.c: Use C++ exception handling.
11321 * guile/scm-symbol.c: Use C++ exception handling.
11322 * guile/scm-pretty-print.c: Use C++ exception handling.
11323 * guile/scm-ports.c: Use C++ exception handling.
11324 * guile/scm-param.c: Use C++ exception handling.
11325 * guile/scm-math.c: Use C++ exception handling.
11326 * guile/scm-lazy-string.c: Use C++ exception handling.
11327 * guile/scm-frame.c: Use C++ exception handling.
11328 * guile/scm-disasm.c: Use C++ exception handling.
11329 * guile/scm-cmd.c: Use C++ exception handling.
11330 * guile/scm-breakpoint.c: Use C++ exception handling.
11331 * guile/scm-block.c: Use C++ exception handling.
11332 * guile/guile-internal.h: Use C++ exception handling.
11333 * gnu-v3-abi.c: Use C++ exception handling.
11334 * gdbtypes.c: Use C++ exception handling.
11335 * frame.c: Use C++ exception handling.
11336 * frame-unwind.c: Use C++ exception handling.
11337 * fbsd-tdep.c: Use C++ exception handling.
11338 * f-valprint.c: Use C++ exception handling.
11339 * exec.c: Use C++ exception handling.
11340 * event-top.c: Use C++ exception handling.
11341 * event-loop.c: Use C++ exception handling.
11342 * eval.c: Use C++ exception handling.
11343 * dwarf2read.c: Use C++ exception handling.
11344 * dwarf2loc.c: Use C++ exception handling.
11345 * dwarf2-frame.c: Use C++ exception handling.
11346 * dwarf2-frame-tailcall.c: Use C++ exception handling.
11347 * dwarf-index-write.c: Use C++ exception handling.
11348 * dwarf-index-cache.c: Use C++ exception handling.
11349 * dtrace-probe.c: Use C++ exception handling.
11350 * disasm-selftests.c: Use C++ exception handling.
11351 * darwin-nat.c: Use C++ exception handling.
11352 * cp-valprint.c: Use C++ exception handling.
11353 * cp-support.c: Use C++ exception handling.
11354 * cp-abi.c: Use C++ exception handling.
11355 * corelow.c: Use C++ exception handling.
11356 * completer.c: Use C++ exception handling.
11357 * compile/compile-object-run.c: Use C++ exception handling.
11358 * compile/compile-object-load.c: Use C++ exception handling.
11359 * compile/compile-cplus-symbols.c: Use C++ exception handling.
11360 * compile/compile-c-symbols.c: Use C++ exception handling.
11361 * common/selftest.c: Use C++ exception handling.
11362 * common/new-op.c: Use C++ exception handling.
11363 * cli/cli-script.c: Use C++ exception handling.
11364 * cli/cli-interp.c: Use C++ exception handling.
11365 * cli/cli-cmds.c: Use C++ exception handling.
11366 * c-varobj.c: Use C++ exception handling.
11367 * btrace.c: Use C++ exception handling.
11368 * breakpoint.c: Use C++ exception handling.
11369 * break-catch-throw.c: Use C++ exception handling.
11370 * arch-utils.c: Use C++ exception handling.
11371 * amd64-tdep.c: Use C++ exception handling.
11372 * ada-valprint.c: Use C++ exception handling.
11373 * ada-typeprint.c: Use C++ exception handling.
11374 * ada-lang.c: Use C++ exception handling.
11375 * aarch64-tdep.c: Use C++ exception handling.
11376
3d6e9d23
TT		 113772019-04-08 Tom Tromey <tom@tromey.com>
11378
11379 * xml-support.c (gdb_xml_parser::parse): Update.
11380 * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
11381 * value.c (show_convenience): Update.
11382 * unittests/cli-utils-selftests.c (test_number_or_range_parser)
11383 (test_parse_flags_qcs): Update.
11384 * thread.c (thr_try_catch_cmd): Update.
11385 * target.c (target_translate_tls_address): Update.
11386 * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
11387 (info_frame_command_core, frame_apply_command_count): Update.
11388 * rust-exp.y (rust_lex_exception_test): Update.
11389 * riscv-tdep.c (riscv_print_one_register_info): Update.
11390 * remote.c (remote_target::enable_btrace): Update.
11391 * record-btrace.c (record_btrace_enable_warn): Update.
11392 * python/py-utils.c (gdbpy_convert_exception): Update.
11393 * printcmd.c (do_one_display, print_variable_and_value): Update.
11394 * mi/mi-main.c (mi_print_exception): Update.
11395 * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
11396 * mi/mi-cmd-stack.c (list_arg_or_local): Update.
11397 * linux-nat.c (linux_nat_target::attach): Update.
11398 * linux-fork.c (class scoped_switch_fork_info): Update.
11399 * infrun.c (displaced_step_prepare): Update.
11400 * infcall.c (call_function_by_hand_dummy): Update.
11401 * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
11402 * gnu-v3-abi.c (print_one_vtable): Update.
11403 * frame.c (get_prev_frame_always): Update.
11404 * f-valprint.c (info_common_command_for_block): Update.
11405 * exec.c (try_open_exec_file): Update.
11406 * exceptions.c (print_exception, exception_print)
11407 (exception_fprintf, exception_print_same): Update.
11408 * dwarf2-frame.c (dwarf2_build_frame_info): Update.
11409 * dwarf-index-cache.c (index_cache::store)
11410 (index_cache::lookup_gdb_index): Update.
11411 * darwin-nat.c (maybe_cache_shell): Update.
11412 * cp-valprint.c (cp_print_value_fields): Update.
11413 * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
11414 (gcc_cplus_symbol_address): Update.
11415 * compile/compile-c-symbols.c (gcc_convert_symbol)
11416 (gcc_symbol_address, generate_c_for_for_one_variable): Update.
11417 * common/selftest.c: Update.
11418 * common/common-exceptions.h (struct gdb_exception) <message>: Now
11419 a std::string.
11420 (exception_try_scope_entry, exception_try_scope_exit): Don't
11421 declare.
11422 (struct exception_try_scope): Remove.
11423 (TRY): Don't use exception_try_scope.
11424 (struct gdb_exception): Add constructor, operator=.
11425 <what>: New method.
11426 (struct gdb_exception_RETURN_MASK_ALL)
11427 (struct gdb_exception_RETURN_MASK_ERROR)
11428 (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
11429 (struct gdb_quit_bad_alloc): Update.
11430 * common/common-exceptions.c (exception_none): Change
11431 initializer.
11432 (struct catcher) <state, exception>: Initialize inline.
11433 <prev>: Remove member.
11434 (current_catcher): Remove.
11435 (catchers): New global.
11436 (exceptions_state_mc_init): Simplify.
11437 (catcher_pop): Remove.
11438 (exceptions_state_mc, exceptions_state_mc_catch): Update.
11439 (try_scope_depth, exception_try_scope_entry)
11440 (exception_try_scope_exit): Remove.
11441 (throw_exception_sjlj): Update.
11442 (exception_messages, exception_messages_size): Remove.
11443 (throw_it): Simplify.
11444 (gdb_exception_sliced_copy): Remove.
11445 (throw_exception_cxx): Update.
11446 * cli/cli-script.c (script_from_file): Update.
11447 * breakpoint.c (insert_bp_location, update_breakpoint_locations):
11448 Update.
11449 * ada-valprint.c (ada_val_print): Update.
11450 * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
11451 (create_excep_cond_exprs): Update.
11452
c5c10118
TT		 114532019-04-08 Tom Tromey <tom@tromey.com>
11454
11455 * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
11456 (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
11457 (TRY, CATCH, END_CATCH): Remove some definitions.
11458 * common/common-exceptions.c: Don't use GDB_XCPT.
11459 (catcher_list_size): Remove.
11460 (throw_exception, throw_it): Simplify.
11461
4de283e4
TT		 114622019-04-05 Tom Tromey <tom@tromey.com>
11463
11464 Revert the header-sorting patch.
11465 * ft32-tdep.c: Revert.
11466 * frv-tdep.c: Revert.
11467 * frv-linux-tdep.c: Revert.
11468 * frame.c: Revert.
11469 * frame-unwind.c: Revert.
11470 * frame-base.c: Revert.
11471 * fork-child.c: Revert.
11472 * findvar.c: Revert.
11473 * findcmd.c: Revert.
11474 * filesystem.c: Revert.
11475 * filename-seen-cache.h: Revert.
11476 * filename-seen-cache.c: Revert.
11477 * fbsd-tdep.c: Revert.
11478 * fbsd-nat.h: Revert.
11479 * fbsd-nat.c: Revert.
11480 * f-valprint.c: Revert.
11481 * f-typeprint.c: Revert.
11482 * f-lang.c: Revert.
11483 * extension.h: Revert.
11484 * extension.c: Revert.
11485 * extension-priv.h: Revert.
11486 * expprint.c: Revert.
11487 * exec.h: Revert.
11488 * exec.c: Revert.
11489 * exceptions.c: Revert.
11490 * event-top.c: Revert.
11491 * event-loop.c: Revert.
11492 * eval.c: Revert.
11493 * elfread.c: Revert.
11494 * dwarf2read.h: Revert.
11495 * dwarf2read.c: Revert.
11496 * dwarf2loc.c: Revert.
11497 * dwarf2expr.h: Revert.
11498 * dwarf2expr.c: Revert.
11499 * dwarf2-frame.c: Revert.
11500 * dwarf2-frame-tailcall.c: Revert.
11501 * dwarf-index-write.h: Revert.
11502 * dwarf-index-write.c: Revert.
11503 * dwarf-index-common.c: Revert.
11504 * dwarf-index-cache.h: Revert.
11505 * dwarf-index-cache.c: Revert.
11506 * dummy-frame.c: Revert.
11507 * dtrace-probe.c: Revert.
11508 * disasm.h: Revert.
11509 * disasm.c: Revert.
11510 * disasm-selftests.c: Revert.
11511 * dictionary.c: Revert.
11512 * dicos-tdep.c: Revert.
11513 * demangle.c: Revert.
11514 * dcache.h: Revert.
11515 * dcache.c: Revert.
11516 * darwin-nat.h: Revert.
11517 * darwin-nat.c: Revert.
11518 * darwin-nat-info.c: Revert.
11519 * d-valprint.c: Revert.
11520 * d-namespace.c: Revert.
11521 * d-lang.c: Revert.
11522 * ctf.c: Revert.
11523 * csky-tdep.c: Revert.
11524 * csky-linux-tdep.c: Revert.
11525 * cris-tdep.c: Revert.
11526 * cris-linux-tdep.c: Revert.
11527 * cp-valprint.c: Revert.
11528 * cp-support.c: Revert.
11529 * cp-namespace.c: Revert.
11530 * cp-abi.c: Revert.
11531 * corelow.c: Revert.
11532 * corefile.c: Revert.
11533 * continuations.c: Revert.
11534 * completer.h: Revert.
11535 * completer.c: Revert.
11536 * complaints.c: Revert.
11537 * coffread.c: Revert.
11538 * coff-pe-read.c: Revert.
11539 * cli-out.h: Revert.
11540 * cli-out.c: Revert.
11541 * charset.c: Revert.
11542 * c-varobj.c: Revert.
11543 * c-valprint.c: Revert.
11544 * c-typeprint.c: Revert.
11545 * c-lang.c: Revert.
11546 * buildsym.c: Revert.
11547 * buildsym-legacy.c: Revert.
11548 * build-id.h: Revert.
11549 * build-id.c: Revert.
11550 * btrace.c: Revert.
11551 * bsd-uthread.c: Revert.
11552 * breakpoint.h: Revert.
11553 * breakpoint.c: Revert.
11554 * break-catch-throw.c: Revert.
11555 * break-catch-syscall.c: Revert.
11556 * break-catch-sig.c: Revert.
11557 * blockframe.c: Revert.
11558 * block.c: Revert.
11559 * bfin-tdep.c: Revert.
11560 * bfin-linux-tdep.c: Revert.
11561 * bfd-target.c: Revert.
11562 * bcache.c: Revert.
11563 * ax-general.c: Revert.
11564 * ax-gdb.h: Revert.
11565 * ax-gdb.c: Revert.
11566 * avr-tdep.c: Revert.
11567 * auxv.c: Revert.
11568 * auto-load.c: Revert.
11569 * arm-wince-tdep.c: Revert.
11570 * arm-tdep.c: Revert.
11571 * arm-symbian-tdep.c: Revert.
11572 * arm-pikeos-tdep.c: Revert.
11573 * arm-obsd-tdep.c: Revert.
11574 * arm-nbsd-tdep.c: Revert.
11575 * arm-nbsd-nat.c: Revert.
11576 * arm-linux-tdep.c: Revert.
11577 * arm-linux-nat.c: Revert.
11578 * arm-fbsd-tdep.c: Revert.
11579 * arm-fbsd-nat.c: Revert.
11580 * arm-bsd-tdep.c: Revert.
11581 * arch-utils.c: Revert.
11582 * arc-tdep.c: Revert.
11583 * arc-newlib-tdep.c: Revert.
11584 * annotate.h: Revert.
11585 * annotate.c: Revert.
11586 * amd64-windows-tdep.c: Revert.
11587 * amd64-windows-nat.c: Revert.
11588 * amd64-tdep.c: Revert.
11589 * amd64-sol2-tdep.c: Revert.
11590 * amd64-obsd-tdep.c: Revert.
11591 * amd64-obsd-nat.c: Revert.
11592 * amd64-nbsd-tdep.c: Revert.
11593 * amd64-nbsd-nat.c: Revert.
11594 * amd64-nat.c: Revert.
11595 * amd64-linux-tdep.c: Revert.
11596 * amd64-linux-nat.c: Revert.
11597 * amd64-fbsd-tdep.c: Revert.
11598 * amd64-fbsd-nat.c: Revert.
11599 * amd64-dicos-tdep.c: Revert.
11600 * amd64-darwin-tdep.c: Revert.
11601 * amd64-bsd-nat.c: Revert.
11602 * alpha-tdep.c: Revert.
11603 * alpha-obsd-tdep.c: Revert.
11604 * alpha-nbsd-tdep.c: Revert.
11605 * alpha-mdebug-tdep.c: Revert.
11606 * alpha-linux-tdep.c: Revert.
11607 * alpha-linux-nat.c: Revert.
11608 * alpha-bsd-tdep.c: Revert.
11609 * alpha-bsd-nat.c: Revert.
11610 * aix-thread.c: Revert.
11611 * agent.c: Revert.
11612 * addrmap.c: Revert.
11613 * ada-varobj.c: Revert.
11614 * ada-valprint.c: Revert.
11615 * ada-typeprint.c: Revert.
11616 * ada-tasks.c: Revert.
11617 * ada-lang.c: Revert.
11618 * aarch64-tdep.c: Revert.
11619 * aarch64-ravenscar-thread.c: Revert.
11620 * aarch64-newlib-tdep.c: Revert.
11621 * aarch64-linux-tdep.c: Revert.
11622 * aarch64-linux-nat.c: Revert.
11623 * aarch64-fbsd-tdep.c: Revert.
11624 * aarch64-fbsd-nat.c: Revert.
11625 * aarch32-linux-nat.c: Revert.
11626
d55e5aa6
TT		 116272019-04-05 Tom Tromey <tom@tromey.com>
11628
11629 * ft32-tdep.c: Sort headers.
11630 * frv-tdep.c: Sort headers.
11631 * frv-linux-tdep.c: Sort headers.
11632 * frame.c: Sort headers.
11633 * frame-unwind.c: Sort headers.
11634 * frame-base.c: Sort headers.
11635 * fork-child.c: Sort headers.
11636 * findvar.c: Sort headers.
11637 * findcmd.c: Sort headers.
11638 * filesystem.c: Sort headers.
11639 * filename-seen-cache.h: Sort headers.
11640 * filename-seen-cache.c: Sort headers.
11641 * fbsd-tdep.c: Sort headers.
11642 * fbsd-nat.h: Sort headers.
11643 * fbsd-nat.c: Sort headers.
11644 * f-valprint.c: Sort headers.
11645 * f-typeprint.c: Sort headers.
11646 * f-lang.c: Sort headers.
11647 * extension.h: Sort headers.
11648 * extension.c: Sort headers.
11649 * extension-priv.h: Sort headers.
11650 * expprint.c: Sort headers.
11651 * exec.h: Sort headers.
11652 * exec.c: Sort headers.
11653 * exceptions.c: Sort headers.
11654 * event-top.c: Sort headers.
11655 * event-loop.c: Sort headers.
11656 * eval.c: Sort headers.
11657 * elfread.c: Sort headers.
11658 * dwarf2read.h: Sort headers.
11659 * dwarf2read.c: Sort headers.
11660 * dwarf2loc.c: Sort headers.
11661 * dwarf2expr.h: Sort headers.
11662 * dwarf2expr.c: Sort headers.
11663 * dwarf2-frame.c: Sort headers.
11664 * dwarf2-frame-tailcall.c: Sort headers.
11665 * dwarf-index-write.h: Sort headers.
11666 * dwarf-index-write.c: Sort headers.
11667 * dwarf-index-common.c: Sort headers.
11668 * dwarf-index-cache.h: Sort headers.
11669 * dwarf-index-cache.c: Sort headers.
11670 * dummy-frame.c: Sort headers.
11671 * dtrace-probe.c: Sort headers.
11672 * disasm.h: Sort headers.
11673 * disasm.c: Sort headers.
11674 * disasm-selftests.c: Sort headers.
11675 * dictionary.c: Sort headers.
11676 * dicos-tdep.c: Sort headers.
11677 * demangle.c: Sort headers.
11678 * dcache.h: Sort headers.
11679 * dcache.c: Sort headers.
11680 * darwin-nat.h: Sort headers.
11681 * darwin-nat.c: Sort headers.
11682 * darwin-nat-info.c: Sort headers.
11683 * d-valprint.c: Sort headers.
11684 * d-namespace.c: Sort headers.
11685 * d-lang.c: Sort headers.
11686 * ctf.c: Sort headers.
11687 * csky-tdep.c: Sort headers.
11688 * csky-linux-tdep.c: Sort headers.
11689 * cris-tdep.c: Sort headers.
11690 * cris-linux-tdep.c: Sort headers.
11691 * cp-valprint.c: Sort headers.
11692 * cp-support.c: Sort headers.
11693 * cp-namespace.c: Sort headers.
11694 * cp-abi.c: Sort headers.
11695 * corelow.c: Sort headers.
11696 * corefile.c: Sort headers.
11697 * continuations.c: Sort headers.
11698 * completer.h: Sort headers.
11699 * completer.c: Sort headers.
11700 * complaints.c: Sort headers.
11701 * coffread.c: Sort headers.
11702 * coff-pe-read.c: Sort headers.
11703 * cli-out.h: Sort headers.
11704 * cli-out.c: Sort headers.
11705 * charset.c: Sort headers.
11706 * c-varobj.c: Sort headers.
11707 * c-valprint.c: Sort headers.
11708 * c-typeprint.c: Sort headers.
11709 * c-lang.c: Sort headers.
11710 * buildsym.c: Sort headers.
11711 * buildsym-legacy.c: Sort headers.
11712 * build-id.h: Sort headers.
11713 * build-id.c: Sort headers.
11714 * btrace.c: Sort headers.
11715 * bsd-uthread.c: Sort headers.
11716 * breakpoint.h: Sort headers.
11717 * breakpoint.c: Sort headers.
11718 * break-catch-throw.c: Sort headers.
11719 * break-catch-syscall.c: Sort headers.
11720 * break-catch-sig.c: Sort headers.
11721 * blockframe.c: Sort headers.
11722 * block.c: Sort headers.
11723 * bfin-tdep.c: Sort headers.
11724 * bfin-linux-tdep.c: Sort headers.
11725 * bfd-target.c: Sort headers.
11726 * bcache.c: Sort headers.
11727 * ax-general.c: Sort headers.
11728 * ax-gdb.h: Sort headers.
11729 * ax-gdb.c: Sort headers.
11730 * avr-tdep.c: Sort headers.
11731 * auxv.c: Sort headers.
11732 * auto-load.c: Sort headers.
11733 * arm-wince-tdep.c: Sort headers.
11734 * arm-tdep.c: Sort headers.
11735 * arm-symbian-tdep.c: Sort headers.
11736 * arm-pikeos-tdep.c: Sort headers.
11737 * arm-obsd-tdep.c: Sort headers.
11738 * arm-nbsd-tdep.c: Sort headers.
11739 * arm-nbsd-nat.c: Sort headers.
11740 * arm-linux-tdep.c: Sort headers.
11741 * arm-linux-nat.c: Sort headers.
11742 * arm-fbsd-tdep.c: Sort headers.
11743 * arm-fbsd-nat.c: Sort headers.
11744 * arm-bsd-tdep.c: Sort headers.
11745 * arch-utils.c: Sort headers.
11746 * arc-tdep.c: Sort headers.
11747 * arc-newlib-tdep.c: Sort headers.
11748 * annotate.h: Sort headers.
11749 * annotate.c: Sort headers.
11750 * amd64-windows-tdep.c: Sort headers.
11751 * amd64-windows-nat.c: Sort headers.
11752 * amd64-tdep.c: Sort headers.
11753 * amd64-sol2-tdep.c: Sort headers.
11754 * amd64-obsd-tdep.c: Sort headers.
11755 * amd64-obsd-nat.c: Sort headers.
11756 * amd64-nbsd-tdep.c: Sort headers.
11757 * amd64-nbsd-nat.c: Sort headers.
11758 * amd64-nat.c: Sort headers.
11759 * amd64-linux-tdep.c: Sort headers.
11760 * amd64-linux-nat.c: Sort headers.
11761 * amd64-fbsd-tdep.c: Sort headers.
11762 * amd64-fbsd-nat.c: Sort headers.
11763 * amd64-dicos-tdep.c: Sort headers.
11764 * amd64-darwin-tdep.c: Sort headers.
11765 * amd64-bsd-nat.c: Sort headers.
11766 * alpha-tdep.c: Sort headers.
11767 * alpha-obsd-tdep.c: Sort headers.
11768 * alpha-nbsd-tdep.c: Sort headers.
11769 * alpha-mdebug-tdep.c: Sort headers.
11770 * alpha-linux-tdep.c: Sort headers.
11771 * alpha-linux-nat.c: Sort headers.
11772 * alpha-bsd-tdep.c: Sort headers.
11773 * alpha-bsd-nat.c: Sort headers.
11774 * aix-thread.c: Sort headers.
11775 * agent.c: Sort headers.
11776 * addrmap.c: Sort headers.
11777 * ada-varobj.c: Sort headers.
11778 * ada-valprint.c: Sort headers.
11779 * ada-typeprint.c: Sort headers.
11780 * ada-tasks.c: Sort headers.
11781 * ada-lang.c: Sort headers.
11782 * aarch64-tdep.c: Sort headers.
11783 * aarch64-ravenscar-thread.c: Sort headers.
11784 * aarch64-newlib-tdep.c: Sort headers.
11785 * aarch64-linux-tdep.c: Sort headers.
11786 * aarch64-linux-nat.c: Sort headers.
11787 * aarch64-fbsd-tdep.c: Sort headers.
11788 * aarch64-fbsd-nat.c: Sort headers.
11789 * aarch32-linux-nat.c: Sort headers.
11790
699bd4cf
TT		 117912019-04-04 Tom Tromey <tom@tromey.com>
11792
11793 * varobj.c (varobj_create): Update.
11794 * rust-exp.y (struct rust_parser) <update_innermost_block,
11795 lookup_symbol>: New methods.
11796 (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
11797 Rename.
11798 (rust_parser::rust_lookup_type)
11799 (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
11800 * printcmd.c (display_command, do_one_display): Update.
11801 * parser-defs.h (struct parser_state) <parser_state>: Add
11802 "tracker" parameter.
11803 (block_tracker): New member.
11804 (class innermost_block_tracker) <innermost_block_tracker>: Add
11805 "types" parameter.
11806 <reset>: Remove method.
11807 (innermost_block): Don't declare.
11808 (null_post_parser): Update.
11809 * parse.c (innermost_block): Remove global.
11810 (write_dollar_variable): Update.
11811 (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
11812 Remove "tracker_types" parameter.
11813 (parse_expression): Add "tracker" parameter.
11814 (parse_expression_for_completion): Update.
11815 (null_post_parser): Add "tracker" parameter.
11816 * p-exp.y: Update rules.
11817 * m2-exp.y: Update rules.
11818 * language.h (struct language_defn) <la_post_parser>: Add
11819 "tracker" parameter.
11820 * go-exp.y: Update rules.
11821 * f-exp.y: Update rules.
11822 * expression.h (parse_expression, parse_exp_1): Add "tracker"
11823 parameter.
11824 * d-exp.y: Update rules.
11825 * c-exp.y: Update rules.
11826 * breakpoint.c (set_breakpoint_condition): Create an
11827 innermost_block_tracker.
11828 (watch_command_1): Likewise.
11829 * ada-lang.c (resolve): Add "tracker" parameter.
11830 (resolve_subexp): Likewise.
11831 * ada-exp.y (write_var_from_sym): Update.
11832
dac43e32
TT		 118332019-04-04 Tom Tromey <tom@tromey.com>
11834
11835 * type-stack.h: New file.
11836 * type-stack.c: New file.
11837 * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
11838 type-stack.h.
11839 (insert_into_type_stack, insert_type, push_type, push_type_int)
11840 (insert_type_address_space, pop_type, pop_type_int)
11841 (pop_typelist, pop_type_stack, append_type_stack)
11842 (push_type_stack, get_type_stack, push_typelist)
11843 (follow_type_instance_flags, follow_types): Don't declare.
11844 * parse.c (type_stack): Remove global.
11845 (parse_exp_in_context): Update.
11846 (insert_into_type_stack, insert_type, push_type, push_type_int)
11847 (insert_type_address_space, pop_type, pop_type_int)
11848 (pop_typelist, pop_type_stack, append_type_stack)
11849 (push_type_stack, get_type_stack, push_typelist)
11850 (follow_type_instance_flags, follow_types): Remove (moved to
11851 type-stack.c).
11852 * f-exp.y (type_stack): New global.
11853 Update rules.
11854 (push_kind_type, f_parse): Update.
11855 * d-exp.y (type_stack): New global.
11856 Update rules.
11857 (d_parse): Update.
11858 * c-exp.y (struct c_parse_state) <type_stack>: New member.
11859 Update rules.
11860 * Makefile.in (COMMON_SFILES): Add type-stack.c.
11861 (HFILES_NO_SRCDIR): Add type-stack.h.
11862
2a612529
TT		 118632019-04-04 Tom Tromey <tom@tromey.com>
11864
11865 * rust-exp.y (rust_parser::lex_identifier, rustyylex)
11866 (rust_parser::convert_ast_to_expression, rust_parse)
11867 (rust_lex_test_completion, rust_lex_tests): Update.
11868 * parser-defs.h (struct expr_completion_state): New.
11869 (struct parser_state) <parser_state>: Add completion parameter.
11870 <mark_struct_expression, mark_completion_tag>: New methods.
11871 <parse_completion, m_completion_state>: New members.
11872 (prefixify_expression, null_post_parser): Update.
11873 (mark_struct_expression, mark_completion_tag): Don't declare.
11874 * parse.c (parse_completion, expout_last_struct)
11875 (expout_tag_completion_type, expout_completion_name): Remove
11876 globals.
11877 (parser_state::mark_struct_expression)
11878 (parser_state::mark_completion_tag): Now methods.
11879 (prefixify_expression): Add last_struct parameter.
11880 (prefixify_subexp): Likewise.
11881 (parse_exp_1): Update.
11882 (parse_exp_in_context): Add cstate parameter. Update.
11883 (parse_expression_for_completion): Create an
11884 expr_completion_state.
11885 (null_post_parser): Add "completion" parameter.
11886 * p-exp.y: Update rules.
11887 (yylex): Update.
11888 * language.h (struct language_defn) <la_post_parser>: Add
11889 "completing" parameter.
11890 * go-exp.y: Update rules.
11891 (lex_one_token): Update.
11892 * expression.h (parse_completion): Don't declare.
11893 * d-exp.y: Update rules.
11894 (lex_one_token): Update rules.
11895 * c-exp.y: Update rules.
11896 (lex_one_token): Update.
11897 * ada-lang.c (resolve): Add "parse_completion" parameter.
11898 (resolve_subexp): Likewise.
11899 (ada_resolve_function): Likewise.
11900
43476f0b
TT		 119012019-04-04 Tom Tromey <tom@tromey.com>
11902
11903 * parser-defs.h (struct parser_state) <start_arglist,
11904 end_arglist>: New methods.
11905 <arglist_len, m_funcall_chain>: New members.
11906 (arglist_len, start_arglist, end_arglist): Don't declare.
11907 * parse.c (arglist_len, funcall_chain): Remove global.
11908 (start_arglist, end_arglist): Remove functions.
11909 (parse_exp_in_context): Update.
11910 * p-exp.y: Update rules.
11911 * m2-exp.y: Update rules.
11912 * go-exp.y: Update rules.
11913 * f-exp.y: Update rules.
11914 * d-exp.y: Update rules.
11915 * c-exp.y: Update rules.
11916
5776fca3
TT		 119172019-04-04 Tom Tromey <tom@tromey.com>
11918
11919 * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
11920 lex_operator, push_back>: New methods.
11921 Update all rules.
11922 (rust_parser::lex_hex, lex_escape): Rename and update.
11923 (rust_parser::lex_string, rust_parser::lex_identifier): Update.
11924 (rust_parser::lex_operator): Rename and update.
11925 (rust_parser::lex_number, rustyylex, rustyyerror)
11926 (rust_lex_test_init, rust_lex_test_sequence)
11927 (rust_lex_test_push_back, rust_lex_tests): Update.
11928 * parser-defs.h (struct parser_state) <parser_state>: Add "input"
11929 parameter.
11930 <lexptr, prev_lexptr>: New members.
11931 (lexptr, prev_lexptr): Don't declare.
11932 * parse.c (lexptr, prev_lexptr): Remove globals.
11933 (parse_exp_in_context): Update.
11934 * p-exp.y (yylex, yyerror): Update.
11935 * m2-exp.y (parse_number, yylex, yyerror): Update.
11936 * go-exp.y (lex_one_token, yyerror): Update.
11937 * f-exp.y (match_string_literal, yylex, yyerror): Update.
11938 * d-exp.y (lex_one_token, yyerror): Update.
11939 * c-exp.y (scan_macro_expansion, finished_macro_expansion)
11940 (lex_one_token, yyerror): Update.
11941 * ada-lex.l (YY_INPUT): Update.
11942 (rewind_to_char): Update.
11943 * ada-exp.y (yyerror): Update.
11944
8621b685
TT		 119452019-04-04 Tom Tromey <tom@tromey.com>
11946
11947 * rust-exp.y (rustyylex, rust_lex_tests): Update.
11948 * parser-defs.h (struct parser_state) <parser_state>: Add new
11949 parameter.
11950 <comma_terminates>: New member.
11951 (comma_terminates): Don't declare global.
11952 * parse.c (comma_terminates): Remove global.
11953 (parse_exp_in_context): Update.
11954 * p-exp.y (yylex): Update.
11955 * m2-exp.y (yylex): Update.
11956 * go-exp.y (lex_one_token): Update.
11957 * f-exp.y (yylex): Update.
11958 * d-exp.y (lex_one_token): Update.
11959 * c-exp.y (lex_one_token): Update.
11960 * ada-lex.l: Update.
11961
28aaf3fd
TT		 119622019-04-04 Tom Tromey <tom@tromey.com>
11963
11964 * rust-exp.y (struct rust_parser) <paren_depth>: New member.
11965 (rustyylex, rust_lex_test_init, rust_lex_test_one)
11966 (rust_lex_test_sequence, rust_lex_test_push_back): Update.
11967 * parser-defs.h (paren_depth): Don't declare.
11968 * parse.c (paren_depth): Remove global.
11969 (parse_exp_in_context): Update.
11970 * p-exp.y (paren_depth): New global.
11971 (pascal_parse): Initialize it.
11972 * m2-exp.y (paren_depth): New global.
11973 (m2_parse): Initialize it.
11974 * go-exp.y (paren_depth): New global.
11975 (go_parse): Initialize it.
11976 * f-exp.y (paren_depth): New global.
11977 (f_parse): Initialize it.
11978 * d-exp.y (paren_depth): New global.
11979 (d_parse): Initialize it.
11980 * c-exp.y (paren_depth): New global.
11981 (c_parse): Initialize it.
11982 * ada-lex.l (paren_depth): New global.
11983 (lexer_init): Initialize it.
11984
1e58a4a4
TT		 119852019-04-04 Tom Tromey <tom@tromey.com>
11986
11987 * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
11988 (rust_parser::convert_ast_to_type)
11989 (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
11990 * parser-defs.h (struct parser_state) <parser_state>: Add
11991 parameters. Initialize new members.
11992 <expression_context_block, expression_context_pc>: New members.
11993 * parse.c (expression_context_block, expression_context_pc):
11994 Remove globals.
11995 (parse_exp_in_context): Update.
11996 * p-exp.y: Update all rules.
11997 (yylex): Update.
11998 * m2-exp.y: Update all rules.
11999 (yylex): Update.
12000 * go-exp.y (yylex): Update.
12001 * f-exp.y (yylex): Update.
12002 * d-exp.y: Update all rules.
12003 (yylex): Update.
12004 * c-exp.y: Update all rules.
12005 (lex_one_token, classify_name, yylex, c_parse): Update.
12006 * ada-exp.y (write_var_or_type, write_name_assoc): Update.
12007
37eedb39
TT		 120082019-04-04 Tom Tromey <tom@tromey.com>
12009
12010 * gdbarch.h, gdbarch.c: Rebuild.
12011 * gdbarch.sh (dtrace_parse_probe_argument): Change type.
12012 * stap-probe.h:
12013 (struct stap_parse_info): Replace "parser_state" with
12014 "expr_builder".
12015 * parser-defs.h (struct expr_builder): Rename from "parser_state".
12016 (parser_state): New class.
12017 * parse.c (expr_builder): Rename.
12018 (expr_builder::release): Rename.
12019 (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
12020 (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
12021 (write_exp_elt_longcst, write_exp_elt_floatcst)
12022 (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
12023 (write_exp_string_vector, write_exp_bitstring)
12024 (write_exp_msymbol, mark_struct_expression)
12025 (write_dollar_variable)
12026 (insert_type_address_space, increase_expout_size): Replace
12027 "parser_state" with "expr_builder".
12028 * dtrace-probe.c: Replace "parser_state" with "expr_builder".
12029 * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
12030 "parser_state" with "expr_builder".
12031
73923d7e
TT		 120322019-04-04 Tom Tromey <tom@tromey.com>
12033
12034 * rust-exp.y: Replace "parse_language" with method call.
12035 * p-exp.y:
12036 (yylex): Replace "parse_language" with method call.
12037 * m2-exp.y:
12038 (yylex): Replace "parse_language" with method call.
12039 * go-exp.y (classify_name): Replace "parse_language" with method
12040 call.
12041 * f-exp.y (yylex): Replace "parse_language" with method call.
12042 * d-exp.y (lex_one_token): Replace "parse_language" with method
12043 call.
12044 * c-exp.y:
12045 (lex_one_token, classify_name, yylex): Replace "parse_language"
12046 with method call.
12047 * ada-exp.y (find_primitive_type, type_char)
12048 (type_system_address): Replace "parse_language" with method call.
12049
fa9f5be6
TT		 120502019-04-04 Tom Tromey <tom@tromey.com>
12051
12052 * rust-exp.y: Replace "parse_gdbarch" with method call.
12053 * parse.c (write_dollar_variable, insert_type_address_space):
12054 Replace "parse_gdbarch" with method call.
12055 * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
12056 call.
12057 * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
12058 call.
12059 * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
12060 "parse_gdbarch" with method call.
12061 * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
12062 with method call.
12063 * f-exp.y (parse_type, parse_f_type, yylex): Replace
12064 "parse_gdbarch" with method call.
12065 * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
12066 "parse_gdbarch" with method call.
12067 * c-exp.y (parse_type, parse_number, classify_name): Replace
12068 "parse_gdbarch" with method call.
12069 * ada-lex.l: Replace "parse_gdbarch" with method call.
12070 * ada-exp.y (parse_type, find_primitive_type, type_char)
12071 (type_system_address): Replace "parse_gdbarch" with method call.
12072
1201a264
TT		 120732019-04-04 Tom Tromey <tom@tromey.com>
12074
12075 * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
12076 * stap-probe.c (stap_parse_argument): Update.
12077 * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
12078 initial_size parameter.
12079 * rust-exp.y (rust_lex_tests): Update.
12080 * parse.c (parser_state): Update.
12081 (parse_exp_in_context): Update.
12082 * parser-defs.h (struct parser_state) <parser_state>: Remove
12083 "initial_size" parameter.
12084
e3980ce2
TT		 120852019-04-04 Tom Tromey <tom@tromey.com>
12086
12087 * parser-defs.h (increase_expout_size): Don't declare.
12088 * parse.c (increase_expout_size): Now static.
12089
e9f8e3f1
TS		 120902019-04-04 Thomas Schwinge <thomas@codesourcery.com>
12091
12092 * gnu-nat.c (gnu_nat_target::wait): Fix
12093 target_waitstatus_to_string call.
12094
d7df6549
AB		 120952019-04-01 Andrew Burgess <andrew.burgess@embecosm.com>
12096
12097 * eval.c (evaluate_subexp_standard): Handle internal functions
12098 during Fortran function call handling.
12099
8bdc1658
AB		 121002019-04-01 Andrew Burgess <andrew.burgess@embecosm.com>
12101
12102 * NEWS: Mention new internal functions.
12103 * dwarf2read.c (dwarf2_init_complex_target_type): New function.
12104 (read_base_type): Use dwarf2_init_complex_target_type.
12105 * value.c (creal_internal_fn): New function.
12106 (cimag_internal_fn): New function.
12107 (_initialize_values): Register new internal functions.
12108
c29705b7
PW		 121092019-04-01 Philippe Waroquiers <philippe.waroquiers@skynet.be>
12110
12111 * infrun.c (stop_all_threads): If debug_infrun, always
12112 trace the wait status after wait_one, using
12113 target_waitstatus_to_string and target_pid_to_str.
12114 (handle_inferior_event): Replace various trace of
12115 wait status kind by a single trace.
12116 * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
12117 wait status kind image by target_waitstatus_to_string.
12118 * target/waitstatus.c (target_waitstatus_to_string): Fix
12119 obsolete comment.
12120
05caa1d2
TT		 121212019-04-01 Tom Tromey <tromey@adacore.com>
12122
12123 PR symtab/23331:
12124 * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
12125
9d1447e0
SDJ		 121262019-04-01 Sergio Durigan Junior <sergiodj@redhat.com>
12127 Pedro Alves <palves@redhat.com>
12128
12129 * top.c (quit_force): Call 'finalize_values'.
12130 * value.c (finalize_values): New function.
12131 * value.h (finalize_values): Declare.
12132
7734102d
EZ		 121332019-03-30 Eli Zaretskii <eliz@gnu.org>
12134
12135 * NEWS: Announce $_gdb_major and $_gdb_minor.
12136
12137 * top.c (init_gdb_version_vars): New function.
12138 (gdb_init): Call init_gdb_version_vars.
12139
188e1fa9
TT		 121402019-03-29 Tom Tromey <tromey@adacore.com>
12141
12142 * printcmd.c (_initialize_printcmd): Add usage lines. Update some
12143 help text. Remove dead code.
12144
2880242d
KS		 121452019-03-29 Keith Seitz <keiths@redhat.com>
12146
12147 From Siddhesh Poyarekar:
12148 * f-lang.h (f77_get_upperbound): Return LONGEST.
12149 (f77_get_lowerbound): Likewise.
12150 * f-typeprint.c (f_type_print_varspec_suffix): Expand
12151 UPPER_BOUND and LOWER_BOUND to LONGEST. Use plongest to format
12152 print them.
12153 (f_type_print_base): Expand UPPER_BOUND to LONGEST. Use
12154 plongest to format print it.
12155 * f-valprint.c (f77_get_lowerbound): Return LONGEST.
12156 (f77_get_upperbound): Likewise.
12157 (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
12158 LOWER_BOUND to LONGEST.
12159 (f77_create_arrayprint_offset_tbl): Likewise.
12160
cc1defb1
KS		 121612019-03-29 Keith Seitz <keiths@redhat.com>
12162
12163 * ada-lang.c (ada_template_to_fixed_record_type_1): Use
12164 %s/pulongest for TYPE_LENGTH instead of %d in format
12165 strings.
12166 * ada-typerint.c (ada_print_type): Likewise.
12167 * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
12168 * compile/compile-c-support.c (generate_register_struct): Likewise.
12169 * gdbtypes.c (recursive_dump_type): Likewise.
12170 * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
12171 * m2-typeprint.c (m2_array): Use %s/pulongest for TYPE_LENGTH
12172 instead of %d in format strings.
12173 * riscv-tdep.c (riscv_type_alignment): Cast second argument
12174 to std::min to ULONGEST.
12175 * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
12176 instead of %d in format strings.
12177 * tracepoint.c (info_scope_command): Likewise.
12178 * typeprint.c (print_offset_data::update)
12179 (print_offset_data::finish): Likewise.
12180 * xtensa-tdep.c (xtensa_store_return_value)
12181 (xtensa_push_dummy_call): Likewise.
12182
e432ccf1
JT		 121832019-03-28 Jon Turney <jon.turney@dronecode.org.uk>
12184
12185 * windows-nat.c (display_selector): Fixed format specifications
12186 for 64-bit Cygwin.
12187
65d2b333
PW		 121882019-03-28 Philippe Waroquiers <philippe.waroquiers@skynet.be>
12189
12190 * infrun.c (follow_exec): Call target_terminal::ours_for_output.
12191
f489207e
SL		 121922019-03-28 Sandra Loosemore <sandra@codesourcery.com>
12193
12194 * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
12195 * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
12196 * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
12197 (nios2_linux_init_abi): Install it.
12198
bffa1015
AH		 121992019-03-28 Alan Hayward <alan.hayward@arm.com>
12200
12201 * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
12202
fc96163a
AH		 122032019-03-28 Alan Hayward <alan.hayward@arm.com>
12204
12205 * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
12206
20dc7e9b
PW		 122072019-03-24 Philippe Waroquiers <philippe.waroquiers@skynet.be>
12208 Tom Tromey <tromey@adacore.com>
12209
12210 * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
12211
7f5331a8
JB		 122122019-03-26 Joel Brobecker <brobecker@adacore.com>
12213
12214 * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
12215 (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
12216 method to compute the bounds of range types. Also print "[evaluated]"
12217 if the bounds' values come from a dynamic evaluation.
12218
18c77628
AB		 122192019-03-26 Andrew Burgess <andrew.burgess@embecosm.com>
12220
12221 * cp-valprint.c (cp_print_value_fields): Don't print trailing
12222 whitespace when pretty printing is on.
12223
53c973f2
AH		 122242019-03-26 Alan Hayward <alan.hayward@arm.com>
12225
e79be6e5 12226 * ppc-linux-nat.c: Add include.
53c973f2 12227
d851aa71
AH		 122282019-03-26 Alan Hayward <alan.hayward@arm.com>
12229
e79be6e5 12230 * NEWS: Mention AArch64 Pointer Authentication.
d851aa71 12231
2fe7bab7
AH		 122322019-03-26 Alan Hayward <alan.hayward@arm.com>
12233
e79be6e5 12234 * arm-linux-nat.c: Add include.
2fe7bab7 12235
068ef30e
SM		 122362019-03-25 Simon Marchi <simon.marchi@polymtl.ca>
12237
12238 * source-cache.c (source_cache::get_source_lines): Re-read
12239 fullname after calling open_source_file.
12240
81a24d04
JB		 122412019-03-25 John Baldwin <jhb@FreeBSD.org>
12242
12243 * NEWS: Mention TLS support for FreeBSD.
12244
79e7ae11
TT		 122452019-03-25 Tom Tromey <tromey@adacore.com>
12246
12247 * minsyms.c (BUNCH_SIZE): Update comment.
12248 (~minimal_symbol_reader): Remove old comment.
12249 (compact_minimal_symbols): Update comment.
12250 (minimal_symbol_reader::install): Remove old comment. Update
12251 other comments.
12252
d45963c2
AH		 122532019-03-25 Alan Hayward <alan.hayward@arm.com>
12254
12255 * s390-linux-nat.c: Add include.
12256
0f83012e
AH		 122572019-03-25 Alan Hayward <alan.hayward@arm.com>
12258
12259 * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
12260 Call linux_get_hwcap.
12261 * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
12262 Likewise.
12263 (aarch64_linux_get_hwcap): Remove function.
12264 * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
12265 declaration.
12266 * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
12267 linux_get_hwcap.
12268 * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
12269 * linux-tdep.c (linux_get_hwcap): Add function.
12270 (linux_get_hwcap2): Likewise.
12271 * linux-tdep.h (linux_get_hwcap): Add declaration.
12272 (linux_get_hwcap2): Likewise.
12273 * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
12274 (ppc_linux_get_hwcap2): Likewise.
12275 (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
12276 linux_get_hwcap.
12277 (ppc_linux_nat_target::insert_watchpoint): Likewise.
12278 (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
12279 (ppc_linux_nat_target::read_description): Likewise.
12280 * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
12281 * s390-linux-nat.c: Likewise.
12282 * s390-linux-tdep.c (s390_core_read_description): Likewise.
12283
6640a367
TT		 122842019-03-24 Tom Tromey <tom@tromey.com>
12285
12286 * ada-lang.c (standard_lookup): Simplify initialization.
12287 (ada_lookup_symbol_nonlocal): Simplify return.
12288 * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
12289 * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
12290 * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
12291 * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
12292 initialization.
12293 * solib.c (solib_global_lookup): Simplify.
12294 * symtab.c (null_block_symbol): Remove.
12295 (symbol_cache_lookup): Simplify returns.
12296 (lookup_language_this): Simplify returns.
12297 (lookup_symbol_aux): Simplify return.
12298 (lookup_local_symbol): Simplify returns.
12299 (lookup_global_symbol_from_objfile): Simplify return.
12300 (lookup_symbol_in_objfile_symtabs)
12301 (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
12302 (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
12303 (lookup_static_symbol, lookup_global_symbol): Simplify return.
12304 * cp-namespace.c (cp_lookup_bare_symbol)
12305 (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
12306 (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
12307 (cp_lookup_nested_symbol): Don't use null_block_symbol.
12308 (cp_lookup_symbol_via_imports): Simplify initialization.
12309 (find_symbol_in_baseclass): Likewise.
12310 * symtab.h (null_block_symbol): Remove.
12311 * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
12312 (d_lookup_nested_symbol, d_lookup_symbol_imports)
12313 (d_lookup_symbol_module): Likewise.
12314 (find_symbol_in_baseclass): Simplify initialization.
12315
a930ebcd
TT		 123162019-03-24 Tom Tromey <tom@tromey.com>
12317
12318 * expression.h: Don't include symtab.h.
12319 (struct block): Forward declare.
12320
582942f4
TT		 123212019-03-24 Tom Tromey <tom@tromey.com>
12322
12323 * c-exp.y (typebase): Remove casts.
12324 * gdbtypes.c (lookup_unsigned_typename, )
12325 (lookup_signed_typename): Remove cast.
12326 * eval.c (parse_to_comma_and_eval): Remove cast.
12327 * parse.c (write_dollar_variable): Remove cast.
12328 * block.h (struct block) <superblock>: Now const.
12329 * symfile-debug.c (debug_qf_map_matching_symbols): Update.
12330 * psymtab.c (psym_map_matching_symbols): Make "block" const.
12331 (map_block): Make "block" const.
12332 * symfile.h (struct quick_symbol_functions)
12333 <map_matching_symbols>: Constify block argument to "callback".
12334 * symtab.c (basic_lookup_transparent_type_quick): Make "block"
12335 const.
12336 (find_pc_sect_compunit_symtab): Make "b" const.
12337 (find_symbol_at_address): Likewise.
12338 (search_symbols): Likewise.
12339 * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
12340 (dw2_debug_names_lookup_symbol): Likewise.
12341 (dw2_map_matching_symbols): Update.
12342 * p-valprint.c (pascal_val_print): Remove "block".
12343 * ada-lang.c (ada_add_global_exceptions): Make "b" const.
12344 (aux_add_nonlocal_symbols): Make "block" const.
12345 (resolve_subexp): Remove cast.
12346 * linespec.c (iterate_over_all_matching_symtabs): Make "block"
12347 const.
12348 (iterate_over_file_blocks): Likewise.
12349 * f-exp.y (%union) <bval>: Remove.
12350 * coffread.c (patch_opaque_types): Make "b" const.
12351 * spu-tdep.c (spu_catch_start): Make "block" const.
12352 * c-valprint.c (print_unpacked_pointer): Remove "block".
12353 * symmisc.c (dump_symtab_1): Make "b" const.
12354 (block_depth): Make "block" const.
12355 * d-exp.y (%union) <bval>: Remove.
12356 * cp-support.h (cp_lookup_rtti_type): Update.
12357 * cp-support.c (cp_lookup_rtti_type): Make "block" const.
12358 * psymtab.c (psym_lookup_symbol): Make "block" const.
12359 (maintenance_check_psymtabs): Make "b" const.
12360 * python/py-framefilter.c (extract_sym): Make "sym_block" const.
12361 (enumerate_locals, enumerate_args): Update.
12362 * python/py-symtab.c (stpy_global_block): Make "block" const.
12363 (stpy_static_block): Likewise.
12364 * inline-frame.c (block_starting_point_at): Make "new_block"
12365 const.
12366 * block.c (find_block_in_blockvector): Make return type const.
12367 (blockvector_for_pc_sect): Make "b" const.
12368 (find_block_in_blockvector): Make "b" const.
12369
7ad417dd
TT		 123702019-03-23 Tom Tromey <tom@tromey.com>
12371
12372 * varobj.c (varobj_create): Update.
12373 * symfile.c (clear_symtab_users): Don't reset innermost_block.
12374 * printcmd.c (display_command, do_one_display): Don't reset
12375 innermost_block.
12376 * parser-defs.h (enum innermost_block_tracker_type): Move to
12377 expression.h.
12378 (innermost_block): Update comment.
12379 * parse.c (parse_exp_1): Add tracker_types parameter.
12380 (parse_exp_in_context): Rename from parse_exp_in_context_1. Add
12381 tracker_types parameter. Reset innermost_block.
12382 (parse_exp_in_context): Remove.
12383 (parse_expression_for_completion): Update.
12384 * objfiles.c (~objfile): Don't reset expression_context_block or
12385 innermost_block.
12386 * expression.h (enum innermost_block_tracker_type): Move from
12387 parser-defs.h.
12388 (parse_exp_1): Add tracker_types parameter.
12389 * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
12390 reset innermost_block.
12391
b366c208
TT		 123922019-03-23 Tom Tromey <tom@tromey.com>
12393
12394 * objfiles.h: Include bcache.h.
12395
9bb9b2f9
TT		 123962019-03-23 Tom Tromey <tom@tromey.com>
12397
12398 * linespec.c (get_current_search_block): Use
12399 scoped_restore_current_language.
12400 * symmisc.c (dump_symtab): Use scoped_restore_current_language.
12401
59c28372
AH		 124022019-03-22 Alan Hayward <alan.hayward@arm.com>
12403 Jiong Wang <jiong.wang@arm.com>
12404
12405 * aarch64-linux-tdep.c
12406 (aarch64_linux_iterate_over_regset_sections): Check for pauth
12407 section.
12408 * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
12409
17e116a7
AH		 124102019-03-22 Alan Hayward <alan.hayward@arm.com>
12411 Jiong Wang <jiong.wang@arm.com>
12412
12413 * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
12414 instructions.
12415 (aarch64_analyze_prologue_test): Add PACIASP test.
12416 (aarch64_prologue_prev_register): Unmask PC value.
12417
11e1b75f
AH		 124182019-03-22 Alan Hayward <alan.hayward@arm.com>
12419 Jiong Wang <jiong.wang@arm.com>
12420
12421 * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
12422 (aarch64_dwarf2_prev_register): Unmask PC value.
12423 (aarch64_dwarf2_frame_init_reg): Init pauth registers.
12424 (aarch64_execute_dwarf_cfa_vendor_op): Check for
12425 DW_CFA_AARCH64_negate_ra_state.
12426 (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
12427
34dcc7cf
AH		 124282019-03-22 Alan Hayward <alan.hayward@arm.com>
12429 Jiong Wang <jiong.wang@arm.com>
12430
12431 * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
12432 registers.
12433 (aarch64_pseudo_register_name): Likewise.
12434 (aarch64_pseudo_register_type): Likewise.
12435 (aarch64_pseudo_register_reggroup_p): Likewise.
12436 (aarch64_gdbarch_init): Add pauth registers.
12437 * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
12438 (AARCH64_DWARF_PAUTH_DMASK): Likewise.
12439 (AARCH64_DWARF_PAUTH_CMASK): Likewise.
12440 (struct gdbarch_tdep): Add regnum for ra_state.
12441
1ef53e6b
AH		 124422019-03-22 Alan Hayward <alan.hayward@arm.com>
12443 Jiong Wang <jiong.wang@arm.com>
12444
12445 * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
12446
76bed0fd
AH		 124472019-03-22 Alan Hayward <alan.hayward@arm.com>
12448 Jiong Wang <jiong.wang@arm.com>
12449
12450 * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
12451 function.
12452 (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
12453 * aarch64-tdep.c (aarch64_cannot_store_register): New function.
12454 (aarch64_gdbarch_init): Add puth registers.
12455 * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
12456 * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
12457 (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
12458
ee4fbcfa
AH		 124592019-03-22 Alan Hayward <alan.hayward@arm.com>
12460 Jiong Wang <jiong.wang@arm.com>
12461
12462 * aarch64-linux-nat.c
12463 (aarch64_linux_nat_target::read_description): Read PACA hwcap.
12464 * aarch64-linux-tdep.c
12465 (aarch64_linux_core_read_description): Likewise.
12466 (aarch64_linux_get_hwcap): New function.
12467 * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
12468 (aarch64_linux_get_hwcap): New declaration.
12469
6dc0ebde
AH		 124702019-03-22 Alan Hayward <alan.hayward@arm.com>
12471 Jiong Wang <jiong.wang@arm.com>
12472
12473 * aarch64-linux-nat.c
12474 (aarch64_linux_nat_target::read_description): Add pauth param.
12475 * aarch64-linux-tdep.c
12476 (aarch64_linux_core_read_description): Likewise.
12477 * aarch64-tdep.c (struct target_desc): Add in pauth.
12478 (aarch64_read_description): Add pauth param.
12479 (aarch64_gdbarch_init): Likewise.
12480 * aarch64-tdep.h (aarch64_read_description): Likewise.
12481 * arch/aarch64.c (aarch64_create_target_description): Likewise.
12482 * arch/aarch64.h (aarch64_create_target_description): Likewise.
12483 * features/Makefile: Add new files.
12484 * features/aarch64-pauth.c: New file.
12485 * features/aarch64-pauth.xml: New file.
12486
595915c1
TT		 124872019-03-20 Tom Tromey <tromey@adacore.com>
12488
12489 * infrun.c (handle_inferior_event): Rename from
12490 handle_inferior_event_1. Create a scoped_value_mark.
12491 (handle_inferior_event): Remove.
12492
4c7d57e7
TT		 124932019-03-19 Tom Tromey <tromey@adacore.com>
12494
12495 * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
12496 * infrun.h (print_stop_event): Add "displays" parameter.
12497 * infrun.c (print_stop_event): Add "displays" parameter.
12498
cb246234
PA		 124992019-03-19 Pedro Alves <palves@redhat.com>
12500
12501 * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
12502 (tui_ui_out::do_text): Add comments. Reset M_LINE to 0 instead of
12503 to -1. Fix TABs vs spaces.
12504 (tui_ui_out::tui_ui_out): Don't initialize fields here.
12505 * tui/tui-out.h (tui_ui_out) Add intro comments.
12506 <m_line, m_start_of_line>: In-class initialize, and add describing
12507 comment.
12508
3a0e45b2
AH		 125092019-03-18 Alan Hayward <alan.hayward@arm.com>
12510
12511 * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
12512 variable names.
12513 (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
12514
5371b850
PA		 125152019-03-18 Pedro Alves <palves@redhat.com>
12516 Eli Zaretskii <eliz@gnu.org>
12517
12518 * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
12519 m_line and m_start_of_line.
12520
b17c4cd0
EZ		 125212019-03-18 Eli Zaretskii <eliz@gnu.org>
12522
12523 * tui/tui-io.c (gdb_wgetch): Don't echo CR.
12524 (tui_getc): When gdb_wgetch returns a CR, behave the same as when
12525 it returns a newline. This fixes a regression in TU mode, whereby
12526 the next line is output on the same screen line as the user input.
12527
4bd56d18
TT		 125282019-03-18 Tom Tromey <tromey@adacore.com>
12529
12530 * minsyms.c (minimal_symbol_reader::install): Remove call to
12531 obstack_blank.
12532
55c10aca
PA		 125332019-03-18 Pedro Alves <palves@redhat.com>
12534
12535 * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
12536 New globals.
12537 (apply_style): New, factored out from ...
12538 (apply_ansi_escape): ... this. Handle reverse video mode.
12539 (tui_set_reverse_mode): New function.
12540 * tui/tui-io.h (tui_set_reverse_mode): New declaration.
12541 * tui/tui-winsource.c (tui_show_source_line): Use
12542 tui_set_reverse_mode instead of setting A_STANDOUT.
12543 * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
12544 New setter methods.
12545
647bb750
HD		 125462019-03-18 Hannes Domani <ssbssa@yahoo.de>
12547
12548 * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
12549 Handle tabs.
12550
bff8c71f
TT		 125512019-03-18 Tom Tromey <tromey@adacore.com>
12552
12553 * ada-lang.c (empty_array): Add "high" parameter.
12554 (ada_evaluate_subexp): Update.
12555
58785d98
ST		 125562019-03-17 Sergei Trofimovich <siarheit@google.com>
12557
12558 * unittests/string_view-selftests.c: Define
12559 _initialize_string_view_selftests unconditionally.
12560
d4cbef22
ВМ		 125612019-03-17 Vladimir Martyanov <vilgeforce@gmail.com>
12562
12563 PR gdb/24350
12564 * windows-nat.c (windows_make_so): Remove unused text_vma variable.
12565
fce4c071
ВМ		 125662019-03-17 Vladimir Martyanov <vilgeforce@gmail.com>
12567
12568 PR gdb/24351
12569 * windows-nat.c (display_selector): Fix format specifiers.
12570
f7f0a123
EZ		 125712019-03-17 Eli Zaretskii <eliz@gnu.org>
12572
12573 * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
12574 tui_refill_source_window instead of tui_refresh_win, to update the
12575 current execution line. This fixes redisplay of the current line
12576 when stepping through the code with "next" or "step".
12577
ab42892f
EZ		 125782019-03-16 Eli Zaretskii <eliz@gnu.org>
12579
12580 * source-cache.c (source_cache::get_source_lines): Call
12581 find_source_lines to initialize s->nlines. This fixes vertical
12582 scrolling of TUI source window when the DOWN arrow is pressed.
12583
8d8c087f
PW		 125842019-03-16 Philippe Waroquiers <philippe.waroquiers@skynet.be>
12585
12586 * auto-load.c (_initialize_auto_load): Fix 'This options has'.
12587 linux-thread-db.c (_initialize_thread_db): Likewise.
12588
798e1c30
EZ		 125892019-03-16 Eli Zaretskii <eliz@gnu.org>
12590
12591 * tui/tui-winsource.c (tui_show_source_line): Revert "Use
12592 wclrtoeol in tui_show_source_line". This reverts changes made in
12593 commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
12594
eefba3da
TT		 125952019-03-15 Tom Tromey <tom@tromey.com>
12596
12597 * symtab.h (struct minimal_symbol): Derive from
12598 general_symbol_info.
12599 (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
12600 (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
12601 (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
12602 (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
12603 (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
12604 (MSYMBOL_SEARCH_NAME): Update.
12605 (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
12606 * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
12607 * minsyms.c (minimal_symbol_reader::record_full): Update.
12608
0de2420c
TT		 126092019-03-15 Tom Tromey <tom@tromey.com>
12610
12611 * minsyms.c (minimal_symbol_reader::install): Use memcpy.
12612
042d75e4
TT		 126132019-03-15 Tom Tromey <tom@tromey.com>
12614
12615 * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
12616 unique_xmalloc_ptr.
12617 (objfile::msymbols_range::begin, objfile::msymbols_range::end):
12618 Update.
12619 * minsyms.c (lookup_minimal_symbol_by_pc_section)
12620 (build_minimal_symbol_hash_tables)
12621 (minimal_symbol_reader::install): Update.
12622
db92718b
TT		 126232019-03-15 Tom Tromey <tom@tromey.com>
12624
12625 * symtab.c (create_demangled_names_hash): Update.
12626 (symbol_set_names): Update.
12627 * objfiles.h (struct objfile_per_bfd_storage)
12628 <demangled_names_hash>: Now an htab_up.
12629 * objfiles.c (objfile_per_bfd_storage): Simplify.
12630
d6797f46
TT		 126312019-03-15 Tom Tromey <tom@tromey.com>
12632
12633 * objfiles.h (struct objfile_per_bfd_storage): Declare
12634 destructor.
12635 * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
12636 New.
12637 (get_objfile_bfd_data): Use new. Don't initialize
12638 language_of_main.
12639 (free_objfile_per_bfd_storage): Remove.
12640 (objfile_bfd_data_free, objfile::~objfile): Use delete.
12641
741d7538
TT		 126422019-03-15 Tom Tromey <tom@tromey.com>
12643
12644 * symfile.c (reread_symbols): Update.
12645 * objfiles.c (objfile::objfile): Update.
12646 * minsyms.h (terminate_minimal_symbol_table): Don't declare.
12647 * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
12648 comment.
12649 (minimal_symbol_reader::install): Update.
12650 (terminate_minimal_symbol_table): Remove.
12651 * jit.c (jit_object_close_impl): Update.
12652
788c80d1
TT		 126532019-03-15 Tom Tromey <tom@tromey.com>
12654
12655 * minsyms.c (minimal_symbol_reader::record_full): Remove some
12656 initializations.
12657
1b7a07cb
TT		 126582019-03-15 Tom Tromey <tom@tromey.com>
12659
12660 * objfiles.h (struct objfile_per_bfd_storage)
12661 <demangled_hash_languages>: Now a bitset.
12662 * minsyms.c (add_minsym_to_demangled_hash_table): Update.
12663 (lookup_minimal_symbol): Update.
12664
3db066bc
TT		 126652019-03-15 Tom Tromey <tom@tromey.com>
12666
12667 * minsyms.h (class minimal_symbol_reader) <record_with_info>:
12668 Don't return the symbol.
12669 * coffread.c (record_minimal_symbol): Use record_full.
12670
3fff2c37
EZ		 126712019-03-14 Eli Zaretskii <eliz@gnu.org>
12672
12673 The MS-Windows port of ncurses fails to switch to a color pair if
12674 one or both of the colors are the implicit default colors. This
12675 change records the default colors when TUI is initialized, and
12676 then specifies them explicitly when a color pair uses the default
12677 colors. This allows color styling in TUI mode on MS-Windows.
12678
12679 * tui/tui-io.c [__MINGW32__]: Include windows.h. Declare
12680 ncurses_norm_attr.
12681 (tui_initialize_io) [__MINGW32__]: Record the default terminal
12682 colors in ncurses_norm_attr.
12683 (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
12684 "none", replace it with the default color recorded in
12685 ncurses_norm_attr.
12686
3b336828
TT		 126872019-03-14 Tom Tromey <tromey@adacore.com>
12688
12689 * source-cache.h (class source_cache) <get_source_lines>: Return
12690 std::string.
12691 * source-cache.c (source_cache::extract_lines): Handle case where
12692 first_pos==npos. Return std::string.
12693 (source_cache::get_source_lines): Update.
12694
d085f989
TT		 126952019-03-14 Tom Tromey <tromey@adacore.com>
12696
12697 * NEWS: Add item for "style sources" commands.
12698 * source-cache.c (source_cache::get_source_lines): Check
12699 source_styling.
12700 * cli/cli-style.c (source_styling): New global.
12701 (_initialize_cli_style): Add "style sources" commands.
12702 (show_style_sources): New function.
12703 * cli/cli-style.h (source_styling): Declare.
12704
6f11e682
TT		 127052019-03-14 Pedro Alves <palves@redhat.com>
12706 Tom Tromey <tromey@adacore.com>
12707
12708 * tui/tui-winsource.h (tui_refill_source_window): Declare.
12709 * tui/tui-winsource.c (tui_refill_source_window): New function,
12710 from...
12711 (tui_horizontal_source_scroll): ... here. Move some logic.
12712 * cli/cli-style.c (set_style_enabled): Notify new observable.
12713 * tui/tui-hooks.c (tui_redisplay_source): New function.
12714 (tui_attach_detach_observers): Attach or detach
12715 tui_redisplay_source.
12716 * observable.h (source_styling_changed): New observable.
12717 * observable.c: Define source_styling_changed observable.
12718
a068643d
TT		 127192019-03-13 Tom Tromey <tromey@adacore.com>
12720
12721 * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
12722 (i386_gnu_nat_target::store_registers): Update.
12723 * target-debug.h (target_debug_print_std_string): New macro.
12724 * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
12725 * windows-tdep.c (display_one_tib): Update.
12726 * tui/tui-stack.c (tui_make_status_line): Update.
12727 * top.c (print_inferior_quit_action): Update.
12728 * thread.c (thr_try_catch_cmd): Update.
12729 (add_thread_with_info): Update.
12730 (thread_target_id_str): Update.
12731 (thr_try_catch_cmd): Update.
12732 (thread_command): Update.
12733 (thread_find_command): Update.
12734 * record-btrace.c (record_btrace_target::info_record)
12735 (record_btrace_resume_thread, record_btrace_target::resume)
12736 (record_btrace_cancel_resume, record_btrace_step_thread)
12737 (record_btrace_target::wait, record_btrace_target::wait)
12738 (record_btrace_target::wait, record_btrace_target::stop): Update.
12739 * progspace.c (print_program_space): Update.
12740 * process-stratum-target.c
12741 (process_stratum_target::thread_address_space): Update.
12742 * linux-fork.c (linux_fork_mourn_inferior)
12743 (detach_checkpoint_command, info_checkpoints_command)
12744 (linux_fork_context): Update.
12745 (linux_fork_detach): Update.
12746 (class scoped_switch_fork_info): Update.
12747 (delete_checkpoint_command): Update.
12748 * infrun.c (follow_fork_inferior): Update.
12749 (follow_fork_inferior): Update.
12750 (proceed_after_vfork_done): Update.
12751 (handle_vfork_child_exec_or_exit): Update.
12752 (follow_exec): Update.
12753 (displaced_step_prepare_throw): Update.
12754 (displaced_step_restore): Update.
12755 (start_step_over): Update.
12756 (resume_1): Update.
12757 (clear_proceed_status_thread): Update.
12758 (proceed): Update.
12759 (print_target_wait_results): Update.
12760 (do_target_wait): Update.
12761 (context_switch): Update.
12762 (stop_all_threads): Update.
12763 (restart_threads): Update.
12764 (finish_step_over): Update.
12765 (handle_signal_stop): Update.
12766 (switch_back_to_stepped_thread): Update.
12767 (keep_going_pass_signal): Update.
12768 (print_exited_reason): Update.
12769 (normal_stop): Update.
12770 * inferior.c (inferior_pid_to_str): Change return type.
12771 (print_selected_inferior): Update.
12772 (add_inferior): Update.
12773 (detach_inferior): Update.
12774 * dummy-frame.c (fprint_dummy_frames): Update.
12775 * dcache.c (dcache_info_1): Update.
12776 * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
12777 (btrace_fetch, btrace_clear): Update.
12778 * linux-tdep.c (linux_core_pid_to_str): Change return type.
12779 * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
12780 type.
12781 * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
12782 * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
12783 * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
12784 * gdbarch.c, gdbarch.h: Rebuild.
12785 * gdbarch.sh (core_pid_to_str): Change return type.
12786 * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
12787 return type.
12788 (windows_nat_target::pid_to_str): Change return type.
12789 (windows_delete_thread): Update.
12790 (windows_nat_target::attach): Update.
12791 (windows_nat_target::files_info): Update.
12792 * target-delegates.c: Rebuild.
12793 * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
12794 return type.
12795 (sol_thread_target::pid_to_str): Change return type.
12796 * remote.c (class remote_target) <pid_to_str>: Change return
12797 type.
12798 (remote_target::pid_to_str): Change return type.
12799 (extended_remote_target::attach, remote_target::remote_stop_ns)
12800 (remote_target::remote_notif_remove_queued_reply)
12801 (remote_target::push_stop_reply, remote_target::disable_btrace):
12802 Update.
12803 (extended_remote_target::attach): Update.
12804 * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
12805 type.
12806 (gdbsim_target::pid_to_str): Change return type.
12807 * ravenscar-thread.c (struct ravenscar_thread_target)
12808 <pid_to_str>: Change return type.
12809 (ravenscar_thread_target::pid_to_str): Change return type.
12810 * procfs.c (class procfs_target) <pid_to_str>: Change return
12811 type.
12812 (procfs_target::pid_to_str): Change return type.
12813 (procfs_target::attach): Update.
12814 (procfs_target::detach): Update.
12815 (procfs_target::fetch_registers): Update.
12816 (procfs_target::store_registers): Update.
12817 (procfs_target::wait): Update.
12818 (procfs_target::files_info): Update.
12819 * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
12820 * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
12821 return type.
12822 (nto_procfs_target::pid_to_str): Change return type.
12823 (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
12824 * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
12825 return type.
12826 * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
12827 (exit_lwp): Update.
12828 (attach_proc_task_lwp_callback, get_detach_signal)
12829 (detach_one_lwp, resume_lwp, linux_nat_target::resume)
12830 (linux_nat_target::resume, wait_lwp, stop_callback)
12831 (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
12832 (save_stop_reason, select_event_lwp, linux_nat_filter_event)
12833 (linux_nat_wait_1, resume_stopped_resumed_lwps)
12834 (linux_nat_target::wait, linux_nat_stop_lwp): Update.
12835 * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
12836 type.
12837 (inf_ptrace_target::attach): Update.
12838 (inf_ptrace_target::files_info): Update.
12839 * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
12840 type.
12841 (go32_nat_target::pid_to_str): Change return type.
12842 * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
12843 (gnu_nat_target::wait): Update.
12844 (gnu_nat_target::wait): Update.
12845 (gnu_nat_target::resume): Update.
12846 * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
12847 (fbsd_nat_target::wait): Update.
12848 * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
12849 type.
12850 (darwin_nat_target::attach): Update.
12851 * corelow.c (class core_target) <pid_to_str>: Change return type.
12852 (core_target::pid_to_str): Change return type.
12853 * target.c (normal_pid_to_str): Change return type.
12854 (default_pid_to_str): Likewise.
12855 (target_pid_to_str): Change return type.
12856 (target_translate_tls_address): Update.
12857 (target_announce_detach): Update.
12858 * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
12859 return type.
12860 (bsd_uthread_target::pid_to_str): Change return type.
12861 * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
12862 type.
12863 (bsd_kvm_target::pid_to_str): Change return type.
12864 * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
12865 return type.
12866 (aix_thread_target::pid_to_str): Change return type.
12867 * target.h (struct target_ops) <pid_to_str>: Change return type.
12868 (target_pid_to_str, normal_pid_to_str): Likewise.
12869 * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
12870 type.
12871 * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
12872 type.
12873 * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
12874 return type.
12875 * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
12876 type.
12877 * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
12878 type.
12879 * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
12880 return type.
12881
b4be1b06
SM		 128822019-03-13 Simon Marchi <simon.marchi@ericsson.com>
12883
12884 * NEWS: Mention that the new default MI version is 3. Mention
12885 changes to the output of commands and events that deal with
12886 multi-location breakpoints.
12887 * breakpoint.c: Include "mi/mi-out.h".
12888 (print_one_breakpoint): Change output syntax if using MI version
12889 >= 3.
12890 * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
12891 New.
12892 (mi_multi_location_breakpoint_output_fixed): New.
12893 * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
12894 (mi_cmd_fix_multi_location_breakpoint_output): New.
12895 (mi_multi_location_breakpoint_output_fixed): New.
12896 * mi/mi-cmds.c (mi_cmds): Register command
12897 -fix-multi-location-breakpoint-output.
12898 * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
12899 interpreter "mi".
12900
8e5e5494
SM		 129012019-03-13 Simon Marchi <simon.marchi@polymtl.ca>
12902
12903 * mi/mi-out.h (mi_out_new): Change parameter to const char *.
12904 * mi/mi-out.c (mi_out_new): Change parameter to const char *,
12905 instantiate mi_ui_out based on interpreter name.
12906 * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
12907 * mi/mi-main.c (mi_load_progress): Likewise.
12908
197df35e
JB		 129092019-03-12 John Baldwin <jhb@FreeBSD.org>
12910
12911 * NEWS: Combine separate "New targets" sections for 8.3.
12912
8399425f
JB		 129132019-03-12 John Baldwin <jhb@FreeBSD.org>
12914
12915 * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
12916 (ppcfbsd_init_abi): Install gdbarch
12917 "fetch_tls_load_module_address" and "get_thread_local_address"
12918 methods.
12919
b0f87ed0
JB		 129202019-03-12 John Baldwin <jhb@FreeBSD.org>
12921
12922 * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
12923 (riscv_fbsd_init_abi): Install gdbarch
12924 "fetch_tls_load_module_address" and "get_thread_local_address"
12925 methods.
12926
ce25aa57
JB		 129272019-03-12 John Baldwin <jhb@FreeBSD.org>
12928
12929 * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
12930 (i386fbsd_init_abi): Install gdbarch
12931 "fetch_tls_load_module_address" and "get_thread_local_address"
12932 methods.
12933
f5424cfa
JB		 129342019-03-12 John Baldwin <jhb@FreeBSD.org>
12935
12936 * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
12937 (amd64fbsd_init_abi): Install gdbarch
12938 "fetch_tls_load_module_address" and "get_thread_local_address"
12939 methods.
12940
945f3901
JB		 129412019-03-12 John Baldwin <jhb@FreeBSD.org>
12942
12943 * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
12944 (struct fbsd_pspace_data): New type.
12945 (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
12946 (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
12947 (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
12948 (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
12949 * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
12950
ef0bd204
JB		 129512019-03-12 John Baldwin <jhb@FreeBSD.org>
12952
12953 * gdbtypes.c (lookup_struct_elt): New function.
12954 (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
12955 * gdbtypes.h (struct struct_elt): New type.
12956 (lookup_struct_elt): New prototype.
12957
36c53a02
JB		 129582019-03-12 John Baldwin <jhb@FreeBSD.org>
12959
12960 * gdbtypes.c (lookup_struct_elt_type): Update comment and
12961 remove disabled code block.
12962
6e056c81
JB		 129632019-03-12 John Baldwin <jhb@FreeBSD.org>
12964
12965 * gdbarch.sh (get_thread_local_address): New method.
12966 * gdbarch.h, gdbarch.c: Regenerate.
12967 * target.c (target_translate_tls_address): Use
12968 gdbarch_get_thread_local_address if present instead of
12969 target::get_thread_local_address.
12970
cd250a18
JB		 129712019-03-12 John Baldwin <jhb@FreeBSD.org>
12972
12973 * target.h (target::get_thread_local_address): Update comment.
12974
df22c1e5
JB		 129752019-03-12 John Baldwin <jhb@FreeBSD.org>
12976
12977 * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
12978 objfile->separate_debug_objfile_backlink if not NULL.
12979
dd6876c9
JB		 129802019-03-12 John Baldwin <jhb@FreeBSD.org>
12981
12982 * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
12983 tdep->fsbase_regnum instead of constants for fs_base and gs_base.
12984 (amd64bsd_store_inferior_registers): Likewise.
12985 * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
12986 Enable segment base registers.
12987 * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
12988 PT_GETFSBASE and PT_GETGSBASE.
12989 (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
12990 PT_SETGSBASE.
12991 * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
12992 segment base registers.
12993 * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
12994
1163a4b7
JB		 129952019-03-12 John Baldwin <jhb@FreeBSD.org>
12996
12997 * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
12998 Update calls to i386_target_description to add 'segments'
12999 parameter.
13000 * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum. Don't
13001 add segment base registers.
13002 * arch/i386.c (i386_create_target_description): Add 'segments'
13003 parameter to enable segment base registers.
13004 * arch/i386.h (i386_create_target_description): Likewise.
13005 * features/i386/32bit-segments.xml: New file.
13006 * features/i386/32bit-segments.c: Generate.
13007 * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
13008 call to i386_target_description to add 'segments' parameter.
13009 * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
13010 * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
13011 * i386-linux-tdep.c (i386_linux_read_description): Likewise.
13012 * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
13013 if feature is present.
13014 (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
13015 Add 'segments' parameter to call to i386_target_description.
13016 (i386_target_description): Add 'segments' parameter to enable
13017 segment base registers.
13018 (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
13019 to call to i386_target_description.
13020 * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
13021 (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
13022 Define I386_NUM_REGS.
13023 (i386_target_description): Add 'segments' parameter to enable
13024 segment base registers.
13025
3a350822
EZ		 130262019-03-12 Eli Zaretskii <eliz@gnu.org>
13027
13028 PR/24325
13029 * source-cache.c: #undef open and close, to avoid unresolved
13030 externals during linking.
13031
ffdd69cf
TT		 130322019-03-12 Tom Tromey <tromey@adacore.com>
13033
13034 * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
13035 const. Add initializers.
13036 (_initialize_remote): Don't initialize ptid globals.
13037
ec148c57
PA		 130382019-03-12 Pedro Alves <palves@redhat.com>
13039
13040 * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
13041
32764270
PA		 130422019-03-12 Pedro Alves <palves@redhat.com>
13043
13044 * cp-name-parser.y (main): Remove unused 'len' variable.
13045
17547186
TT		 130462019-03-12 Tom Tromey <tromey@adacore.com>
13047
13048 * common/ptid.c (null_ptid, minus_one_ptid): Now const.
13049 * common/ptid.h (null_ptid, minus_one_ptid): Now const.
13050
d3a70e03
TT		 130512019-03-12 Tom Tromey <tromey@adacore.com>
13052
13053 * linux-nat.c (iterate_over_lwps): Update.
13054 (stop_callback): Remove parameter.
13055 (stop_wait_callback, detach_callback, resume_set_callback)
13056 (select_singlestep_lwp_callback, set_ignore_sigint)
13057 (status_callback, resumed_callback, resume_clear_callback)
13058 (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
13059 data parameter.
13060 (linux_nat_target::detach, linux_nat_target::resume)
13061 (linux_stop_and_wait_all_lwps, select_event_lwp)
13062 (linux_nat_filter_event, linux_nat_wait_1)
13063 (linux_nat_target::kill, linux_nat_target::stop)
13064 (linux_nat_target::stop): Update.
13065 (linux_nat_resume_callback): Change type.
13066 (resume_stopped_resumed_lwps, count_events_callback)
13067 (select_event_lwp_callback): Likewise.
13068 (linux_stop_lwp, linux_nat_stop_lwp): Update.
13069 * arm-linux-nat.c (struct update_registers_data): Remove.
13070 (update_registers_callback): Change type.
13071 (arm_linux_insert_hw_breakpoint1): Update.
13072 * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
13073 parameter.
13074 (x86_linux_dr_set_addr): Update.
13075 (x86_linux_dr_set_control): Update.
13076 * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
13077 (iterate_over_lwps): Use gdb::function_view.
13078 * nat/aarch64-linux-hw-point.c (struct
13079 aarch64_dr_update_callback_param): Remove.
13080 (debug_reg_change_callback): Change type.
13081 (aarch64_notify_debug_reg_change): Update.
13082 * s390-linux-nat.c (s390_refresh_per_info): Update.
13083
82cb27ff
TT		 130842019-03-11 Tom Tromey <tromey@adacore.com>
13085
13086 * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
13087 redundant assignment to "this_cu".
13088
568c0683
SM		 130892019-03-08 Simon Marchi <simon.marchi@efficios.com>
13090
13091 * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
13092
f09ce22d
SM		 130932019-03-08 Simon Marchi <simon.marchi@efficios.com>
13094
13095 * gdbtypes.c (rank_one_type_parm_set): New function extracted
13096 from...
13097 (rank_one_type): ... this.
13098
595f96a9
SM		 130992019-03-08 Simon Marchi <simon.marchi@efficios.com>
13100
13101 * gdbtypes.c (rank_one_type_parm_struct): New function extracted
13102 from...
13103 (rank_one_type): ... this.
13104
2598a94b
SM		 131052019-03-08 Simon Marchi <simon.marchi@efficios.com>
13106
13107 * gdbtypes.c (rank_one_type_parm_complex): New function extracted
13108 from...
13109 (rank_one_type): ... this.
13110
7f17b20d
SM		 131112019-03-08 Simon Marchi <simon.marchi@efficios.com>
13112
13113 * gdbtypes.c (rank_one_type_parm_float): New function extracted
13114 from...
13115 (rank_one_type): ... this.
13116
2c509035
SM		 131172019-03-08 Simon Marchi <simon.marchi@efficios.com>
13118
13119 * gdbtypes.c (rank_one_type_parm_bool): New function extracted
13120 from...
13121 (rank_one_type): ... this.
13122
0dd322dc
SM		 131232019-03-08 Simon Marchi <simon.marchi@efficios.com>
13124
13125 * gdbtypes.c (rank_one_type_parm_range): New function extracted
13126 from...
13127 (rank_one_type): ... this.
13128
41ea4728
SM		 131292019-03-08 Simon Marchi <simon.marchi@efficios.com>
13130
13131 * gdbtypes.c (rank_one_type_parm_char): New function extracted
13132 from...
13133 (rank_one_type): ... this.
13134
793cd1d2
SM		 131352019-03-08 Simon Marchi <simon.marchi@efficios.com>
13136
13137 * gdbtypes.c (rank_one_type_parm_enum): New function extracted
13138 from...
13139 (rank_one_type): ... this.
13140
34910087
SM		 131412019-03-08 Simon Marchi <simon.marchi@efficios.com>
13142
13143 * gdbtypes.c (rank_one_type_parm_int): New function extracted
13144 from...
13145 (rank_one_type): ... this.
13146
f1f832d6
SM		 131472019-03-08 Simon Marchi <simon.marchi@efficios.com>
13148
13149 * gdbtypes.c (rank_one_type_parm_func): New function extracted
13150 from...
13151 (rank_one_type): ... this.
13152
b9f4512f
SM		 131532019-03-08 Simon Marchi <simon.marchi@efficios.com>
13154
13155 * gdbtypes.c (rank_one_type_parm_array): New function extracted
13156 from...
13157 (rank_one_type): ... this.
13158
9293fc63
SM		 131592019-03-08 Simon Marchi <simon.marchi@efficios.com>
13160
13161 * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
13162 from...
13163 (rank_one_type): ... this.
13164
e3abbe7e
PW		 131652019-02-27 Philippe Waroquiers <philippe.waroquiers@skynet.be>
13166
13167 * inferior.c (initialize_inferiors): Ensure 'help set/show print
13168 inferior-events' shows the example events.
13169
e4adb939
EZ		 131702019-03-08 Eli Zaretskii <eliz@gnu.org>
13171
13172 Support styling on native MS-Windows console
13173
13174 PR/24315
13175 * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
13176 on MS-Windows if $TERM is not defined.
13177
13178 * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
13179
13180 * posix-hdep.c (gdb_console_fputs):
13181 * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
13182 functions.
13183 * ui-file.h (gdb_console_fputs): Add prototype.
13184
13185 * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
13186 back to fputs only if the former returns zero.
13187
25629dfd
TT		 131882019-03-07 Tom Tromey <tom@tromey.com>
13189
13190 * symmisc.c (print_symbol_bcache_statistics): Update.
13191 (print_objfile_statistics): Update.
13192 * symfile.c (allocate_symtab): Update.
13193 * stabsread.c: Don't include bcache.h.
13194 * psymtab.h (struct psymbol_bcache): Don't declare.
13195 (class psymtab_storage) <psymbol_cache>: Now a bcache.
13196 (psymbol_bcache_init, psymbol_bcache_free)
13197 (psymbol_bcache_get_bcache): Don't declare.
13198 * psymtab.c (struct psymbol_bcache): Remove.
13199 (psymtab_storage::psymtab_storage): Update.
13200 (psymtab_storage::~psymtab_storage): Update.
13201 (psymbol_bcache_init, psymbol_bcache_free)
13202 (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
13203 (add_psymbol_to_bcache): Update.
13204 (allocate_psymtab): Update.
13205 * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
13206 macro_cache>: No longer pointers.
13207 * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
13208 (free_objfile_per_bfd_storage): Don't call bcache_xfree.
13209 * macrotab.c (macro_bcache): Update.
13210 * macroexp.c: Don't include bcache.h.
13211 * gdbtypes.c (check_types_worklist): Update.
13212 (types_deeply_equal): Remove TRY/CATCH. Update.
13213 * elfread.c (elf_symtab_read): Update.
13214 * dwarf2read.c: Don't include bcache.h.
13215 * buildsym.c (buildsym_compunit::get_macro_table): Update.
13216 * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
13217 (print_bcache_statistics, bcache_memory_used): Don't declare.
13218 (struct bcache): Move from bcache.c. Add constructor, destructor,
13219 methods. Rename all data members.
13220 * bcache.c (struct bcache): Move to bcache.h.
13221 (bcache::expand_hash_table): Rename from expand_hash_table.
13222 (bcache): Remove.
13223 (bcache::insert): Rename from bcache_full.
13224 (bcache::compare): Rename from bcache_compare.
13225 (bcache_xmalloc): Remove.
13226 (bcache::~bcache): Rename from bcache_xfree.
13227 (bcache::print_statistics): Rename from print_bcache_statistics.
13228 (bcache::memory_used): Rename from bcache_memory_used.
13229
fe726667
PA		 132302019-03-07 Pedro Alves <palves@redhat.com>
13231
13232 * infrun.c (normal_stop): Also check for
13233 TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
13234
7584bb30
AB		 132352019-03-07 Andrew Burgess <andrew.burgess@embecosm.com>
13236
13237 * f-lang.c (value_from_host_double): Moved to...
13238 * value.c (value_from_host_double): ...here.
13239 * value.h (value_from_host_double): Declare.
13240 * guile/scm-math.c (vlscm_convert_typed_number): Use
13241 value_from_host_double.
13242 (vlscm_convert_number): Likewise.
13243 * guile/scm-value.c (gdbscm_value_to_real): Likewise.
13244 * python/py-value.c (convert_value_from_python): Likewise.
13245
a7b1986e
TT		 132462019-03-06 Tom Tromey <tom@tromey.com>
13247
13248 * gcore.c (write_gcore_file): Use SCOPE_EXIT.
13249
0ccf4211
TT		 132502019-03-06 Tom Tromey <tom@tromey.com>
13251
13252 * utils.h (free_current_contents): Don't declare.
13253 * utils.c (free_current_contents): Remove.
13254
fe7b42e5
TT		 132552019-03-06 Tom Tromey <tom@tromey.com>
13256
13257 * top.c (quit_force): Update.
13258 * main.c (captured_command_loop): Update.
13259 * common/new-op.c (operator new): Update.
13260 * common/common-exceptions.c (struct catcher)
13261 <save_cleanup_chain>: Remove member.
13262 (exceptions_state_mc_init): Update.
13263 (exception_try_scope_entry): Return nullptr.
13264 (exception_try_scope_exit, exception_rethrow)
13265 (throw_exception_sjlj, throw_exception_cxx): Update.
13266 * common/cleanups.h (make_cleanup, make_cleanup_dtor)
13267 (all_cleanups, do_cleanups, discard_cleanups)
13268 (discard_final_cleanups, save_cleanups, save_final_cleanups)
13269 (restore_cleanups, restore_final_cleanups): Don't declare.
13270 (do_final_cleanups): Remove parameter.
13271 * common/cleanups.c (cleanup_chain, make_cleanup)
13272 (make_cleanup_dtor, all_cleanups, do_cleanups)
13273 (discard_my_cleanups, discard_cleanups)
13274 (discard_final_cleanups, save_my_cleanups, save_cleanups)
13275 (save_final_cleanups, restore_my_cleanups, restore_cleanups)
13276 (null_cleanup): Remove.
13277 (do_final_cleanups): Remove parameter.
13278
c6321f19
TT		 132792019-03-06 Tom Tromey <tom@tromey.com>
13280
13281 * remote.c (remote_target::remote_parse_stop_reply): Use
13282 unique_xmalloc_ptr.
13283
61b30099
TT		 132842019-03-06 Tom Tromey <tom@tromey.com>
13285
13286 * stabsread.c (struct stabs_field_info): Rename from field_info.
13287 <list, fnlist>: Add initializers.
13288 <obstack>: New member.
13289 (read_member_functions, read_struct_fields, read_baseclasses):
13290 Allocate on obstack. Don't use cleanups.
13291 (read_one_struct_field, read_member_functions, read_struct_fields)
13292 (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
13293 (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
13294 (read_struct_type): Update.
13295
6cceac94
TT		 132962019-03-06 Tom Tromey <tom@tromey.com>
13297
13298 * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
13299 * common/filestuff.h (make_cleanup_close): Don't declare.
13300 * common/filestuff.c (do_close_cleanup, make_cleanup_close):
13301 Remove.
13302
72412762
TT		 133032019-03-06 Tom Tromey <tom@tromey.com>
13304
13305 * solib-aix.c: Use make_scope_exit.
13306
2b6ff1c0
TT		 133072019-03-06 Tom Tromey <tom@tromey.com>
13308
13309 * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
13310 Use make_scope_exit.
13311
d01c5877
TT		 133122019-03-06 Tom Tromey <tom@tromey.com>
13313
13314 * solib-svr4.c (disable_probes_interface): Remove parameter.
13315 (svr4_handle_solib_event): Use make_scope_exit.
13316
32603266
TT		 133172019-03-06 Tom Tromey <tom@tromey.com>
13318
13319 * remote.c (struct stop_reply_deleter): Remove.
13320 (stop_reply_up): Update.
13321 (struct stop_reply): Derive from notif_event. Don't typedef.
13322 <regcache>: Now a std::vector.
13323 (stop_reply_xfree): Remove.
13324 (stop_reply::~stop_reply): Rename from stop_reply_dtr.
13325 (remote_notif_stop_alloc_reply): Return a unique_ptr. Use new.
13326 (remote_target::discard_pending_stop_replies): Use delete.
13327 (remote_target::remote_parse_stop_reply): Update.
13328 (remote_target::process_stop_reply): Update.
13329 * remote-notif.h (struct notif_event): Add virtual destructor.
13330 Remove "dtr" member.
13331 (struct notif_client) <alloc_event>: Return a unique_ptr.
13332 (notif_event_xfree): Don't declare.
13333 (notif_event_up): New typedef.
13334 * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
13335 (notif_event_xfree, do_notif_event_xfree): Remove.
13336 (remote_notif_state_xfree): Update.
13337
9799571e
TT		 133382019-03-06 Tom Tromey <tom@tromey.com>
13339
13340 * infrun.c (displaced_step_clear_cleanup): Now a
13341 forward_scope_exit type.
13342 (displaced_step_prepare_throw): Update.
13343 (displaced_step_fixup): Update.
13344
09e3c4ca
TT		 133452019-03-06 Tom Tromey <tom@tromey.com>
13346
13347 * inferior.h (class inferior): Update comment.
13348 * gdbthread.h (class thread_info): Update comment.
13349
e2a03548
TT		 133502019-03-06 Joel Brobecker <brobecker@adacore.com>
13351 Tom Tromey <tom@tromey.com>
13352
13353 * stabsread.h (struct stab_section_list): Remove.
13354 (coffstab_build_psymtabs): Update.
13355 * dbxread.c (symbuf_sections): Now a std::vector.
13356 (sect_idx): New global.
13357 (fill_symbuf): Update.
13358 (coffstab_build_psymtabs): Change type of stabsects parameter.
13359 Update.
13360 * coffread.c (struct coff_symfile_info) <stabsects>: Now a
13361 std::vector.
13362 (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
13363 (coff_locate_sections): Update.
13364 (coff_symfile_read): Remove cleanups. Update.
13365 (init_stringtab): Add storage parameter.
13366 (free_stringtab, free_stringtab_cleanup): Remove.
13367 (init_lineno): Add storage parameter.
13368 (free_linetab, free_linetab_cleanup): Remove.
13369
b7e60d85
PA		 133702019-03-06 Pedro Alves <palves@redhat.com>
13371
13372 * linux-fork.c (fork_info::clobber_regs): Delete.
13373 (fork_load_infrun_state): Remove reference to 'clobber_regs'.
13374 (fork_save_infrun_state): Remove 'clobber_regs' parameter. Update
13375 comment. Adjust.
13376 (scoped_switch_fork_info::scoped_switch_fork_info)
13377 (checkpoint_command, linux_fork_context): Adjust
13378 fork_save_infrun_state calls.
13379
e52c971f
PA		 133802019-03-06 Pedro Alves <palves@redhat.com>
13381
13382 * linux-fork.c (inf_has_multiple_thread_cb): Delete.
13383 (inf_has_multiple_threads): Return 'bool' and rewrite using
13384 inferior_info::threads().
13385
06974e6c
PA		 133862019-03-06 Pedro Alves <palves@redhat.com>
13387
13388 * linux-fork.c: Include <list>.
13389 (fork_list): Now a std::list instance.
13390 (fork_info): Add ctor, dtor, and in-class initialize all fields.
13391 (forks_exist_p, find_last_fork): Adjust.
13392 (new_fork): Delete.
13393 (one_fork_p): New.
13394 (add_fork): Adjust.
13395 (free_fork): Delete, folded into fork_info::~fork_info().
13396 (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
13397 Adjust.
13398 (init_fork_list): Delete.
13399 (linux_fork_killall, linux_fork_mourn_inferior)
13400 (linux_fork_detach, info_checkpoints_command): Adjust.
13401 (_initialize_linux_fork): No longer call init_fork_list.
13402
72f31aea
PA		 134032019-03-06 Pedro Alves <palves@redhat.com>
13404
13405 * linux-fork.c (new_fork): New, split out of ...
13406 (add_fork): ... this. Return void. Move "first fork" special
13407 case from here, to ...
13408 (checkpoint_command): ... here.
13409 * linux-linux.h (add_fork): Return void.
13410
efbecbc1
AB		 134112019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
13412
13413 * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
13414
0841c79a
AB		 134152019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
13416 Chris January <chris.january@arm.com>
13417 David Lecomber <david.lecomber@arm.com>
13418
13419 * f-exp.y: New token, UNOP_INTRINSIC.
13420 (exp): New pattern using UNOP_INTRINSIC token.
13421 (f77_keywords): Add 'abs' keyword.
13422 * f-lang.c: Add 'target-float.h' and 'math.h' includes.
13423 (value_from_host_double): New function.
13424 (evaluate_subexp_f): Support UNOP_ABS.
13425
4a270568
AB		 134262019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
13427
13428 * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
13429 types.
13430
067630bd
AB		 134312019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
13432
13433 * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
13434 * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
13435 * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
13436
3be47f7a
AB		 134372019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
13438
13439 * f-exp.y (convert_to_kind_type): Handle more type kinds.
13440
4d00f5d8
AB		 134412019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
13442 Chris January <chris.january@arm.com>
13443
13444 * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
13445 * f-exp.y: Define 'KIND' token.
13446 (exp): New pattern for KIND expressions.
13447 (ptype): Handle types with a kind extension.
13448 (direct_abs_decl): Extend to spot kind extensions.
13449 (f77_keywords): Add 'kind' to the list.
13450 (push_kind_type): New function.
13451 (convert_to_kind_type): New function.
13452 * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
13453 * parse.c (operator_length_standard): Likewise.
13454 * parser-defs.h (enum type_pieces): Add tp_kind.
13455 * std-operator.def: Add UNOP_KIND.
13456
e454224f
AB		 134572019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
13458
13459 * f-exp.y (f_parse): Set yydebug.
13460
9dad4a58
AB		 134612019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
13462
13463 * f-lang.c (evaluate_subexp_f): New function.
13464 (exp_descriptor_f): New global.
13465 (f_language_defn): Use exp_descriptor_f instead of
13466 exp_descriptor_standard.
13467
c8f91604
AB		 134682019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
13469
13470 * f-exp.y (struct token): Add comments.
13471 (dot_ops): Remove uppercase versions and the end marker.
13472 (f77_keywords): Likewise.
13473 (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
13474 entries in the dot_ops array are case insensitive, and use
13475 strncasecmp to compare strings. Also some whitespace cleanup in
13476 this area. Similar for the f77_keywords array, except entries in
13477 this list might be case sensitive.
13478
dd9f2c76
AB		 134792019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
13480
13481 * f-exp.y (struct f77_boolean_val): Add comments.
13482 (boolean_values): Remove uppercase versions, and end marker.
13483 (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
13484 and use strncasecmp to achieve case insensitivity. Additionally,
13485 perform whitespace cleanup around this code.
13486
67a3048c
TT		 134872019-03-06 Tom Tromey <tromey@adacore.com>
13488
13489 * remote-sim.c (gdbsim_target_open): Use result of
13490 gdb_argv::release.
13491
aa3cfbda
RB		 134922019-03-06 Richard Bunt <richard.bunt@arm.com>
13493 Dirk Schubert <dirk.schubert@arm.com>
13494 Chris January <chris.january@arm.com>
13495
13496 * eval.c (evaluate_subexp_standard): Call Fortran argument
13497 wrapping logic.
13498 * f-lang.c (struct value): A value which can be passed into a
13499 Fortran function call.
13500 (fortran_argument_convert): Wrap Fortran arguments in a pointer
13501 where appropriate.
13502 (struct type): Value ready for a Fortran function call.
13503 (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
13504 is needed.
13505 * f-lang.h (fortran_argument_convert): Declaration.
13506 (fortran_preserve_arg_pointer): Declaration.
13507 * infcall.c (value_arg_coerce): Call Fortran argument logic.
13508
ea38e5df
TT		 135092019-03-05 Tom Tromey <tromey@adacore.com>
13510
13511 * python/py-prettyprint.c (print_string_repr): Remove #if.
13512 * python/py-utils.c (unicode_to_encoded_string): Remove #if.
13513
06b5b831
TT		 135142019-03-05 Tom Tromey <tromey@adacore.com>
13515
13516 * target.c (the_dummy_target): Move later. Change type to
13517 "dummy_target".
13518 (initialize_targets): Don't initialize the_dummy_target.
13519
edbd9e45
TT		 135202019-03-05 Tom Tromey <tromey@adacore.com>
13521
13522 * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
13523 * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
13524
c119e040
TT		 135252019-03-05 Tom Tromey <tromey@adacore.com>
13526
13527 * windows-nat.c (windows_nat_target::attach)
13528 (windows_nat_target::detach): Don't call gdb_flush.
13529 * valprint.c (generic_val_print, val_print, val_print_string):
13530 Don't call gdb_flush.
13531 * utils.c (defaulted_query): Don't call gdb_flush.
13532 * typeprint.c (print_type_scalar): Don't call gdb_flush.
13533 * target.c (target_announce_detach): Don't call gdb_flush.
13534 * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
13535 * remote.c (extended_remote_target::attach): Don't call
13536 gdb_flush.
13537 * procfs.c (procfs_target::detach): Don't call gdb_flush.
13538 * printcmd.c (do_examine): Don't call gdb_flush.
13539 (info_display_command): Don't call gdb_flush.
13540 * p-valprint.c (pascal_val_print): Don't call gdb_flush.
13541 * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
13542 * memattr.c (info_mem_command): Don't call gdb_flush.
13543 * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
13544 * m2-valprint.c (m2_val_print): Don't call gdb_flush.
13545 * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
13546 * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
13547 * hppa-tdep.c (unwind_command): Don't call gdb_flush.
13548 * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
13549 (gnu_nat_target::detach): Don't call gdb_flush.
13550 * f-valprint.c (f_val_print): Don't call gdb_flush.
13551 * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
13552 * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
13553 * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
13554 gdb_flush.
13555 * c-valprint.c (c_val_print): Don't call gdb_flush.
13556 * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
13557
895dafa6
TT		 135582019-03-05 Tom Tromey <tromey@adacore.com>
13559
13560 * varobj.c (update_dynamic_varobj_children): Update.
13561 (install_default_visualizer): Use reset, not release.
13562 * value.c (set_internalvar): Update.
13563 * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
13564 * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
13565 ATTRIBUTE_UNUSED_RESULT.
13566
88a774b9
TT		 135672019-03-05 Tom Tromey <tromey@adacore.com>
13568
13569 * remote.c (class scoped_remote_fd) <release>: Add
13570 ATTRIBUTE_UNUSED_RESULT.
13571
4e4a8b93
TT		 135722019-03-05 Tom Tromey <tromey@adacore.com>
13573
13574 * macroexp.c (struct macro_buffer) <release>: Add
13575 ATTRIBUTE_UNUSED_RESULT.
13576
083eef1f
TT		 135772019-03-05 Tom Tromey <tromey@adacore.com>
13578
13579 * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
13580 * common/scoped_mmap.h (class scoped_mmap) <release>: Add
13581 ATTRIBUTE_UNUSED_RESULT.
13582
3cabd438
TT		 135832019-03-05 Tom Tromey <tromey@adacore.com>
13584
13585 * common/scoped_fd.h (class scoped_fd) <release>: Add
13586 ATTRIBUTE_UNUSED_RESULT.
13587
41e3300a
TT		 135882019-03-05 Tom Tromey <tromey@adacore.com>
13589
13590 * parser-defs.h (struct parser_state) <release>: Add
13591 ATTRIBUTE_UNUSED_RESULT.
13592
18cb7c9f
TT		 135932019-03-05 Tom Tromey <tromey@adacore.com>
13594
13595 * utils.h (class gdb_argv) <release>: Add
13596 ATTRIBUTE_UNUSED_RESULT.
13597 * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
13598
41fa577f
EZ		 135992019-03-02 Eli Zaretskii <eliz@gnu.org>
13600
a6a4b2c6
EZ		 13601 * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
13602 for-loop range, to avoid compiler warnings.
13603
13604 * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
13605 avoid compiler warnings about unused variables.
13606
742a7df5
EZ		 13607 * NEWS: Mention end of support for native debugging on MS-Windows
13608 before XP.
13609
41fa577f
EZ		 13610 PR gdb/24292
13611 * common/netstuff.c:
13612 * gdbserver/gdbreplay.c
13613 * gdbserver/remote-utils.c:
13614 * ser-tcp.c:
13615 * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
13616 Include ws2tcpip.h instead of wsiapi.h and winsock2.h. Redefine
13617 _WIN32_WINNT to 0x0501 if defined to a smaller value, as
13618 'getaddrinfo' and 'freeaddrinfo' were not available before
13619 Windows XP, and mingw.org's MinGW headers by default define
13620 _WIN32_WINNT to 0x500.
13621
827f438f
GB		 136222019-03-01 Gary Benson <gbenson@redhat.com>
13623
13624 * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
13625
92137da0
RO		 136262019-02-28 Brian Vandenberg <phantall@gmail.com>
13627 Rainer Orth <ro@CeBiTec.Uni-Bielefeld.DE>
13628
13629 PR gdb/8527
13630 * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
13631 set_sigint_trap, clear_sigint_trap.
13632
799efbe8
PW		 136332019-02-27 Philippe Waroquiers <philippe.waroquiers@skynet.be>
13634
13635 * target.c (target_detach): Clear the regcache and the
13636 frame cache.
13637
8ed25214
PA		 136382019-02-27 Pedro Alves <palves@redhat.com>
13639
13640 * utils.c (set_screen_size): When we cap the height/width sizes,
13641 tweak the corresponding command variable to show "unlimited":
13642
23031e31
SJ		 136432019-02-27 Saagar Jha <saagar@saagarjha.com>
13644 Pedro Alves <palves@redhat.com>
13645
13646 * utils.c (set_screen_size): Reduce "infinite" rows and columns
13647 before calling rl_set_screen_size.
13648
6c28e44a
TT		 136492019-02-27 Tom Tromey <tromey@adacore.com>
13650
13651 * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
13652 define.
13653 * python/py-value.c: Remove Python 2.4 workaround.
13654 * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
13655 workaround.
13656 * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
13657 Python 2.4 workaround.
13658 * python/python-internal.h: Remove Python 2.4 comment.
13659 (Py_ssize_t): Don't define.
13660 (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
13661 (gdb_Py_DECREF): Remove Python 2.4 workaround.
13662 (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
13663 (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
13664 * python/python.c (do_start_initialization): Remove Python 2.4
13665 workaround.
13666 * python/py-prettyprint.c (class dummy_python_frame): Remove.
13667 (print_children): Remove Python 2.4 workaround.
13668 * python/py-inferior.c (buffer_procs): Remove Python 2.4
13669 workaround.
13670 (CHARBUFFERPROC_NAME): Remove.
13671 * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
13672 Python 2.4 workaround.
13673
2c3fc25d 136742019-02-27 Kevin Buettner <kevinb@redhat.com>
799efbe8 13675
2c3fc25d
KB		 13676 * NEWS: Note minimum Python version.
13677
6ca62222
KB		 136782019-02-27 Kevin Buettner <kevinb@redhat.com>
13679
13680 * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
13681 code from these functions. Remove corresponding ifdefs. Use
13682 Py_buffer_up instead of explicit calls to PyBuffer_Release.
13683 Remove gotos and target of gotos.
13684 (infpy_search_memory): Likewise.
13685
f4bc7d2c
AB		 136862019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
13687
13688 * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
13689 (hppa_gdbarch_init): Don't register deleted functions with
13690 gdbarch.
13691
9734a586
AB		 136922019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
13693
13694 * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
13695 (h8300_unwind_sp): Delete.
13696 (h8300_dummy_id): Delete.
13697 (h8300_gdbarch_init): Don't register deleted functions with
13698 gdbarch.
13699
68b867f3
AB		 137002019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
13701
13702 * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
13703 (ft32_unwind_pc): Delete.
13704 (ft32_unwind_sp): Delete.
13705 (ft32_gdbarch_init): Don't register deleted functions with
13706 gdbarch.
13707
2fbe7ad0
AB		 137082019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
13709
13710 * gdb/frv-tdep.c (frv_dummy_id): Delete.
13711 (frv_unwind_pc): Delete.
13712 (frv_unwind_sp): Delete.
13713 (frv_gdbarch_init): Don't register deleted functions with
13714 gdbarch.
13715
76055cbe
AB		 137162019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
13717
13718 * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
13719 (riscv_unwind_pc): Delete.
13720 (riscv_unwind_sp): Delete.
13721 (riscv_gdbarch_init): Don't register deleted functions with
13722 gdbarch.
13723
4133e5a1
AB		 137242019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
13725
13726 * gdb/csky-tdep.c (csky_dummy_id): Delete.
13727 (csky_unwind_pc): Delete.
13728 (csky_unwind_sp): Delete.
13729 (csky_gdbarch_init): Don't register deleted functions with
13730 gdbarch.
13731
8010f576
AB		 137322019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
13733
13734 * gdb/cris-tdep.c (cris_dummy_id): Delete.
13735 (cris_unwind_pc): Delete.
13736 (cris_unwind_sp): Delete.
13737 (cris_gdbarch_init): Don't register deleted functions with
13738 gdbarch.
13739
b56bf084
AB		 137402019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
13741
13742 * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
13743 (bfin_unwind_pc): Delete.
13744 (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
13745
a19a650f
AB		 137462019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
13747
13748 * gdb/arm-tdep.c (arm_dummy_id): Delete.
13749 (arm_unwind_pc): Delete.
13750 (arm_unwind_sp): Delete.
13751 (arm_gdbarch_init): Don't register deleted functions with gdbarch.
13752
f8278c3c
AB		 137532019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
13754
13755 * gdb/arc-tdep.c (arc_dummy_id): Delete.
13756 (arc_unwind_pc): Delete.
13757 (arc_unwind_sp): Delete.
13758 (arc_gdbarch_init): Don't register deleted functions with gdbarch.
13759
480e46cf
AB		 137602019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
13761
13762 * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
13763 (alpha_unwind_pc): Delete.
13764 (alpha_gdbarch_init): Don't register deleted functions with
13765 gdbarch.
13766
7a995095
AB		 137672019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
13768
13769 * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
13770 (aarch64_unwind_pc): Delete.
13771 (aarch64_unwind_sp): Delete.
13772 (aarch64_gdbarch_init): Don't register deleted functions with
13773 gdbarch.
13774
bf9a735e
AB		 137752019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
13776
13777 * gdbtypes.c (type_align): Don't consider static members when
13778 computing structure alignment.
13779
5561fc30
AB		 137802019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
13781
13782 * arc-tdep.c (arc_type_align): Provide alignment for basic types,
13783 return 0 for other types.
13784 * arch-utils.c (default_type_align): Always return 0.
13785 * gdbarch.h: Regenerate.
13786 * gdbarch.sh (type_align): Extend comment.
13787 * gdbtypes.c (type_align): Add additional comments, always call
13788 gdbarch_type_align before applying the default rules.
13789 * i386-tdep.c (i386_type_align): Return 0 as the default rule,
13790 generic code will then apply a suitable default.
13791 * nios2-tdep.c (nios2_type_align): Provide alignment for basic
13792 types, return 0 for other types.
13793
9335e75a
JB		 137942019-02-27 Joel Brobecker <brobecker@adacore.com>
13795
13796 * NEWS: Create a new section for the next release branch.
13797 Rename the section of the current branch, now that it has
13798 been cut.
13799
3d34d8de
JB		 138002019-02-27 Joel Brobecker <brobecker@adacore.com>
13801
13802 GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
13803 * version.in: Bump version to 8.3.50.DATE-git.
13804
143420fb
SM		 138052019-02-26 Simon Marchi <simon.marchi@efficios.com>
13806
13807 * aix-thread.c (ptid_cmp): Remove unused variable.
13808 (get_signaled_thread): Likewise.
13809 (store_regs_user_thread): Likewise.
13810 (store_regs_kernel_thread): Likewise.
13811 (fetch_regs_kernel_thread): Remove shadowed variable.
13812
172fb711
AB		 138132019-02-26 Andrew Burgess <andrew.burgess@embecosm.com>
13814
13815 * features/riscv/32bit-cpu.xml: Add register numbers.
13816 * features/riscv/32bit-fpu.c: Regenerate.
13817 * features/riscv/32bit-fpu.xml: Add register numbers.
13818 * features/riscv/64bit-cpu.xml: Add register numbers.
13819 * features/riscv/64bit-fpu.c: Regenerate.
13820 * features/riscv/64bit-fpu.xml: Add register numbers.
13821
26c89782
KB		 138222019-02-26 Kevin Buettner <kevinb@redhat.com>
13823
af54ade9 13824 * NEWS: Mention two argument form of gdb.Value constructor.
fe07eca5
KB		 13825 * python/py-value.c (convert_buffer_and_type_to_value): New
13826 function.
13827 (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
13828 Add support for handling an optional second argument. Call
13829 convert_buffer_and_type_to_value as appropriate.
26c89782
KB		 13830 * python/python-internal.h (Py_buffer_deleter): New struct.
13831 (Py_buffer_up): New typedef.
13832
0f58c9e8
JB		 138332019-02-25 John Baldwin <jhb@FreeBSD.org>
13834
13835 * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
13836 instead of releasing ownership.
13837
0a0f4c01
JR		 138382019-02-25 Jordan Rupprecht <rupprecht@google.com>
13839
13840 * dwarf2read.c (open_and_init_dwp_file): Call
13841 elf_numsections instead of bfd_count_sections to initialize
13842 dwp_file->num_sections.
13843
cd5a152c
TT		 138442019-02-25 Tom Tromey <tromey@adacore.com>
13845
13846 * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
13847
8a6a8513
SDJ		 138482019-02-23 Sergio Durigan Junior <sergiodj@redhat.com>
13849
13850 * gcore.in: Add '--readnever' option when invoking GDB.
13851
04dcda9c
SM		 138522019-02-22 Simon Marchi <simon.marchi@polymtl.ca>
13853
13854 * MAINTAINERS: Update my email address.
13855
07bc701d
SM		 138562019-02-22 Simon Marchi <simon.marchi@polymtl.ca>
13857
13858 * build-id.c (build_id_to_debug_bfd_1): New function.
13859 (build_id_to_debug_bfd): Look for separate debug file in
13860 sysroot.
13861
c6f4a5d0
AB		 138622019-02-22 Andrew Burgess <andrew.burgess@embecosm.com>
13863
13864 * gdbarch.sh: Update the copyright year range that is placed into
13865 generated files.
13866
9600246d
KS		 138672019-02-22 Keith Seitz <keiths@redhat.com>
13868
13869 PR symtab/23853
13870 * linespec.c (create_sals_line_offset): Search for the default
13871 symtab's filename instead of its fullname.
13872
7557a514
AH		 138732019-02-21 Alan Hayward <alan.hayward@arm.com>
13874
13875 * NEWS: Update style defaults.
13876
ee2bcb0c
AH		 138772019-02-21 Alan Hayward <alan.hayward@arm.com>
13878
13879 * main.c (captured_main_1): Disable styling in batch mode.
13880
0c95f9ed
TT		 138812019-02-20 Tom Tromey <tom@tromey.com>
13882
13883 * symtab.c (symtab_symbol_info): Fix typos.
13884
c763b894
TT		 138852019-02-20 Tom Tromey <tromey@adacore.com>
13886
13887 * findcmd.c (_initialize_mem_search): Use upper case for
13888 metasyntactic variables.
13889
0ef8a082
AH		 138902019-02-20 Alan Hayward <alan.hayward@arm.com>
13891
13892 * aarch64-tdep.c (aarch64_add_reggroups): New function.
13893 (aarch64_gdbarch_init): Call aarch64_add_reggroups.
13894
6caa91b6
SM		 138952019-02-19 Simon Marchi <simon.marchi@polymtl.ca>
13896
13897 * top.h (source_file_name): Change to std::string.
13898 * top.c (source_file_name): Likewise.
13899 (command_line_input): Adjust.
13900 * cli/cli-script.c (script_from_file): Adjust.
13901
98814c6c
TT		 139022019-02-19 Tom Tromey <tromey@adacore.com>
13903
13904 * ravenscar-thread.c
13905 (ravenscar_thread_target::update_thread_list): Don't call
13906 ada_build_task_list.
13907 * ada-lang.h (ada_build_task_list): Don't declare.
13908 * ada-tasks.c (struct ada_tasks_inferior_data)
13909 <task_list_valid_p>: Now bool.
13910 (read_known_tasks, ada_task_list_changed)
13911 (ada_tasks_invalidate_inferior_data): Update.
13912 (read_known_tasks_array): Return bool.
13913 (read_known_tasks_list): Likewise.
13914 (read_known_tasks): Return void.
13915 (ada_build_task_list): Now static.
13916
70cd633e
AB		 139172019-02-18 Andrew Burgess <andrew.burgess@embecosm.com>
13918
13919 * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
13920 and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
13921
040b3e95
PW		 139222019-02-18 Philippe Waroquiers <philippe.waroquiers@skynet.be>
13923
13924 * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
13925 variant for ada_tasks_pspace_data_handle and
13926 ada_tasks_inferior_data_handle.
13927 (ada_tasks_pspace_data_cleanup): New function.
13928 (ada_tasks_inferior_data_cleanup): New function.
13929
9409233b
TT		 139302019-02-17 Tom Tromey <tom@tromey.com>
13931
13932 * macrotab.h (macro_source_fullname): Return a std::string.
13933 * macrotab.c (macro_include, check_for_redefinition)
13934 (macro_undef, macro_lookup_definition, foreach_macro)
13935 (foreach_macro_in_scope): Update.
13936 (macro_source_fullname): Return a std::string.
13937 * macrocmd.c (show_pp_source_pos): Update.
13938
6506371f
TT		 139392019-02-17 Tom Tromey <tom@tromey.com>
13940
13941 * macrocmd.c (show_pp_source_pos): Style the file names.
13942
0c820d67
TT		 139432019-02-17 Tom Tromey <tom@tromey.com>
13944
13945 PR tui/24197:
13946 * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
13947
a0087920
TT		 139482019-02-17 Tom Tromey <tom@tromey.com>
13949
13950 * ada-lang.c (user_select_syms): Use filtered printing.
13951 * utils.c (wrap_style): New global.
13952 (desired_style): Remove.
13953 (emit_style_escape): Add stream parameter.
13954 (set_output_style, reset_terminal_style, prompt_for_continue):
13955 Update.
13956 (flush_wrap_buffer): Only flush gdb_stdout.
13957 (wrap_here): Set wrap_style.
13958 (fputs_maybe_filtered): Clear the wrap buffer on exception. Don't
13959 treat escape sequences as a character. Change when wrap buffer is
13960 flushed.
13961 (fputs_styled): Do not set the output style when the default is
13962 requested.
13963 * ui-style.h (struct ui_file_style) <is_default>: New method.
13964 * source.c (print_source_lines_base): Emit escape sequences in one
13965 piece.
13966
75ba10dc
JB		 139672019-02-17 Joel Brobecker <brobecker@adacore.com>
13968
13969 * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
13970 integers and enumeration types.
13971
a2cd4f14
JB		 139722019-02-17 Joel Brobecker <brobecker@adacore.com>
13973
13974 * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
13975 instead of lookup_symbol_in_language
13976 (do_exact_match): New function.
13977 (ada_get_symbol_name_matcher): Return do_exact_match when
13978 doing a verbatim match.
13979
485b851b
TT		 139802019-02-15 Tom Tromey <tromey@adacore.com>
13981
13982 * ravenscar-thread.c (ravenscar_thread_target::resume)
13983 (ravenscar_thread_target::wait): Special case wildcard requests.
13984
0b790b1e
TT		 139852019-02-15 Tom Tromey <tromey@adacore.com>
13986
13987 * ravenscar-thread.c (base_ptid): Remove.
13988 (struct ravenscar_thread_target) <close>: New method.
13989 <m_base_ptid>: New member.
13990 <update_inferior_ptid, active_task, task_is_currently_active,
13991 runtime_initialized>: Declare methods.
13992 <ravenscar_thread_target>: Add constructor.
13993 (ravenscar_thread_target::task_is_currently_active)
13994 (ravenscar_thread_target::update_inferior_ptid)
13995 (ravenscar_runtime_initialized): Rename. Now methods.
13996 (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
13997 (ravenscar_thread_target::update_thread_list): Update.
13998 (ravenscar_thread_target::active_task): Now method.
13999 (ravenscar_thread_target::store_registers)
14000 (ravenscar_thread_target::prepare_to_store)
14001 (ravenscar_thread_target::prepare_to_store)
14002 (ravenscar_thread_target::mourn_inferior): Update.
14003 (ravenscar_inferior_created): Use "new" to create target.
14004 (ravenscar_thread_target::get_ada_task_ptid): Update.
14005 (_initialize_ravenscar): Don't initialize base_ptid.
14006 (ravenscar_ops): Remove global.
14007
dea57a62
TT		 140082019-02-15 Tom Tromey <tromey@adacore.com>
14009
14010 * target.h (push_target): Declare new overload.
14011 * target.c (push_target): New overload, taking an rvalue reference.
14012 * remote.c (remote_target::open_1): Use push_target overload.
14013 * corelow.c (core_target_open): Use push_target overload.
14014
989f3c58
TT		 140152019-02-15 Tom Tromey <tromey@adacore.com>
14016
14017 * ravenscar-thread.c (is_ravenscar_task)
14018 (ravenscar_task_is_currently_active): Return bool.
14019 (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
14020 (_initialize_ravenscar): Remove "(void)".
14021 (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
14022 Return bool.
14023
6cbcc006
TT		 140242019-02-15 Tom Tromey <tromey@adacore.com>
14025
14026 * ravenscar-thread.c (ravenscar_runtime_initializer)
14027 (has_ravenscar_runtime, get_running_thread_id)
14028 (ravenscar_thread_target::resume): Fix indentation.
14029
7657f14d
TT		 140302019-02-15 Tom Tromey <tromey@adacore.com>
14031
14032 * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
14033 from ravenscar_arch_ops.
14034 (sparc_ravenscar_ops::fetch_registers)
14035 (sparc_ravenscar_ops::store_registers): Now methods.
14036 (sparc_ravenscar_prepare_to_store): Remove.
14037 (sparc_ravenscar_ops): Redefine.
14038 * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
14039 methods and destructor. Remove members.
14040 * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
14041 (ravenscar_thread_target::store_registers)
14042 (ravenscar_thread_target::prepare_to_store): Update.
14043 * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
14044 Remove.
14045 (struct ppc_ravenscar_powerpc_ops): Derive from
14046 ravenscar_arch_ops.
14047 (ppc_ravenscar_powerpc_ops::fetch_registers)
14048 (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
14049 (ppc_ravenscar_powerpc_ops): Redefine.
14050 (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
14051 (ppc_ravenscar_e500_ops::fetch_registers)
14052 (ppc_ravenscar_e500_ops::store_registers): Now methods.
14053 (ppc_ravenscar_e500_ops): Redefine.
14054 * aarch64-ravenscar-thread.c
14055 (aarch64_ravenscar_generic_prepare_to_store): Remove.
14056 (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
14057 (aarch64_ravenscar_fetch_registers)
14058 (aarch64_ravenscar_store_registers): Now methods.
14059 (aarch64_ravenscar_ops): Redefine.
14060
5b6ea500
TT		 140612019-02-15 Tom Tromey <tromey@adacore.com>
14062
14063 * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
14064 (ravenscar_thread_target::stopped_by_hw_breakpoint)
14065 (ravenscar_thread_target::stopped_by_watchpoint)
14066 (ravenscar_thread_target::stopped_data_address)
14067 (ravenscar_thread_target::core_of_thread): Use scoped_restore.
14068
e397fd39
TT		 140692019-02-15 Tom Tromey <tromey@adacore.com>
14070
14071 * ravenscar-thread.c: Fix some typos.
14072
cc12f4a8
TT		 140732019-02-15 Philippe Waroquiers <philippe.waroquiers@skynet.be>
14074 Tom Tromey <tromey@adacore.com>
14075
14076 * ada-lang.c (ada_exception_sal): Change addr_string to a
14077 std::string.
14078 (create_ada_exception_catchpoint): Update.
14079
5f486660
TT		 140802019-02-15 Philippe Waroquiers <philippe.waroquiers@skynet.be>
14081 Tom Tromey <tromey@adacore.com>
14082
14083 * breakpoint.c (~bp_location): Rename from bp_location_dtor.
14084 (bp_location_ops): Remove.
14085 (base_breakpoint_allocate_location): Update.
14086 (free_bp_location): Update.
14087 * ada-lang.c (class ada_catchpoint_location)
14088 <ada_catchpoint_location>: Remove ops parameter.
14089 (ada_catchpoint_location_dtor): Remove.
14090 (ada_catchpoint_location_ops): Remove.
14091 (allocate_location_exception): Update.
14092 * breakpoint.h (struct bp_location_ops): Remove.
14093 (class bp_location) <bp_location>: Remove bp_location_ops
14094 parameter.
14095 <~bp_location>: Add destructor.
14096 <ops>: Remove.
14097
b671c7fb
TS		 140982019-02-14 Thomas Schwinge <thomas@codesourcery.com>
14099 Pedro Alves <palves@redhat.com>
14100
14101 * remote.c (remote_target::remote_parse_stop_reply): Avoid using
14102 'PATH_MAX'.
14103
8071c5ce
DM		 141042019-02-14 David Michael <fedora.dm0@gmail.com>
14105 Samuel Thibault <samuel.thibault@gnu.org>
14106 Thomas Schwinge <thomas@codesourcery.com>
14107
14108 * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
14109 (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
14110
b1041ae0
TS		 141112019-02-14 Thomas Schwinge <thomas@codesourcery.com>
14112
924514e1
TS		 14113 * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
14114 (check_empty): Use "const char *".
14115
c29ee8d4
TS		 14116 * gnu-nat.c (gnu_nat_target::detach): Instead of
14117 'detach_inferior (pid)' call
14118 'detach_inferior (find_inferior_pid (pid))'.
14119
6c6ef69f
TS		 14120 * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
14121 'nat/fork-inferior.o'.
14122 * gnu-nat.c: #include "nat/fork-inferior.h".
14123
2d0a338c
TS		 14124 * gnu-nat.c (gnu_nat_target::detach): Instead of
14125 'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
14126 * gnu-nat.h: #include "inf-child.h".
14127 * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
14128 'i386_gnu_nat_target::fetch_registers'.
14129 (gnu_store_registers): Rename/move to
14130 'i386_gnu_nat_target::store_registers'.
14131
cabb5f06
TS		 14132 * config/i386/nm-i386gnu.h: Don't "#include" any files.
14133 * gnu-nat.h (mach_thread_info): New function.
14134 * gnu-nat.c (thread_takeover_sc_cmd): Use it.
14135
b1041ae0
TS		 14136 * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
14137
2988d01e
KF		 141382019-02-14 Frederic Konrad <konrad@adacore.com>
14139
14140 * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
14141
c559d709
JB		 141422019-02-14 Joel Brobecker <brobecker@adacore.com>
14143
14144 * windows-nat.c (windows_add_thread): Add new parameter
14145 "main_thread_p" with default value set to false. Update
14146 function documentation as well as all callers.
14147 (windows_delete_thread): Likewise.
14148 (fake_create_process): Update call to windows_add_thread.
14149 (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
14150 <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
14151 <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
14152 call to windows_delete_thread.
14153
007024cc
SM		 141542019-02-13 Simon Marchi <simon.marchi@ericsson.com>
14155
14156 * MAINTAINERS: Add Andrew Burgess as global maintainer.
14157
f62318e9
JB		 141582019-02-12 John Baldwin <jhb@FreeBSD.org>
14159
14160 * symfile.c (find_separate_debug_file): Use canonical path of
14161 sysroot with child_path instead of gdb_sysroot if it is valid.
14162
cd4b7848
JB		 141632019-02-12 John Baldwin <jhb@FreeBSD.org>
14164
14165 * symfile.c (find_separate_debug_file): Use child_path to
14166 determine if an object file is under a sysroot.
14167
efac4bfe
JB		 141682019-02-12 John Baldwin <jhb@FreeBSD.org>
14169
14170 * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
14171 unittests/child-path-selftests.c.
14172 * common/pathstuff.c (child_path): New function.
14173 * common/pathstuff.h (child_path): New prototype.
14174 * unittests/child-path-selftests.c: New file.
14175
402d2bfe
JB		 141762019-02-12 John Baldwin <jhb@FreeBSD.org>
14177
14178 * symfile.c (find_separate_debug_file): Look for separate debug
14179 files in debug directories under the sysroot.
14180
1ed9f74e
PW		 141812019-02-12 Philippe Waroquiers <philippe.waroquiers@skynet.be>
14182
14183 * symtab.h (struct minimal_symbol data_p): New const method.
14184 (struct minimal_symbol text_p): Likewise.
14185 * symtab.c (output_source_filename): Use file name style
14186 to print file name.
14187 (print_symbol_info): Likewise.
14188 (print_msymbol_info): Use address style to print addresses.
14189 Use function name style to print executable text symbols.
14190 (expand_symtab_containing_pc): Use data_p.
14191 (find_pc_sect_compunit_symtab): Likewise.
14192
2636d81d
PW		 141932019-02-12 Philippe Waroquiers <philippe.waroquiers@skynet.be>
14194
14195 * breakpoint.c (describe_other_breakpoints): Use address style
14196 to print addresses.
14197 (say_where): Likewise.
14198
ac8c53cc
PW		 141992019-02-12 Philippe Waroquiers <philippe.waroquiers@skynet.be>
14200
14201 * ada-typeprint.c (print_func_type): Print function name
14202 style to print function name.
14203 * c-typeprint.c (c_print_type_1): Likewise.
14204
ea638c43
AH		 142052019-02-11 Alan Hayward <alan.hayward@arm.com>
14206
14207 * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
14208 for execve.
14209
ab759ca8
PW		 142102019-02-10 Philippe Waroquiers <philippe.waroquiers@skynet.be>
14211
14212 * c-exp.y (direct_abs_decl): Use emplace_back to record the
14213 type_stack.
14214
aff29d1c
JB		 142152019-02-10 Joel Brobecker <brobecker@adacore.com>
14216
14217 * ada-varobj.c (ada_value_is_changeable_p): Add handling of
14218 TYPE_CODE_REF types.
14219
617126bc
JW		 142202019-02-08 Jim Wilson <jimw@sifive.com>
14221
14222 * riscv-linux-tdep.c (riscv_linux_fregmap): New.
14223 (riscv_linux_fregset): New.
14224 (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
14225
46e3ed7f
TT		 142262019-02-07 Tom Tromey <tom@tromey.com>
14227
14228 * thread.c (thread_cancel_execution_command): Update.
14229 * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
14230 methods.
14231 (struct thread_fsm_ops): Remove.
14232 (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
14233 (thread_fsm_should_stop, thread_fsm_return_value)
14234 (thread_fsm_set_finished, thread_fsm_finished_p)
14235 (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
14236 Don't declare.
14237 * mi/mi-interp.c (mi_on_normal_stop_1): Update.
14238 * infrun.c (clear_proceed_status_thread)
14239 (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
14240 (print_stop_event): Update.
14241 * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
14242 Add constructor.
14243 (step_command_fsm_ops): Remove.
14244 (new_step_command_fsm): Remove.
14245 (step_1): Update.
14246 (step_command_fsm::should_stop): Rename from
14247 step_command_fsm_should_stop.
14248 (step_command_fsm::clean_up): Rename from
14249 step_command_fsm_clean_up.
14250 (step_command_fsm::do_async_reply_reason): Rename from
14251 step_command_fsm_async_reply_reason.
14252 (struct until_next_fsm): Inherit from thread_fsm. Add
14253 constructor.
14254 (until_next_fsm_ops): Remove.
14255 (new_until_next_fsm): Remove.
14256 (until_next_fsm::should_stop): Rename from
14257 until_next_fsm_should_stop.
14258 (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
14259 (until_next_fsm::do_async_reply_reason): Rename from
14260 until_next_fsm_async_reply_reason.
14261 (struct finish_command_fsm): Inherit from thread_fsm. Add
14262 constructor. Change type of breakpoint.
14263 (finish_command_fsm_ops): Remove.
14264 (new_finish_command_fsm): Remove.
14265 (finish_command_fsm::should_stop): Rename from
14266 finish_command_fsm_should_stop.
14267 (finish_command_fsm::clean_up): Rename from
14268 finish_command_fsm_clean_up.
14269 (finish_command_fsm::return_value): Rename from
14270 finish_command_fsm_return_value.
14271 (finish_command_fsm::do_async_reply_reason): Rename from
14272 finish_command_fsm_async_reply_reason.
14273 (finish_command): Update.
14274 * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
14275 Add constructor.
14276 (call_thread_fsm_ops): Remove.
14277 (call_thread_fsm::call_thread_fsm): Rename from
14278 new_call_thread_fsm.
14279 (call_thread_fsm::should_stop): Rename from
14280 call_thread_fsm_should_stop.
14281 (call_thread_fsm::should_notify_stop): Rename from
14282 call_thread_fsm_should_notify_stop.
14283 (run_inferior_call, call_function_by_hand_dummy): Update.
14284 * cli/cli-interp.c (should_print_stop_to_console): Update.
14285 * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
14286 Add constructor. Change type of location_breakpoint,
14287 caller_breakpoint.
14288 (until_break_fsm_ops): Remove.
14289 (new_until_break_fsm): Remove.
14290 (until_break_fsm::should_stop): Rename from
14291 until_break_fsm_should_stop.
14292 (until_break_fsm::clean_up): Rename from
14293 until_break_fsm_clean_up.
14294 (until_break_fsm::do_async_reply_reason): Rename from
14295 until_break_fsm_async_reply_reason.
14296 (until_break_command): Update.
14297 * thread-fsm.c: Remove.
14298 * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
14299
1a5c2598
TT		 143002019-02-07 Tom Tromey <tom@tromey.com>
14301
14302 * yy-remap.h: Add include guard.
14303 * xtensa-tdep.h: Add include guard.
14304 * xcoffread.h: Rename include guard.
14305 * varobj-iter.h: Add include guard.
14306 * tui/tui.h: Rename include guard.
14307 * tui/tui-winsource.h: Rename include guard.
14308 * tui/tui-wingeneral.h: Rename include guard.
14309 * tui/tui-windata.h: Rename include guard.
14310 * tui/tui-win.h: Rename include guard.
14311 * tui/tui-stack.h: Rename include guard.
14312 * tui/tui-source.h: Rename include guard.
14313 * tui/tui-regs.h: Rename include guard.
14314 * tui/tui-out.h: Rename include guard.
14315 * tui/tui-layout.h: Rename include guard.
14316 * tui/tui-io.h: Rename include guard.
14317 * tui/tui-hooks.h: Rename include guard.
14318 * tui/tui-file.h: Rename include guard.
14319 * tui/tui-disasm.h: Rename include guard.
14320 * tui/tui-data.h: Rename include guard.
14321 * tui/tui-command.h: Rename include guard.
14322 * tic6x-tdep.h: Add include guard.
14323 * target/waitstatus.h: Rename include guard.
14324 * target/wait.h: Rename include guard.
14325 * target/target.h: Rename include guard.
14326 * target/resume.h: Rename include guard.
14327 * target-float.h: Rename include guard.
14328 * stabsread.h: Add include guard.
14329 * rs6000-tdep.h: Add include guard.
14330 * riscv-fbsd-tdep.h: Add include guard.
14331 * regformats/regdef.h: Rename include guard.
14332 * record.h: Rename include guard.
14333 * python/python.h: Rename include guard.
14334 * python/python-internal.h: Rename include guard.
14335 * python/py-stopevent.h: Rename include guard.
14336 * python/py-ref.h: Rename include guard.
14337 * python/py-record.h: Rename include guard.
14338 * python/py-record-full.h: Rename include guard.
14339 * python/py-record-btrace.h: Rename include guard.
14340 * python/py-instruction.h: Rename include guard.
14341 * python/py-events.h: Rename include guard.
14342 * python/py-event.h: Rename include guard.
14343 * procfs.h: Add include guard.
14344 * proc-utils.h: Add include guard.
14345 * p-lang.h: Add include guard.
14346 * or1k-tdep.h: Rename include guard.
14347 * observable.h: Rename include guard.
14348 * nto-tdep.h: Rename include guard.
14349 * nat/x86-linux.h: Rename include guard.
14350 * nat/x86-linux-dregs.h: Rename include guard.
14351 * nat/x86-gcc-cpuid.h: Add include guard.
14352 * nat/x86-dregs.h: Rename include guard.
14353 * nat/x86-cpuid.h: Rename include guard.
14354 * nat/ppc-linux.h: Rename include guard.
14355 * nat/mips-linux-watch.h: Rename include guard.
14356 * nat/linux-waitpid.h: Rename include guard.
14357 * nat/linux-ptrace.h: Rename include guard.
14358 * nat/linux-procfs.h: Rename include guard.
14359 * nat/linux-osdata.h: Rename include guard.
14360 * nat/linux-nat.h: Rename include guard.
14361 * nat/linux-namespaces.h: Rename include guard.
14362 * nat/linux-btrace.h: Rename include guard.
14363 * nat/glibc_thread_db.h: Rename include guard.
14364 * nat/gdb_thread_db.h: Rename include guard.
14365 * nat/gdb_ptrace.h: Rename include guard.
14366 * nat/fork-inferior.h: Rename include guard.
14367 * nat/amd64-linux-siginfo.h: Rename include guard.
14368 * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
14369 * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
14370 * nat/aarch64-linux.h: Rename include guard.
14371 * nat/aarch64-linux-hw-point.h: Rename include guard.
14372 * mn10300-tdep.h: Add include guard.
14373 * mips-linux-tdep.h: Add include guard.
14374 * mi/mi-parse.h: Rename include guard.
14375 * mi/mi-out.h: Rename include guard.
14376 * mi/mi-main.h: Rename include guard.
14377 * mi/mi-interp.h: Rename include guard.
14378 * mi/mi-getopt.h: Rename include guard.
14379 * mi/mi-console.h: Rename include guard.
14380 * mi/mi-common.h: Rename include guard.
14381 * mi/mi-cmds.h: Rename include guard.
14382 * mi/mi-cmd-break.h: Rename include guard.
14383 * m2-lang.h: Add include guard.
14384 * location.h: Rename include guard.
14385 * linux-record.h: Rename include guard.
14386 * linux-nat.h: Add include guard.
14387 * linux-fork.h: Add include guard.
14388 * i386-darwin-tdep.h: Rename include guard.
14389 * hppa-linux-offsets.h: Add include guard.
14390 * guile/guile.h: Rename include guard.
14391 * guile/guile-internal.h: Rename include guard.
14392 * gnu-nat.h: Rename include guard.
14393 * gdb-stabs.h: Rename include guard.
14394 * frv-tdep.h: Add include guard.
14395 * f-lang.h: Add include guard.
14396 * event-loop.h: Add include guard.
14397 * darwin-nat.h: Rename include guard.
14398 * cp-abi.h: Rename include guard.
14399 * config/sparc/nm-sol2.h: Rename include guard.
14400 * config/nm-nto.h: Rename include guard.
14401 * config/nm-linux.h: Add include guard.
14402 * config/i386/nm-i386gnu.h: Rename include guard.
14403 * config/djgpp/nl_types.h: Rename include guard.
14404 * config/djgpp/langinfo.h: Rename include guard.
14405 * compile/gcc-cp-plugin.h: Add include guard.
14406 * compile/gcc-c-plugin.h: Add include guard.
14407 * compile/compile.h: Rename include guard.
14408 * compile/compile-object-run.h: Rename include guard.
14409 * compile/compile-object-load.h: Rename include guard.
14410 * compile/compile-internal.h: Rename include guard.
14411 * compile/compile-cplus.h: Rename include guard.
14412 * compile/compile-c.h: Rename include guard.
14413 * common/xml-utils.h: Rename include guard.
14414 * common/x86-xstate.h: Rename include guard.
14415 * common/version.h: Rename include guard.
14416 * common/vec.h: Rename include guard.
14417 * common/tdesc.h: Rename include guard.
14418 * common/selftest.h: Rename include guard.
14419 * common/scoped_restore.h: Rename include guard.
14420 * common/scoped_mmap.h: Rename include guard.
14421 * common/scoped_fd.h: Rename include guard.
14422 * common/safe-iterator.h: Rename include guard.
14423 * common/run-time-clock.h: Rename include guard.
14424 * common/refcounted-object.h: Rename include guard.
14425 * common/queue.h: Rename include guard.
14426 * common/ptid.h: Rename include guard.
14427 * common/print-utils.h: Rename include guard.
14428 * common/preprocessor.h: Rename include guard.
14429 * common/pathstuff.h: Rename include guard.
14430 * common/observable.h: Rename include guard.
14431 * common/netstuff.h: Rename include guard.
14432 * common/job-control.h: Rename include guard.
14433 * common/host-defs.h: Rename include guard.
14434 * common/gdb_wait.h: Rename include guard.
14435 * common/gdb_vecs.h: Rename include guard.
14436 * common/gdb_unlinker.h: Rename include guard.
14437 * common/gdb_unique_ptr.h: Rename include guard.
14438 * common/gdb_tilde_expand.h: Rename include guard.
14439 * common/gdb_sys_time.h: Rename include guard.
14440 * common/gdb_string_view.h: Rename include guard.
14441 * common/gdb_splay_tree.h: Rename include guard.
14442 * common/gdb_setjmp.h: Rename include guard.
14443 * common/gdb_ref_ptr.h: Rename include guard.
14444 * common/gdb_optional.h: Rename include guard.
14445 * common/gdb_locale.h: Rename include guard.
14446 * common/gdb_assert.h: Rename include guard.
14447 * common/filtered-iterator.h: Rename include guard.
14448 * common/filestuff.h: Rename include guard.
14449 * common/fileio.h: Rename include guard.
14450 * common/environ.h: Rename include guard.
14451 * common/common-utils.h: Rename include guard.
14452 * common/common-types.h: Rename include guard.
14453 * common/common-regcache.h: Rename include guard.
14454 * common/common-inferior.h: Rename include guard.
14455 * common/common-gdbthread.h: Rename include guard.
14456 * common/common-exceptions.h: Rename include guard.
14457 * common/common-defs.h: Rename include guard.
14458 * common/common-debug.h: Rename include guard.
14459 * common/cleanups.h: Rename include guard.
14460 * common/buffer.h: Rename include guard.
14461 * common/btrace-common.h: Rename include guard.
14462 * common/break-common.h: Rename include guard.
14463 * cli/cli-utils.h: Rename include guard.
14464 * cli/cli-style.h: Rename include guard.
14465 * cli/cli-setshow.h: Rename include guard.
14466 * cli/cli-script.h: Rename include guard.
14467 * cli/cli-interp.h: Rename include guard.
14468 * cli/cli-decode.h: Rename include guard.
14469 * cli/cli-cmds.h: Rename include guard.
14470 * charset-list.h: Add include guard.
14471 * buildsym-legacy.h: Rename include guard.
14472 * bfin-tdep.h: Add include guard.
14473 * ax.h: Rename include guard.
14474 * arm-linux-tdep.h: Add include guard.
14475 * arm-fbsd-tdep.h: Add include guard.
14476 * arch/xtensa.h: Rename include guard.
14477 * arch/tic6x.h: Add include guard.
14478 * arch/i386.h: Add include guard.
14479 * arch/arm.h: Rename include guard.
14480 * arch/arm-linux.h: Rename include guard.
14481 * arch/arm-get-next-pcs.h: Rename include guard.
14482 * arch/amd64.h: Add include guard.
14483 * arch/aarch64-insn.h: Rename include guard.
14484 * arch-utils.h: Rename include guard.
14485 * annotate.h: Add include guard.
14486 * amd64-darwin-tdep.h: Rename include guard.
14487 * aarch64-linux-tdep.h: Add include guard.
14488 * aarch64-fbsd-tdep.h: Add include guard.
14489 * aarch32-linux-nat.h: Add include guard.
14490
ab9268d2
PW		 144912019-02-06 Philippe Waroquiers <philippe.waroquiers@skynet.be>
14492
14493 * macrotab.c (macro_define_internal): New function that
14494 factorizes macro_define_object_internal and macro_define_function
14495 code.
14496 (macro_define_object_internal): Use macro_define_internal.
14497 (macro_define_function): Likewise.
14498
bb0da2b4
PW		 144992019-02-06 Philippe Waroquiers <philippe.waroquiers@skynet.be>
14500
14501 * macrocmd.c (extract_identifier): Return
14502 a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
14503 callers.
14504
424eb552
JB		 145052019-02-06 John Baldwin <jhb@FreeBSD.org>
14506
14507 * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
14508
1688cb29
TT		 145092019-02-05 Tom Tromey <tom@tromey.com>
14510
14511 * target.c (target_stack::unpush): Move assertion earlier.
14512
b5eba2d8
TT		 145132019-01-30 Tom Tromey <tom@tromey.com>
14514
14515 PR python/23615:
14516 * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
14517 (gdbpy_parse_and_eval): Likewise.
14518 * python/python-internal.h (gdbpy_allow_threads): New class.
14519
7054e2ff
JB		 145202019-01-28 John Baldwin <jhb@FreeBSD.org>
14521
14522 * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
14523 (aarch64_fbsd_fpregmap): Move earlier.
14524 (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
14525 (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
14526 instead of individual calls to trad_frame_set_reg_addr.
14527 * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
14528 earlier.
14529 (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
14530 (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
14531 instead of individual calls to trad_frame_set_reg_addr.
14532
36c25ffa
AH		 145332019-01-28 Alan Hayward <alan.hayward@arm.com>
14534
14535 * CONTRIBUTE: Replace contribution list with wiki link.
14536
a0707f3c
TT		 145372019-01-25 Tom Tromey <tom@tromey.com>
14538
14539 * Makefile.in (GDB_CFLAGS): Don't add -I for common.
14540
0747795c
TT		 145412019-01-25 Tom Tromey <tom@tromey.com>
14542
14543 * xtensa-linux-nat.c: Fix common/ includes.
14544 * xml-support.h: Fix common/ includes.
14545 * xml-support.c: Fix common/ includes.
14546 * x86-linux-nat.c: Fix common/ includes.
14547 * windows-nat.c: Fix common/ includes.
14548 * varobj.h: Fix common/ includes.
14549 * varobj.c: Fix common/ includes.
14550 * value.c: Fix common/ includes.
14551 * valops.c: Fix common/ includes.
14552 * utils.c: Fix common/ includes.
14553 * unittests/xml-utils-selftests.c: Fix common/ includes.
14554 * unittests/utils-selftests.c: Fix common/ includes.
14555 * unittests/unpack-selftests.c: Fix common/ includes.
14556 * unittests/tracepoint-selftests.c: Fix common/ includes.
14557 * unittests/style-selftests.c: Fix common/ includes.
14558 * unittests/string_view-selftests.c: Fix common/ includes.
14559 * unittests/scoped_restore-selftests.c: Fix common/ includes.
14560 * unittests/scoped_mmap-selftests.c: Fix common/ includes.
14561 * unittests/scoped_fd-selftests.c: Fix common/ includes.
14562 * unittests/rsp-low-selftests.c: Fix common/ includes.
14563 * unittests/parse-connection-spec-selftests.c: Fix common/
14564 includes.
14565 * unittests/optional-selftests.c: Fix common/ includes.
14566 * unittests/offset-type-selftests.c: Fix common/ includes.
14567 * unittests/observable-selftests.c: Fix common/ includes.
14568 * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
14569 * unittests/memrange-selftests.c: Fix common/ includes.
14570 * unittests/memory-map-selftests.c: Fix common/ includes.
14571 * unittests/lookup_name_info-selftests.c: Fix common/ includes.
14572 * unittests/function-view-selftests.c: Fix common/ includes.
14573 * unittests/environ-selftests.c: Fix common/ includes.
14574 * unittests/copy_bitwise-selftests.c: Fix common/ includes.
14575 * unittests/common-utils-selftests.c: Fix common/ includes.
14576 * unittests/cli-utils-selftests.c: Fix common/ includes.
14577 * unittests/array-view-selftests.c: Fix common/ includes.
14578 * ui-file.c: Fix common/ includes.
14579 * tui/tui-io.c: Fix common/ includes.
14580 * tracepoint.h: Fix common/ includes.
14581 * tracepoint.c: Fix common/ includes.
14582 * tracefile-tfile.c: Fix common/ includes.
14583 * top.h: Fix common/ includes.
14584 * top.c: Fix common/ includes.
14585 * thread.c: Fix common/ includes.
14586 * target/waitstatus.h: Fix common/ includes.
14587 * target/waitstatus.c: Fix common/ includes.
14588 * target.h: Fix common/ includes.
14589 * target.c: Fix common/ includes.
14590 * target-memory.c: Fix common/ includes.
14591 * target-descriptions.c: Fix common/ includes.
14592 * symtab.h: Fix common/ includes.
14593 * symfile.c: Fix common/ includes.
14594 * stap-probe.c: Fix common/ includes.
14595 * spu-linux-nat.c: Fix common/ includes.
14596 * sparc-nat.c: Fix common/ includes.
14597 * source.c: Fix common/ includes.
14598 * solib.c: Fix common/ includes.
14599 * solib-target.c: Fix common/ includes.
14600 * ser-unix.c: Fix common/ includes.
14601 * ser-tcp.c: Fix common/ includes.
14602 * ser-pipe.c: Fix common/ includes.
14603 * ser-base.c: Fix common/ includes.
14604 * selftest-arch.c: Fix common/ includes.
14605 * s12z-tdep.c: Fix common/ includes.
14606 * rust-exp.y: Fix common/ includes.
14607 * rs6000-aix-tdep.c: Fix common/ includes.
14608 * riscv-tdep.c: Fix common/ includes.
14609 * remote.c: Fix common/ includes.
14610 * remote-notif.h: Fix common/ includes.
14611 * remote-fileio.h: Fix common/ includes.
14612 * remote-fileio.c: Fix common/ includes.
14613 * regcache.h: Fix common/ includes.
14614 * regcache.c: Fix common/ includes.
14615 * record-btrace.c: Fix common/ includes.
14616 * python/python.c: Fix common/ includes.
14617 * python/py-type.c: Fix common/ includes.
14618 * python/py-inferior.c: Fix common/ includes.
14619 * progspace.h: Fix common/ includes.
14620 * producer.c: Fix common/ includes.
14621 * procfs.c: Fix common/ includes.
14622 * proc-api.c: Fix common/ includes.
14623 * printcmd.c: Fix common/ includes.
14624 * ppc-linux-nat.c: Fix common/ includes.
14625 * parser-defs.h: Fix common/ includes.
14626 * osdata.c: Fix common/ includes.
14627 * obsd-nat.c: Fix common/ includes.
14628 * nat/x86-linux.c: Fix common/ includes.
14629 * nat/x86-linux-dregs.c: Fix common/ includes.
14630 * nat/x86-dregs.h: Fix common/ includes.
14631 * nat/x86-dregs.c: Fix common/ includes.
14632 * nat/ppc-linux.c: Fix common/ includes.
14633 * nat/mips-linux-watch.h: Fix common/ includes.
14634 * nat/mips-linux-watch.c: Fix common/ includes.
14635 * nat/linux-waitpid.c: Fix common/ includes.
14636 * nat/linux-ptrace.h: Fix common/ includes.
14637 * nat/linux-ptrace.c: Fix common/ includes.
14638 * nat/linux-procfs.c: Fix common/ includes.
14639 * nat/linux-personality.c: Fix common/ includes.
14640 * nat/linux-osdata.c: Fix common/ includes.
14641 * nat/linux-namespaces.c: Fix common/ includes.
14642 * nat/linux-btrace.h: Fix common/ includes.
14643 * nat/linux-btrace.c: Fix common/ includes.
14644 * nat/fork-inferior.c: Fix common/ includes.
14645 * nat/amd64-linux-siginfo.c: Fix common/ includes.
14646 * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
14647 * nat/aarch64-linux.c: Fix common/ includes.
14648 * nat/aarch64-linux-hw-point.h: Fix common/ includes.
14649 * nat/aarch64-linux-hw-point.c: Fix common/ includes.
14650 * namespace.h: Fix common/ includes.
14651 * mips-linux-tdep.c: Fix common/ includes.
14652 * minsyms.c: Fix common/ includes.
14653 * mi/mi-parse.h: Fix common/ includes.
14654 * mi/mi-main.c: Fix common/ includes.
14655 * mi/mi-cmd-env.c: Fix common/ includes.
14656 * memrange.h: Fix common/ includes.
14657 * memattr.c: Fix common/ includes.
14658 * maint.h: Fix common/ includes.
14659 * maint.c: Fix common/ includes.
14660 * main.c: Fix common/ includes.
14661 * machoread.c: Fix common/ includes.
14662 * location.c: Fix common/ includes.
14663 * linux-thread-db.c: Fix common/ includes.
14664 * linux-nat.c: Fix common/ includes.
14665 * linux-fork.c: Fix common/ includes.
14666 * inline-frame.c: Fix common/ includes.
14667 * infrun.c: Fix common/ includes.
14668 * inflow.c: Fix common/ includes.
14669 * inferior.h: Fix common/ includes.
14670 * inferior.c: Fix common/ includes.
14671 * infcmd.c: Fix common/ includes.
14672 * inf-ptrace.c: Fix common/ includes.
14673 * inf-child.c: Fix common/ includes.
14674 * ia64-linux-nat.c: Fix common/ includes.
14675 * i387-tdep.c: Fix common/ includes.
14676 * i386-tdep.c: Fix common/ includes.
14677 * i386-linux-tdep.c: Fix common/ includes.
14678 * i386-linux-nat.c: Fix common/ includes.
14679 * i386-go32-tdep.c: Fix common/ includes.
14680 * i386-fbsd-tdep.c: Fix common/ includes.
14681 * i386-fbsd-nat.c: Fix common/ includes.
14682 * guile/scm-type.c: Fix common/ includes.
14683 * guile/guile.c: Fix common/ includes.
14684 * go32-nat.c: Fix common/ includes.
14685 * gnu-nat.c: Fix common/ includes.
14686 * gdbthread.h: Fix common/ includes.
14687 * gdbarch-selftests.c: Fix common/ includes.
14688 * gdb_usleep.c: Fix common/ includes.
14689 * gdb_select.h: Fix common/ includes.
14690 * gdb_bfd.c: Fix common/ includes.
14691 * gcore.c: Fix common/ includes.
14692 * fork-child.c: Fix common/ includes.
14693 * findvar.c: Fix common/ includes.
14694 * fbsd-nat.c: Fix common/ includes.
14695 * event-top.c: Fix common/ includes.
14696 * event-loop.c: Fix common/ includes.
14697 * dwarf2read.c: Fix common/ includes.
14698 * dwarf2loc.c: Fix common/ includes.
14699 * dwarf2-frame.c: Fix common/ includes.
14700 * dwarf-index-cache.c: Fix common/ includes.
14701 * dtrace-probe.c: Fix common/ includes.
14702 * disasm-selftests.c: Fix common/ includes.
14703 * defs.h: Fix common/ includes.
14704 * csky-tdep.c: Fix common/ includes.
14705 * cp-valprint.c: Fix common/ includes.
14706 * cp-support.h: Fix common/ includes.
14707 * cp-support.c: Fix common/ includes.
14708 * corelow.c: Fix common/ includes.
14709 * completer.h: Fix common/ includes.
14710 * completer.c: Fix common/ includes.
14711 * compile/compile.c: Fix common/ includes.
14712 * compile/compile-loc2c.c: Fix common/ includes.
14713 * compile/compile-cplus-types.c: Fix common/ includes.
14714 * compile/compile-cplus-symbols.c: Fix common/ includes.
14715 * command.h: Fix common/ includes.
14716 * cli/cli-dump.c: Fix common/ includes.
14717 * cli/cli-cmds.c: Fix common/ includes.
14718 * charset.c: Fix common/ includes.
14719 * build-id.c: Fix common/ includes.
14720 * btrace.h: Fix common/ includes.
14721 * btrace.c: Fix common/ includes.
14722 * breakpoint.h: Fix common/ includes.
14723 * breakpoint.c: Fix common/ includes.
14724 * ax.h:
14725 (enum agent_op): Fix common/ includes.
14726 * ax-general.c (struct aop_map): Fix common/ includes.
14727 * ax-gdb.c: Fix common/ includes.
14728 * auxv.c: Fix common/ includes.
14729 * auto-load.c: Fix common/ includes.
14730 * arm-tdep.c: Fix common/ includes.
14731 * arch/riscv.c: Fix common/ includes.
14732 * arch/ppc-linux-common.c: Fix common/ includes.
14733 * arch/i386.c: Fix common/ includes.
14734 * arch/arm.c: Fix common/ includes.
14735 * arch/arm-linux.c: Fix common/ includes.
14736 * arch/arm-get-next-pcs.c: Fix common/ includes.
14737 * arch/amd64.c: Fix common/ includes.
14738 * arch/aarch64.c: Fix common/ includes.
14739 * arch/aarch64-insn.c: Fix common/ includes.
14740 * arch-utils.c: Fix common/ includes.
14741 * amd64-windows-tdep.c: Fix common/ includes.
14742 * amd64-tdep.c: Fix common/ includes.
14743 * amd64-sol2-tdep.c: Fix common/ includes.
14744 * amd64-obsd-tdep.c: Fix common/ includes.
14745 * amd64-nbsd-tdep.c: Fix common/ includes.
14746 * amd64-linux-tdep.c: Fix common/ includes.
14747 * amd64-linux-nat.c: Fix common/ includes.
14748 * amd64-fbsd-tdep.c: Fix common/ includes.
14749 * amd64-fbsd-nat.c: Fix common/ includes.
14750 * amd64-dicos-tdep.c: Fix common/ includes.
14751 * amd64-darwin-tdep.c: Fix common/ includes.
14752 * agent.c: Fix common/ includes.
14753 * ada-lang.h: Fix common/ includes.
14754 * ada-lang.c: Fix common/ includes.
14755 * aarch64-tdep.c: Fix common/ includes.
14756
2f5c153e
TT		 147572019-01-25 Tom Tromey <tom@tromey.com>
14758
14759 * common/create-version.sh: Use common/version.h.
14760
adc6a863
PA		 147612019-01-24 Pedro Alves <palves@redhat.com>
14762
14763 * infrun.c (signal_stop, signal_print, signal_program)
14764 (signal_catch, signal_pass): Now arrays instead of pointers.
14765 (update_signals_program_target, do_target_resume)
14766 (signal_catch_update, handle_command, _initialize_infrun): Adjust.
14767 * linux-nat.c (linux_nat_target::pass_signals)
14768 (linux_nat_target::create_inferior, linux_nat_target::attach):
14769 Adjust.
14770 * linux-nat.h (linux_nat_target::pass_signals): Adjust.
14771 * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
14772 * procfs.c (procfs_target::pass_signals): Adjust.
14773 * record-full.c (record_full_target::resume): Adjust.
14774 * remote.c (remote_target::pass_signals)
14775 (remote_target::program_signals): Adjust.
14776 * target-debug.h (target_debug_print_signals): Now takes a
14777 gdb::array_view as parameter. Adjust.
14778 * target.h (target_ops) <pass_signals, program_signals>: Replace
14779 pointer and length parameters with gdb::array_view.
14780 (target_pass_signals, target_program_signals): Likewise.
14781 * target-delegates.c: Regenerate.
14782
3046d67a
PA		 147832019-01-24 Pedro Alves <palves@redhat.com>
14784
14785 * common/forward-scope-exit.h
14786 (forward_scope_exit::forward_scope_exit): Pass arguments to
14787 m_bind_function directly, instead of creating a std::bind and
14788 copying that.
14789
353229bf
AH		 147902019-01-24 Alan Hayward <alan.hayward@arm.com>
14791
14792 * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
14793 for static members.
14794 (pass_in_v_vfp_candidate): Likewise.
14795
311dc83a
TT		 147962019-01-23 Tom Tromey <tom@tromey.com>
14797 Pedro Alves <palves@redhat.com>
14798
14799 * regcache.c (class regcache_invalidator): Remove.
14800 (regcache::raw_write): Use make_scope_exit.
14801
296bd123
TT		 148022019-01-23 Tom Tromey <tom@tromey.com>
14803
14804 * ui-out.h (class ui_out_emit_type): Update comment.
14805
979a0d13
TT		 148062019-01-23 Tom Tromey <tom@tromey.com>
14807
14808 * infrun.c (fetch_inferior_event): Update comment.
14809
d238133d
TT		 148102019-01-23 Tom Tromey <tom@tromey.com>
14811 Pedro Alves <palves@redhat.com>
14812
14813 * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
14814 parameter.
14815 (fetch_inferior_event): Use SCOPE_EXIT.
14816
14817
9885e6bb
TT		 148182019-01-23 Tom Tromey <tom@tromey.com>
14819 Pedro Alves <palves@redhat.com>
14820
14821 * infrun.c (disable_thread_events): Delete.
14822 (stop_all_threads): Use SCOPE_EXIT.
14823
286526c1
TT		 148242019-01-23 Tom Tromey <tom@tromey.com>
14825 Pedro Alves <palves@redhat.com>
14826
14827 * symfile.c: Include forward-scope-exit.h.
14828 (clear_symtab_users_cleanup): Replace forward declaration with
14829 a FORWARD_SCOPE_EXIT.
14830 (syms_from_objfile_1): Use the forward_scope_exit and
14831 gdb::optional instead of cleanup_function.
14832 (reread_symbols): Use the forward_scope_exit instead of
14833 cleanup_function.
14834 (clear_symtab_users_cleanup): Remove function.
14835
1db93f14
TT		 148362019-01-23 Tom Tromey <tom@tromey.com>
14837 Pedro Alves <palves@redhat.com>
14838
14839 * linux-nat.c: Include scope-exit.h.
14840 (cleanup_target_stop): Remove.
14841 (linux_nat_target::static_tracepoint_markers_by_strid): Use
14842 SCOPE_EXIT.
14843
2cc83d1e
TT		 148442019-01-23 Tom Tromey <tom@tromey.com>
14845 Pedro Alves <palves@redhat.com>
14846
14847 * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
14848 (call_function_by_hand_dummy): Use SCOPE_EXIT.
14849
694c6bf5
TT		 148502019-01-23 Tom Tromey <tom@tromey.com>
14851 Andrew Burgess <andrew.burgess@embecosm.com>
14852 Pedro Alves <palves@redhat.com>
14853
14854 * infrun.c (fetch_inferior_event): Use scope_exit.
14855 * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
14856 * top.c (execute_command): Use scope_exit.
14857 * breakpoint.c (bpstat_do_actions): Use scope_exit.
14858 * utils.c (do_bpstat_clear_actions_cleanup)
14859 (make_bpstat_clear_actions_cleanup): Remove.
14860
4c41382a
TT		 148612019-01-23 Tom Tromey <tom@tromey.com>
14862 Pedro Alves <palves@redhat.com>
14863
14864 * infrun.c: Include "common/scope-exit.h"
14865 (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
14866 (wait_for_inferior): Use SCOPE_EXIT.
14867 (fetch_inferior_event): Use scope_exit.
14868
89f8fb50
TT		 148692019-01-23 Tom Tromey <tom@tromey.com>
14870 Pedro Alves <palves@redhat.com>
14871
14872 * breakpoint.c (create_breakpoint): Remove cleanup.
14873
5419bdae
TT		 148742019-01-23 Tom Tromey <tom@tromey.com>
14875 Andrew Burgess <andrew.burgess@embecosm.com>
14876 Pedro Alves <palves@redhat.com>
14877
e587ef42
PA		 148782019-01-23 Pedro Alves <palves@redhat.com>
14879
14880 * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
14881
77f0e74c
PA		 148822019-01-23 Pedro Alves <palves@redhat.com>
14883 Andrew Burgess <andrew.burgess@embecosm.com>
14884
14885 * gdbthread.h: Include "common/forward-scope-exit.h".
14886 (scoped_finish_thread_state): Redefine custom class in terms of
14887 forward_scope_exit.
14888
5b9b3e53
PA		 148892019-01-23 Pedro Alves <palves@redhat.com>
14890 Andrew Burgess <andrew.burgess@embecosm.com>
14891
14892 * common/forward-scope-exit.h: New file.
14893
54b65c9b
PA		 148942019-01-23 Pedro Alves <palves@redhat.com>
14895 Andrew Burgess <andrew.burgess@embecosm.com>
14896 Tom Tromey <tom@tromey.com>
14897
14898 * common/scope-exit.h: New file.
14899
cf08fb29
PA		 149002019-01-23 Pedro Alves <palves@redhat.com>
14901
14902 * common/preprocessor.h (ESC): Rename to ...
14903 (ESC_PARENS): ... this.
14904 * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
14905 (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
14906
ae73e2e2
TT		 149072019-01-23 Tom Tromey <tom@tromey.com>
14908
14909 * language.h (class scoped_switch_to_sym_language_if_auto):
14910 Initialize m_lang in both cases.
14911
6594e122
AH		 149122019-01-23 Alan Hayward <alan.hayward@arm.com>
14913
14914 * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
14915 with XCNEW.
14916
a7c9855d
TT		 149172019-01-22 Tom Tromey <tom@tromey.com>
14918
14919 * corelow.c: Do not include sys/file.h.
14920
93cc1d53
TT		 149212019-01-22 Tom Tromey <tom@tromey.com>
14922
14923 * tui/tui-wingeneral.h: Include gdb_curses.h.
14924
38561778
TT		 149252019-01-22 Tom Tromey <tom@tromey.com>
14926
14927 * source-cache.h (class source_cache) <get_source_lines,
14928 get_plain_source_lines, extract_lines>: Rename "lines" parameter.
14929
37b3ab5b
TT		 149302019-01-22 Tom Tromey <tom@tromey.com>
14931
14932 * remote-fileio.h (struct remote_target): Declare.
14933
3fabc016
TT		 149342019-01-22 Tom Tromey <tom@tromey.com>
14935
14936 * python/py-arch.c: Do not include py-ref.h.
14937 * python/py-bpevent.c: Do not include py-ref.h.
14938 * python/py-cmd.c: Do not include py-ref.h.
14939 * python/py-continueevent.c: Do not include py-ref.h.
14940 * python/py-event.h: Do not include py-ref.h.
14941 * python/py-evtregistry.c: Do not include py-ref.h.
14942 * python/py-finishbreakpoint.c: Do not include py-ref.h.
14943 * python/py-frame.c: Do not include py-ref.h.
14944 * python/py-framefilter.c: Do not include py-ref.h.
14945 * python/py-function.c: Do not include py-ref.h.
14946 * python/py-infevents.c: Do not include py-ref.h.
14947 * python/py-linetable.c: Do not include py-ref.h.
14948 * python/py-objfile.c: Do not include py-ref.h.
14949 * python/py-param.c: Do not include py-ref.h.
14950 * python/py-prettyprint.c: Do not include py-ref.h.
14951 * python/py-progspace.c: Do not include py-ref.h.
14952 * python/py-symbol.c: Do not include py-ref.h.
14953 * python/py-symtab.c: Do not include py-ref.h.
14954 * python/py-type.c: Do not include py-ref.h.
14955 * python/py-unwind.c: Do not include py-ref.h.
14956 * python/py-utils.c: Do not include py-ref.h.
14957 * python/py-value.c: Do not include py-ref.h.
14958 * python/py-varobj.c: Do not include py-ref.h.
14959 * python/py-xmethods.c: Do not include py-ref.h.
14960 * python/python.c: Do not include py-ref.h.
14961 * varobj.c: Do not include py-ref.h.
14962
6b4d7774
TT		 149632019-01-22 Tom Tromey <tom@tromey.com>
14964
14965 * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
14966 keyword for bcache.
14967
7af7e9b5
TT		 149682019-01-22 Tom Tromey <tom@tromey.com>
14969
14970 * compile/compile-cplus-types.c: Remove a comment by #include.
14971
951d1049
TT		 149722019-01-22 Tom Tromey <tom@tromey.com>
14973
14974 * compile/gcc-c-plugin.h: Include compile-internal.h.
14975
d65d5705
TT		 149762019-01-22 Tom Tromey <tom@tromey.com>
14977
14978 * stabsread.c (EXTERN): Do not define.
14979 (symnum, next_symbol_text_func, processing_gcc_compilation)
14980 (within_function, global_sym_chain, global_stabs)
14981 (previous_stab_code, this_object_header_files)
14982 (n_this_object_header_files)
14983 (n_allocated_this_object_header_files): Define.
14984 * stabsread.h (EXTERN): Never define. Use "extern".
14985
b6fb1ee5
PW		 149862019-01-22 Philippe Waroquiers <philippe.waroquiers@skynet.be>
14987
14988 * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
14989 history_value.
14990
be6d4f74
TT		 149912019-01-21 Tom Tromey <tom@tromey.com>
14992
14993 * ui-out.c: Fix includes.
14994 * tui/tui-source.c: Fix includes.
14995 * target.c: Fix includes.
14996 * remote.c: Fix includes.
14997 * regcache.c: Fix includes.
14998 * python/py-block.c: Fix includes.
14999 * printcmd.c: Fix includes.
15000 * or1k-tdep.c: Fix includes.
15001 * mi/mi-main.c: Fix includes.
15002 * m32r-tdep.c: Fix includes.
15003 * csky-tdep.c: Fix includes.
15004 * compile/compile-cplus-types.c: Fix includes.
15005 * cli/cli-interp.c: Fix includes.
15006
73021deb
AH		 150072019-01-21 Alan Hayward <alan.hayward@arm.com>
15008
15009 * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
15010 for padding.
15011
7932255d
TT		 150122019-01-16 Tom Tromey <tom@tromey.com>
15013
15014 * objfiles.h (struct minimal_symbol_iterator): Rename. Move
15015 earlier.
15016 (struct objfile) <msymbols_range>: Move from top level.
15017 <msymbols>: New method.
15018 (class objfile_msymbols): Remove.
15019 * symtab.c (default_collect_symbol_completion_matches_break_on):
15020 Update.
15021 * symmisc.c (dump_msymbols): Update.
15022 * stabsread.c (scan_file_globals): Update.
15023 * objc-lang.c (info_selectors_command, info_classes_command)
15024 (find_methods): Update.
15025 * minsyms.c (find_solib_trampoline_target): Update.
15026 * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
15027 * coffread.c (coff_symfile_read): Update.
15028 * ada-lang.c (ada_lookup_simple_minsym)
15029 (ada_collect_symbol_completion_matches): Update.
15030
604b1bfb
TT		 150312019-01-16 Tom Tromey <tom@tromey.com>
15032
15033 * objfiles.h (class objfile_msymbols) <iterator>: Change argument
15034 type. Remove no-argument constructor.
15035 <iterator::operator++>: Simplify.
15036 <begin>: Update.
15037 <end>: Use minimal_symbol_count.
15038
f252c6d5
TT		 150392019-01-16 Tom Tromey <tom@tromey.com>
15040
15041 * objfiles.h (struct objfile) <psymtabs>: New method.
15042 (class objfile_psymtabs): Remove.
15043 * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
15044 typedef.
15045 <range>: New method.
15046 (require_partial_symbols): Change return type.
15047 * psymtab.c (require_partial_symbols)
15048 (psym_expand_symtabs_matching): Update.
15049 * mdebugread.c (parse_partial_symbols): Update.
15050 * dbxread.c (dbx_end_psymtab): Update.
15051
b669c953
TT		 150522019-01-15 Tom Tromey <tom@tromey.com>
15053
15054 * symtab.c (lookup_objfile_from_block)
15055 (lookup_symbol_in_objfile_symtabs)
15056 (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
15057 (find_line_symtab, info_sources_command)
15058 (default_collect_symbol_completion_matches_break_on)
15059 (make_source_files_completion_list): Update.
15060 * symmisc.c (print_objfile_statistics, dump_objfile)
15061 (maintenance_print_symbols, maintenance_info_symtabs)
15062 (maintenance_check_symtabs, maintenance_info_line_tables):
15063 Update.
15064 * source.c (select_source_symtab)
15065 (forget_cached_source_info_for_objfile): Update.
15066 * objfiles.h (class objfile_compunits): Remove.
15067 (struct objfile) <compunits_range>: New typedef.
15068 (compunits): New method.
15069 * objfiles.c (objfile_relocate1): Update.
15070 * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
15071 * maint.c (count_symtabs_and_blocks): Update.
15072 * linespec.c (iterate_over_all_matching_symtabs): Update.
15073 * cp-support.c (add_symbol_overload_list_qualified): Update.
15074 * coffread.c (coff_symtab_read): Update.
15075 * ada-lang.c (add_nonlocal_symbols)
15076 (ada_collect_symbol_completion_matches)
15077 (ada_add_global_exceptions): Update.
15078
7e955d83
TT		 150792019-01-15 Tom Tromey <tom@tromey.com>
15080
15081 * progspace.h (program_space) <objfiles_safe_range>: New
15082 typedef.
15083 <objfiles_safe>: New method.
15084 * objfiles.h (class all_objfiles_safe): Remove.
15085 * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
15086 * jit.c (jit_inferior_exit_hook): Update.
15087
2030c079
TT		 150882019-01-17 Tom Tromey <tom@tromey.com>
15089
15090 * progspace.h (program_space) <objfiles_range>: New typedef.
15091 <objfiles>: New method.
15092 <objfiles_head>: Rename from objfiles.
15093 (object_files): Update.
15094 * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
15095 * guile/scm-pretty-print.c
15096 (ppscm_find_pretty_printer_from_objfiles): Update.
15097 * guile/scm-objfile.c (gdbscm_objfiles): Update.
15098 * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
15099 Update.
15100 * python/py-progspace.c (pspy_get_objfiles): Update.
15101 * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
15102 Update.
15103 * python/py-objfile.c (objfpy_lookup_objfile_by_name)
15104 (objfpy_lookup_objfile_by_build_id): Update.
15105 * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
15106 * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
15107 Update.
15108 * symtab.c (iterate_over_symtabs, matching_obj_sections)
15109 (expand_symtab_containing_pc, lookup_objfile_from_block)
15110 (lookup_static_symbol, basic_lookup_transparent_type)
15111 (find_pc_sect_compunit_symtab, find_symbol_at_address)
15112 (find_line_symtab, info_sources_command)
15113 (default_collect_symbol_completion_matches_break_on)
15114 (make_source_files_completion_list, find_main_name): Update.
15115 * symmisc.c (print_symbol_bcache_statistics)
15116 (print_objfile_statistics, maintenance_print_symbols)
15117 (maintenance_print_msymbols, maintenance_print_objfiles)
15118 (maintenance_info_symtabs, maintenance_check_symtabs)
15119 (maintenance_expand_symtabs, maintenance_info_line_tables):
15120 Update.
15121 * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
15122 (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
15123 (map_overlay_command, unmap_overlay_command)
15124 (simple_overlay_update, expand_symtabs_matching)
15125 (map_symbol_filenames): Update.
15126 * symfile-debug.c (set_debug_symfile): Update.
15127 * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
15128 Update.
15129 * source.c (select_source_symtab, forget_cached_source_info):
15130 Update.
15131 * solib.c (solib_read_symbols): Update.
15132 * solib-spu.c (append_ocl_sos): Update.
15133 * psymtab.c (maintenance_print_psymbols)
15134 (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
15135 * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
15136 * printcmd.c (info_symbol_command): Update.
15137 * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
15138 Update.
15139 * objfiles.h (class all_objfiles): Remove.
15140 * objfiles.c (have_partial_symbols, have_full_symbols)
15141 (have_minimal_symbols, qsort_cmp, update_section_map)
15142 (shared_objfile_contains_address_p)
15143 (default_iterate_over_objfiles_in_search_order): Update.
15144 * objc-lang.c (info_selectors_command, info_classes_command)
15145 (find_methods): Update.
15146 * minsyms.c (find_solib_trampoline_target): Update.
15147 * maint.c (maintenance_info_sections)
15148 (maintenance_translate_address, count_symtabs_and_blocks):
15149 Update.
15150 * main.c (captured_main_1): Update.
15151 * linux-thread-db.c (try_thread_db_load_from_pdir)
15152 (has_libpthread): Update.
15153 * linespec.c (iterate_over_all_matching_symtabs)
15154 (search_minsyms_for_name): Update.
15155 * jit.c (jit_find_objf_with_entry_addr): Update.
15156 * hppa-tdep.c (find_unwind_entry)
15157 (hppa_lookup_stub_minimal_symbol): Update.
15158 * gcore.c (gcore_create_callback, objfile_find_memory_regions):
15159 Update.
15160 * elfread.c (elf_gnu_ifunc_resolve_by_cache)
15161 (elf_gnu_ifunc_resolve_by_got): Update.
15162 * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
15163 * dwarf-index-write.c (save_gdb_index_command): Update.
15164 * cp-support.c (add_symbol_overload_list_qualified): Update.
15165 * breakpoint.c (create_overlay_event_breakpoint)
15166 (create_longjmp_master_breakpoint)
15167 (create_std_terminate_master_breakpoint)
15168 (create_exception_master_breakpoint): Update.
15169 * blockframe.c (find_pc_partial_function): Update.
15170 * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
15171 (ada_collect_symbol_completion_matches)
15172 (ada_add_global_exceptions): Update.
15173
776489e0
TT		 151742019-01-17 Tom Tromey <tom@tromey.com>
15175
15176 * solib-target.c (lm_info_target_p): Remove typedef. Don't
15177 declare VEC.
15178 (solib_target_parse_libraries): Change return type.
15179 (library_list_start_segment, library_list_start_section)
15180 (library_list_end_library, library_list_start_library); Update.
15181 (solib_target_free_library_list): Remove.
15182 (solib_target_parse_libraries): Remove cleanup. Change return
15183 type.
15184 (solib_target_current_sos): Update.
15185
6471e7d2
TT		 151862019-01-17 Tom Tromey <tromey@bapiya>
15187
15188 * valprint.c: Replace "the the" with "the".
15189 * symtab.c: Replace "the the" with "the".
15190 * solib.c: Replace "the the" with "the".
15191 * solib-dsbt.c: Replace "the the" with "the".
15192 * linespec.c: Replace "the the" with "the".
15193 * dwarf2loc.h: Replace "the the" with "the".
15194 * amd64-windows-tdep.c: Replace "the the" with "the".
15195 * aarch64-tdep.c: Replace "the the" with "the".
15196
c24bdb02
KS		 151972019-01-16 Keith Seitz <keiths@redhat.com>
15198
15199 PR gdb/23773
15200 * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
15201 <builder>: Rename to ..
15202 <m_builder>: ... this and make private.
15203 (dwarf2_cu::get_builder): New method. Change all users of
15204 `builder' to use this method.
15205 (dwarf2_start_symtab): Move to ...
15206 (dwarf2_cu::start_symtab): ... here. Update all callers
15207 (setup_type_unit_groups): Move to ...
15208 (dwarf2_cu::setup_type_unit_groups): ... here. Update all
15209 callers.
15210 (dwarf2_cu::reset_builder): New method.
15211 (process_full_compunit, process_full_type_unit): Use
15212 dwarf2_cu::reset_builder.
15213 (follow_die_offset): Record the ancestor CU if it is different
15214 from the followed DIE's CU.
15215 (follow_die_sig_1): Likewise.
15216
8d64371b
TT		 152172019-01-15 Tom Tromey <tom@tromey.com>
15218
15219 * remote.c (class remote_state) <buf>: Now a char_vector.
15220 <buf_size>: Remove.
15221 (remote_target::getpkt): Change type of buf. Remove sizeof_buf
15222 parameter.
15223 (remote_target::getpkt_or_notif_sane_1)
15224 (remote_target::getpkt_sane)
15225 (remote_target::getpkt_or_notif_sane): Likewise.
15226 (class remote_target) <putpkt>: New overload.
15227 (remote_target::read_frame): Change type of "buf_p". Remove
15228 sizeof_p parameter.
15229 (packet_ok): New overload.
15230 (packet_check_result): New overload.
15231 Update all uses.
15232
bb277751
TT		 152332019-01-14 Tom Tromey <tom@tromey.com>
15234
15235 * remote-notif.c (handle_notification, remote_notif_ack)
15236 (remote_notif_parse): Make "buf" const.
15237 * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
15238 const.
15239 (remote_notif_parse, remote_notif_ack, handle_notification):
15240 Likewise.
15241 * remote.c (remote_notif_stop_parse): Make "buf" const.
15242 (remote_target::remote_parse_stop_reply): Make "buf" const.
15243 (remote_notif_stop_ack): Make "buf" const.
15244
05be00a8
TT		 152452019-01-14 Tom Tromey <tom@tromey.com>
15246
15247 * remote.c (remote_console_output): Make parameter const.
15248
491adeca
TT		 152492019-01-14 Tom Tromey <tom@tromey.com>
15250
15251 * target-debug.h (target_debug_print_signals): Constify.
15252 * nto-procfs.c (nto_procfs_target::pass_signals): Update.
15253 * procfs.c (procfs_target::pass_signals): Update.
15254 * linux-nat.c (linux_nat_target::pass_signals): Update.
15255 * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
15256 * target-delegates.c: Rebuild.
15257 * remote.c (remote_target::program_signals): Update.
15258 (remote_target::pass_signals): Update.
15259 * target.c (target_pass_signals): Constify argument.
15260 (target_program_signals): Likewise.
15261 * target.h (struct target_ops) <pass_signals, program_signals>:
15262 Constify argument.
15263 (target_pass_signals, target_program_signals): Constify argument.
15264
bbd94648
TT		 152652019-01-14 Tom Tromey <tom@tromey.com>
15266
15267 PR tui/28819:
15268 * tui/tui-io.c (gdb_wgetch): Print \r when needed.
15269
6f072a10
PFC		 152702019-01-14 Pedro Franco de Carvalho <pedromfc@linux.ibm.com>
15271
15272 * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
15273 field.
15274 * rs6000-tdep.c: Include reggroups.h.
15275 (IS_V_ALIAS_PSEUDOREG): Define.
15276 (rs6000_register_name): Return names for the "vX" aliases.
15277 (rs6000_pseudo_register_type): Return type for the "vX" aliases.
15278 (rs6000_pseudo_register_reggroup_p): Restore. Handle "vX"
15279 aliases. Call default_register_reggroup_p for all other
15280 pseudo-registers.
15281 (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
15282 New functions.
15283 (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
15284 Handle "vX" aliases.
15285 (v_alias_pseudo_register_collect): New function.
15286 (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
15287 (rs6000_gdbarch_init): Initialize "vX" aliases as
15288 pseudo-registers. Restore registration of
15289 rs6000_pseudo_register_reggroup_p with
15290 set_tdesc_pseudo_register_reggroup_p.
15291
1a782351
MF		 152922019-01-13 Max Filippov <jcmvbkbc@gmail.com>
15293
15294 * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
15295 tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
15296 set_gdbarch_num_pseudo_regs.
15297
d73cff18
PW		 152982019-01-12 Philippe Waroquiers <philippe.waroquiers@skynet.be>
15299
15300 * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
15301 Remove arg prefixname, add do_set and do_show.
15302 Add member functions set_list and show_list.
15303 * cli/cli-style.c (class cli_style_option): Update accordingly.
15304 (style_set_list): Move to file scope.
15305 (style_show_list): Likewise.
15306 (set_style): Call help_list.
15307 (show_style): Call cmd_show_list.
15308 (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
15309 Update to use the new macro.
15310
60a90376
JB		 153112019-10-12 Joel Brobecker <brobecker@adacore.com>
15312
15313 * ada-lang.c (_initialize_ada_language): Expand the help text
15314 for the "catch exception" command.
15315
9d7c67bf
PW		 153162019-01-12 Philippe Waroquiers <philippe.waroquiers@skynet.be>
15317
15318 * symtab.c (matching_obj_sections): Initialize obj,
15319 declare it closer to its usage.
15320
7cf47dc4
TT		 153212019-01-10 Tom Tromey <tom@tromey.com>
15322
15323 * thread-iter.h (inf_threads_iterator): Use next_iterator.
15324 (basic_inf_threads_range): Remove.
15325 (inf_threads_range, inf_non_exited_threads_range)
15326 (safe_inf_threads_range): Use next_adapter.
15327
d3cb6808
KS		 153282019-01-10 Keith Seitz <keiths@redhat.com>
15329
15330 PR gdb/23712
15331 PR symtab/23010
15332 * dwarf2read.c (dw2_add_symbol_to_list): Remove.
15333 (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
15334
63a20375
KS		 153352019-01-10 Keith Seitz <keiths@redhat.com>
15336
15337 PR gdb/23712
15338 PR symtab/23010
15339 * dictionary.c (pending_to_vector): Remove.
15340 (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
15341 Remove _1 suffix, replacing functions of the same name. Update
15342 all callers.
15343 (dict_create_hashed, dict_create_hashed_expandable)
15344 (dict_create_linear, dict_create_linear_expandable, dict_free)
15345 (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
15346 Make functions static.
15347
b026f593
KS		 153482019-01-10 Keith Seitz <keiths@redhat.com>
15349
15350 PR gdb/23712
15351 PR symtab/23010
15352 * dictionary.h (struct dictionary): Replace declaration with
15353 multidictionary.
15354 (dict_create_hashed, dict_create_hashed_expandable)
15355 (dict_create_linear, dict_create_linear_expandable)
15356 (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
15357 (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
15358 (dict_iter_match_next, dict_size): Rename to "mdict_" versions
15359 taking multidictionary argument.
15360 [ALL_DICT_SYMBOLS]: Update for multidictionary.
15361 * block.h (struct block) <dict>: Change to multidictionary
15362 and rename `multidict'.
15363 * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
15364 symmisc.c: Update all dictionary references to multidictionary.
15365
c7748ee9
KS		 153662019-01-10 Keith Seitz <keiths@redhat.com>
15367
15368 PR gdb/23712
15369 PR symtab/23010
15370 * dictionary.c: Include unordered_map.
15371 (pending_to_vector): New function.
15372 (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
15373 Rewrite the non-"_1" functions to take vector instead
15374 of linked list.
15375 (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
15376 "new" _1 versions of the same name.
15377 (multidictionary): Define.
15378 (std::hash<enum language): New definition.
15379 (collate_pending_symbols_by_language, mdict_create_hashed)
15380 (mdict_create_hashed_expandable, mdict_create_linear)
15381 (mdict_create_linear_expandable, mdict_free)
15382 (find_language_dictionary, create_new_language_dictionary)
15383 (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
15384 (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
15385 (mdict_size, mdict_empty): New functions.
15386 * dictionary.h (mdict_iterator): Define.
15387
67aa1f3c
PA		 153882019-01-10 Pedro Alves <palves@redhat.com>
15389
15390 * breakpoint.c (read_uploaded_action)
15391 (create_tracepoint_from_upload): Adjust to use
15392 gdb::unique_xmalloc_ptr.
15393 * ctf.c (ctf_write_uploaded_tp):
15394 (SET_ARRAY_FIELD): Use emplace_back.
15395 (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
15396 * tracefile-tfile.c (tfile_write_uploaded_tp):
15397 * tracepoint.c (parse_tracepoint_definition): Adjust to use
15398 gdb::unique_xmalloc_ptr.
15399 * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
15400 at_string, cond_string, cmd_strings>: Replace char pointers
15401 with gdb::unique_xmalloc_ptr.
15402
2f667667
PA		 154032019-01-10 Pedro Alves <palves@redhat.com>
15404
15405 * solib-target.c (library_list_start_library): Don't xstrdup name.
15406
36cb7237
PA		 154072019-01-10 Pedro Alves <palves@redhat.com>
15408
15409 * mdebugread.c (parse_partial_symbols): Use
15410 gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
15411
da584958
AB		 154122019-01-10 Andrew Burgess <andrew.burgess@embecosm.com>
15413
15414 * linux-fork.c (scoped_switch_fork_info)
15415 <~scoped_switch_fork_info>: Fix incorrect variable name.
15416
1ef8573c
AB		 154172019-01-10 Andrew Burgess <andrew.burgess@embecosm.com>
15418
15419 * linux-fork.c (scoped_switch_fork_info)
15420 <scoped_switch_fork_info>: Make explicit.
15421 <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
15422
8d7bcccb
TT		 154232019-01-10 Tom Tromey <tom@tromey.com>
15424
15425 * objfiles.h (objfile::reset_psymtabs): Update.
15426 * objfiles.c (objfile::objfile): Update.
15427 * psymtab.h (psymtab_storage::obstack): Update.
15428 (psymtab_storage::m_obstack): Use gdb::optional.
15429 (class psymtab_storage): Update comment. Remove objfile
15430 parameter.
15431 * psymtab.c (psymtab_storage::psymtab_storage): Update.
15432
b596a3c7
TT		 154332019-01-10 Tom Tromey <tom@tromey.com>
15434
15435 * psymtab.h (psymtab_storage::allocate_psymtab): New method.
15436 <free_psymtabs>: Now private.
15437 * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
15438 (allocate_psymtab): Use new method.
15439
a9342b62
TT		 154402019-01-10 Tom Tromey <tom@tromey.com>
15441
15442 * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
15443 * psymtab.h (psymtab_storage::allocate_dependencies): New method.
15444 * mdebugread.c (parse_partial_symbols): Use
15445 allocate_dependencies.
15446 * dwarf2read.c (dwarf2_create_include_psymtab): Use
15447 allocate_dependencies.
15448 (process_psymtab_comp_unit_reader)
15449 (build_type_psymtab_dependencies): Likewise.
15450 * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
15451
5af70966
TT		 154522019-01-10 Tom Tromey <tom@tromey.com>
15453
15454 * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
15455 PSYMBOL_SET_LANGUAGE.
15456 (allocate_psymtab): Allocate psymtab on the psymtab obstack.
15457
5923a04c
TT		 154582019-01-10 Tom Tromey <tom@tromey.com>
15459
15460 * psymtab.h (psymtab_storage::obstack): New method.
15461 <m_obstack>: Rename from obstack; now private.
15462 * psymtab.c (psymtab_storage): Update.
15463 * dwarf2read.c (create_addrmap_from_index)
15464 (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
15465 Update.
15466
6d6a12bf
TT		 154672019-01-10 Tom Tromey <tom@tromey.com>
15468
15469 * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
15470 * objfiles.h (objfile::reset_psymtabs): New method.
15471
d320c2b5
TT		 154722019-01-10 Tom Tromey <tom@tromey.com>
15473
15474 * symmisc.c (print_symbol_bcache_statistics): Update.
15475 (print_objfile_statistics): Update.
15476 * symfile.c (reread_symbols): Update.
15477 * psymtab.h (class psymtab_storage): New.
15478 * psymtab.c (psymtab_storage): New constructor.
15479 (~psymtab_storage): New destructor.
15480 (require_partial_symbols): Update.
15481 (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
15482 (find_pc_sect_psymtab, find_pc_sect_psymbol)
15483 (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
15484 (psym_dump, recursively_search_psymtabs, psym_has_symbols)
15485 (psym_find_compunit_symtab_by_address, sort_pst_symbols)
15486 (start_psymtab_common, end_psymtab_common)
15487 (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
15488 (allocate_psymtab): Update.
15489 (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
15490 Update.
15491 (dump_psymtab_addrmap, maintenance_print_psymbols)
15492 (maintenance_check_psymtabs): Update.
15493 (class objfile_psymtabs): Move to objfiles.h.
15494 * psympriv.h (discard_psymtab): Now inline.
15495 (psymtab_discarder::psymtab_discarder): Update.
15496 (psymtab_discarder::~psymtab_discarder): Update.
15497 (ALL_OBJFILE_PSYMTABS): Rewrite.
15498 * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
15499 free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
15500 Remove fields.
15501 <partial_symtabs>: New field.
15502 (class objfile_psymtabs): Move from psymtab.h. Update.
15503 * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
15504 psymbol_cache.
15505 (objfile::~objfile): Don't destroy psymbol_cache.
15506 * mdebugread.c (parse_partial_symbols): Update.
15507 * dwarf2read.c (create_addrmap_from_index)
15508 (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
15509 (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
15510 (add_partial_subprogram, dwarf2_ranges_read): Update.
15511 * dwarf-index-write.c (write_address_map)
15512 (write_one_signatured_type, recursively_write_psymbols)
15513 (class debug_names, class debug_names, write_psymtabs_to_index):
15514 Update.
15515
1d94a5a3
TT		 155162019-01-10 Tom Tromey <tom@tromey.com>
15517
15518 * symtab.h (SYMBOL_SET_NAMES): Update.
15519 (symbol_set_names): Update.
15520 (MSYMBOL_SET_NAMES): Update.
15521 * symtab.c (symbol_set_names): Change argument to be an
15522 objfile_per_bfd_storage.
15523 * psymtab.c (add_psymbol_to_bcache): Update.
15524 * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
15525
0f14768a
TT		 155262019-01-10 Tom Tromey <tom@tromey.com>
15527
15528 * symtab.c (create_demangled_names_hash): Change argument to be an
15529 objfile_per_bfd_storage.
15530 (symbol_set_names): Update.
15531
6eee24ce
TT		 155322019-01-10 Tom Tromey <tom@tromey.com>
15533
15534 * xcoffread.c (xcoff_initial_scan): Unconditionally call
15535 init_psymbol_list.
15536 * psymtab.c (init_psymbol_list): Do nothing if already called.
15537 * psympriv.h (init_psymbol_list): Add comment.
15538 * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
15539 init_psymbol_list.
15540 * dbxread.c (dbx_symfile_read): Unconditionally call
15541 init_psymbol_list.
15542
75aedd27
TT		 155432019-01-10 Tom Tromey <tom@tromey.com>
15544
15545 * xcoffread.c (scan_xcoff_symtab): Update.
15546 * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
15547 "where".
15548 * mdebugread.c (parse_partial_symbols)
15549 (handle_psymbol_enumerators): Update.
15550 * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
15551 * dbxread.c (read_dbx_symtab): Update.
15552 * psympriv.h (psymbol_placement): New enum.
15553 (add_psymbol_to_list): Update.
15554
939652a5
TT		 155552019-01-10 Tom Tromey <tom@tromey.com>
15556
15557 * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
15558 static_psymbols parameters.
15559 (scan_xcoff_symtab): Update.
15560 * psymtab.c (start_psymtab_common): Remove global_psymbols and
15561 static_psymbols parameters.
15562 * psympriv.h (start_psymtab_common): Update.
15563 * mdebugread.c (parse_partial_symbols): Update.
15564 * dwarf2read.c (create_partial_symtab): Update.
15565 * dbxread.c (read_dbx_symtab): Update.
15566 (start_psymtab): Remove global_psymbols and static_psymbols
15567 parameters.
15568
baa62830
TT		 155692019-01-10 Tom Tromey <tom@tromey.com>
15570
15571 * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
15572 * psymtab.c (allocate_psymtab): Add comment.
15573 * psympriv.h (allocate_psymtab): Add comment.
15574 * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
15575 initializations.
15576 * dbxread.c (dbx_end_psymtab): Remove some initializations.
15577
0e8f53ba
TT		 155782019-01-10 Tom Tromey <tom@tromey.com>
15579
15580 * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
15581 Don't declare.
15582 * mipsread.c: Include mdebugread.h.
15583 * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
15584 Declare.
15585 * elfread.c: Include mdebugread.h.
15586
b22a7c6a
TT		 155872019-01-09 Tom Tromey <tom@tromey.com>
15588
15589 * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
15590 * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
15591 * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
15592 (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
15593 (psym_lookup_symbol, psym_find_last_source_symtab)
15594 (psym_forget_cached_source_info, psym_print_stats)
15595 (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
15596 (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
15597 (psym_map_matching_symbols, psym_expand_symtabs_matching)
15598 (psym_find_compunit_symtab_by_address)
15599 (maintenance_print_psymbols, maintenance_info_psymtabs)
15600 (maintenance_check_psymtabs): Use ranged for.
15601 * psymtab.h (class objfile_psymtabs): New.
15602 (require_partial_symbols): Return objfile_psymtabs.
15603 * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
15604
3b9d3ac2
TT		 156052019-01-09 Tom Tromey <tom@tromey.com>
15606
15607 * symfile.c (overlay_invalidate_all, find_pc_overlay)
15608 (find_pc_mapped_section, list_overlays_command)
15609 (map_overlay_command, unmap_overlay_command)
15610 (simple_overlay_update): Use all_objfiles.
15611 * spu-tdep.c (spu_overlay_update): Use all_objfiles.
15612 * printcmd.c (info_symbol_command): Use all_objfiles.
15613 * objfiles.h (ALL_OBJSECTIONS): Remove.
15614 * maint.c (maintenance_translate_address): Use all_objfiles.
15615 * gcore.c (gcore_create_callback): Use all_objfiles.
15616 (objfile_find_memory_regions): Likewise.
15617
8b31193a
TT		 156182019-01-09 Tom Tromey <tom@tromey.com>
15619
15620 * symtab.c (find_line_symtab, info_sources_command)
15621 (make_source_files_completion_list): Use objfile_compunits.
15622 * source.c (select_source_symtab): Use objfile_compunits.
15623 * objfiles.h (struct objfile): Update comment.
15624 (ALL_OBJFILES): Remove.
15625 (ALL_FILETABS): Remove.
15626 * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
15627 objfile_compunits.
15628
d5da8b3c
TT		 156292019-01-09 Tom Tromey <tom@tromey.com>
15630
15631 * symmisc.c (print_objfile_statistics, dump_objfile)
15632 (maintenance_print_symbols): Use compunit_filetabs.
15633 * source.c (forget_cached_source_info_for_objfile): Use
15634 compunit_filetabs.
15635 * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
15636 (ALL_FILETABS): Use compunit_filetabs.
15637 * objfiles.c (objfile_relocate1): Use compunit_filetabs.
15638 * coffread.c (coff_symtab_read): Use compunit_filetabs.
15639
5accd1a0
TT		 156402019-01-09 Tom Tromey <tom@tromey.com>
15641
15642 * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
15643 (compunit_filetabs): New.
15644 * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
15645 compunit_filetabs.
15646 (info_sources_command, make_source_files_completion_list): Remove
15647 declaration.
15648 * symmisc.c (print_objfile_statistics, dump_objfile)
15649 (maintenance_print_symbols): Remove declaration.
15650 (maintenance_info_symtabs): Use compunit_filetabs.
15651 (maintenance_info_line_tables): Likewise.
15652 * source.c (select_source_symtab): Change local variable name.
15653 (forget_cached_source_info_for_objfile): Remove declaration.
15654 * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
15655 * objfiles.c (objfile_relocate1): Remove declaration.
15656 * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
15657 declaration.
15658 * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
15659 * coffread.c (coff_symtab_read): Remove declaration.
15660 * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
15661 compunit_filetabs.
15662
d8aeb77f
TT		 156632019-01-09 Tom Tromey <tom@tromey.com>
15664
15665 * symtab.c (lookup_objfile_from_block)
15666 (find_pc_sect_compunit_symtab, search_symbols)
15667 (default_collect_symbol_completion_matches_break_on): Use
15668 objfile_compunits.
15669 * objfiles.h (ALL_COMPUNITS): Remove.
15670 * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
15671 * cp-support.c (add_symbol_overload_list_qualified): Use
15672 objfile_compunits.
15673 * ada-lang.c (ada_collect_symbol_completion_matches)
15674 (ada_add_global_exceptions): Use objfile_compunits.
15675
592553c4
TT		 156762019-01-09 Tom Tromey <tom@tromey.com>
15677
15678 * source.c (select_source_symtab)
15679 (forget_cached_source_info_for_objfile): Remove declaration.
15680 * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
15681 declaration.
15682 * maint.c (count_symtabs_and_blocks): Remove declaration.
15683 * cp-support.c (add_symbol_overload_list_qualified): Remove
15684 declaration.
15685 * coffread.c (coff_symtab_read): Remove declaration.
15686 * symtab.c (lookup_symbol_in_objfile_symtabs)
15687 (basic_lookup_transparent_type_1): Use objfile_compunits.
15688 (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
15689 (info_sources_command, search_symbols)
15690 (default_collect_symbol_completion_matches_break_on)
15691 (make_source_files_completion_list): Remove declaration.
15692 * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
15693 (ada_collect_symbol_completion_matches)
15694 (ada_add_global_exceptions): Remove declaration.
15695 * linespec.c (iterate_over_all_matching_symtabs): Use
15696 objfile_compunits.
15697 * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
15698 (class objfile_compunits): New.
15699 (ALL_COMPUNITS): Use objfile_compunits.
15700 * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
15701 (maintenance_check_symtabs, maintenance_info_line_tables): Use
15702 objfile_compunits.
15703 * objfiles.c (objfile_relocate1): Use objfile_compunits.
15704
5325b9bf
TT		 157052019-01-09 Tom Tromey <tom@tromey.com>
15706
15707 * symtab.c (search_symbols)
15708 (default_collect_symbol_completion_matches_break_on): Use
15709 objfile_msymbols.
15710 * ada-lang.c (ada_lookup_simple_minsym)
15711 (ada_collect_symbol_completion_matches): Use objfile_msymbols.
15712 * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
15713 * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
15714 objfile_msymbols.
15715 * coffread.c (coff_symfile_read): Use objfile_msymbols.
15716 * symmisc.c (dump_msymbols): Use objfile_msymbols.
15717 * objc-lang.c (find_methods): Use objfile_msymbols.
15718 (info_selectors_command, info_classes_command): Likewise.
15719 * stabsread.c (scan_file_globals): Use objfile_msymbols.
15720 * objfiles.h (class objfile_msymbols): New.
15721 (ALL_OBJFILE_MSYMBOLS): Remove.
15722 (ALL_MSYMBOLS): Remove.
15723
cac85af2
TT		 157242019-01-09 Tom Tromey <tom@tromey.com>
15725
15726 * common/next-iterator.h (next_adapter): Add Iterator template
15727 parameter.
15728 * objfiles.h (ALL_OBJFILES_SAFE): Remove.
15729 (class all_objfiles_safe): New.
15730 * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
15731 * objfiles.c (put_objfile_before): Update comment.
15732 (add_separate_debug_objfile): Likewise.
15733 (free_all_objfiles): Use all_objfiles_safe.
15734 (objfile_purge_solibs): Likewise.
15735
aed57c53
TT		 157362019-01-09 Tom Tromey <tom@tromey.com>
15737
15738 * symtab.c (iterate_over_symtabs, matching_obj_sections)
15739 (expand_symtab_containing_pc, lookup_static_symbol)
15740 (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
15741 (find_symbol_at_address, find_line_symtab, find_main_name): Use
15742 all_objfiles.
15743 * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
15744 * breakpoint.c (create_overlay_event_breakpoint)
15745 (create_longjmp_master_breakpoint)
15746 (create_std_terminate_master_breakpoint)
15747 (create_exception_master_breakpoint): Use all_objfiles.
15748 * linux-thread-db.c (try_thread_db_load_from_pdir)
15749 (has_libpthread): Use all_objfiles.
15750 * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
15751 * linespec.c (iterate_over_all_matching_symtabs)
15752 (search_minsyms_for_name): Use all_objfiles.
15753 * maint.c (maintenance_info_sections): Use all_objfiles.
15754 * main.c (captured_main_1): Use all_objfiles.
15755 * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
15756 * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
15757 * guile/scm-pretty-print.c
15758 (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
15759 * solib-spu.c (append_ocl_sos): Use all_objfiles.
15760 * symmisc.c (maintenance_print_symbols): Use all_objfiles.
15761 (maintenance_print_msymbols): Use all_objfiles.
15762 * source.c (select_source_symtab): Use all_objfiles.
15763 * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
15764 * symfile.c (remove_symbol_file_command)
15765 (expand_symtabs_matching, map_symbol_filenames): Use
15766 all_objfiles.
15767 * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
15768 all_objfiles.
15769 * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
15770 * objc-lang.c (find_methods): Use all_objfiles.
15771 * objfiles.c (have_partial_symbols, have_full_symbols)
15772 (have_minimal_symbols, qsort_cmp)
15773 (default_iterate_over_objfiles_in_search_order): Use
15774 all_objfiles.
15775 * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
15776 * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
15777 (maintenance_check_psymtabs): Use all_objfiles.
15778 (ALL_PSYMTABS): Remove.
15779 * compile/compile-object-run.c (do_module_cleanup): Use
15780 all_objfiles.
15781 * blockframe.c (find_pc_partial_function): Use all_objfiles.
15782 * cp-support.c (add_symbol_overload_list_qualified): Use
15783 all_objfiles.
15784 * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
15785 Use all_objfiles.
15786 * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
15787 * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
15788 all_objfiles.
15789 * python/py-objfile.c (objfpy_lookup_objfile_by_name)
15790 (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
15791 * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
15792 Uses all_objfiles.
15793 * solib.c (solib_read_symbols): Use all_objfiles
15794
99d89cde
TT		 157952019-01-09 Tom Tromey <tom@tromey.com>
15796
15797 * probe.c (parse_probes_in_pspace): Use all_objfiles.
15798 * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
15799 all_objfiles.
15800 * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
15801 * symmisc.c (print_symbol_bcache_statistics)
15802 (print_objfile_statistics, maintenance_print_objfiles)
15803 (maintenance_info_symtabs, maintenance_check_symtabs)
15804 (maintenance_expand_symtabs, maintenance_info_line_tables): Use
15805 all_objfiles.
15806 * source.c (forget_cached_source_info): Use all_objfiles.
15807 * symfile-debug.c (set_debug_symfile): Use all_objfiles.
15808 * elfread.c (elf_gnu_ifunc_resolve_by_cache)
15809 (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
15810 * objfiles.c (update_section_map): Use all_objfiles.
15811 (shared_objfile_contains_address_p): Likewise.
15812 * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
15813 * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
15814
21708325
TT		 158152019-01-09 Tom Tromey <tom@tromey.com>
15816
15817 * common/next-iterator.h: New file.
15818 * objfiles.h (class all_objfiles): New.
15819 (struct objfile_iterator): New.
15820
669e09f6
PW		 158212019-01-09 Philippe Waroquiers <philippe.waroquiers@skynet.be>
15822
15823 * NEWS: Move the description of the changed "frame", "select-frame",
15824 and "info frame" commands to the Changed commands section.
15825
041be526
SM		 158262019-01-09 Simon Marchi <simon.marchi@ericsson.com>
15827
15828 * gdbtypes.c (check_stub_method_group): Remove handling of old
15829 mangling schemes.
15830 * linespec.c (find_methods): Likewise.
15831 * stabsread.c (read_member_functions): Likewise.
15832 * valops.c (search_struct_method): Likewise.
15833 (value_struct_elt_for_reference): Likewise.
15834 * NEWS: Mention this change.
15835
0e2a2133
AB		 158362019-01-09 Andrew Burgess <andrew.burgess@embecosm.com>
15837
15838 * cli/cli-cmds.c (list_command): Pass a source_lines_range to
15839 print_source_lines.
15840 * source.c (print_source_lines_base): Update line number check.
15841 (print_source_lines): New function.
15842 (source_lines_range::source_lines_range): New function.
15843 * source.h (class source_lines_range): New class.
15844 (print_source_lines): New declaration.
15845
1055a3b4
PW		 158462019-01-09 Philippe Waroquiers <philippe.waroquiers@skynet.be>
15847
15848 * linespec.c (linespec_state_destructor): Free self->canonical_names.
15849
cfeadda5
TT		 158502019-01-08 Tom Tromey <tom@tromey.com>
15851 Simon Marchi <simon.marchi@ericsson.com>
15852
15853 PR gdb/24060
15854 * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
15855 * ada-lex.l (DOLLAR_VARIABLE): Likewise.
15856 * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
15857 * f-exp.y (DOLLAR_VARIABLE): Likewise.
15858 * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
15859 * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
15860
583068ca
AB		 158612019-01-08 Andrew Burgess <andrew.burgess@embecosm.com>
15862
15863 * source.c (select_source_symtab): Move header comment to
15864 declaration in source.h.
15865 (forget_cached_source_info_for_objfile): Likewise.
15866 (forget_cached_source_info): Likewise.
15867 (identify_source_line): Likewise.
15868 * source.h (identify_source_line): Move declaration from symtab.h
15869 and add comment from source.c
15870 (print_source_lines): Likewise.
15871 (forget_cached_source_info_for_objfile): Likewise.
15872 (forget_cached_source_info): Likewise.
15873 (select_source_symtab): Likewise.
15874 (enum print_source_lines_flag): Move definition from symtab.h.
15875 * symtab.h (identify_source_line): Move declaration to source.h.
15876 (print_source_lines): Likewise.
15877 (forget_cached_source_info_for_objfile): Likewise.
15878 (forget_cached_source_info): Likewise.
15879 (select_source_symtab): Likewise.
15880 (enum print_source_lines_flag): Move definition to source.h.
15881 * tui/tui-hooks.c: Add 'source.h' include.
15882
ec98a4ad
AB		 158832019-01-08 Andrew Burgess <andrew.burgess@embecosm.com>
15884
15885 * source.c (print_source_lines_base): Handle requests to print
15886 reverse line number sequences, and guard against empty lines
15887 string.
15888
62ea19c1
AB		 158892019-01-08 Andrew Burgess <andrew.burgess@embecosm.com>
15890
15891 * source.c (print_source_lines_base): Fix skip of '\r' if next
15892 character is '\n'.
15893
9d30e1fd
TT		 158942019-01-06 Tom Tromey <tom@tromey.com>
15895
15896 * c-exp.y (struct c_parse_state) <macro_original_text,
15897 expansion_obstack>: New member.
15898 (macro_original_text, expansion_obstack): Remove globals.
15899 (scan_macro_expansion, scanning_macro_expansion)
15900 (finished_macro_expansion): Update.
15901 (scan_macro_cleanup): Remove.
15902 (yylex, c_parse): Update.
15903
c65bac38
TT		 159042019-01-06 Tom Tromey <tom@tromey.com>
15905
15906 * c-exp.y (struct c_parse_state) <strings>: New member.
15907 (operator_stoken): Update.
15908
02e12e38
TT		 159092019-01-06 Tom Tromey <tom@tromey.com>
15910
15911 * parser-defs.h (type_ptr): Remove typedef. Don't declare VEC.
15912 (union type_stack_elt) <typelist_val>: Now a pointer to
15913 std::vector.
15914 (type_stack_cleanup): Don't declare.
15915 (push_typelist): Update.
15916 * parse.c (pop_typelist): Return a std::vector.
15917 (push_typelist): Take a std::vector.
15918 (follow_types): Update. Do not free args.
15919 (type_stack_cleanup): Remove.
15920 * c-exp.y (struct c_parse_state): New.
15921 (cpstate): New global.
15922 (type_aggregate_p, exp, ptr_operator, parameter_typelist)
15923 (nonempty_typelist): Update.
15924 (func_mod): Create a new vector.
15925 (c_parse): Create a c_parse_state.
15926 (check_parameter_typelist): Do not delete params.
15927 (function_method): Update. Do not delete type_list.
15928
f097f5ad
TT		 159292019-01-06 Tom Tromey <tom@tromey.com>
15930
15931 PR gdb/28155:
15932 * python/py-finishbreakpoint.c (bpfinishpy_init): Use
15933 check_typedef.
15934 * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
15935 (print_return_value): Likewise.
15936
d2adf9f1
TT		 159372019-01-05 Tom Tromey <tom@tromey.com>
15938
15939 * contrib/cleanup_check.py: Remove.
15940 * contrib/gcc-with-excheck: Remove.
15941 * contrib/exsummary.py: Remove.
15942 * contrib/excheck.py: Remove.
15943
2eab46b1
JB		 159442019-01-05 Joel Brobecker <brobecker@adacore.com>
15945
15946 * thread.c (delete_thread_1): Add gdb_assert that THR is not
15947 NULL. Initialize tpprev to NULL instead of assigning it
15948 to NULL on the next statement.
15949 * windows-nat.c (windows_delete_thread): Remove check for
15950 main_thread_id before printing thread exit notifications.
15951 (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
15952 Remove thread ID check against main_thread_id.
15953 <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
15954 windows_delete_thread.
15955 <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
15956
48c5e7e2
TT		 159572019-01-04 Tom Tromey <tom@tromey.com>
15958
15959 * compile/compile.c (_initialize_compile): Use upper case for
15960 metasyntactic variables.
15961 * symmisc.c (_initialize_symmisc): Use upper case for
15962 metasyntactic variables.
15963 * psymtab.c (_initialize_psymtab): Use upper case for
15964 metasyntactic variables.
15965 * demangle.c (demangle_command): Use upper case for metasyntactic
15966 variables.
15967 (_initialize_demangler): Likewise.
15968 * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
15969 variables.
15970
986041cd
TT		 159712019-01-03 Tom Tromey <tom@tromey.com>
15972
15973 * tui/tui-source.c (tui_set_source_content): Use xstrdup.
15974
7c711119
TT		 159752019-01-03 Tom Tromey <tom@tromey.com>
15976
15977 * python/py-symtab.c (salpy_str): Update.
15978 (struct salpy_sal_object) <symtab>: Now a PyObject.
15979 (salpy_dealloc): Update.
15980 (del_objfile_sal): Use gdbpy_ref.
15981
1b20edf0
TT		 159822019-01-03 Tom Tromey <tom@tromey.com>
15983
15984 * python/py-type.c (convert_field): Use new_reference. Return
15985 gdbpy_ref.
15986 (make_fielditem): Return gdbpy_ref.
15987 (typy_fields): Update.
15988 (typy_getitem): Update.
15989 (field_name): Return gdbpy_ref. Use new_reference.
15990 (typy_iterator_iternext): Update.
15991
ea41325b
TT		 159922019-01-03 Tom Tromey <tom@tromey.com>
15993
15994 * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
15995
2a3c71d6
TT		 159962019-01-03 Tom Tromey <tom@tromey.com>
15997
15998 * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
15999 * python/py-type.c (typy_fields_items): Use gdbpy_ref.
16000 * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
16001 (pspy_set_frame_filters, pspy_set_frame_unwinders)
16002 (pspy_set_type_printers): Likewise.
16003 * python/py-function.c (fnpy_init): Use gdbpy_ref.
16004 * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
16005 * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
16006 (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
16007 (objfpy_set_type_printers): Likewise.
16008
5c329e6a
TT		 160092019-01-03 Tom Tromey <tom@tromey.com>
16010
16011 * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
16012 (gdbpy_print_stack): Use gdbpy_err_fetch.
16013 * python/python-internal.h (class gdbpy_err_fetch): New class.
16014 (class gdbpy_enter) <m_error_type, m_error_value,
16015 m_error_traceback>: Remove.
16016 <m_error>: New member.
16017 (gdbpy_exception_to_string): Don't declare.
16018 * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
16019 * python/py-value.c (convert_value_from_python): Use
16020 gdbpy_err_fetch.
16021 * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
16022 gdbpy_exception_to_string.
16023 (gdbpy_handle_exception): Use gdbpy_err_fetch.
16024 * python/py-prettyprint.c (print_stack_unless_memory_error): Use
16025 gdbpy_err_fetch.
16026
169bb27b
AB		 160272019-01-03 Andrew Burgess <andrew.burgess@embecosm.com>
16028
16029 * linux-nat.c (delete_lwp_cleanup): Delete.
16030 (struct lwp_deleter): New struct.
16031 (lwp_info_up): New typedef.
16032 (linux_nat_target::follow_fork): Delete cleanup, and make use of
16033 lwp_info_up.
16034
a07c8880
AB		 160352019-01-03 Andrew Burgess <andrew.burgess@embecosm.com>
16036
16037 * linux-fork.c (class scoped_switch_fork_info): New class.
16038 (inferior_call_waitpid): Update to use scoped_switch_fork_info.
16039
26089c49
AB		 160402019-01-03 Andrew Burgess <andrew.burgess@embecosm.com>
16041
16042 * valops.c (find_overload_match): Remove use of null_cleanup, and
16043 calls to do_cleanups.
16044
06d3e5b0
AB		 160452019-01-03 Andrew Burgess <andrew.burgess@embecosm.com>
16046
16047 * compile/compile-cplus-types.c
16048 (compile_cplus_instance::decl_name): Handle changes to
16049 cp_func_name.
16050 * cp-support.c (cp_func_name): Update header comment, update
16051 return type.
16052 * cp-support.h (cp_func_name): Update return type in declaration.
16053 * valops.c (find_overload_match): Move temp_func local to top
16054 level of function and change its type. Use temp_func to hold and
16055 delete temporary string obtained from cp_func_name.
16056
66644cd3
AB		 160572019-01-03 Andrew Burgess <andrew.burgess@embecosm.com>
16058
16059 * remote.c (remote_target::remote_check_symbols): Convert `msg` to
16060 gdb::char_vector, remove cleanup, and update uses of `msg`.
16061
592d8c0a
JW		 160622019-01-03 Jim Wilson <jimw@sifive.com>
16063
16064 * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
16065
c55d06ec
TT		 160662019-01-02 Tom Tromey <tom@tromey.com>
16067
16068 * xml-tdesc.c (xml_cache): Hold a target_desc_up.
16069 (tdesc_parse_xml): Remove cleanups.
16070 * target-descriptions.h (make_cleanup_free_target_description):
16071 Don't declare.
16072 (target_desc_deleter): New struct.
16073 (target_desc_up): New typedef.
16074 * target-descriptions.c (target_desc_deleter::operator()): Rename
16075 from free_target_description.
16076 (make_cleanup_free_target_description): Remove.
16077
3a6ae42d
TT		 160782019-01-02 Tom Tromey <tom@tromey.com>
16079
16080 * linespec.c (struct linespec_parser): Rename from ls_parser. Add
16081 constructor, destructor.
16082 (linespec_parser): Remove typedef.
16083 (~linespec_parser): Rename from linespec_parser_delete.
16084 (linespec_lex_to_end, linespec_complete_label)
16085 (linespec_complete): Update.
16086 (decode_line_full): Remove cleanups.
16087 (decode_line_1): Update.
16088
61fd3e73
TT		 160892019-01-02 Tom Tromey <tom@tromey.com>
16090
16091 * python/python-internal.h (inferior_to_inferior_object): Change
16092 return type.
16093 * python/py-exitedevent.c (create_exited_event_object): Update.
16094 * python/py-inferior.c (inferior_to_inferior_object): Return
16095 gdbpy_ref.
16096 (python_new_inferior, python_inferior_deleted)
16097 (thread_to_thread_object, delete_thread_object)
16098 (build_inferior_list, gdbpy_selected_inferior): Update.
16099 * python/py-infthread.c (create_thread_object): Update. Also fail
16100 if inferior_to_inferior_object fails.
16101
d20172fc
SM		 161022019-01-02 Simon Marchi <simon.marchi@ericsson.com>
16103
16104 * inferior.h (class inferior) <displaced_step_state>: New field.
16105 * infrun.h (struct displaced_step_state): Move here from
16106 infrun.c. Initialize fields, add constructor.
16107 <inf>: Remove field.
16108 <reset>: New method.
16109 * infrun.c (struct displaced_step_inferior_state): Move to
16110 infrun.h.
16111 (displaced_step_inferior_states): Remove.
16112 (get_displaced_stepping_state): Adust.
16113 (displaced_step_in_progress_any_inferior): Adjust.
16114 (displaced_step_in_progress_thread): Adjust.
16115 (displaced_step_in_progress): Adjust.
16116 (add_displaced_stepping_state): Remove.
16117 (get_displaced_step_closure_by_addr): Adjust.
16118 (remove_displaced_stepping_state): Remove.
16119 (infrun_inferior_exit): Call displaced_step_state.reset.
16120 (use_displaced_stepping): Don't check for NULL.
16121 (displaced_step_prepare_throw): Call
16122 get_displaced_stepping_state.
16123 (displaced_step_fixup): Don't check for NULL.
16124 (prepare_for_detach): Don't check for NULL.
16125
e3319240
PW		 161262019-01-02 Philippe Waroquiers <philippe.waroquiers@skynet.be>
16127
16128 * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
16129 in case of call that did not complete.
16130
5d36dfb9
AU		 161312019-01-02 Andrey Utkin <autkin@undo.io>
16132
16133 * symfile.c (find_separate_debug_file): Fix search of debug files for
16134 remote debuggee.
16135
8833fbf0
TT		 161362019-01-02 Tom Tromey <tom@tromey.com>
16137
16138 * python/py-inferior.c (gdbpy_initialize_inferior): Fix
16139 indentation.
16140 * python/py-frame.c (frapy_older): Remove cast.
16141 (frapy_newer): Likewise.
16142 * python/py-breakpoint.c (local_setattro): Remove cast.
16143 * python/py-arch.c (archpy_name): Remove local variable.
16144 * python/py-type.c (gdbpy_lookup_type): Remove cast.
16145
4ada3dfd
JB		 161462019-01-02 Joel Brobecker <brobecker@adacore.com>
16147
16148 * unittests/basic_string_view/element_access/char/empty.cc:
16149 Fix year range in copyright header.
16150
113b7b81
AB		 161512019-01-01 Andrew Burgess <andrew.burgess@embecosm.com>
16152
16153 * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
16154 Delete.
16155 <operator==>: Update with for removed field.
16156 <hash>: Likewise.
16157 * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
16158 <isa_features>: ...this.
16159 <abi_features>: New field.
16160 (riscv_isa_flen): Update comment.
16161 (riscv_abi_xlen): New declaration.
16162 (riscv_abi_flen): New declaration.
16163 * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
16164 isa_features.
16165 (riscv_abi_xlen): New function.
16166 (riscv_isa_flen): Update to get answer from isa_features.
16167 (riscv_abi_flen): New function.
16168 (riscv_has_fp_abi): Update to get answer from abi_features.
16169 (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
16170 xlen and flen.
16171 (riscv_call_info) <xlen, flen>: Update comment.
16172 (riscv_call_arg_struct): Remove invalid assertions
16173 (riscv_features_from_gdbarch_info): Update now hw_float_abi field
16174 is removed.
16175 (riscv_gdbarch_init): Gather isa features and abi features
16176 separately, ensure both match on the gdbarch when reusing an old
16177 gdbarch. Relax an error check to allow 32-bit abi float to run on
16178 a target with 64-bit float hardware.
16179
b18ca514
PW		 161802019-01-01 Philippe Waroquiers <philippe.waroquiers@skynet.be>
16181
16182 * source.c (search_command_helper): Stop reverse search
16183 when line 1 has been searched.
16184
ec70d8db
PW		 161852019-01-01 Philippe Waroquiers <philippe.waroquiers@skynet.be>
16186
16187 * record-full.c (record_full_base_target::close): Rewrite
16188 record_full_core_buf_list free logic.
16189
5b38f9c1
PW		 161902019-01-01 Philippe Waroquiers <philippe.waroquiers@skynet.be>
16191
16192 * break-catch-syscall.c (print_one_catch_syscall): xfree
16193 the last text.
16194
66d91b39
JB		 161952019-01-01 Joel Brobecker <brobecker@adacore.com>
16196
16197 * top.c (print_gdb_version): Update Copyright year in version
16198 message.
16199
42a4f53d
JB		 162002019-01-01 Joel Brobecker <brobecker@adacore.com>
16201
16202 Update copyright year range in all GDB files.
16203
7e955d83 162042019-01-01, 19 Joel Brobecker <brobecker@adacore.com>
2139e8dc 16205
5bbd631d 16206 * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
2139e8dc 16207
5bbd631d 16208For older changes see ChangeLog-2018.
c906108c
SS		 16209\f
16210Local Variables:
16211mode: change-log
16212left-margin: 8
16213fill-column: 74
16214version-control: never
57da7796 16215coding: utf-8
c906108c 16216End:
5bbd631d 16217
GDB Binutils - Deliverables
This page took 2.832874 seconds and 4 git commands to generate.