gdb/ChangeLog

   1 2019-10-24  Christian Biesinger  <cbiesinger@google.com>
   2
   3         * config.in: Regenerate.
   4         * configure: Regenerate.
   5         * configure.ac: Remove the code that uses sed to get the python
   6         version and defines HAVE_LIBPYTHON2_6 / HAVE_LIBPYTHON2_7.
   7
   8 2019-10-24  Andrew Burgess  <andrew.burgess@embecosm.com>
   9
  10         * python/py-progspace.c (pspy_block_for_pc): Return None for all
  11         error paths.
  12
  13 2019-10-23  Tom Tromey  <tom@tromey.com>
  14
  15         * arc-tdep.c: Remove ".." from include.
  16         * frv-tdep.c: Remove ".." from include.
  17         * lm32-tdep.c: Remove ".." from include.
  18         * microblaze-tdep.c: Remove ".." from include.
  19         * or1k-tdep.h: Remove ".." from include.
  20         * s12z-tdep.c: Remove ".." from include.
  21         * Makefile.in (OPCODES_CFLAGS): Add comment.
  22         (TOP_CFLAGS): New variable.
  23         (INTERNAL_CFLAGS_BASE): Add TOP_CFLAGS.
  24
  25 2019-10-23  Tom Tromey  <tom@tromey.com>
  26
  27         * Makefile.in (READLINE_DIR): Update.
  28
  29 2019-10-23  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
  30
  31         * infcall.c (call_function_by_hand_dummy): Fix the function
  32         comment.  And extract out a code section into...
  33         (reserve_stack_space): ...this new function.
  34
  35 2019-10-23  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
  36
  37         * infcall.c (value_arg_coerce): Remove an unused parameter.
  38         (call_function_by_hand_dummy): Update the call to
  39         'value_arg_coerce'.
  40
  41 2019-10-23  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
  42
  43         * infcall.c (call_function_by_hand_dummy): Refactor.
  44
  45 2019-10-23  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
  46
  47         * MAINTAINERS (Write After Approval): Add Tankut Baris Aktemur.
  48
  49 2019-10-23  Tom Tromey  <tom@tromey.com>
  50
  51         * configure: Rebuild.
  52         * configure.ac: Don't check for sigprocmask.
  53         * gdbsupport/common.m4 (GDB_AC_COMMON): Check for sigprocmask.
  54
  55 2019-10-23  Tom Tromey  <tom@tromey.com>
  56
  57         * configure: Rebuild.
  58         * acinclude.m4: Use m4_include, not sinclude.
  59
  60 2019-10-23  Tom de Vries  <tdevries@suse.de>
  61
  62         PR breakpoints/24687
  63         * symtab.c (iterate_over_some_symtabs): Apply gdb_realpath on fullname.
  64
  65 2019-10-22  Christian Biesinger  <cbiesinger@google.com>
  66
  67         * symtab.c (struct demangled_name_entry) <language>: Change from
  68         bitfield to regular variable.
  69
  70 2019-10-22  Christian Biesinger  <cbiesinger@google.com>
  71
  72         * symtab.c (struct demangled_name_entry): Add a constructor.
  73         (free_demangled_name_entry): New function to call the destructor
  74         for demangled_name_entry.
  75         (create_demangled_names_hash): Pass free_demangled_name_entry to
  76         htab_create_alloc.
  77         (symbol_set_names): Call placement new for demangled_name_entry.
  78         * utils.c: No longer include xxhash.h here, now that fast_hash
  79         is inlined in the header.
  80         * utils.h: Instead, include it here.
  81
  82 2019-10-22  Christian Biesinger  <cbiesinger@google.com>
  83
  84         * Makefile.in: Link with libxxhash.
  85         * config.in: Regenerate.
  86         * configure: Regenerate.
  87         * configure.ac: Search for libxxhash.
  88         * utils.c (fast_hash): Use xxhash if present.
  89
  90 2019-10-22  Christian Biesinger  <cbiesinger@google.com>
  91
  92         * utils.h (fast_hash): New function.
  93         * symtab.c (hash_demangled_name_entry): Call new function
  94         fast_hash.
  95
  96 2019-10-22  Christian Biesinger  <cbiesinger@google.com>
  97
  98         * symtab.c (struct demangled_name_entry): Change type of mangled
  99         to gdb::string_view. Also adds a constructor that takes the
 100         mangled name.
 101         (hash_demangled_name_entry): Update.
 102         (eq_demangled_name_entry): Update.
 103         (free_demangled_name_entry): New function to call the destructor
 104         now that this is not a POD anymore.
 105         (create_demangled_names_hash): Pass free_demangled_name_entry to
 106         htab_create_alloc.
 107         (symbol_set_names): Update.
 108
 109 2019-10-21  Ali Tamur  <tamu@google.com>
 110
 111         * dwarf2read.c (dir_index): Change type.
 112         (file_name_index): Likewise.
 113         (line_header::include_dir_at): Change comment and implementation on
 114         whether it is DWARF 5.
 115         (line_header::is_valid_file_index): New function.
 116         (line_header::file_name_at): Change comment and implementation on
 117         whether it is DWARF 5.
 118         (line_header::file_names): Change to private field renamed as
 119         m_file_names and introduce a new accessor method.
 120         (line_header::file_names_size): New method.
 121         (line_header::include_dirs): Change to private field and rename as
 122         m_include_dirs.
 123         (dw2_get_file_names_reader): Define local var at a smaller scope and
 124         reflect API change.
 125         (dwarf2_cu::setup_type_unit_groups): Reflect API change.
 126         (process_structure_scope): Likewise.
 127         (line_header::add_include_dir): Change message and reflect renaming.
 128         (line_header::add_file_name): Likewise.
 129         (read_formatted_entries): Handle DW_FORM_data16.
 130         (dwarf_decode_line_header): Fix line header length calculation.
 131         (psymtab_include_file_name): Change comment and API.
 132         (lnp_state_machine::m_file): Update comment and reflect type change.
 133         (lnp_state_machine::record_line): Reflect type change.
 134         (dwarf_decode_lines): Reflect API change.
 135         (file_file_name): Likewise.
 136         (file_full_name): Likewise.
 137
 138 2019-10-21  Andrew Burgess  <andrew.burgess@embecosm.com>
 139
 140         * objfiles.c (sort_cmp): Ensure that !(a < a) holds true.
 141
 142 2019-10-21  Tom Tromey  <tom@tromey.com>
 143
 144         * tui/tui-winsource.h (tui_exec_info_content): Remove typedef.
 145
 146 2019-10-21  Tom Tromey  <tom@tromey.com>
 147
 148         * configure.ac (nm.h): Conditionally create nm.h link.  Subst
 149         NM_H.   Use AC_CONFIG_LINKS.
 150         * configure: Rebuild.
 151         * Makefile.in (NM_H): New variable.
 152         (generated_files): Add NM_H.  Remove gcore.
 153         (nm.h, stamp-nmh): New targets.
 154
 155 2019-10-20  Tom Tromey  <tom@tromey.com>
 156
 157         * objfiles.h (unlink_objfile, put_objfile_before): Don't declare.
 158         * objfiles.c (unlink_objfile): Move earlier.  Now static.  Remove
 159         obsolete comment.
 160         (put_objfile_before): Now static.
 161
 162 2019-10-19  Simon Marchi  <simon.marchi@polymtl.ca>
 163
 164         * gdbsupport/common-utils.h (startswith): Change return type to
 165         bool.
 166
 167 2019-10-19  Christian Biesinger  <cbiesinger@google.com>
 168
 169         * bcache.c (bcache::print_statistics): Use std::sort instead of qsort.
 170         * breakpoint.c (bp_locations_compare): Rename to...
 171         (bp_location_is_less_than): ...this, and change to std::sort semantics.
 172         (update_global_location_list): Use std::sort instead of qsort.
 173         * buildsym.c (compare_line_numbers): Rename to...
 174         (lte_is_less_than): ...this, and change to std::sort semantics.
 175         (buildsym_compunit::end_symtab_with_blockvector): Use std::sort
 176         instead of qsort.
 177         * disasm.c (compare_lines): Rename to...
 178         (line_is_less_than): ...this, and change to std::sort semantics.
 179         (do_mixed_source_and_assembly_deprecated): Call std::sort instead
 180         of qsort.
 181         * dwarf2-frame.c (qsort_fde_cmp): Rename to...
 182         (fde_is_less_than): ...this, and change to std::sort semantics.
 183         (dwarf2_build_frame_info): Call std::sort instead of qsort.
 184         * mdebugread.c (compare_blocks):
 185         (block_is_less_than): ...this, and change to std::sort semantics.
 186         (sort_blocks): Call std::sort instead of qsort.
 187         * objfiles.c (qsort_cmp): Rename to...
 188         (sort_cmp): ...this, and change to std::sort semantics.
 189         (update_section_map): Call std::sort instead of qsort.
 190         * remote.c (compare_pnums): Remove.
 191         (map_regcache_remote_table): Call std::sort instead of qsort.
 192         * utils.c (compare_positive_ints): Remove.
 193         * utils.h (compare_positive_ints): Remove.
 194         * xcoffread.c (compare_lte): Remove.
 195         (arrange_linetable): Call std::sort instead of qsort.
 196
 197 2019-10-19  Sergio Durigan Junior  <sergiodj@redhat.com>
 198
 199         * symfile.c (init_entry_point_info): Fix typo.
 200         * i386-darwin-tdep.c (darwin_dwarf_signal_frame_p): Fix typo.
 201
 202 2019-10-18  Tom de Vries  <tdevries@suse.de>
 203
 204         * aarch64-tdep.c: Fix typos in comments.
 205         * ada-lang.c: Same.
 206         * ada-tasks.c: Same.
 207         * alpha-tdep.c: Same.
 208         * alpha-tdep.h: Same.
 209         * amd64-nat.c: Same.
 210         * amd64-windows-tdep.c: Same.
 211         * arc-tdep.c: Same.
 212         * arc-tdep.h: Same.
 213         * arch-utils.c: Same.
 214         * arm-nbsd-tdep.c: Same.
 215         * arm-tdep.c: Same.
 216         * ax-gdb.c: Same.
 217         * blockframe.c: Same.
 218         * btrace.c: Same.
 219         * c-varobj.c: Same.
 220         * coff-pe-read.c: Same.
 221         * coffread.c: Same.
 222         * cris-tdep.c: Same.
 223         * darwin-nat.c: Same.
 224         * dbxread.c: Same.
 225         * dcache.c: Same.
 226         * disasm.c: Same.
 227         * dtrace-probe.c: Same.
 228         * dwarf-index-write.c: Same.
 229         * dwarf2-frame-tailcall.c: Same.
 230         * dwarf2-frame.c: Same.
 231         * dwarf2read.c: Same.
 232         * eval.c: Same.
 233         * exceptions.c: Same.
 234         * fbsd-tdep.c: Same.
 235         * findvar.c: Same.
 236         * frame.c: Same.
 237         * frv-tdep.c: Same.
 238         * gnu-v3-abi.c: Same.
 239         * go32-nat.c: Same.
 240         * h8300-tdep.c: Same.
 241         * hppa-tdep.c: Same.
 242         * i386-linux-tdep.c: Same.
 243         * i386-tdep.c: Same.
 244         * ia64-libunwind-tdep.c: Same.
 245         * ia64-tdep.c: Same.
 246         * infcmd.c: Same.
 247         * infrun.c: Same.
 248         * linespec.c: Same.
 249         * linux-nat.c: Same.
 250         * linux-thread-db.c: Same.
 251         * machoread.c: Same.
 252         * mdebugread.c: Same.
 253         * mep-tdep.c: Same.
 254         * mn10300-tdep.c: Same.
 255         * namespace.c: Same.
 256         * objfiles.c: Same.
 257         * opencl-lang.c: Same.
 258         * or1k-tdep.c: Same.
 259         * osabi.c: Same.
 260         * ppc-linux-nat.c: Same.
 261         * ppc-linux-tdep.c: Same.
 262         * ppc-sysv-tdep.c: Same.
 263         * printcmd.c: Same.
 264         * procfs.c: Same.
 265         * record-btrace.c: Same.
 266         * record-full.c: Same.
 267         * remote-fileio.c: Same.
 268         * remote.c: Same.
 269         * rs6000-tdep.c: Same.
 270         * s12z-tdep.c: Same.
 271         * score-tdep.c: Same.
 272         * ser-base.c: Same.
 273         * ser-go32.c: Same.
 274         * skip.c: Same.
 275         * sol-thread.c: Same.
 276         * solib-svr4.c: Same.
 277         * solib.c: Same.
 278         * source.c: Same.
 279         * sparc-nat.c: Same.
 280         * sparc-sol2-tdep.c: Same.
 281         * sparc-tdep.c: Same.
 282         * sparc64-tdep.c: Same.
 283         * stabsread.c: Same.
 284         * stack.c: Same.
 285         * symfile.c: Same.
 286         * symtab.c: Same.
 287         * target-descriptions.c: Same.
 288         * target-float.c: Same.
 289         * thread.c: Same.
 290         * utils.c: Same.
 291         * valops.c: Same.
 292         * valprint.c: Same.
 293         * value.c: Same.
 294         * varobj.c: Same.
 295         * windows-nat.c: Same.
 296         * xcoffread.c: Same.
 297         * xstormy16-tdep.c: Same.
 298         * xtensa-tdep.c: Same.
 299
 300 2019-10-17  Tom Tromey  <tromey@adacore.com>
 301
 302         * configure: Rebuild.
 303         * configure.ac: Use AC_CONFIG_HEADERS.  Create stamp-h there, not
 304         in AC_CONFIG_FILES invocation.
 305         * Makefile.in (Makefile, data-directory/Makefile, stamp-h): Use
 306         new-style config.status invocation.
 307
 308 2019-10-17  Tom de Vries  <tdevries@suse.de>
 309
 310         * arm-nbsd-nat.c: Fix typos in comments.
 311         * arm-tdep.c: Same.
 312         * darwin-nat-info.c: Same.
 313         * dwarf2read.c: Same.
 314         * elfread.c: Same.
 315         * event-top.c: Same.
 316         * findvar.c: Same.
 317         * gdbtypes.c: Same.
 318         * hppa-tdep.c: Same.
 319         * i386-tdep.c: Same.
 320         * jit.c: Same.
 321         * main.c: Same.
 322         * mdebugread.c: Same.
 323         * moxie-tdep.c: Same.
 324         * nto-procfs.c: Same.
 325         * osabi.c: Same.
 326         * ppc-linux-tdep.c: Same.
 327         * remote.c: Same.
 328         * riscv-tdep.c: Same.
 329         * s390-tdep.c: Same.
 330         * sh-tdep.c: Same.
 331         * sparc-linux-tdep.c: Same.
 332         * sparc-nat.c: Same.
 333         * stack.c: Same.
 334         * target-descriptions.c: Same.
 335         * top.c: Same.
 336         * varobj.c: Same.
 337
 338 2019-10-16  Tom Tromey  <tom@tromey.com>
 339
 340         * objfiles.h (struct objfile) <original_name>: Now const.
 341
 342 2019-10-16  Christian Biesinger  <cbiesinger@google.com>
 343
 344         * gdbsupport/gdb_setjmp.h (SIGSETJMP): Allow passing in the value to
 345         pass on to sigsetjmp's second argument.
 346         * cp-support.c (gdb_demangle): Unblock SIGSEGV if we caught a crash.
 347
 348 2019-10-16  Keith Seitz  <keiths@redhat.com>
 349
 350         PR gdb/23567
 351         * dwarf2read.c (dwarf2_per_objfile::locate_sections): Discard
 352         sections whose size is greater than the file size.
 353
 354 2019-10-16  Jim Wilson  <jimw@sifive.com>
 355
 356         * riscv-tdep.c (riscv_gcc_target_options): New.
 357         (riscv_gnu_triplet_regexp): New.
 358         (riscv_gdbarch_init): Call set_gdbarch_gcc_triplet_options and
 359         set_gdbarch_gnu_triplet_regexp.
 360
 361 2019-10-16  Christian Biesinger  <cbiesinger@google.com>
 362
 363         * Makefile.in: Add xml-builtin.h.
 364         * features/feature_to_c.sh: Add an include for xml-builtin.h
 365         to ensure that the compiler checks that the types match.
 366         * xml-builtin.h: New file.
 367         * xml-support.c (fetch_xml_builtin): Add missing const.
 368         * xml-support.h: Remove declaration of xml_builtins.
 369
 370 2019-10-16  Tom de Vries  <tdevries@suse.de>
 371
 372         PR tdep/25096
 373         * amd64-tdep.c (amd64_classify_aggregate_field): Factor out of ...
 374         (amd64_classify_aggregate): ... here.
 375         (amd64_classify_aggregate_field): Handled fiels of nested structs
 376         recursively.
 377
 378 2019-10-16  Tom de Vries  <tdevries@suse.de>
 379
 380         PR tdep/24104
 381         * amd64-tdep.c (amd64_push_arguments): Handle AMD64_NO_CLASS in loop
 382         that handles 'theclass'.
 383
 384 2019-10-15  Andrew Burgess  <andrew.burgess@embecosm.com>
 385
 386         * linespec.c (decode_digits_ordinary): Update comment.
 387         * make-target-delegates: No longer need to handle VEC case.
 388         * memrange.c (normalize_mem_ranges): Update comment.
 389         * namespace.c (add_using_directive): Update comment.
 390         * objc-lang.c (uniquify_strings): Update comment.
 391         * ppc-linux-nat.c (struct thread_points): Update comment.
 392         * probe.h (find_probes_in_objfile): Update comment.
 393         * target.h (enum flash_preserve_mode): Update comment.
 394         * varobj.c (varobj_restrict_range): Update comment.
 395         * varobj.h (varobj_list_children): Update comment.
 396
 397 2019-10-15  Andrew Burgess  <andrew.burgess@embecosm.com>
 398
 399         * Makefile.in: Remove references to vec.h and vec.c.
 400         * aarch64-tdep.c: No longer include vec.h.
 401         * ada-lang.c: Likewise.
 402         * ada-lang.h: Likewise.
 403         * arm-tdep.c: Likewise.
 404         * ax.h: Likewise.
 405         * breakpoint.h: Likewise.
 406         * charset.c: Likewise.
 407         * cp-support.h: Likewise.
 408         * dtrace-probe.c: Likewise.
 409         * dwarf2read.c: Likewise.
 410         * extension.h: Likewise.
 411         * gdb_bfd.c: Likewise.
 412         * gdbsupport/gdb_vecs.h: Likewise.
 413         * gdbsupport/vec.c: Remove.
 414         * gdbsupport/vec.h: Remove.
 415         * gdbthread.h: Likewise.
 416         * guile/scm-type.c: Likewise.
 417         * inline-frame.c: Likewise.
 418         * machoread.c: Likewise.
 419         * memattr.c: Likewise.
 420         * memrange.h: Likewise.
 421         * namespace.h: Likewise.
 422         * nat/linux-btrace.h: Likewise.
 423         * osdata.c: Likewise.
 424         * parser-defs.h: Likewise.
 425         * progspace.h: Likewise.
 426         * python/py-type.c: Likewise.
 427         * record-btrace.c: Likewise.
 428         * rust-exp.y: Likewise.
 429         * solib-target.c: Likewise.
 430         * stap-probe.c: Likewise.
 431         * target-descriptions.c: Likewise.
 432         * target-memory.c: Likewise.
 433         * target.h: Likewise.
 434         * varobj.c: Likewise.
 435         * varobj.h: Likewise.
 436         * xml-support.h: Likewise.
 437
 438 2019-10-15  Andrew Burgess  <andrew.burgess@embecosm.com>
 439
 440         * gdb/dwarf2read.c (dwarf2_per_objfile::~dwarf2_per_objfile):
 441         Update for new std::vector based implementation.
 442         (process_psymtab_comp_unit_reader): Likewise.
 443         (scan_partial_symbols): Likewise.
 444         (recursively_compute_inclusions): Likewise.
 445         (compute_compunit_symtab_includes): Likewise.
 446         (process_imported_unit_die): Likewise.
 447         (queue_and_load_dwo_tu): Likewise.
 448         (follow_die_sig_1): Likewise.
 449         * gdb/dwarf2read.h: Remove DEF_VEC_P.
 450         (typedef dwarf2_per_cu_ptr): Remove.
 451         (struct dwarf2_per_cu_data) <imported_symtabs_empty>: New
 452         function.
 453         (struct dwarf2_per_cu_data) <imported_symtabs_push>: New function.
 454         (struct dwarf2_per_cu_data) <imported_symtabs_size>: New function.
 455         (struct dwarf2_per_cu_data) <imported_symtabs_free>: New function.
 456         (struct dwarf2_per_cu_data) <imported_symtabs>: Change to
 457         std::vector.
 458
 459 2019-10-15  Tom Tromey  <tromey@adacore.com>
 460
 461         * windows-nat.c (windows_nat_target::resume): Use %x when logging
 462         TID.
 463
 464 2019-10-15  Tom Tromey  <tromey@adacore.com>
 465
 466         * windows-nat.c (windows_nat_target::fetch_registers)
 467         (windows_nat_target::store_registers): Rename "pid" to "tid".
 468
 469 2019-10-15  Tom Tromey  <tromey@adacore.com>
 470
 471         * gdbarch.h, gdbarch.c: Rebuild.
 472         * gdbarch.sh (gcc_target_options): Change return type to
 473         std::string.
 474         * compile/compile.c (get_args): Update.
 475         * nios2-tdep.c (nios2_gcc_target_options): Return std::string.
 476         * arm-linux-tdep.c (arm_linux_gcc_target_options): Return
 477         std::string.
 478         * aarch64-linux-tdep.c (aarch64_linux_gcc_target_options): Return
 479         std::string.
 480         * arch-utils.c (default_gcc_target_options): Return std::string.
 481         * arch-utils.h (default_gcc_target_options): Return std::string.
 482         * s390-tdep.c (s390_gcc_target_options): Return std::string.
 483
 484 2019-10-15  Christian Biesinger  <cbiesinger@google.com>
 485
 486         * breakpoint.c (breakpoint_chain): Make static.
 487         * tui/tui-winsource.c: Call iterate_over_breakpoints instead
 488         of accessing breakpoint_chain.
 489
 490 2019-10-15  Christian Biesinger  <cbiesinger@google.com>
 491
 492         * breakpoint.c (iterate_over_breakpoints): Change function pointer
 493         to a gdb::function_view and return value to bool.
 494         * breakpoint.h (iterate_over_breakpoints): Likewise.
 495         * dummy-frame.c (pop_dummy_frame_bpt): Update.
 496         (pop_dummy_frame): Update.
 497         * guile/scm-breakpoint.c (bpscm_build_bp_list): Update.
 498         (gdbscm_breakpoints): Update.
 499         * python/py-breakpoint.c (build_bp_list): Update.
 500         (gdbpy_breakpoints): Update.
 501         * python/py-finishbreakpoint.c (bpfinishpy_detect_out_scope_cb):
 502         Update.
 503         (bpfinishpy_handle_stop): Update.
 504         (bpfinishpy_handle_exit): Update.
 505         * solib-svr4.c (svr4_update_solib_event_breakpoint): Update.
 506         (svr4_update_solib_event_breakpoints): Update.
 507
 508 2019-10-15  Andreas Arnez  <arnez@linux.ibm.com>
 509
 510         * s390-tdep.c (s390_effective_inner_type): Ignore static fields
 511         when unwrapping single-field structs.
 512
 513 2019-10-14  Simon Marchi  <simon.marchi@polymtl.ca>
 514
 515         * dwarf2read.c: Remove includes.
 516
 517 2019-10-13  Simon Marchi  <simon.marchi@polymtl.ca>
 518
 519         * ui-out.c (ui_out::call_do_message): Silence
 520         -Wformat-nonliteral warning.
 521
 522 2019-10-12  Simon Marchi  <simon.marchi@polymtl.ca>
 523
 524         * breakpoint.c: Remove some includes: continuations.h, skip.h,
 525         mi/mi-main.h, readline/readline.h, readline/history.h.  Add
 526         include: readline/tilde.h.
 527
 528 2019-10-12  Christian Biesinger  <cbiesinger@google.com>
 529
 530         * remote.c (remote_target::get_trace_status): Remove declaration of
 531         trace_regblock_size.
 532
 533 2019-10-12  Christian Biesinger  <cbiesinger@google.com>
 534
 535         * cli/cli-cmds.c (max_user_call_depth): Move comment to header.
 536         (show_user): Remove declaration of cmdlist.
 537         * cli/cli-cmds.h (max_user_call_depth): Declare.
 538         * cli/cli-script.c (execute_user_command): Remove declaration
 539         of max_user_call_depth.
 540
 541 2019-10-11  Jim Wilson  <jimw@sifive.com>
 542
 543         * gdbsupport/print-utils.h (pulongest): Fix comment.
 544         (plongest): Likewise.
 545         (phex): Add missing comment, mention leading zeros.
 546         (phex_nz): Add mention of no leading zeros to comment.
 547
 548         * riscv-tdep.c (riscv_push_dummy_code): Change %lld to %s and use
 549         plongest instead of unsigned long long cast.
 550
 551 2019-10-10  Christian Biesinger  <cbiesinger@google.com>
 552
 553         * main.c (captured_main_1): Include gdbtk.h and remove declarations
 554         for external_editor_command and gdbtk_test.
 555
 556 2019-10-10  Christian Biesinger  <cbiesinger@google.com>
 557
 558         * mi/mi-cmd-var.c (varobjdebug): Remove declaration.
 559         * varobj.c (varobjdebug): Move comment to...
 560         * varobj.h (varobjdebug): ...here, and declare.
 561
 562 2019-10-09  Tom Tromey  <tom@tromey.com>
 563
 564         * tui/tui-regs.c (tui_data_window::show_registers): Don't call
 565         erase_data_content.
 566
 567 2019-10-09  Tom Tromey  <tom@tromey.com>
 568
 569         * tui/tui-wingeneral.h (tui_delete_win): Don't declare.
 570         * tui/tui-stack.c (tui_locator_window::rerender): Update.
 571         * tui/tui-command.c (tui_cmd_window::resize)
 572         (tui_refresh_cmd_win): Update.
 573         * tui/tui-win.c (tui_resize_all, tui_set_focus_command): Update.
 574         * tui/tui.c (tui_rl_other_window, tui_enable): Update.
 575         * tui/tui-data.c (~tui_gen_win_info): Remove.
 576         * tui/tui-layout.c (tui_gen_win_info::resize): Update.
 577         * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
 578         (tui_redisplay_readline, tui_mld_flush)
 579         (tui_mld_erase_entire_line, tui_mld_getc, tui_getc): Update.
 580         * tui/tui-regs.c (tui_data_window::delete_data_content_windows)
 581         (tui_data_window::erase_data_content)
 582         (tui_data_item_window::rerender)
 583         (tui_data_item_window::refresh_window): Update.
 584         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window)
 585         (box_win, tui_gen_win_info::make_window)
 586         (tui_gen_win_info::make_visible): Update.
 587         (tui_delete_win): Remove.
 588         * tui/tui-winsource.c
 589         (tui_source_window_base::do_erase_source_content): Update.
 590         (tui_show_source_line, tui_source_window_base::update_tab_width)
 591         (tui_source_window_base::update_exec_info): Update.
 592         * tui/tui-data.h (struct curses_deleter): New.
 593         (struct tui_gen_win_info) <handle>: Now a unique_ptr.
 594         (struct tui_gen_win_info) <~tui_gen_win_info>: Define.
 595
 596 2019-10-09  Tom Tromey  <tom@tromey.com>
 597
 598         * tui/tui-wingeneral.h (struct tui_gen_win_info): Don't declare.
 599
 600 2019-10-09  Tom Tromey  <tom@tromey.com>
 601
 602         * tui/tui-data.c (tui_win_is_auxiliary): Remove.
 603         * tui/tui-data.h (tui_win_is_auxiliary): Don't declare.
 604
 605 2019-10-09  Tom Tromey  <tom@tromey.com>
 606
 607         * tui/tui-disasm.c (tui_get_low_disassembly_address): Compute
 608         window height directly.
 609         * tui/tui-layout.h (tui_default_win_viewport_height): Don't
 610         declare.
 611         * tui/tui-layout.c (tui_default_win_height): Remove.
 612         (tui_default_win_viewport_height): Remove.
 613
 614 2019-10-09  Tom Tromey  <tom@tromey.com>
 615
 616         * tui/tui.h: Remove comments.
 617
 618 2019-10-09  Tom de Vries  <tdevries@suse.de>
 619
 620         * python/lib/gdb/printer/bound_registers.py: Use
 621         '^builtin_type_bound128' as regexp argument for
 622         add_builtin_pretty_printer.
 623
 624 2019-10-09  Christian Biesinger  <cbiesinger@google.com>
 625
 626         * guile/guile.c (guile_extension_script_ops): Remove forward
 627         declaration and mark as static.
 628         (guile_script_ops): Likewise.
 629         (extension_language_guile): Move further down in the file so
 630         it can reference the definitions for guile_{extension_,}script_ops.
 631
 632 2019-10-09  Andreas Arnez  <arnez@linux.ibm.com>
 633
 634         * s390-tdep.c (390_process_record): Handle new arch13 instructions
 635         except SORTL, DFLTCC, and KDSA.
 636
 637 2019-10-08  Tom Tromey  <tromey@adacore.com>
 638
 639         * windows-nat.c (struct windows_thread_info_struct) <sf>: Remove.
 640         (struct safe_symbol_file_add_args): Remove.
 641
 642 2019-10-08  Tom Tromey  <tromey@adacore.com>
 643
 644         * windows-nat.c: Don't include buildsym-legacy.h.
 645
 646 2019-10-08  Tom Tromey  <tromey@adacore.com>
 647
 648         * contrib/ari/gdb_ari.sh (%p): Allow gdb-specific %p extensions.
 649
 650 2019-10-08  Christian Biesinger  <cbiesinger@google.com>
 651
 652         * gdbtypes.c (overload_debug): Move comment to header.
 653         * gdbtypes.h (overload_debug): Declare.
 654         * valops.c: Remove declaration of overload_debug, instead
 655         include gdbtypes.h.
 656
 657 2019-10-08  Christian Biesinger  <cbiesinger@google.com>
 658
 659         * language.c (show_language_command): Pass lang_frame_mismatch_warn
 660         through _().
 661         (lang_frame_mismatch_warn): Make const, mark with N_(), and
 662         move comment...
 663         * language.h (lang_frame_mismatch_warn): ... here. Also add
 664         declaration.
 665         * top.c (lang_frame_mismatch_warn): Remove declaration.
 666         (check_frame_language_change): Pass lang_frame_mismatch_warn
 667         through _().
 668
 669 2019-10-07  Christian Biesinger  <cbiesinger@google.com>
 670
 671         * c-lang.h (vtbl_ptr_name): Declare.
 672         * cp-valprint.c (vtbl_ptr_name): Remove "extern" now that we get
 673         it from the header.
 674         * stabsread.c (define_symbol): Remove declaration of vtbl_ptr_name.
 675
 676 2019-10-07  Christian Biesinger  <cbiesinger@google.com>
 677
 678         * charset.c (your_gdb_wchar_t_is_bogus): Replace with a
 679         gdb_static_assert.
 680
 681 2019-10-07  Weimin Pan  <weimin.pan@oracle.com>
 682
 683         * ../Makefile.def (dependencies): Add all-libctf to all-gdb
 684         * ../Makefile.in: Add "all-gdb: maybe-all-libctf"
 685         * ctfread.c: New file.
 686         * ctfread.h: New file.
 687         * elfread.c: Include ctfread.h.
 688         (struct elfinfo text_p): New member ctfsect.
 689         (elf_locate_sections): Mark CTF section.
 690         (elf_symfile_read): Call elfctf_build_psymtabs.
 691         * Makefile.in (LIBCTF): Add.
 692         (CLIBS): Use it.
 693         (CDEPS): Likewise.
 694         (DIST): Add ctfread.c.
 695
 696 2019-10-07  Andrew Burgess  <andrew.burgess@embecosm.com>
 697
 698         * ctfread.c (struct nextfield): Renamed to ...
 699         (struct ctf_nextfield): ... this.
 700         (struct field_info): Renamed to ...
 701         (strut ctf_field_info): ... this.
 702         (attach_fields_to_type): Update for renamed structures.
 703         (ctf_add_member_cb): Likewise.
 704         (ctf_add_enum_member_cb): Likewise.
 705         (process_struct_members): Likewise.
 706         (process_enum_type): Likewise.
 707
 708 2019-10-07  Weimin Pan  <weimin.pan@oracle.com>
 709
 710         * tracectf.h: Rename, was ctf.h.
 711         * tracectf.c: Rename, was ctf.c, replace ctf.h with tracectf.h.
 712         * tracefile.c: Likewise.
 713         * tracepoint.c: Remove unused include ctf.h.
 714         * mi/mi-main.c: Likewise.
 715         * Makefile.in Replace ctf.c with tracectf.c.
 716
 717 2019-10-06  Joel Brobecker  <brobecker@adacore.com>
 718
 719         * version.in: Change version number to "9.0.50.DATE-git".
 720
 721 2019-10-03  Tom Tromey  <tom@tromey.com>
 722
 723         PR rust/24976:
 724         * dwarf2read.c (quirk_rust_enum): Handle single-element unions.
 725
 726 2019-10-03  Andrew Burgess  <andrew.burgess@embecosm.com>
 727
 728         * f-lang.c (f_language_defn): Use cp_get_symbol_name_matcher and
 729         cp_search_name_hash.
 730         * NEWS: Add entry about nested function support.
 731
 732 2019-10-03  Bernhard Heckel  <bernhard.heckel@intel.com>
 733             Andrew Burgess  <andrew.burgess@embecosm.com>
 734
 735         * cp-namespace.c (cp_search_static_and_baseclasses): Only search
 736         for nested static variables when searchin VAR_DOMAIN.
 737         * dwarf2read.c (add_partial_symbol): Add nested subroutines to the
 738         global scope, update comment.
 739         (add_partial_subprogram): Call add_partial_subprogram recursively
 740         for nested subroutines when processinng Fortran.
 741         (load_partial_dies): Process the child entities of a subprogram
 742         when processing Fortran.
 743         (partial_die_parent_scope): Handle building scope
 744         for Fortran nested functions.
 745         (process_die): Record that nested functions have a scope.
 746         (new_symbol): Always record Fortran subprograms on the global
 747         symbol list.
 748         (determine_prefix): How to build the prefix for Fortran
 749         subprograms.
 750
 751 2019-10-03  Andrew Burgess  <andrew.burgess@embecosm.com>
 752
 753         * linux-nat.c (linux_nat_filter_event): Don't ignore SIGSTOP if we
 754         have just sent the thread a SIGSTOP and are waiting for it to
 755         arrive.
 756
 757 2019-10-03  Andrew Burgess  <andrew.burgess@embecosm.com>
 758
 759         * btrace.c (btrace_add_pc): Remove whitespace before the template
 760         parameter in 'std::vector <...>'.
 761         (parse_xml_btrace_block): Likewise.
 762         (btrace_maint_decode_pt): Likewise.
 763         (btrace_maint_update_packets): Likewise.
 764         (btrace_maint_print_packets): Likewise.
 765         * btrace.h (struct btrace_maint_info): Likewise.
 766         * dwarf2read.c (struct type_unit_group): Likewise.
 767         (build_type_psymtabs_reader): Likewise.
 768         * gdbsupport/btrace-common.c (btrace_data_append): Likewise.
 769         * gdbsupport/btrace-common.h (struct btrace_data_bts): Likewise.
 770         * nat/linux-btrace.c (perf_event_read_bts): Likewise.
 771
 772 2019-10-03  Tom de Vries  <tdevries@suse.de>
 773
 774         * cli/cli-style.c (_initialize_cli_style): Adding a '.' at the end of
 775         the first line of the help text for set/show style metadata.
 776
 777 2019-10-02  Tom Tromey  <tromey@adacore.com>
 778
 779         * Makefile.in (COMMON_SFILES): Add common-inferior.c.
 780         * gdbsupport/common-inferior.c: New file.
 781         * infcmd.c (startup_with_shell): Don't define.
 782         * nat/fork-inferior.h (startup_with_shell): Don't declare.
 783         * gdbsupport/common-inferior.h (startup_with_shell): Declare.
 784         * inferior.h (startup_with_shell): Don't declare.
 785
 786 2019-10-02  Christian Biesinger  <cbiesinger@google.com>
 787
 788         * gdbsupport/gdb_assert.h: Include errors.h.
 789         * gdbsupport/gdb_string_view.h: Include gdb_assert.h.
 790
 791 2019-10-02  Tom Tromey  <tromey@adacore.com>
 792
 793         * NEWS: Add $_ada_exception entry.
 794         * ada-lang.c (struct ada_catchpoint): Add constructor.
 795         <m_kind>: New member.
 796         (allocate_location_exception, re_set_exception): Remove
 797         "ex" parameter.
 798         (should_stop_exception): Compute $_ada_exception.
 799         (check_status_exception, print_it_exception)
 800         (print_one_exception, print_mention_exception): Remove
 801         "ex" parameter.
 802         (allocate_location_catch_exception, re_set_catch_exception)
 803         (check_status_exception, print_it_catch_exception)
 804         (print_one_catch_exception, print_mention_catch_exception)
 805         (print_recreate_catch_exception)
 806         (allocate_location_catch_exception_unhandled)
 807         (re_set_catch_exception_unhandled)
 808         (check_status_exception, print_it_catch_exception_unhandled)
 809         (print_one_catch_exception_unhandled)
 810         (print_mention_catch_exception_unhandled)
 811         (print_recreate_catch_exception_unhandled)
 812         (allocate_location_catch_assert, re_set_catch_assert)
 813         (check_status_assert, print_it_catch_assert)
 814         (print_one_catch_assert, print_mention_catch_assert)
 815         (print_recreate_catch_assert)
 816         (allocate_location_catch_handlers, re_set_catch_handlers)
 817         (check_status_handlers, print_it_catch_handlers)
 818         (print_one_catch_handlers, print_mention_catch_handlers)
 819         (print_recreate_catch_handlers): Remove.
 820         (create_ada_exception_catchpoint): Update.
 821         (initialize_ada_catchpoint_ops): Update.
 822
 823 2019-10-02  Tom Tromey  <tromey@adacore.com>
 824
 825         * ada-lang.c (ada_lookup_simple_minsyms): Remove.
 826         (create_excep_cond_exprs): Simplify exception string computation.
 827         (ada_exception_catchpoint_cond_string): Likewise.
 828
 829 2019-10-02  Tom Tromey  <tromey@adacore.com>
 830
 831         * symmisc.c (dump_msymbols): Don't use MSYMBOL_VALUE_ADDRESS.
 832         * ada-lang.c (lesseq_defined_than): Handle
 833         LOC_STATIC.
 834         * dwarf2read.c (dwarf2_per_objfile): Add can_copy
 835         parameter.
 836         (dwarf2_has_info): Likewise.
 837         (new_symbol): Set maybe_copied on symbol when
 838         appropriate.
 839         * dwarf2read.h (dwarf2_per_objfile): Add can_copy
 840         parameter.
 841         <can_copy>: New member.
 842         * elfread.c (record_minimal_symbol): Set maybe_copied
 843         on symbol when appropriate.
 844         (elf_symfile_read): Update call to dwarf2_has_info.
 845         * minsyms.c (lookup_minimal_symbol_linkage): New
 846         function.
 847         * minsyms.h (lookup_minimal_symbol_linkage): Declare.
 848         * symtab.c (get_symbol_address, get_msymbol_address):
 849         New functions.
 850         * symtab.h (get_symbol_address, get_msymbol_address):
 851         Declare.
 852         (SYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_ADDRESS): Handle
 853         maybe_copied.
 854         (struct symbol, struct minimal_symbol) <maybe_copied>:
 855         New member.
 856
 857 2019-10-02  Tom Tromey  <tromey@adacore.com>
 858
 859         * source.c (struct current_source_location): New.
 860         (current_source_key): New global.
 861         (current_source_symtab, current_source_line)
 862         (current_source_pspace): Remove.
 863         (get_source_location): New function.
 864         (get_current_source_symtab_and_line)
 865         (set_default_source_symtab_and_line)
 866         (set_current_source_symtab_and_line)
 867         (clear_current_source_symtab_and_line, select_source_symtab)
 868         (info_source_command, print_source_lines_base)
 869         (info_line_command, search_command_helper, _initialize_source):
 870         Update.
 871
 872 2019-10-02  Tom Tromey  <tromey@adacore.com>
 873
 874         * source.c (select_source_symtab): Don't call
 875         decode_line_with_current_source.
 876
 877 2019-10-02  Andrew Burgess  <andrew.burgess@embecosm.com>
 878
 879         * symtab.c (lookup_global_symbol): Search global block.
 880
 881 2019-10-02  Tom Tromey  <tromey@adacore.com>
 882
 883         * coffread.c (process_coff_symbol): Update.
 884         * dwarf2read.c (var_decode_location, new_symbol): Update.
 885         * mdebugread.c (parse_symbol): Update.
 886         * objfiles.c (relocate_one_symbol): Update.
 887         * stabsread.c (define_symbol, fix_common_block)
 888         (scan_file_globals): Update.
 889         * symtab.h (SYMBOL_VALUE_ADDRESS): Expand to an rvalue.
 890         (SET_SYMBOL_VALUE_ADDRESS): New macro.
 891         * xcoffread.c (process_xcoff_symbol): Update.
 892
 893 2019-10-02  Andreas Arnez  <arnez@linux.ibm.com>
 894
 895         * MAINTAINERS: Update my email address.
 896
 897 2019-10-02  Andrew Burgess  <andrew.burgess@embecosm.com>
 898
 899         * dwarf2read.c (struct type_unit_group) <tus>: Convert to
 900         std::vector.
 901         (build_type_psymtabs_reader): Update for std::vector.
 902         (build_type_psymtab_dependencies): Likewise.
 903         * dwarf2read.h: Remove use of DEF_VEC_P.
 904         (typedef sig_type_ptr): Delete.
 905
 906 2019-10-02  Andrew Burgess  <andrew.burgess@embecosm.com>
 907
 908         * btrace.c (btrace_maint_clear): Update to handle change from VEC
 909         to std::vector.
 910         (btrace_maint_decode_pt): Likewise, and move allocation of the
 911         vector outside of the loop.
 912         (btrace_maint_update_packets): Update to handle change from VEC to
 913         std::vector.
 914         (btrace_maint_print_packets): Likewise.
 915         (maint_info_btrace_cmd): Likewise.
 916         * btrace.h: Remove use of DEF_VEC_O.
 917         (typedef btrace_pt_packet_s): Delete.
 918         (struct btrace_maint_info) <packets>: Change fromm VEC to
 919         std::vector.
 920         * gdbsupport/btrace-common.h: Remove 'vec.h' include.
 921
 922 2019-10-02  Andrew Burgess  <andrew.burgess@embecosm.com>
 923
 924         * btrace.c (btrace_compute_ftrace_bts): Update for std::vector,
 925         make accesses into the vector constant references.
 926         (btrace_add_pc): Update for std::vector.
 927         (btrace_stitch_bts): Likewise.
 928         (parse_xml_btrace_block): Likewise.
 929         (btrace_maint_update_packets): Likewise.
 930         (btrace_maint_print_packets): Likewise.
 931         (maint_info_btrace_cmd): Likewise.
 932         * gdbsupport/btrace-common.c (btrace_data::fini): Update for
 933         std::vector.
 934         (btrace_data::empty): Likewise.
 935         (btrace_data_append): Likewise.
 936         * gdbsupport/btrace-common.h: Remove use of DEF_VEC_O.
 937         (typedef btrace_block_s): Delete.
 938         (struct btrace_block): Add constructor.
 939         (struct btrace_data_bts) <blocks>: Change to std::vector.
 940         * nat/linux-btrace.c (perf_event_read_bts): Update for
 941         std::vector.
 942         (linux_read_bts): Likewise.
 943
 944 2019-10-01  Tom Tromey  <tom@tromey.com>
 945
 946         * cli/cli-logging.c (show_logging_filename): Use styled_string.
 947
 948 2019-10-01  Tom Tromey  <tom@tromey.com>
 949
 950         * stack.c (print_frame, info_frame_command_core): Use
 951         styled_string.
 952         * linux-thread-db.c (try_thread_db_load_1)
 953         (try_thread_db_load_from_pdir_1): Use styled_string.
 954         * auto-load.c (file_is_auto_load_safe, execute_script_contents)
 955         (auto_load_section_scripts, info_auto_load_local_gdbinit)
 956         (maybe_print_unsupported_script_warning)
 957         (maybe_print_script_not_found_warning): Use styled_string.
 958         * ada-lang.c (user_select_syms): Use styled_string.
 959
 960 2019-10-01  Tom Tromey  <tom@tromey.com>
 961
 962         * p-lang.c (pascal_printstr): Use metadata style.
 963         * value.c (show_convenience): Use metadata style.
 964         * valprint.c (valprint_check_validity, val_print_optimized_out)
 965         (val_print_not_saved, val_print_unavailable)
 966         (val_print_invalid_address, generic_val_print, val_print)
 967         (value_check_printable, val_print_array_elements): Use metadata
 968         style.
 969         * ui-out.h (class ui_out) <field_fmt>: New overload.
 970         <do_field_fmt>: Add style parameter.
 971         * ui-out.c (ui_out::field_fmt): New overload.
 972         * typeprint.c (type_print_unknown_return_type)
 973         (val_print_not_allocated, val_print_not_associated): Use metadata
 974         style.
 975         * tui/tui-out.h (class tui_ui_out) <do_field_fmt>: Add style
 976         parameter.
 977         * tui/tui-out.c (tui_ui_out::do_field_fmt): Update.
 978         * tracepoint.c (tvariables_info_1): Use metadata style.
 979         * stack.c (print_frame_arg, print_frame_info, print_frame)
 980         (info_frame_command_core): Use metadata style.
 981         * skip.c (info_skip_command): Use metadata style.
 982         * rust-lang.c (rust_print_enum): Use metadata style.
 983         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
 984         metadata style.
 985         * python/py-framefilter.c (py_print_single_arg): Use metadata
 986         style.
 987         * printcmd.c (do_one_display, print_variable_and_value): Use
 988         metadata style.
 989         * p-valprint.c (pascal_val_print)
 990         (pascal_object_print_value_fields): Use metadata style.
 991         * p-typeprint.c (pascal_type_print_base): Use metadata style.
 992         * mi/mi-out.h (class mi_ui_out) <do_field_fmt>: Add style
 993         parameter.
 994         * mi/mi-out.c (mi_ui_out::do_field_fmt): Update.
 995         * m2-valprint.c (m2_print_long_set): Use metadata style.
 996         * m2-typeprint.c (m2_print_type): Use metadata style.
 997         * infcmd.c (print_return_value_1): Use metadata style.
 998         * gnu-v3-abi.c (print_one_vtable): Use metadata style.
 999         * f-valprint.c (info_common_command_for_block): Use metadata
1000         style.
1001         * f-typeprint.c (f_type_print_base): Use metadata style.
1002         * expprint.c (print_subexp_standard): Use metadata style.
1003         * cp-valprint.c (cp_print_value_fields): Use metadata style.
1004         * cli/cli-style.h (class cli_style_option): Add constructor.
1005         (metadata_style): Declare.
1006         * cli/cli-style.c (metadata_style): New global.
1007         (_initialize_cli_style): Register metadata style.
1008         * cli-out.h (class cli_ui_out) <do_field_fmt>: Add style
1009         parameter.
1010         * cli-out.c (cli_ui_out::do_field_fmt): Update.
1011         * c-typeprint.c (c_type_print_base_struct_union)
1012         (c_type_print_base_1): Use metadata style.
1013         * breakpoint.c (watchpoint_value_print)
1014         (print_one_breakpoint_location): Use metadata style.
1015         * break-catch-syscall.c (print_one_catch_syscall): Use metadata
1016         style.
1017         * break-catch-sig.c (signal_catchpoint_print_one): Use metadata
1018         style.
1019         * ada-valprint.c (val_print_packed_array_elements, printstr)
1020         (print_field_values, ada_val_print_ref, ada_val_print): Use
1021         metadata style.
1022         * ada-typeprint.c (print_array_type, ada_print_type): Use metadata
1023         style.
1024         * ada-tasks.c (print_ada_task_info, info_task): Use metadata
1025         style.
1026         * ada-lang.c (user_select_syms): Use metadata style.
1027
1028 2019-10-01  Tom Tromey  <tom@tromey.com>
1029
1030         * cli/cli-cmds.c (pwd_command): Style output.
1031
1032 2019-10-01  Pedro Alves  <palves@redhat.com>
1033             Tom Tromey  <tom@tromey.com>
1034
1035         * symtab.c (print_symbol_info): Use %ps.
1036         (print_msymbol_info): Use %ps.
1037         * symfile.c (symbol_file_add_with_addrs): Use %ps.
1038         * printcmd.c (print_variable_and_value): Use %ps.
1039         * macrocmd.c (show_pp_source_pos): Use %ps.
1040         * infrun.c (print_exited_reason): Use ui_out::message.
1041         * breakpoint.c (watchpoint_check, print_one_breakpoint_location)
1042         (describe_other_breakpoints): Use ui_out::message and new
1043         formats.
1044         (say_where): Use new formats.
1045         (bkpt_print_it, tracepoint_print_one_detail): Use ui_out::message
1046         and new formats.
1047
1048 2019-10-01  Pedro Alves  <palves@redhat.com>
1049             Tom Tromey  <tom@tromey.com>
1050
1051         * unittests/format_pieces-selftests.c: Add gdb_format parameter.
1052         (test_gdb_formats): New function.
1053         (run_tests): Call it.
1054         (test_format_specifier): Update.
1055         * utils.h (fputs_filtered): Update comment.
1056         (vfprintf_styled, vfprintf_styled_no_gdbfmt)
1057         (fputs_styled_unfiltered): Declare.
1058         * utils.c (fputs_styled_unfiltered): New function.
1059         (vfprintf_maybe_filtered): Add gdbfmt parameter.
1060         (vfprintf_filtered): Update.
1061         (vfprintf_unfiltered, vprintf_filtered): Update.
1062         (vfprintf_styled, vfprintf_styled_no_gdbfmt): New functions.
1063         * ui-out.h (enum ui_out_flag) <unfiltered_output,
1064         disallow_ui_out_field>: New constants.
1065         (enum class field_kind): New.
1066         (struct base_field_s, struct signed_field_s): New.
1067         (signed_field): New function.
1068         (struct string_field_s): New.
1069         (string_field): New function.
1070         (struct styled_string_s): New.
1071         (styled_string): New function.
1072         (class ui_out) <message>: Add comment.
1073         <vmessage, call_do_message>: New methods.
1074         <do_message>: Add style parameter.
1075         * ui-out.c (ui_out::call_do_message, ui_out::vmessage): New
1076         methods.
1077         (ui_out::message): Rewrite.
1078         * mi/mi-out.h (class mi_ui_out) <do_message>: Add style
1079         parameter.
1080         * mi/mi-out.c (mi_ui_out::do_message): Add style parameter.
1081         * gdbsupport/format.h (class format_pieces) <format_pieces>: Add
1082         gdb_extensions parameter.
1083         (class format_piece): Add parameter to constructor.
1084         (n_int_args): New field.
1085         * gdbsupport/format.c (format_pieces::format_pieces): Add
1086         gdb_extensions parameter.  Handle '*'.
1087         * cli-out.h (class cli_ui_out) <do_message>: Add style parameter.
1088         * cli-out.c (cli_ui_out::do_message): Add style parameter.  Call
1089         vfprintf_styled_no_gdbfmt.
1090         (cli_ui_out::do_field_string, cli_ui_out::do_spaces)
1091         (cli_ui_out::do_text, cli_ui_out::field_separator): Allow
1092         unfiltered output.
1093         * ui-style.h (struct ui_file_style) <ptr>: New method.
1094
1095 2019-10-01  Tom Tromey  <tom@tromey.com>
1096
1097         * unittests/format_pieces-selftests.c: Update.  Add final format.
1098         * gdbsupport/format.c (format_pieces::format_pieces): Don't add
1099         empty literal pieces.
1100
1101 2019-10-01  Tom Tromey  <tom@tromey.com>
1102
1103         * ui-out.h (enum class ui_out_style_kind): Remove.
1104         (class ui_out) <field_string, field_stsream, do_field_string>:
1105         Change type of "style".
1106         * ui-out.c (ui_out::field_core_addr, ui_out::field_stream)
1107         (ui_out::field_string): Update.
1108         * tui/tui-out.h (class tui_ui_out) <do_field_string>: Change type
1109         of "style".
1110         * tui/tui-out.c (tui_ui_out::do_field_string): Update.
1111         * tracepoint.c (print_one_static_tracepoint_marker): Update.
1112         * stack.c (print_frame_arg, print_frame_info, print_frame):
1113         Update.
1114         * source.c (print_source_lines_base): Update.
1115         * solib.c (info_sharedlibrary_command): Update.
1116         * skip.c (info_skip_command): Update.
1117         * record-btrace.c (btrace_call_history_src_line)
1118         (btrace_call_history): Update.
1119         * python/py-framefilter.c (py_print_frame): Update.
1120         * mi/mi-out.h (class mi_ui_out) <do_field_string>: Change type of
1121         "style".
1122         * mi/mi-out.c (mi_ui_out::do_table_header)
1123         (mi_ui_out::do_field_signed, mi_ui_out::do_field_unsigned)
1124         (mi_ui_out::do_field_string): Update.
1125         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
1126         Update.
1127         * cli-out.h (class cli_ui_out) <do_field_string>: Change type of
1128         "style".
1129         * cli-out.c (cli_ui_out::do_table_header)
1130         (cli_ui_out::do_field_signed, cli_ui_out::do_field_unsigned)
1131         (cli_ui_out::do_field_skip, cli_ui_out::do_field_string)
1132         (cli_ui_out::do_field_fmt): Update.
1133         * breakpoint.c (print_breakpoint_location): Update.
1134         (update_static_tracepoint): Update.
1135
1136 2019-10-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1137
1138         * main.c (relocate_gdbinit_path_maybe_in_datadir): Remove std::string
1139         conversion of gdb_datadir.
1140         (captured_main_1): Remove xstrdup when assigning to gdb_datadir,
1141         remove not needed c_str ().
1142
1143 2019-09-30  Ali Tamur <tamur@google.com>
1144
1145         * dwarf2read.c (skip_one_die): Handle DW_FORM_strx forms.
1146         (dwarf2_string_attr): Likewise.
1147
1148 2019-09-30  Ali Tamur <tamur@google.com>
1149
1150         * dwarf2read.c (process_full_comp_unit): Remove whitespace at the EOL.
1151         (process_full_type_unit): Likewise.
1152         (dump_die_shallow): Likewise.
1153         (cu_debug_loc_section): Likewise.
1154
1155 2019-09-28  Christian Biesinger  <cbiesinger@google.com>
1156
1157         * minsyms.c (compare_minimal_symbols): Rename to...
1158         (minimal_symbol_is_less_than): ...this, and adjust to STL
1159         conventions (return bool, take arguments as references)
1160         (minimal_symbol_reader::install): Call std::sort instead
1161         of qsort.
1162
1163 2019-09-29  Christian Biesinger  <cbiesinger@google.com>
1164
1165         * minsyms.h (msymbol_hash): Document that this is a case-insensitive
1166         hash and why.
1167         * objfiles.h (struct objfile_per_bfd_storage) <demangled_names_hash,
1168         msymbol_hash, msymbol_demangled_hash>: Improve comments.
1169
1170 2019-09-30  Simon Marchi  <simon.marchi@polymtl.ca>
1171
1172         * psymtab.c (add_psymbol_to_list): Move comment to psympriv.h.
1173         * psympriv.h (add_psymbol_to_list): Move comment here and update
1174         it.
1175
1176 2019-09-29  Tom de Vries  <tdevries@suse.de>
1177
1178         * contrib/cc-with-tweaks.sh (get_tmpdir): New function.
1179         Use $tmpdir/$(basename "$output_file").dwz instead of
1180         "${output_file}.dwz".
1181
1182 2019-09-28  Simon Marchi  <simon.marchi@polymtl.ca>
1183
1184         PR gdb/25045
1185         * hppa-linux-nat.c: Include gdbarch.h.
1186
1187 2019-09-26  Christian Biesinger  <cbiesinger@google.com>
1188
1189         * blockframe.c (find_pc_partial_function): Change return type to bool.
1190         * elfread.c (elf_gnu_ifunc_resolve_name): Likewise.
1191         * minsyms.c (in_gnu_ifunc_stub): Likewise.
1192         (stub_gnu_ifunc_resolve_name): Likewise.
1193         * symtab.c (compare_filenames_for_search): Likewise.
1194         (compare_glob_filenames_for_search): Likewise.
1195         (matching_obj_sections): Likewise.
1196         (symbol_matches_domain): Likewise.
1197         (find_line_symtab): Change out param EXACT_MATCH to bool *.
1198         (find_line_pc): Change return type to bool.
1199         (find_line_pc_range): Likewise.
1200         (producer_is_realview): Likewise.
1201         * symtab.h (symbol_matches_domain): Likewise.
1202         (find_pc_partial_function): Likewise.
1203         (find_pc_line_pc_range): Likewise.
1204         (in_gnu_ifunc_stub): Likewise.
1205         (struct gnu_ifunc_fns) <gnu_ifunc_resolve_name>: Likewise.
1206         (find_line_pc): Likewise.
1207         (find_line_pc_range): Likewise.
1208         (matching_obj_sections): Likewise.
1209         (find_line_symtab): Change out parameter to bool.
1210         (producer_is_realview): Change return type to bool.
1211         (compare_filenames_for_search): Likewise.
1212         (compare_glob_filenames_for_search): Likewise.
1213
1214 2019-09-26  Tom Tromey  <tom@tromey.com>
1215
1216         * Makefile.in (COMMON_SFILES): Remove gdb_usleep.c.
1217         (HFILES_NO_SRCDIR): Remove gdb_usleep.h.
1218         * gdb_usleep.h: Remove.
1219         * gdb_usleep.c: Remove.
1220         * utils.c: Don't include gdb_usleep.h.
1221
1222 2019-09-26  Tom Tromey  <tromey@adacore.com>
1223
1224         * python/py-type.c (type_to_type_object): Call check_typedef
1225         for stub types.
1226
1227 2019-09-26  Tom Tromey  <tom@tromey.com>
1228
1229         * utils.h (initialize_utils): Don't declare.
1230         * top.c (gdb_init): Don't call initialize_utils.
1231         * utils.c (initialize_utils): Remove.  Move contents...
1232         (_initialize_utils): ... here.
1233
1234 2019-09-25  Tom Tromey  <tom@tromey.com>
1235
1236         * python/py-objfile.c (objfpy_get_build_id): Use bin2hex.
1237         * utils.h (make_hex_string): Don't declare.
1238         * utils.c (make_hex_string): Remove.
1239
1240 2019-09-24  Tom de Vries  <tdevries@suse.de>
1241
1242         PR gdb/23815
1243         * amd64-linux-nat.c (amd64_linux_nat_target::fetch_registers):
1244         Initialize xstateregs before ptrace PTRACE_GETREGSET call.
1245
1246 2019-09-23  Dimitar Dimitrov  <dimitar@dinux.eu>
1247
1248         * NEWS: Mention new simulator port for PRU.
1249
1250 2019-09-23  Christian Biesinger  <cbiesinger@google.com>
1251
1252         * ada-exp.y (write_object_remaining): Update.
1253         * ada-lang.c (ada_decode): Return a std::string instead of a char*
1254         and eliminate the static buffer.
1255         (ada_decode_symbol): Update.
1256         (ada_la_decode): Update.
1257         (ada_sniff_from_mangled_name): Update.
1258         (is_valid_name_for_wild_match): Update.
1259         (ada_lookup_name_info::matches): Update and simplify.
1260         (name_matches_regex): Update.
1261         (ada_add_global_exceptions): Update.
1262         * ada-lang.h (ada_decode): Update signature.
1263         * ada-varobj.c (ada_varobj_describe_simple_array_child): Update.
1264         * dwarf-index-write.c (debug_names::insert): Update.
1265
1266 2019-09-21  Simon Marchi  <simon.marchi@polymtl.ca>
1267
1268         * solib-svr4.c (svr4_iterate_over_objfiles_in_search_order): Fix
1269         formatting.
1270
1271 2019-09-21  Simon Marchi  <simon.marchi@polymtl.ca>
1272
1273         * breakpoint.h (bp_location) <inserted, permanent, duplicate>:
1274         Change "nonzero" to "true" in documentation.
1275
1276 2019-09-20  Christian Biesinger  <cbiesinger@google.com>
1277
1278         * solib-darwin.c (darwin_lookup_lib_symbol): Remove.
1279         (_initialize_darwin_solib): Don't set
1280         darwin_so_ops.lookup_lib_global_symbol.
1281         * solib-svr4.c (set_solib_svr4_fetch_link_map_offsets): Call
1282         set_gdbarch_iterate_over_objfiles_in_search_order.
1283         (elf_lookup_lib_symbol): Rename to...
1284         (svr4_iterate_over_objfiles_in_search_order): this, and update
1285         to iterate semantics.
1286         (_initialize_svr4_solib): Don't set lookup_lib_global_symbol.
1287         * solib.c (solib_global_lookup): Remove.
1288         * solist.h (struct target_so_ops): Remove lookup_lib_global_symbol.
1289         (solib_global_lookup): Remove.
1290         * symtab.c (lookup_global_or_static_symbol): Remove call to
1291         solib_global_lookup.
1292
1293 2019-09-20  Joel Brobecker  <brobecker@adacore.com>
1294
1295         * NEWS: Move entries about default MI version now being
1296         version 3, and about the GDB/MI fix for multi-location
1297         breakpoints to the "since GDB 8.3" section.
1298
1299 2019-09-20  Joel Brobecker  <brobecker@adacore.com>
1300
1301         GDB 8.3.1 released.
1302
1303 2019-09-20  Ulrich Weigand  <uweigand@de.ibm.com>
1304
1305         * NEWS: Mention that Cell/B.E. debugging support was removed.
1306         * MAINTAINERS: Remove spu target.
1307
1308         * config/djgpp/fnchange.lst: Remove entries for removed files.
1309
1310         * Makefile.in (ALL_TARGET_OBS): Remove solib-spu.o,
1311         spu-multiarch.o, and spu-tdep.o.
1312         (HFILES_NO_SRCDIR): Remove solib-spu.h and spu-tdep.h.
1313         (ALLDEPFILES): Remove solib-spu.c, spu-linux-nat.c,
1314         spu-multiarch.c, and spu-tdep.c.
1315         * spu-linux-nat.c: Remove file.
1316         * spu-multiarch.c: Remove file.
1317         * spu-tdep.c: Remove file.
1318         * spu-tdep.h: Remove file.
1319         * solib-spu.c: Remove file.
1320         * solib-spu.h: Remove file.
1321
1322         * configure.host (powerpc64*-*-linux*): Remove Cell/B.E. support.
1323         * configure.nat (spu-linux): Remove.
1324         * configure.tgt (powerpc*-*-linux*): Remove solib-spu.o and
1325         solib-multiarch.o from gdb_target_obs.
1326         (spu*-*-*): Remove.
1327
1328         * arch/ppc-linux-common.h (struct ppc_linux_features): Remove "cell"
1329         feature flag.
1330         (ppc_linux_no_features): Update.
1331         * arch/ppc-linux-common.c (ppc_linux_match_description): Remove
1332         Cell/B.E. support.
1333         * arch/ppc-linux-tdesc.h (tdesc_powerpc_cell32l): Remove declaration.
1334         (tdesc_powerpc_cell64l): Likewise.
1335         * nat/ppc-linux.h (PPC_FEATURE_CELL): Remove.
1336         * ppc-linux-nat.c (ppc_linux_nat_target::read_description): Remove
1337         Cell/B.E. support.
1338         * ppc-linux-tdep.h: Do not include "solib-spu.h" or "spu-tdep.h".
1339         Do not include "features/rs6000/powerpc-cell32l.c" or
1340         "features/rs6000/powerpc-cell64l.c".
1341         (ppc_linux_spu_section): Remove.
1342         (ppc_linux_core_read_description): Remove Cell/B.E. support.
1343         (spe_context_objfile, spe_context_lm_addr, spe_context_offset,
1344         spe_context_cache_ptid, spe_context_cache_ptid): Remove.
1345         (ppc_linux_spe_context_lookup): Remove.
1346         (ppc_linux_spe_context_inferior_created): Remove.
1347         (ppc_linux_spe_context_solib_loaded): Remove.
1348         (ppc_linux_spe_context_solib_unloaded): Remove.
1349         (ppc_linux_spe_context): Remove.
1350         (struct ppu2spu_cache): Remove.
1351         (ppu2spu_prev_arch, ppu2spu_this_id, ppu2spu_prev_register): Remove.
1352         (struct ppu2spu_data): Remove.
1353         (ppu2spu_unwind_register, ppu2spu_sniffer, ppu2spu_dealloc_cache,
1354         ppu2spu_unwind): Remove.
1355         (ppc_linux_init_abi): Remove Cell/B.E. support.
1356         * rs6000-tdep.h (rs6000_gdbarch_init): Remove Cell/B.E. support.
1357
1358         * features/Makefile (rs6000/powerpc-cell32l-expedite): Remove.
1359         (rs6000/powerpc-cell64l-expedite): Likewise
1360         (WHICH): Remove rs6000/powerpc-cell32l and rs6000/powerpc-cell64l.
1361         (XMLTOC): Remove rs6000/powerpc-cell32l.xml and
1362         rs6000/powerpc-cell64l.xml.
1363         * features/rs6000/powerpc-cell32l.xml: Remove.
1364         * features/rs6000/powerpc-cell64l.xml: Likewise.
1365         * features/rs6000/powerpc-cell32l.c: Remove generated file.
1366         * features/rs6000/powerpc-cell64l.c: Likewise.
1367         * regformats/rs6000/powerpc-cell32l.dat: Remove generated file.
1368         * regformats/rs6000/powerpc-cell64l.dat: Likewise.
1369         * regformats/reg-spu.dat: Remove.
1370
1371         * target.h (enum target_object): Remove TARGET_OBJECT_SPU.
1372         * corelow.c (struct spuid_list): Remove.
1373         (add_to_spuid_list): Remove.
1374         (core_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
1375         * remote.c (PACKET_qXfer_spu_read, PACKET_qXfer_spu_write): Remove.
1376         (remote_protocol_features): Remove associated entries.
1377         (_initialize_remote): No longer initialize them.
1378         (remote_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
1379         * linux-nat.c (SPUFS_MAGIC): Remove.
1380         (linux_proc_xfer_spu): Remove.
1381         (spu_enumerate_spu_ids): Remove.
1382         (linux_nat_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
1383         * linux-tdep.c (-linux_spu_make_corefile_notes): Remove.
1384         (linux_make_corefile_notes): No longer call it.
1385
1386         * regcache.c (cooked_read_test): Remove bfd_arch_spu special case.
1387         (cooked_write_test): Likewise.
1388
1389 2019-09-20  Tom Tromey  <tom@tromey.com>
1390
1391         * NEWS: Mention case-sensitivity of TUI commands.
1392         * tui/tui-win.c (tui_set_focus_command): Now case-sensitive.
1393         (tui_set_win_height_command, parse_scrolling_args): Likewise.
1394         * tui/tui-layout.c (tui_layout_command): Now case-sensitive.
1395
1396 2019-09-20  Tom Tromey  <tom@tromey.com>
1397
1398         * tui/tui-source.c (tui_source_window::set_contents): Use
1399         make_unique_xstrdup.
1400         * tui/tui-disasm.c (tui_disasm_window::set_contents): Use
1401         make_unique_xstrdup.
1402
1403 2019-09-20  Tom Tromey  <tom@tromey.com>
1404
1405         * tui/tui-data.c: Remove separator comments.
1406         * tui/tui-layout.c: Remove separator comments.
1407         * tui/tui-win.c: Remove separator comments.
1408         * tui/tui-wingeneral.c: Remove separator comments.
1409
1410 2019-09-20  Tom Tromey  <tom@tromey.com>
1411
1412         * tui/tui.h (strcat_to_buf): Don't declare.
1413         * tui/tui.c (strcat_to_buf): Remove.
1414
1415 2019-09-20  Tom Tromey  <tom@tromey.com>
1416
1417         * tui/tui-source.h (struct tui_source_window) <m_fullname>: Rename
1418         from "fullname".
1419         * tui/tui-source.c (tui_source_window::set_contents)
1420         (tui_source_window::location_matches_p)
1421         (tui_source_window::maybe_update): Update.
1422
1423 2019-09-20  Tom Tromey  <tom@tromey.com>
1424
1425         * tui/tui-regs.h (struct tui_data_window) <get_current_group>:
1426         Update.
1427         <m_regs_content, m_regs_column_count, m_current_group>: Add "m_"
1428         prefix.
1429         * tui/tui-regs.c (tui_data_window::last_regs_line_no)
1430         (tui_data_window::line_from_reg_element_no)
1431         (tui_data_window::first_reg_element_no_inline)
1432         (tui_data_window::show_registers)
1433         (tui_data_window::show_register_group)
1434         (tui_data_window::display_registers_from)
1435         (tui_data_window::display_registers_from_line)
1436         (tui_data_window::first_data_item_displayed)
1437         (tui_data_window::delete_data_content_windows)
1438         (tui_data_window::erase_data_content)
1439         (tui_data_window::do_scroll_vertical)
1440         (tui_data_window::refresh_window)
1441         (tui_data_window::check_register_values): Update.
1442
1443 2019-09-20  Tom Tromey  <tom@tromey.com>
1444
1445         * tui/tui-stack.h (MAX_LOCATOR_ELEMENT_LEN): Remove define.
1446         (struct tui_locator_window) <full_name, proc_name>: Now
1447         std::string.
1448         * tui/tui-stack.c (tui_locator_window::make_status_line)
1449         (tui_locator_window::set_locator_fullname)
1450         (tui_locator_window::set_locator_info): Update.
1451         * tui/tui-source.c (tui_source_window::set_contents)
1452         (tui_source_window::showing_source_p): Update.
1453
1454 2019-09-20  Tom Tromey  <tom@tromey.com>
1455
1456         * tui/tui-stack.c (tui_locator_window::set_locator_fullname):
1457         Don't call tui_locator_win_info_ptr.
1458
1459 2019-09-20  Tom Tromey  <tom@tromey.com>
1460
1461         * tui/tui-win.c (tui_resize_all): Don't call refresh.
1462
1463 2019-09-20  Tom Tromey  <tom@tromey.com>
1464
1465         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Use 1 as
1466         height for locator.
1467         * tui/tui-stack.c (tui_locator_window::rerender): Call scrollok.
1468         * tui/tui-layout.c (show_source_disasm_command, show_data)
1469         (show_source_or_disasm_and_command): Use 1 as height for locator.
1470
1471 2019-09-20  Tom Tromey  <tom@tromey.com>
1472
1473         * tui/tui.c (tui_enable): Update.
1474         * tui/tui-win.c (tui_sigwinch_handler, tui_async_resize_screen):
1475         Update.
1476         * tui/tui-data.h (tui_win_resized, tui_set_win_resized_to):
1477         Update.
1478         * tui/tui-data.c (win_resized): Now bool.
1479         (tui_win_resized): Return bool.
1480         (tui_set_win_resized_to): Accept a bool.
1481
1482 2019-09-20  Tom Tromey  <tom@tromey.com>
1483
1484         * tui/tui-regs.h (struct tui_data_window) <show_register_group>:
1485         Change type of "refresh_values_only".
1486         * tui/tui-regs.c (tui_data_window::show_register_group): Change
1487         type of "refresh_values_only".
1488
1489 2019-09-20  Tom Tromey  <tom@tromey.com>
1490
1491         * tui/tui-disasm.c (struct tui_asm_line) <addr_string, insn>: Now
1492         std::string.
1493         (tui_disassemble): Add "pos" parameter.
1494         (tui_disasm_window::set_contents): Simplify.
1495
1496 2019-09-20  Tom Tromey  <tom@tromey.com>
1497
1498         * tui/tui-winsource.h (struct tui_source_window_base)
1499         <show_source_content>: Now private.
1500         * tui/tui-winsource.c
1501         (tui_source_window_base::show_source_content): Don't handle empty
1502         content case.
1503
1504 2019-09-20  Tom Tromey  <tom@tromey.com>
1505
1506         * tui/tui-layout.c (show_source_disasm_command)
1507         (show_source_or_disasm_and_command): Don't call
1508         show_source_content.
1509
1510 2019-09-20  Tom Tromey  <tom@tromey.com>
1511
1512         * tui/tui-stack.h (struct tui_locator_window) <make_status_line>:
1513         Declare.
1514         * tui/tui-stack.c (tui_locator_window::make_status_line): Rename
1515         from tui_make_status_line.
1516         (tui_locator_window::rerender): Update.
1517
1518 2019-09-20  Tom Tromey  <tom@tromey.com>
1519
1520         * tui/tui-stack.c (tui_make_status_line): Return std::string.
1521         (tui_locator_window::rerender): Update.
1522
1523 2019-09-20  Tom Tromey  <tom@tromey.com>
1524
1525         * tui/tui-winsource.h (struct tui_source_window_base)
1526         <~tui_source_window_base>: Don't declare.
1527         <fullname>: Remove.
1528         * tui/tui-winsource.c (~tui_source_window_base): Remove.
1529         * tui/tui-source.h (struct tui_source_window) <fullname>: New
1530         member.
1531         * tui/tui-source.c (tui_source_window::set_contents): Update.
1532         (tui_source_window::location_matches_p)
1533         (tui_source_window::maybe_update): Update.
1534
1535 2019-09-20  Tom Tromey  <tom@tromey.com>
1536
1537         * tui/tui-winsource.h (~tui_source_element): Remove.
1538         (tui_source_element): Update.
1539         (struct tui_source_element) <line>: Now a unique_xmalloc_ptr.
1540         * tui/tui-winsource.c (tui_show_source_line): Update.
1541         * tui/tui-source.c (tui_source_window::set_contents): Update.
1542         * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
1543
1544 2019-09-20  Tom Tromey  <tom@tromey.com>
1545
1546         * tui/tui-data.h (tui_clear_source_windows_detail): Don't
1547         declare.
1548         * tui/tui-layout.c (tui_add_win_to_layout): Don't call
1549         tui_clear_source_windows_detail.
1550         * tui/tui-winsource.h (struct tui_source_window_base)
1551         <clear_detail>: Don't declare.
1552         * tui/tui-winsource.c (tui_source_window_base::clear_detail):
1553         Remove.
1554         * tui/tui-data.c (tui_clear_source_windows_detail): Remove.
1555
1556 2019-09-20  Tom Tromey  <tromey@adacore.com>
1557
1558         PR ada/24919:
1559         * block.c (contained_in): Fix final return value.
1560
1561 2019-09-20  Alan Modra  <amodra@gmail.com>
1562
1563         * gdb_bfd.c (gdb_bfd_ref, gdb_bfd_unref): Use bfd_set_usrdata.
1564         * dwarf2read.c (dwarf2_read_gdb_index, dwarf2_read_debug_names),
1565         (read_indirect_string_from_dwz): Use bfd accessor.
1566         * dwarf2read.h (struct dwz_file <filename>): Likewise.
1567         * machoread.c (macho_symfile_read_all_oso): Likewise.
1568         * solib.c (solib_bfd_open): Likewise.
1569
1570 2019-09-19  Christian Biesinger  <cbiesinger@google.com>
1571
1572         * eval.c: Move declaration of overload_resolution to...
1573         * value.h: ...here.
1574
1575 2019-09-19  Christian Biesinger  <cbiesinger@google.com>
1576
1577         * arm-linux-nat.c: Remove extern declaration for arm_apcs_32.
1578         * arm-linux-tdep.c: Likewise.
1579         * arm-nbsd-nat.c: Likewise.
1580         * arm-tdep.h: Declare arm_apcs_32.
1581         * arm-tdep.c: Move documentation for arm_apcs_32 to arm-tdep.h.
1582
1583 2019-09-19  Christian Biesinger  <cbiesinger@google.com>
1584
1585         * dwarf2loc.c: Remove extern declaration of dwarf_always_disassemble.
1586         * dwarf2read.h: Declare dwarf_always_disassemble.
1587
1588 2019-09-19  Tom de Vries  <tdevries@suse.de>
1589
1590         PR gdb/25009
1591         * source-cache.c (source_cache::ensure): Catch exception thrown during
1592         construction of the highlighter.
1593
1594 2019-09-18  Alan Modra  <amodra@gmail.com>
1595
1596         * aarch64-linux-tdep.c, * arm-tdep.c, * auto-load.c,
1597         * coff-pe-read.c, * coffread.c, * corelow.c, * dbxread.c,
1598         * dicos-tdep.c, * dwarf2-frame.c, * dwarf2read.c, * elfread.c,
1599         * exec.c, * fbsd-tdep.c, * gcore.c, * gdb_bfd.c, * gdb_bfd.h,
1600         * hppa-tdep.c, * i386-cygwin-tdep.c, * i386-fbsd-tdep.c,
1601         * i386-linux-tdep.c, * jit.c, * linux-tdep.c, * machoread.c,
1602         * maint.c, * mdebugread.c, * minidebug.c, * mips-linux-tdep.c,
1603         * mips-sde-tdep.c, * mips-tdep.c, * mipsread.c, * nto-tdep.c,
1604         * objfiles.c, * objfiles.h, * osabi.c, * ppc-linux-tdep.c,
1605         * ppc64-tdep.c, * record-btrace.c, * record-full.c, * remote.c,
1606         * rs6000-aix-tdep.c, * rs6000-tdep.c, * s390-linux-tdep.c,
1607         * s390-tdep.c, * solib-aix.c, * solib-dsbt.c, * solib-frv.c,
1608         * solib-spu.c, * solib-svr4.c, * solib-target.c,
1609         * spu-linux-nat.c, * spu-tdep.c, * symfile-mem.c, * symfile.c,
1610         * symmisc.c, * symtab.c, * target.c, * windows-nat.c,
1611         * xcoffread.c, * cli/cli-dump.c, * compile/compile-object-load.c,
1612         * mi/mi-interp.c: Update throughout for bfd section macro and
1613         function changes.
1614         * gcore (gcore_create_callback): Use bfd_set_section_lma.
1615         * spu-tdep.c (spu_overlay_new_objfile): Likewise.
1616
1617 2019-09-18  Tom Tromey  <tom@tromey.com>
1618
1619         * NEWS: Add entry.
1620         * tui/tui.c (tui_initialize_readline): Set name of keymap.  Do not
1621         call rl_initialize.
1622         (tui_enable): Do not call rl_initialize.
1623
1624 2019-09-18  Christian Groessler  <chris@groessler.org>
1625
1626         * alpha-linux-nat.c: Include gdbarch.h.
1627
1628 2019-09-18  Simon Marchi  <simon.marchi@polymtl.ca>
1629
1630         * ui-file.c: Include cli/cli-style.h.
1631         (term_cli_styling): Remove cli_styling declaration.
1632
1633 2019-09-18  Alan Modra  <amodra@gmail.com>
1634
1635         * arm-tdep.c (arm_record_special_symbol): Update bfd_get_section
1636         to bfd_asymbol_section.
1637
1638 2019-09-18  Alan Modra  <amodra@gmail.com>
1639
1640         * amd64-dicos-tdep.c (amd64_dicos_osabi_sniffer): Constify target.
1641         * i386-cygwin-tdep.c (i386_cygwin_init_abi): Likewise.
1642         * i386-dicos-tdep.c (i386_dicos_osabi_sniffer): Likewise.
1643
1644 2019-09-18  Alan Modra  <amodra@gmail.com>
1645
1646         * solib-spu.c (spu_bfd_open): Use bfd_set_filename.
1647         * spu-linux-nat.c (spu_bfd_open): Likewise.
1648
1649 2019-09-18  Christian Biesinger  <cbiesinger@google.com>
1650
1651         * dwarf2loc.c: Change extern declaration of dwarf_always_disassemble
1652         to bool to match definition in dwarf2read.c.
1653
1654 2019-09-17  Christian Biesinger  <cbiesinger@google.com>
1655
1656         * ada-lang.c (ada_ignore_descriptive_types_p): Change to bool.
1657         (print_signatures): Likewise.
1658         (trust_pad_over_xvs): Likewise.
1659         * arch/aarch64-insn.c (aarch64_debug): Likewise.
1660         * arch/aarch64-insn.h (aarch64_debug): Likewise.
1661         * arm-linux-nat.c (arm_apcs_32): Likewise.
1662         * arm-linux-tdep.c (arm_apcs_32): Likewise.
1663         * arm-nbsd-nat.c (arm_apcs_32): Likewise.
1664         * arm-tdep.c (arm_debug): Likewise.
1665         (arm_apcs_32): Likewise.
1666         * auto-load.c (debug_auto_load): Likewise.
1667         (auto_load_gdb_scripts): Likewise.
1668         (global_auto_load): Likewise.
1669         (auto_load_local_gdbinit): Likewise.
1670         (auto_load_local_gdbinit_loaded): Likewise.
1671         * auto-load.h (global_auto_load): Likewise.
1672         (auto_load_local_gdbinit): Likewise.
1673         (auto_load_local_gdbinit_loaded): Likewise.
1674         * breakpoint.c (disconnected_dprintf): Likewise.
1675         (breakpoint_proceeded): Likewise.
1676         (automatic_hardware_breakpoints): Likewise.
1677         (always_inserted_mode): Likewise.
1678         (target_exact_watchpoints): Likewise.
1679         (_initialize_breakpoint): Update.
1680         * breakpoint.h (target_exact_watchpoints): Change to bool.
1681         * btrace.c (maint_btrace_pt_skip_pad): Likewise.
1682         * cli/cli-cmds.c (trace_commands): Likewise.
1683         * cli/cli-cmds.h (trace_commands): Likewise.
1684         * cli/cli-decode.c (add_setshow_boolean_cmd): Change int* argument
1685         to bool*.
1686         * cli/cli-logging.c (logging_overwrite): Change to bool.
1687         (logging_redirect): Likewise.
1688         (debug_redirect): Likewise.
1689         * cli/cli-option.h (option_def) <boolean>: Change return type to bool*.
1690         (struct boolean_option_def) <get_var_address_cb_>: Change return type
1691         to bool.
1692         <boolean_option_def>: Update.
1693         (struct flag_option_def): Change default type of Context to bool
1694         from int.
1695         <flag_option_def>: Change return type of var_address_cb_ to bool*.
1696         * cli/cli-setshow.c (do_set_command): Cast to bool* instead of int*.
1697         (get_setshow_command_value_string): Likewise.
1698         * cli/cli-style.c (cli_styling): Change to bool.
1699         (source_styling): Likewise.
1700         * cli/cli-style.h (source_styling): Likewise.
1701         (cli_styling): Likewise.
1702         * cli/cli-utils.h (struct qcs_flags) <quiet, cont, silent>: Change
1703         to bool.
1704         * command.h (var_types): Update comment.
1705         (add_setshow_boolean_cmd): Change int* var argument to bool*.
1706         * compile/compile-cplus-types.c (debug_compile_cplus_types): Change to
1707         bool.
1708         (debug_compile_cplus_scopes): Likewise.
1709         * compile/compile-internal.h (compile_debug): Likewise.
1710         * compile/compile.c (compile_debug): Likewise.
1711         (struct compile_options) <raw>: Likewise.
1712         * cp-support.c (catch_demangler_crashes): Likewise.
1713         * cris-tdep.c (usr_cmd_cris_version_valid): Likewise.
1714         (usr_cmd_cris_dwarf2_cfi): Likewise.
1715         * csky-tdep.c (csky_debug): Likewise.
1716         * darwin-nat.c (enable_mach_exceptions): Likewise.
1717         * dcache.c (dcache_enabled_p): Likewise.
1718         * defs.h (info_verbose): Likewise.
1719         * demangle.c (demangle): Likewise.
1720         (asm_demangle): Likewise.
1721         * dwarf-index-cache.c (debug_index_cache): Likewise.
1722         * dwarf2-frame.c (dwarf2_frame_unwinders_enabled_p): Likewise.
1723         * dwarf2-frame.h (dwarf2_frame_unwinders_enabled_p): Likewise.
1724         * dwarf2read.c (check_physname): Likewise.
1725         (use_deprecated_index_sections): Likewise.
1726         (dwarf_always_disassemble): Likewise.
1727         * eval.c (overload_resolution): Likewise.
1728         * event-top.c (set_editing_cmd_var): Likewise.
1729         (exec_done_display_p): Likewise.
1730         * event-top.h (set_editing_cmd_var): Likewise.
1731         (exec_done_display_p): Likewise.
1732         * exec.c (write_files): Likewise.
1733         * fbsd-nat.c (debug_fbsd_lwp): Likewise
1734         (debug_fbsd_nat): Likewise.
1735         * frame.h (struct frame_print_options) <print_raw_frame_arguments>:
1736         Likewise.
1737         (struct set_backtrace_options) <backtrace_past_main>: Likewise.
1738         <backtrace_past_entry> Likewise.
1739         * gdb-demangle.h (demangle): Likewise.
1740         (asm_demangle): Likewise.
1741         * gdb_bfd.c (bfd_sharing): Likewise.
1742         * gdbcore.h (write_files): Likewise.
1743         * gdbsupport/common-debug.c (show_debug_regs): Likewise.
1744         * gdbsupport/common-debug.h (show_debug_regs): Likewise.
1745         * gdbthread.h (print_thread_events): Likewise.
1746         * gdbtypes.c (opaque_type_resolution): Likewise.
1747         (strict_type_checking): Likewise.
1748         * gnu-nat.c (gnu_debug_flag): Likewise.
1749         * guile/scm-auto-load.c (auto_load_guile_scripts): Likewise.
1750         * guile/scm-param.c (pascm_variable): Add boolval.
1751         (add_setshow_generic): Update.
1752         (pascm_param_value): Update.
1753         (pascm_set_param_value_x): Update.
1754         * hppa-tdep.c (hppa_debug): Change to bool..
1755         * infcall.c (may_call_functions_p): Likewise.
1756         (coerce_float_to_double_p): Likewise.
1757         (unwind_on_signal_p): Likewise.
1758         (unwind_on_terminating_exception_p): Likewise.
1759         * infcmd.c (startup_with_shell): Likewise.
1760         * inferior.c (print_inferior_events): Likewise.
1761         * inferior.h (startup_with_shell): Likewise.
1762         (print_inferior_events): Likewise.
1763         * infrun.c (step_stop_if_no_debug): Likewise.
1764         (detach_fork): Likewise.
1765         (debug_displaced): Likewise.
1766         (disable_randomization): Likewise.
1767         (non_stop): Likewise.
1768         (non_stop_1): Likewise.
1769         (observer_mode): Likewise.
1770         (observer_mode_1): Likewise.
1771         (set_observer_mode): Update.
1772         (sched_multi): Change to bool.
1773         * infrun.h (debug_displaced): Likewise.
1774         (sched_multi): Likewise.
1775         (step_stop_if_no_debug): Likewise.
1776         (non_stop): Likewise.
1777         (disable_randomization): Likewise.
1778         * linux-tdep.c (use_coredump_filter): Likewise.
1779         (dump_excluded_mappings): Likewise.
1780         * linux-thread-db.c (auto_load_thread_db): Likewise.
1781         (check_thread_db_on_load): Likewise.
1782         * main.c (captured_main_1): Update.
1783         * maint-test-options.c (struct test_options_opts) <flag_opt, xx1_opt,
1784         xx2_opt, boolean_opt>: Change to bool.
1785         * maint-test-settings.c (maintenance_test_settings_boolean): Likewise.
1786         * maint.c (maintenance_profile_p): Likewise.
1787         (per_command_time): Likewise.
1788         (per_command_space): Likewise.
1789         (per_command_symtab): Likewise.
1790         * memattr.c (inaccessible_by_default): Likewise.
1791         * mi/mi-main.c (mi_async): Likewise.
1792         (mi_async_1): Likewise.
1793         * mips-tdep.c (mips64_transfers_32bit_regs_p): Likewise.
1794         * nat/fork-inferior.h (startup_with_shell): Likewise.
1795         * nat/linux-namespaces.c (debug_linux_namespaces): Likewise.
1796         * nat/linux-namespaces.h (debug_linux_namespaces): Likewise.
1797         * nios2-tdep.c (nios2_debug): Likewise.
1798         * or1k-tdep.c (or1k_debug): Likewise.
1799         * parse.c (parser_debug): Likewise.
1800         * parser-defs.h (parser_debug): Likewise.
1801         * printcmd.c (print_symbol_filename): Likewise.
1802         * proc-api.c (procfs_trace): Likewise.
1803         * python/py-auto-load.c (auto_load_python_scripts): Likewise.
1804         * python/py-param.c (union parmpy_variable): Add "bool boolval" field.
1805         (set_parameter_value): Update.
1806         (add_setshow_generic): Update.
1807         * python/py-value.c (copy_py_bool_obj): Change argument from int*
1808         to bool*.
1809         * python/python.c (gdbpy_parameter_value): Cast to bool* instead of
1810         int*.
1811         * ravenscar-thread.c (ravenscar_task_support): Change to bool.
1812         * record-btrace.c (record_btrace_target::store_registers): Update.
1813         * record-full.c (record_full_memory_query): Change to bool.
1814         (record_full_stop_at_limit): Likewise.
1815         * record-full.h (record_full_memory_query): Likewise.
1816         * remote-notif.c (notif_debug): Likewise.
1817         * remote-notif.h (notif_debug): Likewise.
1818         * remote.c (use_range_stepping): Likewise.
1819         (interrupt_on_connect): Likewise.
1820         (remote_break): Likewise.
1821         * ser-tcp.c (tcp_auto_retry): Likewise.
1822         * ser-unix.c (serial_hwflow): Likewise.
1823         * skip.c (debug_skip): Likewise.
1824         * solib-aix.c (solib_aix_debug): Likewise.
1825         * spu-tdep.c (spu_stop_on_load_p): Likewise.
1826         (spu_auto_flush_cache_p): Likewise.
1827         * stack.c (struct backtrace_cmd_options) <full, no_filters, hide>:
1828         Likewise.
1829         (struct info_print_options) <quiet>: Likewise.
1830         * symfile-debug.c (debug_symfile): Likewise.
1831         * symfile.c (auto_solib_add): Likewise.
1832         (separate_debug_file_debug): Likewise.
1833         * symfile.h (auto_solib_add): Likewise.
1834         (separate_debug_file_debug): Likewise.
1835         * symtab.c (basenames_may_differ): Likewise.
1836         (struct filename_partial_match_opts) <dirname, basename>: Likewise.
1837         (struct info_print_options) <quiet, exclude_minsyms>: Likewise.
1838         (struct info_types_options) <quiet>: Likewise.
1839         * symtab.h (demangle): Likewise.
1840         (basenames_may_differ): Likewise.
1841         * target-dcache.c (stack_cache_enabled_1): Likewise.
1842         (code_cache_enabled_1): Likewise.
1843         * target.c (trust_readonly): Likewise.
1844         (may_write_registers): Likewise.
1845         (may_write_memory): Likewise.
1846         (may_insert_breakpoints): Likewise.
1847         (may_insert_tracepoints): Likewise.
1848         (may_insert_fast_tracepoints): Likewise.
1849         (may_stop): Likewise.
1850         (auto_connect_native_target): Likewise.
1851         (target_stop_and_wait): Update.
1852         (target_async_permitted): Change to bool.
1853         (target_async_permitted_1): Likewise.
1854         (may_write_registers_1): Likewise.
1855         (may_write_memory_1): Likewise.
1856         (may_insert_breakpoints_1): Likewise.
1857         (may_insert_tracepoints_1): Likewise.
1858         (may_insert_fast_tracepoints_1): Likewise.
1859         (may_stop_1): Likewise.
1860         * target.h (target_async_permitted): Likewise.
1861         (may_write_registers): Likewise.
1862         (may_write_memory): Likewise.
1863         (may_insert_breakpoints): Likewise.
1864         (may_insert_tracepoints): Likewise.
1865         (may_insert_fast_tracepoints): Likewise.
1866         (may_stop): Likewise.
1867         * thread.c (struct info_threads_opts) <show_global_ids>: Likewise.
1868         (make_thread_apply_all_options_def_group): Change argument from int*
1869         to bool*.
1870         (thread_apply_all_command): Update.
1871         (print_thread_events): Change to bool.
1872         * top.c (confirm): Likewise.
1873         (command_editing_p): Likewise.
1874         (history_expansion_p): Likewise.
1875         (write_history_p): Likewise.
1876         (info_verbose): Likewise.
1877         * top.h (confirm): Likewise.
1878         (history_expansion_p): Likewise.
1879         * tracepoint.c (disconnected_tracing): Likewise.
1880         (circular_trace_buffer): Likewise.
1881         * typeprint.c (print_methods): Likewise.
1882         (print_typedefs): Likewise.
1883         * utils.c (debug_timestamp): Likewise.
1884         (sevenbit_strings): Likewise.
1885         (pagination_enabled): Likewise.
1886         * utils.h (sevenbit_strings): Likewise.
1887         (pagination_enabled): Likewise.
1888         * valops.c (overload_resolution): Likewise.
1889         * valprint.h (struct value_print_options) <prettyformat_arrays,
1890         prettyformat_structs, vtblprint, unionprint, addressprint, objectprint,
1891         stop_print_at_null, print_array_indexes, deref_ref, static_field_print,
1892         pascal_static_field_print, raw, summary, symbol_print, finish_print>:
1893         Likewise.
1894         * windows-nat.c (new_console): Likewise.
1895         (cygwin_exceptions): Likewise.
1896         (new_group): Likewise.
1897         (debug_exec): Likewise.
1898         (debug_events): Likewise.
1899         (debug_memory): Likewise.
1900         (debug_exceptions): Likewise.
1901         (useshell): Likewise.
1902         * windows-tdep.c (maint_display_all_tib): Likewise.
1903         * xml-support.c (debug_xml): Likewise.
1904
1905 2019-09-17  Mike Gulick  <mgulick@mathworks.com>
1906
1907         * source.c (prepare_path_for_appending): New function.
1908         (openp): Make use of new function.
1909         (find_and_open_source): Search for the compilation directory and
1910         source file as a relative path beneath the directory search path.
1911
1912 2019-09-17  Andrew Burgess  <andrew.burgess@embecosm.com>
1913
1914         * source-cache.c (source_cache::get_line_charpos): Catch
1915         exceptions and return false, this matches the behaviour documented
1916         in the header file.
1917
1918 2019-09-17  Joel Brobecker  <brobecker@adacore.com>
1919
1920         * ada-tasks.c (info_task): Remove quoting of the task's name.
1921
1922 2019-09-16  Christian Biesinger  <cbiesinger@google.com>
1923
1924         * symfile.c (auto_solib_add): Replace comment with a reference
1925         to the header file.
1926
1927 2019-09-14  Christian Biesinger  <cbiesinger@google.com>
1928
1929         * NEWS: Mention that gdb can now be compiled with Python 3
1930         on Windows.
1931
1932 2019-09-12  Andrew Burgess  <andrew.burgess@embecosm.com>
1933
1934         * maint.c (maint_print_section_data::maint_print_section_data):
1935         Force use of 'float log10 (float)' by casting the argument to
1936         float.
1937
1938 2019-09-12  Andrew Burgess  <andrew.burgess@embecosm.com>
1939
1940         * maint.c: Add 'cmath' include.
1941         (struct maint_print_section_data): New structure.
1942         (print_section_index): New function.
1943         (print_bfd_section_info): Add header comment, small whitespace
1944         cleanup, and update to call new print_section_index function.
1945         (print_objfile_section_info): Likewise.
1946         (maint_obj_section_from_bfd_section): New function.
1947         (print_bfd_section_info_maybe_relocated): New function.
1948         (maintenance_info_sections): Add header comment, always use
1949         bfd_map_over_sections instead of ALL_OBJFILE_OSECTIONS.
1950
1951 2019-09-12  Andrew Burgess  <andrew.burgess@embecosm.com>
1952
1953         * psymtab.c (find_pc_sect_psymtab): Move baseaddr local into more
1954         inner scope, add check that the objfile has psymtabs before
1955         checking psymtabs_addrmap.
1956         * psymtab.h (psymtab_storage) <psymtabs_addrmap>: Extend comment.
1957
1958 2019-09-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1959
1960         * NEWS: Announce that Ada task names are now shown at more places,
1961         and between quotes (except in info task output).
1962         * gdb/ada-tasks.c (task_to_str): New function.
1963         (display_current_task_id): Call task_to_str.
1964         (task_command_1): Likewise.
1965         (print_ada_task_info): In non-mi mode, Properly align headers and data
1966         when task-id length is > 9 (9 is the default for a 32 bits CORE_ADDR).
1967
1968 2019-09-12  Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
1969
1970         * procfs.c (procfs_target::wait) <PR_FAULTED>: Get signal from
1971         prstatus.pr_lwp.pr_info instead of making it up.
1972
1973 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
1974
1975         * auto-load.c (auto_load_expand_dir_vars): Update.
1976         * defs.h (gdb_datadir): Change to std::string.
1977         (python_libdir): Likewise.
1978         (relocate_gdb_directory): Change return type to std::string.
1979         * guile/guile.c (gdbscm_data_directory): Update.
1980         (initialize_scheme_side): Update.
1981         * jit.c (jit_reader_dir): Change to std::string.
1982         (jit_reader_load_command): Update.
1983         * main.c (gdb_datadir): Change to std::string.
1984         (python_libdir): Likewise.
1985         (set_gdb_data_directory): Update.
1986         (relocate_path): Change to return std::string.
1987         (relocate_gdb_directory): Change to return std::string.
1988         (relocate_gdbinit_path_maybe_in_datadir): Update.
1989         (captured_main_1): Update.
1990         * python/python.c (do_start_initialization): Update.
1991         * top.c (show_gdb_datadir): Update.
1992         * xml-syscall.c (xml_init_syscalls_info): Update.
1993         (init_syscalls_info): Update.
1994
1995 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
1996
1997         * main.c (relocate_gdbinit_path_maybe_in_datadir): Factor this code
1998         out of get_init_files.
1999         (get_init_files): Update.
2000
2001 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
2002
2003         * main.c (get_init_files): Change to use std::string.
2004         (captured_main_1): Update.
2005         (print_gdb_help): Update.
2006
2007 2019-09-11  Ali Tamur  <tamur@google.com>
2008
2009         *gdb/target-float.c (host_float_ops<T>::to_longest): Update
2010         implementation.
2011
2012 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
2013
2014         * dbxread.c (read_dbx_symtab): Update.
2015         * dwarf2read.c (load_partial_dies): Update.
2016         * mdebugread.c (parse_partial_symbols): Update.
2017         (handle_psymbol_enumerators): Update.
2018         * psympriv.h (add_psymbol_to_list): Change type of copy_names to bool.
2019         * psymtab.c (add_psymbol_to_bcache): Likewise.
2020         (add_psymbol_to_list): Likewise.
2021         * symtab.c (symbol_set_names): Likewise.
2022         * symtab.h (symbol_set_names): Likewise.
2023         * xcoffread.c (scan_xcoff_symtab): Update.
2024
2025 2019-09-11  Tom Tromey  <tom@tromey.com>
2026
2027         * symfile-mem.c (symbol_file_add_from_memory): Use
2028         bfd_set_filename.
2029         * solib-darwin.c (darwin_bfd_open): Use bfd_set_filename.
2030         * solib-aix.c (solib_aix_bfd_open): Use bfd_set_filename.
2031
2032 2019-09-10  Tom Tromey  <tromey@adacore.com>
2033
2034         * dwarf-index-write.c (write_psymbols): Extend error message.
2035         (debug_names::insert): Add Ada code.
2036         (debug_names::write_psymbols): Remove Ada check.
2037         (debug_names) <m_string_obstack>: New member.
2038         * dwarf2read.c (gdb_index_symbol_name_matcher): Remove.
2039         (gdb_index_symbol_name_matcher::matches): Remove.
2040         (mapped_index_base::find_name_components_bounds): Add "lang"
2041         parameter.
2042         (mapped_index_base::build_name_components): Also split names
2043         according to Ada syntax.
2044         (dw2_expand_symtabs_matching_symbol): Loop over languages.  Change
2045         type of "match_callback".
2046         (check_match, check_find_bounds_finds)
2047         (dw2_expand_symtabs_matching): Update.
2048         (dw2_debug_names_iterator): Add new constructor.
2049         (dw2_debug_names_map_matching_symbols): New function.
2050         (dw2_debug_names_expand_symtabs_matching): Update.
2051         (dwarf2_debug_names_functions): Use
2052         dw2_debug_names_map_matching_symbols.
2053
2054 2019-09-10  Tom Tromey  <tromey@adacore.com>
2055
2056         * dwarf2read.c (dw2_get_file_names_reader): Add the
2057         CU's file name to the results.
2058
2059 2019-09-10  Tom Tromey  <tromey@adacore.com>
2060
2061         * ada-lang.c (add_nonlocal_symbols): Combine calls to
2062         map_matching_symbols.  Update.
2063         * dwarf2read.c (dw2_map_matching_symbols): Update.
2064         * psymtab.c (match_partial_symbol): Change type; update.
2065         (psym_map_matching_symbols): Likewise.
2066         * symfile-debug.c (debug_qf_map_matching_symbols): Change
2067         type; update.
2068         * symfile.h (struct quick_symbol_functions)
2069         <map_matching_symbols>: Change "name" to be a lookup_name_info.
2070         Remove "match".
2071
2072 2019-09-10  Tom Tromey  <tromey@adacore.com>
2073
2074         * psymtab.c (map_block): Remove.
2075         (psym_map_matching_symbols): Use iterate_over_symbols_terminated.
2076         * symtab.c (iterate_over_symbols_terminated): New function.
2077         * symtab.c (iterate_over_symbols_terminated): Declare.
2078
2079 2019-09-10  Tom Tromey  <tromey@adacore.com>
2080
2081         * ada-lang.c (ada_iterate_over_symbols): Return bool.
2082         * language.h (struct language_defn) <la_iterate_over_symbols>:
2083         Return bool.
2084         * symtab.c (iterate_over_symbols): Return bool.
2085         * symtab.h (iterate_over_symbols): Return bool.
2086
2087 2019-09-10  Tom Tromey  <tromey@adacore.com>
2088
2089         * ada-lang.c (aux_add_nonlocal_symbols): Change type.
2090         (add_nonlocal_symbols): Update.
2091         * dwarf2read.c (dw2_map_matching_symbols): Change type.
2092         * psymtab.c (map_block, psym_map_matching_symbols): Change type.
2093         * symfile-debug.c (debug_qf_map_matching_symbols): Change type.
2094         * symfile.h (struct quick_symbol_functions) <map_matching_symbols>:
2095         Change type of "callback".  Remove "data".
2096
2097
2098 2019-09-09  Ali Tamur  <tamur@google.com>
2099
2100         * dwarf2read.c (comp_unit_head): Update comment.
2101         (dwarf2_dwo_name): New function declaration.
2102         (dwarf_unit_type_name): New function declaration.
2103         (read_comp_unit_head): Add support for new compilation units,
2104         DW_UT_partial, DW_UT_skeleton, DW_UT_split_compile, DW_UT_split_type.
2105         Particularly, DW_UT_skeleton and DW_UT_split_compile have dwo_id
2106         (currently named as "signature") in their header. Also clarify error
2107         messages.
2108         (lookup_dwo_id): New function. Returns the dwo id of the given
2109         compile unit.
2110         (lookup_dwo_unit): Use the new lookup_dwo_id function.
2111         (init_cutu_and_read_dies): Use the new dwarf2_dwo_name and lookup_dwo_id
2112         functions.
2113         (create_dwo_cu_reader): Use the added lookup_dwo_id function.
2114         (dwarf2_dwo_name): Get the dwo name if present.
2115         (dwarf_unit_type_name): Convert DW_UT_* types to string for diagnostic
2116         purposes.
2117
2118 2019-09-09  Tom Tromey  <tom@tromey.com>
2119
2120         * tui/tui-win.c (tui_all_windows_info): Use ui_out.
2121
2122 2019-09-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2123
2124         * python/python.c (do_start_initialization): Make progname_copy static,
2125         to avoid a leak report.
2126
2127 2019-09-08  Tom Tromey  <tom@tromey.com>
2128
2129         * tui/tui-wingeneral.c (box_win): Truncate long window titles.
2130
2131 2019-09-07  Simon Marchi  <simon.marchi@efficios.com>
2132
2133         * dwarf2read.c (struct dw2_symtab_iterator) <block_index>:
2134         Change type to gdb::optional<block_enum>.
2135         (dw2_symtab_iter_init): Change block_index parameter type
2136         to gdb::optional<block_enum>.
2137         (dw2_lookup_symbol): Change block_index parameter
2138         type to block_enum.c
2139         (dw2_debug_names_lookup_symbol): Likewise.
2140         * psymtab.c (psym_lookup_symbol): Likewise.
2141         * symfile-debug.c (debug_qf_lookup_symbol): Likewise.
2142         * symfile.h (struct quick_symbol_functions) <lookup_symbol>:
2143         Likewise.
2144
2145 2019-09-06  Christian Biesinger  <cbiesinger@google.com>
2146
2147         * defs.h (relocate_gdb_directory): Change int to bool in
2148         signature and rename flag to relocatable.
2149         * main.c (relocate_path): Likewise.
2150         (relocate_gdb_directory): Likewise.
2151
2152 2019-09-06  Alan Modra  <amodra@gmail.com>
2153
2154         * coffread.c (coff_symfile_read): Constify filename variable.
2155         * dbxread.c (dbx_symfile_init, coffstab_build_psymtabs),
2156         (elfstab_build_psymtabs, stabsect_build_psymtabs): Likewise.
2157         * gdb_bfd.c (gdb_bfd_close_or_warn): Likewise.
2158         * solib.c (reload_shared_libraries_1): Likewise.
2159         * symfile.c (reread_symbols): Likewise.
2160         * solib-aix.c (solib_aix_bfd_open): Add cast for xfree of filename.
2161         * solib-darwin.c (darwin_bfd_open): Likewise.
2162         * symfile-mem.c (symbol_file_add_from_memory): Likewise.
2163
2164 2019-09-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2165
2166         * psymtab.c (print_partial_symbols): Handle missing domain_enum
2167         values MODULE_DOMAIN and COMMON_BLOCK_DOMAIN.
2168
2169 2019-09-03  Tom Tromey  <tromey@adacore.com>
2170
2171         * ada-valprint.c (ada_val_print_num): Don't recurse for range
2172         types.
2173         (has_negatives): Unbias a range type bound.
2174         * dwarf2read.c (read_subrange_type): Handle DW_AT_GNU_bias.
2175         * gdbtypes.c (operator==): Handle new field.
2176         (create_range_type): Add "bias" parameter.
2177         (create_static_range_type, resolve_dynamic_range): Update.
2178         * gdbtypes.h (struct range_bounds) <bias>: New member.
2179         (create_range_type): Add bias parameter.
2180         * printcmd.c (print_scalar_formatted): Unbias range types.
2181         * value.c (unpack_long): Unbias range types.
2182         (pack_long): Bias range types.
2183
2184 2019-09-02  Alan Hayward  <alan.hayward@arm.com>
2185
2186         * solib-svr4.c (svr4_find_and_create_probe_breakpoints): Check all
2187         probe arguments.
2188
2189 2019-09-02  Alan Hayward  <alan.hayward@arm.com>
2190
2191         * break-catch-throw.c (fetch_probe_arguments): Use gdbarch.
2192         * dtrace-probe.c (dtrace_probe::get_argument_count): Likewise.
2193         * probe.c (probe_safe_evaluate_at_pc) (compute_probe_arg)
2194         (compile_probe_arg): Likewise.
2195         * probe.h (get_argument_count): Likewise.
2196         * solib-svr4.c (solib_event_probe_action): Likewise.
2197         * stap-probe.c (stap_probe::get_argument_count): Likewise.
2198
2199 2019-09-02  Alan Hayward  <alan.hayward@arm.com>
2200
2201         * solib-svr4.c (svr4_find_and_create_probe_breakpoints): Move
2202         code to here...
2203         (svr4_create_solib_event_breakpoints): ...from here.
2204
2205 2019-08-30  Sergio Durigan Junior  <sergiodj@redhat.com>
2206
2207         * nat/fork-inferior.c (trace_start_error): Remove "\nError: "
2208         suffix from warning message.
2209
2210 2019-08-30  Tom Tromey  <tom@tromey.com>
2211
2212         * tui/tui-winsource.h (struct tui_source_window_base)
2213         <refresh_all>: Don't declare.
2214         * tui/tui-winsource.c (tui_source_window_base::refresh_all):
2215         Remove.
2216         * tui/tui-win.c (tui_refresh_all_win): Don't call refresh_all or
2217         tui_show_locator_content.
2218         * tui/tui-regs.h (struct tui_data_window) <refresh_all>: Don't
2219         declare.
2220         * tui/tui-regs.c (tui_data_window::refresh_all): Remove.
2221         * tui/tui-data.h (struct tui_win_info) <refresh_all>: Don't
2222         declare.
2223
2224 2019-08-30  Tom Tromey  <tom@tromey.com>
2225
2226         * tui/tui-io.c (tui_cont_sig): Don't call wrefresh.
2227
2228 2019-08-30  Tom Tromey  <tom@tromey.com>
2229
2230         * tui/tui-stack.c (_initialize_tui_stack): Move later.
2231         Remove unnecessary forward declarations.
2232
2233 2019-08-30  Tom Tromey  <tom@tromey.com>
2234
2235         * tui/tui-stack.c (tui_locator_window::set_locator_fullname): Call
2236         rerender.
2237         (tui_update_locator_fullname, tui_show_frame_info): Don't call
2238         tui_show_locator_content.
2239
2240 2019-08-30  Tom Tromey  <tom@tromey.com>
2241
2242         * tui/tui-stack.c (tui_show_locator_content): Move lower.  Rewrite.
2243         (tui_locator_window::rerender): Rewrite using body of previous
2244         tui_show_locator_content.
2245
2246 2019-08-30  Tom Tromey  <tom@tromey.com>
2247
2248         * tui/tui-stack.h (struct tui_locator_window) <set_locator_info,
2249         set_locator_fullname>: New methods.
2250         * tui/tui-stack.c (tui_locator_window::set_locator_fullname):
2251         Rename from tui_set_locator_fullname.
2252         (tui_locator_window::set_locator_info): Rename from
2253         tui_set_locator_info.  Return bool.
2254         (tui_update_locator_fullname, tui_show_frame_info): Update.
2255
2256 2019-08-30  Tom Tromey  <tom@tromey.com>
2257
2258         * tui/tui-layout.c (show_layout): Don't call tui_refresh_all.
2259
2260 2019-08-30  Tom Tromey  <tom@tromey.com>
2261
2262         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Don't
2263         call touchwin.
2264
2265 2019-08-30  Tom Tromey  <tom@tromey.com>
2266
2267         * tui/tui-wingeneral.c (box_win): Assume win_info and
2268         win_info->handle cannot be NULL.
2269
2270 2019-08-30  Tom Tromey  <tom@tromey.com>
2271
2272         * tui/tui-regs.h (struct tui_data_item_window) <rerender,
2273         refresh_window>: Declare.
2274         * tui/tui-regs.c (tui_data_window::display_registers_from): Call
2275         resize.
2276         (tui_data_item_window::rerender): Rename from
2277         tui_display_register.
2278         (tui_data_item_window::refresh_window): New method.
2279         * tui/tui-layout.c (tui_gen_win_info::resize): Do nothing on
2280         no-op.
2281
2282 2019-08-30  Tom Tromey  <tom@tromey.com>
2283
2284         * tui/tui-regs.h (struct tui_data_window) <regs_content,
2285         regs_column_count, current_group>: Move later.  Now private.
2286         <get_current_group>: New method.
2287         * tui/tui-regs.c (tui_reg_command): Update.
2288         * tui/tui-layout.c (tui_set_layout): Update.
2289
2290 2019-08-30  Tom Tromey  <tom@tromey.com>
2291
2292         * tui/tui-regs.c (tui_data_window::display_registers_from_line)
2293         (tui_data_window::rerender): Don't call
2294         check_and_display_highlight_if_needed.
2295         (tui_data_window::refresh_all): Remove call to
2296         erase_data_content.
2297
2298 2019-08-30  Tom Tromey  <tom@tromey.com>
2299
2300         * tui/tui-regs.c (tui_data_window::last_regs_line_no)
2301         (tui_data_window::display_registers_from)
2302         (tui_data_window::display_reg_element_at_line)
2303         (tui_data_window::display_registers_from_line): Remove checks of
2304         "empty".
2305
2306 2019-08-30  Tom Tromey  <tom@tromey.com>
2307
2308         * tui/tui-regs.h (struct tui_data_window) <display_all_data>:
2309         Don't declare.
2310         * tui/tui-regs.c (tui_data_window::show_registers): Call
2311         rerender.
2312         (tui_data_window::rerender): Rename from display_all_data.
2313         (tui_data_window::rerender): Remove old implementation.
2314
2315 2019-08-30  Tom Tromey  <tom@tromey.com>
2316
2317         * tui/tui-regs.c (tui_data_window::display_all_data): Change
2318         text.
2319         * tui/tui-data.h (NO_DATA_STRING): Remove define.
2320
2321 2019-08-29  Bernhard Wodok  <barto@gmx.net>
2322             Sergio Durigan Junior  <sergiodj@redhat.com>
2323
2324         PR win32/24284
2325         * mingw-hdep.c (gdb_select): Handle case when 'n' is zero.
2326
2327 2019-08-28  Andrew Burgess  <andrew.burgess@embecosm.com>
2328
2329         * symtab.c (search_symbols): Don't include MODULE_DOMAIN symbols
2330         when searching for types.
2331
2332 2019-08-28  Andrew Burgess  <andrew.burgess@embecosm.com>
2333
2334         * f-lang.c (f_language_defn): Use f_print_typedef.
2335         * f-lang.h (f_print_typedef): Declare.
2336         * f-typeprint.c (f_print_typedef): Define.
2337
2338 2019-08-27  Christian Biesinger  <cbiesinger@google.com>
2339
2340         * nat/linux-namespaces.c (mnsh_main): Initialize fd (to -1).
2341
2342 2019-08-27  Andrew Burgess  <andrew.burgess@embecosm.com>
2343
2344         * cli/cli-utils.c (info_print_options_defs): Delete.
2345         (make_info_print_options_def_group): Delete.
2346         (extract_info_print_options): Delete.
2347         (info_print_command_completer): Delete.
2348         (info_print_args_help): Add extra parameter, and optionally
2349         include text about -n flag.
2350         * cli/cli-utils.h (struct info_print_options): Delete.
2351         (extract_info_print_options): Delete declaration.
2352         (info_print_command_completer): Delete declaration.
2353         (info_print_args_help): Add extra parameter, extend header
2354         comment.
2355         * python/python.c (gdbpy_rbreak): Pass additional parameter to
2356         search_symbols.
2357         * stack.c (struct info_print_options): New type.
2358         (info_print_options_defs): New file scoped variable.
2359         (make_info_print_options_def_group): New static function.
2360         (info_print_command_completer): New static function.
2361         (info_locals_command): Update to use new local functions.
2362         (info_args_command): Likewise.
2363         (_initialize_stack): Add extra parameter to calls to
2364         info_print_args_help.
2365         * symtab.c (search_symbols): Add extra parameter, use this to
2366         possibly excluse non-debug symbols.
2367         (symtab_symbol_info): Add extra parameter, which is passed on to
2368         search_symbols.
2369         (struct info_print_options): New type.
2370         (info_print_options_defs): New file scoped variable.
2371         (make_info_print_options_def_group): New static function.
2372         (info_print_command_completer): New static function.
2373         (info_variables_command): Update to use local functions, and pass
2374         extra parameter through to symtab_symbol_info.
2375         (info_functions_command): Likewise.
2376         (info_types_command): Pass additional argument through to
2377         symtab_symbol_info.
2378         (rbreak_command): Pass extra argument to search_symbols.
2379         (_initialize_symtab): Add extra arguments for calls to
2380         info_print_args_help, and update help text for 'info variables',
2381         'whereis', and 'info functions' commands.
2382         * symtab.h (search_symbols): Add extra argument to declaration.
2383         * NEWS: Mention new flags.
2384
2385 2019-08-26  Christian Biesinger  <cbiesinger@google.com>
2386
2387         * symtab.c (lookup_static_symbol): Call the new function (and move
2388         it down to be next to lookup_global_symbol).
2389         (struct global_sym_lookup_data): Add block_enum member and rename to...
2390         (struct global_or_static_sym_lookup_data): ...this.
2391         (lookup_symbol_global_iterator_cb): Pass block_index instead of
2392         GLOBAL_BLOCK to lookup_symbol_in_objfile and rename to...
2393         (lookup_symbol_global_or_static_iterator_cb): ...this.
2394         (lookup_global_or_static_symbol): New function.
2395         (lookup_global_symbol): Call new function.
2396
2397 2019-08-26  Tom de Vries  <tdevries@suse.de>
2398
2399         PR c++/24852
2400         * break-catch-throw.c (fetch_probe_arguments): Improve error mesage
2401         when pc_probe.prob == NULL.
2402
2403 2019-08-25  Simon Marchi  <simon.marchi@efficios.com>
2404
2405         * dwarf2read.c (dw2_debug_names_iterator::next): Rename local
2406         variable symbol_linkage to symbol_linkage_.
2407
2408 2019-08-25  Simon Marchi  <simon.marchi@efficios.com>
2409
2410         * dwarf2read.c (dw2_debug_names_iterator::next): Use enum to
2411         represent whether the symbol is static, dynamic, or we don't
2412         know.
2413
2414 2019-08-25  Yoshinori Sato <ysato@users.sourceforge.jp>
2415
2416         * gdb/rx-tdep.c (rx_register_names): New.
2417         (rx_register_name): Delete.
2418         (rx_psw_type): Delete.
2419         (rx_fpsw_type): Delete.
2420         (rx_register_type): Delete.
2421         (rx_gdbarch_init): Convert target-descriptions.
2422         (_initialize_rx_tdep): Add initialize_tdesc_rx.
2423         * gdb/features/Makefile: Add rx.xml.
2424         * gdb/features/rx.xml: New.
2425         * gdb/features/rx.c: Generated.
2426         * gdb/NEWS: Mention target description support.
2427
2428 2019-08-22  Christian Biesinger  <cbiesinger@google.com>
2429
2430         * symtab.c (symbol_cache_lookup): Always initialize *bsc_ptr and
2431         *slot_ptr.
2432
2433 2019-08-23  Sergio Durigan Junior  <sergiodj@redhat.com>
2434
2435         * configure.ac: Don't check for 'dlfcn.h' (moved to
2436         gdbsupport/common.m4).
2437         * Makefile.in (COMMON_SFILES): Move 'gdb-dlfcn.c' to
2438         'gdbsupport/'.
2439         (HFILES_NO_SRCDIR): Likewise, for 'gdb-dlfcn.h'.
2440         * compile/compile-c-support.c: Include
2441         'gdbsupport/gdb-dlfcn.h'.
2442         * gdbsupport/common.m4: Check for 'dlfcn.h'.
2443         * gdb-dlfcn.c: Move to...
2444         * gdbsupport/gdb-dlfcn.c: ... here.
2445         * gdb-dlfcn.h: Move to...
2446         * gdbsupport/gdb-dlfcn.h: ... here.
2447
2448 2019-08-23  Sandra Loosemore  <sandra@codesourcery.com>
2449
2450         * nios2-tdep.c (struct reg_value): Improve comments.  Make
2451         the offset field signed.
2452
2453 2019-08-22  Christian Biesinger  <cbiesinger@google.com>
2454
2455         * python/lib/gdb/__init__.py (_execute_file): New function.
2456         * python/python.c (python_run_simple_file): Call gdb._execute_file
2457         on Windows.
2458
2459 2019-08-22  Andrew Burgess  <andrew.burgess@embecosm.com>
2460
2461         * f-exp.y (yylex): Remove is_a_field_of_this local variable, and
2462         all uses as this was never set to anything but a zero value.
2463
2464 2019-08-21  Bogdan Harjoc  <harjoc@gmail.com>
2465
2466         * cli/cli-cmds.c (with_command_1): Error out if no arguments.
2467
2468 2019-08-21  Christian Biesinger  <cbiesinger@google.com>
2469
2470         * tui/tui-data.h (tui_gen_win_info): Add an =default
2471         move constructor, required by some GCC versions.
2472
2473 2019-08-21  Jinke Fan  <fanjinke51@yeah.net>
2474
2475         * go32-nat.c (go32_sysinfo): Add hygon_p.
2476
2477 2019-08-20  Tom Tromey  <tom@tromey.com>
2478
2479         * tui/tui-regs.h (struct tui_data_window) <last_regs_line_no,
2480         line_from_reg_element_no, first_reg_element_no_inline,
2481         display_all_data, delete_data_content_windows,
2482         erase_data_content>: Now private.
2483
2484 2019-08-20  Tom Tromey  <tom@tromey.com>
2485
2486         * tui/tui-wingeneral.c (box_win): Change type of highlight_flag.
2487         (tui_unhighlight_win, tui_highlight_win)
2488         (tui_win_info::make_window): Update.
2489         * tui/tui-data.h (HILITE, NO_HILITE): Remove.
2490
2491 2019-08-20  Tom Tromey  <tom@tromey.com>
2492
2493         * tui/tui-data.h (PROC_PREFIX, LINE_PREFIX, PC_PREFIX)
2494         (MIN_LINE_WIDTH, MIN_PROC_WIDTH, MAX_TARGET_WIDTH)
2495         (MAX_PID_WIDTH): Move to tui-stack.c.
2496         * tui/tui-stack.c (PROC_PREFIX, LINE_PREFIX, PC_PREFIX)
2497         (MIN_LINE_WIDTH, MIN_PROC_WIDTH, MAX_TARGET_WIDTH)
2498         (MAX_PID_WIDTH): Move from tui-data.h.
2499
2500 2019-08-20  Tom Tromey  <tom@tromey.com>
2501
2502         * tui/tui-wingeneral.h (tui_make_window): Don't declare.
2503         * tui/tui-wingeneral.c (box_win): Change type of win_info.
2504         (box_win): Update.
2505         (tui_gen_win_info::make_window): Rename from tui_make_window.
2506         (tui_win_info::make_window): New method.
2507         (tui_gen_win_info::make_visible): Update.
2508         * tui/tui-source.c (tui_source_window::set_contents): Update.
2509         * tui/tui-regs.c (tui_data_window::show_register_group): Update.
2510         (tui_data_window::display_registers_from): Update.
2511         * tui/tui-layout.c (tui_gen_win_info::resize): Update.
2512         * tui/tui-data.h (struct tui_gen_win_info) <make_window>:
2513         Declare.
2514         <can_box>: Remove.
2515         <title>: Remove.
2516         (struct tui_win_info) <make_window>: Declare.
2517         <can_box>: Now virtual.
2518         <title>: New member.
2519         * tui/tui-data.c (~tui_gen_win_info): Don't free title.
2520         * tui/tui-command.c (tui_cmd_window::resize): Update.
2521
2522 2019-08-20  Tom Tromey  <tom@tromey.com>
2523
2524         * tui/tui-regs.h (struct tui_data_window) <display_regs>: Remove.
2525         * tui/tui-regs.c (tui_data_window::show_registers): Update.
2526         (tui_data_window::check_register_values): Update.
2527
2528 2019-08-20  Tom Tromey  <tom@tromey.com>
2529
2530         * tui/tui-regs.h (struct tui_data_window): Use
2531         DISABLE_COPY_AND_ASSIGN.
2532         <regs_content>: Change type, removing unique_ptr.
2533         <tui_data_window>: Add move constructor.
2534         * tui/tui-regs.c (tui_data_window::show_registers)
2535         (tui_data_window::show_register_group)
2536         (tui_data_window::display_registers_from)
2537         (tui_data_window::display_registers_from)
2538         (tui_data_window::first_data_item_displayed)
2539         (tui_data_window::delete_data_content_windows)
2540         (tui_data_window::rerender, tui_data_window::refresh_window)
2541         (tui_data_window::check_register_values): Update.
2542
2543 2019-08-20  Tom Tromey  <tom@tromey.com>
2544
2545         * tui/tui-regs.h (struct tui_data_window) <show_registers,
2546         show_register_group>: Declare.
2547         (tui_show_register_group): Don't declare.
2548         * tui/tui-regs.c (tui_data_window::show_registers): Rename from
2549         tui_show_registers.
2550         (tui_data_window::show_register_group): Rename from
2551         tui_show_register_group.
2552         (tui_data_window::check_register_values, tui_reg_command):
2553         Update.
2554         * tui/tui-layout.c (tui_set_layout): Update.
2555
2556 2019-08-20  Tom Tromey  <tom@tromey.com>
2557
2558         * tui/tui-regs.h (struct tui_data_window) <check_register_values>:
2559         Declare.
2560         (tui_check_register_values): Don't declare.
2561         * tui/tui-regs.c (tui_data_window::check_register_values): Rename
2562         from tui_check_register_values.
2563         * tui/tui-hooks.c (tui_register_changed): Update.
2564
2565 2019-08-20  Tom Tromey  <tom@tromey.com>
2566
2567         * tui/tui-regs.c (tui_reg_layout): Move later.
2568         (tui_show_registers): Don't enable TUI mode or change layout.
2569
2570 2019-08-20  Tom Tromey  <tom@tromey.com>
2571
2572         * tui/tui-regs.h (struct tui_data_item_window)
2573         <~tui_data_item_window>: Remove.
2574         <content>: Now a unique_xmalloc_ptr.
2575         * tui/tui-regs.c (tui_register_format): Return a
2576         unique_xmalloc_ptr.
2577         (tui_get_register): Update.
2578         (~tui_data_item_window): Remove.
2579         (tui_data_window::display_registers_from, tui_display_register):
2580         Update.
2581         * tui/tui-io.h (tui_expand_tabs): Update.
2582         * tui/tui-io.c (tui_expand_tabs): Return a unique_xmalloc_ptr.
2583         Remove "col" parameter.
2584
2585 2019-08-20  Tom Tromey  <tom@tromey.com>
2586
2587         * tui/tui-regs.h (struct tui_data_item_window) <value>: Remove
2588         field.
2589         * tui/tui-regs.c (~tui_data_item_window): Update.
2590
2591 2019-08-20  Tom Tromey  <tom@tromey.com>
2592
2593         * tui/tui-regs.c (tui_register_format, tui_get_register): Move
2594         earlier.
2595
2596 2019-08-20  Tom Tromey  <tom@tromey.com>
2597
2598         * tui/tui-regs.c (tui_reg_command): Remove NULL check.
2599
2600 2019-08-20  Tom Tromey  <tom@tromey.com>
2601
2602         * tui/tui-source.h (struct tui_source_window): Update.
2603         * tui/tui-regs.c (tui_show_registers): Update.
2604         * tui/tui-disasm.h (struct tui_disasm_window): Update.
2605         * tui/tui-data.h (NO_SRC_STRING, NO_DISASSEM_STRING)
2606         (NO_REGS_STRING): Remove defines.
2607
2608 2019-08-20  Conrad Meyer  <cem@FreeBSD.org>
2609
2610         * remote.c (remote_target::remote_btrace_maybe_reopen): Avoid
2611         unnecessary thread walk if remote doesn't support the packet.
2612
2613 2019-08-19  Tom Tromey  <tromey@adacore.com>
2614
2615         * python/py-value.c (value_has_field): Fix indentation.
2616
2617 2019-08-19  Tom Tromey  <tromey@adacore.com>
2618
2619         * printcmd.c (do_one_display, info_display_command): Update.
2620         * block.h (contained_in): Return bool.  Add allow_nested
2621         parameter.
2622         * block.c (contained_in): Return bool.  Add allow_nested
2623         parameter.
2624
2625 2019-08-19  Tom Tromey  <tom@tromey.com>
2626
2627         * configure: Rebuild.
2628         * configure.ac: Disallow the combination of -static-libstdc++ and
2629         source highlight.
2630         * source-cache.c (get_language_name): Handle rust.
2631         (source_cache::get_source_lines): Ignore highlighting exceptions.
2632
2633 2019-08-16  Tom Tromey  <tom@tromey.com>
2634
2635         * tui/tui.h (enum tui_win_type) <EXEC_INFO_WIN>: Remove.
2636         * tui/tui-winsource.h (struct tui_exec_info_window): Remove.
2637         (struct tui_source_window_base) <make_visible, refresh_window,
2638         resize>: Remove methods.
2639         <execution_info>: Remove field.
2640         * tui/tui-winsource.c (tui_source_window_base::do_erase_source_content)
2641         (tui_show_source_line, tui_source_window_base)
2642         (~tui_source_window_base): Update.
2643         (tui_source_window_base::resize)
2644         (tui_source_window_base::make_visible)
2645         (tui_source_window_base::refresh_window): Remove.
2646         (tui_source_window_base::update_exec_info): Update.
2647         * tui/tui-source.c (tui_source_window::set_contents): Update.
2648         * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
2649
2650 2019-08-16  Tom Tromey  <tom@tromey.com>
2651
2652         * tui/tui-hooks.c (tui_remove_hooks): Don't set
2653         deprecated_query_hook.
2654
2655 2019-08-16  Tom Tromey  <tom@tromey.com>
2656
2657         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
2658         (tui_update_source_windows_with_line): Update.
2659         * tui/tui-source.h (struct tui_source_window)
2660         <show_symtab_source>: Declare.
2661         (tui_show_symtab_source): Don't declare.
2662         * tui/tui-source.c (tui_show_symtab_source): Rename from
2663         tui_show_symtab_source.
2664
2665 2019-08-16  Tom Tromey  <tom@tromey.com>
2666
2667         * tui/tui-winsource.h (struct tui_source_window_base)
2668         <set_contents>: Declare.
2669         * tui/tui-winsource.c
2670         (tui_source_window_base::update_source_window_as_is): Update.
2671         * tui/tui-source.h (struct tui_source_window) <set_contents>:
2672         Declare.
2673         (tui_set_source_content): Don't declare.
2674         * tui/tui-source.c (tui_source_window::set_contents): Rename from
2675         tui_set_source_content.
2676         * tui/tui-disasm.h (struct tui_disasm_window) <set_contents>:
2677         Declare.
2678         (tui_set_disassem_content): Don't declare.
2679         * tui/tui-disasm.c (tui_disasm_window::set_contents): Rename from
2680         tui_set_disassem_content.
2681
2682 2019-08-16  Tom Tromey  <tom@tromey.com>
2683
2684         * tui/tui-winsource.h (struct tui_source_window_base)
2685         <update_breakpoint_info>: Declare.
2686         (tui_update_breakpoint_info): Don't declare.
2687         * tui/tui-winsource.c (tui_source_window_base::update_source_window_as_is)
2688         (tui_update_all_breakpoint_info): Update.
2689         (tui_source_window_base::update_breakpoint_info): Rename from
2690         tui_update_breakpoint_info.
2691         (tui_source_window_base::update_exec_info): Update.
2692
2693 2019-08-16  Tom Tromey  <tom@tromey.com>
2694
2695         * tui/tui-winsource.h (struct tui_source_window_base)
2696         <update_source_window>: Declare.
2697         (tui_update_source_window): Don't declare.
2698         * tui/tui-winsource.c
2699         (tui_source_window_base::update_source_window): Rename from
2700         tui_update_source_window.
2701         (tui_source_window_base::rerender): Update.
2702         * tui/tui-source.c (tui_source_window::maybe_update): Update.
2703         * tui/tui-disasm.c (tui_show_disassem)
2704         (tui_show_disassem_and_update_source)
2705         (tui_disasm_window::maybe_update): Update.
2706
2707 2019-08-16  Tom Tromey  <tom@tromey.com>
2708
2709         * tui/tui-winsource.h (struct tui_source_window_base)
2710         <update_source_window_as_is>: Declare.
2711         (tui_update_source_window_as_is): Don't declare.
2712         * tui/tui-winsource.c (tui_update_source_window): Update
2713         (tui_source_window_base::update_source_window_as_is): Rename from
2714         tui_update_source_window_as_is.
2715         (tui_source_window_base::refill): Update.
2716         * tui/tui-source.c (tui_show_symtab_source): Update.
2717         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical):
2718         Update.
2719
2720 2019-08-16  Tom Tromey  <tom@tromey.com>
2721
2722         * tui/tui-winsource.h (tui_update_source_window)
2723         (tui_update_source_window_as_is): Remove "noerror" parameter.
2724         * tui/tui-winsource.c (tui_update_source_window)
2725         (tui_update_source_window_as_is): Remove "noerror" parameter.
2726         (tui_update_source_windows_with_addr)
2727         (tui_update_source_windows_with_line)
2728         (tui_source_window_base::rerender)
2729         (tui_source_window_base::refill): Update.
2730         * tui/tui-source.h (tui_set_source_content)
2731         (tui_show_symtab_source): Remove "noerror" parameter.
2732         * tui/tui-source.c (tui_set_source_content): Remove "noerror"
2733         parameter.
2734         (tui_show_symtab_source): Likewise.
2735         (tui_source_window::maybe_update): Update.
2736         * tui/tui-disasm.c (tui_show_disassem)
2737         (tui_show_disassem_and_update_source)
2738         (tui_disasm_window::do_scroll_vertical)
2739         (tui_disasm_window::maybe_update): Update.
2740
2741 2019-08-16  Tom Tromey  <tom@tromey.com>
2742
2743         * tui/tui.c (tui_is_window_visible): Update.
2744         * tui/tui-wingeneral.c (tui_make_window)
2745         (tui_gen_win_info::make_visible, tui_refresh_all): Update.
2746         * tui/tui-win.c (window_name_completer, tui_refresh_all_win)
2747         (tui_set_focus_command, tui_all_windows_info, update_tab_width)
2748         (tui_set_win_height_command, parse_scrolling_args): Update.
2749         * tui/tui-source.c (tui_source_window::style_changed): Update.
2750         * tui/tui-regs.c (tui_show_registers)
2751         (tui_data_window::first_data_item_displayed)
2752         (tui_data_window::delete_data_content_windows)
2753         (tui_check_register_values, tui_reg_command): Update.
2754         * tui/tui-disasm.c (tui_show_disassem): Update.
2755         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: New
2756         method.
2757         <is_visible>: Remove field.
2758         * tui/tui-data.c (tui_next_win, tui_prev_win)
2759         (tui_delete_invisible_windows): Update.
2760
2761 2019-08-16  Tom Tromey  <tom@tromey.com>
2762
2763         * tui/tui-winsource.h (struct tui_source_window_base)
2764         <m_has_locator>: Remove.
2765         * tui/tui-layout.c (show_source_disasm_command, show_data)
2766         (show_source_or_disasm_and_command): Update.
2767
2768 2019-08-16  Alan Hayward  <alan.hayward@arm.com>
2769
2770         * NEWS (Other MI changes): New subsection.
2771         * aarch64-tdep.c (aarch64_get_pc_address_flags): New function.
2772         (aarch64_gdbarch_init): Add aarch64_get_pc_address_flags.
2773         * arch-utils.c (default_get_pc_address_flags): New function.
2774         * arch-utils.h (default_get_pc_address_flags): New declaration.
2775         * gdbarch.sh: Add get_pc_address_flags.
2776         * gdbarch.c: Regenerate.
2777         * gdbarch.h: Likewise.
2778         * stack.c (print_pc): New function.
2779         (print_frame_info) (print_frame): Call print_pc.
2780
2781 2019-08-16  Tom de Vries  <tdevries@suse.de>
2782
2783         * maint.c (maintenance_info_sections): Also handle !ALLOBJ case using
2784         print_objfile_section_info.
2785
2786 2019-08-15  Tom Tromey  <tom@tromey.com>
2787
2788         * tui/tui-io.c (tui_puts_internal): Check TUI_CMD_WIN before
2789         calling update_cmdwin_start_line.
2790         * tui/tui-winsource.h (struct tui_source_window_base)
2791         <do_make_visible_with_new_height, set_new_height>: Don't declare.
2792         <rerender>: Declare.
2793         * tui/tui-winsource.c (tui_source_window_base::update_tab_width):
2794         Call rerender.
2795         (tui_source_window_base::set_new_height): Remove.
2796         (tui_source_window_base::rerender): Rename from
2797         do_make_visible_with_new_height.
2798         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Use
2799         resize method.
2800         (tui_win_info::make_invisible_and_set_new_height)
2801         (tui_win_info::make_visible_with_new_height): Remove.
2802         * tui/tui-stack.h (struct tui_locator_window) <rerender>:
2803         Declare.
2804         * tui/tui-stack.c (tui_locator_window::rerender): New method.
2805         * tui/tui-regs.h (struct tui_data_window) <set_new_height,
2806         do_make_visible_with_new_height>: Don't declare.
2807         <rerender>: Declare.
2808         * tui/tui-regs.c (tui_data_window::rerender): Rename from
2809         set_new_height.
2810         (tui_data_window::do_make_visible_with_new_height): Remove.
2811         * tui/tui-layout.c (show_source_disasm_command, show_data): Don't
2812         call tui_show_locator_content.
2813         (tui_gen_win_info::resize): Call rerender.
2814         (show_source_or_disasm_and_command): Don't call
2815         tui_show_locator_content.
2816         * tui/tui-data.h (struct tui_gen_win_info) <rerender>: New
2817         method.
2818         (struct tui_win_info) <rerender>: Declare.
2819         <set_new_height, make_invisible_and_set_new_height,
2820         make_visible_with_new_height>: Don't declare.
2821         * tui/tui-data.c (tui_win_list::rerender): New method.
2822         * tui/tui-command.h (struct tui_cmd_window)
2823         <do_make_visible_with_new_height>: Don't declare.
2824         * tui/tui-command.c
2825         (tui_cmd_window::do_make_visible_with_new_height): Remove.
2826
2827 2019-08-15  Tom Tromey  <tromey@adacore.com>
2828
2829         * ada-exp.y (convert_char_literal): Handle "Q%c" encoding.
2830         * ada-lang.c (ada_enum_name): Likewise.
2831
2832 2019-08-15  Christian Biesinger  <cbiesinger@google.com>
2833
2834         * python/lib/gdb/__init__.py (GdbOutputFile): Rename to have a
2835         leading underscore.
2836         (GdbOutputErrorFile): Likewise.
2837         (global scope): Adjust constructor calls to GdbOutput{,Error}File
2838         accordingly.
2839         (execute_unwinders): Rename to have a leading underscore.
2840         (auto_load_packages): Likewise.
2841         (global scope): Adjust call to auto_load_packages accordingly.
2842         (GdbSetPythonDirectory): Likewise.
2843         * python/py-unwind.c (pyuw_sniffer): Call _execute_unwinders
2844         instead of execute_unwinders.
2845
2846 2019-08-15  Tom Tromey  <tom@tromey.com>
2847
2848         * tui/tui-layout.c (show_layout, show_source_disasm_command)
2849         (show_data): Don't change window visibility.
2850         (tui_gen_win_info::resize): Remove special case for command
2851         window.  Use wresize, when available.
2852         (show_source_or_disasm_and_command): Don't change window
2853         visibility.
2854         * tui/tui-command.h (struct tui_cmd_window) <resize>: Declare.
2855         <make_visible>: New method.
2856         * tui/tui-command.c (tui_cmd_window::resize): New method.
2857
2858 2019-08-15  Tom Tromey  <tom@tromey.com>
2859
2860         * tui/tui-winsource.h (struct tui_source_window_iterator): New.
2861         (struct tui_source_windows): New.
2862         * tui/tui-winsource.c (tui_display_main): Update.
2863         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
2864         (new_height_ok, parse_scrolling_args): Update.
2865         * tui/tui-layout.c (show_layout, show_data): Update.
2866         * tui/tui-data.h (tui_source_windows, tui_clear_source_windows)
2867         (tui_add_to_source_windows): Don't declare.
2868         * tui/tui-data.c (source_windows, tui_source_windows)
2869         (tui_clear_source_windows, tui_add_to_source_windows): Remove.
2870
2871 2019-08-15  Tom Tromey  <tom@tromey.com>
2872
2873         * tui/tui-winsource.h (struct tui_source_window_base) <resize>:
2874         Rename from reset.
2875         * tui/tui-winsource.c (tui_source_window_base::resize): Rename.
2876         * tui/tui-layout.c (show_source_disasm_command, show_data):
2877         Update.
2878         (tui_gen_win_info::resize): Rename.
2879         (show_source_or_disasm_and_command): Update.
2880         * tui/tui-data.h (struct tui_gen_win_info) <resize>: Rename from
2881         reset.
2882
2883 2019-08-15  Tom Tromey  <tom@tromey.com>
2884
2885         * tui/tui-stack.c (tui_initialize_static_data): Remove.
2886         * tui/tui-interp.c (tui_interp::init): Don't call
2887         tui_initialize_static_data.
2888         * tui/tui-data.h (tui_initialize_static_data): Don't declare.
2889
2890 2019-08-15  Tom Tromey  <tom@tromey.com>
2891
2892         * tui/tui-layout.c (tui_default_win_viewport_height): Don't
2893         examine tui_win_list.
2894
2895 2019-08-15  Tom Tromey  <tom@tromey.com>
2896
2897         * tui/tui-winsource.h (tui_clear_source_content): Don't declare.
2898         * tui/tui-winsource.c (tui_update_source_window_as_is): Don't call
2899         tui_clear_source_content.
2900         (tui_clear_source_content): Remove.
2901         (tui_source_window_base::do_erase_source_content): Hoist call to
2902         content.clear().
2903         * tui/tui-stack.c (tui_show_frame_info): Don't call
2904         tui_clear_source_content.
2905
2906 2019-08-15  Tom Tromey  <tom@tromey.com>
2907
2908         * tui/tui-winsource.h (struct tui_source_window_base)
2909         <do_erase_source_content>: New method.
2910         <erase_source_content>: New method.
2911         (tui_erase_source_content): Don't declare.
2912         * tui/tui-winsource.c (tui_clear_source_content): Update.
2913         (tui_source_window_base::do_erase_source_content): Rename from
2914         tui_erase_source_content.
2915         (tui_source_window_base::show_source_content): Update.
2916         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
2917         * tui/tui-source.h (struct tui_source_window)
2918         <erase_source_content>: New method.
2919         * tui/tui-disasm.h (struct tui_disasm_window)
2920         <erase_source_content>: New method.
2921
2922 2019-08-15  Tom Tromey  <tom@tromey.com>
2923
2924         * tui/tui-winsource.h (tui_alloc_source_buffer): Don't declare.
2925         (struct tui_source_element): Add DISABLE_COPY_AND_ASSIGN, and move
2926         constructor.
2927         * tui/tui-winsource.c (tui_alloc_source_buffer): Remove.
2928         * tui/tui-source.c (tui_set_source_content): Update.
2929         * tui/tui-disasm.c (tui_set_disassem_content): Update.
2930
2931 2019-08-15  Tom Tromey  <tom@tromey.com>
2932
2933         * tui/tui-winsource.h (tui_line_is_displayed): Don't declare.
2934         * tui/tui-winsource.c (tui_line_is_displayed): Move to
2935         tui-source.c.
2936         * tui/tui-source.h (struct tui_source_window) <line_is_displayed>:
2937         Declare.
2938         * tui/tui-source.c (tui_source_window::line_is_displayed): New
2939         method.
2940         (tui_source_window::maybe_update): Update.
2941
2942 2019-08-15  Tom Tromey  <tom@tromey.com>
2943
2944         * tui/tui-winsource.h (tui_addr_is_displayed): Don't declare.
2945         * tui/tui-winsource.c (tui_addr_is_displayed): Move to
2946         tui-disasm.c.
2947         * tui/tui-disasm.h (struct tui_disasm_window) <addr_is_displayed>:
2948         Declare.
2949         * tui/tui-disasm.c (tui_disasm_window::addr_is_displayed): New
2950         method.
2951         (tui_disasm_window::maybe_update): Update.
2952
2953 2019-08-15  Tom Tromey  <tom@tromey.com>
2954
2955         * tui/tui-winsource.h (struct tui_source_window_base)
2956         <maybe_update>: Declare.
2957         * tui/tui-stack.c (tui_show_frame_info): Call maybe_update
2958         method.
2959         * tui/tui-source.h (struct tui_source_window) <maybe_update>:
2960         Declare.
2961         * tui/tui-source.c (tui_source_window::maybe_update): New method.
2962         * tui/tui-disasm.h (struct tui_disasm_window) <maybe_update>:
2963         Declare.
2964         * tui/tui-disasm.c (tui_disasm_window::maybe_update): New method.
2965
2966 2019-08-15  Tom Tromey  <tom@tromey.com>
2967
2968         * tui/tui-stack.c (tui_make_status_line): Use string constructor.
2969
2970 2019-08-15  Tom Tromey  <tom@tromey.com>
2971
2972         * tui/tui-wingeneral.c: Include tui-stack.h.
2973         * tui/tui-stack.h (MAX_LOCATOR_ELEMENT_LEN)
2974         (struct tui_locator_window): Move from tui-data.h.
2975         * tui/tui-stack.c (_locator, tui_locator_win_info_ptr)
2976         (tui_initialize_static_data): Move from tui-data.c.
2977         * tui/tui-data.h (MAX_LOCATOR_ELEMENT_LEN)
2978         (struct tui_locator_window): Move to tui-stack.c.
2979         * tui/tui-data.c (_locator, tui_locator_win_info_ptr)
2980         (tui_initialize_static_data): Move to tui-stack.c.
2981
2982 2019-08-15  Tom Tromey  <tom@tromey.com>
2983
2984         * tui/tui-layout.c (show_source_disasm_command)
2985         (show_source_or_disasm_and_command): Use make_visible method, not
2986         tui_make_window.
2987         * tui/tui-command.h (struct tui_cmd_window) <make_visible>:
2988         Remove.
2989
2990 2019-08-15  Tom Tromey  <tom@tromey.com>
2991
2992         * tui/tui-wingeneral.h (tui_make_window): Update.
2993         * tui/tui-wingeneral.c (tui_make_window): Remove "box_it"
2994         parameter.
2995         (tui_gen_win_info::make_visible): Update.
2996         * tui/tui-regs.c (tui_data_window::display_registers_from):
2997         Update.
2998         * tui/tui-layout.c (show_source_disasm_command)
2999         (show_source_or_disasm_and_command): Update.
3000         * tui/tui-data.h (struct tui_gen_win_info) <can_box>: New method.
3001         (enum tui_box): Remove.
3002         (struct tui_win_info) <can_box>: New method.
3003         * tui/tui-command.h (struct tui_cmd_window) <can_box>: New
3004         method.
3005
3006 2019-08-15  Tom de Vries  <tdevries@suse.de>
3007
3008         * linux-nat-trad.c: Include gdbarch.h.
3009
3010 2019-08-14  Alan Hayward  <alan.hayward@arm.com>
3011
3012         * aarch64-tdep.c (aarch64_analyze_prologue): Allow any valid
3013         register sizes.
3014
3015 2019-08-14  Tom Tromey  <tromey@adacore.com>
3016
3017         * darwin-nat.c: Include gdbarch.h.
3018         * darwin-nat-info.c: Include gdbarch.h.
3019
3020 2019-08-13  Tom Tromey  <tom@tromey.com>
3021
3022         * tui/tui-data.h (struct tui_gen_win_info) <last_visible_line>:
3023         Remove.
3024         * tui/tui-data.c (tui_initialize_static_data): Update.
3025
3026 2019-08-13  Tom Tromey  <tom@tromey.com>
3027
3028         * tui/tui-winsource.h (struct tui_exec_info_window)
3029         <~tui_exec_info_window, maybe_allocate_content, get_content,
3030         m_content>: Remove.
3031         (struct tui_source_window_base) <set_exec_info_content,
3032         show_exec_info_content>: Don't declare.
3033         * tui/tui-winsource.c
3034         (tui_exec_info_window::maybe_allocate_content): Remove.
3035         (tui_source_window_base::update_exec_info): Rename from
3036         set_exec_info_content.
3037         (tui_source_window_base::show_exec_info_content)
3038         (tui_source_window_base::update_exec_info): Remove.
3039
3040 2019-08-13  Tom Tromey  <tom@tromey.com>
3041
3042         * tui/tui-winsource.h (tui_clear_exec_info_content): Don't
3043         declare.
3044         * tui/tui-winsource.c (tui_update_source_window_as_is)
3045         (tui_update_source_windows_with_addr, tui_erase_source_content):
3046         Update.
3047         (tui_clear_exec_info_content): Remove.
3048
3049 2019-08-13  Tom Tromey  <tom@tromey.com>
3050
3051         * tui/tui-winsource.h (tui_erase_exec_info_content): Don't
3052         declare.
3053         * tui/tui-winsource.c (tui_source_window_base::refresh_all): Don't
3054         call tui_erase_exec_info_content.
3055         (tui_clear_exec_info_content): Rename from
3056         tui_erase_exec_info_content.
3057         (tui_clear_exec_info_content): Delete.
3058
3059 2019-08-13  Tom Tromey  <tom@tromey.com>
3060
3061         * tui/tui-winsource.h (struct tui_source_window_base)
3062         <show_exec_info_content>: Declare.
3063         (tui_show_exec_info_content): Don't declare.
3064         * tui/tui-winsource.c
3065         (tui_source_window_base::show_exec_info_content): Rename from
3066         tui_show_exec_info_content.
3067         (tui_source_window_base::update_exec_info): Update.
3068
3069 2019-08-13  Tom Tromey  <tom@tromey.com>
3070
3071         * tui/tui-data.h (enum tui_bp_flag, tui_bp_flags, struct tui_source_element)
3072         (TUI_BP_HIT_POS, TUI_BP_BREAK_POS, TUI_EXEC_POS)
3073         (TUI_EXECINFO_SIZE, tui_exec_info_content): Move ...
3074         * tui/tui-winsource.h (enum tui_bp_flag, tui_bp_flags, struct
3075         tui_source_element, TUI_BP_HIT_POS, TUI_BP_BREAK_POS)
3076         (TUI_EXEC_POS, TUI_EXECINFO_SIZE, tui_exec_info_content):
3077         ... here.
3078
3079 2019-08-13  Tom Tromey  <tom@tromey.com>
3080
3081         * tui/tui-winsource.h (struct tui_source_window_base)
3082         <update_exec_info>: Declare.
3083         (tui_update_exec_info): Don't declare.
3084         * tui/tui-winsource.c (tui_update_source_window_as_is)
3085         (tui_source_window_base::refresh_all)
3086         (tui_update_all_breakpoint_info): Update.
3087         (tui_source_window_base::update_exec_info): Rename from
3088         tui_update_exec_info.
3089         * tui/tui-stack.c (tui_show_frame_info): Update.
3090
3091 2019-08-13  Tom Tromey  <tom@tromey.com>
3092
3093         * tui/tui-winsource.h (struct tui_source_window_base)
3094         <set_exec_info_content>: Declare.
3095         (tui_set_exec_info_content): Don't declare.
3096         * tui/tui-winsource.c
3097         (tui_source_window_base::set_exec_info_content): Rename from
3098         tui_set_exec_info_content.
3099         (tui_update_exec_info): Update.
3100
3101 2019-08-13  Tom Tromey  <tom@tromey.com>
3102
3103         * tui/tui-winsource.h (struct tui_source_window_base)
3104         <show_source_content>: Declare.
3105         (tui_show_source_content): Don't declare.
3106         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
3107         (tui_source_window_base::show_source_content): Rename from
3108         tui_show_source_content.
3109         (tui_source_window_base::refresh_all): Update.
3110         * tui/tui-layout.c (show_source_disasm_command)
3111         (show_source_or_disasm_and_command): Update.
3112
3113 2019-08-13  Tom Tromey  <tom@tromey.com>
3114
3115         * tui/tui-winsource.c (tui_erase_source_content)
3116         (tui_show_source_content, tui_source_window_base::refresh_all):
3117         Update.
3118         * tui/tui-wingeneral.h
3119         (tui_check_and_display_highlight_if_needed): Don't declare.
3120         * tui/tui-wingeneral.c
3121         (tui_win_info::check_and_display_highlight_if_needed): Rename from
3122         check_and_display_highlight_if_needed.
3123         * tui/tui-win.c (tui_rehighlight_all)
3124         (tui_win_info::make_visible_with_new_height): Update.
3125         * tui/tui-regs.c (tui_data_window::display_registers_from_line)
3126         (tui_data_window::erase_data_content)
3127         (tui_data_window::display_all_data): Update.
3128         * tui/tui-data.h (struct tui_win_info)
3129         <check_and_display_highlight_if_needed>: Declare.
3130
3131 2019-08-13  Tom Tromey  <tom@tromey.com>
3132
3133         * tui/tui-win.c (tui_resize_all): Call
3134         tui_delete_invisible_windows.
3135         * tui/tui-layout.c (show_layout): Call
3136         tui_delete_invisible_windows.
3137         * tui/tui-data.h (tui_delete_invisible_windows): Declare.
3138         * tui/tui-data.c (tui_delete_invisible_windows): New function.
3139
3140 2019-08-13  Tom Tromey  <tom@tromey.com>
3141
3142         * tui/tui-disasm.c (tui_show_disassem): Add assertion.  Don't call
3143         tui_add_win_to_layout.
3144
3145 2019-08-13  Tom Tromey  <tom@tromey.com>
3146
3147         * tui/tui-layout.h (tui_default_win_height): Don't declare.
3148         * tui/tui-layout.c (tui_default_win_height): Now static.
3149
3150 2019-08-13  Tom Tromey  <tom@tromey.com>
3151
3152         * tui/tui-layout.c (show_layout): Unify all layout cases into a
3153         single switch.
3154         (show_source_disasm_command, show_source_or_disasm_and_command):
3155         Don't check current layout.
3156
3157 2019-08-13  Tom Tromey  <tom@tromey.com>
3158
3159         * tui/tui-wingeneral.c (make_all_visible): Remove.
3160         (tui_make_all_invisible): Simplify.
3161         * tui/tui-layout.c (tui_make_all_invisible): Move from
3162         tui-wingeneral.c; simplify.
3163         (show_layout): Hoist call to tui_make_all_invisible.
3164         (show_data): Don't call tui_make_all_invisible.
3165
3166 2019-08-13  Tom Tromey  <tom@tromey.com>
3167
3168         * tui/tui-wingeneral.h (tui_make_all_visible): Don't declare.
3169         * tui/tui-wingeneral.c (tui_make_all_visible): Remove.
3170
3171 2019-08-13  Tom Tromey  <tom@tromey.com>
3172
3173         * tui/tui-layout.c (current_layout, tui_current_layout): Move from
3174         tui-data.c.
3175         (show_source_disasm_command, show_data)
3176         (show_source_or_disasm_and_command): Don't use
3177         tui_set_current_layout_to.
3178         * tui/tui-data.h (tui_set_current_layout_to): Don't declare.
3179         * tui/tui-data.c (current_layout, tui_current_layout): Move to
3180         tui-layout.c.
3181         (tui_set_current_layout_to): Remove.
3182
3183 2019-08-13  Tom Tromey  <tom@tromey.com>
3184
3185         * tui/tui-layout.c (tui_set_layout): Update.
3186         * tui/tui-data.h (struct tui_layout_def): Remove.
3187         (tui_layout_def): Don't declare.
3188         * tui/tui-data.c (layout_def): Remove.
3189         (tui_layout_def): Remove.
3190
3191 2019-08-13  Tom Tromey  <tom@tromey.com>
3192
3193         * tui/tui-winsource.h (struct tui_source_window_base)
3194         <clear_detail>: No longer "override".
3195         * tui/tui-regs.h (struct tui_data_window) <clear_detail>: Remove.
3196         * tui/tui-regs.c (tui_data_window::clear_detail): Remove.
3197         * tui/tui-data.h (struct tui_win_info) <clear_detail>: Remove.
3198         * tui/tui-command.h (struct tui_cmd_window) <clear_detail>:
3199         Remove.
3200         * tui/tui-command.c (tui_cmd_window::clear_detail): Remove.
3201
3202 2019-08-13  Tom Tromey  <tromey@adacore.com>
3203
3204         * tracepoint.c: Don't include readline.h or history.h.
3205
3206 2019-08-12  Tom Tromey  <tom@tromey.com>
3207
3208         * configure: Rebuild.
3209         * configure.ac: Check for readline 7.
3210         * NEWS: Mention readline 7 requirement.
3211         * README: Update.
3212
3213 2019-08-12  Tom Tromey  <tom@tromey.com>
3214
3215         * mingw-hdep.c (gdb_select): Remove readline hack.
3216
3217 2019-08-09  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
3218
3219         * blockframe.c (find_pc_partial_function): Set *block to nullptr
3220         when the function fails.
3221
3222 2019-08-09  Andreas Arnez  <arnez@linux.ibm.com>
3223
3224         * s390-tdep.c (s390_type_align): New function.
3225         (s390_gdbarch_init): Set it as type_align gdbarch method.
3226
3227 2019-08-09  Tom de Vries  <tdevries@suse.de>
3228
3229         PR gdb/24591
3230         * dwarf2read.c (dwarf2_fetch_die_loc_sect_off): Adjust pc_high and
3231         pc_low with relocation offset.
3232
3233 2019-08-07  Tom Tromey  <tromey@adacore.com>
3234
3235         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
3236         (print_frame_args): Update.
3237         * python/py-framefilter.c (py_print_single_arg, enumerate_args):
3238         Update.
3239         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
3240         * frame.h (struct frame_arg): Add initializers.
3241         <error>: Now a unique_xmalloc_ptr.
3242
3243 2019-08-07  Alan Hayward  <alan.hayward@arm.com>
3244
3245         * NEWS: Expand the Pointer Authentication entry.
3246         * aarch64-tdep.c (aarch64_frame_unmask_address): Rename from this.
3247         (aarch64_frame_unmask_lr): ... to this.
3248         (aarch64_prologue_prev_register, aarch64_dwarf2_prev_register):
3249         Call aarch64_frame_unmask_lr.
3250         * frame.c (struct frame_info): Add "masked" variable.
3251         (frame_set_previous_pc_masked) (frame_get_pc_masked): New functions.
3252         (fprint_frame): Check for masked pc.
3253         * frame.h (frame_set_previous_pc_masked) (frame_get_pc_masked): New
3254         declarations.
3255         * python/py-framefilter.c (py_print_frame): Check for masked pc.
3256         * stack.c (print_frame): Check for masked pc.
3257
3258 2019-08-06  Tom Tromey  <tom@tromey.com>
3259
3260         * stabsread.c (patch_block_stabs, read_one_struct_field)
3261         (read_enum_type): Use obstack_strndup.
3262         * rust-exp.y (rust_parser::copy_name): Use obstack_strndup.
3263         * gdb_obstack.h (obstack_strndup): Use obstack_strndup.
3264         * dwarf2read.c (guess_full_die_structure_name)
3265         (anonymous_struct_prefix): Use obstack_strndup.
3266         * dbxread.c (cp_set_block_scope): Use obstack_strndup.
3267         * c-exp.y (yylex): Use obstack_strndup.
3268         * ada-exp.y (write_object_renaming, write_ambiguous_var)
3269         (write_var_or_type): Use obstack_strndup.
3270
3271 2019-08-06  Tom Tromey  <tom@tromey.com>
3272
3273         * symfile.c (reread_symbols): Use obstack_strdup.
3274         * stabsread.c (read_type): Use obstack_strdup.
3275         * gdb_obstack.h (obstack_strdup): New overload.
3276         * dwarf2read.c (dwarf2_compute_name, create_dwo_unit_in_dwp_v1)
3277         (create_dwo_unit_in_dwp_v2, build_error_marker_type)
3278         (dwarf2_canonicalize_name): Use obstack_strdup.
3279         * dbxread.c (read_dbx_symtab): Use obstack_strdup.
3280         * cp-support.c (inspect_type, replace_typedefs_qualified_name):
3281         Use obstack_strdup.
3282
3283 2019-08-06  Tom Tromey  <tom@tromey.com>
3284
3285         * gdb_obstack.h (obstack_strdup): Define.
3286         * gdb_obstack.c (obstack_strdup): Don't define.
3287
3288 2019-08-06  Tom Tromey  <tom@tromey.com>
3289
3290         * xcoffread.c (SYMNAME_ALLOC, process_xcoff_symbol): Use
3291         obstack_strdup.
3292         * typeprint.c (typedef_hash_table::find_global_typedef): Use
3293         obstack_strdup.
3294         * symfile.c (allocate_compunit_symtab): Use obstack_strdup.
3295         * stabsread.c (common_block_start): Use obstack_strdup.
3296         * objfiles.c (set_objfile_main_name, objfile): Use
3297         obstack_strdup.
3298         * namespace.c (add_using_directive): Use obstack_strdup.
3299         * mdebugread.c (parse_symbol, parse_type): Use obstack_strdup.
3300         * jit.c (finalize_symtab): Use obstack_strdup.
3301         * dwarf2read.c (fixup_go_packaging, dwarf2_physname)
3302         (guess_partial_die_structure_name, partial_die_info::fixup)
3303         (dwarf2_name): Use obstack_strdup.
3304         * coffread.c (coff_read_struct_type, coff_read_enum_type): Use
3305         obstack_strdup.
3306         * c-exp.y (scan_macro_expansion): Use obstack_strdup.
3307         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
3308         obstack_strdup.
3309         * ada-lang.c (ada_decode_symbol): Use obstack_strdup.
3310
3311 2019-08-07  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3312
3313         * unittests/help-doc-selftests.c: New file.
3314         * Makefile.in: Add the new file.
3315
3316 2019-08-07  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3317
3318         * cli/cli-decode.h (print_doc_line): Add for_value_prefix argument.
3319         * cli/cli-decode.c (print_doc_line): Likewise.  It now prints
3320         the full first line, except when FOR_VALUE_PREFIX.  In this case,
3321         the trailing '.' is not output, and the first character is uppercased.
3322         (print_help_for_command): Update call to print_doc_line.
3323         (print_doc_of_command): Likewise.
3324         * cli/cli-setshow.c (deprecated_show_value_hack): Likewise.
3325         * cli/cli-option.c (append_indented_doc): Do not append newline.
3326         (build_help_option): Append newline after first appended_indented_doc
3327         only if a second call is done.
3328         (build_help): Append 2 new lines before each option, except the first
3329         one.
3330         * compile/compile.c (_initialize_compile): Add new lines after
3331         %OPTIONS%, when not at the end of the help.
3332         Change help doc or code
3333         producing the help doc to respect the invariants.
3334         * maint-test-options.c (_initialize_maint_test_options): Likewise.
3335         Also removed the new line after 'Options:', as all other commands
3336         do not put an empty line between 'Options:' and the first option.
3337         * printcmd.c (_initialize_printcmd): Likewise.
3338         * stack.c (_initialize_stack): Likewise.
3339         * interps.c (interpreter_exec_cmd): Fix "Usage:" line that was
3340         incorrectly telling COMMAND is optional.
3341         * ada-lang.c (_initialize_ada_language): Change help doc or code
3342         producing the help doc to respect the invariants.
3343         * ada-tasks.c (_initialize_ada_tasks): Likewise.
3344         * breakpoint.c (_initialize_breakpoint): Likewise.
3345         * cli/cli-cmds.c (_initialize_cli_cmds): Likewise.
3346         * cli/cli-logging.c (_initialize_cli_logging): Likewise.
3347         * cli/cli-setshow.c (_initialize_cli_setshow): Likewise.
3348         * cli/cli-style.c (cli_style_option::add_setshow_commands,
3349         _initialize_cli_style): Likewise.
3350         * corelow.c (core_target_info): Likewise.
3351         * dwarf-index-cache.c (_initialize_index_cache): Likewise.
3352         * dwarf2read.c (_initialize_dwarf2_read): Likewise.
3353         * filesystem.c (_initialize_filesystem): Likewise.
3354         * frame.c (_initialize_frame): Likewise.
3355         * gnu-nat.c (add_task_commands): Likewise.
3356         * infcall.c (_initialize_infcall): Likewise.
3357         * infcmd.c (_initialize_infcmd): Likewise.
3358         * interps.c (_initialize_interpreter): Likewise.
3359         * language.c (_initialize_language): Likewise.
3360         * linux-fork.c (_initialize_linux_fork): Likewise.
3361         * maint-test-settings.c (_initialize_maint_test_settings): Likewise.
3362         * maint.c (_initialize_maint_cmds): Likewise.
3363         * memattr.c (_initialize_mem): Likewise.
3364         * printcmd.c (_initialize_printcmd): Likewise.
3365         * python/lib/gdb/function/strfns.py (_MemEq, _StrLen, _StrEq,
3366         _RegEx): Likewise.
3367         * ravenscar-thread.c (_initialize_ravenscar): Likewise.
3368         * record-btrace.c (_initialize_record_btrace): Likewise.
3369         * record-full.c (_initialize_record_full): Likewise.
3370         * record.c (_initialize_record): Likewise.
3371         * regcache-dump.c (_initialize_regcache_dump): Likewise.
3372         * regcache.c (_initialize_regcache): Likewise.
3373         * remote.c (add_packet_config_cmd, init_remote_threadtests,
3374         _initialize_remote): Likewise.
3375         * ser-tcp.c (_initialize_ser_tcp): Likewise.
3376         * serial.c (_initialize_serial): Likewise.
3377         * skip.c (_initialize_step_skip): Likewise.
3378         * source.c (_initialize_source): Likewise.
3379         * stack.c (_initialize_stack): Likewise.
3380         * symfile.c (_initialize_symfile): Likewise.
3381         * symtab.c (_initialize_symtab): Likewise.
3382         * target-descriptions.c (_initialize_target_descriptions): Likewise.
3383         * top.c (init_main): Likewise.
3384         * tracefile-tfile.c (tfile_target_info): Likewise.
3385         * tracepoint.c (_initialize_tracepoint): Likewise.
3386         * tui/tui-win.c (_initialize_tui_win): Likewise.
3387         * utils.c (add_internal_problem_command): Likewise.
3388         * valprint.c (value_print_option_defs): Likewise.
3389
3390 2019-08-06  Frank Ch. Eigler  <fche@redhat.com>
3391
3392         PR build/24886
3393         * configure.ac: Drop enable-libmcheck support.
3394         * configure, config.in: Rebuild.
3395         * libmcheck.m4: Remove.
3396         * acinclude.m4: Don't include it.
3397         * Makefile.in: Don't distribute it.
3398         * top.c (print_gdb_configuration): Don't mention it.
3399
3400 2019-08-06  Tom Tromey  <tom@tromey.com>
3401
3402         * utils.c (set_output_style): Sometimes pass stream to
3403         emit_style_escape.
3404         * ui-out.h (class ui_out) <can_emit_style_escape>: Declare.
3405         * record-btrace.c (btrace_insn_history): Update.
3406         * mi/mi-out.h (class mi_ui_out) <can_emit_style_escape>: New
3407         method.
3408         * disasm.h (gdb_pretty_print_disassembler): Add uiout parameter.
3409         Update initializers.
3410         <m_uiout>: New field.
3411         <m_di>: Move lower.
3412         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
3413         Remove "uiout" parameter.
3414         (dump_insns): Update.
3415         * cli-out.h (class cli_ui_out) <can_emit_style_escape>: Declare.
3416         * cli-out.c (cli_ui_out::can_emit_style_escape): New method.
3417
3418 2019-08-06  Christian Biesinger  <cbiesinger@google.com>
3419
3420         * symtab.c (symbol_cache_lookup): Change int to enum block_enum.
3421         (error_in_psymtab_expansion): Likewise.
3422         (lookup_symbol_via_quick_fns): Likewise.
3423         (basic_lookup_transparent_type_quick): Likewise.
3424         (basic_lookup_transparent_type_1): Likewise.
3425
3426 2019-08-06  Tom Tromey  <tromey@adacore.com>
3427
3428         * source.c (last_source_error): Now bool.
3429         (print_source_lines_base): Make "noprint" bool.  Only open
3430         source file when last_source_visited changes.
3431
3432 2019-08-06  Tom Tromey  <tromey@adacore.com>
3433
3434         * annotate.c (annotate_source_line): Use g_source_cache.
3435         * source-cache.c (source_cache::get_plain_source_lines): Change
3436         parameters.  Populate m_offset_cache.
3437         (source_cache::ensure): New method.
3438         (source_cache::get_line_charpos): New method.
3439         (extract_lines): Move lower.  Change parameters.
3440         (source_cache::get_source_lines): Move lower.
3441         * source-cache.h (class source_cache): Update comment.
3442         <get_line_charpos>: New method.
3443         <get_source_lines>: Update comment.
3444         <clear>: Clear m_offset_cache.
3445         <get_plain_source_lines>: Change parameters.
3446         <ensure>: New method
3447         <m_offset_cache>: New member.
3448         * source.c (forget_cached_source_info_for_objfile): Update.
3449         (info_source_command): Use g_source_cache.
3450         (find_source_lines, open_source_file_with_line_charpos): Remove.
3451         (print_source_lines_base, search_command_helper): Use g_source_cache.
3452         * source.h (open_source_file_with_line_charpos): Don't declare.
3453         * symtab.h (struct symtab) <nlines, line_charpos>: Remove.
3454         * tui/tui-source.c (tui_source_window::do_scroll_vertical):
3455         Use g_source_cache.
3456
3457 2019-08-06  Tom Tromey  <tromey@adacore.com>
3458
3459         * source-cache.c (source_cache::get_plain_source_lines):
3460         Remove "first_line" and "last_line" parameters.
3461         (source_cache::get_source_lines): Cache plain text.
3462         * source-cache.h (class source_cache)
3463         <get_plain_source_lines>: Update.
3464
3465 2019-08-06  Tom Tromey  <tromey@adacore.com>
3466
3467         * source-cache.c (extract_lines): No longer a method.
3468         Changed type of parameter.  Include final newline.
3469         (selftests::extract_lines_test): New function.
3470         (_initialize_source_cache): Likewise.
3471         * source-cache.h (class source_cache)
3472         <extract_lines>: Don't declare.
3473
3474 2019-08-06  Tom Tromey  <tromey@adacore.com>
3475
3476         * breakpoint.c (init_breakpoint_sal): Update.
3477         (breakpoint): Update.
3478         * breakpoint.h (struct breakpoint) <filter>: Now a
3479         unique_xmalloc_ptr.
3480
3481 2019-08-05  Christian Biesinger  <cbiesinger@google.com>
3482
3483         * NEWS: Mention dictionary access on blocks.
3484         * python/py-block.c (blpy_getitem): New function.
3485         (block_object_as_mapping): New struct.
3486         (block_object_type): Use new struct for tp_as_mapping field.
3487
3488 2019-08-05  Christian Biesinger  <cbiesinger@google.com>
3489
3490         * objfiles.h (objfile): Add a comment describing partial symbols.
3491
3492 2019-08-05  Tom Tromey  <tromey@adacore.com>
3493
3494         * compile/compile.c (_initialize_compile): Use _(), not N_().
3495         * thread.c (_initialize_thread): Use _(), not N_().
3496         * stack.c (_initialize_stack): Use _(), not N_().
3497         * printcmd.c (_initialize_printcmd): Use _(), not N_().
3498
3499 2019-08-04  Simon Marchi  <simon.marchi@polymtl.ca>
3500
3501         * dwarf2read.c (struct dw2_symtab_iterator):
3502         <want_specific_block>: Remove.
3503         <block_index>: Change type to gdb::optional.
3504         (dw2_symtab_iter_init): Remove WANT_SPECIFIC_BLOCK parameter,
3505         change type of BLOCK_INDEX parameter to gdb::optional.
3506         (dw2_symtab_iter_next): Re-write in function of gdb::optional.
3507         (dw2_lookup_symbol): Don't pass argument for
3508         WANT_SPECIFIC_BLOCK.
3509         (dw2_expand_symtabs_for_function): Don't pass argument for
3510         WANT_SPECIFIC_BLOCK, pass empty optional for BLOCK_INDEX.
3511         (class dw2_debug_names_iterator)
3512         <dw2_debug_names_iterator>: Remove WANT_SPECIFIC_BLOCK
3513         parameter, change BLOCK_INDEX type to gdb::optional.
3514         <m_want_specific_block>: Remove.
3515         <m_block_index>: Change type to gdb::optional.
3516         (dw2_debug_names_iterator::next): Change type of IS_STATIC to
3517         gdb::optional.  Re-write in function of gdb::optional.
3518         (dw2_debug_names_lookup_symbol): Don't pass argument for
3519         WANT_SPECIFIC_BLOCK.
3520         (dw2_debug_names_expand_symtabs_for_function): Don't pass
3521         argument for WANT_SPECIFIC_BLOCK, pass empty optional for
3522         BLOCK_INDEX.
3523
3524 2019-08-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3525
3526         * NEWS: Mention changes to "info sources" command.
3527
3528 2019-08-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3529
3530         * symtab.c (filename_partial_match_opts): New struct type.
3531         (struct output_source_filename_data): New members
3532         regexp, c_regexp, partial_match.
3533         (output_source_filename): Use new members to decide to print file.
3534         (info_sources_option_defs): New variable.
3535         (make_info_sources_options_def_group, print_info_sources_header,
3536         info_sources_command_completer):
3537         New functions.
3538         (info_sources_command): Read new optional arguments.
3539         (_initialize_symtab): Update info sources help.
3540
3541 2019-08-02  Alexandre Oliva <oliva@adacore.com>
3542
3543         * ada-lang.c (exception_support_info_v0): Renamed from...
3544         (default_exception_support_info): ... this.  Create new
3545         definition for v1.
3546         (ada_has_this_exception_support): Look up catch_handlers_sym.
3547         (ada_exception_support_info_sniffer): Try v0 after default.
3548
3549 2019-08-01  Tom Tromey  <tromey@adacore.com>
3550
3551         * ia64-libunwind-tdep.h (struct libunwind_descr): Include
3552         gdbarch.h.
3553
3554 2019-08-01  Christian Biesinger  <cbiesinger@google.com>
3555
3556         * s12z-tdep.c: Fix include path for s12z-opc.h.
3557
3558 2019-08-01  Alan Hayward  <alan.hayward@arm.com>
3559
3560         * NEWS: Require GNU make 3.82.
3561
3562 2019-07-16  Tom Tromey  <tom@tromey.com>
3563
3564         * tui/tui-wingeneral.h (tui_copy_win, tui_box_win): Don't
3565         declare.
3566
3567 2019-07-30  Tom Tromey  <tromey@adacore.com>
3568
3569         * block.c (contained_in): Remove BLOCK_FUNCTION check.
3570
3571 2019-07-30  Kevin Buettner  <kevinb@redhat.com>
3572
3573         * printcmd.c (print_address_symbolic): Print negative offsets.
3574         (build_address_symbolic): Force signed arithmetic when computing
3575         offset.
3576
3577 2019-07-30  Christian Biesinger  <cbiesinger@google.com>
3578
3579         PR/24474: Add a function to lookup static variables.
3580         * NEWS: Mention this new function.
3581         * python/py-symbol.c (gdbpy_lookup_static_symbol): New function.
3582         * python/python-internal.h (gdbpy_lookup_static_symbol): New function.
3583         * python/python.c (python_GdbMethods): Add new function.
3584
3585 2019-07-29  Christian Biesinger  <cbiesinger@google.com>
3586
3587         * NEWS: Mention new functions Objfile.lookup_{global,static}_symbol.
3588         * python/py-objfile.c (objfpy_lookup_global_symbol): New function.
3589         (objfpy_lookup_static_symbol): New function.
3590         (objfile_object_methods): Add new functions.
3591
3592 2019-07-29  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3593
3594         * NEWS: Mention 'set|show print frame-info'.  Mention new
3595         'presence' value for 'frame-arguments'.  Mention new '-frame-info'
3596         backtrace argument.  Mention that python frame filtering code
3597         is now consistent with what 'backtrace' command prints.
3598
3599 2019-07-29  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3600
3601         * frame.h (enum print_what): New value 'SHORT_LOCATION', update
3602         comments.
3603         (print_frame_info_auto, print_frame_info_source_line,
3604         print_frame_info_location, print_frame_info_source_and_location,
3605         print_frame_info_location_and_address, print_frame_info_short_location):
3606         New declarations.
3607         (struct frame_print_options): New member print_frame_info.
3608         * extension.h (enum ext_lang_frame_args): New value CLI_PRESENCE.
3609         * stack.h (get_user_print_what_frame_info): New declaration.
3610         (frame_show_address): New declaration.
3611         * stack.c (print_frame_arguments_choices): New value 'presence'.
3612         (print_frame_info_auto, print_frame_info_source_line,
3613         print_frame_info_location, print_frame_info_source_and_location,
3614         print_frame_info_location_and_address, print_frame_info_short_location,
3615         print_frame_info_choices, print_frame_info_print_what): New definitions.
3616         (print_frame_args): Only print dots for args if print frame-arguments
3617         is 'presence'.
3618         (frame_print_option_defs): New element for "frame-info".
3619         (get_user_print_what_frame_info): New function.
3620         (frame_show_address): Make non static.  Move comment to stack.h.
3621         (print_frame_info_to_print_what): New function.
3622         (print_frame_info): Update comment.  Use fp_opts.print_frame_info
3623         to decide what to print.
3624         (backtrace_command_1): Handle the new print_frame_arguments_presence
3625         value.
3626         (_initialize_stack): Call add_setshow_enum_cmd for frame-info.
3627         * python/py-framefilter.c (py_print_args): Handle CLI_PRESENCE.
3628         (py_print_frame): In non-mi mode, use LOCATION as default for
3629         print_what, similarly to frame information printed directly by
3630         backtrace command. Handle frame-info user option in non MI mode.
3631
3632 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
3633
3634         * linux-thread-db.c (thread_db_target::thread_handle_to_thread_info):
3635         Add case for debugging 32-bit target on 64-bit host.  Revise
3636         comment.
3637
3638 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
3639
3640         * infrun.c (fill_in_stop_func): Use find_pc_partial_function
3641         instead of find_function_entry_range_from_pc.
3642
3643 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
3644
3645         * stack.c (find_frame_funname): Remove code which preferred
3646         minsym over symtab sym in "certain pathological cases".
3647
3648         * valprint.h (build_address_symbolic): Add "prefer_sym_over_minsym"
3649         parameter.  Change type of "do_demangle" to bool.
3650         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
3651         Pass suitable "prefer_sym_over_minsym" flag to
3652         build_address_symbolic().  Don't output "+" for negative offsets.
3653         * printcmd.c (print_address_symbolic): Update invocation of
3654         build_address_symbolic to include a "prefer_sym_over_minsym"
3655         flag.
3656         (build_address_symbolic): Add "prefer_sym_over_minsym" parameter.
3657         Restrict cases in which use of minimal symbol is preferred to that
3658         of a found symbol.  Update comments.
3659
3660         * dwarf2-frame.c (dwarf2_frame_cache): Don't decode FDE instructions
3661         for entry pc when entry pc is out of range for that FDE.
3662
3663 2019-07-26  Brian Callahan  <bcallah@openbsd.org>
3664
3665         PR gdb/24839:
3666         * gdb/obsd-nat.c (obsd_nat_target::pid_to_str): Fix typo in return
3667         type.
3668
3669 2019-07-25  Christian Biesinger  <cbiesinger@google.com>
3670
3671         * python/py-objfile.c (add_separate_debug_file): Fix comment about
3672         this function's Python signature.
3673
3674
3675 2019-07-24  Christian Biesinger  <cbiesinger@google.com>
3676
3677         * compile/compile-object-load.c (compile_object_load): Pass GLOBAL_SCOPE.
3678         * solib-spu.c (spu_lookup_lib_symbol): Pass GLOBAL_SCOPE.
3679         * solib-svr4.c (elf_lookup_lib_symbol): Pass GLOBAL_SCOPE.
3680         * symtab.c (lookup_global_symbol_from_objfile): Add a scope parameter.
3681         * symtab.h (lookup_global_symbol_from_objfile): Likewise.
3682
3683
3684 2019-07-24  Yoshinori Sato  <ysato@users.sourceforge.jp>
3685
3686         * h8300-tdep.c (h8300_register_name_common): New.
3687         h8300_register_name): Use h8300_register_name_common.
3688         (h8300s_register_name): Likewise.
3689         (h8300sx_register_name): Likewise.
3690         (h8300h_register_nam): New.
3691         (h8300_gdbarch_init): Use h8300h_register_name in h8300h machine.
3692
3693
3694 2019-07-23  Srinath Parvathaneni  <srinath.parvathaneni@arm.com>
3695
3696         * arm-tdep.c (arm_skip_cmse_entry): New function.
3697         (arm_is_sgstubs_section): New function.
3698         (arm_skip_stub): Add call to arm_skip_cmse_entry function.
3699
3700 2019-07-22  Tom Tromey  <tom@tromey.com>
3701
3702         * tui/tui-win.c (tui_win_info::make_invisible_and_set_new_height):
3703         Don't self-assign.
3704
3705 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
3706
3707         * c-typeprint.c (c_print_typedef): Pass -1 instead of 0 to
3708         type_print.
3709
3710 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
3711
3712         * symtab.c (search_symbols): Adjust msymbol matching type arrays
3713         so that GDB doesn't match any msymbols when searching in the
3714         TYPES_DOMAIN.
3715         (print_symbol_info): Print using typedef_print or type_print based
3716         on the type of the symbol.  Add updated FIXME comment moved from...
3717         (_initialize_symtab): ... move and update FIXME comment to above.
3718
3719 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
3720
3721         * NEWS: Mention adding -q option to "info types".
3722         * symtab.c (struct info_types_options): New struct.
3723         (info_types_options_defs): New variable.
3724         (make_info_types_options_def_group): New function.
3725         (info_types_command): Use gdb::option framework to parse options.
3726         (info_types_command_completer): New function.
3727         (_initialize_symtab): Extend the help text on "info types" and
3728         register command completer.
3729
3730 2019-07-21  Christian Biesinger  <cbiesinger@google.com>
3731
3732         * symtab.c (lookup_symbol_in_objfile_symtabs): Change int to block_enum.
3733         (lookup_symbol_in_objfile): Change int to block_enum and add a
3734         gdb_assert to make sure block_index is GLOBAL_BLOCK or STATIC_BLOCK.
3735
3736 2019-07-20  Christian Biesinger  <cbiesinger@google.com>
3737
3738         * MAINTAINERS (Write After Approval): Add self.
3739
3740 2019-07-19  Andrew Burgess  <andrew.burgess@embecosm.com>
3741
3742         * riscv-tdep.c (riscv_push_dummy_code): Write a 4-byte nop
3743         instruction to the dummy code region.
3744
3745 2019-07-19  Tom Tromey  <tromey@adacore.com>
3746
3747         * contrib/ari/gdb_ari.sh: Mention C++11, not ISO C 90.
3748         (ARGSUSED, PARAMS, __func__): Remove rules.
3749
3750 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
3751
3752         * arm-tdep.c (_initialize_arm_tdep): Remove xml tests.
3753         * features/arm/arm-with-iwmmxt.c: Remove.
3754         * features/arm/arm-with-iwmmxt.xml: Remove.
3755         * features/arm/arm-with-m-fpa-layout.c: Remove.
3756         * features/arm/arm-with-m-fpa-layout.xml: Remove.
3757         * features/arm/arm-with-m-vfp-d16.c: Remove.
3758         * features/arm/arm-with-m-vfp-d16.xml: Remove.
3759         * features/arm/arm-with-m.c: Remove.
3760         * features/arm/arm-with-m.xml: Remove.
3761         * features/arm/arm-with-neon.c: Remove.
3762         * features/arm/arm-with-neon.xml: Remove.
3763         * features/arm/arm-with-vfpv2.c: Remove.
3764         * features/arm/arm-with-vfpv2.xml: Remove.
3765         * features/arm/arm-with-vfpv3.c: Remove.
3766         * features/arm/arm-with-vfpv3.xml: Remove.
3767
3768 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
3769
3770         * arm-tdep.c (_initialize_arm_tdep): Add xml regression tests.
3771
3772 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
3773
3774         * arch/aarch32.c (aarch32_create_target_description): Create
3775         target descriptions using features.
3776         * arch/arm.c (arm_create_target_description)
3777         (arm_create_mprofile_target_description): Likewise.
3778         * arm-tdep.c (_initialize_arm_tdep): Remove tdesc init calls.
3779
3780 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
3781
3782         * Makefile.in: Add new files.
3783         * aarch32-tdep.c: New file.
3784         * aarch32-tdep.h: New file.
3785         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
3786         Call aarch32_read_description.
3787         * arch/aarch32.c: New file.
3788         * arch/aarch32.h: New file.
3789         * arch/arm.c (arm_create_target_description)
3790         (arm_create_mprofile_target_description): New function.
3791         * arch/arm.h (arm_fp_type, arm_m_profile_type): New enum.
3792         (arm_create_target_description)
3793         (arm_create_mprofile_target_description): New declaration.
3794         * arm-fbsd-tdep.c (arm_fbsd_read_description_auxv): Call
3795         read_description functions.
3796         * arm-linux-nat.c (arm_linux_nat_target::read_description):
3797         Likewise.
3798         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
3799         * arm-tdep.c (tdesc_arm_list): New variable.
3800         (arm_register_g_packet_guesses): Call create description functions.
3801         (arm_read_description) (arm_read_mprofile_description): New
3802         function.
3803         * arm-tdep.h (arm_read_description)
3804         (arm_read_mprofile_description): Add declaration.
3805         * configure.tgt: Add new files.
3806
3807 2019-07-18  Guillaume LABARTHE  <guillaume.labarthe@gmail.com>
3808
3809         * top.c (new_ui_command): Open specified terminal just once.
3810
3811 2019-07-18  Tom Tromey  <tromey@adacore.com>
3812
3813         * symtab.c (main_name): Constify return type.
3814         * symfile.c (set_initial_language): Update.
3815         * symtab.h (main_name): Constify return type.
3816
3817 2019-07-17  Tom Tromey  <tom@tromey.com>
3818
3819         * tui/tui-winsource.c (tui_update_source_window)
3820         (tui_update_source_window_as_is)
3821         (tui_update_source_windows_with_line): Remove return.
3822         * tui/tui-disasm.c (tui_show_disassem)
3823         (tui_show_disassem_and_update_source): Remove return.
3824         * tui/tui.c (tui_reset): Remove return.
3825         * tui/tui-wingeneral.c
3826         (tui_check_and_display_highlight_if_needed): Remove return.
3827
3828 2019-07-17  Tom Tromey  <tom@tromey.com>
3829
3830         * tui/tui-win.c (parse_scrolling_args): Throw separate errors.
3831
3832 2019-07-17  Tom Tromey  <tom@tromey.com>
3833
3834         * tui/tui-winsource.h (struct tui_exec_info_window)
3835         (struct tui_source_window_base): Move from tui-data.h.
3836         * tui/tui-winsource.c: Move many method definitions from
3837         elsewhere.  Remove "structuring" comments.
3838         * tui/tui-wingeneral.c (tui_source_window_base::make_visible)
3839         (tui_source_window_base::refresh_window): Move to
3840         tui-winsource.c.
3841         * tui/tui-win.c (tui_source_window_base::refresh_all)
3842         (tui_source_window_base::update_tab_width)
3843         (tui_source_window_base::set_new_height)
3844         (tui_source_window_base::do_make_visible_with_new_height): Move to
3845         tui-winsource.c.
3846         * tui/tui-source.h: Update.
3847         * tui/tui-source.c (tui_source_window_base::reset): Move to
3848         tui-winsource.c.
3849         * tui/tui-disasm.h: Update.
3850         * tui/tui-data.h (struct tui_exec_info_window): Move to
3851         tui-winsource.h.
3852         (struct tui_source_window_base): Likewise.
3853         * tui/tui-data.c (tui_source_window_base::clear_detail)
3854         (tui_source_window_base, ~tui_source_window_base): Move to
3855         tui-winsource.c.
3856
3857 2019-07-17  Tom Tromey  <tom@tromey.com>
3858
3859         * tui/tui-win.c (tui_resize_all)
3860         (tui_source_window_base::update_tab_width)
3861         (tui_adjust_win_heights): Update.
3862         (tui_win_info::make_invisible_and_set_new_height): Rename from
3863         make_invisible_and_set_new_height.
3864         * tui/tui-data.h (struct tui_win_info)
3865         <make_invisible_and_set_new_height>: New method.
3866
3867 2019-07-17  Tom Tromey  <tom@tromey.com>
3868
3869         * tui/tui.c: Update.
3870         * tui/tui-source.h (struct tui_source_window): Move from
3871         tui-data.h.
3872         * tui/tui-layout.c: Update.
3873         * tui/tui-disasm.c: Update.
3874         * tui/tui-data.h (struct tui_source_window): Move to
3875         tui-source.h.
3876
3877 2019-07-17  Tom Tromey  <tom@tromey.com>
3878
3879         * tui/tui-disasm.h (struct tui_disasm_window): Move from
3880         tui-data.h.
3881         * tui/tui-data.h (struct tui_disasm_window): Move to
3882         tui-disasm.h.
3883
3884 2019-07-17  Tom Tromey  <tom@tromey.com>
3885
3886         * tui/tui-regs.h (struct tui_data_item_window): Move from
3887         tui-data.h.
3888         * tui/tui-regs.c (tui_data_item_window): Move from tui-data.c.
3889         * tui/tui-data.h (struct tui_data_item_window): Move to
3890         tui-regs.h.
3891         * tui/tui-data.c (~tui_data_item_window): Move to tui-regs.c.
3892
3893 2019-07-17  Tom Tromey  <tom@tromey.com>
3894
3895         * tui/tui.c: Update.
3896         * tui/tui-win.c (tui_cmd_window::do_make_visible_with_new_height)
3897         (tui_cmd_window::max_height): Move to tui-command.c.
3898         * tui/tui-layout.c: Update.
3899         * tui/tui-data.h (struct tui_cmd_window): Move to tui-command.h.
3900         * tui/tui-data.c (tui_cmd_window::clear_detail): Move to
3901         tui-command.c.
3902         * tui/tui-command.h (struct tui_cmd_window): Move from
3903         tui-data.h.
3904         * tui/tui-command.c: Remove "structuring" comments.
3905         (tui_cmd_window::clear_detail)
3906         (tui_cmd_window::do_make_visible_with_new_height)
3907         (tui_cmd_window::max_height): Move from elsewhere.
3908
3909 2019-07-17  Tom Tromey  <tom@tromey.com>
3910
3911         * tui/tui-io.c (tui_dispatch_ctrl_char): Move from tui-command.c.
3912         Now static.
3913         * tui/tui-command.h (tui_dispatch_ctrl_char): Don't declare.
3914         * tui/tui-command.c (tui_dispatch_ctrl_char): Move to tui-io.c.
3915
3916 2019-07-17  Tom Tromey  <tom@tromey.com>
3917
3918         * tui/tui.c: Update.
3919         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Move to
3920         tui-regs.c.
3921         * tui/tui-windata.h: Remove file.
3922         * tui/tui-windata.c: Remove file.
3923         * tui/tui-win.c (tui_data_window::set_new_height)
3924         (tui_data_window::do_make_visible_with_new_height): Move to
3925         tui-regs.c.
3926         * tui/tui-regs.h (struct tui_data_window): Move from tui-data.h.
3927         * tui/tui-regs.c: Remove "structuring" comments.
3928         (tui_data_window::first_data_item_displayed)
3929         (tui_data_window::delete_data_content_windows)
3930         (tui_data_window::erase_data_content)
3931         (tui_data_window::display_all_data)
3932         (tui_data_window::refresh_all)
3933         (tui_data_window::do_scroll_vertical)
3934         (tui_data_window::clear_detail, tui_data_window::set_new_height)
3935         (tui_data_window::do_make_visible_with_new_height)
3936         (tui_data_window::refresh_window): Move from elsewhere.
3937         (_initialize_tui_regs): Move to end of file.
3938         * tui/tui-layout.c: Update.
3939         * tui/tui-hooks.c: Update.
3940         * tui/tui-data.h (struct tui_data_window): Move to tui-regs.h.
3941         * tui/tui-data.c (tui_data_window::clear_detail): Move to
3942         tui-regs.c.
3943         * Makefile.in (SUBDIR_TUI_SRCS): Remove tui-windata.c.
3944
3945 2019-07-17  Tom Tromey  <tom@tromey.com>
3946
3947         * tui/tui-io.c (tui_puts_internal): Call wrefresh if newline is
3948         seen.
3949
3950 2019-07-17  Tom Tromey  <tom@tromey.com>
3951
3952         * tui/tui-win.c (tui_source_window_base::set_new_height)
3953         (tui_source_window_base::do_make_visible_with_new_height): Use
3954         m_has_locator field directly.
3955         * tui/tui-data.h (struct tui_win_info) <has_locator>: Remove
3956         method.
3957         (struct tui_source_window_base) <has_locator>: Likewise.
3958
3959 2019-07-17  Tom Tromey  <tom@tromey.com>
3960
3961         * tui/tui-wingeneral.h (tui_make_visible, tui_make_invisible):
3962         Don't declare.
3963         * tui/tui-wingeneral.c (tui_make_visible, tui_make_invisible):
3964         Remove.
3965         * tui/tui-win.c (tui_source_window_base::set_new_height)
3966         (tui_source_window_base::set_new_height)
3967         (make_invisible_and_set_new_height)
3968         (tui_source_window_base::do_make_visible_with_new_height)
3969         (tui_source_window_base::do_make_visible_with_new_height):
3970         Update.
3971         * tui/tui-layout.c (show_source_disasm_command, show_data)
3972         (show_source_or_disasm_and_command): Update.
3973         * tui/tui-layout.c (show_layout): Update.
3974
3975 2019-07-17  Tom Tromey  <tom@tromey.com>
3976
3977         * tui/tui-layout.c (make_data_window): Remove.
3978         (show_data): Unify creation and re-initialization cases.
3979
3980 2019-07-17  Tom Tromey  <tom@tromey.com>
3981
3982         * tui/tui-layout.c (make_source_window, make_disasm_window):
3983         Remove.
3984         (show_data): Unify creation and re-initialization cases.
3985
3986 2019-07-17  Tom Tromey  <tom@tromey.com>
3987
3988         * tui/tui-layout.c (make_command_window): Remove.
3989         (show_source_disasm_command, show_source_or_disasm_and_command):
3990         Unify creation and re-initialization cases.
3991
3992 2019-07-17  Tom Tromey  <tom@tromey.com>
3993
3994         * tui/tui-layout.c (show_source_or_disasm_and_command): Unify
3995         creation and re-initialization cases.
3996
3997 2019-07-17  Tom Tromey  <tom@tromey.com>
3998
3999         * tui/tui-regs.c (tui_get_register): Return void.
4000
4001 2019-07-17  Tom Tromey  <tom@tromey.com>
4002
4003         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible):
4004         Simplify.
4005
4006 2019-07-17  Tom Tromey  <tom@tromey.com>
4007
4008         * tui/tui-layout.c (show_source_disasm_command): Simplify window
4009         resetting.
4010
4011 2019-07-17  Tom Tromey  <tom@tromey.com>
4012
4013         * tui/tui.h (tui_set_layout_by_name): Don't declare.
4014         * tui/tui-regs.c (tui_reg_layout): New function.
4015         (tui_show_registers, tui_reg_command): Use it.
4016         * tui/tui-layout.c (LAYOUT_USAGE): Remove.
4017         (tui_layout_command): Rename from tui_set_layout_by_name.  Change
4018         parameters.
4019         (tui_layout_command): Remove.
4020
4021 2019-07-17  Tom Tromey  <tom@tromey.com>
4022
4023         * tui/tui-layout.h (tui/tui-layout): Return void.
4024         * tui/tui-layout.c (tui_set_layout): Return void.  Add assert.
4025
4026 2019-07-17  Tom Tromey  <tom@tromey.com>
4027
4028         * tui/tui-layout.c (show_source_disasm_command, show_data):
4029         Update.
4030         (reset_locator): Remove.
4031         (show_source_or_disasm_and_command): Update.
4032
4033 2019-07-17  Tom Tromey  <tom@tromey.com>
4034
4035         * tui/tui-source.c (tui_source_window_base::reset): Remove
4036         win_type parameter.
4037         * tui/tui-layout.c (make_command_window, make_source_window)
4038         (make_disasm_window, make_data_window)
4039         (show_source_disasm_command, show_data, tui_gen_win_info::reset)
4040         (reset_locator, show_source_or_disasm_and_command): Update.
4041         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Remove
4042         win_type parameter.
4043         (struct tui_source_window_base) <reset>: Likewise.
4044
4045 2019-07-17  Tom Tromey  <tom@tromey.com>
4046
4047         * tui/tui-layout.c (show_source_disasm_command): Use
4048         reset_locator.
4049         (reset_locator): New function.
4050         (init_and_make_win): Remove.
4051         (show_source_or_disasm_and_command): Use reset_locator.
4052
4053 2019-07-17  Tom Tromey  <tom@tromey.com>
4054
4055         * tui/tui-winsource.c (tui_set_exec_info_content): Remove
4056         condition.
4057         * tui/tui-wingeneral.c (tui_source_window_base::make_visible):
4058         Remove condition.
4059         * tui/tui-source.c (tui_source_window_base::reset): New method.
4060         * tui/tui-layout.c (make_command_window): Don't call
4061         init_and_make_win.
4062         (make_source_window, make_disasm_window): Don't call
4063         make_source_or_disasm_window.
4064         (make_data_window): Don't call init_and_make_win.  Change calling
4065         convention.
4066         (show_source_disasm_command, show_data): Simplify.
4067         (make_source_or_disasm_window): Remove.
4068         (show_source_or_disasm_and_command): Simplify.
4069         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Now virtual.
4070         (struct tui_source_window_base) <reset>: Likewise.
4071         <execution_info>: Remove initializer.
4072         * tui/tui-data.c (tui_source_window_base): Initialize
4073         execution_info.
4074
4075 2019-07-17  Tom Tromey  <tom@tromey.com>
4076
4077         * tui/tui-layout.c (tui_set_layout): Remove regs_populate
4078         variable.
4079
4080 2019-07-17  Tom Tromey  <tom@tromey.com>
4081
4082         * tui/tui.c (tui_rl_other_window): Update.
4083         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Call
4084         superclass method first.  Always iterate over regs_content.
4085         (tui_unhighlight_win, tui_highlight_win): Use refresh_window
4086         method.
4087         * tui/tui-win.c (tui_set_focus_command): Update.
4088
4089 2019-07-17  Tom Tromey  <tom@tromey.com>
4090
4091         * tui/tui-win.c (tui_set_focus_command): Rename from
4092         tui_set_focus.  Call tui_enable.
4093         (tui_set_focus_command): Remove.
4094
4095 2019-07-17  Tom Tromey  <tom@tromey.com>
4096
4097         * tui/tui-winsource.c (tui_show_exec_info_content): Don't call
4098         refresh_window.
4099         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Call
4100         touchwin.
4101         (tui_data_window::refresh_window): Call refresh_window on data
4102         items.  Always call superclass refresh_window.
4103         (tui_win_info::refresh): Remove.
4104         (tui_source_window_base::refresh_window): Update.
4105         (tui_refresh_all): Update.
4106         * tui/tui-layout.c (show_source_disasm_command): Remove call to
4107         refresh_window.
4108         (show_source_or_disasm_and_command): Likewise.
4109         * tui/tui-data.h (struct tui_win_info) <refresh>: Remove.
4110         (struct tui_source_window_base) <refresh>: Likewise.
4111
4112 2019-07-17  Tom Tromey  <tom@tromey.com>
4113
4114         * tui/tui-winsource.c (tui_clear_source_content)
4115         (tui_show_source_content): Update.
4116         * tui/tui-source.c (tui_source_window::showing_source_p): Check
4117         whether content is empty.
4118         * tui/tui-data.h (struct tui_source_window_base) <content_in_use>:
4119         Remove.
4120
4121 2019-07-17  Tom Tromey  <tom@tromey.com>
4122
4123         * tui/tui-winsource.c (tui_erase_source_content): Clear the
4124         window's contents.
4125         * tui/tui-source.h (tui_set_source_content_nil): Don't declare.
4126         * tui/tui-source.c (tui_set_source_content_nil): Remove.
4127
4128 2019-07-17  Tom Tromey  <tom@tromey.com>
4129
4130         * tui/tui-data.h (UNDEFINED_ITEM): Remove define.
4131         (struct tui_data_item_window): Update.
4132
4133 2019-07-17  Tom Tromey  <tom@tromey.com>
4134
4135         * tui/tui-data.h (MAX_CONTENT_COUNT, TUI_NULL_STR)
4136         (DEFAULT_HISTORY_COUNT, WITH_LOCATOR, NO_LOCATOR): Remove
4137         defines.
4138
4139 2019-07-17  Tom Tromey  <tom@tromey.com>
4140
4141         * tui/tui-winsource.h (tui_erase_source_content)
4142         (tui_clear_source_content): Remove "display_prompt" parameter.
4143         * tui/tui-winsource.c (tui_update_source_window_as_is)
4144         (tui_update_source_windows_with_addr): Update.
4145         (tui_clear_source_content): Remove "display_prompt" parameter.
4146         (tui_erase_source_content): Likewise.  Simplify.
4147         (tui_show_source_content): Update.
4148         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
4149         * tui/tui-stack.c (tui_show_frame_info): Update.
4150         * tui/tui-data.h (EMPTY_SOURCE_PROMPT, NO_EMPTY_SOURCE_PROMPT):
4151         Remove defines.
4152
4153 2019-07-17  Tom Tromey  <tom@tromey.com>
4154
4155         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
4156         * tui/tui-disasm.h (tui_set_disassem_content): Add win_info
4157         parameter.
4158         * tui/tui-disasm.c (tui_set_disassem_content): Add win_info
4159         parameter.
4160
4161 2019-07-17  Tom Tromey  <tom@tromey.com>
4162
4163         * tui/tui-winsource.c (tui_clear_source_content)
4164         (tui_show_source_content, tui_show_exec_info_content)
4165         (tui_clear_exec_info_content): Update.
4166         * tui/tui-stack.c (tui_show_locator_content): Update.
4167         (tui_show_frame_info): Update.
4168         * tui/tui-source.h (tui_source_window): Don't declare.
4169         * tui/tui-source.c (tui_source_window::showing_source_p): Rename
4170         from tui_source_is_displayed.
4171         * tui/tui-data.h (struct tui_gen_win_info) <content_in_use>:
4172         Remove field.
4173         (struct tui_source_window_base) <content_in_use>: New field.  Now
4174         bool.
4175         (struct tui_source_window) <showing_source_p>: New method.
4176         (TUI_SRC_WIN): Change cast.
4177         * tui/tui-data.c (tui_initialize_static_data): Update.
4178
4179 2019-07-17  Tom Tromey  <tom@tromey.com>
4180
4181         * tui/tui-winsource.c (tui_update_breakpoint_info): Use
4182         location_matches_p.
4183         * tui/tui-source.c (tui_source_window::location_matches_p): New
4184         method.
4185         * tui/tui-disasm.c (tui_disasm_window::location_matches_p): New
4186         method.
4187         * tui/tui-data.h (struct tui_source_window_base)
4188         <location_matches_p>: New method.
4189         (struct tui_source_window, struct tui_disasm_window)
4190         <location_matches_p>: Likewise.
4191
4192 2019-07-17  Tom Tromey  <tom@tromey.com>
4193
4194         * tui/tui-win.c (tui_set_win_height_command): Rename from
4195         tui_set_win_height.
4196         (tui_set_win_height_command): Remove.
4197
4198 2019-07-17  Tom Tromey  <tom@tromey.com>
4199
4200         * tui/tui-source.c (tui_source_window): New constructor.  Add
4201         observer.
4202         (~tui_source_window): New destructor.
4203         (tui_source_window::style_changed): New method.
4204         * tui/tui-hooks.c (tui_redisplay_source): Remove.
4205         (tui_attach_detach_observers): Update.
4206         * tui/tui-data.h (struct tui_source_window): Make constructor not
4207         inline.  Add destructor.
4208         (struct tui_source_window) <style_changed>: New method.
4209         <m_observable>: New member.
4210
4211 2019-07-17  Tom Tromey  <tom@tromey.com>
4212
4213         * tui/tui-data.c (tui_clear_source_windows_detail): Fix typo.
4214         * tui/tui-win.c (tui_resize_all): Fix typo.
4215
4216 2019-07-17  Tom Tromey  <tom@tromey.com>
4217
4218         * tui/tui-wingeneral.h (tui_refresh_all): Update.
4219         * tui/tui-wingeneral.c (make_all_visible): Use foreach.
4220         (tui_refresh_all): Remove "list" parameter.  Use foreach.
4221         * tui/tui-win.c (window_name_completer): Use foreach.
4222         (tui_refresh_all_win, tui_rehighlight_all, tui_all_windows_info)
4223         (update_tab_width): Likewise.
4224         * tui/tui-layout.c (show_layout): Update.
4225         * tui/tui-data.h (class tui_window_iterator): New.
4226         (struct all_tui_windows): New.
4227         * tui/tui-data.c (tui_partial_win_by_name): Use foreach.
4228
4229 2019-07-17  Tom Tromey  <tom@tromey.com>
4230
4231         * tui/tui-regs.c (tui_reg_next, tui_reg_prev): Add "current_group"
4232         parameter.  Don't reference globals.
4233         (tui_reg_command): Update.
4234
4235 2019-07-17  Tom Tromey  <tom@tromey.com>
4236
4237         * tui/tui-regs.c (tui_show_registers): Simplify.
4238
4239 2019-07-17  Tom Tromey  <tom@tromey.com>
4240
4241         * tui/tui-regs.c (tui_show_registers): Update.
4242         (tui_show_register_group): Add win_info parameter.
4243
4244 2019-07-17  Tom Tromey  <tom@tromey.com>
4245
4246         * tui/tui-regs.c (tui_data_window::display_reg_element_at_line):
4247         Rename from tui_display_reg_element_at_line.
4248         (tui_data_window::display_registers_from_line): Update.
4249         * tui/tui-data.h (struct tui_data_window)
4250         <display_reg_element_at_line>: New method.
4251
4252 2019-07-17  Tom Tromey  <tom@tromey.com>
4253
4254         * tui/tui-regs.h (tui_display_registers_from)
4255         (tui_display_registers_from_line): Don't declare.
4256         * tui/tui-windata.c (tui_data_window::display_all_data)
4257         (tui_data_window::refresh_all)
4258         (tui_data_window::do_scroll_vertical): Update.
4259         * tui/tui-regs.c (tui_data_window::display_registers_from): Rename
4260         from tui_display_registers_from.
4261         (tui_display_reg_element_at_line): Update.
4262         (tui_data_window::display_registers_from_line): Rename from
4263         tui_display_registers_from_line.
4264         * tui/tui-data.h (struct tui_data_window) <display_registers_from,
4265         display_registers_from_line>: New methods.
4266
4267 2019-07-17  Tom Tromey  <tom@tromey.com>
4268
4269         * tui/tui-windata.h (tui_erase_data_content): Don't declare.
4270         * tui/tui-windata.c (tui_data_window::erase_data_content): Rename
4271         from tui_erase_data_content.
4272         (tui_data_window::display_all_data)
4273         (tui_data_window::refresh_all)
4274         (tui_data_window::do_scroll_vertical): Update.
4275         * tui/tui-regs.c (tui_show_registers): Update.
4276         * tui/tui-data.h (struct tui_data_window) <erase_data_content>:
4277         New method.
4278
4279 2019-07-17  Tom Tromey  <tom@tromey.com>
4280
4281         * tui/tui-windata.h (tui_delete_data_content_windows): Don't
4282         declare.
4283         * tui/tui-windata.c
4284         (tui_data_window::delete_data_content_windows): Rename from
4285         tui_delete_data_content_windows.
4286         (tui_data_window::display_all_data)
4287         (tui_data_window::do_scroll_vertical): Update.
4288         * tui/tui-data.h (struct tui_data_window)
4289         <delete_data_content_windows>: New method.
4290
4291 2019-07-17  Tom Tromey  <tom@tromey.com>
4292
4293         * tui/tui-windata.h (tui_refresh_data_win): Don't declare.
4294         * tui/tui-regs.h (tui_first_reg_element_inline): Don't declare.
4295
4296 2019-07-17  Tom Tromey  <tom@tromey.com>
4297
4298         * tui/tui-windata.h (tui_display_all_data): Don't declare.
4299         * tui/tui-windata.c (tui_data_window::display_all_data): Rename
4300         from tui_display_all_data.
4301         * tui/tui-win.c
4302         (tui_data_window::do_make_visible_with_new_height): Update.
4303         * tui/tui-regs.c (tui_show_registers): Update.
4304         * tui/tui-layout.c (tui_set_layout): Update.
4305         * tui/tui-data.h (struct tui_data_window) <display_all_data>: New
4306         method.
4307
4308 2019-07-17  Tom Tromey  <tom@tromey.com>
4309
4310         * tui/tui-windata.h (tui_display_data_from): Don't declare.
4311         * tui/tui-windata.c (tui_display_data_from): Remove.
4312         (tui_data_window::refresh_all): Update.
4313
4314 2019-07-17  Tom Tromey  <tom@tromey.com>
4315
4316         * tui/tui-windata.h (tui_display_data_from_line): Don't declare.
4317         * tui/tui-windata.c (tui_display_data_from_line): Remove.
4318         (tui_display_data_from, tui_data_window::do_scroll_vertical): Call
4319         tui_display_registers_from_line.
4320         * tui/tui-regs.h (tui_display_registers_from_line): Update.
4321         * tui/tui-regs.c (tui_display_registers_from_line): Remove
4322         "force_display" parameter.
4323
4324 2019-07-17  Tom Tromey  <tom@tromey.com>
4325
4326         * tui/tui-regs.h (tui_first_reg_element_no_inline): Don't
4327         declare.
4328         * tui/tui-regs.c (tui_data_window::first_reg_element_no_inline):
4329         Rename from tui_first_reg_element_no_inline.
4330         (tui_display_reg_element_at_line)
4331         (tui_display_registers_from_line): Update.
4332         * tui/tui-data.h (struct tui_data_window)
4333         <first_reg_element_no_inline>: New method.
4334
4335 2019-07-17  Tom Tromey  <tom@tromey.com>
4336
4337         * tui/tui-windata.c (tui_display_data_from)
4338         (tui_data_window::do_scroll_vertical): Update.
4339         * tui/tui-regs.h (tui_line_from_reg_element_no): Don't declare.
4340         * tui/tui-regs.c (tui_data_window::line_from_reg_element_no):
4341         Rename from tui_line_from_reg_element_no.
4342         (tui_display_registers_from_line): Update.
4343         * tui/tui-data.h (struct tui_data_window)
4344         <line_from_reg_element_no>: New method.
4345
4346 2019-07-17  Tom Tromey  <tom@tromey.com>
4347
4348         * tui/tui-regs.h (tui_last_regs_line_no): Don't declare.
4349         * tui/tui-regs.c (tui_data_window::last_regs_line_no): Rename from
4350         tui_last_regs_line_no.
4351         (tui_display_reg_element_at_line)
4352         (tui_display_registers_from_line): Update.
4353         * tui/tui-data.h (struct tui_data_window) <last_regs_line_no>: New
4354         method.
4355
4356 2019-07-17  Tom Tromey  <tom@tromey.com>
4357
4358         PR tui/24722:
4359         * tui/tui-winsource.h (tui_update_all_breakpoint_info)
4360         (tui_update_breakpoint_info): Add "being_deleted" parameter.
4361         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
4362         (tui_update_all_breakpoint_info): Add "being_deleted" parameter.
4363         (tui_update_breakpoint_info): Likewise.
4364         * tui/tui-hooks.c (tui_event_create_breakpoint)
4365         (tui_event_delete_breakpoint, tui_event_modify_breakpoint):
4366         Update.
4367
4368 2019-07-17  Tom Tromey  <tom@tromey.com>
4369
4370         * tui/tui-stack.c (tui_show_frame_info): Consolidate "if"s.
4371
4372 2019-07-17  Tom Tromey  <tom@tromey.com>
4373
4374         * tui/tui-winsource.c (tui_update_source_window_as_is)
4375         (tui_update_source_windows_with_addr): Update.
4376         * tui/tui-source.h (tui_set_source_content)
4377         (tui_show_symtab_source): Add "win_info" parameter.
4378         * tui/tui-source.c (tui_set_source_content): Add "win_info"
4379         parameter.
4380         (tui_show_symtab_source): Likewise.
4381
4382 2019-07-17  Tom Tromey  <tom@tromey.com>
4383
4384         * tui/tui-wingeneral.c
4385         (tui_check_and_display_highlight_if_needed): Check can_highlight.
4386
4387 2019-07-17  Tom Tromey  <tom@tromey.com>
4388
4389         * tui/tui-data.h (struct tui_win_info) <can_scroll>: New method.
4390         (struct tui_cmd_window) <can_scroll>: New method.
4391         * tui/tui-command.c (tui_dispatch_ctrl_char): Use can_scroll
4392         method.
4393
4394 2019-07-17  Tom Tromey  <tromey@adacore.com>
4395
4396         * ui-out.h (class ui_out) <field_signed, field_fmt_signed,
4397         do_field_signed>: Rename.  Change type of "value".
4398         * ui-out.c (ui_out::field_signed): Rename from field_int.
4399         Change type of "value".
4400         (ui_out::field_fmt_signed): Rename from field_fmt_int.  Change
4401         type of "value".
4402         * tui/tui-out.h (class tui_ui_out) <do_field_signed>: Rename from
4403         do_field_int.  Change type of "value".
4404         * tui/tui-out.c (tui_ui_out::do_field_signed): Rename from
4405         do_field_int.  Change type of "value".
4406         * tracepoint.c (trace_status_mi, tfind_1)
4407         (print_one_static_tracepoint_marker): Update.
4408         * thread.c (print_thread_info_1, print_selected_thread_frame):
4409         Update.
4410         * stack.c (print_frame, print_frame_info): Update.
4411         * spu-tdep.c (info_spu_signal_command, info_spu_dma_cmdlist):
4412         Update.
4413         * source.c (print_source_lines_base): Update.
4414         * skip.c (info_skip_command): Update.
4415         * record-btrace.c (btrace_ui_out_decode_error)
4416         (btrace_call_history_src_line): Update.
4417         * python/py-framefilter.c (py_print_single_arg, py_print_frame):
4418         Update.
4419         * progspace.c (print_program_space): Update.
4420         * mi/mi-symbol-cmds.c (mi_cmd_symbol_list_lines): Update.
4421         * mi/mi-out.h (class mi_ui_out) <do_field_signed>: Rename from
4422         do_field_int.  Change type of "value".
4423         * mi/mi-out.c (mi_ui_out::do_table_begin)
4424         (mi_ui_out::do_table_header): Update.
4425         (mi_ui_out::do_field_signed): Rename from do_field_int.  Change
4426         type of "value".
4427         * mi/mi-main.c (mi_cmd_thread_list_ids, print_one_inferior)
4428         (mi_cmd_data_list_changed_registers, output_register)
4429         (mi_cmd_data_read_memory, mi_load_progress)
4430         (mi_cmd_trace_frame_collected): Update.
4431         * mi/mi-interp.c (mi_on_normal_stop_1, mi_output_solib_attribs):
4432         Update.
4433         * mi/mi-cmd-var.c (print_varobj, mi_cmd_var_create)
4434         (mi_cmd_var_delete, mi_cmd_var_info_num_children)
4435         (mi_cmd_var_list_children, varobj_update_one): Update.
4436         * mi/mi-cmd-stack.c (mi_cmd_stack_info_depth)
4437         (mi_cmd_stack_list_args, list_arg_or_local): Update.
4438         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_file): Update.
4439         * inferior.c (print_inferior): Update.
4440         * gdb_bfd.c (print_one_bfd): Update.
4441         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
4442         Update.
4443         * darwin-nat-info.c (darwin_debug_regions_recurse): Update.
4444         * cli-out.h (class cli_ui_out) <do_field_signed>: Rename from
4445         do_field_int.  Change type of "value".
4446         * cli-out.c (cli_ui_out::do_field_signed): Rename from
4447         do_field_int.  Change type of "value".
4448         * breakpoint.c (watchpoint_check, print_breakpoint_location)
4449         (print_one_breakpoint_location, print_it_catch_fork)
4450         (print_one_catch_fork, print_it_catch_vfork)
4451         (print_one_catch_vfork, print_it_catch_solib)
4452         (print_it_catch_exec, print_it_ranged_breakpoint)
4453         (print_mention_watchpoint, print_mention_masked_watchpoint)
4454         (bkpt_print_it, update_static_tracepoint): Update.
4455         * break-catch-throw.c (print_it_exception_catchpoint): Update.
4456         * break-catch-syscall.c (print_it_catch_syscall): Update.
4457         * ada-tasks.c (print_ada_task_info): Update.
4458         * ada-lang.c (print_it_exception, print_mention_exception):
4459         Update.
4460
4461 2019-07-17  Andrew Burgess  <andrew.burgess@embecosm.com>
4462
4463         PR breakpoints/24541
4464         * gdbarch.c: Regenerate.
4465         * gdbarch.h: Regenerate.
4466         * gdbarch.sh: Adjust return type and parameter types for
4467         'stap_adjust_register'.
4468         (i386_stap_adjust_register): Adjust signature and return new
4469         register name.
4470         * stap-probe.c (stap_parse_register_operand): Adjust use of
4471         'gdbarch_stap_adjust_register'.
4472
4473 2019-07-17  Tom Tromey  <tromey@adacore.com>
4474
4475         * s390-linux-nat.c (s390_watch_area): Remove typedef.  Don't
4476         declare VEC.
4477         (struct s390_debug_reg_state) <watch_areas, break_areas>: Now
4478         std::vector.
4479         (struct s390_process_info): Add initializers.
4480         (s390_add_process): Use new.
4481         (s390_linux_nat_target::low_forget_process): Use delete.
4482         (s390_linux_nat_target::low_new_fork)
4483         (s390_linux_nat_target::stopped_by_watchpoint)
4484         (s390_linux_nat_target::low_prepare_to_resume)
4485         (s390_linux_nat_target::insert_watchpoint)
4486         (s390_linux_nat_target::insert_hw_breakpoint)
4487         (s390_linux_nat_target::remove_watchpoint)
4488         (s390_linux_nat_target::remove_hw_breakpoint): Update.
4489
4490 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
4491
4492         * aarch64-fbsd-nat.c: Include regcache.h.
4493         (getregs_supplies, getfpregs_supplies): Remove unused gdbarch
4494         argument.
4495         (aarch64_fbsd_nat_target::fetch_registers)
4496         (aarch64_fbsd_nat_target::store_registers): Remove gdbarch
4497         variable.
4498         * arm-fbsd-nat.c, riscv-fbsd-nat.c: Likewise.
4499
4500 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
4501
4502         * fbsd-nat.c: Include gdbarch.h.
4503
4504 2019-07-15  Tom Tromey  <tromey@adacore.com>
4505
4506         * mi/mi-out.c (mi_ui_out::do_field_int): Use plongest.
4507
4508 2019-07-15  Tom Tromey  <tromey@adacore.com>
4509
4510         * mi/mi-out.h (class mi_ui_out) <do_field_unsigned>: Declare.
4511         * mi/mi-out.c (mi_ui_out::do_field_unsigned): New method.
4512         * cli-out.h (class cli_ui_out) <do_field_unsigned>: Declare.
4513         * cli-out.c (cli_ui_out::do_field_int): New method.
4514         * ui-out.c (ui_out::field_unsigned): New method.
4515         * symfile.c (generic_load): Use field_unsigned.
4516         (print_transfer_performance): Likewise.
4517         * record-btrace.c (ui_out_field_uint): Remove.
4518         (btrace_call_history_insn_range, btrace_call_history): Use
4519         field_unsigned.
4520         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn): Use
4521         field_unsigned.
4522         * ui-out.h (class ui_out) <field_unsigned>: New method.
4523         <do_field_unsigned>: Likewise.
4524
4525 2019-07-15  Tom Tromey  <tromey@adacore.com>
4526
4527         * mi/mi-main.c (list_available_thread_groups): Use field_string.
4528         * mi/mi-interp.c (mi_memory_changed): Use field_string.
4529         * target.c (flash_erase_command): Use field_string.
4530         * infrun.c (print_signal_received_reason): Use field_string.
4531         * i386-tdep.c (i386_mpx_print_bounds): Use field_string.
4532         * breakpoint.c (maybe_print_thread_hit_breakpoint): Use
4533         field_string.
4534         * ada-tasks.c (print_ada_task_info): Use field_string.
4535
4536 2019-07-15  Tom Tromey  <tromey@adacore.com>
4537
4538         * target.c (flash_erase_command): Use field_core_addr.
4539         * symfile.c (generic_load): Use field_core_addr.
4540         * sparc64-linux-tdep.c (sparc64_linux_handle_segmentation_fault):
4541         Use field_core_addr.
4542         * i386-linux-tdep.c (i386_linux_handle_segmentation_fault): Use
4543         field_core_addr.
4544
4545 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
4546
4547         * dwarf2loc.c (dwarf2_evaluate_property): Sign extend property
4548         value if its desired type is smaller than a CORE_ADDR and signed.
4549
4550 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
4551
4552         * dwarf2loc.c (dwarf2_evaluate_property): Update to take account
4553         of changes to field names, and use new is_reference field to
4554         decide if a property is a reference or not.
4555         * dwarf2loc.h (struct dwarf2_locexpr_baton): Add 'is_reference'
4556         field.
4557         (struct dwarf2_property_baton): Update header comment, rename
4558         'referenced_type' to 'property_type' and update comments.
4559         * dwarf2read.c (attr_to_dynamic_prop): Add extra parameter to hold
4560         default property type, store in property baton, update to take
4561         accound of renamed field.
4562         (read_func_scope): Update call to attr_to_dynamic_prop.
4563         (read_array_type): Likewise.
4564         (dwarf2_per_cu_addr_sized_int_type): New function.
4565         (read_subrange_index_type): Move type finding code to
4566         dwarf2_per_cu_addr_sized_int_type.
4567         (read_subrange_type): Update calls to attr_to_dynamic_prop.
4568         (dwarf2_per_cu_addr_type): New function.
4569         (set_die_type): Update calls to attr_to_dynamic_prop.
4570
4571 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
4572
4573         * dwarf2read.c (read_subrange_index_type): New function.
4574         (read_subrange_type): Move code into new function and call it.
4575         * gdbtypes.c (create_range_type): Add some asserts.
4576
4577 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
4578
4579         * dwarf2loc.c (dwarf2_evaluate_property): Change return type, and
4580         update return statements.
4581         * dwarf2loc.h (dwarf2_evaluate_property): Update return type on
4582         declaration, and update comment to match.
4583         * gdbtypes.c (resolve_dynamic_array): Update call to
4584         dwarf2_evaluate_property to match new return type.
4585
4586 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
4587
4588         * valarith.c (value_subscripted_rvalue): Change lowerbound
4589         parameter type from int to LONGEST.
4590         * value.h (value_subscripted_rvalue): Likewise in declaration.
4591
4592 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
4593
4594         * cli/cli-utils.c (info_print_command_completer): New function.
4595         * cli/cli-utils.h: Add 'completer.h' include, and forward
4596         declaration for 'struct cmd_list_element'.
4597         (info_print_command_completer): Declare.
4598         * stack.c (_initialize_stack): Add completer for 'info locals' and
4599         'info args'.
4600         * symtab.c (_initialize_symtab): Add completer for 'info
4601         variables' and 'info functions'.
4602         * NEWS: Mention completion for additional info commands.
4603
4604 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
4605
4606         * cli/cli-utils.c (extract_info_print_args): Delete.
4607         (extract_arg_maybe_quoted): Delete.
4608         (info_print_options_defs): New variable.
4609         (make_info_print_options_def_group): New function.
4610         (extract_info_print_options): Define new function.
4611         * cli/cli-utils.h (extract_info_print_args): Delete.
4612         (struct info_print_options): New structure.
4613         (extract_info_print_options): Declare new function.
4614         * stack.c (info_locals_command): Update to use new
4615         extract_info_print_options, also add a header comment.
4616         (info_args_command): Likewise.
4617         * symtab.c (info_variables_command): Likewise.
4618         (info_functions_command): Likewise.
4619
4620 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
4621
4622         * cli/cli-option.c (parse_option): Use extract_string_maybe_quoted
4623         to extract string arguments.
4624         * common/common-utils.c (extract_string_maybe_quoted): New function.
4625         * common/common-utils.h (extract_string_maybe_quoted): Declare.
4626
4627 2019-07-11  Tom Tromey  <tromey@adacore.com>
4628
4629         * main.c (get_init_files): Use GDBINIT, not gdbinit.
4630         * auto-load.c (file_is_auto_load_safe): Use GDBINIT, not gdbinit.
4631         * top.h (gdbinit): Don't declare.
4632         * cli/cli-cmds.c (init_cli_cmds): Remove, merging contents
4633         into...
4634         (_initialize_cli_cmds): ...here.  Use GDBINIT, not gdbinit.
4635         * top.c (gdb_init): Don't call init_cli_cmds.
4636         (gdbinit): Remove.
4637         * cli/cli-cmds.h (init_cli_cmds): Don't declare.
4638
4639 2019-07-11  Tom Tromey  <tromey@adacore.com>
4640
4641         * python/py-inferior.c (add_thread_object): Don't use thread_obj
4642         after it has been moved.
4643
4644 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
4645
4646         * valops.c (value_must_coerce_to_target): Change return type to
4647         bool.
4648         * value.h (value_must_coerce_to_target): Likewise.
4649
4650 2019-07-10  Simon Marchi  <simon.marchi@efficios.com>
4651
4652         * breakpoint.c (is_hardware_watchpoint): Remove
4653         forward-declaration.
4654         (is_masked_watchpoint): Change return type to bool.
4655         (is_tracepoint): Likewise.
4656         (is_breakpoint): Likewise.
4657         (is_hardware_watchpoint): Likewise.
4658         (is_watchpoint): Likewise.
4659         (is_no_memory_software_watchpoint): Likewise.
4660         (is_catchpoint): Likewise.
4661         (breakpoint_1): Make FILTER parameter's return type bool.
4662         is_masked_watchpoint): Change return type to bool.
4663         (save_breakpoints): Make FILTER parameter's return type bool.
4664         * breakpoint.h (is_breakpoint): Change return type to bool.
4665         (is_watchpoint): Likewise.
4666         (is_catchpoint): Likewise.
4667         (is_tracepoint): Likewise.
4668
4669 2019-07-10  Tom Tromey  <tom@tromey.com>
4670
4671         * defs.h: Don't include gdbarch.h.
4672         * aarch64-ravenscar-thread.c, aarch64-tdep.c, alpha-bsd-tdep.h,
4673         alpha-linux-tdep.c, alpha-mdebug-tdep.c, arch-utils.h, arm-tdep.h,
4674         ax-general.c, btrace.c, buildsym-legacy.c, buildsym.h, c-lang.c,
4675         cli/cli-decode.h, cli/cli-dump.c, cli/cli-script.h,
4676         cli/cli-style.h, coff-pe-read.h, compile/compile-c-support.c,
4677         compile/compile-cplus.h, compile/compile-loc2c.c, corefile.c,
4678         cp-valprint.c, cris-linux-tdep.c, ctf.c, d-lang.c, d-namespace.c,
4679         dcache.c, dicos-tdep.c, dictionary.c, disasm-selftests.c,
4680         dummy-frame.c, dummy-frame.h, dwarf2-frame-tailcall.c,
4681         dwarf2expr.c, expression.h, f-lang.c, frame-base.c,
4682         frame-unwind.c, frv-linux-tdep.c, gdbarch-selftests.c, gdbtypes.h,
4683         go-lang.c, hppa-nbsd-tdep.c, hppa-obsd-tdep.c, i386-dicos-tdep.c,
4684         i386-tdep.h, ia64-vms-tdep.c, interps.h, language.c,
4685         linux-record.c, location.h, m2-lang.c, m32r-linux-tdep.c,
4686         mem-break.c, memattr.c, mn10300-linux-tdep.c, nios2-linux-tdep.c,
4687         objfiles.h, opencl-lang.c, or1k-linux-tdep.c, p-lang.c,
4688         parser-defs.h, ppc-tdep.h, probe.h, python/py-record-btrace.c,
4689         record-btrace.c, record.h, regcache-dump.c, regcache.h,
4690         riscv-fbsd-tdep.c, riscv-linux-tdep.c, rust-exp.y,
4691         sh-linux-tdep.c, sh-nbsd-tdep.c, source-cache.c,
4692         sparc-nbsd-tdep.c, sparc-obsd-tdep.c, sparc-ravenscar-thread.c,
4693         sparc64-fbsd-tdep.c, std-regs.c, target-descriptions.h,
4694         target-float.c, tic6x-linux-tdep.c, tilegx-linux-tdep.c, top.c,
4695         tracefile.c, trad-frame.c, type-stack.h, ui-style.c, utils.c,
4696         utils.h, valarith.c, valprint.c, varobj.c, x86-tdep.c,
4697         xml-support.h, xtensa-linux-tdep.c, cli/cli-cmds.h: Update.
4698         * s390-linux-nat.c, procfs.c, inf-ptrace.c: Likewise.
4699
4700 2019-07-10  Tom Tromey  <tromey@adacore.com>
4701
4702         * ada-lang.h (is_ada_exception_catchpoint): Declare.
4703         * breakpoint.c (init_ada_exception_breakpoint): Register as
4704         bp_catchpoint.
4705         (print_one_breakpoint_location, print_one_breakpoint): Use
4706         is_ada_exception_catchpoint.
4707         * ada-lang.c (class ada_catchpoint_location): Pass
4708         bp_loc_software_breakpoint to bp_location constructor.
4709         (is_ada_exception_catchpoint): New function.
4710
4711 2019-07-10  Tom Tromey  <tromey@adacore.com>
4712
4713         * arm-tdep.c (arm_exidx_entry_s): Remove typedef.  Don't define
4714         VEC.
4715         (struct arm_exidx_entry): New method operator<.
4716         (struct arm_exidx_data) <section_maps>: Change type.
4717         (arm_exidx_data_free): Remove.
4718         (arm_exidx_data_key): Change type.  Move lower.
4719         (arm_exidx_new_objfile): Update.
4720         (arm_compare_exidx_entries): Remove.
4721         (arm_find_exidx_entry, _initialize_arm_tdep)
4722
4723 2019-07-10  Tom Tromey  <tromey@adacore.com>
4724
4725         * solib-spu.c (ocl_program_data_key): Change type.
4726         (append_ocl_sos, ocl_enable_break, _initialize_spu_solib):
4727         Update.
4728
4729 2019-07-10  Tom Tromey  <tromey@adacore.com>
4730
4731         * solib-aix.c (lm_info_aix_p): Remove typedef.  Don't define VEC.
4732         (struct solib_aix_inferior_data) <library_list>: Change type.
4733         (solib_aix_inferior_data_handle): Change type.
4734         (get_solib_aix_inferior_data): Update.
4735         (solib_aix_free_library_list): Remove.
4736         (library_list_start_library): Update.
4737         (solib_aix_parse_libraries, solib_aix_get_library_list): Change
4738         return type.
4739         (solib_aix_get_library_list)
4740         (solib_aix_solib_create_inferior_hook, solib_aix_current_sos)
4741         (solib_aix_normal_stop_observer, _initialize_solib_aix): Update.
4742
4743 2019-07-10  Tom Tromey  <tromey@adacore.com>
4744
4745         * solib-dsbt.c (struct dsbt_info): Add initializers.
4746         (solib_dsbt_pspace_data): Change type.
4747         (dsbt_pspace_data_cleanup): Remove.
4748         (get_dsbt_info, _initialize_dsbt_solib): Update.
4749
4750 2019-07-10  Tom Tromey  <tromey@adacore.com>
4751
4752         * spu-tdep.c (spu_overlay_data): Change type.
4753         (spu_get_overlay_table, spu_overlay_new_objfile)
4754         (_initialize_spu_tdep): Update.
4755
4756 2019-07-10  Tom Tromey  <tromey@adacore.com>
4757
4758         * gdb-stabs.h (struct dbx_symfile_info): Add initializers and
4759         destructor.
4760         (dbx_objfile_data_key): Change type and declare later.
4761         (DBX_SYMFILE_INFO): Rewrite.
4762         * dbxread.c (dbx_objfile_data_key): Change type.
4763         (dbx_symfile_init): Update.
4764         (~dbx_symfile_info): Rename from dbx_free_symfile_info.  Update.
4765         (coffstab_build_psymtabs, elfstab_build_psymtabs)
4766         (stabsect_build_psymtabs, _initialize_dbxread): Update.
4767
4768 2019-07-10  Tom Tromey  <tromey@adacore.com>
4769
4770         * jit.c (jit_program_space_key): Change type.  Move lower.
4771         (get_jit_program_space_data): Update.
4772         (jit_program_space_data_cleanup): Remove.
4773         (jit_breakpoint_deleted, free_objfile_data, _initialize_jit):
4774         Update.
4775         (struct jit_program_space_data): Add initializers.
4776
4777 2019-07-10  Tom Tromey  <tromey@adacore.com>
4778
4779         * solib-darwin.c (struct darwin_info): Add initializers.
4780         (solib_darwin_pspace_data): Change type.
4781         (darwin_pspace_data_cleanup): Remove.
4782         (get_darwin_info, _initialize_darwin_solib): Update.
4783
4784 2019-07-10  Tom Tromey  <tromey@adacore.com>
4785
4786         * remote-sim.c (struct sim_inferior_data): Add initializers,
4787         constructor, and destructor.
4788         (sim_inferior_data_key): Change type.  Move lower.
4789         (check_for_duplicate_sim_descriptor): Update.
4790         (get_sim_inferior_data): Use new.  Update.
4791         (~sim_inferior_data_cleanup): Rename from
4792         sim_inferior_data_cleanup.  Simplify.
4793         (gdbsim_close_inferior, simulator_command)
4794         (sim_command_completer, _initialize_remote_sim): Update.
4795         (next_pid, INITIAL_PID): Move earlier.
4796
4797 2019-07-10  Tom Tromey  <tromey@adacore.com>
4798
4799         * python/python-internal.h (create_thread_object): Return
4800         gdbpy_ref.
4801         * python/py-infthread.c (create_thread_object): Return gdbpy_ref.
4802         * python/py-inferior.c (struct threadlist_entry): Add
4803         constructor.
4804         <thread_obj>: Now a gdbpy_ref.
4805         (thread_to_thread_object): Update.
4806         (add_thread_object): Use new.
4807         (delete_thread_object): Use delete.
4808         (infpy_threads): Update.
4809         (py_free_inferior): Update.  Construct "inf_obj" after acquiring
4810         GIL.
4811
4812 2019-07-10  Tom Tromey  <tromey@adacore.com>
4813
4814         * valops.c (value_cast): Specialize error message for Ada.
4815
4816 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
4817
4818         * breakpoint.c (breakpoint_1): Update doc and parameter names.
4819
4820 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
4821
4822         * breakpoint.h (bpstat_explains_signal, bpstat_causes_stop,
4823         bpstat_should_step): Return bool, adjust comments.
4824         * breakpoint.c (bpstat_explains_signal, bpstat_causes_stop,
4825         bpstat_should_step): Likewise.
4826
4827 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
4828
4829         * features/Makefile: Use feature target descriptions for Arm.
4830         * features/arm/arm-core.c: Generate new file.
4831         * features/arm/arm-fpa.c: Likewise.
4832         * features/arm/arm-m-profile-with-fpa.xml: Likewise.
4833         * features/arm/arm-m-profile.c: Likewise.
4834         * features/arm/arm-vfpv2.c: Likewise.
4835         * features/arm/arm-vfpv3.c: Likewise.
4836         * features/arm/xscale-iwmmxt.c: Likewise.
4837         * target-descriptions.c (maint_print_c_tdesc_cmd): Add Arm.
4838
4839 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
4840
4841         * arm-linux-nat.c (arm_linux_nat_target::read_description): Check
4842         ptrace earlier.
4843
4844 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
4845
4846         * features/aarch64-pauth.c: Regenerate.
4847
4848 2019-07-09  Simon Marchi  <simon.marchi@polymtl.ca>
4849
4850         * breakpoint.h (struct bpstat_what) <is_longjmp>: Change type to
4851         bool.
4852         (bpstat_what): Use false instead of 0.
4853
4854 2019-07-09  Pedro Alves  <palves@redhat.com>
4855
4856         * break-catch-throw.c (is_exception_catchpoint): New.
4857         * breakpoint.c (print_one_breakpoint_location): New parameter
4858         'raw_loc'.  Handle it.  Use
4859         is_watchpoint/is_catchpoint/is_exception_catchpoint instead of
4860         looking at the breakpoint's type.
4861         (print_one_breakpoint): If handling "maint info breakpoints", also
4862         print locations of exception catchpoints.
4863         * breakpoint.h (is_exception_catchpoint): Declare.
4864
4865 2019-07-09  Pedro Alves  <palves@redhat.com>
4866
4867         * break-catch-throw.c (print_one_exception_catchpoint): Skip the
4868         "addr" field.
4869         (allocate_location_exception_catchpoint): New.
4870         (handle_gnu_v3_exceptions): Don't reset 'type' to bp_breakpoint.
4871         (initialize_throw_catchpoint_ops): Install
4872         allocate_location_exception_catchpoint as allocate_location
4873         method.
4874         * breakpoint.c (bpstat_what) <bp_catch>: Set action to
4875         BPSTAT_WHAT_SINGLE if not stopping and the location's type is not
4876         bp_loc_other.
4877         (breakpoint_address_is_meaningful): Delete.
4878         (bl_address_is_meaningful): New.
4879         (breakpoint_locations_match): Adjust comment.
4880         (bp_location_from_bp_type): New, factored out of...
4881         (bp_location::bp_location(breakpoint *)): ... this.
4882         (bp_location::bp_location(breakpoint *, bp_loc_type)): New,
4883         factored out of...
4884         (bp_location::bp_location(breakpoint *)): ... this.  Reimplement.
4885         (bp_loc_is_permanent): Use bl_address_is_meaningful instead of
4886         breakpoint_address_is_meaningful.
4887         (bp_locations_compare): Adjust comment.
4888         (update_global_location_list): Use bl_address_is_meaningful
4889         instead of breakpoint_address_is_meaningful.
4890         * breakpoint.h (bp_location::bp_location(breakpoint *)): New
4891         explicit.
4892         (bp_location::bp_location(breakpoint *, bp_loc_type)): Declare.
4893         * python/py-breakpoint.c (bppy_get_location): No longer check
4894         whether location is null.
4895
4896 2019-07-09  Pedro Alves  <palves@redhat.com>
4897
4898         PR c++/15468
4899         * breakpoint.c (print_one_breakpoint_location): Remove
4900         single-location assert.
4901
4902 2019-07-09  Tom Tromey  <tom@tromey.com>
4903
4904         * contrib/ari/gdb_ari.sh: Change common to gdbsupport.
4905         * configure: Rebuild.
4906         * configure.ac: Change common to gdbsupport.
4907         * gdbsupport: Rename from common.
4908         * acinclude.m4: Change common to gdbsupport.
4909         * Makefile.in (CONFIG_SRC_SUBDIR, COMMON_SFILES)
4910         (HFILES_NO_SRCDIR, stamp-version, ALLDEPFILES): Change common to
4911         gdbsupport.
4912         * aarch64-tdep.c, ada-lang.c, ada-lang.h, agent.c, alloc.c,
4913         amd64-darwin-tdep.c, amd64-dicos-tdep.c, amd64-fbsd-nat.c,
4914         amd64-fbsd-tdep.c, amd64-linux-nat.c, amd64-linux-tdep.c,
4915         amd64-nbsd-tdep.c, amd64-obsd-tdep.c, amd64-sol2-tdep.c,
4916         amd64-tdep.c, amd64-windows-tdep.c, arch-utils.c,
4917         arch/aarch64-insn.c, arch/aarch64.c, arch/aarch64.h, arch/amd64.c,
4918         arch/amd64.h, arch/arm-get-next-pcs.c, arch/arm-linux.c,
4919         arch/arm.c, arch/i386.c, arch/i386.h, arch/ppc-linux-common.c,
4920         arch/riscv.c, arch/riscv.h, arch/tic6x.c, arm-tdep.c, auto-load.c,
4921         auxv.c, ax-gdb.c, ax-general.c, ax.h, breakpoint.c, breakpoint.h,
4922         btrace.c, btrace.h, build-id.c, build-id.h, c-lang.h, charset.c,
4923         charset.h, cli/cli-cmds.c, cli/cli-cmds.h, cli/cli-decode.c,
4924         cli/cli-dump.c, cli/cli-option.h, cli/cli-script.c,
4925         coff-pe-read.c, command.h, compile/compile-c-support.c,
4926         compile/compile-c.h, compile/compile-cplus-symbols.c,
4927         compile/compile-cplus-types.c, compile/compile-cplus.h,
4928         compile/compile-loc2c.c, compile/compile.c, completer.c,
4929         completer.h, contrib/ari/gdb_ari.sh, corefile.c, corelow.c,
4930         cp-support.c, cp-support.h, cp-valprint.c, csky-tdep.c, ctf.c,
4931         darwin-nat.c, debug.c, defs.h, disasm-selftests.c, disasm.c,
4932         disasm.h, dtrace-probe.c, dwarf-index-cache.c,
4933         dwarf-index-cache.h, dwarf-index-write.c, dwarf2-frame.c,
4934         dwarf2expr.c, dwarf2loc.c, dwarf2read.c, event-loop.c,
4935         event-top.c, exceptions.c, exec.c, extension.h, fbsd-nat.c,
4936         features/aarch64-core.c, features/aarch64-fpu.c,
4937         features/aarch64-pauth.c, features/aarch64-sve.c,
4938         features/i386/32bit-avx.c, features/i386/32bit-avx512.c,
4939         features/i386/32bit-core.c, features/i386/32bit-linux.c,
4940         features/i386/32bit-mpx.c, features/i386/32bit-pkeys.c,
4941         features/i386/32bit-segments.c, features/i386/32bit-sse.c,
4942         features/i386/64bit-avx.c, features/i386/64bit-avx512.c,
4943         features/i386/64bit-core.c, features/i386/64bit-linux.c,
4944         features/i386/64bit-mpx.c, features/i386/64bit-pkeys.c,
4945         features/i386/64bit-segments.c, features/i386/64bit-sse.c,
4946         features/i386/x32-core.c, features/riscv/32bit-cpu.c,
4947         features/riscv/32bit-csr.c, features/riscv/32bit-fpu.c,
4948         features/riscv/64bit-cpu.c, features/riscv/64bit-csr.c,
4949         features/riscv/64bit-fpu.c, features/tic6x-c6xp.c,
4950         features/tic6x-core.c, features/tic6x-gp.c, filename-seen-cache.h,
4951         findcmd.c, findvar.c, fork-child.c, gcore.c, gdb_bfd.c, gdb_bfd.h,
4952         gdb_proc_service.h, gdb_regex.c, gdb_select.h, gdb_usleep.c,
4953         gdbarch-selftests.c, gdbthread.h, gdbtypes.h, gnu-nat.c,
4954         go32-nat.c, guile/guile.c, guile/scm-ports.c,
4955         guile/scm-safe-call.c, guile/scm-type.c, i386-fbsd-nat.c,
4956         i386-fbsd-tdep.c, i386-go32-tdep.c, i386-linux-nat.c,
4957         i386-linux-tdep.c, i386-tdep.c, i387-tdep.c,
4958         ia64-libunwind-tdep.c, ia64-linux-nat.c, inf-child.c,
4959         inf-ptrace.c, infcall.c, infcall.h, infcmd.c, inferior-iter.h,
4960         inferior.c, inferior.h, inflow.c, inflow.h, infrun.c, infrun.h,
4961         inline-frame.c, language.h, linespec.c, linux-fork.c, linux-nat.c,
4962         linux-tdep.c, linux-thread-db.c, location.c, machoread.c,
4963         macrotab.h, main.c, maint.c, maint.h, memattr.c, memrange.h,
4964         mi/mi-cmd-break.h, mi/mi-cmd-env.c, mi/mi-cmd-stack.c,
4965         mi/mi-cmd-var.c, mi/mi-interp.c, mi/mi-main.c, mi/mi-parse.h,
4966         minsyms.c, mips-linux-tdep.c, namespace.h,
4967         nat/aarch64-linux-hw-point.c, nat/aarch64-linux-hw-point.h,
4968         nat/aarch64-linux.c, nat/aarch64-sve-linux-ptrace.c,
4969         nat/amd64-linux-siginfo.c, nat/fork-inferior.c,
4970         nat/linux-btrace.c, nat/linux-btrace.h, nat/linux-namespaces.c,
4971         nat/linux-nat.h, nat/linux-osdata.c, nat/linux-personality.c,
4972         nat/linux-procfs.c, nat/linux-ptrace.c, nat/linux-ptrace.h,
4973         nat/linux-waitpid.c, nat/mips-linux-watch.c,
4974         nat/mips-linux-watch.h, nat/ppc-linux.c, nat/x86-dregs.c,
4975         nat/x86-dregs.h, nat/x86-linux-dregs.c, nat/x86-linux.c,
4976         nto-procfs.c, nto-tdep.c, objfile-flags.h, objfiles.c, objfiles.h,
4977         obsd-nat.c, observable.h, osdata.c, p-valprint.c, parse.c,
4978         parser-defs.h, ppc-linux-nat.c, printcmd.c, probe.c, proc-api.c,
4979         procfs.c, producer.c, progspace.h, psymtab.h,
4980         python/py-framefilter.c, python/py-inferior.c, python/py-ref.h,
4981         python/py-type.c, python/python.c, record-btrace.c, record-full.c,
4982         record.c, record.h, regcache-dump.c, regcache.c, regcache.h,
4983         remote-fileio.c, remote-fileio.h, remote-sim.c, remote.c,
4984         riscv-tdep.c, rs6000-aix-tdep.c, rust-exp.y, s12z-tdep.c,
4985         selftest-arch.c, ser-base.c, ser-event.c, ser-pipe.c, ser-tcp.c,
4986         ser-unix.c, skip.c, solib-aix.c, solib-target.c, solib.c,
4987         source-cache.c, source.c, source.h, sparc-nat.c, spu-linux-nat.c,
4988         stack.c, stap-probe.c, symfile-add-flags.h, symfile.c, symfile.h,
4989         symtab.c, symtab.h, target-descriptions.c, target-descriptions.h,
4990         target-memory.c, target.c, target.h, target/waitstatus.c,
4991         target/waitstatus.h, thread-iter.h, thread.c, tilegx-tdep.c,
4992         top.c, top.h, tracefile-tfile.c, tracefile.c, tracepoint.c,
4993         tracepoint.h, tui/tui-io.c, ui-file.c, ui-out.h,
4994         unittests/array-view-selftests.c,
4995         unittests/child-path-selftests.c, unittests/cli-utils-selftests.c,
4996         unittests/common-utils-selftests.c,
4997         unittests/copy_bitwise-selftests.c, unittests/environ-selftests.c,
4998         unittests/format_pieces-selftests.c,
4999         unittests/function-view-selftests.c,
5000         unittests/lookup_name_info-selftests.c,
5001         unittests/memory-map-selftests.c, unittests/memrange-selftests.c,
5002         unittests/mkdir-recursive-selftests.c,
5003         unittests/observable-selftests.c,
5004         unittests/offset-type-selftests.c, unittests/optional-selftests.c,
5005         unittests/parse-connection-spec-selftests.c,
5006         unittests/ptid-selftests.c, unittests/rsp-low-selftests.c,
5007         unittests/scoped_fd-selftests.c,
5008         unittests/scoped_mmap-selftests.c,
5009         unittests/scoped_restore-selftests.c,
5010         unittests/string_view-selftests.c, unittests/style-selftests.c,
5011         unittests/tracepoint-selftests.c, unittests/unpack-selftests.c,
5012         unittests/utils-selftests.c, unittests/xml-utils-selftests.c,
5013         utils.c, utils.h, valarith.c, valops.c, valprint.c, value.c,
5014         value.h, varobj.c, varobj.h, windows-nat.c, x86-linux-nat.c,
5015         xml-support.c, xml-support.h, xml-tdesc.h, xstormy16-tdep.c,
5016         xtensa-linux-nat.c, dwarf2read.h: Change common to gdbsupport.
5017
5018 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
5019
5020         * linespec.c (decode_digits_list_mode): Set explicit_line to a
5021         bool value.
5022         (decode_digits_ordinary): Set explicit_line field in sal.
5023         * symtab.c (skip_prologue_sal): Don't skip prologue for a
5024         symtab_and_line that was set on an explicit line number in
5025         assembler code.  Do always update the recorded symtab and line if
5026         we do skip the prologue.
5027
5028 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
5029
5030         * breakpoint.c (set_breakpoint_location_function): Remove
5031         explicit_loc parameter.
5032         (momentary_breakpoint_from_master): Update call to
5033         set_breakpoint_location_function.
5034         (add_location_to_breakpoint): Likewise.
5035
5036 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
5037
5038         * riscv-tdep.c (riscv_features_from_gdbarch_info): Don't modify
5039         required features based on default bfd type when no specific bfd
5040         is present.
5041
5042 2019-07-08  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5043
5044         * NEWS: Mention that GDB printf and eval commands can now print
5045         C-style and Ada-style convenience var strings without
5046         calling the inferior.
5047         * printcmd.c (printf_c_string): Locally print GDB internal var
5048         instead of transiting via the inferior.
5049         (printf_wide_c_string): Likewise.
5050
5051 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
5052
5053         PR breakpoints/25011
5054         * symfile.c (symbol_file_command): Call solib_create_inferior_hook.
5055
5056 2019-07-04  Tom Tromey  <tom@tromey.com>
5057
5058         PR tui/24724:
5059         * tui/tui-winsource.c (tui_clear_source_content): Update.
5060         (tui_source_window_base::set_is_exec_point_at): Fix comment.
5061         (tui_update_breakpoint_info): Update.
5062         (tui_set_exec_info_content): Update.
5063         * tui/tui-source.c (tui_set_source_content_nil): Update.
5064         * tui/tui-disasm.c (tui_set_disassem_content): Don't set
5065         has_break.
5066         * tui/tui-data.h (enum tui_bp_flag): New.
5067         (tui_bp_flags): New enum flags type.
5068         (struct tui_source_element) <break_mode>: Change type.  Rename
5069         from has_break.
5070         (TUI_BP_ENABLED, TUI_BP_DISABLED, TUI_BP_HIT)
5071         (TUI_BP_CONDITIONAL, TUI_BP_HARDWARE): Don't define.  Now enum
5072         constants.
5073         * tui/tui-winsource.h: Fix comment.
5074
5075 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
5076
5077         * aarch32-linux-nat.h (VFP_REGS_SIZE): Remove define.
5078         * aarch64-linux-nat.c (fetch_fpregs_from_thread)
5079         (store_fpregs_to_thread)
5080         (aarch64_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
5081         * arch/arm.h (IWMMXT_VEC_REGISTER_SIZE, ARM_CORE_REGS_SIZE)
5082         (ARM_FP_REGS_SIZE, ARM_VFP2_REGS_SIZE, ARM_VFP3_REGS_SIZE)
5083         (IWMMXT_REGS_SIZE): Add define.
5084         * arm-linux-nat.c (IWMMXT_REGS_SIZE): Remove define.
5085         (fetch_vfp_regs, store_vfp_regs)
5086         (arm_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
5087         * arm-tdep.c (arm_register_g_packet_guesses): Use new defines.
5088
5089 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
5090
5091         * arch/arm-get-next-pcs.c (thumb_get_next_pcs_raw): Use ARM_
5092         defines.
5093         * arch/arm-linux.c (arm_linux_sigreturn_next_pc_offset): Likewise.
5094         * arch/arm.h (INT_REGISTER_SIZE) Rename from...
5095         (ARM_INT_REGISTER_SIZE): ...to this.
5096         (ARM_FP_REGISTER_SIZE) (ARM_VFP_REGISTER_SIZE): Add define.
5097         * arm-linux-tdep.c (ARM_LINUX_JB_ELEMENT_SIZE)
5098         (ARM_LINUX_SIZEOF_GREGSET, arm_linux_supply_gregset)
5099         (arm_linux_collect_gregset, supply_nwfpe_register)
5100         (collect_nwfpe_register, arm_linux_collect_nwfpe): Use ARM_
5101         defines.
5102         * arm-linux-tdep.h (ARM_LINUX_SIZEOF_NWFPE, NWFPE_FPSR_OFFSET)
5103         (NWFPE_FPCR_OFFSET, NWFPE_TAGS_OFFSET): Likewise
5104         * arm-nbsd-tdep.c (ARM_NBSD_JB_ELEMENT_SIZE): Likewise.
5105         * arm-tdep.c (arm_push_dummy_call, arm_extract_return_value)
5106         (arm_return_in_memory, arm_store_return_value)
5107         (arm_get_longjmp_target, arm_register_g_packet_guesses)
5108         (arm_record_ld_st_multiple): Likewise.
5109         * arm-tdep.h (FP_REGISTER_SIZE, VFP_REGISTER_SIZE): Remove.
5110         * arm-wince-tdep.c (ARM_WINCE_JB_ELEMENT_SIZE): Use ARM_ defines.
5111
5112 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
5113
5114         * aarch64-linux-tdep.c (aarch64_linux_init_abi): Use
5115         AARCH64_DISPLACED_MODIFIED_INSNS.
5116         * aarch64-tdep.c (struct aarch64_displaced_step_data)
5117         (aarch64_displaced_step_copy_insn): Likewise.
5118         * aarch64-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
5119         (AARCH64_DISPLACED_MODIFIED_INSNS): ...to this.
5120         * arm-linux-tdep.c (arm_linux_cleanup_svc): Use
5121         ARM_DISPLACED_MODIFIED_INSNS.
5122         * arm-tdep.c (arm_gdbarch_init): Likewise.
5123         * arm-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
5124         (ARM_DISPLACED_MODIFIED_INSNS): ...to this.
5125         (struct arm_displaced_step_closure): Use
5126         ARM_DISPLACED_MODIFIED_INSNS.
5127
5128 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
5129
5130         * features/Makefile: Remove unused xml files.
5131         * features/aarch64.xml: Remove.
5132         * features/i386/amd64-avx-avx512-linux.xml: Remove.
5133         * features/i386/amd64-avx-avx512.xml: Remove.
5134         * features/i386/amd64-avx-linux.xml: Remove.
5135         * features/i386/amd64-avx-mpx-avx512-pku-linux.xml: Remove.
5136         * features/i386/amd64-avx-mpx-avx512-pku.xml: Remove.
5137         * features/i386/amd64-avx-mpx-linux.xml: Remove.
5138         * features/i386/amd64-avx-mpx.xml: Remove.
5139         * features/i386/amd64-avx.xml: Remove.
5140         * features/i386/amd64-linux.xml: Remove.
5141         * features/i386/amd64-mpx-linux.xml: Remove.
5142         * features/i386/amd64-mpx.xml: Remove.
5143         * features/i386/amd64.xml: Remove.
5144         * features/i386/i386-avx-avx512-linux.xml: Remove.
5145         * features/i386/i386-avx-avx512.xml: Remove.
5146         * features/i386/i386-avx-linux.xml: Remove.
5147         * features/i386/i386-avx-mpx-avx512-pku-linux.xml: Remove.
5148         * features/i386/i386-avx-mpx-avx512-pku.xml: Remove.
5149         * features/i386/i386-avx-mpx-linux.xml: Remove.
5150         * features/i386/i386-avx-mpx.xml: Remove.
5151         * features/i386/i386-avx.xml: Remove.
5152         * features/i386/i386-linux.xml: Remove.
5153         * features/i386/i386-mmx-linux.xml: Remove.
5154         * features/i386/i386-mmx.xml: Remove.
5155         * features/i386/i386-mpx-linux.xml: Remove.
5156         * features/i386/i386-mpx.xml: Remove.
5157         * features/i386/i386.xml: Remove.
5158         * features/i386/x32-avx-avx512-linux.xml: Remove.
5159         * features/i386/x32-avx-linux.xml: Remove.
5160         * features/i386/x32-linux.xml: Remove.
5161
5162 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
5163
5164         * regformats/aarch64.dat: Remove.
5165         * regformats/i386/amd64-avx-avx512-linux.dat: Remove.
5166         * regformats/i386/amd64-avx-linux.dat: Remove.
5167         * regformats/i386/amd64-avx-mpx-avx512-pku-linux.dat: Remove.
5168         * regformats/i386/amd64-avx-mpx-linux.dat: Remove.
5169         * regformats/i386/amd64-linux.dat: Remove.
5170         * regformats/i386/amd64-mpx-linux.dat: Remove.
5171         * regformats/i386/amd64.dat: Remove.
5172         * regformats/i386/i386-avx-avx512-linux.dat: Remove.
5173         * regformats/i386/i386-avx-linux.dat: Remove.
5174         * regformats/i386/i386-avx-mpx-avx512-pku-linux.dat: Remove.
5175         * regformats/i386/i386-avx-mpx-linux.dat: Remove.
5176         * regformats/i386/i386-linux.dat: Remove.
5177         * regformats/i386/i386-mmx-linux.dat: Remove.
5178         * regformats/i386/i386-mpx-linux.dat: Remove.
5179         * regformats/i386/i386.dat: Remove.
5180         * regformats/i386/x32-avx-avx512-linux.dat: Remove.
5181         * regformats/i386/x32-avx-linux.dat: Remove.
5182         * regformats/i386/x32-linux.dat: Remove.
5183
5184 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
5185
5186         * aarch64-tdep.c: Remove xml self tests.
5187         * amd64-linux-tdep.c: Likewise.
5188         * amd64-tdep.c: Likewise.
5189         * i386-linux-tdep.c: Likewise.
5190         * i386-tdep.c: Likewise.
5191
5192 2019-07-03  Pedro Alves  <palves@redhat.com>
5193
5194         PR cli/24732
5195         * cli/cli-cmds.c (struct pipe_cmd_opts): New.
5196         (pipe_cmd_option_defs): New.
5197         (make_pipe_cmd_options_def_group): New.
5198         (pipe_command): Use gdb::option::process_options.
5199         (pipe_command_completer): New function.
5200         (_initialize_cli_cmds): Install completer for "pipe" command.
5201
5202 2019-07-03  Pedro Alves  <palves@redhat.com>
5203
5204         * cli/cli-option.c (union option_value) <string>: New field.
5205         (struct option_def_and_value): Add ctor, move ctor, dtor and
5206         use DISABLE_COPY_AND_ASSIGN.
5207         (option_def_and_value::clear_value): New.
5208         (parse_option, save_option_value_in_ctx, get_val_type_str)
5209         (add_setshow_cmds_for_options): Handle var_string.
5210         * cli-option.h (union option_def::var_address) <string>: New
5211         field.
5212         (struct string_option_def): New.
5213         * maint-test-options.c (struct test_options_opts): Add default
5214         ctor and use DISABLE_COPY_AND_ASSIGN.
5215         <string_opt>: New field.
5216         (test_options_opts::~test_options_opts): New.
5217         (test_options_opts::dump): Also dump "-string".
5218         (test_options_option_defs): Install "string.
5219
5220 2019-07-03  Pedro Alves  <palves@redhat.com>
5221
5222         * cli/cli-option.c (parse_option) <var_enum>: Don't return an
5223         option_value with a null enumeration.
5224         (complete_options): Save the option values in the context.
5225         (save_option_value_in_ctx): New, factored out from ...
5226         (process_options): ... here.
5227         * cli/cli-utils.c (get_ulongest): Don't advance PP until the end
5228         of the function.
5229         * maint-test-options.c (test_options_opts::dump): New, factored
5230         out from ...
5231         (maintenance_test_options_command_mode): ... here.
5232         (maintenance_test_options_command_completion_result): Delete.
5233         (maintenance_test_options_command_completion_text): Update
5234         comment.
5235         (maintenance_show_test_options_completion_result): Change
5236         prototype.  Just print
5237         maintenance_test_options_command_completion_text.
5238         (save_completion_result): New.
5239         (maintenance_test_options_completer_mode): Pass options context to
5240         complete_options, and then save a dump.
5241         (_initialize_maint_test_options): Use add_cmd to install "maint
5242         show test-options-completion-result".
5243
5244 2019-07-03  Pedro Alves  <palves@redhat.com>
5245
5246         * NEWS (New commands): Mention "with" and "maint with".
5247         * cli/cli-cmds.c (with_command_1, with_command_completer_1)
5248         (with_command, with_command_completer): New.
5249         (pipe_command): Adjust to new repeat_previous
5250         interface.
5251         (_initialize_cli_cmds): Install the "with" command and its "w"
5252         alias.
5253         * cli/cli-cmds.h (with_command_1, with_command_completer_1): New
5254         declarations.
5255         * cli/cli-setshow.c (parse_cli_var_uinteger)
5256         (parse_cli_var_zuinteger_unlimited, do_set_command): Handle empty
5257         argument strings for all var_types.
5258         (get_setshow_command_value_string): New, factored out from ...
5259         (do_show_command): ... this.
5260         * cli/cli-setshow.h: Include <string>.
5261         (get_setshow_command_value_string): Declare.
5262         * command.h (repeat_previous): Now returns const char *.  Adjust
5263         comment.
5264         * maint.c: Include "cli/cli-cmds.h".
5265         (maintenance_with_cmd, maintenance_with_cmd_completer): New.
5266         (_initialize_maint_cmds): Register the "maintenance with" command.
5267         * top.c (repeat_previous): Move bits from pipe_command here:
5268         Return the saved command line, if any; error out if there's no
5269         command to relaunch.
5270
5271 2019-07-03  Pedro Alves  <palves@redhat.com>
5272
5273         * NEWS (New commands): Mention "maint set/show test-settings"
5274         instead of "maint test-settings".
5275         * maint-test-settings.c (maintenance_test_settings_list): Delete.
5276         (maintenance_test_settings_set_list): Rename to ...
5277         (maintenance_set_test_settings_list): ... this.
5278         (maintenance_test_settings_show_list): Rename to  ...
5279         (maintenance_show_test_settings_list): ... this.
5280         (maintenance_test_settings_cmd): Delete.
5281         (maintenance_test_settings_set_cmd): ...
5282         (maintenance_set_test_settings_cmd): ... this.
5283         (maintenance_test_settings_show_cmd): ...
5284         (maintenance_show_test_settings_cmd): ... this.
5285         (maintenance_test_settings_show_value_cmd):
5286         (maintenance_show_test_settings_value_cmd): ... this.
5287         (_initialize_maint_test_settings): No longer install the "maint
5288         test-settings" prefix command.  Rename "maint test-settings set"
5289         to "maint set test-settings", and "maint test-settings show" to
5290         "maint show test-settings".  Adjust all subcommands.
5291
5292 2019-07-03  Pedro Alves  <palves@redhat.com>
5293
5294         * maint-test-settings.c: Fix file's intro comment.  Replace all
5295         references to "test-options" with references to "test-settings",
5296         in comments.
5297
5298 2019-07-03  Pedro Alves  <palves@redhat.com>
5299
5300         * maint-test-settings.c (maintenance_test_settings_xxx)
5301         (maintenance_test_settings_yyy, maintenance_test_settings_zzz):
5302         New.
5303         (maintenance_test_settings_enums): Use them.
5304         (maintenance_test_settings_enum): Default to
5305         maintenance_test_settings_xxx.
5306         (_initialize_maint_test_settings): Initialize
5307         MAINTENANCE_TEST_SETTINGS_FILENAME.
5308
5309 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
5310
5311         * breakpoint.h (remove_breakpoints_inf): Change return type to
5312         void, move function documentation here.
5313         * breakpoint.c (remove_breakpoints_inf): Change return type to
5314         void, move function documentation to header.
5315
5316 2019-07-02  Pedro Alves  <palves@redhat.com>
5317
5318         * NEWS (Completion improvements): Mention "info threads".
5319         * thread.c (struct info_threads_opts, info_threads_option_defs)
5320         (make_info_threads_options_def_group): New.
5321         (info_threads_command): Use gdb::option::process_options.
5322         (info_threads_command_completer): New.
5323         (_initialize_thread): Use gdb::option::build_help to build the
5324         help text for "info threads".
5325
5326 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
5327
5328         * defs.h (generic_load): Move from here...
5329         * symfile.h (generic_load): ... to here.  Rename name parameter
5330         to args.
5331         * symfile.c (generic_load): Add comment.
5332
5333 2019-07-01  Tom Tromey  <tromey@adacore.com>
5334
5335         * dwarf2read.c
5336         (dw2_debug_names_iterator::find_vec_in_debug_names): Hoist
5337         declaration of without_params.  Fix formatting.
5338
5339 2019-07-01  Tom Tromey  <tromey@adacore.com>
5340
5341         * ada-exp.y (find_primitive_type): Update.
5342         * ada-lang.h (ada_lookup_symbol): Update.
5343         * ada-lang.c (ada_lookup_symbol): Remove "is_a_field_of_this"
5344         parameter.
5345         (ada_lookup_encoded_symbol, ada_lookup_symbol_nonlocal): Update.
5346
5347 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
5348
5349         PR breakpoints/24541
5350         * gdbarch.c: Regenerate.
5351         * gdbarch.h: Regenerate.
5352         * gdbarch.sh: Add 'stap_adjust_register'.
5353         * i386-tdep.c: Include '<unordered_set>'.
5354         (i386_stap_adjust_register): New function.
5355         (i386_elf_init_abi): Register 'i386_stap_adjust_register'.
5356         * stap-probe.c (stap_parse_register_operand): Call
5357         'gdbarch_stap_adjust_register'.
5358
5359 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
5360
5361         PR python/24742
5362         https://bugzilla.redhat.com/show_bug.cgi?id=1723564
5363         * python/python.c (do_start_initialization): Use 'xmalloc'
5364         instead of 'PyMem_Malloc'.
5365
5366 2019-06-28  Tom Tromey  <tromey@adacore.com>
5367
5368         * dwarf2read.c (partial_die_info::read): Prefer the linkage name
5369         for Ada.
5370
5371 2019-06-27  Tom Tromey  <tromey@adacore.com>
5372
5373         * arm-tdep.c (arm_objfile_data_key): Move lower.  Change type to
5374         objfile_key.
5375         (arm_find_mapping_symbol, arm_record_special_symbol)
5376         (_initialize_arm_tdep): Update.
5377         (arm_objfile_data_free): Remove.
5378
5379 2019-06-27  Tom Tromey  <tromey@adacore.com>
5380
5381         * cp-valprint.c (cp_print_value_fields): Pass opts, not options,
5382         to cp_print_static_field.
5383
5384 2019-06-26  Tom Tromey  <tromey@adacore.com>
5385
5386         * minsyms.c (lookup_minimal_symbol_solib_trampoline): Remove.
5387         * minsyms.h (lookup_minimal_symbol_solib_trampoline): Don't
5388         declare.
5389
5390 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
5391
5392         * features/aarch64-core.c (create_feature_aarch64_core):
5393         Regenerate.
5394         * features/aarch64-core.xml: Add cpsr flags.
5395
5396 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
5397
5398         * arm-tdep.c (arm_gnu_triplet_regexp): New function.
5399         (arm_gdbarch_init): Add arm_gnu_triplet_regexp.
5400
5401 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
5402
5403         * arm-tdep.c (struct arm_per_objfile) <section_maps_sorted>: New
5404         field.
5405         (arm_find_mapping_symbol): Sort mapping symbol vectors on first
5406         use.
5407         (arm_record_special_symbol): Don't insert new symbol in sorted
5408         position, push it at the end.
5409
5410 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
5411
5412         * arm-tdep.c (struct arm_mapping_symbol) (operator <): New.
5413         (arm_mapping_symbol_s): Remove.
5414         (DEF_VEC_O(arm_mapping_symbol_s)): Remove.
5415         (arm_mapping_symbol_vec): New typedef.
5416         (struct arm_per_objfile): Add constructor.
5417         <section_maps>: Change type to
5418         std::unique_ptr<arm_mapping_symbol_vec[]>.
5419         (arm_compare_mapping_symbols): Remove.
5420         (arm_find_mapping_symbol): Adjust to section_maps type change.
5421         (arm_objfile_data_free): Call delete on arm_per_objfile.
5422         (arm_record_special_symbol): Adjust to section_maps type change.
5423         Allocate arm_per_objfile with new.
5424
5425 2019-06-25  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5426
5427         * cli/cli-cmds.c (alias_command): Compare the alias prefix
5428         with the command prefix.
5429
5430 2019-06-25  Tom Tromey  <tom@tromey.com>
5431
5432         * tui/tui-wingeneral.c (tui_delete_win): Remove "return".
5433         * tui/tui-data.c (~tui_gen_win_info): Remove "if".
5434
5435 2019-06-25  Tom Tromey  <tom@tromey.com>
5436
5437         * tui/tui-layout.c (init_and_make_win): Assert on unrecognized
5438         type.
5439         * tui/tui-data.h (struct tui_gen_win_info): Make constructor
5440         protected.
5441
5442 2019-06-25  Tom Tromey  <tom@tromey.com>
5443
5444         * tui/tui-winsource.c
5445         (tui_source_window_base::set_is_exec_point_at): Add check against
5446         LOA_ADDRESS.
5447
5448 2019-06-25  Tom Tromey  <tom@tromey.com>
5449
5450         * tui/tui-source.c (tui_set_source_content): Don't check before
5451         xfree.
5452         * tui/tui-disasm.c (tui_disassemble): Don't check before xfree.
5453
5454 2019-06-25  Tom Tromey  <tom@tromey.com>
5455
5456         * tui/tui-winsource.h (tui_update_source_window_as_is)
5457         (tui_alloc_source_buffer, tui_line_is_displayed)
5458         (tui_addr_is_displayed): Change type of win_info.
5459         * tui/tui-winsource.c (tui_update_source_window_as_is)
5460         (tui_clear_source_content, tui_show_source_line)
5461         (tui_show_source_content, tui_source_window_base::refill)
5462         (tui_source_window_base::set_is_exec_point_at)
5463         (tui_source_window_base::set_is_exec_point_at)
5464         (tui_update_breakpoint_info, tui_set_exec_info_content): Update.
5465         (tui_alloc_source_buffer, tui_line_is_displayed)
5466         (tui_addr_is_displayed): Change type of win_info.  Update.
5467         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
5468         (tui_source_window_base::do_make_visible_with_new_height):
5469         Update.
5470         * tui/tui-source.c (tui_set_source_content)
5471         (tui_set_source_content_nil)
5472         (tui_source_window::do_scroll_vertical): Update.
5473         * tui/tui-layout.c (show_layout): Update.
5474         * tui/tui-disasm.c (tui_set_disassem_content)
5475         (tui_disasm_window::do_scroll_vertical): Update.
5476         * tui/tui-data.h (tui_win_content): Remove.
5477         (struct tui_gen_win_info) <content, content_size>: Remove.
5478         (struct tui_source_element): Add initializers and destructor.
5479         (union tui_which_element, struct tui_win_element): Remove.
5480         (struct tui_source_window_base) <content>: New field.
5481         (struct tui_data_window): Remove destructor.
5482         (tui_alloc_content, tui_free_win_content)
5483         (tui_free_all_source_wins_content): Don't declare.
5484         * tui/tui-data.c (tui_initialize_static_data): Update.
5485         (init_content_element, tui_alloc_content): Remove.
5486         (~tui_gen_win_info): Update.
5487         (~tui_data_window, tui_free_all_source_wins_content)
5488         (tui_free_win_content, free_content, free_content_elements):
5489         Remove.
5490
5491 2019-06-25  Tom Tromey  <tom@tromey.com>
5492
5493         * tui/tui-winsource.h (tui_clear_source_content)
5494         (tui_erase_source_content, tui_show_source_content): Change type
5495         of win_info.
5496         * tui/tui-winsource.c (tui_clear_source_content)
5497         (tui_erase_source_content, tui_show_source_content): Change type
5498         of win_info.
5499         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
5500         * tui/tui-source.h (tui_set_source_content_nil): Change type of
5501         win_info.
5502         * tui/tui-source.c (tui_set_source_content_nil): Change type of
5503         win_info.
5504         * tui/tui-layout.c (show_source_or_disasm_and_command): Update.
5505
5506 2019-06-25  Tom Tromey  <tom@tromey.com>
5507
5508         * tui/tui-winsource.c (tui_clear_source_content)
5509         (tui_source_window_base::set_is_exec_point_at): Update.
5510         * tui/tui-source.c (tui_set_source_content_nil): Update.
5511         * tui/tui-data.h (struct tui_source_element) <is_exec_point>: Now
5512         a bool.
5513         * tui/tui-data.c (init_content_element): Update.
5514
5515 2019-06-25  Tom Tromey  <tom@tromey.com>
5516
5517         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Update.
5518         * tui/tui-win.c (make_invisible_and_set_new_height): Update.
5519         * tui/tui-layout.c (init_and_make_win): Update.
5520         * tui/tui.h (enum tui_win_type): Update.
5521         * tui/tui-data.h (tui_win_is_auxiliary): Rename from
5522         tui_win_is_auxillary.
5523         * tui/tui-data.c (tui_win_is_auxiliary): Rename from
5524         tui_win_is_auxillary.
5525
5526 2019-06-25  Tom Tromey  <tom@tromey.com>
5527
5528         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Update.
5529         * tui/tui-windata.c (tui_data_window::first_data_item_displayed)
5530         (tui_delete_data_content_windows, tui_display_all_data)
5531         (tui_data_window::do_scroll_vertical, tui_display_data_from):
5532         Update.
5533         * tui/tui-win.c (tui_data_window::set_new_height): Simplify.
5534         * tui/tui-regs.c (tui_last_regs_line_no)
5535         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
5536         (tui_show_registers): Update.
5537         (tui_show_register_group): Return void.  Update.
5538         (tui_display_registers_from, tui_display_reg_element_at_line)
5539         (tui_display_registers_from_line, tui_check_register_values):
5540         Update.
5541         * tui/tui-data.h (union tui_which_element) <data_window>: Remove
5542         member.
5543         (struct tui_data_window) <regs_content>: Now a std::vector.
5544         <regs_content_count>: Remove.
5545         (tui_add_content_elements, tui_free_data_content): Don't declare.
5546         * tui/tui-data.c (tui_data_window::clear_detail): Update.
5547         (init_content_element): Remove DATA_WIN case.  Add assert.
5548         (tui_add_content_elements): Remove.
5549         (tui_data_window): Update.
5550         (tui_free_data_content): Remove.
5551         (free_content_elements): Remove DATA_WIN case.
5552
5553 2019-06-25  Tom Tromey  <tom@tromey.com>
5554
5555         * tui/tui-data.c (tui_data_item_window): Update.
5556         * tui/tui-windata.h (tui_check_data_values): Don't declare.
5557         * tui/tui-windata.c (tui_display_all_data)
5558         (tui_display_data_from_line): Update.
5559         (tui_check_data_values): Remove.
5560         * tui/tui-regs.c (tui_show_register_group)
5561         (tui_display_reg_element_at_line): Update.
5562         * tui/tui-hooks.c (tui_register_changed)
5563         (tui_refresh_frame_and_register_information): Call
5564         tui_check_register_values.
5565         * tui/tui-data.h (struct tui_data_window) <data_content,
5566         data_content_count, data_type>: Remove.
5567         (enum tui_data_type): Remove.
5568
5569         * tui/tui-data.c (tui_data_window::clear_detail)
5570         (~tui_data_window): Update.
5571
5572 2019-06-25  Tom Tromey  <tom@tromey.com>
5573
5574         * tui/tui-windata.h (tui_first_data_item_displayed): Don't
5575         declare.
5576         * tui/tui-windata.c (tui_data_window::first_data_item_displayed):
5577         Rename from tui_first_data_item_displayed.  Update.
5578         (tui_data_window::refresh_all)
5579         (tui_data_window::do_scroll_vertical): Update.
5580         * tui/tui-data.h (struct tui_data_window)
5581         <first_data_item_displayed>: Declare new method.
5582
5583 2019-06-25  Tom Tromey  <tom@tromey.com>
5584
5585         * tui/tui-data.h (tui_init_generic_part): Don't declare.
5586         * tui/tui-data.c (tui_init_generic_part): Remove, moving
5587         contents...
5588         (tui_initialize_static_data): ...here.
5589
5590 2019-06-25  Tom Tromey  <tom@tromey.com>
5591
5592         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
5593         (tui_display_registers_from, tui_check_register_values): Update.
5594         (tui_display_register): Remove win_info parameter; update.
5595         (tui_get_register): Change type of parameters.
5596         * tui/tui-data.h (struct tui_data_element): Remove.
5597         (union tui_which_element) <data>: Remove.
5598         <data_window>: Change type.
5599         (struct tui_data_item_window): New.
5600         * tui/tui-data.c (init_content_element): Remove DATA_ITEM_WIN
5601         case.  Add assert.
5602         (~tui_data_item_window): New destructor.
5603         (free_content_elements): Remove DATA_ITEM_WIN case.
5604
5605 2019-06-25  Tom Tromey  <tom@tromey.com>
5606
5607         * tui/tui.h (enum tui_win_type) <MAX_WINDOWS, UNDEFINED_WIN>:
5608         Remove.
5609
5610 2019-06-25  Tom Tromey  <tom@tromey.com>
5611
5612         * tui/tui-data.h (struct tui_command_element): Remove.
5613         (union tui_which_element) <command>: Remove.
5614         * tui/tui-data.c (init_content_element): Remove CMD_WIN case.  Add
5615         assert.
5616         (free_content_elements): Remove CMD_WIN case.
5617
5618 2019-06-25  Tom Tromey  <tom@tromey.com>
5619
5620         * tui/tui-layout.c (tui_set_layout): Update.
5621         * tui/tui-data.h (struct tui_layout_def) <split>: Remove.
5622         * tui/tui-data.c (layout_def): Update.
5623
5624 2019-06-25  Tom Tromey  <tom@tromey.com>
5625
5626         * tui/tui-wingeneral.c (tui_refresh_all): Update.
5627         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
5628         (tui_source_window_base::set_new_height): Update.
5629         * tui/tui-stack.c (tui_make_status_line): Change parameter type.
5630         Update.
5631         (tui_set_locator_fullname, tui_set_locator_info)
5632         (tui_show_frame_info): Update.
5633         * tui/tui-source.c (tui_set_source_content)
5634         (tui_source_is_displayed): Update.
5635         * tui/tui-layout.c (show_source_disasm_command, show_data)
5636         (show_source_or_disasm_and_command): Update.
5637         * tui/tui-disasm.c (tui_set_disassem_content)
5638         (tui_get_begin_asm_address): Update.
5639         * tui/tui-data.h (struct tui_locator_element): Remove.
5640         (union tui_which_element) <locator>: Remove.
5641         (struct tui_locator_window): New.
5642         (tui_locator_win_info_ptr): Change return type.
5643         * tui/tui-data.c (_locator): Change type.
5644         (tui_locator_win_info_ptr): Change return type.
5645         (init_content_element): Remove LOCATOR_WIN case.  Add assert.
5646         (tui_alloc_content): Add assert.
5647
5648 2019-06-25  Tom Tromey  <tom@tromey.com>
5649
5650         * tui/tui-winsource.c
5651         (tui_exec_info_window::maybe_allocate_content): New method.
5652         (tui_set_exec_info_content, tui_show_exec_info_content): Update.
5653         * tui/tui-layout.c (init_and_make_win): Add EXEC_INFO_WIN case.
5654         (make_source_or_disasm_window): Add cast.
5655         * tui/tui-data.h (union tui_which_element) <simple_string>:
5656         Remove.
5657         (struct tui_source_info): New.
5658         (struct tui_source_window_base) <execution_info>: Change type.
5659         * tui/tui-data.c (init_content_element): Remove EXEC_INFO_WIN
5660         case, and add assert.
5661         (tui_alloc_content): Add assert.
5662
5663 2019-06-25  Tom Tromey  <tom@tromey.com>
5664
5665         * tui/tui-data.h (tui_alloc_win_info): Don't declare.
5666         * tui/tui-layout.c (init_and_make_win): Use "new" directly.
5667         * tui/tui-data.c (tui_alloc_win_info): Remove.
5668
5669 2019-06-25  Tom Tromey  <tom@tromey.com>
5670
5671         * tui/tui-win.c (tui_set_win_focus_to): Don't check window type.
5672         * tui/tui-wingeneral.c (tui_unhighlight_win): Check
5673         can_highlight.
5674
5675 2019-06-25  Tom Tromey  <tom@tromey.com>
5676
5677         * tui/tui-win.c (tui_source_window_base::update_tab_width): Call
5678         make_visible_with_new_height method.
5679         (tui_win_info::make_visible_with_new_height): New method.
5680         (tui_source_window_base::do_make_visible_with_new_height)
5681         (tui_data_window::do_make_visible_with_new_height)
5682         (tui_cmd_window::do_make_visible_with_new_height): New methods.
5683         (make_visible_with_new_height): Remove.
5684         (tui_resize_all, tui_adjust_win_heights): Use
5685         make_visible_with_new_height method.
5686         * tui/tui-data.h (struct tui_win_info)
5687         <do_make_visible_with_new_height, make_visible_with_new_height>:
5688         New methods.
5689         (struct tui_source_window_base, struct tui_data_window)
5690         (struct tui_cmd_window) <do_make_visible_with_new_height>: New
5691         methods.
5692
5693 2019-06-25  Tom Tromey  <tom@tromey.com>
5694
5695         * tui/tui-win.c (tui_source_window_base::update_tab_width): New
5696         method.
5697         (update_tab_width): Call update_tab_width method.
5698         * tui/tui-data.h (struct tui_win_info)
5699         (struct tui_source_window_base) <update_tab_width>: New methods.
5700
5701 2019-06-25  Tom Tromey  <tom@tromey.com>
5702
5703         * tui/tui-wingeneral.h (tui_make_window): Change type of "box_it"
5704         parameter.
5705         * tui/tui-wingeneral.c (tui_make_window): Change type of "box_it"
5706         parameter.
5707         (tui_gen_win_info::make_visible): Update.
5708         * tui/tui-layout.c (init_and_make_win): Change type of "box_it"
5709         parameter.
5710         * tui/tui-data.h (enum tui_box): New enum.
5711         (BOX_WINDOW, DONT_BOX_WINDOW): Remove defines.
5712
5713 2019-06-25  Tom Tromey  <tom@tromey.com>
5714
5715         * tui/tui-layout.c (make_source_or_disasm_window): Always use
5716         init_and_make_win for EXEC_INFO_WIN.
5717         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>: No
5718         longer inline.
5719         (struct tui_win_info) <~tui_win_info>: Inline.
5720         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
5721         Don't declare.
5722         * tui/tui-data.c (source_win, disasm_win): Remove globals.
5723         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
5724         Remove.
5725         (tui_initialize_static_data): Update.
5726         (~tui_gen_win_info): Handle more cleanup here.
5727         (~tui_source_window_base): Delete "execution_info".
5728         (~tui_win_info): Move code to ~tui_gen_win_info; remove.
5729
5730 2019-06-25  Tom Tromey  <tom@tromey.com>
5731
5732         * tui/tui-layout.c (make_command_window): Don't set
5733         can_highlight.
5734         (show_source_disasm_command): Call the reset method.
5735         (show_data): Don't set can_highlight.  Call the reset method.
5736         (tui_gen_win_info::reset): Rename from init_gen_win_info
5737         (init_and_make_win): Simplify.  Return tui_gen_win_info.
5738         (show_source_or_disasm_and_command): Call the reset method.
5739         * tui/tui-data.h (struct tui_gen_win_info) <reset>: New method.
5740         (struct tui_cmd_window): Set can_highlight.
5741
5742 2019-06-25  Tom Tromey  <tom@tromey.com>
5743
5744         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Rename
5745         from make_visible.
5746         (tui_make_visible, tui_make_invisible): Rewrite.
5747         (tui_win_info::make_visible): Remove.
5748         (tui_source_window_base::make_visible): Update.
5749         * tui/tui-data.h (struct tui_gen_win_info) <make_visible>: New
5750         method.  Moved from...
5751         (struct tui_win_info) <make_visible>: ...here.
5752
5753 2019-06-25  Tom Tromey  <tom@tromey.com>
5754
5755         * tui/tui-winsource.c
5756         (tui_source_window_base::do_scroll_horizontal): Remove direction
5757         parameter.
5758         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Remove
5759         direction parameter.
5760         * tui/tui-win.c (tui_win_info::forward_scroll)
5761         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
5762         (tui_win_info::right_scroll): Update.
5763         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Remove
5764         direction parameter.
5765         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Remove
5766         direction parameter.
5767         * tui/tui-data.h (enum tui_scroll_direction): Remove.
5768         (struct tui_win_info) <do_scroll_vertical, do_scroll_horizontal>:
5769         Remove direction parameter.
5770         (struct tui_source_window_base, struct tui_source_window)
5771         (struct tui_disasm_window, struct tui_data_window)
5772         (struct tui_cmd_window): Update.
5773
5774 2019-06-25  Tom Tromey  <tom@tromey.com>
5775
5776         * tui/tui-winsource.h (tui_set_exec_info_content)
5777         (tui_show_exec_info_content, tui_erase_exec_info_content)
5778         (tui_clear_exec_info_content, tui_update_exec_info): Change
5779         argument to tui_source_window_base.
5780         * tui/tui-winsource.c (tui_set_exec_info_content)
5781         (tui_show_exec_info_content, tui_erase_exec_info_content)
5782         (tui_clear_exec_info_content, tui_update_exec_info): Change
5783         argument to tui_source_window_base.
5784
5785 2019-06-25  Tom Tromey  <tom@tromey.com>
5786
5787         * tui/tui-winsource.h (tui_set_exec_info_content): Return void.
5788         * tui/tui-winsource.c (tui_set_exec_info_content): Return void.
5789
5790 2019-06-25  Tom Tromey  <tom@tromey.com>
5791
5792         * tui/tui-winsource.c (tui_set_exec_info_content): Remove NULL
5793         check.
5794
5795 2019-06-25  Tom Tromey  <tom@tromey.com>
5796
5797         * tui/tui-winsource.h (tui_alloc_source_buffer): Change return
5798         type to void.
5799         * tui/tui-winsource.c (tui_alloc_source_buffer): Change return
5800         type to void.
5801         * tui/tui-source.c (tui_set_source_content): Update.
5802         * tui/tui-disasm.c (tui_set_disassem_content): Update.
5803
5804 2019-06-25  Tom Tromey  <tom@tromey.com>
5805
5806         * tui/tui-win.c (window_name_completer, tui_set_focus)
5807         (tui_all_windows_info): Use name method.
5808         * tui/tui-data.h (struct tui_gen_win_info)
5809         (struct tui_source_window, struct tui_disasm_window)
5810         (struct tui_data_window, struct tui_cmd_window) <name>: New
5811         method.
5812         (tui_win_name): Don't declare.
5813         * tui/tui-data.c (tui_partial_win_by_name): Use name method.
5814         (tui_win_name): Remove.
5815
5816 2019-06-25  Tom Tromey  <tom@tromey.com>
5817
5818         * tui/tui-winsource.h (tui_update_source_window)
5819         (tui_update_source_window_as_is): Change parameter type.
5820         * tui/tui-winsource.c (tui_update_source_window): Change win_info
5821         to be a tui_source_window_base.
5822         (tui_update_source_window_as_is): Likewise.
5823         * tui/tui-win.c (make_visible_with_new_height): Update.
5824
5825 2019-06-25  Tom Tromey  <tom@tromey.com>
5826
5827         * tui/tui-winsource.c (tui_erase_source_content)
5828         (tui_show_source_content, tui_show_exec_info_content)
5829         (tui_erase_exec_info_content): Use refresh_window method.
5830         * tui/tui-wingeneral.h (tui_refresh_win): Don't declare.
5831         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Rename
5832         from tui_refresh_win.
5833         (tui_data_window::refresh_window): New method.
5834         (tui_win_info::refresh, tui_source_window_base::refresh)
5835         (tui_refresh_all): Use refresh_window method.
5836         * tui/tui-stack.c (tui_show_locator_content): Call refresh_window
5837         method.
5838         * tui/tui-regs.c (tui_display_register): Call refresh_window
5839         method.
5840         * tui/tui-layout.c (show_source_disasm_command)
5841         (show_source_or_disasm_and_command): Call refresh_window method.
5842         * tui/tui-data.h (struct tui_gen_win_info)
5843         (struct tui_data_window, struct tui_cmd_window) <refresh_window>:
5844         New method.
5845
5846 2019-06-25  Tom Tromey  <tom@tromey.com>
5847
5848         * tui/tui.c (tui_rl_other_window, tui_enable)
5849         (tui_is_window_visible, tui_get_command_dimension): Update.
5850         * tui/tui-winsource.c (tui_update_source_window_as_is)
5851         (tui_clear_source_content, tui_erase_source_content)
5852         (tui_show_source_line, tui_source_window_base::refill)
5853         (tui_source_window_base::do_scroll_horizontal)
5854         (tui_source_window_base::set_is_exec_point_at)
5855         (tui_update_breakpoint_info, tui_set_exec_info_content)
5856         (tui_alloc_source_buffer, tui_line_is_displayed)
5857         (tui_addr_is_displayed): Update.
5858         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
5859         (tui_check_and_display_highlight_if_needed)
5860         (tui_win_info::make_visible, tui_win_info::refresh)
5861         (tui_refresh_all): Update.
5862         * tui/tui-windata.c (tui_first_data_item_displayed)
5863         (tui_delete_data_content_windows, tui_erase_data_content)
5864         (tui_display_all_data, tui_data_window::refresh_all)
5865         (tui_check_data_values): Update.
5866         * tui/tui-win.c (window_name_completer, tui_update_gdb_sizes)
5867         (tui_set_win_focus_to, tui_win_info::forward_scroll)
5868         (tui_win_info::backward_scroll, tui_refresh_all_win)
5869         (tui_resize_all, tui_set_focus, tui_all_windows_info)
5870         (update_tab_width, tui_set_win_height, tui_adjust_win_heights)
5871         (tui_source_window_base::set_new_height)
5872         (tui_data_window::set_new_height)
5873         (make_invisible_and_set_new_height)
5874         (make_visible_with_new_height, new_height_ok)
5875         (parse_scrolling_args): Update.
5876         * tui/tui-stack.c (tui_show_frame_info): Update.
5877         * tui/tui-source.c (tui_set_source_content)
5878         (tui_set_source_content_nil, tui_source_is_displayed)
5879         (tui_source_window::do_scroll_vertical): Update.
5880         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
5881         (tui_display_registers_from, tui_display_reg_element_at_line)
5882         (tui_check_register_values, tui_reg_command): Update.
5883         * tui/tui-layout.c (tui_default_win_height)
5884         (show_source_disasm_command, show_data, init_and_make_win)
5885         (show_source_or_disasm_and_command): Update.
5886         * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
5887         (tui_redisplay_readline, tui_mld_flush)
5888         (tui_mld_erase_entire_line, tui_mld_getc, tui_cont_sig)
5889         (tui_getc): Update.
5890         * tui/tui-disasm.c (tui_set_disassem_content)
5891         (tui_disasm_window::do_scroll_vertical): Update.
5892         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>:
5893         Now virtual.
5894         (struct tui_win_info): Derive from tui_gen_win_info.
5895         <~tui_win_info>: Mark as override.
5896         <generic>: Remove member.
5897         * tui/tui-data.c (tui_cmd_window::clear_detail, tui_next_win)
5898         (tui_prev_win, tui_partial_win_by_name, tui_win_info)
5899         (~tui_data_window, ~tui_win_info)
5900         (tui_free_all_source_wins_content): Update.
5901         * tui/tui-command.c (tui_refresh_cmd_win): Update.
5902
5903 2019-06-25  Tom Tromey  <tom@tromey.com>
5904
5905         * tui/tui-layout.c (init_and_make_win): Use new.
5906         * tui/tui-data.h (struct tui_gen_win_info): Add constructor,
5907         destructor, initializers.
5908         (tui_alloc_generic_win_info): Don't declare.
5909         * tui/tui-data.c (_locator): Add argument to constructor.
5910         (source_win, disasm_win): New globals.
5911         (exec_info): Remove.
5912         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
5913         Update.
5914         (tui_alloc_generic_win_info): Remove.
5915         (init_content_element): Use new.
5916         (tui_win_info::tui_win_info): Update.
5917         (free_content_elements) <case DATA_WIN>: Use delete.
5918
5919 2019-06-25  Tom Tromey  <tom@tromey.com>
5920
5921         * tui/tui-wingeneral.c (tui_refresh_win): Update.
5922         * tui/tui-windata.c (tui_first_data_item_displayed)
5923         (tui_delete_data_content_windows): Update.
5924         * tui/tui-win.c (tui_data_window::set_new_height): Update.
5925         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
5926         (tui_display_registers_from, tui_check_register_values): Update.
5927         * tui/tui-data.h (union tui_which_element) <data_window>: Now a
5928         pointer.
5929         * tui/tui-data.c (init_content_element): Update.  Allocate the new
5930         window.
5931         (tui_free_data_content): Update.
5932         (free_content_elements) <case DATA_WIN>: Free the window.
5933
5934 2019-06-25  Tom Tromey  <tom@tromey.com>
5935
5936         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win):
5937         Update.
5938         * tui/tui-layout.c (make_command_window)
5939         (show_source_disasm_command, show_data, init_and_make_win)
5940         (show_source_or_disasm_and_command): Update.
5941         * tui/tui-data.h (struct tui_win_info) <set_highlight>: New
5942         method.
5943         <can_highight, is_highlighted>: Now bool.
5944         (tui_set_win_highlight): Don't declare.
5945         * tui/tui-data.c (tui_set_win_highlight): Remove.
5946
5947 2019-06-25  Tom Tromey  <tom@tromey.com>
5948
5949         * tui/tui-wingeneral.c (make_visible): Remove check of window
5950         type.
5951
5952 2019-06-25  Tom Tromey  <tom@tromey.com>
5953
5954         * tui/tui-win.c (tui_win_info::max_height)
5955         (tui_cmd_window::max_height): New methods.
5956         (new_height_ok): Call max_height.
5957         * tui/tui-data.h (struct tui_win_info, struct tui_cmd_window)
5958         <max_height>: New method.
5959
5960 2019-06-25  Tom Tromey  <tom@tromey.com>
5961
5962         * tui/tui-win.c (tui_source_window_base::set_new_height)
5963         (tui_data_window::set_new_height): New methods.
5964         (make_invisible_and_set_new_height): Call set_new_height method.
5965         * tui/tui-data.h (struct tui_win_info)
5966         (struct tui_source_window_base, struct tui_data_window)
5967         <set_new_height>: New method.
5968
5969 2019-06-25  Tom Tromey  <tom@tromey.com>
5970
5971         * tui/tui.c (tui_rl_other_window): Call the refresh_all method.
5972         * tui/tui-windata.c (tui_data_window::refresh_all): Rename from
5973         tui_refresh_data_win.
5974         * tui/tui-win.c (tui_source_window_base::refresh_all): New
5975         method.
5976         (tui_refresh_all_win): Call the refresh_all method.
5977         (tui_set_focus): Likewise.
5978         * tui/tui-data.h (struct tui_win_info) <refresh_all>: New method.
5979         (struct tui_source_window_base, struct tui_data_window) <refresh>:
5980         Likewise.
5981
5982 2019-06-25  Tom Tromey  <tom@tromey.com>
5983
5984         * tui/tui-winsource.h (tui_refill_source_window)
5985         (tui_set_is_exec_point_at): Don't declare.
5986         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
5987         (tui_source_window_base::refill): Rename from
5988         tui_refill_source_window.
5989         (tui_source_window_base::do_scroll_horizontal): Update.
5990         (tui_source_window_base::set_is_exec_point_at): Rename from
5991         tui_set_is_exec_point_at.
5992         (tui_update_all_breakpoint_info): Update.
5993         * tui/tui-stack.c (tui_show_frame_info): Update.
5994         * tui/tui-layout.c (show_data): Add cast.
5995         * tui/tui-hooks.c (tui_redisplay_source): Call refill method.
5996         * tui/tui-data.h (struct tui_source_window_base) <refill,
5997         set_is_exec_point_at>: New methods.
5998         (tui_source_windows, tui_add_to_source_windows): Update types.
5999         (tui_add_to_source_windows): Remove redundant declaration.
6000         * tui/tui-data.c (source_windows): Store tui_source_window_base.
6001         (tui_source_windows): Change return type.
6002         (tui_clear_source_windows_detail): Update.
6003         (tui_add_to_source_windows): Change type of parameter.
6004         (tui_free_all_source_wins_content): Update.
6005
6006 2019-06-25  Tom Tromey  <tom@tromey.com>
6007
6008         * tui/tui-wingeneral.c (tui_win_info::refresh)
6009         (tui_source_window_base::refresh): New methods.
6010         (tui_refresh_all): Call the refresh method.
6011         * tui/tui-data.h (struct tui_win_info)
6012         (struct tui_source_window_base) <refresh>: New method.
6013
6014 2019-06-25  Tom Tromey  <tom@tromey.com>
6015
6016         * tui/tui.h (tui_is_window_visible): Return bool.
6017         * tui/tui.c (tui_is_window_visible): Return bool.
6018         * tui/tui-wingeneral.c (tui_make_window, make_visible)
6019         (tui_make_visible, tui_make_invisible)
6020         (tui_win_info::make_visible)
6021         (tui_source_window_base::make_visible, make_all_visible)
6022         (tui_make_all_visible, tui_make_all_invisible): Update.
6023         * tui/tui-windata.c (tui_delete_data_content_windows): Update.
6024         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: Now
6025         bool.
6026         (struct tui_win_info, struct tui_source_window_base)
6027         (struct tui_cmd_window) <make_visible>: Change parameter to bool.
6028         * tui/tui-data.c (tui_init_generic_part): Update.
6029
6030 2019-06-25  Tom Tromey  <tom@tromey.com>
6031
6032         * tui/tui-wingeneral.c (tui_win_info::make_visible)
6033         (tui_source_window_base::make_visible): New methods.
6034         (make_all_visible): Make method call.
6035         * tui/tui-data.h (struct tui_win_info) <make_visible>: New method.
6036         (struct tui_source_window_base, struct tui_cmd_window): Override
6037         make_visible.
6038         (tui_win_is_source_type): Don't declare.
6039         * tui/tui-data.c (tui_win_is_source_type): Remove.
6040
6041 2019-06-25  Tom Tromey  <tom@tromey.com>
6042
6043         * tui/tui-layout.c (show_source_or_disasm_and_command): Remove
6044         NULL check.
6045
6046 2019-06-25  Tom Tromey  <tom@tromey.com>
6047
6048         * tui/tui-data.h (struct tui_data_window, struct tui_cmd_window):
6049         Inline constructor.  Add initializers for members.
6050         * tui/tui-data.c (tui_data_window, tui_cmd_window): Remove
6051         constructors; now inline in class.
6052
6053 2019-06-25  Tom Tromey  <tom@tromey.com>
6054
6055         * tui/tui-regs.c (tui_show_registers): Update.
6056         * tui/tui-data.h (struct tui_data_window) <display_regs>: Now
6057         bool.
6058         * tui/tui-data.c (tui_data_window::clear_detail)
6059         (tui_data_window): Update.
6060
6061 2019-06-25  Tom Tromey  <tom@tromey.com>
6062
6063         * tui/tui-windata.c (tui_display_all_data)
6064         (tui_display_data_from_line, tui_display_data_from)
6065         (tui_check_data_values, tui_data_window::do_scroll_vertical):
6066         Update.
6067         * tui/tui-regs.c (tui_last_regs_line_no)
6068         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
6069         (tui_show_registers, tui_show_register_group)
6070         (tui_display_registers_from, tui_display_reg_element_at_line)
6071         (tui_display_registers_from_line, tui_check_register_values)
6072         (tui_reg_next, tui_reg_prev): Update.
6073         * tui/tui-layout.c (tui_set_layout, show_data): Update.
6074         * tui/tui-data.h (struct tui_data_info): Remove.  Move contents to
6075         tui_data_window.
6076         (struct tui_win_info) <detail>: Remove.  Add new fields from
6077         tui_data_info.
6078         (TUI_DATA_WIN): Add cast.
6079         * tui/tui-data.c (tui_data_window::clear_detail, tui_data_window)
6080         (~tui_data_window): Simplify.
6081
6082 2019-06-25  Tom Tromey  <tom@tromey.com>
6083
6084         * tui/tui-layout.c (show_source_disasm_command)
6085         (show_source_or_disasm_and_command): Update.
6086         * tui/tui-io.c (update_cmdwin_start_line)
6087         (tui_redisplay_readline): Update.
6088         * tui/tui-data.h (struct tui_command_info): Remove.
6089         (struct tui_win_info) <detail>: Remove command_info member.
6090         (struct tui_data_window) <start_line>: New member, from
6091         tui_command_info.
6092         (TUI_CMD_WIN): Add casts.
6093
6094 2019-06-25  Tom Tromey  <tom@tromey.com>
6095
6096         * tui/tui-winsource.c (tui_update_source_window)
6097         (tui_refill_source_window)
6098         (tui_source_window_base::do_scroll_horizontal)
6099         (tui_update_breakpoint_info, tui_set_exec_info_content)
6100         (tui_show_exec_info_content, tui_erase_exec_info_content)
6101         (tui_clear_exec_info_content): Update.
6102         * tui/tui-wingeneral.c (make_all_visible, tui_refresh_all):
6103         Update.
6104         * tui/tui-win.c (make_invisible_and_set_new_height)
6105         (make_visible_with_new_height): Update.
6106         * tui/tui-source.c (tui_set_source_content)
6107         (tui_show_symtab_source): Update.
6108         * tui/tui-layout.c (extract_display_start_addr)
6109         (show_source_disasm_command, show_data)
6110         (make_source_or_disasm_window)
6111         (show_source_or_disasm_and_command): Update.
6112         * tui/tui-disasm.c (tui_set_disassem_content): Simplify.
6113         (tui_disasm_window::do_scroll_vertical): Remove shadowing
6114         "gdbarch".
6115         * tui/tui-data.h (struct tui_source_info): Remove.  Move contents
6116         to tui_source_window_base.
6117         (struct tui_win_info) <detail>: Remove source_info member.
6118         (struct tui_source_window_base) <has_locator>: Inline.
6119         Move contents from tui_source_info; rename has_locator member to
6120         m_has_locator.
6121         (TUI_SRC_WIN, TUI_DISASM_WIN): Add casts.
6122         * tui/tui-data.c (tui_source_window_base::has_locator): Move to
6123         header file.
6124         (tui_source_window_base::clear_detail, ~tui_source_window_base):
6125         Simplify.
6126         (tui_free_all_source_wins_content): Cast to
6127         tui_source_window_base.
6128
6129 2019-06-25  Tom Tromey  <tom@tromey.com>
6130
6131         * tui/tui-win.c (make_invisible_and_set_new_height)
6132         (make_visible_with_new_height): Call has_locator method.
6133         * tui/tui-layout.c (show_source_disasm_command, show_data)
6134         (show_source_or_disasm_and_command): Update for bool change.
6135         * tui/tui-data.h (struct tui_source_info) <has_locator>: Now bool.
6136         (tui_win_info) <has_locator>: New method.
6137         (struct tui_source_window_base) <has_locator>: New method.
6138         (tui_win_has_locator): Don't declare.
6139         * tui/tui-data.c (tui_source_window_base::has_locator): Rename
6140         from tui_win_has_locator.
6141         (tui_source_window_base): Use false, not FALSE.
6142
6143 2019-06-25  Tom Tromey  <tom@tromey.com>
6144
6145         * tui/tui-data.h (tui_clear_win_detail): Don't declare.
6146         * tui/tui-data.c (tui_clear_source_windows_detail): Call the
6147         clear_detail method directly.
6148         (tui_clear_win_detail): Remove.
6149
6150 2019-06-25  Tom Tromey  <tom@tromey.com>
6151
6152         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Use
6153         "this", not TUI_DISASM_WIN.
6154
6155 2019-06-25  Tom Tromey  <tom@tromey.com>
6156
6157         * tui/tui-winsource.h (tui_horizontal_source_scroll):  Don't
6158         declare.
6159         * tui/tui-winsource.c
6160         (tui_source_window_base::do_scroll_horizontal): Rename from
6161         tui_horizontal_source_scroll.
6162         * tui/tui-windata.h (tui_vertical_data_scroll): Don't declare.
6163         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Rename
6164         from tui_vertical_data_scroll.
6165         * tui/tui-win.h (tui_scroll): Don't declare.
6166         * tui/tui-win.c (tui_win_info::forward_scroll)
6167         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
6168         (tui_win_info::right_scroll): Rename and update.
6169         (tui_scroll_forward_command, tui_scroll_backward_command)
6170         (tui_scroll_left_command, tui_scroll_right_command): Update.
6171         (tui_scroll): Remove.
6172         * tui/tui-source.h: Don't declare tui_vertical_source_scroll.
6173         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Rename
6174         from tui_vertical_source_scroll.
6175         * tui/tui-disasm.h (tui_vertical_disassem_scroll): Don't declare.
6176         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Rename
6177         from tui_vertical_disassem_scroll.
6178         * tui/tui-data.h (struct tui_win_info) <do_scroll_vertical,
6179         do_scroll_horizontal>: New methods.
6180         <forward_scroll, backward_scroll, left_scroll, right_scroll>:
6181         Likewise.
6182         (struct tui_source_window_base): Add do_scroll_horizontal.
6183         (struct tui_source_window, struct tui_disasm_window): Add
6184         do_scroll_vertical.
6185         (struct tui_data_window, struct tui_cmd_window): Add
6186         do_scroll_horizontal and do_scroll_vertical.
6187         * tui/tui-command.c (tui_dispatch_ctrl_char): Use method calls.
6188
6189 2019-06-25  Tom Tromey  <tom@tromey.com>
6190
6191         * tui/tui-data.h (struct tui_source_window_base): New struct.
6192         (struct tui_source_window): Derive from tui_source_window_base.
6193         (struct tui_disasm_window): New struct.
6194         * tui/tui-data.c (tui_source_window_base::clear_detail): Rename
6195         from tui_source_window::clear_detail.
6196         (tui_source_window_base): Rename from tui_source_window.
6197         (~tui_source_window_base): Rename from ~tui_source_window.
6198         (tui_alloc_win_info): Create a tui_disasm_window.
6199
6200 2019-06-25  Tom Tromey  <tom@tromey.com>
6201
6202         * tui/tui-data.h (struct tui_source_window)
6203         (struct tui_data_window): Declare destructors.
6204         * tui/tui-data.c (~tui_source_window, ~tui_data_window): New
6205         destructors.
6206         (tui_win_info): Simplify.
6207
6208 2019-06-25  Tom Tromey  <tom@tromey.com>
6209
6210         * tui/tui-winsource.c (tui_display_main)
6211         (tui_update_source_windows_with_addr)
6212         (tui_update_all_breakpoint_info): Update.
6213         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
6214         (new_height_ok, parse_scrolling_args): Update.
6215         * tui/tui-stack.c (tui_show_frame_info): Update.
6216         * tui/tui-data.h (struct tui_list): Remove.
6217         (tui_source_windows): Return a reference to a std::vector.
6218         * tui/tui-data.c (source_windows): Now a std::vector.
6219         (tui_source_windows): Change return type.
6220         (tui_clear_source_windows): Rewrite.
6221         (tui_clear_source_windows_detail, tui_add_to_source_windows)
6222         (tui_free_all_source_wins_content): Rewrite.
6223
6224 2019-06-25  Tom Tromey  <tom@tromey.com>
6225
6226         * tui/tui-data.h (struct tui_win_info, struct tui_source_window)
6227         (struct tui_data_window, struct tui_cmd_window): Declare
6228         clear_detail method.
6229         * tui/tui-data.c (tui_source_window::clear_detail)
6230         (tui_cmd_window::clear_detail, tui_data_window::clear_detail): New
6231         methods.
6232         (tui_clear_win_detail): Simplify.
6233
6234 2019-06-25  Tom Tromey  <tom@tromey.com>
6235
6236         * tui/tui-layout.c (make_source_window, make_disasm_window)
6237         (make_source_or_disasm_window): Remove win_info_ptr parameter.
6238         Return the new window.
6239         (show_source_disasm_command, show_data)
6240         (show_source_or_disasm_and_command): Update.
6241
6242 2019-06-25  Tom Tromey  <tom@tromey.com>
6243
6244         * tui/tui-layout.c (make_command_window): Remove win_info_ptr
6245         parameter.  Return the new window.
6246         (show_source_disasm_command): Update and remove NULL check.
6247         (show_source_or_disasm_and_command): Update.
6248
6249 2019-06-25  Tom Tromey  <tom@tromey.com>
6250
6251         * tui/tui-layout.c (init_and_make_win): Remove NULL check.
6252
6253 2019-06-25  Tom Tromey  <tom@tromey.com>
6254
6255         * tui/tui-data.h (struct tui_win_info): Make constructor
6256         protected.  Make destructor virtual.  Add initializers.
6257         (tui_source_window, tui_data_window, tui_cmd_window): New
6258         classes.
6259         * tui/tui-data.c (tui_win_info): Rename from init_win_info.  Now a
6260         constructor.  Add "type" parameter.
6261         (tui_source_window, tui_data_window, tui_cmd_window): New
6262         constructors.
6263         (tui_alloc_win_info): Instantiate the appropriate subclass.
6264
6265 2019-06-25  Tom Tromey  <tom@tromey.com>
6266
6267         * tui/tui-win.c (tui_resize_all): Use delete.
6268         * tui/tui-data.h (struct tui_win_info) <~tui_win_info>: Declare
6269         destructor.
6270         (tui_free_window): Don't declare.
6271         * tui/tui-data.c (~tui_win_info): Rename from tui_free_window.
6272         Update.
6273
6274 2019-06-25  Tom Tromey  <tom@tromey.com>
6275
6276         * tui/tui-data.h (struct tui_win_info): Add constructor.
6277         * tui/tui-data.c (tui_alloc_win_info): Use new.
6278         (tui_free_window): Use delete.
6279
6280 2019-06-22  Tom Tromey  <tom@tromey.com>
6281
6282         * tui/tui-windata.h (tui_first_data_element_no_in_line): Don't
6283         declare.
6284         * tui/tui-windata.c (tui_first_data_element_no_in_line): Remove.
6285
6286 2019-06-22  Tom Tromey  <tom@tromey.com>
6287
6288         * tui/tui-data.h (tui_del_window, tui_del_data_windows): Don't
6289         declare.
6290         * tui/tui-data.c (tui_del_window, tui_del_data_windows): Remove.
6291
6292 2019-06-22  Tom de Vries  <tdevries@suse.de>
6293
6294         * dwarf2read.c (create_addrmap_from_aranges)
6295         (read_debug_names_from_section): Print ptrdiff_t using '%s' and plongest
6296         instead of '%zu'.
6297
6298 2019-06-21  Simon Marchi  <simon.marchi@efficios.com>
6299
6300         * dwarf2read.h (dwarf2_section_info_def): Remove.
6301         (DEF_VEC_O (dwarf2_section_info_def)): Remove.
6302         * dwarf2read.c (struct dwo_sections) <types>: Change type to
6303         std::vector<dwarf2_section_info>.
6304         (struct dwo_file) <~dwo_file>: Remove.
6305         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't manually free
6306         types field.
6307         (dwarf2_per_objfile::locate_sections): Adjust to std::vector.
6308         (dwarf2_read_debug_names): Likewise.
6309         (create_debug_types_hash_table): Change parameter type to
6310         array_view, adjust code accordingly.
6311         (dwarf2_locate_dwo_sections): Adjust to std::vector.
6312         (partial_die_info::fixup): Likewise.
6313         (determine_prefix): Likewise.
6314         * dwarf-index-write.c (write_psymtabs_to_index): Adjust.
6315
6316 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
6317
6318         * dwarf2read.c (struct dwo_file) <dbfd>: Change type to
6319         gdb_bfd_ref_ptr.
6320         <~dwo_file>: Remove call to gdb_bfd_unref.
6321         (open_and_init_dwo_file): Move gdb_bfd_ref_ptr into dbfd field. Call
6322         gdb_bfd_ref_ptr::get.
6323
6324 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
6325
6326         * dwarf2read.h (struct dwarf2_per_objfile) <dwo_files>: Change
6327         type to htab_up.
6328         * dwarf2read.c (struct dwo_file): Initialize fields.
6329         <~dwo_file>: New.
6330         (free_dwo_file): Remove, move content to ~dwo_file.
6331         (struct dwo_file_deleter): Remove.
6332         (dwo_file_up>: Remove custom deleter.
6333         (free_dwo_files): Remove.
6334         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't explicitly free
6335         dwo_files.
6336         (process_skeletonless_type_units): Call unique_ptr::get.
6337         (allocate_dwo_file_hash_table): Add deleter to created hash
6338         table.  Change return type to htab_up.
6339         (lookup_dwo_file_slot): Don't memset dwo_file, call
6340         unique_ptr::get.
6341         (create_dwo_unit_in_dwp_v1): Allocate dwo_file with new.
6342         (create_dwo_unit_in_dwp_v2): Likewise.
6343         (open_and_init_dwo_file): Likewise.
6344         (free_dwo_file_from_slot): Remove.
6345
6346 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
6347
6348         * dwarf2read.h (struct dwarf2_section_info) <readin,
6349         is_virtual>: Change type to bool.
6350         * dwarf2read.c (dwarf2_read_section, create_dwp_v2_section): Use
6351         true instead of 1.
6352
6353 2019-06-19  Tom Tromey  <tom@tromey.com>
6354
6355         * tui/tui-data.h (tui_init_content_element): Don't declare.
6356
6357 2019-06-19  Tom Tromey  <tom@tromey.com>
6358
6359         * tui/tui-data.h (tui_init_win_info): Don't declare.
6360
6361 2019-06-19  Tom de Vries  <tdevries@suse.de>
6362
6363         * dwarf2read.h (abstract_to_concrete): Change type to
6364         std::unordered_map<sect_offset, std::vector<sect_offset>,
6365         gdb::hash_enum<sect_offset>>.
6366
6367 2019-06-19  Tom Tromey  <tromey@adacore.com>
6368
6369         * ada-lang.c (ada_evaluate_subexp) <case OP_ATR_FIRST>: Handle
6370         EVAL_AVOID_SIDE_EFFECTS specially.
6371
6372 2019-06-19  Tom Tromey  <tromey@adacore.com>
6373
6374         * source-cache.c (highlighter): New global.
6375         (source_cache::get_source_lines): Create a highlighter on demand.
6376
6377 2019-06-18  Andrew Burgess  <andrew.burgess@embecosm.com>
6378
6379         * defs.h (deprecated_interactive_hook): Delete declaration.
6380         * interps.c (clear_interpreter_hooks): Remove use of
6381         deprecated_interactive_hook.
6382         * top.c (deprecated_interactive_hook): Delete definition.
6383         * utils.c (maybe_quit): Remove use of deprecated_interactive_hook.
6384
6385 2019-06-18  Tom de Vries  <tdevries@suse.de>
6386
6387         PR gdb/24515
6388         * dwarf2read.h (abstract_to_concrete): Change type from
6389         std::unordered_map<die_info_ptr, std::vector<die_info_ptr>> to
6390         std::unordered_map<sect_offset, std::vector<sect_offset>>.
6391         * dwarf2read.c (read_variable): Update.
6392         (dwarf2_fetch_die_loc_sect_off): Update.
6393
6394 2019-06-17  Tom de Vries  <tdevries@suse.de>
6395
6396         PR gdb/24617
6397         * common/pathstuff.c (child_path): Make sure parent_len > 0 before
6398         accessing parent[parent_len - 1].
6399
6400 2019-06-17  Paul Pluzhnikov  <ppluzhnikov@google.com>
6401
6402         PR gdb/24364
6403         * gdb/dtrace-probe.c (dtrace_static_probe_ops::get_probe): Don't
6404         call dtrace_process_dof with NULL dof.
6405
6406 2019-06-16  Tom de Vries  <tdevries@suse.de>
6407
6408         PR gdb/24445
6409         * contrib/gdb-add-index.sh: Update to handle dwz-m-ed executable.
6410
6411 2019-06-16  Tom Tromey  <tom@tromey.com>
6412
6413         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
6414         (make_all_visible): Use address of member.
6415
6416 2019-06-16  Tom Tromey  <tom@tromey.com>
6417
6418         * tui/tui-data.c (tui_clear_win_detail, init_win_info)
6419         (tui_free_window, free_content, free_content_elements): Remove
6420         unnecessary cast.
6421         * tui/tui-windata.c (tui_display_all_data): Remove unnecessary
6422         cast.
6423         * tui/tui-regs.c (tui_show_register_group)
6424         (tui_display_registers_from, tui_display_reg_element_at_line):
6425         Remove unnecessary cast.
6426
6427 2019-06-16  Andrew Burgess  <andrew.burgess@embecosm.com>
6428
6429         * linux-nat.c (normal_mask): Delete.
6430         (_initialize_linux_nat): Don't initialise normal_mask.
6431
6432 2019-06-16  Simon Marchi  <simon.marchi@polymtl.ca>
6433
6434         PR gdb/24445
6435         * dwarf-index-write.h (write_psymtabs_to_index): Add
6436         dwz_basename parameter.
6437         * dwarf-index-write.c (write_gdbindex): Move file writing to
6438         write_gdbindex_1.  Change return type void.
6439         (assert_file_size): Move up, remove filename parameter.
6440         (write_gdbindex_1): New function.
6441         (write_debug_names): Change return type to void, call
6442         assert_file_size.
6443         (struct index_wip_file): New struct.
6444         (write_psymtabs_to_index): Add dwz_basename parameter.  Move
6445         file logic to index_wip_file.  Write index for dwz file if
6446         needed.
6447         (save_gdb_index_command): Pass basename of dwz file, if present.
6448         * dwarf-index-cache.c (index_cache::store): Obtain and pass
6449         build-id of dwz file, if present.
6450         * dwarf2read.c (struct dwz_file): Move to dwarf2read.h.
6451         (dwarf2_get_dwz_file): Likewise.
6452         * dwarf2read.h (struct dwz_file): Move from dwarf2read.c.
6453         (dwarf2_get_dwz_file): Likewise.
6454
6455 2019-06-16  Tom Tromey  <tom@tromey.com>
6456
6457         * coffread.c (process_coff_symbol): Use xstrdup.
6458         * value.c (create_internalvar): Use xstrdup.
6459
6460 2019-06-16  Tom Tromey  <tom@tromey.com>
6461
6462         * valops.c (value_cast, value_slice): Remove unnecessary cast.
6463         * breakpoint.c (stopin_command, stopat_command)
6464         (until_break_command, decode_location_default): Remove unnecessary
6465         cast.
6466         * utils.c (subset_compare): Remove unnecessary cast.
6467         * ada-lang.c (ada_update_initial_language): Remove unnecessary
6468         cast.
6469         * linespec.c (decode_line_with_last_displayed): Remove unnecessary
6470         cast.
6471         * infcmd.c (path_command): Remove unnecessary cast.
6472         * coffread.c (decode_type): Remove unnecessary cast.
6473         * xcoffread.c (read_xcoff_symtab): Remove unnecessary cast.
6474         * mipsread.c (mipscoff_symfile_read): Remove unnecessary cast.
6475         * tui/tui-stack.c (tui_show_locator_content)
6476         (tui_show_frame_info): Remove unnecessary cast.
6477         * tui/tui-win.c (tui_scroll_forward_command)
6478         (tui_scroll_backward_command, tui_set_focus, tui_set_win_height)
6479         (parse_scrolling_args): Remove unnecessary cast.
6480         * tui/tui-data.c (init_win_info, tui_del_window)
6481         (tui_free_window, tui_del_data_windows, tui_free_data_content)
6482         (free_content_elements): Remove unnecessary cast.
6483         * tui/tui-windata.c (tui_first_data_item_displayed): Remove
6484         unnecessary cast.
6485         * tui/tui-source.c (tui_set_source_content)
6486         (tui_vertical_source_scroll): Remove unnecessary cast.
6487         * tui/tui-layout.c (tui_default_win_height): Remove unnecessary
6488         cast.
6489         * tui/tui-io.c (tui_initialize_io): Remove unnecessary cast.
6490         * tui/tui-regs.c (tui_display_registers_from)
6491         (tui_display_register): Remove unnecessary cast.
6492         * tui/tui-wingeneral.c (tui_refresh_win, tui_delete_win)
6493         (tui_unhighlight_win, tui_highlight_win, tui_make_window)
6494         (make_visible): Remove unnecessary cast.
6495         * tui/tui-winsource.c (tui_erase_source_content)
6496         (tui_update_breakpoint_info, tui_set_exec_info_content): Remove
6497         unnecessary cast.
6498         * ax-gdb.c (agent_command_1): Remove unnecessary cast.
6499         * cli/cli-setshow.c (cmd_show_list): Remove unnecessary cast.
6500         * stabsread.c (read_type, read_array_type, read_range_type):
6501         Remove unnecessary cast.
6502         * mdebugread.c (mdebug_build_psymtabs): Remove unnecessary cast.
6503         (parse_symbol, parse_type, upgrade_type, parse_external)
6504         (parse_partial_symbols, psymtab_to_symtab_1, cross_ref): Remove
6505         unnecessary cast.
6506         * gdb_bfd.c (gdb_bfd_map_section): Remove unnecessary cast.
6507
6508 2019-06-16  Tom Tromey  <tom@tromey.com>
6509
6510         * tui/tui-data.c (tui_alloc_generic_win_info)
6511         (tui_alloc_win_info, tui_add_content_elements): Remove NULL
6512         checks.
6513
6514 2019-06-16  Bernhard Heckel  <bernhard.heckel@intel.com>
6515             Andrew Burgess  <andrew.burgess@embecosm.com>
6516
6517         * f-typeprint.c (f_print_type): Don't return early for not
6518         associated or not allocated types.
6519         (f_type_print_varspec_suffix): Add print_rank parameter and print
6520         ranks of array types in case they dangling.
6521         (f_type_print_base): Add print_rank parameter.
6522
6523 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
6524
6525         * NEWS: Mention new MI commands.
6526         * break-catch-throw.c (enum exception_event_kind): Move to
6527         breakpoint.h.
6528         (print_mention_exception_catchpoint): Output text as a single
6529         message.
6530         (catch_exception_command_1): Rename to...
6531         (catch_exception_event): ...this, make non-static, update header
6532         command, and change some parameter types.
6533         (catch_catch_command): Update for changes to
6534         catch_exception_command_1.
6535         (catch_throw_command): Likewise.
6536         (catch_rethrow_command): Likewise.
6537         * breakpoint.c (enum exception_event_kind): Delete.
6538         * breakpoint.h (enum exception_event_kind): Moved here from
6539         break-catch-throw.c.
6540         (catch_exception_event): Declare.
6541         * mi/mi-cmd-catch.c (mi_cmd_catch_exception_event): New function.
6542         (mi_cmd_catch_throw): New function.
6543         (mi_cmd_catch_rethrow): New function.
6544         (mi_cmd_catch_catch): New function.
6545         * mi/mi-cmds.c (mi_cmds): Add 'catch-throw', 'catch-rethrow', and
6546         'catch-catch' entries.
6547         * mi/mi-cmds.h (mi_cmd_catch_throw): Declare.
6548         (mi_cmd_catch_rethrow): Declare.
6549         (mi_cmd_catch_catch): Declare.
6550
6551 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
6552
6553         * annotate.c (annotate_source_line): Change return type to void,
6554         update implementation to match.
6555         * annotate.h (annotate_source_line): Change return type to void,
6556         update header comment.
6557         * stack.c (print_frame_info): Don't change what frame information
6558         is printed based on whether annotations are on or not.
6559
6560 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
6561
6562         * annotate.c: Add 'source.h' and 'objfiles.h' includes.
6563         (annotate_source): Make static.
6564         (annotate_source_line): Moved from source.c and renamed from
6565         identify_source_line.  Update the return type.
6566         * annotate.h (annotate_source): Delete declaration.
6567         (annotate_source_line): Declaration moved from source.h, and
6568         renamed from identify_source_line.  Return type updated.
6569         * source.c (identify_source_line): Moved to annotate.c and renamed
6570         to annotate_source_line.
6571         (info_line_command): Remove check of annotation_level.
6572         * source.h (identify_source_line): Move declaration to annotate.h
6573         and rename to annotate_source_line.
6574         * stack.c: Add 'annotate.h' include.
6575         (print_frame_info): Remove check of annotation_level before
6576         calling annotate_source_line.
6577
6578 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
6579
6580         * source-cache.c (source_cache::get_plain_source_lines): Use
6581         open_source_file_with_line_charpos instead of just
6582         open_source_file, remove call to find_source_lines.
6583         (source_cache::get_source_lines): Likewise.
6584         * source.c (find_source_lines): Make static.
6585         (get_filename_and_charpos): Renamed into...
6586         (open_source_file_with_line_charpos): ..this along with changes to
6587         return a scoped_fd, and some other minor clean ups.
6588         (identify_source_line): Use open_source_file_with_line_charpos.
6589         (search_command_helper): Use open_source_file_with_line_charpos
6590         instead of just open_source_file, remove call to
6591         find_source_lines.
6592         * source.h (open_source_file_with_line_charpos): Declare new
6593         function.
6594         (find_source_lines): Delete declaration.
6595
6596 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
6597
6598         * source.c (get_filename_and_charpos): Remove fullname
6599         parameter.
6600         (identify_source_line): Update call to get_filename_and_charpos.
6601
6602 2019-06-14  Tom Tromey  <tromey@adacore.com>
6603
6604         PR gdb/24502:
6605         * ui-style.h (skip_ansi_escape): Update comment.
6606         * ui-file.h (class no_terminal_escape_file): New class.
6607         * ui-file.c (no_terminal_escape_file::write)
6608         (no_terminal_escape_file::puts): New methods.
6609         * cli/cli-logging.c (handle_redirections): Use
6610         no_terminal_escape_file.
6611
6612 2019-06-14  Tom Tromey  <tromey@adacore.com>
6613
6614         * NEWS: Move convenience variable news above Python news.
6615
6616 2019-06-14  Tom Tromey  <tom@tromey.com>
6617
6618         * gnulib: Move directory to top-level.
6619         * configure.ac: Don't configure gnulib.
6620         * configure: Rebuild.
6621         * common/common-defs.h: Use new path to gnulib.
6622         * Makefile.in (GNULIB_BUILDDIR): Now ../gnulib.
6623         (GNULIB_H): Remove.
6624         (INCGNU): Look in new gnulib location.
6625         (HFILES_NO_SRCDIR): Remove gnulib files.
6626         (SUBDIR, REQUIRED_SUBDIRS): Remove gnulib.
6627         (generated_files): Remove GNULIB_H.
6628         ($(LIBGNU), all-lib): Remove targets.
6629         (distclean): Don't mention GNULIB_BUILDDIR.
6630         ($(GNULIB_BUILDDIR)/Makefile): Remove target.
6631
6632 2019-06-14  Tom Tromey  <tromey@adacore.com>
6633
6634         * symfile.c (add_symbol_file_command): Remove obsolete comment.
6635         Warn if symbol file does not provide any symbols.
6636
6637 2019-06-14  Tom Tromey  <tromey@adacore.com>
6638
6639         * source.c (find_and_open_source): Respect basenames_may_differ.
6640
6641 2019-06-14  Andrew Burgess  <andrew.burgess@embecosm.com>
6642
6643         * annotate.c (annotate_breakpoints_invalid): Make use of
6644         scoped_restore_terminal_state.
6645         (annotate_frames_invalid): Likewise.
6646
6647 2019-06-14  Tom Tromey  <tromey@adacore.com>
6648
6649         * ada-lang.c (ada_evaluate_subexp) <case BINOP_ASSIGN>: Always
6650         allow assignment to an internalvar.
6651
6652 2019-06-14  Tom Tromey  <tromey@adacore.com>
6653
6654         * ada-lex.l: Allow "_" in attribute names.
6655
6656 2019-06-14  Tom Tromey  <tromey@adacore.com>
6657
6658         PR gdb/24653:
6659         * regcache.c (registers_changed): Don't call alloca.
6660         * top.c (execute_command): Don't call alloca.
6661
6662 2019-06-13  Pedro Alves  <palves@redhat.com>
6663
6664         * cli/cli-setshow.c (cli/cli-setshow.c): New parameter
6665         'expression'.  When parsing an expression, error out if there's
6666         junk after "unlimited".
6667         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
6668         (do_set_command): Adjust calls to is_unlimited_literal.
6669
6670 2019-06-13  Pedro Alves  <palves@redhat.com>
6671
6672         * compile/compile.c (make_compile_options_def_group): Add braces
6673         around array_view initializer.
6674         * thread.c (make_thread_apply_all_options_def_group)
6675         (make_thread_apply_all_options_def_group): Likewise.
6676
6677 2019-06-13  Pedro Alves  <palves@redhat.com>
6678
6679         * NEWS (New commands): Mention "maint test-options
6680         require-delimiter", "maint test-options unknown-is-error", "maint
6681         test-options unknown-is-operand" and "maint show
6682         test-options-completion-result".
6683         (New command options, command completion): New section.
6684         (Completion improvements): New section.
6685         Mention that you can abbreviate "unlimited".
6686
6687 2019-06-13  Pedro Alves  <palves@redhat.com>
6688
6689         * cli/cli-utils.c (parse_flags, parse_flags_qcs): Delete.
6690         * cli/cli-utils.h (parse_flags, parse_flags_qcs): Delete.
6691         * unittests/cli-utils-selftests.c (test_parse_flags)
6692         (test_parse_flags_qcs): Delete.
6693         (test_cli_utils): Don't call deleted functions.
6694
6695 2019-06-13  Pedro Alves  <palves@redhat.com>
6696
6697         * thread.c: Include "cli/cli-option.h".
6698         (tp_array_compar_ascending): Global.
6699         (tp_array_compar): Delete function.
6700         (tp_array_compar_ascending, tp_array_compar_descending): New
6701         functions.
6702         (ascending_option_def, qcs_flag_option_def)
6703         (thr_qcs_flags_option_defs)
6704         (make_thread_apply_all_options_def_group)
6705         (make_thread_apply_options_def_group): New.
6706         (thread_apply_all_command): Use gdb::option::process_options.
6707         (thread_apply_command_completer)
6708         (thread_apply_all_command_completer): New.
6709         (thread_apply_command): Use gdb::option::process_options.
6710         (_initialize_thread): Delete THREAD_APPLY_FLAGS_HELP, replace it
6711         with a new THREAD_APPLY_OPTION_HELP.  Use gdb::option::build_help
6712         to generate help text of "thread apply".  Adjust "taas"'s help.
6713         * tid-parse.c (tid_range_parser::in_thread_range): New method.
6714         * tid-parse.h (tid_range_parser::in_thread_range): New method.
6715
6716 2019-06-13  Pedro Alves  <palves@redhat.com>
6717
6718         * thread.c (thread_apply_command): Check for invalid TID with
6719         isdigit instead of !isalpha.
6720
6721 2019-06-13  Pedro Alves  <palves@redhat.com>
6722
6723         * cli/cli-utils.c (parse_flags_qcs): Use validate_flags_qcs.
6724         (validate_flags_qcs): New.
6725         * cli/cli-utils.h (struct qcs_flags): Change field types to int.
6726         (validate_flags_qcs): Declare.
6727         * stack.c (qcs_flag_option_def, fr_qcs_flags_option_defs): New.
6728         (make_frame_apply_options_def_group): New.
6729         (frame_apply_command_count): Process options with
6730         gdb::option::process_options.
6731         (frame_apply_completer): New.
6732         (frame_apply_level_completer, frame_apply_all_completer)
6733         (frame_apply_completer): New.
6734         (_initialize_stack): Update help of "frame apply", "frame apply
6735         level", "frame apply all" and "faas" to mention supported options
6736         and install command completers.
6737         * stack.h (frame_apply_all_completer): Declare.
6738         * thread.c: Include "stack.h".
6739         (tfaas_command): Add "--".
6740         (_initialize_thread): Update help "tfaas" to mention supported
6741         options and install command completer.
6742
6743 2019-06-13  Pedro Alves  <palves@redhat.com>
6744
6745         * completer.c (complete_nested_command_line): New.
6746         (gdb_completion_word_break_characters_throw): Add assertion.
6747         * completer.h (complete_nested_command_line): Declare.
6748
6749 2019-06-13  Pedro Alves  <palves@redhat.com>
6750
6751         * stack.c (parse_backtrace_qualifiers): New.
6752         (backtrace_command): Use it.
6753         (backtrace_command_completer): Complete on qualifiers.
6754
6755 2019-06-13  Pedro Alves  <palves@redhat.com>
6756
6757         * frame.c: Include "cli/cli-option.h.
6758         (user_set_backtrace_options): New.
6759         (backtrace_past_main, backtrace_past_entry, backtrace_limit):
6760         Delete.
6761         (get_prev_frame): Adjust.
6762         (boolean_option_def, uinteger_option_def)
6763         (set_backtrace_option_defs): New.
6764         (_initialize_frame): Adjust and use
6765         gdb::option::add_setshow_cmds_for_options to install "set
6766         backtrace past-main" and "set backtrace past-entry".
6767         * frame.h: Include "cli/cli-option.h".
6768         (struct frame_print_options): Forward declare.
6769         (print_frame_arguments_all, print_frame_arguments_scalars)
6770         (print_frame_arguments_none): Declare.
6771         (print_entry_values): Delete declaration.
6772         (struct frame_print_options, user_frame_print_options): New.
6773         (struct set_backtrace_options): New.
6774         (set_backtrace_option_defs, user_set_backtrace_options): Declare.
6775         * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
6776         (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
6777         (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
6778         (list_args_or_locals): Add frame_print_options parameter.
6779         (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
6780         * python/py-framefilter.c (enumerate_args): Pass down
6781         USER_FRAME_PRINT_OPTIONS.
6782         * stack.c: Include "cli/cli-option.h".
6783         (print_frame_arguments_all, print_frame_arguments_scalars)
6784         (print_frame_arguments_none): Declare.
6785         (print_raw_frame_arguments, print_entry_values): Delete.
6786         (user_frame_print_options): New.
6787         (boolean_option_def, enum_option_def, frame_print_option_defs):
6788         New.
6789         (struct backtrace_cmd_options): New.
6790         (bt_flag_option_def): New.
6791         (backtrace_command_option_defs): New.
6792         (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
6793         (print_frame_arg, read_frame_arg, print_frame_args)
6794         (print_frame_info, print_frame): Add frame_print_options parameter
6795         and use it.
6796         (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
6797         (backtrace_command_1): Add frame_print_options and
6798         backtrace_cmd_options parameters and use them.
6799         (make_backtrace_options_def_group): New.
6800         (backtrace_command): Process command options with
6801         gdb::option::process_options.
6802         (backtrace_command_completer): New.
6803         (_initialize_stack): Extend "backtrace"'s help to mention
6804         supported options.  Install completer for "backtrace".
6805         Install some settings commands with add_setshow_cmds_for_options.
6806
6807 2019-06-13  Pedro Alves  <palves@redhat.com>
6808
6809         * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
6810         and that "set/show print raw frame-arguments" are now deprecated.
6811
6812         * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
6813         command.
6814         * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
6815         * stack.c (_initialize_stack): Install "set/show print
6816         raw-frame-arguments", and deprecate "set/show print raw
6817         frame-arguments".
6818         * valprint.c (_initialize_valprint): Deprecate "set/show print
6819         raw".
6820
6821 2019-06-13  Pedro Alves  <palves@redhat.com>
6822
6823         * compile/compile.c (struct compile_options): New.
6824         (compile_flag_option_def, compile_command_option_defs)
6825         (make_compile_options_def_group): New.
6826         (compile_file_command): Handle options with
6827         gdb::option::process_options.
6828         (compile_file_command_completer): New function.
6829         (compile_code_command): Handle options with
6830         gdb::option::process_options.
6831         (compile_code_command_completer): New function.
6832         (_initialize_compiler): Install completers for "compile code" and
6833         "compile file".  Mention available options in "compile code" and
6834         "compile code"'s help.
6835         * completer.c (advance_to_completion_word): New, factored out from
6836         ...
6837         (advance_to_expression_complete_word_point): ... this.
6838         (advance_to_filename_complete_word_point): New.
6839         * completer.h (advance_to_filename_complete_word_point): New
6840         declaration.
6841
6842 2019-06-13  Pedro Alves  <palves@redhat.com>
6843
6844         * compile/compile.c: Include "cli/cli-option.h".
6845         (compile_print_value): Scope data pointer is now a
6846         value_print_options pointer; adjust.
6847         (compile_print_command): Process options.  Scope data pointer is
6848         now a value_print_options pointer; adjust.
6849         (_initialize_compile): Update "compile print"'s help to include
6850         supported options.  Install a completer for "compile print".
6851         * cp-valprint.c (show_vtblprint, show_objectprint)
6852         (show_static_field_print): Delete.
6853         (_initialize_cp_valprint): Don't install "set print
6854         static-members", "set print vtbl", "set print object" here.
6855         * printcmd.c: Include "cli/cli-option.h" and
6856         "common/gdb_optional.h".
6857         (print_command_parse_format): Rework to fill in a
6858         value_print_options instead of a format_data.
6859         (print_value): Change parameter type from format_data pointer to
6860         value_print_options reference.  Adjust.
6861         (print_command_1): Process options.  Adjust to pass down a
6862         value_print_options.
6863         (print_command_completer): New.
6864         (_initialize_printcmd): Install print_command_completer as
6865         handle_brkchars completer for the "print" command.  Update
6866         "print"'s help to include supported options.
6867         * valprint.c: Include "cli/cli-option.h".
6868         (show_vtblprint, show_objectprint, show_static_field_print): Moved
6869         here from cp-valprint.c.
6870         (boolean_option_def, uinteger_option_def)
6871         (value_print_option_defs, make_value_print_options_def_group):
6872         New.  Use gdb::option::add_setshow_cmds_for_options to install
6873         "set print elements", "set print null-stop", "set print repeats",
6874         "set print pretty", "set print union", "set print array", "set
6875         print address", "set print symbol", "set print array-indexes".
6876         * valprint.h: Include <string> and "cli/cli-option.h".
6877         (make_value_print_options_def_group): Declare.
6878         (print_value): Change parameter type from format_data pointer to
6879         value_print_options reference.
6880         (print_command_completer): Declare.
6881
6882 2019-06-13  Pedro Alves  <palves@redhat.com>
6883
6884         * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
6885         (COMMON_SFILES): Add maint-test-settings.c.
6886         * cli/cli-decode.c (boolean_enums): New global, factored out from
6887         ...
6888         (add_setshow_boolean_cmd): ... here.
6889         * cli/cli-decode.h (boolean_enums): Declare.
6890         * cli/cli-option.c: New file.
6891         * cli/cli-option.h: New file.
6892         * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
6893         factored out from ...
6894         (parse_cli_boolean_value(const char *)): ... this.
6895         (is_unlimited_literal): Change parameter type to pointer to
6896         pointer.  Adjust and advance ARG pointer.
6897         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
6898         (parse_cli_var_enum): New, factored out from ...
6899         (do_set_command): ... this.  Adjust.
6900         * cli/cli-setshow.h (parse_cli_boolean_value)
6901         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
6902         (parse_cli_var_enum): Declare.
6903         * cli/cli-utils.c: Include "cli/cli-option.h".
6904         (get_ulongest): New.
6905         * cli/cli-utils.h (get_ulongest): Declare.
6906         (check_for_argument): New overloads.
6907         * maint-test-options.c: New file.
6908
6909 2019-06-13  Pedro Alves  <palves@redhat.com>
6910
6911         * cli/cli-utils.c (number_or_range_parser::get_number): Do not
6912         parse a range if "-" is at the end of the string.
6913
6914 2019-06-13  Pedro Alves  <palves@redhat.com>
6915
6916         * cli/cli-setshow.c (parse_auto_binary_operation)
6917         (parse_cli_boolean_value): Don't allow "o".
6918
6919 2019-06-13  Pedro Alves  <palves@redhat.com>
6920
6921         * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
6922         * NEWS: Mention maint test-settings KIND.
6923         * maint-test-settings.c: New file.
6924
6925 2019-06-13  Pedro Alves  <palves@redhat.com>
6926
6927         * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
6928         completer.
6929         (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
6930         "set" completers.
6931
6932 2019-06-13  Pedro Alves  <palves@redhat.com>
6933
6934         * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
6935         after item.
6936
6937 2019-06-13  Pedro Alves  <palves@redhat.com>
6938
6939         * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
6940
6941 2019-06-13  Pedro Alves <palves@redhat.com>
6942
6943         * ax-gdb.c (agent_command_1): Remove skip_spaces call.
6944         * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
6945         call.
6946         * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
6947         * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
6948         calls.
6949         (check_for_argument): Skip spaces after argument.
6950
6951 2019-06-13  Pedro Alves  <palves@redhat.com>
6952
6953         * thread.c (thread_apply_command): Adjust TID parsing.
6954         * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
6955         detected before end of string.
6956         (tid_is_in_list): Error out if LIST is invalid.
6957
6958 2019-06-13  Pedro Alves  <palves@redhat.com>
6959
6960         * completer.c (complete_line_internal_1): Rewind completion word
6961         point.
6962         (completion_tracker::advance_custom_word_point_by): Change
6963         parameter type to int.
6964         * completer.h (completion_tracker::advance_custom_word_point_by):
6965         Likewise.
6966
6967 2019-06-13  Pedro Alves  <palves@redhat.com>
6968
6969         * completer.c (advance_to_completion_word): Handle delimiters.
6970
6971 2019-06-11  Bernhard Heckel  <bernhard.heckel@intel.com>
6972
6973         * dwarf2read.c (add_partial_symbol): Skip nameless modules.
6974
6975 2019-06-11  Tom Tromey  <tom@tromey.com>
6976
6977         * common/common-utils.c (xmalloc, xrealloc, xcalloc)
6978         (xmalloc_failed): Move to alloc.c.
6979         * alloc.c: New file.
6980         * Makefile.in (COMMON_SFILES): Add alloc.c.
6981
6982 2019-06-11  Tom Tromey  <tom@tromey.com>
6983
6984         * nat/linux-waitpid.c: Don't include server.h.
6985         (linux_debug): Remove.
6986         (my_waitpid): Update.
6987
6988 2019-06-11  Tom Tromey  <tromey@adacore.com>
6989
6990         * infcall.c (_initialize_infcall): Remove trailing newline from
6991         help.
6992         * user-regs.c (_initialize_user_regs): Remove trailing newline
6993         from help.
6994         * typeprint.c (_initialize_typeprint): Remove trailing newline
6995         from help.
6996         * reverse.c (_initialize_reverse): Remove trailing newlines from
6997         help.
6998         * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
6999         from help.
7000         * language.c (add_set_language_command): Remove trailing newline
7001         from help.
7002         * infcmd.c (_initialize_infcmd): Remove trailing newlines from
7003         help.
7004         * disasm.c (_initialize_disasm): Remove trailing newline from
7005         help.
7006         * top.c (init_main): Remove trailing newline from help.
7007         * interps.c (_initialize_interpreter): Remove trailing newline
7008         from help.
7009         * btrace.c (_initialize_btrace): Remove trailing newlines from
7010         help.
7011         * breakpoint.c (_initialize_breakpoint): Remove trailing newline
7012         from help.
7013         * python/python.c (_initialize_python): Remove trailing newline
7014         from help.
7015         * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
7016         help.
7017         * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
7018         from help.  Reformat some text.
7019         * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
7020         from help.
7021         * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
7022         newline from help.
7023
7024 2019-06-11  Tom Tromey  <tromey@adacore.com>
7025
7026         * darwin-nat.c (darwin_decode_exception_message)
7027         (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
7028
7029 2019-06-10  Andrew Burgess  <andrew.burgess@embecosm.com>
7030
7031         * valops.c (value_slice): Check for not allocated or not
7032         associated values.
7033
7034 2019-06-10  Tom de Vries  <tdevries@suse.de>
7035
7036         PR gdb/24618
7037         * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
7038         sure an empty slot (defined by a 32-bit zero pair) is recognized as
7039         invalid.
7040
7041 2019-06-10  Tom de Vries  <tdevries@suse.de>
7042
7043         PR gdb/24611
7044         * linespec.c (linespec_lexer_lex_string): Remove incorrect
7045         "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon.  Add assert.
7046
7047 2019-06-10  Tom de Vries  <tdevries@suse.de>
7048
7049         PR symtab/24545
7050         * symtab.c (struct demangled_name_entry): Add language field.
7051         (symbol_set_names):  Revert "[gdb/symtab] Fix language of duplicate
7052         static minimal symbol".  Set and use language field.
7053
7054 2019-06-10  Tom Tromey  <tromey@adacore.com>
7055
7056         * ada-lang.c (_initialize_ada_language): Update help text.
7057
7058 2019-06-10  Tom Tromey  <tromey@adacore.com>
7059
7060         * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
7061         with a newline.
7062         * guile/guile.c (handle_boot_error): Don't end warning with a
7063         newline.
7064         * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
7065         warning with a newline.
7066         * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
7067         newline.
7068         (s12z_frame_cache): Likewise.
7069         * dwarf-index-cache.c (index_cache::store): Don't end warning with
7070         a newline.
7071         * solib-svr4.c (disable_probes_interface): Don't end warning with
7072         a newline.
7073         * nat/fork-inferior.c (fork_inferior): Don't end warning with a
7074         newline.
7075         * python/python.c (do_finish_initialization): Don't end warning
7076         with a newline.
7077
7078 2019-06-10  Tom Tromey  <tom@tromey.com>
7079
7080         * python/py-breakpoint.c (gdbpy_breakpoint_created)
7081         (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
7082         gdbpy_enter.
7083
7084 2019-06-10  Tom Tromey  <tromey@adacore.com>
7085
7086         * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
7087         data.
7088         (elf_new_init): Don't call stabsread_new_init.
7089         * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
7090         (elfstab_build_psymtabs): Likewise.  Call stabsread_new_init.
7091         * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
7092
7093 2019-06-10  Tom de Vries  <tdevries@suse.de>
7094
7095         PR symtab/16264
7096         PR symtab/24517
7097         * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
7098
7099 2019-06-06  Руслан Ижбулатов <lrn1986@gmail.com>
7100
7101         * source.c (find_and_open_source): Also rewrite relative file
7102         names.
7103
7104 2019-04-26  Amos Bird  <amosbird@gmail.com>
7105
7106         * annotate.c (annotate_thread_exited): Add "thread-exited"
7107         annotation.
7108
7109 2019-06-06  Tom Tromey  <tromey@adacore.com>
7110
7111         * maint.h (class scoped_command_stats): Use
7112         DISABLE_COPY_AND_ASSIGN.
7113         <print_time>: New method.
7114         * maint.c (scoped_command_stats, ~scoped_command_stats): Call
7115         print_time.
7116         (scoped_command_stats::print_time): New method.
7117
7118 2019-06-05  Andrew Burgess  <andrew.burgess@embecosm.com>
7119
7120         * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
7121         instructions of lengths 6 or 8 bytes.
7122
7123 2019-06-04  Pedro Alves  <palves@redhat.com>
7124
7125         * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
7126
7127         * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
7128         * breakpoint.c (condition_completer): Likewise.
7129         * cli/cli-dump.c (scan_expression): Likewise.
7130         * common/filestuff.c (mkdir_recursive): Likewise.
7131         * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
7132         * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
7133         (gdb_abspath): Likewise.
7134         * compile/compile-cplus-types.c
7135         (compile_cplus_instance::decl_name): Likewise.
7136         * completer.c (complete_explicit_location):
7137         (signal_completer, reg_or_group_completer_1): Likewise.
7138         * cp-support.c (cp_remove_params_if_any): Likewise.
7139         * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
7140         * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
7141         * infcmd.c (strip_bg_char): Likewise.
7142         * linespec.c (copy_token_string): Likewise.
7143         * mi/mi-main.c (output_cores): Likewise.
7144         * psymtab.c (psymtab_search_name):
7145         * symfile.c (test_set_ext_lang_command): Likewise.
7146         * target.c (target_fileio_read_stralloc): Likewise.
7147         * tui/tui-regs.c (tui_reggroup_completer): Likewise.
7148         * value.c (complete_internalvar): Likewise.
7149
7150 2019-06-04  Christian Biesinger  <cbiesinger@google.com>
7151
7152         Add objfile property to gdb.Type.
7153         * NEWS: Mention Python API addition.
7154         * python/py-type.c (typy_get_objfile): New method.
7155
7156 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7157
7158         * NEWS: Mention the new set|show style [title|highlight].
7159         Mention changes to "show style", "help" and "apropos".
7160
7161 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7162
7163         * cli/cli-decode.h (apropos_cmd): Add verbose argument.
7164         * cli/cli-decode.c (apropos_cmd): Likewise.  Use print_doc_of_command
7165         instead of print_help_for_command.
7166         (print_doc_of_command): New function.
7167         (help_list): Add 'apropos -v word' suggestion.
7168         (print_help_for_command): Style the command name using title style.
7169         * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
7170         (_initialize_cli_cmds): Describe -v in apropos_command help.
7171
7172 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7173
7174         * cli/cli-style.h (cli_style_option): Add name in constructor,
7175         add m_name class member, add constructor with intensity,
7176         add name class function.
7177         (cli_style_option::add_setshow_commands): Remove name argument.
7178         (highlight_style, title_style): New styles.
7179         * cli/cli-style.c (do_show): New function that shows a style
7180         characteristic styling the style name with itself.
7181         (set_style_name): New function.
7182         (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
7183         Update all callers according to the changes in cli/cli-style.h.
7184         * utils.h (fputs_highlighted): New function.
7185         * utils.c (fputs_highlighted): Likewise.
7186
7187 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7188
7189         * NEWS: Mention new pipe command and new convenience variables.
7190
7191 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7192
7193         * cli/cli-cmds.c (pipe_command): New function.
7194         (_initialize_cli_cmds): Call add_com for pipe_command.
7195         Define | as an alias for pipe.
7196         (exit_status_set_internal_vars): New function.
7197         (shell_escape): Call exit_status_set_internal_vars.
7198         cli/cli-decode.c (find_command_name_length): Recognize | as
7199         a single character command.
7200
7201 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7202
7203         * gdbcmd.h (execute_command_to_ui_file): New declaration.
7204         top.c (execute_command_to_ui_file): New function, mostly a copy
7205         of execute_command_to_string.
7206         (execute_command_to_string): Implement by calling
7207         execute_command_to_ui_file.
7208
7209 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7210
7211         * top.h (saved_command_line): Remove declaration.
7212         * top.c (previous_saved_command_line, previous_repeat_arguments):
7213         New variables.
7214         (saved_command_line): Make static, define together with other
7215         'repeat variables'.
7216         (dont_repeat): Clear repeat_arguments.
7217         (repeat_previous, get_saved_command_line, save_command_line):
7218         New functions.
7219         (gdb_init): Initialize saved_command_line
7220         and previous_saved_command_line.
7221         * main.c (captured_main_1): Remove saved_command_line initialization.
7222         * event-top.c (handle_line_of_input): Update to use
7223         the new 'repeat' related functions instead of direct access to
7224         saved_command_line.
7225         * command.h (repeat_previous, get_saved_command_line,
7226         save_command_line): New declarations.
7227         (dont_repeat): Add comment.
7228
7229 2019-05-30  Tom Tromey  <tromey@adacore.com>
7230
7231         * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
7232         Fix comment.
7233         (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
7234
7235 2019-05-30  Jan Vrany  <jan.vrany@fit.cvut.cz>
7236
7237         PR cli/24587
7238         * completer.c (complete): Initialize variable word.
7239
7240 2019-05-29  Sergio Durigan Junior  <sergiodj@redhat.com>
7241
7242         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
7243         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
7244         * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
7245         'body' is NULL to the outter 'if', protecting the '!is_define'
7246         situation as well.
7247
7248 2019-05-29  Tom Tromey  <tromey@adacore.com>
7249
7250         * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
7251         (dwarf_unknown): New function.
7252         (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
7253         (dwarf_type_encoding_name): Use dwarf_unknown.
7254
7255 2019-05-29  Tom Tromey  <tromey@adacore.com>
7256
7257         PR c++/20020:
7258         * cp-valprint.c (cp_print_value_fields): Call
7259         cp_print_static_field inside "try".
7260
7261 2019-05-29  Tom Tromey  <tromey@adacore.com>
7262
7263         * inflow.c (struct terminal_info): Add default operator=.
7264         * configure: Rebuild.
7265         * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
7266         -Wdeprecated-copy-dtor, -Wredundant-move.
7267
7268 2019-05-29  Tom Tromey  <tromey@adacore.com>
7269
7270         * NEWS: Add entry.
7271         * infcmd.c (print_return_value_1): Handle finish_print
7272         option.
7273         (show_print_finish): New function.
7274         (_initialize_infcmd): Add "set/show print finish" commands.
7275         * valprint.c (user_print_options): Initialize new member.
7276         * valprint.h (struct value_print_options) <finish_print>: New
7277         member.
7278
7279 2019-05-28  Tom Tromey  <tromey@adacore.com>
7280
7281         * ada-lang.c (ada_remove_Xbn_suffix)
7282         (find_old_style_renaming_symbol)
7283         (parse_old_style_renaming): Remove.
7284         (ada_find_renaming_symbol): Don't call
7285         find_old_style_renaming_symbol.
7286         (ada_is_renaming_symbol): Rename from
7287         ada_find_renaming_symbol.  Remove "block" parameter.  Return
7288         bool.  Now static.
7289         (ada_read_var_value): Update and simplify.
7290         * ada-exp.y (write_var_or_type): Remove old code.
7291
7292 2019-05-28  Alan Hayward  <alan.hayward@arm.com>
7293
7294         PR gdb/25010
7295         * event-top.c: Remove include comment.
7296         * inflow.c (class scoped_ignore_sigttou): Move from here...
7297         * inflow.h (class scoped_ignore_sigttou): ...to here.
7298         * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
7299         * top.c:  Remove include comment.
7300
7301 2019-05-27  Tom Tromey  <tom@tromey.com>
7302
7303         * NEWS: Fix typo.
7304
7305 2019-05-22  Tom Tromey  <tromey@adacore.com>
7306
7307         * target.c (target_follow_exec): Constify parameter.
7308         * target-delegates.c: Rebuild.
7309         * remote.c (remote_target::follow_exec): Constify parameter.
7310         * infrun.c (follow_exec): Constify parameter.
7311         * target.h (struct target_ops) <follow_exec>: Constify parameter.
7312         (target_follow_exec): Likewise.
7313
7314 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
7315
7316         * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
7317         DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
7318
7319 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
7320
7321         * NEWS: Add debugredirect and testsuite sections.
7322
7323 2019-05-22  Simon Cook  <simon.cook@embecosm.com>
7324
7325         * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
7326         target descriptions using exclusively floating point register name
7327         aliases.
7328
7329 2019-05-21  Andrew Burgess  <andrew.burgess@embecosm.com>
7330
7331         PR gdb/18644:
7332         * f-lang.c (build_fortran_types): Handle the case where
7333         gdbarch_floatformat_for_type returns a nullptr.
7334
7335 2019-05-21  Tom de Vries  <tdevries@suse.de>
7336
7337         PR cli/24587
7338         * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
7339
7340 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
7341
7342         PR gdb/18644:
7343         * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
7344         16-byte floats.
7345         * i386-tdep.c (i386_floatformat_for_type): Use
7346         floatformats_ia64_quad for the 16-byte floating point component
7347         within a fortran 32-byte complex number.
7348
7349 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
7350
7351         * dwarf2read.c (struct cu_partial_die_info): Add constructor,
7352         delete default constructor.
7353         (find_partial_die): Update to return const struct.
7354         (partial_die_parent_scope): Move variable declaration into scope
7355         of its use and change its type to auto.
7356         (guess_partial_die_structure_name): Likewise.
7357         (partial_die_info::fixup): Likewise.
7358
7359 2019-05-17  Tom Tromey  <tromey@adacore.com>
7360
7361         * source.c (find_and_open_source): Remove cast.
7362
7363 2019-05-17  Tom Tromey  <tromey@adacore.com>
7364
7365         * annotate.c (annotate_source): Make "filename" const.
7366         * annotate.h (annotate_source): Use const.
7367
7368 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
7369
7370         * disasm.c (set_disassembler_options): Send errors to stderr.
7371
7372 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
7373
7374         * cli/cli-interp.c (struct saved_output_files): Add saved entry.
7375         (cli_interp_base::set_logging): Check debug_redirect.
7376         * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
7377         * cli/cli-logging.c (debug_redirect): Add static variable.
7378         (pop_output_files): Add default param.
7379         (handle_redirections): Print debug setting.
7380         (show_logging_command): Likewise.
7381         (_initialize_cli_logging): Add debugredirect command.
7382         * interps.c (current_interp_set_logging): Add debug_redirect
7383         parameter.
7384         * interps.h (set_logging): Add debug_redirect parameter.
7385         (current_interp_set_logging): Likewise.
7386         * mi/mi-common.h: Likewise.
7387         * mi/mi-interp.c (mi_interp::set_logging): Likewise.
7388
7389 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
7390             Tom Tromey  <tromey@adacore.com>
7391
7392         * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
7393         directly.
7394         * cli/cli-interp.h (make_logging_output): Remove declaration.
7395         * cli/cli-logging.c (make_logging_output): Remove function.
7396         * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
7397         directly.
7398         * ui-file.c (tee_file::tee_file): Remove bools.
7399         (tee_file::~tee_file): Remove deletes.
7400         * ui-file.h (tee_file): Remove bools.
7401
7402 2019-01-28  Jan Vrany  <jan.vrany@fit.cvut.cz>
7403
7404         * mi/mi-cmds.h (mi_cmd_complete): New function.
7405         * mi/mi-main.c (mi_cmd_complete): Likewise.
7406         * mi/mi-cmds.c: Define new MI command -complete.
7407         * NEWS: Mention new -complete command.
7408
7409 2019-01-24  Jan Vrany  <jan.vrany@fit.cvut.cz>
7410
7411         * completer.h (complete): New function.
7412         * completer.c (complete): Likewise.
7413         * cli/cli-cmds.c: (complete_command): Update to use new complete()
7414         function defined in completer.h.
7415
7416 2019-05-17  Jan Vrany  <jan.vrany@fit.cvut.cz>
7417
7418         * MAINTAINERS (Write After Approval): Add myself.
7419
7420 2019-05-17  Tom de Vries  <tdevries@suse.de>
7421
7422         PR gdb/24094
7423         * dwarf2read.c (struct cu_partial_die_info): New struct.
7424         (find_partial_die): Return cu_partial_die_info.
7425         (partial_die_parent_scope, guess_partial_die_structure_name)
7426         (partial_die_info::fixup): Handle new return type of find_partial_die.
7427
7428 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
7429
7430         PR breakpoints/24541
7431         * stap-probe.c (stap_parse_register_operand): Make "regname" an
7432         "std::string", simplifying the algorithm.
7433
7434 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
7435
7436         * stap-probe.c (handle_stap_probe): Fix complaint formatting.
7437         (stap_static_probe_ops::get_probes): Likewise.
7438
7439 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
7440
7441         * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
7442         '-')" and "else if".
7443         (stap_parse_single_operand): Join checks for
7444         "gdbarch_stap_parse_special_token_p" and
7445         "gdbarch_stap_parse_special_token" in the same "if" statement.
7446         Invert check when verifying for operation on register
7447         displacement.
7448
7449 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
7450
7451         * stap-probe.c (stap_get_opcode): Update comment.
7452         (stap_get_expected_argument_type): Likewise.
7453         (handle_stap_probe): Likewise.
7454
7455 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
7456
7457         * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
7458         return type to 'bool'.  Adjust comment.  Use 'bool' when
7459         appropriate.
7460         (i386_stap_parse_special_token_three_arg_disp): Likewise.
7461         * stap-probe.c (stap_parse_argument_1): Likewise.
7462         (stap_is_operator): Likewise.
7463         (stap_is_generic_prefix): Likewise.
7464         (stap_is_register_prefix): Likewise.
7465         (stap_is_register_indirection_prefix): Likewise.
7466         (stap_is_integer_prefix): Likewise.
7467         (stap_generic_check_suffix): Likewise.
7468         (stap_check_integer_suffix): Likewise.
7469         (stap_check_register_suffix): Likewise.
7470         (stap_check_register_indirection_suffix): Likewise.
7471         (stap_parse_register_operand): Likewise.
7472         (stap_parse_single_operand): Likewise.
7473         (stap_parse_argument_1): Likewise.
7474         (stap_probe::get_argument_count): Likewise.
7475         (stap_is_operator): Likewise.
7476
7477 2019-05-16  Tom Tromey  <tromey@adacore.com>
7478
7479         * darwin-nat.c (thread_info_from_private_thread_info): Add struct
7480         keyword to foreach.
7481
7482 2019-05-15  Simon Marchi  <simon.marchi@efficios.com>
7483
7484         * linux-thread-db.c (try_thread_db_load_1): Change return type
7485         to bool.
7486         (try_thread_db_load): Likewise.
7487         (try_thread_db_load_from_pdir_1): Likewise.
7488         (try_thread_db_load_from_pdir): Likewise.
7489         (try_thread_db_load_from_sdir): Likewise.
7490         (try_thread_db_load_from_dir): Likewise.
7491         (thread_db_load_search): Likewise.
7492         (has_libpthread): Likewise.
7493         (thread_db_load): Likewise.
7494
7495 2019-05-15  Sergio Durigan Junior  <sergiodj@redhat.com>
7496
7497         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
7498         * dwarf2read.c (parse_macro_definition): Check whether 'body' is
7499         NULL, and complain/return if that's the case.
7500
7501 2019-05-15  John Darrington <john@darrington.wattle.id.au>
7502
7503         * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
7504         (advance, posn, abstract_read_memory): New functions.
7505         [struct mem_read_abstraction]: New struct.
7506         (s12z_frame_cache): Use opcodes API to interpret stack frame code.
7507
7508 2019-05-14  Tom Tromey  <tromey@adacore.com>
7509
7510         * ada-lang.c (coerce_unspec_val_to_type): Only set address when
7511         value is not lval_memory.
7512
7513 2019-05-14  Tom Tromey  <tromey@adacore.com>
7514
7515         * solib.c (info_sharedlibrary_command): Style the file name.
7516
7517 2019-05-14  Alan Hayward  <alan.hayward@arm.com>
7518
7519         * aarch64-tdep.c (aarch64_vnh_type): Add half view.
7520         (aarch64_vnv_type): Likewise.
7521         * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
7522         * common/tdesc.c: Likewise.
7523         * common/tdesc.h (enum tdesc_type_kind): Likewise.
7524         * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
7525         * features/aarch64-fpu.xml: Add ieee half view.
7526         * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
7527         * gdbtypes.c (gdbtypes_post_init): Add builtin_half
7528         * gdbtypes.h (struct builtin_type): Likewise.
7529         (struct objfile_type): Likewise.
7530
7531 2019-05-12  Paul Naert  <paul.naert@polymtl.ca>
7532
7533         * language.c (language_sniff_from_mangled_name): Fix "langauge"
7534         typo.
7535         * location.h (string_to_event_location): Likewise.
7536
7537 2019-05-11  Joel Brobecker  <brobecker@adacore.com>
7538
7539         GDB 8.3 released.
7540
7541 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
7542
7543         * breakpoint.h (fix_multi_location_breakpoint_output_globally):
7544         New variable declaration.
7545         * breakpoint.c (fix_multi_location_breakpoint_output_globally):
7546         New variable.
7547         (print_one_breakpoint): Use ui_out::test_flags and new global
7548         variable to compute use_fixed_output.
7549         * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
7550         Remove.
7551         * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
7552         (mi_multi_location_breakpoint_output_fixed): Remove.
7553         (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
7554         new variable.
7555         * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
7556         fix_multi_location_breakpoint_output flag if version >= 3.
7557         * ui-out.h (enum ui_out_flag)
7558         <fix_multi_location_breakpoint_output>: New enumerator.
7559
7560 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
7561
7562         * contrib/cc-with-tweaks.sh: Validate dwz's work.
7563
7564 2019-05-10  Tom Tromey  <tromey@adacore.com>
7565
7566         * ada-lang.c (catch_ada_completer): New function.
7567         (_initialize_ada_language): Use it.
7568
7569 2019-05-10  Tom Tromey  <tromey@adacore.com>
7570
7571         * thread.c (print_thread_info): Make "requested_threads" const.
7572         * gdbthread.h (print_thread_info): Make "requested_threads"
7573         const.
7574         * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
7575         * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
7576
7577 2019-05-08  Tom Tromey  <tom@tromey.com>
7578
7579         * gdbtypes.c (objfile_type_data): Change type.
7580         (objfile_type, _initialize_gdbtypes): Update.
7581
7582 2019-05-08  Tom Tromey  <tom@tromey.com>
7583
7584         * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
7585         (dwarf2_frame_find_fde, dwarf2_build_frame_info)
7586         (_initialize_dwarf2_frame): Update.
7587
7588 2019-05-08  Tom Tromey  <tom@tromey.com>
7589
7590         * objc-lang.c (objc_objfile_data): Change type.
7591         (find_methods): Update.
7592         (_initialize_objc_lang): Remove.
7593
7594 2019-05-08  Tom Tromey  <tom@tromey.com>
7595
7596         * stabsread.c (rs6000_builtin_type_data): Change type.
7597         (rs6000_builtin_type, _initialize_stabsread): Update.
7598
7599 2019-05-08  Tom Tromey  <tom@tromey.com>
7600
7601         * mips-tdep.c (mips_pdr_data): Remove.
7602         (_initialize_mips_tdep): Update.
7603
7604 2019-05-08  Tom Tromey  <tom@tromey.com>
7605
7606         * hppa-tdep.c (hppa_objfile_priv_data): Change type.
7607         (hppa_init_objfile_priv_data, read_unwind_info)
7608         (find_unwind_entry, _initialize_hppa_tdep): Update.
7609
7610 2019-05-08  Tom Tromey  <tom@tromey.com>
7611
7612         * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
7613         (elf_gnu_ifunc_record_cache): Update.  Don't allocate hash table
7614         on obstack.
7615         (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
7616
7617 2019-05-08  Tom Tromey  <tom@tromey.com>
7618
7619         * mdebugread.c (basic_type_data): Change type.
7620         (basic_type, _initialize_mdebugread): Update.
7621
7622 2019-05-08  Tom Tromey  <tom@tromey.com>
7623
7624         * common/gdb_unique_ptr.h (struct noop_deleter): New.
7625
7626 2019-05-08  Tom Tromey  <tom@tromey.com>
7627
7628         * nto-tdep.c (nto_inferior_data_reg): Change type.
7629         (nto_inferior_data): Update.
7630         (nto_inferior_data_cleanup, nto_new_inferior_data)
7631         (_initialize_nto_tdep): Remove.
7632         * nto-tdep.h (struct nto_inferior_data): Add initializers.
7633
7634 2019-05-08  Tom Tromey  <tom@tromey.com>
7635
7636         * ada-lang.c (struct ada_inferior_data): Add initializers.
7637         (ada_inferior_data): Change type.
7638         (ada_inferior_data_cleanup): Remove.
7639         (get_ada_inferior_data, ada_inferior_exit)
7640         (struct ada_pspace_data): Add initializers, destructor.
7641         (ada_pspace_data_handle): Change type.
7642         (get_ada_pspace_data): Update.
7643         (ada_pspace_data_cleanup): Remove.
7644
7645 2019-05-08  Tom Tromey  <tom@tromey.com>
7646
7647         * coffread.c (struct coff_symfile_info): Add initializers.
7648         (coff_objfile_data_key): Move lower.  Change type.
7649         (coff_symfile_init, coff_symfile_read, _initialize_coffread):
7650         Update.
7651         (coff_free_info): Remove.
7652
7653 2019-05-08  Tom Tromey  <tom@tromey.com>
7654
7655         * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
7656         (fbsd_pspace_data_handle): Move lower.  Change type.
7657         (get_fbsd_pspace_data): Update.
7658         (fbsd_pspace_data_cleanup): Remove.
7659         (_initialize_fbsd_tdep): Update.
7660
7661 2019-05-08  Tom Tromey  <tom@tromey.com>
7662
7663         * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
7664         (get_ada_tasks_pspace_data): Update.
7665         (ada_tasks_pspace_data_cleanup): Remove.
7666         (_initialize_tasks): Update.
7667         (ada_tasks_inferior_data_handle): Change type.
7668         (get_ada_tasks_inferior_data): Update.
7669         (ada_tasks_inferior_data_cleanup): Remove.
7670         (struct ada_tasks_pspace_data): Add initializers.
7671
7672 2019-05-08  Tom Tromey  <tom@tromey.com>
7673
7674         * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
7675         * symfile-debug.c (debug_sym_get_probes): Change type.
7676         * stap-probe.c (handle_stap_probe):
7677         (stap_static_probe_ops::get_probes): Change type.
7678         * probe.h (class static_probe_ops) <get_probes>: Change type.
7679         * probe.c (class any_static_probe_ops) <get_probes>: Change type.
7680         (parse_probes_in_pspace): Update.
7681         (find_probes_in_objfile, find_probe_by_pc, collect_probes):
7682         Update.
7683         (any_static_probe_ops::get_probes): Change type.
7684         * elfread.c (elfread_data): New typedef.
7685         (probe_key): Change type.
7686         (elf_get_probes): Likewise.  Update.
7687         (probe_key_free): Remove.
7688         (_initialize_elfread): Update.
7689         * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
7690         Change type.
7691         (dtrace_process_dof_probe, dtrace_process_dof)
7692         (dtrace_static_probe_ops::get_probe): Change type.
7693
7694 2019-05-08  Tom Tromey  <tom@tromey.com>
7695
7696         * xcoffread.c (struct xcoff_symfile_info): Rename from
7697         coff_symfile_info.  Add initializers.
7698         (xcoff_objfile_data_key): Move lower.  Change type.
7699         (XCOFF_DATA): Rewrite.
7700         (xcoff_free_info): Remove.
7701         (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
7702         (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
7703         (xcoff_initial_scan): Update.
7704
7705 2019-05-08  Tom Tromey  <tom@tromey.com>
7706
7707         * solib-svr4.c (struct svr4_info): Add initializers and
7708         destructor.
7709         <probes_table>: Now an htab_up.
7710         (solib_svr4_pspace_data): Change type.
7711         (free_probes_table): Simplify.
7712         (~svr4_info): Rename from svr4_pspace_data_cleanup.
7713         (get_svr4_info, probes_table_htab_remove_objfile_probes)
7714         (probes_table_remove_objfile_probes, register_solib_event_probe)
7715         (solib_event_probe_at, svr4_update_solib_event_breakpoint)
7716         (_initialize_svr4_solib): Update.
7717
7718 2019-05-08  Tom Tromey  <tom@tromey.com>
7719
7720         * remote.c (remote_pspace_data): Change type.
7721         (remote_pspace_data_cleanup): Remove.
7722         (get_remote_exec_file, set_pspace_remote_exec_file)
7723         (_initialize_remote): Update.
7724
7725 2019-05-08  Tom Tromey  <tom@tromey.com>
7726
7727         * breakpoint.c (breakpoint_objfile_key): Change type.
7728         (get_breakpoint_objfile_data): Update.
7729         (free_breakpoint_objfile_data): Remove.
7730         (_initialize_breakpoint): Update.
7731
7732 2019-05-08  Tom Tromey  <tom@tromey.com>
7733
7734         * linux-tdep.c (struct linux_info): Add initializers.
7735         (linux_inferior_data): Move.  Change type.
7736         (invalidate_linux_cache_inf): Update.
7737         (linux_inferior_data_cleanup): Remove.
7738         (get_linux_inferior_data, _initialize_linux_tdep): Update.
7739
7740 2019-05-08  Tom Tromey  <tom@tromey.com>
7741
7742         * auxv.c (auxv_inferior_data): Move.  Change type.
7743         (auxv_inferior_data_cleanup): Remove.
7744         (invalidate_auxv_cache_inf): Rewrite.
7745         (get_auxv_inferior_data, _initialize_auxv): Update.
7746
7747 2019-05-08  Tom Tromey  <tom@tromey.com>
7748
7749         * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
7750         (symfile_debug_objfile_data_key): Change type.
7751         (symfile_debug_installed, debug_qf_has_symbols)
7752         (debug_qf_find_last_source_symtab)
7753         (debug_qf_forget_cached_source_info)
7754         (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
7755         (debug_qf_print_stats, debug_qf_dump)
7756         (debug_qf_expand_symtabs_for_function)
7757         (debug_qf_expand_all_symtabs)
7758         (debug_qf_expand_symtabs_with_fullname)
7759         (debug_qf_map_matching_symbols)
7760         (debug_qf_expand_symtabs_matching)
7761         (debug_qf_find_pc_sect_compunit_symtab)
7762         (debug_qf_map_symbol_filenames)
7763         (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
7764         (debug_sym_new_init, debug_sym_init, debug_sym_read)
7765         (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
7766         (debug_sym_read_linetable, debug_sym_relocate): Update.
7767         (symfile_debug_free_objfile): Remove.
7768         (install_symfile_debug_logging, _initialize_symfile_debug):
7769         Update.
7770
7771 2019-05-08  Tom Tromey  <tom@tromey.com>
7772
7773         * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
7774         allocate_on_obstack.
7775         * dwarf2read.c (dwarf2_objfile_data_key): Change type.
7776         (get_dwarf2_per_objfile): Update.
7777         (set_dwarf2_per_objfile): Remove.
7778         (dwarf2_has_info, dwarf2_get_section_info): Update.
7779         (dwarf2_free_objfile): Remove.
7780         (_initialize_dwarf2_read): Update.
7781
7782 2019-05-08  Tom Tromey  <tom@tromey.com>
7783
7784         * auto-load.c (struct auto_load_pspace_info): Add destructor and
7785         initializers.
7786         <unsupported_script_warning_printed,
7787         script_not_found_warning_printed>: Now bool.
7788         (auto_load_pspace_data): Change type.
7789         (~auto_load_pspace_info): Rename from
7790         auto_load_pspace_data_cleanup.
7791         (get_auto_load_pspace_data, init_loaded_scripts_info)
7792         (clear_section_scripts, maybe_print_unsupported_script_warning)
7793         (maybe_print_script_not_found_warning, _initialize_auto_load):
7794         Update.
7795
7796 2019-05-08  Tom Tromey  <tom@tromey.com>
7797
7798         * objfiles.c (objfile_pspace_info): Add destructor and
7799         initializers.
7800         (objfiles_pspace_data): Change type.
7801         (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
7802         (get_objfile_pspace_data): Update.
7803         (objfiles_bfd_data): Change type.
7804         (get_objfile_bfd_data): Update.
7805         (objfile_bfd_data_free, _initialize_objfiles): Remove.
7806
7807 2019-05-08  Tom Tromey  <tom@tromey.com>
7808
7809         * break-catch-syscall.c (catch_syscall_inferior_data): Move.
7810         Change type.
7811         (get_catch_syscall_inferior_data): Update.
7812         (catch_syscall_inferior_data_cleanup): Remove.
7813         (_initialize_break_catch_syscall): Update.
7814
7815 2019-05-08  Tom Tromey  <tom@tromey.com>
7816
7817         * inflow.c (struct terminal_info): Add destructor and
7818         initializers.
7819         (inflow_inferior_data): Change type.
7820         (~terminal_info): Rename from inflow_inferior_data_cleanup.
7821         (get_inflow_inferior_data, inflow_inferior_exit)
7822         (swap_terminal_info, _initialize_inflow): Update.
7823
7824 2019-05-08  Tom Tromey  <tom@tromey.com>
7825
7826         * target-dcache.c (target_dcache_cleanup): Remove.
7827         (target_dcache_aspace_key): Change type.
7828         (target_dcache_init_p, target_dcache_invalidate)
7829         (target_dcache_get, target_dcache_get_or_init)
7830         (_initialize_target_dcache): Update.
7831         * dcache.h (struct dcache_deleter): New.
7832
7833 2019-05-08  Tom Tromey  <tom@tromey.com>
7834
7835         * symtab.c (struct symbol_cache): Add destructor and
7836         initializers.
7837         (symbol_cache_key): Move.  Change type.
7838         (make_symbol_cache, free_symbol_cache): Remove.
7839         (get_symbol_cache): Update.
7840         (symbol_cache_cleanup): Remove.
7841         (ALL_PSPACES, symbol_cache_flush)
7842         (maintenance_print_symbol_cache)
7843         (maintenance_print_symbol_cache_statistics, _initialize_symtab):
7844         Update.
7845
7846 2019-05-08  Tom Tromey  <tom@tromey.com>
7847
7848         * symtab.c (struct main_info): Add destructor and initializers.
7849         (main_progspace_key): Move.  Change type.
7850         (get_main_info): Update.
7851         (main_info_cleanup): Remove.
7852         (_initialize_symtab): Update.
7853
7854 2019-05-08  Tom Tromey  <tom@tromey.com>
7855
7856         * registry.h (DECLARE_REGISTRY): Define the _key class.
7857
7858 2019-05-08  Andrew Burgess  <andrew.burgess@embecosm.com>
7859
7860         * NEWS: Merge two 'New commands' sections.
7861
7862 2019-05-08  Joel Brobecker  <brobecker@adacore.com>
7863
7864         * ada-valprint.c (ada_val_print_gnat_array): Remove language
7865         parameter and use Ada language definition instead.
7866         (ada_val_print_ptr): Remove unused language parameter.
7867         (ada_val_print_num): Remove language parameter and use Ada language
7868         definition instead.
7869         (ada_val_print_enum, ada_val_print_flt): Remove unused language
7870         parameter.
7871         (ada_val_print_struct_union, ada_val_print_ref): Remove language
7872         parameter and use Ada language definition instead.
7873         (ada_val_print_1): Update all ada_val_print_xxx calls.
7874         Remove language parameter.
7875         (ada_val_print): Update ada_val_print_1 call.
7876
7877 2019-05-08  Tom Tromey  <tromey@adacore.com>
7878
7879         * remote.c (remote_hw_watchpoint_limit)
7880         (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
7881         Now static.
7882
7883 2019-05-08  Tom Tromey  <tromey@adacore.com>
7884
7885         * maint.c (_initialize_maint_cmds): Move initialization code to
7886         remote.c.
7887         (watchdog, show_watchdog): Move to remote.c.
7888         * remote.c (watchdog, show_watchdog): Move from maint.c.  Make
7889         "watchdog" static.
7890         (_initialize_remote): Move initialization code from maint.c.
7891         * defs.h (watchdog): Don't declare.
7892
7893 2019-05-08  Tom Tromey  <tromey@adacore.com>
7894
7895         * tui/tui-interp.c: Include main.h.
7896         * interps.c: Include main.h.
7897         * main.h (interpreter_p): Declare.
7898         * defs.h (interpreter_p): Don't declare.
7899
7900 2019-05-08  Tom Tromey  <tromey@adacore.com>
7901
7902         * dwarf2loc.c: Include dwarf2read.h.
7903         * defs.h (read_unsigned_leb128): Don't declare.
7904         * dwarf2read.h (read_unsigned_leb128): Declare.
7905
7906 2019-05-08  Tom Tromey  <tromey@adacore.com>
7907
7908         * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
7909         method.
7910
7911 2019-05-08  Tom Tromey  <tromey@adacore.com>
7912
7913         * utils.c (fputs_maybe_filtered): Reset style after paging, even
7914         when no wrap column is set.
7915
7916 2019-05-08  Tom Tromey  <tromey@adacore.com>
7917
7918         * c-lang.c (c_get_string): Handle non-C-style arrays.
7919
7920 2019-05-08  Tom Tromey  <tromey@adacore.com>
7921
7922         * typeprint.c (print_offset_data::update): Print the bit offset,
7923         not the number of bits remaining.
7924
7925 2019-05-08  Tom Tromey  <tromey@adacore.com>
7926
7927         * typeprint.c (print_offset_data::maybe_print_hole): Add extra
7928         padding at end of comment.
7929
7930 2019-05-08  Tom Tromey  <tromey@adacore.com>
7931
7932         * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
7933         Compare main types.
7934
7935 2019-05-06  Tom Tromey  <tom@tromey.com>
7936
7937         * common/scoped_mmap.c: Include common-defs.h.
7938         * common/scoped_mmap.h: Don't include config.h.
7939
7940 2019-05-04  Tom Tromey  <tom@tromey.com>
7941
7942         * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
7943         (struct aarch64_call_info): Add initializers.
7944         <si>: Now a std::vector.
7945         (pass_on_stack, aarch64_push_dummy_call): Update.
7946
7947 2019-05-04  Simon Marchi  <simon.marchi@efficios.com>
7948             Tom Tromey  <tom@tromey.com>
7949
7950         * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
7951         (ppc_threads): Now a std::vector.  Now static.
7952         (hwdebug_find_thread_points_by_tid)
7953         (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
7954         Update.
7955
7956 2019-05-04  Tom Tromey  <tom@tromey.com>
7957
7958         * arc-tdep.c (arc_tdesc_init): Return bool.
7959
7960 2019-05-04  Tom Tromey  <tom@tromey.com>
7961
7962         * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
7963         Use gdb_assert_not_reached.
7964
7965 2019-05-04  Tom Tromey  <tom@tromey.com>
7966
7967         * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
7968         "false".
7969
7970 2019-05-04  Tom Tromey  <tom@tromey.com>
7971
7972         * arc-tdep.c (arc_tdesc_init): Use bool.
7973
7974 2019-05-04  Tom Tromey  <tom@tromey.com>
7975
7976         * stack.c (select_frame_for_mi): Use "false", not "FALSE".
7977
7978 2019-05-04  Tom Tromey  <tom@tromey.com>
7979
7980         * cli/cli-cmds.c (valid_command_p): Return bool.
7981
7982 2019-05-04  Tom Tromey  <tom@tromey.com>
7983
7984         * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
7985         * command.h (valid_user_defined_cmd_name_p): Channge return type.
7986
7987 2019-05-04  Raul Tambre  <raul@tambre.ee>
7988
7989         * python/lib/gdb/prompt.py (_ExtendedPrompt)
7990         <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
7991         operator for comparison.
7992
7993 2019-05-04  Tom Tromey  <tom@tromey.com>
7994
7995         * psymtab.c (psymbol_name_matches, match_partial_symbol)
7996         (lookup_partial_symbol, print_partial_symbols)
7997         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
7998         (psymbol_compare): Update.
7999         (add_psymbol_to_bcache): Clear the entire psymbol.
8000         (maintenance_check_psymtabs): Update.
8001         * psympriv.h (struct partial_symbol): Don't derive from
8002         general_symbol_info.
8003         <obj_section, unrelocated_address, address,
8004         set_unrelocated_address>: Update.
8005         <ginfo>: New member.
8006         * dwarf-index-write.c (write_psymbols, debug_names::insert)
8007         (debug_names::write_psymbols): Update.
8008
8009 2019-05-04  Tom de Vries  <tdevries@suse.de>
8010
8011         * contrib/cc-with-tweaks.sh: Support -n arg.
8012
8013 2019-05-04  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8014
8015         * corelow.c (core_target::detach): Ensure frame cache and
8016         register caches are cleared.
8017         inferior.c (exit_inferior_1): Likewise.
8018
8019 2019-05-03  Sandra Loosemore  <sandra@codesourcery.com>
8020             Tom Tromey  <tom@tromey.com>
8021
8022         * dictionary.c (collate_pending_symbols_by_language): Remove
8023         "struct" from foreach.
8024         * symtab.c (lookup_global_symbol_from_objfile)
8025         (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
8026         foreach.
8027         * ser-tcp.c (net_open): Remove "struct" from foreach.
8028         * objfiles.c (objfile_relocate, objfile_rebase)
8029         (objfile_has_symbols): Remove "struct" from foreach.
8030         * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
8031         from foreach.
8032         * dwarf2read.c (handle_struct_member_die): Remove "struct" from
8033         foreach.
8034         * darwin-nat.c (thread_info_from_private_thread_info): Remove
8035         "struct" from foreach.
8036         * ada-lang.c (create_excep_cond_exprs)
8037         (ada_exception_catchpoint_cond_string): Remove "struct" from
8038         foreach.
8039
8040 2019-05-03  Tom Tromey  <tromey@adacore.com>
8041
8042         * ada-exp.y (convert_char_literal): Check suffix of each
8043         enumerator.
8044
8045 2019-05-03  Dilyan Palauzov  <dilyan.palauzov@aegee.org>
8046
8047         PR ada/21406:
8048         * ada-exp.y (yywrap): Don't define.
8049         * ada-lex.l (%option): Add noyywrap
8050         (yywrap): Remove.
8051
8052 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
8053
8054         * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
8055         _WIN32_WINNT to the XP level, unless already defined to a higher
8056         level.
8057
8058         * unittests/parse-connection-spec-selftests.c:
8059         * ser-tcp.c:
8060         * common/netstuff.c [USE_WIN32API]:  Remove the _WIN32_WINNT
8061         override.
8062
8063         * symfile.c (find_separate_debug_file): Remove colon from the
8064         drive spec of DOS/Windows file names of the target, so that the
8065         file name produced from DEBUGDIR and the target's directory will
8066         be valid on DOS/Windows systems.
8067
8068 2019-05-02  Andrew Burgess  <andrew.burgess@embecosm.com>
8069
8070         * rust-lang.c (val_print_struct): Handle printing structures
8071         containing strings.
8072
8073 2019-05-02  Tom Tromey  <tromey@adacore.com>
8074
8075         * valarith.c (_initialize_valarith): Remove.
8076
8077 2019-05-01  Tom Tromey  <tromey@adacore.com>
8078
8079         * ada-lang.c (ada_value_primitive_field): Treat more fields as
8080         bitfields.
8081
8082 2019-05-01  Tom Tromey  <tromey@adacore.com>
8083
8084         * ada-lang.c (ada_value_assign): Correctly compute starting offset
8085         for big-endian copies.
8086
8087 2019-04-30  Ali Tamur  <tamur@google.com>
8088         * gdb/dwarf2read.c (read_3_bytes): New declaration.
8089         (read_attribute_value): Added DW_FORM_strx1-4 cases.
8090         (read_3_bytes): New function.
8091
8092 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
8093
8094         * windows-nat.c (main_thread_id): Delete.
8095         (handle_output_debug_string): Replace main_thread_id by
8096         current_event.dwThreadId.
8097         (fake_create_process): Likewise.
8098         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
8099         Do not set main_thread_id.
8100         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
8101         current_event.dwThreadId.
8102         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
8103
8104 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
8105
8106         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
8107         Use current_event.dwThreadId instead of main_thread_id.
8108
8109 2019-04-30  Tom Tromey  <tromey@adacore.com>
8110
8111         * ada-lang.c (ada_lookup_simple_minsyms): New function.
8112         (create_excep_cond_exprs): Iterate over program spaces.
8113         (ada_exception_catchpoint_cond_string): Examine all minimal
8114         symbols for exception types.
8115
8116 2019-04-30  Tom Tromey  <tromey@adacore.com>
8117
8118         PR c++/24470:
8119         * dwarf2read.c (process_structure_scope): Handle case where type
8120         has template parameters but no symbol was created.
8121
8122 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
8123             Chris January  <chris.january@arm.com>
8124
8125         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
8126         qualifier.
8127         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
8128
8129 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
8130
8131         * f-typeprint.c (f_print_type): Update rules for printing
8132         whitespace.
8133         (f_type_print_varspec_suffix): Likewise.
8134
8135 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
8136             Chris January  <chris.january@arm.com>
8137
8138         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
8139         function arguments.
8140
8141 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
8142
8143         * f-lang.c (build_fortran_types): Change name of void type to
8144         lower case.
8145         * f-typeprint.c (f_type_print_base): Print the name of the void
8146         type, rather than a fixed string.
8147         * f-valprint.c (f_decorations): Use lower case void string.
8148
8149 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
8150             Chris January  <chris.january@arm.com>
8151
8152         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
8153         types for Fortran.
8154
8155 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
8156             Chris January  <chris.january@arm.com>
8157             David Lecomber  <david.lecomber@arm.com>
8158
8159         * f-exp.y (BINOP_INTRINSIC): New token.
8160         (exp): New parser rule handling BINOP_INTRINSIC.
8161         (f77_keywords): Add new builtin procedures.
8162         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
8163         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
8164         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
8165         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
8166         (print_unop_subexp_f): New function.
8167         (print_binop_subexp_f): New function.
8168         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
8169         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
8170         (dump_subexp_body_f): Likewise.
8171         (operator_check_f): Likewise.
8172         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
8173         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
8174
8175 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
8176
8177         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
8178         UNOP_KIND.
8179         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
8180         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
8181         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
8182         (operator_length_f): New fuction.
8183         (print_subexp_f): New function.
8184         (op_name_f): New function.
8185         (dump_subexp_body_f): New function.
8186         (operator_check_f): New function.
8187         (exp_descriptor_f): Replace standard expression handling functions
8188         with new functions.
8189         * gdb/fortran-operator.def: New file.
8190         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
8191         * gdb/std-operator.def: Remove UNOP_KIND.
8192
8193 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
8194
8195         * std-operator.def: Remove unbalanced, stray double quote
8196         character.
8197
8198 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
8199             Chris January  <chris.january@arm.com>
8200             Daniel Everett  <daniel.everett@arm.com>
8201             Nick Forrington  <nick.forrington@arm.com>
8202             Richard Bunt  <richard.bunt@arm.com>
8203
8204         * cp-valprint.c (cp_print_value_fields): Allow an additional level
8205         of depth when printing anonymous structs or unions.
8206         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
8207         Don't print either the top-level value, or the children if the
8208         max-depth is exceeded.
8209         (ppscm_print_children): When printing the key of a map, allow one
8210         extra level of depth.
8211         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
8212         print either the top-level value, or the children if the max-depth
8213         is exceeded.
8214         (print_children): When printing the key of a map, allow one extra
8215         level of depth.
8216         * python/py-value.c (valpy_format_string): Add max_depth keyword.
8217         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
8218         (user_print_options): Initialise max_depth field.
8219         (val_print_scalar_or_string_type_p): New function.
8220         (val_print): Check to see if the max depth has been reached.
8221         (val_print_check_max_depth): Define new function.
8222         (show_print_max_depth): New function.
8223         (_initialize_valprint): Add 'print max-depth' option.
8224         * valprint.h (struct value_print_options) <max_depth>: New field.
8225         (val_print_check_max_depth): Declare new function.
8226         * NEWS: Document new feature.
8227
8228 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
8229
8230         * ada-lang.c (ada_language_defn): Initialise new field.
8231         * c-lang.c (c_is_string_type_p): New function.
8232         (c_language_defn): Initialise new field.
8233         (cplus_language_defn): Initialise new field.
8234         (asm_language_defn): Initialise new field.
8235         (minimal_language_defn): Initialise new field.
8236         * c-lang.h (c_is_string_type_p): Declare new function.
8237         * d-lang.c (d_language_defn): Initialise new field.
8238         * f-lang.c (f_is_string_type_p): New function.
8239         (f_language_defn): Initialise new field.
8240         * go-lang.c (go_is_string_type_p): New function.
8241         (go_language_defn): Initialise new field.
8242         * language.c (default_is_string_type_p): New function.
8243         (unknown_language_defn): Initialise new field.
8244         (auto_language_defn): Initialise new field.
8245         * language.h (struct language_defn) <la_is_string_type_p>: New
8246         member variable.
8247         (default_is_string_type_p): Declare new function.
8248         * m2-lang.c (m2_language_defn): Initialise new field.
8249         * objc-lang.c (objc_language_defn): Initialise new field.
8250         * opencl-lang.c (opencl_language_defn): Initialise new field.
8251         * p-lang.c (pascal_is_string_type_p): New function.
8252         (pascal_language_defn): Initialise new field.
8253         * rust-lang.c (rust_is_string_type_p): New function.
8254         (rust_language_defn): Initialise new field.
8255
8256 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
8257
8258         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
8259         New field.
8260         * ada-lang.c (ada_language_defn): Initialise new field.
8261         * c-lang.c (c_language_defn): Likewise.
8262         (cplus_language_defn): Likewise.
8263         (asm_language_defn): Likewise.
8264         (minimal_language_defn): Likewise.
8265         * d-lang.c (d_language_defn): Likewise.
8266         * f-lang.c (f_language_defn): Likewise.
8267         * go-lang.c (go_language_defn): Likewise.
8268         * language.c (unknown_language_defn): Likewise.
8269         (auto_language_defn): Likewise.
8270         * m2-lang.c (m2_language_defn): Likewise.
8271         * objc-lang.c (objc_language_defn): Likewise.
8272         * opencl-lang.c (opencl_language_defn): Likewise.
8273         * p-lang.c (pascal_language_defn): Likewise.
8274         * rust-lang.c (rust_language_defn): Likewise.
8275
8276 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
8277
8278         * ada-lang.c (ada_is_character_type): Change return type to bool.
8279         (ada_is_string_type): Likewise.
8280         * ada-lang.h (ada_is_character_type): Update declaration
8281         (ada_is_string_type): Likewise.
8282
8283 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8284
8285         Support style in 'frame|thread apply'
8286
8287         * gdbcmd.h (execute_command_to_string): New term_out parameter.
8288         * record.c (record_start, record_stop): Update callers of
8289         execute_command_to_string with false.
8290         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
8291         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
8292         methods.
8293         (class string_file): New constructor with term_out parameter.
8294         Override methods term_out and can_emit_style_escape.  New member
8295         term_out.
8296         (class stdio_file): Override can_emit_style_escape.
8297         (class tee_file): Override term_out and can_emit_style_escape.
8298         * utils.h (can_emit_style_escape): Remove.
8299         * utils.c (can_emit_style_escape): Likewise.
8300         Update all callers of can_emit_style_escape (SOMESTREAM) to
8301         SOMESTREAM->can_emit_style_escape.
8302         * source-cache.c (source_cache::get_source_lines): Likewise.
8303         * stack.c (frame_apply_command_count): Call execute_command_to_string
8304         passing the term_out characteristic of the current gdb_stdout.
8305         * thread.c (thr_try_catch_cmd): Likewise.
8306         * top.c (execute_command_to_string): pass term_out parameter
8307         to construct the string_file for the command output.
8308         * ui-file.c (term_cli_styling): New function (most code moved
8309         from utils.c can_emit_style_escape).
8310         (string_file::string_file, string_file::can_emit_style_escape,
8311         stdio_file::can_emit_style_escape, tee_file::term_out,
8312         tee_file::can_emit_style_escape): New functions.
8313
8314 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8315
8316         * NEWS: Mention the new set|show may-call-functions.
8317         * infcall.c (may_call_functions_p): New variable.
8318         (show_may_call_functions_p): New function.
8319         (call_function_by_hand_dummy): Throws an error if not
8320         may-call-functions.
8321         (_initialize_infcall): Call add_setshow_boolean_cmd for
8322         may-call-functions.
8323
8324 2019-04-25  Keith Seitz  <keiths@redhat.com>
8325
8326         PR c++/24367
8327         * cp-support.c (inspect_type): Don't attempt substitutions
8328         of symbol with the same name.
8329
8330 2019-04-25  Tom Tromey  <tromey@adacore.com>
8331
8332         PR gdb/24475:
8333         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
8334         static.
8335
8336 2019-04-25  Tom Tromey  <tromey@adacore.com>
8337
8338         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
8339         rvalue reference.
8340         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
8341         (gdb_xml_parser::parse): Use std::move.
8342         * python/python-internal.h (gdbpy_convert_exception): Take a const
8343         reference.
8344         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
8345         std::move.
8346         * python/py-utils.c (gdbpy_convert_exception): Take a const
8347         reference.
8348         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
8349         Use std::move.
8350         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
8351         Use std::move.
8352         * mi/mi-main.c (mi_print_exception): Take a const reference.
8353         * main.c (handle_command_errors): Take a const reference.
8354         * linespec.c (parse_linespec): Use std::move.
8355         * infcall.c (run_inferior_call): Use std::move.
8356         (call_function_by_hand_dummy): Use std::move.
8357         * exec.c (try_open_exec_file): Use std::move.
8358         * exceptions.h (exception_print, exception_fprintf)
8359         (exception_print_same): Update.
8360         * exceptions.c (print_exception, exception_print)
8361         (exception_fprintf, exception_print_same): Change parameters to
8362         const reference.
8363         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
8364         * common/new-op.c: Use std::move.
8365         * common/common-exceptions.h (struct gdb_exception): Add move
8366         constructor.
8367         (struct gdb_exception_error, struct gdb_exception_quit, struct
8368         gdb_quit_bad_alloc): Change constructor to move constructor.
8369         (throw_exception): Change parameter to rvalue reference.
8370         * common/common-exceptions.c (throw_exception): Take rvalue
8371         reference.
8372         * cli/cli-interp.c (safe_execute_command): Use std::move.
8373         * breakpoint.c (insert_bp_location, location_to_sals): Use
8374         std::move.
8375
8376 2019-04-25  Tom Tromey  <tromey@adacore.com>
8377
8378         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
8379         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
8380         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
8381         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
8382         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
8383         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
8384         guile/scm-value.c: Use unpack.
8385         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
8386         gdbscm_gdb_exception.
8387         (gdbscm_throw_gdb_exception): Likewise.
8388         (struct gdbscm_gdb_exception): New.
8389         (unpack): New function.
8390         (gdbscm_wrap): Use unpack.
8391
8392 2019-04-25  Tom Tromey  <tromey@adacore.com>
8393
8394         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
8395         (gdb_rl_callback_handler): Use std::move.
8396         * common/common-exceptions.h (struct gdb_exception): Add move
8397         assignment operator.
8398         (throw_exception_sjlj): Change "exception" to const reference.
8399         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
8400         (throw_exception_sjlj): Change "exception" to const reference.
8401
8402 2019-04-25  Tom Tromey  <tromey@adacore.com>
8403
8404         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
8405         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
8406         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
8407         Update.
8408         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
8409         Update.
8410         * mi/mi-interp.c (mi_interp::exec): Update.
8411         * linespec.c (parse_linespec): Update.
8412         * infcall.c (run_inferior_call): Update.
8413         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
8414         * guile/scm-symbol.c (gdbscm_lookup_symbol)
8415         (gdbscm_lookup_global_symbol): Update.
8416         * guile/scm-param.c (gdbscm_parameter_value): Update.
8417         * guile/scm-frame.c (gdbscm_frame_read_register)
8418         (gdbscm_frame_read_var): Update.
8419         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
8420         * exec.c (try_open_exec_file): Update.
8421         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
8422         (gdb_rl_callback_handler): Update.
8423         * common/common-exceptions.h (exception_none): Don't declare.
8424         * common/common-exceptions.c (exception_none): Don't define.
8425         (struct catcher) <exception>: Update.
8426         * cli/cli-interp.c (safe_execute_command): Update.
8427         * breakpoint.c (insert_bp_location, location_to_sals): Update.
8428
8429 2019-04-25  Ali Tamur  <tamur@google.com>
8430
8431         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
8432         (read_attribute_value): Likewise.
8433         (dwarf2_read_addr_index): Update comment.
8434         (read_str_index): Add DW_FORM_strx.
8435         (dwarf2_string_attr): Likewise.
8436         (dwarf2_const_value_attr): Likewise.
8437         (dump_die_shallow): Likewise.
8438         (dwarf2_fetch_constant_bytes): Likewise.
8439         (skip_form_bytes): Likewise.
8440         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
8441
8442 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
8443
8444         PR corefiles/11608
8445         PR corefiles/18187
8446         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
8447         OFFSET.  Verify if current mapping contains an ELF header.
8448         (linux_find_memory_regions_full): Adjust call to
8449         dump_mapping_p.
8450
8451 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
8452             Kang Li <kanglictf@gmail.com>
8453
8454         PR gdb/21600
8455
8456         * dwarf2-frame.c (read_initial_length): Be consistent about using
8457         unsigned representation of length.
8458         (decode_frame_entry_1): Likewise.  Check for wraparound of
8459         end pointer as well as buffer overflow.
8460
8461 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
8462
8463         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
8464         "vq".
8465
8466 2019-04-24  Tom Tromey  <tromey@adacore.com>
8467
8468         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
8469
8470 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8471
8472         * s12z-tdep.c (s12z_unwind_pc): Delete.
8473         (s12z_unwind_sp): Delete.
8474         (s12z_gdbarch_init): Don't register deleted functions with
8475         gdbarch.
8476
8477 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8478
8479         * rl78-tdep.c (rl78_unwind_sp): Delete.
8480         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
8481
8482 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8483
8484         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
8485         (xstormy16_unwind_pc): Delete.
8486         (xstormy16_dummy_id): Delete.
8487         (xstormy16_gdbarch_init): Don't register deleted functions with
8488         gdbarch.
8489
8490 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8491
8492         * vax-tdep.c (vax_unwind_pc): Delete.
8493         (vax_gdbarch_init): Don't register deleted function with gdbarch.
8494
8495 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8496
8497         * v850-tdep.c (v850_unwind_sp): Delete.
8498         (v850_unwind_pc): Delete.
8499         (v850_dummy_id): Delete.
8500         (v850_gdbarch_init): Don't register deleted functions with
8501         gdbarch.
8502
8503 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8504
8505         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
8506         (tilegx_unwind_pc): Delete.
8507         (tilegx_unwind_dummy_id): Delete.
8508         (tilegx_gdbarch_init): Don't register deleted functions with
8509         gdbarch.
8510
8511 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8512
8513         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
8514         (tic6x_dummy_id): Delete.
8515         (tic6x_gdbarch_init): Don't register deleted functions with
8516         gdbarch.
8517
8518 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8519
8520         * sparc-tdep.c (sparc_unwind_pc): Delete.
8521         (sparc32_gdbarch_init): Don't register deleted function with
8522         gdbarch.
8523
8524 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8525
8526         * sh-tdep.c (sh_unwind_sp): Delete.
8527         (sh_unwind_pc): Delete.
8528         (sh_dummy_id): Delete.
8529         (sh_gdbarch_init): Don't register deleted functions with
8530         gdbarch.
8531
8532 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8533
8534         * score-tdep.c (score_unwind_sp): Delete.
8535         (score_unwind_pc): Delete.
8536         (score_dummy_id): Delete.
8537         (score_gdbarch_init): Don't register deleted functions with
8538         gdbarch.
8539
8540 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8541
8542         * rx-tdep.c (rx_unwind_pc): Delete.
8543         (rx_unwind_sp): Delete.
8544         (rx_dummy_id): Delete.
8545         (rx_gdbarch_init): Don't register deleted functions with
8546         gdbarch.  Update comment.
8547
8548 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8549
8550         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
8551         (rs6000_dummy_id): Delete.
8552         (rs6000_gdbarch_init): Don't register deleted functions with
8553         gdbarch.
8554
8555 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8556
8557         * or1k-tdep.c (or1k_dummy_id): Delete.
8558         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
8559
8560 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8561
8562         * nios2-tdep.c (nios2_dummy_id): Delete.
8563         (nios2_unwind_sp): Delete.
8564         (nios2_gdbarch_init): Don't register deleted functions with
8565         gdbarch.
8566
8567 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8568
8569         * nds32-tdep.c (nds32_dummy_id): Delete.
8570         (nds32_unwind_pc): Delete.
8571         (nds32_unwind_sp): Delete.
8572         (nds32_gdbarch_init): Don't register deleted functions with
8573         gdbarch.
8574
8575 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8576
8577         * msp430-tdep.c (msp430_unwind_pc): Delete.
8578         (msp430_unwind_sp): Delete.
8579         (msp430_dummy_id): Delete.
8580         (msp430_gdbarch_init): Don't register deleted functions with
8581         gdbarch.
8582
8583 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8584
8585         * moxie-tdep.c (moxie_unwind_sp): Delete.
8586         (moxie_unwind_pc): Delete.
8587         (moxie_dummy_id): Delete.
8588         (moxie_gdbarch_init): Don't register deleted functions with
8589         gdbarch.
8590
8591 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8592
8593         * mn10300-tdep.c (mn10300_dummy_id): Delete.
8594         (mn10300_unwind_pc): Delete.
8595         (mn10300_unwind_sp): Delete.
8596         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
8597         mn10300_unwind_sp.
8598         (mn10300_frame_unwind_init): Don't register deleted functions with
8599         gdbarch.
8600
8601 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8602
8603         * mep-tdep.c (mep_unwind_pc): Delete.
8604         (mep_unwind_sp): Delete.
8605         (mep_dummy_id): Delete.
8606         (mep_gdbarch_init): Don't register deleted functions with
8607         gdbarch.
8608
8609 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8610
8611         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
8612         (m68hc11_unwind_sp): Delete.
8613         (m68hc11_gdbarch_init): Don't register deleted functions with
8614         gdbarch.
8615
8616 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8617
8618         * m32r-tdep.c (m32r_unwind_sp): Delete.
8619         (m32r_unwind_pc): Delete.
8620         (m32r_dummy_id): Delete.
8621         (m32r_gdbarch_init): Don't register deleted functions with
8622         gdbarch.
8623
8624 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8625
8626         * m32c-tdep.c (m32c_unwind_pc): Delete.
8627         (m32c_unwind_sp): Delete.
8628         (m32c_dummy_id): Delete.
8629         (m32c_gdbarch_init): Don't register deleted functions with
8630         gdbarch.
8631
8632 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8633
8634         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
8635         (lm32_unwind_pc): Delete.
8636         (lm32_dummy_id): Delete.
8637         (lm32_gdbarch_init): Don't register deleted functions with
8638         gdbarch.
8639
8640 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8641
8642         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
8643         (iq2000_unwind_pc): Delete.
8644         (iq2000_dummy_id): Delete.
8645         (iq2000_gdbarch_init): Don't register deleted functions with
8646         gdbarch.
8647
8648 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8649
8650         * nds32-tdep.c (nds32_type_align): Delete.
8651         (nds32_push_dummy_call): Use type_align instead.
8652
8653 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8654
8655         * arm-tdep.c (arm_type_align): Only handle vector override case.
8656         (arm_push_dummy_call): Use type_align.
8657         (arm_gdbarch_init): Register arm_type_align gdbarch function.
8658
8659 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8660
8661         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
8662         case.
8663         (pass_on_stack): Use type_align.
8664         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
8665         function.
8666
8667 2019-04-23  Tom Tromey  <tromey@adacore.com>
8668
8669         * dwarf2read.c (line_header::file_name_at): Remove unused
8670         overload.
8671
8672 2019-04-23  Tom de Vries  <tdevries@suse.de>
8673
8674         PR gdb/24438
8675         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
8676         invocation.
8677
8678
8679 2019-03-27  Ali Tamur  <tamur@google.com>
8680
8681         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
8682         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
8683         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
8684         (dwarf_expr_context::get_addr_index): Likewise
8685         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
8686         (symbol_needs_eval_context::get_addr_index): Likewise
8687         (disassemble_dwarf_expression): Add DW_OP_addrx
8688         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
8689         (read_cutu_die_from_dwo): Update comment
8690         (skip_one_die): Add DW_FORM_addrx
8691         (read_attribute_value): Likewise
8692         (var_decode_location): Add DW_OP_addrx
8693         (dwarf2_const_value_attr): Add DW_FORM_addrx
8694         (dump_die_shallow): Likewise
8695         (dwarf2_fetch_constant_bytes): Likewise
8696         (decode_locdesc): Add DW_OP_addrx
8697         (skip_form_bytes): Add DW_FORM_addrx
8698
8699 2019-04-22  Ali Tamur  <tamur@google.com>
8700
8701         * MAINTAINERS (Write After Approval): Add self.
8702
8703 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
8704
8705         * solib-svr4.c (get_svr4_info): Add pspace parameter.
8706         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
8707         (open_symbol_file_object): Likewise.
8708         (svr4_default_sos): Add info parameter.
8709         (svr4_read_so_list): Likewise.
8710         (svr4_current_sos_direct): Adjust functions calls to pass down
8711         info.
8712         (svr4_current_sos_1): Add info parameter.
8713         (svr4_current_sos): Call get_svr4_info, pass info down to
8714         svr4_current_sos_1.
8715         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
8716         get_svr4_info.
8717         (svr4_in_dynsym_resolve_code): Pass current_program_space to
8718         get_svr4_info.
8719         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
8720         to get_svr4_info.
8721         (probes_table_remove_objfile_probes): Likewise.
8722         (register_solib_event_probe): Add info parameter.
8723         (solist_update_incremental): Pass info parameter down to
8724         svr4_read_so_list.
8725         (disable_probes_interface): Add info parameter.
8726         (svr4_handle_solib_event): Pass current_program_space to
8727         get_svr4_info.  Adjust disable_probes_interface cleanup.
8728         (svr4_create_probe_breakpoints): Add info parameter, pass it
8729         down to register_solib_event_probe.
8730         (svr4_create_solib_event_breakpoints): Add info parameter,
8731         pass it down to svr4_create_probe_breakpoints.
8732         (enable_break): Pass info down to
8733         svr4_create_solib_event_breakpoints.
8734         (svr4_solib_create_inferior_hook): Pass current_program_space to
8735         get_svr4_info.
8736         (svr4_clear_solib): Likewise.
8737
8738 2019-04-22  Pedro Alves  <palves@redhat.com>
8739
8740         * solib-svr4.c (svr4_free_objfile_observer): New.
8741         (probe_and_action::objfile): New field.
8742         (probes_table_htab_remove_objfile_probes)
8743         (probes_table_remove_objfile_probes): New functions.
8744         (register_solib_event_probe): Add 'objfile' parameter.  Store it
8745         in the new probe_and_action.  Don't store the probe in 'lookup'.
8746         (svr4_create_probe_breakpoints): Pass objfile to
8747         register_solib_event_probe.
8748         (_initialize_svr4_solib): Register a free_objfile observer.
8749
8750 2019-04-19  Tom Tromey  <tom@tromey.com>
8751
8752         * common/queue.h: Remove.
8753
8754 2019-04-19  Tom Tromey  <tom@tromey.com>
8755
8756         * event-loop.c: Don't include "common/queue.h".
8757
8758 2019-04-19  Tom Tromey  <tom@tromey.com>
8759
8760         * remote.c (remote_target): Use delete.
8761         * remote-notif.h: Include <list>, not "common/queue.h".
8762         (notif_client_p): Remove typedef.
8763         (remote_notif_state): Add constructor, destructor, initializer.
8764         <notif_queue>: Now a std::list.
8765         (remote_notif_state_xfree): Don't declare.
8766         * remote-notif.c (remote_notif_process, handle_notification)
8767         (remote_notif_state_allocate): Update.
8768         (~remote_notif_state): Rename from remote_notif_state_xfree.
8769
8770 2019-04-19  Tom Tromey  <tom@tromey.com>
8771
8772         * symfile.c (reread_symbols): Update.
8773         * objfiles.c (objfile_register_static_link)
8774         (objfile_lookup_static_link): Update
8775         (~objfile) Don't delete static_links.
8776         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
8777
8778 2019-04-19  Tom Tromey  <tom@tromey.com>
8779
8780         * type-stack.h (struct type_stack) <insert>: Constify string.
8781         * type-stack.c (type_stack::insert): Constify string.
8782         * gdbtypes.h (lookup_template_type): Update.
8783         (address_space_name_to_int): Update.
8784         * gdbtypes.c (address_space_name_to_int): Make space_identifier
8785         const.
8786         (lookup_template_type): Make name const.
8787         * c-exp.y: Update rules.
8788         (lex_one_token, classify_name, classify_inner_name)
8789         (c_print_token): Update.
8790         * p-exp.y: Update rules.
8791         (yylex): Update.
8792         * f-exp.y: Update rules.
8793         (yylex): Update.
8794         * d-exp.y: Update rules.
8795         (lex_one_token, classify_name, classify_inner_name): Update.
8796         * parse.c (write_dollar_variable, copy_name): Return std::string.
8797         * parser-defs.h (copy_name): Change return type.
8798         * m2-exp.y: Update rules.
8799         (yylex): Update.
8800         * go-exp.y (lex_one_token): Update.
8801         Update rules.
8802         (classify_unsafe_function, classify_packaged_name)
8803         (classify_name, yylex): Update.
8804
8805 2019-04-19  Sergei Trofimovich <siarheit@google.com>
8806
8807         * configure.ac: add --enable-source-highlight switch.
8808         * configure: Regenerate.
8809         * top.c (print_gdb_version): plumb --enable-source-highlight
8810         status to "show configuration".
8811
8812 2019-04-19  Tom Tromey  <tromey@adacore.com>
8813
8814         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
8815         Check ADA_TYPE_P.
8816         (empty_record, ada_template_to_fixed_record_type_1)
8817         (template_to_static_fixed_type)
8818         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
8819         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
8820         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
8821         macros.
8822
8823 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
8824
8825         PR symtab/24423:
8826         * source.c (print_source_lines_base): Advance "iter" when a
8827         control character is seen.
8828
8829 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8830
8831         * inferior.h (struct infcall_suspend_state_deleter):
8832         Catch exception in destructor to avoid crash.
8833
8834 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8835
8836         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
8837         close to the add_com "shell".
8838
8839 2019-04-18  Tom Tromey  <tromey@adacore.com>
8840
8841         * process-stratum-target.h (class process_stratum_target)
8842         <stratum>: Add "final".
8843
8844 2019-04-17  Tom Tromey  <tromey@adacore.com>
8845
8846         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
8847         against nullptr before use.
8848
8849 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
8850
8851         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
8852
8853 2019-04-17  Jim Wilson  <jimw@sifive.com>
8854             Andrew Burgess  <andrew.burgess@embecosm.com>
8855
8856         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
8857         code read might fail, assume 4-byte breakpoint in that case.
8858
8859 2019-04-15  Leszek Swirski  <leszeks@google.com>
8860
8861         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
8862         rather than a hand-rolled POD check when checking for forced MEMORY
8863         classification.
8864
8865 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
8866
8867         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
8868         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
8869         function.
8870         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
8871         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
8872         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
8873         declaration.
8874
8875 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
8876
8877         * aarch64-linux-nat.c
8878         (aarch64_linux_nat_target::thread_architecture): Add override.
8879         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
8880         each VQ.
8881
8882 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
8883
8884         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
8885
8886 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
8887
8888         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
8889         target types of size 96-bits, add some additional comments, and
8890         check that the builtin type we found was the correct size.
8891
8892 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
8893
8894         * utils.c (prompt_for_continue): Don't restore the styling at the
8895         end, as applied_style has the wrong value.  This fixes styling in
8896         long lists of file names that are interrupted by the "Continue?"
8897         prompt.
8898
8899 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
8900
8901         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
8902         * c-lang.c (c_language_defn): Likewise.
8903         (cplus_language_defn): Likewise.
8904         (asm_language_defn): Likewise.
8905         (minimal_language_defn): Likewise.
8906         * d-lang.c (d_language_defn): Likewise.
8907         * f-lang.c (f_language_defn): Likewise.
8908         * go-lang.c (go_language_defn): Likewise.
8909         * language.c (unknown_language_defn): Likewise.
8910         (auto_language_defn): Likewise.
8911         * language.h (struct language_defn): Remove la_magic field.
8912         (LANG_MAGIC): Delete.
8913         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
8914         * objc-lang.c (objc_language_defn): Likewise.
8915         * opencl-lang.c (opencl_language_defn): Likewise.
8916         * p-lang.c (pascal_language_defn): Likewise.
8917         * rust-lang.c (rust_language_defn): Likewise.
8918
8919 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
8920
8921         * riscv-tdep.c (riscv_type_align): New function.
8922         (riscv_type_alignment): Delete.
8923         (riscv_arg_location): Use 'type_align'.
8924         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
8925
8926 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
8927
8928         * gdbtypes.c (type_align): A struct with no non-static fields also
8929         has alignment of 1.
8930
8931 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
8932
8933         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
8934         component to 0.
8935         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
8936         member.
8937         (riscv_struct_info::analyse): New implementation using new
8938         analyse_inner member function.
8939         (riscv_struct_info::field_offset): New member function.
8940         (riscv_struct_info::m_offsets): New member variable.
8941         (riscv_struct_info::analyse_inner): New private member function,
8942         takes the old implementation of riscv_struct_info::analyse but
8943         extended to track field offsets.
8944         (riscv_call_arg_struct): Update the struct folding special cases
8945         to handle cases where empty C++ structs, which are non-zero
8946         length, are found.
8947         (riscv_arg_location): Initialise the length of each location, a
8948         non-zero length now indicates the location is in use.
8949         (riscv_push_dummy_call): Allow for the first location having a
8950         non-zero offset when setting up arguments.
8951         (riscv_return_value): Likewise, but for return values.
8952
8953 2019-04-11  Tom Tromey  <tromey@adacore.com>
8954
8955         * utils.c (internal_vproblem): Make "msg" const.
8956
8957 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
8958
8959         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
8960         * trad-frame.c (trad_frame_reset_saved_regs): New function.
8961         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
8962         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
8963
8964 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
8965
8966         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
8967         function.
8968         (fill_gregset): Call amd64_linux_collect_native_gregset instead
8969         of amd64_collect_native_gregset.
8970         (amd64_linux_nat_target::store_registers): Likewise.
8971
8972 2019-04-10  Tom Tromey  <tom@tromey.com>
8973
8974         * symtab.c (lookup_global_symbol_from_objfile)
8975         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
8976         * objfiles.h (class separate_debug_iterator): New.
8977         (class separate_debug_range): New.
8978         (struct objfile) <separate_debug_objfiles>: New method.
8979         (objfile_separate_debug_iterate): Don't declare.
8980         * objfiles.c (separate_debug_iterator::operator++): Rename from
8981         objfile_separate_debug_iterate.
8982         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
8983         iterator.
8984         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
8985         iterator.
8986
8987 2019-04-10  Tom Tromey  <tom@tromey.com>
8988
8989         * symfile.c (reread_symbols): Remove old comment.
8990         * objfiles.c (free_all_objfiles): Fix a typo.
8991
8992 2019-04-10  Tom Tromey  <tom@tromey.com>
8993
8994         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
8995         * minsyms.c (lookup_minimal_symbol): Use foreach.
8996         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
8997         (lookup_minimal_symbol_solib_trampoline): Likewise.
8998         * symfile.c (reread_symbols): Use foreach.
8999
9000 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
9001             Tom Tromey  <tromey@adacore.com>
9002
9003         PR rust/24414:
9004         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
9005         (rust_lex_int_test): Change "value" to be LONGEST.
9006         (rust_lex_tests): Add test for long integer literal.
9007
9008 2019-04-09  Tom Tromey  <tromey@adacore.com>
9009
9010         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
9011         to bool.
9012         (extended_remote_target::attach): Update.
9013         (remote_target::remote_notice_new_inferior): Update.
9014         (remote_target::add_current_inferior_and_thread): Update.
9015         * inferior.c (exit_inferior_1): Use "false".
9016         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
9017
9018 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
9019
9020         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
9021         the "start" command.
9022
9023 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
9024
9025         * python/py-inferior.c (infpy_thread_from_thread_handle):
9026         Adjust comments to reflect renaming of thread_from_thread_handle
9027         to thread_from_handle.  Adjust keywords.  Fix type error message.
9028         (inferior_object_methods): Add thread_from_handle.  Retain
9029         thread_from_thread_handle, but mark it as deprecated.
9030
9031 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
9032
9033         * gdbthread.h (find_thread_by_handle): Revise declaration.
9034         * thread.c (find_thread_by_handle): Likewise.  Adjust
9035         implementation too.
9036         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
9037         support for buffer objects as handles.
9038
9039 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
9040
9041         * python/py-infthread.c (thpy_thread_handle): New function.
9042         (thread_object_methods): Register thpy_thread_handle.
9043
9044 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
9045
9046         * gdbthread.h (thread_to_thread_handle): Declare.
9047         * thread.c (gdbtypes.h): Include.
9048         (thread_to_thread_handle): New function.
9049
9050         * target.h (struct target_ops): Add thread_info_to_thread_handle.
9051         (target_thread_info_to_thread_handle): Declare.
9052         * target.c (target_thread_info_to_thread_handle): New function.
9053         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
9054         * target-delegates.c: Regenerate.
9055
9056         * linux-thread-db.c (class thread_db_target): Add method
9057         thread_info_to_thread_handle.
9058         (thread_db_target::thread_info_to_thread_handle): Define.
9059         * remote.c (class remote_target): Add new method
9060         thread_info_to_thread_handle.
9061         (remote_target::thread_info_to_thread_handle): Define.
9062
9063 2019-04-08  Pedro Alves  <palves@redhat.com>
9064
9065         * common/common-exceptions.c (throw_exception): Don't create
9066         named object to throw; throw directly.
9067         (throw_it): Likewise.  Don't initialize gdb_exception::message
9068         here, with new; pass FMT and AP to the ctor instead.
9069         * common/common-exceptions.h: Include <string>.
9070         (gdb_exception::gdb_exception(enum return_reason, enum errors,
9071         const char *, va_list)): New ctor.  Use std::make_shared.
9072         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
9073         errors)): Delete.
9074         (gdb_exception_error::gdb_exception_error(enum errors, const char
9075         *, va_list)): New.
9076         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
9077         Add assertion.
9078         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
9079         errors)): Delete.
9080         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
9081         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
9082         Add assertion.
9083
9084 2019-04-08  Tom Tromey  <tom@tromey.com>
9085
9086         * valops.c (value_rtti_indirect_type): Replace throw_exception
9087         with throw.
9088         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
9089         with throw.
9090         * thread.c (thr_try_catch_cmd): Replace throw_exception with
9091         throw.
9092         * target.c (target_translate_tls_address): Replace throw_exception
9093         with throw.
9094         * stack.c (frame_apply_command_count): Replace throw_exception
9095         with throw.
9096         * solib-spu.c (append_ocl_sos): Replace throw_exception with
9097         throw.
9098         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
9099         with throw.
9100         * rs6000-tdep.c (rs6000_frame_cache)
9101         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
9102         * remote.c: Replace throw_exception with throw.
9103         * record-full.c (record_full_message, record_full_wait_1)
9104         (record_full_restore): Replace throw_exception with throw.
9105         * record-btrace.c:
9106         (get_thread_current_frame_id, record_btrace_start_replaying)
9107         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
9108         (cmd_record_btrace_start): Replace throw_exception with throw.
9109         * parse.c (parse_exp_in_context_1): Replace throw_exception with
9110         throw.
9111         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
9112         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
9113         * linespec.c:
9114         (find_linespec_symbols): Replace throw_exception with throw.
9115         * infrun.c (displaced_step_prepare, resume): Replace
9116         throw_exception with throw.
9117         * infcmd.c (post_create_inferior): Replace throw_exception with
9118         throw.
9119         * inf-loop.c (inferior_event_handler): Replace throw_exception
9120         with throw.
9121         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
9122         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
9123         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
9124         (get_prev_frame_always, get_frame_pc_if_available)
9125         (get_frame_address_in_block_if_available, get_frame_language):
9126         Replace throw_exception with throw.
9127         * frame-unwind.c (frame_unwind_try_unwinder): Replace
9128         throw_exception with throw.
9129         * eval.c (fetch_subexp_value, evaluate_var_value)
9130         (evaluate_funcall, evaluate_subexp_standard): Replace
9131         throw_exception with throw.
9132         * dwarf2loc.c (call_site_find_chain)
9133         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
9134         Replace throw_exception with throw.
9135         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
9136         with throw.
9137         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
9138         throw.
9139         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
9140         * completer.c (complete_line_internal): Replace throw_exception
9141         with throw.
9142         * compile/compile-object-run.c (compile_object_run): Replace
9143         throw_exception with throw.
9144         * cli/cli-script.c (process_next_line): Replace throw_exception
9145         with throw.
9146         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
9147         (btrace_enable, btrace_maint_update_pt_packets): Replace
9148         throw_exception with throw.
9149         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
9150         throw_exception with throw.
9151         * break-catch-throw.c (re_set_exception_catchpoint): Replace
9152         throw_exception with throw.
9153         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
9154         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
9155         * aarch64-tdep.c (aarch64_make_prologue_cache)
9156         (aarch64_make_stub_cache): Replace throw_exception with throw.
9157
9158 2019-04-08  Tom Tromey  <tom@tromey.com>
9159
9160         * common/common-exceptions.c (throw_exception): Rename from
9161         throw_exception_cxx.  Remove old copy.  Make argument const.
9162         (throw_it): Create and throw exception objects directly.
9163         * common/common-exceptions.h (throw_exception): Make argument
9164         const.
9165         (struct gdb_exception_error): Add constructor.
9166         (struct gdb_exception_quit): Add constructor.
9167
9168 2019-04-08  Tom Tromey  <tom@tromey.com>
9169
9170         * common/common-exceptions.h (exception_rethrow): Don't declare.
9171         (TRY_SJLJ): Update comment.
9172         (TRY, CATCH, END_CATCH): Remove.
9173         * common/common-exceptions.c (exception_rethrow): Remove.
9174
9175 2019-04-08  Tom Tromey  <tom@tromey.com>
9176
9177         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
9178         Remove.
9179         (gdb_exception_error): Rename from
9180         gdb_exception_RETURN_MASK_ERROR.
9181         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
9182         (gdb_quit_bad_alloc): Update.
9183         * aarch64-tdep.c: Update.
9184         * ada-lang.c: Update.
9185         * ada-typeprint.c: Update.
9186         * ada-valprint.c: Update.
9187         * amd64-tdep.c: Update.
9188         * arch-utils.c: Update.
9189         * break-catch-throw.c: Update.
9190         * breakpoint.c: Update.
9191         * btrace.c: Update.
9192         * c-varobj.c: Update.
9193         * cli/cli-cmds.c: Update.
9194         * cli/cli-interp.c: Update.
9195         * cli/cli-script.c: Update.
9196         * common/common-exceptions.c: Update.
9197         * common/new-op.c: Update.
9198         * common/selftest.c: Update.
9199         * compile/compile-c-symbols.c: Update.
9200         * compile/compile-cplus-symbols.c: Update.
9201         * compile/compile-object-load.c: Update.
9202         * compile/compile-object-run.c: Update.
9203         * completer.c: Update.
9204         * corelow.c: Update.
9205         * cp-abi.c: Update.
9206         * cp-support.c: Update.
9207         * cp-valprint.c: Update.
9208         * darwin-nat.c: Update.
9209         * disasm-selftests.c: Update.
9210         * dtrace-probe.c: Update.
9211         * dwarf-index-cache.c: Update.
9212         * dwarf-index-write.c: Update.
9213         * dwarf2-frame-tailcall.c: Update.
9214         * dwarf2-frame.c: Update.
9215         * dwarf2loc.c: Update.
9216         * dwarf2read.c: Update.
9217         * eval.c: Update.
9218         * event-loop.c: Update.
9219         * event-top.c: Update.
9220         * exec.c: Update.
9221         * f-valprint.c: Update.
9222         * fbsd-tdep.c: Update.
9223         * frame-unwind.c: Update.
9224         * frame.c: Update.
9225         * gdbtypes.c: Update.
9226         * gnu-v3-abi.c: Update.
9227         * guile/guile-internal.h: Update.
9228         * guile/scm-block.c: Update.
9229         * guile/scm-breakpoint.c: Update.
9230         * guile/scm-cmd.c: Update.
9231         * guile/scm-disasm.c: Update.
9232         * guile/scm-frame.c: Update.
9233         * guile/scm-lazy-string.c: Update.
9234         * guile/scm-math.c: Update.
9235         * guile/scm-param.c: Update.
9236         * guile/scm-ports.c: Update.
9237         * guile/scm-pretty-print.c: Update.
9238         * guile/scm-symbol.c: Update.
9239         * guile/scm-symtab.c: Update.
9240         * guile/scm-type.c: Update.
9241         * guile/scm-value.c: Update.
9242         * i386-linux-tdep.c: Update.
9243         * i386-tdep.c: Update.
9244         * inf-loop.c: Update.
9245         * infcall.c: Update.
9246         * infcmd.c: Update.
9247         * infrun.c: Update.
9248         * jit.c: Update.
9249         * language.c: Update.
9250         * linespec.c: Update.
9251         * linux-fork.c: Update.
9252         * linux-nat.c: Update.
9253         * linux-tdep.c: Update.
9254         * linux-thread-db.c: Update.
9255         * main.c: Update.
9256         * mi/mi-cmd-break.c: Update.
9257         * mi/mi-cmd-stack.c: Update.
9258         * mi/mi-interp.c: Update.
9259         * mi/mi-main.c: Update.
9260         * objc-lang.c: Update.
9261         * p-valprint.c: Update.
9262         * parse.c: Update.
9263         * ppc-linux-tdep.c: Update.
9264         * printcmd.c: Update.
9265         * python/py-arch.c: Update.
9266         * python/py-breakpoint.c: Update.
9267         * python/py-cmd.c: Update.
9268         * python/py-finishbreakpoint.c: Update.
9269         * python/py-frame.c: Update.
9270         * python/py-framefilter.c: Update.
9271         * python/py-gdb-readline.c: Update.
9272         * python/py-inferior.c: Update.
9273         * python/py-infthread.c: Update.
9274         * python/py-lazy-string.c: Update.
9275         * python/py-linetable.c: Update.
9276         * python/py-objfile.c: Update.
9277         * python/py-param.c: Update.
9278         * python/py-prettyprint.c: Update.
9279         * python/py-progspace.c: Update.
9280         * python/py-record-btrace.c: Update.
9281         * python/py-record.c: Update.
9282         * python/py-symbol.c: Update.
9283         * python/py-type.c: Update.
9284         * python/py-unwind.c: Update.
9285         * python/py-utils.c: Update.
9286         * python/py-value.c: Update.
9287         * python/python.c: Update.
9288         * record-btrace.c: Update.
9289         * record-full.c: Update.
9290         * remote-fileio.c: Update.
9291         * remote.c: Update.
9292         * riscv-tdep.c: Update.
9293         * rs6000-aix-tdep.c: Update.
9294         * rs6000-tdep.c: Update.
9295         * rust-exp.y: Update.
9296         * rust-lang.c: Update.
9297         * s390-tdep.c: Update.
9298         * selftest-arch.c: Update.
9299         * solib-dsbt.c: Update.
9300         * solib-frv.c: Update.
9301         * solib-spu.c: Update.
9302         * solib-svr4.c: Update.
9303         * solib.c: Update.
9304         * sparc64-linux-tdep.c: Update.
9305         * stack.c: Update.
9306         * symfile-mem.c: Update.
9307         * symmisc.c: Update.
9308         * target.c: Update.
9309         * thread.c: Update.
9310         * top.c: Update.
9311         * tracefile-tfile.c: Update.
9312         * tui/tui.c: Update.
9313         * typeprint.c: Update.
9314         * unittests/cli-utils-selftests.c: Update.
9315         * unittests/parse-connection-spec-selftests.c: Update.
9316         * valops.c: Update.
9317         * valprint.c: Update.
9318         * value.c: Update.
9319         * varobj.c: Update.
9320         * windows-nat.c: Update.
9321         * x86-linux-nat.c: Update.
9322         * xml-support.c: Update.
9323
9324 2019-04-08  Tom Tromey  <tom@tromey.com>
9325
9326         * xml-support.c: Use C++ exception handling.
9327         * x86-linux-nat.c: Use C++ exception handling.
9328         * windows-nat.c: Use C++ exception handling.
9329         * varobj.c: Use C++ exception handling.
9330         * value.c: Use C++ exception handling.
9331         * valprint.c: Use C++ exception handling.
9332         * valops.c: Use C++ exception handling.
9333         * unittests/parse-connection-spec-selftests.c: Use C++ exception
9334         handling.
9335         * unittests/cli-utils-selftests.c: Use C++ exception handling.
9336         * typeprint.c: Use C++ exception handling.
9337         * tui/tui.c: Use C++ exception handling.
9338         * tracefile-tfile.c: Use C++ exception handling.
9339         * top.c: Use C++ exception handling.
9340         * thread.c: Use C++ exception handling.
9341         * target.c: Use C++ exception handling.
9342         * symmisc.c: Use C++ exception handling.
9343         * symfile-mem.c: Use C++ exception handling.
9344         * stack.c: Use C++ exception handling.
9345         * sparc64-linux-tdep.c: Use C++ exception handling.
9346         * solib.c: Use C++ exception handling.
9347         * solib-svr4.c: Use C++ exception handling.
9348         * solib-spu.c: Use C++ exception handling.
9349         * solib-frv.c: Use C++ exception handling.
9350         * solib-dsbt.c: Use C++ exception handling.
9351         * selftest-arch.c: Use C++ exception handling.
9352         * s390-tdep.c: Use C++ exception handling.
9353         * rust-lang.c: Use C++ exception handling.
9354         * rust-exp.y: Use C++ exception handling.
9355         * rs6000-tdep.c: Use C++ exception handling.
9356         * rs6000-aix-tdep.c: Use C++ exception handling.
9357         * riscv-tdep.c: Use C++ exception handling.
9358         * remote.c: Use C++ exception handling.
9359         * remote-fileio.c: Use C++ exception handling.
9360         * record-full.c: Use C++ exception handling.
9361         * record-btrace.c: Use C++ exception handling.
9362         * python/python.c: Use C++ exception handling.
9363         * python/py-value.c: Use C++ exception handling.
9364         * python/py-utils.c: Use C++ exception handling.
9365         * python/py-unwind.c: Use C++ exception handling.
9366         * python/py-type.c: Use C++ exception handling.
9367         * python/py-symbol.c: Use C++ exception handling.
9368         * python/py-record.c: Use C++ exception handling.
9369         * python/py-record-btrace.c: Use C++ exception handling.
9370         * python/py-progspace.c: Use C++ exception handling.
9371         * python/py-prettyprint.c: Use C++ exception handling.
9372         * python/py-param.c: Use C++ exception handling.
9373         * python/py-objfile.c: Use C++ exception handling.
9374         * python/py-linetable.c: Use C++ exception handling.
9375         * python/py-lazy-string.c: Use C++ exception handling.
9376         * python/py-infthread.c: Use C++ exception handling.
9377         * python/py-inferior.c: Use C++ exception handling.
9378         * python/py-gdb-readline.c: Use C++ exception handling.
9379         * python/py-framefilter.c: Use C++ exception handling.
9380         * python/py-frame.c: Use C++ exception handling.
9381         * python/py-finishbreakpoint.c: Use C++ exception handling.
9382         * python/py-cmd.c: Use C++ exception handling.
9383         * python/py-breakpoint.c: Use C++ exception handling.
9384         * python/py-arch.c: Use C++ exception handling.
9385         * printcmd.c: Use C++ exception handling.
9386         * ppc-linux-tdep.c: Use C++ exception handling.
9387         * parse.c: Use C++ exception handling.
9388         * p-valprint.c: Use C++ exception handling.
9389         * objc-lang.c: Use C++ exception handling.
9390         * mi/mi-main.c: Use C++ exception handling.
9391         * mi/mi-interp.c: Use C++ exception handling.
9392         * mi/mi-cmd-stack.c: Use C++ exception handling.
9393         * mi/mi-cmd-break.c: Use C++ exception handling.
9394         * main.c: Use C++ exception handling.
9395         * linux-thread-db.c: Use C++ exception handling.
9396         * linux-tdep.c: Use C++ exception handling.
9397         * linux-nat.c: Use C++ exception handling.
9398         * linux-fork.c: Use C++ exception handling.
9399         * linespec.c: Use C++ exception handling.
9400         * language.c: Use C++ exception handling.
9401         * jit.c: Use C++ exception handling.
9402         * infrun.c: Use C++ exception handling.
9403         * infcmd.c: Use C++ exception handling.
9404         * infcall.c: Use C++ exception handling.
9405         * inf-loop.c: Use C++ exception handling.
9406         * i386-tdep.c: Use C++ exception handling.
9407         * i386-linux-tdep.c: Use C++ exception handling.
9408         * guile/scm-value.c: Use C++ exception handling.
9409         * guile/scm-type.c: Use C++ exception handling.
9410         * guile/scm-symtab.c: Use C++ exception handling.
9411         * guile/scm-symbol.c: Use C++ exception handling.
9412         * guile/scm-pretty-print.c: Use C++ exception handling.
9413         * guile/scm-ports.c: Use C++ exception handling.
9414         * guile/scm-param.c: Use C++ exception handling.
9415         * guile/scm-math.c: Use C++ exception handling.
9416         * guile/scm-lazy-string.c: Use C++ exception handling.
9417         * guile/scm-frame.c: Use C++ exception handling.
9418         * guile/scm-disasm.c: Use C++ exception handling.
9419         * guile/scm-cmd.c: Use C++ exception handling.
9420         * guile/scm-breakpoint.c: Use C++ exception handling.
9421         * guile/scm-block.c: Use C++ exception handling.
9422         * guile/guile-internal.h: Use C++ exception handling.
9423         * gnu-v3-abi.c: Use C++ exception handling.
9424         * gdbtypes.c: Use C++ exception handling.
9425         * frame.c: Use C++ exception handling.
9426         * frame-unwind.c: Use C++ exception handling.
9427         * fbsd-tdep.c: Use C++ exception handling.
9428         * f-valprint.c: Use C++ exception handling.
9429         * exec.c: Use C++ exception handling.
9430         * event-top.c: Use C++ exception handling.
9431         * event-loop.c: Use C++ exception handling.
9432         * eval.c: Use C++ exception handling.
9433         * dwarf2read.c: Use C++ exception handling.
9434         * dwarf2loc.c: Use C++ exception handling.
9435         * dwarf2-frame.c: Use C++ exception handling.
9436         * dwarf2-frame-tailcall.c: Use C++ exception handling.
9437         * dwarf-index-write.c: Use C++ exception handling.
9438         * dwarf-index-cache.c: Use C++ exception handling.
9439         * dtrace-probe.c: Use C++ exception handling.
9440         * disasm-selftests.c: Use C++ exception handling.
9441         * darwin-nat.c: Use C++ exception handling.
9442         * cp-valprint.c: Use C++ exception handling.
9443         * cp-support.c: Use C++ exception handling.
9444         * cp-abi.c: Use C++ exception handling.
9445         * corelow.c: Use C++ exception handling.
9446         * completer.c: Use C++ exception handling.
9447         * compile/compile-object-run.c: Use C++ exception handling.
9448         * compile/compile-object-load.c: Use C++ exception handling.
9449         * compile/compile-cplus-symbols.c: Use C++ exception handling.
9450         * compile/compile-c-symbols.c: Use C++ exception handling.
9451         * common/selftest.c: Use C++ exception handling.
9452         * common/new-op.c: Use C++ exception handling.
9453         * cli/cli-script.c: Use C++ exception handling.
9454         * cli/cli-interp.c: Use C++ exception handling.
9455         * cli/cli-cmds.c: Use C++ exception handling.
9456         * c-varobj.c: Use C++ exception handling.
9457         * btrace.c: Use C++ exception handling.
9458         * breakpoint.c: Use C++ exception handling.
9459         * break-catch-throw.c: Use C++ exception handling.
9460         * arch-utils.c: Use C++ exception handling.
9461         * amd64-tdep.c: Use C++ exception handling.
9462         * ada-valprint.c: Use C++ exception handling.
9463         * ada-typeprint.c: Use C++ exception handling.
9464         * ada-lang.c: Use C++ exception handling.
9465         * aarch64-tdep.c: Use C++ exception handling.
9466
9467 2019-04-08  Tom Tromey  <tom@tromey.com>
9468
9469         * xml-support.c (gdb_xml_parser::parse): Update.
9470         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
9471         * value.c (show_convenience): Update.
9472         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
9473         (test_parse_flags_qcs): Update.
9474         * thread.c (thr_try_catch_cmd): Update.
9475         * target.c (target_translate_tls_address): Update.
9476         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
9477         (info_frame_command_core, frame_apply_command_count): Update.
9478         * rust-exp.y (rust_lex_exception_test): Update.
9479         * riscv-tdep.c (riscv_print_one_register_info): Update.
9480         * remote.c (remote_target::enable_btrace): Update.
9481         * record-btrace.c (record_btrace_enable_warn): Update.
9482         * python/py-utils.c (gdbpy_convert_exception): Update.
9483         * printcmd.c (do_one_display, print_variable_and_value): Update.
9484         * mi/mi-main.c (mi_print_exception): Update.
9485         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
9486         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
9487         * linux-nat.c (linux_nat_target::attach): Update.
9488         * linux-fork.c (class scoped_switch_fork_info): Update.
9489         * infrun.c (displaced_step_prepare): Update.
9490         * infcall.c (call_function_by_hand_dummy): Update.
9491         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
9492         * gnu-v3-abi.c (print_one_vtable): Update.
9493         * frame.c (get_prev_frame_always): Update.
9494         * f-valprint.c (info_common_command_for_block): Update.
9495         * exec.c (try_open_exec_file): Update.
9496         * exceptions.c (print_exception, exception_print)
9497         (exception_fprintf, exception_print_same): Update.
9498         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
9499         * dwarf-index-cache.c (index_cache::store)
9500         (index_cache::lookup_gdb_index): Update.
9501         * darwin-nat.c (maybe_cache_shell): Update.
9502         * cp-valprint.c (cp_print_value_fields): Update.
9503         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
9504         (gcc_cplus_symbol_address): Update.
9505         * compile/compile-c-symbols.c (gcc_convert_symbol)
9506         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
9507         * common/selftest.c: Update.
9508         * common/common-exceptions.h (struct gdb_exception) <message>: Now
9509         a std::string.
9510         (exception_try_scope_entry, exception_try_scope_exit): Don't
9511         declare.
9512         (struct exception_try_scope): Remove.
9513         (TRY): Don't use exception_try_scope.
9514         (struct gdb_exception): Add constructor, operator=.
9515         <what>: New method.
9516         (struct gdb_exception_RETURN_MASK_ALL)
9517         (struct gdb_exception_RETURN_MASK_ERROR)
9518         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
9519         (struct gdb_quit_bad_alloc): Update.
9520         * common/common-exceptions.c (exception_none): Change
9521         initializer.
9522         (struct catcher) <state, exception>: Initialize inline.
9523         <prev>: Remove member.
9524         (current_catcher): Remove.
9525         (catchers): New global.
9526         (exceptions_state_mc_init): Simplify.
9527         (catcher_pop): Remove.
9528         (exceptions_state_mc, exceptions_state_mc_catch): Update.
9529         (try_scope_depth, exception_try_scope_entry)
9530         (exception_try_scope_exit): Remove.
9531         (throw_exception_sjlj): Update.
9532         (exception_messages, exception_messages_size): Remove.
9533         (throw_it): Simplify.
9534         (gdb_exception_sliced_copy): Remove.
9535         (throw_exception_cxx): Update.
9536         * cli/cli-script.c (script_from_file): Update.
9537         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
9538         Update.
9539         * ada-valprint.c (ada_val_print): Update.
9540         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
9541         (create_excep_cond_exprs): Update.
9542
9543 2019-04-08  Tom Tromey  <tom@tromey.com>
9544
9545         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
9546         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
9547         (TRY, CATCH, END_CATCH): Remove some definitions.
9548         * common/common-exceptions.c: Don't use GDB_XCPT.
9549         (catcher_list_size): Remove.
9550         (throw_exception, throw_it): Simplify.
9551
9552 2019-04-05  Tom Tromey  <tom@tromey.com>
9553
9554         Revert the header-sorting patch.
9555         * ft32-tdep.c: Revert.
9556         * frv-tdep.c: Revert.
9557         * frv-linux-tdep.c: Revert.
9558         * frame.c: Revert.
9559         * frame-unwind.c: Revert.
9560         * frame-base.c: Revert.
9561         * fork-child.c: Revert.
9562         * findvar.c: Revert.
9563         * findcmd.c: Revert.
9564         * filesystem.c: Revert.
9565         * filename-seen-cache.h: Revert.
9566         * filename-seen-cache.c: Revert.
9567         * fbsd-tdep.c: Revert.
9568         * fbsd-nat.h: Revert.
9569         * fbsd-nat.c: Revert.
9570         * f-valprint.c: Revert.
9571         * f-typeprint.c: Revert.
9572         * f-lang.c: Revert.
9573         * extension.h: Revert.
9574         * extension.c: Revert.
9575         * extension-priv.h: Revert.
9576         * expprint.c: Revert.
9577         * exec.h: Revert.
9578         * exec.c: Revert.
9579         * exceptions.c: Revert.
9580         * event-top.c: Revert.
9581         * event-loop.c: Revert.
9582         * eval.c: Revert.
9583         * elfread.c: Revert.
9584         * dwarf2read.h: Revert.
9585         * dwarf2read.c: Revert.
9586         * dwarf2loc.c: Revert.
9587         * dwarf2expr.h: Revert.
9588         * dwarf2expr.c: Revert.
9589         * dwarf2-frame.c: Revert.
9590         * dwarf2-frame-tailcall.c: Revert.
9591         * dwarf-index-write.h: Revert.
9592         * dwarf-index-write.c: Revert.
9593         * dwarf-index-common.c: Revert.
9594         * dwarf-index-cache.h: Revert.
9595         * dwarf-index-cache.c: Revert.
9596         * dummy-frame.c: Revert.
9597         * dtrace-probe.c: Revert.
9598         * disasm.h: Revert.
9599         * disasm.c: Revert.
9600         * disasm-selftests.c: Revert.
9601         * dictionary.c: Revert.
9602         * dicos-tdep.c: Revert.
9603         * demangle.c: Revert.
9604         * dcache.h: Revert.
9605         * dcache.c: Revert.
9606         * darwin-nat.h: Revert.
9607         * darwin-nat.c: Revert.
9608         * darwin-nat-info.c: Revert.
9609         * d-valprint.c: Revert.
9610         * d-namespace.c: Revert.
9611         * d-lang.c: Revert.
9612         * ctf.c: Revert.
9613         * csky-tdep.c: Revert.
9614         * csky-linux-tdep.c: Revert.
9615         * cris-tdep.c: Revert.
9616         * cris-linux-tdep.c: Revert.
9617         * cp-valprint.c: Revert.
9618         * cp-support.c: Revert.
9619         * cp-namespace.c: Revert.
9620         * cp-abi.c: Revert.
9621         * corelow.c: Revert.
9622         * corefile.c: Revert.
9623         * continuations.c: Revert.
9624         * completer.h: Revert.
9625         * completer.c: Revert.
9626         * complaints.c: Revert.
9627         * coffread.c: Revert.
9628         * coff-pe-read.c: Revert.
9629         * cli-out.h: Revert.
9630         * cli-out.c: Revert.
9631         * charset.c: Revert.
9632         * c-varobj.c: Revert.
9633         * c-valprint.c: Revert.
9634         * c-typeprint.c: Revert.
9635         * c-lang.c: Revert.
9636         * buildsym.c: Revert.
9637         * buildsym-legacy.c: Revert.
9638         * build-id.h: Revert.
9639         * build-id.c: Revert.
9640         * btrace.c: Revert.
9641         * bsd-uthread.c: Revert.
9642         * breakpoint.h: Revert.
9643         * breakpoint.c: Revert.
9644         * break-catch-throw.c: Revert.
9645         * break-catch-syscall.c: Revert.
9646         * break-catch-sig.c: Revert.
9647         * blockframe.c: Revert.
9648         * block.c: Revert.
9649         * bfin-tdep.c: Revert.
9650         * bfin-linux-tdep.c: Revert.
9651         * bfd-target.c: Revert.
9652         * bcache.c: Revert.
9653         * ax-general.c: Revert.
9654         * ax-gdb.h: Revert.
9655         * ax-gdb.c: Revert.
9656         * avr-tdep.c: Revert.
9657         * auxv.c: Revert.
9658         * auto-load.c: Revert.
9659         * arm-wince-tdep.c: Revert.
9660         * arm-tdep.c: Revert.
9661         * arm-symbian-tdep.c: Revert.
9662         * arm-pikeos-tdep.c: Revert.
9663         * arm-obsd-tdep.c: Revert.
9664         * arm-nbsd-tdep.c: Revert.
9665         * arm-nbsd-nat.c: Revert.
9666         * arm-linux-tdep.c: Revert.
9667         * arm-linux-nat.c: Revert.
9668         * arm-fbsd-tdep.c: Revert.
9669         * arm-fbsd-nat.c: Revert.
9670         * arm-bsd-tdep.c: Revert.
9671         * arch-utils.c: Revert.
9672         * arc-tdep.c: Revert.
9673         * arc-newlib-tdep.c: Revert.
9674         * annotate.h: Revert.
9675         * annotate.c: Revert.
9676         * amd64-windows-tdep.c: Revert.
9677         * amd64-windows-nat.c: Revert.
9678         * amd64-tdep.c: Revert.
9679         * amd64-sol2-tdep.c: Revert.
9680         * amd64-obsd-tdep.c: Revert.
9681         * amd64-obsd-nat.c: Revert.
9682         * amd64-nbsd-tdep.c: Revert.
9683         * amd64-nbsd-nat.c: Revert.
9684         * amd64-nat.c: Revert.
9685         * amd64-linux-tdep.c: Revert.
9686         * amd64-linux-nat.c: Revert.
9687         * amd64-fbsd-tdep.c: Revert.
9688         * amd64-fbsd-nat.c: Revert.
9689         * amd64-dicos-tdep.c: Revert.
9690         * amd64-darwin-tdep.c: Revert.
9691         * amd64-bsd-nat.c: Revert.
9692         * alpha-tdep.c: Revert.
9693         * alpha-obsd-tdep.c: Revert.
9694         * alpha-nbsd-tdep.c: Revert.
9695         * alpha-mdebug-tdep.c: Revert.
9696         * alpha-linux-tdep.c: Revert.
9697         * alpha-linux-nat.c: Revert.
9698         * alpha-bsd-tdep.c: Revert.
9699         * alpha-bsd-nat.c: Revert.
9700         * aix-thread.c: Revert.
9701         * agent.c: Revert.
9702         * addrmap.c: Revert.
9703         * ada-varobj.c: Revert.
9704         * ada-valprint.c: Revert.
9705         * ada-typeprint.c: Revert.
9706         * ada-tasks.c: Revert.
9707         * ada-lang.c: Revert.
9708         * aarch64-tdep.c: Revert.
9709         * aarch64-ravenscar-thread.c: Revert.
9710         * aarch64-newlib-tdep.c: Revert.
9711         * aarch64-linux-tdep.c: Revert.
9712         * aarch64-linux-nat.c: Revert.
9713         * aarch64-fbsd-tdep.c: Revert.
9714         * aarch64-fbsd-nat.c: Revert.
9715         * aarch32-linux-nat.c: Revert.
9716
9717 2019-04-05  Tom Tromey  <tom@tromey.com>
9718
9719         * ft32-tdep.c: Sort headers.
9720         * frv-tdep.c: Sort headers.
9721         * frv-linux-tdep.c: Sort headers.
9722         * frame.c: Sort headers.
9723         * frame-unwind.c: Sort headers.
9724         * frame-base.c: Sort headers.
9725         * fork-child.c: Sort headers.
9726         * findvar.c: Sort headers.
9727         * findcmd.c: Sort headers.
9728         * filesystem.c: Sort headers.
9729         * filename-seen-cache.h: Sort headers.
9730         * filename-seen-cache.c: Sort headers.
9731         * fbsd-tdep.c: Sort headers.
9732         * fbsd-nat.h: Sort headers.
9733         * fbsd-nat.c: Sort headers.
9734         * f-valprint.c: Sort headers.
9735         * f-typeprint.c: Sort headers.
9736         * f-lang.c: Sort headers.
9737         * extension.h: Sort headers.
9738         * extension.c: Sort headers.
9739         * extension-priv.h: Sort headers.
9740         * expprint.c: Sort headers.
9741         * exec.h: Sort headers.
9742         * exec.c: Sort headers.
9743         * exceptions.c: Sort headers.
9744         * event-top.c: Sort headers.
9745         * event-loop.c: Sort headers.
9746         * eval.c: Sort headers.
9747         * elfread.c: Sort headers.
9748         * dwarf2read.h: Sort headers.
9749         * dwarf2read.c: Sort headers.
9750         * dwarf2loc.c: Sort headers.
9751         * dwarf2expr.h: Sort headers.
9752         * dwarf2expr.c: Sort headers.
9753         * dwarf2-frame.c: Sort headers.
9754         * dwarf2-frame-tailcall.c: Sort headers.
9755         * dwarf-index-write.h: Sort headers.
9756         * dwarf-index-write.c: Sort headers.
9757         * dwarf-index-common.c: Sort headers.
9758         * dwarf-index-cache.h: Sort headers.
9759         * dwarf-index-cache.c: Sort headers.
9760         * dummy-frame.c: Sort headers.
9761         * dtrace-probe.c: Sort headers.
9762         * disasm.h: Sort headers.
9763         * disasm.c: Sort headers.
9764         * disasm-selftests.c: Sort headers.
9765         * dictionary.c: Sort headers.
9766         * dicos-tdep.c: Sort headers.
9767         * demangle.c: Sort headers.
9768         * dcache.h: Sort headers.
9769         * dcache.c: Sort headers.
9770         * darwin-nat.h: Sort headers.
9771         * darwin-nat.c: Sort headers.
9772         * darwin-nat-info.c: Sort headers.
9773         * d-valprint.c: Sort headers.
9774         * d-namespace.c: Sort headers.
9775         * d-lang.c: Sort headers.
9776         * ctf.c: Sort headers.
9777         * csky-tdep.c: Sort headers.
9778         * csky-linux-tdep.c: Sort headers.
9779         * cris-tdep.c: Sort headers.
9780         * cris-linux-tdep.c: Sort headers.
9781         * cp-valprint.c: Sort headers.
9782         * cp-support.c: Sort headers.
9783         * cp-namespace.c: Sort headers.
9784         * cp-abi.c: Sort headers.
9785         * corelow.c: Sort headers.
9786         * corefile.c: Sort headers.
9787         * continuations.c: Sort headers.
9788         * completer.h: Sort headers.
9789         * completer.c: Sort headers.
9790         * complaints.c: Sort headers.
9791         * coffread.c: Sort headers.
9792         * coff-pe-read.c: Sort headers.
9793         * cli-out.h: Sort headers.
9794         * cli-out.c: Sort headers.
9795         * charset.c: Sort headers.
9796         * c-varobj.c: Sort headers.
9797         * c-valprint.c: Sort headers.
9798         * c-typeprint.c: Sort headers.
9799         * c-lang.c: Sort headers.
9800         * buildsym.c: Sort headers.
9801         * buildsym-legacy.c: Sort headers.
9802         * build-id.h: Sort headers.
9803         * build-id.c: Sort headers.
9804         * btrace.c: Sort headers.
9805         * bsd-uthread.c: Sort headers.
9806         * breakpoint.h: Sort headers.
9807         * breakpoint.c: Sort headers.
9808         * break-catch-throw.c: Sort headers.
9809         * break-catch-syscall.c: Sort headers.
9810         * break-catch-sig.c: Sort headers.
9811         * blockframe.c: Sort headers.
9812         * block.c: Sort headers.
9813         * bfin-tdep.c: Sort headers.
9814         * bfin-linux-tdep.c: Sort headers.
9815         * bfd-target.c: Sort headers.
9816         * bcache.c: Sort headers.
9817         * ax-general.c: Sort headers.
9818         * ax-gdb.h: Sort headers.
9819         * ax-gdb.c: Sort headers.
9820         * avr-tdep.c: Sort headers.
9821         * auxv.c: Sort headers.
9822         * auto-load.c: Sort headers.
9823         * arm-wince-tdep.c: Sort headers.
9824         * arm-tdep.c: Sort headers.
9825         * arm-symbian-tdep.c: Sort headers.
9826         * arm-pikeos-tdep.c: Sort headers.
9827         * arm-obsd-tdep.c: Sort headers.
9828         * arm-nbsd-tdep.c: Sort headers.
9829         * arm-nbsd-nat.c: Sort headers.
9830         * arm-linux-tdep.c: Sort headers.
9831         * arm-linux-nat.c: Sort headers.
9832         * arm-fbsd-tdep.c: Sort headers.
9833         * arm-fbsd-nat.c: Sort headers.
9834         * arm-bsd-tdep.c: Sort headers.
9835         * arch-utils.c: Sort headers.
9836         * arc-tdep.c: Sort headers.
9837         * arc-newlib-tdep.c: Sort headers.
9838         * annotate.h: Sort headers.
9839         * annotate.c: Sort headers.
9840         * amd64-windows-tdep.c: Sort headers.
9841         * amd64-windows-nat.c: Sort headers.
9842         * amd64-tdep.c: Sort headers.
9843         * amd64-sol2-tdep.c: Sort headers.
9844         * amd64-obsd-tdep.c: Sort headers.
9845         * amd64-obsd-nat.c: Sort headers.
9846         * amd64-nbsd-tdep.c: Sort headers.
9847         * amd64-nbsd-nat.c: Sort headers.
9848         * amd64-nat.c: Sort headers.
9849         * amd64-linux-tdep.c: Sort headers.
9850         * amd64-linux-nat.c: Sort headers.
9851         * amd64-fbsd-tdep.c: Sort headers.
9852         * amd64-fbsd-nat.c: Sort headers.
9853         * amd64-dicos-tdep.c: Sort headers.
9854         * amd64-darwin-tdep.c: Sort headers.
9855         * amd64-bsd-nat.c: Sort headers.
9856         * alpha-tdep.c: Sort headers.
9857         * alpha-obsd-tdep.c: Sort headers.
9858         * alpha-nbsd-tdep.c: Sort headers.
9859         * alpha-mdebug-tdep.c: Sort headers.
9860         * alpha-linux-tdep.c: Sort headers.
9861         * alpha-linux-nat.c: Sort headers.
9862         * alpha-bsd-tdep.c: Sort headers.
9863         * alpha-bsd-nat.c: Sort headers.
9864         * aix-thread.c: Sort headers.
9865         * agent.c: Sort headers.
9866         * addrmap.c: Sort headers.
9867         * ada-varobj.c: Sort headers.
9868         * ada-valprint.c: Sort headers.
9869         * ada-typeprint.c: Sort headers.
9870         * ada-tasks.c: Sort headers.
9871         * ada-lang.c: Sort headers.
9872         * aarch64-tdep.c: Sort headers.
9873         * aarch64-ravenscar-thread.c: Sort headers.
9874         * aarch64-newlib-tdep.c: Sort headers.
9875         * aarch64-linux-tdep.c: Sort headers.
9876         * aarch64-linux-nat.c: Sort headers.
9877         * aarch64-fbsd-tdep.c: Sort headers.
9878         * aarch64-fbsd-nat.c: Sort headers.
9879         * aarch32-linux-nat.c: Sort headers.
9880
9881 2019-04-04  Tom Tromey  <tom@tromey.com>
9882
9883         * varobj.c (varobj_create): Update.
9884         * rust-exp.y (struct rust_parser) <update_innermost_block,
9885         lookup_symbol>: New methods.
9886         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
9887         Rename.
9888         (rust_parser::rust_lookup_type)
9889         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
9890         * printcmd.c (display_command, do_one_display): Update.
9891         * parser-defs.h (struct parser_state) <parser_state>: Add
9892         "tracker" parameter.
9893         (block_tracker): New member.
9894         (class innermost_block_tracker) <innermost_block_tracker>: Add
9895         "types" parameter.
9896         <reset>: Remove method.
9897         (innermost_block): Don't declare.
9898         (null_post_parser): Update.
9899         * parse.c (innermost_block): Remove global.
9900         (write_dollar_variable): Update.
9901         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
9902         Remove "tracker_types" parameter.
9903         (parse_expression): Add "tracker" parameter.
9904         (parse_expression_for_completion): Update.
9905         (null_post_parser): Add "tracker" parameter.
9906         * p-exp.y: Update rules.
9907         * m2-exp.y: Update rules.
9908         * language.h (struct language_defn) <la_post_parser>: Add
9909         "tracker" parameter.
9910         * go-exp.y: Update rules.
9911         * f-exp.y: Update rules.
9912         * expression.h (parse_expression, parse_exp_1): Add "tracker"
9913         parameter.
9914         * d-exp.y: Update rules.
9915         * c-exp.y: Update rules.
9916         * breakpoint.c (set_breakpoint_condition): Create an
9917         innermost_block_tracker.
9918         (watch_command_1): Likewise.
9919         * ada-lang.c (resolve): Add "tracker" parameter.
9920         (resolve_subexp): Likewise.
9921         * ada-exp.y (write_var_from_sym): Update.
9922
9923 2019-04-04  Tom Tromey  <tom@tromey.com>
9924
9925         * type-stack.h: New file.
9926         * type-stack.c: New file.
9927         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
9928         type-stack.h.
9929         (insert_into_type_stack, insert_type, push_type, push_type_int)
9930         (insert_type_address_space, pop_type, pop_type_int)
9931         (pop_typelist, pop_type_stack, append_type_stack)
9932         (push_type_stack, get_type_stack, push_typelist)
9933         (follow_type_instance_flags, follow_types): Don't declare.
9934         * parse.c (type_stack): Remove global.
9935         (parse_exp_in_context): Update.
9936         (insert_into_type_stack, insert_type, push_type, push_type_int)
9937         (insert_type_address_space, pop_type, pop_type_int)
9938         (pop_typelist, pop_type_stack, append_type_stack)
9939         (push_type_stack, get_type_stack, push_typelist)
9940         (follow_type_instance_flags, follow_types): Remove (moved to
9941         type-stack.c).
9942         * f-exp.y (type_stack): New global.
9943         Update rules.
9944         (push_kind_type, f_parse): Update.
9945         * d-exp.y (type_stack): New global.
9946         Update rules.
9947         (d_parse): Update.
9948         * c-exp.y (struct c_parse_state) <type_stack>: New member.
9949         Update rules.
9950         * Makefile.in (COMMON_SFILES): Add type-stack.c.
9951         (HFILES_NO_SRCDIR): Add type-stack.h.
9952
9953 2019-04-04  Tom Tromey  <tom@tromey.com>
9954
9955         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
9956         (rust_parser::convert_ast_to_expression, rust_parse)
9957         (rust_lex_test_completion, rust_lex_tests): Update.
9958         * parser-defs.h (struct expr_completion_state): New.
9959         (struct parser_state) <parser_state>: Add completion parameter.
9960         <mark_struct_expression, mark_completion_tag>: New methods.
9961         <parse_completion, m_completion_state>: New members.
9962         (prefixify_expression, null_post_parser): Update.
9963         (mark_struct_expression, mark_completion_tag): Don't declare.
9964         * parse.c (parse_completion, expout_last_struct)
9965         (expout_tag_completion_type, expout_completion_name): Remove
9966         globals.
9967         (parser_state::mark_struct_expression)
9968         (parser_state::mark_completion_tag): Now methods.
9969         (prefixify_expression): Add last_struct parameter.
9970         (prefixify_subexp): Likewise.
9971         (parse_exp_1): Update.
9972         (parse_exp_in_context): Add cstate parameter.  Update.
9973         (parse_expression_for_completion): Create an
9974         expr_completion_state.
9975         (null_post_parser): Add "completion" parameter.
9976         * p-exp.y: Update rules.
9977         (yylex): Update.
9978         * language.h (struct language_defn) <la_post_parser>: Add
9979         "completing" parameter.
9980         * go-exp.y: Update rules.
9981         (lex_one_token): Update.
9982         * expression.h (parse_completion): Don't declare.
9983         * d-exp.y: Update rules.
9984         (lex_one_token): Update rules.
9985         * c-exp.y: Update rules.
9986         (lex_one_token): Update.
9987         * ada-lang.c (resolve): Add "parse_completion" parameter.
9988         (resolve_subexp): Likewise.
9989         (ada_resolve_function): Likewise.
9990
9991 2019-04-04  Tom Tromey  <tom@tromey.com>
9992
9993         * parser-defs.h (struct parser_state) <start_arglist,
9994         end_arglist>: New methods.
9995         <arglist_len, m_funcall_chain>: New members.
9996         (arglist_len, start_arglist, end_arglist): Don't declare.
9997         * parse.c (arglist_len, funcall_chain): Remove global.
9998         (start_arglist, end_arglist): Remove functions.
9999         (parse_exp_in_context): Update.
10000         * p-exp.y: Update rules.
10001         * m2-exp.y: Update rules.
10002         * go-exp.y: Update rules.
10003         * f-exp.y: Update rules.
10004         * d-exp.y: Update rules.
10005         * c-exp.y: Update rules.
10006
10007 2019-04-04  Tom Tromey  <tom@tromey.com>
10008
10009         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
10010         lex_operator, push_back>: New methods.
10011         Update all rules.
10012         (rust_parser::lex_hex, lex_escape): Rename and update.
10013         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
10014         (rust_parser::lex_operator): Rename and update.
10015         (rust_parser::lex_number, rustyylex, rustyyerror)
10016         (rust_lex_test_init, rust_lex_test_sequence)
10017         (rust_lex_test_push_back, rust_lex_tests): Update.
10018         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
10019         parameter.
10020         <lexptr, prev_lexptr>: New members.
10021         (lexptr, prev_lexptr): Don't declare.
10022         * parse.c (lexptr, prev_lexptr): Remove globals.
10023         (parse_exp_in_context): Update.
10024         * p-exp.y (yylex, yyerror): Update.
10025         * m2-exp.y (parse_number, yylex, yyerror): Update.
10026         * go-exp.y (lex_one_token, yyerror): Update.
10027         * f-exp.y (match_string_literal, yylex, yyerror): Update.
10028         * d-exp.y (lex_one_token, yyerror): Update.
10029         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
10030         (lex_one_token, yyerror): Update.
10031         * ada-lex.l (YY_INPUT): Update.
10032         (rewind_to_char): Update.
10033         * ada-exp.y (yyerror): Update.
10034
10035 2019-04-04  Tom Tromey  <tom@tromey.com>
10036
10037         * rust-exp.y (rustyylex, rust_lex_tests): Update.
10038         * parser-defs.h (struct parser_state) <parser_state>: Add new
10039         parameter.
10040         <comma_terminates>: New member.
10041         (comma_terminates): Don't declare global.
10042         * parse.c (comma_terminates): Remove global.
10043         (parse_exp_in_context): Update.
10044         * p-exp.y (yylex): Update.
10045         * m2-exp.y (yylex): Update.
10046         * go-exp.y (lex_one_token): Update.
10047         * f-exp.y (yylex): Update.
10048         * d-exp.y (lex_one_token): Update.
10049         * c-exp.y (lex_one_token): Update.
10050         * ada-lex.l: Update.
10051
10052 2019-04-04  Tom Tromey  <tom@tromey.com>
10053
10054         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
10055         (rustyylex, rust_lex_test_init, rust_lex_test_one)
10056         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
10057         * parser-defs.h (paren_depth): Don't declare.
10058         * parse.c (paren_depth): Remove global.
10059         (parse_exp_in_context): Update.
10060         * p-exp.y (paren_depth): New global.
10061         (pascal_parse): Initialize it.
10062         * m2-exp.y (paren_depth): New global.
10063         (m2_parse): Initialize it.
10064         * go-exp.y (paren_depth): New global.
10065         (go_parse): Initialize it.
10066         * f-exp.y (paren_depth): New global.
10067         (f_parse): Initialize it.
10068         * d-exp.y (paren_depth): New global.
10069         (d_parse): Initialize it.
10070         * c-exp.y (paren_depth): New global.
10071         (c_parse): Initialize it.
10072         * ada-lex.l (paren_depth): New global.
10073         (lexer_init): Initialize it.
10074
10075 2019-04-04  Tom Tromey  <tom@tromey.com>
10076
10077         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
10078         (rust_parser::convert_ast_to_type)
10079         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
10080         * parser-defs.h (struct parser_state) <parser_state>: Add
10081         parameters.  Initialize new members.
10082         <expression_context_block, expression_context_pc>: New members.
10083         * parse.c (expression_context_block, expression_context_pc):
10084         Remove globals.
10085         (parse_exp_in_context): Update.
10086         * p-exp.y: Update all rules.
10087         (yylex): Update.
10088         * m2-exp.y: Update all rules.
10089         (yylex): Update.
10090         * go-exp.y (yylex): Update.
10091         * f-exp.y (yylex): Update.
10092         * d-exp.y: Update all rules.
10093         (yylex): Update.
10094         * c-exp.y: Update all rules.
10095         (lex_one_token, classify_name, yylex, c_parse): Update.
10096         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
10097
10098 2019-04-04  Tom Tromey  <tom@tromey.com>
10099
10100         * gdbarch.h, gdbarch.c: Rebuild.
10101         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
10102         * stap-probe.h:
10103         (struct stap_parse_info): Replace "parser_state" with
10104         "expr_builder".
10105         * parser-defs.h (struct expr_builder): Rename from "parser_state".
10106         (parser_state): New class.
10107         * parse.c (expr_builder): Rename.
10108         (expr_builder::release): Rename.
10109         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
10110         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
10111         (write_exp_elt_longcst, write_exp_elt_floatcst)
10112         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
10113         (write_exp_string_vector, write_exp_bitstring)
10114         (write_exp_msymbol, mark_struct_expression)
10115         (write_dollar_variable)
10116         (insert_type_address_space, increase_expout_size): Replace
10117         "parser_state" with "expr_builder".
10118         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
10119         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
10120         "parser_state" with "expr_builder".
10121
10122 2019-04-04  Tom Tromey  <tom@tromey.com>
10123
10124         * rust-exp.y: Replace "parse_language" with method call.
10125         * p-exp.y:
10126         (yylex): Replace "parse_language" with method call.
10127         * m2-exp.y:
10128         (yylex): Replace "parse_language" with method call.
10129         * go-exp.y (classify_name): Replace "parse_language" with method
10130         call.
10131         * f-exp.y (yylex): Replace "parse_language" with method call.
10132         * d-exp.y (lex_one_token): Replace "parse_language" with method
10133         call.
10134         * c-exp.y:
10135         (lex_one_token, classify_name, yylex): Replace "parse_language"
10136         with method call.
10137         * ada-exp.y (find_primitive_type, type_char)
10138         (type_system_address): Replace "parse_language" with method call.
10139
10140 2019-04-04  Tom Tromey  <tom@tromey.com>
10141
10142         * rust-exp.y: Replace "parse_gdbarch" with method call.
10143         * parse.c (write_dollar_variable, insert_type_address_space):
10144         Replace "parse_gdbarch" with method call.
10145         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
10146         call.
10147         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
10148         call.
10149         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
10150         "parse_gdbarch" with method call.
10151         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
10152         with method call.
10153         * f-exp.y (parse_type, parse_f_type, yylex): Replace
10154         "parse_gdbarch" with method call.
10155         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
10156         "parse_gdbarch" with method call.
10157         * c-exp.y (parse_type, parse_number, classify_name): Replace
10158         "parse_gdbarch" with method call.
10159         * ada-lex.l: Replace "parse_gdbarch" with method call.
10160         * ada-exp.y (parse_type, find_primitive_type, type_char)
10161         (type_system_address): Replace "parse_gdbarch" with method call.
10162
10163 2019-04-04  Tom Tromey  <tom@tromey.com>
10164
10165         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
10166         * stap-probe.c (stap_parse_argument): Update.
10167         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
10168         initial_size parameter.
10169         * rust-exp.y (rust_lex_tests): Update.
10170         * parse.c (parser_state): Update.
10171         (parse_exp_in_context): Update.
10172         * parser-defs.h (struct parser_state) <parser_state>: Remove
10173         "initial_size" parameter.
10174
10175 2019-04-04  Tom Tromey  <tom@tromey.com>
10176
10177         * parser-defs.h (increase_expout_size): Don't declare.
10178         * parse.c (increase_expout_size): Now static.
10179
10180 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
10181
10182         * gnu-nat.c (gnu_nat_target::wait): Fix
10183         target_waitstatus_to_string call.
10184
10185 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
10186
10187         * eval.c (evaluate_subexp_standard): Handle internal functions
10188         during Fortran function call handling.
10189
10190 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
10191
10192         * NEWS: Mention new internal functions.
10193         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
10194         (read_base_type): Use dwarf2_init_complex_target_type.
10195         * value.c (creal_internal_fn): New function.
10196         (cimag_internal_fn): New function.
10197         (_initialize_values): Register new internal functions.
10198
10199 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10200
10201         * infrun.c (stop_all_threads): If debug_infrun, always
10202         trace the wait status after wait_one, using
10203         target_waitstatus_to_string and target_pid_to_str.
10204         (handle_inferior_event): Replace various trace of
10205         wait status kind by a single trace.
10206         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
10207         wait status kind image by target_waitstatus_to_string.
10208         * target/waitstatus.c (target_waitstatus_to_string): Fix
10209         obsolete comment.
10210
10211 2019-04-01  Tom Tromey  <tromey@adacore.com>
10212
10213         PR symtab/23331:
10214         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
10215
10216 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
10217             Pedro Alves  <palves@redhat.com>
10218
10219         * top.c (quit_force): Call 'finalize_values'.
10220         * value.c (finalize_values): New function.
10221         * value.h (finalize_values): Declare.
10222
10223 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
10224
10225         * NEWS: Announce $_gdb_major and $_gdb_minor.
10226
10227         * top.c (init_gdb_version_vars): New function.
10228         (gdb_init): Call init_gdb_version_vars.
10229
10230 2019-03-29  Tom Tromey  <tromey@adacore.com>
10231
10232         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
10233         help text.  Remove dead code.
10234
10235 2019-03-29  Keith Seitz  <keiths@redhat.com>
10236
10237         From Siddhesh Poyarekar:
10238         * f-lang.h (f77_get_upperbound): Return LONGEST.
10239         (f77_get_lowerbound): Likewise.
10240         * f-typeprint.c (f_type_print_varspec_suffix): Expand
10241         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
10242         print them.
10243         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
10244         plongest to format print it.
10245         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
10246         (f77_get_upperbound): Likewise.
10247         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
10248         LOWER_BOUND to LONGEST.
10249         (f77_create_arrayprint_offset_tbl): Likewise.
10250
10251 2019-03-29  Keith Seitz  <keiths@redhat.com>
10252
10253         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
10254         %s/pulongest for TYPE_LENGTH instead of %d in format
10255         strings.
10256         * ada-typerint.c (ada_print_type): Likewise.
10257         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
10258         * compile/compile-c-support.c (generate_register_struct): Likewise.
10259         * gdbtypes.c (recursive_dump_type): Likewise.
10260         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
10261         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
10262         instead of %d in format strings.
10263         * riscv-tdep.c (riscv_type_alignment): Cast second argument
10264         to std::min to ULONGEST.
10265         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
10266         instead of %d in format strings.
10267         * tracepoint.c (info_scope_command): Likewise.
10268         * typeprint.c (print_offset_data::update)
10269         (print_offset_data::finish): Likewise.
10270         * xtensa-tdep.c (xtensa_store_return_value)
10271         (xtensa_push_dummy_call): Likewise.
10272
10273 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
10274
10275         * windows-nat.c (display_selector): Fixed format specifications
10276         for 64-bit Cygwin.
10277
10278 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10279
10280         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
10281
10282 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
10283
10284         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
10285         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
10286         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
10287         (nios2_linux_init_abi): Install it.
10288
10289 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
10290
10291         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
10292
10293 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
10294
10295         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
10296
10297 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10298             Tom Tromey  <tromey@adacore.com>
10299
10300         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
10301
10302 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
10303
10304         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
10305         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
10306         method to compute the bounds of range types. Also print "[evaluated]"
10307         if the bounds' values come from a dynamic evaluation.
10308
10309 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
10310
10311         * cp-valprint.c (cp_print_value_fields): Don't print trailing
10312         whitespace when pretty printing is on.
10313
10314 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
10315
10316         * ppc-linux-nat.c: Add include.
10317
10318 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
10319
10320         * NEWS: Mention AArch64 Pointer Authentication.
10321
10322 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
10323
10324         * arm-linux-nat.c: Add include.
10325
10326 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
10327
10328         * source-cache.c (source_cache::get_source_lines): Re-read
10329         fullname after calling open_source_file.
10330
10331 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
10332
10333         * NEWS: Mention TLS support for FreeBSD.
10334
10335 2019-03-25  Tom Tromey  <tromey@adacore.com>
10336
10337         * minsyms.c (BUNCH_SIZE): Update comment.
10338         (~minimal_symbol_reader): Remove old comment.
10339         (compact_minimal_symbols): Update comment.
10340         (minimal_symbol_reader::install): Remove old comment.  Update
10341         other comments.
10342
10343 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
10344
10345         * s390-linux-nat.c: Add include.
10346
10347 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
10348
10349         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
10350         Call linux_get_hwcap.
10351         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
10352         Likewise.
10353         (aarch64_linux_get_hwcap): Remove function.
10354         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
10355         declaration.
10356         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
10357         linux_get_hwcap.
10358         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
10359         * linux-tdep.c (linux_get_hwcap): Add function.
10360         (linux_get_hwcap2): Likewise.
10361         * linux-tdep.h (linux_get_hwcap): Add declaration.
10362         (linux_get_hwcap2): Likewise.
10363         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
10364         (ppc_linux_get_hwcap2): Likewise.
10365         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
10366         linux_get_hwcap.
10367         (ppc_linux_nat_target::insert_watchpoint): Likewise.
10368         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
10369         (ppc_linux_nat_target::read_description): Likewise.
10370         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
10371         * s390-linux-nat.c: Likewise.
10372         * s390-linux-tdep.c (s390_core_read_description): Likewise.
10373
10374 2019-03-24  Tom Tromey  <tom@tromey.com>
10375
10376         * ada-lang.c (standard_lookup): Simplify initialization.
10377         (ada_lookup_symbol_nonlocal): Simplify return.
10378         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
10379         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
10380         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
10381         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
10382         initialization.
10383         * solib.c (solib_global_lookup): Simplify.
10384         * symtab.c (null_block_symbol): Remove.
10385         (symbol_cache_lookup): Simplify returns.
10386         (lookup_language_this): Simplify returns.
10387         (lookup_symbol_aux): Simplify return.
10388         (lookup_local_symbol): Simplify returns.
10389         (lookup_global_symbol_from_objfile): Simplify return.
10390         (lookup_symbol_in_objfile_symtabs)
10391         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
10392         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
10393         (lookup_static_symbol, lookup_global_symbol): Simplify return.
10394         * cp-namespace.c (cp_lookup_bare_symbol)
10395         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
10396         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
10397         (cp_lookup_nested_symbol): Don't use null_block_symbol.
10398         (cp_lookup_symbol_via_imports): Simplify initialization.
10399         (find_symbol_in_baseclass): Likewise.
10400         * symtab.h (null_block_symbol): Remove.
10401         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
10402         (d_lookup_nested_symbol, d_lookup_symbol_imports)
10403         (d_lookup_symbol_module): Likewise.
10404         (find_symbol_in_baseclass): Simplify initialization.
10405
10406 2019-03-24  Tom Tromey  <tom@tromey.com>
10407
10408         * expression.h: Don't include symtab.h.
10409         (struct block): Forward declare.
10410
10411 2019-03-24  Tom Tromey  <tom@tromey.com>
10412
10413         * c-exp.y (typebase): Remove casts.
10414         * gdbtypes.c (lookup_unsigned_typename, )
10415         (lookup_signed_typename): Remove cast.
10416         * eval.c (parse_to_comma_and_eval): Remove cast.
10417         * parse.c (write_dollar_variable): Remove cast.
10418         * block.h (struct block) <superblock>: Now const.
10419         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
10420         * psymtab.c (psym_map_matching_symbols): Make "block" const.
10421         (map_block): Make "block" const.
10422         * symfile.h (struct quick_symbol_functions)
10423         <map_matching_symbols>: Constify block argument to "callback".
10424         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
10425         const.
10426         (find_pc_sect_compunit_symtab): Make "b" const.
10427         (find_symbol_at_address): Likewise.
10428         (search_symbols): Likewise.
10429         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
10430         (dw2_debug_names_lookup_symbol): Likewise.
10431         (dw2_map_matching_symbols): Update.
10432         * p-valprint.c (pascal_val_print): Remove "block".
10433         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
10434         (aux_add_nonlocal_symbols): Make "block" const.
10435         (resolve_subexp): Remove cast.
10436         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
10437         const.
10438         (iterate_over_file_blocks): Likewise.
10439         * f-exp.y (%union) <bval>: Remove.
10440         * coffread.c (patch_opaque_types): Make "b" const.
10441         * spu-tdep.c (spu_catch_start): Make "block" const.
10442         * c-valprint.c (print_unpacked_pointer): Remove "block".
10443         * symmisc.c (dump_symtab_1): Make "b" const.
10444         (block_depth): Make "block" const.
10445         * d-exp.y (%union) <bval>: Remove.
10446         * cp-support.h (cp_lookup_rtti_type): Update.
10447         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
10448         * psymtab.c (psym_lookup_symbol): Make "block" const.
10449         (maintenance_check_psymtabs): Make "b" const.
10450         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
10451         (enumerate_locals, enumerate_args): Update.
10452         * python/py-symtab.c (stpy_global_block): Make "block" const.
10453         (stpy_static_block): Likewise.
10454         * inline-frame.c (block_starting_point_at): Make "new_block"
10455         const.
10456         * block.c (find_block_in_blockvector): Make return type const.
10457         (blockvector_for_pc_sect): Make "b" const.
10458         (find_block_in_blockvector): Make "b" const.
10459
10460 2019-03-23  Tom Tromey  <tom@tromey.com>
10461
10462         * varobj.c (varobj_create): Update.
10463         * symfile.c (clear_symtab_users): Don't reset innermost_block.
10464         * printcmd.c (display_command, do_one_display): Don't reset
10465         innermost_block.
10466         * parser-defs.h (enum innermost_block_tracker_type): Move to
10467         expression.h.
10468         (innermost_block): Update comment.
10469         * parse.c (parse_exp_1): Add tracker_types parameter.
10470         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
10471         tracker_types parameter.  Reset innermost_block.
10472         (parse_exp_in_context): Remove.
10473         (parse_expression_for_completion): Update.
10474         * objfiles.c (~objfile): Don't reset expression_context_block or
10475         innermost_block.
10476         * expression.h (enum innermost_block_tracker_type): Move from
10477         parser-defs.h.
10478         (parse_exp_1): Add tracker_types parameter.
10479         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
10480         reset innermost_block.
10481
10482 2019-03-23  Tom Tromey  <tom@tromey.com>
10483
10484         * objfiles.h: Include bcache.h.
10485
10486 2019-03-23  Tom Tromey  <tom@tromey.com>
10487
10488         * linespec.c (get_current_search_block): Use
10489         scoped_restore_current_language.
10490         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
10491
10492 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
10493             Jiong Wang  <jiong.wang@arm.com>
10494
10495         * aarch64-linux-tdep.c
10496         (aarch64_linux_iterate_over_regset_sections): Check for pauth
10497         section.
10498         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
10499
10500 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
10501             Jiong Wang  <jiong.wang@arm.com>
10502
10503         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
10504         instructions.
10505         (aarch64_analyze_prologue_test): Add PACIASP test.
10506         (aarch64_prologue_prev_register): Unmask PC value.
10507
10508 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
10509             Jiong Wang  <jiong.wang@arm.com>
10510
10511         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
10512         (aarch64_dwarf2_prev_register): Unmask PC value.
10513         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
10514         (aarch64_execute_dwarf_cfa_vendor_op): Check for
10515         DW_CFA_AARCH64_negate_ra_state.
10516         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
10517
10518 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
10519             Jiong Wang  <jiong.wang@arm.com>
10520
10521         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
10522         registers.
10523         (aarch64_pseudo_register_name): Likewise.
10524         (aarch64_pseudo_register_type): Likewise.
10525         (aarch64_pseudo_register_reggroup_p): Likewise.
10526         (aarch64_gdbarch_init): Add pauth registers.
10527         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
10528         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
10529         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
10530         (struct gdbarch_tdep): Add regnum for ra_state.
10531
10532 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
10533             Jiong Wang  <jiong.wang@arm.com>
10534
10535         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
10536
10537 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
10538             Jiong Wang  <jiong.wang@arm.com>
10539
10540         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
10541         function.
10542         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
10543         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
10544         (aarch64_gdbarch_init): Add puth registers.
10545         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
10546         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
10547         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
10548
10549 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
10550             Jiong Wang  <jiong.wang@arm.com>
10551
10552         * aarch64-linux-nat.c
10553         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
10554         * aarch64-linux-tdep.c
10555         (aarch64_linux_core_read_description): Likewise.
10556         (aarch64_linux_get_hwcap): New function.
10557         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
10558         (aarch64_linux_get_hwcap): New declaration.
10559
10560 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
10561             Jiong Wang  <jiong.wang@arm.com>
10562
10563         * aarch64-linux-nat.c
10564         (aarch64_linux_nat_target::read_description): Add pauth param.
10565         * aarch64-linux-tdep.c
10566         (aarch64_linux_core_read_description): Likewise.
10567         * aarch64-tdep.c (struct target_desc): Add in pauth.
10568         (aarch64_read_description): Add pauth param.
10569         (aarch64_gdbarch_init): Likewise.
10570         * aarch64-tdep.h (aarch64_read_description): Likewise.
10571         * arch/aarch64.c (aarch64_create_target_description): Likewise.
10572         * arch/aarch64.h (aarch64_create_target_description): Likewise.
10573         * features/Makefile: Add new files.
10574         * features/aarch64-pauth.c: New file.
10575         * features/aarch64-pauth.xml: New file.
10576
10577 2019-03-20  Tom Tromey  <tromey@adacore.com>
10578
10579         * infrun.c (handle_inferior_event): Rename from
10580         handle_inferior_event_1.  Create a scoped_value_mark.
10581         (handle_inferior_event): Remove.
10582
10583 2019-03-19  Tom Tromey  <tromey@adacore.com>
10584
10585         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
10586         * infrun.h (print_stop_event): Add "displays" parameter.
10587         * infrun.c (print_stop_event): Add "displays" parameter.
10588
10589 2019-03-19  Pedro Alves  <palves@redhat.com>
10590
10591         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
10592         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
10593         to -1.  Fix TABs vs spaces.
10594         (tui_ui_out::tui_ui_out): Don't initialize fields here.
10595         * tui/tui-out.h (tui_ui_out) Add intro comments.
10596         <m_line, m_start_of_line>: In-class initialize, and add describing
10597         comment.
10598
10599 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
10600
10601         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
10602         variable names.
10603         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
10604
10605 2019-03-18  Pedro Alves  <palves@redhat.com>
10606             Eli Zaretskii <eliz@gnu.org>
10607
10608         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
10609         m_line and m_start_of_line.
10610
10611 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
10612
10613         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
10614         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
10615         it returns a newline.  This fixes a regression in TU mode, whereby
10616         the next line is output on the same screen line as the user input.
10617
10618 2019-03-18  Tom Tromey  <tromey@adacore.com>
10619
10620         * minsyms.c (minimal_symbol_reader::install): Remove call to
10621         obstack_blank.
10622
10623 2019-03-18  Pedro Alves  <palves@redhat.com>
10624
10625         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
10626         New globals.
10627         (apply_style): New, factored out from ...
10628         (apply_ansi_escape): ... this.  Handle reverse video mode.
10629         (tui_set_reverse_mode): New function.
10630         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
10631         * tui/tui-winsource.c (tui_show_source_line): Use
10632         tui_set_reverse_mode instead of setting A_STANDOUT.
10633         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
10634         New setter methods.
10635
10636 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
10637
10638         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
10639         Handle tabs.
10640
10641 2019-03-18  Tom Tromey  <tromey@adacore.com>
10642
10643         * ada-lang.c (empty_array): Add "high" parameter.
10644         (ada_evaluate_subexp): Update.
10645
10646 2019-03-17  Sergei Trofimovich <siarheit@google.com>
10647
10648         * unittests/string_view-selftests.c: Define
10649         _initialize_string_view_selftests unconditionally.
10650
10651 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
10652
10653         PR gdb/24350
10654         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
10655
10656 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
10657
10658         PR gdb/24351
10659         * windows-nat.c (display_selector): Fix format specifiers.
10660
10661 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
10662
10663         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
10664         tui_refill_source_window instead of tui_refresh_win, to update the
10665         current execution line.  This fixes redisplay of the current line
10666         when stepping through the code with "next" or "step".
10667
10668 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
10669
10670         * source-cache.c (source_cache::get_source_lines): Call
10671         find_source_lines to initialize s->nlines.  This fixes vertical
10672         scrolling of TUI source window when the DOWN arrow is pressed.
10673
10674 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10675
10676         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
10677         linux-thread-db.c (_initialize_thread_db): Likewise.
10678
10679 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
10680
10681         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
10682         wclrtoeol in tui_show_source_line".  This reverts changes made in
10683         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
10684
10685 2019-03-15  Tom Tromey  <tom@tromey.com>
10686
10687         * symtab.h (struct minimal_symbol): Derive from
10688         general_symbol_info.
10689         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
10690         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
10691         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
10692         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
10693         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
10694         (MSYMBOL_SEARCH_NAME): Update.
10695         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
10696         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
10697         * minsyms.c (minimal_symbol_reader::record_full): Update.
10698
10699 2019-03-15  Tom Tromey  <tom@tromey.com>
10700
10701         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
10702
10703 2019-03-15  Tom Tromey  <tom@tromey.com>
10704
10705         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
10706         unique_xmalloc_ptr.
10707         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
10708         Update.
10709         * minsyms.c (lookup_minimal_symbol_by_pc_section)
10710         (build_minimal_symbol_hash_tables)
10711         (minimal_symbol_reader::install): Update.
10712
10713 2019-03-15  Tom Tromey  <tom@tromey.com>
10714
10715         * symtab.c (create_demangled_names_hash): Update.
10716         (symbol_set_names): Update.
10717         * objfiles.h (struct objfile_per_bfd_storage)
10718         <demangled_names_hash>: Now an htab_up.
10719         * objfiles.c (objfile_per_bfd_storage): Simplify.
10720
10721 2019-03-15  Tom Tromey  <tom@tromey.com>
10722
10723         * objfiles.h (struct objfile_per_bfd_storage): Declare
10724         destructor.
10725         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
10726         New.
10727         (get_objfile_bfd_data): Use new.  Don't initialize
10728         language_of_main.
10729         (free_objfile_per_bfd_storage): Remove.
10730         (objfile_bfd_data_free, objfile::~objfile): Use delete.
10731
10732 2019-03-15  Tom Tromey  <tom@tromey.com>
10733
10734         * symfile.c (reread_symbols): Update.
10735         * objfiles.c (objfile::objfile): Update.
10736         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
10737         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
10738         comment.
10739         (minimal_symbol_reader::install): Update.
10740         (terminate_minimal_symbol_table): Remove.
10741         * jit.c (jit_object_close_impl): Update.
10742
10743 2019-03-15  Tom Tromey  <tom@tromey.com>
10744
10745         * minsyms.c (minimal_symbol_reader::record_full): Remove some
10746         initializations.
10747
10748 2019-03-15  Tom Tromey  <tom@tromey.com>
10749
10750         * objfiles.h (struct objfile_per_bfd_storage)
10751         <demangled_hash_languages>: Now a bitset.
10752         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
10753         (lookup_minimal_symbol): Update.
10754
10755 2019-03-15  Tom Tromey  <tom@tromey.com>
10756
10757         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
10758         Don't return the symbol.
10759         * coffread.c (record_minimal_symbol): Use record_full.
10760
10761 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
10762
10763         The MS-Windows port of ncurses fails to switch to a color pair if
10764         one or both of the colors are the implicit default colors.  This
10765         change records the default colors when TUI is initialized, and
10766         then specifies them explicitly when a color pair uses the default
10767         colors.  This allows color styling in TUI mode on MS-Windows.
10768
10769         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
10770         ncurses_norm_attr.
10771         (tui_initialize_io) [__MINGW32__]: Record the default terminal
10772         colors in ncurses_norm_attr.
10773         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
10774         "none", replace it with the default color recorded in
10775         ncurses_norm_attr.
10776
10777 2019-03-14  Tom Tromey  <tromey@adacore.com>
10778
10779         * source-cache.h (class source_cache) <get_source_lines>: Return
10780         std::string.
10781         * source-cache.c (source_cache::extract_lines): Handle case where
10782         first_pos==npos.  Return std::string.
10783         (source_cache::get_source_lines): Update.
10784
10785 2019-03-14  Tom Tromey  <tromey@adacore.com>
10786
10787         * NEWS: Add item for "style sources" commands.
10788         * source-cache.c (source_cache::get_source_lines): Check
10789         source_styling.
10790         * cli/cli-style.c (source_styling): New global.
10791         (_initialize_cli_style): Add "style sources" commands.
10792         (show_style_sources): New function.
10793         * cli/cli-style.h (source_styling): Declare.
10794
10795 2019-03-14  Pedro Alves  <palves@redhat.com>
10796             Tom Tromey  <tromey@adacore.com>
10797
10798         * tui/tui-winsource.h (tui_refill_source_window): Declare.
10799         * tui/tui-winsource.c (tui_refill_source_window): New function,
10800         from...
10801         (tui_horizontal_source_scroll): ... here.  Move some logic.
10802         * cli/cli-style.c (set_style_enabled): Notify new observable.
10803         * tui/tui-hooks.c (tui_redisplay_source): New function.
10804         (tui_attach_detach_observers): Attach or detach
10805         tui_redisplay_source.
10806         * observable.h (source_styling_changed): New observable.
10807         * observable.c: Define source_styling_changed observable.
10808
10809 2019-03-13  Tom Tromey  <tromey@adacore.com>
10810
10811         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
10812         (i386_gnu_nat_target::store_registers): Update.
10813         * target-debug.h (target_debug_print_std_string): New macro.
10814         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
10815         * windows-tdep.c (display_one_tib): Update.
10816         * tui/tui-stack.c (tui_make_status_line): Update.
10817         * top.c (print_inferior_quit_action): Update.
10818         * thread.c (thr_try_catch_cmd): Update.
10819         (add_thread_with_info): Update.
10820         (thread_target_id_str): Update.
10821         (thr_try_catch_cmd): Update.
10822         (thread_command): Update.
10823         (thread_find_command): Update.
10824         * record-btrace.c (record_btrace_target::info_record)
10825         (record_btrace_resume_thread, record_btrace_target::resume)
10826         (record_btrace_cancel_resume, record_btrace_step_thread)
10827         (record_btrace_target::wait, record_btrace_target::wait)
10828         (record_btrace_target::wait, record_btrace_target::stop): Update.
10829         * progspace.c (print_program_space): Update.
10830         * process-stratum-target.c
10831         (process_stratum_target::thread_address_space): Update.
10832         * linux-fork.c (linux_fork_mourn_inferior)
10833         (detach_checkpoint_command, info_checkpoints_command)
10834         (linux_fork_context): Update.
10835         (linux_fork_detach): Update.
10836         (class scoped_switch_fork_info): Update.
10837         (delete_checkpoint_command): Update.
10838         * infrun.c (follow_fork_inferior): Update.
10839         (follow_fork_inferior): Update.
10840         (proceed_after_vfork_done): Update.
10841         (handle_vfork_child_exec_or_exit): Update.
10842         (follow_exec): Update.
10843         (displaced_step_prepare_throw): Update.
10844         (displaced_step_restore): Update.
10845         (start_step_over): Update.
10846         (resume_1): Update.
10847         (clear_proceed_status_thread): Update.
10848         (proceed): Update.
10849         (print_target_wait_results): Update.
10850         (do_target_wait): Update.
10851         (context_switch): Update.
10852         (stop_all_threads): Update.
10853         (restart_threads): Update.
10854         (finish_step_over): Update.
10855         (handle_signal_stop): Update.
10856         (switch_back_to_stepped_thread): Update.
10857         (keep_going_pass_signal): Update.
10858         (print_exited_reason): Update.
10859         (normal_stop): Update.
10860         * inferior.c (inferior_pid_to_str): Change return type.
10861         (print_selected_inferior): Update.
10862         (add_inferior): Update.
10863         (detach_inferior): Update.
10864         * dummy-frame.c (fprint_dummy_frames): Update.
10865         * dcache.c (dcache_info_1): Update.
10866         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
10867         (btrace_fetch, btrace_clear): Update.
10868         * linux-tdep.c (linux_core_pid_to_str): Change return type.
10869         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
10870         type.
10871         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
10872         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
10873         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
10874         * gdbarch.c, gdbarch.h: Rebuild.
10875         * gdbarch.sh (core_pid_to_str): Change return type.
10876         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
10877         return type.
10878         (windows_nat_target::pid_to_str): Change return type.
10879         (windows_delete_thread): Update.
10880         (windows_nat_target::attach): Update.
10881         (windows_nat_target::files_info): Update.
10882         * target-delegates.c: Rebuild.
10883         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
10884         return type.
10885         (sol_thread_target::pid_to_str): Change return type.
10886         * remote.c (class remote_target) <pid_to_str>: Change return
10887         type.
10888         (remote_target::pid_to_str): Change return type.
10889         (extended_remote_target::attach, remote_target::remote_stop_ns)
10890         (remote_target::remote_notif_remove_queued_reply)
10891         (remote_target::push_stop_reply, remote_target::disable_btrace):
10892         Update.
10893         (extended_remote_target::attach): Update.
10894         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
10895         type.
10896         (gdbsim_target::pid_to_str): Change return type.
10897         * ravenscar-thread.c (struct ravenscar_thread_target)
10898         <pid_to_str>: Change return type.
10899         (ravenscar_thread_target::pid_to_str): Change return type.
10900         * procfs.c (class procfs_target) <pid_to_str>: Change return
10901         type.
10902         (procfs_target::pid_to_str): Change return type.
10903         (procfs_target::attach): Update.
10904         (procfs_target::detach): Update.
10905         (procfs_target::fetch_registers): Update.
10906         (procfs_target::store_registers): Update.
10907         (procfs_target::wait): Update.
10908         (procfs_target::files_info): Update.
10909         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
10910         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
10911         return type.
10912         (nto_procfs_target::pid_to_str): Change return type.
10913         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
10914         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
10915         return type.
10916         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
10917         (exit_lwp): Update.
10918         (attach_proc_task_lwp_callback, get_detach_signal)
10919         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
10920         (linux_nat_target::resume, wait_lwp, stop_callback)
10921         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
10922         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
10923         (linux_nat_wait_1, resume_stopped_resumed_lwps)
10924         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
10925         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
10926         type.
10927         (inf_ptrace_target::attach): Update.
10928         (inf_ptrace_target::files_info): Update.
10929         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
10930         type.
10931         (go32_nat_target::pid_to_str): Change return type.
10932         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
10933         (gnu_nat_target::wait): Update.
10934         (gnu_nat_target::wait): Update.
10935         (gnu_nat_target::resume): Update.
10936         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
10937         (fbsd_nat_target::wait): Update.
10938         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
10939         type.
10940         (darwin_nat_target::attach): Update.
10941         * corelow.c (class core_target) <pid_to_str>: Change return type.
10942         (core_target::pid_to_str): Change return type.
10943         * target.c (normal_pid_to_str): Change return type.
10944         (default_pid_to_str): Likewise.
10945         (target_pid_to_str): Change return type.
10946         (target_translate_tls_address): Update.
10947         (target_announce_detach): Update.
10948         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
10949         return type.
10950         (bsd_uthread_target::pid_to_str): Change return type.
10951         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
10952         type.
10953         (bsd_kvm_target::pid_to_str): Change return type.
10954         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
10955         return type.
10956         (aix_thread_target::pid_to_str): Change return type.
10957         * target.h (struct target_ops) <pid_to_str>: Change return type.
10958         (target_pid_to_str, normal_pid_to_str): Likewise.
10959         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
10960         type.
10961         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
10962         type.
10963         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
10964         return type.
10965         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
10966         type.
10967         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
10968         type.
10969         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
10970         return type.
10971
10972 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
10973
10974         * NEWS: Mention that the new default MI version is 3.  Mention
10975         changes to the output of commands and events that deal with
10976         multi-location breakpoints.
10977         * breakpoint.c: Include "mi/mi-out.h".
10978         (print_one_breakpoint): Change output syntax if using MI version
10979         >= 3.
10980         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
10981         New.
10982         (mi_multi_location_breakpoint_output_fixed): New.
10983         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
10984         (mi_cmd_fix_multi_location_breakpoint_output): New.
10985         (mi_multi_location_breakpoint_output_fixed): New.
10986         * mi/mi-cmds.c (mi_cmds): Register command
10987         -fix-multi-location-breakpoint-output.
10988         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
10989         interpreter "mi".
10990
10991 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
10992
10993         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
10994         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
10995         instantiate mi_ui_out based on interpreter name.
10996         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
10997         * mi/mi-main.c (mi_load_progress): Likewise.
10998
10999 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
11000
11001         * NEWS: Combine separate "New targets" sections for 8.3.
11002
11003 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
11004
11005         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
11006         (ppcfbsd_init_abi): Install gdbarch
11007         "fetch_tls_load_module_address" and "get_thread_local_address"
11008         methods.
11009
11010 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
11011
11012         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
11013         (riscv_fbsd_init_abi): Install gdbarch
11014         "fetch_tls_load_module_address" and "get_thread_local_address"
11015         methods.
11016
11017 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
11018
11019         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
11020         (i386fbsd_init_abi): Install gdbarch
11021         "fetch_tls_load_module_address" and "get_thread_local_address"
11022         methods.
11023
11024 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
11025
11026         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
11027         (amd64fbsd_init_abi): Install gdbarch
11028         "fetch_tls_load_module_address" and "get_thread_local_address"
11029         methods.
11030
11031 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
11032
11033         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
11034         (struct fbsd_pspace_data): New type.
11035         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
11036         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
11037         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
11038         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
11039         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
11040
11041 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
11042
11043         * gdbtypes.c (lookup_struct_elt): New function.
11044         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
11045         * gdbtypes.h (struct struct_elt): New type.
11046         (lookup_struct_elt): New prototype.
11047
11048 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
11049
11050         * gdbtypes.c (lookup_struct_elt_type): Update comment and
11051         remove disabled code block.
11052
11053 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
11054
11055         * gdbarch.sh (get_thread_local_address): New method.
11056         * gdbarch.h, gdbarch.c: Regenerate.
11057         * target.c (target_translate_tls_address): Use
11058         gdbarch_get_thread_local_address if present instead of
11059         target::get_thread_local_address.
11060
11061 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
11062
11063         * target.h (target::get_thread_local_address): Update comment.
11064
11065 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
11066
11067         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
11068         objfile->separate_debug_objfile_backlink if not NULL.
11069
11070 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
11071
11072         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
11073         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
11074         (amd64bsd_store_inferior_registers): Likewise.
11075         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
11076         Enable segment base registers.
11077         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
11078         PT_GETFSBASE and PT_GETGSBASE.
11079         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
11080         PT_SETGSBASE.
11081         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
11082         segment base registers.
11083         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
11084
11085 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
11086
11087         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
11088         Update calls to i386_target_description to add 'segments'
11089         parameter.
11090         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
11091         add segment base registers.
11092         * arch/i386.c (i386_create_target_description): Add 'segments'
11093         parameter to enable segment base registers.
11094         * arch/i386.h (i386_create_target_description): Likewise.
11095         * features/i386/32bit-segments.xml: New file.
11096         * features/i386/32bit-segments.c: Generate.
11097         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
11098         call to i386_target_description to add 'segments' parameter.
11099         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
11100         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
11101         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
11102         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
11103         if feature is present.
11104         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
11105         Add 'segments' parameter to call to i386_target_description.
11106         (i386_target_description): Add 'segments' parameter to enable
11107         segment base registers.
11108         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
11109         to call to i386_target_description.
11110         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
11111         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
11112         Define I386_NUM_REGS.
11113         (i386_target_description): Add 'segments' parameter to enable
11114         segment base registers.
11115
11116 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
11117
11118         PR/24325
11119         * source-cache.c: #undef open and close, to avoid unresolved
11120         externals during linking.
11121
11122 2019-03-12  Tom Tromey  <tromey@adacore.com>
11123
11124         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
11125         const.  Add initializers.
11126         (_initialize_remote): Don't initialize ptid globals.
11127
11128 2019-03-12  Pedro Alves  <palves@redhat.com>
11129
11130         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
11131
11132 2019-03-12  Pedro Alves  <palves@redhat.com>
11133
11134         * cp-name-parser.y (main): Remove unused 'len' variable.
11135
11136 2019-03-12  Tom Tromey  <tromey@adacore.com>
11137
11138         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
11139         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
11140
11141 2019-03-12  Tom Tromey  <tromey@adacore.com>
11142
11143         * linux-nat.c (iterate_over_lwps): Update.
11144         (stop_callback): Remove parameter.
11145         (stop_wait_callback, detach_callback, resume_set_callback)
11146         (select_singlestep_lwp_callback, set_ignore_sigint)
11147         (status_callback, resumed_callback, resume_clear_callback)
11148         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
11149         data parameter.
11150         (linux_nat_target::detach, linux_nat_target::resume)
11151         (linux_stop_and_wait_all_lwps, select_event_lwp)
11152         (linux_nat_filter_event, linux_nat_wait_1)
11153         (linux_nat_target::kill, linux_nat_target::stop)
11154         (linux_nat_target::stop): Update.
11155         (linux_nat_resume_callback): Change type.
11156         (resume_stopped_resumed_lwps, count_events_callback)
11157         (select_event_lwp_callback): Likewise.
11158         (linux_stop_lwp, linux_nat_stop_lwp): Update.
11159         * arm-linux-nat.c (struct update_registers_data): Remove.
11160         (update_registers_callback): Change type.
11161         (arm_linux_insert_hw_breakpoint1): Update.
11162         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
11163         parameter.
11164         (x86_linux_dr_set_addr): Update.
11165         (x86_linux_dr_set_control): Update.
11166         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
11167         (iterate_over_lwps): Use gdb::function_view.
11168         * nat/aarch64-linux-hw-point.c (struct
11169         aarch64_dr_update_callback_param): Remove.
11170         (debug_reg_change_callback): Change type.
11171         (aarch64_notify_debug_reg_change): Update.
11172         * s390-linux-nat.c (s390_refresh_per_info): Update.
11173
11174 2019-03-11  Tom Tromey  <tromey@adacore.com>
11175
11176         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
11177         redundant assignment to "this_cu".
11178
11179 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11180
11181         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
11182
11183 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11184
11185         * gdbtypes.c (rank_one_type_parm_set): New function extracted
11186         from...
11187         (rank_one_type): ... this.
11188
11189 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11190
11191         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
11192         from...
11193         (rank_one_type): ... this.
11194
11195 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11196
11197         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
11198         from...
11199         (rank_one_type): ... this.
11200
11201 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11202
11203         * gdbtypes.c (rank_one_type_parm_float): New function extracted
11204         from...
11205         (rank_one_type): ... this.
11206
11207 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11208
11209         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
11210         from...
11211         (rank_one_type): ... this.
11212
11213 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11214
11215         * gdbtypes.c (rank_one_type_parm_range): New function extracted
11216         from...
11217         (rank_one_type): ... this.
11218
11219 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11220
11221         * gdbtypes.c (rank_one_type_parm_char): New function extracted
11222         from...
11223         (rank_one_type): ... this.
11224
11225 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11226
11227         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
11228         from...
11229         (rank_one_type): ... this.
11230
11231 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11232
11233         * gdbtypes.c (rank_one_type_parm_int): New function extracted
11234         from...
11235         (rank_one_type): ... this.
11236
11237 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11238
11239         * gdbtypes.c (rank_one_type_parm_func): New function extracted
11240         from...
11241         (rank_one_type): ... this.
11242
11243 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11244
11245         * gdbtypes.c (rank_one_type_parm_array): New function extracted
11246         from...
11247         (rank_one_type): ... this.
11248
11249 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11250
11251         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
11252         from...
11253         (rank_one_type): ... this.
11254
11255 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11256
11257         * inferior.c (initialize_inferiors): Ensure 'help set/show print
11258         inferior-events' shows the example events.
11259
11260 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
11261
11262         Support styling on native MS-Windows console
11263
11264         PR/24315
11265         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
11266         on MS-Windows if $TERM is not defined.
11267
11268         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
11269
11270         * posix-hdep.c (gdb_console_fputs):
11271         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
11272         functions.
11273         * ui-file.h (gdb_console_fputs): Add prototype.
11274
11275         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
11276         back to fputs only if the former returns zero.
11277
11278 2019-03-07  Tom Tromey  <tom@tromey.com>
11279
11280         * symmisc.c (print_symbol_bcache_statistics): Update.
11281         (print_objfile_statistics): Update.
11282         * symfile.c (allocate_symtab): Update.
11283         * stabsread.c: Don't include bcache.h.
11284         * psymtab.h (struct psymbol_bcache): Don't declare.
11285         (class psymtab_storage) <psymbol_cache>: Now a bcache.
11286         (psymbol_bcache_init, psymbol_bcache_free)
11287         (psymbol_bcache_get_bcache): Don't declare.
11288         * psymtab.c (struct psymbol_bcache): Remove.
11289         (psymtab_storage::psymtab_storage): Update.
11290         (psymtab_storage::~psymtab_storage): Update.
11291         (psymbol_bcache_init, psymbol_bcache_free)
11292         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
11293         (add_psymbol_to_bcache): Update.
11294         (allocate_psymtab): Update.
11295         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
11296         macro_cache>: No longer pointers.
11297         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
11298         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
11299         * macrotab.c (macro_bcache): Update.
11300         * macroexp.c: Don't include bcache.h.
11301         * gdbtypes.c (check_types_worklist): Update.
11302         (types_deeply_equal): Remove TRY/CATCH.  Update.
11303         * elfread.c (elf_symtab_read): Update.
11304         * dwarf2read.c: Don't include bcache.h.
11305         * buildsym.c (buildsym_compunit::get_macro_table): Update.
11306         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
11307         (print_bcache_statistics, bcache_memory_used): Don't declare.
11308         (struct bcache): Move from bcache.c.  Add constructor, destructor,
11309         methods.  Rename all data members.
11310         * bcache.c (struct bcache): Move to bcache.h.
11311         (bcache::expand_hash_table): Rename from expand_hash_table.
11312         (bcache): Remove.
11313         (bcache::insert): Rename from bcache_full.
11314         (bcache::compare): Rename from bcache_compare.
11315         (bcache_xmalloc): Remove.
11316         (bcache::~bcache): Rename from bcache_xfree.
11317         (bcache::print_statistics): Rename from print_bcache_statistics.
11318         (bcache::memory_used): Rename from bcache_memory_used.
11319
11320 2019-03-07  Pedro Alves  <palves@redhat.com>
11321
11322         * infrun.c (normal_stop): Also check for
11323         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
11324
11325 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
11326
11327         * f-lang.c (value_from_host_double): Moved to...
11328         * value.c (value_from_host_double): ...here.
11329         * value.h (value_from_host_double): Declare.
11330         * guile/scm-math.c (vlscm_convert_typed_number): Use
11331         value_from_host_double.
11332         (vlscm_convert_number): Likewise.
11333         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
11334         * python/py-value.c (convert_value_from_python): Likewise.
11335
11336 2019-03-06  Tom Tromey  <tom@tromey.com>
11337
11338         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
11339
11340 2019-03-06  Tom Tromey  <tom@tromey.com>
11341
11342         * utils.h (free_current_contents): Don't declare.
11343         * utils.c (free_current_contents): Remove.
11344
11345 2019-03-06  Tom Tromey  <tom@tromey.com>
11346
11347         * top.c (quit_force): Update.
11348         * main.c (captured_command_loop): Update.
11349         * common/new-op.c (operator new): Update.
11350         * common/common-exceptions.c (struct catcher)
11351         <save_cleanup_chain>: Remove member.
11352         (exceptions_state_mc_init): Update.
11353         (exception_try_scope_entry): Return nullptr.
11354         (exception_try_scope_exit, exception_rethrow)
11355         (throw_exception_sjlj, throw_exception_cxx): Update.
11356         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
11357         (all_cleanups, do_cleanups, discard_cleanups)
11358         (discard_final_cleanups, save_cleanups, save_final_cleanups)
11359         (restore_cleanups, restore_final_cleanups): Don't declare.
11360         (do_final_cleanups): Remove parameter.
11361         * common/cleanups.c (cleanup_chain, make_cleanup)
11362         (make_cleanup_dtor, all_cleanups, do_cleanups)
11363         (discard_my_cleanups, discard_cleanups)
11364         (discard_final_cleanups, save_my_cleanups, save_cleanups)
11365         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
11366         (null_cleanup): Remove.
11367         (do_final_cleanups): Remove parameter.
11368
11369 2019-03-06  Tom Tromey  <tom@tromey.com>
11370
11371         * remote.c (remote_target::remote_parse_stop_reply): Use
11372         unique_xmalloc_ptr.
11373
11374 2019-03-06  Tom Tromey  <tom@tromey.com>
11375
11376         * stabsread.c (struct stabs_field_info): Rename from field_info.
11377         <list, fnlist>: Add initializers.
11378         <obstack>: New member.
11379         (read_member_functions, read_struct_fields, read_baseclasses):
11380         Allocate on obstack.  Don't use cleanups.
11381         (read_one_struct_field, read_member_functions, read_struct_fields)
11382         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
11383         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
11384         (read_struct_type): Update.
11385
11386 2019-03-06  Tom Tromey  <tom@tromey.com>
11387
11388         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
11389         * common/filestuff.h (make_cleanup_close): Don't declare.
11390         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
11391         Remove.
11392
11393 2019-03-06  Tom Tromey  <tom@tromey.com>
11394
11395         * solib-aix.c: Use make_scope_exit.
11396
11397 2019-03-06  Tom Tromey  <tom@tromey.com>
11398
11399         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
11400         Use make_scope_exit.
11401
11402 2019-03-06  Tom Tromey  <tom@tromey.com>
11403
11404         * solib-svr4.c (disable_probes_interface): Remove parameter.
11405         (svr4_handle_solib_event): Use make_scope_exit.
11406
11407 2019-03-06  Tom Tromey  <tom@tromey.com>
11408
11409         * remote.c (struct stop_reply_deleter): Remove.
11410         (stop_reply_up): Update.
11411         (struct stop_reply): Derive from notif_event.  Don't typedef.
11412         <regcache>: Now a std::vector.
11413         (stop_reply_xfree): Remove.
11414         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
11415         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
11416         (remote_target::discard_pending_stop_replies): Use delete.
11417         (remote_target::remote_parse_stop_reply): Update.
11418         (remote_target::process_stop_reply): Update.
11419         * remote-notif.h (struct notif_event): Add virtual destructor.
11420         Remove "dtr" member.
11421         (struct notif_client) <alloc_event>: Return a unique_ptr.
11422         (notif_event_xfree): Don't declare.
11423         (notif_event_up): New typedef.
11424         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
11425         (notif_event_xfree, do_notif_event_xfree): Remove.
11426         (remote_notif_state_xfree): Update.
11427
11428 2019-03-06  Tom Tromey  <tom@tromey.com>
11429
11430         * infrun.c (displaced_step_clear_cleanup): Now a
11431         forward_scope_exit type.
11432         (displaced_step_prepare_throw): Update.
11433         (displaced_step_fixup): Update.
11434
11435 2019-03-06  Tom Tromey  <tom@tromey.com>
11436
11437         * inferior.h (class inferior): Update comment.
11438         * gdbthread.h (class thread_info): Update comment.
11439
11440 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
11441             Tom Tromey  <tom@tromey.com>
11442
11443         * stabsread.h (struct stab_section_list): Remove.
11444         (coffstab_build_psymtabs): Update.
11445         * dbxread.c (symbuf_sections): Now a std::vector.
11446         (sect_idx): New global.
11447         (fill_symbuf): Update.
11448         (coffstab_build_psymtabs): Change type of stabsects parameter.
11449         Update.
11450         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
11451         std::vector.
11452         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
11453         (coff_locate_sections): Update.
11454         (coff_symfile_read): Remove cleanups.  Update.
11455         (init_stringtab): Add storage parameter.
11456         (free_stringtab, free_stringtab_cleanup): Remove.
11457         (init_lineno): Add storage parameter.
11458         (free_linetab, free_linetab_cleanup): Remove.
11459
11460 2019-03-06  Pedro Alves  <palves@redhat.com>
11461
11462         * linux-fork.c (fork_info::clobber_regs): Delete.
11463         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
11464         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
11465         comment.  Adjust.
11466         (scoped_switch_fork_info::scoped_switch_fork_info)
11467         (checkpoint_command, linux_fork_context): Adjust
11468         fork_save_infrun_state calls.
11469
11470 2019-03-06  Pedro Alves  <palves@redhat.com>
11471
11472         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
11473         (inf_has_multiple_threads): Return 'bool' and rewrite using
11474         inferior_info::threads().
11475
11476 2019-03-06  Pedro Alves  <palves@redhat.com>
11477
11478         * linux-fork.c: Include <list>.
11479         (fork_list): Now a std::list instance.
11480         (fork_info): Add ctor, dtor, and in-class initialize all fields.
11481         (forks_exist_p, find_last_fork): Adjust.
11482         (new_fork): Delete.
11483         (one_fork_p): New.
11484         (add_fork): Adjust.
11485         (free_fork): Delete, folded into fork_info::~fork_info().
11486         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
11487         Adjust.
11488         (init_fork_list): Delete.
11489         (linux_fork_killall, linux_fork_mourn_inferior)
11490         (linux_fork_detach, info_checkpoints_command): Adjust.
11491         (_initialize_linux_fork): No longer call init_fork_list.
11492
11493 2019-03-06  Pedro Alves  <palves@redhat.com>
11494
11495         * linux-fork.c (new_fork): New, split out of ...
11496         (add_fork): ... this.  Return void.  Move "first fork" special
11497         case from here, to ...
11498         (checkpoint_command): ... here.
11499         * linux-linux.h (add_fork): Return void.
11500
11501 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
11502
11503         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
11504
11505 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
11506             Chris January  <chris.january@arm.com>
11507             David Lecomber  <david.lecomber@arm.com>
11508
11509         * f-exp.y: New token, UNOP_INTRINSIC.
11510         (exp): New pattern using UNOP_INTRINSIC token.
11511         (f77_keywords): Add 'abs' keyword.
11512         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
11513         (value_from_host_double): New function.
11514         (evaluate_subexp_f): Support UNOP_ABS.
11515
11516 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
11517
11518         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
11519         types.
11520
11521 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
11522
11523         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
11524         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
11525         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
11526
11527 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
11528
11529         * f-exp.y (convert_to_kind_type): Handle more type kinds.
11530
11531 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
11532             Chris January  <chris.january@arm.com>
11533
11534         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
11535         * f-exp.y: Define 'KIND' token.
11536         (exp): New pattern for KIND expressions.
11537         (ptype): Handle types with a kind extension.
11538         (direct_abs_decl): Extend to spot kind extensions.
11539         (f77_keywords): Add 'kind' to the list.
11540         (push_kind_type): New function.
11541         (convert_to_kind_type): New function.
11542         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
11543         * parse.c (operator_length_standard): Likewise.
11544         * parser-defs.h (enum type_pieces): Add tp_kind.
11545         * std-operator.def: Add UNOP_KIND.
11546
11547 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
11548
11549         * f-exp.y (f_parse): Set yydebug.
11550
11551 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
11552
11553         * f-lang.c (evaluate_subexp_f): New function.
11554         (exp_descriptor_f): New global.
11555         (f_language_defn): Use exp_descriptor_f instead of
11556         exp_descriptor_standard.
11557
11558 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
11559
11560         * f-exp.y (struct token): Add comments.
11561         (dot_ops): Remove uppercase versions and the end marker.
11562         (f77_keywords): Likewise.
11563         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
11564         entries in the dot_ops array are case insensitive, and use
11565         strncasecmp to compare strings.  Also some whitespace cleanup in
11566         this area.  Similar for the f77_keywords array, except entries in
11567         this list might be case sensitive.
11568
11569 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
11570
11571         * f-exp.y (struct f77_boolean_val): Add comments.
11572         (boolean_values): Remove uppercase versions, and end marker.
11573         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
11574         and use strncasecmp to achieve case insensitivity.  Additionally,
11575         perform whitespace cleanup around this code.
11576
11577 2019-03-06  Tom Tromey  <tromey@adacore.com>
11578
11579         * remote-sim.c (gdbsim_target_open): Use result of
11580         gdb_argv::release.
11581
11582 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
11583         Dirk Schubert  <dirk.schubert@arm.com>
11584         Chris January  <chris.january@arm.com>
11585
11586         * eval.c (evaluate_subexp_standard): Call Fortran argument
11587         wrapping logic.
11588         * f-lang.c (struct value): A value which can be passed into a
11589         Fortran function call.
11590         (fortran_argument_convert): Wrap Fortran arguments in a pointer
11591         where appropriate.
11592         (struct type): Value ready for a Fortran function call.
11593         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
11594         is needed.
11595         * f-lang.h (fortran_argument_convert): Declaration.
11596         (fortran_preserve_arg_pointer): Declaration.
11597         * infcall.c (value_arg_coerce): Call Fortran argument logic.
11598
11599 2019-03-05  Tom Tromey  <tromey@adacore.com>
11600
11601         * python/py-prettyprint.c (print_string_repr): Remove #if.
11602         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
11603
11604 2019-03-05  Tom Tromey  <tromey@adacore.com>
11605
11606         * target.c (the_dummy_target): Move later.  Change type to
11607         "dummy_target".
11608         (initialize_targets): Don't initialize the_dummy_target.
11609
11610 2019-03-05  Tom Tromey  <tromey@adacore.com>
11611
11612         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
11613         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
11614
11615 2019-03-05  Tom Tromey  <tromey@adacore.com>
11616
11617         * windows-nat.c (windows_nat_target::attach)
11618         (windows_nat_target::detach): Don't call gdb_flush.
11619         * valprint.c (generic_val_print, val_print, val_print_string):
11620         Don't call gdb_flush.
11621         * utils.c (defaulted_query): Don't call gdb_flush.
11622         * typeprint.c (print_type_scalar): Don't call gdb_flush.
11623         * target.c (target_announce_detach): Don't call gdb_flush.
11624         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
11625         * remote.c (extended_remote_target::attach): Don't call
11626         gdb_flush.
11627         * procfs.c (procfs_target::detach): Don't call gdb_flush.
11628         * printcmd.c (do_examine): Don't call gdb_flush.
11629         (info_display_command): Don't call gdb_flush.
11630         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
11631         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
11632         * memattr.c (info_mem_command): Don't call gdb_flush.
11633         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
11634         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
11635         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
11636         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
11637         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
11638         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
11639         (gnu_nat_target::detach): Don't call gdb_flush.
11640         * f-valprint.c (f_val_print): Don't call gdb_flush.
11641         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
11642         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
11643         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
11644         gdb_flush.
11645         * c-valprint.c (c_val_print): Don't call gdb_flush.
11646         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
11647
11648 2019-03-05  Tom Tromey  <tromey@adacore.com>
11649
11650         * varobj.c (update_dynamic_varobj_children): Update.
11651         (install_default_visualizer): Use reset, not release.
11652         * value.c (set_internalvar): Update.
11653         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
11654         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
11655         ATTRIBUTE_UNUSED_RESULT.
11656
11657 2019-03-05  Tom Tromey  <tromey@adacore.com>
11658
11659         * remote.c (class scoped_remote_fd) <release>: Add
11660         ATTRIBUTE_UNUSED_RESULT.
11661
11662 2019-03-05  Tom Tromey  <tromey@adacore.com>
11663
11664         * macroexp.c (struct macro_buffer) <release>: Add
11665         ATTRIBUTE_UNUSED_RESULT.
11666
11667 2019-03-05  Tom Tromey  <tromey@adacore.com>
11668
11669         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
11670         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
11671         ATTRIBUTE_UNUSED_RESULT.
11672
11673 2019-03-05  Tom Tromey  <tromey@adacore.com>
11674
11675         * common/scoped_fd.h (class scoped_fd) <release>: Add
11676         ATTRIBUTE_UNUSED_RESULT.
11677
11678 2019-03-05  Tom Tromey  <tromey@adacore.com>
11679
11680         * parser-defs.h (struct parser_state) <release>: Add
11681         ATTRIBUTE_UNUSED_RESULT.
11682
11683 2019-03-05  Tom Tromey  <tromey@adacore.com>
11684
11685         * utils.h (class gdb_argv) <release>: Add
11686         ATTRIBUTE_UNUSED_RESULT.
11687         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
11688
11689 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
11690
11691         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
11692         for-loop range, to avoid compiler warnings.
11693
11694         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
11695         avoid compiler warnings about unused variables.
11696
11697         * NEWS: Mention end of support for native debugging on MS-Windows
11698         before XP.
11699
11700         PR gdb/24292
11701         * common/netstuff.c:
11702         * gdbserver/gdbreplay.c
11703         * gdbserver/remote-utils.c:
11704         * ser-tcp.c:
11705         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
11706         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
11707         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
11708         'getaddrinfo' and 'freeaddrinfo' were not available before
11709         Windows XP, and mingw.org's MinGW headers by default define
11710         _WIN32_WINNT to 0x500.
11711
11712 2019-03-01  Gary Benson <gbenson@redhat.com>
11713
11714         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
11715
11716 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
11717             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
11718
11719         PR gdb/8527
11720         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
11721         set_sigint_trap, clear_sigint_trap.
11722
11723 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11724
11725         * target.c (target_detach): Clear the regcache and the
11726         frame cache.
11727
11728 2019-02-27  Pedro Alves  <palves@redhat.com>
11729
11730         * utils.c (set_screen_size): When we cap the height/width sizes,
11731         tweak the corresponding command variable to show "unlimited":
11732
11733 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
11734             Pedro Alves  <palves@redhat.com>
11735
11736         * utils.c (set_screen_size): Reduce "infinite" rows and columns
11737         before calling rl_set_screen_size.
11738
11739 2019-02-27  Tom Tromey  <tromey@adacore.com>
11740
11741         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
11742         define.
11743         * python/py-value.c: Remove Python 2.4 workaround.
11744         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
11745         workaround.
11746         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
11747         Python 2.4 workaround.
11748         * python/python-internal.h: Remove Python 2.4 comment.
11749         (Py_ssize_t): Don't define.
11750         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
11751         (gdb_Py_DECREF): Remove Python 2.4 workaround.
11752         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
11753         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
11754         * python/python.c (do_start_initialization): Remove Python 2.4
11755         workaround.
11756         * python/py-prettyprint.c (class dummy_python_frame): Remove.
11757         (print_children): Remove Python 2.4 workaround.
11758         * python/py-inferior.c (buffer_procs): Remove Python 2.4
11759         workaround.
11760         (CHARBUFFERPROC_NAME): Remove.
11761         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
11762         Python 2.4 workaround.
11763
11764 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
11765
11766         * NEWS: Note minimum Python version.
11767
11768 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
11769
11770         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
11771         code from these functions.  Remove corresponding ifdefs.  Use
11772         Py_buffer_up instead of explicit calls to PyBuffer_Release.
11773         Remove gotos and target of gotos.
11774         (infpy_search_memory): Likewise.
11775
11776 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
11777
11778         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
11779         (hppa_gdbarch_init): Don't register deleted functions with
11780         gdbarch.
11781
11782 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
11783
11784         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
11785         (h8300_unwind_sp): Delete.
11786         (h8300_dummy_id): Delete.
11787         (h8300_gdbarch_init): Don't register deleted functions with
11788         gdbarch.
11789
11790 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
11791
11792         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
11793         (ft32_unwind_pc): Delete.
11794         (ft32_unwind_sp): Delete.
11795         (ft32_gdbarch_init): Don't register deleted functions with
11796         gdbarch.
11797
11798 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
11799
11800         * gdb/frv-tdep.c (frv_dummy_id): Delete.
11801         (frv_unwind_pc): Delete.
11802         (frv_unwind_sp): Delete.
11803         (frv_gdbarch_init): Don't register deleted functions with
11804         gdbarch.
11805
11806 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
11807
11808         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
11809         (riscv_unwind_pc): Delete.
11810         (riscv_unwind_sp): Delete.
11811         (riscv_gdbarch_init): Don't register deleted functions with
11812         gdbarch.
11813
11814 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
11815
11816         * gdb/csky-tdep.c (csky_dummy_id): Delete.
11817         (csky_unwind_pc): Delete.
11818         (csky_unwind_sp): Delete.
11819         (csky_gdbarch_init): Don't register deleted functions with
11820         gdbarch.
11821
11822 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
11823
11824         * gdb/cris-tdep.c (cris_dummy_id): Delete.
11825         (cris_unwind_pc): Delete.
11826         (cris_unwind_sp): Delete.
11827         (cris_gdbarch_init): Don't register deleted functions with
11828         gdbarch.
11829
11830 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
11831
11832         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
11833         (bfin_unwind_pc): Delete.
11834         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
11835
11836 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
11837
11838         * gdb/arm-tdep.c (arm_dummy_id): Delete.
11839         (arm_unwind_pc): Delete.
11840         (arm_unwind_sp): Delete.
11841         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
11842
11843 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
11844
11845         * gdb/arc-tdep.c (arc_dummy_id): Delete.
11846         (arc_unwind_pc): Delete.
11847         (arc_unwind_sp): Delete.
11848         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
11849
11850 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
11851
11852         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
11853         (alpha_unwind_pc): Delete.
11854         (alpha_gdbarch_init): Don't register deleted functions with
11855         gdbarch.
11856
11857 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
11858
11859         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
11860         (aarch64_unwind_pc): Delete.
11861         (aarch64_unwind_sp): Delete.
11862         (aarch64_gdbarch_init): Don't register deleted functions with
11863         gdbarch.
11864
11865 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
11866
11867         * gdbtypes.c (type_align): Don't consider static members when
11868         computing structure alignment.
11869
11870 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
11871
11872         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
11873         return 0 for other types.
11874         * arch-utils.c (default_type_align): Always return 0.
11875         * gdbarch.h: Regenerate.
11876         * gdbarch.sh (type_align): Extend comment.
11877         * gdbtypes.c (type_align): Add additional comments, always call
11878         gdbarch_type_align before applying the default rules.
11879         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
11880         generic code will then apply a suitable default.
11881         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
11882         types, return 0 for other types.
11883
11884 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
11885
11886         * NEWS: Create a new section for the next release branch.
11887         Rename the section of the current branch, now that it has
11888         been cut.
11889
11890 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
11891
11892         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
11893         * version.in: Bump version to 8.3.50.DATE-git.
11894
11895 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
11896
11897         * aix-thread.c (ptid_cmp): Remove unused variable.
11898         (get_signaled_thread): Likewise.
11899         (store_regs_user_thread): Likewise.
11900         (store_regs_kernel_thread): Likewise.
11901         (fetch_regs_kernel_thread): Remove shadowed variable.
11902
11903 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
11904
11905         * features/riscv/32bit-cpu.xml: Add register numbers.
11906         * features/riscv/32bit-fpu.c: Regenerate.
11907         * features/riscv/32bit-fpu.xml: Add register numbers.
11908         * features/riscv/64bit-cpu.xml: Add register numbers.
11909         * features/riscv/64bit-fpu.c: Regenerate.
11910         * features/riscv/64bit-fpu.xml: Add register numbers.
11911
11912 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
11913
11914         * NEWS: Mention two argument form of gdb.Value constructor.
11915         * python/py-value.c (convert_buffer_and_type_to_value): New
11916         function.
11917         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
11918         Add support for handling an optional second argument.  Call
11919         convert_buffer_and_type_to_value as appropriate.
11920         * python/python-internal.h (Py_buffer_deleter): New struct.
11921         (Py_buffer_up): New typedef.
11922
11923 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
11924
11925         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
11926         instead of releasing ownership.
11927
11928 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
11929
11930         * dwarf2read.c (open_and_init_dwp_file): Call
11931         elf_numsections instead of bfd_count_sections to initialize
11932         dwp_file->num_sections.
11933
11934 2019-02-25  Tom Tromey  <tromey@adacore.com>
11935
11936         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
11937
11938 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
11939
11940         * gcore.in: Add '--readnever' option when invoking GDB.
11941
11942 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
11943
11944         * MAINTAINERS: Update my email address.
11945
11946 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
11947
11948         * build-id.c (build_id_to_debug_bfd_1): New function.
11949         (build_id_to_debug_bfd): Look for separate debug file in
11950         sysroot.
11951
11952 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
11953
11954         * gdbarch.sh: Update the copyright year range that is placed into
11955         generated files.
11956
11957 2019-02-22  Keith Seitz  <keiths@redhat.com>
11958
11959         PR symtab/23853
11960         * linespec.c (create_sals_line_offset): Search for the default
11961         symtab's filename instead of its fullname.
11962
11963 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
11964
11965         * NEWS: Update style defaults.
11966
11967 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
11968
11969         * main.c (captured_main_1): Disable styling in batch mode.
11970
11971 2019-02-20  Tom Tromey  <tom@tromey.com>
11972
11973         * symtab.c (symtab_symbol_info): Fix typos.
11974
11975 2019-02-20  Tom Tromey  <tromey@adacore.com>
11976
11977         * findcmd.c (_initialize_mem_search): Use upper case for
11978         metasyntactic variables.
11979
11980 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
11981
11982         * aarch64-tdep.c (aarch64_add_reggroups): New function.
11983         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
11984
11985 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
11986
11987         * top.h (source_file_name): Change to std::string.
11988         * top.c (source_file_name): Likewise.
11989         (command_line_input): Adjust.
11990         * cli/cli-script.c (script_from_file): Adjust.
11991
11992 2019-02-19  Tom Tromey  <tromey@adacore.com>
11993
11994         * ravenscar-thread.c
11995         (ravenscar_thread_target::update_thread_list): Don't call
11996         ada_build_task_list.
11997         * ada-lang.h (ada_build_task_list): Don't declare.
11998         * ada-tasks.c (struct ada_tasks_inferior_data)
11999         <task_list_valid_p>: Now bool.
12000         (read_known_tasks, ada_task_list_changed)
12001         (ada_tasks_invalidate_inferior_data): Update.
12002         (read_known_tasks_array): Return bool.
12003         (read_known_tasks_list): Likewise.
12004         (read_known_tasks): Return void.
12005         (ada_build_task_list): Now static.
12006
12007 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
12008
12009         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
12010         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
12011
12012 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12013
12014         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
12015         variant for ada_tasks_pspace_data_handle and
12016         ada_tasks_inferior_data_handle.
12017         (ada_tasks_pspace_data_cleanup): New function.
12018         (ada_tasks_inferior_data_cleanup): New function.
12019
12020 2019-02-17  Tom Tromey  <tom@tromey.com>
12021
12022         * macrotab.h (macro_source_fullname): Return a std::string.
12023         * macrotab.c (macro_include, check_for_redefinition)
12024         (macro_undef, macro_lookup_definition, foreach_macro)
12025         (foreach_macro_in_scope): Update.
12026         (macro_source_fullname): Return a std::string.
12027         * macrocmd.c (show_pp_source_pos): Update.
12028
12029 2019-02-17  Tom Tromey  <tom@tromey.com>
12030
12031         * macrocmd.c (show_pp_source_pos): Style the file names.
12032
12033 2019-02-17  Tom Tromey  <tom@tromey.com>
12034
12035         PR tui/24197:
12036         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
12037
12038 2019-02-17  Tom Tromey  <tom@tromey.com>
12039
12040         * ada-lang.c (user_select_syms): Use filtered printing.
12041         * utils.c (wrap_style): New global.
12042         (desired_style): Remove.
12043         (emit_style_escape): Add stream parameter.
12044         (set_output_style, reset_terminal_style, prompt_for_continue):
12045         Update.
12046         (flush_wrap_buffer): Only flush gdb_stdout.
12047         (wrap_here): Set wrap_style.
12048         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
12049         treat escape sequences as a character.  Change when wrap buffer is
12050         flushed.
12051         (fputs_styled): Do not set the output style when the default is
12052         requested.
12053         * ui-style.h (struct ui_file_style) <is_default>: New method.
12054         * source.c (print_source_lines_base): Emit escape sequences in one
12055         piece.
12056
12057 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
12058
12059         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
12060         integers and enumeration types.
12061
12062 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
12063
12064         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
12065         instead of lookup_symbol_in_language
12066         (do_exact_match): New function.
12067         (ada_get_symbol_name_matcher): Return do_exact_match when
12068         doing a verbatim match.
12069
12070 2019-02-15  Tom Tromey  <tromey@adacore.com>
12071
12072         * ravenscar-thread.c (ravenscar_thread_target::resume)
12073         (ravenscar_thread_target::wait): Special case wildcard requests.
12074
12075 2019-02-15  Tom Tromey  <tromey@adacore.com>
12076
12077         * ravenscar-thread.c (base_ptid): Remove.
12078         (struct ravenscar_thread_target) <close>: New method.
12079         <m_base_ptid>: New member.
12080         <update_inferior_ptid, active_task, task_is_currently_active,
12081         runtime_initialized>: Declare methods.
12082         <ravenscar_thread_target>: Add constructor.
12083         (ravenscar_thread_target::task_is_currently_active)
12084         (ravenscar_thread_target::update_inferior_ptid)
12085         (ravenscar_runtime_initialized): Rename.  Now methods.
12086         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
12087         (ravenscar_thread_target::update_thread_list): Update.
12088         (ravenscar_thread_target::active_task): Now method.
12089         (ravenscar_thread_target::store_registers)
12090         (ravenscar_thread_target::prepare_to_store)
12091         (ravenscar_thread_target::prepare_to_store)
12092         (ravenscar_thread_target::mourn_inferior): Update.
12093         (ravenscar_inferior_created): Use "new" to create target.
12094         (ravenscar_thread_target::get_ada_task_ptid): Update.
12095         (_initialize_ravenscar): Don't initialize base_ptid.
12096         (ravenscar_ops): Remove global.
12097
12098 2019-02-15  Tom Tromey  <tromey@adacore.com>
12099
12100         * target.h (push_target): Declare new overload.
12101         * target.c (push_target): New overload, taking an rvalue reference.
12102         * remote.c (remote_target::open_1): Use push_target overload.
12103         * corelow.c (core_target_open): Use push_target overload.
12104
12105 2019-02-15  Tom Tromey  <tromey@adacore.com>
12106
12107         * ravenscar-thread.c (is_ravenscar_task)
12108         (ravenscar_task_is_currently_active): Return bool.
12109         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
12110         (_initialize_ravenscar): Remove "(void)".
12111         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
12112         Return bool.
12113
12114 2019-02-15  Tom Tromey  <tromey@adacore.com>
12115
12116         * ravenscar-thread.c (ravenscar_runtime_initializer)
12117         (has_ravenscar_runtime, get_running_thread_id)
12118         (ravenscar_thread_target::resume): Fix indentation.
12119
12120 2019-02-15  Tom Tromey  <tromey@adacore.com>
12121
12122         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
12123         from ravenscar_arch_ops.
12124         (sparc_ravenscar_ops::fetch_registers)
12125         (sparc_ravenscar_ops::store_registers): Now methods.
12126         (sparc_ravenscar_prepare_to_store): Remove.
12127         (sparc_ravenscar_ops): Redefine.
12128         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
12129         methods and destructor.  Remove members.
12130         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
12131         (ravenscar_thread_target::store_registers)
12132         (ravenscar_thread_target::prepare_to_store): Update.
12133         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
12134         Remove.
12135         (struct ppc_ravenscar_powerpc_ops): Derive from
12136         ravenscar_arch_ops.
12137         (ppc_ravenscar_powerpc_ops::fetch_registers)
12138         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
12139         (ppc_ravenscar_powerpc_ops): Redefine.
12140         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
12141         (ppc_ravenscar_e500_ops::fetch_registers)
12142         (ppc_ravenscar_e500_ops::store_registers): Now methods.
12143         (ppc_ravenscar_e500_ops): Redefine.
12144         * aarch64-ravenscar-thread.c
12145         (aarch64_ravenscar_generic_prepare_to_store): Remove.
12146         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
12147         (aarch64_ravenscar_fetch_registers)
12148         (aarch64_ravenscar_store_registers): Now methods.
12149         (aarch64_ravenscar_ops): Redefine.
12150
12151 2019-02-15  Tom Tromey  <tromey@adacore.com>
12152
12153         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
12154         (ravenscar_thread_target::stopped_by_hw_breakpoint)
12155         (ravenscar_thread_target::stopped_by_watchpoint)
12156         (ravenscar_thread_target::stopped_data_address)
12157         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
12158
12159 2019-02-15  Tom Tromey  <tromey@adacore.com>
12160
12161         * ravenscar-thread.c: Fix some typos.
12162
12163 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12164             Tom Tromey  <tromey@adacore.com>
12165
12166         * ada-lang.c (ada_exception_sal): Change addr_string to a
12167         std::string.
12168         (create_ada_exception_catchpoint): Update.
12169
12170 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12171             Tom Tromey  <tromey@adacore.com>
12172
12173         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
12174         (bp_location_ops): Remove.
12175         (base_breakpoint_allocate_location): Update.
12176         (free_bp_location): Update.
12177         * ada-lang.c (class ada_catchpoint_location)
12178         <ada_catchpoint_location>: Remove ops parameter.
12179         (ada_catchpoint_location_dtor): Remove.
12180         (ada_catchpoint_location_ops): Remove.
12181         (allocate_location_exception): Update.
12182         * breakpoint.h (struct bp_location_ops): Remove.
12183         (class bp_location) <bp_location>: Remove bp_location_ops
12184         parameter.
12185         <~bp_location>: Add destructor.
12186         <ops>: Remove.
12187
12188 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
12189             Pedro Alves  <palves@redhat.com>
12190
12191         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
12192         'PATH_MAX'.
12193
12194 2019-02-14  David Michael  <fedora.dm0@gmail.com>
12195             Samuel Thibault  <samuel.thibault@gnu.org>
12196             Thomas Schwinge  <thomas@codesourcery.com>
12197
12198         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
12199         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
12200
12201 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
12202
12203         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
12204         (check_empty): Use "const char *".
12205
12206         * gnu-nat.c (gnu_nat_target::detach): Instead of
12207         'detach_inferior (pid)' call
12208         'detach_inferior (find_inferior_pid (pid))'.
12209
12210         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
12211         'nat/fork-inferior.o'.
12212         * gnu-nat.c: #include "nat/fork-inferior.h".
12213
12214         * gnu-nat.c (gnu_nat_target::detach): Instead of
12215         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
12216         * gnu-nat.h: #include "inf-child.h".
12217         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
12218         'i386_gnu_nat_target::fetch_registers'.
12219         (gnu_store_registers): Rename/move to
12220         'i386_gnu_nat_target::store_registers'.
12221
12222         * config/i386/nm-i386gnu.h: Don't "#include" any files.
12223         * gnu-nat.h (mach_thread_info): New function.
12224         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
12225
12226         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
12227
12228 2019-02-14  Frederic Konrad  <konrad@adacore.com>
12229
12230         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
12231
12232 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
12233
12234         * windows-nat.c (windows_add_thread): Add new parameter
12235         "main_thread_p" with default value set to false.  Update
12236         function documentation as well as all callers.
12237         (windows_delete_thread): Likewise.
12238         (fake_create_process): Update call to windows_add_thread.
12239         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
12240         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
12241         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
12242         call to windows_delete_thread.
12243
12244 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
12245
12246         * MAINTAINERS: Add Andrew Burgess as global maintainer.
12247
12248 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
12249
12250         * symfile.c (find_separate_debug_file): Use canonical path of
12251         sysroot with child_path instead of gdb_sysroot if it is valid.
12252
12253 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
12254
12255         * symfile.c (find_separate_debug_file): Use child_path to
12256         determine if an object file is under a sysroot.
12257
12258 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
12259
12260         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
12261         unittests/child-path-selftests.c.
12262         * common/pathstuff.c (child_path): New function.
12263         * common/pathstuff.h (child_path): New prototype.
12264         * unittests/child-path-selftests.c: New file.
12265
12266 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
12267
12268         * symfile.c (find_separate_debug_file): Look for separate debug
12269         files in debug directories under the sysroot.
12270
12271 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12272
12273         * symtab.h (struct minimal_symbol data_p): New const method.
12274         (struct minimal_symbol text_p): Likewise.
12275         * symtab.c (output_source_filename): Use file name style
12276         to print file name.
12277         (print_symbol_info): Likewise.
12278         (print_msymbol_info): Use address style to print addresses.
12279         Use function name style to print executable text symbols.
12280         (expand_symtab_containing_pc): Use data_p.
12281         (find_pc_sect_compunit_symtab): Likewise.
12282
12283 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12284
12285         * breakpoint.c (describe_other_breakpoints): Use address style
12286         to print addresses.
12287         (say_where): Likewise.
12288
12289 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12290
12291         * ada-typeprint.c (print_func_type): Print function name
12292         style to print function name.
12293         * c-typeprint.c (c_print_type_1): Likewise.
12294
12295 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
12296
12297         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
12298         for execve.
12299
12300 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12301
12302         * c-exp.y (direct_abs_decl): Use emplace_back to record the
12303         type_stack.
12304
12305 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
12306
12307         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
12308         TYPE_CODE_REF types.
12309
12310 2019-02-08  Jim Wilson  <jimw@sifive.com>
12311
12312         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
12313         (riscv_linux_fregset): New.
12314         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
12315
12316 2019-02-07  Tom Tromey  <tom@tromey.com>
12317
12318         * thread.c (thread_cancel_execution_command): Update.
12319         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
12320         methods.
12321         (struct thread_fsm_ops): Remove.
12322         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
12323         (thread_fsm_should_stop, thread_fsm_return_value)
12324         (thread_fsm_set_finished, thread_fsm_finished_p)
12325         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
12326         Don't declare.
12327         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
12328         * infrun.c (clear_proceed_status_thread)
12329         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
12330         (print_stop_event): Update.
12331         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
12332         Add constructor.
12333         (step_command_fsm_ops): Remove.
12334         (new_step_command_fsm): Remove.
12335         (step_1): Update.
12336         (step_command_fsm::should_stop): Rename from
12337         step_command_fsm_should_stop.
12338         (step_command_fsm::clean_up): Rename from
12339         step_command_fsm_clean_up.
12340         (step_command_fsm::do_async_reply_reason): Rename from
12341         step_command_fsm_async_reply_reason.
12342         (struct until_next_fsm): Inherit from thread_fsm.  Add
12343         constructor.
12344         (until_next_fsm_ops): Remove.
12345         (new_until_next_fsm): Remove.
12346         (until_next_fsm::should_stop): Rename from
12347         until_next_fsm_should_stop.
12348         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
12349         (until_next_fsm::do_async_reply_reason): Rename from
12350         until_next_fsm_async_reply_reason.
12351         (struct finish_command_fsm): Inherit from thread_fsm.  Add
12352         constructor.  Change type of breakpoint.
12353         (finish_command_fsm_ops): Remove.
12354         (new_finish_command_fsm): Remove.
12355         (finish_command_fsm::should_stop): Rename from
12356         finish_command_fsm_should_stop.
12357         (finish_command_fsm::clean_up): Rename from
12358         finish_command_fsm_clean_up.
12359         (finish_command_fsm::return_value): Rename from
12360         finish_command_fsm_return_value.
12361         (finish_command_fsm::do_async_reply_reason): Rename from
12362         finish_command_fsm_async_reply_reason.
12363         (finish_command): Update.
12364         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
12365         Add constructor.
12366         (call_thread_fsm_ops): Remove.
12367         (call_thread_fsm::call_thread_fsm): Rename from
12368         new_call_thread_fsm.
12369         (call_thread_fsm::should_stop): Rename from
12370         call_thread_fsm_should_stop.
12371         (call_thread_fsm::should_notify_stop): Rename from
12372         call_thread_fsm_should_notify_stop.
12373         (run_inferior_call, call_function_by_hand_dummy): Update.
12374         * cli/cli-interp.c (should_print_stop_to_console): Update.
12375         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
12376         Add constructor.  Change type of location_breakpoint,
12377         caller_breakpoint.
12378         (until_break_fsm_ops): Remove.
12379         (new_until_break_fsm): Remove.
12380         (until_break_fsm::should_stop): Rename from
12381         until_break_fsm_should_stop.
12382         (until_break_fsm::clean_up): Rename from
12383         until_break_fsm_clean_up.
12384         (until_break_fsm::do_async_reply_reason): Rename from
12385         until_break_fsm_async_reply_reason.
12386         (until_break_command): Update.
12387         * thread-fsm.c: Remove.
12388         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
12389
12390 2019-02-07  Tom Tromey  <tom@tromey.com>
12391
12392         * yy-remap.h: Add include guard.
12393         * xtensa-tdep.h: Add include guard.
12394         * xcoffread.h: Rename include guard.
12395         * varobj-iter.h: Add include guard.
12396         * tui/tui.h: Rename include guard.
12397         * tui/tui-winsource.h: Rename include guard.
12398         * tui/tui-wingeneral.h: Rename include guard.
12399         * tui/tui-windata.h: Rename include guard.
12400         * tui/tui-win.h: Rename include guard.
12401         * tui/tui-stack.h: Rename include guard.
12402         * tui/tui-source.h: Rename include guard.
12403         * tui/tui-regs.h: Rename include guard.
12404         * tui/tui-out.h: Rename include guard.
12405         * tui/tui-layout.h: Rename include guard.
12406         * tui/tui-io.h: Rename include guard.
12407         * tui/tui-hooks.h: Rename include guard.
12408         * tui/tui-file.h: Rename include guard.
12409         * tui/tui-disasm.h: Rename include guard.
12410         * tui/tui-data.h: Rename include guard.
12411         * tui/tui-command.h: Rename include guard.
12412         * tic6x-tdep.h: Add include guard.
12413         * target/waitstatus.h: Rename include guard.
12414         * target/wait.h: Rename include guard.
12415         * target/target.h: Rename include guard.
12416         * target/resume.h: Rename include guard.
12417         * target-float.h: Rename include guard.
12418         * stabsread.h: Add include guard.
12419         * rs6000-tdep.h: Add include guard.
12420         * riscv-fbsd-tdep.h: Add include guard.
12421         * regformats/regdef.h: Rename include guard.
12422         * record.h: Rename include guard.
12423         * python/python.h: Rename include guard.
12424         * python/python-internal.h: Rename include guard.
12425         * python/py-stopevent.h: Rename include guard.
12426         * python/py-ref.h: Rename include guard.
12427         * python/py-record.h: Rename include guard.
12428         * python/py-record-full.h: Rename include guard.
12429         * python/py-record-btrace.h: Rename include guard.
12430         * python/py-instruction.h: Rename include guard.
12431         * python/py-events.h: Rename include guard.
12432         * python/py-event.h: Rename include guard.
12433         * procfs.h: Add include guard.
12434         * proc-utils.h: Add include guard.
12435         * p-lang.h: Add include guard.
12436         * or1k-tdep.h: Rename include guard.
12437         * observable.h: Rename include guard.
12438         * nto-tdep.h: Rename include guard.
12439         * nat/x86-linux.h: Rename include guard.
12440         * nat/x86-linux-dregs.h: Rename include guard.
12441         * nat/x86-gcc-cpuid.h: Add include guard.
12442         * nat/x86-dregs.h: Rename include guard.
12443         * nat/x86-cpuid.h: Rename include guard.
12444         * nat/ppc-linux.h: Rename include guard.
12445         * nat/mips-linux-watch.h: Rename include guard.
12446         * nat/linux-waitpid.h: Rename include guard.
12447         * nat/linux-ptrace.h: Rename include guard.
12448         * nat/linux-procfs.h: Rename include guard.
12449         * nat/linux-osdata.h: Rename include guard.
12450         * nat/linux-nat.h: Rename include guard.
12451         * nat/linux-namespaces.h: Rename include guard.
12452         * nat/linux-btrace.h: Rename include guard.
12453         * nat/glibc_thread_db.h: Rename include guard.
12454         * nat/gdb_thread_db.h: Rename include guard.
12455         * nat/gdb_ptrace.h: Rename include guard.
12456         * nat/fork-inferior.h: Rename include guard.
12457         * nat/amd64-linux-siginfo.h: Rename include guard.
12458         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
12459         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
12460         * nat/aarch64-linux.h: Rename include guard.
12461         * nat/aarch64-linux-hw-point.h: Rename include guard.
12462         * mn10300-tdep.h: Add include guard.
12463         * mips-linux-tdep.h: Add include guard.
12464         * mi/mi-parse.h: Rename include guard.
12465         * mi/mi-out.h: Rename include guard.
12466         * mi/mi-main.h: Rename include guard.
12467         * mi/mi-interp.h: Rename include guard.
12468         * mi/mi-getopt.h: Rename include guard.
12469         * mi/mi-console.h: Rename include guard.
12470         * mi/mi-common.h: Rename include guard.
12471         * mi/mi-cmds.h: Rename include guard.
12472         * mi/mi-cmd-break.h: Rename include guard.
12473         * m2-lang.h: Add include guard.
12474         * location.h: Rename include guard.
12475         * linux-record.h: Rename include guard.
12476         * linux-nat.h: Add include guard.
12477         * linux-fork.h: Add include guard.
12478         * i386-darwin-tdep.h: Rename include guard.
12479         * hppa-linux-offsets.h: Add include guard.
12480         * guile/guile.h: Rename include guard.
12481         * guile/guile-internal.h: Rename include guard.
12482         * gnu-nat.h: Rename include guard.
12483         * gdb-stabs.h: Rename include guard.
12484         * frv-tdep.h: Add include guard.
12485         * f-lang.h: Add include guard.
12486         * event-loop.h: Add include guard.
12487         * darwin-nat.h: Rename include guard.
12488         * cp-abi.h: Rename include guard.
12489         * config/sparc/nm-sol2.h: Rename include guard.
12490         * config/nm-nto.h: Rename include guard.
12491         * config/nm-linux.h: Add include guard.
12492         * config/i386/nm-i386gnu.h: Rename include guard.
12493         * config/djgpp/nl_types.h: Rename include guard.
12494         * config/djgpp/langinfo.h: Rename include guard.
12495         * compile/gcc-cp-plugin.h: Add include guard.
12496         * compile/gcc-c-plugin.h: Add include guard.
12497         * compile/compile.h: Rename include guard.
12498         * compile/compile-object-run.h: Rename include guard.
12499         * compile/compile-object-load.h: Rename include guard.
12500         * compile/compile-internal.h: Rename include guard.
12501         * compile/compile-cplus.h: Rename include guard.
12502         * compile/compile-c.h: Rename include guard.
12503         * common/xml-utils.h: Rename include guard.
12504         * common/x86-xstate.h: Rename include guard.
12505         * common/version.h: Rename include guard.
12506         * common/vec.h: Rename include guard.
12507         * common/tdesc.h: Rename include guard.
12508         * common/selftest.h: Rename include guard.
12509         * common/scoped_restore.h: Rename include guard.
12510         * common/scoped_mmap.h: Rename include guard.
12511         * common/scoped_fd.h: Rename include guard.
12512         * common/safe-iterator.h: Rename include guard.
12513         * common/run-time-clock.h: Rename include guard.
12514         * common/refcounted-object.h: Rename include guard.
12515         * common/queue.h: Rename include guard.
12516         * common/ptid.h: Rename include guard.
12517         * common/print-utils.h: Rename include guard.
12518         * common/preprocessor.h: Rename include guard.
12519         * common/pathstuff.h: Rename include guard.
12520         * common/observable.h: Rename include guard.
12521         * common/netstuff.h: Rename include guard.
12522         * common/job-control.h: Rename include guard.
12523         * common/host-defs.h: Rename include guard.
12524         * common/gdb_wait.h: Rename include guard.
12525         * common/gdb_vecs.h: Rename include guard.
12526         * common/gdb_unlinker.h: Rename include guard.
12527         * common/gdb_unique_ptr.h: Rename include guard.
12528         * common/gdb_tilde_expand.h: Rename include guard.
12529         * common/gdb_sys_time.h: Rename include guard.
12530         * common/gdb_string_view.h: Rename include guard.
12531         * common/gdb_splay_tree.h: Rename include guard.
12532         * common/gdb_setjmp.h: Rename include guard.
12533         * common/gdb_ref_ptr.h: Rename include guard.
12534         * common/gdb_optional.h: Rename include guard.
12535         * common/gdb_locale.h: Rename include guard.
12536         * common/gdb_assert.h: Rename include guard.
12537         * common/filtered-iterator.h: Rename include guard.
12538         * common/filestuff.h: Rename include guard.
12539         * common/fileio.h: Rename include guard.
12540         * common/environ.h: Rename include guard.
12541         * common/common-utils.h: Rename include guard.
12542         * common/common-types.h: Rename include guard.
12543         * common/common-regcache.h: Rename include guard.
12544         * common/common-inferior.h: Rename include guard.
12545         * common/common-gdbthread.h: Rename include guard.
12546         * common/common-exceptions.h: Rename include guard.
12547         * common/common-defs.h: Rename include guard.
12548         * common/common-debug.h: Rename include guard.
12549         * common/cleanups.h: Rename include guard.
12550         * common/buffer.h: Rename include guard.
12551         * common/btrace-common.h: Rename include guard.
12552         * common/break-common.h: Rename include guard.
12553         * cli/cli-utils.h: Rename include guard.
12554         * cli/cli-style.h: Rename include guard.
12555         * cli/cli-setshow.h: Rename include guard.
12556         * cli/cli-script.h: Rename include guard.
12557         * cli/cli-interp.h: Rename include guard.
12558         * cli/cli-decode.h: Rename include guard.
12559         * cli/cli-cmds.h: Rename include guard.
12560         * charset-list.h: Add include guard.
12561         * buildsym-legacy.h: Rename include guard.
12562         * bfin-tdep.h: Add include guard.
12563         * ax.h: Rename include guard.
12564         * arm-linux-tdep.h: Add include guard.
12565         * arm-fbsd-tdep.h: Add include guard.
12566         * arch/xtensa.h: Rename include guard.
12567         * arch/tic6x.h: Add include guard.
12568         * arch/i386.h: Add include guard.
12569         * arch/arm.h: Rename include guard.
12570         * arch/arm-linux.h: Rename include guard.
12571         * arch/arm-get-next-pcs.h: Rename include guard.
12572         * arch/amd64.h: Add include guard.
12573         * arch/aarch64-insn.h: Rename include guard.
12574         * arch-utils.h: Rename include guard.
12575         * annotate.h: Add include guard.
12576         * amd64-darwin-tdep.h: Rename include guard.
12577         * aarch64-linux-tdep.h: Add include guard.
12578         * aarch64-fbsd-tdep.h: Add include guard.
12579         * aarch32-linux-nat.h: Add include guard.
12580
12581 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12582
12583         * macrotab.c (macro_define_internal): New function that
12584         factorizes macro_define_object_internal and macro_define_function
12585         code.
12586         (macro_define_object_internal): Use macro_define_internal.
12587         (macro_define_function): Likewise.
12588
12589 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12590
12591         * macrocmd.c (extract_identifier): Return
12592         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
12593         callers.
12594
12595 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
12596
12597         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
12598
12599 2019-02-05  Tom Tromey  <tom@tromey.com>
12600
12601         * target.c (target_stack::unpush): Move assertion earlier.
12602
12603 2019-01-30  Tom Tromey  <tom@tromey.com>
12604
12605         PR python/23615:
12606         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
12607         (gdbpy_parse_and_eval): Likewise.
12608         * python/python-internal.h (gdbpy_allow_threads): New class.
12609
12610 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
12611
12612         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
12613         (aarch64_fbsd_fpregmap): Move earlier.
12614         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
12615         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
12616         instead of individual calls to trad_frame_set_reg_addr.
12617         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
12618         earlier.
12619         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
12620         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
12621         instead of individual calls to trad_frame_set_reg_addr.
12622
12623 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
12624
12625         * CONTRIBUTE: Replace contribution list with wiki link.
12626
12627 2019-01-25  Tom Tromey  <tom@tromey.com>
12628
12629         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
12630
12631 2019-01-25  Tom Tromey  <tom@tromey.com>
12632
12633         * xtensa-linux-nat.c: Fix common/ includes.
12634         * xml-support.h: Fix common/ includes.
12635         * xml-support.c: Fix common/ includes.
12636         * x86-linux-nat.c: Fix common/ includes.
12637         * windows-nat.c: Fix common/ includes.
12638         * varobj.h: Fix common/ includes.
12639         * varobj.c: Fix common/ includes.
12640         * value.c: Fix common/ includes.
12641         * valops.c: Fix common/ includes.
12642         * utils.c: Fix common/ includes.
12643         * unittests/xml-utils-selftests.c: Fix common/ includes.
12644         * unittests/utils-selftests.c: Fix common/ includes.
12645         * unittests/unpack-selftests.c: Fix common/ includes.
12646         * unittests/tracepoint-selftests.c: Fix common/ includes.
12647         * unittests/style-selftests.c: Fix common/ includes.
12648         * unittests/string_view-selftests.c: Fix common/ includes.
12649         * unittests/scoped_restore-selftests.c: Fix common/ includes.
12650         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
12651         * unittests/scoped_fd-selftests.c: Fix common/ includes.
12652         * unittests/rsp-low-selftests.c: Fix common/ includes.
12653         * unittests/parse-connection-spec-selftests.c: Fix common/
12654         includes.
12655         * unittests/optional-selftests.c: Fix common/ includes.
12656         * unittests/offset-type-selftests.c: Fix common/ includes.
12657         * unittests/observable-selftests.c: Fix common/ includes.
12658         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
12659         * unittests/memrange-selftests.c: Fix common/ includes.
12660         * unittests/memory-map-selftests.c: Fix common/ includes.
12661         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
12662         * unittests/function-view-selftests.c: Fix common/ includes.
12663         * unittests/environ-selftests.c: Fix common/ includes.
12664         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
12665         * unittests/common-utils-selftests.c: Fix common/ includes.
12666         * unittests/cli-utils-selftests.c: Fix common/ includes.
12667         * unittests/array-view-selftests.c: Fix common/ includes.
12668         * ui-file.c: Fix common/ includes.
12669         * tui/tui-io.c: Fix common/ includes.
12670         * tracepoint.h: Fix common/ includes.
12671         * tracepoint.c: Fix common/ includes.
12672         * tracefile-tfile.c: Fix common/ includes.
12673         * top.h: Fix common/ includes.
12674         * top.c: Fix common/ includes.
12675         * thread.c: Fix common/ includes.
12676         * target/waitstatus.h: Fix common/ includes.
12677         * target/waitstatus.c: Fix common/ includes.
12678         * target.h: Fix common/ includes.
12679         * target.c: Fix common/ includes.
12680         * target-memory.c: Fix common/ includes.
12681         * target-descriptions.c: Fix common/ includes.
12682         * symtab.h: Fix common/ includes.
12683         * symfile.c: Fix common/ includes.
12684         * stap-probe.c: Fix common/ includes.
12685         * spu-linux-nat.c: Fix common/ includes.
12686         * sparc-nat.c: Fix common/ includes.
12687         * source.c: Fix common/ includes.
12688         * solib.c: Fix common/ includes.
12689         * solib-target.c: Fix common/ includes.
12690         * ser-unix.c: Fix common/ includes.
12691         * ser-tcp.c: Fix common/ includes.
12692         * ser-pipe.c: Fix common/ includes.
12693         * ser-base.c: Fix common/ includes.
12694         * selftest-arch.c: Fix common/ includes.
12695         * s12z-tdep.c: Fix common/ includes.
12696         * rust-exp.y: Fix common/ includes.
12697         * rs6000-aix-tdep.c: Fix common/ includes.
12698         * riscv-tdep.c: Fix common/ includes.
12699         * remote.c: Fix common/ includes.
12700         * remote-notif.h: Fix common/ includes.
12701         * remote-fileio.h: Fix common/ includes.
12702         * remote-fileio.c: Fix common/ includes.
12703         * regcache.h: Fix common/ includes.
12704         * regcache.c: Fix common/ includes.
12705         * record-btrace.c: Fix common/ includes.
12706         * python/python.c: Fix common/ includes.
12707         * python/py-type.c: Fix common/ includes.
12708         * python/py-inferior.c: Fix common/ includes.
12709         * progspace.h: Fix common/ includes.
12710         * producer.c: Fix common/ includes.
12711         * procfs.c: Fix common/ includes.
12712         * proc-api.c: Fix common/ includes.
12713         * printcmd.c: Fix common/ includes.
12714         * ppc-linux-nat.c: Fix common/ includes.
12715         * parser-defs.h: Fix common/ includes.
12716         * osdata.c: Fix common/ includes.
12717         * obsd-nat.c: Fix common/ includes.
12718         * nat/x86-linux.c: Fix common/ includes.
12719         * nat/x86-linux-dregs.c: Fix common/ includes.
12720         * nat/x86-dregs.h: Fix common/ includes.
12721         * nat/x86-dregs.c: Fix common/ includes.
12722         * nat/ppc-linux.c: Fix common/ includes.
12723         * nat/mips-linux-watch.h: Fix common/ includes.
12724         * nat/mips-linux-watch.c: Fix common/ includes.
12725         * nat/linux-waitpid.c: Fix common/ includes.
12726         * nat/linux-ptrace.h: Fix common/ includes.
12727         * nat/linux-ptrace.c: Fix common/ includes.
12728         * nat/linux-procfs.c: Fix common/ includes.
12729         * nat/linux-personality.c: Fix common/ includes.
12730         * nat/linux-osdata.c: Fix common/ includes.
12731         * nat/linux-namespaces.c: Fix common/ includes.
12732         * nat/linux-btrace.h: Fix common/ includes.
12733         * nat/linux-btrace.c: Fix common/ includes.
12734         * nat/fork-inferior.c: Fix common/ includes.
12735         * nat/amd64-linux-siginfo.c: Fix common/ includes.
12736         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
12737         * nat/aarch64-linux.c: Fix common/ includes.
12738         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
12739         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
12740         * namespace.h: Fix common/ includes.
12741         * mips-linux-tdep.c: Fix common/ includes.
12742         * minsyms.c: Fix common/ includes.
12743         * mi/mi-parse.h: Fix common/ includes.
12744         * mi/mi-main.c: Fix common/ includes.
12745         * mi/mi-cmd-env.c: Fix common/ includes.
12746         * memrange.h: Fix common/ includes.
12747         * memattr.c: Fix common/ includes.
12748         * maint.h: Fix common/ includes.
12749         * maint.c: Fix common/ includes.
12750         * main.c: Fix common/ includes.
12751         * machoread.c: Fix common/ includes.
12752         * location.c: Fix common/ includes.
12753         * linux-thread-db.c: Fix common/ includes.
12754         * linux-nat.c: Fix common/ includes.
12755         * linux-fork.c: Fix common/ includes.
12756         * inline-frame.c: Fix common/ includes.
12757         * infrun.c: Fix common/ includes.
12758         * inflow.c: Fix common/ includes.
12759         * inferior.h: Fix common/ includes.
12760         * inferior.c: Fix common/ includes.
12761         * infcmd.c: Fix common/ includes.
12762         * inf-ptrace.c: Fix common/ includes.
12763         * inf-child.c: Fix common/ includes.
12764         * ia64-linux-nat.c: Fix common/ includes.
12765         * i387-tdep.c: Fix common/ includes.
12766         * i386-tdep.c: Fix common/ includes.
12767         * i386-linux-tdep.c: Fix common/ includes.
12768         * i386-linux-nat.c: Fix common/ includes.
12769         * i386-go32-tdep.c: Fix common/ includes.
12770         * i386-fbsd-tdep.c: Fix common/ includes.
12771         * i386-fbsd-nat.c: Fix common/ includes.
12772         * guile/scm-type.c: Fix common/ includes.
12773         * guile/guile.c: Fix common/ includes.
12774         * go32-nat.c: Fix common/ includes.
12775         * gnu-nat.c: Fix common/ includes.
12776         * gdbthread.h: Fix common/ includes.
12777         * gdbarch-selftests.c: Fix common/ includes.
12778         * gdb_usleep.c: Fix common/ includes.
12779         * gdb_select.h: Fix common/ includes.
12780         * gdb_bfd.c: Fix common/ includes.
12781         * gcore.c: Fix common/ includes.
12782         * fork-child.c: Fix common/ includes.
12783         * findvar.c: Fix common/ includes.
12784         * fbsd-nat.c: Fix common/ includes.
12785         * event-top.c: Fix common/ includes.
12786         * event-loop.c: Fix common/ includes.
12787         * dwarf2read.c: Fix common/ includes.
12788         * dwarf2loc.c: Fix common/ includes.
12789         * dwarf2-frame.c: Fix common/ includes.
12790         * dwarf-index-cache.c: Fix common/ includes.
12791         * dtrace-probe.c: Fix common/ includes.
12792         * disasm-selftests.c: Fix common/ includes.
12793         * defs.h: Fix common/ includes.
12794         * csky-tdep.c: Fix common/ includes.
12795         * cp-valprint.c: Fix common/ includes.
12796         * cp-support.h: Fix common/ includes.
12797         * cp-support.c: Fix common/ includes.
12798         * corelow.c: Fix common/ includes.
12799         * completer.h: Fix common/ includes.
12800         * completer.c: Fix common/ includes.
12801         * compile/compile.c: Fix common/ includes.
12802         * compile/compile-loc2c.c: Fix common/ includes.
12803         * compile/compile-cplus-types.c: Fix common/ includes.
12804         * compile/compile-cplus-symbols.c: Fix common/ includes.
12805         * command.h: Fix common/ includes.
12806         * cli/cli-dump.c: Fix common/ includes.
12807         * cli/cli-cmds.c: Fix common/ includes.
12808         * charset.c: Fix common/ includes.
12809         * build-id.c: Fix common/ includes.
12810         * btrace.h: Fix common/ includes.
12811         * btrace.c: Fix common/ includes.
12812         * breakpoint.h: Fix common/ includes.
12813         * breakpoint.c: Fix common/ includes.
12814         * ax.h:
12815         (enum agent_op): Fix common/ includes.
12816         * ax-general.c (struct aop_map): Fix common/ includes.
12817         * ax-gdb.c: Fix common/ includes.
12818         * auxv.c: Fix common/ includes.
12819         * auto-load.c: Fix common/ includes.
12820         * arm-tdep.c: Fix common/ includes.
12821         * arch/riscv.c: Fix common/ includes.
12822         * arch/ppc-linux-common.c: Fix common/ includes.
12823         * arch/i386.c: Fix common/ includes.
12824         * arch/arm.c: Fix common/ includes.
12825         * arch/arm-linux.c: Fix common/ includes.
12826         * arch/arm-get-next-pcs.c: Fix common/ includes.
12827         * arch/amd64.c: Fix common/ includes.
12828         * arch/aarch64.c: Fix common/ includes.
12829         * arch/aarch64-insn.c: Fix common/ includes.
12830         * arch-utils.c: Fix common/ includes.
12831         * amd64-windows-tdep.c: Fix common/ includes.
12832         * amd64-tdep.c: Fix common/ includes.
12833         * amd64-sol2-tdep.c: Fix common/ includes.
12834         * amd64-obsd-tdep.c: Fix common/ includes.
12835         * amd64-nbsd-tdep.c: Fix common/ includes.
12836         * amd64-linux-tdep.c: Fix common/ includes.
12837         * amd64-linux-nat.c: Fix common/ includes.
12838         * amd64-fbsd-tdep.c: Fix common/ includes.
12839         * amd64-fbsd-nat.c: Fix common/ includes.
12840         * amd64-dicos-tdep.c: Fix common/ includes.
12841         * amd64-darwin-tdep.c: Fix common/ includes.
12842         * agent.c: Fix common/ includes.
12843         * ada-lang.h: Fix common/ includes.
12844         * ada-lang.c: Fix common/ includes.
12845         * aarch64-tdep.c: Fix common/ includes.
12846
12847 2019-01-25  Tom Tromey  <tom@tromey.com>
12848
12849         * common/create-version.sh: Use common/version.h.
12850
12851 2019-01-24  Pedro Alves  <palves@redhat.com>
12852
12853         * infrun.c (signal_stop, signal_print, signal_program)
12854         (signal_catch, signal_pass): Now arrays instead of pointers.
12855         (update_signals_program_target, do_target_resume)
12856         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
12857         * linux-nat.c (linux_nat_target::pass_signals)
12858         (linux_nat_target::create_inferior, linux_nat_target::attach):
12859         Adjust.
12860         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
12861         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
12862         * procfs.c (procfs_target::pass_signals): Adjust.
12863         * record-full.c (record_full_target::resume): Adjust.
12864         * remote.c (remote_target::pass_signals)
12865         (remote_target::program_signals): Adjust.
12866         * target-debug.h (target_debug_print_signals): Now takes a
12867         gdb::array_view as parameter.  Adjust.
12868         * target.h (target_ops) <pass_signals, program_signals>: Replace
12869         pointer and length parameters with gdb::array_view.
12870         (target_pass_signals, target_program_signals): Likewise.
12871         * target-delegates.c: Regenerate.
12872
12873 2019-01-24  Pedro Alves  <palves@redhat.com>
12874
12875         * common/forward-scope-exit.h
12876         (forward_scope_exit::forward_scope_exit): Pass arguments to
12877         m_bind_function directly, instead of creating a std::bind and
12878         copying that.
12879
12880 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
12881
12882         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
12883         for static members.
12884         (pass_in_v_vfp_candidate): Likewise.
12885
12886 2019-01-23  Tom Tromey  <tom@tromey.com>
12887             Pedro Alves  <palves@redhat.com>
12888
12889         * regcache.c (class regcache_invalidator): Remove.
12890         (regcache::raw_write): Use make_scope_exit.
12891
12892 2019-01-23  Tom Tromey  <tom@tromey.com>
12893
12894         * ui-out.h (class ui_out_emit_type): Update comment.
12895
12896 2019-01-23  Tom Tromey  <tom@tromey.com>
12897
12898         * infrun.c (fetch_inferior_event): Update comment.
12899
12900 2019-01-23  Tom Tromey  <tom@tromey.com>
12901             Pedro Alves  <palves@redhat.com>
12902
12903         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
12904         parameter.
12905         (fetch_inferior_event): Use SCOPE_EXIT.
12906
12907
12908 2019-01-23  Tom Tromey  <tom@tromey.com>
12909             Pedro Alves  <palves@redhat.com>
12910
12911         * infrun.c (disable_thread_events): Delete.
12912         (stop_all_threads): Use SCOPE_EXIT.
12913
12914 2019-01-23  Tom Tromey  <tom@tromey.com>
12915             Pedro Alves  <palves@redhat.com>
12916
12917         * symfile.c: Include forward-scope-exit.h.
12918         (clear_symtab_users_cleanup): Replace forward declaration with
12919         a FORWARD_SCOPE_EXIT.
12920         (syms_from_objfile_1): Use the forward_scope_exit and
12921         gdb::optional instead of cleanup_function.
12922         (reread_symbols): Use the forward_scope_exit instead of
12923         cleanup_function.
12924         (clear_symtab_users_cleanup): Remove function.
12925
12926 2019-01-23  Tom Tromey  <tom@tromey.com>
12927             Pedro Alves  <palves@redhat.com>
12928
12929         * linux-nat.c: Include scope-exit.h.
12930         (cleanup_target_stop): Remove.
12931         (linux_nat_target::static_tracepoint_markers_by_strid): Use
12932         SCOPE_EXIT.
12933
12934 2019-01-23  Tom Tromey  <tom@tromey.com>
12935             Pedro Alves  <palves@redhat.com>
12936
12937         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
12938         (call_function_by_hand_dummy): Use SCOPE_EXIT.
12939
12940 2019-01-23  Tom Tromey  <tom@tromey.com>
12941             Andrew Burgess  <andrew.burgess@embecosm.com>
12942             Pedro Alves  <palves@redhat.com>
12943
12944         * infrun.c (fetch_inferior_event): Use scope_exit.
12945         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
12946         * top.c (execute_command): Use scope_exit.
12947         * breakpoint.c (bpstat_do_actions): Use scope_exit.
12948         * utils.c (do_bpstat_clear_actions_cleanup)
12949         (make_bpstat_clear_actions_cleanup): Remove.
12950
12951 2019-01-23  Tom Tromey  <tom@tromey.com>
12952             Pedro Alves  <palves@redhat.com>
12953
12954         * infrun.c: Include "common/scope-exit.h"
12955         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
12956         (wait_for_inferior): Use SCOPE_EXIT.
12957         (fetch_inferior_event): Use scope_exit.
12958
12959 2019-01-23  Tom Tromey  <tom@tromey.com>
12960             Pedro Alves  <palves@redhat.com>
12961
12962         * breakpoint.c (create_breakpoint): Remove cleanup.
12963
12964 2019-01-23  Tom Tromey  <tom@tromey.com>
12965             Andrew Burgess  <andrew.burgess@embecosm.com>
12966             Pedro Alves  <palves@redhat.com>
12967
12968 2019-01-23  Pedro Alves  <palves@redhat.com>
12969
12970         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
12971
12972 2019-01-23  Pedro Alves  <palves@redhat.com>
12973             Andrew Burgess  <andrew.burgess@embecosm.com>
12974
12975         * gdbthread.h: Include "common/forward-scope-exit.h".
12976         (scoped_finish_thread_state): Redefine custom class in terms of
12977         forward_scope_exit.
12978
12979 2019-01-23  Pedro Alves  <palves@redhat.com>
12980             Andrew Burgess  <andrew.burgess@embecosm.com>
12981
12982         * common/forward-scope-exit.h: New file.
12983
12984 2019-01-23  Pedro Alves  <palves@redhat.com>
12985             Andrew Burgess  <andrew.burgess@embecosm.com>
12986             Tom Tromey  <tom@tromey.com>
12987
12988         * common/scope-exit.h: New file.
12989
12990 2019-01-23  Pedro Alves  <palves@redhat.com>
12991
12992         * common/preprocessor.h (ESC): Rename to ...
12993         (ESC_PARENS): ... this.
12994         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
12995         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
12996
12997 2019-01-23  Tom Tromey  <tom@tromey.com>
12998
12999         * language.h (class scoped_switch_to_sym_language_if_auto):
13000         Initialize m_lang in both cases.
13001
13002 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
13003
13004         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
13005         with XCNEW.
13006
13007 2019-01-22  Tom Tromey  <tom@tromey.com>
13008
13009         * corelow.c: Do not include sys/file.h.
13010
13011 2019-01-22  Tom Tromey  <tom@tromey.com>
13012
13013         * tui/tui-wingeneral.h: Include gdb_curses.h.
13014
13015 2019-01-22  Tom Tromey  <tom@tromey.com>
13016
13017         * source-cache.h (class source_cache) <get_source_lines,
13018         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
13019
13020 2019-01-22  Tom Tromey  <tom@tromey.com>
13021
13022         * remote-fileio.h (struct remote_target): Declare.
13023
13024 2019-01-22  Tom Tromey  <tom@tromey.com>
13025
13026         * python/py-arch.c: Do not include py-ref.h.
13027         * python/py-bpevent.c: Do not include py-ref.h.
13028         * python/py-cmd.c: Do not include py-ref.h.
13029         * python/py-continueevent.c: Do not include py-ref.h.
13030         * python/py-event.h: Do not include py-ref.h.
13031         * python/py-evtregistry.c: Do not include py-ref.h.
13032         * python/py-finishbreakpoint.c: Do not include py-ref.h.
13033         * python/py-frame.c: Do not include py-ref.h.
13034         * python/py-framefilter.c: Do not include py-ref.h.
13035         * python/py-function.c: Do not include py-ref.h.
13036         * python/py-infevents.c: Do not include py-ref.h.
13037         * python/py-linetable.c: Do not include py-ref.h.
13038         * python/py-objfile.c: Do not include py-ref.h.
13039         * python/py-param.c: Do not include py-ref.h.
13040         * python/py-prettyprint.c: Do not include py-ref.h.
13041         * python/py-progspace.c: Do not include py-ref.h.
13042         * python/py-symbol.c: Do not include py-ref.h.
13043         * python/py-symtab.c: Do not include py-ref.h.
13044         * python/py-type.c: Do not include py-ref.h.
13045         * python/py-unwind.c: Do not include py-ref.h.
13046         * python/py-utils.c: Do not include py-ref.h.
13047         * python/py-value.c: Do not include py-ref.h.
13048         * python/py-varobj.c: Do not include py-ref.h.
13049         * python/py-xmethods.c: Do not include py-ref.h.
13050         * python/python.c: Do not include py-ref.h.
13051         * varobj.c: Do not include py-ref.h.
13052
13053 2019-01-22  Tom Tromey  <tom@tromey.com>
13054
13055         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
13056         keyword for bcache.
13057
13058 2019-01-22  Tom Tromey  <tom@tromey.com>
13059
13060         * compile/compile-cplus-types.c: Remove a comment by #include.
13061
13062 2019-01-22  Tom Tromey  <tom@tromey.com>
13063
13064         * compile/gcc-c-plugin.h: Include compile-internal.h.
13065
13066 2019-01-22  Tom Tromey  <tom@tromey.com>
13067
13068         * stabsread.c (EXTERN): Do not define.
13069         (symnum, next_symbol_text_func, processing_gcc_compilation)
13070         (within_function, global_sym_chain, global_stabs)
13071         (previous_stab_code, this_object_header_files)
13072         (n_this_object_header_files)
13073         (n_allocated_this_object_header_files): Define.
13074         * stabsread.h (EXTERN): Never define.  Use "extern".
13075
13076 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
13077
13078         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
13079         history_value.
13080
13081 2019-01-21  Tom Tromey  <tom@tromey.com>
13082
13083         * ui-out.c: Fix includes.
13084         * tui/tui-source.c: Fix includes.
13085         * target.c: Fix includes.
13086         * remote.c: Fix includes.
13087         * regcache.c: Fix includes.
13088         * python/py-block.c: Fix includes.
13089         * printcmd.c: Fix includes.
13090         * or1k-tdep.c: Fix includes.
13091         * mi/mi-main.c: Fix includes.
13092         * m32r-tdep.c: Fix includes.
13093         * csky-tdep.c: Fix includes.
13094         * compile/compile-cplus-types.c: Fix includes.
13095         * cli/cli-interp.c: Fix includes.
13096
13097 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
13098
13099         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
13100         for padding.
13101
13102 2019-01-16  Tom Tromey  <tom@tromey.com>
13103
13104         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
13105         earlier.
13106         (struct objfile) <msymbols_range>: Move from top level.
13107         <msymbols>: New method.
13108         (class objfile_msymbols): Remove.
13109         * symtab.c (default_collect_symbol_completion_matches_break_on):
13110         Update.
13111         * symmisc.c (dump_msymbols): Update.
13112         * stabsread.c (scan_file_globals): Update.
13113         * objc-lang.c (info_selectors_command, info_classes_command)
13114         (find_methods): Update.
13115         * minsyms.c (find_solib_trampoline_target): Update.
13116         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
13117         * coffread.c (coff_symfile_read): Update.
13118         * ada-lang.c (ada_lookup_simple_minsym)
13119         (ada_collect_symbol_completion_matches): Update.
13120
13121 2019-01-16  Tom Tromey  <tom@tromey.com>
13122
13123         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
13124         type.  Remove no-argument constructor.
13125         <iterator::operator++>: Simplify.
13126         <begin>: Update.
13127         <end>: Use minimal_symbol_count.
13128
13129 2019-01-16  Tom Tromey  <tom@tromey.com>
13130
13131         * objfiles.h (struct objfile) <psymtabs>: New method.
13132         (class objfile_psymtabs): Remove.
13133         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
13134         typedef.
13135         <range>: New method.
13136         (require_partial_symbols): Change return type.
13137         * psymtab.c (require_partial_symbols)
13138         (psym_expand_symtabs_matching): Update.
13139         * mdebugread.c (parse_partial_symbols): Update.
13140         * dbxread.c (dbx_end_psymtab): Update.
13141
13142 2019-01-15  Tom Tromey  <tom@tromey.com>
13143
13144         * symtab.c (lookup_objfile_from_block)
13145         (lookup_symbol_in_objfile_symtabs)
13146         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
13147         (find_line_symtab, info_sources_command)
13148         (default_collect_symbol_completion_matches_break_on)
13149         (make_source_files_completion_list): Update.
13150         * symmisc.c (print_objfile_statistics, dump_objfile)
13151         (maintenance_print_symbols, maintenance_info_symtabs)
13152         (maintenance_check_symtabs, maintenance_info_line_tables):
13153         Update.
13154         * source.c (select_source_symtab)
13155         (forget_cached_source_info_for_objfile): Update.
13156         * objfiles.h (class objfile_compunits): Remove.
13157         (struct objfile) <compunits_range>: New typedef.
13158         (compunits): New method.
13159         * objfiles.c (objfile_relocate1): Update.
13160         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
13161         * maint.c (count_symtabs_and_blocks): Update.
13162         * linespec.c (iterate_over_all_matching_symtabs): Update.
13163         * cp-support.c (add_symbol_overload_list_qualified): Update.
13164         * coffread.c (coff_symtab_read): Update.
13165         * ada-lang.c (add_nonlocal_symbols)
13166         (ada_collect_symbol_completion_matches)
13167         (ada_add_global_exceptions): Update.
13168
13169 2019-01-15  Tom Tromey  <tom@tromey.com>
13170
13171         * progspace.h (program_space) <objfiles_safe_range>: New
13172         typedef.
13173         <objfiles_safe>: New method.
13174         * objfiles.h (class all_objfiles_safe): Remove.
13175         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
13176         * jit.c (jit_inferior_exit_hook): Update.
13177
13178 2019-01-17  Tom Tromey  <tom@tromey.com>
13179
13180         * progspace.h (program_space) <objfiles_range>: New typedef.
13181         <objfiles>: New method.
13182         <objfiles_head>: Rename from objfiles.
13183         (object_files): Update.
13184         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
13185         * guile/scm-pretty-print.c
13186         (ppscm_find_pretty_printer_from_objfiles): Update.
13187         * guile/scm-objfile.c (gdbscm_objfiles): Update.
13188         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
13189         Update.
13190         * python/py-progspace.c (pspy_get_objfiles): Update.
13191         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
13192         Update.
13193         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
13194         (objfpy_lookup_objfile_by_build_id): Update.
13195         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
13196         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
13197         Update.
13198         * symtab.c (iterate_over_symtabs, matching_obj_sections)
13199         (expand_symtab_containing_pc, lookup_objfile_from_block)
13200         (lookup_static_symbol, basic_lookup_transparent_type)
13201         (find_pc_sect_compunit_symtab, find_symbol_at_address)
13202         (find_line_symtab, info_sources_command)
13203         (default_collect_symbol_completion_matches_break_on)
13204         (make_source_files_completion_list, find_main_name): Update.
13205         * symmisc.c (print_symbol_bcache_statistics)
13206         (print_objfile_statistics, maintenance_print_symbols)
13207         (maintenance_print_msymbols, maintenance_print_objfiles)
13208         (maintenance_info_symtabs, maintenance_check_symtabs)
13209         (maintenance_expand_symtabs, maintenance_info_line_tables):
13210         Update.
13211         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
13212         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
13213         (map_overlay_command, unmap_overlay_command)
13214         (simple_overlay_update, expand_symtabs_matching)
13215         (map_symbol_filenames): Update.
13216         * symfile-debug.c (set_debug_symfile): Update.
13217         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
13218         Update.
13219         * source.c (select_source_symtab, forget_cached_source_info):
13220         Update.
13221         * solib.c (solib_read_symbols): Update.
13222         * solib-spu.c (append_ocl_sos): Update.
13223         * psymtab.c (maintenance_print_psymbols)
13224         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
13225         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
13226         * printcmd.c (info_symbol_command): Update.
13227         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
13228         Update.
13229         * objfiles.h (class all_objfiles): Remove.
13230         * objfiles.c (have_partial_symbols, have_full_symbols)
13231         (have_minimal_symbols, qsort_cmp, update_section_map)
13232         (shared_objfile_contains_address_p)
13233         (default_iterate_over_objfiles_in_search_order): Update.
13234         * objc-lang.c (info_selectors_command, info_classes_command)
13235         (find_methods): Update.
13236         * minsyms.c (find_solib_trampoline_target): Update.
13237         * maint.c (maintenance_info_sections)
13238         (maintenance_translate_address, count_symtabs_and_blocks):
13239         Update.
13240         * main.c (captured_main_1): Update.
13241         * linux-thread-db.c (try_thread_db_load_from_pdir)
13242         (has_libpthread): Update.
13243         * linespec.c (iterate_over_all_matching_symtabs)
13244         (search_minsyms_for_name): Update.
13245         * jit.c (jit_find_objf_with_entry_addr): Update.
13246         * hppa-tdep.c (find_unwind_entry)
13247         (hppa_lookup_stub_minimal_symbol): Update.
13248         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
13249         Update.
13250         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
13251         (elf_gnu_ifunc_resolve_by_got): Update.
13252         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
13253         * dwarf-index-write.c (save_gdb_index_command): Update.
13254         * cp-support.c (add_symbol_overload_list_qualified): Update.
13255         * breakpoint.c (create_overlay_event_breakpoint)
13256         (create_longjmp_master_breakpoint)
13257         (create_std_terminate_master_breakpoint)
13258         (create_exception_master_breakpoint): Update.
13259         * blockframe.c (find_pc_partial_function): Update.
13260         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
13261         (ada_collect_symbol_completion_matches)
13262         (ada_add_global_exceptions): Update.
13263
13264 2019-01-17  Tom Tromey  <tom@tromey.com>
13265
13266         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
13267         declare VEC.
13268         (solib_target_parse_libraries): Change return type.
13269         (library_list_start_segment, library_list_start_section)
13270         (library_list_end_library, library_list_start_library); Update.
13271         (solib_target_free_library_list): Remove.
13272         (solib_target_parse_libraries): Remove cleanup.  Change return
13273         type.
13274         (solib_target_current_sos): Update.
13275
13276 2019-01-17  Tom Tromey  <tromey@bapiya>
13277
13278         * valprint.c: Replace "the the" with "the".
13279         * symtab.c: Replace "the the" with "the".
13280         * solib.c: Replace "the the" with "the".
13281         * solib-dsbt.c: Replace "the the" with "the".
13282         * linespec.c: Replace "the the" with "the".
13283         * dwarf2loc.h: Replace "the the" with "the".
13284         * amd64-windows-tdep.c: Replace "the the" with "the".
13285         * aarch64-tdep.c: Replace "the the" with "the".
13286
13287 2019-01-16  Keith Seitz  <keiths@redhat.com>
13288
13289         PR gdb/23773
13290         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
13291         <builder>: Rename to ..
13292         <m_builder>: ... this and make private.
13293         (dwarf2_cu::get_builder): New method.  Change all users of
13294         `builder' to use this method.
13295         (dwarf2_start_symtab): Move to ...
13296         (dwarf2_cu::start_symtab): ... here.  Update all callers
13297         (setup_type_unit_groups): Move to ...
13298         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
13299         callers.
13300         (dwarf2_cu::reset_builder): New method.
13301         (process_full_compunit, process_full_type_unit): Use
13302         dwarf2_cu::reset_builder.
13303         (follow_die_offset): Record the ancestor CU if it is different
13304         from the followed DIE's CU.
13305         (follow_die_sig_1): Likewise.
13306
13307 2019-01-15  Tom Tromey  <tom@tromey.com>
13308
13309         * remote.c (class remote_state) <buf>: Now a char_vector.
13310         <buf_size>: Remove.
13311         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
13312         parameter.
13313         (remote_target::getpkt_or_notif_sane_1)
13314         (remote_target::getpkt_sane)
13315         (remote_target::getpkt_or_notif_sane): Likewise.
13316         (class remote_target) <putpkt>: New overload.
13317         (remote_target::read_frame): Change type of "buf_p".  Remove
13318         sizeof_p parameter.
13319         (packet_ok): New overload.
13320         (packet_check_result): New overload.
13321         Update all uses.
13322
13323 2019-01-14  Tom Tromey  <tom@tromey.com>
13324
13325         * remote-notif.c (handle_notification, remote_notif_ack)
13326         (remote_notif_parse): Make "buf" const.
13327         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
13328         const.
13329         (remote_notif_parse, remote_notif_ack, handle_notification):
13330         Likewise.
13331         * remote.c (remote_notif_stop_parse): Make "buf" const.
13332         (remote_target::remote_parse_stop_reply): Make "buf" const.
13333         (remote_notif_stop_ack): Make "buf" const.
13334
13335 2019-01-14  Tom Tromey  <tom@tromey.com>
13336
13337         * remote.c (remote_console_output): Make parameter const.
13338
13339 2019-01-14  Tom Tromey  <tom@tromey.com>
13340
13341         * target-debug.h (target_debug_print_signals): Constify.
13342         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
13343         * procfs.c (procfs_target::pass_signals): Update.
13344         * linux-nat.c (linux_nat_target::pass_signals): Update.
13345         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
13346         * target-delegates.c: Rebuild.
13347         * remote.c (remote_target::program_signals): Update.
13348         (remote_target::pass_signals): Update.
13349         * target.c (target_pass_signals): Constify argument.
13350         (target_program_signals): Likewise.
13351         * target.h (struct target_ops) <pass_signals, program_signals>:
13352         Constify argument.
13353         (target_pass_signals, target_program_signals): Constify argument.
13354
13355 2019-01-14  Tom Tromey  <tom@tromey.com>
13356
13357         PR tui/28819:
13358         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
13359
13360 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
13361
13362         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
13363         field.
13364         * rs6000-tdep.c: Include reggroups.h.
13365         (IS_V_ALIAS_PSEUDOREG): Define.
13366         (rs6000_register_name): Return names for the "vX" aliases.
13367         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
13368         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
13369         aliases.  Call default_register_reggroup_p for all other
13370         pseudo-registers.
13371         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
13372         New functions.
13373         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
13374         Handle "vX" aliases.
13375         (v_alias_pseudo_register_collect): New function.
13376         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
13377         (rs6000_gdbarch_init): Initialize "vX" aliases as
13378         pseudo-registers.  Restore registration of
13379         rs6000_pseudo_register_reggroup_p with
13380         set_tdesc_pseudo_register_reggroup_p.
13381
13382 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
13383
13384         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
13385         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
13386         set_gdbarch_num_pseudo_regs.
13387
13388 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
13389
13390         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
13391         Remove arg prefixname, add do_set and do_show.
13392         Add member functions set_list and show_list.
13393         * cli/cli-style.c (class cli_style_option): Update accordingly.
13394         (style_set_list): Move to file scope.
13395         (style_show_list): Likewise.
13396         (set_style): Call help_list.
13397         (show_style): Call cmd_show_list.
13398         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
13399         Update to use the new macro.
13400
13401 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
13402
13403         * ada-lang.c (_initialize_ada_language): Expand the help text
13404         for the "catch exception" command.
13405
13406 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
13407
13408         * symtab.c (matching_obj_sections): Initialize obj,
13409         declare it closer to its usage.
13410
13411 2019-01-10  Tom Tromey  <tom@tromey.com>
13412
13413         * thread-iter.h (inf_threads_iterator): Use next_iterator.
13414         (basic_inf_threads_range): Remove.
13415         (inf_threads_range, inf_non_exited_threads_range)
13416         (safe_inf_threads_range): Use next_adapter.
13417
13418 2019-01-10  Keith Seitz  <keiths@redhat.com>
13419
13420         PR gdb/23712
13421         PR symtab/23010
13422         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
13423         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
13424
13425 2019-01-10  Keith Seitz  <keiths@redhat.com>
13426
13427         PR gdb/23712
13428         PR symtab/23010
13429         * dictionary.c (pending_to_vector): Remove.
13430         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
13431         Remove _1 suffix, replacing functions of the same name.  Update
13432         all callers.
13433         (dict_create_hashed, dict_create_hashed_expandable)
13434         (dict_create_linear, dict_create_linear_expandable, dict_free)
13435         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
13436         Make functions static.
13437
13438 2019-01-10  Keith Seitz  <keiths@redhat.com>
13439
13440         PR gdb/23712
13441         PR symtab/23010
13442         * dictionary.h (struct dictionary): Replace declaration with
13443         multidictionary.
13444         (dict_create_hashed, dict_create_hashed_expandable)
13445         (dict_create_linear, dict_create_linear_expandable)
13446         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
13447         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
13448         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
13449         taking multidictionary argument.
13450         [ALL_DICT_SYMBOLS]: Update for multidictionary.
13451         * block.h (struct block) <dict>: Change to multidictionary
13452         and rename `multidict'.
13453         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
13454         symmisc.c: Update all dictionary references to multidictionary.
13455
13456 2019-01-10  Keith Seitz  <keiths@redhat.com>
13457
13458         PR gdb/23712
13459         PR symtab/23010
13460         * dictionary.c: Include unordered_map.
13461         (pending_to_vector): New function.
13462         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
13463         Rewrite the non-"_1" functions to take vector instead
13464         of linked list.
13465         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
13466         "new" _1 versions of the same name.
13467         (multidictionary): Define.
13468         (std::hash<enum language): New definition.
13469         (collate_pending_symbols_by_language, mdict_create_hashed)
13470         (mdict_create_hashed_expandable, mdict_create_linear)
13471         (mdict_create_linear_expandable, mdict_free)
13472         (find_language_dictionary, create_new_language_dictionary)
13473         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
13474         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
13475         (mdict_size, mdict_empty): New functions.
13476         * dictionary.h (mdict_iterator): Define.
13477
13478 2019-01-10  Pedro Alves  <palves@redhat.com>
13479
13480         * breakpoint.c (read_uploaded_action)
13481         (create_tracepoint_from_upload): Adjust to use
13482         gdb::unique_xmalloc_ptr.
13483         * ctf.c (ctf_write_uploaded_tp):
13484         (SET_ARRAY_FIELD): Use emplace_back.
13485         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
13486         * tracefile-tfile.c (tfile_write_uploaded_tp):
13487         * tracepoint.c (parse_tracepoint_definition): Adjust to use
13488         gdb::unique_xmalloc_ptr.
13489         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
13490         at_string, cond_string, cmd_strings>: Replace char pointers
13491         with gdb::unique_xmalloc_ptr.
13492
13493 2019-01-10  Pedro Alves  <palves@redhat.com>
13494
13495         * solib-target.c (library_list_start_library): Don't xstrdup name.
13496
13497 2019-01-10  Pedro Alves  <palves@redhat.com>
13498
13499         * mdebugread.c (parse_partial_symbols): Use
13500         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
13501
13502 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
13503
13504         * linux-fork.c (scoped_switch_fork_info)
13505         <~scoped_switch_fork_info>: Fix incorrect variable name.
13506
13507 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
13508
13509         * linux-fork.c (scoped_switch_fork_info)
13510         <scoped_switch_fork_info>: Make explicit.
13511         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
13512
13513 2019-01-10  Tom Tromey  <tom@tromey.com>
13514
13515         * objfiles.h (objfile::reset_psymtabs): Update.
13516         * objfiles.c (objfile::objfile): Update.
13517         * psymtab.h (psymtab_storage::obstack): Update.
13518         (psymtab_storage::m_obstack): Use gdb::optional.
13519         (class psymtab_storage): Update comment.  Remove objfile
13520         parameter.
13521         * psymtab.c (psymtab_storage::psymtab_storage): Update.
13522
13523 2019-01-10  Tom Tromey  <tom@tromey.com>
13524
13525         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
13526         <free_psymtabs>: Now private.
13527         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
13528         (allocate_psymtab): Use new method.
13529
13530 2019-01-10  Tom Tromey  <tom@tromey.com>
13531
13532         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
13533         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
13534         * mdebugread.c (parse_partial_symbols): Use
13535         allocate_dependencies.
13536         * dwarf2read.c (dwarf2_create_include_psymtab): Use
13537         allocate_dependencies.
13538         (process_psymtab_comp_unit_reader)
13539         (build_type_psymtab_dependencies): Likewise.
13540         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
13541
13542 2019-01-10  Tom Tromey  <tom@tromey.com>
13543
13544         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
13545         PSYMBOL_SET_LANGUAGE.
13546         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
13547
13548 2019-01-10  Tom Tromey  <tom@tromey.com>
13549
13550         * psymtab.h (psymtab_storage::obstack): New method.
13551         <m_obstack>: Rename from obstack; now private.
13552         * psymtab.c (psymtab_storage): Update.
13553         * dwarf2read.c (create_addrmap_from_index)
13554         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
13555         Update.
13556
13557 2019-01-10  Tom Tromey  <tom@tromey.com>
13558
13559         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
13560         * objfiles.h (objfile::reset_psymtabs): New method.
13561
13562 2019-01-10  Tom Tromey  <tom@tromey.com>
13563
13564         * symmisc.c (print_symbol_bcache_statistics): Update.
13565         (print_objfile_statistics): Update.
13566         * symfile.c (reread_symbols): Update.
13567         * psymtab.h (class psymtab_storage): New.
13568         * psymtab.c (psymtab_storage): New constructor.
13569         (~psymtab_storage): New destructor.
13570         (require_partial_symbols): Update.
13571         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
13572         (find_pc_sect_psymtab, find_pc_sect_psymbol)
13573         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
13574         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
13575         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
13576         (start_psymtab_common, end_psymtab_common)
13577         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
13578         (allocate_psymtab): Update.
13579         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
13580         Update.
13581         (dump_psymtab_addrmap, maintenance_print_psymbols)
13582         (maintenance_check_psymtabs): Update.
13583         (class objfile_psymtabs): Move to objfiles.h.
13584         * psympriv.h (discard_psymtab): Now inline.
13585         (psymtab_discarder::psymtab_discarder): Update.
13586         (psymtab_discarder::~psymtab_discarder): Update.
13587         (ALL_OBJFILE_PSYMTABS): Rewrite.
13588         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
13589         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
13590         Remove fields.
13591         <partial_symtabs>: New field.
13592         (class objfile_psymtabs): Move from psymtab.h.  Update.
13593         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
13594         psymbol_cache.
13595         (objfile::~objfile): Don't destroy psymbol_cache.
13596         * mdebugread.c (parse_partial_symbols): Update.
13597         * dwarf2read.c (create_addrmap_from_index)
13598         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
13599         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
13600         (add_partial_subprogram, dwarf2_ranges_read): Update.
13601         * dwarf-index-write.c (write_address_map)
13602         (write_one_signatured_type, recursively_write_psymbols)
13603         (class debug_names, class debug_names, write_psymtabs_to_index):
13604         Update.
13605
13606 2019-01-10  Tom Tromey  <tom@tromey.com>
13607
13608         * symtab.h (SYMBOL_SET_NAMES): Update.
13609         (symbol_set_names): Update.
13610         (MSYMBOL_SET_NAMES): Update.
13611         * symtab.c (symbol_set_names): Change argument to be an
13612         objfile_per_bfd_storage.
13613         * psymtab.c (add_psymbol_to_bcache): Update.
13614         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
13615
13616 2019-01-10  Tom Tromey  <tom@tromey.com>
13617
13618         * symtab.c (create_demangled_names_hash): Change argument to be an
13619         objfile_per_bfd_storage.
13620         (symbol_set_names): Update.
13621
13622 2019-01-10  Tom Tromey  <tom@tromey.com>
13623
13624         * xcoffread.c (xcoff_initial_scan): Unconditionally call
13625         init_psymbol_list.
13626         * psymtab.c (init_psymbol_list): Do nothing if already called.
13627         * psympriv.h (init_psymbol_list): Add comment.
13628         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
13629         init_psymbol_list.
13630         * dbxread.c (dbx_symfile_read): Unconditionally call
13631         init_psymbol_list.
13632
13633 2019-01-10  Tom Tromey  <tom@tromey.com>
13634
13635         * xcoffread.c (scan_xcoff_symtab): Update.
13636         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
13637         "where".
13638         * mdebugread.c (parse_partial_symbols)
13639         (handle_psymbol_enumerators): Update.
13640         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
13641         * dbxread.c (read_dbx_symtab): Update.
13642         * psympriv.h (psymbol_placement): New enum.
13643         (add_psymbol_to_list): Update.
13644
13645 2019-01-10  Tom Tromey  <tom@tromey.com>
13646
13647         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
13648         static_psymbols parameters.
13649         (scan_xcoff_symtab): Update.
13650         * psymtab.c (start_psymtab_common): Remove global_psymbols and
13651         static_psymbols parameters.
13652         * psympriv.h (start_psymtab_common): Update.
13653         * mdebugread.c (parse_partial_symbols): Update.
13654         * dwarf2read.c (create_partial_symtab): Update.
13655         * dbxread.c (read_dbx_symtab): Update.
13656         (start_psymtab): Remove global_psymbols and static_psymbols
13657         parameters.
13658
13659 2019-01-10  Tom Tromey  <tom@tromey.com>
13660
13661         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
13662         * psymtab.c (allocate_psymtab): Add comment.
13663         * psympriv.h (allocate_psymtab): Add comment.
13664         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
13665         initializations.
13666         * dbxread.c (dbx_end_psymtab): Remove some initializations.
13667
13668 2019-01-10  Tom Tromey  <tom@tromey.com>
13669
13670         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
13671         Don't declare.
13672         * mipsread.c: Include mdebugread.h.
13673         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
13674         Declare.
13675         * elfread.c: Include mdebugread.h.
13676
13677 2019-01-09  Tom Tromey  <tom@tromey.com>
13678
13679         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
13680         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
13681         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
13682         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
13683         (psym_lookup_symbol, psym_find_last_source_symtab)
13684         (psym_forget_cached_source_info, psym_print_stats)
13685         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
13686         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
13687         (psym_map_matching_symbols, psym_expand_symtabs_matching)
13688         (psym_find_compunit_symtab_by_address)
13689         (maintenance_print_psymbols, maintenance_info_psymtabs)
13690         (maintenance_check_psymtabs): Use ranged for.
13691         * psymtab.h (class objfile_psymtabs): New.
13692         (require_partial_symbols): Return objfile_psymtabs.
13693         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
13694
13695 2019-01-09  Tom Tromey  <tom@tromey.com>
13696
13697         * symfile.c (overlay_invalidate_all, find_pc_overlay)
13698         (find_pc_mapped_section, list_overlays_command)
13699         (map_overlay_command, unmap_overlay_command)
13700         (simple_overlay_update): Use all_objfiles.
13701         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
13702         * printcmd.c (info_symbol_command): Use all_objfiles.
13703         * objfiles.h (ALL_OBJSECTIONS): Remove.
13704         * maint.c (maintenance_translate_address): Use all_objfiles.
13705         * gcore.c (gcore_create_callback): Use all_objfiles.
13706         (objfile_find_memory_regions): Likewise.
13707
13708 2019-01-09  Tom Tromey  <tom@tromey.com>
13709
13710         * symtab.c (find_line_symtab, info_sources_command)
13711         (make_source_files_completion_list): Use objfile_compunits.
13712         * source.c (select_source_symtab): Use objfile_compunits.
13713         * objfiles.h (struct objfile): Update comment.
13714         (ALL_OBJFILES): Remove.
13715         (ALL_FILETABS): Remove.
13716         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
13717         objfile_compunits.
13718
13719 2019-01-09  Tom Tromey  <tom@tromey.com>
13720
13721         * symmisc.c (print_objfile_statistics, dump_objfile)
13722         (maintenance_print_symbols): Use compunit_filetabs.
13723         * source.c (forget_cached_source_info_for_objfile): Use
13724         compunit_filetabs.
13725         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
13726         (ALL_FILETABS): Use compunit_filetabs.
13727         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
13728         * coffread.c (coff_symtab_read): Use compunit_filetabs.
13729
13730 2019-01-09  Tom Tromey  <tom@tromey.com>
13731
13732         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
13733         (compunit_filetabs): New.
13734         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
13735         compunit_filetabs.
13736         (info_sources_command, make_source_files_completion_list): Remove
13737         declaration.
13738         * symmisc.c (print_objfile_statistics, dump_objfile)
13739         (maintenance_print_symbols): Remove declaration.
13740         (maintenance_info_symtabs): Use compunit_filetabs.
13741         (maintenance_info_line_tables): Likewise.
13742         * source.c (select_source_symtab): Change local variable name.
13743         (forget_cached_source_info_for_objfile): Remove declaration.
13744         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
13745         * objfiles.c (objfile_relocate1): Remove declaration.
13746         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
13747         declaration.
13748         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
13749         * coffread.c (coff_symtab_read): Remove declaration.
13750         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
13751         compunit_filetabs.
13752
13753 2019-01-09  Tom Tromey  <tom@tromey.com>
13754
13755         * symtab.c (lookup_objfile_from_block)
13756         (find_pc_sect_compunit_symtab, search_symbols)
13757         (default_collect_symbol_completion_matches_break_on): Use
13758         objfile_compunits.
13759         * objfiles.h (ALL_COMPUNITS): Remove.
13760         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
13761         * cp-support.c (add_symbol_overload_list_qualified): Use
13762         objfile_compunits.
13763         * ada-lang.c (ada_collect_symbol_completion_matches)
13764         (ada_add_global_exceptions): Use objfile_compunits.
13765
13766 2019-01-09  Tom Tromey  <tom@tromey.com>
13767
13768         * source.c (select_source_symtab)
13769         (forget_cached_source_info_for_objfile): Remove declaration.
13770         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
13771         declaration.
13772         * maint.c (count_symtabs_and_blocks): Remove declaration.
13773         * cp-support.c (add_symbol_overload_list_qualified): Remove
13774         declaration.
13775         * coffread.c (coff_symtab_read): Remove declaration.
13776         * symtab.c (lookup_symbol_in_objfile_symtabs)
13777         (basic_lookup_transparent_type_1): Use objfile_compunits.
13778         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
13779         (info_sources_command, search_symbols)
13780         (default_collect_symbol_completion_matches_break_on)
13781         (make_source_files_completion_list): Remove declaration.
13782         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
13783         (ada_collect_symbol_completion_matches)
13784         (ada_add_global_exceptions): Remove declaration.
13785         * linespec.c (iterate_over_all_matching_symtabs): Use
13786         objfile_compunits.
13787         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
13788         (class objfile_compunits): New.
13789         (ALL_COMPUNITS): Use objfile_compunits.
13790         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
13791         (maintenance_check_symtabs, maintenance_info_line_tables): Use
13792         objfile_compunits.
13793         * objfiles.c (objfile_relocate1): Use objfile_compunits.
13794
13795 2019-01-09  Tom Tromey  <tom@tromey.com>
13796
13797         * symtab.c (search_symbols)
13798         (default_collect_symbol_completion_matches_break_on): Use
13799         objfile_msymbols.
13800         * ada-lang.c (ada_lookup_simple_minsym)
13801         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
13802         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
13803         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
13804         objfile_msymbols.
13805         * coffread.c (coff_symfile_read): Use objfile_msymbols.
13806         * symmisc.c (dump_msymbols): Use objfile_msymbols.
13807         * objc-lang.c (find_methods): Use objfile_msymbols.
13808         (info_selectors_command, info_classes_command): Likewise.
13809         * stabsread.c (scan_file_globals): Use objfile_msymbols.
13810         * objfiles.h (class objfile_msymbols): New.
13811         (ALL_OBJFILE_MSYMBOLS): Remove.
13812         (ALL_MSYMBOLS): Remove.
13813
13814 2019-01-09  Tom Tromey  <tom@tromey.com>
13815
13816         * common/next-iterator.h (next_adapter): Add Iterator template
13817         parameter.
13818         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
13819         (class all_objfiles_safe): New.
13820         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
13821         * objfiles.c (put_objfile_before): Update comment.
13822         (add_separate_debug_objfile): Likewise.
13823         (free_all_objfiles): Use all_objfiles_safe.
13824         (objfile_purge_solibs): Likewise.
13825
13826 2019-01-09  Tom Tromey  <tom@tromey.com>
13827
13828         * symtab.c (iterate_over_symtabs, matching_obj_sections)
13829         (expand_symtab_containing_pc, lookup_static_symbol)
13830         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
13831         (find_symbol_at_address, find_line_symtab, find_main_name): Use
13832         all_objfiles.
13833         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
13834         * breakpoint.c (create_overlay_event_breakpoint)
13835         (create_longjmp_master_breakpoint)
13836         (create_std_terminate_master_breakpoint)
13837         (create_exception_master_breakpoint): Use all_objfiles.
13838         * linux-thread-db.c (try_thread_db_load_from_pdir)
13839         (has_libpthread): Use all_objfiles.
13840         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
13841         * linespec.c (iterate_over_all_matching_symtabs)
13842         (search_minsyms_for_name): Use all_objfiles.
13843         * maint.c (maintenance_info_sections): Use all_objfiles.
13844         * main.c (captured_main_1): Use all_objfiles.
13845         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
13846         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
13847         * guile/scm-pretty-print.c
13848         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
13849         * solib-spu.c (append_ocl_sos): Use all_objfiles.
13850         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
13851         (maintenance_print_msymbols): Use all_objfiles.
13852         * source.c (select_source_symtab): Use all_objfiles.
13853         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
13854         * symfile.c (remove_symbol_file_command)
13855         (expand_symtabs_matching, map_symbol_filenames): Use
13856         all_objfiles.
13857         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
13858         all_objfiles.
13859         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
13860         * objc-lang.c (find_methods): Use all_objfiles.
13861         * objfiles.c (have_partial_symbols, have_full_symbols)
13862         (have_minimal_symbols, qsort_cmp)
13863         (default_iterate_over_objfiles_in_search_order): Use
13864         all_objfiles.
13865         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
13866         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
13867         (maintenance_check_psymtabs): Use all_objfiles.
13868         (ALL_PSYMTABS): Remove.
13869         * compile/compile-object-run.c (do_module_cleanup): Use
13870         all_objfiles.
13871         * blockframe.c (find_pc_partial_function): Use all_objfiles.
13872         * cp-support.c (add_symbol_overload_list_qualified): Use
13873         all_objfiles.
13874         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
13875         Use all_objfiles.
13876         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
13877         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
13878         all_objfiles.
13879         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
13880         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
13881         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
13882         Uses all_objfiles.
13883         * solib.c (solib_read_symbols): Use all_objfiles
13884
13885 2019-01-09  Tom Tromey  <tom@tromey.com>
13886
13887         * probe.c (parse_probes_in_pspace): Use all_objfiles.
13888         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
13889         all_objfiles.
13890         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
13891         * symmisc.c (print_symbol_bcache_statistics)
13892         (print_objfile_statistics, maintenance_print_objfiles)
13893         (maintenance_info_symtabs, maintenance_check_symtabs)
13894         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
13895         all_objfiles.
13896         * source.c (forget_cached_source_info): Use all_objfiles.
13897         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
13898         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
13899         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
13900         * objfiles.c (update_section_map): Use all_objfiles.
13901         (shared_objfile_contains_address_p): Likewise.
13902         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
13903         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
13904
13905 2019-01-09  Tom Tromey  <tom@tromey.com>
13906
13907         * common/next-iterator.h: New file.
13908         * objfiles.h (class all_objfiles): New.
13909         (struct objfile_iterator): New.
13910
13911 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
13912
13913         * NEWS: Move the description of the changed "frame", "select-frame",
13914          and "info frame" commands to the Changed commands section.
13915
13916 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
13917
13918         * gdbtypes.c (check_stub_method_group): Remove handling of old
13919         mangling schemes.
13920         * linespec.c (find_methods): Likewise.
13921         * stabsread.c (read_member_functions): Likewise.
13922         * valops.c (search_struct_method): Likewise.
13923         (value_struct_elt_for_reference): Likewise.
13924         * NEWS: Mention this change.
13925
13926 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
13927
13928         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
13929         print_source_lines.
13930         * source.c (print_source_lines_base): Update line number check.
13931         (print_source_lines): New function.
13932         (source_lines_range::source_lines_range): New function.
13933         * source.h (class source_lines_range): New class.
13934         (print_source_lines): New declaration.
13935
13936 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
13937
13938         * linespec.c (linespec_state_destructor): Free self->canonical_names.
13939
13940 2019-01-08  Tom Tromey  <tom@tromey.com>
13941             Simon Marchi  <simon.marchi@ericsson.com>
13942
13943         PR gdb/24060
13944         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
13945         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
13946         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
13947         * f-exp.y (DOLLAR_VARIABLE): Likewise.
13948         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
13949         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
13950
13951 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
13952
13953         * source.c (select_source_symtab): Move header comment to
13954         declaration in source.h.
13955         (forget_cached_source_info_for_objfile): Likewise.
13956         (forget_cached_source_info): Likewise.
13957         (identify_source_line): Likewise.
13958         * source.h (identify_source_line): Move declaration from symtab.h
13959         and add comment from source.c
13960         (print_source_lines): Likewise.
13961         (forget_cached_source_info_for_objfile): Likewise.
13962         (forget_cached_source_info): Likewise.
13963         (select_source_symtab): Likewise.
13964         (enum print_source_lines_flag): Move definition from symtab.h.
13965         * symtab.h (identify_source_line): Move declaration to source.h.
13966         (print_source_lines): Likewise.
13967         (forget_cached_source_info_for_objfile): Likewise.
13968         (forget_cached_source_info): Likewise.
13969         (select_source_symtab): Likewise.
13970         (enum print_source_lines_flag): Move definition to source.h.
13971         * tui/tui-hooks.c: Add 'source.h' include.
13972
13973 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
13974
13975         * source.c (print_source_lines_base): Handle requests to print
13976         reverse line number sequences, and guard against empty lines
13977         string.
13978
13979 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
13980
13981         * source.c (print_source_lines_base): Fix skip of '\r' if next
13982         character is '\n'.
13983
13984 2019-01-06  Tom Tromey  <tom@tromey.com>
13985
13986         * c-exp.y (struct c_parse_state) <macro_original_text,
13987         expansion_obstack>: New member.
13988         (macro_original_text, expansion_obstack): Remove globals.
13989         (scan_macro_expansion, scanning_macro_expansion)
13990         (finished_macro_expansion): Update.
13991         (scan_macro_cleanup): Remove.
13992         (yylex, c_parse): Update.
13993
13994 2019-01-06  Tom Tromey  <tom@tromey.com>
13995
13996         * c-exp.y (struct c_parse_state) <strings>: New member.
13997         (operator_stoken): Update.
13998
13999 2019-01-06  Tom Tromey  <tom@tromey.com>
14000
14001         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
14002         (union type_stack_elt) <typelist_val>: Now a pointer to
14003         std::vector.
14004         (type_stack_cleanup): Don't declare.
14005         (push_typelist): Update.
14006         * parse.c (pop_typelist): Return a std::vector.
14007         (push_typelist): Take a std::vector.
14008         (follow_types): Update.  Do not free args.
14009         (type_stack_cleanup): Remove.
14010         * c-exp.y (struct c_parse_state): New.
14011         (cpstate): New global.
14012         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
14013         (nonempty_typelist): Update.
14014         (func_mod): Create a new vector.
14015         (c_parse): Create a c_parse_state.
14016         (check_parameter_typelist): Do not delete params.
14017         (function_method): Update.  Do not delete type_list.
14018
14019 2019-01-06  Tom Tromey  <tom@tromey.com>
14020
14021         PR gdb/28155:
14022         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
14023         check_typedef.
14024         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
14025         (print_return_value): Likewise.
14026
14027 2019-01-05  Tom Tromey  <tom@tromey.com>
14028
14029         * contrib/cleanup_check.py: Remove.
14030         * contrib/gcc-with-excheck: Remove.
14031         * contrib/exsummary.py: Remove.
14032         * contrib/excheck.py: Remove.
14033
14034 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
14035
14036         * thread.c (delete_thread_1): Add gdb_assert that THR is not
14037         NULL. Initialize tpprev to NULL instead of assigning it
14038         to NULL on the next statement.
14039         * windows-nat.c (windows_delete_thread): Remove check for
14040         main_thread_id before printing thread exit notifications.
14041         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
14042         Remove thread ID check against main_thread_id.
14043         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
14044         windows_delete_thread.
14045         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
14046
14047 2019-01-04  Tom Tromey  <tom@tromey.com>
14048
14049         * compile/compile.c (_initialize_compile): Use upper case for
14050         metasyntactic variables.
14051         * symmisc.c (_initialize_symmisc): Use upper case for
14052         metasyntactic variables.
14053         * psymtab.c (_initialize_psymtab): Use upper case for
14054         metasyntactic variables.
14055         * demangle.c (demangle_command): Use upper case for metasyntactic
14056         variables.
14057         (_initialize_demangler): Likewise.
14058         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
14059         variables.
14060
14061 2019-01-03  Tom Tromey  <tom@tromey.com>
14062
14063         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
14064
14065 2019-01-03  Tom Tromey  <tom@tromey.com>
14066
14067         * python/py-symtab.c (salpy_str): Update.
14068         (struct salpy_sal_object) <symtab>: Now a PyObject.
14069         (salpy_dealloc): Update.
14070         (del_objfile_sal): Use gdbpy_ref.
14071
14072 2019-01-03  Tom Tromey  <tom@tromey.com>
14073
14074         * python/py-type.c (convert_field): Use new_reference.  Return
14075         gdbpy_ref.
14076         (make_fielditem): Return gdbpy_ref.
14077         (typy_fields): Update.
14078         (typy_getitem): Update.
14079         (field_name): Return gdbpy_ref.  Use new_reference.
14080         (typy_iterator_iternext): Update.
14081
14082 2019-01-03  Tom Tromey  <tom@tromey.com>
14083
14084         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
14085
14086 2019-01-03  Tom Tromey  <tom@tromey.com>
14087
14088         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
14089         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
14090         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
14091         (pspy_set_frame_filters, pspy_set_frame_unwinders)
14092         (pspy_set_type_printers): Likewise.
14093         * python/py-function.c (fnpy_init): Use gdbpy_ref.
14094         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
14095         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
14096         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
14097         (objfpy_set_type_printers): Likewise.
14098
14099 2019-01-03  Tom Tromey  <tom@tromey.com>
14100
14101         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
14102         (gdbpy_print_stack): Use gdbpy_err_fetch.
14103         * python/python-internal.h (class gdbpy_err_fetch): New class.
14104         (class gdbpy_enter) <m_error_type, m_error_value,
14105         m_error_traceback>: Remove.
14106         <m_error>: New member.
14107         (gdbpy_exception_to_string): Don't declare.
14108         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
14109         * python/py-value.c (convert_value_from_python): Use
14110         gdbpy_err_fetch.
14111         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
14112         gdbpy_exception_to_string.
14113         (gdbpy_handle_exception): Use gdbpy_err_fetch.
14114         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
14115         gdbpy_err_fetch.
14116
14117 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
14118
14119         * linux-nat.c (delete_lwp_cleanup): Delete.
14120         (struct lwp_deleter): New struct.
14121         (lwp_info_up): New typedef.
14122         (linux_nat_target::follow_fork): Delete cleanup, and make use of
14123         lwp_info_up.
14124
14125 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
14126
14127         * linux-fork.c (class scoped_switch_fork_info): New class.
14128         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
14129
14130 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
14131
14132         * valops.c (find_overload_match): Remove use of null_cleanup, and
14133         calls to do_cleanups.
14134
14135 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
14136
14137         * compile/compile-cplus-types.c
14138         (compile_cplus_instance::decl_name): Handle changes to
14139         cp_func_name.
14140         * cp-support.c (cp_func_name): Update header comment, update
14141         return type.
14142         * cp-support.h (cp_func_name): Update return type in declaration.
14143         * valops.c (find_overload_match): Move temp_func local to top
14144         level of function and change its type.  Use temp_func to hold and
14145         delete temporary string obtained from cp_func_name.
14146
14147 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
14148
14149         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
14150         gdb::char_vector, remove cleanup, and update uses of `msg`.
14151
14152 2019-01-03  Jim Wilson  <jimw@sifive.com>
14153
14154         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
14155
14156 2019-01-02  Tom Tromey  <tom@tromey.com>
14157
14158         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
14159         (tdesc_parse_xml): Remove cleanups.
14160         * target-descriptions.h (make_cleanup_free_target_description):
14161         Don't declare.
14162         (target_desc_deleter): New struct.
14163         (target_desc_up): New typedef.
14164         * target-descriptions.c (target_desc_deleter::operator()): Rename
14165         from free_target_description.
14166         (make_cleanup_free_target_description): Remove.
14167
14168 2019-01-02  Tom Tromey  <tom@tromey.com>
14169
14170         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
14171         constructor, destructor.
14172         (linespec_parser): Remove typedef.
14173         (~linespec_parser): Rename from linespec_parser_delete.
14174         (linespec_lex_to_end, linespec_complete_label)
14175         (linespec_complete): Update.
14176         (decode_line_full): Remove cleanups.
14177         (decode_line_1): Update.
14178
14179 2019-01-02  Tom Tromey  <tom@tromey.com>
14180
14181         * python/python-internal.h (inferior_to_inferior_object): Change
14182         return type.
14183         * python/py-exitedevent.c (create_exited_event_object): Update.
14184         * python/py-inferior.c (inferior_to_inferior_object): Return
14185         gdbpy_ref.
14186         (python_new_inferior, python_inferior_deleted)
14187         (thread_to_thread_object, delete_thread_object)
14188         (build_inferior_list, gdbpy_selected_inferior): Update.
14189         * python/py-infthread.c (create_thread_object): Update.  Also fail
14190         if inferior_to_inferior_object fails.
14191
14192 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
14193
14194         * inferior.h (class inferior) <displaced_step_state>: New field.
14195         * infrun.h (struct displaced_step_state): Move here from
14196         infrun.c.  Initialize fields, add constructor.
14197         <inf>: Remove field.
14198         <reset>: New method.
14199         * infrun.c (struct displaced_step_inferior_state): Move to
14200         infrun.h.
14201         (displaced_step_inferior_states): Remove.
14202         (get_displaced_stepping_state): Adust.
14203         (displaced_step_in_progress_any_inferior): Adjust.
14204         (displaced_step_in_progress_thread): Adjust.
14205         (displaced_step_in_progress): Adjust.
14206         (add_displaced_stepping_state): Remove.
14207         (get_displaced_step_closure_by_addr): Adjust.
14208         (remove_displaced_stepping_state): Remove.
14209         (infrun_inferior_exit): Call displaced_step_state.reset.
14210         (use_displaced_stepping): Don't check for NULL.
14211         (displaced_step_prepare_throw): Call
14212         get_displaced_stepping_state.
14213         (displaced_step_fixup): Don't check for NULL.
14214         (prepare_for_detach): Don't check for NULL.
14215
14216 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
14217
14218         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
14219          in case of call that did not complete.
14220
14221 2019-01-02  Andrey Utkin  <autkin@undo.io>
14222
14223         * symfile.c (find_separate_debug_file): Fix search of debug files for
14224         remote debuggee.
14225
14226 2019-01-02  Tom Tromey  <tom@tromey.com>
14227
14228         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
14229         indentation.
14230         * python/py-frame.c (frapy_older): Remove cast.
14231         (frapy_newer): Likewise.
14232         * python/py-breakpoint.c (local_setattro): Remove cast.
14233         * python/py-arch.c (archpy_name): Remove local variable.
14234         * python/py-type.c (gdbpy_lookup_type): Remove cast.
14235
14236 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
14237
14238         * unittests/basic_string_view/element_access/char/empty.cc:
14239         Fix year range in copyright header.
14240
14241 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
14242
14243         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
14244         Delete.
14245         <operator==>: Update with for removed field.
14246         <hash>: Likewise.
14247         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
14248         <isa_features>: ...this.
14249         <abi_features>: New field.
14250         (riscv_isa_flen): Update comment.
14251         (riscv_abi_xlen): New declaration.
14252         (riscv_abi_flen): New declaration.
14253         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
14254         isa_features.
14255         (riscv_abi_xlen): New function.
14256         (riscv_isa_flen): Update to get answer from isa_features.
14257         (riscv_abi_flen): New function.
14258         (riscv_has_fp_abi): Update to get answer from abi_features.
14259         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
14260         xlen and flen.
14261         (riscv_call_info) <xlen, flen>: Update comment.
14262         (riscv_call_arg_struct): Remove invalid assertions
14263         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
14264         is removed.
14265         (riscv_gdbarch_init): Gather isa features and abi features
14266         separately, ensure both match on the gdbarch when reusing an old
14267         gdbarch.  Relax an error check to allow 32-bit abi float to run on
14268         a target with 64-bit float hardware.
14269
14270 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
14271
14272         * source.c (search_command_helper): Stop reverse search
14273         when line 1 has been searched.
14274
14275 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
14276
14277         * record-full.c (record_full_base_target::close): Rewrite
14278         record_full_core_buf_list free logic.
14279
14280 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
14281
14282         * break-catch-syscall.c (print_one_catch_syscall): xfree
14283         the last text.
14284
14285 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
14286
14287         * top.c (print_gdb_version): Update Copyright year in version
14288         message.
14289
14290 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
14291
14292         Update copyright year range in all GDB files.
14293
14294 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
14295
14296         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
14297
14298 For older changes see ChangeLog-2018.
14299 \f
14300 Local Variables:
14301 mode: change-log
14302 left-margin: 8
14303 fill-column: 74
14304 version-control: never
14305 coding: utf-8
14306 End:
14307