gdb/ChangeLog

   1 2019-12-12  Tom Tromey  <tom@tromey.com>
   2
   3         * symfile.c (syms_from_objfile_1): Use objfile_up.
   4         (syms_from_objfile_1, remove_symbol_file_command): Call unlink
   5         method.
   6         (reread_symbols): Use objfile_up.
   7         * solib.c (update_solib_list, reload_shared_libraries_1): Call
   8         unlink method.
   9         * objfiles.h (struct objfile) <~objfile>: Now private.
  10         <unlink>: New method.
  11         (struct objfile_deleter): New.
  12         (objfile_up): New typedef.
  13         * objfiles.c (objfile::unlink): New method.
  14         (free_objfile_separate_debug, free_all_objfiles)
  15         (objfile_purge_solibs): Use it.
  16         * jit.c (jit_unregister_code): Remove.
  17         (jit_inferior_exit_hook, jit_event_handler): Call unlink on
  18         objfile.
  19         * compile/compile-object-run.c (do_module_cleanup): Call unlink on
  20         objfile.
  21         * compile/compile-object-load.c (compile_object_load): Use
  22         objfile_up.
  23
  24 2019-12-12  Tom Tromey  <tom@tromey.com>
  25
  26         * symfile.c (symbol_file_add_with_addrs): Pass "parent" to
  27         objfile::make.
  28         * objfiles.h (struct objjfile) <make>: No longer inline.
  29         (add_separate_debug_objfile): Don't declare.
  30         * objfiles.c (add_separate_debug_objfile): Now static.
  31         (objfile::make): Move from objfiles.h.  Call
  32         add_separate_debug_objfile.  Add "parent" parameter.
  33
  34 2019-12-12  Tom Tromey  <tom@tromey.com>
  35
  36         * symfile.c (symbol_file_add_with_addrs): Use objfile::make.
  37         * objfiles.h (struct objfile): Make constructor private.
  38         <make>: New static method.
  39         * jit.c (jit_object_close_impl): Update.
  40
  41 2019-12-12  Simon Marchi  <simon.marchi@polymtl.ca>
  42
  43         * jit.c (jit_reader_try_read_symtab): Replace xmalloc/xfree with
  44         gdb::byte_vector.
  45
  46 2019-12-12  Tom Tromey  <tromey@adacore.com>
  47
  48         * xml-support.c (xml_fetch_content_from_file): Don't call
  49         malloc_failure.
  50         * utils.h (class gdb_argv): Remove malloc_failure comment.
  51         * utils.c (gdb_argv::reset): Don't call malloc_failure.
  52
  53 2019-12-12  Tom Tromey  <tromey@adacore.com>
  54
  55         * Makefile.in (ALL_TARGET_OBS): Add riscv-ravenscar-thread.o.
  56         (HFILES_NO_SRCDIR): Add riscv-ravenscar-thread.h.
  57         (ALLDEPFILES): Add riscv-ravenscar-thread.c.
  58         * configure.tgt (riscv-*-*): Add riscv-ravenscar-thread.o.
  59         * riscv-ravenscar-thread.c: New file.
  60         * riscv-ravenscar-thread.h: New file.
  61         * riscv-tdep.c (riscv_gdbarch_init): Call
  62         register_riscv_ravenscar_ops.
  63
  64 2019-12-12  Tom Tromey  <tromey@adacore.com>
  65
  66         * gdbsupport/thread-pool.c (set_thread_name): Use
  67         ATTRIBUTE_UNUSED.
  68
  69 2019-12-12  Luis Machado  <luis.machado@linaro.org>
  70
  71         * gdbsupport/safe-strerror.c: Don't include diagnostics.h.
  72         (select_strerror_r): Use ATTRIBUTE_UNUSED instead of the diagnostics
  73         macros.
  74
  75 2019-12-11  Tom Tromey  <tom@tromey.com>
  76
  77         * tui/tui-win.c (tui_set_win_height_command): Call
  78         tui_adjust_window_height.
  79         (tui_adjust_win_heights, new_height_ok): Remove.
  80         * tui/tui-layout.h (tui_adjust_window_height): Declare.
  81         * tui/tui-layout.c (tui_adjust_window_height): New function.
  82
  83 2019-12-11  Tom Tromey  <tom@tromey.com>
  84
  85         * tui/tui-win.c (tui_resize_all): Remove code, call
  86         tui_apply_current_layout.
  87
  88 2019-12-11  Tom Tromey  <tom@tromey.com>
  89
  90         * tui/tui-layout.h (tui_apply_current_layout): Declare.
  91         * tui/tui-layout.c (standard_layouts, applied_layout): New
  92         globals.
  93         (tui_apply_current_layout): New function.
  94         (show_layout): Set applied_layout.  Call
  95         tui_apply_current_layout.
  96         (show_source_command, show_disasm_command)
  97         (show_source_disasm_command, show_data)
  98         (show_source_or_disasm_and_command): Remove.
  99         (initialize_layouts): New function.
 100         (_initialize_tui_layout): Call initialize_layouts.
 101
 102 2019-12-11  Tom Tromey  <tom@tromey.com>
 103
 104         * tui/tui-layout.h (class tui_layout_base)
 105         (class tui_layout_window, class tui_layout_split): New.
 106         * tui/tui-layout.c (tui_get_window_by_name)
 107         (tui_layout_window::clone, tui_layout_window::apply)
 108         (tui_layout_window::get_sizes, tui_layout_window::add_split)
 109         (tui_layout_split::add_window, tui_layout_split::clone)
 110         (tui_layout_split::get_sizes)
 111         (tui_layout_split::set_weights_from_heights)
 112         (tui_layout_split::adjust_size, tui_layout_split::apply): New
 113         functions.
 114         (tui_layout_split::add_split, tui_layout_split::add_split)
 115         (tui_layout_split::set_weights_from_heights)
 116         (tui_layout_split::set_weights_from_heights): New functions.
 117
 118 2019-12-11  Tom Tromey  <tom@tromey.com>
 119
 120         * tui/tui-wingeneral.c (tui_gen_win_info::make_window): Update.
 121         * tui/tui-win.c (tui_adjust_win_heights, tui_resize_all): Update.
 122         * tui/tui-layout.c (tui_gen_win_info::resize): Update.
 123         * tui/tui-data.h (struct tui_point): Remove.
 124         (struct tui_gen_win_info) <origin>: Remove.
 125         <x, y>: New fields.
 126         * tui/tui-command.c (tui_cmd_window::resize): Update.
 127
 128 2019-12-11  Tom Tromey  <tom@tromey.com>
 129
 130         * tui/tui-stack.h (struct tui_locator_window) <min_height>:
 131         Implement.
 132         * tui/tui-regs.h (struct tui_data_item_window) <min_height>:
 133         Implement.
 134         * tui/tui-data.h (struct tui_gen_win_info) <min_height>: New
 135         method.
 136         (struct tui_win_info) <min_height>: Implement.
 137
 138 2019-12-11  Tom Tromey  <tom@tromey.com>
 139
 140         * tui/tui-data.h (struct tui_gen_win_info) <can_box>: New method.
 141         (struct tui_win_info) <can_box>: Update.
 142
 143 2019-12-11  Tom Tromey  <tom@tromey.com>
 144
 145         * tui/tui-stack.h (struct tui_locator_window) <max_height>: New
 146         method.
 147         * tui/tui-regs.h (struct tui_data_item_window) <max_height>: New
 148         method.
 149         * tui/tui-data.h (struct tui_gen_win_info) <max_height>: New
 150         method.
 151         (struct tui_win_info) <max_height>: Now override.
 152
 153 2019-12-11  Joel Brobecker  <brobecker@adacore.com>
 154
 155         * NEWS: Create a new section for the next release branch.
 156         Rename the section of the current branch, now that it has
 157         been cut.
 158
 159 2019-12-11  Joel Brobecker  <brobecker@adacore.com>
 160
 161         GDB 9 branch created (27f7b2f64062ac9e52afc60509263c2702a9ebd0):
 162         * version.in: Bump version to 10.0.50.DATE-git.
 163
 164 2019-12-11  Tom Tromey  <tromey@adacore.com>
 165
 166         PR build/25268:
 167         * gdbsupport/thread-pool.c (set_thread_name): New function.
 168         (thread_pool::set_thread_count): Don't call pthread_setname_np.
 169         (thread_pool::thread_function): Call set_thread_name.
 170
 171 2019-12-11  Tom Tromey  <tromey@adacore.com>
 172
 173         * fbsd-tdep.c (fbsd_core_info_proc_status): Cast result of
 174         bfd_get_signed_8.
 175
 176 2019-12-11  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 177
 178         * NEWS: Document -raw-values option and the related setting commands.
 179         * printcmd.c (print_command_parse_format): Do not set opts->raw off,
 180         only set it on when /r is given.
 181         * valprint.c (value_print_option_defs): New element raw-values.
 182         * Makefile.in: Add the new file.
 183
 184 2019-12-10  Christian Biesinger  <cbiesinger@google.com>
 185
 186         * gdbsupport/safe-strerror.c: Supress the unused function warning
 187         for select_strerror_r.
 188
 189 2019-12-10  Christian Biesinger  <cbiesinger@google.com>
 190
 191         * config.in: Regenerate.
 192         * configure: Regenerate.
 193         * gdbsupport/agent.c (gdb_connect_sync_socket): Call
 194         safe_strerror instead of strerror.
 195         * gdbsupport/common.m4: Don't check for strerror.
 196         * gdbsupport/safe-strerror.c: Support both the glibc version
 197         of strerror_r and the XSI version.
 198
 199 2019-12-10  Tom Tromey  <tromey@adacore.com>
 200
 201         * ada-typeprint.c (print_choices): Use a single "?".
 202         (print_variant_part): Print "?" if the discriminant name
 203         is not known.
 204
 205 2019-12-10  George Barrett  <bob@bob131.so>
 206
 207         Fix scripted probe breakpoints.
 208         * breakpoint.c (tracepoint_probe_breakpoint_ops): Move
 209         declaration forward.
 210         (breakpoint_ops_for_event_location_type)
 211         (breakpoint_ops_for_event_location): Add function definitions.
 212         (break_command_1, trace_command): Use
 213         breakpoint_ops_for_event_location.
 214         * breakpoint.h (breakpoint_ops_for_event_location): Add function
 215         declarations.
 216         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Use
 217         breakpoint_ops_for_event_location.
 218         * python/py-breakpoint.c (bppy_init): Use
 219         breakpoint_ops_for_event_location.
 220
 221 2019-12-09  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
 222
 223         * gdbtypes.c (rank_one_type): Return INCOMPATIBLE_TYPE_BADNESS
 224         when ranking an lvalue argument for an rvalue parameter.
 225
 226 2019-12-08  Wataru Ashihara  <wataash@wataash.com>
 227
 228         * darwin-nat.c (darwin_nat_target::create_inferior): Fix
 229         template argument for scoped_restore_tmpl from bool to int.
 230
 231 2019-12-07  Keith Seitz  <keiths@redhat.com>
 232
 233         * build-id.c (build_id_bfd_get): Permit bfd_core, too.
 234         (build_id_to_debug_bfd): Make static, rewriting to use
 235         build_id_to_bfd_suffix.
 236         (build_id_to_bfd_suffix): Copy of build_id_to_debug_bfd,
 237         adding `suffix' parameter. Append SUFFIX to file names
 238         when searching for matching files.
 239         (build_id_to_debug_bfd): Use build_id_to_bfd_suffix.
 240         (build_id_to_exec_bfd): Likewise.
 241         * build-id.h (build_id_to_debug_bfd): Clarify that function
 242         searches for BFD of debug info file.
 243         (build_id_to_exec_bfd): Declare.
 244         * corelow.c: Include build-id.h.
 245         (locate_exec_from_corefile_build_id): New function.
 246         (core_target_open): If no executable BFD is found,
 247         search for a core file BFD using build-id.
 248
 249 2019-12-06  Christian Biesinger  <cbiesinger@google.com>
 250
 251         * bcache.c: Put in namespace gdb.
 252         * bcache.h: Likewise.
 253         * gdbtypes.c (check_types_worklist): Update.
 254         (types_deeply_equal): Update.
 255         * macrotab.c (struct macro_table) <bcache>: Update.
 256         (new_macro_table): Update.
 257         * macrotab.h (struct bcache): Put this forward declaration
 258         inside namespace gdb.
 259         (new_macro_table): Update.
 260         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache>:
 261         Update.
 262         <macro_cache>: Update.
 263         * psymtab.h: (psymtab_storage) <psymbol_cache>: Update.
 264
 265 2019-12-06  Tom de Vries  <tdevries@suse.de>
 266
 267         PR symtab/24971
 268         * block.c (best_symbol, better_symbol): New function.
 269         (block_lookup_symbol_primary, block_lookup_symbol): Prefer def over
 270         decl.
 271
 272 2019-12-06  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
 273
 274         * gdbtypes.h: Define the REFERENCE_SEE_THROUGH_BADNESS value.
 275         * gdbtypes.c (rank_one_type): Use REFERENCE_SEE_THROUGH_BADNESS
 276         for ranking see-through reference cases.
 277
 278 2019-12-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 279         * stack.c (faas_command): Check a command is provided.
 280         * thread.c (taas_command, tfaas_command): Likewise.
 281
 282 2019-12-05  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 283         * inferior.c (prune_inferiors):  Only call delete_inferior,
 284         Do not modify the inferior list.
 285
 286 2019-12-05  Simon Marchi  <simon.marchi@polymtl.ca>
 287
 288         * c-exp.y: Update calls to lookup_typename,
 289         lookup_signed_typename and lookup_unsigned_typename.
 290         * c-lang.c (evaluate_subexp_c): Likewise.
 291         * cp-namespace.c (cp_lookup_symbol_imports_or_template):
 292         Likewise.
 293         * eval.c (binop_promote): Likewise.
 294         * gdbtypes.c (lookup_typename): Remove gdbarch parameter.
 295         (lookup_unsigned_typename): Likewise.
 296         (lookup_signed_typename): Likewise.
 297         * gdbtypes.h (lookup_unsigned_typename): Likewise.
 298         (lookup_signed_typename): Likewise.
 299         (lookup_typename): Likewise.
 300         * guile/scm-type.c (tyscm_lookup_typename): Update calls to
 301         lookup_typename, lookup_signed_typename,
 302         lookup_unsigned_typename.
 303         * m2-exp.y: Likewise.
 304         * printcmd.c (printf_wide_c_string): Likewise.
 305         (ui_printf): Likewise.
 306         * python/py-type.c (typy_lookup_typename): Likewise.
 307         * python/py-xmethods.c (python_xmethod_worker::invoke):
 308         Likewise.
 309         * rust-exp.y: Likewise.
 310
 311 2019-12-04  Christian Biesinger  <cbiesinger@google.com>
 312
 313         * configure.nat (obsd64): Add missing files x86-nat.o and
 314         nat/x86-dregs.o.
 315
 316 2019-12-04  Tom Tromey  <tom@tromey.com>
 317
 318         * valprint.c (val_print_string): Use metadata_style.
 319         * go-valprint.c (print_go_string): Use metadata style.
 320         * p-valprint.c (pascal_object_print_static_field): Use metadata
 321         style.
 322         * cp-valprint.c (cp_print_static_field): Use metadata style.
 323
 324 2019-12-04  Andrew Burgess  <andrew.burgess@embecosm.com>
 325             Chris January  <chris.january@arm.com>
 326
 327         * f-exp.y (COMPLEX_KEYWORD, SINGLE, DOUBLE, PRECISION): New
 328         tokens.
 329         (typebase): New patterns for complex, single/double precision, and
 330         single/double complex.
 331         (f77_keywords): Change token for complex keyword, and add single,
 332         double, and precision keywords.
 333
 334 2019-12-04  Simon Marchi  <simon.marchi@polymtl.ca>
 335
 336         * avr-tdep.c (_initialize_avr_tdep): Improve help of command
 337         "info io_registers".
 338
 339 2019-12-04  Simon Marchi  <simon.marchi@polymtl.ca>
 340
 341         * regcache.c (cooked_read_test): Initialize thread list of
 342         mock_inferior.
 343
 344 2019-12-04  Simon Marchi  <simon.marchi@polymtl.ca>
 345
 346         * aarch64-linux-tdep.c: Remove includes.
 347
 348 2019-12-04  Simon Marchi  <simon.marchi@polymtl.ca>
 349
 350         * aarch64-tdep.c: Remove includes.
 351
 352 2019-12-04  Simon Marchi  <simon.marchi@efficios.com>
 353
 354         * filtered-iterator.h (filtered_iterator) <operator==,
 355         operator!=>: Compare wrapped iterators, not wrapped pointers.
 356         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
 357         unittests/filtered_iterator-selftests.c.
 358         * unittests/filtered_iterator-selftests.c: New file.
 359
 360 2019-12-04  Tom Tromey  <tromey@adacore.com>
 361
 362         * gdbtypes.c (create_range_type): Inherit endianity
 363         from base type.
 364
 365 2019-12-04  Tom Tromey  <tromey@adacore.com>
 366
 367         * ada-lang.c (decode_constrained_packed_array)
 368         (ada_value_assign, value_assign_to_component): Update.
 369         * dwarf2loc.c (rw_pieced_value, access_memory)
 370         (dwarf2_compile_expr_to_ax): Update.
 371         * dwarf2read.c (dwarf2_add_field): Update.
 372         * eval.c (evaluate_subexp_standard): Update.
 373         * gdbarch.c, gdbarch.h: Rebuild.
 374         * gdbarch.sh (bits_big_endian): Remove.
 375         * gdbtypes.h (union field_location): Update comment.
 376         * target-descriptions.c (make_gdb_type): Update.
 377         * valarith.c (value_bit_index): Update.
 378         * value.c (struct value) <bitpos>: Update comment.
 379         (unpack_bits_as_long, modify_field): Update.
 380         * value.h (value_bitpos): Update comment.
 381
 382 2019-12-04  Tom Tromey  <tromey@adacore.com>
 383
 384         * gdbtypes.c (type_byte_order): Move earlier.  Assert for unknown
 385         endian-ness.
 386
 387 2019-12-04  Tom Tromey  <tromey@adacore.com>
 388
 389         * dwarf2read.c (dwarf2_init_float_type)
 390         (dwarf2_init_complex_target_type): Add byte_order parameter.
 391         (read_base_type): Compute byte order earlier.
 392         * gdbtypes.c (init_float_type): Add byte_order parameter.
 393         * gdbtypes.h (init_float_type): Add byte_order parameter.
 394
 395 2019-12-04  Tom Tromey  <tromey@adacore.com>
 396
 397         * unittests/tui-selftests.c: Conditionally include tui-winsource.h.
 398
 399 2019-12-04  Tom Tromey  <tromey@adacore.com>
 400
 401         * dwarf2read.c (process_structure_scope): Initialize
 402         "discr_offset".
 403
 404 2019-12-04  Andrew Burgess  <andrew.burgess@embecosm.com>
 405
 406         * mi/mi-symbol-cmds.c (mi_symbol_info): Take extra parameter, and
 407         add it into the search spec.
 408         (parse_max_results_option): New function.
 409         (mi_info_functions_or_variables): Parse -max-results flag and pass
 410         it to mi_symbol_info.
 411         (mi_cmd_symbol_info_modules): Likewise.
 412         (mi_cmd_symbol_info_types): Likewise.
 413         * symtab.c (global_symbol_searcher::add_matching_symbols): Change
 414         return type to bool, change result container into a set, and don't
 415         add new results if we have enough already.
 416         (global_symbol_searcher::add_matching_msymbols): Change return
 417         type to bool, and don't add new results if we have enough already.
 418         (sort_search_symbols_remove_dups): Delete.
 419         (global_symbol_searcher::search): Early exit from search loop when
 420         we have enough results.  Use a std::set to collect the results
 421         from calling add_matching_symbols.
 422         * symtab.h (global_symbol_searcher) <set_max_seach_results>: New
 423         member function.
 424         (global_symbol_searcher) <m_max_search_results>: New member
 425         variable.
 426         (global_symbol_searcher) <add_matching_symbols>: Update header
 427         comment and change return type to bool.
 428         (global_symbol_searcher) <add_matching_msymbols>: Update header
 429         comment and change return type to bool.
 430
 431 2019-12-04  Andrew Burgess  <andrew.burgess@embecosm.com>
 432
 433         * symtab.c (symbol_search::compare_search_syms): Update header
 434         comment.
 435         (global_symbol_searcher::is_suitable_msymbol): New function.
 436         (global_symbol_searcher::expand_symtabs): New function.
 437         (global_symbol_searcher::add_matching_symbols): New function.
 438         (global_symbol_searcher::add_matching_msymbols): New function.
 439         (global_symbol_searcher::search): Move most of the content
 440         into the new functions above, and call them as needed.
 441         * symtab.h (global_symbol_searcher) <expand_symtabs>: New member
 442         function.
 443         (global_symbol_searcher) <add_matching_symbols>: New member
 444         function.
 445         (global_symbol_searcher) <add_matching_msymbols>: New member
 446         function.
 447         (global_symbol_searcher) <is_suitable_msymbol>: New member
 448         function.
 449
 450 2019-12-04  Andrew Burgess  <andrew.burgess@embecosm.com>
 451
 452         * mi/mi-cmds.c (mi_cmds): Add -symbol-info-module-functions and
 453         -symbol-info-module-variables entries.
 454         * mi/mi-cmds.h (mi_cmd_symbol_info_module_functions): Declare.
 455         (mi_cmd_symbol_info_module_variables): Declare.
 456         * mi/mi-symbol-cmds.c
 457         (module_symbol_search_iterator): New typedef.
 458         (output_module_symbols_in_single_module_and_file): New function.
 459         (output_module_symbols_in_single_module): New function.
 460         (mi_info_module_functions_or_variables): New function.
 461         (mi_cmd_symbol_info_module_functions): New function.
 462         (mi_cmd_symbol_info_module_variables): New function.
 463         * NEWS: Mention new MI command.
 464
 465 2019-12-03  Christian Biesinger  <cbiesinger@google.com>
 466
 467         * bcache.c (hash): Remove.
 468         (hash_continue): Remove.
 469         * bcache.h (hash): Remove.
 470         (hash_continue): Remove.
 471         (struct bcache) <ctor>: Update.
 472         * psymtab.c (psymbol_hash): Update.
 473         * stabsread.c (hashname): Update.
 474         * utils.h (fast_hash): Add an argument for a start value,
 475         defaulting to zero.
 476
 477 2019-12-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 478         * symtab.c (symbol_cache_clear_slot):  Move close to cleared type.
 479         (destroy_block_symbol_cache): New function.
 480         (symbol_cache:~symbol_cache) Call destroy_block_symbol_cache.
 481         (resize_symbol_cache): Likewise.
 482
 483 2019-12-02  Tom Tromey  <tom@tromey.com>
 484
 485         * unittests/tui-selftests.c (run_tests): Make conditional.
 486         (_initialize_tui_selftest): Make conditional.
 487
 488 2019-12-02  Christian Biesinger  <cbiesinger@google.com>
 489
 490         * aix-thread.c (debug_aix_thread): Change type to bool.
 491
 492 2019-12-02  Luis Machado  <luis.machado@linaro.org>
 493
 494         * infrun.c (follow_fork_inferior): Remove outdated FIXME comment.
 495
 496 2019-12-01  Andrew Burgess  <andrew.burgess@embecosm.com>
 497
 498         * dwarf2read.c (read_tag_string_type): Read the fields required to
 499         make a dynamic string, and possibly create a dynamic range for the
 500         string.
 501         (attr_to_dynamic_prop): Setup is_reference based on the type of
 502         attribute being processed.
 503         * gdbtypes.c (is_dynamic_type_internal): Handle TYPE_CODE_STRING.
 504         (resolve_dynamic_array): Rename to...
 505         (resolve_dynamic_array_or_string): ...this, update header comment,
 506         and accept TYPE_CODE_STRING.
 507         (resolve_dynamic_type_internal): Handle TYPE_CODE_STRING.
 508
 509 2019-12-01  Andrew Burgess  <andrew.burgess@embecosm.com>
 510
 511         * dwarf2read.c (dwarf2_per_cu_int_type): New function, takes most
 512         of its implementation from...
 513         (dwarf2_per_cu_addr_sized_int_type): ...here, which now just calls
 514         the new function.
 515
 516 2019-12-01  Andrew Burgess  <andrew.burgess@embecosm.com>
 517
 518         * dwarf2read.c (read_subrange_type): Read bit and byte stride and
 519         create a range with stride where appropriate.
 520         * f-valprint.c: Include 'gdbarch.h'.
 521         (f77_print_array_1): Take the stride into account when walking the
 522         array.  Also convert the stride into addressable units.
 523         * gdbtypes.c (create_range_type): Initialise the stride to
 524         constant zero.
 525         (create_range_type_with_stride): New function, initialise the
 526         range as normal, and then setup the stride.
 527         (has_static_range): Include the stride here.  Also change the
 528         return type to bool.
 529         (create_array_type_with_stride): Consider the range stride if the
 530         array isn't given its own stride.
 531         (resolve_dynamic_range): Resolve the stride if needed.
 532         * gdbtypes.h (struct range_bounds) <stride>: New member variable.
 533         (struct range_bounds) <flag_is_byte_stride>: New member variable.
 534         (TYPE_BIT_STRIDE): Define.
 535         (TYPE_ARRAY_BIT_STRIDE): Define.
 536         (create_range_type_with_stride): Declare.
 537         * valarith.c (value_subscripted_rvalue): Take range stride into
 538         account when walking the array.
 539
 540 2019-12-01  Tom Tromey  <tom@tromey.com>
 541
 542         * tui/tui-win.c (tui_all_windows_info): Treat inactive TUI
 543         specially.
 544
 545 2019-12-01  Tom Tromey  <tom@tromey.com>
 546
 547         * tui/tui-winsource.c (tui_copy_source_line): Don't advance past
 548         \0.
 549         * unittests/tui-selftests.c: New file.
 550         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add tui-selftests.c.
 551
 552 2019-12-01  Tom Tromey  <tom@tromey.com>
 553
 554         * tui/tui.c (tui_enable): Call tui_update_variables earlier.
 555
 556 2019-12-01  Tom Tromey  <tom@tromey.com>
 557
 558         * NEWS: Document new settings.
 559         * tui/tui-wingeneral.c (box_win): Apply appropriate border style.
 560         * tui/tui-win.c (_initialize_tui_win): Add border style
 561         observers.
 562         * tui/tui-io.h (tui_apply_style): Declare.
 563         * tui/tui-io.c (tui_apply_style): Rename from apply_style.  No
 564         longer static.
 565         (apply_ansi_escape, tui_set_reverse_mode): Update.
 566         * cli/cli-style.h (class cli_style_option) <add_setshow_commands>:
 567         Add "skip_intensity" parameter.
 568         <changed>: New member.
 569         <do_set_value>: Declare.
 570         (tui_border_style, tui_active_border_style): Declare.
 571         * cli/cli-style.c (tui_border_style, tui_active_border_style): New
 572         globals.
 573         (cli_style_option): Initialize "changed".
 574         (cli_style_option::do_set_value): New function.
 575         (cli_style_option::add_setshow_commands): Add "skip_intensity"
 576         parameter.  Update.
 577         (STYLE_ADD_SETSHOW_COMMANDS): Add "SKIP" parameter.
 578         (_initialize_cli_style): Update.  Create TUI border style
 579         commands.
 580
 581 2019-12-01  Tom Tromey  <tom@tromey.com>
 582
 583         * tui/tui-winsource.h (tui_copy_source_line): Add "ndigits"
 584         parameter.
 585         * tui/tui-winsource.c (tui_copy_source_line): Add "ndigits"
 586         parameter.
 587         * tui/tui-win.h (compact_source): Declare.
 588         * tui/tui-win.c (compact_source): New global.
 589         (tui_set_compact_source, tui_show_compact_source): New functions.
 590         (_initialize_tui_win): Add "compact-source" setting.
 591         * tui/tui-source.c (tui_source_window::set_contents): Handle
 592         compact_source setting.
 593         * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
 594         * NEWS: Document new setting.
 595
 596 2019-11-30  Tom Tromey  <tom@tromey.com>
 597
 598         * dwarf2read.c (dwarf2_add_field): Include field offset when
 599         computing variant part length.
 600
 601 2019-11-30  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 602         * NEWS:  Mention define-prefix.  Tell that command names can now
 603         contain a . character.
 604
 605 2019-11-30  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 606
 607         * command.h (valid_cmd_char_p): Declare.
 608         * cli/cli-decode.c (valid_cmd_char_p): New function factorizing
 609         the check of valid command char.
 610         (find_command_name_length, valid_user_defined_cmd_name_p): Use
 611         valid_cmd_char_p.
 612         * cli/cli-script.c (validate_comname): Likewise.
 613         * completer.c (gdb_completer_command_word_break_characters):
 614         Do not remove . from the word break char, update comments.
 615         (complete_line_internal_1): Use valid_cmd_char_p.
 616         * guile/scm-cmd.c (gdbscm_parse_command_name): Likewise.
 617         * python/py-cmd.c (gdbpy_parse_command_name): Likewise.
 618
 619 2019-11-30  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 620
 621         * cli/cli-script.c (do_define_command): Ensure a redefined
 622         prefix command is kept as a prefix command.
 623         (define_prefix_command): New function.
 624         (show_user_1): Report user defined prefixes.
 625         (_initialize_cli_script):  Create the new 'define-prefix' command.
 626         Add completers for 'define' and 'document'.
 627         * top.c (execute_command):  If command is a user-defined prefix only
 628         command, report the list of commands for this prefix command.
 629
 630 2019-11-29  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
 631
 632         * valops.c (find_oload_champ): Improve debug output.
 633
 634 2019-11-29  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
 635
 636         * valops.c (find_oload_champ): Print part of debug messages
 637         before the badness vector is std::move'd.
 638
 639 2019-11-28  Tom Tromey  <tom@tromey.com>
 640
 641         * value.c (creal_internal_fn): Fix comment.
 642
 643 2019-11-28  Tom Tromey  <tom@tromey.com>
 644
 645         * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count,
 646         flag_bound_evaluated>: Now unsigned.
 647
 648 2019-11-28  Tom Tromey  <tom@tromey.com>
 649
 650         * guile/guile-internal.h (vlscm_scm_from_value_unsafe): Don't
 651         declare.
 652
 653 2019-11-28  Mihails Strasuns  <mihails.strasuns@intel.com>
 654
 655         * jit.c (jit_bfd_try_read_symtab): Fix printed function name in the
 656         debug output.
 657         * jit.c (jit_unregister_code): Add debug print to match
 658         `jit_register_code`.
 659
 660 2019-11-27  Christian Biesinger  <cbiesinger@google.com>
 661
 662         * NEWS: Mention the new multithreaded symbol loading.
 663
 664 2019-11-27  Christian Biesinger  <cbiesinger@google.com>
 665
 666         * maint.c (n_worker_threads): Default to 0.
 667         (worker_threads_disabled): New function.
 668         * maint.h (worker_threads_disabled): New function.
 669         * minsyms.c (minimal_symbol_reader::record_full): Call symbol_set_names
 670         here if worker_threads_disabled () is true.
 671         (minimal_symbol_reader::install): Skip all threading if
 672         worker_threads_disabled () is true.
 673
 674 2019-11-27  Christian Biesinger  <cbiesinger@google.com>
 675
 676         * minsyms.c (add_minsym_to_hash_table): Use a previously computed
 677         hash code if possible.
 678         (add_minsym_to_demangled_hash_table): Likewise.
 679         (minimal_symbol_reader::install): Compute the hash codes for msymbol
 680         on the background thread.
 681         * symtab.h (struct minimal_symbol) <hash_value, demangled_hash_value>:
 682         Add these fields.
 683
 684 2019-11-27  Christian Biesinger  <cbiesinger@google.com>
 685
 686         * minsyms.c (minimal_symbol_reader::install): Also compute the hash
 687         of the mangled name on the background thread.
 688         * symtab.c (symbol_set_names): Allow passing in the hash of the
 689         linkage_name.
 690         * symtab.h (symbol_set_names): Likewise.
 691
 692 2019-11-27  Kevin Buettner  <kevinb@redhat.com>
 693
 694         * dwarf2read.c (inherit_abstract_dies): Ensure that delayed
 695         physnames are computed for inherited DIEs.
 696
 697 2019-11-27  Tom Tromey  <tromey@adacore.com>
 698
 699         * dwarf2read.h (struct dwarf2_per_objfile): Remove unnecessary
 700         backslashes.
 701         * cp-support.c: Remove unnecessary backslashes.
 702
 703 2019-11-27  Christian Biesinger  <cbiesinger@google.com>
 704
 705         * ada-exp.y (write_ambiguous_var): Replace SYMBOL_SET_LINKAGE_NAME
 706         with sym->set_linkage_name.
 707         * coffread.c (coff_read_enum_type): Likewise.
 708         * mdebugread.c (parse_symbol): Likewise.
 709         * stabsread.c (patch_block_stabs): Likewise.
 710         (define_symbol): Likewise.
 711         (read_enum_type): Likewise.
 712         (common_block_end): Likewise.
 713         * symtab.h (struct general_symbol_info) <set_linkage_name>: New
 714         function.
 715         (SYMBOL_SET_LINKAGE_NAME): Remove.
 716         * xcoffread.c (process_xcoff_symbol): Replace SYMBOL_SET_LINKAGE_NAME
 717         with sym->set_linkage_name.
 718
 719 2019-11-27  Andrew Burgess  <andrew.burgess@embecosm.com>
 720
 721         * mi/mi-cmds.c (mi_cmds): Add 'symbol-info-modules' entry.
 722         * mi/mi-cmds.h (mi_cmd_symbol_info_modules): Declare.
 723         * mi/mi-symbol-cmds.c (mi_cmd_symbol_info_modules): New function.
 724         * NEWS: Mention new MI command.
 725
 726 2019-11-27  Andrew Burgess  <andrew.burgess@embecosm.com>
 727
 728         * mi/mi-cmds.c (mi_cmds): Add '-symbol-info-functions',
 729         '-symbol-info-types', and '-symbol-info-variables'.
 730         * mi/mi-cmds.h (mi_cmd_symbol_info_functions): Declare.
 731         (mi_cmd_symbol_info_types): Declare.
 732         (mi_cmd_symbol_info_variables): Declare.
 733         * mi/mi-symbol-cmds.c: Add 'source.h' and 'mi-getopt.h' includes.
 734         (output_debug_symbol): New function.
 735         (output_nondebug_symbol): New function.
 736         (mi_symbol_info): New function.
 737         (mi_info_functions_or_variables): New function.
 738         (mi_cmd_symbol_info_functions): New function.
 739         (mi_cmd_symbol_info_types): New function.
 740         (mi_cmd_symbol_info_variables): New function.
 741         * NEWS: Mention new commands.
 742
 743 2019-11-27  Andrew Burgess  <andrew.burgess@embecosm.com>
 744
 745         * symtab.c (symbol_to_info_string): New function, most content
 746         moved from print_symbol_info, but updated to return a std::string.
 747         (print_symbol_info): Update to use symbol_to_info_string and print
 748         returned string.
 749         * symtab.h (symbol_to_info_string): Declare new function.
 750
 751 2019-11-27  Andrew Burgess  <andrew.burgess@embecosm.com>
 752
 753         * python/python.c (gdbpy_rbreak): Convert to using
 754         global_symbol_searcher.
 755         * symtab.c (file_matches): Convert return type to bool, change
 756         file list to std::vector, update header comment.
 757         (search_symbols): Rename to...
 758         (global_symbol_searcher::search): ...this and update now its
 759         a member function of global_symbol_searcher.  Take account of the
 760         changes to file_matches.
 761         (symtab_symbol_info): Convert to using global_symbol_searcher.
 762         (rbreak_command): Likewise.
 763         (search_module_symbols): Likewise.
 764         * symtab.h (enum symbol_search): Update comment.
 765         (search_symbols): Remove declaration.
 766         (class global_symbol_searcher): New class.
 767
 768 2019-11-26  Tom Tromey  <tromey@adacore.com>
 769
 770         * cp-support.c (_initialize_cp_support): Conditionally initialize
 771         gdb_demangle_attempt_core_dump.
 772
 773 2019-11-26  Tom Tromey  <tom@tromey.com>
 774
 775         * python/py-function.c (fnpy_init): Update.
 776         * value.h (add_internal_function): Adjust declaration.
 777         * value.c (function_destroyer): Remove.
 778         (do_add_internal_function): Don't set destroyer or copy name.
 779         (add_internal_function): Take unique_xmalloc_ptr<char> for name.
 780         Set name_allocated.
 781         * python/py-cmd.c (cmdpy_destroyer): Don't free "name".
 782         (cmdpy_init): Set name_allocated.
 783         * cli/cli-decode.h (struct cmd_list_element) <name_allocated>: New
 784         member.
 785         (~cmd_list_element): Free "name" if needed.
 786
 787 2019-11-26  Tom Tromey  <tom@tromey.com>
 788
 789         * value.h (add_internal_function): Add new overload.  Move
 790         documentation from value.h.
 791         * value.c (do_add_internal_function): New function.
 792         (add_internal_function): Use it.  Add new overload.
 793         (function_destroyer): Don't free doc.
 794         * python/py-function.c (fnpy_init): Update.
 795
 796 2019-11-26  Tom Tromey  <tom@tromey.com>
 797
 798         * python/py-cmd.c (cmdpy_destroyer): Don't free "doc".
 799         (cmdpy_init): Set "doc_allocated".
 800
 801 2019-11-26  Tom Tromey  <tom@tromey.com>
 802
 803         * gdbsupport/thread-pool.c (thread_pool::set_thread_count): Set
 804         name of worker thread.
 805         * gdbsupport/common.m4 (GDB_AC_COMMON): Check for
 806         pthread_setname_np.
 807         * configure, config.in: Rebuild.
 808
 809 2019-11-26  Tom Tromey  <tom@tromey.com>
 810
 811         * python/python.c (class gdbpy_gil): New.
 812         (struct gdbpy_event): Add constructor, destructor, operator().
 813         (gdbpy_post_event): Use run_on_main_thread.
 814         (gdbpy_initialize_events): Remove.
 815         (do_start_initialization): Update.
 816
 817 2019-11-26  Tom Tromey  <tom@tromey.com>
 818
 819         * NEWS: Add entry.
 820         * maint.c (_initialize_maint_cmds): Add "worker-threads" maint
 821         commands.  Call update_thread_pool_size.
 822         (update_thread_pool_size, maintenance_set_worker_threads): New
 823         functions.
 824         (n_worker_threads): New global.
 825
 826 2019-11-26  Christian Biesinger  <cbiesinger@google.com>
 827             Tom Tromey  <tom@tromey.com>
 828
 829         * minsyms.c (minimal_symbol_reader::install): Use
 830         parallel_for_each.
 831         * gdbsupport/parallel-for.h: New file.
 832         * Makefile.in (HFILES_NO_SRCDIR): Add gdbsupport/parallel-for.h.
 833
 834 2019-11-26  Christian Biesinger  <cbiesinger@google.com>
 835             Tom Tromey  <tom@tromey.com>
 836
 837         * gdbsupport/thread-pool.h: New file.
 838         * gdbsupport/thread-pool.c: New file.
 839         * Makefile.in (COMMON_SFILES): Add thread-pool.c.
 840         (HFILES_NO_SRCDIR): Add thread-pool.h.
 841
 842 2019-11-26  Tom Tromey  <tom@tromey.com>
 843
 844         * event-top.h (thread_local_segv_handler): Declare.
 845         * event-top.c (thread_local_segv_handler): New global.
 846         (install_handle_sigsegv, handle_sigsegv): New functions.
 847         (async_init_signals): Install SIGSEGV handler.
 848         * cp-support.c (gdb_demangle_jmp_buf): Change type.  Now
 849         thread-local.
 850         (report_failed_demangle): New function.
 851         (gdb_demangle): Make core_dump_allowed atomic.  Remove signal
 852         handler-setting code, instead use segv_handler.  Run warning code
 853         on main thread.
 854
 855 2019-11-26  Tom Tromey  <tom@tromey.com>
 856
 857         * run-on-main-thread.c: New file.
 858         * run-on-main-thread.h: New file.
 859         * unittests/main-thread-selftests.c: New file.
 860         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
 861         main-thread-selftests.c.
 862         (HFILES_NO_SRCDIR): Add run-on-main-thread.h.
 863         (COMMON_SFILES): Add run-on-main-thread.c.
 864
 865 2019-11-26  Tom Tromey  <tom@tromey.com>
 866
 867         * main.c (setup_alternate_signal_stack): Remove.
 868         (captured_main_1): Use gdb::alternate_signal_stack.
 869         * gdbsupport/alt-stack.h: New file.
 870
 871 2019-11-26  Tom Tromey  <tom@tromey.com>
 872
 873         * gdbsupport/signals-state-save-restore.c (original_signal_mask):
 874         Remove comment.
 875         (save_original_signals_state, restore_original_signals_state): Use
 876         gdb_sigmask.
 877         * linux-nat.c (block_child_signals, restore_child_signals_mask)
 878         (_initialize_linux_nat): Use gdb_sigmask.
 879         * guile/guile.c (_initialize_guile): Use block_signals.
 880         * Makefile.in (HFILES_NO_SRCDIR): Add gdb-sigmask.h.
 881         * gdbsupport/gdb-sigmask.h: New file.
 882         * event-top.c (async_sigtstp_handler): Use gdb_sigmask.
 883         * cp-support.c (gdb_demangle): Use gdb_sigmask.
 884         * gdbsupport/common.m4 (GDB_AC_COMMON): Check for
 885         pthread_sigmask.
 886         * configure, config.in: Rebuild.
 887         * gdbsupport/block-signals.h: New file.
 888
 889 2019-11-26  Tom Tromey  <tom@tromey.com>
 890
 891         * acinclude.m4: Include ax_pthread.m4.
 892         * Makefile.in (PTHREAD_CFLAGS, PTHREAD_LIBS): New variables.
 893         (INTERNAL_CFLAGS_BASE): Use PTHREAD_CFLAGS.
 894         (CLIBS): Use PTHREAD_LIBS.
 895         (aclocal_m4_deps): Add ax_pthread.m4.
 896         * config.in, configure: Rebuild.
 897         * gdbsupport/common.m4 (GDB_AC_COMMON): Check for std::thread.
 898
 899 2019-11-26  Tom Tromey  <tom@tromey.com>
 900
 901         * symtab.h (struct minimal_symbol) <name_set>: New member.
 902         * minsyms.c (minimal_symbol_reader::record_full): Copy name.
 903         Don't call symbol_set_names.
 904         (minimal_symbol_reader::install): Call symbol_set_names.
 905
 906 2019-11-26  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 907
 908         * python/python.c (gdbpy_enter::~gdbpy_enter): Release GIL after
 909         restore_active_ext_lang, as GIL is needed for (indirectly)
 910         called PyOS_InterruptOccurred.
 911
 912 2019-11-26  Simon Marchi  <simon.marchi@efficios.com>
 913
 914         * sparc-nat.c (sparc_xfer_wcookie): Sync declaration with
 915         definition.
 916
 917 2019-11-26  Simon Marchi  <simon.marchi@efficios.com>
 918
 919         * remote-sim.c (simulator_command): Make static, remove
 920         declaration.
 921
 922 2019-11-26  Simon Marchi  <simon.marchi@efficios.com>
 923
 924         * unittests/array-view-selftests.c (check_ptr_size_ctor2): Make
 925         static.
 926         * unittests/basic_string_view/capacity/1.cc (test01): Likewise.
 927         * unittests/basic_string_view/cons/char/1.cc (test01): Likewise.
 928         (main): Likewise.
 929         * unittests/basic_string_view/cons/char/2.cc (test03): Likewise.
 930         (main): Likewise.
 931         * unittests/basic_string_view/cons/char/3.cc (test05): Likewise.
 932         (main): Likewise.
 933         * unittests/basic_string_view/element_access/char/1.cc (test01):
 934         Likewise.
 935         (main): Likewise.
 936         * unittests/basic_string_view/element_access/char/empty.cc (main):
 937         Likewise.
 938         * unittests/basic_string_view/element_access/char/front_back.cc
 939         (test01): Likewise.
 940         (main): Likewise.
 941         * unittests/basic_string_view/inserters/char/2.cc (test05):
 942         Likewise.
 943         (main): Likewise.
 944         * unittests/basic_string_view/modifiers/remove_prefix/char/1.cc
 945         (test01): Likewise.
 946         (main): Likewise.
 947         * unittests/basic_string_view/modifiers/remove_suffix/char/1.cc
 948         (test01): Likewise.
 949         (main): Likewise.
 950         * unittests/basic_string_view/modifiers/swap/char/1.cc (test01):
 951         Likewise.
 952         * unittests/basic_string_view/operations/compare/char/1.cc
 953         (test01): Likewise.
 954         (main): Likewise.
 955         * unittests/basic_string_view/operations/compare/char/13650.cc
 956         (test01): Likewise.
 957         * unittests/basic_string_view/operations/copy/char/1.cc (test01):
 958         Likewise.
 959         (main): Likewise.
 960         * unittests/basic_string_view/operations/data/char/1.cc (test01):
 961         Likewise.
 962         (main): Likewise.
 963         * unittests/basic_string_view/operations/find/char/1.cc (test01):
 964         Likewise.
 965         (main): Likewise.
 966         * unittests/basic_string_view/operations/find/char/2.cc (test02):
 967         Likewise.
 968         (main): Likewise.
 969         * unittests/basic_string_view/operations/find/char/3.cc (test03):
 970         Likewise.
 971         (main): Likewise.
 972         * unittests/basic_string_view/operations/find/char/4.cc (main):
 973         Likewise.
 974         * unittests/basic_string_view/operations/rfind/char/1.cc (test01):
 975         Likewise.
 976         (main): Likewise.
 977         * unittests/basic_string_view/operations/rfind/char/2.cc (test02):
 978         Likewise.
 979         (main): Likewise.
 980         * unittests/basic_string_view/operations/rfind/char/3.cc (test03):
 981         Likewise.
 982         (main): Likewise.
 983         * unittests/basic_string_view/operations/substr/char/1.cc
 984         (test01): Likewise.
 985         (main): Likewise.
 986         * unittests/basic_string_view/operators/char/2.cc (main):
 987         Likewise.
 988         * unittests/optional/assignment/1.cc (test): Likewise.
 989         * unittests/optional/assignment/2.cc (test): Likewise.
 990         * unittests/optional/assignment/3.cc (test): Likewise.
 991         * unittests/optional/assignment/4.cc (test): Likewise.
 992         * unittests/optional/assignment/5.cc (test): Likewise.
 993         * unittests/optional/assignment/6.cc (test): Likewise.
 994         * unittests/optional/assignment/7.cc (test): Likewise.
 995         * unittests/optional/cons/copy.cc (test): Likewise.
 996         * unittests/optional/cons/default.cc (test): Likewise.
 997         * unittests/optional/cons/move.cc (test): Likewise.
 998         * unittests/optional/cons/value.cc (test): Likewise.
 999         * unittests/optional/in_place.cc (test): Likewise.
1000         * unittests/optional/observers/1.cc (test): Likewise.
1001         * unittests/optional/observers/2.cc (test): Likewise.
1002
1003 2019-11-26  Simon Marchi  <simon.marchi@efficios.com>
1004
1005         * tui-win.h (tui_set_var_cmd): Remove.
1006         * tui-win.c (tui_set_var_cmd): Make static.
1007
1008 2019-11-26  Simon Marchi  <simon.marchi@efficios.com>
1009
1010         * breakpoint.h (hbreak_command_wrapper, thbreak_command_wrapper,
1011         rbreak_command_wrapper): Remove.
1012         * symtab.c (rbreak_command_wrapper): Remove.
1013
1014 2019-11-26  Simon Marchi  <simon.marchi@efficios.com>
1015
1016         * inferior.h (info_terminal_command): Remove declaration.
1017         * inflow.c (info_terminal_command): Make static.
1018
1019 2019-11-26  Simon Marchi  <simon.marchi@efficios.com>
1020
1021         * inferior.c (exit_inferior_silent): Remove.
1022
1023 2019-11-26  Simon Marchi  <simon.marchi@efficios.com>
1024
1025         * dictionary.c (dict_empty, mdict_empty): Remove.
1026         * dictionary.c (mdict_empty): Remove.
1027
1028 2019-11-26  Simon Marchi  <simon.marchi@efficios.com>
1029
1030          * arc-tdep.c (arc_insn_get_memory_base_reg): Make static.
1031          (arc_insn_get_memory_offset): Likewise.
1032          (arc_insn_dump): Likewise.
1033          * cp-support.c (test_cp_symbol_name_matches): Likewise.
1034          * csky-linux-tdep.c (csky_supply_fregset): Likewise.
1035          * dictionary.c (dict_iterator_next): Likewise.
1036          (dict_iter_match_first): Likewise.
1037          (dict_iter_match_next): Likewise.
1038          * f-lang.c (evaluate_subexp_f): Likewise.
1039          * hppa-tdep.c (hppa_read_pc): Likewise.
1040          * i386-tdep.c (i386_floatformat_for_type): Likewise.
1041          * parse.c (write_exp_elt_msym): Likewise.
1042          * ppc-linux-tdep.c (ppc_floatformat_for_type): Likewise.
1043          * remote.c (remote_packet_size): Likewise.
1044          (remote_notif_stop_parse): Likewise.
1045          * rs6000-aix-tdep.c (aix_sighandle_frame_sniffer): Likewise.
1046          * s12z-tdep.c (s12z_disassemble_info): Likewise.
1047          * source.c (prepare_path_for_appending): Likewise.
1048          * sparc64-linux-tdep.c
1049          (sparc64_linux_handle_segmentation_fault); Likewise.
1050          * stack.c (frame_selection_by_function_completer): Likewise.
1051
1052 2019-11-26  Simon Marchi  <simon.marchi@efficios.com>
1053
1054         * completer.c (set_gdb_completion_word_break_characters):
1055         Remove.
1056
1057 2019-11-26  Simon Marchi  <simon.marchi@efficios.com>
1058
1059         * dwarf-index-write.c: Include dwarf-index-write.h.
1060         * mi/mi-interp.c: Include mi/mi-interp.h.
1061
1062 2019-11-26  Simon Marchi  <simon.marchi@efficios.com>
1063
1064         * aarch32-tdep.c: Include aarch32-tdep.h.
1065         * aarch32-tdep.h: Forward-declare struct target_desc.
1066
1067 2019-11-26  Christian Biesinger  <cbiesinger@google.com>
1068
1069         * linux-nat.c (detach_one_lwp): Call safe_strerror instead of
1070         strerror.
1071         * nto-procfs.c (nto_procfs_target::create_inferior): Likewise.
1072         * windows-nat.c (windows_nat_target::create_inferior): Likewise.
1073
1074 2019-11-25  Tom de Vries  <tdevries@suse.de>
1075
1076         * contrib/words.sh: Add -c option.
1077
1078 2019-11-25  Christian Biesinger  <cbiesinger@google.com>
1079
1080         * solib.c (solib_find_1): Change int to bool.
1081         (exec_file_find): Change int to bool.
1082         (solib_find): Change int to bool.
1083         (solib_read_symbols): Change int to bool.
1084         (solib_used): Change int to bool.
1085         (solib_add): Change int to bool.
1086         (info_sharedlibrary_command): Change int to bool.
1087         (solib_contains_address_p): Change int to bool.
1088         (solib_keep_data_in_core): Change int to bool.
1089         (in_solib_dynsym_resolve_code): Change int to bool.
1090         (reload_shared_libraries_1): Change int to bool.
1091         (gdb_sysroot_changed): Change int to bool.
1092         * solib.h (solib_read_symbols): Change int to bool.
1093         (solib_contains_address_p): Change int to bool.
1094         (solib_keep_data_in_core): Change int to bool.
1095         (in_solib_dynsym_resolve_code): Change int to bool.
1096         (libpthread_name_p): Change int to bool.
1097
1098 2019-11-25  Luis Machado  <luis.machado@linaro.org>
1099
1100         * NEWS (New Commands): Mention "set debug remote-packet-max-chars".
1101         * remote.c (REMOTE_DEBUG_MAX_CHAR): Remove.
1102         (remote_packet_max_chars): New static global.
1103         (show_remote_packet_max_chars): New function.
1104         (remote_target::putpkt_binary): Adjust to use new
1105         remote_packet_max_chars option.
1106         (remote_target::getpkt_or_notif_sane_1): Likewise.
1107         (_initialize_remote): Register new remote-packet-max-chars option.
1108
1109 2019-11-24  Simon Marchi  <simon.marchi@efficios.com>
1110
1111         * m68k-linux-nat.c: Include gdbarch.h.
1112
1113 2019-11-24  Tom Tromey  <tom@tromey.com>
1114
1115         * symfile.c (read_symbols): Update.
1116         * psymtab.c (require_partial_symbols): Change type of "verbose" to
1117         bool.
1118         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
1119         (psym_lookup_symbol, psym_find_last_source_symtab)
1120         (psym_forget_cached_source_info, psym_print_stats)
1121         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
1122         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
1123         (psym_map_matching_symbols, psym_expand_symtabs_matching)
1124         (psym_find_compunit_symtab_by_address)
1125         (maintenance_print_psymbols, maintenance_info_psymtabs)
1126         (maintenance_check_psymtabs): Update.
1127         * psymtab.h (require_partial_symbols): Change type of "verbose" to
1128         bool.
1129
1130 2019-11-22  Tom Tromey  <tom@tromey.com>
1131
1132         * observable.h: Update comments.
1133
1134 2019-11-22  Tom Tromey  <tromey@adacore.com>
1135
1136         * ada-tasks.c (ada_task_is_alive): Make parameter const.
1137         (print_ada_task_info): Don't try to fetch thread id if task is not
1138         alive.
1139
1140 2019-11-22  Christian Biesinger  <cbiesinger@google.com>
1141
1142         * ada-exp.y: Update.
1143         * ada-lang.c (sort_choices): Update.
1144         (ada_print_symbol_signature): Update.
1145         (resolve_subexp): Update.
1146         (ada_parse_renaming): Update.
1147         (ada_read_renaming_var_value): Update.
1148         (lesseq_defined_than): Update.
1149         (remove_extra_symbols): Update.
1150         (remove_irrelevant_renamings): Update.
1151         (ada_add_block_symbols): Update.
1152         (ada_collect_symbol_completion_matches): Update.
1153         (ada_is_renaming_symbol): Update.
1154         (aggregate_assign_from_choices): Update.
1155         (ada_evaluate_subexp): Update.
1156         (ada_has_this_exception_support): Update.
1157         (ada_is_non_standard_exception_sym): Update.
1158         (ada_add_exceptions_from_frame): Update.
1159         (ada_add_global_exceptions): Update.
1160         (ada_print_subexp): Update.
1161         * ax-gdb.c (gen_var_ref): Update.
1162         (gen_maybe_namespace_elt): Update.
1163         (gen_expr_for_cast): Update.
1164         (gen_expr): Update.
1165         * block.h: Update.
1166         * blockframe.c (find_pc_partial_function): Update.
1167         * breakpoint.c (print_breakpoint_location): Update.
1168         (update_static_tracepoint): Update.
1169         * btrace.c (ftrace_print_function_name): Update.
1170         (ftrace_function_switched): Update.
1171         * buildsym.c (find_symbol_in_list): Update.
1172         * c-exp.y: Update.
1173         * c-typeprint.c (c_print_typedef): Update.
1174         (c_type_print_template_args): Update.
1175         * cli/cli-cmds.c (edit_command): Update.
1176         (list_command): Update.
1177         (print_sal_location): Update.
1178         * coffread.c (patch_opaque_types): Update.
1179         (process_coff_symbol): Update.
1180         (coff_read_enum_type): Update.
1181         * compile/compile-c-symbols.c (c_symbol_substitution_name): Update.
1182         (convert_one_symbol): Update.
1183         (hash_symname): Update.
1184         (eq_symname): Update.
1185         * compile/compile-cplus-symbols.c (convert_one_symbol): Update.
1186         * compile/compile-cplus-types.c (debug_print_scope): Update.
1187         * compile/compile-loc2c.c (do_compile_dwarf_expr_to_c): Update.
1188         * compile/compile-object-load.c (get_out_value_type): Update.
1189         * cp-namespace.c (cp_scan_for_anonymous_namespaces): Update.
1190         (search_symbol_list): Update.
1191         (cp_lookup_symbol_imports_or_template): Update.
1192         * cp-support.c (overload_list_add_symbol): Update.
1193         * ctfread.c (psymtab_to_symtab): Update.
1194         * dbxread.c (cp_set_block_scope): Update.
1195         * dictionary.c (iter_match_first_hashed): Update.
1196         (iter_match_next_hashed): Update.
1197         (insert_symbol_hashed): Update.
1198         (iter_match_next_linear): Update.
1199         * dictionary.h: Update.
1200         * dwarf2loc.c (func_get_frame_base_dwarf_block): Update.
1201         (locexpr_describe_location_piece): Update.
1202         (locexpr_describe_location_1): Update.
1203         (locexpr_generate_c_location): Update.
1204         (loclist_describe_location): Update.
1205         (loclist_generate_c_location): Update.
1206         * dwarf2read.c (dw2_debug_names_lookup_symbol): Update.
1207         (read_func_scope): Update.
1208         (process_enumeration_scope): Update.
1209         (new_symbol): Update.
1210         (dwarf2_const_value): Update.
1211         (dwarf2_symbol_mark_computed): Update.
1212         * eval.c (evaluate_funcall): Update.
1213         (evaluate_subexp_standard): Update.
1214         * expprint.c (print_subexp_standard): Update.
1215         (dump_subexp_body_standard): Update.
1216         * f-valprint.c (info_common_command_for_block): Update.
1217         * findvar.c (get_hosting_frame): Update.
1218         (default_read_var_value): Update.
1219         * go-lang.c (go_symbol_package_name): Update.
1220         * guile/scm-block.c (bkscm_print_block_smob): Update.
1221         * guile/scm-symbol.c (syscm_print_symbol_smob): Update.
1222         (gdbscm_symbol_name): Update.
1223         (gdbscm_symbol_linkage_name): Update.
1224         (gdbscm_symbol_print_name): Update.
1225         * infcall.c (get_function_name): Update.
1226         * infcmd.c (jump_command): Update.
1227         (finish_command): Update.
1228         * infrun.c (insert_exception_resume_breakpoint): Update.
1229         * linespec.c (canonicalize_linespec): Update.
1230         (create_sals_line_offset): Update.
1231         (convert_linespec_to_sals): Update.
1232         (complete_label): Update.
1233         (find_label_symbols_in_block): Update.
1234         * m2-typeprint.c (m2_print_typedef): Update.
1235         * mdebugread.c (mdebug_reg_to_regnum): Update.
1236         (parse_symbol): Update.
1237         (mylookup_symbol): Update.
1238         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
1239         (list_args_or_locals): Update.
1240         * objc-lang.c (compare_selectors): Update.
1241         (info_selectors_command): Update.
1242         (compare_classes): Update.
1243         (info_classes_command): Update.
1244         (find_imps): Update.
1245         * p-typeprint.c (pascal_print_typedef): Update.
1246         * printcmd.c (build_address_symbolic): Update.
1247         (info_address_command): Update.
1248         (print_variable_and_value): Update.
1249         * python/py-framefilter.c (extract_sym): Update.
1250         (py_print_single_arg): Update.
1251         * python/py-symbol.c (sympy_str): Update.
1252         (sympy_get_name): Update.
1253         (sympy_get_linkage_name): Update.
1254         * python/python.c (gdbpy_rbreak): Update.
1255         * record-btrace.c (btrace_get_bfun_name): Update.
1256         (btrace_call_history): Update.
1257         * rust-lang.c (rust_print_typedef): Update.
1258         * solib-frv.c (frv_fdpic_find_canonical_descriptor): Update.
1259         * stabsread.c (stab_reg_to_regnum): Update.
1260         (define_symbol): Update.
1261         (read_enum_type): Update.
1262         (common_block_end): Update.
1263         (cleanup_undefined_types_1): Update.
1264         (scan_file_globals): Update.
1265         * stack.c (print_frame_arg): Update.
1266         (print_frame_args): Update.
1267         (find_frame_funname): Update.
1268         (info_frame_command_core): Update.
1269         (iterate_over_block_locals): Update.
1270         (print_block_frame_labels): Update.
1271         (do_print_variable_and_value): Update.
1272         (iterate_over_block_arg_vars): Update.
1273         (return_command): Update.
1274         * symmisc.c (dump_symtab_1): Update.
1275         (print_symbol): Update.
1276         * symtab.c (eq_symbol_entry): Update.
1277         (symbol_cache_dump): Update.
1278         (lookup_language_this): Update.
1279         (find_pc_sect_line): Update.
1280         (skip_prologue_sal): Update.
1281         (symbol_search::compare_search_syms): Update.
1282         (treg_matches_sym_type_name): Update.
1283         (search_symbols): Update.
1284         (print_symbol_info): Update.
1285         (rbreak_command): Update.
1286         (completion_list_add_symbol): Update.
1287         (find_gnu_ifunc): Update.
1288         (get_symbol_address): Update.
1289         (search_module_symbols): Update.
1290         (info_module_subcommand): Update.
1291         * symtab.h (SYMBOL_NATURAL_NAME): Remove.
1292         (SYMBOL_LINKAGE_NAME): Remove.
1293         (SYMBOL_DEMANGLED_NAME): Remove.
1294         (SYMBOL_PRINT_NAME): Remove.
1295         (SYMBOL_SEARCH_NAME): Remove.
1296         * tracepoint.c (set_traceframe_context): Update.
1297         (validate_actionline): Update.
1298         (collection_list::collect_symbol): Update.
1299         (encode_actions_1): Update.
1300         (info_scope_command): Update.
1301         (print_one_static_tracepoint_marker): Update.
1302         * typeprint.c (typedef_hash_table::add_template_parameters): Update.
1303         * valops.c (address_of_variable): Update.
1304         (find_overload_match): Update.
1305         (find_oload_champ): Update.
1306
1307 2019-11-22  Christian Biesinger  <cbiesinger@google.com>
1308
1309         * ada-lang.c (ada_lookup_simple_minsym): Update.
1310         (ada_collect_symbol_completion_matches): Update.
1311         * ada-tasks.c (read_atcb): Update.
1312         * amd64-windows-tdep.c (amd64_skip_main_prologue): Update.
1313         (amd64_windows_skip_trampoline_code): Update.
1314         * arm-tdep.c (skip_prologue_function): Update.
1315         (arm_skip_stack_protector): Update.
1316         * arm-wince-tdep.c (arm_pe_skip_trampoline_code): Update.
1317         (arm_wince_skip_main_prologue): Update.
1318         * ax-gdb.c (gen_expr): Update.
1319         * block.c (call_site_for_pc): Update.
1320         * blockframe.c (find_pc_partial_function): Update.
1321         * breakpoint.c (set_breakpoint_location_function): Update.
1322         * btrace.c (ftrace_print_function_name): Update.
1323         (ftrace_function_switched): Update.
1324         * c-valprint.c (print_unpacked_pointer): Update.
1325         * coffread.c (coff_symfile_read): Update.
1326         * compile/compile-c-symbols.c (convert_symbol_bmsym): Update.
1327         * compile/compile-cplus-symbols.c (convert_symbol_bmsym): Update.
1328         * dwarf-index-write.c (write_psymbols): Update.
1329         * dwarf2loc.c (call_site_to_target_addr): Update.
1330         (func_verify_no_selftailcall): Update.
1331         (tailcall_dump): Update.
1332         (call_site_find_chain_1): Update.
1333         (dwarf_expr_reg_to_entry_parameter): Update.
1334         * elfread.c (elf_gnu_ifunc_record_cache): Update.
1335         * eval.c (evaluate_funcall): Update.
1336         (evaluate_subexp_standard): Update.
1337         (evaluate_subexp_for_sizeof): Update.
1338         * expprint.c (print_subexp_standard): Update.
1339         (dump_subexp_body_standard): Update.
1340         * frame.c (get_prev_frame_always_1): Update.
1341         * frv-tdep.c (frv_skip_main_prologue): Update.
1342         * gnu-v2-abi.c (gnuv2_value_rtti_type): Update.
1343         * gnu-v3-abi.c (gnuv3_rtti_type): Update.
1344         (gnuv3_get_typename_from_type_info): Update.
1345         (gnuv3_skip_trampoline): Update.
1346         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
1347         * i386-tdep.c (i386_skip_main_prologue): Update.
1348         (i386_pe_skip_trampoline_code): Update.
1349         * ia64-tdep.c (ia64_convert_from_func_ptr_addr): Update.
1350         * infcall.c (get_function_name): Update.
1351         * linespec.c (minsym_found): Update.
1352         * linux-fork.c (info_checkpoints_command): Update.
1353         * m32c-tdep.c (m32c_m16c_address_to_pointer): Update.
1354         (m32c_m16c_pointer_to_address): Update.
1355         * maint.c (maintenance_translate_address): Update.
1356         * minsyms.c (add_minsym_to_hash_table): Update.
1357         (add_minsym_to_demangled_hash_table): Update.
1358         (lookup_minimal_symbol_mangled): Update.
1359         (lookup_minimal_symbol_demangled): Update.
1360         (lookup_minimal_symbol_linkage): Update.
1361         (lookup_minimal_symbol_text): Update.
1362         (lookup_minimal_symbol_by_pc_name): Update.
1363         (minimal_symbol_is_less_than): Update.
1364         (compact_minimal_symbols): Update.
1365         (build_minimal_symbol_hash_tables): Update.
1366         (find_solib_trampoline_target): Update.
1367         * mips-tdep.c (mips_stub_frame_sniffer): Update.
1368         (mips_skip_pic_trampoline_code): Update.
1369         * msp430-tdep.c (msp430_skip_trampoline_code): Update.
1370         * objc-lang.c (info_selectors_command): Update.
1371         (info_classes_command): Update.
1372         (find_methods): Update.
1373         (find_imps): Update.
1374         * p-valprint.c (pascal_val_print): Update.
1375         * ppc-linux-tdep.c (powerpc_linux_in_dynsym_resolve_code): Update.
1376         * ppc-sysv-tdep.c (convert_code_addr_to_desc_addr): Update.
1377         * printcmd.c (build_address_symbolic): Update.
1378         (info_symbol_command): Update.
1379         * psymtab.c (psymbol_name_matches): Update.
1380         (match_partial_symbol): Update.
1381         (lookup_partial_symbol): Update.
1382         (print_partial_symbols): Update.
1383         (sort_pst_symbols): Update.
1384         (maintenance_check_psymtabs): Update.
1385         * python/py-framefilter.c (py_print_frame): Update.
1386         * python/python.c (gdbpy_rbreak): Update.
1387         * record-btrace.c (btrace_get_bfun_name): Update.
1388         (btrace_call_history): Update.
1389         * rs6000-tdep.c (rs6000_skip_main_prologue): Update.
1390         (rs6000_skip_trampoline_code): Update.
1391         * sol-thread.c (info_cb): Update.
1392         * stabsread.c (scan_file_globals): Update.
1393         * stack.c (find_frame_funname): Update.
1394         (info_frame_command_core): Update.
1395         * symmisc.c (dump_msymbols): Update.
1396         * symtab.c (symbol_natural_name): Rename to..,
1397         (general_symbol_info::natural_name): ...this.
1398         (symbol_demangled_name): Rename to...
1399         (general_symbol_info::demangled_name): ...this.
1400         (symbol_search_name): Rename to...
1401         (general_symbol_info::search_name): ...this.
1402         (symbol_matches_search_name): Update.
1403         (find_pc_sect_line): Update.
1404         (skip_prologue_sal): Update.
1405         (search_symbols): Update.
1406         (print_msymbol_info): Update.
1407         (rbreak_command): Update.
1408         (completion_list_add_msymbol): Update.
1409         (completion_list_objc_symbol): Update.
1410         (get_msymbol_address): Update.
1411         * symtab.h (struct general_symbol_info): Add member functions
1412         natural_name (), linkage_name (), print_name (), demangled_name (),
1413         and search_name ().
1414         (SYMBOL_NATURAL_NAME): Update.
1415         (symbol_natural_name): Move to a member function on general_symbol_info.
1416         (SYMBOL_DEMANGLED_NAME): Update.
1417         (symbol_demangled_name): Move to a member function on
1418         general_symbol_info.
1419         (SYMBOL_SEARCH_NAME): Update.
1420         (symbol_search_name): Move to a member function on general_symbol_info.
1421         (MSYMBOL_NATURAL_NAME): Remove.
1422         (MSYMBOL_LINKAGE_NAME): Remove.
1423         (MSYMBOL_PRINT_NAME): Remove.
1424         (MSYMBOL_DEMANGLED_NAME): Remove.
1425         (MSYMBOL_SEARCH_NAME): Remove.
1426         * x86-tdep.c (x86_in_indirect_branch_thunk): Update.
1427
1428 2019-11-22  Christian Biesinger  <cbiesinger@google.com>
1429
1430         * symtab.c (create_demangled_names_hash): Use per_bfd->
1431         minimal_symbol_count for computing the initial size, if greater
1432         than our default size.
1433
1434 2019-11-22  Tom de Vries  <tdevries@suse.de>
1435
1436         * contrib/words.sh: Improve words extraction.
1437
1438 2019-11-22  Tom de Vries  <tdevries@suse.de>
1439
1440         * contrib/words.sh: Combine sed invocations.
1441
1442 2019-11-21  Christian Biesinger  <cbiesinger@google.com>
1443
1444         * Makefile.in: Update.
1445         * demangle.c: Rename to...
1446         * gdb-demangle.c: ..this.
1447         (is_cplus_marker): Change return type to bool.
1448         (_initialize_demangler): Rename to...
1449         (_initialize_gdb_demangle): ...this.
1450         * gdb-demangle.h (is_cplus_marker): Change return type to bool.
1451         * symtab.h (demangle): Remove declaration; instead include
1452         gdb-demangle.h.
1453
1454 2019-11-21  Tom Tromey  <tromey@adacore.com>
1455
1456         * gdbsupport/format.c (format_pieces): Parse %I64d.
1457         * unittests/format_pieces-selftests.c (test_windows_formats): New
1458         function.
1459         (run_tests): Call it.
1460
1461 2019-11-21  Peeter Joot  <peeter.joot@lzlabs.com>
1462
1463         Byte reverse display of variables with DW_END_big, DW_END_little
1464         (DW_AT_endianity) dwarf attributes if different than the native
1465         byte order.
1466         * ada-lang.c (ada_value_binop):
1467         Use type_byte_order instead of gdbarch_byte_order.
1468         * ada-valprint.c (printstr):
1469         (ada_val_print_string):
1470         * ada-lang.c (value_pointer):
1471         (ada_value_binop):
1472         Use type_byte_order instead of gdbarch_byte_order.
1473         * c-lang.c (c_get_string):
1474         Use type_byte_order instead of gdbarch_byte_order.
1475         * c-valprint.c (c_val_print_array):
1476         Use type_byte_order instead of gdbarch_byte_order.
1477         * cp-valprint.c (cp_print_class_member):
1478         Use type_byte_order instead of gdbarch_byte_order.
1479         * dwarf2loc.c (rw_pieced_value):
1480         Use type_byte_order instead of gdbarch_byte_order.
1481         * dwarf2read.c (read_base_type): Handle DW_END_big,
1482         DW_END_little
1483         * f-lang.c (f_get_encoding):
1484         Use type_byte_order instead of gdbarch_byte_order.
1485         * findvar.c (default_read_var_value):
1486         Use type_byte_order instead of gdbarch_byte_order.
1487         * gdbtypes.c (check_types_equal):
1488         Require matching TYPE_ENDIANITY_NOT_DEFAULT if set.
1489         (recursive_dump_type): Print TYPE_ENDIANITY_BIG,
1490         and TYPE_ENDIANITY_LITTLE if set.
1491         (type_byte_order): new function.
1492         * gdbtypes.h (TYPE_ENDIANITY_NOT_DEFAULT): New macro.
1493         (struct main_type) <flag_endianity_not_default>:
1494         New field.
1495         (type_byte_order): New function.
1496         * infcmd.c (default_print_one_register_info):
1497         Use type_byte_order instead of gdbarch_byte_order.
1498         * p-lang.c (pascal_printstr):
1499         Use type_byte_order instead of gdbarch_byte_order.
1500         * p-valprint.c (pascal_val_print):
1501         Use type_byte_order instead of gdbarch_byte_order.
1502         * printcmd.c (print_scalar_formatted):
1503         Use type_byte_order instead of gdbarch_byte_order.
1504         * solib-darwin.c (darwin_current_sos):
1505         Use type_byte_order instead of gdbarch_byte_order.
1506         * solib-svr4.c (solib_svr4_r_ldsomap):
1507         Use type_byte_order instead of gdbarch_byte_order.
1508         * stap-probe.c (stap_modify_semaphore):
1509         Use type_byte_order instead of gdbarch_byte_order.
1510         * target-float.c (target_float_same_format_p):
1511         Use type_byte_order instead of gdbarch_byte_order.
1512         * valarith.c (scalar_binop):
1513         (value_bit_index):
1514         Use type_byte_order instead of gdbarch_byte_order.
1515         * valops.c (value_cast):
1516         Use type_byte_order instead of gdbarch_byte_order.
1517         * valprint.c (generic_emit_char):
1518         (generic_printstr):
1519         (val_print_string):
1520         Use type_byte_order instead of gdbarch_byte_order.
1521         * value.c (unpack_long):
1522         (unpack_bits_as_long):
1523         (unpack_value_bitfield):
1524         (modify_field):
1525         (pack_long):
1526         (pack_unsigned_long):
1527         Use type_byte_order instead of gdbarch_byte_order.
1528         * findvar.c (unsigned_pointer_to_address):
1529         (signed_pointer_to_address):
1530         (unsigned_address_to_pointer):
1531         (address_to_signed_pointer):
1532         (default_read_var_value):
1533         (default_value_from_register):
1534         Use type_byte_order instead of gdbarch_byte_order.
1535         * gnu-v3-abi.c (gnuv3_make_method_ptr):
1536         Use type_byte_order instead of gdbarch_byte_order.
1537         * riscv-tdep.c (riscv_print_one_register_info):
1538         Use type_byte_order instead of gdbarch_byte_order.
1539
1540 2019-11-21  Simon Marchi  <simon.marchi@polymtl.ca>
1541
1542         * top.c (current_ui_gdb_stdout_ptr): Spell out by hand.
1543         (current_ui_gdb_stdin_ptr): Likewise.
1544         (current_ui_gdb_stderr_ptr): Likewise.
1545         (current_ui_gdb_stdlog_ptr): Likewise.
1546         (current_ui_current_uiout_ptr): Likewise.
1547         (gen_ret_current_ui_field_ptr): Remove.
1548
1549 2019-11-21  Tom de Vries  <tdevries@suse.de>
1550
1551         PR gdb/24956
1552         * cli/cli-script.c (execute_control_command): Only switch to
1553         INTERP_CONSOLE's ui_out when INTERP_MI is active.
1554
1555 2019-11-19  Tom Tromey  <tom@tromey.com>
1556
1557         * tui/tui-win.c (tui_partial_win_by_name): Move from tui-data.c.
1558         Now static.  Change type of "name".
1559         (tui_set_win_height_command): Don't copy "arg".
1560         * tui/tui-data.h (tui_partial_win_by_name): Don't declare.
1561         * tui/tui-data.c (tui_partial_win_by_name): Move to tui-win.c.
1562
1563 2019-11-19  Ali Tamur <tamur@google.com>
1564
1565         * dwarf2read.c (dw2_get_file_names_reader): Replace "if (attr)" with
1566         "if (attr != nullptr)".
1567         (dwarf2_find_base_address): Likewise.
1568         (dwarf2_build_include_psymtabs): Likewise.
1569         (read_cutu_die_from_dwo): Likewise.
1570         (read_func_scope): Likewise.
1571         (read_call_site_scope): Likewise.
1572         (dwarf2_get_pc_bounds): Likewise.
1573         (dwarf2_record_block_ranges): Likewise.
1574         (dwarf2_add_field): Likewise.
1575         (dwarf2_add_member_fn): Likewise.
1576         (read_structure_type): Likewise.
1577         (read_enumeration_type): Likewise.
1578         (read_array_type): Likewise.
1579         (read_array_order): Likewise.
1580         (read_set_type): Likewise.
1581         (read_common_block): Likewise.
1582         (read_tag_reference_type): Likewise.
1583         (read_tag_string_type): Likewise.
1584         (read_subroutine_type): Likewise.
1585         (read_base_type): Likewise.
1586         (read_subrange_type): Likewise.
1587         (new_symbol): Likewise.
1588         (prepare_one_comp_unit): Likewise.
1589
1590 2019-11-19  Tom Tromey  <tromey@adacore.com>
1591
1592         * windows-nat.c (windows_nat_target::attach): Include GetLastError
1593         result in error when DebugActiveProcess fails.
1594
1595 2019-11-18  Sergio Durigan Junior  <sergiodj@redhat.com>
1596             Pedro Alves  <palves@redhat.com>
1597
1598         https://bugzilla.redhat.com/show_bug.cgi?id=1765117
1599         * target.c (target_stack::push): Call 'unpush' if there's a
1600         target on top of the stack.
1601
1602 2019-11-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1603
1604         * python/py-block.c (blpy_dealloc): Call tp_free.
1605         (blpy_block_syms_dealloc): Likewise.
1606         * python/py-finishbreakpoint.c (bpfinishpy_dealloc): Likewise.
1607         * python/py-inferior.c (infpy_dealloc): Likewise.
1608         * python/py-lazy-string.c (stpy_dealloc): Likewise.
1609         * python/py-linetable.c (ltpy_iterator_dealloc): Likewise.
1610         * python/py-symbol.c (sympy_dealloc): Likewise.
1611         * python/py-symtab.c (stpy_dealloc): Likewise.
1612         * python/py-type.c (typy_iterator_dealloc): Likewise.
1613
1614 2019-11-18  Christian Biesinger  <cbiesinger@google.com>
1615
1616         * symtab.h (struct symbol) <owner>: Initialize explicitly in the
1617         constructor instead of using a class initializer.
1618
1619 2019-11-15  Christian Biesinger  <cbiesinger@google.com>
1620
1621         * Makefile.in: Replace {posix,mingw}-strerror.c with safe-strerror.c.
1622         * configure: Regenerate.
1623         * configure.ac: Don't source common.host.
1624         * gdbsupport/common.host: Remove.
1625         * gdbsupport/mingw-strerror.c: Remove.
1626         * gdbsupport/posix-strerror.c: Rename to...
1627         * gdbsupport/safe-strerror.c: ...this.
1628
1629 2019-11-15  Christian Biesinger  <cbiesinger@google.com>
1630
1631         * maint.c (scoped_command_stats::print_time): Use localtime_r
1632         instead of localtime (provided through gnulib if necessary).
1633         * nat/linux-osdata.c (time_from_time_t): Use ctime_r instead
1634         of ctime.
1635
1636 2019-11-15  Christian Biesinger  <cbiesinger@google.com>
1637
1638         * gdbsupport/common-defs.h: Include time.h before pathmax.h to
1639         avoid compile errors.
1640
1641 2019-11-15  Christian Biesinger  <cbiesinger@google.com>
1642
1643         * config.in: Regenerate.
1644         * configure: Regenerate.
1645         * gdbsupport/common.m4: No longer check for strerror_r.
1646         * gdbsupport/posix-strerror.c (safe_strerror): Always call the
1647         POSIX version of strerror_r, now that gnulib provides it if
1648         necessary.
1649
1650 2019-11-14  Christian Biesinger  <cbiesinger@google.com>
1651
1652         * README (`configure' options): Update.
1653
1654 2019-11-14  Tom Tromey  <tromey@adacore.com>
1655
1656         * eval.c (evaluate_subexp_standard) <BINOP_ASSIGN>: Do not pass an
1657         expected type for the RHS if the LHS is a convenience variable.
1658
1659 2019-11-14  Simon Marchi  <simon.marchi@polymtl.ca>
1660
1661         * unittests/vec-utils-selftests.c (unordered_remove_tests::obj):
1662         Provide explicit default and copy constructor.
1663
1664 2019-11-14  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1665
1666         * python/py-finishbreakpoint.c (gdbpy_breakpoint_created):
1667         only call Py_INCREF (newbp) in the bppy_pending_object case.
1668
1669 2019-11-13  Tom Tromey  <tromey@adacore.com>
1670
1671         PR build/25182:
1672         * psympriv.h (partial_symbol): Remove static assert.
1673         * symtab.h (general_symbol_info, symbol): Remove static assert.
1674
1675 2019-11-12  Andrew Burgess  <andrew.burgess@embecosm.com>
1676
1677         * gdbsupport/format.c (format_pieces::format_pieces): Support
1678         printf 'z' size modifier.
1679         * gdbsupport/format.h (enum argclass): Add size_t_arg.
1680         * printcmd.c (ui_printf):  Handle size_t_arg.
1681         * ui-out.c (ui_out::vmessage): Likewise.
1682         * unittests/format_pieces-selftests.c (test_format_int_sizes): New
1683         function.
1684         (run_tests): Call test_format_int_sizes.
1685
1686 2019-11-12  Christian Biesinger  <cbiesinger@google.com>
1687
1688         * ada-exp.y (write_ambiguous_var): Update.
1689         * buildsym.c (add_symbol_to_list): Update.
1690         * dwarf2read.c (read_variable): Update.
1691         (new_symbol): Update.
1692         * jit.c (finalize_symtab): Update.
1693         * language.c (language_alloc_type_symbol): Update.
1694         * symtab.c (fixup_symbol_section): Update.
1695         (initialize_objfile_symbol_1): Move code to...
1696         (initialize_objfile_symbol): ...here. Remove now-unnecessary memset.
1697         (allocate_symbol): Update.
1698         (allocate_template_symbol): Update.
1699         (get_symbol_address): Update.
1700         * symtab.h (struct symbol): Inherit from general_symbol_info instead
1701         of having as a field, and add a constructor.
1702         (SYMBOL_VALUE): Update.
1703         (SYMBOL_VALUE_ADDRESS): Update.
1704         (SET_SYMBOL_VALUE_ADDRESS): Update.
1705         (SYMBOL_VALUE_BYTES): Update.
1706         (SYMBOL_VALUE_COMMON_BLOCK): Update.
1707         (SYMBOL_BLOCK_VALUE): Update.
1708         (SYMBOL_VALUE_CHAIN): Update.
1709         (SYMBOL_LANGUAGE): Update.
1710         (SYMBOL_SECTION): Update.
1711         (SYMBOL_OBJ_SECTION): Update.
1712         (SYMBOL_SET_LANGUAGE): Update.
1713         (SYMBOL_SET_LINKAGE_NAME): Update.
1714         (SYMBOL_SET_NAMES): Update.
1715         (SYMBOL_NATURAL_NAME): Update.
1716         (SYMBOL_LINKAGE_NAME): Update.
1717         (SYMBOL_DEMANGLED_NAME): Update.
1718         (SYMBOL_SEARCH_NAME): Update.
1719         (SYMBOL_MATCHES_SEARCH_NAME): Update.
1720         (struct symbol): Update.
1721         (struct template_symbol): Update.
1722         (struct rust_vtable_symbol): Update.
1723         * xcoffread.c (SYMBOL_DUP): Update.
1724
1725 2019-11-12  Tom Tromey  <tom@tromey.com>
1726
1727         * tui/tui-layout.c (show_layout): Set current_layout.
1728         (show_source_disasm_command, show_data)
1729         (show_source_or_disasm_and_command): Don't set current_layout.
1730
1731 2019-11-12  Tom Tromey  <tom@tromey.com>
1732
1733         * tui/tui-layout.c (_initialize_tui_layout): Move to end.
1734
1735 2019-11-12  Tom Tromey  <tom@tromey.com>
1736
1737         * tui/tui-win.c (resize_message): New global.
1738         (show_tui_resize_message): New function.
1739         (tui_async_resize_screen): Print message if requested.
1740         (_initialize_tui_win): Add tui-resize-message setting.
1741         * NEWS: Add entry for new commands.
1742
1743 2019-11-11  Tom Tromey  <tom@tromey.com>
1744
1745         * tui/tui.c (tui_initialize_readline): Add new bindable readline
1746         functions.
1747
1748 2019-11-11  Christian Biesinger  <cbiesinger@google.com>
1749
1750         * nat/linux-osdata.c (user_from_uid): Use getpwuid_r.
1751
1752 2019-11-10  Andrew Burgess  <andrew.burgess@embecosm.com>
1753
1754         * python/py-symbol.c (gdbpy_lookup_static_symbols): New
1755         function.
1756         * python/python-internal.h (gdbpy_lookup_static_symbols):
1757         Declare new function.
1758         * python/python.c (python_GdbMethods): Add
1759         gdb.lookup_static_symbols method.
1760         * NEWS: Mention gdb.lookup_static_symbols.
1761
1762 2019-11-10  Andrew Burgess  <andrew.burgess@embecosm.com>
1763
1764         * python/py-symbol.c (gdbpy_lookup_static_symbol): Lookup in
1765         static block of current object file first.  Also fix typo in
1766         header comment.
1767
1768 2019-11-10  Andrew Burgess  <andrew.burgess@embecosm.com>
1769
1770         * stack.c (set_last_displayed_sal): Delete.
1771         (last_displayed_sal_valid): Delete.
1772         (last_displayed_pspace): Delete.
1773         (last_displayed_addr): Delete.
1774         (last_displayed_symtab): Delete.
1775         (last_displayed_line): Delete.
1776         (class last_displayed_symtab_info_type): New.
1777         (last_displayed_symtab_info): New static global variable.
1778         (print_frame_info): Call methods on last_displayed_symtab_info.
1779         (clear_last_displayed_sal): Update header comment, and make use of
1780         last_displayed_symtab_info.
1781         (last_displayed_sal_is_valid): Likewise.
1782         (get_last_displayed_pspace): Likewise.
1783         (get_last_displayed_addr): Likewise.
1784         (get_last_displayed_symtab): Likewise.
1785         (get_last_displayed_line): Likewise.
1786         (get_last_displayed_sal): Likewise.
1787         * stack.h (clear_last_displayed_sal): Update header comment.
1788         (last_displayed_sal_is_valid): Likewise.
1789         (get_last_displayed_pspace): Likewise.
1790         (get_last_displayed_addr): Likewise.
1791         (get_last_displayed_symtab): Likewise.
1792         (get_last_displayed_line): Likewise.
1793         (get_last_displayed_sal): Likewise.
1794
1795 2019-11-10  Andrew Burgess  <andrew.burgess@embecosm.com>
1796
1797         * stack.c (frame_show_address): Convert return type to bool.
1798         * stack.h (frame_show_address): Likewise, and update header
1799         comment.
1800
1801 2019-11-10  Andrew Burgess  <andrew.burgess@embecosm.com>
1802
1803         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add new file to the list.
1804         * unittests/vec-utils-selftests.c: New file.
1805         * gdbsupport/gdb_vecs.h (unordered_remove): Avoid self move assign.
1806
1807 2019-11-10  Tom Tromey  <tom@tromey.com>
1808
1809         * tui/tui-wingeneral.c (tui_unhighlight_win): Use can_box.
1810         (tui_highlight_win): Likewise.
1811         (tui_win_info::check_and_display_highlight_if_needed): Likewise.
1812         * tui/tui-data.h (struct tui_win_info) <can_highlight>: Remove.
1813         * tui/tui-command.h (struct tui_cmd_window) <tui_cmd_window>:
1814         Don't set can_highlight.
1815
1816 2019-11-10  Tom Tromey  <tom@tromey.com>
1817
1818         * cli/cli-style.h (class cli_style_option) <cli_style_option>:
1819         Remove unused declaration.
1820
1821 2019-11-08  Tom Tromey  <tromey@adacore.com>
1822
1823         * top.c (read_command_file): Update.
1824         (command_line_input): Make return type const.
1825         * python/py-gdb-readline.c: Update.
1826         * linespec.c (decode_line_2): Update.
1827         * defs.h (command_line_input): Make return type const.
1828         * cli/cli-script.c (read_next_line): Make return type const.
1829         * ada-lang.c (get_selections): Update.
1830
1831 2019-11-06  Christian Biesinger  <cbiesinger@google.com>
1832
1833         * linux-tdep.c (linux_info_proc): Use strtok_r instead of strtok.
1834         * mi/mi-main.c (output_cores): Likewise.
1835         * nat/linux-osdata.c (linux_xfer_osdata_cpus): Likewise.
1836         (linux_xfer_osdata_modules): Likewise.
1837         * remote.c (register_remote_support_xml): Likewise.
1838         * sparc64-tdep.c (adi_is_addr_mapped): Likewise.
1839         * xml-syscall.c (syscall_create_syscall_desc): Likewise.
1840
1841 2019-11-06  Tom Tromey  <tom@tromey.com>
1842
1843         * tui/tui-interp.c: Don't include readline.h.
1844         * tui/tui-hooks.c: Don't include readline.h.
1845         * symmisc.c: Include tilde.h, not readline.h.
1846         * symfile.c: Include tilde.h, not readline.h.
1847         * source.c: Include tilde.h, not readline.h.
1848         * solib.c: Include tilde.h, not readline.h.
1849         * psymtab.c: Include tilde.h, not readline.h.
1850         * exec.c: Include tilde.h, not readline.h.
1851         * corelow.c: Include tilde.h, not readline.h.
1852         * cli/cli-dump.c: Include tilde.h, not readline.h.
1853         * cli/cli-cmds.c: Don't include readline.h.
1854
1855 2019-11-05  Tom Tromey  <tom@tromey.com>
1856
1857         * tui/tui-disasm.c (struct tui_asm_line) <addr_size>: New member.
1858         (tui_disassemble): Set addr_size.
1859         (tui_disasm_window::set_contents): Use addr_size.
1860
1861 2019-11-05  Tom Tromey  <tom@tromey.com>
1862
1863         * rust-lang.c (rust_language_defn): Update.
1864         * python/py-value.c (valpy_string): Call c_get_string.
1865         * p-lang.c (pascal_language_defn): Update.
1866         * opencl-lang.c (opencl_language_defn): Update.
1867         * objc-lang.c (objc_language_defn): Update.
1868         * m2-lang.c (m2_language_defn): Update.
1869         * language.c (unknown_language_defn, auto_language_defn): Update.
1870         (default_get_string): Remove.
1871         * guile/scm-value.c (gdbscm_value_to_string): Use c_get_string.
1872         * go-lang.c (go_language_defn): Update.
1873         * f-lang.c (f_language_defn): Update.
1874         * d-lang.c (d_language_defn): Update.
1875         * c-lang.c (c_language_defn, cplus_language_defn)
1876         (asm_language_defn, minimal_language_defn): Update.
1877         * ada-lang.c (ada_language_defn): Update.
1878         * language.h (struct language_defn) <la_get_string>: Remove.
1879         (LA_GET_STRING): Remove.
1880         (default_get_string): Don't declare.
1881
1882 2019-11-05  Tom Tromey  <tom@tromey.com>
1883
1884         * tui/tui-source.h (struct tui_source_window): Inline
1885         constructor.  Remove destructor.
1886         <style_changed, m_observable>: Move to superclass.
1887         * tui/tui-winsource.h (tui_copy_source_line): Declare.
1888         (struct tui_source_window_base): Move private members to end.
1889         <style_changed, m_observable>: Move from tui_source_window.
1890         * tui/tui-winsource.c (tui_copy_source_line): Move from
1891         tui-source.c.  Rename from copy_source_line.  Add special handling
1892         for negative line number.
1893         (tui_source_window_base::style_changed): Move from
1894         tui_source_window.
1895         (tui_source_window_base): Register observer.
1896         (~tui_source_window_base): New.
1897         * tui/tui-source.c (copy_source_line): Move to tui-winsource.c;
1898         rename.
1899         (tui_source_window::set_contents): Use tui_copy_source_line.
1900         (tui_source_window::tui_source_window): Move to tui-source.h.
1901         (tui_source_window::~tui_source_window): Remove.
1902         (tui_source_window::style_changed): Move to superclass.
1903         * tui/tui-disasm.c (tui_disassemble): Create string file with
1904         styling, when possible.  Add "addr_size" parameter.
1905         (tui_disasm_window::set_contents): Use tui_copy_source_line.
1906         Don't compute maximum size.
1907         (len_without_escapes): New function
1908
1909 2019-11-05  Tom Tromey  <tom@tromey.com>
1910
1911         * tui/tui-winsource.h (struct tui_source_element) <line>: Now a
1912         std::string.
1913         * tui/tui-winsource.c (tui_show_source_line): Update.
1914         * tui/tui-source.c (tui_source_window::set_contents): Update.
1915         * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
1916
1917 2019-11-05  Christian Biesinger  <cbiesinger@google.com>
1918
1919         * symtab.h (gdb_static_assert): Put && operator at the beginning
1920         of the line instead of the end.
1921
1922 2019-11-04  Christian Biesinger  <cbiesinger@google.com>
1923
1924         * psympriv.h: Add static_asserts for sizeof (general_symbol_info)
1925         and sizeof (symbol).
1926         * symtab.h: Add a static_assert for sizeof (partial_symbol).
1927
1928 2019-11-04  Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
1929
1930         * NEWS (Changes since GDB 8.3): Document Solaris 10 removal.
1931         * configure.host: Mark *-*-solaris2.10* obsolete.
1932         * configure.tgt: Mark Solaris < 11 obsolete.
1933         * MAINTAINERS (Target Instruction Set Architectures) <sparc>:
1934         Update target triplet.
1935
1936 2019-11-01  Tom Tromey  <tromey@adacore.com>
1937
1938         * utils.c (print_sys_errmsg): Simplify.
1939
1940 2019-11-01  Tom Tromey  <tromey@adacore.com>
1941
1942         * gdbsupport/mingw-strerror.c (safe_strerror): Constify result.
1943
1944 2019-11-01  Christian Biesinger  <cbiesinger@google.com>
1945
1946         * configure: Regenerate.
1947         * configure.ac: Remove check for strerror_r.
1948         * gdbsupport/common.m4: Check for strerror_r.
1949
1950 2019-11-01  Luis Machado  <luis.machado@linaro.org>
1951
1952         PR gdb/25124
1953
1954         * arm-tdep.c (arm_per_objfile): Rename to ...
1955         (arm_per_bfd): ... this.
1956         (arm_objfile_data_key): Rename to ...
1957         (arm_bfd_data_key): ... this.
1958         (arm_find_mapping_symbol): Adjust access to new bfd_key-based
1959         data.
1960         (arm_record_special_symbol): Likewise.
1961
1962 2019-10-31  Andrew Burgess  <andrew.burgess@embecosm.com>
1963
1964         * ada-typeprint.c (ada_print_typedef): Don't print newline at the
1965         end.
1966         * c-typeprint.c (c_print_typedef): Likewise.
1967         * f-typeprint.c (f_print_typedef): Likewise.
1968         * m2-typeprint.c (m2_print_typedef): Likewise.
1969         * p-typeprint.c (pascal_print_typedef): Likewise.
1970         * rust-lang.c (rust_print_typedef): Likewise.
1971         * symtab.c (print_symbol_info): Print a newline after calling
1972         typedef_print.
1973
1974 2019-10-31  Andrew Burgess  <andrew.burgess@embecosm.com>
1975
1976         * symtab.c (info_module_cmdlist): New variable.
1977         (info_module_command): New function.
1978         (search_module_symbols): New function.
1979         (info_module_subcommand): New function.
1980         (struct info_modules_var_func_options): New struct.
1981         (info_modules_var_func_options_defs): New variable.
1982         (make_info_modules_var_func_options_def_group): New function.
1983         (info_module_functions_command): New function.
1984         (info_module_variables_command): New function.
1985         (info_module_var_func_command_completer): New function.
1986         (_initialize_symtab): Register new 'info module functions' and
1987         'info module variables' commands.
1988         * symtab.h (typedef symbol_search_in_module): New typedef.
1989         (search_module_symbols): Declare new function.
1990         * NEWS: Mention new commands.
1991
1992 2019-10-31  Andrew Burgess  <andrew.burgess@embecosm.com>
1993
1994         * dwarf2read.c (dw2_symtab_iter_next): Handle MODULE_DOMAIN.
1995         (dw2_expand_marked_cus): Handle MODULES_DOMAIN.
1996         (dw2_debug_names_iterator::next): Handle MODULE_DOMAIN and
1997         MODULES_DOMAIN.
1998         (scan_partial_symbols): Only create partial module symbols for non
1999         declarations.
2000         * psymtab.c (recursively_search_psymtabs): Handle MODULE_DOMAIN
2001         and MODULES_DOMAIN.
2002         * symtab.c (search_domain_name): Likewise.
2003         (search_symbols): Likewise.
2004         (print_symbol_info): Likewise.
2005         (symtab_symbol_info): Likewise.
2006         (info_modules_command): New function.
2007         (_initialize_symtab): Register 'info modules' command.
2008         * symtab.h (enum search_domain): Add MODULES_DOMAIN.
2009         * NEWS: Mention new 'info modules' command.
2010
2011 2019-10-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2012
2013         * NEWS: Mention $_gdb_setting, $_gdb_setting_str, $_gdb_maint_setting
2014         and $_gdb_maint_setting_str.
2015
2016 2019-10-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2017
2018         * cli/cli-cmds.c (setting_cmd, value_from_setting)
2019         (gdb_setting_internal_fn, gdb_maint_setting_internal_fn)
2020         (str_value_from_setting, gdb_setting_str_internal_fn)
2021         (gdb_maint_setting_str_internal_fn): New functions.
2022         (_initialize_cli_cmds): Define the new convenience functions.
2023         * gdb/cli/cli-setshow.h (get_setshow_command_value_string): Constify.
2024         * gdb/cli/cli-setshow.c (get_setshow_command_value_string): Constify.
2025
2026 2019-10-31  Christian Biesinger  <cbiesinger@google.com>
2027
2028         * agent.c (set_can_use_agent): When the setting is turned on,
2029         look up agent symbols if we don't have them yet.
2030         (agent_new_objfile): Don't look up agent symbols when the agent
2031         setting is off.
2032
2033 2019-10-31  Christian Biesinger  <cbiesinger@google.com>
2034
2035         * config.in: Regenerate.
2036
2037 2019-10-31  Christian Biesinger  <cbiesinger@google.com>
2038
2039         * configure: Regenerate.
2040         * configure.ac: Check for strerror_r.
2041         * gdbsupport/common-utils.h (safe_strerror): Change return value
2042         to const char * and document that this function is now threadsafe.
2043         * gdbsupport/posix-strerror.c (safe_strerror): Make buf
2044         thread_local and call strerror_r, if available.
2045         * utils.c (perror_string): Update.
2046         (print_sys_errmsg): Update.
2047
2048 2019-10-31  Luis Machado  <luis.machado@linaro.org>
2049
2050         * arm-tdep.c (arm_exidx_data_key): Use bfd_key instead of
2051         objfile_key.
2052         (arm_exidx_new_objfile): Adjust to use objfile->obfd instead of
2053         objfile to fetch per-bfd data.
2054         (arm_find_exidx_entry): Likewise.
2055
2056 2019-10-31  Christian Biesinger  <cbiesinger@google.com>
2057
2058         * gdbsupport/agent.c (debug_agent): Change type to bool.
2059         (use_agent): Likewise.
2060         (all_agent_symbols_look_up): Likewise.
2061         (agent_loaded_p): Change return value to bool.
2062         (agent_look_up_symbols): Update.
2063         (agent_capability_check): Change return value to bool.
2064         * gdbsupport/agent.h (agent_loaded_p): Likewise.
2065         (debug_agent): Change type to bool.
2066         (use_agent): Likewise.
2067         (agent_capability_check): Change return value to bool.
2068
2069 2019-10-30  Christian Biesinger  <cbiesinger@google.com>
2070
2071         * minsyms.c (clear_minimal_symbol_hash_tables): New function.
2072         (build_minimal_symbol_hash_tables): Code to clear the table moved
2073         to clear_minimal_symbol_hash_tables.
2074         (minimal_symbol_reader::install): Call clear_minimal_symbol_hash_tables
2075         when needed.
2076
2077 2019-10-29  Simon Marchi  <simon.marchi@polymtl.ca>
2078
2079         * infcmd.c: Remove includes.
2080         * infrun.c: Remove includes.
2081
2082 2019-10-29  Simon Marchi  <simon.marchi@polymtl.ca>
2083
2084         * ada-lang.h (GROW_VECT): Move to ada-lang.c.
2085         (grow_vect): Remove declaration.
2086         (ada_type_of_array): Remove declaration.
2087         (ada_update_initial_language): Remove declaration.
2088         (ada_fold_name): Remove declaration.
2089         (ada_fill_in_ada_prototype): Remove declaration.
2090         (user_select_syms): Remove declaration.
2091         (get_selections): Remove declaration.
2092         (ada_tag_type): Remove declaration.
2093         (ada_value_tag): Remove declaration.
2094         (ada_is_others_clause): Remove declaration.
2095         (ada_in_variant): Remove declaration.
2096         (ada_value_struct_elt): Remove declaration.
2097         (ada_attribute_name): Remove declaration.
2098         (ada_system_address_type): Remove declaration.
2099         * ada-lang.c (ada_watch_location_expression): Make static.
2100         (GROW_VECT): Move here from ada-lang.h.
2101         (grow_vect): Make static.
2102         (ada_update_initial_language): Make static.
2103         (ada_fold_name): Make static.
2104         (ada_type_of_array): Make static.
2105         (encoded_ordered_before): Move up.
2106         (sort_choices): Move up.
2107         (print_signatures): Move up.
2108         (ada_print_symbol_signature): Move up.
2109         (get_selections): Move up and make static.
2110         (user_select_syms): Move up and make static.
2111         (ada_value_struct_elt): Move up and make static.
2112         (ada_tag_type): Make static.
2113         (ada_value_tag): Make static.
2114         (ada_is_others_clause): Make static.
2115         (ada_in_variant): Make static.
2116         (ada_attribute_name): Make static.
2117
2118 2019-10-29  Simon Marchi  <simon.marchi@polymtl.ca>
2119
2120         * ada-lang.c: Remove includes.
2121         * ada-typeprint.c: Remove includes.
2122         * ada-valprint.c: Remove includes.
2123
2124 2019-10-29  Simon Marchi  <simon.marchi@efficios.com>
2125
2126         * addrmap.c: Add static assertions of type size, moved from
2127         _initialize_addrmap.
2128         (_initialize_addrmap): Remove.
2129
2130 2019-10-29  Christian Biesinger  <cbiesinger@google.com>
2131
2132         * coffread.c (record_minimal_symbol): Update.
2133         (process_coff_symbol): Update.
2134         * dbxread.c (read_dbx_symtab): Update.
2135         * dwarf2read.c (add_partial_symbol): Update.
2136         (fixup_go_packaging): Update.
2137         (load_partial_dies): Update.
2138         (new_symbol): Update.
2139         * elfread.c (record_minimal_symbol): Change signature to use
2140         gdb::string_view instead of name+len.
2141         (elf_symtab_read): Update.
2142         (elf_rel_plt_read): Update.
2143         * mdebugread.c (parse_partial_symbols): Update.
2144         (handle_psymbol_enumerators): Update.
2145         (new_symbol): Update.
2146         * minsyms.c (minimal_symbol_reader::record_full): Change signature
2147         to use gdb::string_view instead of name+len.
2148         * minsyms.h (class minimal_symbol_reader) <record_full>: Likewise.
2149         * psympriv.h (add_psymbol_to_list): Likewise.
2150         * psymtab.c (add_psymbol_to_bcache): Likewise.
2151         (add_psymbol_to_list): Likewise.
2152         * stabsread.c (define_symbol): Update.
2153         * symtab.c (symbol_set_names): Change signature to use gdb::string_view.
2154         * symtab.h (SYMBOL_SET_NAMES): Likewise.
2155         (symbol_set_names): Likewise.
2156         * xcoffread.c (scan_xcoff_symtab): Update.
2157
2158 2019-10-29  Christian Biesinger  <cbiesinger@google.com>
2159
2160         * symtab.h (symbol_set_names): Document that copy_name must be
2161         set to true for non-nullterminated strings.
2162         * symtab.c (symbol_set_names): Only make a nullterminated copy of
2163         linkage_name if the entry was not found and we need to demangle.
2164
2165 2019-10-29  Christian Biesinger  <cbiesinger@google.com>
2166
2167         * Makefile.in (HFILES_NO_SRCDIR): Add gdb_binary_search.h.
2168         * dwarf2-frame.c (bsearch_fde_cmp): Update.
2169         (dwarf2_frame_find_fde): Replace bsearch with gdb::binary_search.
2170         * gdbsupport/gdb_binary_search.h: New file.
2171
2172 2019-10-29  Christian Biesinger  <cbiesinger@google.com>
2173
2174         * NEWS: Mention new --with-system-gdbinit-dir option.
2175         * config.in: Regenerate.
2176         * configure: Regenerate.
2177         * configure.ac: Add new option --with-system-gdbinit-dir.
2178         * extension.c (get_ext_lang_of_file): Return extension_language_gdb
2179         for a ".gdb" suffix.
2180         * main.c (get_init_files): Change system_gdbinit argument to
2181         a vector and return the files in SYSTEM_GDBINIT_DIR in
2182         addition to SYSTEM_GDBINIT.
2183         (captured_main_1): Update.
2184         (print_gdb_help): Update.
2185         * top.c (print_gdb_configuration): Also print the value of
2186         SYSTEM_GDBINIT_DIR.
2187
2188 2019-10-28  Christian Biesinger  <cbiesinger@google.com>
2189
2190         * gdbsupport/common-utils.h (startswith): Add an overloaded version
2191         that takes gdb::string_view arguments.
2192
2193 2019-10-26  Tom de Vries  <tdevries@suse.de>
2194
2195         * aarch64-linux-tdep.c: Fix typos in comments.
2196         * aarch64-tdep.c: Same.
2197         * ada-lang.c: Same.
2198         * amd64-nat.c: Same.
2199         * arc-tdep.c: Same.
2200         * arch/aarch64-insn.c: Same.
2201         * block.c: Same.
2202         * breakpoint.h: Same.
2203         * btrace.h: Same.
2204         * c-varobj.c: Same.
2205         * cli/cli-decode.c: Same.
2206         * cli/cli-script.c: Same.
2207         * cli/cli-utils.h: Same.
2208         * coff-pe-read.c: Same.
2209         * coffread.c: Same.
2210         * compile/compile-cplus-symbols.c: Same.
2211         * compile/compile-object-run.c: Same.
2212         * completer.c: Same.
2213         * corelow.c: Same.
2214         * cp-support.c: Same.
2215         * demangle.c: Same.
2216         * dwarf-index-write.c: Same.
2217         * dwarf2-frame.c: Same.
2218         * dwarf2-frame.h: Same.
2219         * eval.c: Same.
2220         * frame-base.h: Same.
2221         * frame.h: Same.
2222         * gdbcmd.h: Same.
2223         * gdbtypes.h: Same.
2224         * gnu-nat.c: Same.
2225         * guile/scm-objfile.c: Same.
2226         * i386-tdep.c: Same.
2227         * i386-tdep.h: Same.
2228         * infcall.c: Same.
2229         * infcall.h: Same.
2230         * linux-nat.c: Same.
2231         * m68k-tdep.c: Same.
2232         * macroexp.c: Same.
2233         * memattr.c: Same.
2234         * mi/mi-cmd-disas.c: Same.
2235         * mi/mi-getopt.h: Same.
2236         * mi/mi-main.c: Same.
2237         * minsyms.c: Same.
2238         * nat/aarch64-sve-linux-sigcontext.h: Same.
2239         * objfiles.h: Same.
2240         * ppc-linux-nat.c: Same.
2241         * ppc-linux-tdep.c: Same.
2242         * ppc-tdep.h: Same.
2243         * progspace.h: Same.
2244         * prologue-value.h: Same.
2245         * python/py-evtregistry.c: Same.
2246         * python/py-instruction.h: Same.
2247         * record-btrace.c: Same.
2248         * record-full.c: Same.
2249         * remote.c: Same.
2250         * rs6000-tdep.c: Same.
2251         * ser-tcp.c: Same.
2252         * sol-thread.c: Same.
2253         * sparc-sol2-tdep.c: Same.
2254         * sparc64-tdep.c: Same.
2255         * stabsread.c: Same.
2256         * symfile.c: Same.
2257         * symtab.h: Same.
2258         * target.c: Same.
2259         * tracepoint.c: Same.
2260         * tui/tui-data.h: Same.
2261         * tui/tui-io.c: Same.
2262         * tui/tui-win.c: Same.
2263         * tui/tui.c: Same.
2264         * unittests/rsp-low-selftests.c: Same.
2265         * user-regs.h: Same.
2266         * utils.c: Same.
2267         * utils.h: Same.
2268         * valarith.c: Same.
2269         * valops.c: Same.
2270         * valprint.c: Same.
2271         * valprint.h: Same.
2272         * value.c: Same.
2273         * value.h: Same.
2274         * varobj.c: Same.
2275         * x86-nat.h: Same.
2276         * xtensa-tdep.c: Same.
2277
2278 2019-10-25  Ali Tamur <tamur@google.com>
2279
2280         * charset.c (find_charset_names): Reflect API change.
2281
2282 2019-10-25  Christian Biesinger  <cbiesinger@google.com>
2283
2284         * symtab.c (struct demangled_name_entry): Change demangled name
2285         to a unique_xmalloc_ptr<char>, now that we don't allocate it as
2286         part of the struct anymore.
2287         (symbol_set_names): No longer obstack allocate + copy the demangled
2288         name, just store the allocated name from bfd.
2289
2290 2019-10-25  Tom Tromey  <tromey@adacore.com>
2291
2292         * dwarf2-frame.c (dwarf2_cie_table): Now a typedef.
2293         (bsearch_cie_cmp, add_cie): Remove.
2294         (find_cie): Reimplement.
2295         (decode_frame_entry_1, decode_frame_entry): Change type.  Update.
2296         (dwarf2_build_frame_info): Update.
2297
2298 2019-10-24  H.J. Lu  <hongjiu.lu@intel.com>
2299
2300         PR gdb/25126
2301         * symfile.c (reread_symbols): Call forget_cached_source_info to
2302         clear the stale source cache.
2303
2304 2019-10-24  Christian Biesinger  <cbiesinger@google.com>
2305
2306         * configure: Regenerate.
2307         * configure.ac: Remove code that sets python_has_threads.
2308
2309 2019-10-24  Christian Biesinger  <cbiesinger@google.com>
2310
2311         * config.in: Regenerate.
2312         * configure: Regenerate.
2313         * configure.ac: Remove the code that uses sed to get the python
2314         version and defines HAVE_LIBPYTHON2_6 / HAVE_LIBPYTHON2_7.
2315
2316 2019-10-24  Andrew Burgess  <andrew.burgess@embecosm.com>
2317
2318         * python/py-progspace.c (pspy_block_for_pc): Return None for all
2319         error paths.
2320
2321 2019-10-23  Tom Tromey  <tom@tromey.com>
2322
2323         * arc-tdep.c: Remove ".." from include.
2324         * frv-tdep.c: Remove ".." from include.
2325         * lm32-tdep.c: Remove ".." from include.
2326         * microblaze-tdep.c: Remove ".." from include.
2327         * or1k-tdep.h: Remove ".." from include.
2328         * s12z-tdep.c: Remove ".." from include.
2329         * Makefile.in (OPCODES_CFLAGS): Add comment.
2330         (TOP_CFLAGS): New variable.
2331         (INTERNAL_CFLAGS_BASE): Add TOP_CFLAGS.
2332
2333 2019-10-23  Tom Tromey  <tom@tromey.com>
2334
2335         * Makefile.in (READLINE_DIR): Update.
2336
2337 2019-10-23  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
2338
2339         * infcall.c (call_function_by_hand_dummy): Fix the function
2340         comment.  And extract out a code section into...
2341         (reserve_stack_space): ...this new function.
2342
2343 2019-10-23  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
2344
2345         * infcall.c (value_arg_coerce): Remove an unused parameter.
2346         (call_function_by_hand_dummy): Update the call to
2347         'value_arg_coerce'.
2348
2349 2019-10-23  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
2350
2351         * infcall.c (call_function_by_hand_dummy): Refactor.
2352
2353 2019-10-23  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
2354
2355         * MAINTAINERS (Write After Approval): Add Tankut Baris Aktemur.
2356
2357 2019-10-23  Tom Tromey  <tom@tromey.com>
2358
2359         * configure: Rebuild.
2360         * configure.ac: Don't check for sigprocmask.
2361         * gdbsupport/common.m4 (GDB_AC_COMMON): Check for sigprocmask.
2362
2363 2019-10-23  Tom Tromey  <tom@tromey.com>
2364
2365         * configure: Rebuild.
2366         * acinclude.m4: Use m4_include, not sinclude.
2367
2368 2019-10-23  Tom de Vries  <tdevries@suse.de>
2369
2370         PR breakpoints/24687
2371         * symtab.c (iterate_over_some_symtabs): Apply gdb_realpath on fullname.
2372
2373 2019-10-22  Christian Biesinger  <cbiesinger@google.com>
2374
2375         * symtab.c (struct demangled_name_entry) <language>: Change from
2376         bitfield to regular variable.
2377
2378 2019-10-22  Christian Biesinger  <cbiesinger@google.com>
2379
2380         * symtab.c (struct demangled_name_entry): Add a constructor.
2381         (free_demangled_name_entry): New function to call the destructor
2382         for demangled_name_entry.
2383         (create_demangled_names_hash): Pass free_demangled_name_entry to
2384         htab_create_alloc.
2385         (symbol_set_names): Call placement new for demangled_name_entry.
2386         * utils.c: No longer include xxhash.h here, now that fast_hash
2387         is inlined in the header.
2388         * utils.h: Instead, include it here.
2389
2390 2019-10-22  Christian Biesinger  <cbiesinger@google.com>
2391
2392         * Makefile.in: Link with libxxhash.
2393         * config.in: Regenerate.
2394         * configure: Regenerate.
2395         * configure.ac: Search for libxxhash.
2396         * utils.c (fast_hash): Use xxhash if present.
2397
2398 2019-10-22  Christian Biesinger  <cbiesinger@google.com>
2399
2400         * utils.h (fast_hash): New function.
2401         * symtab.c (hash_demangled_name_entry): Call new function
2402         fast_hash.
2403
2404 2019-10-22  Christian Biesinger  <cbiesinger@google.com>
2405
2406         * symtab.c (struct demangled_name_entry): Change type of mangled
2407         to gdb::string_view. Also adds a constructor that takes the
2408         mangled name.
2409         (hash_demangled_name_entry): Update.
2410         (eq_demangled_name_entry): Update.
2411         (free_demangled_name_entry): New function to call the destructor
2412         now that this is not a POD anymore.
2413         (create_demangled_names_hash): Pass free_demangled_name_entry to
2414         htab_create_alloc.
2415         (symbol_set_names): Update.
2416
2417 2019-10-21  Ali Tamur  <tamu@google.com>
2418
2419         * dwarf2read.c (dir_index): Change type.
2420         (file_name_index): Likewise.
2421         (line_header::include_dir_at): Change comment and implementation on
2422         whether it is DWARF 5.
2423         (line_header::is_valid_file_index): New function.
2424         (line_header::file_name_at): Change comment and implementation on
2425         whether it is DWARF 5.
2426         (line_header::file_names): Change to private field renamed as
2427         m_file_names and introduce a new accessor method.
2428         (line_header::file_names_size): New method.
2429         (line_header::include_dirs): Change to private field and rename as
2430         m_include_dirs.
2431         (dw2_get_file_names_reader): Define local var at a smaller scope and
2432         reflect API change.
2433         (dwarf2_cu::setup_type_unit_groups): Reflect API change.
2434         (process_structure_scope): Likewise.
2435         (line_header::add_include_dir): Change message and reflect renaming.
2436         (line_header::add_file_name): Likewise.
2437         (read_formatted_entries): Handle DW_FORM_data16.
2438         (dwarf_decode_line_header): Fix line header length calculation.
2439         (psymtab_include_file_name): Change comment and API.
2440         (lnp_state_machine::m_file): Update comment and reflect type change.
2441         (lnp_state_machine::record_line): Reflect type change.
2442         (dwarf_decode_lines): Reflect API change.
2443         (file_file_name): Likewise.
2444         (file_full_name): Likewise.
2445
2446 2019-10-21  Andrew Burgess  <andrew.burgess@embecosm.com>
2447
2448         * objfiles.c (sort_cmp): Ensure that !(a < a) holds true.
2449
2450 2019-10-21  Tom Tromey  <tom@tromey.com>
2451
2452         * tui/tui-winsource.h (tui_exec_info_content): Remove typedef.
2453
2454 2019-10-21  Tom Tromey  <tom@tromey.com>
2455
2456         * configure.ac (nm.h): Conditionally create nm.h link.  Subst
2457         NM_H.   Use AC_CONFIG_LINKS.
2458         * configure: Rebuild.
2459         * Makefile.in (NM_H): New variable.
2460         (generated_files): Add NM_H.  Remove gcore.
2461         (nm.h, stamp-nmh): New targets.
2462
2463 2019-10-20  Tom Tromey  <tom@tromey.com>
2464
2465         * objfiles.h (unlink_objfile, put_objfile_before): Don't declare.
2466         * objfiles.c (unlink_objfile): Move earlier.  Now static.  Remove
2467         obsolete comment.
2468         (put_objfile_before): Now static.
2469
2470 2019-10-19  Simon Marchi  <simon.marchi@polymtl.ca>
2471
2472         * gdbsupport/common-utils.h (startswith): Change return type to
2473         bool.
2474
2475 2019-10-19  Christian Biesinger  <cbiesinger@google.com>
2476
2477         * bcache.c (bcache::print_statistics): Use std::sort instead of qsort.
2478         * breakpoint.c (bp_locations_compare): Rename to...
2479         (bp_location_is_less_than): ...this, and change to std::sort semantics.
2480         (update_global_location_list): Use std::sort instead of qsort.
2481         * buildsym.c (compare_line_numbers): Rename to...
2482         (lte_is_less_than): ...this, and change to std::sort semantics.
2483         (buildsym_compunit::end_symtab_with_blockvector): Use std::sort
2484         instead of qsort.
2485         * disasm.c (compare_lines): Rename to...
2486         (line_is_less_than): ...this, and change to std::sort semantics.
2487         (do_mixed_source_and_assembly_deprecated): Call std::sort instead
2488         of qsort.
2489         * dwarf2-frame.c (qsort_fde_cmp): Rename to...
2490         (fde_is_less_than): ...this, and change to std::sort semantics.
2491         (dwarf2_build_frame_info): Call std::sort instead of qsort.
2492         * mdebugread.c (compare_blocks):
2493         (block_is_less_than): ...this, and change to std::sort semantics.
2494         (sort_blocks): Call std::sort instead of qsort.
2495         * objfiles.c (qsort_cmp): Rename to...
2496         (sort_cmp): ...this, and change to std::sort semantics.
2497         (update_section_map): Call std::sort instead of qsort.
2498         * remote.c (compare_pnums): Remove.
2499         (map_regcache_remote_table): Call std::sort instead of qsort.
2500         * utils.c (compare_positive_ints): Remove.
2501         * utils.h (compare_positive_ints): Remove.
2502         * xcoffread.c (compare_lte): Remove.
2503         (arrange_linetable): Call std::sort instead of qsort.
2504
2505 2019-10-19  Sergio Durigan Junior  <sergiodj@redhat.com>
2506
2507         * symfile.c (init_entry_point_info): Fix typo.
2508         * i386-darwin-tdep.c (darwin_dwarf_signal_frame_p): Fix typo.
2509
2510 2019-10-18  Tom de Vries  <tdevries@suse.de>
2511
2512         * aarch64-tdep.c: Fix typos in comments.
2513         * ada-lang.c: Same.
2514         * ada-tasks.c: Same.
2515         * alpha-tdep.c: Same.
2516         * alpha-tdep.h: Same.
2517         * amd64-nat.c: Same.
2518         * amd64-windows-tdep.c: Same.
2519         * arc-tdep.c: Same.
2520         * arc-tdep.h: Same.
2521         * arch-utils.c: Same.
2522         * arm-nbsd-tdep.c: Same.
2523         * arm-tdep.c: Same.
2524         * ax-gdb.c: Same.
2525         * blockframe.c: Same.
2526         * btrace.c: Same.
2527         * c-varobj.c: Same.
2528         * coff-pe-read.c: Same.
2529         * coffread.c: Same.
2530         * cris-tdep.c: Same.
2531         * darwin-nat.c: Same.
2532         * dbxread.c: Same.
2533         * dcache.c: Same.
2534         * disasm.c: Same.
2535         * dtrace-probe.c: Same.
2536         * dwarf-index-write.c: Same.
2537         * dwarf2-frame-tailcall.c: Same.
2538         * dwarf2-frame.c: Same.
2539         * dwarf2read.c: Same.
2540         * eval.c: Same.
2541         * exceptions.c: Same.
2542         * fbsd-tdep.c: Same.
2543         * findvar.c: Same.
2544         * frame.c: Same.
2545         * frv-tdep.c: Same.
2546         * gnu-v3-abi.c: Same.
2547         * go32-nat.c: Same.
2548         * h8300-tdep.c: Same.
2549         * hppa-tdep.c: Same.
2550         * i386-linux-tdep.c: Same.
2551         * i386-tdep.c: Same.
2552         * ia64-libunwind-tdep.c: Same.
2553         * ia64-tdep.c: Same.
2554         * infcmd.c: Same.
2555         * infrun.c: Same.
2556         * linespec.c: Same.
2557         * linux-nat.c: Same.
2558         * linux-thread-db.c: Same.
2559         * machoread.c: Same.
2560         * mdebugread.c: Same.
2561         * mep-tdep.c: Same.
2562         * mn10300-tdep.c: Same.
2563         * namespace.c: Same.
2564         * objfiles.c: Same.
2565         * opencl-lang.c: Same.
2566         * or1k-tdep.c: Same.
2567         * osabi.c: Same.
2568         * ppc-linux-nat.c: Same.
2569         * ppc-linux-tdep.c: Same.
2570         * ppc-sysv-tdep.c: Same.
2571         * printcmd.c: Same.
2572         * procfs.c: Same.
2573         * record-btrace.c: Same.
2574         * record-full.c: Same.
2575         * remote-fileio.c: Same.
2576         * remote.c: Same.
2577         * rs6000-tdep.c: Same.
2578         * s12z-tdep.c: Same.
2579         * score-tdep.c: Same.
2580         * ser-base.c: Same.
2581         * ser-go32.c: Same.
2582         * skip.c: Same.
2583         * sol-thread.c: Same.
2584         * solib-svr4.c: Same.
2585         * solib.c: Same.
2586         * source.c: Same.
2587         * sparc-nat.c: Same.
2588         * sparc-sol2-tdep.c: Same.
2589         * sparc-tdep.c: Same.
2590         * sparc64-tdep.c: Same.
2591         * stabsread.c: Same.
2592         * stack.c: Same.
2593         * symfile.c: Same.
2594         * symtab.c: Same.
2595         * target-descriptions.c: Same.
2596         * target-float.c: Same.
2597         * thread.c: Same.
2598         * utils.c: Same.
2599         * valops.c: Same.
2600         * valprint.c: Same.
2601         * value.c: Same.
2602         * varobj.c: Same.
2603         * windows-nat.c: Same.
2604         * xcoffread.c: Same.
2605         * xstormy16-tdep.c: Same.
2606         * xtensa-tdep.c: Same.
2607
2608 2019-10-17  Tom Tromey  <tromey@adacore.com>
2609
2610         * configure: Rebuild.
2611         * configure.ac: Use AC_CONFIG_HEADERS.  Create stamp-h there, not
2612         in AC_CONFIG_FILES invocation.
2613         * Makefile.in (Makefile, data-directory/Makefile, stamp-h): Use
2614         new-style config.status invocation.
2615
2616 2019-10-17  Tom de Vries  <tdevries@suse.de>
2617
2618         * arm-nbsd-nat.c: Fix typos in comments.
2619         * arm-tdep.c: Same.
2620         * darwin-nat-info.c: Same.
2621         * dwarf2read.c: Same.
2622         * elfread.c: Same.
2623         * event-top.c: Same.
2624         * findvar.c: Same.
2625         * gdbtypes.c: Same.
2626         * hppa-tdep.c: Same.
2627         * i386-tdep.c: Same.
2628         * jit.c: Same.
2629         * main.c: Same.
2630         * mdebugread.c: Same.
2631         * moxie-tdep.c: Same.
2632         * nto-procfs.c: Same.
2633         * osabi.c: Same.
2634         * ppc-linux-tdep.c: Same.
2635         * remote.c: Same.
2636         * riscv-tdep.c: Same.
2637         * s390-tdep.c: Same.
2638         * sh-tdep.c: Same.
2639         * sparc-linux-tdep.c: Same.
2640         * sparc-nat.c: Same.
2641         * stack.c: Same.
2642         * target-descriptions.c: Same.
2643         * top.c: Same.
2644         * varobj.c: Same.
2645
2646 2019-10-16  Tom Tromey  <tom@tromey.com>
2647
2648         * objfiles.h (struct objfile) <original_name>: Now const.
2649
2650 2019-10-16  Christian Biesinger  <cbiesinger@google.com>
2651
2652         * gdbsupport/gdb_setjmp.h (SIGSETJMP): Allow passing in the value to
2653         pass on to sigsetjmp's second argument.
2654         * cp-support.c (gdb_demangle): Unblock SIGSEGV if we caught a crash.
2655
2656 2019-10-16  Keith Seitz  <keiths@redhat.com>
2657
2658         PR gdb/23567
2659         * dwarf2read.c (dwarf2_per_objfile::locate_sections): Discard
2660         sections whose size is greater than the file size.
2661
2662 2019-10-16  Jim Wilson  <jimw@sifive.com>
2663
2664         * riscv-tdep.c (riscv_gcc_target_options): New.
2665         (riscv_gnu_triplet_regexp): New.
2666         (riscv_gdbarch_init): Call set_gdbarch_gcc_triplet_options and
2667         set_gdbarch_gnu_triplet_regexp.
2668
2669 2019-10-16  Christian Biesinger  <cbiesinger@google.com>
2670
2671         * Makefile.in: Add xml-builtin.h.
2672         * features/feature_to_c.sh: Add an include for xml-builtin.h
2673         to ensure that the compiler checks that the types match.
2674         * xml-builtin.h: New file.
2675         * xml-support.c (fetch_xml_builtin): Add missing const.
2676         * xml-support.h: Remove declaration of xml_builtins.
2677
2678 2019-10-16  Tom de Vries  <tdevries@suse.de>
2679
2680         PR tdep/25096
2681         * amd64-tdep.c (amd64_classify_aggregate_field): Factor out of ...
2682         (amd64_classify_aggregate): ... here.
2683         (amd64_classify_aggregate_field): Handled fiels of nested structs
2684         recursively.
2685
2686 2019-10-16  Tom de Vries  <tdevries@suse.de>
2687
2688         PR tdep/24104
2689         * amd64-tdep.c (amd64_push_arguments): Handle AMD64_NO_CLASS in loop
2690         that handles 'theclass'.
2691
2692 2019-10-15  Andrew Burgess  <andrew.burgess@embecosm.com>
2693
2694         * linespec.c (decode_digits_ordinary): Update comment.
2695         * make-target-delegates: No longer need to handle VEC case.
2696         * memrange.c (normalize_mem_ranges): Update comment.
2697         * namespace.c (add_using_directive): Update comment.
2698         * objc-lang.c (uniquify_strings): Update comment.
2699         * ppc-linux-nat.c (struct thread_points): Update comment.
2700         * probe.h (find_probes_in_objfile): Update comment.
2701         * target.h (enum flash_preserve_mode): Update comment.
2702         * varobj.c (varobj_restrict_range): Update comment.
2703         * varobj.h (varobj_list_children): Update comment.
2704
2705 2019-10-15  Andrew Burgess  <andrew.burgess@embecosm.com>
2706
2707         * Makefile.in: Remove references to vec.h and vec.c.
2708         * aarch64-tdep.c: No longer include vec.h.
2709         * ada-lang.c: Likewise.
2710         * ada-lang.h: Likewise.
2711         * arm-tdep.c: Likewise.
2712         * ax.h: Likewise.
2713         * breakpoint.h: Likewise.
2714         * charset.c: Likewise.
2715         * cp-support.h: Likewise.
2716         * dtrace-probe.c: Likewise.
2717         * dwarf2read.c: Likewise.
2718         * extension.h: Likewise.
2719         * gdb_bfd.c: Likewise.
2720         * gdbsupport/gdb_vecs.h: Likewise.
2721         * gdbsupport/vec.c: Remove.
2722         * gdbsupport/vec.h: Remove.
2723         * gdbthread.h: Likewise.
2724         * guile/scm-type.c: Likewise.
2725         * inline-frame.c: Likewise.
2726         * machoread.c: Likewise.
2727         * memattr.c: Likewise.
2728         * memrange.h: Likewise.
2729         * namespace.h: Likewise.
2730         * nat/linux-btrace.h: Likewise.
2731         * osdata.c: Likewise.
2732         * parser-defs.h: Likewise.
2733         * progspace.h: Likewise.
2734         * python/py-type.c: Likewise.
2735         * record-btrace.c: Likewise.
2736         * rust-exp.y: Likewise.
2737         * solib-target.c: Likewise.
2738         * stap-probe.c: Likewise.
2739         * target-descriptions.c: Likewise.
2740         * target-memory.c: Likewise.
2741         * target.h: Likewise.
2742         * varobj.c: Likewise.
2743         * varobj.h: Likewise.
2744         * xml-support.h: Likewise.
2745
2746 2019-10-15  Andrew Burgess  <andrew.burgess@embecosm.com>
2747
2748         * gdb/dwarf2read.c (dwarf2_per_objfile::~dwarf2_per_objfile):
2749         Update for new std::vector based implementation.
2750         (process_psymtab_comp_unit_reader): Likewise.
2751         (scan_partial_symbols): Likewise.
2752         (recursively_compute_inclusions): Likewise.
2753         (compute_compunit_symtab_includes): Likewise.
2754         (process_imported_unit_die): Likewise.
2755         (queue_and_load_dwo_tu): Likewise.
2756         (follow_die_sig_1): Likewise.
2757         * gdb/dwarf2read.h: Remove DEF_VEC_P.
2758         (typedef dwarf2_per_cu_ptr): Remove.
2759         (struct dwarf2_per_cu_data) <imported_symtabs_empty>: New
2760         function.
2761         (struct dwarf2_per_cu_data) <imported_symtabs_push>: New function.
2762         (struct dwarf2_per_cu_data) <imported_symtabs_size>: New function.
2763         (struct dwarf2_per_cu_data) <imported_symtabs_free>: New function.
2764         (struct dwarf2_per_cu_data) <imported_symtabs>: Change to
2765         std::vector.
2766
2767 2019-10-15  Tom Tromey  <tromey@adacore.com>
2768
2769         * windows-nat.c (windows_nat_target::resume): Use %x when logging
2770         TID.
2771
2772 2019-10-15  Tom Tromey  <tromey@adacore.com>
2773
2774         * windows-nat.c (windows_nat_target::fetch_registers)
2775         (windows_nat_target::store_registers): Rename "pid" to "tid".
2776
2777 2019-10-15  Tom Tromey  <tromey@adacore.com>
2778
2779         * gdbarch.h, gdbarch.c: Rebuild.
2780         * gdbarch.sh (gcc_target_options): Change return type to
2781         std::string.
2782         * compile/compile.c (get_args): Update.
2783         * nios2-tdep.c (nios2_gcc_target_options): Return std::string.
2784         * arm-linux-tdep.c (arm_linux_gcc_target_options): Return
2785         std::string.
2786         * aarch64-linux-tdep.c (aarch64_linux_gcc_target_options): Return
2787         std::string.
2788         * arch-utils.c (default_gcc_target_options): Return std::string.
2789         * arch-utils.h (default_gcc_target_options): Return std::string.
2790         * s390-tdep.c (s390_gcc_target_options): Return std::string.
2791
2792 2019-10-15  Christian Biesinger  <cbiesinger@google.com>
2793
2794         * breakpoint.c (breakpoint_chain): Make static.
2795         * tui/tui-winsource.c: Call iterate_over_breakpoints instead
2796         of accessing breakpoint_chain.
2797
2798 2019-10-15  Christian Biesinger  <cbiesinger@google.com>
2799
2800         * breakpoint.c (iterate_over_breakpoints): Change function pointer
2801         to a gdb::function_view and return value to bool.
2802         * breakpoint.h (iterate_over_breakpoints): Likewise.
2803         * dummy-frame.c (pop_dummy_frame_bpt): Update.
2804         (pop_dummy_frame): Update.
2805         * guile/scm-breakpoint.c (bpscm_build_bp_list): Update.
2806         (gdbscm_breakpoints): Update.
2807         * python/py-breakpoint.c (build_bp_list): Update.
2808         (gdbpy_breakpoints): Update.
2809         * python/py-finishbreakpoint.c (bpfinishpy_detect_out_scope_cb):
2810         Update.
2811         (bpfinishpy_handle_stop): Update.
2812         (bpfinishpy_handle_exit): Update.
2813         * solib-svr4.c (svr4_update_solib_event_breakpoint): Update.
2814         (svr4_update_solib_event_breakpoints): Update.
2815
2816 2019-10-15  Andreas Arnez  <arnez@linux.ibm.com>
2817
2818         * s390-tdep.c (s390_effective_inner_type): Ignore static fields
2819         when unwrapping single-field structs.
2820
2821 2019-10-14  Simon Marchi  <simon.marchi@polymtl.ca>
2822
2823         * dwarf2read.c: Remove includes.
2824
2825 2019-10-13  Simon Marchi  <simon.marchi@polymtl.ca>
2826
2827         * ui-out.c (ui_out::call_do_message): Silence
2828         -Wformat-nonliteral warning.
2829
2830 2019-10-12  Simon Marchi  <simon.marchi@polymtl.ca>
2831
2832         * breakpoint.c: Remove some includes: continuations.h, skip.h,
2833         mi/mi-main.h, readline/readline.h, readline/history.h.  Add
2834         include: readline/tilde.h.
2835
2836 2019-10-12  Christian Biesinger  <cbiesinger@google.com>
2837
2838         * remote.c (remote_target::get_trace_status): Remove declaration of
2839         trace_regblock_size.
2840
2841 2019-10-12  Christian Biesinger  <cbiesinger@google.com>
2842
2843         * cli/cli-cmds.c (max_user_call_depth): Move comment to header.
2844         (show_user): Remove declaration of cmdlist.
2845         * cli/cli-cmds.h (max_user_call_depth): Declare.
2846         * cli/cli-script.c (execute_user_command): Remove declaration
2847         of max_user_call_depth.
2848
2849 2019-10-11  Jim Wilson  <jimw@sifive.com>
2850
2851         * gdbsupport/print-utils.h (pulongest): Fix comment.
2852         (plongest): Likewise.
2853         (phex): Add missing comment, mention leading zeros.
2854         (phex_nz): Add mention of no leading zeros to comment.
2855
2856         * riscv-tdep.c (riscv_push_dummy_code): Change %lld to %s and use
2857         plongest instead of unsigned long long cast.
2858
2859 2019-10-10  Christian Biesinger  <cbiesinger@google.com>
2860
2861         * main.c (captured_main_1): Include gdbtk.h and remove declarations
2862         for external_editor_command and gdbtk_test.
2863
2864 2019-10-10  Christian Biesinger  <cbiesinger@google.com>
2865
2866         * mi/mi-cmd-var.c (varobjdebug): Remove declaration.
2867         * varobj.c (varobjdebug): Move comment to...
2868         * varobj.h (varobjdebug): ...here, and declare.
2869
2870 2019-10-09  Tom Tromey  <tom@tromey.com>
2871
2872         * tui/tui-regs.c (tui_data_window::show_registers): Don't call
2873         erase_data_content.
2874
2875 2019-10-09  Tom Tromey  <tom@tromey.com>
2876
2877         * tui/tui-wingeneral.h (tui_delete_win): Don't declare.
2878         * tui/tui-stack.c (tui_locator_window::rerender): Update.
2879         * tui/tui-command.c (tui_cmd_window::resize)
2880         (tui_refresh_cmd_win): Update.
2881         * tui/tui-win.c (tui_resize_all, tui_set_focus_command): Update.
2882         * tui/tui.c (tui_rl_other_window, tui_enable): Update.
2883         * tui/tui-data.c (~tui_gen_win_info): Remove.
2884         * tui/tui-layout.c (tui_gen_win_info::resize): Update.
2885         * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
2886         (tui_redisplay_readline, tui_mld_flush)
2887         (tui_mld_erase_entire_line, tui_mld_getc, tui_getc): Update.
2888         * tui/tui-regs.c (tui_data_window::delete_data_content_windows)
2889         (tui_data_window::erase_data_content)
2890         (tui_data_item_window::rerender)
2891         (tui_data_item_window::refresh_window): Update.
2892         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window)
2893         (box_win, tui_gen_win_info::make_window)
2894         (tui_gen_win_info::make_visible): Update.
2895         (tui_delete_win): Remove.
2896         * tui/tui-winsource.c
2897         (tui_source_window_base::do_erase_source_content): Update.
2898         (tui_show_source_line, tui_source_window_base::update_tab_width)
2899         (tui_source_window_base::update_exec_info): Update.
2900         * tui/tui-data.h (struct curses_deleter): New.
2901         (struct tui_gen_win_info) <handle>: Now a unique_ptr.
2902         (struct tui_gen_win_info) <~tui_gen_win_info>: Define.
2903
2904 2019-10-09  Tom Tromey  <tom@tromey.com>
2905
2906         * tui/tui-wingeneral.h (struct tui_gen_win_info): Don't declare.
2907
2908 2019-10-09  Tom Tromey  <tom@tromey.com>
2909
2910         * tui/tui-data.c (tui_win_is_auxiliary): Remove.
2911         * tui/tui-data.h (tui_win_is_auxiliary): Don't declare.
2912
2913 2019-10-09  Tom Tromey  <tom@tromey.com>
2914
2915         * tui/tui-disasm.c (tui_get_low_disassembly_address): Compute
2916         window height directly.
2917         * tui/tui-layout.h (tui_default_win_viewport_height): Don't
2918         declare.
2919         * tui/tui-layout.c (tui_default_win_height): Remove.
2920         (tui_default_win_viewport_height): Remove.
2921
2922 2019-10-09  Tom Tromey  <tom@tromey.com>
2923
2924         * tui/tui.h: Remove comments.
2925
2926 2019-10-09  Tom de Vries  <tdevries@suse.de>
2927
2928         * python/lib/gdb/printer/bound_registers.py: Use
2929         '^builtin_type_bound128' as regexp argument for
2930         add_builtin_pretty_printer.
2931
2932 2019-10-09  Christian Biesinger  <cbiesinger@google.com>
2933
2934         * guile/guile.c (guile_extension_script_ops): Remove forward
2935         declaration and mark as static.
2936         (guile_script_ops): Likewise.
2937         (extension_language_guile): Move further down in the file so
2938         it can reference the definitions for guile_{extension_,}script_ops.
2939
2940 2019-10-09  Andreas Arnez  <arnez@linux.ibm.com>
2941
2942         * s390-tdep.c (390_process_record): Handle new arch13 instructions
2943         except SORTL, DFLTCC, and KDSA.
2944
2945 2019-10-08  Tom Tromey  <tromey@adacore.com>
2946
2947         * windows-nat.c (struct windows_thread_info_struct) <sf>: Remove.
2948         (struct safe_symbol_file_add_args): Remove.
2949
2950 2019-10-08  Tom Tromey  <tromey@adacore.com>
2951
2952         * windows-nat.c: Don't include buildsym-legacy.h.
2953
2954 2019-10-08  Tom Tromey  <tromey@adacore.com>
2955
2956         * contrib/ari/gdb_ari.sh (%p): Allow gdb-specific %p extensions.
2957
2958 2019-10-08  Christian Biesinger  <cbiesinger@google.com>
2959
2960         * gdbtypes.c (overload_debug): Move comment to header.
2961         * gdbtypes.h (overload_debug): Declare.
2962         * valops.c: Remove declaration of overload_debug, instead
2963         include gdbtypes.h.
2964
2965 2019-10-08  Christian Biesinger  <cbiesinger@google.com>
2966
2967         * language.c (show_language_command): Pass lang_frame_mismatch_warn
2968         through _().
2969         (lang_frame_mismatch_warn): Make const, mark with N_(), and
2970         move comment...
2971         * language.h (lang_frame_mismatch_warn): ... here. Also add
2972         declaration.
2973         * top.c (lang_frame_mismatch_warn): Remove declaration.
2974         (check_frame_language_change): Pass lang_frame_mismatch_warn
2975         through _().
2976
2977 2019-10-07  Christian Biesinger  <cbiesinger@google.com>
2978
2979         * c-lang.h (vtbl_ptr_name): Declare.
2980         * cp-valprint.c (vtbl_ptr_name): Remove "extern" now that we get
2981         it from the header.
2982         * stabsread.c (define_symbol): Remove declaration of vtbl_ptr_name.
2983
2984 2019-10-07  Christian Biesinger  <cbiesinger@google.com>
2985
2986         * charset.c (your_gdb_wchar_t_is_bogus): Replace with a
2987         gdb_static_assert.
2988
2989 2019-10-07  Weimin Pan  <weimin.pan@oracle.com>
2990
2991         * ../Makefile.def (dependencies): Add all-libctf to all-gdb
2992         * ../Makefile.in: Add "all-gdb: maybe-all-libctf"
2993         * ctfread.c: New file.
2994         * ctfread.h: New file.
2995         * elfread.c: Include ctfread.h.
2996         (struct elfinfo text_p): New member ctfsect.
2997         (elf_locate_sections): Mark CTF section.
2998         (elf_symfile_read): Call elfctf_build_psymtabs.
2999         * Makefile.in (LIBCTF): Add.
3000         (CLIBS): Use it.
3001         (CDEPS): Likewise.
3002         (DIST): Add ctfread.c.
3003
3004 2019-10-07  Andrew Burgess  <andrew.burgess@embecosm.com>
3005
3006         * ctfread.c (struct nextfield): Renamed to ...
3007         (struct ctf_nextfield): ... this.
3008         (struct field_info): Renamed to ...
3009         (strut ctf_field_info): ... this.
3010         (attach_fields_to_type): Update for renamed structures.
3011         (ctf_add_member_cb): Likewise.
3012         (ctf_add_enum_member_cb): Likewise.
3013         (process_struct_members): Likewise.
3014         (process_enum_type): Likewise.
3015
3016 2019-10-07  Weimin Pan  <weimin.pan@oracle.com>
3017
3018         * tracectf.h: Rename, was ctf.h.
3019         * tracectf.c: Rename, was ctf.c, replace ctf.h with tracectf.h.
3020         * tracefile.c: Likewise.
3021         * tracepoint.c: Remove unused include ctf.h.
3022         * mi/mi-main.c: Likewise.
3023         * Makefile.in Replace ctf.c with tracectf.c.
3024
3025 2019-10-06  Joel Brobecker  <brobecker@adacore.com>
3026
3027         * version.in: Change version number to "9.0.50.DATE-git".
3028
3029 2019-10-03  Tom Tromey  <tom@tromey.com>
3030
3031         PR rust/24976:
3032         * dwarf2read.c (quirk_rust_enum): Handle single-element unions.
3033
3034 2019-10-03  Andrew Burgess  <andrew.burgess@embecosm.com>
3035
3036         * f-lang.c (f_language_defn): Use cp_get_symbol_name_matcher and
3037         cp_search_name_hash.
3038         * NEWS: Add entry about nested function support.
3039
3040 2019-10-03  Bernhard Heckel  <bernhard.heckel@intel.com>
3041             Andrew Burgess  <andrew.burgess@embecosm.com>
3042
3043         * cp-namespace.c (cp_search_static_and_baseclasses): Only search
3044         for nested static variables when searchin VAR_DOMAIN.
3045         * dwarf2read.c (add_partial_symbol): Add nested subroutines to the
3046         global scope, update comment.
3047         (add_partial_subprogram): Call add_partial_subprogram recursively
3048         for nested subroutines when processinng Fortran.
3049         (load_partial_dies): Process the child entities of a subprogram
3050         when processing Fortran.
3051         (partial_die_parent_scope): Handle building scope
3052         for Fortran nested functions.
3053         (process_die): Record that nested functions have a scope.
3054         (new_symbol): Always record Fortran subprograms on the global
3055         symbol list.
3056         (determine_prefix): How to build the prefix for Fortran
3057         subprograms.
3058
3059 2019-10-03  Andrew Burgess  <andrew.burgess@embecosm.com>
3060
3061         * linux-nat.c (linux_nat_filter_event): Don't ignore SIGSTOP if we
3062         have just sent the thread a SIGSTOP and are waiting for it to
3063         arrive.
3064
3065 2019-10-03  Andrew Burgess  <andrew.burgess@embecosm.com>
3066
3067         * btrace.c (btrace_add_pc): Remove whitespace before the template
3068         parameter in 'std::vector <...>'.
3069         (parse_xml_btrace_block): Likewise.
3070         (btrace_maint_decode_pt): Likewise.
3071         (btrace_maint_update_packets): Likewise.
3072         (btrace_maint_print_packets): Likewise.
3073         * btrace.h (struct btrace_maint_info): Likewise.
3074         * dwarf2read.c (struct type_unit_group): Likewise.
3075         (build_type_psymtabs_reader): Likewise.
3076         * gdbsupport/btrace-common.c (btrace_data_append): Likewise.
3077         * gdbsupport/btrace-common.h (struct btrace_data_bts): Likewise.
3078         * nat/linux-btrace.c (perf_event_read_bts): Likewise.
3079
3080 2019-10-03  Tom de Vries  <tdevries@suse.de>
3081
3082         * cli/cli-style.c (_initialize_cli_style): Adding a '.' at the end of
3083         the first line of the help text for set/show style metadata.
3084
3085 2019-10-02  Tom Tromey  <tromey@adacore.com>
3086
3087         * Makefile.in (COMMON_SFILES): Add common-inferior.c.
3088         * gdbsupport/common-inferior.c: New file.
3089         * infcmd.c (startup_with_shell): Don't define.
3090         * nat/fork-inferior.h (startup_with_shell): Don't declare.
3091         * gdbsupport/common-inferior.h (startup_with_shell): Declare.
3092         * inferior.h (startup_with_shell): Don't declare.
3093
3094 2019-10-02  Christian Biesinger  <cbiesinger@google.com>
3095
3096         * gdbsupport/gdb_assert.h: Include errors.h.
3097         * gdbsupport/gdb_string_view.h: Include gdb_assert.h.
3098
3099 2019-10-02  Tom Tromey  <tromey@adacore.com>
3100
3101         * NEWS: Add $_ada_exception entry.
3102         * ada-lang.c (struct ada_catchpoint): Add constructor.
3103         <m_kind>: New member.
3104         (allocate_location_exception, re_set_exception): Remove
3105         "ex" parameter.
3106         (should_stop_exception): Compute $_ada_exception.
3107         (check_status_exception, print_it_exception)
3108         (print_one_exception, print_mention_exception): Remove
3109         "ex" parameter.
3110         (allocate_location_catch_exception, re_set_catch_exception)
3111         (check_status_exception, print_it_catch_exception)
3112         (print_one_catch_exception, print_mention_catch_exception)
3113         (print_recreate_catch_exception)
3114         (allocate_location_catch_exception_unhandled)
3115         (re_set_catch_exception_unhandled)
3116         (check_status_exception, print_it_catch_exception_unhandled)
3117         (print_one_catch_exception_unhandled)
3118         (print_mention_catch_exception_unhandled)
3119         (print_recreate_catch_exception_unhandled)
3120         (allocate_location_catch_assert, re_set_catch_assert)
3121         (check_status_assert, print_it_catch_assert)
3122         (print_one_catch_assert, print_mention_catch_assert)
3123         (print_recreate_catch_assert)
3124         (allocate_location_catch_handlers, re_set_catch_handlers)
3125         (check_status_handlers, print_it_catch_handlers)
3126         (print_one_catch_handlers, print_mention_catch_handlers)
3127         (print_recreate_catch_handlers): Remove.
3128         (create_ada_exception_catchpoint): Update.
3129         (initialize_ada_catchpoint_ops): Update.
3130
3131 2019-10-02  Tom Tromey  <tromey@adacore.com>
3132
3133         * ada-lang.c (ada_lookup_simple_minsyms): Remove.
3134         (create_excep_cond_exprs): Simplify exception string computation.
3135         (ada_exception_catchpoint_cond_string): Likewise.
3136
3137 2019-10-02  Tom Tromey  <tromey@adacore.com>
3138
3139         * symmisc.c (dump_msymbols): Don't use MSYMBOL_VALUE_ADDRESS.
3140         * ada-lang.c (lesseq_defined_than): Handle
3141         LOC_STATIC.
3142         * dwarf2read.c (dwarf2_per_objfile): Add can_copy
3143         parameter.
3144         (dwarf2_has_info): Likewise.
3145         (new_symbol): Set maybe_copied on symbol when
3146         appropriate.
3147         * dwarf2read.h (dwarf2_per_objfile): Add can_copy
3148         parameter.
3149         <can_copy>: New member.
3150         * elfread.c (record_minimal_symbol): Set maybe_copied
3151         on symbol when appropriate.
3152         (elf_symfile_read): Update call to dwarf2_has_info.
3153         * minsyms.c (lookup_minimal_symbol_linkage): New
3154         function.
3155         * minsyms.h (lookup_minimal_symbol_linkage): Declare.
3156         * symtab.c (get_symbol_address, get_msymbol_address):
3157         New functions.
3158         * symtab.h (get_symbol_address, get_msymbol_address):
3159         Declare.
3160         (SYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_ADDRESS): Handle
3161         maybe_copied.
3162         (struct symbol, struct minimal_symbol) <maybe_copied>:
3163         New member.
3164
3165 2019-10-02  Tom Tromey  <tromey@adacore.com>
3166
3167         * source.c (struct current_source_location): New.
3168         (current_source_key): New global.
3169         (current_source_symtab, current_source_line)
3170         (current_source_pspace): Remove.
3171         (get_source_location): New function.
3172         (get_current_source_symtab_and_line)
3173         (set_default_source_symtab_and_line)
3174         (set_current_source_symtab_and_line)
3175         (clear_current_source_symtab_and_line, select_source_symtab)
3176         (info_source_command, print_source_lines_base)
3177         (info_line_command, search_command_helper, _initialize_source):
3178         Update.
3179
3180 2019-10-02  Tom Tromey  <tromey@adacore.com>
3181
3182         * source.c (select_source_symtab): Don't call
3183         decode_line_with_current_source.
3184
3185 2019-10-02  Andrew Burgess  <andrew.burgess@embecosm.com>
3186
3187         * symtab.c (lookup_global_symbol): Search global block.
3188
3189 2019-10-02  Tom Tromey  <tromey@adacore.com>
3190
3191         * coffread.c (process_coff_symbol): Update.
3192         * dwarf2read.c (var_decode_location, new_symbol): Update.
3193         * mdebugread.c (parse_symbol): Update.
3194         * objfiles.c (relocate_one_symbol): Update.
3195         * stabsread.c (define_symbol, fix_common_block)
3196         (scan_file_globals): Update.
3197         * symtab.h (SYMBOL_VALUE_ADDRESS): Expand to an rvalue.
3198         (SET_SYMBOL_VALUE_ADDRESS): New macro.
3199         * xcoffread.c (process_xcoff_symbol): Update.
3200
3201 2019-10-02  Andreas Arnez  <arnez@linux.ibm.com>
3202
3203         * MAINTAINERS: Update my email address.
3204
3205 2019-10-02  Andrew Burgess  <andrew.burgess@embecosm.com>
3206
3207         * dwarf2read.c (struct type_unit_group) <tus>: Convert to
3208         std::vector.
3209         (build_type_psymtabs_reader): Update for std::vector.
3210         (build_type_psymtab_dependencies): Likewise.
3211         * dwarf2read.h: Remove use of DEF_VEC_P.
3212         (typedef sig_type_ptr): Delete.
3213
3214 2019-10-02  Andrew Burgess  <andrew.burgess@embecosm.com>
3215
3216         * btrace.c (btrace_maint_clear): Update to handle change from VEC
3217         to std::vector.
3218         (btrace_maint_decode_pt): Likewise, and move allocation of the
3219         vector outside of the loop.
3220         (btrace_maint_update_packets): Update to handle change from VEC to
3221         std::vector.
3222         (btrace_maint_print_packets): Likewise.
3223         (maint_info_btrace_cmd): Likewise.
3224         * btrace.h: Remove use of DEF_VEC_O.
3225         (typedef btrace_pt_packet_s): Delete.
3226         (struct btrace_maint_info) <packets>: Change fromm VEC to
3227         std::vector.
3228         * gdbsupport/btrace-common.h: Remove 'vec.h' include.
3229
3230 2019-10-02  Andrew Burgess  <andrew.burgess@embecosm.com>
3231
3232         * btrace.c (btrace_compute_ftrace_bts): Update for std::vector,
3233         make accesses into the vector constant references.
3234         (btrace_add_pc): Update for std::vector.
3235         (btrace_stitch_bts): Likewise.
3236         (parse_xml_btrace_block): Likewise.
3237         (btrace_maint_update_packets): Likewise.
3238         (btrace_maint_print_packets): Likewise.
3239         (maint_info_btrace_cmd): Likewise.
3240         * gdbsupport/btrace-common.c (btrace_data::fini): Update for
3241         std::vector.
3242         (btrace_data::empty): Likewise.
3243         (btrace_data_append): Likewise.
3244         * gdbsupport/btrace-common.h: Remove use of DEF_VEC_O.
3245         (typedef btrace_block_s): Delete.
3246         (struct btrace_block): Add constructor.
3247         (struct btrace_data_bts) <blocks>: Change to std::vector.
3248         * nat/linux-btrace.c (perf_event_read_bts): Update for
3249         std::vector.
3250         (linux_read_bts): Likewise.
3251
3252 2019-10-01  Tom Tromey  <tom@tromey.com>
3253
3254         * cli/cli-logging.c (show_logging_filename): Use styled_string.
3255
3256 2019-10-01  Tom Tromey  <tom@tromey.com>
3257
3258         * stack.c (print_frame, info_frame_command_core): Use
3259         styled_string.
3260         * linux-thread-db.c (try_thread_db_load_1)
3261         (try_thread_db_load_from_pdir_1): Use styled_string.
3262         * auto-load.c (file_is_auto_load_safe, execute_script_contents)
3263         (auto_load_section_scripts, info_auto_load_local_gdbinit)
3264         (maybe_print_unsupported_script_warning)
3265         (maybe_print_script_not_found_warning): Use styled_string.
3266         * ada-lang.c (user_select_syms): Use styled_string.
3267
3268 2019-10-01  Tom Tromey  <tom@tromey.com>
3269
3270         * p-lang.c (pascal_printstr): Use metadata style.
3271         * value.c (show_convenience): Use metadata style.
3272         * valprint.c (valprint_check_validity, val_print_optimized_out)
3273         (val_print_not_saved, val_print_unavailable)
3274         (val_print_invalid_address, generic_val_print, val_print)
3275         (value_check_printable, val_print_array_elements): Use metadata
3276         style.
3277         * ui-out.h (class ui_out) <field_fmt>: New overload.
3278         <do_field_fmt>: Add style parameter.
3279         * ui-out.c (ui_out::field_fmt): New overload.
3280         * typeprint.c (type_print_unknown_return_type)
3281         (val_print_not_allocated, val_print_not_associated): Use metadata
3282         style.
3283         * tui/tui-out.h (class tui_ui_out) <do_field_fmt>: Add style
3284         parameter.
3285         * tui/tui-out.c (tui_ui_out::do_field_fmt): Update.
3286         * tracepoint.c (tvariables_info_1): Use metadata style.
3287         * stack.c (print_frame_arg, print_frame_info, print_frame)
3288         (info_frame_command_core): Use metadata style.
3289         * skip.c (info_skip_command): Use metadata style.
3290         * rust-lang.c (rust_print_enum): Use metadata style.
3291         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
3292         metadata style.
3293         * python/py-framefilter.c (py_print_single_arg): Use metadata
3294         style.
3295         * printcmd.c (do_one_display, print_variable_and_value): Use
3296         metadata style.
3297         * p-valprint.c (pascal_val_print)
3298         (pascal_object_print_value_fields): Use metadata style.
3299         * p-typeprint.c (pascal_type_print_base): Use metadata style.
3300         * mi/mi-out.h (class mi_ui_out) <do_field_fmt>: Add style
3301         parameter.
3302         * mi/mi-out.c (mi_ui_out::do_field_fmt): Update.
3303         * m2-valprint.c (m2_print_long_set): Use metadata style.
3304         * m2-typeprint.c (m2_print_type): Use metadata style.
3305         * infcmd.c (print_return_value_1): Use metadata style.
3306         * gnu-v3-abi.c (print_one_vtable): Use metadata style.
3307         * f-valprint.c (info_common_command_for_block): Use metadata
3308         style.
3309         * f-typeprint.c (f_type_print_base): Use metadata style.
3310         * expprint.c (print_subexp_standard): Use metadata style.
3311         * cp-valprint.c (cp_print_value_fields): Use metadata style.
3312         * cli/cli-style.h (class cli_style_option): Add constructor.
3313         (metadata_style): Declare.
3314         * cli/cli-style.c (metadata_style): New global.
3315         (_initialize_cli_style): Register metadata style.
3316         * cli-out.h (class cli_ui_out) <do_field_fmt>: Add style
3317         parameter.
3318         * cli-out.c (cli_ui_out::do_field_fmt): Update.
3319         * c-typeprint.c (c_type_print_base_struct_union)
3320         (c_type_print_base_1): Use metadata style.
3321         * breakpoint.c (watchpoint_value_print)
3322         (print_one_breakpoint_location): Use metadata style.
3323         * break-catch-syscall.c (print_one_catch_syscall): Use metadata
3324         style.
3325         * break-catch-sig.c (signal_catchpoint_print_one): Use metadata
3326         style.
3327         * ada-valprint.c (val_print_packed_array_elements, printstr)
3328         (print_field_values, ada_val_print_ref, ada_val_print): Use
3329         metadata style.
3330         * ada-typeprint.c (print_array_type, ada_print_type): Use metadata
3331         style.
3332         * ada-tasks.c (print_ada_task_info, info_task): Use metadata
3333         style.
3334         * ada-lang.c (user_select_syms): Use metadata style.
3335
3336 2019-10-01  Tom Tromey  <tom@tromey.com>
3337
3338         * cli/cli-cmds.c (pwd_command): Style output.
3339
3340 2019-10-01  Pedro Alves  <palves@redhat.com>
3341             Tom Tromey  <tom@tromey.com>
3342
3343         * symtab.c (print_symbol_info): Use %ps.
3344         (print_msymbol_info): Use %ps.
3345         * symfile.c (symbol_file_add_with_addrs): Use %ps.
3346         * printcmd.c (print_variable_and_value): Use %ps.
3347         * macrocmd.c (show_pp_source_pos): Use %ps.
3348         * infrun.c (print_exited_reason): Use ui_out::message.
3349         * breakpoint.c (watchpoint_check, print_one_breakpoint_location)
3350         (describe_other_breakpoints): Use ui_out::message and new
3351         formats.
3352         (say_where): Use new formats.
3353         (bkpt_print_it, tracepoint_print_one_detail): Use ui_out::message
3354         and new formats.
3355
3356 2019-10-01  Pedro Alves  <palves@redhat.com>
3357             Tom Tromey  <tom@tromey.com>
3358
3359         * unittests/format_pieces-selftests.c: Add gdb_format parameter.
3360         (test_gdb_formats): New function.
3361         (run_tests): Call it.
3362         (test_format_specifier): Update.
3363         * utils.h (fputs_filtered): Update comment.
3364         (vfprintf_styled, vfprintf_styled_no_gdbfmt)
3365         (fputs_styled_unfiltered): Declare.
3366         * utils.c (fputs_styled_unfiltered): New function.
3367         (vfprintf_maybe_filtered): Add gdbfmt parameter.
3368         (vfprintf_filtered): Update.
3369         (vfprintf_unfiltered, vprintf_filtered): Update.
3370         (vfprintf_styled, vfprintf_styled_no_gdbfmt): New functions.
3371         * ui-out.h (enum ui_out_flag) <unfiltered_output,
3372         disallow_ui_out_field>: New constants.
3373         (enum class field_kind): New.
3374         (struct base_field_s, struct signed_field_s): New.
3375         (signed_field): New function.
3376         (struct string_field_s): New.
3377         (string_field): New function.
3378         (struct styled_string_s): New.
3379         (styled_string): New function.
3380         (class ui_out) <message>: Add comment.
3381         <vmessage, call_do_message>: New methods.
3382         <do_message>: Add style parameter.
3383         * ui-out.c (ui_out::call_do_message, ui_out::vmessage): New
3384         methods.
3385         (ui_out::message): Rewrite.
3386         * mi/mi-out.h (class mi_ui_out) <do_message>: Add style
3387         parameter.
3388         * mi/mi-out.c (mi_ui_out::do_message): Add style parameter.
3389         * gdbsupport/format.h (class format_pieces) <format_pieces>: Add
3390         gdb_extensions parameter.
3391         (class format_piece): Add parameter to constructor.
3392         (n_int_args): New field.
3393         * gdbsupport/format.c (format_pieces::format_pieces): Add
3394         gdb_extensions parameter.  Handle '*'.
3395         * cli-out.h (class cli_ui_out) <do_message>: Add style parameter.
3396         * cli-out.c (cli_ui_out::do_message): Add style parameter.  Call
3397         vfprintf_styled_no_gdbfmt.
3398         (cli_ui_out::do_field_string, cli_ui_out::do_spaces)
3399         (cli_ui_out::do_text, cli_ui_out::field_separator): Allow
3400         unfiltered output.
3401         * ui-style.h (struct ui_file_style) <ptr>: New method.
3402
3403 2019-10-01  Tom Tromey  <tom@tromey.com>
3404
3405         * unittests/format_pieces-selftests.c: Update.  Add final format.
3406         * gdbsupport/format.c (format_pieces::format_pieces): Don't add
3407         empty literal pieces.
3408
3409 2019-10-01  Tom Tromey  <tom@tromey.com>
3410
3411         * ui-out.h (enum class ui_out_style_kind): Remove.
3412         (class ui_out) <field_string, field_stsream, do_field_string>:
3413         Change type of "style".
3414         * ui-out.c (ui_out::field_core_addr, ui_out::field_stream)
3415         (ui_out::field_string): Update.
3416         * tui/tui-out.h (class tui_ui_out) <do_field_string>: Change type
3417         of "style".
3418         * tui/tui-out.c (tui_ui_out::do_field_string): Update.
3419         * tracepoint.c (print_one_static_tracepoint_marker): Update.
3420         * stack.c (print_frame_arg, print_frame_info, print_frame):
3421         Update.
3422         * source.c (print_source_lines_base): Update.
3423         * solib.c (info_sharedlibrary_command): Update.
3424         * skip.c (info_skip_command): Update.
3425         * record-btrace.c (btrace_call_history_src_line)
3426         (btrace_call_history): Update.
3427         * python/py-framefilter.c (py_print_frame): Update.
3428         * mi/mi-out.h (class mi_ui_out) <do_field_string>: Change type of
3429         "style".
3430         * mi/mi-out.c (mi_ui_out::do_table_header)
3431         (mi_ui_out::do_field_signed, mi_ui_out::do_field_unsigned)
3432         (mi_ui_out::do_field_string): Update.
3433         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
3434         Update.
3435         * cli-out.h (class cli_ui_out) <do_field_string>: Change type of
3436         "style".
3437         * cli-out.c (cli_ui_out::do_table_header)
3438         (cli_ui_out::do_field_signed, cli_ui_out::do_field_unsigned)
3439         (cli_ui_out::do_field_skip, cli_ui_out::do_field_string)
3440         (cli_ui_out::do_field_fmt): Update.
3441         * breakpoint.c (print_breakpoint_location): Update.
3442         (update_static_tracepoint): Update.
3443
3444 2019-10-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3445
3446         * main.c (relocate_gdbinit_path_maybe_in_datadir): Remove std::string
3447         conversion of gdb_datadir.
3448         (captured_main_1): Remove xstrdup when assigning to gdb_datadir,
3449         remove not needed c_str ().
3450
3451 2019-09-30  Ali Tamur <tamur@google.com>
3452
3453         * dwarf2read.c (skip_one_die): Handle DW_FORM_strx forms.
3454         (dwarf2_string_attr): Likewise.
3455
3456 2019-09-30  Ali Tamur <tamur@google.com>
3457
3458         * dwarf2read.c (process_full_comp_unit): Remove whitespace at the EOL.
3459         (process_full_type_unit): Likewise.
3460         (dump_die_shallow): Likewise.
3461         (cu_debug_loc_section): Likewise.
3462
3463 2019-09-28  Christian Biesinger  <cbiesinger@google.com>
3464
3465         * minsyms.c (compare_minimal_symbols): Rename to...
3466         (minimal_symbol_is_less_than): ...this, and adjust to STL
3467         conventions (return bool, take arguments as references)
3468         (minimal_symbol_reader::install): Call std::sort instead
3469         of qsort.
3470
3471 2019-09-29  Christian Biesinger  <cbiesinger@google.com>
3472
3473         * minsyms.h (msymbol_hash): Document that this is a case-insensitive
3474         hash and why.
3475         * objfiles.h (struct objfile_per_bfd_storage) <demangled_names_hash,
3476         msymbol_hash, msymbol_demangled_hash>: Improve comments.
3477
3478 2019-09-30  Simon Marchi  <simon.marchi@polymtl.ca>
3479
3480         * psymtab.c (add_psymbol_to_list): Move comment to psympriv.h.
3481         * psympriv.h (add_psymbol_to_list): Move comment here and update
3482         it.
3483
3484 2019-09-29  Tom de Vries  <tdevries@suse.de>
3485
3486         * contrib/cc-with-tweaks.sh (get_tmpdir): New function.
3487         Use $tmpdir/$(basename "$output_file").dwz instead of
3488         "${output_file}.dwz".
3489
3490 2019-09-28  Simon Marchi  <simon.marchi@polymtl.ca>
3491
3492         PR gdb/25045
3493         * hppa-linux-nat.c: Include gdbarch.h.
3494
3495 2019-09-26  Christian Biesinger  <cbiesinger@google.com>
3496
3497         * blockframe.c (find_pc_partial_function): Change return type to bool.
3498         * elfread.c (elf_gnu_ifunc_resolve_name): Likewise.
3499         * minsyms.c (in_gnu_ifunc_stub): Likewise.
3500         (stub_gnu_ifunc_resolve_name): Likewise.
3501         * symtab.c (compare_filenames_for_search): Likewise.
3502         (compare_glob_filenames_for_search): Likewise.
3503         (matching_obj_sections): Likewise.
3504         (symbol_matches_domain): Likewise.
3505         (find_line_symtab): Change out param EXACT_MATCH to bool *.
3506         (find_line_pc): Change return type to bool.
3507         (find_line_pc_range): Likewise.
3508         (producer_is_realview): Likewise.
3509         * symtab.h (symbol_matches_domain): Likewise.
3510         (find_pc_partial_function): Likewise.
3511         (find_pc_line_pc_range): Likewise.
3512         (in_gnu_ifunc_stub): Likewise.
3513         (struct gnu_ifunc_fns) <gnu_ifunc_resolve_name>: Likewise.
3514         (find_line_pc): Likewise.
3515         (find_line_pc_range): Likewise.
3516         (matching_obj_sections): Likewise.
3517         (find_line_symtab): Change out parameter to bool.
3518         (producer_is_realview): Change return type to bool.
3519         (compare_filenames_for_search): Likewise.
3520         (compare_glob_filenames_for_search): Likewise.
3521
3522 2019-09-26  Tom Tromey  <tom@tromey.com>
3523
3524         * Makefile.in (COMMON_SFILES): Remove gdb_usleep.c.
3525         (HFILES_NO_SRCDIR): Remove gdb_usleep.h.
3526         * gdb_usleep.h: Remove.
3527         * gdb_usleep.c: Remove.
3528         * utils.c: Don't include gdb_usleep.h.
3529
3530 2019-09-26  Tom Tromey  <tromey@adacore.com>
3531
3532         * python/py-type.c (type_to_type_object): Call check_typedef
3533         for stub types.
3534
3535 2019-09-26  Tom Tromey  <tom@tromey.com>
3536
3537         * utils.h (initialize_utils): Don't declare.
3538         * top.c (gdb_init): Don't call initialize_utils.
3539         * utils.c (initialize_utils): Remove.  Move contents...
3540         (_initialize_utils): ... here.
3541
3542 2019-09-25  Tom Tromey  <tom@tromey.com>
3543
3544         * python/py-objfile.c (objfpy_get_build_id): Use bin2hex.
3545         * utils.h (make_hex_string): Don't declare.
3546         * utils.c (make_hex_string): Remove.
3547
3548 2019-09-24  Tom de Vries  <tdevries@suse.de>
3549
3550         PR gdb/23815
3551         * amd64-linux-nat.c (amd64_linux_nat_target::fetch_registers):
3552         Initialize xstateregs before ptrace PTRACE_GETREGSET call.
3553
3554 2019-09-23  Dimitar Dimitrov  <dimitar@dinux.eu>
3555
3556         * NEWS: Mention new simulator port for PRU.
3557
3558 2019-09-23  Christian Biesinger  <cbiesinger@google.com>
3559
3560         * ada-exp.y (write_object_remaining): Update.
3561         * ada-lang.c (ada_decode): Return a std::string instead of a char*
3562         and eliminate the static buffer.
3563         (ada_decode_symbol): Update.
3564         (ada_la_decode): Update.
3565         (ada_sniff_from_mangled_name): Update.
3566         (is_valid_name_for_wild_match): Update.
3567         (ada_lookup_name_info::matches): Update and simplify.
3568         (name_matches_regex): Update.
3569         (ada_add_global_exceptions): Update.
3570         * ada-lang.h (ada_decode): Update signature.
3571         * ada-varobj.c (ada_varobj_describe_simple_array_child): Update.
3572         * dwarf-index-write.c (debug_names::insert): Update.
3573
3574 2019-09-21  Simon Marchi  <simon.marchi@polymtl.ca>
3575
3576         * solib-svr4.c (svr4_iterate_over_objfiles_in_search_order): Fix
3577         formatting.
3578
3579 2019-09-21  Simon Marchi  <simon.marchi@polymtl.ca>
3580
3581         * breakpoint.h (bp_location) <inserted, permanent, duplicate>:
3582         Change "nonzero" to "true" in documentation.
3583
3584 2019-09-20  Christian Biesinger  <cbiesinger@google.com>
3585
3586         * solib-darwin.c (darwin_lookup_lib_symbol): Remove.
3587         (_initialize_darwin_solib): Don't set
3588         darwin_so_ops.lookup_lib_global_symbol.
3589         * solib-svr4.c (set_solib_svr4_fetch_link_map_offsets): Call
3590         set_gdbarch_iterate_over_objfiles_in_search_order.
3591         (elf_lookup_lib_symbol): Rename to...
3592         (svr4_iterate_over_objfiles_in_search_order): this, and update
3593         to iterate semantics.
3594         (_initialize_svr4_solib): Don't set lookup_lib_global_symbol.
3595         * solib.c (solib_global_lookup): Remove.
3596         * solist.h (struct target_so_ops): Remove lookup_lib_global_symbol.
3597         (solib_global_lookup): Remove.
3598         * symtab.c (lookup_global_or_static_symbol): Remove call to
3599         solib_global_lookup.
3600
3601 2019-09-20  Joel Brobecker  <brobecker@adacore.com>
3602
3603         * NEWS: Move entries about default MI version now being
3604         version 3, and about the GDB/MI fix for multi-location
3605         breakpoints to the "since GDB 8.3" section.
3606
3607 2019-09-20  Joel Brobecker  <brobecker@adacore.com>
3608
3609         GDB 8.3.1 released.
3610
3611 2019-09-20  Ulrich Weigand  <uweigand@de.ibm.com>
3612
3613         * NEWS: Mention that Cell/B.E. debugging support was removed.
3614         * MAINTAINERS: Remove spu target.
3615
3616         * config/djgpp/fnchange.lst: Remove entries for removed files.
3617
3618         * Makefile.in (ALL_TARGET_OBS): Remove solib-spu.o,
3619         spu-multiarch.o, and spu-tdep.o.
3620         (HFILES_NO_SRCDIR): Remove solib-spu.h and spu-tdep.h.
3621         (ALLDEPFILES): Remove solib-spu.c, spu-linux-nat.c,
3622         spu-multiarch.c, and spu-tdep.c.
3623         * spu-linux-nat.c: Remove file.
3624         * spu-multiarch.c: Remove file.
3625         * spu-tdep.c: Remove file.
3626         * spu-tdep.h: Remove file.
3627         * solib-spu.c: Remove file.
3628         * solib-spu.h: Remove file.
3629
3630         * configure.host (powerpc64*-*-linux*): Remove Cell/B.E. support.
3631         * configure.nat (spu-linux): Remove.
3632         * configure.tgt (powerpc*-*-linux*): Remove solib-spu.o and
3633         solib-multiarch.o from gdb_target_obs.
3634         (spu*-*-*): Remove.
3635
3636         * arch/ppc-linux-common.h (struct ppc_linux_features): Remove "cell"
3637         feature flag.
3638         (ppc_linux_no_features): Update.
3639         * arch/ppc-linux-common.c (ppc_linux_match_description): Remove
3640         Cell/B.E. support.
3641         * arch/ppc-linux-tdesc.h (tdesc_powerpc_cell32l): Remove declaration.
3642         (tdesc_powerpc_cell64l): Likewise.
3643         * nat/ppc-linux.h (PPC_FEATURE_CELL): Remove.
3644         * ppc-linux-nat.c (ppc_linux_nat_target::read_description): Remove
3645         Cell/B.E. support.
3646         * ppc-linux-tdep.h: Do not include "solib-spu.h" or "spu-tdep.h".
3647         Do not include "features/rs6000/powerpc-cell32l.c" or
3648         "features/rs6000/powerpc-cell64l.c".
3649         (ppc_linux_spu_section): Remove.
3650         (ppc_linux_core_read_description): Remove Cell/B.E. support.
3651         (spe_context_objfile, spe_context_lm_addr, spe_context_offset,
3652         spe_context_cache_ptid, spe_context_cache_ptid): Remove.
3653         (ppc_linux_spe_context_lookup): Remove.
3654         (ppc_linux_spe_context_inferior_created): Remove.
3655         (ppc_linux_spe_context_solib_loaded): Remove.
3656         (ppc_linux_spe_context_solib_unloaded): Remove.
3657         (ppc_linux_spe_context): Remove.
3658         (struct ppu2spu_cache): Remove.
3659         (ppu2spu_prev_arch, ppu2spu_this_id, ppu2spu_prev_register): Remove.
3660         (struct ppu2spu_data): Remove.
3661         (ppu2spu_unwind_register, ppu2spu_sniffer, ppu2spu_dealloc_cache,
3662         ppu2spu_unwind): Remove.
3663         (ppc_linux_init_abi): Remove Cell/B.E. support.
3664         * rs6000-tdep.h (rs6000_gdbarch_init): Remove Cell/B.E. support.
3665
3666         * features/Makefile (rs6000/powerpc-cell32l-expedite): Remove.
3667         (rs6000/powerpc-cell64l-expedite): Likewise
3668         (WHICH): Remove rs6000/powerpc-cell32l and rs6000/powerpc-cell64l.
3669         (XMLTOC): Remove rs6000/powerpc-cell32l.xml and
3670         rs6000/powerpc-cell64l.xml.
3671         * features/rs6000/powerpc-cell32l.xml: Remove.
3672         * features/rs6000/powerpc-cell64l.xml: Likewise.
3673         * features/rs6000/powerpc-cell32l.c: Remove generated file.
3674         * features/rs6000/powerpc-cell64l.c: Likewise.
3675         * regformats/rs6000/powerpc-cell32l.dat: Remove generated file.
3676         * regformats/rs6000/powerpc-cell64l.dat: Likewise.
3677         * regformats/reg-spu.dat: Remove.
3678
3679         * target.h (enum target_object): Remove TARGET_OBJECT_SPU.
3680         * corelow.c (struct spuid_list): Remove.
3681         (add_to_spuid_list): Remove.
3682         (core_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
3683         * remote.c (PACKET_qXfer_spu_read, PACKET_qXfer_spu_write): Remove.
3684         (remote_protocol_features): Remove associated entries.
3685         (_initialize_remote): No longer initialize them.
3686         (remote_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
3687         * linux-nat.c (SPUFS_MAGIC): Remove.
3688         (linux_proc_xfer_spu): Remove.
3689         (spu_enumerate_spu_ids): Remove.
3690         (linux_nat_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
3691         * linux-tdep.c (-linux_spu_make_corefile_notes): Remove.
3692         (linux_make_corefile_notes): No longer call it.
3693
3694         * regcache.c (cooked_read_test): Remove bfd_arch_spu special case.
3695         (cooked_write_test): Likewise.
3696
3697 2019-09-20  Tom Tromey  <tom@tromey.com>
3698
3699         * NEWS: Mention case-sensitivity of TUI commands.
3700         * tui/tui-win.c (tui_set_focus_command): Now case-sensitive.
3701         (tui_set_win_height_command, parse_scrolling_args): Likewise.
3702         * tui/tui-layout.c (tui_layout_command): Now case-sensitive.
3703
3704 2019-09-20  Tom Tromey  <tom@tromey.com>
3705
3706         * tui/tui-source.c (tui_source_window::set_contents): Use
3707         make_unique_xstrdup.
3708         * tui/tui-disasm.c (tui_disasm_window::set_contents): Use
3709         make_unique_xstrdup.
3710
3711 2019-09-20  Tom Tromey  <tom@tromey.com>
3712
3713         * tui/tui-data.c: Remove separator comments.
3714         * tui/tui-layout.c: Remove separator comments.
3715         * tui/tui-win.c: Remove separator comments.
3716         * tui/tui-wingeneral.c: Remove separator comments.
3717
3718 2019-09-20  Tom Tromey  <tom@tromey.com>
3719
3720         * tui/tui.h (strcat_to_buf): Don't declare.
3721         * tui/tui.c (strcat_to_buf): Remove.
3722
3723 2019-09-20  Tom Tromey  <tom@tromey.com>
3724
3725         * tui/tui-source.h (struct tui_source_window) <m_fullname>: Rename
3726         from "fullname".
3727         * tui/tui-source.c (tui_source_window::set_contents)
3728         (tui_source_window::location_matches_p)
3729         (tui_source_window::maybe_update): Update.
3730
3731 2019-09-20  Tom Tromey  <tom@tromey.com>
3732
3733         * tui/tui-regs.h (struct tui_data_window) <get_current_group>:
3734         Update.
3735         <m_regs_content, m_regs_column_count, m_current_group>: Add "m_"
3736         prefix.
3737         * tui/tui-regs.c (tui_data_window::last_regs_line_no)
3738         (tui_data_window::line_from_reg_element_no)
3739         (tui_data_window::first_reg_element_no_inline)
3740         (tui_data_window::show_registers)
3741         (tui_data_window::show_register_group)
3742         (tui_data_window::display_registers_from)
3743         (tui_data_window::display_registers_from_line)
3744         (tui_data_window::first_data_item_displayed)
3745         (tui_data_window::delete_data_content_windows)
3746         (tui_data_window::erase_data_content)
3747         (tui_data_window::do_scroll_vertical)
3748         (tui_data_window::refresh_window)
3749         (tui_data_window::check_register_values): Update.
3750
3751 2019-09-20  Tom Tromey  <tom@tromey.com>
3752
3753         * tui/tui-stack.h (MAX_LOCATOR_ELEMENT_LEN): Remove define.
3754         (struct tui_locator_window) <full_name, proc_name>: Now
3755         std::string.
3756         * tui/tui-stack.c (tui_locator_window::make_status_line)
3757         (tui_locator_window::set_locator_fullname)
3758         (tui_locator_window::set_locator_info): Update.
3759         * tui/tui-source.c (tui_source_window::set_contents)
3760         (tui_source_window::showing_source_p): Update.
3761
3762 2019-09-20  Tom Tromey  <tom@tromey.com>
3763
3764         * tui/tui-stack.c (tui_locator_window::set_locator_fullname):
3765         Don't call tui_locator_win_info_ptr.
3766
3767 2019-09-20  Tom Tromey  <tom@tromey.com>
3768
3769         * tui/tui-win.c (tui_resize_all): Don't call refresh.
3770
3771 2019-09-20  Tom Tromey  <tom@tromey.com>
3772
3773         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Use 1 as
3774         height for locator.
3775         * tui/tui-stack.c (tui_locator_window::rerender): Call scrollok.
3776         * tui/tui-layout.c (show_source_disasm_command, show_data)
3777         (show_source_or_disasm_and_command): Use 1 as height for locator.
3778
3779 2019-09-20  Tom Tromey  <tom@tromey.com>
3780
3781         * tui/tui.c (tui_enable): Update.
3782         * tui/tui-win.c (tui_sigwinch_handler, tui_async_resize_screen):
3783         Update.
3784         * tui/tui-data.h (tui_win_resized, tui_set_win_resized_to):
3785         Update.
3786         * tui/tui-data.c (win_resized): Now bool.
3787         (tui_win_resized): Return bool.
3788         (tui_set_win_resized_to): Accept a bool.
3789
3790 2019-09-20  Tom Tromey  <tom@tromey.com>
3791
3792         * tui/tui-regs.h (struct tui_data_window) <show_register_group>:
3793         Change type of "refresh_values_only".
3794         * tui/tui-regs.c (tui_data_window::show_register_group): Change
3795         type of "refresh_values_only".
3796
3797 2019-09-20  Tom Tromey  <tom@tromey.com>
3798
3799         * tui/tui-disasm.c (struct tui_asm_line) <addr_string, insn>: Now
3800         std::string.
3801         (tui_disassemble): Add "pos" parameter.
3802         (tui_disasm_window::set_contents): Simplify.
3803
3804 2019-09-20  Tom Tromey  <tom@tromey.com>
3805
3806         * tui/tui-winsource.h (struct tui_source_window_base)
3807         <show_source_content>: Now private.
3808         * tui/tui-winsource.c
3809         (tui_source_window_base::show_source_content): Don't handle empty
3810         content case.
3811
3812 2019-09-20  Tom Tromey  <tom@tromey.com>
3813
3814         * tui/tui-layout.c (show_source_disasm_command)
3815         (show_source_or_disasm_and_command): Don't call
3816         show_source_content.
3817
3818 2019-09-20  Tom Tromey  <tom@tromey.com>
3819
3820         * tui/tui-stack.h (struct tui_locator_window) <make_status_line>:
3821         Declare.
3822         * tui/tui-stack.c (tui_locator_window::make_status_line): Rename
3823         from tui_make_status_line.
3824         (tui_locator_window::rerender): Update.
3825
3826 2019-09-20  Tom Tromey  <tom@tromey.com>
3827
3828         * tui/tui-stack.c (tui_make_status_line): Return std::string.
3829         (tui_locator_window::rerender): Update.
3830
3831 2019-09-20  Tom Tromey  <tom@tromey.com>
3832
3833         * tui/tui-winsource.h (struct tui_source_window_base)
3834         <~tui_source_window_base>: Don't declare.
3835         <fullname>: Remove.
3836         * tui/tui-winsource.c (~tui_source_window_base): Remove.
3837         * tui/tui-source.h (struct tui_source_window) <fullname>: New
3838         member.
3839         * tui/tui-source.c (tui_source_window::set_contents): Update.
3840         (tui_source_window::location_matches_p)
3841         (tui_source_window::maybe_update): Update.
3842
3843 2019-09-20  Tom Tromey  <tom@tromey.com>
3844
3845         * tui/tui-winsource.h (~tui_source_element): Remove.
3846         (tui_source_element): Update.
3847         (struct tui_source_element) <line>: Now a unique_xmalloc_ptr.
3848         * tui/tui-winsource.c (tui_show_source_line): Update.
3849         * tui/tui-source.c (tui_source_window::set_contents): Update.
3850         * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
3851
3852 2019-09-20  Tom Tromey  <tom@tromey.com>
3853
3854         * tui/tui-data.h (tui_clear_source_windows_detail): Don't
3855         declare.
3856         * tui/tui-layout.c (tui_add_win_to_layout): Don't call
3857         tui_clear_source_windows_detail.
3858         * tui/tui-winsource.h (struct tui_source_window_base)
3859         <clear_detail>: Don't declare.
3860         * tui/tui-winsource.c (tui_source_window_base::clear_detail):
3861         Remove.
3862         * tui/tui-data.c (tui_clear_source_windows_detail): Remove.
3863
3864 2019-09-20  Tom Tromey  <tromey@adacore.com>
3865
3866         PR ada/24919:
3867         * block.c (contained_in): Fix final return value.
3868
3869 2019-09-20  Alan Modra  <amodra@gmail.com>
3870
3871         * gdb_bfd.c (gdb_bfd_ref, gdb_bfd_unref): Use bfd_set_usrdata.
3872         * dwarf2read.c (dwarf2_read_gdb_index, dwarf2_read_debug_names),
3873         (read_indirect_string_from_dwz): Use bfd accessor.
3874         * dwarf2read.h (struct dwz_file <filename>): Likewise.
3875         * machoread.c (macho_symfile_read_all_oso): Likewise.
3876         * solib.c (solib_bfd_open): Likewise.
3877
3878 2019-09-19  Christian Biesinger  <cbiesinger@google.com>
3879
3880         * eval.c: Move declaration of overload_resolution to...
3881         * value.h: ...here.
3882
3883 2019-09-19  Christian Biesinger  <cbiesinger@google.com>
3884
3885         * arm-linux-nat.c: Remove extern declaration for arm_apcs_32.
3886         * arm-linux-tdep.c: Likewise.
3887         * arm-nbsd-nat.c: Likewise.
3888         * arm-tdep.h: Declare arm_apcs_32.
3889         * arm-tdep.c: Move documentation for arm_apcs_32 to arm-tdep.h.
3890
3891 2019-09-19  Christian Biesinger  <cbiesinger@google.com>
3892
3893         * dwarf2loc.c: Remove extern declaration of dwarf_always_disassemble.
3894         * dwarf2read.h: Declare dwarf_always_disassemble.
3895
3896 2019-09-19  Tom de Vries  <tdevries@suse.de>
3897
3898         PR gdb/25009
3899         * source-cache.c (source_cache::ensure): Catch exception thrown during
3900         construction of the highlighter.
3901
3902 2019-09-18  Alan Modra  <amodra@gmail.com>
3903
3904         * aarch64-linux-tdep.c, * arm-tdep.c, * auto-load.c,
3905         * coff-pe-read.c, * coffread.c, * corelow.c, * dbxread.c,
3906         * dicos-tdep.c, * dwarf2-frame.c, * dwarf2read.c, * elfread.c,
3907         * exec.c, * fbsd-tdep.c, * gcore.c, * gdb_bfd.c, * gdb_bfd.h,
3908         * hppa-tdep.c, * i386-cygwin-tdep.c, * i386-fbsd-tdep.c,
3909         * i386-linux-tdep.c, * jit.c, * linux-tdep.c, * machoread.c,
3910         * maint.c, * mdebugread.c, * minidebug.c, * mips-linux-tdep.c,
3911         * mips-sde-tdep.c, * mips-tdep.c, * mipsread.c, * nto-tdep.c,
3912         * objfiles.c, * objfiles.h, * osabi.c, * ppc-linux-tdep.c,
3913         * ppc64-tdep.c, * record-btrace.c, * record-full.c, * remote.c,
3914         * rs6000-aix-tdep.c, * rs6000-tdep.c, * s390-linux-tdep.c,
3915         * s390-tdep.c, * solib-aix.c, * solib-dsbt.c, * solib-frv.c,
3916         * solib-spu.c, * solib-svr4.c, * solib-target.c,
3917         * spu-linux-nat.c, * spu-tdep.c, * symfile-mem.c, * symfile.c,
3918         * symmisc.c, * symtab.c, * target.c, * windows-nat.c,
3919         * xcoffread.c, * cli/cli-dump.c, * compile/compile-object-load.c,
3920         * mi/mi-interp.c: Update throughout for bfd section macro and
3921         function changes.
3922         * gcore (gcore_create_callback): Use bfd_set_section_lma.
3923         * spu-tdep.c (spu_overlay_new_objfile): Likewise.
3924
3925 2019-09-18  Tom Tromey  <tom@tromey.com>
3926
3927         * NEWS: Add entry.
3928         * tui/tui.c (tui_initialize_readline): Set name of keymap.  Do not
3929         call rl_initialize.
3930         (tui_enable): Do not call rl_initialize.
3931
3932 2019-09-18  Christian Groessler  <chris@groessler.org>
3933
3934         * alpha-linux-nat.c: Include gdbarch.h.
3935
3936 2019-09-18  Simon Marchi  <simon.marchi@polymtl.ca>
3937
3938         * ui-file.c: Include cli/cli-style.h.
3939         (term_cli_styling): Remove cli_styling declaration.
3940
3941 2019-09-18  Alan Modra  <amodra@gmail.com>
3942
3943         * arm-tdep.c (arm_record_special_symbol): Update bfd_get_section
3944         to bfd_asymbol_section.
3945
3946 2019-09-18  Alan Modra  <amodra@gmail.com>
3947
3948         * amd64-dicos-tdep.c (amd64_dicos_osabi_sniffer): Constify target.
3949         * i386-cygwin-tdep.c (i386_cygwin_init_abi): Likewise.
3950         * i386-dicos-tdep.c (i386_dicos_osabi_sniffer): Likewise.
3951
3952 2019-09-18  Alan Modra  <amodra@gmail.com>
3953
3954         * solib-spu.c (spu_bfd_open): Use bfd_set_filename.
3955         * spu-linux-nat.c (spu_bfd_open): Likewise.
3956
3957 2019-09-18  Christian Biesinger  <cbiesinger@google.com>
3958
3959         * dwarf2loc.c: Change extern declaration of dwarf_always_disassemble
3960         to bool to match definition in dwarf2read.c.
3961
3962 2019-09-17  Christian Biesinger  <cbiesinger@google.com>
3963
3964         * ada-lang.c (ada_ignore_descriptive_types_p): Change to bool.
3965         (print_signatures): Likewise.
3966         (trust_pad_over_xvs): Likewise.
3967         * arch/aarch64-insn.c (aarch64_debug): Likewise.
3968         * arch/aarch64-insn.h (aarch64_debug): Likewise.
3969         * arm-linux-nat.c (arm_apcs_32): Likewise.
3970         * arm-linux-tdep.c (arm_apcs_32): Likewise.
3971         * arm-nbsd-nat.c (arm_apcs_32): Likewise.
3972         * arm-tdep.c (arm_debug): Likewise.
3973         (arm_apcs_32): Likewise.
3974         * auto-load.c (debug_auto_load): Likewise.
3975         (auto_load_gdb_scripts): Likewise.
3976         (global_auto_load): Likewise.
3977         (auto_load_local_gdbinit): Likewise.
3978         (auto_load_local_gdbinit_loaded): Likewise.
3979         * auto-load.h (global_auto_load): Likewise.
3980         (auto_load_local_gdbinit): Likewise.
3981         (auto_load_local_gdbinit_loaded): Likewise.
3982         * breakpoint.c (disconnected_dprintf): Likewise.
3983         (breakpoint_proceeded): Likewise.
3984         (automatic_hardware_breakpoints): Likewise.
3985         (always_inserted_mode): Likewise.
3986         (target_exact_watchpoints): Likewise.
3987         (_initialize_breakpoint): Update.
3988         * breakpoint.h (target_exact_watchpoints): Change to bool.
3989         * btrace.c (maint_btrace_pt_skip_pad): Likewise.
3990         * cli/cli-cmds.c (trace_commands): Likewise.
3991         * cli/cli-cmds.h (trace_commands): Likewise.
3992         * cli/cli-decode.c (add_setshow_boolean_cmd): Change int* argument
3993         to bool*.
3994         * cli/cli-logging.c (logging_overwrite): Change to bool.
3995         (logging_redirect): Likewise.
3996         (debug_redirect): Likewise.
3997         * cli/cli-option.h (option_def) <boolean>: Change return type to bool*.
3998         (struct boolean_option_def) <get_var_address_cb_>: Change return type
3999         to bool.
4000         <boolean_option_def>: Update.
4001         (struct flag_option_def): Change default type of Context to bool
4002         from int.
4003         <flag_option_def>: Change return type of var_address_cb_ to bool*.
4004         * cli/cli-setshow.c (do_set_command): Cast to bool* instead of int*.
4005         (get_setshow_command_value_string): Likewise.
4006         * cli/cli-style.c (cli_styling): Change to bool.
4007         (source_styling): Likewise.
4008         * cli/cli-style.h (source_styling): Likewise.
4009         (cli_styling): Likewise.
4010         * cli/cli-utils.h (struct qcs_flags) <quiet, cont, silent>: Change
4011         to bool.
4012         * command.h (var_types): Update comment.
4013         (add_setshow_boolean_cmd): Change int* var argument to bool*.
4014         * compile/compile-cplus-types.c (debug_compile_cplus_types): Change to
4015         bool.
4016         (debug_compile_cplus_scopes): Likewise.
4017         * compile/compile-internal.h (compile_debug): Likewise.
4018         * compile/compile.c (compile_debug): Likewise.
4019         (struct compile_options) <raw>: Likewise.
4020         * cp-support.c (catch_demangler_crashes): Likewise.
4021         * cris-tdep.c (usr_cmd_cris_version_valid): Likewise.
4022         (usr_cmd_cris_dwarf2_cfi): Likewise.
4023         * csky-tdep.c (csky_debug): Likewise.
4024         * darwin-nat.c (enable_mach_exceptions): Likewise.
4025         * dcache.c (dcache_enabled_p): Likewise.
4026         * defs.h (info_verbose): Likewise.
4027         * demangle.c (demangle): Likewise.
4028         (asm_demangle): Likewise.
4029         * dwarf-index-cache.c (debug_index_cache): Likewise.
4030         * dwarf2-frame.c (dwarf2_frame_unwinders_enabled_p): Likewise.
4031         * dwarf2-frame.h (dwarf2_frame_unwinders_enabled_p): Likewise.
4032         * dwarf2read.c (check_physname): Likewise.
4033         (use_deprecated_index_sections): Likewise.
4034         (dwarf_always_disassemble): Likewise.
4035         * eval.c (overload_resolution): Likewise.
4036         * event-top.c (set_editing_cmd_var): Likewise.
4037         (exec_done_display_p): Likewise.
4038         * event-top.h (set_editing_cmd_var): Likewise.
4039         (exec_done_display_p): Likewise.
4040         * exec.c (write_files): Likewise.
4041         * fbsd-nat.c (debug_fbsd_lwp): Likewise
4042         (debug_fbsd_nat): Likewise.
4043         * frame.h (struct frame_print_options) <print_raw_frame_arguments>:
4044         Likewise.
4045         (struct set_backtrace_options) <backtrace_past_main>: Likewise.
4046         <backtrace_past_entry> Likewise.
4047         * gdb-demangle.h (demangle): Likewise.
4048         (asm_demangle): Likewise.
4049         * gdb_bfd.c (bfd_sharing): Likewise.
4050         * gdbcore.h (write_files): Likewise.
4051         * gdbsupport/common-debug.c (show_debug_regs): Likewise.
4052         * gdbsupport/common-debug.h (show_debug_regs): Likewise.
4053         * gdbthread.h (print_thread_events): Likewise.
4054         * gdbtypes.c (opaque_type_resolution): Likewise.
4055         (strict_type_checking): Likewise.
4056         * gnu-nat.c (gnu_debug_flag): Likewise.
4057         * guile/scm-auto-load.c (auto_load_guile_scripts): Likewise.
4058         * guile/scm-param.c (pascm_variable): Add boolval.
4059         (add_setshow_generic): Update.
4060         (pascm_param_value): Update.
4061         (pascm_set_param_value_x): Update.
4062         * hppa-tdep.c (hppa_debug): Change to bool..
4063         * infcall.c (may_call_functions_p): Likewise.
4064         (coerce_float_to_double_p): Likewise.
4065         (unwind_on_signal_p): Likewise.
4066         (unwind_on_terminating_exception_p): Likewise.
4067         * infcmd.c (startup_with_shell): Likewise.
4068         * inferior.c (print_inferior_events): Likewise.
4069         * inferior.h (startup_with_shell): Likewise.
4070         (print_inferior_events): Likewise.
4071         * infrun.c (step_stop_if_no_debug): Likewise.
4072         (detach_fork): Likewise.
4073         (debug_displaced): Likewise.
4074         (disable_randomization): Likewise.
4075         (non_stop): Likewise.
4076         (non_stop_1): Likewise.
4077         (observer_mode): Likewise.
4078         (observer_mode_1): Likewise.
4079         (set_observer_mode): Update.
4080         (sched_multi): Change to bool.
4081         * infrun.h (debug_displaced): Likewise.
4082         (sched_multi): Likewise.
4083         (step_stop_if_no_debug): Likewise.
4084         (non_stop): Likewise.
4085         (disable_randomization): Likewise.
4086         * linux-tdep.c (use_coredump_filter): Likewise.
4087         (dump_excluded_mappings): Likewise.
4088         * linux-thread-db.c (auto_load_thread_db): Likewise.
4089         (check_thread_db_on_load): Likewise.
4090         * main.c (captured_main_1): Update.
4091         * maint-test-options.c (struct test_options_opts) <flag_opt, xx1_opt,
4092         xx2_opt, boolean_opt>: Change to bool.
4093         * maint-test-settings.c (maintenance_test_settings_boolean): Likewise.
4094         * maint.c (maintenance_profile_p): Likewise.
4095         (per_command_time): Likewise.
4096         (per_command_space): Likewise.
4097         (per_command_symtab): Likewise.
4098         * memattr.c (inaccessible_by_default): Likewise.
4099         * mi/mi-main.c (mi_async): Likewise.
4100         (mi_async_1): Likewise.
4101         * mips-tdep.c (mips64_transfers_32bit_regs_p): Likewise.
4102         * nat/fork-inferior.h (startup_with_shell): Likewise.
4103         * nat/linux-namespaces.c (debug_linux_namespaces): Likewise.
4104         * nat/linux-namespaces.h (debug_linux_namespaces): Likewise.
4105         * nios2-tdep.c (nios2_debug): Likewise.
4106         * or1k-tdep.c (or1k_debug): Likewise.
4107         * parse.c (parser_debug): Likewise.
4108         * parser-defs.h (parser_debug): Likewise.
4109         * printcmd.c (print_symbol_filename): Likewise.
4110         * proc-api.c (procfs_trace): Likewise.
4111         * python/py-auto-load.c (auto_load_python_scripts): Likewise.
4112         * python/py-param.c (union parmpy_variable): Add "bool boolval" field.
4113         (set_parameter_value): Update.
4114         (add_setshow_generic): Update.
4115         * python/py-value.c (copy_py_bool_obj): Change argument from int*
4116         to bool*.
4117         * python/python.c (gdbpy_parameter_value): Cast to bool* instead of
4118         int*.
4119         * ravenscar-thread.c (ravenscar_task_support): Change to bool.
4120         * record-btrace.c (record_btrace_target::store_registers): Update.
4121         * record-full.c (record_full_memory_query): Change to bool.
4122         (record_full_stop_at_limit): Likewise.
4123         * record-full.h (record_full_memory_query): Likewise.
4124         * remote-notif.c (notif_debug): Likewise.
4125         * remote-notif.h (notif_debug): Likewise.
4126         * remote.c (use_range_stepping): Likewise.
4127         (interrupt_on_connect): Likewise.
4128         (remote_break): Likewise.
4129         * ser-tcp.c (tcp_auto_retry): Likewise.
4130         * ser-unix.c (serial_hwflow): Likewise.
4131         * skip.c (debug_skip): Likewise.
4132         * solib-aix.c (solib_aix_debug): Likewise.
4133         * spu-tdep.c (spu_stop_on_load_p): Likewise.
4134         (spu_auto_flush_cache_p): Likewise.
4135         * stack.c (struct backtrace_cmd_options) <full, no_filters, hide>:
4136         Likewise.
4137         (struct info_print_options) <quiet>: Likewise.
4138         * symfile-debug.c (debug_symfile): Likewise.
4139         * symfile.c (auto_solib_add): Likewise.
4140         (separate_debug_file_debug): Likewise.
4141         * symfile.h (auto_solib_add): Likewise.
4142         (separate_debug_file_debug): Likewise.
4143         * symtab.c (basenames_may_differ): Likewise.
4144         (struct filename_partial_match_opts) <dirname, basename>: Likewise.
4145         (struct info_print_options) <quiet, exclude_minsyms>: Likewise.
4146         (struct info_types_options) <quiet>: Likewise.
4147         * symtab.h (demangle): Likewise.
4148         (basenames_may_differ): Likewise.
4149         * target-dcache.c (stack_cache_enabled_1): Likewise.
4150         (code_cache_enabled_1): Likewise.
4151         * target.c (trust_readonly): Likewise.
4152         (may_write_registers): Likewise.
4153         (may_write_memory): Likewise.
4154         (may_insert_breakpoints): Likewise.
4155         (may_insert_tracepoints): Likewise.
4156         (may_insert_fast_tracepoints): Likewise.
4157         (may_stop): Likewise.
4158         (auto_connect_native_target): Likewise.
4159         (target_stop_and_wait): Update.
4160         (target_async_permitted): Change to bool.
4161         (target_async_permitted_1): Likewise.
4162         (may_write_registers_1): Likewise.
4163         (may_write_memory_1): Likewise.
4164         (may_insert_breakpoints_1): Likewise.
4165         (may_insert_tracepoints_1): Likewise.
4166         (may_insert_fast_tracepoints_1): Likewise.
4167         (may_stop_1): Likewise.
4168         * target.h (target_async_permitted): Likewise.
4169         (may_write_registers): Likewise.
4170         (may_write_memory): Likewise.
4171         (may_insert_breakpoints): Likewise.
4172         (may_insert_tracepoints): Likewise.
4173         (may_insert_fast_tracepoints): Likewise.
4174         (may_stop): Likewise.
4175         * thread.c (struct info_threads_opts) <show_global_ids>: Likewise.
4176         (make_thread_apply_all_options_def_group): Change argument from int*
4177         to bool*.
4178         (thread_apply_all_command): Update.
4179         (print_thread_events): Change to bool.
4180         * top.c (confirm): Likewise.
4181         (command_editing_p): Likewise.
4182         (history_expansion_p): Likewise.
4183         (write_history_p): Likewise.
4184         (info_verbose): Likewise.
4185         * top.h (confirm): Likewise.
4186         (history_expansion_p): Likewise.
4187         * tracepoint.c (disconnected_tracing): Likewise.
4188         (circular_trace_buffer): Likewise.
4189         * typeprint.c (print_methods): Likewise.
4190         (print_typedefs): Likewise.
4191         * utils.c (debug_timestamp): Likewise.
4192         (sevenbit_strings): Likewise.
4193         (pagination_enabled): Likewise.
4194         * utils.h (sevenbit_strings): Likewise.
4195         (pagination_enabled): Likewise.
4196         * valops.c (overload_resolution): Likewise.
4197         * valprint.h (struct value_print_options) <prettyformat_arrays,
4198         prettyformat_structs, vtblprint, unionprint, addressprint, objectprint,
4199         stop_print_at_null, print_array_indexes, deref_ref, static_field_print,
4200         pascal_static_field_print, raw, summary, symbol_print, finish_print>:
4201         Likewise.
4202         * windows-nat.c (new_console): Likewise.
4203         (cygwin_exceptions): Likewise.
4204         (new_group): Likewise.
4205         (debug_exec): Likewise.
4206         (debug_events): Likewise.
4207         (debug_memory): Likewise.
4208         (debug_exceptions): Likewise.
4209         (useshell): Likewise.
4210         * windows-tdep.c (maint_display_all_tib): Likewise.
4211         * xml-support.c (debug_xml): Likewise.
4212
4213 2019-09-17  Mike Gulick  <mgulick@mathworks.com>
4214
4215         * source.c (prepare_path_for_appending): New function.
4216         (openp): Make use of new function.
4217         (find_and_open_source): Search for the compilation directory and
4218         source file as a relative path beneath the directory search path.
4219
4220 2019-09-17  Andrew Burgess  <andrew.burgess@embecosm.com>
4221
4222         * source-cache.c (source_cache::get_line_charpos): Catch
4223         exceptions and return false, this matches the behaviour documented
4224         in the header file.
4225
4226 2019-09-17  Joel Brobecker  <brobecker@adacore.com>
4227
4228         * ada-tasks.c (info_task): Remove quoting of the task's name.
4229
4230 2019-09-16  Christian Biesinger  <cbiesinger@google.com>
4231
4232         * symfile.c (auto_solib_add): Replace comment with a reference
4233         to the header file.
4234
4235 2019-09-14  Christian Biesinger  <cbiesinger@google.com>
4236
4237         * NEWS: Mention that gdb can now be compiled with Python 3
4238         on Windows.
4239
4240 2019-09-12  Andrew Burgess  <andrew.burgess@embecosm.com>
4241
4242         * maint.c (maint_print_section_data::maint_print_section_data):
4243         Force use of 'float log10 (float)' by casting the argument to
4244         float.
4245
4246 2019-09-12  Andrew Burgess  <andrew.burgess@embecosm.com>
4247
4248         * maint.c: Add 'cmath' include.
4249         (struct maint_print_section_data): New structure.
4250         (print_section_index): New function.
4251         (print_bfd_section_info): Add header comment, small whitespace
4252         cleanup, and update to call new print_section_index function.
4253         (print_objfile_section_info): Likewise.
4254         (maint_obj_section_from_bfd_section): New function.
4255         (print_bfd_section_info_maybe_relocated): New function.
4256         (maintenance_info_sections): Add header comment, always use
4257         bfd_map_over_sections instead of ALL_OBJFILE_OSECTIONS.
4258
4259 2019-09-12  Andrew Burgess  <andrew.burgess@embecosm.com>
4260
4261         * psymtab.c (find_pc_sect_psymtab): Move baseaddr local into more
4262         inner scope, add check that the objfile has psymtabs before
4263         checking psymtabs_addrmap.
4264         * psymtab.h (psymtab_storage) <psymtabs_addrmap>: Extend comment.
4265
4266 2019-09-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4267
4268         * NEWS: Announce that Ada task names are now shown at more places,
4269         and between quotes (except in info task output).
4270         * gdb/ada-tasks.c (task_to_str): New function.
4271         (display_current_task_id): Call task_to_str.
4272         (task_command_1): Likewise.
4273         (print_ada_task_info): In non-mi mode, Properly align headers and data
4274         when task-id length is > 9 (9 is the default for a 32 bits CORE_ADDR).
4275
4276 2019-09-12  Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
4277
4278         * procfs.c (procfs_target::wait) <PR_FAULTED>: Get signal from
4279         prstatus.pr_lwp.pr_info instead of making it up.
4280
4281 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
4282
4283         * auto-load.c (auto_load_expand_dir_vars): Update.
4284         * defs.h (gdb_datadir): Change to std::string.
4285         (python_libdir): Likewise.
4286         (relocate_gdb_directory): Change return type to std::string.
4287         * guile/guile.c (gdbscm_data_directory): Update.
4288         (initialize_scheme_side): Update.
4289         * jit.c (jit_reader_dir): Change to std::string.
4290         (jit_reader_load_command): Update.
4291         * main.c (gdb_datadir): Change to std::string.
4292         (python_libdir): Likewise.
4293         (set_gdb_data_directory): Update.
4294         (relocate_path): Change to return std::string.
4295         (relocate_gdb_directory): Change to return std::string.
4296         (relocate_gdbinit_path_maybe_in_datadir): Update.
4297         (captured_main_1): Update.
4298         * python/python.c (do_start_initialization): Update.
4299         * top.c (show_gdb_datadir): Update.
4300         * xml-syscall.c (xml_init_syscalls_info): Update.
4301         (init_syscalls_info): Update.
4302
4303 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
4304
4305         * main.c (relocate_gdbinit_path_maybe_in_datadir): Factor this code
4306         out of get_init_files.
4307         (get_init_files): Update.
4308
4309 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
4310
4311         * main.c (get_init_files): Change to use std::string.
4312         (captured_main_1): Update.
4313         (print_gdb_help): Update.
4314
4315 2019-09-11  Ali Tamur  <tamur@google.com>
4316
4317         *gdb/target-float.c (host_float_ops<T>::to_longest): Update
4318         implementation.
4319
4320 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
4321
4322         * dbxread.c (read_dbx_symtab): Update.
4323         * dwarf2read.c (load_partial_dies): Update.
4324         * mdebugread.c (parse_partial_symbols): Update.
4325         (handle_psymbol_enumerators): Update.
4326         * psympriv.h (add_psymbol_to_list): Change type of copy_names to bool.
4327         * psymtab.c (add_psymbol_to_bcache): Likewise.
4328         (add_psymbol_to_list): Likewise.
4329         * symtab.c (symbol_set_names): Likewise.
4330         * symtab.h (symbol_set_names): Likewise.
4331         * xcoffread.c (scan_xcoff_symtab): Update.
4332
4333 2019-09-11  Tom Tromey  <tom@tromey.com>
4334
4335         * symfile-mem.c (symbol_file_add_from_memory): Use
4336         bfd_set_filename.
4337         * solib-darwin.c (darwin_bfd_open): Use bfd_set_filename.
4338         * solib-aix.c (solib_aix_bfd_open): Use bfd_set_filename.
4339
4340 2019-09-10  Tom Tromey  <tromey@adacore.com>
4341
4342         * dwarf-index-write.c (write_psymbols): Extend error message.
4343         (debug_names::insert): Add Ada code.
4344         (debug_names::write_psymbols): Remove Ada check.
4345         (debug_names) <m_string_obstack>: New member.
4346         * dwarf2read.c (gdb_index_symbol_name_matcher): Remove.
4347         (gdb_index_symbol_name_matcher::matches): Remove.
4348         (mapped_index_base::find_name_components_bounds): Add "lang"
4349         parameter.
4350         (mapped_index_base::build_name_components): Also split names
4351         according to Ada syntax.
4352         (dw2_expand_symtabs_matching_symbol): Loop over languages.  Change
4353         type of "match_callback".
4354         (check_match, check_find_bounds_finds)
4355         (dw2_expand_symtabs_matching): Update.
4356         (dw2_debug_names_iterator): Add new constructor.
4357         (dw2_debug_names_map_matching_symbols): New function.
4358         (dw2_debug_names_expand_symtabs_matching): Update.
4359         (dwarf2_debug_names_functions): Use
4360         dw2_debug_names_map_matching_symbols.
4361
4362 2019-09-10  Tom Tromey  <tromey@adacore.com>
4363
4364         * dwarf2read.c (dw2_get_file_names_reader): Add the
4365         CU's file name to the results.
4366
4367 2019-09-10  Tom Tromey  <tromey@adacore.com>
4368
4369         * ada-lang.c (add_nonlocal_symbols): Combine calls to
4370         map_matching_symbols.  Update.
4371         * dwarf2read.c (dw2_map_matching_symbols): Update.
4372         * psymtab.c (match_partial_symbol): Change type; update.
4373         (psym_map_matching_symbols): Likewise.
4374         * symfile-debug.c (debug_qf_map_matching_symbols): Change
4375         type; update.
4376         * symfile.h (struct quick_symbol_functions)
4377         <map_matching_symbols>: Change "name" to be a lookup_name_info.
4378         Remove "match".
4379
4380 2019-09-10  Tom Tromey  <tromey@adacore.com>
4381
4382         * psymtab.c (map_block): Remove.
4383         (psym_map_matching_symbols): Use iterate_over_symbols_terminated.
4384         * symtab.c (iterate_over_symbols_terminated): New function.
4385         * symtab.c (iterate_over_symbols_terminated): Declare.
4386
4387 2019-09-10  Tom Tromey  <tromey@adacore.com>
4388
4389         * ada-lang.c (ada_iterate_over_symbols): Return bool.
4390         * language.h (struct language_defn) <la_iterate_over_symbols>:
4391         Return bool.
4392         * symtab.c (iterate_over_symbols): Return bool.
4393         * symtab.h (iterate_over_symbols): Return bool.
4394
4395 2019-09-10  Tom Tromey  <tromey@adacore.com>
4396
4397         * ada-lang.c (aux_add_nonlocal_symbols): Change type.
4398         (add_nonlocal_symbols): Update.
4399         * dwarf2read.c (dw2_map_matching_symbols): Change type.
4400         * psymtab.c (map_block, psym_map_matching_symbols): Change type.
4401         * symfile-debug.c (debug_qf_map_matching_symbols): Change type.
4402         * symfile.h (struct quick_symbol_functions) <map_matching_symbols>:
4403         Change type of "callback".  Remove "data".
4404
4405
4406 2019-09-09  Ali Tamur  <tamur@google.com>
4407
4408         * dwarf2read.c (comp_unit_head): Update comment.
4409         (dwarf2_dwo_name): New function declaration.
4410         (dwarf_unit_type_name): New function declaration.
4411         (read_comp_unit_head): Add support for new compilation units,
4412         DW_UT_partial, DW_UT_skeleton, DW_UT_split_compile, DW_UT_split_type.
4413         Particularly, DW_UT_skeleton and DW_UT_split_compile have dwo_id
4414         (currently named as "signature") in their header. Also clarify error
4415         messages.
4416         (lookup_dwo_id): New function. Returns the dwo id of the given
4417         compile unit.
4418         (lookup_dwo_unit): Use the new lookup_dwo_id function.
4419         (init_cutu_and_read_dies): Use the new dwarf2_dwo_name and lookup_dwo_id
4420         functions.
4421         (create_dwo_cu_reader): Use the added lookup_dwo_id function.
4422         (dwarf2_dwo_name): Get the dwo name if present.
4423         (dwarf_unit_type_name): Convert DW_UT_* types to string for diagnostic
4424         purposes.
4425
4426 2019-09-09  Tom Tromey  <tom@tromey.com>
4427
4428         * tui/tui-win.c (tui_all_windows_info): Use ui_out.
4429
4430 2019-09-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4431
4432         * python/python.c (do_start_initialization): Make progname_copy static,
4433         to avoid a leak report.
4434
4435 2019-09-08  Tom Tromey  <tom@tromey.com>
4436
4437         * tui/tui-wingeneral.c (box_win): Truncate long window titles.
4438
4439 2019-09-07  Simon Marchi  <simon.marchi@efficios.com>
4440
4441         * dwarf2read.c (struct dw2_symtab_iterator) <block_index>:
4442         Change type to gdb::optional<block_enum>.
4443         (dw2_symtab_iter_init): Change block_index parameter type
4444         to gdb::optional<block_enum>.
4445         (dw2_lookup_symbol): Change block_index parameter
4446         type to block_enum.c
4447         (dw2_debug_names_lookup_symbol): Likewise.
4448         * psymtab.c (psym_lookup_symbol): Likewise.
4449         * symfile-debug.c (debug_qf_lookup_symbol): Likewise.
4450         * symfile.h (struct quick_symbol_functions) <lookup_symbol>:
4451         Likewise.
4452
4453 2019-09-06  Christian Biesinger  <cbiesinger@google.com>
4454
4455         * defs.h (relocate_gdb_directory): Change int to bool in
4456         signature and rename flag to relocatable.
4457         * main.c (relocate_path): Likewise.
4458         (relocate_gdb_directory): Likewise.
4459
4460 2019-09-06  Alan Modra  <amodra@gmail.com>
4461
4462         * coffread.c (coff_symfile_read): Constify filename variable.
4463         * dbxread.c (dbx_symfile_init, coffstab_build_psymtabs),
4464         (elfstab_build_psymtabs, stabsect_build_psymtabs): Likewise.
4465         * gdb_bfd.c (gdb_bfd_close_or_warn): Likewise.
4466         * solib.c (reload_shared_libraries_1): Likewise.
4467         * symfile.c (reread_symbols): Likewise.
4468         * solib-aix.c (solib_aix_bfd_open): Add cast for xfree of filename.
4469         * solib-darwin.c (darwin_bfd_open): Likewise.
4470         * symfile-mem.c (symbol_file_add_from_memory): Likewise.
4471
4472 2019-09-03  Andrew Burgess  <andrew.burgess@embecosm.com>
4473
4474         * psymtab.c (print_partial_symbols): Handle missing domain_enum
4475         values MODULE_DOMAIN and COMMON_BLOCK_DOMAIN.
4476
4477 2019-09-03  Tom Tromey  <tromey@adacore.com>
4478
4479         * ada-valprint.c (ada_val_print_num): Don't recurse for range
4480         types.
4481         (has_negatives): Unbias a range type bound.
4482         * dwarf2read.c (read_subrange_type): Handle DW_AT_GNU_bias.
4483         * gdbtypes.c (operator==): Handle new field.
4484         (create_range_type): Add "bias" parameter.
4485         (create_static_range_type, resolve_dynamic_range): Update.
4486         * gdbtypes.h (struct range_bounds) <bias>: New member.
4487         (create_range_type): Add bias parameter.
4488         * printcmd.c (print_scalar_formatted): Unbias range types.
4489         * value.c (unpack_long): Unbias range types.
4490         (pack_long): Bias range types.
4491
4492 2019-09-02  Alan Hayward  <alan.hayward@arm.com>
4493
4494         * solib-svr4.c (svr4_find_and_create_probe_breakpoints): Check all
4495         probe arguments.
4496
4497 2019-09-02  Alan Hayward  <alan.hayward@arm.com>
4498
4499         * break-catch-throw.c (fetch_probe_arguments): Use gdbarch.
4500         * dtrace-probe.c (dtrace_probe::get_argument_count): Likewise.
4501         * probe.c (probe_safe_evaluate_at_pc) (compute_probe_arg)
4502         (compile_probe_arg): Likewise.
4503         * probe.h (get_argument_count): Likewise.
4504         * solib-svr4.c (solib_event_probe_action): Likewise.
4505         * stap-probe.c (stap_probe::get_argument_count): Likewise.
4506
4507 2019-09-02  Alan Hayward  <alan.hayward@arm.com>
4508
4509         * solib-svr4.c (svr4_find_and_create_probe_breakpoints): Move
4510         code to here...
4511         (svr4_create_solib_event_breakpoints): ...from here.
4512
4513 2019-08-30  Sergio Durigan Junior  <sergiodj@redhat.com>
4514
4515         * nat/fork-inferior.c (trace_start_error): Remove "\nError: "
4516         suffix from warning message.
4517
4518 2019-08-30  Tom Tromey  <tom@tromey.com>
4519
4520         * tui/tui-winsource.h (struct tui_source_window_base)
4521         <refresh_all>: Don't declare.
4522         * tui/tui-winsource.c (tui_source_window_base::refresh_all):
4523         Remove.
4524         * tui/tui-win.c (tui_refresh_all_win): Don't call refresh_all or
4525         tui_show_locator_content.
4526         * tui/tui-regs.h (struct tui_data_window) <refresh_all>: Don't
4527         declare.
4528         * tui/tui-regs.c (tui_data_window::refresh_all): Remove.
4529         * tui/tui-data.h (struct tui_win_info) <refresh_all>: Don't
4530         declare.
4531
4532 2019-08-30  Tom Tromey  <tom@tromey.com>
4533
4534         * tui/tui-io.c (tui_cont_sig): Don't call wrefresh.
4535
4536 2019-08-30  Tom Tromey  <tom@tromey.com>
4537
4538         * tui/tui-stack.c (_initialize_tui_stack): Move later.
4539         Remove unnecessary forward declarations.
4540
4541 2019-08-30  Tom Tromey  <tom@tromey.com>
4542
4543         * tui/tui-stack.c (tui_locator_window::set_locator_fullname): Call
4544         rerender.
4545         (tui_update_locator_fullname, tui_show_frame_info): Don't call
4546         tui_show_locator_content.
4547
4548 2019-08-30  Tom Tromey  <tom@tromey.com>
4549
4550         * tui/tui-stack.c (tui_show_locator_content): Move lower.  Rewrite.
4551         (tui_locator_window::rerender): Rewrite using body of previous
4552         tui_show_locator_content.
4553
4554 2019-08-30  Tom Tromey  <tom@tromey.com>
4555
4556         * tui/tui-stack.h (struct tui_locator_window) <set_locator_info,
4557         set_locator_fullname>: New methods.
4558         * tui/tui-stack.c (tui_locator_window::set_locator_fullname):
4559         Rename from tui_set_locator_fullname.
4560         (tui_locator_window::set_locator_info): Rename from
4561         tui_set_locator_info.  Return bool.
4562         (tui_update_locator_fullname, tui_show_frame_info): Update.
4563
4564 2019-08-30  Tom Tromey  <tom@tromey.com>
4565
4566         * tui/tui-layout.c (show_layout): Don't call tui_refresh_all.
4567
4568 2019-08-30  Tom Tromey  <tom@tromey.com>
4569
4570         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Don't
4571         call touchwin.
4572
4573 2019-08-30  Tom Tromey  <tom@tromey.com>
4574
4575         * tui/tui-wingeneral.c (box_win): Assume win_info and
4576         win_info->handle cannot be NULL.
4577
4578 2019-08-30  Tom Tromey  <tom@tromey.com>
4579
4580         * tui/tui-regs.h (struct tui_data_item_window) <rerender,
4581         refresh_window>: Declare.
4582         * tui/tui-regs.c (tui_data_window::display_registers_from): Call
4583         resize.
4584         (tui_data_item_window::rerender): Rename from
4585         tui_display_register.
4586         (tui_data_item_window::refresh_window): New method.
4587         * tui/tui-layout.c (tui_gen_win_info::resize): Do nothing on
4588         no-op.
4589
4590 2019-08-30  Tom Tromey  <tom@tromey.com>
4591
4592         * tui/tui-regs.h (struct tui_data_window) <regs_content,
4593         regs_column_count, current_group>: Move later.  Now private.
4594         <get_current_group>: New method.
4595         * tui/tui-regs.c (tui_reg_command): Update.
4596         * tui/tui-layout.c (tui_set_layout): Update.
4597
4598 2019-08-30  Tom Tromey  <tom@tromey.com>
4599
4600         * tui/tui-regs.c (tui_data_window::display_registers_from_line)
4601         (tui_data_window::rerender): Don't call
4602         check_and_display_highlight_if_needed.
4603         (tui_data_window::refresh_all): Remove call to
4604         erase_data_content.
4605
4606 2019-08-30  Tom Tromey  <tom@tromey.com>
4607
4608         * tui/tui-regs.c (tui_data_window::last_regs_line_no)
4609         (tui_data_window::display_registers_from)
4610         (tui_data_window::display_reg_element_at_line)
4611         (tui_data_window::display_registers_from_line): Remove checks of
4612         "empty".
4613
4614 2019-08-30  Tom Tromey  <tom@tromey.com>
4615
4616         * tui/tui-regs.h (struct tui_data_window) <display_all_data>:
4617         Don't declare.
4618         * tui/tui-regs.c (tui_data_window::show_registers): Call
4619         rerender.
4620         (tui_data_window::rerender): Rename from display_all_data.
4621         (tui_data_window::rerender): Remove old implementation.
4622
4623 2019-08-30  Tom Tromey  <tom@tromey.com>
4624
4625         * tui/tui-regs.c (tui_data_window::display_all_data): Change
4626         text.
4627         * tui/tui-data.h (NO_DATA_STRING): Remove define.
4628
4629 2019-08-29  Bernhard Wodok  <barto@gmx.net>
4630             Sergio Durigan Junior  <sergiodj@redhat.com>
4631
4632         PR win32/24284
4633         * mingw-hdep.c (gdb_select): Handle case when 'n' is zero.
4634
4635 2019-08-28  Andrew Burgess  <andrew.burgess@embecosm.com>
4636
4637         * symtab.c (search_symbols): Don't include MODULE_DOMAIN symbols
4638         when searching for types.
4639
4640 2019-08-28  Andrew Burgess  <andrew.burgess@embecosm.com>
4641
4642         * f-lang.c (f_language_defn): Use f_print_typedef.
4643         * f-lang.h (f_print_typedef): Declare.
4644         * f-typeprint.c (f_print_typedef): Define.
4645
4646 2019-08-27  Christian Biesinger  <cbiesinger@google.com>
4647
4648         * nat/linux-namespaces.c (mnsh_main): Initialize fd (to -1).
4649
4650 2019-08-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4651
4652         * cli/cli-utils.c (info_print_options_defs): Delete.
4653         (make_info_print_options_def_group): Delete.
4654         (extract_info_print_options): Delete.
4655         (info_print_command_completer): Delete.
4656         (info_print_args_help): Add extra parameter, and optionally
4657         include text about -n flag.
4658         * cli/cli-utils.h (struct info_print_options): Delete.
4659         (extract_info_print_options): Delete declaration.
4660         (info_print_command_completer): Delete declaration.
4661         (info_print_args_help): Add extra parameter, extend header
4662         comment.
4663         * python/python.c (gdbpy_rbreak): Pass additional parameter to
4664         search_symbols.
4665         * stack.c (struct info_print_options): New type.
4666         (info_print_options_defs): New file scoped variable.
4667         (make_info_print_options_def_group): New static function.
4668         (info_print_command_completer): New static function.
4669         (info_locals_command): Update to use new local functions.
4670         (info_args_command): Likewise.
4671         (_initialize_stack): Add extra parameter to calls to
4672         info_print_args_help.
4673         * symtab.c (search_symbols): Add extra parameter, use this to
4674         possibly excluse non-debug symbols.
4675         (symtab_symbol_info): Add extra parameter, which is passed on to
4676         search_symbols.
4677         (struct info_print_options): New type.
4678         (info_print_options_defs): New file scoped variable.
4679         (make_info_print_options_def_group): New static function.
4680         (info_print_command_completer): New static function.
4681         (info_variables_command): Update to use local functions, and pass
4682         extra parameter through to symtab_symbol_info.
4683         (info_functions_command): Likewise.
4684         (info_types_command): Pass additional argument through to
4685         symtab_symbol_info.
4686         (rbreak_command): Pass extra argument to search_symbols.
4687         (_initialize_symtab): Add extra arguments for calls to
4688         info_print_args_help, and update help text for 'info variables',
4689         'whereis', and 'info functions' commands.
4690         * symtab.h (search_symbols): Add extra argument to declaration.
4691         * NEWS: Mention new flags.
4692
4693 2019-08-26  Christian Biesinger  <cbiesinger@google.com>
4694
4695         * symtab.c (lookup_static_symbol): Call the new function (and move
4696         it down to be next to lookup_global_symbol).
4697         (struct global_sym_lookup_data): Add block_enum member and rename to...
4698         (struct global_or_static_sym_lookup_data): ...this.
4699         (lookup_symbol_global_iterator_cb): Pass block_index instead of
4700         GLOBAL_BLOCK to lookup_symbol_in_objfile and rename to...
4701         (lookup_symbol_global_or_static_iterator_cb): ...this.
4702         (lookup_global_or_static_symbol): New function.
4703         (lookup_global_symbol): Call new function.
4704
4705 2019-08-26  Tom de Vries  <tdevries@suse.de>
4706
4707         PR c++/24852
4708         * break-catch-throw.c (fetch_probe_arguments): Improve error mesage
4709         when pc_probe.prob == NULL.
4710
4711 2019-08-25  Simon Marchi  <simon.marchi@efficios.com>
4712
4713         * dwarf2read.c (dw2_debug_names_iterator::next): Rename local
4714         variable symbol_linkage to symbol_linkage_.
4715
4716 2019-08-25  Simon Marchi  <simon.marchi@efficios.com>
4717
4718         * dwarf2read.c (dw2_debug_names_iterator::next): Use enum to
4719         represent whether the symbol is static, dynamic, or we don't
4720         know.
4721
4722 2019-08-25  Yoshinori Sato <ysato@users.sourceforge.jp>
4723
4724         * gdb/rx-tdep.c (rx_register_names): New.
4725         (rx_register_name): Delete.
4726         (rx_psw_type): Delete.
4727         (rx_fpsw_type): Delete.
4728         (rx_register_type): Delete.
4729         (rx_gdbarch_init): Convert target-descriptions.
4730         (_initialize_rx_tdep): Add initialize_tdesc_rx.
4731         * gdb/features/Makefile: Add rx.xml.
4732         * gdb/features/rx.xml: New.
4733         * gdb/features/rx.c: Generated.
4734         * gdb/NEWS: Mention target description support.
4735
4736 2019-08-22  Christian Biesinger  <cbiesinger@google.com>
4737
4738         * symtab.c (symbol_cache_lookup): Always initialize *bsc_ptr and
4739         *slot_ptr.
4740
4741 2019-08-23  Sergio Durigan Junior  <sergiodj@redhat.com>
4742
4743         * configure.ac: Don't check for 'dlfcn.h' (moved to
4744         gdbsupport/common.m4).
4745         * Makefile.in (COMMON_SFILES): Move 'gdb-dlfcn.c' to
4746         'gdbsupport/'.
4747         (HFILES_NO_SRCDIR): Likewise, for 'gdb-dlfcn.h'.
4748         * compile/compile-c-support.c: Include
4749         'gdbsupport/gdb-dlfcn.h'.
4750         * gdbsupport/common.m4: Check for 'dlfcn.h'.
4751         * gdb-dlfcn.c: Move to...
4752         * gdbsupport/gdb-dlfcn.c: ... here.
4753         * gdb-dlfcn.h: Move to...
4754         * gdbsupport/gdb-dlfcn.h: ... here.
4755
4756 2019-08-23  Sandra Loosemore  <sandra@codesourcery.com>
4757
4758         * nios2-tdep.c (struct reg_value): Improve comments.  Make
4759         the offset field signed.
4760
4761 2019-08-22  Christian Biesinger  <cbiesinger@google.com>
4762
4763         * python/lib/gdb/__init__.py (_execute_file): New function.
4764         * python/python.c (python_run_simple_file): Call gdb._execute_file
4765         on Windows.
4766
4767 2019-08-22  Andrew Burgess  <andrew.burgess@embecosm.com>
4768
4769         * f-exp.y (yylex): Remove is_a_field_of_this local variable, and
4770         all uses as this was never set to anything but a zero value.
4771
4772 2019-08-21  Bogdan Harjoc  <harjoc@gmail.com>
4773
4774         * cli/cli-cmds.c (with_command_1): Error out if no arguments.
4775
4776 2019-08-21  Christian Biesinger  <cbiesinger@google.com>
4777
4778         * tui/tui-data.h (tui_gen_win_info): Add an =default
4779         move constructor, required by some GCC versions.
4780
4781 2019-08-21  Jinke Fan  <fanjinke51@yeah.net>
4782
4783         * go32-nat.c (go32_sysinfo): Add hygon_p.
4784
4785 2019-08-20  Tom Tromey  <tom@tromey.com>
4786
4787         * tui/tui-regs.h (struct tui_data_window) <last_regs_line_no,
4788         line_from_reg_element_no, first_reg_element_no_inline,
4789         display_all_data, delete_data_content_windows,
4790         erase_data_content>: Now private.
4791
4792 2019-08-20  Tom Tromey  <tom@tromey.com>
4793
4794         * tui/tui-wingeneral.c (box_win): Change type of highlight_flag.
4795         (tui_unhighlight_win, tui_highlight_win)
4796         (tui_win_info::make_window): Update.
4797         * tui/tui-data.h (HILITE, NO_HILITE): Remove.
4798
4799 2019-08-20  Tom Tromey  <tom@tromey.com>
4800
4801         * tui/tui-data.h (PROC_PREFIX, LINE_PREFIX, PC_PREFIX)
4802         (MIN_LINE_WIDTH, MIN_PROC_WIDTH, MAX_TARGET_WIDTH)
4803         (MAX_PID_WIDTH): Move to tui-stack.c.
4804         * tui/tui-stack.c (PROC_PREFIX, LINE_PREFIX, PC_PREFIX)
4805         (MIN_LINE_WIDTH, MIN_PROC_WIDTH, MAX_TARGET_WIDTH)
4806         (MAX_PID_WIDTH): Move from tui-data.h.
4807
4808 2019-08-20  Tom Tromey  <tom@tromey.com>
4809
4810         * tui/tui-wingeneral.h (tui_make_window): Don't declare.
4811         * tui/tui-wingeneral.c (box_win): Change type of win_info.
4812         (box_win): Update.
4813         (tui_gen_win_info::make_window): Rename from tui_make_window.
4814         (tui_win_info::make_window): New method.
4815         (tui_gen_win_info::make_visible): Update.
4816         * tui/tui-source.c (tui_source_window::set_contents): Update.
4817         * tui/tui-regs.c (tui_data_window::show_register_group): Update.
4818         (tui_data_window::display_registers_from): Update.
4819         * tui/tui-layout.c (tui_gen_win_info::resize): Update.
4820         * tui/tui-data.h (struct tui_gen_win_info) <make_window>:
4821         Declare.
4822         <can_box>: Remove.
4823         <title>: Remove.
4824         (struct tui_win_info) <make_window>: Declare.
4825         <can_box>: Now virtual.
4826         <title>: New member.
4827         * tui/tui-data.c (~tui_gen_win_info): Don't free title.
4828         * tui/tui-command.c (tui_cmd_window::resize): Update.
4829
4830 2019-08-20  Tom Tromey  <tom@tromey.com>
4831
4832         * tui/tui-regs.h (struct tui_data_window) <display_regs>: Remove.
4833         * tui/tui-regs.c (tui_data_window::show_registers): Update.
4834         (tui_data_window::check_register_values): Update.
4835
4836 2019-08-20  Tom Tromey  <tom@tromey.com>
4837
4838         * tui/tui-regs.h (struct tui_data_window): Use
4839         DISABLE_COPY_AND_ASSIGN.
4840         <regs_content>: Change type, removing unique_ptr.
4841         <tui_data_window>: Add move constructor.
4842         * tui/tui-regs.c (tui_data_window::show_registers)
4843         (tui_data_window::show_register_group)
4844         (tui_data_window::display_registers_from)
4845         (tui_data_window::display_registers_from)
4846         (tui_data_window::first_data_item_displayed)
4847         (tui_data_window::delete_data_content_windows)
4848         (tui_data_window::rerender, tui_data_window::refresh_window)
4849         (tui_data_window::check_register_values): Update.
4850
4851 2019-08-20  Tom Tromey  <tom@tromey.com>
4852
4853         * tui/tui-regs.h (struct tui_data_window) <show_registers,
4854         show_register_group>: Declare.
4855         (tui_show_register_group): Don't declare.
4856         * tui/tui-regs.c (tui_data_window::show_registers): Rename from
4857         tui_show_registers.
4858         (tui_data_window::show_register_group): Rename from
4859         tui_show_register_group.
4860         (tui_data_window::check_register_values, tui_reg_command):
4861         Update.
4862         * tui/tui-layout.c (tui_set_layout): Update.
4863
4864 2019-08-20  Tom Tromey  <tom@tromey.com>
4865
4866         * tui/tui-regs.h (struct tui_data_window) <check_register_values>:
4867         Declare.
4868         (tui_check_register_values): Don't declare.
4869         * tui/tui-regs.c (tui_data_window::check_register_values): Rename
4870         from tui_check_register_values.
4871         * tui/tui-hooks.c (tui_register_changed): Update.
4872
4873 2019-08-20  Tom Tromey  <tom@tromey.com>
4874
4875         * tui/tui-regs.c (tui_reg_layout): Move later.
4876         (tui_show_registers): Don't enable TUI mode or change layout.
4877
4878 2019-08-20  Tom Tromey  <tom@tromey.com>
4879
4880         * tui/tui-regs.h (struct tui_data_item_window)
4881         <~tui_data_item_window>: Remove.
4882         <content>: Now a unique_xmalloc_ptr.
4883         * tui/tui-regs.c (tui_register_format): Return a
4884         unique_xmalloc_ptr.
4885         (tui_get_register): Update.
4886         (~tui_data_item_window): Remove.
4887         (tui_data_window::display_registers_from, tui_display_register):
4888         Update.
4889         * tui/tui-io.h (tui_expand_tabs): Update.
4890         * tui/tui-io.c (tui_expand_tabs): Return a unique_xmalloc_ptr.
4891         Remove "col" parameter.
4892
4893 2019-08-20  Tom Tromey  <tom@tromey.com>
4894
4895         * tui/tui-regs.h (struct tui_data_item_window) <value>: Remove
4896         field.
4897         * tui/tui-regs.c (~tui_data_item_window): Update.
4898
4899 2019-08-20  Tom Tromey  <tom@tromey.com>
4900
4901         * tui/tui-regs.c (tui_register_format, tui_get_register): Move
4902         earlier.
4903
4904 2019-08-20  Tom Tromey  <tom@tromey.com>
4905
4906         * tui/tui-regs.c (tui_reg_command): Remove NULL check.
4907
4908 2019-08-20  Tom Tromey  <tom@tromey.com>
4909
4910         * tui/tui-source.h (struct tui_source_window): Update.
4911         * tui/tui-regs.c (tui_show_registers): Update.
4912         * tui/tui-disasm.h (struct tui_disasm_window): Update.
4913         * tui/tui-data.h (NO_SRC_STRING, NO_DISASSEM_STRING)
4914         (NO_REGS_STRING): Remove defines.
4915
4916 2019-08-20  Conrad Meyer  <cem@FreeBSD.org>
4917
4918         * remote.c (remote_target::remote_btrace_maybe_reopen): Avoid
4919         unnecessary thread walk if remote doesn't support the packet.
4920
4921 2019-08-19  Tom Tromey  <tromey@adacore.com>
4922
4923         * python/py-value.c (value_has_field): Fix indentation.
4924
4925 2019-08-19  Tom Tromey  <tromey@adacore.com>
4926
4927         * printcmd.c (do_one_display, info_display_command): Update.
4928         * block.h (contained_in): Return bool.  Add allow_nested
4929         parameter.
4930         * block.c (contained_in): Return bool.  Add allow_nested
4931         parameter.
4932
4933 2019-08-19  Tom Tromey  <tom@tromey.com>
4934
4935         * configure: Rebuild.
4936         * configure.ac: Disallow the combination of -static-libstdc++ and
4937         source highlight.
4938         * source-cache.c (get_language_name): Handle rust.
4939         (source_cache::get_source_lines): Ignore highlighting exceptions.
4940
4941 2019-08-16  Tom Tromey  <tom@tromey.com>
4942
4943         * tui/tui.h (enum tui_win_type) <EXEC_INFO_WIN>: Remove.
4944         * tui/tui-winsource.h (struct tui_exec_info_window): Remove.
4945         (struct tui_source_window_base) <make_visible, refresh_window,
4946         resize>: Remove methods.
4947         <execution_info>: Remove field.
4948         * tui/tui-winsource.c (tui_source_window_base::do_erase_source_content)
4949         (tui_show_source_line, tui_source_window_base)
4950         (~tui_source_window_base): Update.
4951         (tui_source_window_base::resize)
4952         (tui_source_window_base::make_visible)
4953         (tui_source_window_base::refresh_window): Remove.
4954         (tui_source_window_base::update_exec_info): Update.
4955         * tui/tui-source.c (tui_source_window::set_contents): Update.
4956         * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
4957
4958 2019-08-16  Tom Tromey  <tom@tromey.com>
4959
4960         * tui/tui-hooks.c (tui_remove_hooks): Don't set
4961         deprecated_query_hook.
4962
4963 2019-08-16  Tom Tromey  <tom@tromey.com>
4964
4965         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
4966         (tui_update_source_windows_with_line): Update.
4967         * tui/tui-source.h (struct tui_source_window)
4968         <show_symtab_source>: Declare.
4969         (tui_show_symtab_source): Don't declare.
4970         * tui/tui-source.c (tui_show_symtab_source): Rename from
4971         tui_show_symtab_source.
4972
4973 2019-08-16  Tom Tromey  <tom@tromey.com>
4974
4975         * tui/tui-winsource.h (struct tui_source_window_base)
4976         <set_contents>: Declare.
4977         * tui/tui-winsource.c
4978         (tui_source_window_base::update_source_window_as_is): Update.
4979         * tui/tui-source.h (struct tui_source_window) <set_contents>:
4980         Declare.
4981         (tui_set_source_content): Don't declare.
4982         * tui/tui-source.c (tui_source_window::set_contents): Rename from
4983         tui_set_source_content.
4984         * tui/tui-disasm.h (struct tui_disasm_window) <set_contents>:
4985         Declare.
4986         (tui_set_disassem_content): Don't declare.
4987         * tui/tui-disasm.c (tui_disasm_window::set_contents): Rename from
4988         tui_set_disassem_content.
4989
4990 2019-08-16  Tom Tromey  <tom@tromey.com>
4991
4992         * tui/tui-winsource.h (struct tui_source_window_base)
4993         <update_breakpoint_info>: Declare.
4994         (tui_update_breakpoint_info): Don't declare.
4995         * tui/tui-winsource.c (tui_source_window_base::update_source_window_as_is)
4996         (tui_update_all_breakpoint_info): Update.
4997         (tui_source_window_base::update_breakpoint_info): Rename from
4998         tui_update_breakpoint_info.
4999         (tui_source_window_base::update_exec_info): Update.
5000
5001 2019-08-16  Tom Tromey  <tom@tromey.com>
5002
5003         * tui/tui-winsource.h (struct tui_source_window_base)
5004         <update_source_window>: Declare.
5005         (tui_update_source_window): Don't declare.
5006         * tui/tui-winsource.c
5007         (tui_source_window_base::update_source_window): Rename from
5008         tui_update_source_window.
5009         (tui_source_window_base::rerender): Update.
5010         * tui/tui-source.c (tui_source_window::maybe_update): Update.
5011         * tui/tui-disasm.c (tui_show_disassem)
5012         (tui_show_disassem_and_update_source)
5013         (tui_disasm_window::maybe_update): Update.
5014
5015 2019-08-16  Tom Tromey  <tom@tromey.com>
5016
5017         * tui/tui-winsource.h (struct tui_source_window_base)
5018         <update_source_window_as_is>: Declare.
5019         (tui_update_source_window_as_is): Don't declare.
5020         * tui/tui-winsource.c (tui_update_source_window): Update
5021         (tui_source_window_base::update_source_window_as_is): Rename from
5022         tui_update_source_window_as_is.
5023         (tui_source_window_base::refill): Update.
5024         * tui/tui-source.c (tui_show_symtab_source): Update.
5025         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical):
5026         Update.
5027
5028 2019-08-16  Tom Tromey  <tom@tromey.com>
5029
5030         * tui/tui-winsource.h (tui_update_source_window)
5031         (tui_update_source_window_as_is): Remove "noerror" parameter.
5032         * tui/tui-winsource.c (tui_update_source_window)
5033         (tui_update_source_window_as_is): Remove "noerror" parameter.
5034         (tui_update_source_windows_with_addr)
5035         (tui_update_source_windows_with_line)
5036         (tui_source_window_base::rerender)
5037         (tui_source_window_base::refill): Update.
5038         * tui/tui-source.h (tui_set_source_content)
5039         (tui_show_symtab_source): Remove "noerror" parameter.
5040         * tui/tui-source.c (tui_set_source_content): Remove "noerror"
5041         parameter.
5042         (tui_show_symtab_source): Likewise.
5043         (tui_source_window::maybe_update): Update.
5044         * tui/tui-disasm.c (tui_show_disassem)
5045         (tui_show_disassem_and_update_source)
5046         (tui_disasm_window::do_scroll_vertical)
5047         (tui_disasm_window::maybe_update): Update.
5048
5049 2019-08-16  Tom Tromey  <tom@tromey.com>
5050
5051         * tui/tui.c (tui_is_window_visible): Update.
5052         * tui/tui-wingeneral.c (tui_make_window)
5053         (tui_gen_win_info::make_visible, tui_refresh_all): Update.
5054         * tui/tui-win.c (window_name_completer, tui_refresh_all_win)
5055         (tui_set_focus_command, tui_all_windows_info, update_tab_width)
5056         (tui_set_win_height_command, parse_scrolling_args): Update.
5057         * tui/tui-source.c (tui_source_window::style_changed): Update.
5058         * tui/tui-regs.c (tui_show_registers)
5059         (tui_data_window::first_data_item_displayed)
5060         (tui_data_window::delete_data_content_windows)
5061         (tui_check_register_values, tui_reg_command): Update.
5062         * tui/tui-disasm.c (tui_show_disassem): Update.
5063         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: New
5064         method.
5065         <is_visible>: Remove field.
5066         * tui/tui-data.c (tui_next_win, tui_prev_win)
5067         (tui_delete_invisible_windows): Update.
5068
5069 2019-08-16  Tom Tromey  <tom@tromey.com>
5070
5071         * tui/tui-winsource.h (struct tui_source_window_base)
5072         <m_has_locator>: Remove.
5073         * tui/tui-layout.c (show_source_disasm_command, show_data)
5074         (show_source_or_disasm_and_command): Update.
5075
5076 2019-08-16  Alan Hayward  <alan.hayward@arm.com>
5077
5078         * NEWS (Other MI changes): New subsection.
5079         * aarch64-tdep.c (aarch64_get_pc_address_flags): New function.
5080         (aarch64_gdbarch_init): Add aarch64_get_pc_address_flags.
5081         * arch-utils.c (default_get_pc_address_flags): New function.
5082         * arch-utils.h (default_get_pc_address_flags): New declaration.
5083         * gdbarch.sh: Add get_pc_address_flags.
5084         * gdbarch.c: Regenerate.
5085         * gdbarch.h: Likewise.
5086         * stack.c (print_pc): New function.
5087         (print_frame_info) (print_frame): Call print_pc.
5088
5089 2019-08-16  Tom de Vries  <tdevries@suse.de>
5090
5091         * maint.c (maintenance_info_sections): Also handle !ALLOBJ case using
5092         print_objfile_section_info.
5093
5094 2019-08-15  Tom Tromey  <tom@tromey.com>
5095
5096         * tui/tui-io.c (tui_puts_internal): Check TUI_CMD_WIN before
5097         calling update_cmdwin_start_line.
5098         * tui/tui-winsource.h (struct tui_source_window_base)
5099         <do_make_visible_with_new_height, set_new_height>: Don't declare.
5100         <rerender>: Declare.
5101         * tui/tui-winsource.c (tui_source_window_base::update_tab_width):
5102         Call rerender.
5103         (tui_source_window_base::set_new_height): Remove.
5104         (tui_source_window_base::rerender): Rename from
5105         do_make_visible_with_new_height.
5106         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Use
5107         resize method.
5108         (tui_win_info::make_invisible_and_set_new_height)
5109         (tui_win_info::make_visible_with_new_height): Remove.
5110         * tui/tui-stack.h (struct tui_locator_window) <rerender>:
5111         Declare.
5112         * tui/tui-stack.c (tui_locator_window::rerender): New method.
5113         * tui/tui-regs.h (struct tui_data_window) <set_new_height,
5114         do_make_visible_with_new_height>: Don't declare.
5115         <rerender>: Declare.
5116         * tui/tui-regs.c (tui_data_window::rerender): Rename from
5117         set_new_height.
5118         (tui_data_window::do_make_visible_with_new_height): Remove.
5119         * tui/tui-layout.c (show_source_disasm_command, show_data): Don't
5120         call tui_show_locator_content.
5121         (tui_gen_win_info::resize): Call rerender.
5122         (show_source_or_disasm_and_command): Don't call
5123         tui_show_locator_content.
5124         * tui/tui-data.h (struct tui_gen_win_info) <rerender>: New
5125         method.
5126         (struct tui_win_info) <rerender>: Declare.
5127         <set_new_height, make_invisible_and_set_new_height,
5128         make_visible_with_new_height>: Don't declare.
5129         * tui/tui-data.c (tui_win_list::rerender): New method.
5130         * tui/tui-command.h (struct tui_cmd_window)
5131         <do_make_visible_with_new_height>: Don't declare.
5132         * tui/tui-command.c
5133         (tui_cmd_window::do_make_visible_with_new_height): Remove.
5134
5135 2019-08-15  Tom Tromey  <tromey@adacore.com>
5136
5137         * ada-exp.y (convert_char_literal): Handle "Q%c" encoding.
5138         * ada-lang.c (ada_enum_name): Likewise.
5139
5140 2019-08-15  Christian Biesinger  <cbiesinger@google.com>
5141
5142         * python/lib/gdb/__init__.py (GdbOutputFile): Rename to have a
5143         leading underscore.
5144         (GdbOutputErrorFile): Likewise.
5145         (global scope): Adjust constructor calls to GdbOutput{,Error}File
5146         accordingly.
5147         (execute_unwinders): Rename to have a leading underscore.
5148         (auto_load_packages): Likewise.
5149         (global scope): Adjust call to auto_load_packages accordingly.
5150         (GdbSetPythonDirectory): Likewise.
5151         * python/py-unwind.c (pyuw_sniffer): Call _execute_unwinders
5152         instead of execute_unwinders.
5153
5154 2019-08-15  Tom Tromey  <tom@tromey.com>
5155
5156         * tui/tui-layout.c (show_layout, show_source_disasm_command)
5157         (show_data): Don't change window visibility.
5158         (tui_gen_win_info::resize): Remove special case for command
5159         window.  Use wresize, when available.
5160         (show_source_or_disasm_and_command): Don't change window
5161         visibility.
5162         * tui/tui-command.h (struct tui_cmd_window) <resize>: Declare.
5163         <make_visible>: New method.
5164         * tui/tui-command.c (tui_cmd_window::resize): New method.
5165
5166 2019-08-15  Tom Tromey  <tom@tromey.com>
5167
5168         * tui/tui-winsource.h (struct tui_source_window_iterator): New.
5169         (struct tui_source_windows): New.
5170         * tui/tui-winsource.c (tui_display_main): Update.
5171         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
5172         (new_height_ok, parse_scrolling_args): Update.
5173         * tui/tui-layout.c (show_layout, show_data): Update.
5174         * tui/tui-data.h (tui_source_windows, tui_clear_source_windows)
5175         (tui_add_to_source_windows): Don't declare.
5176         * tui/tui-data.c (source_windows, tui_source_windows)
5177         (tui_clear_source_windows, tui_add_to_source_windows): Remove.
5178
5179 2019-08-15  Tom Tromey  <tom@tromey.com>
5180
5181         * tui/tui-winsource.h (struct tui_source_window_base) <resize>:
5182         Rename from reset.
5183         * tui/tui-winsource.c (tui_source_window_base::resize): Rename.
5184         * tui/tui-layout.c (show_source_disasm_command, show_data):
5185         Update.
5186         (tui_gen_win_info::resize): Rename.
5187         (show_source_or_disasm_and_command): Update.
5188         * tui/tui-data.h (struct tui_gen_win_info) <resize>: Rename from
5189         reset.
5190
5191 2019-08-15  Tom Tromey  <tom@tromey.com>
5192
5193         * tui/tui-stack.c (tui_initialize_static_data): Remove.
5194         * tui/tui-interp.c (tui_interp::init): Don't call
5195         tui_initialize_static_data.
5196         * tui/tui-data.h (tui_initialize_static_data): Don't declare.
5197
5198 2019-08-15  Tom Tromey  <tom@tromey.com>
5199
5200         * tui/tui-layout.c (tui_default_win_viewport_height): Don't
5201         examine tui_win_list.
5202
5203 2019-08-15  Tom Tromey  <tom@tromey.com>
5204
5205         * tui/tui-winsource.h (tui_clear_source_content): Don't declare.
5206         * tui/tui-winsource.c (tui_update_source_window_as_is): Don't call
5207         tui_clear_source_content.
5208         (tui_clear_source_content): Remove.
5209         (tui_source_window_base::do_erase_source_content): Hoist call to
5210         content.clear().
5211         * tui/tui-stack.c (tui_show_frame_info): Don't call
5212         tui_clear_source_content.
5213
5214 2019-08-15  Tom Tromey  <tom@tromey.com>
5215
5216         * tui/tui-winsource.h (struct tui_source_window_base)
5217         <do_erase_source_content>: New method.
5218         <erase_source_content>: New method.
5219         (tui_erase_source_content): Don't declare.
5220         * tui/tui-winsource.c (tui_clear_source_content): Update.
5221         (tui_source_window_base::do_erase_source_content): Rename from
5222         tui_erase_source_content.
5223         (tui_source_window_base::show_source_content): Update.
5224         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
5225         * tui/tui-source.h (struct tui_source_window)
5226         <erase_source_content>: New method.
5227         * tui/tui-disasm.h (struct tui_disasm_window)
5228         <erase_source_content>: New method.
5229
5230 2019-08-15  Tom Tromey  <tom@tromey.com>
5231
5232         * tui/tui-winsource.h (tui_alloc_source_buffer): Don't declare.
5233         (struct tui_source_element): Add DISABLE_COPY_AND_ASSIGN, and move
5234         constructor.
5235         * tui/tui-winsource.c (tui_alloc_source_buffer): Remove.
5236         * tui/tui-source.c (tui_set_source_content): Update.
5237         * tui/tui-disasm.c (tui_set_disassem_content): Update.
5238
5239 2019-08-15  Tom Tromey  <tom@tromey.com>
5240
5241         * tui/tui-winsource.h (tui_line_is_displayed): Don't declare.
5242         * tui/tui-winsource.c (tui_line_is_displayed): Move to
5243         tui-source.c.
5244         * tui/tui-source.h (struct tui_source_window) <line_is_displayed>:
5245         Declare.
5246         * tui/tui-source.c (tui_source_window::line_is_displayed): New
5247         method.
5248         (tui_source_window::maybe_update): Update.
5249
5250 2019-08-15  Tom Tromey  <tom@tromey.com>
5251
5252         * tui/tui-winsource.h (tui_addr_is_displayed): Don't declare.
5253         * tui/tui-winsource.c (tui_addr_is_displayed): Move to
5254         tui-disasm.c.
5255         * tui/tui-disasm.h (struct tui_disasm_window) <addr_is_displayed>:
5256         Declare.
5257         * tui/tui-disasm.c (tui_disasm_window::addr_is_displayed): New
5258         method.
5259         (tui_disasm_window::maybe_update): Update.
5260
5261 2019-08-15  Tom Tromey  <tom@tromey.com>
5262
5263         * tui/tui-winsource.h (struct tui_source_window_base)
5264         <maybe_update>: Declare.
5265         * tui/tui-stack.c (tui_show_frame_info): Call maybe_update
5266         method.
5267         * tui/tui-source.h (struct tui_source_window) <maybe_update>:
5268         Declare.
5269         * tui/tui-source.c (tui_source_window::maybe_update): New method.
5270         * tui/tui-disasm.h (struct tui_disasm_window) <maybe_update>:
5271         Declare.
5272         * tui/tui-disasm.c (tui_disasm_window::maybe_update): New method.
5273
5274 2019-08-15  Tom Tromey  <tom@tromey.com>
5275
5276         * tui/tui-stack.c (tui_make_status_line): Use string constructor.
5277
5278 2019-08-15  Tom Tromey  <tom@tromey.com>
5279
5280         * tui/tui-wingeneral.c: Include tui-stack.h.
5281         * tui/tui-stack.h (MAX_LOCATOR_ELEMENT_LEN)
5282         (struct tui_locator_window): Move from tui-data.h.
5283         * tui/tui-stack.c (_locator, tui_locator_win_info_ptr)
5284         (tui_initialize_static_data): Move from tui-data.c.
5285         * tui/tui-data.h (MAX_LOCATOR_ELEMENT_LEN)
5286         (struct tui_locator_window): Move to tui-stack.c.
5287         * tui/tui-data.c (_locator, tui_locator_win_info_ptr)
5288         (tui_initialize_static_data): Move to tui-stack.c.
5289
5290 2019-08-15  Tom Tromey  <tom@tromey.com>
5291
5292         * tui/tui-layout.c (show_source_disasm_command)
5293         (show_source_or_disasm_and_command): Use make_visible method, not
5294         tui_make_window.
5295         * tui/tui-command.h (struct tui_cmd_window) <make_visible>:
5296         Remove.
5297
5298 2019-08-15  Tom Tromey  <tom@tromey.com>
5299
5300         * tui/tui-wingeneral.h (tui_make_window): Update.
5301         * tui/tui-wingeneral.c (tui_make_window): Remove "box_it"
5302         parameter.
5303         (tui_gen_win_info::make_visible): Update.
5304         * tui/tui-regs.c (tui_data_window::display_registers_from):
5305         Update.
5306         * tui/tui-layout.c (show_source_disasm_command)
5307         (show_source_or_disasm_and_command): Update.
5308         * tui/tui-data.h (struct tui_gen_win_info) <can_box>: New method.
5309         (enum tui_box): Remove.
5310         (struct tui_win_info) <can_box>: New method.
5311         * tui/tui-command.h (struct tui_cmd_window) <can_box>: New
5312         method.
5313
5314 2019-08-15  Tom de Vries  <tdevries@suse.de>
5315
5316         * linux-nat-trad.c: Include gdbarch.h.
5317
5318 2019-08-14  Alan Hayward  <alan.hayward@arm.com>
5319
5320         * aarch64-tdep.c (aarch64_analyze_prologue): Allow any valid
5321         register sizes.
5322
5323 2019-08-14  Tom Tromey  <tromey@adacore.com>
5324
5325         * darwin-nat.c: Include gdbarch.h.
5326         * darwin-nat-info.c: Include gdbarch.h.
5327
5328 2019-08-13  Tom Tromey  <tom@tromey.com>
5329
5330         * tui/tui-data.h (struct tui_gen_win_info) <last_visible_line>:
5331         Remove.
5332         * tui/tui-data.c (tui_initialize_static_data): Update.
5333
5334 2019-08-13  Tom Tromey  <tom@tromey.com>
5335
5336         * tui/tui-winsource.h (struct tui_exec_info_window)
5337         <~tui_exec_info_window, maybe_allocate_content, get_content,
5338         m_content>: Remove.
5339         (struct tui_source_window_base) <set_exec_info_content,
5340         show_exec_info_content>: Don't declare.
5341         * tui/tui-winsource.c
5342         (tui_exec_info_window::maybe_allocate_content): Remove.
5343         (tui_source_window_base::update_exec_info): Rename from
5344         set_exec_info_content.
5345         (tui_source_window_base::show_exec_info_content)
5346         (tui_source_window_base::update_exec_info): Remove.
5347
5348 2019-08-13  Tom Tromey  <tom@tromey.com>
5349
5350         * tui/tui-winsource.h (tui_clear_exec_info_content): Don't
5351         declare.
5352         * tui/tui-winsource.c (tui_update_source_window_as_is)
5353         (tui_update_source_windows_with_addr, tui_erase_source_content):
5354         Update.
5355         (tui_clear_exec_info_content): Remove.
5356
5357 2019-08-13  Tom Tromey  <tom@tromey.com>
5358
5359         * tui/tui-winsource.h (tui_erase_exec_info_content): Don't
5360         declare.
5361         * tui/tui-winsource.c (tui_source_window_base::refresh_all): Don't
5362         call tui_erase_exec_info_content.
5363         (tui_clear_exec_info_content): Rename from
5364         tui_erase_exec_info_content.
5365         (tui_clear_exec_info_content): Delete.
5366
5367 2019-08-13  Tom Tromey  <tom@tromey.com>
5368
5369         * tui/tui-winsource.h (struct tui_source_window_base)
5370         <show_exec_info_content>: Declare.
5371         (tui_show_exec_info_content): Don't declare.
5372         * tui/tui-winsource.c
5373         (tui_source_window_base::show_exec_info_content): Rename from
5374         tui_show_exec_info_content.
5375         (tui_source_window_base::update_exec_info): Update.
5376
5377 2019-08-13  Tom Tromey  <tom@tromey.com>
5378
5379         * tui/tui-data.h (enum tui_bp_flag, tui_bp_flags, struct tui_source_element)
5380         (TUI_BP_HIT_POS, TUI_BP_BREAK_POS, TUI_EXEC_POS)
5381         (TUI_EXECINFO_SIZE, tui_exec_info_content): Move ...
5382         * tui/tui-winsource.h (enum tui_bp_flag, tui_bp_flags, struct
5383         tui_source_element, TUI_BP_HIT_POS, TUI_BP_BREAK_POS)
5384         (TUI_EXEC_POS, TUI_EXECINFO_SIZE, tui_exec_info_content):
5385         ... here.
5386
5387 2019-08-13  Tom Tromey  <tom@tromey.com>
5388
5389         * tui/tui-winsource.h (struct tui_source_window_base)
5390         <update_exec_info>: Declare.
5391         (tui_update_exec_info): Don't declare.
5392         * tui/tui-winsource.c (tui_update_source_window_as_is)
5393         (tui_source_window_base::refresh_all)
5394         (tui_update_all_breakpoint_info): Update.
5395         (tui_source_window_base::update_exec_info): Rename from
5396         tui_update_exec_info.
5397         * tui/tui-stack.c (tui_show_frame_info): Update.
5398
5399 2019-08-13  Tom Tromey  <tom@tromey.com>
5400
5401         * tui/tui-winsource.h (struct tui_source_window_base)
5402         <set_exec_info_content>: Declare.
5403         (tui_set_exec_info_content): Don't declare.
5404         * tui/tui-winsource.c
5405         (tui_source_window_base::set_exec_info_content): Rename from
5406         tui_set_exec_info_content.
5407         (tui_update_exec_info): Update.
5408
5409 2019-08-13  Tom Tromey  <tom@tromey.com>
5410
5411         * tui/tui-winsource.h (struct tui_source_window_base)
5412         <show_source_content>: Declare.
5413         (tui_show_source_content): Don't declare.
5414         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
5415         (tui_source_window_base::show_source_content): Rename from
5416         tui_show_source_content.
5417         (tui_source_window_base::refresh_all): Update.
5418         * tui/tui-layout.c (show_source_disasm_command)
5419         (show_source_or_disasm_and_command): Update.
5420
5421 2019-08-13  Tom Tromey  <tom@tromey.com>
5422
5423         * tui/tui-winsource.c (tui_erase_source_content)
5424         (tui_show_source_content, tui_source_window_base::refresh_all):
5425         Update.
5426         * tui/tui-wingeneral.h
5427         (tui_check_and_display_highlight_if_needed): Don't declare.
5428         * tui/tui-wingeneral.c
5429         (tui_win_info::check_and_display_highlight_if_needed): Rename from
5430         check_and_display_highlight_if_needed.
5431         * tui/tui-win.c (tui_rehighlight_all)
5432         (tui_win_info::make_visible_with_new_height): Update.
5433         * tui/tui-regs.c (tui_data_window::display_registers_from_line)
5434         (tui_data_window::erase_data_content)
5435         (tui_data_window::display_all_data): Update.
5436         * tui/tui-data.h (struct tui_win_info)
5437         <check_and_display_highlight_if_needed>: Declare.
5438
5439 2019-08-13  Tom Tromey  <tom@tromey.com>
5440
5441         * tui/tui-win.c (tui_resize_all): Call
5442         tui_delete_invisible_windows.
5443         * tui/tui-layout.c (show_layout): Call
5444         tui_delete_invisible_windows.
5445         * tui/tui-data.h (tui_delete_invisible_windows): Declare.
5446         * tui/tui-data.c (tui_delete_invisible_windows): New function.
5447
5448 2019-08-13  Tom Tromey  <tom@tromey.com>
5449
5450         * tui/tui-disasm.c (tui_show_disassem): Add assertion.  Don't call
5451         tui_add_win_to_layout.
5452
5453 2019-08-13  Tom Tromey  <tom@tromey.com>
5454
5455         * tui/tui-layout.h (tui_default_win_height): Don't declare.
5456         * tui/tui-layout.c (tui_default_win_height): Now static.
5457
5458 2019-08-13  Tom Tromey  <tom@tromey.com>
5459
5460         * tui/tui-layout.c (show_layout): Unify all layout cases into a
5461         single switch.
5462         (show_source_disasm_command, show_source_or_disasm_and_command):
5463         Don't check current layout.
5464
5465 2019-08-13  Tom Tromey  <tom@tromey.com>
5466
5467         * tui/tui-wingeneral.c (make_all_visible): Remove.
5468         (tui_make_all_invisible): Simplify.
5469         * tui/tui-layout.c (tui_make_all_invisible): Move from
5470         tui-wingeneral.c; simplify.
5471         (show_layout): Hoist call to tui_make_all_invisible.
5472         (show_data): Don't call tui_make_all_invisible.
5473
5474 2019-08-13  Tom Tromey  <tom@tromey.com>
5475
5476         * tui/tui-wingeneral.h (tui_make_all_visible): Don't declare.
5477         * tui/tui-wingeneral.c (tui_make_all_visible): Remove.
5478
5479 2019-08-13  Tom Tromey  <tom@tromey.com>
5480
5481         * tui/tui-layout.c (current_layout, tui_current_layout): Move from
5482         tui-data.c.
5483         (show_source_disasm_command, show_data)
5484         (show_source_or_disasm_and_command): Don't use
5485         tui_set_current_layout_to.
5486         * tui/tui-data.h (tui_set_current_layout_to): Don't declare.
5487         * tui/tui-data.c (current_layout, tui_current_layout): Move to
5488         tui-layout.c.
5489         (tui_set_current_layout_to): Remove.
5490
5491 2019-08-13  Tom Tromey  <tom@tromey.com>
5492
5493         * tui/tui-layout.c (tui_set_layout): Update.
5494         * tui/tui-data.h (struct tui_layout_def): Remove.
5495         (tui_layout_def): Don't declare.
5496         * tui/tui-data.c (layout_def): Remove.
5497         (tui_layout_def): Remove.
5498
5499 2019-08-13  Tom Tromey  <tom@tromey.com>
5500
5501         * tui/tui-winsource.h (struct tui_source_window_base)
5502         <clear_detail>: No longer "override".
5503         * tui/tui-regs.h (struct tui_data_window) <clear_detail>: Remove.
5504         * tui/tui-regs.c (tui_data_window::clear_detail): Remove.
5505         * tui/tui-data.h (struct tui_win_info) <clear_detail>: Remove.
5506         * tui/tui-command.h (struct tui_cmd_window) <clear_detail>:
5507         Remove.
5508         * tui/tui-command.c (tui_cmd_window::clear_detail): Remove.
5509
5510 2019-08-13  Tom Tromey  <tromey@adacore.com>
5511
5512         * tracepoint.c: Don't include readline.h or history.h.
5513
5514 2019-08-12  Tom Tromey  <tom@tromey.com>
5515
5516         * configure: Rebuild.
5517         * configure.ac: Check for readline 7.
5518         * NEWS: Mention readline 7 requirement.
5519         * README: Update.
5520
5521 2019-08-12  Tom Tromey  <tom@tromey.com>
5522
5523         * mingw-hdep.c (gdb_select): Remove readline hack.
5524
5525 2019-08-09  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
5526
5527         * blockframe.c (find_pc_partial_function): Set *block to nullptr
5528         when the function fails.
5529
5530 2019-08-09  Andreas Arnez  <arnez@linux.ibm.com>
5531
5532         * s390-tdep.c (s390_type_align): New function.
5533         (s390_gdbarch_init): Set it as type_align gdbarch method.
5534
5535 2019-08-09  Tom de Vries  <tdevries@suse.de>
5536
5537         PR gdb/24591
5538         * dwarf2read.c (dwarf2_fetch_die_loc_sect_off): Adjust pc_high and
5539         pc_low with relocation offset.
5540
5541 2019-08-07  Tom Tromey  <tromey@adacore.com>
5542
5543         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
5544         (print_frame_args): Update.
5545         * python/py-framefilter.c (py_print_single_arg, enumerate_args):
5546         Update.
5547         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
5548         * frame.h (struct frame_arg): Add initializers.
5549         <error>: Now a unique_xmalloc_ptr.
5550
5551 2019-08-07  Alan Hayward  <alan.hayward@arm.com>
5552
5553         * NEWS: Expand the Pointer Authentication entry.
5554         * aarch64-tdep.c (aarch64_frame_unmask_address): Rename from this.
5555         (aarch64_frame_unmask_lr): ... to this.
5556         (aarch64_prologue_prev_register, aarch64_dwarf2_prev_register):
5557         Call aarch64_frame_unmask_lr.
5558         * frame.c (struct frame_info): Add "masked" variable.
5559         (frame_set_previous_pc_masked) (frame_get_pc_masked): New functions.
5560         (fprint_frame): Check for masked pc.
5561         * frame.h (frame_set_previous_pc_masked) (frame_get_pc_masked): New
5562         declarations.
5563         * python/py-framefilter.c (py_print_frame): Check for masked pc.
5564         * stack.c (print_frame): Check for masked pc.
5565
5566 2019-08-06  Tom Tromey  <tom@tromey.com>
5567
5568         * stabsread.c (patch_block_stabs, read_one_struct_field)
5569         (read_enum_type): Use obstack_strndup.
5570         * rust-exp.y (rust_parser::copy_name): Use obstack_strndup.
5571         * gdb_obstack.h (obstack_strndup): Use obstack_strndup.
5572         * dwarf2read.c (guess_full_die_structure_name)
5573         (anonymous_struct_prefix): Use obstack_strndup.
5574         * dbxread.c (cp_set_block_scope): Use obstack_strndup.
5575         * c-exp.y (yylex): Use obstack_strndup.
5576         * ada-exp.y (write_object_renaming, write_ambiguous_var)
5577         (write_var_or_type): Use obstack_strndup.
5578
5579 2019-08-06  Tom Tromey  <tom@tromey.com>
5580
5581         * symfile.c (reread_symbols): Use obstack_strdup.
5582         * stabsread.c (read_type): Use obstack_strdup.
5583         * gdb_obstack.h (obstack_strdup): New overload.
5584         * dwarf2read.c (dwarf2_compute_name, create_dwo_unit_in_dwp_v1)
5585         (create_dwo_unit_in_dwp_v2, build_error_marker_type)
5586         (dwarf2_canonicalize_name): Use obstack_strdup.
5587         * dbxread.c (read_dbx_symtab): Use obstack_strdup.
5588         * cp-support.c (inspect_type, replace_typedefs_qualified_name):
5589         Use obstack_strdup.
5590
5591 2019-08-06  Tom Tromey  <tom@tromey.com>
5592
5593         * gdb_obstack.h (obstack_strdup): Define.
5594         * gdb_obstack.c (obstack_strdup): Don't define.
5595
5596 2019-08-06  Tom Tromey  <tom@tromey.com>
5597
5598         * xcoffread.c (SYMNAME_ALLOC, process_xcoff_symbol): Use
5599         obstack_strdup.
5600         * typeprint.c (typedef_hash_table::find_global_typedef): Use
5601         obstack_strdup.
5602         * symfile.c (allocate_compunit_symtab): Use obstack_strdup.
5603         * stabsread.c (common_block_start): Use obstack_strdup.
5604         * objfiles.c (set_objfile_main_name, objfile): Use
5605         obstack_strdup.
5606         * namespace.c (add_using_directive): Use obstack_strdup.
5607         * mdebugread.c (parse_symbol, parse_type): Use obstack_strdup.
5608         * jit.c (finalize_symtab): Use obstack_strdup.
5609         * dwarf2read.c (fixup_go_packaging, dwarf2_physname)
5610         (guess_partial_die_structure_name, partial_die_info::fixup)
5611         (dwarf2_name): Use obstack_strdup.
5612         * coffread.c (coff_read_struct_type, coff_read_enum_type): Use
5613         obstack_strdup.
5614         * c-exp.y (scan_macro_expansion): Use obstack_strdup.
5615         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
5616         obstack_strdup.
5617         * ada-lang.c (ada_decode_symbol): Use obstack_strdup.
5618
5619 2019-08-07  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5620
5621         * unittests/help-doc-selftests.c: New file.
5622         * Makefile.in: Add the new file.
5623
5624 2019-08-07  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5625
5626         * cli/cli-decode.h (print_doc_line): Add for_value_prefix argument.
5627         * cli/cli-decode.c (print_doc_line): Likewise.  It now prints
5628         the full first line, except when FOR_VALUE_PREFIX.  In this case,
5629         the trailing '.' is not output, and the first character is uppercased.
5630         (print_help_for_command): Update call to print_doc_line.
5631         (print_doc_of_command): Likewise.
5632         * cli/cli-setshow.c (deprecated_show_value_hack): Likewise.
5633         * cli/cli-option.c (append_indented_doc): Do not append newline.
5634         (build_help_option): Append newline after first appended_indented_doc
5635         only if a second call is done.
5636         (build_help): Append 2 new lines before each option, except the first
5637         one.
5638         * compile/compile.c (_initialize_compile): Add new lines after
5639         %OPTIONS%, when not at the end of the help.
5640         Change help doc or code
5641         producing the help doc to respect the invariants.
5642         * maint-test-options.c (_initialize_maint_test_options): Likewise.
5643         Also removed the new line after 'Options:', as all other commands
5644         do not put an empty line between 'Options:' and the first option.
5645         * printcmd.c (_initialize_printcmd): Likewise.
5646         * stack.c (_initialize_stack): Likewise.
5647         * interps.c (interpreter_exec_cmd): Fix "Usage:" line that was
5648         incorrectly telling COMMAND is optional.
5649         * ada-lang.c (_initialize_ada_language): Change help doc or code
5650         producing the help doc to respect the invariants.
5651         * ada-tasks.c (_initialize_ada_tasks): Likewise.
5652         * breakpoint.c (_initialize_breakpoint): Likewise.
5653         * cli/cli-cmds.c (_initialize_cli_cmds): Likewise.
5654         * cli/cli-logging.c (_initialize_cli_logging): Likewise.
5655         * cli/cli-setshow.c (_initialize_cli_setshow): Likewise.
5656         * cli/cli-style.c (cli_style_option::add_setshow_commands,
5657         _initialize_cli_style): Likewise.
5658         * corelow.c (core_target_info): Likewise.
5659         * dwarf-index-cache.c (_initialize_index_cache): Likewise.
5660         * dwarf2read.c (_initialize_dwarf2_read): Likewise.
5661         * filesystem.c (_initialize_filesystem): Likewise.
5662         * frame.c (_initialize_frame): Likewise.
5663         * gnu-nat.c (add_task_commands): Likewise.
5664         * infcall.c (_initialize_infcall): Likewise.
5665         * infcmd.c (_initialize_infcmd): Likewise.
5666         * interps.c (_initialize_interpreter): Likewise.
5667         * language.c (_initialize_language): Likewise.
5668         * linux-fork.c (_initialize_linux_fork): Likewise.
5669         * maint-test-settings.c (_initialize_maint_test_settings): Likewise.
5670         * maint.c (_initialize_maint_cmds): Likewise.
5671         * memattr.c (_initialize_mem): Likewise.
5672         * printcmd.c (_initialize_printcmd): Likewise.
5673         * python/lib/gdb/function/strfns.py (_MemEq, _StrLen, _StrEq,
5674         _RegEx): Likewise.
5675         * ravenscar-thread.c (_initialize_ravenscar): Likewise.
5676         * record-btrace.c (_initialize_record_btrace): Likewise.
5677         * record-full.c (_initialize_record_full): Likewise.
5678         * record.c (_initialize_record): Likewise.
5679         * regcache-dump.c (_initialize_regcache_dump): Likewise.
5680         * regcache.c (_initialize_regcache): Likewise.
5681         * remote.c (add_packet_config_cmd, init_remote_threadtests,
5682         _initialize_remote): Likewise.
5683         * ser-tcp.c (_initialize_ser_tcp): Likewise.
5684         * serial.c (_initialize_serial): Likewise.
5685         * skip.c (_initialize_step_skip): Likewise.
5686         * source.c (_initialize_source): Likewise.
5687         * stack.c (_initialize_stack): Likewise.
5688         * symfile.c (_initialize_symfile): Likewise.
5689         * symtab.c (_initialize_symtab): Likewise.
5690         * target-descriptions.c (_initialize_target_descriptions): Likewise.
5691         * top.c (init_main): Likewise.
5692         * tracefile-tfile.c (tfile_target_info): Likewise.
5693         * tracepoint.c (_initialize_tracepoint): Likewise.
5694         * tui/tui-win.c (_initialize_tui_win): Likewise.
5695         * utils.c (add_internal_problem_command): Likewise.
5696         * valprint.c (value_print_option_defs): Likewise.
5697
5698 2019-08-06  Frank Ch. Eigler  <fche@redhat.com>
5699
5700         PR build/24886
5701         * configure.ac: Drop enable-libmcheck support.
5702         * configure, config.in: Rebuild.
5703         * libmcheck.m4: Remove.
5704         * acinclude.m4: Don't include it.
5705         * Makefile.in: Don't distribute it.
5706         * top.c (print_gdb_configuration): Don't mention it.
5707
5708 2019-08-06  Tom Tromey  <tom@tromey.com>
5709
5710         * utils.c (set_output_style): Sometimes pass stream to
5711         emit_style_escape.
5712         * ui-out.h (class ui_out) <can_emit_style_escape>: Declare.
5713         * record-btrace.c (btrace_insn_history): Update.
5714         * mi/mi-out.h (class mi_ui_out) <can_emit_style_escape>: New
5715         method.
5716         * disasm.h (gdb_pretty_print_disassembler): Add uiout parameter.
5717         Update initializers.
5718         <m_uiout>: New field.
5719         <m_di>: Move lower.
5720         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
5721         Remove "uiout" parameter.
5722         (dump_insns): Update.
5723         * cli-out.h (class cli_ui_out) <can_emit_style_escape>: Declare.
5724         * cli-out.c (cli_ui_out::can_emit_style_escape): New method.
5725
5726 2019-08-06  Christian Biesinger  <cbiesinger@google.com>
5727
5728         * symtab.c (symbol_cache_lookup): Change int to enum block_enum.
5729         (error_in_psymtab_expansion): Likewise.
5730         (lookup_symbol_via_quick_fns): Likewise.
5731         (basic_lookup_transparent_type_quick): Likewise.
5732         (basic_lookup_transparent_type_1): Likewise.
5733
5734 2019-08-06  Tom Tromey  <tromey@adacore.com>
5735
5736         * source.c (last_source_error): Now bool.
5737         (print_source_lines_base): Make "noprint" bool.  Only open
5738         source file when last_source_visited changes.
5739
5740 2019-08-06  Tom Tromey  <tromey@adacore.com>
5741
5742         * annotate.c (annotate_source_line): Use g_source_cache.
5743         * source-cache.c (source_cache::get_plain_source_lines): Change
5744         parameters.  Populate m_offset_cache.
5745         (source_cache::ensure): New method.
5746         (source_cache::get_line_charpos): New method.
5747         (extract_lines): Move lower.  Change parameters.
5748         (source_cache::get_source_lines): Move lower.
5749         * source-cache.h (class source_cache): Update comment.
5750         <get_line_charpos>: New method.
5751         <get_source_lines>: Update comment.
5752         <clear>: Clear m_offset_cache.
5753         <get_plain_source_lines>: Change parameters.
5754         <ensure>: New method
5755         <m_offset_cache>: New member.
5756         * source.c (forget_cached_source_info_for_objfile): Update.
5757         (info_source_command): Use g_source_cache.
5758         (find_source_lines, open_source_file_with_line_charpos): Remove.
5759         (print_source_lines_base, search_command_helper): Use g_source_cache.
5760         * source.h (open_source_file_with_line_charpos): Don't declare.
5761         * symtab.h (struct symtab) <nlines, line_charpos>: Remove.
5762         * tui/tui-source.c (tui_source_window::do_scroll_vertical):
5763         Use g_source_cache.
5764
5765 2019-08-06  Tom Tromey  <tromey@adacore.com>
5766
5767         * source-cache.c (source_cache::get_plain_source_lines):
5768         Remove "first_line" and "last_line" parameters.
5769         (source_cache::get_source_lines): Cache plain text.
5770         * source-cache.h (class source_cache)
5771         <get_plain_source_lines>: Update.
5772
5773 2019-08-06  Tom Tromey  <tromey@adacore.com>
5774
5775         * source-cache.c (extract_lines): No longer a method.
5776         Changed type of parameter.  Include final newline.
5777         (selftests::extract_lines_test): New function.
5778         (_initialize_source_cache): Likewise.
5779         * source-cache.h (class source_cache)
5780         <extract_lines>: Don't declare.
5781
5782 2019-08-06  Tom Tromey  <tromey@adacore.com>
5783
5784         * breakpoint.c (init_breakpoint_sal): Update.
5785         (breakpoint): Update.
5786         * breakpoint.h (struct breakpoint) <filter>: Now a
5787         unique_xmalloc_ptr.
5788
5789 2019-08-05  Christian Biesinger  <cbiesinger@google.com>
5790
5791         * NEWS: Mention dictionary access on blocks.
5792         * python/py-block.c (blpy_getitem): New function.
5793         (block_object_as_mapping): New struct.
5794         (block_object_type): Use new struct for tp_as_mapping field.
5795
5796 2019-08-05  Christian Biesinger  <cbiesinger@google.com>
5797
5798         * objfiles.h (objfile): Add a comment describing partial symbols.
5799
5800 2019-08-05  Tom Tromey  <tromey@adacore.com>
5801
5802         * compile/compile.c (_initialize_compile): Use _(), not N_().
5803         * thread.c (_initialize_thread): Use _(), not N_().
5804         * stack.c (_initialize_stack): Use _(), not N_().
5805         * printcmd.c (_initialize_printcmd): Use _(), not N_().
5806
5807 2019-08-04  Simon Marchi  <simon.marchi@polymtl.ca>
5808
5809         * dwarf2read.c (struct dw2_symtab_iterator):
5810         <want_specific_block>: Remove.
5811         <block_index>: Change type to gdb::optional.
5812         (dw2_symtab_iter_init): Remove WANT_SPECIFIC_BLOCK parameter,
5813         change type of BLOCK_INDEX parameter to gdb::optional.
5814         (dw2_symtab_iter_next): Re-write in function of gdb::optional.
5815         (dw2_lookup_symbol): Don't pass argument for
5816         WANT_SPECIFIC_BLOCK.
5817         (dw2_expand_symtabs_for_function): Don't pass argument for
5818         WANT_SPECIFIC_BLOCK, pass empty optional for BLOCK_INDEX.
5819         (class dw2_debug_names_iterator)
5820         <dw2_debug_names_iterator>: Remove WANT_SPECIFIC_BLOCK
5821         parameter, change BLOCK_INDEX type to gdb::optional.
5822         <m_want_specific_block>: Remove.
5823         <m_block_index>: Change type to gdb::optional.
5824         (dw2_debug_names_iterator::next): Change type of IS_STATIC to
5825         gdb::optional.  Re-write in function of gdb::optional.
5826         (dw2_debug_names_lookup_symbol): Don't pass argument for
5827         WANT_SPECIFIC_BLOCK.
5828         (dw2_debug_names_expand_symtabs_for_function): Don't pass
5829         argument for WANT_SPECIFIC_BLOCK, pass empty optional for
5830         BLOCK_INDEX.
5831
5832 2019-08-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5833
5834         * NEWS: Mention changes to "info sources" command.
5835
5836 2019-08-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5837
5838         * symtab.c (filename_partial_match_opts): New struct type.
5839         (struct output_source_filename_data): New members
5840         regexp, c_regexp, partial_match.
5841         (output_source_filename): Use new members to decide to print file.
5842         (info_sources_option_defs): New variable.
5843         (make_info_sources_options_def_group, print_info_sources_header,
5844         info_sources_command_completer):
5845         New functions.
5846         (info_sources_command): Read new optional arguments.
5847         (_initialize_symtab): Update info sources help.
5848
5849 2019-08-02  Alexandre Oliva <oliva@adacore.com>
5850
5851         * ada-lang.c (exception_support_info_v0): Renamed from...
5852         (default_exception_support_info): ... this.  Create new
5853         definition for v1.
5854         (ada_has_this_exception_support): Look up catch_handlers_sym.
5855         (ada_exception_support_info_sniffer): Try v0 after default.
5856
5857 2019-08-01  Tom Tromey  <tromey@adacore.com>
5858
5859         * ia64-libunwind-tdep.h (struct libunwind_descr): Include
5860         gdbarch.h.
5861
5862 2019-08-01  Christian Biesinger  <cbiesinger@google.com>
5863
5864         * s12z-tdep.c: Fix include path for s12z-opc.h.
5865
5866 2019-08-01  Alan Hayward  <alan.hayward@arm.com>
5867
5868         * NEWS: Require GNU make 3.82.
5869
5870 2019-07-16  Tom Tromey  <tom@tromey.com>
5871
5872         * tui/tui-wingeneral.h (tui_copy_win, tui_box_win): Don't
5873         declare.
5874
5875 2019-07-30  Tom Tromey  <tromey@adacore.com>
5876
5877         * block.c (contained_in): Remove BLOCK_FUNCTION check.
5878
5879 2019-07-30  Kevin Buettner  <kevinb@redhat.com>
5880
5881         * printcmd.c (print_address_symbolic): Print negative offsets.
5882         (build_address_symbolic): Force signed arithmetic when computing
5883         offset.
5884
5885 2019-07-30  Christian Biesinger  <cbiesinger@google.com>
5886
5887         PR/24474: Add a function to lookup static variables.
5888         * NEWS: Mention this new function.
5889         * python/py-symbol.c (gdbpy_lookup_static_symbol): New function.
5890         * python/python-internal.h (gdbpy_lookup_static_symbol): New function.
5891         * python/python.c (python_GdbMethods): Add new function.
5892
5893 2019-07-29  Christian Biesinger  <cbiesinger@google.com>
5894
5895         * NEWS: Mention new functions Objfile.lookup_{global,static}_symbol.
5896         * python/py-objfile.c (objfpy_lookup_global_symbol): New function.
5897         (objfpy_lookup_static_symbol): New function.
5898         (objfile_object_methods): Add new functions.
5899
5900 2019-07-29  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5901
5902         * NEWS: Mention 'set|show print frame-info'.  Mention new
5903         'presence' value for 'frame-arguments'.  Mention new '-frame-info'
5904         backtrace argument.  Mention that python frame filtering code
5905         is now consistent with what 'backtrace' command prints.
5906
5907 2019-07-29  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5908
5909         * frame.h (enum print_what): New value 'SHORT_LOCATION', update
5910         comments.
5911         (print_frame_info_auto, print_frame_info_source_line,
5912         print_frame_info_location, print_frame_info_source_and_location,
5913         print_frame_info_location_and_address, print_frame_info_short_location):
5914         New declarations.
5915         (struct frame_print_options): New member print_frame_info.
5916         * extension.h (enum ext_lang_frame_args): New value CLI_PRESENCE.
5917         * stack.h (get_user_print_what_frame_info): New declaration.
5918         (frame_show_address): New declaration.
5919         * stack.c (print_frame_arguments_choices): New value 'presence'.
5920         (print_frame_info_auto, print_frame_info_source_line,
5921         print_frame_info_location, print_frame_info_source_and_location,
5922         print_frame_info_location_and_address, print_frame_info_short_location,
5923         print_frame_info_choices, print_frame_info_print_what): New definitions.
5924         (print_frame_args): Only print dots for args if print frame-arguments
5925         is 'presence'.
5926         (frame_print_option_defs): New element for "frame-info".
5927         (get_user_print_what_frame_info): New function.
5928         (frame_show_address): Make non static.  Move comment to stack.h.
5929         (print_frame_info_to_print_what): New function.
5930         (print_frame_info): Update comment.  Use fp_opts.print_frame_info
5931         to decide what to print.
5932         (backtrace_command_1): Handle the new print_frame_arguments_presence
5933         value.
5934         (_initialize_stack): Call add_setshow_enum_cmd for frame-info.
5935         * python/py-framefilter.c (py_print_args): Handle CLI_PRESENCE.
5936         (py_print_frame): In non-mi mode, use LOCATION as default for
5937         print_what, similarly to frame information printed directly by
5938         backtrace command. Handle frame-info user option in non MI mode.
5939
5940 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
5941
5942         * linux-thread-db.c (thread_db_target::thread_handle_to_thread_info):
5943         Add case for debugging 32-bit target on 64-bit host.  Revise
5944         comment.
5945
5946 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
5947
5948         * infrun.c (fill_in_stop_func): Use find_pc_partial_function
5949         instead of find_function_entry_range_from_pc.
5950
5951 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
5952
5953         * stack.c (find_frame_funname): Remove code which preferred
5954         minsym over symtab sym in "certain pathological cases".
5955
5956         * valprint.h (build_address_symbolic): Add "prefer_sym_over_minsym"
5957         parameter.  Change type of "do_demangle" to bool.
5958         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
5959         Pass suitable "prefer_sym_over_minsym" flag to
5960         build_address_symbolic().  Don't output "+" for negative offsets.
5961         * printcmd.c (print_address_symbolic): Update invocation of
5962         build_address_symbolic to include a "prefer_sym_over_minsym"
5963         flag.
5964         (build_address_symbolic): Add "prefer_sym_over_minsym" parameter.
5965         Restrict cases in which use of minimal symbol is preferred to that
5966         of a found symbol.  Update comments.
5967
5968         * dwarf2-frame.c (dwarf2_frame_cache): Don't decode FDE instructions
5969         for entry pc when entry pc is out of range for that FDE.
5970
5971 2019-07-26  Brian Callahan  <bcallah@openbsd.org>
5972
5973         PR gdb/24839:
5974         * gdb/obsd-nat.c (obsd_nat_target::pid_to_str): Fix typo in return
5975         type.
5976
5977 2019-07-25  Christian Biesinger  <cbiesinger@google.com>
5978
5979         * python/py-objfile.c (add_separate_debug_file): Fix comment about
5980         this function's Python signature.
5981
5982
5983 2019-07-24  Christian Biesinger  <cbiesinger@google.com>
5984
5985         * compile/compile-object-load.c (compile_object_load): Pass GLOBAL_SCOPE.
5986         * solib-spu.c (spu_lookup_lib_symbol): Pass GLOBAL_SCOPE.
5987         * solib-svr4.c (elf_lookup_lib_symbol): Pass GLOBAL_SCOPE.
5988         * symtab.c (lookup_global_symbol_from_objfile): Add a scope parameter.
5989         * symtab.h (lookup_global_symbol_from_objfile): Likewise.
5990
5991
5992 2019-07-24  Yoshinori Sato  <ysato@users.sourceforge.jp>
5993
5994         * h8300-tdep.c (h8300_register_name_common): New.
5995         h8300_register_name): Use h8300_register_name_common.
5996         (h8300s_register_name): Likewise.
5997         (h8300sx_register_name): Likewise.
5998         (h8300h_register_nam): New.
5999         (h8300_gdbarch_init): Use h8300h_register_name in h8300h machine.
6000
6001
6002 2019-07-23  Srinath Parvathaneni  <srinath.parvathaneni@arm.com>
6003
6004         * arm-tdep.c (arm_skip_cmse_entry): New function.
6005         (arm_is_sgstubs_section): New function.
6006         (arm_skip_stub): Add call to arm_skip_cmse_entry function.
6007
6008 2019-07-22  Tom Tromey  <tom@tromey.com>
6009
6010         * tui/tui-win.c (tui_win_info::make_invisible_and_set_new_height):
6011         Don't self-assign.
6012
6013 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
6014
6015         * c-typeprint.c (c_print_typedef): Pass -1 instead of 0 to
6016         type_print.
6017
6018 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
6019
6020         * symtab.c (search_symbols): Adjust msymbol matching type arrays
6021         so that GDB doesn't match any msymbols when searching in the
6022         TYPES_DOMAIN.
6023         (print_symbol_info): Print using typedef_print or type_print based
6024         on the type of the symbol.  Add updated FIXME comment moved from...
6025         (_initialize_symtab): ... move and update FIXME comment to above.
6026
6027 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
6028
6029         * NEWS: Mention adding -q option to "info types".
6030         * symtab.c (struct info_types_options): New struct.
6031         (info_types_options_defs): New variable.
6032         (make_info_types_options_def_group): New function.
6033         (info_types_command): Use gdb::option framework to parse options.
6034         (info_types_command_completer): New function.
6035         (_initialize_symtab): Extend the help text on "info types" and
6036         register command completer.
6037
6038 2019-07-21  Christian Biesinger  <cbiesinger@google.com>
6039
6040         * symtab.c (lookup_symbol_in_objfile_symtabs): Change int to block_enum.
6041         (lookup_symbol_in_objfile): Change int to block_enum and add a
6042         gdb_assert to make sure block_index is GLOBAL_BLOCK or STATIC_BLOCK.
6043
6044 2019-07-20  Christian Biesinger  <cbiesinger@google.com>
6045
6046         * MAINTAINERS (Write After Approval): Add self.
6047
6048 2019-07-19  Andrew Burgess  <andrew.burgess@embecosm.com>
6049
6050         * riscv-tdep.c (riscv_push_dummy_code): Write a 4-byte nop
6051         instruction to the dummy code region.
6052
6053 2019-07-19  Tom Tromey  <tromey@adacore.com>
6054
6055         * contrib/ari/gdb_ari.sh: Mention C++11, not ISO C 90.
6056         (ARGSUSED, PARAMS, __func__): Remove rules.
6057
6058 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
6059
6060         * arm-tdep.c (_initialize_arm_tdep): Remove xml tests.
6061         * features/arm/arm-with-iwmmxt.c: Remove.
6062         * features/arm/arm-with-iwmmxt.xml: Remove.
6063         * features/arm/arm-with-m-fpa-layout.c: Remove.
6064         * features/arm/arm-with-m-fpa-layout.xml: Remove.
6065         * features/arm/arm-with-m-vfp-d16.c: Remove.
6066         * features/arm/arm-with-m-vfp-d16.xml: Remove.
6067         * features/arm/arm-with-m.c: Remove.
6068         * features/arm/arm-with-m.xml: Remove.
6069         * features/arm/arm-with-neon.c: Remove.
6070         * features/arm/arm-with-neon.xml: Remove.
6071         * features/arm/arm-with-vfpv2.c: Remove.
6072         * features/arm/arm-with-vfpv2.xml: Remove.
6073         * features/arm/arm-with-vfpv3.c: Remove.
6074         * features/arm/arm-with-vfpv3.xml: Remove.
6075
6076 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
6077
6078         * arm-tdep.c (_initialize_arm_tdep): Add xml regression tests.
6079
6080 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
6081
6082         * arch/aarch32.c (aarch32_create_target_description): Create
6083         target descriptions using features.
6084         * arch/arm.c (arm_create_target_description)
6085         (arm_create_mprofile_target_description): Likewise.
6086         * arm-tdep.c (_initialize_arm_tdep): Remove tdesc init calls.
6087
6088 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
6089
6090         * Makefile.in: Add new files.
6091         * aarch32-tdep.c: New file.
6092         * aarch32-tdep.h: New file.
6093         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
6094         Call aarch32_read_description.
6095         * arch/aarch32.c: New file.
6096         * arch/aarch32.h: New file.
6097         * arch/arm.c (arm_create_target_description)
6098         (arm_create_mprofile_target_description): New function.
6099         * arch/arm.h (arm_fp_type, arm_m_profile_type): New enum.
6100         (arm_create_target_description)
6101         (arm_create_mprofile_target_description): New declaration.
6102         * arm-fbsd-tdep.c (arm_fbsd_read_description_auxv): Call
6103         read_description functions.
6104         * arm-linux-nat.c (arm_linux_nat_target::read_description):
6105         Likewise.
6106         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
6107         * arm-tdep.c (tdesc_arm_list): New variable.
6108         (arm_register_g_packet_guesses): Call create description functions.
6109         (arm_read_description) (arm_read_mprofile_description): New
6110         function.
6111         * arm-tdep.h (arm_read_description)
6112         (arm_read_mprofile_description): Add declaration.
6113         * configure.tgt: Add new files.
6114
6115 2019-07-18  Guillaume LABARTHE  <guillaume.labarthe@gmail.com>
6116
6117         * top.c (new_ui_command): Open specified terminal just once.
6118
6119 2019-07-18  Tom Tromey  <tromey@adacore.com>
6120
6121         * symtab.c (main_name): Constify return type.
6122         * symfile.c (set_initial_language): Update.
6123         * symtab.h (main_name): Constify return type.
6124
6125 2019-07-17  Tom Tromey  <tom@tromey.com>
6126
6127         * tui/tui-winsource.c (tui_update_source_window)
6128         (tui_update_source_window_as_is)
6129         (tui_update_source_windows_with_line): Remove return.
6130         * tui/tui-disasm.c (tui_show_disassem)
6131         (tui_show_disassem_and_update_source): Remove return.
6132         * tui/tui.c (tui_reset): Remove return.
6133         * tui/tui-wingeneral.c
6134         (tui_check_and_display_highlight_if_needed): Remove return.
6135
6136 2019-07-17  Tom Tromey  <tom@tromey.com>
6137
6138         * tui/tui-win.c (parse_scrolling_args): Throw separate errors.
6139
6140 2019-07-17  Tom Tromey  <tom@tromey.com>
6141
6142         * tui/tui-winsource.h (struct tui_exec_info_window)
6143         (struct tui_source_window_base): Move from tui-data.h.
6144         * tui/tui-winsource.c: Move many method definitions from
6145         elsewhere.  Remove "structuring" comments.
6146         * tui/tui-wingeneral.c (tui_source_window_base::make_visible)
6147         (tui_source_window_base::refresh_window): Move to
6148         tui-winsource.c.
6149         * tui/tui-win.c (tui_source_window_base::refresh_all)
6150         (tui_source_window_base::update_tab_width)
6151         (tui_source_window_base::set_new_height)
6152         (tui_source_window_base::do_make_visible_with_new_height): Move to
6153         tui-winsource.c.
6154         * tui/tui-source.h: Update.
6155         * tui/tui-source.c (tui_source_window_base::reset): Move to
6156         tui-winsource.c.
6157         * tui/tui-disasm.h: Update.
6158         * tui/tui-data.h (struct tui_exec_info_window): Move to
6159         tui-winsource.h.
6160         (struct tui_source_window_base): Likewise.
6161         * tui/tui-data.c (tui_source_window_base::clear_detail)
6162         (tui_source_window_base, ~tui_source_window_base): Move to
6163         tui-winsource.c.
6164
6165 2019-07-17  Tom Tromey  <tom@tromey.com>
6166
6167         * tui/tui-win.c (tui_resize_all)
6168         (tui_source_window_base::update_tab_width)
6169         (tui_adjust_win_heights): Update.
6170         (tui_win_info::make_invisible_and_set_new_height): Rename from
6171         make_invisible_and_set_new_height.
6172         * tui/tui-data.h (struct tui_win_info)
6173         <make_invisible_and_set_new_height>: New method.
6174
6175 2019-07-17  Tom Tromey  <tom@tromey.com>
6176
6177         * tui/tui.c: Update.
6178         * tui/tui-source.h (struct tui_source_window): Move from
6179         tui-data.h.
6180         * tui/tui-layout.c: Update.
6181         * tui/tui-disasm.c: Update.
6182         * tui/tui-data.h (struct tui_source_window): Move to
6183         tui-source.h.
6184
6185 2019-07-17  Tom Tromey  <tom@tromey.com>
6186
6187         * tui/tui-disasm.h (struct tui_disasm_window): Move from
6188         tui-data.h.
6189         * tui/tui-data.h (struct tui_disasm_window): Move to
6190         tui-disasm.h.
6191
6192 2019-07-17  Tom Tromey  <tom@tromey.com>
6193
6194         * tui/tui-regs.h (struct tui_data_item_window): Move from
6195         tui-data.h.
6196         * tui/tui-regs.c (tui_data_item_window): Move from tui-data.c.
6197         * tui/tui-data.h (struct tui_data_item_window): Move to
6198         tui-regs.h.
6199         * tui/tui-data.c (~tui_data_item_window): Move to tui-regs.c.
6200
6201 2019-07-17  Tom Tromey  <tom@tromey.com>
6202
6203         * tui/tui.c: Update.
6204         * tui/tui-win.c (tui_cmd_window::do_make_visible_with_new_height)
6205         (tui_cmd_window::max_height): Move to tui-command.c.
6206         * tui/tui-layout.c: Update.
6207         * tui/tui-data.h (struct tui_cmd_window): Move to tui-command.h.
6208         * tui/tui-data.c (tui_cmd_window::clear_detail): Move to
6209         tui-command.c.
6210         * tui/tui-command.h (struct tui_cmd_window): Move from
6211         tui-data.h.
6212         * tui/tui-command.c: Remove "structuring" comments.
6213         (tui_cmd_window::clear_detail)
6214         (tui_cmd_window::do_make_visible_with_new_height)
6215         (tui_cmd_window::max_height): Move from elsewhere.
6216
6217 2019-07-17  Tom Tromey  <tom@tromey.com>
6218
6219         * tui/tui-io.c (tui_dispatch_ctrl_char): Move from tui-command.c.
6220         Now static.
6221         * tui/tui-command.h (tui_dispatch_ctrl_char): Don't declare.
6222         * tui/tui-command.c (tui_dispatch_ctrl_char): Move to tui-io.c.
6223
6224 2019-07-17  Tom Tromey  <tom@tromey.com>
6225
6226         * tui/tui.c: Update.
6227         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Move to
6228         tui-regs.c.
6229         * tui/tui-windata.h: Remove file.
6230         * tui/tui-windata.c: Remove file.
6231         * tui/tui-win.c (tui_data_window::set_new_height)
6232         (tui_data_window::do_make_visible_with_new_height): Move to
6233         tui-regs.c.
6234         * tui/tui-regs.h (struct tui_data_window): Move from tui-data.h.
6235         * tui/tui-regs.c: Remove "structuring" comments.
6236         (tui_data_window::first_data_item_displayed)
6237         (tui_data_window::delete_data_content_windows)
6238         (tui_data_window::erase_data_content)
6239         (tui_data_window::display_all_data)
6240         (tui_data_window::refresh_all)
6241         (tui_data_window::do_scroll_vertical)
6242         (tui_data_window::clear_detail, tui_data_window::set_new_height)
6243         (tui_data_window::do_make_visible_with_new_height)
6244         (tui_data_window::refresh_window): Move from elsewhere.
6245         (_initialize_tui_regs): Move to end of file.
6246         * tui/tui-layout.c: Update.
6247         * tui/tui-hooks.c: Update.
6248         * tui/tui-data.h (struct tui_data_window): Move to tui-regs.h.
6249         * tui/tui-data.c (tui_data_window::clear_detail): Move to
6250         tui-regs.c.
6251         * Makefile.in (SUBDIR_TUI_SRCS): Remove tui-windata.c.
6252
6253 2019-07-17  Tom Tromey  <tom@tromey.com>
6254
6255         * tui/tui-io.c (tui_puts_internal): Call wrefresh if newline is
6256         seen.
6257
6258 2019-07-17  Tom Tromey  <tom@tromey.com>
6259
6260         * tui/tui-win.c (tui_source_window_base::set_new_height)
6261         (tui_source_window_base::do_make_visible_with_new_height): Use
6262         m_has_locator field directly.
6263         * tui/tui-data.h (struct tui_win_info) <has_locator>: Remove
6264         method.
6265         (struct tui_source_window_base) <has_locator>: Likewise.
6266
6267 2019-07-17  Tom Tromey  <tom@tromey.com>
6268
6269         * tui/tui-wingeneral.h (tui_make_visible, tui_make_invisible):
6270         Don't declare.
6271         * tui/tui-wingeneral.c (tui_make_visible, tui_make_invisible):
6272         Remove.
6273         * tui/tui-win.c (tui_source_window_base::set_new_height)
6274         (tui_source_window_base::set_new_height)
6275         (make_invisible_and_set_new_height)
6276         (tui_source_window_base::do_make_visible_with_new_height)
6277         (tui_source_window_base::do_make_visible_with_new_height):
6278         Update.
6279         * tui/tui-layout.c (show_source_disasm_command, show_data)
6280         (show_source_or_disasm_and_command): Update.
6281         * tui/tui-layout.c (show_layout): Update.
6282
6283 2019-07-17  Tom Tromey  <tom@tromey.com>
6284
6285         * tui/tui-layout.c (make_data_window): Remove.
6286         (show_data): Unify creation and re-initialization cases.
6287
6288 2019-07-17  Tom Tromey  <tom@tromey.com>
6289
6290         * tui/tui-layout.c (make_source_window, make_disasm_window):
6291         Remove.
6292         (show_data): Unify creation and re-initialization cases.
6293
6294 2019-07-17  Tom Tromey  <tom@tromey.com>
6295
6296         * tui/tui-layout.c (make_command_window): Remove.
6297         (show_source_disasm_command, show_source_or_disasm_and_command):
6298         Unify creation and re-initialization cases.
6299
6300 2019-07-17  Tom Tromey  <tom@tromey.com>
6301
6302         * tui/tui-layout.c (show_source_or_disasm_and_command): Unify
6303         creation and re-initialization cases.
6304
6305 2019-07-17  Tom Tromey  <tom@tromey.com>
6306
6307         * tui/tui-regs.c (tui_get_register): Return void.
6308
6309 2019-07-17  Tom Tromey  <tom@tromey.com>
6310
6311         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible):
6312         Simplify.
6313
6314 2019-07-17  Tom Tromey  <tom@tromey.com>
6315
6316         * tui/tui-layout.c (show_source_disasm_command): Simplify window
6317         resetting.
6318
6319 2019-07-17  Tom Tromey  <tom@tromey.com>
6320
6321         * tui/tui.h (tui_set_layout_by_name): Don't declare.
6322         * tui/tui-regs.c (tui_reg_layout): New function.
6323         (tui_show_registers, tui_reg_command): Use it.
6324         * tui/tui-layout.c (LAYOUT_USAGE): Remove.
6325         (tui_layout_command): Rename from tui_set_layout_by_name.  Change
6326         parameters.
6327         (tui_layout_command): Remove.
6328
6329 2019-07-17  Tom Tromey  <tom@tromey.com>
6330
6331         * tui/tui-layout.h (tui/tui-layout): Return void.
6332         * tui/tui-layout.c (tui_set_layout): Return void.  Add assert.
6333
6334 2019-07-17  Tom Tromey  <tom@tromey.com>
6335
6336         * tui/tui-layout.c (show_source_disasm_command, show_data):
6337         Update.
6338         (reset_locator): Remove.
6339         (show_source_or_disasm_and_command): Update.
6340
6341 2019-07-17  Tom Tromey  <tom@tromey.com>
6342
6343         * tui/tui-source.c (tui_source_window_base::reset): Remove
6344         win_type parameter.
6345         * tui/tui-layout.c (make_command_window, make_source_window)
6346         (make_disasm_window, make_data_window)
6347         (show_source_disasm_command, show_data, tui_gen_win_info::reset)
6348         (reset_locator, show_source_or_disasm_and_command): Update.
6349         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Remove
6350         win_type parameter.
6351         (struct tui_source_window_base) <reset>: Likewise.
6352
6353 2019-07-17  Tom Tromey  <tom@tromey.com>
6354
6355         * tui/tui-layout.c (show_source_disasm_command): Use
6356         reset_locator.
6357         (reset_locator): New function.
6358         (init_and_make_win): Remove.
6359         (show_source_or_disasm_and_command): Use reset_locator.
6360
6361 2019-07-17  Tom Tromey  <tom@tromey.com>
6362
6363         * tui/tui-winsource.c (tui_set_exec_info_content): Remove
6364         condition.
6365         * tui/tui-wingeneral.c (tui_source_window_base::make_visible):
6366         Remove condition.
6367         * tui/tui-source.c (tui_source_window_base::reset): New method.
6368         * tui/tui-layout.c (make_command_window): Don't call
6369         init_and_make_win.
6370         (make_source_window, make_disasm_window): Don't call
6371         make_source_or_disasm_window.
6372         (make_data_window): Don't call init_and_make_win.  Change calling
6373         convention.
6374         (show_source_disasm_command, show_data): Simplify.
6375         (make_source_or_disasm_window): Remove.
6376         (show_source_or_disasm_and_command): Simplify.
6377         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Now virtual.
6378         (struct tui_source_window_base) <reset>: Likewise.
6379         <execution_info>: Remove initializer.
6380         * tui/tui-data.c (tui_source_window_base): Initialize
6381         execution_info.
6382
6383 2019-07-17  Tom Tromey  <tom@tromey.com>
6384
6385         * tui/tui-layout.c (tui_set_layout): Remove regs_populate
6386         variable.
6387
6388 2019-07-17  Tom Tromey  <tom@tromey.com>
6389
6390         * tui/tui.c (tui_rl_other_window): Update.
6391         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Call
6392         superclass method first.  Always iterate over regs_content.
6393         (tui_unhighlight_win, tui_highlight_win): Use refresh_window
6394         method.
6395         * tui/tui-win.c (tui_set_focus_command): Update.
6396
6397 2019-07-17  Tom Tromey  <tom@tromey.com>
6398
6399         * tui/tui-win.c (tui_set_focus_command): Rename from
6400         tui_set_focus.  Call tui_enable.
6401         (tui_set_focus_command): Remove.
6402
6403 2019-07-17  Tom Tromey  <tom@tromey.com>
6404
6405         * tui/tui-winsource.c (tui_show_exec_info_content): Don't call
6406         refresh_window.
6407         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Call
6408         touchwin.
6409         (tui_data_window::refresh_window): Call refresh_window on data
6410         items.  Always call superclass refresh_window.
6411         (tui_win_info::refresh): Remove.
6412         (tui_source_window_base::refresh_window): Update.
6413         (tui_refresh_all): Update.
6414         * tui/tui-layout.c (show_source_disasm_command): Remove call to
6415         refresh_window.
6416         (show_source_or_disasm_and_command): Likewise.
6417         * tui/tui-data.h (struct tui_win_info) <refresh>: Remove.
6418         (struct tui_source_window_base) <refresh>: Likewise.
6419
6420 2019-07-17  Tom Tromey  <tom@tromey.com>
6421
6422         * tui/tui-winsource.c (tui_clear_source_content)
6423         (tui_show_source_content): Update.
6424         * tui/tui-source.c (tui_source_window::showing_source_p): Check
6425         whether content is empty.
6426         * tui/tui-data.h (struct tui_source_window_base) <content_in_use>:
6427         Remove.
6428
6429 2019-07-17  Tom Tromey  <tom@tromey.com>
6430
6431         * tui/tui-winsource.c (tui_erase_source_content): Clear the
6432         window's contents.
6433         * tui/tui-source.h (tui_set_source_content_nil): Don't declare.
6434         * tui/tui-source.c (tui_set_source_content_nil): Remove.
6435
6436 2019-07-17  Tom Tromey  <tom@tromey.com>
6437
6438         * tui/tui-data.h (UNDEFINED_ITEM): Remove define.
6439         (struct tui_data_item_window): Update.
6440
6441 2019-07-17  Tom Tromey  <tom@tromey.com>
6442
6443         * tui/tui-data.h (MAX_CONTENT_COUNT, TUI_NULL_STR)
6444         (DEFAULT_HISTORY_COUNT, WITH_LOCATOR, NO_LOCATOR): Remove
6445         defines.
6446
6447 2019-07-17  Tom Tromey  <tom@tromey.com>
6448
6449         * tui/tui-winsource.h (tui_erase_source_content)
6450         (tui_clear_source_content): Remove "display_prompt" parameter.
6451         * tui/tui-winsource.c (tui_update_source_window_as_is)
6452         (tui_update_source_windows_with_addr): Update.
6453         (tui_clear_source_content): Remove "display_prompt" parameter.
6454         (tui_erase_source_content): Likewise.  Simplify.
6455         (tui_show_source_content): Update.
6456         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
6457         * tui/tui-stack.c (tui_show_frame_info): Update.
6458         * tui/tui-data.h (EMPTY_SOURCE_PROMPT, NO_EMPTY_SOURCE_PROMPT):
6459         Remove defines.
6460
6461 2019-07-17  Tom Tromey  <tom@tromey.com>
6462
6463         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
6464         * tui/tui-disasm.h (tui_set_disassem_content): Add win_info
6465         parameter.
6466         * tui/tui-disasm.c (tui_set_disassem_content): Add win_info
6467         parameter.
6468
6469 2019-07-17  Tom Tromey  <tom@tromey.com>
6470
6471         * tui/tui-winsource.c (tui_clear_source_content)
6472         (tui_show_source_content, tui_show_exec_info_content)
6473         (tui_clear_exec_info_content): Update.
6474         * tui/tui-stack.c (tui_show_locator_content): Update.
6475         (tui_show_frame_info): Update.
6476         * tui/tui-source.h (tui_source_window): Don't declare.
6477         * tui/tui-source.c (tui_source_window::showing_source_p): Rename
6478         from tui_source_is_displayed.
6479         * tui/tui-data.h (struct tui_gen_win_info) <content_in_use>:
6480         Remove field.
6481         (struct tui_source_window_base) <content_in_use>: New field.  Now
6482         bool.
6483         (struct tui_source_window) <showing_source_p>: New method.
6484         (TUI_SRC_WIN): Change cast.
6485         * tui/tui-data.c (tui_initialize_static_data): Update.
6486
6487 2019-07-17  Tom Tromey  <tom@tromey.com>
6488
6489         * tui/tui-winsource.c (tui_update_breakpoint_info): Use
6490         location_matches_p.
6491         * tui/tui-source.c (tui_source_window::location_matches_p): New
6492         method.
6493         * tui/tui-disasm.c (tui_disasm_window::location_matches_p): New
6494         method.
6495         * tui/tui-data.h (struct tui_source_window_base)
6496         <location_matches_p>: New method.
6497         (struct tui_source_window, struct tui_disasm_window)
6498         <location_matches_p>: Likewise.
6499
6500 2019-07-17  Tom Tromey  <tom@tromey.com>
6501
6502         * tui/tui-win.c (tui_set_win_height_command): Rename from
6503         tui_set_win_height.
6504         (tui_set_win_height_command): Remove.
6505
6506 2019-07-17  Tom Tromey  <tom@tromey.com>
6507
6508         * tui/tui-source.c (tui_source_window): New constructor.  Add
6509         observer.
6510         (~tui_source_window): New destructor.
6511         (tui_source_window::style_changed): New method.
6512         * tui/tui-hooks.c (tui_redisplay_source): Remove.
6513         (tui_attach_detach_observers): Update.
6514         * tui/tui-data.h (struct tui_source_window): Make constructor not
6515         inline.  Add destructor.
6516         (struct tui_source_window) <style_changed>: New method.
6517         <m_observable>: New member.
6518
6519 2019-07-17  Tom Tromey  <tom@tromey.com>
6520
6521         * tui/tui-data.c (tui_clear_source_windows_detail): Fix typo.
6522         * tui/tui-win.c (tui_resize_all): Fix typo.
6523
6524 2019-07-17  Tom Tromey  <tom@tromey.com>
6525
6526         * tui/tui-wingeneral.h (tui_refresh_all): Update.
6527         * tui/tui-wingeneral.c (make_all_visible): Use foreach.
6528         (tui_refresh_all): Remove "list" parameter.  Use foreach.
6529         * tui/tui-win.c (window_name_completer): Use foreach.
6530         (tui_refresh_all_win, tui_rehighlight_all, tui_all_windows_info)
6531         (update_tab_width): Likewise.
6532         * tui/tui-layout.c (show_layout): Update.
6533         * tui/tui-data.h (class tui_window_iterator): New.
6534         (struct all_tui_windows): New.
6535         * tui/tui-data.c (tui_partial_win_by_name): Use foreach.
6536
6537 2019-07-17  Tom Tromey  <tom@tromey.com>
6538
6539         * tui/tui-regs.c (tui_reg_next, tui_reg_prev): Add "current_group"
6540         parameter.  Don't reference globals.
6541         (tui_reg_command): Update.
6542
6543 2019-07-17  Tom Tromey  <tom@tromey.com>
6544
6545         * tui/tui-regs.c (tui_show_registers): Simplify.
6546
6547 2019-07-17  Tom Tromey  <tom@tromey.com>
6548
6549         * tui/tui-regs.c (tui_show_registers): Update.
6550         (tui_show_register_group): Add win_info parameter.
6551
6552 2019-07-17  Tom Tromey  <tom@tromey.com>
6553
6554         * tui/tui-regs.c (tui_data_window::display_reg_element_at_line):
6555         Rename from tui_display_reg_element_at_line.
6556         (tui_data_window::display_registers_from_line): Update.
6557         * tui/tui-data.h (struct tui_data_window)
6558         <display_reg_element_at_line>: New method.
6559
6560 2019-07-17  Tom Tromey  <tom@tromey.com>
6561
6562         * tui/tui-regs.h (tui_display_registers_from)
6563         (tui_display_registers_from_line): Don't declare.
6564         * tui/tui-windata.c (tui_data_window::display_all_data)
6565         (tui_data_window::refresh_all)
6566         (tui_data_window::do_scroll_vertical): Update.
6567         * tui/tui-regs.c (tui_data_window::display_registers_from): Rename
6568         from tui_display_registers_from.
6569         (tui_display_reg_element_at_line): Update.
6570         (tui_data_window::display_registers_from_line): Rename from
6571         tui_display_registers_from_line.
6572         * tui/tui-data.h (struct tui_data_window) <display_registers_from,
6573         display_registers_from_line>: New methods.
6574
6575 2019-07-17  Tom Tromey  <tom@tromey.com>
6576
6577         * tui/tui-windata.h (tui_erase_data_content): Don't declare.
6578         * tui/tui-windata.c (tui_data_window::erase_data_content): Rename
6579         from tui_erase_data_content.
6580         (tui_data_window::display_all_data)
6581         (tui_data_window::refresh_all)
6582         (tui_data_window::do_scroll_vertical): Update.
6583         * tui/tui-regs.c (tui_show_registers): Update.
6584         * tui/tui-data.h (struct tui_data_window) <erase_data_content>:
6585         New method.
6586
6587 2019-07-17  Tom Tromey  <tom@tromey.com>
6588
6589         * tui/tui-windata.h (tui_delete_data_content_windows): Don't
6590         declare.
6591         * tui/tui-windata.c
6592         (tui_data_window::delete_data_content_windows): Rename from
6593         tui_delete_data_content_windows.
6594         (tui_data_window::display_all_data)
6595         (tui_data_window::do_scroll_vertical): Update.
6596         * tui/tui-data.h (struct tui_data_window)
6597         <delete_data_content_windows>: New method.
6598
6599 2019-07-17  Tom Tromey  <tom@tromey.com>
6600
6601         * tui/tui-windata.h (tui_refresh_data_win): Don't declare.
6602         * tui/tui-regs.h (tui_first_reg_element_inline): Don't declare.
6603
6604 2019-07-17  Tom Tromey  <tom@tromey.com>
6605
6606         * tui/tui-windata.h (tui_display_all_data): Don't declare.
6607         * tui/tui-windata.c (tui_data_window::display_all_data): Rename
6608         from tui_display_all_data.
6609         * tui/tui-win.c
6610         (tui_data_window::do_make_visible_with_new_height): Update.
6611         * tui/tui-regs.c (tui_show_registers): Update.
6612         * tui/tui-layout.c (tui_set_layout): Update.
6613         * tui/tui-data.h (struct tui_data_window) <display_all_data>: New
6614         method.
6615
6616 2019-07-17  Tom Tromey  <tom@tromey.com>
6617
6618         * tui/tui-windata.h (tui_display_data_from): Don't declare.
6619         * tui/tui-windata.c (tui_display_data_from): Remove.
6620         (tui_data_window::refresh_all): Update.
6621
6622 2019-07-17  Tom Tromey  <tom@tromey.com>
6623
6624         * tui/tui-windata.h (tui_display_data_from_line): Don't declare.
6625         * tui/tui-windata.c (tui_display_data_from_line): Remove.
6626         (tui_display_data_from, tui_data_window::do_scroll_vertical): Call
6627         tui_display_registers_from_line.
6628         * tui/tui-regs.h (tui_display_registers_from_line): Update.
6629         * tui/tui-regs.c (tui_display_registers_from_line): Remove
6630         "force_display" parameter.
6631
6632 2019-07-17  Tom Tromey  <tom@tromey.com>
6633
6634         * tui/tui-regs.h (tui_first_reg_element_no_inline): Don't
6635         declare.
6636         * tui/tui-regs.c (tui_data_window::first_reg_element_no_inline):
6637         Rename from tui_first_reg_element_no_inline.
6638         (tui_display_reg_element_at_line)
6639         (tui_display_registers_from_line): Update.
6640         * tui/tui-data.h (struct tui_data_window)
6641         <first_reg_element_no_inline>: New method.
6642
6643 2019-07-17  Tom Tromey  <tom@tromey.com>
6644
6645         * tui/tui-windata.c (tui_display_data_from)
6646         (tui_data_window::do_scroll_vertical): Update.
6647         * tui/tui-regs.h (tui_line_from_reg_element_no): Don't declare.
6648         * tui/tui-regs.c (tui_data_window::line_from_reg_element_no):
6649         Rename from tui_line_from_reg_element_no.
6650         (tui_display_registers_from_line): Update.
6651         * tui/tui-data.h (struct tui_data_window)
6652         <line_from_reg_element_no>: New method.
6653
6654 2019-07-17  Tom Tromey  <tom@tromey.com>
6655
6656         * tui/tui-regs.h (tui_last_regs_line_no): Don't declare.
6657         * tui/tui-regs.c (tui_data_window::last_regs_line_no): Rename from
6658         tui_last_regs_line_no.
6659         (tui_display_reg_element_at_line)
6660         (tui_display_registers_from_line): Update.
6661         * tui/tui-data.h (struct tui_data_window) <last_regs_line_no>: New
6662         method.
6663
6664 2019-07-17  Tom Tromey  <tom@tromey.com>
6665
6666         PR tui/24722:
6667         * tui/tui-winsource.h (tui_update_all_breakpoint_info)
6668         (tui_update_breakpoint_info): Add "being_deleted" parameter.
6669         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
6670         (tui_update_all_breakpoint_info): Add "being_deleted" parameter.
6671         (tui_update_breakpoint_info): Likewise.
6672         * tui/tui-hooks.c (tui_event_create_breakpoint)
6673         (tui_event_delete_breakpoint, tui_event_modify_breakpoint):
6674         Update.
6675
6676 2019-07-17  Tom Tromey  <tom@tromey.com>
6677
6678         * tui/tui-stack.c (tui_show_frame_info): Consolidate "if"s.
6679
6680 2019-07-17  Tom Tromey  <tom@tromey.com>
6681
6682         * tui/tui-winsource.c (tui_update_source_window_as_is)
6683         (tui_update_source_windows_with_addr): Update.
6684         * tui/tui-source.h (tui_set_source_content)
6685         (tui_show_symtab_source): Add "win_info" parameter.
6686         * tui/tui-source.c (tui_set_source_content): Add "win_info"
6687         parameter.
6688         (tui_show_symtab_source): Likewise.
6689
6690 2019-07-17  Tom Tromey  <tom@tromey.com>
6691
6692         * tui/tui-wingeneral.c
6693         (tui_check_and_display_highlight_if_needed): Check can_highlight.
6694
6695 2019-07-17  Tom Tromey  <tom@tromey.com>
6696
6697         * tui/tui-data.h (struct tui_win_info) <can_scroll>: New method.
6698         (struct tui_cmd_window) <can_scroll>: New method.
6699         * tui/tui-command.c (tui_dispatch_ctrl_char): Use can_scroll
6700         method.
6701
6702 2019-07-17  Tom Tromey  <tromey@adacore.com>
6703
6704         * ui-out.h (class ui_out) <field_signed, field_fmt_signed,
6705         do_field_signed>: Rename.  Change type of "value".
6706         * ui-out.c (ui_out::field_signed): Rename from field_int.
6707         Change type of "value".
6708         (ui_out::field_fmt_signed): Rename from field_fmt_int.  Change
6709         type of "value".
6710         * tui/tui-out.h (class tui_ui_out) <do_field_signed>: Rename from
6711         do_field_int.  Change type of "value".
6712         * tui/tui-out.c (tui_ui_out::do_field_signed): Rename from
6713         do_field_int.  Change type of "value".
6714         * tracepoint.c (trace_status_mi, tfind_1)
6715         (print_one_static_tracepoint_marker): Update.
6716         * thread.c (print_thread_info_1, print_selected_thread_frame):
6717         Update.
6718         * stack.c (print_frame, print_frame_info): Update.
6719         * spu-tdep.c (info_spu_signal_command, info_spu_dma_cmdlist):
6720         Update.
6721         * source.c (print_source_lines_base): Update.
6722         * skip.c (info_skip_command): Update.
6723         * record-btrace.c (btrace_ui_out_decode_error)
6724         (btrace_call_history_src_line): Update.
6725         * python/py-framefilter.c (py_print_single_arg, py_print_frame):
6726         Update.
6727         * progspace.c (print_program_space): Update.
6728         * mi/mi-symbol-cmds.c (mi_cmd_symbol_list_lines): Update.
6729         * mi/mi-out.h (class mi_ui_out) <do_field_signed>: Rename from
6730         do_field_int.  Change type of "value".
6731         * mi/mi-out.c (mi_ui_out::do_table_begin)
6732         (mi_ui_out::do_table_header): Update.
6733         (mi_ui_out::do_field_signed): Rename from do_field_int.  Change
6734         type of "value".
6735         * mi/mi-main.c (mi_cmd_thread_list_ids, print_one_inferior)
6736         (mi_cmd_data_list_changed_registers, output_register)
6737         (mi_cmd_data_read_memory, mi_load_progress)
6738         (mi_cmd_trace_frame_collected): Update.
6739         * mi/mi-interp.c (mi_on_normal_stop_1, mi_output_solib_attribs):
6740         Update.
6741         * mi/mi-cmd-var.c (print_varobj, mi_cmd_var_create)
6742         (mi_cmd_var_delete, mi_cmd_var_info_num_children)
6743         (mi_cmd_var_list_children, varobj_update_one): Update.
6744         * mi/mi-cmd-stack.c (mi_cmd_stack_info_depth)
6745         (mi_cmd_stack_list_args, list_arg_or_local): Update.
6746         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_file): Update.
6747         * inferior.c (print_inferior): Update.
6748         * gdb_bfd.c (print_one_bfd): Update.
6749         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
6750         Update.
6751         * darwin-nat-info.c (darwin_debug_regions_recurse): Update.
6752         * cli-out.h (class cli_ui_out) <do_field_signed>: Rename from
6753         do_field_int.  Change type of "value".
6754         * cli-out.c (cli_ui_out::do_field_signed): Rename from
6755         do_field_int.  Change type of "value".
6756         * breakpoint.c (watchpoint_check, print_breakpoint_location)
6757         (print_one_breakpoint_location, print_it_catch_fork)
6758         (print_one_catch_fork, print_it_catch_vfork)
6759         (print_one_catch_vfork, print_it_catch_solib)
6760         (print_it_catch_exec, print_it_ranged_breakpoint)
6761         (print_mention_watchpoint, print_mention_masked_watchpoint)
6762         (bkpt_print_it, update_static_tracepoint): Update.
6763         * break-catch-throw.c (print_it_exception_catchpoint): Update.
6764         * break-catch-syscall.c (print_it_catch_syscall): Update.
6765         * ada-tasks.c (print_ada_task_info): Update.
6766         * ada-lang.c (print_it_exception, print_mention_exception):
6767         Update.
6768
6769 2019-07-17  Andrew Burgess  <andrew.burgess@embecosm.com>
6770
6771         PR breakpoints/24541
6772         * gdbarch.c: Regenerate.
6773         * gdbarch.h: Regenerate.
6774         * gdbarch.sh: Adjust return type and parameter types for
6775         'stap_adjust_register'.
6776         (i386_stap_adjust_register): Adjust signature and return new
6777         register name.
6778         * stap-probe.c (stap_parse_register_operand): Adjust use of
6779         'gdbarch_stap_adjust_register'.
6780
6781 2019-07-17  Tom Tromey  <tromey@adacore.com>
6782
6783         * s390-linux-nat.c (s390_watch_area): Remove typedef.  Don't
6784         declare VEC.
6785         (struct s390_debug_reg_state) <watch_areas, break_areas>: Now
6786         std::vector.
6787         (struct s390_process_info): Add initializers.
6788         (s390_add_process): Use new.
6789         (s390_linux_nat_target::low_forget_process): Use delete.
6790         (s390_linux_nat_target::low_new_fork)
6791         (s390_linux_nat_target::stopped_by_watchpoint)
6792         (s390_linux_nat_target::low_prepare_to_resume)
6793         (s390_linux_nat_target::insert_watchpoint)
6794         (s390_linux_nat_target::insert_hw_breakpoint)
6795         (s390_linux_nat_target::remove_watchpoint)
6796         (s390_linux_nat_target::remove_hw_breakpoint): Update.
6797
6798 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
6799
6800         * aarch64-fbsd-nat.c: Include regcache.h.
6801         (getregs_supplies, getfpregs_supplies): Remove unused gdbarch
6802         argument.
6803         (aarch64_fbsd_nat_target::fetch_registers)
6804         (aarch64_fbsd_nat_target::store_registers): Remove gdbarch
6805         variable.
6806         * arm-fbsd-nat.c, riscv-fbsd-nat.c: Likewise.
6807
6808 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
6809
6810         * fbsd-nat.c: Include gdbarch.h.
6811
6812 2019-07-15  Tom Tromey  <tromey@adacore.com>
6813
6814         * mi/mi-out.c (mi_ui_out::do_field_int): Use plongest.
6815
6816 2019-07-15  Tom Tromey  <tromey@adacore.com>
6817
6818         * mi/mi-out.h (class mi_ui_out) <do_field_unsigned>: Declare.
6819         * mi/mi-out.c (mi_ui_out::do_field_unsigned): New method.
6820         * cli-out.h (class cli_ui_out) <do_field_unsigned>: Declare.
6821         * cli-out.c (cli_ui_out::do_field_int): New method.
6822         * ui-out.c (ui_out::field_unsigned): New method.
6823         * symfile.c (generic_load): Use field_unsigned.
6824         (print_transfer_performance): Likewise.
6825         * record-btrace.c (ui_out_field_uint): Remove.
6826         (btrace_call_history_insn_range, btrace_call_history): Use
6827         field_unsigned.
6828         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn): Use
6829         field_unsigned.
6830         * ui-out.h (class ui_out) <field_unsigned>: New method.
6831         <do_field_unsigned>: Likewise.
6832
6833 2019-07-15  Tom Tromey  <tromey@adacore.com>
6834
6835         * mi/mi-main.c (list_available_thread_groups): Use field_string.
6836         * mi/mi-interp.c (mi_memory_changed): Use field_string.
6837         * target.c (flash_erase_command): Use field_string.
6838         * infrun.c (print_signal_received_reason): Use field_string.
6839         * i386-tdep.c (i386_mpx_print_bounds): Use field_string.
6840         * breakpoint.c (maybe_print_thread_hit_breakpoint): Use
6841         field_string.
6842         * ada-tasks.c (print_ada_task_info): Use field_string.
6843
6844 2019-07-15  Tom Tromey  <tromey@adacore.com>
6845
6846         * target.c (flash_erase_command): Use field_core_addr.
6847         * symfile.c (generic_load): Use field_core_addr.
6848         * sparc64-linux-tdep.c (sparc64_linux_handle_segmentation_fault):
6849         Use field_core_addr.
6850         * i386-linux-tdep.c (i386_linux_handle_segmentation_fault): Use
6851         field_core_addr.
6852
6853 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
6854
6855         * dwarf2loc.c (dwarf2_evaluate_property): Sign extend property
6856         value if its desired type is smaller than a CORE_ADDR and signed.
6857
6858 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
6859
6860         * dwarf2loc.c (dwarf2_evaluate_property): Update to take account
6861         of changes to field names, and use new is_reference field to
6862         decide if a property is a reference or not.
6863         * dwarf2loc.h (struct dwarf2_locexpr_baton): Add 'is_reference'
6864         field.
6865         (struct dwarf2_property_baton): Update header comment, rename
6866         'referenced_type' to 'property_type' and update comments.
6867         * dwarf2read.c (attr_to_dynamic_prop): Add extra parameter to hold
6868         default property type, store in property baton, update to take
6869         accound of renamed field.
6870         (read_func_scope): Update call to attr_to_dynamic_prop.
6871         (read_array_type): Likewise.
6872         (dwarf2_per_cu_addr_sized_int_type): New function.
6873         (read_subrange_index_type): Move type finding code to
6874         dwarf2_per_cu_addr_sized_int_type.
6875         (read_subrange_type): Update calls to attr_to_dynamic_prop.
6876         (dwarf2_per_cu_addr_type): New function.
6877         (set_die_type): Update calls to attr_to_dynamic_prop.
6878
6879 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
6880
6881         * dwarf2read.c (read_subrange_index_type): New function.
6882         (read_subrange_type): Move code into new function and call it.
6883         * gdbtypes.c (create_range_type): Add some asserts.
6884
6885 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
6886
6887         * dwarf2loc.c (dwarf2_evaluate_property): Change return type, and
6888         update return statements.
6889         * dwarf2loc.h (dwarf2_evaluate_property): Update return type on
6890         declaration, and update comment to match.
6891         * gdbtypes.c (resolve_dynamic_array): Update call to
6892         dwarf2_evaluate_property to match new return type.
6893
6894 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
6895
6896         * valarith.c (value_subscripted_rvalue): Change lowerbound
6897         parameter type from int to LONGEST.
6898         * value.h (value_subscripted_rvalue): Likewise in declaration.
6899
6900 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
6901
6902         * cli/cli-utils.c (info_print_command_completer): New function.
6903         * cli/cli-utils.h: Add 'completer.h' include, and forward
6904         declaration for 'struct cmd_list_element'.
6905         (info_print_command_completer): Declare.
6906         * stack.c (_initialize_stack): Add completer for 'info locals' and
6907         'info args'.
6908         * symtab.c (_initialize_symtab): Add completer for 'info
6909         variables' and 'info functions'.
6910         * NEWS: Mention completion for additional info commands.
6911
6912 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
6913
6914         * cli/cli-utils.c (extract_info_print_args): Delete.
6915         (extract_arg_maybe_quoted): Delete.
6916         (info_print_options_defs): New variable.
6917         (make_info_print_options_def_group): New function.
6918         (extract_info_print_options): Define new function.
6919         * cli/cli-utils.h (extract_info_print_args): Delete.
6920         (struct info_print_options): New structure.
6921         (extract_info_print_options): Declare new function.
6922         * stack.c (info_locals_command): Update to use new
6923         extract_info_print_options, also add a header comment.
6924         (info_args_command): Likewise.
6925         * symtab.c (info_variables_command): Likewise.
6926         (info_functions_command): Likewise.
6927
6928 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
6929
6930         * cli/cli-option.c (parse_option): Use extract_string_maybe_quoted
6931         to extract string arguments.
6932         * common/common-utils.c (extract_string_maybe_quoted): New function.
6933         * common/common-utils.h (extract_string_maybe_quoted): Declare.
6934
6935 2019-07-11  Tom Tromey  <tromey@adacore.com>
6936
6937         * main.c (get_init_files): Use GDBINIT, not gdbinit.
6938         * auto-load.c (file_is_auto_load_safe): Use GDBINIT, not gdbinit.
6939         * top.h (gdbinit): Don't declare.
6940         * cli/cli-cmds.c (init_cli_cmds): Remove, merging contents
6941         into...
6942         (_initialize_cli_cmds): ...here.  Use GDBINIT, not gdbinit.
6943         * top.c (gdb_init): Don't call init_cli_cmds.
6944         (gdbinit): Remove.
6945         * cli/cli-cmds.h (init_cli_cmds): Don't declare.
6946
6947 2019-07-11  Tom Tromey  <tromey@adacore.com>
6948
6949         * python/py-inferior.c (add_thread_object): Don't use thread_obj
6950         after it has been moved.
6951
6952 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
6953
6954         * valops.c (value_must_coerce_to_target): Change return type to
6955         bool.
6956         * value.h (value_must_coerce_to_target): Likewise.
6957
6958 2019-07-10  Simon Marchi  <simon.marchi@efficios.com>
6959
6960         * breakpoint.c (is_hardware_watchpoint): Remove
6961         forward-declaration.
6962         (is_masked_watchpoint): Change return type to bool.
6963         (is_tracepoint): Likewise.
6964         (is_breakpoint): Likewise.
6965         (is_hardware_watchpoint): Likewise.
6966         (is_watchpoint): Likewise.
6967         (is_no_memory_software_watchpoint): Likewise.
6968         (is_catchpoint): Likewise.
6969         (breakpoint_1): Make FILTER parameter's return type bool.
6970         is_masked_watchpoint): Change return type to bool.
6971         (save_breakpoints): Make FILTER parameter's return type bool.
6972         * breakpoint.h (is_breakpoint): Change return type to bool.
6973         (is_watchpoint): Likewise.
6974         (is_catchpoint): Likewise.
6975         (is_tracepoint): Likewise.
6976
6977 2019-07-10  Tom Tromey  <tom@tromey.com>
6978
6979         * defs.h: Don't include gdbarch.h.
6980         * aarch64-ravenscar-thread.c, aarch64-tdep.c, alpha-bsd-tdep.h,
6981         alpha-linux-tdep.c, alpha-mdebug-tdep.c, arch-utils.h, arm-tdep.h,
6982         ax-general.c, btrace.c, buildsym-legacy.c, buildsym.h, c-lang.c,
6983         cli/cli-decode.h, cli/cli-dump.c, cli/cli-script.h,
6984         cli/cli-style.h, coff-pe-read.h, compile/compile-c-support.c,
6985         compile/compile-cplus.h, compile/compile-loc2c.c, corefile.c,
6986         cp-valprint.c, cris-linux-tdep.c, ctf.c, d-lang.c, d-namespace.c,
6987         dcache.c, dicos-tdep.c, dictionary.c, disasm-selftests.c,
6988         dummy-frame.c, dummy-frame.h, dwarf2-frame-tailcall.c,
6989         dwarf2expr.c, expression.h, f-lang.c, frame-base.c,
6990         frame-unwind.c, frv-linux-tdep.c, gdbarch-selftests.c, gdbtypes.h,
6991         go-lang.c, hppa-nbsd-tdep.c, hppa-obsd-tdep.c, i386-dicos-tdep.c,
6992         i386-tdep.h, ia64-vms-tdep.c, interps.h, language.c,
6993         linux-record.c, location.h, m2-lang.c, m32r-linux-tdep.c,
6994         mem-break.c, memattr.c, mn10300-linux-tdep.c, nios2-linux-tdep.c,
6995         objfiles.h, opencl-lang.c, or1k-linux-tdep.c, p-lang.c,
6996         parser-defs.h, ppc-tdep.h, probe.h, python/py-record-btrace.c,
6997         record-btrace.c, record.h, regcache-dump.c, regcache.h,
6998         riscv-fbsd-tdep.c, riscv-linux-tdep.c, rust-exp.y,
6999         sh-linux-tdep.c, sh-nbsd-tdep.c, source-cache.c,
7000         sparc-nbsd-tdep.c, sparc-obsd-tdep.c, sparc-ravenscar-thread.c,
7001         sparc64-fbsd-tdep.c, std-regs.c, target-descriptions.h,
7002         target-float.c, tic6x-linux-tdep.c, tilegx-linux-tdep.c, top.c,
7003         tracefile.c, trad-frame.c, type-stack.h, ui-style.c, utils.c,
7004         utils.h, valarith.c, valprint.c, varobj.c, x86-tdep.c,
7005         xml-support.h, xtensa-linux-tdep.c, cli/cli-cmds.h: Update.
7006         * s390-linux-nat.c, procfs.c, inf-ptrace.c: Likewise.
7007
7008 2019-07-10  Tom Tromey  <tromey@adacore.com>
7009
7010         * ada-lang.h (is_ada_exception_catchpoint): Declare.
7011         * breakpoint.c (init_ada_exception_breakpoint): Register as
7012         bp_catchpoint.
7013         (print_one_breakpoint_location, print_one_breakpoint): Use
7014         is_ada_exception_catchpoint.
7015         * ada-lang.c (class ada_catchpoint_location): Pass
7016         bp_loc_software_breakpoint to bp_location constructor.
7017         (is_ada_exception_catchpoint): New function.
7018
7019 2019-07-10  Tom Tromey  <tromey@adacore.com>
7020
7021         * arm-tdep.c (arm_exidx_entry_s): Remove typedef.  Don't define
7022         VEC.
7023         (struct arm_exidx_entry): New method operator<.
7024         (struct arm_exidx_data) <section_maps>: Change type.
7025         (arm_exidx_data_free): Remove.
7026         (arm_exidx_data_key): Change type.  Move lower.
7027         (arm_exidx_new_objfile): Update.
7028         (arm_compare_exidx_entries): Remove.
7029         (arm_find_exidx_entry, _initialize_arm_tdep)
7030
7031 2019-07-10  Tom Tromey  <tromey@adacore.com>
7032
7033         * solib-spu.c (ocl_program_data_key): Change type.
7034         (append_ocl_sos, ocl_enable_break, _initialize_spu_solib):
7035         Update.
7036
7037 2019-07-10  Tom Tromey  <tromey@adacore.com>
7038
7039         * solib-aix.c (lm_info_aix_p): Remove typedef.  Don't define VEC.
7040         (struct solib_aix_inferior_data) <library_list>: Change type.
7041         (solib_aix_inferior_data_handle): Change type.
7042         (get_solib_aix_inferior_data): Update.
7043         (solib_aix_free_library_list): Remove.
7044         (library_list_start_library): Update.
7045         (solib_aix_parse_libraries, solib_aix_get_library_list): Change
7046         return type.
7047         (solib_aix_get_library_list)
7048         (solib_aix_solib_create_inferior_hook, solib_aix_current_sos)
7049         (solib_aix_normal_stop_observer, _initialize_solib_aix): Update.
7050
7051 2019-07-10  Tom Tromey  <tromey@adacore.com>
7052
7053         * solib-dsbt.c (struct dsbt_info): Add initializers.
7054         (solib_dsbt_pspace_data): Change type.
7055         (dsbt_pspace_data_cleanup): Remove.
7056         (get_dsbt_info, _initialize_dsbt_solib): Update.
7057
7058 2019-07-10  Tom Tromey  <tromey@adacore.com>
7059
7060         * spu-tdep.c (spu_overlay_data): Change type.
7061         (spu_get_overlay_table, spu_overlay_new_objfile)
7062         (_initialize_spu_tdep): Update.
7063
7064 2019-07-10  Tom Tromey  <tromey@adacore.com>
7065
7066         * gdb-stabs.h (struct dbx_symfile_info): Add initializers and
7067         destructor.
7068         (dbx_objfile_data_key): Change type and declare later.
7069         (DBX_SYMFILE_INFO): Rewrite.
7070         * dbxread.c (dbx_objfile_data_key): Change type.
7071         (dbx_symfile_init): Update.
7072         (~dbx_symfile_info): Rename from dbx_free_symfile_info.  Update.
7073         (coffstab_build_psymtabs, elfstab_build_psymtabs)
7074         (stabsect_build_psymtabs, _initialize_dbxread): Update.
7075
7076 2019-07-10  Tom Tromey  <tromey@adacore.com>
7077
7078         * jit.c (jit_program_space_key): Change type.  Move lower.
7079         (get_jit_program_space_data): Update.
7080         (jit_program_space_data_cleanup): Remove.
7081         (jit_breakpoint_deleted, free_objfile_data, _initialize_jit):
7082         Update.
7083         (struct jit_program_space_data): Add initializers.
7084
7085 2019-07-10  Tom Tromey  <tromey@adacore.com>
7086
7087         * solib-darwin.c (struct darwin_info): Add initializers.
7088         (solib_darwin_pspace_data): Change type.
7089         (darwin_pspace_data_cleanup): Remove.
7090         (get_darwin_info, _initialize_darwin_solib): Update.
7091
7092 2019-07-10  Tom Tromey  <tromey@adacore.com>
7093
7094         * remote-sim.c (struct sim_inferior_data): Add initializers,
7095         constructor, and destructor.
7096         (sim_inferior_data_key): Change type.  Move lower.
7097         (check_for_duplicate_sim_descriptor): Update.
7098         (get_sim_inferior_data): Use new.  Update.
7099         (~sim_inferior_data_cleanup): Rename from
7100         sim_inferior_data_cleanup.  Simplify.
7101         (gdbsim_close_inferior, simulator_command)
7102         (sim_command_completer, _initialize_remote_sim): Update.
7103         (next_pid, INITIAL_PID): Move earlier.
7104
7105 2019-07-10  Tom Tromey  <tromey@adacore.com>
7106
7107         * python/python-internal.h (create_thread_object): Return
7108         gdbpy_ref.
7109         * python/py-infthread.c (create_thread_object): Return gdbpy_ref.
7110         * python/py-inferior.c (struct threadlist_entry): Add
7111         constructor.
7112         <thread_obj>: Now a gdbpy_ref.
7113         (thread_to_thread_object): Update.
7114         (add_thread_object): Use new.
7115         (delete_thread_object): Use delete.
7116         (infpy_threads): Update.
7117         (py_free_inferior): Update.  Construct "inf_obj" after acquiring
7118         GIL.
7119
7120 2019-07-10  Tom Tromey  <tromey@adacore.com>
7121
7122         * valops.c (value_cast): Specialize error message for Ada.
7123
7124 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
7125
7126         * breakpoint.c (breakpoint_1): Update doc and parameter names.
7127
7128 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
7129
7130         * breakpoint.h (bpstat_explains_signal, bpstat_causes_stop,
7131         bpstat_should_step): Return bool, adjust comments.
7132         * breakpoint.c (bpstat_explains_signal, bpstat_causes_stop,
7133         bpstat_should_step): Likewise.
7134
7135 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
7136
7137         * features/Makefile: Use feature target descriptions for Arm.
7138         * features/arm/arm-core.c: Generate new file.
7139         * features/arm/arm-fpa.c: Likewise.
7140         * features/arm/arm-m-profile-with-fpa.xml: Likewise.
7141         * features/arm/arm-m-profile.c: Likewise.
7142         * features/arm/arm-vfpv2.c: Likewise.
7143         * features/arm/arm-vfpv3.c: Likewise.
7144         * features/arm/xscale-iwmmxt.c: Likewise.
7145         * target-descriptions.c (maint_print_c_tdesc_cmd): Add Arm.
7146
7147 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
7148
7149         * arm-linux-nat.c (arm_linux_nat_target::read_description): Check
7150         ptrace earlier.
7151
7152 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
7153
7154         * features/aarch64-pauth.c: Regenerate.
7155
7156 2019-07-09  Simon Marchi  <simon.marchi@polymtl.ca>
7157
7158         * breakpoint.h (struct bpstat_what) <is_longjmp>: Change type to
7159         bool.
7160         (bpstat_what): Use false instead of 0.
7161
7162 2019-07-09  Pedro Alves  <palves@redhat.com>
7163
7164         * break-catch-throw.c (is_exception_catchpoint): New.
7165         * breakpoint.c (print_one_breakpoint_location): New parameter
7166         'raw_loc'.  Handle it.  Use
7167         is_watchpoint/is_catchpoint/is_exception_catchpoint instead of
7168         looking at the breakpoint's type.
7169         (print_one_breakpoint): If handling "maint info breakpoints", also
7170         print locations of exception catchpoints.
7171         * breakpoint.h (is_exception_catchpoint): Declare.
7172
7173 2019-07-09  Pedro Alves  <palves@redhat.com>
7174
7175         * break-catch-throw.c (print_one_exception_catchpoint): Skip the
7176         "addr" field.
7177         (allocate_location_exception_catchpoint): New.
7178         (handle_gnu_v3_exceptions): Don't reset 'type' to bp_breakpoint.
7179         (initialize_throw_catchpoint_ops): Install
7180         allocate_location_exception_catchpoint as allocate_location
7181         method.
7182         * breakpoint.c (bpstat_what) <bp_catch>: Set action to
7183         BPSTAT_WHAT_SINGLE if not stopping and the location's type is not
7184         bp_loc_other.
7185         (breakpoint_address_is_meaningful): Delete.
7186         (bl_address_is_meaningful): New.
7187         (breakpoint_locations_match): Adjust comment.
7188         (bp_location_from_bp_type): New, factored out of...
7189         (bp_location::bp_location(breakpoint *)): ... this.
7190         (bp_location::bp_location(breakpoint *, bp_loc_type)): New,
7191         factored out of...
7192         (bp_location::bp_location(breakpoint *)): ... this.  Reimplement.
7193         (bp_loc_is_permanent): Use bl_address_is_meaningful instead of
7194         breakpoint_address_is_meaningful.
7195         (bp_locations_compare): Adjust comment.
7196         (update_global_location_list): Use bl_address_is_meaningful
7197         instead of breakpoint_address_is_meaningful.
7198         * breakpoint.h (bp_location::bp_location(breakpoint *)): New
7199         explicit.
7200         (bp_location::bp_location(breakpoint *, bp_loc_type)): Declare.
7201         * python/py-breakpoint.c (bppy_get_location): No longer check
7202         whether location is null.
7203
7204 2019-07-09  Pedro Alves  <palves@redhat.com>
7205
7206         PR c++/15468
7207         * breakpoint.c (print_one_breakpoint_location): Remove
7208         single-location assert.
7209
7210 2019-07-09  Tom Tromey  <tom@tromey.com>
7211
7212         * contrib/ari/gdb_ari.sh: Change common to gdbsupport.
7213         * configure: Rebuild.
7214         * configure.ac: Change common to gdbsupport.
7215         * gdbsupport: Rename from common.
7216         * acinclude.m4: Change common to gdbsupport.
7217         * Makefile.in (CONFIG_SRC_SUBDIR, COMMON_SFILES)
7218         (HFILES_NO_SRCDIR, stamp-version, ALLDEPFILES): Change common to
7219         gdbsupport.
7220         * aarch64-tdep.c, ada-lang.c, ada-lang.h, agent.c, alloc.c,
7221         amd64-darwin-tdep.c, amd64-dicos-tdep.c, amd64-fbsd-nat.c,
7222         amd64-fbsd-tdep.c, amd64-linux-nat.c, amd64-linux-tdep.c,
7223         amd64-nbsd-tdep.c, amd64-obsd-tdep.c, amd64-sol2-tdep.c,
7224         amd64-tdep.c, amd64-windows-tdep.c, arch-utils.c,
7225         arch/aarch64-insn.c, arch/aarch64.c, arch/aarch64.h, arch/amd64.c,
7226         arch/amd64.h, arch/arm-get-next-pcs.c, arch/arm-linux.c,
7227         arch/arm.c, arch/i386.c, arch/i386.h, arch/ppc-linux-common.c,
7228         arch/riscv.c, arch/riscv.h, arch/tic6x.c, arm-tdep.c, auto-load.c,
7229         auxv.c, ax-gdb.c, ax-general.c, ax.h, breakpoint.c, breakpoint.h,
7230         btrace.c, btrace.h, build-id.c, build-id.h, c-lang.h, charset.c,
7231         charset.h, cli/cli-cmds.c, cli/cli-cmds.h, cli/cli-decode.c,
7232         cli/cli-dump.c, cli/cli-option.h, cli/cli-script.c,
7233         coff-pe-read.c, command.h, compile/compile-c-support.c,
7234         compile/compile-c.h, compile/compile-cplus-symbols.c,
7235         compile/compile-cplus-types.c, compile/compile-cplus.h,
7236         compile/compile-loc2c.c, compile/compile.c, completer.c,
7237         completer.h, contrib/ari/gdb_ari.sh, corefile.c, corelow.c,
7238         cp-support.c, cp-support.h, cp-valprint.c, csky-tdep.c, ctf.c,
7239         darwin-nat.c, debug.c, defs.h, disasm-selftests.c, disasm.c,
7240         disasm.h, dtrace-probe.c, dwarf-index-cache.c,
7241         dwarf-index-cache.h, dwarf-index-write.c, dwarf2-frame.c,
7242         dwarf2expr.c, dwarf2loc.c, dwarf2read.c, event-loop.c,
7243         event-top.c, exceptions.c, exec.c, extension.h, fbsd-nat.c,
7244         features/aarch64-core.c, features/aarch64-fpu.c,
7245         features/aarch64-pauth.c, features/aarch64-sve.c,
7246         features/i386/32bit-avx.c, features/i386/32bit-avx512.c,
7247         features/i386/32bit-core.c, features/i386/32bit-linux.c,
7248         features/i386/32bit-mpx.c, features/i386/32bit-pkeys.c,
7249         features/i386/32bit-segments.c, features/i386/32bit-sse.c,
7250         features/i386/64bit-avx.c, features/i386/64bit-avx512.c,
7251         features/i386/64bit-core.c, features/i386/64bit-linux.c,
7252         features/i386/64bit-mpx.c, features/i386/64bit-pkeys.c,
7253         features/i386/64bit-segments.c, features/i386/64bit-sse.c,
7254         features/i386/x32-core.c, features/riscv/32bit-cpu.c,
7255         features/riscv/32bit-csr.c, features/riscv/32bit-fpu.c,
7256         features/riscv/64bit-cpu.c, features/riscv/64bit-csr.c,
7257         features/riscv/64bit-fpu.c, features/tic6x-c6xp.c,
7258         features/tic6x-core.c, features/tic6x-gp.c, filename-seen-cache.h,
7259         findcmd.c, findvar.c, fork-child.c, gcore.c, gdb_bfd.c, gdb_bfd.h,
7260         gdb_proc_service.h, gdb_regex.c, gdb_select.h, gdb_usleep.c,
7261         gdbarch-selftests.c, gdbthread.h, gdbtypes.h, gnu-nat.c,
7262         go32-nat.c, guile/guile.c, guile/scm-ports.c,
7263         guile/scm-safe-call.c, guile/scm-type.c, i386-fbsd-nat.c,
7264         i386-fbsd-tdep.c, i386-go32-tdep.c, i386-linux-nat.c,
7265         i386-linux-tdep.c, i386-tdep.c, i387-tdep.c,
7266         ia64-libunwind-tdep.c, ia64-linux-nat.c, inf-child.c,
7267         inf-ptrace.c, infcall.c, infcall.h, infcmd.c, inferior-iter.h,
7268         inferior.c, inferior.h, inflow.c, inflow.h, infrun.c, infrun.h,
7269         inline-frame.c, language.h, linespec.c, linux-fork.c, linux-nat.c,
7270         linux-tdep.c, linux-thread-db.c, location.c, machoread.c,
7271         macrotab.h, main.c, maint.c, maint.h, memattr.c, memrange.h,
7272         mi/mi-cmd-break.h, mi/mi-cmd-env.c, mi/mi-cmd-stack.c,
7273         mi/mi-cmd-var.c, mi/mi-interp.c, mi/mi-main.c, mi/mi-parse.h,
7274         minsyms.c, mips-linux-tdep.c, namespace.h,
7275         nat/aarch64-linux-hw-point.c, nat/aarch64-linux-hw-point.h,
7276         nat/aarch64-linux.c, nat/aarch64-sve-linux-ptrace.c,
7277         nat/amd64-linux-siginfo.c, nat/fork-inferior.c,
7278         nat/linux-btrace.c, nat/linux-btrace.h, nat/linux-namespaces.c,
7279         nat/linux-nat.h, nat/linux-osdata.c, nat/linux-personality.c,
7280         nat/linux-procfs.c, nat/linux-ptrace.c, nat/linux-ptrace.h,
7281         nat/linux-waitpid.c, nat/mips-linux-watch.c,
7282         nat/mips-linux-watch.h, nat/ppc-linux.c, nat/x86-dregs.c,
7283         nat/x86-dregs.h, nat/x86-linux-dregs.c, nat/x86-linux.c,
7284         nto-procfs.c, nto-tdep.c, objfile-flags.h, objfiles.c, objfiles.h,
7285         obsd-nat.c, observable.h, osdata.c, p-valprint.c, parse.c,
7286         parser-defs.h, ppc-linux-nat.c, printcmd.c, probe.c, proc-api.c,
7287         procfs.c, producer.c, progspace.h, psymtab.h,
7288         python/py-framefilter.c, python/py-inferior.c, python/py-ref.h,
7289         python/py-type.c, python/python.c, record-btrace.c, record-full.c,
7290         record.c, record.h, regcache-dump.c, regcache.c, regcache.h,
7291         remote-fileio.c, remote-fileio.h, remote-sim.c, remote.c,
7292         riscv-tdep.c, rs6000-aix-tdep.c, rust-exp.y, s12z-tdep.c,
7293         selftest-arch.c, ser-base.c, ser-event.c, ser-pipe.c, ser-tcp.c,
7294         ser-unix.c, skip.c, solib-aix.c, solib-target.c, solib.c,
7295         source-cache.c, source.c, source.h, sparc-nat.c, spu-linux-nat.c,
7296         stack.c, stap-probe.c, symfile-add-flags.h, symfile.c, symfile.h,
7297         symtab.c, symtab.h, target-descriptions.c, target-descriptions.h,
7298         target-memory.c, target.c, target.h, target/waitstatus.c,
7299         target/waitstatus.h, thread-iter.h, thread.c, tilegx-tdep.c,
7300         top.c, top.h, tracefile-tfile.c, tracefile.c, tracepoint.c,
7301         tracepoint.h, tui/tui-io.c, ui-file.c, ui-out.h,
7302         unittests/array-view-selftests.c,
7303         unittests/child-path-selftests.c, unittests/cli-utils-selftests.c,
7304         unittests/common-utils-selftests.c,
7305         unittests/copy_bitwise-selftests.c, unittests/environ-selftests.c,
7306         unittests/format_pieces-selftests.c,
7307         unittests/function-view-selftests.c,
7308         unittests/lookup_name_info-selftests.c,
7309         unittests/memory-map-selftests.c, unittests/memrange-selftests.c,
7310         unittests/mkdir-recursive-selftests.c,
7311         unittests/observable-selftests.c,
7312         unittests/offset-type-selftests.c, unittests/optional-selftests.c,
7313         unittests/parse-connection-spec-selftests.c,
7314         unittests/ptid-selftests.c, unittests/rsp-low-selftests.c,
7315         unittests/scoped_fd-selftests.c,
7316         unittests/scoped_mmap-selftests.c,
7317         unittests/scoped_restore-selftests.c,
7318         unittests/string_view-selftests.c, unittests/style-selftests.c,
7319         unittests/tracepoint-selftests.c, unittests/unpack-selftests.c,
7320         unittests/utils-selftests.c, unittests/xml-utils-selftests.c,
7321         utils.c, utils.h, valarith.c, valops.c, valprint.c, value.c,
7322         value.h, varobj.c, varobj.h, windows-nat.c, x86-linux-nat.c,
7323         xml-support.c, xml-support.h, xml-tdesc.h, xstormy16-tdep.c,
7324         xtensa-linux-nat.c, dwarf2read.h: Change common to gdbsupport.
7325
7326 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
7327
7328         * linespec.c (decode_digits_list_mode): Set explicit_line to a
7329         bool value.
7330         (decode_digits_ordinary): Set explicit_line field in sal.
7331         * symtab.c (skip_prologue_sal): Don't skip prologue for a
7332         symtab_and_line that was set on an explicit line number in
7333         assembler code.  Do always update the recorded symtab and line if
7334         we do skip the prologue.
7335
7336 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
7337
7338         * breakpoint.c (set_breakpoint_location_function): Remove
7339         explicit_loc parameter.
7340         (momentary_breakpoint_from_master): Update call to
7341         set_breakpoint_location_function.
7342         (add_location_to_breakpoint): Likewise.
7343
7344 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
7345
7346         * riscv-tdep.c (riscv_features_from_gdbarch_info): Don't modify
7347         required features based on default bfd type when no specific bfd
7348         is present.
7349
7350 2019-07-08  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7351
7352         * NEWS: Mention that GDB printf and eval commands can now print
7353         C-style and Ada-style convenience var strings without
7354         calling the inferior.
7355         * printcmd.c (printf_c_string): Locally print GDB internal var
7356         instead of transiting via the inferior.
7357         (printf_wide_c_string): Likewise.
7358
7359 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
7360
7361         PR breakpoints/25011
7362         * symfile.c (symbol_file_command): Call solib_create_inferior_hook.
7363
7364 2019-07-04  Tom Tromey  <tom@tromey.com>
7365
7366         PR tui/24724:
7367         * tui/tui-winsource.c (tui_clear_source_content): Update.
7368         (tui_source_window_base::set_is_exec_point_at): Fix comment.
7369         (tui_update_breakpoint_info): Update.
7370         (tui_set_exec_info_content): Update.
7371         * tui/tui-source.c (tui_set_source_content_nil): Update.
7372         * tui/tui-disasm.c (tui_set_disassem_content): Don't set
7373         has_break.
7374         * tui/tui-data.h (enum tui_bp_flag): New.
7375         (tui_bp_flags): New enum flags type.
7376         (struct tui_source_element) <break_mode>: Change type.  Rename
7377         from has_break.
7378         (TUI_BP_ENABLED, TUI_BP_DISABLED, TUI_BP_HIT)
7379         (TUI_BP_CONDITIONAL, TUI_BP_HARDWARE): Don't define.  Now enum
7380         constants.
7381         * tui/tui-winsource.h: Fix comment.
7382
7383 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
7384
7385         * aarch32-linux-nat.h (VFP_REGS_SIZE): Remove define.
7386         * aarch64-linux-nat.c (fetch_fpregs_from_thread)
7387         (store_fpregs_to_thread)
7388         (aarch64_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
7389         * arch/arm.h (IWMMXT_VEC_REGISTER_SIZE, ARM_CORE_REGS_SIZE)
7390         (ARM_FP_REGS_SIZE, ARM_VFP2_REGS_SIZE, ARM_VFP3_REGS_SIZE)
7391         (IWMMXT_REGS_SIZE): Add define.
7392         * arm-linux-nat.c (IWMMXT_REGS_SIZE): Remove define.
7393         (fetch_vfp_regs, store_vfp_regs)
7394         (arm_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
7395         * arm-tdep.c (arm_register_g_packet_guesses): Use new defines.
7396
7397 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
7398
7399         * arch/arm-get-next-pcs.c (thumb_get_next_pcs_raw): Use ARM_
7400         defines.
7401         * arch/arm-linux.c (arm_linux_sigreturn_next_pc_offset): Likewise.
7402         * arch/arm.h (INT_REGISTER_SIZE) Rename from...
7403         (ARM_INT_REGISTER_SIZE): ...to this.
7404         (ARM_FP_REGISTER_SIZE) (ARM_VFP_REGISTER_SIZE): Add define.
7405         * arm-linux-tdep.c (ARM_LINUX_JB_ELEMENT_SIZE)
7406         (ARM_LINUX_SIZEOF_GREGSET, arm_linux_supply_gregset)
7407         (arm_linux_collect_gregset, supply_nwfpe_register)
7408         (collect_nwfpe_register, arm_linux_collect_nwfpe): Use ARM_
7409         defines.
7410         * arm-linux-tdep.h (ARM_LINUX_SIZEOF_NWFPE, NWFPE_FPSR_OFFSET)
7411         (NWFPE_FPCR_OFFSET, NWFPE_TAGS_OFFSET): Likewise
7412         * arm-nbsd-tdep.c (ARM_NBSD_JB_ELEMENT_SIZE): Likewise.
7413         * arm-tdep.c (arm_push_dummy_call, arm_extract_return_value)
7414         (arm_return_in_memory, arm_store_return_value)
7415         (arm_get_longjmp_target, arm_register_g_packet_guesses)
7416         (arm_record_ld_st_multiple): Likewise.
7417         * arm-tdep.h (FP_REGISTER_SIZE, VFP_REGISTER_SIZE): Remove.
7418         * arm-wince-tdep.c (ARM_WINCE_JB_ELEMENT_SIZE): Use ARM_ defines.
7419
7420 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
7421
7422         * aarch64-linux-tdep.c (aarch64_linux_init_abi): Use
7423         AARCH64_DISPLACED_MODIFIED_INSNS.
7424         * aarch64-tdep.c (struct aarch64_displaced_step_data)
7425         (aarch64_displaced_step_copy_insn): Likewise.
7426         * aarch64-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
7427         (AARCH64_DISPLACED_MODIFIED_INSNS): ...to this.
7428         * arm-linux-tdep.c (arm_linux_cleanup_svc): Use
7429         ARM_DISPLACED_MODIFIED_INSNS.
7430         * arm-tdep.c (arm_gdbarch_init): Likewise.
7431         * arm-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
7432         (ARM_DISPLACED_MODIFIED_INSNS): ...to this.
7433         (struct arm_displaced_step_closure): Use
7434         ARM_DISPLACED_MODIFIED_INSNS.
7435
7436 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
7437
7438         * features/Makefile: Remove unused xml files.
7439         * features/aarch64.xml: Remove.
7440         * features/i386/amd64-avx-avx512-linux.xml: Remove.
7441         * features/i386/amd64-avx-avx512.xml: Remove.
7442         * features/i386/amd64-avx-linux.xml: Remove.
7443         * features/i386/amd64-avx-mpx-avx512-pku-linux.xml: Remove.
7444         * features/i386/amd64-avx-mpx-avx512-pku.xml: Remove.
7445         * features/i386/amd64-avx-mpx-linux.xml: Remove.
7446         * features/i386/amd64-avx-mpx.xml: Remove.
7447         * features/i386/amd64-avx.xml: Remove.
7448         * features/i386/amd64-linux.xml: Remove.
7449         * features/i386/amd64-mpx-linux.xml: Remove.
7450         * features/i386/amd64-mpx.xml: Remove.
7451         * features/i386/amd64.xml: Remove.
7452         * features/i386/i386-avx-avx512-linux.xml: Remove.
7453         * features/i386/i386-avx-avx512.xml: Remove.
7454         * features/i386/i386-avx-linux.xml: Remove.
7455         * features/i386/i386-avx-mpx-avx512-pku-linux.xml: Remove.
7456         * features/i386/i386-avx-mpx-avx512-pku.xml: Remove.
7457         * features/i386/i386-avx-mpx-linux.xml: Remove.
7458         * features/i386/i386-avx-mpx.xml: Remove.
7459         * features/i386/i386-avx.xml: Remove.
7460         * features/i386/i386-linux.xml: Remove.
7461         * features/i386/i386-mmx-linux.xml: Remove.
7462         * features/i386/i386-mmx.xml: Remove.
7463         * features/i386/i386-mpx-linux.xml: Remove.
7464         * features/i386/i386-mpx.xml: Remove.
7465         * features/i386/i386.xml: Remove.
7466         * features/i386/x32-avx-avx512-linux.xml: Remove.
7467         * features/i386/x32-avx-linux.xml: Remove.
7468         * features/i386/x32-linux.xml: Remove.
7469
7470 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
7471
7472         * regformats/aarch64.dat: Remove.
7473         * regformats/i386/amd64-avx-avx512-linux.dat: Remove.
7474         * regformats/i386/amd64-avx-linux.dat: Remove.
7475         * regformats/i386/amd64-avx-mpx-avx512-pku-linux.dat: Remove.
7476         * regformats/i386/amd64-avx-mpx-linux.dat: Remove.
7477         * regformats/i386/amd64-linux.dat: Remove.
7478         * regformats/i386/amd64-mpx-linux.dat: Remove.
7479         * regformats/i386/amd64.dat: Remove.
7480         * regformats/i386/i386-avx-avx512-linux.dat: Remove.
7481         * regformats/i386/i386-avx-linux.dat: Remove.
7482         * regformats/i386/i386-avx-mpx-avx512-pku-linux.dat: Remove.
7483         * regformats/i386/i386-avx-mpx-linux.dat: Remove.
7484         * regformats/i386/i386-linux.dat: Remove.
7485         * regformats/i386/i386-mmx-linux.dat: Remove.
7486         * regformats/i386/i386-mpx-linux.dat: Remove.
7487         * regformats/i386/i386.dat: Remove.
7488         * regformats/i386/x32-avx-avx512-linux.dat: Remove.
7489         * regformats/i386/x32-avx-linux.dat: Remove.
7490         * regformats/i386/x32-linux.dat: Remove.
7491
7492 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
7493
7494         * aarch64-tdep.c: Remove xml self tests.
7495         * amd64-linux-tdep.c: Likewise.
7496         * amd64-tdep.c: Likewise.
7497         * i386-linux-tdep.c: Likewise.
7498         * i386-tdep.c: Likewise.
7499
7500 2019-07-03  Pedro Alves  <palves@redhat.com>
7501
7502         PR cli/24732
7503         * cli/cli-cmds.c (struct pipe_cmd_opts): New.
7504         (pipe_cmd_option_defs): New.
7505         (make_pipe_cmd_options_def_group): New.
7506         (pipe_command): Use gdb::option::process_options.
7507         (pipe_command_completer): New function.
7508         (_initialize_cli_cmds): Install completer for "pipe" command.
7509
7510 2019-07-03  Pedro Alves  <palves@redhat.com>
7511
7512         * cli/cli-option.c (union option_value) <string>: New field.
7513         (struct option_def_and_value): Add ctor, move ctor, dtor and
7514         use DISABLE_COPY_AND_ASSIGN.
7515         (option_def_and_value::clear_value): New.
7516         (parse_option, save_option_value_in_ctx, get_val_type_str)
7517         (add_setshow_cmds_for_options): Handle var_string.
7518         * cli-option.h (union option_def::var_address) <string>: New
7519         field.
7520         (struct string_option_def): New.
7521         * maint-test-options.c (struct test_options_opts): Add default
7522         ctor and use DISABLE_COPY_AND_ASSIGN.
7523         <string_opt>: New field.
7524         (test_options_opts::~test_options_opts): New.
7525         (test_options_opts::dump): Also dump "-string".
7526         (test_options_option_defs): Install "string.
7527
7528 2019-07-03  Pedro Alves  <palves@redhat.com>
7529
7530         * cli/cli-option.c (parse_option) <var_enum>: Don't return an
7531         option_value with a null enumeration.
7532         (complete_options): Save the option values in the context.
7533         (save_option_value_in_ctx): New, factored out from ...
7534         (process_options): ... here.
7535         * cli/cli-utils.c (get_ulongest): Don't advance PP until the end
7536         of the function.
7537         * maint-test-options.c (test_options_opts::dump): New, factored
7538         out from ...
7539         (maintenance_test_options_command_mode): ... here.
7540         (maintenance_test_options_command_completion_result): Delete.
7541         (maintenance_test_options_command_completion_text): Update
7542         comment.
7543         (maintenance_show_test_options_completion_result): Change
7544         prototype.  Just print
7545         maintenance_test_options_command_completion_text.
7546         (save_completion_result): New.
7547         (maintenance_test_options_completer_mode): Pass options context to
7548         complete_options, and then save a dump.
7549         (_initialize_maint_test_options): Use add_cmd to install "maint
7550         show test-options-completion-result".
7551
7552 2019-07-03  Pedro Alves  <palves@redhat.com>
7553
7554         * NEWS (New commands): Mention "with" and "maint with".
7555         * cli/cli-cmds.c (with_command_1, with_command_completer_1)
7556         (with_command, with_command_completer): New.
7557         (pipe_command): Adjust to new repeat_previous
7558         interface.
7559         (_initialize_cli_cmds): Install the "with" command and its "w"
7560         alias.
7561         * cli/cli-cmds.h (with_command_1, with_command_completer_1): New
7562         declarations.
7563         * cli/cli-setshow.c (parse_cli_var_uinteger)
7564         (parse_cli_var_zuinteger_unlimited, do_set_command): Handle empty
7565         argument strings for all var_types.
7566         (get_setshow_command_value_string): New, factored out from ...
7567         (do_show_command): ... this.
7568         * cli/cli-setshow.h: Include <string>.
7569         (get_setshow_command_value_string): Declare.
7570         * command.h (repeat_previous): Now returns const char *.  Adjust
7571         comment.
7572         * maint.c: Include "cli/cli-cmds.h".
7573         (maintenance_with_cmd, maintenance_with_cmd_completer): New.
7574         (_initialize_maint_cmds): Register the "maintenance with" command.
7575         * top.c (repeat_previous): Move bits from pipe_command here:
7576         Return the saved command line, if any; error out if there's no
7577         command to relaunch.
7578
7579 2019-07-03  Pedro Alves  <palves@redhat.com>
7580
7581         * NEWS (New commands): Mention "maint set/show test-settings"
7582         instead of "maint test-settings".
7583         * maint-test-settings.c (maintenance_test_settings_list): Delete.
7584         (maintenance_test_settings_set_list): Rename to ...
7585         (maintenance_set_test_settings_list): ... this.
7586         (maintenance_test_settings_show_list): Rename to  ...
7587         (maintenance_show_test_settings_list): ... this.
7588         (maintenance_test_settings_cmd): Delete.
7589         (maintenance_test_settings_set_cmd): ...
7590         (maintenance_set_test_settings_cmd): ... this.
7591         (maintenance_test_settings_show_cmd): ...
7592         (maintenance_show_test_settings_cmd): ... this.
7593         (maintenance_test_settings_show_value_cmd):
7594         (maintenance_show_test_settings_value_cmd): ... this.
7595         (_initialize_maint_test_settings): No longer install the "maint
7596         test-settings" prefix command.  Rename "maint test-settings set"
7597         to "maint set test-settings", and "maint test-settings show" to
7598         "maint show test-settings".  Adjust all subcommands.
7599
7600 2019-07-03  Pedro Alves  <palves@redhat.com>
7601
7602         * maint-test-settings.c: Fix file's intro comment.  Replace all
7603         references to "test-options" with references to "test-settings",
7604         in comments.
7605
7606 2019-07-03  Pedro Alves  <palves@redhat.com>
7607
7608         * maint-test-settings.c (maintenance_test_settings_xxx)
7609         (maintenance_test_settings_yyy, maintenance_test_settings_zzz):
7610         New.
7611         (maintenance_test_settings_enums): Use them.
7612         (maintenance_test_settings_enum): Default to
7613         maintenance_test_settings_xxx.
7614         (_initialize_maint_test_settings): Initialize
7615         MAINTENANCE_TEST_SETTINGS_FILENAME.
7616
7617 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
7618
7619         * breakpoint.h (remove_breakpoints_inf): Change return type to
7620         void, move function documentation here.
7621         * breakpoint.c (remove_breakpoints_inf): Change return type to
7622         void, move function documentation to header.
7623
7624 2019-07-02  Pedro Alves  <palves@redhat.com>
7625
7626         * NEWS (Completion improvements): Mention "info threads".
7627         * thread.c (struct info_threads_opts, info_threads_option_defs)
7628         (make_info_threads_options_def_group): New.
7629         (info_threads_command): Use gdb::option::process_options.
7630         (info_threads_command_completer): New.
7631         (_initialize_thread): Use gdb::option::build_help to build the
7632         help text for "info threads".
7633
7634 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
7635
7636         * defs.h (generic_load): Move from here...
7637         * symfile.h (generic_load): ... to here.  Rename name parameter
7638         to args.
7639         * symfile.c (generic_load): Add comment.
7640
7641 2019-07-01  Tom Tromey  <tromey@adacore.com>
7642
7643         * dwarf2read.c
7644         (dw2_debug_names_iterator::find_vec_in_debug_names): Hoist
7645         declaration of without_params.  Fix formatting.
7646
7647 2019-07-01  Tom Tromey  <tromey@adacore.com>
7648
7649         * ada-exp.y (find_primitive_type): Update.
7650         * ada-lang.h (ada_lookup_symbol): Update.
7651         * ada-lang.c (ada_lookup_symbol): Remove "is_a_field_of_this"
7652         parameter.
7653         (ada_lookup_encoded_symbol, ada_lookup_symbol_nonlocal): Update.
7654
7655 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
7656
7657         PR breakpoints/24541
7658         * gdbarch.c: Regenerate.
7659         * gdbarch.h: Regenerate.
7660         * gdbarch.sh: Add 'stap_adjust_register'.
7661         * i386-tdep.c: Include '<unordered_set>'.
7662         (i386_stap_adjust_register): New function.
7663         (i386_elf_init_abi): Register 'i386_stap_adjust_register'.
7664         * stap-probe.c (stap_parse_register_operand): Call
7665         'gdbarch_stap_adjust_register'.
7666
7667 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
7668
7669         PR python/24742
7670         https://bugzilla.redhat.com/show_bug.cgi?id=1723564
7671         * python/python.c (do_start_initialization): Use 'xmalloc'
7672         instead of 'PyMem_Malloc'.
7673
7674 2019-06-28  Tom Tromey  <tromey@adacore.com>
7675
7676         * dwarf2read.c (partial_die_info::read): Prefer the linkage name
7677         for Ada.
7678
7679 2019-06-27  Tom Tromey  <tromey@adacore.com>
7680
7681         * arm-tdep.c (arm_objfile_data_key): Move lower.  Change type to
7682         objfile_key.
7683         (arm_find_mapping_symbol, arm_record_special_symbol)
7684         (_initialize_arm_tdep): Update.
7685         (arm_objfile_data_free): Remove.
7686
7687 2019-06-27  Tom Tromey  <tromey@adacore.com>
7688
7689         * cp-valprint.c (cp_print_value_fields): Pass opts, not options,
7690         to cp_print_static_field.
7691
7692 2019-06-26  Tom Tromey  <tromey@adacore.com>
7693
7694         * minsyms.c (lookup_minimal_symbol_solib_trampoline): Remove.
7695         * minsyms.h (lookup_minimal_symbol_solib_trampoline): Don't
7696         declare.
7697
7698 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
7699
7700         * features/aarch64-core.c (create_feature_aarch64_core):
7701         Regenerate.
7702         * features/aarch64-core.xml: Add cpsr flags.
7703
7704 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
7705
7706         * arm-tdep.c (arm_gnu_triplet_regexp): New function.
7707         (arm_gdbarch_init): Add arm_gnu_triplet_regexp.
7708
7709 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
7710
7711         * arm-tdep.c (struct arm_per_objfile) <section_maps_sorted>: New
7712         field.
7713         (arm_find_mapping_symbol): Sort mapping symbol vectors on first
7714         use.
7715         (arm_record_special_symbol): Don't insert new symbol in sorted
7716         position, push it at the end.
7717
7718 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
7719
7720         * arm-tdep.c (struct arm_mapping_symbol) (operator <): New.
7721         (arm_mapping_symbol_s): Remove.
7722         (DEF_VEC_O(arm_mapping_symbol_s)): Remove.
7723         (arm_mapping_symbol_vec): New typedef.
7724         (struct arm_per_objfile): Add constructor.
7725         <section_maps>: Change type to
7726         std::unique_ptr<arm_mapping_symbol_vec[]>.
7727         (arm_compare_mapping_symbols): Remove.
7728         (arm_find_mapping_symbol): Adjust to section_maps type change.
7729         (arm_objfile_data_free): Call delete on arm_per_objfile.
7730         (arm_record_special_symbol): Adjust to section_maps type change.
7731         Allocate arm_per_objfile with new.
7732
7733 2019-06-25  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7734
7735         * cli/cli-cmds.c (alias_command): Compare the alias prefix
7736         with the command prefix.
7737
7738 2019-06-25  Tom Tromey  <tom@tromey.com>
7739
7740         * tui/tui-wingeneral.c (tui_delete_win): Remove "return".
7741         * tui/tui-data.c (~tui_gen_win_info): Remove "if".
7742
7743 2019-06-25  Tom Tromey  <tom@tromey.com>
7744
7745         * tui/tui-layout.c (init_and_make_win): Assert on unrecognized
7746         type.
7747         * tui/tui-data.h (struct tui_gen_win_info): Make constructor
7748         protected.
7749
7750 2019-06-25  Tom Tromey  <tom@tromey.com>
7751
7752         * tui/tui-winsource.c
7753         (tui_source_window_base::set_is_exec_point_at): Add check against
7754         LOA_ADDRESS.
7755
7756 2019-06-25  Tom Tromey  <tom@tromey.com>
7757
7758         * tui/tui-source.c (tui_set_source_content): Don't check before
7759         xfree.
7760         * tui/tui-disasm.c (tui_disassemble): Don't check before xfree.
7761
7762 2019-06-25  Tom Tromey  <tom@tromey.com>
7763
7764         * tui/tui-winsource.h (tui_update_source_window_as_is)
7765         (tui_alloc_source_buffer, tui_line_is_displayed)
7766         (tui_addr_is_displayed): Change type of win_info.
7767         * tui/tui-winsource.c (tui_update_source_window_as_is)
7768         (tui_clear_source_content, tui_show_source_line)
7769         (tui_show_source_content, tui_source_window_base::refill)
7770         (tui_source_window_base::set_is_exec_point_at)
7771         (tui_source_window_base::set_is_exec_point_at)
7772         (tui_update_breakpoint_info, tui_set_exec_info_content): Update.
7773         (tui_alloc_source_buffer, tui_line_is_displayed)
7774         (tui_addr_is_displayed): Change type of win_info.  Update.
7775         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
7776         (tui_source_window_base::do_make_visible_with_new_height):
7777         Update.
7778         * tui/tui-source.c (tui_set_source_content)
7779         (tui_set_source_content_nil)
7780         (tui_source_window::do_scroll_vertical): Update.
7781         * tui/tui-layout.c (show_layout): Update.
7782         * tui/tui-disasm.c (tui_set_disassem_content)
7783         (tui_disasm_window::do_scroll_vertical): Update.
7784         * tui/tui-data.h (tui_win_content): Remove.
7785         (struct tui_gen_win_info) <content, content_size>: Remove.
7786         (struct tui_source_element): Add initializers and destructor.
7787         (union tui_which_element, struct tui_win_element): Remove.
7788         (struct tui_source_window_base) <content>: New field.
7789         (struct tui_data_window): Remove destructor.
7790         (tui_alloc_content, tui_free_win_content)
7791         (tui_free_all_source_wins_content): Don't declare.
7792         * tui/tui-data.c (tui_initialize_static_data): Update.
7793         (init_content_element, tui_alloc_content): Remove.
7794         (~tui_gen_win_info): Update.
7795         (~tui_data_window, tui_free_all_source_wins_content)
7796         (tui_free_win_content, free_content, free_content_elements):
7797         Remove.
7798
7799 2019-06-25  Tom Tromey  <tom@tromey.com>
7800
7801         * tui/tui-winsource.h (tui_clear_source_content)
7802         (tui_erase_source_content, tui_show_source_content): Change type
7803         of win_info.
7804         * tui/tui-winsource.c (tui_clear_source_content)
7805         (tui_erase_source_content, tui_show_source_content): Change type
7806         of win_info.
7807         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
7808         * tui/tui-source.h (tui_set_source_content_nil): Change type of
7809         win_info.
7810         * tui/tui-source.c (tui_set_source_content_nil): Change type of
7811         win_info.
7812         * tui/tui-layout.c (show_source_or_disasm_and_command): Update.
7813
7814 2019-06-25  Tom Tromey  <tom@tromey.com>
7815
7816         * tui/tui-winsource.c (tui_clear_source_content)
7817         (tui_source_window_base::set_is_exec_point_at): Update.
7818         * tui/tui-source.c (tui_set_source_content_nil): Update.
7819         * tui/tui-data.h (struct tui_source_element) <is_exec_point>: Now
7820         a bool.
7821         * tui/tui-data.c (init_content_element): Update.
7822
7823 2019-06-25  Tom Tromey  <tom@tromey.com>
7824
7825         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Update.
7826         * tui/tui-win.c (make_invisible_and_set_new_height): Update.
7827         * tui/tui-layout.c (init_and_make_win): Update.
7828         * tui/tui.h (enum tui_win_type): Update.
7829         * tui/tui-data.h (tui_win_is_auxiliary): Rename from
7830         tui_win_is_auxillary.
7831         * tui/tui-data.c (tui_win_is_auxiliary): Rename from
7832         tui_win_is_auxillary.
7833
7834 2019-06-25  Tom Tromey  <tom@tromey.com>
7835
7836         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Update.
7837         * tui/tui-windata.c (tui_data_window::first_data_item_displayed)
7838         (tui_delete_data_content_windows, tui_display_all_data)
7839         (tui_data_window::do_scroll_vertical, tui_display_data_from):
7840         Update.
7841         * tui/tui-win.c (tui_data_window::set_new_height): Simplify.
7842         * tui/tui-regs.c (tui_last_regs_line_no)
7843         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
7844         (tui_show_registers): Update.
7845         (tui_show_register_group): Return void.  Update.
7846         (tui_display_registers_from, tui_display_reg_element_at_line)
7847         (tui_display_registers_from_line, tui_check_register_values):
7848         Update.
7849         * tui/tui-data.h (union tui_which_element) <data_window>: Remove
7850         member.
7851         (struct tui_data_window) <regs_content>: Now a std::vector.
7852         <regs_content_count>: Remove.
7853         (tui_add_content_elements, tui_free_data_content): Don't declare.
7854         * tui/tui-data.c (tui_data_window::clear_detail): Update.
7855         (init_content_element): Remove DATA_WIN case.  Add assert.
7856         (tui_add_content_elements): Remove.
7857         (tui_data_window): Update.
7858         (tui_free_data_content): Remove.
7859         (free_content_elements): Remove DATA_WIN case.
7860
7861 2019-06-25  Tom Tromey  <tom@tromey.com>
7862
7863         * tui/tui-data.c (tui_data_item_window): Update.
7864         * tui/tui-windata.h (tui_check_data_values): Don't declare.
7865         * tui/tui-windata.c (tui_display_all_data)
7866         (tui_display_data_from_line): Update.
7867         (tui_check_data_values): Remove.
7868         * tui/tui-regs.c (tui_show_register_group)
7869         (tui_display_reg_element_at_line): Update.
7870         * tui/tui-hooks.c (tui_register_changed)
7871         (tui_refresh_frame_and_register_information): Call
7872         tui_check_register_values.
7873         * tui/tui-data.h (struct tui_data_window) <data_content,
7874         data_content_count, data_type>: Remove.
7875         (enum tui_data_type): Remove.
7876
7877         * tui/tui-data.c (tui_data_window::clear_detail)
7878         (~tui_data_window): Update.
7879
7880 2019-06-25  Tom Tromey  <tom@tromey.com>
7881
7882         * tui/tui-windata.h (tui_first_data_item_displayed): Don't
7883         declare.
7884         * tui/tui-windata.c (tui_data_window::first_data_item_displayed):
7885         Rename from tui_first_data_item_displayed.  Update.
7886         (tui_data_window::refresh_all)
7887         (tui_data_window::do_scroll_vertical): Update.
7888         * tui/tui-data.h (struct tui_data_window)
7889         <first_data_item_displayed>: Declare new method.
7890
7891 2019-06-25  Tom Tromey  <tom@tromey.com>
7892
7893         * tui/tui-data.h (tui_init_generic_part): Don't declare.
7894         * tui/tui-data.c (tui_init_generic_part): Remove, moving
7895         contents...
7896         (tui_initialize_static_data): ...here.
7897
7898 2019-06-25  Tom Tromey  <tom@tromey.com>
7899
7900         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
7901         (tui_display_registers_from, tui_check_register_values): Update.
7902         (tui_display_register): Remove win_info parameter; update.
7903         (tui_get_register): Change type of parameters.
7904         * tui/tui-data.h (struct tui_data_element): Remove.
7905         (union tui_which_element) <data>: Remove.
7906         <data_window>: Change type.
7907         (struct tui_data_item_window): New.
7908         * tui/tui-data.c (init_content_element): Remove DATA_ITEM_WIN
7909         case.  Add assert.
7910         (~tui_data_item_window): New destructor.
7911         (free_content_elements): Remove DATA_ITEM_WIN case.
7912
7913 2019-06-25  Tom Tromey  <tom@tromey.com>
7914
7915         * tui/tui.h (enum tui_win_type) <MAX_WINDOWS, UNDEFINED_WIN>:
7916         Remove.
7917
7918 2019-06-25  Tom Tromey  <tom@tromey.com>
7919
7920         * tui/tui-data.h (struct tui_command_element): Remove.
7921         (union tui_which_element) <command>: Remove.
7922         * tui/tui-data.c (init_content_element): Remove CMD_WIN case.  Add
7923         assert.
7924         (free_content_elements): Remove CMD_WIN case.
7925
7926 2019-06-25  Tom Tromey  <tom@tromey.com>
7927
7928         * tui/tui-layout.c (tui_set_layout): Update.
7929         * tui/tui-data.h (struct tui_layout_def) <split>: Remove.
7930         * tui/tui-data.c (layout_def): Update.
7931
7932 2019-06-25  Tom Tromey  <tom@tromey.com>
7933
7934         * tui/tui-wingeneral.c (tui_refresh_all): Update.
7935         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
7936         (tui_source_window_base::set_new_height): Update.
7937         * tui/tui-stack.c (tui_make_status_line): Change parameter type.
7938         Update.
7939         (tui_set_locator_fullname, tui_set_locator_info)
7940         (tui_show_frame_info): Update.
7941         * tui/tui-source.c (tui_set_source_content)
7942         (tui_source_is_displayed): Update.
7943         * tui/tui-layout.c (show_source_disasm_command, show_data)
7944         (show_source_or_disasm_and_command): Update.
7945         * tui/tui-disasm.c (tui_set_disassem_content)
7946         (tui_get_begin_asm_address): Update.
7947         * tui/tui-data.h (struct tui_locator_element): Remove.
7948         (union tui_which_element) <locator>: Remove.
7949         (struct tui_locator_window): New.
7950         (tui_locator_win_info_ptr): Change return type.
7951         * tui/tui-data.c (_locator): Change type.
7952         (tui_locator_win_info_ptr): Change return type.
7953         (init_content_element): Remove LOCATOR_WIN case.  Add assert.
7954         (tui_alloc_content): Add assert.
7955
7956 2019-06-25  Tom Tromey  <tom@tromey.com>
7957
7958         * tui/tui-winsource.c
7959         (tui_exec_info_window::maybe_allocate_content): New method.
7960         (tui_set_exec_info_content, tui_show_exec_info_content): Update.
7961         * tui/tui-layout.c (init_and_make_win): Add EXEC_INFO_WIN case.
7962         (make_source_or_disasm_window): Add cast.
7963         * tui/tui-data.h (union tui_which_element) <simple_string>:
7964         Remove.
7965         (struct tui_source_info): New.
7966         (struct tui_source_window_base) <execution_info>: Change type.
7967         * tui/tui-data.c (init_content_element): Remove EXEC_INFO_WIN
7968         case, and add assert.
7969         (tui_alloc_content): Add assert.
7970
7971 2019-06-25  Tom Tromey  <tom@tromey.com>
7972
7973         * tui/tui-data.h (tui_alloc_win_info): Don't declare.
7974         * tui/tui-layout.c (init_and_make_win): Use "new" directly.
7975         * tui/tui-data.c (tui_alloc_win_info): Remove.
7976
7977 2019-06-25  Tom Tromey  <tom@tromey.com>
7978
7979         * tui/tui-win.c (tui_set_win_focus_to): Don't check window type.
7980         * tui/tui-wingeneral.c (tui_unhighlight_win): Check
7981         can_highlight.
7982
7983 2019-06-25  Tom Tromey  <tom@tromey.com>
7984
7985         * tui/tui-win.c (tui_source_window_base::update_tab_width): Call
7986         make_visible_with_new_height method.
7987         (tui_win_info::make_visible_with_new_height): New method.
7988         (tui_source_window_base::do_make_visible_with_new_height)
7989         (tui_data_window::do_make_visible_with_new_height)
7990         (tui_cmd_window::do_make_visible_with_new_height): New methods.
7991         (make_visible_with_new_height): Remove.
7992         (tui_resize_all, tui_adjust_win_heights): Use
7993         make_visible_with_new_height method.
7994         * tui/tui-data.h (struct tui_win_info)
7995         <do_make_visible_with_new_height, make_visible_with_new_height>:
7996         New methods.
7997         (struct tui_source_window_base, struct tui_data_window)
7998         (struct tui_cmd_window) <do_make_visible_with_new_height>: New
7999         methods.
8000
8001 2019-06-25  Tom Tromey  <tom@tromey.com>
8002
8003         * tui/tui-win.c (tui_source_window_base::update_tab_width): New
8004         method.
8005         (update_tab_width): Call update_tab_width method.
8006         * tui/tui-data.h (struct tui_win_info)
8007         (struct tui_source_window_base) <update_tab_width>: New methods.
8008
8009 2019-06-25  Tom Tromey  <tom@tromey.com>
8010
8011         * tui/tui-wingeneral.h (tui_make_window): Change type of "box_it"
8012         parameter.
8013         * tui/tui-wingeneral.c (tui_make_window): Change type of "box_it"
8014         parameter.
8015         (tui_gen_win_info::make_visible): Update.
8016         * tui/tui-layout.c (init_and_make_win): Change type of "box_it"
8017         parameter.
8018         * tui/tui-data.h (enum tui_box): New enum.
8019         (BOX_WINDOW, DONT_BOX_WINDOW): Remove defines.
8020
8021 2019-06-25  Tom Tromey  <tom@tromey.com>
8022
8023         * tui/tui-layout.c (make_source_or_disasm_window): Always use
8024         init_and_make_win for EXEC_INFO_WIN.
8025         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>: No
8026         longer inline.
8027         (struct tui_win_info) <~tui_win_info>: Inline.
8028         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
8029         Don't declare.
8030         * tui/tui-data.c (source_win, disasm_win): Remove globals.
8031         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
8032         Remove.
8033         (tui_initialize_static_data): Update.
8034         (~tui_gen_win_info): Handle more cleanup here.
8035         (~tui_source_window_base): Delete "execution_info".
8036         (~tui_win_info): Move code to ~tui_gen_win_info; remove.
8037
8038 2019-06-25  Tom Tromey  <tom@tromey.com>
8039
8040         * tui/tui-layout.c (make_command_window): Don't set
8041         can_highlight.
8042         (show_source_disasm_command): Call the reset method.
8043         (show_data): Don't set can_highlight.  Call the reset method.
8044         (tui_gen_win_info::reset): Rename from init_gen_win_info
8045         (init_and_make_win): Simplify.  Return tui_gen_win_info.
8046         (show_source_or_disasm_and_command): Call the reset method.
8047         * tui/tui-data.h (struct tui_gen_win_info) <reset>: New method.
8048         (struct tui_cmd_window): Set can_highlight.
8049
8050 2019-06-25  Tom Tromey  <tom@tromey.com>
8051
8052         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Rename
8053         from make_visible.
8054         (tui_make_visible, tui_make_invisible): Rewrite.
8055         (tui_win_info::make_visible): Remove.
8056         (tui_source_window_base::make_visible): Update.
8057         * tui/tui-data.h (struct tui_gen_win_info) <make_visible>: New
8058         method.  Moved from...
8059         (struct tui_win_info) <make_visible>: ...here.
8060
8061 2019-06-25  Tom Tromey  <tom@tromey.com>
8062
8063         * tui/tui-winsource.c
8064         (tui_source_window_base::do_scroll_horizontal): Remove direction
8065         parameter.
8066         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Remove
8067         direction parameter.
8068         * tui/tui-win.c (tui_win_info::forward_scroll)
8069         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
8070         (tui_win_info::right_scroll): Update.
8071         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Remove
8072         direction parameter.
8073         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Remove
8074         direction parameter.
8075         * tui/tui-data.h (enum tui_scroll_direction): Remove.
8076         (struct tui_win_info) <do_scroll_vertical, do_scroll_horizontal>:
8077         Remove direction parameter.
8078         (struct tui_source_window_base, struct tui_source_window)
8079         (struct tui_disasm_window, struct tui_data_window)
8080         (struct tui_cmd_window): Update.
8081
8082 2019-06-25  Tom Tromey  <tom@tromey.com>
8083
8084         * tui/tui-winsource.h (tui_set_exec_info_content)
8085         (tui_show_exec_info_content, tui_erase_exec_info_content)
8086         (tui_clear_exec_info_content, tui_update_exec_info): Change
8087         argument to tui_source_window_base.
8088         * tui/tui-winsource.c (tui_set_exec_info_content)
8089         (tui_show_exec_info_content, tui_erase_exec_info_content)
8090         (tui_clear_exec_info_content, tui_update_exec_info): Change
8091         argument to tui_source_window_base.
8092
8093 2019-06-25  Tom Tromey  <tom@tromey.com>
8094
8095         * tui/tui-winsource.h (tui_set_exec_info_content): Return void.
8096         * tui/tui-winsource.c (tui_set_exec_info_content): Return void.
8097
8098 2019-06-25  Tom Tromey  <tom@tromey.com>
8099
8100         * tui/tui-winsource.c (tui_set_exec_info_content): Remove NULL
8101         check.
8102
8103 2019-06-25  Tom Tromey  <tom@tromey.com>
8104
8105         * tui/tui-winsource.h (tui_alloc_source_buffer): Change return
8106         type to void.
8107         * tui/tui-winsource.c (tui_alloc_source_buffer): Change return
8108         type to void.
8109         * tui/tui-source.c (tui_set_source_content): Update.
8110         * tui/tui-disasm.c (tui_set_disassem_content): Update.
8111
8112 2019-06-25  Tom Tromey  <tom@tromey.com>
8113
8114         * tui/tui-win.c (window_name_completer, tui_set_focus)
8115         (tui_all_windows_info): Use name method.
8116         * tui/tui-data.h (struct tui_gen_win_info)
8117         (struct tui_source_window, struct tui_disasm_window)
8118         (struct tui_data_window, struct tui_cmd_window) <name>: New
8119         method.
8120         (tui_win_name): Don't declare.
8121         * tui/tui-data.c (tui_partial_win_by_name): Use name method.
8122         (tui_win_name): Remove.
8123
8124 2019-06-25  Tom Tromey  <tom@tromey.com>
8125
8126         * tui/tui-winsource.h (tui_update_source_window)
8127         (tui_update_source_window_as_is): Change parameter type.
8128         * tui/tui-winsource.c (tui_update_source_window): Change win_info
8129         to be a tui_source_window_base.
8130         (tui_update_source_window_as_is): Likewise.
8131         * tui/tui-win.c (make_visible_with_new_height): Update.
8132
8133 2019-06-25  Tom Tromey  <tom@tromey.com>
8134
8135         * tui/tui-winsource.c (tui_erase_source_content)
8136         (tui_show_source_content, tui_show_exec_info_content)
8137         (tui_erase_exec_info_content): Use refresh_window method.
8138         * tui/tui-wingeneral.h (tui_refresh_win): Don't declare.
8139         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Rename
8140         from tui_refresh_win.
8141         (tui_data_window::refresh_window): New method.
8142         (tui_win_info::refresh, tui_source_window_base::refresh)
8143         (tui_refresh_all): Use refresh_window method.
8144         * tui/tui-stack.c (tui_show_locator_content): Call refresh_window
8145         method.
8146         * tui/tui-regs.c (tui_display_register): Call refresh_window
8147         method.
8148         * tui/tui-layout.c (show_source_disasm_command)
8149         (show_source_or_disasm_and_command): Call refresh_window method.
8150         * tui/tui-data.h (struct tui_gen_win_info)
8151         (struct tui_data_window, struct tui_cmd_window) <refresh_window>:
8152         New method.
8153
8154 2019-06-25  Tom Tromey  <tom@tromey.com>
8155
8156         * tui/tui.c (tui_rl_other_window, tui_enable)
8157         (tui_is_window_visible, tui_get_command_dimension): Update.
8158         * tui/tui-winsource.c (tui_update_source_window_as_is)
8159         (tui_clear_source_content, tui_erase_source_content)
8160         (tui_show_source_line, tui_source_window_base::refill)
8161         (tui_source_window_base::do_scroll_horizontal)
8162         (tui_source_window_base::set_is_exec_point_at)
8163         (tui_update_breakpoint_info, tui_set_exec_info_content)
8164         (tui_alloc_source_buffer, tui_line_is_displayed)
8165         (tui_addr_is_displayed): Update.
8166         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
8167         (tui_check_and_display_highlight_if_needed)
8168         (tui_win_info::make_visible, tui_win_info::refresh)
8169         (tui_refresh_all): Update.
8170         * tui/tui-windata.c (tui_first_data_item_displayed)
8171         (tui_delete_data_content_windows, tui_erase_data_content)
8172         (tui_display_all_data, tui_data_window::refresh_all)
8173         (tui_check_data_values): Update.
8174         * tui/tui-win.c (window_name_completer, tui_update_gdb_sizes)
8175         (tui_set_win_focus_to, tui_win_info::forward_scroll)
8176         (tui_win_info::backward_scroll, tui_refresh_all_win)
8177         (tui_resize_all, tui_set_focus, tui_all_windows_info)
8178         (update_tab_width, tui_set_win_height, tui_adjust_win_heights)
8179         (tui_source_window_base::set_new_height)
8180         (tui_data_window::set_new_height)
8181         (make_invisible_and_set_new_height)
8182         (make_visible_with_new_height, new_height_ok)
8183         (parse_scrolling_args): Update.
8184         * tui/tui-stack.c (tui_show_frame_info): Update.
8185         * tui/tui-source.c (tui_set_source_content)
8186         (tui_set_source_content_nil, tui_source_is_displayed)
8187         (tui_source_window::do_scroll_vertical): Update.
8188         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
8189         (tui_display_registers_from, tui_display_reg_element_at_line)
8190         (tui_check_register_values, tui_reg_command): Update.
8191         * tui/tui-layout.c (tui_default_win_height)
8192         (show_source_disasm_command, show_data, init_and_make_win)
8193         (show_source_or_disasm_and_command): Update.
8194         * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
8195         (tui_redisplay_readline, tui_mld_flush)
8196         (tui_mld_erase_entire_line, tui_mld_getc, tui_cont_sig)
8197         (tui_getc): Update.
8198         * tui/tui-disasm.c (tui_set_disassem_content)
8199         (tui_disasm_window::do_scroll_vertical): Update.
8200         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>:
8201         Now virtual.
8202         (struct tui_win_info): Derive from tui_gen_win_info.
8203         <~tui_win_info>: Mark as override.
8204         <generic>: Remove member.
8205         * tui/tui-data.c (tui_cmd_window::clear_detail, tui_next_win)
8206         (tui_prev_win, tui_partial_win_by_name, tui_win_info)
8207         (~tui_data_window, ~tui_win_info)
8208         (tui_free_all_source_wins_content): Update.
8209         * tui/tui-command.c (tui_refresh_cmd_win): Update.
8210
8211 2019-06-25  Tom Tromey  <tom@tromey.com>
8212
8213         * tui/tui-layout.c (init_and_make_win): Use new.
8214         * tui/tui-data.h (struct tui_gen_win_info): Add constructor,
8215         destructor, initializers.
8216         (tui_alloc_generic_win_info): Don't declare.
8217         * tui/tui-data.c (_locator): Add argument to constructor.
8218         (source_win, disasm_win): New globals.
8219         (exec_info): Remove.
8220         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
8221         Update.
8222         (tui_alloc_generic_win_info): Remove.
8223         (init_content_element): Use new.
8224         (tui_win_info::tui_win_info): Update.
8225         (free_content_elements) <case DATA_WIN>: Use delete.
8226
8227 2019-06-25  Tom Tromey  <tom@tromey.com>
8228
8229         * tui/tui-wingeneral.c (tui_refresh_win): Update.
8230         * tui/tui-windata.c (tui_first_data_item_displayed)
8231         (tui_delete_data_content_windows): Update.
8232         * tui/tui-win.c (tui_data_window::set_new_height): Update.
8233         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
8234         (tui_display_registers_from, tui_check_register_values): Update.
8235         * tui/tui-data.h (union tui_which_element) <data_window>: Now a
8236         pointer.
8237         * tui/tui-data.c (init_content_element): Update.  Allocate the new
8238         window.
8239         (tui_free_data_content): Update.
8240         (free_content_elements) <case DATA_WIN>: Free the window.
8241
8242 2019-06-25  Tom Tromey  <tom@tromey.com>
8243
8244         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win):
8245         Update.
8246         * tui/tui-layout.c (make_command_window)
8247         (show_source_disasm_command, show_data, init_and_make_win)
8248         (show_source_or_disasm_and_command): Update.
8249         * tui/tui-data.h (struct tui_win_info) <set_highlight>: New
8250         method.
8251         <can_highight, is_highlighted>: Now bool.
8252         (tui_set_win_highlight): Don't declare.
8253         * tui/tui-data.c (tui_set_win_highlight): Remove.
8254
8255 2019-06-25  Tom Tromey  <tom@tromey.com>
8256
8257         * tui/tui-wingeneral.c (make_visible): Remove check of window
8258         type.
8259
8260 2019-06-25  Tom Tromey  <tom@tromey.com>
8261
8262         * tui/tui-win.c (tui_win_info::max_height)
8263         (tui_cmd_window::max_height): New methods.
8264         (new_height_ok): Call max_height.
8265         * tui/tui-data.h (struct tui_win_info, struct tui_cmd_window)
8266         <max_height>: New method.
8267
8268 2019-06-25  Tom Tromey  <tom@tromey.com>
8269
8270         * tui/tui-win.c (tui_source_window_base::set_new_height)
8271         (tui_data_window::set_new_height): New methods.
8272         (make_invisible_and_set_new_height): Call set_new_height method.
8273         * tui/tui-data.h (struct tui_win_info)
8274         (struct tui_source_window_base, struct tui_data_window)
8275         <set_new_height>: New method.
8276
8277 2019-06-25  Tom Tromey  <tom@tromey.com>
8278
8279         * tui/tui.c (tui_rl_other_window): Call the refresh_all method.
8280         * tui/tui-windata.c (tui_data_window::refresh_all): Rename from
8281         tui_refresh_data_win.
8282         * tui/tui-win.c (tui_source_window_base::refresh_all): New
8283         method.
8284         (tui_refresh_all_win): Call the refresh_all method.
8285         (tui_set_focus): Likewise.
8286         * tui/tui-data.h (struct tui_win_info) <refresh_all>: New method.
8287         (struct tui_source_window_base, struct tui_data_window) <refresh>:
8288         Likewise.
8289
8290 2019-06-25  Tom Tromey  <tom@tromey.com>
8291
8292         * tui/tui-winsource.h (tui_refill_source_window)
8293         (tui_set_is_exec_point_at): Don't declare.
8294         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
8295         (tui_source_window_base::refill): Rename from
8296         tui_refill_source_window.
8297         (tui_source_window_base::do_scroll_horizontal): Update.
8298         (tui_source_window_base::set_is_exec_point_at): Rename from
8299         tui_set_is_exec_point_at.
8300         (tui_update_all_breakpoint_info): Update.
8301         * tui/tui-stack.c (tui_show_frame_info): Update.
8302         * tui/tui-layout.c (show_data): Add cast.
8303         * tui/tui-hooks.c (tui_redisplay_source): Call refill method.
8304         * tui/tui-data.h (struct tui_source_window_base) <refill,
8305         set_is_exec_point_at>: New methods.
8306         (tui_source_windows, tui_add_to_source_windows): Update types.
8307         (tui_add_to_source_windows): Remove redundant declaration.
8308         * tui/tui-data.c (source_windows): Store tui_source_window_base.
8309         (tui_source_windows): Change return type.
8310         (tui_clear_source_windows_detail): Update.
8311         (tui_add_to_source_windows): Change type of parameter.
8312         (tui_free_all_source_wins_content): Update.
8313
8314 2019-06-25  Tom Tromey  <tom@tromey.com>
8315
8316         * tui/tui-wingeneral.c (tui_win_info::refresh)
8317         (tui_source_window_base::refresh): New methods.
8318         (tui_refresh_all): Call the refresh method.
8319         * tui/tui-data.h (struct tui_win_info)
8320         (struct tui_source_window_base) <refresh>: New method.
8321
8322 2019-06-25  Tom Tromey  <tom@tromey.com>
8323
8324         * tui/tui.h (tui_is_window_visible): Return bool.
8325         * tui/tui.c (tui_is_window_visible): Return bool.
8326         * tui/tui-wingeneral.c (tui_make_window, make_visible)
8327         (tui_make_visible, tui_make_invisible)
8328         (tui_win_info::make_visible)
8329         (tui_source_window_base::make_visible, make_all_visible)
8330         (tui_make_all_visible, tui_make_all_invisible): Update.
8331         * tui/tui-windata.c (tui_delete_data_content_windows): Update.
8332         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: Now
8333         bool.
8334         (struct tui_win_info, struct tui_source_window_base)
8335         (struct tui_cmd_window) <make_visible>: Change parameter to bool.
8336         * tui/tui-data.c (tui_init_generic_part): Update.
8337
8338 2019-06-25  Tom Tromey  <tom@tromey.com>
8339
8340         * tui/tui-wingeneral.c (tui_win_info::make_visible)
8341         (tui_source_window_base::make_visible): New methods.
8342         (make_all_visible): Make method call.
8343         * tui/tui-data.h (struct tui_win_info) <make_visible>: New method.
8344         (struct tui_source_window_base, struct tui_cmd_window): Override
8345         make_visible.
8346         (tui_win_is_source_type): Don't declare.
8347         * tui/tui-data.c (tui_win_is_source_type): Remove.
8348
8349 2019-06-25  Tom Tromey  <tom@tromey.com>
8350
8351         * tui/tui-layout.c (show_source_or_disasm_and_command): Remove
8352         NULL check.
8353
8354 2019-06-25  Tom Tromey  <tom@tromey.com>
8355
8356         * tui/tui-data.h (struct tui_data_window, struct tui_cmd_window):
8357         Inline constructor.  Add initializers for members.
8358         * tui/tui-data.c (tui_data_window, tui_cmd_window): Remove
8359         constructors; now inline in class.
8360
8361 2019-06-25  Tom Tromey  <tom@tromey.com>
8362
8363         * tui/tui-regs.c (tui_show_registers): Update.
8364         * tui/tui-data.h (struct tui_data_window) <display_regs>: Now
8365         bool.
8366         * tui/tui-data.c (tui_data_window::clear_detail)
8367         (tui_data_window): Update.
8368
8369 2019-06-25  Tom Tromey  <tom@tromey.com>
8370
8371         * tui/tui-windata.c (tui_display_all_data)
8372         (tui_display_data_from_line, tui_display_data_from)
8373         (tui_check_data_values, tui_data_window::do_scroll_vertical):
8374         Update.
8375         * tui/tui-regs.c (tui_last_regs_line_no)
8376         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
8377         (tui_show_registers, tui_show_register_group)
8378         (tui_display_registers_from, tui_display_reg_element_at_line)
8379         (tui_display_registers_from_line, tui_check_register_values)
8380         (tui_reg_next, tui_reg_prev): Update.
8381         * tui/tui-layout.c (tui_set_layout, show_data): Update.
8382         * tui/tui-data.h (struct tui_data_info): Remove.  Move contents to
8383         tui_data_window.
8384         (struct tui_win_info) <detail>: Remove.  Add new fields from
8385         tui_data_info.
8386         (TUI_DATA_WIN): Add cast.
8387         * tui/tui-data.c (tui_data_window::clear_detail, tui_data_window)
8388         (~tui_data_window): Simplify.
8389
8390 2019-06-25  Tom Tromey  <tom@tromey.com>
8391
8392         * tui/tui-layout.c (show_source_disasm_command)
8393         (show_source_or_disasm_and_command): Update.
8394         * tui/tui-io.c (update_cmdwin_start_line)
8395         (tui_redisplay_readline): Update.
8396         * tui/tui-data.h (struct tui_command_info): Remove.
8397         (struct tui_win_info) <detail>: Remove command_info member.
8398         (struct tui_data_window) <start_line>: New member, from
8399         tui_command_info.
8400         (TUI_CMD_WIN): Add casts.
8401
8402 2019-06-25  Tom Tromey  <tom@tromey.com>
8403
8404         * tui/tui-winsource.c (tui_update_source_window)
8405         (tui_refill_source_window)
8406         (tui_source_window_base::do_scroll_horizontal)
8407         (tui_update_breakpoint_info, tui_set_exec_info_content)
8408         (tui_show_exec_info_content, tui_erase_exec_info_content)
8409         (tui_clear_exec_info_content): Update.
8410         * tui/tui-wingeneral.c (make_all_visible, tui_refresh_all):
8411         Update.
8412         * tui/tui-win.c (make_invisible_and_set_new_height)
8413         (make_visible_with_new_height): Update.
8414         * tui/tui-source.c (tui_set_source_content)
8415         (tui_show_symtab_source): Update.
8416         * tui/tui-layout.c (extract_display_start_addr)
8417         (show_source_disasm_command, show_data)
8418         (make_source_or_disasm_window)
8419         (show_source_or_disasm_and_command): Update.
8420         * tui/tui-disasm.c (tui_set_disassem_content): Simplify.
8421         (tui_disasm_window::do_scroll_vertical): Remove shadowing
8422         "gdbarch".
8423         * tui/tui-data.h (struct tui_source_info): Remove.  Move contents
8424         to tui_source_window_base.
8425         (struct tui_win_info) <detail>: Remove source_info member.
8426         (struct tui_source_window_base) <has_locator>: Inline.
8427         Move contents from tui_source_info; rename has_locator member to
8428         m_has_locator.
8429         (TUI_SRC_WIN, TUI_DISASM_WIN): Add casts.
8430         * tui/tui-data.c (tui_source_window_base::has_locator): Move to
8431         header file.
8432         (tui_source_window_base::clear_detail, ~tui_source_window_base):
8433         Simplify.
8434         (tui_free_all_source_wins_content): Cast to
8435         tui_source_window_base.
8436
8437 2019-06-25  Tom Tromey  <tom@tromey.com>
8438
8439         * tui/tui-win.c (make_invisible_and_set_new_height)
8440         (make_visible_with_new_height): Call has_locator method.
8441         * tui/tui-layout.c (show_source_disasm_command, show_data)
8442         (show_source_or_disasm_and_command): Update for bool change.
8443         * tui/tui-data.h (struct tui_source_info) <has_locator>: Now bool.
8444         (tui_win_info) <has_locator>: New method.
8445         (struct tui_source_window_base) <has_locator>: New method.
8446         (tui_win_has_locator): Don't declare.
8447         * tui/tui-data.c (tui_source_window_base::has_locator): Rename
8448         from tui_win_has_locator.
8449         (tui_source_window_base): Use false, not FALSE.
8450
8451 2019-06-25  Tom Tromey  <tom@tromey.com>
8452
8453         * tui/tui-data.h (tui_clear_win_detail): Don't declare.
8454         * tui/tui-data.c (tui_clear_source_windows_detail): Call the
8455         clear_detail method directly.
8456         (tui_clear_win_detail): Remove.
8457
8458 2019-06-25  Tom Tromey  <tom@tromey.com>
8459
8460         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Use
8461         "this", not TUI_DISASM_WIN.
8462
8463 2019-06-25  Tom Tromey  <tom@tromey.com>
8464
8465         * tui/tui-winsource.h (tui_horizontal_source_scroll):  Don't
8466         declare.
8467         * tui/tui-winsource.c
8468         (tui_source_window_base::do_scroll_horizontal): Rename from
8469         tui_horizontal_source_scroll.
8470         * tui/tui-windata.h (tui_vertical_data_scroll): Don't declare.
8471         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Rename
8472         from tui_vertical_data_scroll.
8473         * tui/tui-win.h (tui_scroll): Don't declare.
8474         * tui/tui-win.c (tui_win_info::forward_scroll)
8475         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
8476         (tui_win_info::right_scroll): Rename and update.
8477         (tui_scroll_forward_command, tui_scroll_backward_command)
8478         (tui_scroll_left_command, tui_scroll_right_command): Update.
8479         (tui_scroll): Remove.
8480         * tui/tui-source.h: Don't declare tui_vertical_source_scroll.
8481         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Rename
8482         from tui_vertical_source_scroll.
8483         * tui/tui-disasm.h (tui_vertical_disassem_scroll): Don't declare.
8484         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Rename
8485         from tui_vertical_disassem_scroll.
8486         * tui/tui-data.h (struct tui_win_info) <do_scroll_vertical,
8487         do_scroll_horizontal>: New methods.
8488         <forward_scroll, backward_scroll, left_scroll, right_scroll>:
8489         Likewise.
8490         (struct tui_source_window_base): Add do_scroll_horizontal.
8491         (struct tui_source_window, struct tui_disasm_window): Add
8492         do_scroll_vertical.
8493         (struct tui_data_window, struct tui_cmd_window): Add
8494         do_scroll_horizontal and do_scroll_vertical.
8495         * tui/tui-command.c (tui_dispatch_ctrl_char): Use method calls.
8496
8497 2019-06-25  Tom Tromey  <tom@tromey.com>
8498
8499         * tui/tui-data.h (struct tui_source_window_base): New struct.
8500         (struct tui_source_window): Derive from tui_source_window_base.
8501         (struct tui_disasm_window): New struct.
8502         * tui/tui-data.c (tui_source_window_base::clear_detail): Rename
8503         from tui_source_window::clear_detail.
8504         (tui_source_window_base): Rename from tui_source_window.
8505         (~tui_source_window_base): Rename from ~tui_source_window.
8506         (tui_alloc_win_info): Create a tui_disasm_window.
8507
8508 2019-06-25  Tom Tromey  <tom@tromey.com>
8509
8510         * tui/tui-data.h (struct tui_source_window)
8511         (struct tui_data_window): Declare destructors.
8512         * tui/tui-data.c (~tui_source_window, ~tui_data_window): New
8513         destructors.
8514         (tui_win_info): Simplify.
8515
8516 2019-06-25  Tom Tromey  <tom@tromey.com>
8517
8518         * tui/tui-winsource.c (tui_display_main)
8519         (tui_update_source_windows_with_addr)
8520         (tui_update_all_breakpoint_info): Update.
8521         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
8522         (new_height_ok, parse_scrolling_args): Update.
8523         * tui/tui-stack.c (tui_show_frame_info): Update.
8524         * tui/tui-data.h (struct tui_list): Remove.
8525         (tui_source_windows): Return a reference to a std::vector.
8526         * tui/tui-data.c (source_windows): Now a std::vector.
8527         (tui_source_windows): Change return type.
8528         (tui_clear_source_windows): Rewrite.
8529         (tui_clear_source_windows_detail, tui_add_to_source_windows)
8530         (tui_free_all_source_wins_content): Rewrite.
8531
8532 2019-06-25  Tom Tromey  <tom@tromey.com>
8533
8534         * tui/tui-data.h (struct tui_win_info, struct tui_source_window)
8535         (struct tui_data_window, struct tui_cmd_window): Declare
8536         clear_detail method.
8537         * tui/tui-data.c (tui_source_window::clear_detail)
8538         (tui_cmd_window::clear_detail, tui_data_window::clear_detail): New
8539         methods.
8540         (tui_clear_win_detail): Simplify.
8541
8542 2019-06-25  Tom Tromey  <tom@tromey.com>
8543
8544         * tui/tui-layout.c (make_source_window, make_disasm_window)
8545         (make_source_or_disasm_window): Remove win_info_ptr parameter.
8546         Return the new window.
8547         (show_source_disasm_command, show_data)
8548         (show_source_or_disasm_and_command): Update.
8549
8550 2019-06-25  Tom Tromey  <tom@tromey.com>
8551
8552         * tui/tui-layout.c (make_command_window): Remove win_info_ptr
8553         parameter.  Return the new window.
8554         (show_source_disasm_command): Update and remove NULL check.
8555         (show_source_or_disasm_and_command): Update.
8556
8557 2019-06-25  Tom Tromey  <tom@tromey.com>
8558
8559         * tui/tui-layout.c (init_and_make_win): Remove NULL check.
8560
8561 2019-06-25  Tom Tromey  <tom@tromey.com>
8562
8563         * tui/tui-data.h (struct tui_win_info): Make constructor
8564         protected.  Make destructor virtual.  Add initializers.
8565         (tui_source_window, tui_data_window, tui_cmd_window): New
8566         classes.
8567         * tui/tui-data.c (tui_win_info): Rename from init_win_info.  Now a
8568         constructor.  Add "type" parameter.
8569         (tui_source_window, tui_data_window, tui_cmd_window): New
8570         constructors.
8571         (tui_alloc_win_info): Instantiate the appropriate subclass.
8572
8573 2019-06-25  Tom Tromey  <tom@tromey.com>
8574
8575         * tui/tui-win.c (tui_resize_all): Use delete.
8576         * tui/tui-data.h (struct tui_win_info) <~tui_win_info>: Declare
8577         destructor.
8578         (tui_free_window): Don't declare.
8579         * tui/tui-data.c (~tui_win_info): Rename from tui_free_window.
8580         Update.
8581
8582 2019-06-25  Tom Tromey  <tom@tromey.com>
8583
8584         * tui/tui-data.h (struct tui_win_info): Add constructor.
8585         * tui/tui-data.c (tui_alloc_win_info): Use new.
8586         (tui_free_window): Use delete.
8587
8588 2019-06-22  Tom Tromey  <tom@tromey.com>
8589
8590         * tui/tui-windata.h (tui_first_data_element_no_in_line): Don't
8591         declare.
8592         * tui/tui-windata.c (tui_first_data_element_no_in_line): Remove.
8593
8594 2019-06-22  Tom Tromey  <tom@tromey.com>
8595
8596         * tui/tui-data.h (tui_del_window, tui_del_data_windows): Don't
8597         declare.
8598         * tui/tui-data.c (tui_del_window, tui_del_data_windows): Remove.
8599
8600 2019-06-22  Tom de Vries  <tdevries@suse.de>
8601
8602         * dwarf2read.c (create_addrmap_from_aranges)
8603         (read_debug_names_from_section): Print ptrdiff_t using '%s' and plongest
8604         instead of '%zu'.
8605
8606 2019-06-21  Simon Marchi  <simon.marchi@efficios.com>
8607
8608         * dwarf2read.h (dwarf2_section_info_def): Remove.
8609         (DEF_VEC_O (dwarf2_section_info_def)): Remove.
8610         * dwarf2read.c (struct dwo_sections) <types>: Change type to
8611         std::vector<dwarf2_section_info>.
8612         (struct dwo_file) <~dwo_file>: Remove.
8613         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't manually free
8614         types field.
8615         (dwarf2_per_objfile::locate_sections): Adjust to std::vector.
8616         (dwarf2_read_debug_names): Likewise.
8617         (create_debug_types_hash_table): Change parameter type to
8618         array_view, adjust code accordingly.
8619         (dwarf2_locate_dwo_sections): Adjust to std::vector.
8620         (partial_die_info::fixup): Likewise.
8621         (determine_prefix): Likewise.
8622         * dwarf-index-write.c (write_psymtabs_to_index): Adjust.
8623
8624 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
8625
8626         * dwarf2read.c (struct dwo_file) <dbfd>: Change type to
8627         gdb_bfd_ref_ptr.
8628         <~dwo_file>: Remove call to gdb_bfd_unref.
8629         (open_and_init_dwo_file): Move gdb_bfd_ref_ptr into dbfd field. Call
8630         gdb_bfd_ref_ptr::get.
8631
8632 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
8633
8634         * dwarf2read.h (struct dwarf2_per_objfile) <dwo_files>: Change
8635         type to htab_up.
8636         * dwarf2read.c (struct dwo_file): Initialize fields.
8637         <~dwo_file>: New.
8638         (free_dwo_file): Remove, move content to ~dwo_file.
8639         (struct dwo_file_deleter): Remove.
8640         (dwo_file_up>: Remove custom deleter.
8641         (free_dwo_files): Remove.
8642         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't explicitly free
8643         dwo_files.
8644         (process_skeletonless_type_units): Call unique_ptr::get.
8645         (allocate_dwo_file_hash_table): Add deleter to created hash
8646         table.  Change return type to htab_up.
8647         (lookup_dwo_file_slot): Don't memset dwo_file, call
8648         unique_ptr::get.
8649         (create_dwo_unit_in_dwp_v1): Allocate dwo_file with new.
8650         (create_dwo_unit_in_dwp_v2): Likewise.
8651         (open_and_init_dwo_file): Likewise.
8652         (free_dwo_file_from_slot): Remove.
8653
8654 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
8655
8656         * dwarf2read.h (struct dwarf2_section_info) <readin,
8657         is_virtual>: Change type to bool.
8658         * dwarf2read.c (dwarf2_read_section, create_dwp_v2_section): Use
8659         true instead of 1.
8660
8661 2019-06-19  Tom Tromey  <tom@tromey.com>
8662
8663         * tui/tui-data.h (tui_init_content_element): Don't declare.
8664
8665 2019-06-19  Tom Tromey  <tom@tromey.com>
8666
8667         * tui/tui-data.h (tui_init_win_info): Don't declare.
8668
8669 2019-06-19  Tom de Vries  <tdevries@suse.de>
8670
8671         * dwarf2read.h (abstract_to_concrete): Change type to
8672         std::unordered_map<sect_offset, std::vector<sect_offset>,
8673         gdb::hash_enum<sect_offset>>.
8674
8675 2019-06-19  Tom Tromey  <tromey@adacore.com>
8676
8677         * ada-lang.c (ada_evaluate_subexp) <case OP_ATR_FIRST>: Handle
8678         EVAL_AVOID_SIDE_EFFECTS specially.
8679
8680 2019-06-19  Tom Tromey  <tromey@adacore.com>
8681
8682         * source-cache.c (highlighter): New global.
8683         (source_cache::get_source_lines): Create a highlighter on demand.
8684
8685 2019-06-18  Andrew Burgess  <andrew.burgess@embecosm.com>
8686
8687         * defs.h (deprecated_interactive_hook): Delete declaration.
8688         * interps.c (clear_interpreter_hooks): Remove use of
8689         deprecated_interactive_hook.
8690         * top.c (deprecated_interactive_hook): Delete definition.
8691         * utils.c (maybe_quit): Remove use of deprecated_interactive_hook.
8692
8693 2019-06-18  Tom de Vries  <tdevries@suse.de>
8694
8695         PR gdb/24515
8696         * dwarf2read.h (abstract_to_concrete): Change type from
8697         std::unordered_map<die_info_ptr, std::vector<die_info_ptr>> to
8698         std::unordered_map<sect_offset, std::vector<sect_offset>>.
8699         * dwarf2read.c (read_variable): Update.
8700         (dwarf2_fetch_die_loc_sect_off): Update.
8701
8702 2019-06-17  Tom de Vries  <tdevries@suse.de>
8703
8704         PR gdb/24617
8705         * common/pathstuff.c (child_path): Make sure parent_len > 0 before
8706         accessing parent[parent_len - 1].
8707
8708 2019-06-17  Paul Pluzhnikov  <ppluzhnikov@google.com>
8709
8710         PR gdb/24364
8711         * gdb/dtrace-probe.c (dtrace_static_probe_ops::get_probe): Don't
8712         call dtrace_process_dof with NULL dof.
8713
8714 2019-06-16  Tom de Vries  <tdevries@suse.de>
8715
8716         PR gdb/24445
8717         * contrib/gdb-add-index.sh: Update to handle dwz-m-ed executable.
8718
8719 2019-06-16  Tom Tromey  <tom@tromey.com>
8720
8721         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
8722         (make_all_visible): Use address of member.
8723
8724 2019-06-16  Tom Tromey  <tom@tromey.com>
8725
8726         * tui/tui-data.c (tui_clear_win_detail, init_win_info)
8727         (tui_free_window, free_content, free_content_elements): Remove
8728         unnecessary cast.
8729         * tui/tui-windata.c (tui_display_all_data): Remove unnecessary
8730         cast.
8731         * tui/tui-regs.c (tui_show_register_group)
8732         (tui_display_registers_from, tui_display_reg_element_at_line):
8733         Remove unnecessary cast.
8734
8735 2019-06-16  Andrew Burgess  <andrew.burgess@embecosm.com>
8736
8737         * linux-nat.c (normal_mask): Delete.
8738         (_initialize_linux_nat): Don't initialise normal_mask.
8739
8740 2019-06-16  Simon Marchi  <simon.marchi@polymtl.ca>
8741
8742         PR gdb/24445
8743         * dwarf-index-write.h (write_psymtabs_to_index): Add
8744         dwz_basename parameter.
8745         * dwarf-index-write.c (write_gdbindex): Move file writing to
8746         write_gdbindex_1.  Change return type void.
8747         (assert_file_size): Move up, remove filename parameter.
8748         (write_gdbindex_1): New function.
8749         (write_debug_names): Change return type to void, call
8750         assert_file_size.
8751         (struct index_wip_file): New struct.
8752         (write_psymtabs_to_index): Add dwz_basename parameter.  Move
8753         file logic to index_wip_file.  Write index for dwz file if
8754         needed.
8755         (save_gdb_index_command): Pass basename of dwz file, if present.
8756         * dwarf-index-cache.c (index_cache::store): Obtain and pass
8757         build-id of dwz file, if present.
8758         * dwarf2read.c (struct dwz_file): Move to dwarf2read.h.
8759         (dwarf2_get_dwz_file): Likewise.
8760         * dwarf2read.h (struct dwz_file): Move from dwarf2read.c.
8761         (dwarf2_get_dwz_file): Likewise.
8762
8763 2019-06-16  Tom Tromey  <tom@tromey.com>
8764
8765         * coffread.c (process_coff_symbol): Use xstrdup.
8766         * value.c (create_internalvar): Use xstrdup.
8767
8768 2019-06-16  Tom Tromey  <tom@tromey.com>
8769
8770         * valops.c (value_cast, value_slice): Remove unnecessary cast.
8771         * breakpoint.c (stopin_command, stopat_command)
8772         (until_break_command, decode_location_default): Remove unnecessary
8773         cast.
8774         * utils.c (subset_compare): Remove unnecessary cast.
8775         * ada-lang.c (ada_update_initial_language): Remove unnecessary
8776         cast.
8777         * linespec.c (decode_line_with_last_displayed): Remove unnecessary
8778         cast.
8779         * infcmd.c (path_command): Remove unnecessary cast.
8780         * coffread.c (decode_type): Remove unnecessary cast.
8781         * xcoffread.c (read_xcoff_symtab): Remove unnecessary cast.
8782         * mipsread.c (mipscoff_symfile_read): Remove unnecessary cast.
8783         * tui/tui-stack.c (tui_show_locator_content)
8784         (tui_show_frame_info): Remove unnecessary cast.
8785         * tui/tui-win.c (tui_scroll_forward_command)
8786         (tui_scroll_backward_command, tui_set_focus, tui_set_win_height)
8787         (parse_scrolling_args): Remove unnecessary cast.
8788         * tui/tui-data.c (init_win_info, tui_del_window)
8789         (tui_free_window, tui_del_data_windows, tui_free_data_content)
8790         (free_content_elements): Remove unnecessary cast.
8791         * tui/tui-windata.c (tui_first_data_item_displayed): Remove
8792         unnecessary cast.
8793         * tui/tui-source.c (tui_set_source_content)
8794         (tui_vertical_source_scroll): Remove unnecessary cast.
8795         * tui/tui-layout.c (tui_default_win_height): Remove unnecessary
8796         cast.
8797         * tui/tui-io.c (tui_initialize_io): Remove unnecessary cast.
8798         * tui/tui-regs.c (tui_display_registers_from)
8799         (tui_display_register): Remove unnecessary cast.
8800         * tui/tui-wingeneral.c (tui_refresh_win, tui_delete_win)
8801         (tui_unhighlight_win, tui_highlight_win, tui_make_window)
8802         (make_visible): Remove unnecessary cast.
8803         * tui/tui-winsource.c (tui_erase_source_content)
8804         (tui_update_breakpoint_info, tui_set_exec_info_content): Remove
8805         unnecessary cast.
8806         * ax-gdb.c (agent_command_1): Remove unnecessary cast.
8807         * cli/cli-setshow.c (cmd_show_list): Remove unnecessary cast.
8808         * stabsread.c (read_type, read_array_type, read_range_type):
8809         Remove unnecessary cast.
8810         * mdebugread.c (mdebug_build_psymtabs): Remove unnecessary cast.
8811         (parse_symbol, parse_type, upgrade_type, parse_external)
8812         (parse_partial_symbols, psymtab_to_symtab_1, cross_ref): Remove
8813         unnecessary cast.
8814         * gdb_bfd.c (gdb_bfd_map_section): Remove unnecessary cast.
8815
8816 2019-06-16  Tom Tromey  <tom@tromey.com>
8817
8818         * tui/tui-data.c (tui_alloc_generic_win_info)
8819         (tui_alloc_win_info, tui_add_content_elements): Remove NULL
8820         checks.
8821
8822 2019-06-16  Bernhard Heckel  <bernhard.heckel@intel.com>
8823             Andrew Burgess  <andrew.burgess@embecosm.com>
8824
8825         * f-typeprint.c (f_print_type): Don't return early for not
8826         associated or not allocated types.
8827         (f_type_print_varspec_suffix): Add print_rank parameter and print
8828         ranks of array types in case they dangling.
8829         (f_type_print_base): Add print_rank parameter.
8830
8831 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
8832
8833         * NEWS: Mention new MI commands.
8834         * break-catch-throw.c (enum exception_event_kind): Move to
8835         breakpoint.h.
8836         (print_mention_exception_catchpoint): Output text as a single
8837         message.
8838         (catch_exception_command_1): Rename to...
8839         (catch_exception_event): ...this, make non-static, update header
8840         command, and change some parameter types.
8841         (catch_catch_command): Update for changes to
8842         catch_exception_command_1.
8843         (catch_throw_command): Likewise.
8844         (catch_rethrow_command): Likewise.
8845         * breakpoint.c (enum exception_event_kind): Delete.
8846         * breakpoint.h (enum exception_event_kind): Moved here from
8847         break-catch-throw.c.
8848         (catch_exception_event): Declare.
8849         * mi/mi-cmd-catch.c (mi_cmd_catch_exception_event): New function.
8850         (mi_cmd_catch_throw): New function.
8851         (mi_cmd_catch_rethrow): New function.
8852         (mi_cmd_catch_catch): New function.
8853         * mi/mi-cmds.c (mi_cmds): Add 'catch-throw', 'catch-rethrow', and
8854         'catch-catch' entries.
8855         * mi/mi-cmds.h (mi_cmd_catch_throw): Declare.
8856         (mi_cmd_catch_rethrow): Declare.
8857         (mi_cmd_catch_catch): Declare.
8858
8859 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
8860
8861         * annotate.c (annotate_source_line): Change return type to void,
8862         update implementation to match.
8863         * annotate.h (annotate_source_line): Change return type to void,
8864         update header comment.
8865         * stack.c (print_frame_info): Don't change what frame information
8866         is printed based on whether annotations are on or not.
8867
8868 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
8869
8870         * annotate.c: Add 'source.h' and 'objfiles.h' includes.
8871         (annotate_source): Make static.
8872         (annotate_source_line): Moved from source.c and renamed from
8873         identify_source_line.  Update the return type.
8874         * annotate.h (annotate_source): Delete declaration.
8875         (annotate_source_line): Declaration moved from source.h, and
8876         renamed from identify_source_line.  Return type updated.
8877         * source.c (identify_source_line): Moved to annotate.c and renamed
8878         to annotate_source_line.
8879         (info_line_command): Remove check of annotation_level.
8880         * source.h (identify_source_line): Move declaration to annotate.h
8881         and rename to annotate_source_line.
8882         * stack.c: Add 'annotate.h' include.
8883         (print_frame_info): Remove check of annotation_level before
8884         calling annotate_source_line.
8885
8886 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
8887
8888         * source-cache.c (source_cache::get_plain_source_lines): Use
8889         open_source_file_with_line_charpos instead of just
8890         open_source_file, remove call to find_source_lines.
8891         (source_cache::get_source_lines): Likewise.
8892         * source.c (find_source_lines): Make static.
8893         (get_filename_and_charpos): Renamed into...
8894         (open_source_file_with_line_charpos): ..this along with changes to
8895         return a scoped_fd, and some other minor clean ups.
8896         (identify_source_line): Use open_source_file_with_line_charpos.
8897         (search_command_helper): Use open_source_file_with_line_charpos
8898         instead of just open_source_file, remove call to
8899         find_source_lines.
8900         * source.h (open_source_file_with_line_charpos): Declare new
8901         function.
8902         (find_source_lines): Delete declaration.
8903
8904 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
8905
8906         * source.c (get_filename_and_charpos): Remove fullname
8907         parameter.
8908         (identify_source_line): Update call to get_filename_and_charpos.
8909
8910 2019-06-14  Tom Tromey  <tromey@adacore.com>
8911
8912         PR gdb/24502:
8913         * ui-style.h (skip_ansi_escape): Update comment.
8914         * ui-file.h (class no_terminal_escape_file): New class.
8915         * ui-file.c (no_terminal_escape_file::write)
8916         (no_terminal_escape_file::puts): New methods.
8917         * cli/cli-logging.c (handle_redirections): Use
8918         no_terminal_escape_file.
8919
8920 2019-06-14  Tom Tromey  <tromey@adacore.com>
8921
8922         * NEWS: Move convenience variable news above Python news.
8923
8924 2019-06-14  Tom Tromey  <tom@tromey.com>
8925
8926         * gnulib: Move directory to top-level.
8927         * configure.ac: Don't configure gnulib.
8928         * configure: Rebuild.
8929         * common/common-defs.h: Use new path to gnulib.
8930         * Makefile.in (GNULIB_BUILDDIR): Now ../gnulib.
8931         (GNULIB_H): Remove.
8932         (INCGNU): Look in new gnulib location.
8933         (HFILES_NO_SRCDIR): Remove gnulib files.
8934         (SUBDIR, REQUIRED_SUBDIRS): Remove gnulib.
8935         (generated_files): Remove GNULIB_H.
8936         ($(LIBGNU), all-lib): Remove targets.
8937         (distclean): Don't mention GNULIB_BUILDDIR.
8938         ($(GNULIB_BUILDDIR)/Makefile): Remove target.
8939
8940 2019-06-14  Tom Tromey  <tromey@adacore.com>
8941
8942         * symfile.c (add_symbol_file_command): Remove obsolete comment.
8943         Warn if symbol file does not provide any symbols.
8944
8945 2019-06-14  Tom Tromey  <tromey@adacore.com>
8946
8947         * source.c (find_and_open_source): Respect basenames_may_differ.
8948
8949 2019-06-14  Andrew Burgess  <andrew.burgess@embecosm.com>
8950
8951         * annotate.c (annotate_breakpoints_invalid): Make use of
8952         scoped_restore_terminal_state.
8953         (annotate_frames_invalid): Likewise.
8954
8955 2019-06-14  Tom Tromey  <tromey@adacore.com>
8956
8957         * ada-lang.c (ada_evaluate_subexp) <case BINOP_ASSIGN>: Always
8958         allow assignment to an internalvar.
8959
8960 2019-06-14  Tom Tromey  <tromey@adacore.com>
8961
8962         * ada-lex.l: Allow "_" in attribute names.
8963
8964 2019-06-14  Tom Tromey  <tromey@adacore.com>
8965
8966         PR gdb/24653:
8967         * regcache.c (registers_changed): Don't call alloca.
8968         * top.c (execute_command): Don't call alloca.
8969
8970 2019-06-13  Pedro Alves  <palves@redhat.com>
8971
8972         * cli/cli-setshow.c (cli/cli-setshow.c): New parameter
8973         'expression'.  When parsing an expression, error out if there's
8974         junk after "unlimited".
8975         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
8976         (do_set_command): Adjust calls to is_unlimited_literal.
8977
8978 2019-06-13  Pedro Alves  <palves@redhat.com>
8979
8980         * compile/compile.c (make_compile_options_def_group): Add braces
8981         around array_view initializer.
8982         * thread.c (make_thread_apply_all_options_def_group)
8983         (make_thread_apply_all_options_def_group): Likewise.
8984
8985 2019-06-13  Pedro Alves  <palves@redhat.com>
8986
8987         * NEWS (New commands): Mention "maint test-options
8988         require-delimiter", "maint test-options unknown-is-error", "maint
8989         test-options unknown-is-operand" and "maint show
8990         test-options-completion-result".
8991         (New command options, command completion): New section.
8992         (Completion improvements): New section.
8993         Mention that you can abbreviate "unlimited".
8994
8995 2019-06-13  Pedro Alves  <palves@redhat.com>
8996
8997         * cli/cli-utils.c (parse_flags, parse_flags_qcs): Delete.
8998         * cli/cli-utils.h (parse_flags, parse_flags_qcs): Delete.
8999         * unittests/cli-utils-selftests.c (test_parse_flags)
9000         (test_parse_flags_qcs): Delete.
9001         (test_cli_utils): Don't call deleted functions.
9002
9003 2019-06-13  Pedro Alves  <palves@redhat.com>
9004
9005         * thread.c: Include "cli/cli-option.h".
9006         (tp_array_compar_ascending): Global.
9007         (tp_array_compar): Delete function.
9008         (tp_array_compar_ascending, tp_array_compar_descending): New
9009         functions.
9010         (ascending_option_def, qcs_flag_option_def)
9011         (thr_qcs_flags_option_defs)
9012         (make_thread_apply_all_options_def_group)
9013         (make_thread_apply_options_def_group): New.
9014         (thread_apply_all_command): Use gdb::option::process_options.
9015         (thread_apply_command_completer)
9016         (thread_apply_all_command_completer): New.
9017         (thread_apply_command): Use gdb::option::process_options.
9018         (_initialize_thread): Delete THREAD_APPLY_FLAGS_HELP, replace it
9019         with a new THREAD_APPLY_OPTION_HELP.  Use gdb::option::build_help
9020         to generate help text of "thread apply".  Adjust "taas"'s help.
9021         * tid-parse.c (tid_range_parser::in_thread_range): New method.
9022         * tid-parse.h (tid_range_parser::in_thread_range): New method.
9023
9024 2019-06-13  Pedro Alves  <palves@redhat.com>
9025
9026         * thread.c (thread_apply_command): Check for invalid TID with
9027         isdigit instead of !isalpha.
9028
9029 2019-06-13  Pedro Alves  <palves@redhat.com>
9030
9031         * cli/cli-utils.c (parse_flags_qcs): Use validate_flags_qcs.
9032         (validate_flags_qcs): New.
9033         * cli/cli-utils.h (struct qcs_flags): Change field types to int.
9034         (validate_flags_qcs): Declare.
9035         * stack.c (qcs_flag_option_def, fr_qcs_flags_option_defs): New.
9036         (make_frame_apply_options_def_group): New.
9037         (frame_apply_command_count): Process options with
9038         gdb::option::process_options.
9039         (frame_apply_completer): New.
9040         (frame_apply_level_completer, frame_apply_all_completer)
9041         (frame_apply_completer): New.
9042         (_initialize_stack): Update help of "frame apply", "frame apply
9043         level", "frame apply all" and "faas" to mention supported options
9044         and install command completers.
9045         * stack.h (frame_apply_all_completer): Declare.
9046         * thread.c: Include "stack.h".
9047         (tfaas_command): Add "--".
9048         (_initialize_thread): Update help "tfaas" to mention supported
9049         options and install command completer.
9050
9051 2019-06-13  Pedro Alves  <palves@redhat.com>
9052
9053         * completer.c (complete_nested_command_line): New.
9054         (gdb_completion_word_break_characters_throw): Add assertion.
9055         * completer.h (complete_nested_command_line): Declare.
9056
9057 2019-06-13  Pedro Alves  <palves@redhat.com>
9058
9059         * stack.c (parse_backtrace_qualifiers): New.
9060         (backtrace_command): Use it.
9061         (backtrace_command_completer): Complete on qualifiers.
9062
9063 2019-06-13  Pedro Alves  <palves@redhat.com>
9064
9065         * frame.c: Include "cli/cli-option.h.
9066         (user_set_backtrace_options): New.
9067         (backtrace_past_main, backtrace_past_entry, backtrace_limit):
9068         Delete.
9069         (get_prev_frame): Adjust.
9070         (boolean_option_def, uinteger_option_def)
9071         (set_backtrace_option_defs): New.
9072         (_initialize_frame): Adjust and use
9073         gdb::option::add_setshow_cmds_for_options to install "set
9074         backtrace past-main" and "set backtrace past-entry".
9075         * frame.h: Include "cli/cli-option.h".
9076         (struct frame_print_options): Forward declare.
9077         (print_frame_arguments_all, print_frame_arguments_scalars)
9078         (print_frame_arguments_none): Declare.
9079         (print_entry_values): Delete declaration.
9080         (struct frame_print_options, user_frame_print_options): New.
9081         (struct set_backtrace_options): New.
9082         (set_backtrace_option_defs, user_set_backtrace_options): Declare.
9083         * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
9084         (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
9085         (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
9086         (list_args_or_locals): Add frame_print_options parameter.
9087         (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
9088         * python/py-framefilter.c (enumerate_args): Pass down
9089         USER_FRAME_PRINT_OPTIONS.
9090         * stack.c: Include "cli/cli-option.h".
9091         (print_frame_arguments_all, print_frame_arguments_scalars)
9092         (print_frame_arguments_none): Declare.
9093         (print_raw_frame_arguments, print_entry_values): Delete.
9094         (user_frame_print_options): New.
9095         (boolean_option_def, enum_option_def, frame_print_option_defs):
9096         New.
9097         (struct backtrace_cmd_options): New.
9098         (bt_flag_option_def): New.
9099         (backtrace_command_option_defs): New.
9100         (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
9101         (print_frame_arg, read_frame_arg, print_frame_args)
9102         (print_frame_info, print_frame): Add frame_print_options parameter
9103         and use it.
9104         (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
9105         (backtrace_command_1): Add frame_print_options and
9106         backtrace_cmd_options parameters and use them.
9107         (make_backtrace_options_def_group): New.
9108         (backtrace_command): Process command options with
9109         gdb::option::process_options.
9110         (backtrace_command_completer): New.
9111         (_initialize_stack): Extend "backtrace"'s help to mention
9112         supported options.  Install completer for "backtrace".
9113         Install some settings commands with add_setshow_cmds_for_options.
9114
9115 2019-06-13  Pedro Alves  <palves@redhat.com>
9116
9117         * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
9118         and that "set/show print raw frame-arguments" are now deprecated.
9119
9120         * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
9121         command.
9122         * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
9123         * stack.c (_initialize_stack): Install "set/show print
9124         raw-frame-arguments", and deprecate "set/show print raw
9125         frame-arguments".
9126         * valprint.c (_initialize_valprint): Deprecate "set/show print
9127         raw".
9128
9129 2019-06-13  Pedro Alves  <palves@redhat.com>
9130
9131         * compile/compile.c (struct compile_options): New.
9132         (compile_flag_option_def, compile_command_option_defs)
9133         (make_compile_options_def_group): New.
9134         (compile_file_command): Handle options with
9135         gdb::option::process_options.
9136         (compile_file_command_completer): New function.
9137         (compile_code_command): Handle options with
9138         gdb::option::process_options.
9139         (compile_code_command_completer): New function.
9140         (_initialize_compiler): Install completers for "compile code" and
9141         "compile file".  Mention available options in "compile code" and
9142         "compile code"'s help.
9143         * completer.c (advance_to_completion_word): New, factored out from
9144         ...
9145         (advance_to_expression_complete_word_point): ... this.
9146         (advance_to_filename_complete_word_point): New.
9147         * completer.h (advance_to_filename_complete_word_point): New
9148         declaration.
9149
9150 2019-06-13  Pedro Alves  <palves@redhat.com>
9151
9152         * compile/compile.c: Include "cli/cli-option.h".
9153         (compile_print_value): Scope data pointer is now a
9154         value_print_options pointer; adjust.
9155         (compile_print_command): Process options.  Scope data pointer is
9156         now a value_print_options pointer; adjust.
9157         (_initialize_compile): Update "compile print"'s help to include
9158         supported options.  Install a completer for "compile print".
9159         * cp-valprint.c (show_vtblprint, show_objectprint)
9160         (show_static_field_print): Delete.
9161         (_initialize_cp_valprint): Don't install "set print
9162         static-members", "set print vtbl", "set print object" here.
9163         * printcmd.c: Include "cli/cli-option.h" and
9164         "common/gdb_optional.h".
9165         (print_command_parse_format): Rework to fill in a
9166         value_print_options instead of a format_data.
9167         (print_value): Change parameter type from format_data pointer to
9168         value_print_options reference.  Adjust.
9169         (print_command_1): Process options.  Adjust to pass down a
9170         value_print_options.
9171         (print_command_completer): New.
9172         (_initialize_printcmd): Install print_command_completer as
9173         handle_brkchars completer for the "print" command.  Update
9174         "print"'s help to include supported options.
9175         * valprint.c: Include "cli/cli-option.h".
9176         (show_vtblprint, show_objectprint, show_static_field_print): Moved
9177         here from cp-valprint.c.
9178         (boolean_option_def, uinteger_option_def)
9179         (value_print_option_defs, make_value_print_options_def_group):
9180         New.  Use gdb::option::add_setshow_cmds_for_options to install
9181         "set print elements", "set print null-stop", "set print repeats",
9182         "set print pretty", "set print union", "set print array", "set
9183         print address", "set print symbol", "set print array-indexes".
9184         * valprint.h: Include <string> and "cli/cli-option.h".
9185         (make_value_print_options_def_group): Declare.
9186         (print_value): Change parameter type from format_data pointer to
9187         value_print_options reference.
9188         (print_command_completer): Declare.
9189
9190 2019-06-13  Pedro Alves  <palves@redhat.com>
9191
9192         * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
9193         (COMMON_SFILES): Add maint-test-settings.c.
9194         * cli/cli-decode.c (boolean_enums): New global, factored out from
9195         ...
9196         (add_setshow_boolean_cmd): ... here.
9197         * cli/cli-decode.h (boolean_enums): Declare.
9198         * cli/cli-option.c: New file.
9199         * cli/cli-option.h: New file.
9200         * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
9201         factored out from ...
9202         (parse_cli_boolean_value(const char *)): ... this.
9203         (is_unlimited_literal): Change parameter type to pointer to
9204         pointer.  Adjust and advance ARG pointer.
9205         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
9206         (parse_cli_var_enum): New, factored out from ...
9207         (do_set_command): ... this.  Adjust.
9208         * cli/cli-setshow.h (parse_cli_boolean_value)
9209         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
9210         (parse_cli_var_enum): Declare.
9211         * cli/cli-utils.c: Include "cli/cli-option.h".
9212         (get_ulongest): New.
9213         * cli/cli-utils.h (get_ulongest): Declare.
9214         (check_for_argument): New overloads.
9215         * maint-test-options.c: New file.
9216
9217 2019-06-13  Pedro Alves  <palves@redhat.com>
9218
9219         * cli/cli-utils.c (number_or_range_parser::get_number): Do not
9220         parse a range if "-" is at the end of the string.
9221
9222 2019-06-13  Pedro Alves  <palves@redhat.com>
9223
9224         * cli/cli-setshow.c (parse_auto_binary_operation)
9225         (parse_cli_boolean_value): Don't allow "o".
9226
9227 2019-06-13  Pedro Alves  <palves@redhat.com>
9228
9229         * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
9230         * NEWS: Mention maint test-settings KIND.
9231         * maint-test-settings.c: New file.
9232
9233 2019-06-13  Pedro Alves  <palves@redhat.com>
9234
9235         * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
9236         completer.
9237         (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
9238         "set" completers.
9239
9240 2019-06-13  Pedro Alves  <palves@redhat.com>
9241
9242         * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
9243         after item.
9244
9245 2019-06-13  Pedro Alves  <palves@redhat.com>
9246
9247         * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
9248
9249 2019-06-13  Pedro Alves <palves@redhat.com>
9250
9251         * ax-gdb.c (agent_command_1): Remove skip_spaces call.
9252         * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
9253         call.
9254         * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
9255         * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
9256         calls.
9257         (check_for_argument): Skip spaces after argument.
9258
9259 2019-06-13  Pedro Alves  <palves@redhat.com>
9260
9261         * thread.c (thread_apply_command): Adjust TID parsing.
9262         * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
9263         detected before end of string.
9264         (tid_is_in_list): Error out if LIST is invalid.
9265
9266 2019-06-13  Pedro Alves  <palves@redhat.com>
9267
9268         * completer.c (complete_line_internal_1): Rewind completion word
9269         point.
9270         (completion_tracker::advance_custom_word_point_by): Change
9271         parameter type to int.
9272         * completer.h (completion_tracker::advance_custom_word_point_by):
9273         Likewise.
9274
9275 2019-06-13  Pedro Alves  <palves@redhat.com>
9276
9277         * completer.c (advance_to_completion_word): Handle delimiters.
9278
9279 2019-06-11  Bernhard Heckel  <bernhard.heckel@intel.com>
9280
9281         * dwarf2read.c (add_partial_symbol): Skip nameless modules.
9282
9283 2019-06-11  Tom Tromey  <tom@tromey.com>
9284
9285         * common/common-utils.c (xmalloc, xrealloc, xcalloc)
9286         (xmalloc_failed): Move to alloc.c.
9287         * alloc.c: New file.
9288         * Makefile.in (COMMON_SFILES): Add alloc.c.
9289
9290 2019-06-11  Tom Tromey  <tom@tromey.com>
9291
9292         * nat/linux-waitpid.c: Don't include server.h.
9293         (linux_debug): Remove.
9294         (my_waitpid): Update.
9295
9296 2019-06-11  Tom Tromey  <tromey@adacore.com>
9297
9298         * infcall.c (_initialize_infcall): Remove trailing newline from
9299         help.
9300         * user-regs.c (_initialize_user_regs): Remove trailing newline
9301         from help.
9302         * typeprint.c (_initialize_typeprint): Remove trailing newline
9303         from help.
9304         * reverse.c (_initialize_reverse): Remove trailing newlines from
9305         help.
9306         * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
9307         from help.
9308         * language.c (add_set_language_command): Remove trailing newline
9309         from help.
9310         * infcmd.c (_initialize_infcmd): Remove trailing newlines from
9311         help.
9312         * disasm.c (_initialize_disasm): Remove trailing newline from
9313         help.
9314         * top.c (init_main): Remove trailing newline from help.
9315         * interps.c (_initialize_interpreter): Remove trailing newline
9316         from help.
9317         * btrace.c (_initialize_btrace): Remove trailing newlines from
9318         help.
9319         * breakpoint.c (_initialize_breakpoint): Remove trailing newline
9320         from help.
9321         * python/python.c (_initialize_python): Remove trailing newline
9322         from help.
9323         * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
9324         help.
9325         * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
9326         from help.  Reformat some text.
9327         * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
9328         from help.
9329         * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
9330         newline from help.
9331
9332 2019-06-11  Tom Tromey  <tromey@adacore.com>
9333
9334         * darwin-nat.c (darwin_decode_exception_message)
9335         (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
9336
9337 2019-06-10  Andrew Burgess  <andrew.burgess@embecosm.com>
9338
9339         * valops.c (value_slice): Check for not allocated or not
9340         associated values.
9341
9342 2019-06-10  Tom de Vries  <tdevries@suse.de>
9343
9344         PR gdb/24618
9345         * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
9346         sure an empty slot (defined by a 32-bit zero pair) is recognized as
9347         invalid.
9348
9349 2019-06-10  Tom de Vries  <tdevries@suse.de>
9350
9351         PR gdb/24611
9352         * linespec.c (linespec_lexer_lex_string): Remove incorrect
9353         "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon.  Add assert.
9354
9355 2019-06-10  Tom de Vries  <tdevries@suse.de>
9356
9357         PR symtab/24545
9358         * symtab.c (struct demangled_name_entry): Add language field.
9359         (symbol_set_names):  Revert "[gdb/symtab] Fix language of duplicate
9360         static minimal symbol".  Set and use language field.
9361
9362 2019-06-10  Tom Tromey  <tromey@adacore.com>
9363
9364         * ada-lang.c (_initialize_ada_language): Update help text.
9365
9366 2019-06-10  Tom Tromey  <tromey@adacore.com>
9367
9368         * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
9369         with a newline.
9370         * guile/guile.c (handle_boot_error): Don't end warning with a
9371         newline.
9372         * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
9373         warning with a newline.
9374         * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
9375         newline.
9376         (s12z_frame_cache): Likewise.
9377         * dwarf-index-cache.c (index_cache::store): Don't end warning with
9378         a newline.
9379         * solib-svr4.c (disable_probes_interface): Don't end warning with
9380         a newline.
9381         * nat/fork-inferior.c (fork_inferior): Don't end warning with a
9382         newline.
9383         * python/python.c (do_finish_initialization): Don't end warning
9384         with a newline.
9385
9386 2019-06-10  Tom Tromey  <tom@tromey.com>
9387
9388         * python/py-breakpoint.c (gdbpy_breakpoint_created)
9389         (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
9390         gdbpy_enter.
9391
9392 2019-06-10  Tom Tromey  <tromey@adacore.com>
9393
9394         * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
9395         data.
9396         (elf_new_init): Don't call stabsread_new_init.
9397         * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
9398         (elfstab_build_psymtabs): Likewise.  Call stabsread_new_init.
9399         * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
9400
9401 2019-06-10  Tom de Vries  <tdevries@suse.de>
9402
9403         PR symtab/16264
9404         PR symtab/24517
9405         * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
9406
9407 2019-06-06  Руслан Ижбулатов <lrn1986@gmail.com>
9408
9409         * source.c (find_and_open_source): Also rewrite relative file
9410         names.
9411
9412 2019-04-26  Amos Bird  <amosbird@gmail.com>
9413
9414         * annotate.c (annotate_thread_exited): Add "thread-exited"
9415         annotation.
9416
9417 2019-06-06  Tom Tromey  <tromey@adacore.com>
9418
9419         * maint.h (class scoped_command_stats): Use
9420         DISABLE_COPY_AND_ASSIGN.
9421         <print_time>: New method.
9422         * maint.c (scoped_command_stats, ~scoped_command_stats): Call
9423         print_time.
9424         (scoped_command_stats::print_time): New method.
9425
9426 2019-06-05  Andrew Burgess  <andrew.burgess@embecosm.com>
9427
9428         * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
9429         instructions of lengths 6 or 8 bytes.
9430
9431 2019-06-04  Pedro Alves  <palves@redhat.com>
9432
9433         * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
9434
9435         * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
9436         * breakpoint.c (condition_completer): Likewise.
9437         * cli/cli-dump.c (scan_expression): Likewise.
9438         * common/filestuff.c (mkdir_recursive): Likewise.
9439         * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
9440         * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
9441         (gdb_abspath): Likewise.
9442         * compile/compile-cplus-types.c
9443         (compile_cplus_instance::decl_name): Likewise.
9444         * completer.c (complete_explicit_location):
9445         (signal_completer, reg_or_group_completer_1): Likewise.
9446         * cp-support.c (cp_remove_params_if_any): Likewise.
9447         * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
9448         * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
9449         * infcmd.c (strip_bg_char): Likewise.
9450         * linespec.c (copy_token_string): Likewise.
9451         * mi/mi-main.c (output_cores): Likewise.
9452         * psymtab.c (psymtab_search_name):
9453         * symfile.c (test_set_ext_lang_command): Likewise.
9454         * target.c (target_fileio_read_stralloc): Likewise.
9455         * tui/tui-regs.c (tui_reggroup_completer): Likewise.
9456         * value.c (complete_internalvar): Likewise.
9457
9458 2019-06-04  Christian Biesinger  <cbiesinger@google.com>
9459
9460         Add objfile property to gdb.Type.
9461         * NEWS: Mention Python API addition.
9462         * python/py-type.c (typy_get_objfile): New method.
9463
9464 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9465
9466         * NEWS: Mention the new set|show style [title|highlight].
9467         Mention changes to "show style", "help" and "apropos".
9468
9469 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9470
9471         * cli/cli-decode.h (apropos_cmd): Add verbose argument.
9472         * cli/cli-decode.c (apropos_cmd): Likewise.  Use print_doc_of_command
9473         instead of print_help_for_command.
9474         (print_doc_of_command): New function.
9475         (help_list): Add 'apropos -v word' suggestion.
9476         (print_help_for_command): Style the command name using title style.
9477         * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
9478         (_initialize_cli_cmds): Describe -v in apropos_command help.
9479
9480 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9481
9482         * cli/cli-style.h (cli_style_option): Add name in constructor,
9483         add m_name class member, add constructor with intensity,
9484         add name class function.
9485         (cli_style_option::add_setshow_commands): Remove name argument.
9486         (highlight_style, title_style): New styles.
9487         * cli/cli-style.c (do_show): New function that shows a style
9488         characteristic styling the style name with itself.
9489         (set_style_name): New function.
9490         (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
9491         Update all callers according to the changes in cli/cli-style.h.
9492         * utils.h (fputs_highlighted): New function.
9493         * utils.c (fputs_highlighted): Likewise.
9494
9495 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9496
9497         * NEWS: Mention new pipe command and new convenience variables.
9498
9499 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9500
9501         * cli/cli-cmds.c (pipe_command): New function.
9502         (_initialize_cli_cmds): Call add_com for pipe_command.
9503         Define | as an alias for pipe.
9504         (exit_status_set_internal_vars): New function.
9505         (shell_escape): Call exit_status_set_internal_vars.
9506         cli/cli-decode.c (find_command_name_length): Recognize | as
9507         a single character command.
9508
9509 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9510
9511         * gdbcmd.h (execute_command_to_ui_file): New declaration.
9512         top.c (execute_command_to_ui_file): New function, mostly a copy
9513         of execute_command_to_string.
9514         (execute_command_to_string): Implement by calling
9515         execute_command_to_ui_file.
9516
9517 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9518
9519         * top.h (saved_command_line): Remove declaration.
9520         * top.c (previous_saved_command_line, previous_repeat_arguments):
9521         New variables.
9522         (saved_command_line): Make static, define together with other
9523         'repeat variables'.
9524         (dont_repeat): Clear repeat_arguments.
9525         (repeat_previous, get_saved_command_line, save_command_line):
9526         New functions.
9527         (gdb_init): Initialize saved_command_line
9528         and previous_saved_command_line.
9529         * main.c (captured_main_1): Remove saved_command_line initialization.
9530         * event-top.c (handle_line_of_input): Update to use
9531         the new 'repeat' related functions instead of direct access to
9532         saved_command_line.
9533         * command.h (repeat_previous, get_saved_command_line,
9534         save_command_line): New declarations.
9535         (dont_repeat): Add comment.
9536
9537 2019-05-30  Tom Tromey  <tromey@adacore.com>
9538
9539         * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
9540         Fix comment.
9541         (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
9542
9543 2019-05-30  Jan Vrany  <jan.vrany@fit.cvut.cz>
9544
9545         PR cli/24587
9546         * completer.c (complete): Initialize variable word.
9547
9548 2019-05-29  Sergio Durigan Junior  <sergiodj@redhat.com>
9549
9550         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
9551         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
9552         * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
9553         'body' is NULL to the outter 'if', protecting the '!is_define'
9554         situation as well.
9555
9556 2019-05-29  Tom Tromey  <tromey@adacore.com>
9557
9558         * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
9559         (dwarf_unknown): New function.
9560         (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
9561         (dwarf_type_encoding_name): Use dwarf_unknown.
9562
9563 2019-05-29  Tom Tromey  <tromey@adacore.com>
9564
9565         PR c++/20020:
9566         * cp-valprint.c (cp_print_value_fields): Call
9567         cp_print_static_field inside "try".
9568
9569 2019-05-29  Tom Tromey  <tromey@adacore.com>
9570
9571         * inflow.c (struct terminal_info): Add default operator=.
9572         * configure: Rebuild.
9573         * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
9574         -Wdeprecated-copy-dtor, -Wredundant-move.
9575
9576 2019-05-29  Tom Tromey  <tromey@adacore.com>
9577
9578         * NEWS: Add entry.
9579         * infcmd.c (print_return_value_1): Handle finish_print
9580         option.
9581         (show_print_finish): New function.
9582         (_initialize_infcmd): Add "set/show print finish" commands.
9583         * valprint.c (user_print_options): Initialize new member.
9584         * valprint.h (struct value_print_options) <finish_print>: New
9585         member.
9586
9587 2019-05-28  Tom Tromey  <tromey@adacore.com>
9588
9589         * ada-lang.c (ada_remove_Xbn_suffix)
9590         (find_old_style_renaming_symbol)
9591         (parse_old_style_renaming): Remove.
9592         (ada_find_renaming_symbol): Don't call
9593         find_old_style_renaming_symbol.
9594         (ada_is_renaming_symbol): Rename from
9595         ada_find_renaming_symbol.  Remove "block" parameter.  Return
9596         bool.  Now static.
9597         (ada_read_var_value): Update and simplify.
9598         * ada-exp.y (write_var_or_type): Remove old code.
9599
9600 2019-05-28  Alan Hayward  <alan.hayward@arm.com>
9601
9602         PR gdb/25010
9603         * event-top.c: Remove include comment.
9604         * inflow.c (class scoped_ignore_sigttou): Move from here...
9605         * inflow.h (class scoped_ignore_sigttou): ...to here.
9606         * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
9607         * top.c:  Remove include comment.
9608
9609 2019-05-27  Tom Tromey  <tom@tromey.com>
9610
9611         * NEWS: Fix typo.
9612
9613 2019-05-22  Tom Tromey  <tromey@adacore.com>
9614
9615         * target.c (target_follow_exec): Constify parameter.
9616         * target-delegates.c: Rebuild.
9617         * remote.c (remote_target::follow_exec): Constify parameter.
9618         * infrun.c (follow_exec): Constify parameter.
9619         * target.h (struct target_ops) <follow_exec>: Constify parameter.
9620         (target_follow_exec): Likewise.
9621
9622 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
9623
9624         * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
9625         DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
9626
9627 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
9628
9629         * NEWS: Add debugredirect and testsuite sections.
9630
9631 2019-05-22  Simon Cook  <simon.cook@embecosm.com>
9632
9633         * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
9634         target descriptions using exclusively floating point register name
9635         aliases.
9636
9637 2019-05-21  Andrew Burgess  <andrew.burgess@embecosm.com>
9638
9639         PR gdb/18644:
9640         * f-lang.c (build_fortran_types): Handle the case where
9641         gdbarch_floatformat_for_type returns a nullptr.
9642
9643 2019-05-21  Tom de Vries  <tdevries@suse.de>
9644
9645         PR cli/24587
9646         * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
9647
9648 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
9649
9650         PR gdb/18644:
9651         * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
9652         16-byte floats.
9653         * i386-tdep.c (i386_floatformat_for_type): Use
9654         floatformats_ia64_quad for the 16-byte floating point component
9655         within a fortran 32-byte complex number.
9656
9657 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
9658
9659         * dwarf2read.c (struct cu_partial_die_info): Add constructor,
9660         delete default constructor.
9661         (find_partial_die): Update to return const struct.
9662         (partial_die_parent_scope): Move variable declaration into scope
9663         of its use and change its type to auto.
9664         (guess_partial_die_structure_name): Likewise.
9665         (partial_die_info::fixup): Likewise.
9666
9667 2019-05-17  Tom Tromey  <tromey@adacore.com>
9668
9669         * source.c (find_and_open_source): Remove cast.
9670
9671 2019-05-17  Tom Tromey  <tromey@adacore.com>
9672
9673         * annotate.c (annotate_source): Make "filename" const.
9674         * annotate.h (annotate_source): Use const.
9675
9676 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
9677
9678         * disasm.c (set_disassembler_options): Send errors to stderr.
9679
9680 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
9681
9682         * cli/cli-interp.c (struct saved_output_files): Add saved entry.
9683         (cli_interp_base::set_logging): Check debug_redirect.
9684         * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
9685         * cli/cli-logging.c (debug_redirect): Add static variable.
9686         (pop_output_files): Add default param.
9687         (handle_redirections): Print debug setting.
9688         (show_logging_command): Likewise.
9689         (_initialize_cli_logging): Add debugredirect command.
9690         * interps.c (current_interp_set_logging): Add debug_redirect
9691         parameter.
9692         * interps.h (set_logging): Add debug_redirect parameter.
9693         (current_interp_set_logging): Likewise.
9694         * mi/mi-common.h: Likewise.
9695         * mi/mi-interp.c (mi_interp::set_logging): Likewise.
9696
9697 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
9698             Tom Tromey  <tromey@adacore.com>
9699
9700         * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
9701         directly.
9702         * cli/cli-interp.h (make_logging_output): Remove declaration.
9703         * cli/cli-logging.c (make_logging_output): Remove function.
9704         * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
9705         directly.
9706         * ui-file.c (tee_file::tee_file): Remove bools.
9707         (tee_file::~tee_file): Remove deletes.
9708         * ui-file.h (tee_file): Remove bools.
9709
9710 2019-01-28  Jan Vrany  <jan.vrany@fit.cvut.cz>
9711
9712         * mi/mi-cmds.h (mi_cmd_complete): New function.
9713         * mi/mi-main.c (mi_cmd_complete): Likewise.
9714         * mi/mi-cmds.c: Define new MI command -complete.
9715         * NEWS: Mention new -complete command.
9716
9717 2019-01-24  Jan Vrany  <jan.vrany@fit.cvut.cz>
9718
9719         * completer.h (complete): New function.
9720         * completer.c (complete): Likewise.
9721         * cli/cli-cmds.c: (complete_command): Update to use new complete()
9722         function defined in completer.h.
9723
9724 2019-05-17  Jan Vrany  <jan.vrany@fit.cvut.cz>
9725
9726         * MAINTAINERS (Write After Approval): Add myself.
9727
9728 2019-05-17  Tom de Vries  <tdevries@suse.de>
9729
9730         PR gdb/24094
9731         * dwarf2read.c (struct cu_partial_die_info): New struct.
9732         (find_partial_die): Return cu_partial_die_info.
9733         (partial_die_parent_scope, guess_partial_die_structure_name)
9734         (partial_die_info::fixup): Handle new return type of find_partial_die.
9735
9736 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
9737
9738         PR breakpoints/24541
9739         * stap-probe.c (stap_parse_register_operand): Make "regname" an
9740         "std::string", simplifying the algorithm.
9741
9742 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
9743
9744         * stap-probe.c (handle_stap_probe): Fix complaint formatting.
9745         (stap_static_probe_ops::get_probes): Likewise.
9746
9747 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
9748
9749         * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
9750         '-')" and "else if".
9751         (stap_parse_single_operand): Join checks for
9752         "gdbarch_stap_parse_special_token_p" and
9753         "gdbarch_stap_parse_special_token" in the same "if" statement.
9754         Invert check when verifying for operation on register
9755         displacement.
9756
9757 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
9758
9759         * stap-probe.c (stap_get_opcode): Update comment.
9760         (stap_get_expected_argument_type): Likewise.
9761         (handle_stap_probe): Likewise.
9762
9763 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
9764
9765         * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
9766         return type to 'bool'.  Adjust comment.  Use 'bool' when
9767         appropriate.
9768         (i386_stap_parse_special_token_three_arg_disp): Likewise.
9769         * stap-probe.c (stap_parse_argument_1): Likewise.
9770         (stap_is_operator): Likewise.
9771         (stap_is_generic_prefix): Likewise.
9772         (stap_is_register_prefix): Likewise.
9773         (stap_is_register_indirection_prefix): Likewise.
9774         (stap_is_integer_prefix): Likewise.
9775         (stap_generic_check_suffix): Likewise.
9776         (stap_check_integer_suffix): Likewise.
9777         (stap_check_register_suffix): Likewise.
9778         (stap_check_register_indirection_suffix): Likewise.
9779         (stap_parse_register_operand): Likewise.
9780         (stap_parse_single_operand): Likewise.
9781         (stap_parse_argument_1): Likewise.
9782         (stap_probe::get_argument_count): Likewise.
9783         (stap_is_operator): Likewise.
9784
9785 2019-05-16  Tom Tromey  <tromey@adacore.com>
9786
9787         * darwin-nat.c (thread_info_from_private_thread_info): Add struct
9788         keyword to foreach.
9789
9790 2019-05-15  Simon Marchi  <simon.marchi@efficios.com>
9791
9792         * linux-thread-db.c (try_thread_db_load_1): Change return type
9793         to bool.
9794         (try_thread_db_load): Likewise.
9795         (try_thread_db_load_from_pdir_1): Likewise.
9796         (try_thread_db_load_from_pdir): Likewise.
9797         (try_thread_db_load_from_sdir): Likewise.
9798         (try_thread_db_load_from_dir): Likewise.
9799         (thread_db_load_search): Likewise.
9800         (has_libpthread): Likewise.
9801         (thread_db_load): Likewise.
9802
9803 2019-05-15  Sergio Durigan Junior  <sergiodj@redhat.com>
9804
9805         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
9806         * dwarf2read.c (parse_macro_definition): Check whether 'body' is
9807         NULL, and complain/return if that's the case.
9808
9809 2019-05-15  John Darrington <john@darrington.wattle.id.au>
9810
9811         * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
9812         (advance, posn, abstract_read_memory): New functions.
9813         [struct mem_read_abstraction]: New struct.
9814         (s12z_frame_cache): Use opcodes API to interpret stack frame code.
9815
9816 2019-05-14  Tom Tromey  <tromey@adacore.com>
9817
9818         * ada-lang.c (coerce_unspec_val_to_type): Only set address when
9819         value is not lval_memory.
9820
9821 2019-05-14  Tom Tromey  <tromey@adacore.com>
9822
9823         * solib.c (info_sharedlibrary_command): Style the file name.
9824
9825 2019-05-14  Alan Hayward  <alan.hayward@arm.com>
9826
9827         * aarch64-tdep.c (aarch64_vnh_type): Add half view.
9828         (aarch64_vnv_type): Likewise.
9829         * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
9830         * common/tdesc.c: Likewise.
9831         * common/tdesc.h (enum tdesc_type_kind): Likewise.
9832         * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
9833         * features/aarch64-fpu.xml: Add ieee half view.
9834         * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
9835         * gdbtypes.c (gdbtypes_post_init): Add builtin_half
9836         * gdbtypes.h (struct builtin_type): Likewise.
9837         (struct objfile_type): Likewise.
9838
9839 2019-05-12  Paul Naert  <paul.naert@polymtl.ca>
9840
9841         * language.c (language_sniff_from_mangled_name): Fix "langauge"
9842         typo.
9843         * location.h (string_to_event_location): Likewise.
9844
9845 2019-05-11  Joel Brobecker  <brobecker@adacore.com>
9846
9847         GDB 8.3 released.
9848
9849 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
9850
9851         * breakpoint.h (fix_multi_location_breakpoint_output_globally):
9852         New variable declaration.
9853         * breakpoint.c (fix_multi_location_breakpoint_output_globally):
9854         New variable.
9855         (print_one_breakpoint): Use ui_out::test_flags and new global
9856         variable to compute use_fixed_output.
9857         * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
9858         Remove.
9859         * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
9860         (mi_multi_location_breakpoint_output_fixed): Remove.
9861         (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
9862         new variable.
9863         * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
9864         fix_multi_location_breakpoint_output flag if version >= 3.
9865         * ui-out.h (enum ui_out_flag)
9866         <fix_multi_location_breakpoint_output>: New enumerator.
9867
9868 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
9869
9870         * contrib/cc-with-tweaks.sh: Validate dwz's work.
9871
9872 2019-05-10  Tom Tromey  <tromey@adacore.com>
9873
9874         * ada-lang.c (catch_ada_completer): New function.
9875         (_initialize_ada_language): Use it.
9876
9877 2019-05-10  Tom Tromey  <tromey@adacore.com>
9878
9879         * thread.c (print_thread_info): Make "requested_threads" const.
9880         * gdbthread.h (print_thread_info): Make "requested_threads"
9881         const.
9882         * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
9883         * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
9884
9885 2019-05-08  Tom Tromey  <tom@tromey.com>
9886
9887         * gdbtypes.c (objfile_type_data): Change type.
9888         (objfile_type, _initialize_gdbtypes): Update.
9889
9890 2019-05-08  Tom Tromey  <tom@tromey.com>
9891
9892         * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
9893         (dwarf2_frame_find_fde, dwarf2_build_frame_info)
9894         (_initialize_dwarf2_frame): Update.
9895
9896 2019-05-08  Tom Tromey  <tom@tromey.com>
9897
9898         * objc-lang.c (objc_objfile_data): Change type.
9899         (find_methods): Update.
9900         (_initialize_objc_lang): Remove.
9901
9902 2019-05-08  Tom Tromey  <tom@tromey.com>
9903
9904         * stabsread.c (rs6000_builtin_type_data): Change type.
9905         (rs6000_builtin_type, _initialize_stabsread): Update.
9906
9907 2019-05-08  Tom Tromey  <tom@tromey.com>
9908
9909         * mips-tdep.c (mips_pdr_data): Remove.
9910         (_initialize_mips_tdep): Update.
9911
9912 2019-05-08  Tom Tromey  <tom@tromey.com>
9913
9914         * hppa-tdep.c (hppa_objfile_priv_data): Change type.
9915         (hppa_init_objfile_priv_data, read_unwind_info)
9916         (find_unwind_entry, _initialize_hppa_tdep): Update.
9917
9918 2019-05-08  Tom Tromey  <tom@tromey.com>
9919
9920         * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
9921         (elf_gnu_ifunc_record_cache): Update.  Don't allocate hash table
9922         on obstack.
9923         (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
9924
9925 2019-05-08  Tom Tromey  <tom@tromey.com>
9926
9927         * mdebugread.c (basic_type_data): Change type.
9928         (basic_type, _initialize_mdebugread): Update.
9929
9930 2019-05-08  Tom Tromey  <tom@tromey.com>
9931
9932         * common/gdb_unique_ptr.h (struct noop_deleter): New.
9933
9934 2019-05-08  Tom Tromey  <tom@tromey.com>
9935
9936         * nto-tdep.c (nto_inferior_data_reg): Change type.
9937         (nto_inferior_data): Update.
9938         (nto_inferior_data_cleanup, nto_new_inferior_data)
9939         (_initialize_nto_tdep): Remove.
9940         * nto-tdep.h (struct nto_inferior_data): Add initializers.
9941
9942 2019-05-08  Tom Tromey  <tom@tromey.com>
9943
9944         * ada-lang.c (struct ada_inferior_data): Add initializers.
9945         (ada_inferior_data): Change type.
9946         (ada_inferior_data_cleanup): Remove.
9947         (get_ada_inferior_data, ada_inferior_exit)
9948         (struct ada_pspace_data): Add initializers, destructor.
9949         (ada_pspace_data_handle): Change type.
9950         (get_ada_pspace_data): Update.
9951         (ada_pspace_data_cleanup): Remove.
9952
9953 2019-05-08  Tom Tromey  <tom@tromey.com>
9954
9955         * coffread.c (struct coff_symfile_info): Add initializers.
9956         (coff_objfile_data_key): Move lower.  Change type.
9957         (coff_symfile_init, coff_symfile_read, _initialize_coffread):
9958         Update.
9959         (coff_free_info): Remove.
9960
9961 2019-05-08  Tom Tromey  <tom@tromey.com>
9962
9963         * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
9964         (fbsd_pspace_data_handle): Move lower.  Change type.
9965         (get_fbsd_pspace_data): Update.
9966         (fbsd_pspace_data_cleanup): Remove.
9967         (_initialize_fbsd_tdep): Update.
9968
9969 2019-05-08  Tom Tromey  <tom@tromey.com>
9970
9971         * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
9972         (get_ada_tasks_pspace_data): Update.
9973         (ada_tasks_pspace_data_cleanup): Remove.
9974         (_initialize_tasks): Update.
9975         (ada_tasks_inferior_data_handle): Change type.
9976         (get_ada_tasks_inferior_data): Update.
9977         (ada_tasks_inferior_data_cleanup): Remove.
9978         (struct ada_tasks_pspace_data): Add initializers.
9979
9980 2019-05-08  Tom Tromey  <tom@tromey.com>
9981
9982         * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
9983         * symfile-debug.c (debug_sym_get_probes): Change type.
9984         * stap-probe.c (handle_stap_probe):
9985         (stap_static_probe_ops::get_probes): Change type.
9986         * probe.h (class static_probe_ops) <get_probes>: Change type.
9987         * probe.c (class any_static_probe_ops) <get_probes>: Change type.
9988         (parse_probes_in_pspace): Update.
9989         (find_probes_in_objfile, find_probe_by_pc, collect_probes):
9990         Update.
9991         (any_static_probe_ops::get_probes): Change type.
9992         * elfread.c (elfread_data): New typedef.
9993         (probe_key): Change type.
9994         (elf_get_probes): Likewise.  Update.
9995         (probe_key_free): Remove.
9996         (_initialize_elfread): Update.
9997         * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
9998         Change type.
9999         (dtrace_process_dof_probe, dtrace_process_dof)
10000         (dtrace_static_probe_ops::get_probe): Change type.
10001
10002 2019-05-08  Tom Tromey  <tom@tromey.com>
10003
10004         * xcoffread.c (struct xcoff_symfile_info): Rename from
10005         coff_symfile_info.  Add initializers.
10006         (xcoff_objfile_data_key): Move lower.  Change type.
10007         (XCOFF_DATA): Rewrite.
10008         (xcoff_free_info): Remove.
10009         (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
10010         (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
10011         (xcoff_initial_scan): Update.
10012
10013 2019-05-08  Tom Tromey  <tom@tromey.com>
10014
10015         * solib-svr4.c (struct svr4_info): Add initializers and
10016         destructor.
10017         <probes_table>: Now an htab_up.
10018         (solib_svr4_pspace_data): Change type.
10019         (free_probes_table): Simplify.
10020         (~svr4_info): Rename from svr4_pspace_data_cleanup.
10021         (get_svr4_info, probes_table_htab_remove_objfile_probes)
10022         (probes_table_remove_objfile_probes, register_solib_event_probe)
10023         (solib_event_probe_at, svr4_update_solib_event_breakpoint)
10024         (_initialize_svr4_solib): Update.
10025
10026 2019-05-08  Tom Tromey  <tom@tromey.com>
10027
10028         * remote.c (remote_pspace_data): Change type.
10029         (remote_pspace_data_cleanup): Remove.
10030         (get_remote_exec_file, set_pspace_remote_exec_file)
10031         (_initialize_remote): Update.
10032
10033 2019-05-08  Tom Tromey  <tom@tromey.com>
10034
10035         * breakpoint.c (breakpoint_objfile_key): Change type.
10036         (get_breakpoint_objfile_data): Update.
10037         (free_breakpoint_objfile_data): Remove.
10038         (_initialize_breakpoint): Update.
10039
10040 2019-05-08  Tom Tromey  <tom@tromey.com>
10041
10042         * linux-tdep.c (struct linux_info): Add initializers.
10043         (linux_inferior_data): Move.  Change type.
10044         (invalidate_linux_cache_inf): Update.
10045         (linux_inferior_data_cleanup): Remove.
10046         (get_linux_inferior_data, _initialize_linux_tdep): Update.
10047
10048 2019-05-08  Tom Tromey  <tom@tromey.com>
10049
10050         * auxv.c (auxv_inferior_data): Move.  Change type.
10051         (auxv_inferior_data_cleanup): Remove.
10052         (invalidate_auxv_cache_inf): Rewrite.
10053         (get_auxv_inferior_data, _initialize_auxv): Update.
10054
10055 2019-05-08  Tom Tromey  <tom@tromey.com>
10056
10057         * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
10058         (symfile_debug_objfile_data_key): Change type.
10059         (symfile_debug_installed, debug_qf_has_symbols)
10060         (debug_qf_find_last_source_symtab)
10061         (debug_qf_forget_cached_source_info)
10062         (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
10063         (debug_qf_print_stats, debug_qf_dump)
10064         (debug_qf_expand_symtabs_for_function)
10065         (debug_qf_expand_all_symtabs)
10066         (debug_qf_expand_symtabs_with_fullname)
10067         (debug_qf_map_matching_symbols)
10068         (debug_qf_expand_symtabs_matching)
10069         (debug_qf_find_pc_sect_compunit_symtab)
10070         (debug_qf_map_symbol_filenames)
10071         (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
10072         (debug_sym_new_init, debug_sym_init, debug_sym_read)
10073         (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
10074         (debug_sym_read_linetable, debug_sym_relocate): Update.
10075         (symfile_debug_free_objfile): Remove.
10076         (install_symfile_debug_logging, _initialize_symfile_debug):
10077         Update.
10078
10079 2019-05-08  Tom Tromey  <tom@tromey.com>
10080
10081         * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
10082         allocate_on_obstack.
10083         * dwarf2read.c (dwarf2_objfile_data_key): Change type.
10084         (get_dwarf2_per_objfile): Update.
10085         (set_dwarf2_per_objfile): Remove.
10086         (dwarf2_has_info, dwarf2_get_section_info): Update.
10087         (dwarf2_free_objfile): Remove.
10088         (_initialize_dwarf2_read): Update.
10089
10090 2019-05-08  Tom Tromey  <tom@tromey.com>
10091
10092         * auto-load.c (struct auto_load_pspace_info): Add destructor and
10093         initializers.
10094         <unsupported_script_warning_printed,
10095         script_not_found_warning_printed>: Now bool.
10096         (auto_load_pspace_data): Change type.
10097         (~auto_load_pspace_info): Rename from
10098         auto_load_pspace_data_cleanup.
10099         (get_auto_load_pspace_data, init_loaded_scripts_info)
10100         (clear_section_scripts, maybe_print_unsupported_script_warning)
10101         (maybe_print_script_not_found_warning, _initialize_auto_load):
10102         Update.
10103
10104 2019-05-08  Tom Tromey  <tom@tromey.com>
10105
10106         * objfiles.c (objfile_pspace_info): Add destructor and
10107         initializers.
10108         (objfiles_pspace_data): Change type.
10109         (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
10110         (get_objfile_pspace_data): Update.
10111         (objfiles_bfd_data): Change type.
10112         (get_objfile_bfd_data): Update.
10113         (objfile_bfd_data_free, _initialize_objfiles): Remove.
10114
10115 2019-05-08  Tom Tromey  <tom@tromey.com>
10116
10117         * break-catch-syscall.c (catch_syscall_inferior_data): Move.
10118         Change type.
10119         (get_catch_syscall_inferior_data): Update.
10120         (catch_syscall_inferior_data_cleanup): Remove.
10121         (_initialize_break_catch_syscall): Update.
10122
10123 2019-05-08  Tom Tromey  <tom@tromey.com>
10124
10125         * inflow.c (struct terminal_info): Add destructor and
10126         initializers.
10127         (inflow_inferior_data): Change type.
10128         (~terminal_info): Rename from inflow_inferior_data_cleanup.
10129         (get_inflow_inferior_data, inflow_inferior_exit)
10130         (swap_terminal_info, _initialize_inflow): Update.
10131
10132 2019-05-08  Tom Tromey  <tom@tromey.com>
10133
10134         * target-dcache.c (target_dcache_cleanup): Remove.
10135         (target_dcache_aspace_key): Change type.
10136         (target_dcache_init_p, target_dcache_invalidate)
10137         (target_dcache_get, target_dcache_get_or_init)
10138         (_initialize_target_dcache): Update.
10139         * dcache.h (struct dcache_deleter): New.
10140
10141 2019-05-08  Tom Tromey  <tom@tromey.com>
10142
10143         * symtab.c (struct symbol_cache): Add destructor and
10144         initializers.
10145         (symbol_cache_key): Move.  Change type.
10146         (make_symbol_cache, free_symbol_cache): Remove.
10147         (get_symbol_cache): Update.
10148         (symbol_cache_cleanup): Remove.
10149         (ALL_PSPACES, symbol_cache_flush)
10150         (maintenance_print_symbol_cache)
10151         (maintenance_print_symbol_cache_statistics, _initialize_symtab):
10152         Update.
10153
10154 2019-05-08  Tom Tromey  <tom@tromey.com>
10155
10156         * symtab.c (struct main_info): Add destructor and initializers.
10157         (main_progspace_key): Move.  Change type.
10158         (get_main_info): Update.
10159         (main_info_cleanup): Remove.
10160         (_initialize_symtab): Update.
10161
10162 2019-05-08  Tom Tromey  <tom@tromey.com>
10163
10164         * registry.h (DECLARE_REGISTRY): Define the _key class.
10165
10166 2019-05-08  Andrew Burgess  <andrew.burgess@embecosm.com>
10167
10168         * NEWS: Merge two 'New commands' sections.
10169
10170 2019-05-08  Joel Brobecker  <brobecker@adacore.com>
10171
10172         * ada-valprint.c (ada_val_print_gnat_array): Remove language
10173         parameter and use Ada language definition instead.
10174         (ada_val_print_ptr): Remove unused language parameter.
10175         (ada_val_print_num): Remove language parameter and use Ada language
10176         definition instead.
10177         (ada_val_print_enum, ada_val_print_flt): Remove unused language
10178         parameter.
10179         (ada_val_print_struct_union, ada_val_print_ref): Remove language
10180         parameter and use Ada language definition instead.
10181         (ada_val_print_1): Update all ada_val_print_xxx calls.
10182         Remove language parameter.
10183         (ada_val_print): Update ada_val_print_1 call.
10184
10185 2019-05-08  Tom Tromey  <tromey@adacore.com>
10186
10187         * remote.c (remote_hw_watchpoint_limit)
10188         (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
10189         Now static.
10190
10191 2019-05-08  Tom Tromey  <tromey@adacore.com>
10192
10193         * maint.c (_initialize_maint_cmds): Move initialization code to
10194         remote.c.
10195         (watchdog, show_watchdog): Move to remote.c.
10196         * remote.c (watchdog, show_watchdog): Move from maint.c.  Make
10197         "watchdog" static.
10198         (_initialize_remote): Move initialization code from maint.c.
10199         * defs.h (watchdog): Don't declare.
10200
10201 2019-05-08  Tom Tromey  <tromey@adacore.com>
10202
10203         * tui/tui-interp.c: Include main.h.
10204         * interps.c: Include main.h.
10205         * main.h (interpreter_p): Declare.
10206         * defs.h (interpreter_p): Don't declare.
10207
10208 2019-05-08  Tom Tromey  <tromey@adacore.com>
10209
10210         * dwarf2loc.c: Include dwarf2read.h.
10211         * defs.h (read_unsigned_leb128): Don't declare.
10212         * dwarf2read.h (read_unsigned_leb128): Declare.
10213
10214 2019-05-08  Tom Tromey  <tromey@adacore.com>
10215
10216         * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
10217         method.
10218
10219 2019-05-08  Tom Tromey  <tromey@adacore.com>
10220
10221         * utils.c (fputs_maybe_filtered): Reset style after paging, even
10222         when no wrap column is set.
10223
10224 2019-05-08  Tom Tromey  <tromey@adacore.com>
10225
10226         * c-lang.c (c_get_string): Handle non-C-style arrays.
10227
10228 2019-05-08  Tom Tromey  <tromey@adacore.com>
10229
10230         * typeprint.c (print_offset_data::update): Print the bit offset,
10231         not the number of bits remaining.
10232
10233 2019-05-08  Tom Tromey  <tromey@adacore.com>
10234
10235         * typeprint.c (print_offset_data::maybe_print_hole): Add extra
10236         padding at end of comment.
10237
10238 2019-05-08  Tom Tromey  <tromey@adacore.com>
10239
10240         * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
10241         Compare main types.
10242
10243 2019-05-06  Tom Tromey  <tom@tromey.com>
10244
10245         * common/scoped_mmap.c: Include common-defs.h.
10246         * common/scoped_mmap.h: Don't include config.h.
10247
10248 2019-05-04  Tom Tromey  <tom@tromey.com>
10249
10250         * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
10251         (struct aarch64_call_info): Add initializers.
10252         <si>: Now a std::vector.
10253         (pass_on_stack, aarch64_push_dummy_call): Update.
10254
10255 2019-05-04  Simon Marchi  <simon.marchi@efficios.com>
10256             Tom Tromey  <tom@tromey.com>
10257
10258         * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
10259         (ppc_threads): Now a std::vector.  Now static.
10260         (hwdebug_find_thread_points_by_tid)
10261         (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
10262         Update.
10263
10264 2019-05-04  Tom Tromey  <tom@tromey.com>
10265
10266         * arc-tdep.c (arc_tdesc_init): Return bool.
10267
10268 2019-05-04  Tom Tromey  <tom@tromey.com>
10269
10270         * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
10271         Use gdb_assert_not_reached.
10272
10273 2019-05-04  Tom Tromey  <tom@tromey.com>
10274
10275         * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
10276         "false".
10277
10278 2019-05-04  Tom Tromey  <tom@tromey.com>
10279
10280         * arc-tdep.c (arc_tdesc_init): Use bool.
10281
10282 2019-05-04  Tom Tromey  <tom@tromey.com>
10283
10284         * stack.c (select_frame_for_mi): Use "false", not "FALSE".
10285
10286 2019-05-04  Tom Tromey  <tom@tromey.com>
10287
10288         * cli/cli-cmds.c (valid_command_p): Return bool.
10289
10290 2019-05-04  Tom Tromey  <tom@tromey.com>
10291
10292         * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
10293         * command.h (valid_user_defined_cmd_name_p): Channge return type.
10294
10295 2019-05-04  Raul Tambre  <raul@tambre.ee>
10296
10297         * python/lib/gdb/prompt.py (_ExtendedPrompt)
10298         <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
10299         operator for comparison.
10300
10301 2019-05-04  Tom Tromey  <tom@tromey.com>
10302
10303         * psymtab.c (psymbol_name_matches, match_partial_symbol)
10304         (lookup_partial_symbol, print_partial_symbols)
10305         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
10306         (psymbol_compare): Update.
10307         (add_psymbol_to_bcache): Clear the entire psymbol.
10308         (maintenance_check_psymtabs): Update.
10309         * psympriv.h (struct partial_symbol): Don't derive from
10310         general_symbol_info.
10311         <obj_section, unrelocated_address, address,
10312         set_unrelocated_address>: Update.
10313         <ginfo>: New member.
10314         * dwarf-index-write.c (write_psymbols, debug_names::insert)
10315         (debug_names::write_psymbols): Update.
10316
10317 2019-05-04  Tom de Vries  <tdevries@suse.de>
10318
10319         * contrib/cc-with-tweaks.sh: Support -n arg.
10320
10321 2019-05-04  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10322
10323         * corelow.c (core_target::detach): Ensure frame cache and
10324         register caches are cleared.
10325         inferior.c (exit_inferior_1): Likewise.
10326
10327 2019-05-03  Sandra Loosemore  <sandra@codesourcery.com>
10328             Tom Tromey  <tom@tromey.com>
10329
10330         * dictionary.c (collate_pending_symbols_by_language): Remove
10331         "struct" from foreach.
10332         * symtab.c (lookup_global_symbol_from_objfile)
10333         (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
10334         foreach.
10335         * ser-tcp.c (net_open): Remove "struct" from foreach.
10336         * objfiles.c (objfile_relocate, objfile_rebase)
10337         (objfile_has_symbols): Remove "struct" from foreach.
10338         * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
10339         from foreach.
10340         * dwarf2read.c (handle_struct_member_die): Remove "struct" from
10341         foreach.
10342         * darwin-nat.c (thread_info_from_private_thread_info): Remove
10343         "struct" from foreach.
10344         * ada-lang.c (create_excep_cond_exprs)
10345         (ada_exception_catchpoint_cond_string): Remove "struct" from
10346         foreach.
10347
10348 2019-05-03  Tom Tromey  <tromey@adacore.com>
10349
10350         * ada-exp.y (convert_char_literal): Check suffix of each
10351         enumerator.
10352
10353 2019-05-03  Dilyan Palauzov  <dilyan.palauzov@aegee.org>
10354
10355         PR ada/21406:
10356         * ada-exp.y (yywrap): Don't define.
10357         * ada-lex.l (%option): Add noyywrap
10358         (yywrap): Remove.
10359
10360 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
10361
10362         * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
10363         _WIN32_WINNT to the XP level, unless already defined to a higher
10364         level.
10365
10366         * unittests/parse-connection-spec-selftests.c:
10367         * ser-tcp.c:
10368         * common/netstuff.c [USE_WIN32API]:  Remove the _WIN32_WINNT
10369         override.
10370
10371         * symfile.c (find_separate_debug_file): Remove colon from the
10372         drive spec of DOS/Windows file names of the target, so that the
10373         file name produced from DEBUGDIR and the target's directory will
10374         be valid on DOS/Windows systems.
10375
10376 2019-05-02  Andrew Burgess  <andrew.burgess@embecosm.com>
10377
10378         * rust-lang.c (val_print_struct): Handle printing structures
10379         containing strings.
10380
10381 2019-05-02  Tom Tromey  <tromey@adacore.com>
10382
10383         * valarith.c (_initialize_valarith): Remove.
10384
10385 2019-05-01  Tom Tromey  <tromey@adacore.com>
10386
10387         * ada-lang.c (ada_value_primitive_field): Treat more fields as
10388         bitfields.
10389
10390 2019-05-01  Tom Tromey  <tromey@adacore.com>
10391
10392         * ada-lang.c (ada_value_assign): Correctly compute starting offset
10393         for big-endian copies.
10394
10395 2019-04-30  Ali Tamur  <tamur@google.com>
10396         * gdb/dwarf2read.c (read_3_bytes): New declaration.
10397         (read_attribute_value): Added DW_FORM_strx1-4 cases.
10398         (read_3_bytes): New function.
10399
10400 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
10401
10402         * windows-nat.c (main_thread_id): Delete.
10403         (handle_output_debug_string): Replace main_thread_id by
10404         current_event.dwThreadId.
10405         (fake_create_process): Likewise.
10406         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
10407         Do not set main_thread_id.
10408         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
10409         current_event.dwThreadId.
10410         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
10411
10412 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
10413
10414         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
10415         Use current_event.dwThreadId instead of main_thread_id.
10416
10417 2019-04-30  Tom Tromey  <tromey@adacore.com>
10418
10419         * ada-lang.c (ada_lookup_simple_minsyms): New function.
10420         (create_excep_cond_exprs): Iterate over program spaces.
10421         (ada_exception_catchpoint_cond_string): Examine all minimal
10422         symbols for exception types.
10423
10424 2019-04-30  Tom Tromey  <tromey@adacore.com>
10425
10426         PR c++/24470:
10427         * dwarf2read.c (process_structure_scope): Handle case where type
10428         has template parameters but no symbol was created.
10429
10430 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
10431             Chris January  <chris.january@arm.com>
10432
10433         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
10434         qualifier.
10435         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
10436
10437 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
10438
10439         * f-typeprint.c (f_print_type): Update rules for printing
10440         whitespace.
10441         (f_type_print_varspec_suffix): Likewise.
10442
10443 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
10444             Chris January  <chris.january@arm.com>
10445
10446         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
10447         function arguments.
10448
10449 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
10450
10451         * f-lang.c (build_fortran_types): Change name of void type to
10452         lower case.
10453         * f-typeprint.c (f_type_print_base): Print the name of the void
10454         type, rather than a fixed string.
10455         * f-valprint.c (f_decorations): Use lower case void string.
10456
10457 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
10458             Chris January  <chris.january@arm.com>
10459
10460         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
10461         types for Fortran.
10462
10463 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
10464             Chris January  <chris.january@arm.com>
10465             David Lecomber  <david.lecomber@arm.com>
10466
10467         * f-exp.y (BINOP_INTRINSIC): New token.
10468         (exp): New parser rule handling BINOP_INTRINSIC.
10469         (f77_keywords): Add new builtin procedures.
10470         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
10471         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
10472         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
10473         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
10474         (print_unop_subexp_f): New function.
10475         (print_binop_subexp_f): New function.
10476         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
10477         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
10478         (dump_subexp_body_f): Likewise.
10479         (operator_check_f): Likewise.
10480         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
10481         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
10482
10483 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
10484
10485         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
10486         UNOP_KIND.
10487         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
10488         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
10489         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
10490         (operator_length_f): New fuction.
10491         (print_subexp_f): New function.
10492         (op_name_f): New function.
10493         (dump_subexp_body_f): New function.
10494         (operator_check_f): New function.
10495         (exp_descriptor_f): Replace standard expression handling functions
10496         with new functions.
10497         * gdb/fortran-operator.def: New file.
10498         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
10499         * gdb/std-operator.def: Remove UNOP_KIND.
10500
10501 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
10502
10503         * std-operator.def: Remove unbalanced, stray double quote
10504         character.
10505
10506 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
10507             Chris January  <chris.january@arm.com>
10508             Daniel Everett  <daniel.everett@arm.com>
10509             Nick Forrington  <nick.forrington@arm.com>
10510             Richard Bunt  <richard.bunt@arm.com>
10511
10512         * cp-valprint.c (cp_print_value_fields): Allow an additional level
10513         of depth when printing anonymous structs or unions.
10514         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
10515         Don't print either the top-level value, or the children if the
10516         max-depth is exceeded.
10517         (ppscm_print_children): When printing the key of a map, allow one
10518         extra level of depth.
10519         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
10520         print either the top-level value, or the children if the max-depth
10521         is exceeded.
10522         (print_children): When printing the key of a map, allow one extra
10523         level of depth.
10524         * python/py-value.c (valpy_format_string): Add max_depth keyword.
10525         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
10526         (user_print_options): Initialise max_depth field.
10527         (val_print_scalar_or_string_type_p): New function.
10528         (val_print): Check to see if the max depth has been reached.
10529         (val_print_check_max_depth): Define new function.
10530         (show_print_max_depth): New function.
10531         (_initialize_valprint): Add 'print max-depth' option.
10532         * valprint.h (struct value_print_options) <max_depth>: New field.
10533         (val_print_check_max_depth): Declare new function.
10534         * NEWS: Document new feature.
10535
10536 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
10537
10538         * ada-lang.c (ada_language_defn): Initialise new field.
10539         * c-lang.c (c_is_string_type_p): New function.
10540         (c_language_defn): Initialise new field.
10541         (cplus_language_defn): Initialise new field.
10542         (asm_language_defn): Initialise new field.
10543         (minimal_language_defn): Initialise new field.
10544         * c-lang.h (c_is_string_type_p): Declare new function.
10545         * d-lang.c (d_language_defn): Initialise new field.
10546         * f-lang.c (f_is_string_type_p): New function.
10547         (f_language_defn): Initialise new field.
10548         * go-lang.c (go_is_string_type_p): New function.
10549         (go_language_defn): Initialise new field.
10550         * language.c (default_is_string_type_p): New function.
10551         (unknown_language_defn): Initialise new field.
10552         (auto_language_defn): Initialise new field.
10553         * language.h (struct language_defn) <la_is_string_type_p>: New
10554         member variable.
10555         (default_is_string_type_p): Declare new function.
10556         * m2-lang.c (m2_language_defn): Initialise new field.
10557         * objc-lang.c (objc_language_defn): Initialise new field.
10558         * opencl-lang.c (opencl_language_defn): Initialise new field.
10559         * p-lang.c (pascal_is_string_type_p): New function.
10560         (pascal_language_defn): Initialise new field.
10561         * rust-lang.c (rust_is_string_type_p): New function.
10562         (rust_language_defn): Initialise new field.
10563
10564 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
10565
10566         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
10567         New field.
10568         * ada-lang.c (ada_language_defn): Initialise new field.
10569         * c-lang.c (c_language_defn): Likewise.
10570         (cplus_language_defn): Likewise.
10571         (asm_language_defn): Likewise.
10572         (minimal_language_defn): Likewise.
10573         * d-lang.c (d_language_defn): Likewise.
10574         * f-lang.c (f_language_defn): Likewise.
10575         * go-lang.c (go_language_defn): Likewise.
10576         * language.c (unknown_language_defn): Likewise.
10577         (auto_language_defn): Likewise.
10578         * m2-lang.c (m2_language_defn): Likewise.
10579         * objc-lang.c (objc_language_defn): Likewise.
10580         * opencl-lang.c (opencl_language_defn): Likewise.
10581         * p-lang.c (pascal_language_defn): Likewise.
10582         * rust-lang.c (rust_language_defn): Likewise.
10583
10584 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
10585
10586         * ada-lang.c (ada_is_character_type): Change return type to bool.
10587         (ada_is_string_type): Likewise.
10588         * ada-lang.h (ada_is_character_type): Update declaration
10589         (ada_is_string_type): Likewise.
10590
10591 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10592
10593         Support style in 'frame|thread apply'
10594
10595         * gdbcmd.h (execute_command_to_string): New term_out parameter.
10596         * record.c (record_start, record_stop): Update callers of
10597         execute_command_to_string with false.
10598         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
10599         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
10600         methods.
10601         (class string_file): New constructor with term_out parameter.
10602         Override methods term_out and can_emit_style_escape.  New member
10603         term_out.
10604         (class stdio_file): Override can_emit_style_escape.
10605         (class tee_file): Override term_out and can_emit_style_escape.
10606         * utils.h (can_emit_style_escape): Remove.
10607         * utils.c (can_emit_style_escape): Likewise.
10608         Update all callers of can_emit_style_escape (SOMESTREAM) to
10609         SOMESTREAM->can_emit_style_escape.
10610         * source-cache.c (source_cache::get_source_lines): Likewise.
10611         * stack.c (frame_apply_command_count): Call execute_command_to_string
10612         passing the term_out characteristic of the current gdb_stdout.
10613         * thread.c (thr_try_catch_cmd): Likewise.
10614         * top.c (execute_command_to_string): pass term_out parameter
10615         to construct the string_file for the command output.
10616         * ui-file.c (term_cli_styling): New function (most code moved
10617         from utils.c can_emit_style_escape).
10618         (string_file::string_file, string_file::can_emit_style_escape,
10619         stdio_file::can_emit_style_escape, tee_file::term_out,
10620         tee_file::can_emit_style_escape): New functions.
10621
10622 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10623
10624         * NEWS: Mention the new set|show may-call-functions.
10625         * infcall.c (may_call_functions_p): New variable.
10626         (show_may_call_functions_p): New function.
10627         (call_function_by_hand_dummy): Throws an error if not
10628         may-call-functions.
10629         (_initialize_infcall): Call add_setshow_boolean_cmd for
10630         may-call-functions.
10631
10632 2019-04-25  Keith Seitz  <keiths@redhat.com>
10633
10634         PR c++/24367
10635         * cp-support.c (inspect_type): Don't attempt substitutions
10636         of symbol with the same name.
10637
10638 2019-04-25  Tom Tromey  <tromey@adacore.com>
10639
10640         PR gdb/24475:
10641         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
10642         static.
10643
10644 2019-04-25  Tom Tromey  <tromey@adacore.com>
10645
10646         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
10647         rvalue reference.
10648         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
10649         (gdb_xml_parser::parse): Use std::move.
10650         * python/python-internal.h (gdbpy_convert_exception): Take a const
10651         reference.
10652         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
10653         std::move.
10654         * python/py-utils.c (gdbpy_convert_exception): Take a const
10655         reference.
10656         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
10657         Use std::move.
10658         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
10659         Use std::move.
10660         * mi/mi-main.c (mi_print_exception): Take a const reference.
10661         * main.c (handle_command_errors): Take a const reference.
10662         * linespec.c (parse_linespec): Use std::move.
10663         * infcall.c (run_inferior_call): Use std::move.
10664         (call_function_by_hand_dummy): Use std::move.
10665         * exec.c (try_open_exec_file): Use std::move.
10666         * exceptions.h (exception_print, exception_fprintf)
10667         (exception_print_same): Update.
10668         * exceptions.c (print_exception, exception_print)
10669         (exception_fprintf, exception_print_same): Change parameters to
10670         const reference.
10671         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
10672         * common/new-op.c: Use std::move.
10673         * common/common-exceptions.h (struct gdb_exception): Add move
10674         constructor.
10675         (struct gdb_exception_error, struct gdb_exception_quit, struct
10676         gdb_quit_bad_alloc): Change constructor to move constructor.
10677         (throw_exception): Change parameter to rvalue reference.
10678         * common/common-exceptions.c (throw_exception): Take rvalue
10679         reference.
10680         * cli/cli-interp.c (safe_execute_command): Use std::move.
10681         * breakpoint.c (insert_bp_location, location_to_sals): Use
10682         std::move.
10683
10684 2019-04-25  Tom Tromey  <tromey@adacore.com>
10685
10686         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
10687         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
10688         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
10689         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
10690         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
10691         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
10692         guile/scm-value.c: Use unpack.
10693         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
10694         gdbscm_gdb_exception.
10695         (gdbscm_throw_gdb_exception): Likewise.
10696         (struct gdbscm_gdb_exception): New.
10697         (unpack): New function.
10698         (gdbscm_wrap): Use unpack.
10699
10700 2019-04-25  Tom Tromey  <tromey@adacore.com>
10701
10702         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
10703         (gdb_rl_callback_handler): Use std::move.
10704         * common/common-exceptions.h (struct gdb_exception): Add move
10705         assignment operator.
10706         (throw_exception_sjlj): Change "exception" to const reference.
10707         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
10708         (throw_exception_sjlj): Change "exception" to const reference.
10709
10710 2019-04-25  Tom Tromey  <tromey@adacore.com>
10711
10712         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
10713         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
10714         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
10715         Update.
10716         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
10717         Update.
10718         * mi/mi-interp.c (mi_interp::exec): Update.
10719         * linespec.c (parse_linespec): Update.
10720         * infcall.c (run_inferior_call): Update.
10721         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
10722         * guile/scm-symbol.c (gdbscm_lookup_symbol)
10723         (gdbscm_lookup_global_symbol): Update.
10724         * guile/scm-param.c (gdbscm_parameter_value): Update.
10725         * guile/scm-frame.c (gdbscm_frame_read_register)
10726         (gdbscm_frame_read_var): Update.
10727         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
10728         * exec.c (try_open_exec_file): Update.
10729         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
10730         (gdb_rl_callback_handler): Update.
10731         * common/common-exceptions.h (exception_none): Don't declare.
10732         * common/common-exceptions.c (exception_none): Don't define.
10733         (struct catcher) <exception>: Update.
10734         * cli/cli-interp.c (safe_execute_command): Update.
10735         * breakpoint.c (insert_bp_location, location_to_sals): Update.
10736
10737 2019-04-25  Ali Tamur  <tamur@google.com>
10738
10739         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
10740         (read_attribute_value): Likewise.
10741         (dwarf2_read_addr_index): Update comment.
10742         (read_str_index): Add DW_FORM_strx.
10743         (dwarf2_string_attr): Likewise.
10744         (dwarf2_const_value_attr): Likewise.
10745         (dump_die_shallow): Likewise.
10746         (dwarf2_fetch_constant_bytes): Likewise.
10747         (skip_form_bytes): Likewise.
10748         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
10749
10750 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
10751
10752         PR corefiles/11608
10753         PR corefiles/18187
10754         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
10755         OFFSET.  Verify if current mapping contains an ELF header.
10756         (linux_find_memory_regions_full): Adjust call to
10757         dump_mapping_p.
10758
10759 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
10760             Kang Li <kanglictf@gmail.com>
10761
10762         PR gdb/21600
10763
10764         * dwarf2-frame.c (read_initial_length): Be consistent about using
10765         unsigned representation of length.
10766         (decode_frame_entry_1): Likewise.  Check for wraparound of
10767         end pointer as well as buffer overflow.
10768
10769 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
10770
10771         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
10772         "vq".
10773
10774 2019-04-24  Tom Tromey  <tromey@adacore.com>
10775
10776         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
10777
10778 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
10779
10780         * s12z-tdep.c (s12z_unwind_pc): Delete.
10781         (s12z_unwind_sp): Delete.
10782         (s12z_gdbarch_init): Don't register deleted functions with
10783         gdbarch.
10784
10785 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
10786
10787         * rl78-tdep.c (rl78_unwind_sp): Delete.
10788         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
10789
10790 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
10791
10792         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
10793         (xstormy16_unwind_pc): Delete.
10794         (xstormy16_dummy_id): Delete.
10795         (xstormy16_gdbarch_init): Don't register deleted functions with
10796         gdbarch.
10797
10798 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
10799
10800         * vax-tdep.c (vax_unwind_pc): Delete.
10801         (vax_gdbarch_init): Don't register deleted function with gdbarch.
10802
10803 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
10804
10805         * v850-tdep.c (v850_unwind_sp): Delete.
10806         (v850_unwind_pc): Delete.
10807         (v850_dummy_id): Delete.
10808         (v850_gdbarch_init): Don't register deleted functions with
10809         gdbarch.
10810
10811 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
10812
10813         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
10814         (tilegx_unwind_pc): Delete.
10815         (tilegx_unwind_dummy_id): Delete.
10816         (tilegx_gdbarch_init): Don't register deleted functions with
10817         gdbarch.
10818
10819 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
10820
10821         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
10822         (tic6x_dummy_id): Delete.
10823         (tic6x_gdbarch_init): Don't register deleted functions with
10824         gdbarch.
10825
10826 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
10827
10828         * sparc-tdep.c (sparc_unwind_pc): Delete.
10829         (sparc32_gdbarch_init): Don't register deleted function with
10830         gdbarch.
10831
10832 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
10833
10834         * sh-tdep.c (sh_unwind_sp): Delete.
10835         (sh_unwind_pc): Delete.
10836         (sh_dummy_id): Delete.
10837         (sh_gdbarch_init): Don't register deleted functions with
10838         gdbarch.
10839
10840 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
10841
10842         * score-tdep.c (score_unwind_sp): Delete.
10843         (score_unwind_pc): Delete.
10844         (score_dummy_id): Delete.
10845         (score_gdbarch_init): Don't register deleted functions with
10846         gdbarch.
10847
10848 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
10849
10850         * rx-tdep.c (rx_unwind_pc): Delete.
10851         (rx_unwind_sp): Delete.
10852         (rx_dummy_id): Delete.
10853         (rx_gdbarch_init): Don't register deleted functions with
10854         gdbarch.  Update comment.
10855
10856 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
10857
10858         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
10859         (rs6000_dummy_id): Delete.
10860         (rs6000_gdbarch_init): Don't register deleted functions with
10861         gdbarch.
10862
10863 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
10864
10865         * or1k-tdep.c (or1k_dummy_id): Delete.
10866         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
10867
10868 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
10869
10870         * nios2-tdep.c (nios2_dummy_id): Delete.
10871         (nios2_unwind_sp): Delete.
10872         (nios2_gdbarch_init): Don't register deleted functions with
10873         gdbarch.
10874
10875 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
10876
10877         * nds32-tdep.c (nds32_dummy_id): Delete.
10878         (nds32_unwind_pc): Delete.
10879         (nds32_unwind_sp): Delete.
10880         (nds32_gdbarch_init): Don't register deleted functions with
10881         gdbarch.
10882
10883 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
10884
10885         * msp430-tdep.c (msp430_unwind_pc): Delete.
10886         (msp430_unwind_sp): Delete.
10887         (msp430_dummy_id): Delete.
10888         (msp430_gdbarch_init): Don't register deleted functions with
10889         gdbarch.
10890
10891 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
10892
10893         * moxie-tdep.c (moxie_unwind_sp): Delete.
10894         (moxie_unwind_pc): Delete.
10895         (moxie_dummy_id): Delete.
10896         (moxie_gdbarch_init): Don't register deleted functions with
10897         gdbarch.
10898
10899 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
10900
10901         * mn10300-tdep.c (mn10300_dummy_id): Delete.
10902         (mn10300_unwind_pc): Delete.
10903         (mn10300_unwind_sp): Delete.
10904         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
10905         mn10300_unwind_sp.
10906         (mn10300_frame_unwind_init): Don't register deleted functions with
10907         gdbarch.
10908
10909 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
10910
10911         * mep-tdep.c (mep_unwind_pc): Delete.
10912         (mep_unwind_sp): Delete.
10913         (mep_dummy_id): Delete.
10914         (mep_gdbarch_init): Don't register deleted functions with
10915         gdbarch.
10916
10917 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
10918
10919         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
10920         (m68hc11_unwind_sp): Delete.
10921         (m68hc11_gdbarch_init): Don't register deleted functions with
10922         gdbarch.
10923
10924 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
10925
10926         * m32r-tdep.c (m32r_unwind_sp): Delete.
10927         (m32r_unwind_pc): Delete.
10928         (m32r_dummy_id): Delete.
10929         (m32r_gdbarch_init): Don't register deleted functions with
10930         gdbarch.
10931
10932 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
10933
10934         * m32c-tdep.c (m32c_unwind_pc): Delete.
10935         (m32c_unwind_sp): Delete.
10936         (m32c_dummy_id): Delete.
10937         (m32c_gdbarch_init): Don't register deleted functions with
10938         gdbarch.
10939
10940 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
10941
10942         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
10943         (lm32_unwind_pc): Delete.
10944         (lm32_dummy_id): Delete.
10945         (lm32_gdbarch_init): Don't register deleted functions with
10946         gdbarch.
10947
10948 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
10949
10950         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
10951         (iq2000_unwind_pc): Delete.
10952         (iq2000_dummy_id): Delete.
10953         (iq2000_gdbarch_init): Don't register deleted functions with
10954         gdbarch.
10955
10956 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
10957
10958         * nds32-tdep.c (nds32_type_align): Delete.
10959         (nds32_push_dummy_call): Use type_align instead.
10960
10961 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
10962
10963         * arm-tdep.c (arm_type_align): Only handle vector override case.
10964         (arm_push_dummy_call): Use type_align.
10965         (arm_gdbarch_init): Register arm_type_align gdbarch function.
10966
10967 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
10968
10969         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
10970         case.
10971         (pass_on_stack): Use type_align.
10972         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
10973         function.
10974
10975 2019-04-23  Tom Tromey  <tromey@adacore.com>
10976
10977         * dwarf2read.c (line_header::file_name_at): Remove unused
10978         overload.
10979
10980 2019-04-23  Tom de Vries  <tdevries@suse.de>
10981
10982         PR gdb/24438
10983         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
10984         invocation.
10985
10986
10987 2019-03-27  Ali Tamur  <tamur@google.com>
10988
10989         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
10990         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
10991         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
10992         (dwarf_expr_context::get_addr_index): Likewise
10993         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
10994         (symbol_needs_eval_context::get_addr_index): Likewise
10995         (disassemble_dwarf_expression): Add DW_OP_addrx
10996         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
10997         (read_cutu_die_from_dwo): Update comment
10998         (skip_one_die): Add DW_FORM_addrx
10999         (read_attribute_value): Likewise
11000         (var_decode_location): Add DW_OP_addrx
11001         (dwarf2_const_value_attr): Add DW_FORM_addrx
11002         (dump_die_shallow): Likewise
11003         (dwarf2_fetch_constant_bytes): Likewise
11004         (decode_locdesc): Add DW_OP_addrx
11005         (skip_form_bytes): Add DW_FORM_addrx
11006
11007 2019-04-22  Ali Tamur  <tamur@google.com>
11008
11009         * MAINTAINERS (Write After Approval): Add self.
11010
11011 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
11012
11013         * solib-svr4.c (get_svr4_info): Add pspace parameter.
11014         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
11015         (open_symbol_file_object): Likewise.
11016         (svr4_default_sos): Add info parameter.
11017         (svr4_read_so_list): Likewise.
11018         (svr4_current_sos_direct): Adjust functions calls to pass down
11019         info.
11020         (svr4_current_sos_1): Add info parameter.
11021         (svr4_current_sos): Call get_svr4_info, pass info down to
11022         svr4_current_sos_1.
11023         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
11024         get_svr4_info.
11025         (svr4_in_dynsym_resolve_code): Pass current_program_space to
11026         get_svr4_info.
11027         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
11028         to get_svr4_info.
11029         (probes_table_remove_objfile_probes): Likewise.
11030         (register_solib_event_probe): Add info parameter.
11031         (solist_update_incremental): Pass info parameter down to
11032         svr4_read_so_list.
11033         (disable_probes_interface): Add info parameter.
11034         (svr4_handle_solib_event): Pass current_program_space to
11035         get_svr4_info.  Adjust disable_probes_interface cleanup.
11036         (svr4_create_probe_breakpoints): Add info parameter, pass it
11037         down to register_solib_event_probe.
11038         (svr4_create_solib_event_breakpoints): Add info parameter,
11039         pass it down to svr4_create_probe_breakpoints.
11040         (enable_break): Pass info down to
11041         svr4_create_solib_event_breakpoints.
11042         (svr4_solib_create_inferior_hook): Pass current_program_space to
11043         get_svr4_info.
11044         (svr4_clear_solib): Likewise.
11045
11046 2019-04-22  Pedro Alves  <palves@redhat.com>
11047
11048         * solib-svr4.c (svr4_free_objfile_observer): New.
11049         (probe_and_action::objfile): New field.
11050         (probes_table_htab_remove_objfile_probes)
11051         (probes_table_remove_objfile_probes): New functions.
11052         (register_solib_event_probe): Add 'objfile' parameter.  Store it
11053         in the new probe_and_action.  Don't store the probe in 'lookup'.
11054         (svr4_create_probe_breakpoints): Pass objfile to
11055         register_solib_event_probe.
11056         (_initialize_svr4_solib): Register a free_objfile observer.
11057
11058 2019-04-19  Tom Tromey  <tom@tromey.com>
11059
11060         * common/queue.h: Remove.
11061
11062 2019-04-19  Tom Tromey  <tom@tromey.com>
11063
11064         * event-loop.c: Don't include "common/queue.h".
11065
11066 2019-04-19  Tom Tromey  <tom@tromey.com>
11067
11068         * remote.c (remote_target): Use delete.
11069         * remote-notif.h: Include <list>, not "common/queue.h".
11070         (notif_client_p): Remove typedef.
11071         (remote_notif_state): Add constructor, destructor, initializer.
11072         <notif_queue>: Now a std::list.
11073         (remote_notif_state_xfree): Don't declare.
11074         * remote-notif.c (remote_notif_process, handle_notification)
11075         (remote_notif_state_allocate): Update.
11076         (~remote_notif_state): Rename from remote_notif_state_xfree.
11077
11078 2019-04-19  Tom Tromey  <tom@tromey.com>
11079
11080         * symfile.c (reread_symbols): Update.
11081         * objfiles.c (objfile_register_static_link)
11082         (objfile_lookup_static_link): Update
11083         (~objfile) Don't delete static_links.
11084         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
11085
11086 2019-04-19  Tom Tromey  <tom@tromey.com>
11087
11088         * type-stack.h (struct type_stack) <insert>: Constify string.
11089         * type-stack.c (type_stack::insert): Constify string.
11090         * gdbtypes.h (lookup_template_type): Update.
11091         (address_space_name_to_int): Update.
11092         * gdbtypes.c (address_space_name_to_int): Make space_identifier
11093         const.
11094         (lookup_template_type): Make name const.
11095         * c-exp.y: Update rules.
11096         (lex_one_token, classify_name, classify_inner_name)
11097         (c_print_token): Update.
11098         * p-exp.y: Update rules.
11099         (yylex): Update.
11100         * f-exp.y: Update rules.
11101         (yylex): Update.
11102         * d-exp.y: Update rules.
11103         (lex_one_token, classify_name, classify_inner_name): Update.
11104         * parse.c (write_dollar_variable, copy_name): Return std::string.
11105         * parser-defs.h (copy_name): Change return type.
11106         * m2-exp.y: Update rules.
11107         (yylex): Update.
11108         * go-exp.y (lex_one_token): Update.
11109         Update rules.
11110         (classify_unsafe_function, classify_packaged_name)
11111         (classify_name, yylex): Update.
11112
11113 2019-04-19  Sergei Trofimovich <siarheit@google.com>
11114
11115         * configure.ac: add --enable-source-highlight switch.
11116         * configure: Regenerate.
11117         * top.c (print_gdb_version): plumb --enable-source-highlight
11118         status to "show configuration".
11119
11120 2019-04-19  Tom Tromey  <tromey@adacore.com>
11121
11122         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
11123         Check ADA_TYPE_P.
11124         (empty_record, ada_template_to_fixed_record_type_1)
11125         (template_to_static_fixed_type)
11126         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
11127         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
11128         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
11129         macros.
11130
11131 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
11132
11133         PR symtab/24423:
11134         * source.c (print_source_lines_base): Advance "iter" when a
11135         control character is seen.
11136
11137 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11138
11139         * inferior.h (struct infcall_suspend_state_deleter):
11140         Catch exception in destructor to avoid crash.
11141
11142 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11143
11144         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
11145         close to the add_com "shell".
11146
11147 2019-04-18  Tom Tromey  <tromey@adacore.com>
11148
11149         * process-stratum-target.h (class process_stratum_target)
11150         <stratum>: Add "final".
11151
11152 2019-04-17  Tom Tromey  <tromey@adacore.com>
11153
11154         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
11155         against nullptr before use.
11156
11157 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
11158
11159         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
11160
11161 2019-04-17  Jim Wilson  <jimw@sifive.com>
11162             Andrew Burgess  <andrew.burgess@embecosm.com>
11163
11164         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
11165         code read might fail, assume 4-byte breakpoint in that case.
11166
11167 2019-04-15  Leszek Swirski  <leszeks@google.com>
11168
11169         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
11170         rather than a hand-rolled POD check when checking for forced MEMORY
11171         classification.
11172
11173 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
11174
11175         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
11176         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
11177         function.
11178         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
11179         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
11180         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
11181         declaration.
11182
11183 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
11184
11185         * aarch64-linux-nat.c
11186         (aarch64_linux_nat_target::thread_architecture): Add override.
11187         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
11188         each VQ.
11189
11190 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
11191
11192         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
11193
11194 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
11195
11196         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
11197         target types of size 96-bits, add some additional comments, and
11198         check that the builtin type we found was the correct size.
11199
11200 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
11201
11202         * utils.c (prompt_for_continue): Don't restore the styling at the
11203         end, as applied_style has the wrong value.  This fixes styling in
11204         long lists of file names that are interrupted by the "Continue?"
11205         prompt.
11206
11207 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
11208
11209         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
11210         * c-lang.c (c_language_defn): Likewise.
11211         (cplus_language_defn): Likewise.
11212         (asm_language_defn): Likewise.
11213         (minimal_language_defn): Likewise.
11214         * d-lang.c (d_language_defn): Likewise.
11215         * f-lang.c (f_language_defn): Likewise.
11216         * go-lang.c (go_language_defn): Likewise.
11217         * language.c (unknown_language_defn): Likewise.
11218         (auto_language_defn): Likewise.
11219         * language.h (struct language_defn): Remove la_magic field.
11220         (LANG_MAGIC): Delete.
11221         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
11222         * objc-lang.c (objc_language_defn): Likewise.
11223         * opencl-lang.c (opencl_language_defn): Likewise.
11224         * p-lang.c (pascal_language_defn): Likewise.
11225         * rust-lang.c (rust_language_defn): Likewise.
11226
11227 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
11228
11229         * riscv-tdep.c (riscv_type_align): New function.
11230         (riscv_type_alignment): Delete.
11231         (riscv_arg_location): Use 'type_align'.
11232         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
11233
11234 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
11235
11236         * gdbtypes.c (type_align): A struct with no non-static fields also
11237         has alignment of 1.
11238
11239 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
11240
11241         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
11242         component to 0.
11243         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
11244         member.
11245         (riscv_struct_info::analyse): New implementation using new
11246         analyse_inner member function.
11247         (riscv_struct_info::field_offset): New member function.
11248         (riscv_struct_info::m_offsets): New member variable.
11249         (riscv_struct_info::analyse_inner): New private member function,
11250         takes the old implementation of riscv_struct_info::analyse but
11251         extended to track field offsets.
11252         (riscv_call_arg_struct): Update the struct folding special cases
11253         to handle cases where empty C++ structs, which are non-zero
11254         length, are found.
11255         (riscv_arg_location): Initialise the length of each location, a
11256         non-zero length now indicates the location is in use.
11257         (riscv_push_dummy_call): Allow for the first location having a
11258         non-zero offset when setting up arguments.
11259         (riscv_return_value): Likewise, but for return values.
11260
11261 2019-04-11  Tom Tromey  <tromey@adacore.com>
11262
11263         * utils.c (internal_vproblem): Make "msg" const.
11264
11265 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
11266
11267         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
11268         * trad-frame.c (trad_frame_reset_saved_regs): New function.
11269         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
11270         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
11271
11272 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
11273
11274         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
11275         function.
11276         (fill_gregset): Call amd64_linux_collect_native_gregset instead
11277         of amd64_collect_native_gregset.
11278         (amd64_linux_nat_target::store_registers): Likewise.
11279
11280 2019-04-10  Tom Tromey  <tom@tromey.com>
11281
11282         * symtab.c (lookup_global_symbol_from_objfile)
11283         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
11284         * objfiles.h (class separate_debug_iterator): New.
11285         (class separate_debug_range): New.
11286         (struct objfile) <separate_debug_objfiles>: New method.
11287         (objfile_separate_debug_iterate): Don't declare.
11288         * objfiles.c (separate_debug_iterator::operator++): Rename from
11289         objfile_separate_debug_iterate.
11290         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
11291         iterator.
11292         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
11293         iterator.
11294
11295 2019-04-10  Tom Tromey  <tom@tromey.com>
11296
11297         * symfile.c (reread_symbols): Remove old comment.
11298         * objfiles.c (free_all_objfiles): Fix a typo.
11299
11300 2019-04-10  Tom Tromey  <tom@tromey.com>
11301
11302         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
11303         * minsyms.c (lookup_minimal_symbol): Use foreach.
11304         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
11305         (lookup_minimal_symbol_solib_trampoline): Likewise.
11306         * symfile.c (reread_symbols): Use foreach.
11307
11308 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
11309             Tom Tromey  <tromey@adacore.com>
11310
11311         PR rust/24414:
11312         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
11313         (rust_lex_int_test): Change "value" to be LONGEST.
11314         (rust_lex_tests): Add test for long integer literal.
11315
11316 2019-04-09  Tom Tromey  <tromey@adacore.com>
11317
11318         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
11319         to bool.
11320         (extended_remote_target::attach): Update.
11321         (remote_target::remote_notice_new_inferior): Update.
11322         (remote_target::add_current_inferior_and_thread): Update.
11323         * inferior.c (exit_inferior_1): Use "false".
11324         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
11325
11326 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
11327
11328         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
11329         the "start" command.
11330
11331 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
11332
11333         * python/py-inferior.c (infpy_thread_from_thread_handle):
11334         Adjust comments to reflect renaming of thread_from_thread_handle
11335         to thread_from_handle.  Adjust keywords.  Fix type error message.
11336         (inferior_object_methods): Add thread_from_handle.  Retain
11337         thread_from_thread_handle, but mark it as deprecated.
11338
11339 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
11340
11341         * gdbthread.h (find_thread_by_handle): Revise declaration.
11342         * thread.c (find_thread_by_handle): Likewise.  Adjust
11343         implementation too.
11344         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
11345         support for buffer objects as handles.
11346
11347 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
11348
11349         * python/py-infthread.c (thpy_thread_handle): New function.
11350         (thread_object_methods): Register thpy_thread_handle.
11351
11352 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
11353
11354         * gdbthread.h (thread_to_thread_handle): Declare.
11355         * thread.c (gdbtypes.h): Include.
11356         (thread_to_thread_handle): New function.
11357
11358         * target.h (struct target_ops): Add thread_info_to_thread_handle.
11359         (target_thread_info_to_thread_handle): Declare.
11360         * target.c (target_thread_info_to_thread_handle): New function.
11361         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
11362         * target-delegates.c: Regenerate.
11363
11364         * linux-thread-db.c (class thread_db_target): Add method
11365         thread_info_to_thread_handle.
11366         (thread_db_target::thread_info_to_thread_handle): Define.
11367         * remote.c (class remote_target): Add new method
11368         thread_info_to_thread_handle.
11369         (remote_target::thread_info_to_thread_handle): Define.
11370
11371 2019-04-08  Pedro Alves  <palves@redhat.com>
11372
11373         * common/common-exceptions.c (throw_exception): Don't create
11374         named object to throw; throw directly.
11375         (throw_it): Likewise.  Don't initialize gdb_exception::message
11376         here, with new; pass FMT and AP to the ctor instead.
11377         * common/common-exceptions.h: Include <string>.
11378         (gdb_exception::gdb_exception(enum return_reason, enum errors,
11379         const char *, va_list)): New ctor.  Use std::make_shared.
11380         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
11381         errors)): Delete.
11382         (gdb_exception_error::gdb_exception_error(enum errors, const char
11383         *, va_list)): New.
11384         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
11385         Add assertion.
11386         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
11387         errors)): Delete.
11388         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
11389         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
11390         Add assertion.
11391
11392 2019-04-08  Tom Tromey  <tom@tromey.com>
11393
11394         * valops.c (value_rtti_indirect_type): Replace throw_exception
11395         with throw.
11396         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
11397         with throw.
11398         * thread.c (thr_try_catch_cmd): Replace throw_exception with
11399         throw.
11400         * target.c (target_translate_tls_address): Replace throw_exception
11401         with throw.
11402         * stack.c (frame_apply_command_count): Replace throw_exception
11403         with throw.
11404         * solib-spu.c (append_ocl_sos): Replace throw_exception with
11405         throw.
11406         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
11407         with throw.
11408         * rs6000-tdep.c (rs6000_frame_cache)
11409         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
11410         * remote.c: Replace throw_exception with throw.
11411         * record-full.c (record_full_message, record_full_wait_1)
11412         (record_full_restore): Replace throw_exception with throw.
11413         * record-btrace.c:
11414         (get_thread_current_frame_id, record_btrace_start_replaying)
11415         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
11416         (cmd_record_btrace_start): Replace throw_exception with throw.
11417         * parse.c (parse_exp_in_context_1): Replace throw_exception with
11418         throw.
11419         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
11420         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
11421         * linespec.c:
11422         (find_linespec_symbols): Replace throw_exception with throw.
11423         * infrun.c (displaced_step_prepare, resume): Replace
11424         throw_exception with throw.
11425         * infcmd.c (post_create_inferior): Replace throw_exception with
11426         throw.
11427         * inf-loop.c (inferior_event_handler): Replace throw_exception
11428         with throw.
11429         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
11430         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
11431         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
11432         (get_prev_frame_always, get_frame_pc_if_available)
11433         (get_frame_address_in_block_if_available, get_frame_language):
11434         Replace throw_exception with throw.
11435         * frame-unwind.c (frame_unwind_try_unwinder): Replace
11436         throw_exception with throw.
11437         * eval.c (fetch_subexp_value, evaluate_var_value)
11438         (evaluate_funcall, evaluate_subexp_standard): Replace
11439         throw_exception with throw.
11440         * dwarf2loc.c (call_site_find_chain)
11441         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
11442         Replace throw_exception with throw.
11443         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
11444         with throw.
11445         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
11446         throw.
11447         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
11448         * completer.c (complete_line_internal): Replace throw_exception
11449         with throw.
11450         * compile/compile-object-run.c (compile_object_run): Replace
11451         throw_exception with throw.
11452         * cli/cli-script.c (process_next_line): Replace throw_exception
11453         with throw.
11454         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
11455         (btrace_enable, btrace_maint_update_pt_packets): Replace
11456         throw_exception with throw.
11457         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
11458         throw_exception with throw.
11459         * break-catch-throw.c (re_set_exception_catchpoint): Replace
11460         throw_exception with throw.
11461         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
11462         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
11463         * aarch64-tdep.c (aarch64_make_prologue_cache)
11464         (aarch64_make_stub_cache): Replace throw_exception with throw.
11465
11466 2019-04-08  Tom Tromey  <tom@tromey.com>
11467
11468         * common/common-exceptions.c (throw_exception): Rename from
11469         throw_exception_cxx.  Remove old copy.  Make argument const.
11470         (throw_it): Create and throw exception objects directly.
11471         * common/common-exceptions.h (throw_exception): Make argument
11472         const.
11473         (struct gdb_exception_error): Add constructor.
11474         (struct gdb_exception_quit): Add constructor.
11475
11476 2019-04-08  Tom Tromey  <tom@tromey.com>
11477
11478         * common/common-exceptions.h (exception_rethrow): Don't declare.
11479         (TRY_SJLJ): Update comment.
11480         (TRY, CATCH, END_CATCH): Remove.
11481         * common/common-exceptions.c (exception_rethrow): Remove.
11482
11483 2019-04-08  Tom Tromey  <tom@tromey.com>
11484
11485         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
11486         Remove.
11487         (gdb_exception_error): Rename from
11488         gdb_exception_RETURN_MASK_ERROR.
11489         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
11490         (gdb_quit_bad_alloc): Update.
11491         * aarch64-tdep.c: Update.
11492         * ada-lang.c: Update.
11493         * ada-typeprint.c: Update.
11494         * ada-valprint.c: Update.
11495         * amd64-tdep.c: Update.
11496         * arch-utils.c: Update.
11497         * break-catch-throw.c: Update.
11498         * breakpoint.c: Update.
11499         * btrace.c: Update.
11500         * c-varobj.c: Update.
11501         * cli/cli-cmds.c: Update.
11502         * cli/cli-interp.c: Update.
11503         * cli/cli-script.c: Update.
11504         * common/common-exceptions.c: Update.
11505         * common/new-op.c: Update.
11506         * common/selftest.c: Update.
11507         * compile/compile-c-symbols.c: Update.
11508         * compile/compile-cplus-symbols.c: Update.
11509         * compile/compile-object-load.c: Update.
11510         * compile/compile-object-run.c: Update.
11511         * completer.c: Update.
11512         * corelow.c: Update.
11513         * cp-abi.c: Update.
11514         * cp-support.c: Update.
11515         * cp-valprint.c: Update.
11516         * darwin-nat.c: Update.
11517         * disasm-selftests.c: Update.
11518         * dtrace-probe.c: Update.
11519         * dwarf-index-cache.c: Update.
11520         * dwarf-index-write.c: Update.
11521         * dwarf2-frame-tailcall.c: Update.
11522         * dwarf2-frame.c: Update.
11523         * dwarf2loc.c: Update.
11524         * dwarf2read.c: Update.
11525         * eval.c: Update.
11526         * event-loop.c: Update.
11527         * event-top.c: Update.
11528         * exec.c: Update.
11529         * f-valprint.c: Update.
11530         * fbsd-tdep.c: Update.
11531         * frame-unwind.c: Update.
11532         * frame.c: Update.
11533         * gdbtypes.c: Update.
11534         * gnu-v3-abi.c: Update.
11535         * guile/guile-internal.h: Update.
11536         * guile/scm-block.c: Update.
11537         * guile/scm-breakpoint.c: Update.
11538         * guile/scm-cmd.c: Update.
11539         * guile/scm-disasm.c: Update.
11540         * guile/scm-frame.c: Update.
11541         * guile/scm-lazy-string.c: Update.
11542         * guile/scm-math.c: Update.
11543         * guile/scm-param.c: Update.
11544         * guile/scm-ports.c: Update.
11545         * guile/scm-pretty-print.c: Update.
11546         * guile/scm-symbol.c: Update.
11547         * guile/scm-symtab.c: Update.
11548         * guile/scm-type.c: Update.
11549         * guile/scm-value.c: Update.
11550         * i386-linux-tdep.c: Update.
11551         * i386-tdep.c: Update.
11552         * inf-loop.c: Update.
11553         * infcall.c: Update.
11554         * infcmd.c: Update.
11555         * infrun.c: Update.
11556         * jit.c: Update.
11557         * language.c: Update.
11558         * linespec.c: Update.
11559         * linux-fork.c: Update.
11560         * linux-nat.c: Update.
11561         * linux-tdep.c: Update.
11562         * linux-thread-db.c: Update.
11563         * main.c: Update.
11564         * mi/mi-cmd-break.c: Update.
11565         * mi/mi-cmd-stack.c: Update.
11566         * mi/mi-interp.c: Update.
11567         * mi/mi-main.c: Update.
11568         * objc-lang.c: Update.
11569         * p-valprint.c: Update.
11570         * parse.c: Update.
11571         * ppc-linux-tdep.c: Update.
11572         * printcmd.c: Update.
11573         * python/py-arch.c: Update.
11574         * python/py-breakpoint.c: Update.
11575         * python/py-cmd.c: Update.
11576         * python/py-finishbreakpoint.c: Update.
11577         * python/py-frame.c: Update.
11578         * python/py-framefilter.c: Update.
11579         * python/py-gdb-readline.c: Update.
11580         * python/py-inferior.c: Update.
11581         * python/py-infthread.c: Update.
11582         * python/py-lazy-string.c: Update.
11583         * python/py-linetable.c: Update.
11584         * python/py-objfile.c: Update.
11585         * python/py-param.c: Update.
11586         * python/py-prettyprint.c: Update.
11587         * python/py-progspace.c: Update.
11588         * python/py-record-btrace.c: Update.
11589         * python/py-record.c: Update.
11590         * python/py-symbol.c: Update.
11591         * python/py-type.c: Update.
11592         * python/py-unwind.c: Update.
11593         * python/py-utils.c: Update.
11594         * python/py-value.c: Update.
11595         * python/python.c: Update.
11596         * record-btrace.c: Update.
11597         * record-full.c: Update.
11598         * remote-fileio.c: Update.
11599         * remote.c: Update.
11600         * riscv-tdep.c: Update.
11601         * rs6000-aix-tdep.c: Update.
11602         * rs6000-tdep.c: Update.
11603         * rust-exp.y: Update.
11604         * rust-lang.c: Update.
11605         * s390-tdep.c: Update.
11606         * selftest-arch.c: Update.
11607         * solib-dsbt.c: Update.
11608         * solib-frv.c: Update.
11609         * solib-spu.c: Update.
11610         * solib-svr4.c: Update.
11611         * solib.c: Update.
11612         * sparc64-linux-tdep.c: Update.
11613         * stack.c: Update.
11614         * symfile-mem.c: Update.
11615         * symmisc.c: Update.
11616         * target.c: Update.
11617         * thread.c: Update.
11618         * top.c: Update.
11619         * tracefile-tfile.c: Update.
11620         * tui/tui.c: Update.
11621         * typeprint.c: Update.
11622         * unittests/cli-utils-selftests.c: Update.
11623         * unittests/parse-connection-spec-selftests.c: Update.
11624         * valops.c: Update.
11625         * valprint.c: Update.
11626         * value.c: Update.
11627         * varobj.c: Update.
11628         * windows-nat.c: Update.
11629         * x86-linux-nat.c: Update.
11630         * xml-support.c: Update.
11631
11632 2019-04-08  Tom Tromey  <tom@tromey.com>
11633
11634         * xml-support.c: Use C++ exception handling.
11635         * x86-linux-nat.c: Use C++ exception handling.
11636         * windows-nat.c: Use C++ exception handling.
11637         * varobj.c: Use C++ exception handling.
11638         * value.c: Use C++ exception handling.
11639         * valprint.c: Use C++ exception handling.
11640         * valops.c: Use C++ exception handling.
11641         * unittests/parse-connection-spec-selftests.c: Use C++ exception
11642         handling.
11643         * unittests/cli-utils-selftests.c: Use C++ exception handling.
11644         * typeprint.c: Use C++ exception handling.
11645         * tui/tui.c: Use C++ exception handling.
11646         * tracefile-tfile.c: Use C++ exception handling.
11647         * top.c: Use C++ exception handling.
11648         * thread.c: Use C++ exception handling.
11649         * target.c: Use C++ exception handling.
11650         * symmisc.c: Use C++ exception handling.
11651         * symfile-mem.c: Use C++ exception handling.
11652         * stack.c: Use C++ exception handling.
11653         * sparc64-linux-tdep.c: Use C++ exception handling.
11654         * solib.c: Use C++ exception handling.
11655         * solib-svr4.c: Use C++ exception handling.
11656         * solib-spu.c: Use C++ exception handling.
11657         * solib-frv.c: Use C++ exception handling.
11658         * solib-dsbt.c: Use C++ exception handling.
11659         * selftest-arch.c: Use C++ exception handling.
11660         * s390-tdep.c: Use C++ exception handling.
11661         * rust-lang.c: Use C++ exception handling.
11662         * rust-exp.y: Use C++ exception handling.
11663         * rs6000-tdep.c: Use C++ exception handling.
11664         * rs6000-aix-tdep.c: Use C++ exception handling.
11665         * riscv-tdep.c: Use C++ exception handling.
11666         * remote.c: Use C++ exception handling.
11667         * remote-fileio.c: Use C++ exception handling.
11668         * record-full.c: Use C++ exception handling.
11669         * record-btrace.c: Use C++ exception handling.
11670         * python/python.c: Use C++ exception handling.
11671         * python/py-value.c: Use C++ exception handling.
11672         * python/py-utils.c: Use C++ exception handling.
11673         * python/py-unwind.c: Use C++ exception handling.
11674         * python/py-type.c: Use C++ exception handling.
11675         * python/py-symbol.c: Use C++ exception handling.
11676         * python/py-record.c: Use C++ exception handling.
11677         * python/py-record-btrace.c: Use C++ exception handling.
11678         * python/py-progspace.c: Use C++ exception handling.
11679         * python/py-prettyprint.c: Use C++ exception handling.
11680         * python/py-param.c: Use C++ exception handling.
11681         * python/py-objfile.c: Use C++ exception handling.
11682         * python/py-linetable.c: Use C++ exception handling.
11683         * python/py-lazy-string.c: Use C++ exception handling.
11684         * python/py-infthread.c: Use C++ exception handling.
11685         * python/py-inferior.c: Use C++ exception handling.
11686         * python/py-gdb-readline.c: Use C++ exception handling.
11687         * python/py-framefilter.c: Use C++ exception handling.
11688         * python/py-frame.c: Use C++ exception handling.
11689         * python/py-finishbreakpoint.c: Use C++ exception handling.
11690         * python/py-cmd.c: Use C++ exception handling.
11691         * python/py-breakpoint.c: Use C++ exception handling.
11692         * python/py-arch.c: Use C++ exception handling.
11693         * printcmd.c: Use C++ exception handling.
11694         * ppc-linux-tdep.c: Use C++ exception handling.
11695         * parse.c: Use C++ exception handling.
11696         * p-valprint.c: Use C++ exception handling.
11697         * objc-lang.c: Use C++ exception handling.
11698         * mi/mi-main.c: Use C++ exception handling.
11699         * mi/mi-interp.c: Use C++ exception handling.
11700         * mi/mi-cmd-stack.c: Use C++ exception handling.
11701         * mi/mi-cmd-break.c: Use C++ exception handling.
11702         * main.c: Use C++ exception handling.
11703         * linux-thread-db.c: Use C++ exception handling.
11704         * linux-tdep.c: Use C++ exception handling.
11705         * linux-nat.c: Use C++ exception handling.
11706         * linux-fork.c: Use C++ exception handling.
11707         * linespec.c: Use C++ exception handling.
11708         * language.c: Use C++ exception handling.
11709         * jit.c: Use C++ exception handling.
11710         * infrun.c: Use C++ exception handling.
11711         * infcmd.c: Use C++ exception handling.
11712         * infcall.c: Use C++ exception handling.
11713         * inf-loop.c: Use C++ exception handling.
11714         * i386-tdep.c: Use C++ exception handling.
11715         * i386-linux-tdep.c: Use C++ exception handling.
11716         * guile/scm-value.c: Use C++ exception handling.
11717         * guile/scm-type.c: Use C++ exception handling.
11718         * guile/scm-symtab.c: Use C++ exception handling.
11719         * guile/scm-symbol.c: Use C++ exception handling.
11720         * guile/scm-pretty-print.c: Use C++ exception handling.
11721         * guile/scm-ports.c: Use C++ exception handling.
11722         * guile/scm-param.c: Use C++ exception handling.
11723         * guile/scm-math.c: Use C++ exception handling.
11724         * guile/scm-lazy-string.c: Use C++ exception handling.
11725         * guile/scm-frame.c: Use C++ exception handling.
11726         * guile/scm-disasm.c: Use C++ exception handling.
11727         * guile/scm-cmd.c: Use C++ exception handling.
11728         * guile/scm-breakpoint.c: Use C++ exception handling.
11729         * guile/scm-block.c: Use C++ exception handling.
11730         * guile/guile-internal.h: Use C++ exception handling.
11731         * gnu-v3-abi.c: Use C++ exception handling.
11732         * gdbtypes.c: Use C++ exception handling.
11733         * frame.c: Use C++ exception handling.
11734         * frame-unwind.c: Use C++ exception handling.
11735         * fbsd-tdep.c: Use C++ exception handling.
11736         * f-valprint.c: Use C++ exception handling.
11737         * exec.c: Use C++ exception handling.
11738         * event-top.c: Use C++ exception handling.
11739         * event-loop.c: Use C++ exception handling.
11740         * eval.c: Use C++ exception handling.
11741         * dwarf2read.c: Use C++ exception handling.
11742         * dwarf2loc.c: Use C++ exception handling.
11743         * dwarf2-frame.c: Use C++ exception handling.
11744         * dwarf2-frame-tailcall.c: Use C++ exception handling.
11745         * dwarf-index-write.c: Use C++ exception handling.
11746         * dwarf-index-cache.c: Use C++ exception handling.
11747         * dtrace-probe.c: Use C++ exception handling.
11748         * disasm-selftests.c: Use C++ exception handling.
11749         * darwin-nat.c: Use C++ exception handling.
11750         * cp-valprint.c: Use C++ exception handling.
11751         * cp-support.c: Use C++ exception handling.
11752         * cp-abi.c: Use C++ exception handling.
11753         * corelow.c: Use C++ exception handling.
11754         * completer.c: Use C++ exception handling.
11755         * compile/compile-object-run.c: Use C++ exception handling.
11756         * compile/compile-object-load.c: Use C++ exception handling.
11757         * compile/compile-cplus-symbols.c: Use C++ exception handling.
11758         * compile/compile-c-symbols.c: Use C++ exception handling.
11759         * common/selftest.c: Use C++ exception handling.
11760         * common/new-op.c: Use C++ exception handling.
11761         * cli/cli-script.c: Use C++ exception handling.
11762         * cli/cli-interp.c: Use C++ exception handling.
11763         * cli/cli-cmds.c: Use C++ exception handling.
11764         * c-varobj.c: Use C++ exception handling.
11765         * btrace.c: Use C++ exception handling.
11766         * breakpoint.c: Use C++ exception handling.
11767         * break-catch-throw.c: Use C++ exception handling.
11768         * arch-utils.c: Use C++ exception handling.
11769         * amd64-tdep.c: Use C++ exception handling.
11770         * ada-valprint.c: Use C++ exception handling.
11771         * ada-typeprint.c: Use C++ exception handling.
11772         * ada-lang.c: Use C++ exception handling.
11773         * aarch64-tdep.c: Use C++ exception handling.
11774
11775 2019-04-08  Tom Tromey  <tom@tromey.com>
11776
11777         * xml-support.c (gdb_xml_parser::parse): Update.
11778         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
11779         * value.c (show_convenience): Update.
11780         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
11781         (test_parse_flags_qcs): Update.
11782         * thread.c (thr_try_catch_cmd): Update.
11783         * target.c (target_translate_tls_address): Update.
11784         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
11785         (info_frame_command_core, frame_apply_command_count): Update.
11786         * rust-exp.y (rust_lex_exception_test): Update.
11787         * riscv-tdep.c (riscv_print_one_register_info): Update.
11788         * remote.c (remote_target::enable_btrace): Update.
11789         * record-btrace.c (record_btrace_enable_warn): Update.
11790         * python/py-utils.c (gdbpy_convert_exception): Update.
11791         * printcmd.c (do_one_display, print_variable_and_value): Update.
11792         * mi/mi-main.c (mi_print_exception): Update.
11793         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
11794         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
11795         * linux-nat.c (linux_nat_target::attach): Update.
11796         * linux-fork.c (class scoped_switch_fork_info): Update.
11797         * infrun.c (displaced_step_prepare): Update.
11798         * infcall.c (call_function_by_hand_dummy): Update.
11799         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
11800         * gnu-v3-abi.c (print_one_vtable): Update.
11801         * frame.c (get_prev_frame_always): Update.
11802         * f-valprint.c (info_common_command_for_block): Update.
11803         * exec.c (try_open_exec_file): Update.
11804         * exceptions.c (print_exception, exception_print)
11805         (exception_fprintf, exception_print_same): Update.
11806         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
11807         * dwarf-index-cache.c (index_cache::store)
11808         (index_cache::lookup_gdb_index): Update.
11809         * darwin-nat.c (maybe_cache_shell): Update.
11810         * cp-valprint.c (cp_print_value_fields): Update.
11811         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
11812         (gcc_cplus_symbol_address): Update.
11813         * compile/compile-c-symbols.c (gcc_convert_symbol)
11814         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
11815         * common/selftest.c: Update.
11816         * common/common-exceptions.h (struct gdb_exception) <message>: Now
11817         a std::string.
11818         (exception_try_scope_entry, exception_try_scope_exit): Don't
11819         declare.
11820         (struct exception_try_scope): Remove.
11821         (TRY): Don't use exception_try_scope.
11822         (struct gdb_exception): Add constructor, operator=.
11823         <what>: New method.
11824         (struct gdb_exception_RETURN_MASK_ALL)
11825         (struct gdb_exception_RETURN_MASK_ERROR)
11826         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
11827         (struct gdb_quit_bad_alloc): Update.
11828         * common/common-exceptions.c (exception_none): Change
11829         initializer.
11830         (struct catcher) <state, exception>: Initialize inline.
11831         <prev>: Remove member.
11832         (current_catcher): Remove.
11833         (catchers): New global.
11834         (exceptions_state_mc_init): Simplify.
11835         (catcher_pop): Remove.
11836         (exceptions_state_mc, exceptions_state_mc_catch): Update.
11837         (try_scope_depth, exception_try_scope_entry)
11838         (exception_try_scope_exit): Remove.
11839         (throw_exception_sjlj): Update.
11840         (exception_messages, exception_messages_size): Remove.
11841         (throw_it): Simplify.
11842         (gdb_exception_sliced_copy): Remove.
11843         (throw_exception_cxx): Update.
11844         * cli/cli-script.c (script_from_file): Update.
11845         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
11846         Update.
11847         * ada-valprint.c (ada_val_print): Update.
11848         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
11849         (create_excep_cond_exprs): Update.
11850
11851 2019-04-08  Tom Tromey  <tom@tromey.com>
11852
11853         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
11854         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
11855         (TRY, CATCH, END_CATCH): Remove some definitions.
11856         * common/common-exceptions.c: Don't use GDB_XCPT.
11857         (catcher_list_size): Remove.
11858         (throw_exception, throw_it): Simplify.
11859
11860 2019-04-05  Tom Tromey  <tom@tromey.com>
11861
11862         Revert the header-sorting patch.
11863         * ft32-tdep.c: Revert.
11864         * frv-tdep.c: Revert.
11865         * frv-linux-tdep.c: Revert.
11866         * frame.c: Revert.
11867         * frame-unwind.c: Revert.
11868         * frame-base.c: Revert.
11869         * fork-child.c: Revert.
11870         * findvar.c: Revert.
11871         * findcmd.c: Revert.
11872         * filesystem.c: Revert.
11873         * filename-seen-cache.h: Revert.
11874         * filename-seen-cache.c: Revert.
11875         * fbsd-tdep.c: Revert.
11876         * fbsd-nat.h: Revert.
11877         * fbsd-nat.c: Revert.
11878         * f-valprint.c: Revert.
11879         * f-typeprint.c: Revert.
11880         * f-lang.c: Revert.
11881         * extension.h: Revert.
11882         * extension.c: Revert.
11883         * extension-priv.h: Revert.
11884         * expprint.c: Revert.
11885         * exec.h: Revert.
11886         * exec.c: Revert.
11887         * exceptions.c: Revert.
11888         * event-top.c: Revert.
11889         * event-loop.c: Revert.
11890         * eval.c: Revert.
11891         * elfread.c: Revert.
11892         * dwarf2read.h: Revert.
11893         * dwarf2read.c: Revert.
11894         * dwarf2loc.c: Revert.
11895         * dwarf2expr.h: Revert.
11896         * dwarf2expr.c: Revert.
11897         * dwarf2-frame.c: Revert.
11898         * dwarf2-frame-tailcall.c: Revert.
11899         * dwarf-index-write.h: Revert.
11900         * dwarf-index-write.c: Revert.
11901         * dwarf-index-common.c: Revert.
11902         * dwarf-index-cache.h: Revert.
11903         * dwarf-index-cache.c: Revert.
11904         * dummy-frame.c: Revert.
11905         * dtrace-probe.c: Revert.
11906         * disasm.h: Revert.
11907         * disasm.c: Revert.
11908         * disasm-selftests.c: Revert.
11909         * dictionary.c: Revert.
11910         * dicos-tdep.c: Revert.
11911         * demangle.c: Revert.
11912         * dcache.h: Revert.
11913         * dcache.c: Revert.
11914         * darwin-nat.h: Revert.
11915         * darwin-nat.c: Revert.
11916         * darwin-nat-info.c: Revert.
11917         * d-valprint.c: Revert.
11918         * d-namespace.c: Revert.
11919         * d-lang.c: Revert.
11920         * ctf.c: Revert.
11921         * csky-tdep.c: Revert.
11922         * csky-linux-tdep.c: Revert.
11923         * cris-tdep.c: Revert.
11924         * cris-linux-tdep.c: Revert.
11925         * cp-valprint.c: Revert.
11926         * cp-support.c: Revert.
11927         * cp-namespace.c: Revert.
11928         * cp-abi.c: Revert.
11929         * corelow.c: Revert.
11930         * corefile.c: Revert.
11931         * continuations.c: Revert.
11932         * completer.h: Revert.
11933         * completer.c: Revert.
11934         * complaints.c: Revert.
11935         * coffread.c: Revert.
11936         * coff-pe-read.c: Revert.
11937         * cli-out.h: Revert.
11938         * cli-out.c: Revert.
11939         * charset.c: Revert.
11940         * c-varobj.c: Revert.
11941         * c-valprint.c: Revert.
11942         * c-typeprint.c: Revert.
11943         * c-lang.c: Revert.
11944         * buildsym.c: Revert.
11945         * buildsym-legacy.c: Revert.
11946         * build-id.h: Revert.
11947         * build-id.c: Revert.
11948         * btrace.c: Revert.
11949         * bsd-uthread.c: Revert.
11950         * breakpoint.h: Revert.
11951         * breakpoint.c: Revert.
11952         * break-catch-throw.c: Revert.
11953         * break-catch-syscall.c: Revert.
11954         * break-catch-sig.c: Revert.
11955         * blockframe.c: Revert.
11956         * block.c: Revert.
11957         * bfin-tdep.c: Revert.
11958         * bfin-linux-tdep.c: Revert.
11959         * bfd-target.c: Revert.
11960         * bcache.c: Revert.
11961         * ax-general.c: Revert.
11962         * ax-gdb.h: Revert.
11963         * ax-gdb.c: Revert.
11964         * avr-tdep.c: Revert.
11965         * auxv.c: Revert.
11966         * auto-load.c: Revert.
11967         * arm-wince-tdep.c: Revert.
11968         * arm-tdep.c: Revert.
11969         * arm-symbian-tdep.c: Revert.
11970         * arm-pikeos-tdep.c: Revert.
11971         * arm-obsd-tdep.c: Revert.
11972         * arm-nbsd-tdep.c: Revert.
11973         * arm-nbsd-nat.c: Revert.
11974         * arm-linux-tdep.c: Revert.
11975         * arm-linux-nat.c: Revert.
11976         * arm-fbsd-tdep.c: Revert.
11977         * arm-fbsd-nat.c: Revert.
11978         * arm-bsd-tdep.c: Revert.
11979         * arch-utils.c: Revert.
11980         * arc-tdep.c: Revert.
11981         * arc-newlib-tdep.c: Revert.
11982         * annotate.h: Revert.
11983         * annotate.c: Revert.
11984         * amd64-windows-tdep.c: Revert.
11985         * amd64-windows-nat.c: Revert.
11986         * amd64-tdep.c: Revert.
11987         * amd64-sol2-tdep.c: Revert.
11988         * amd64-obsd-tdep.c: Revert.
11989         * amd64-obsd-nat.c: Revert.
11990         * amd64-nbsd-tdep.c: Revert.
11991         * amd64-nbsd-nat.c: Revert.
11992         * amd64-nat.c: Revert.
11993         * amd64-linux-tdep.c: Revert.
11994         * amd64-linux-nat.c: Revert.
11995         * amd64-fbsd-tdep.c: Revert.
11996         * amd64-fbsd-nat.c: Revert.
11997         * amd64-dicos-tdep.c: Revert.
11998         * amd64-darwin-tdep.c: Revert.
11999         * amd64-bsd-nat.c: Revert.
12000         * alpha-tdep.c: Revert.
12001         * alpha-obsd-tdep.c: Revert.
12002         * alpha-nbsd-tdep.c: Revert.
12003         * alpha-mdebug-tdep.c: Revert.
12004         * alpha-linux-tdep.c: Revert.
12005         * alpha-linux-nat.c: Revert.
12006         * alpha-bsd-tdep.c: Revert.
12007         * alpha-bsd-nat.c: Revert.
12008         * aix-thread.c: Revert.
12009         * agent.c: Revert.
12010         * addrmap.c: Revert.
12011         * ada-varobj.c: Revert.
12012         * ada-valprint.c: Revert.
12013         * ada-typeprint.c: Revert.
12014         * ada-tasks.c: Revert.
12015         * ada-lang.c: Revert.
12016         * aarch64-tdep.c: Revert.
12017         * aarch64-ravenscar-thread.c: Revert.
12018         * aarch64-newlib-tdep.c: Revert.
12019         * aarch64-linux-tdep.c: Revert.
12020         * aarch64-linux-nat.c: Revert.
12021         * aarch64-fbsd-tdep.c: Revert.
12022         * aarch64-fbsd-nat.c: Revert.
12023         * aarch32-linux-nat.c: Revert.
12024
12025 2019-04-05  Tom Tromey  <tom@tromey.com>
12026
12027         * ft32-tdep.c: Sort headers.
12028         * frv-tdep.c: Sort headers.
12029         * frv-linux-tdep.c: Sort headers.
12030         * frame.c: Sort headers.
12031         * frame-unwind.c: Sort headers.
12032         * frame-base.c: Sort headers.
12033         * fork-child.c: Sort headers.
12034         * findvar.c: Sort headers.
12035         * findcmd.c: Sort headers.
12036         * filesystem.c: Sort headers.
12037         * filename-seen-cache.h: Sort headers.
12038         * filename-seen-cache.c: Sort headers.
12039         * fbsd-tdep.c: Sort headers.
12040         * fbsd-nat.h: Sort headers.
12041         * fbsd-nat.c: Sort headers.
12042         * f-valprint.c: Sort headers.
12043         * f-typeprint.c: Sort headers.
12044         * f-lang.c: Sort headers.
12045         * extension.h: Sort headers.
12046         * extension.c: Sort headers.
12047         * extension-priv.h: Sort headers.
12048         * expprint.c: Sort headers.
12049         * exec.h: Sort headers.
12050         * exec.c: Sort headers.
12051         * exceptions.c: Sort headers.
12052         * event-top.c: Sort headers.
12053         * event-loop.c: Sort headers.
12054         * eval.c: Sort headers.
12055         * elfread.c: Sort headers.
12056         * dwarf2read.h: Sort headers.
12057         * dwarf2read.c: Sort headers.
12058         * dwarf2loc.c: Sort headers.
12059         * dwarf2expr.h: Sort headers.
12060         * dwarf2expr.c: Sort headers.
12061         * dwarf2-frame.c: Sort headers.
12062         * dwarf2-frame-tailcall.c: Sort headers.
12063         * dwarf-index-write.h: Sort headers.
12064         * dwarf-index-write.c: Sort headers.
12065         * dwarf-index-common.c: Sort headers.
12066         * dwarf-index-cache.h: Sort headers.
12067         * dwarf-index-cache.c: Sort headers.
12068         * dummy-frame.c: Sort headers.
12069         * dtrace-probe.c: Sort headers.
12070         * disasm.h: Sort headers.
12071         * disasm.c: Sort headers.
12072         * disasm-selftests.c: Sort headers.
12073         * dictionary.c: Sort headers.
12074         * dicos-tdep.c: Sort headers.
12075         * demangle.c: Sort headers.
12076         * dcache.h: Sort headers.
12077         * dcache.c: Sort headers.
12078         * darwin-nat.h: Sort headers.
12079         * darwin-nat.c: Sort headers.
12080         * darwin-nat-info.c: Sort headers.
12081         * d-valprint.c: Sort headers.
12082         * d-namespace.c: Sort headers.
12083         * d-lang.c: Sort headers.
12084         * ctf.c: Sort headers.
12085         * csky-tdep.c: Sort headers.
12086         * csky-linux-tdep.c: Sort headers.
12087         * cris-tdep.c: Sort headers.
12088         * cris-linux-tdep.c: Sort headers.
12089         * cp-valprint.c: Sort headers.
12090         * cp-support.c: Sort headers.
12091         * cp-namespace.c: Sort headers.
12092         * cp-abi.c: Sort headers.
12093         * corelow.c: Sort headers.
12094         * corefile.c: Sort headers.
12095         * continuations.c: Sort headers.
12096         * completer.h: Sort headers.
12097         * completer.c: Sort headers.
12098         * complaints.c: Sort headers.
12099         * coffread.c: Sort headers.
12100         * coff-pe-read.c: Sort headers.
12101         * cli-out.h: Sort headers.
12102         * cli-out.c: Sort headers.
12103         * charset.c: Sort headers.
12104         * c-varobj.c: Sort headers.
12105         * c-valprint.c: Sort headers.
12106         * c-typeprint.c: Sort headers.
12107         * c-lang.c: Sort headers.
12108         * buildsym.c: Sort headers.
12109         * buildsym-legacy.c: Sort headers.
12110         * build-id.h: Sort headers.
12111         * build-id.c: Sort headers.
12112         * btrace.c: Sort headers.
12113         * bsd-uthread.c: Sort headers.
12114         * breakpoint.h: Sort headers.
12115         * breakpoint.c: Sort headers.
12116         * break-catch-throw.c: Sort headers.
12117         * break-catch-syscall.c: Sort headers.
12118         * break-catch-sig.c: Sort headers.
12119         * blockframe.c: Sort headers.
12120         * block.c: Sort headers.
12121         * bfin-tdep.c: Sort headers.
12122         * bfin-linux-tdep.c: Sort headers.
12123         * bfd-target.c: Sort headers.
12124         * bcache.c: Sort headers.
12125         * ax-general.c: Sort headers.
12126         * ax-gdb.h: Sort headers.
12127         * ax-gdb.c: Sort headers.
12128         * avr-tdep.c: Sort headers.
12129         * auxv.c: Sort headers.
12130         * auto-load.c: Sort headers.
12131         * arm-wince-tdep.c: Sort headers.
12132         * arm-tdep.c: Sort headers.
12133         * arm-symbian-tdep.c: Sort headers.
12134         * arm-pikeos-tdep.c: Sort headers.
12135         * arm-obsd-tdep.c: Sort headers.
12136         * arm-nbsd-tdep.c: Sort headers.
12137         * arm-nbsd-nat.c: Sort headers.
12138         * arm-linux-tdep.c: Sort headers.
12139         * arm-linux-nat.c: Sort headers.
12140         * arm-fbsd-tdep.c: Sort headers.
12141         * arm-fbsd-nat.c: Sort headers.
12142         * arm-bsd-tdep.c: Sort headers.
12143         * arch-utils.c: Sort headers.
12144         * arc-tdep.c: Sort headers.
12145         * arc-newlib-tdep.c: Sort headers.
12146         * annotate.h: Sort headers.
12147         * annotate.c: Sort headers.
12148         * amd64-windows-tdep.c: Sort headers.
12149         * amd64-windows-nat.c: Sort headers.
12150         * amd64-tdep.c: Sort headers.
12151         * amd64-sol2-tdep.c: Sort headers.
12152         * amd64-obsd-tdep.c: Sort headers.
12153         * amd64-obsd-nat.c: Sort headers.
12154         * amd64-nbsd-tdep.c: Sort headers.
12155         * amd64-nbsd-nat.c: Sort headers.
12156         * amd64-nat.c: Sort headers.
12157         * amd64-linux-tdep.c: Sort headers.
12158         * amd64-linux-nat.c: Sort headers.
12159         * amd64-fbsd-tdep.c: Sort headers.
12160         * amd64-fbsd-nat.c: Sort headers.
12161         * amd64-dicos-tdep.c: Sort headers.
12162         * amd64-darwin-tdep.c: Sort headers.
12163         * amd64-bsd-nat.c: Sort headers.
12164         * alpha-tdep.c: Sort headers.
12165         * alpha-obsd-tdep.c: Sort headers.
12166         * alpha-nbsd-tdep.c: Sort headers.
12167         * alpha-mdebug-tdep.c: Sort headers.
12168         * alpha-linux-tdep.c: Sort headers.
12169         * alpha-linux-nat.c: Sort headers.
12170         * alpha-bsd-tdep.c: Sort headers.
12171         * alpha-bsd-nat.c: Sort headers.
12172         * aix-thread.c: Sort headers.
12173         * agent.c: Sort headers.
12174         * addrmap.c: Sort headers.
12175         * ada-varobj.c: Sort headers.
12176         * ada-valprint.c: Sort headers.
12177         * ada-typeprint.c: Sort headers.
12178         * ada-tasks.c: Sort headers.
12179         * ada-lang.c: Sort headers.
12180         * aarch64-tdep.c: Sort headers.
12181         * aarch64-ravenscar-thread.c: Sort headers.
12182         * aarch64-newlib-tdep.c: Sort headers.
12183         * aarch64-linux-tdep.c: Sort headers.
12184         * aarch64-linux-nat.c: Sort headers.
12185         * aarch64-fbsd-tdep.c: Sort headers.
12186         * aarch64-fbsd-nat.c: Sort headers.
12187         * aarch32-linux-nat.c: Sort headers.
12188
12189 2019-04-04  Tom Tromey  <tom@tromey.com>
12190
12191         * varobj.c (varobj_create): Update.
12192         * rust-exp.y (struct rust_parser) <update_innermost_block,
12193         lookup_symbol>: New methods.
12194         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
12195         Rename.
12196         (rust_parser::rust_lookup_type)
12197         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
12198         * printcmd.c (display_command, do_one_display): Update.
12199         * parser-defs.h (struct parser_state) <parser_state>: Add
12200         "tracker" parameter.
12201         (block_tracker): New member.
12202         (class innermost_block_tracker) <innermost_block_tracker>: Add
12203         "types" parameter.
12204         <reset>: Remove method.
12205         (innermost_block): Don't declare.
12206         (null_post_parser): Update.
12207         * parse.c (innermost_block): Remove global.
12208         (write_dollar_variable): Update.
12209         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
12210         Remove "tracker_types" parameter.
12211         (parse_expression): Add "tracker" parameter.
12212         (parse_expression_for_completion): Update.
12213         (null_post_parser): Add "tracker" parameter.
12214         * p-exp.y: Update rules.
12215         * m2-exp.y: Update rules.
12216         * language.h (struct language_defn) <la_post_parser>: Add
12217         "tracker" parameter.
12218         * go-exp.y: Update rules.
12219         * f-exp.y: Update rules.
12220         * expression.h (parse_expression, parse_exp_1): Add "tracker"
12221         parameter.
12222         * d-exp.y: Update rules.
12223         * c-exp.y: Update rules.
12224         * breakpoint.c (set_breakpoint_condition): Create an
12225         innermost_block_tracker.
12226         (watch_command_1): Likewise.
12227         * ada-lang.c (resolve): Add "tracker" parameter.
12228         (resolve_subexp): Likewise.
12229         * ada-exp.y (write_var_from_sym): Update.
12230
12231 2019-04-04  Tom Tromey  <tom@tromey.com>
12232
12233         * type-stack.h: New file.
12234         * type-stack.c: New file.
12235         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
12236         type-stack.h.
12237         (insert_into_type_stack, insert_type, push_type, push_type_int)
12238         (insert_type_address_space, pop_type, pop_type_int)
12239         (pop_typelist, pop_type_stack, append_type_stack)
12240         (push_type_stack, get_type_stack, push_typelist)
12241         (follow_type_instance_flags, follow_types): Don't declare.
12242         * parse.c (type_stack): Remove global.
12243         (parse_exp_in_context): Update.
12244         (insert_into_type_stack, insert_type, push_type, push_type_int)
12245         (insert_type_address_space, pop_type, pop_type_int)
12246         (pop_typelist, pop_type_stack, append_type_stack)
12247         (push_type_stack, get_type_stack, push_typelist)
12248         (follow_type_instance_flags, follow_types): Remove (moved to
12249         type-stack.c).
12250         * f-exp.y (type_stack): New global.
12251         Update rules.
12252         (push_kind_type, f_parse): Update.
12253         * d-exp.y (type_stack): New global.
12254         Update rules.
12255         (d_parse): Update.
12256         * c-exp.y (struct c_parse_state) <type_stack>: New member.
12257         Update rules.
12258         * Makefile.in (COMMON_SFILES): Add type-stack.c.
12259         (HFILES_NO_SRCDIR): Add type-stack.h.
12260
12261 2019-04-04  Tom Tromey  <tom@tromey.com>
12262
12263         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
12264         (rust_parser::convert_ast_to_expression, rust_parse)
12265         (rust_lex_test_completion, rust_lex_tests): Update.
12266         * parser-defs.h (struct expr_completion_state): New.
12267         (struct parser_state) <parser_state>: Add completion parameter.
12268         <mark_struct_expression, mark_completion_tag>: New methods.
12269         <parse_completion, m_completion_state>: New members.
12270         (prefixify_expression, null_post_parser): Update.
12271         (mark_struct_expression, mark_completion_tag): Don't declare.
12272         * parse.c (parse_completion, expout_last_struct)
12273         (expout_tag_completion_type, expout_completion_name): Remove
12274         globals.
12275         (parser_state::mark_struct_expression)
12276         (parser_state::mark_completion_tag): Now methods.
12277         (prefixify_expression): Add last_struct parameter.
12278         (prefixify_subexp): Likewise.
12279         (parse_exp_1): Update.
12280         (parse_exp_in_context): Add cstate parameter.  Update.
12281         (parse_expression_for_completion): Create an
12282         expr_completion_state.
12283         (null_post_parser): Add "completion" parameter.
12284         * p-exp.y: Update rules.
12285         (yylex): Update.
12286         * language.h (struct language_defn) <la_post_parser>: Add
12287         "completing" parameter.
12288         * go-exp.y: Update rules.
12289         (lex_one_token): Update.
12290         * expression.h (parse_completion): Don't declare.
12291         * d-exp.y: Update rules.
12292         (lex_one_token): Update rules.
12293         * c-exp.y: Update rules.
12294         (lex_one_token): Update.
12295         * ada-lang.c (resolve): Add "parse_completion" parameter.
12296         (resolve_subexp): Likewise.
12297         (ada_resolve_function): Likewise.
12298
12299 2019-04-04  Tom Tromey  <tom@tromey.com>
12300
12301         * parser-defs.h (struct parser_state) <start_arglist,
12302         end_arglist>: New methods.
12303         <arglist_len, m_funcall_chain>: New members.
12304         (arglist_len, start_arglist, end_arglist): Don't declare.
12305         * parse.c (arglist_len, funcall_chain): Remove global.
12306         (start_arglist, end_arglist): Remove functions.
12307         (parse_exp_in_context): Update.
12308         * p-exp.y: Update rules.
12309         * m2-exp.y: Update rules.
12310         * go-exp.y: Update rules.
12311         * f-exp.y: Update rules.
12312         * d-exp.y: Update rules.
12313         * c-exp.y: Update rules.
12314
12315 2019-04-04  Tom Tromey  <tom@tromey.com>
12316
12317         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
12318         lex_operator, push_back>: New methods.
12319         Update all rules.
12320         (rust_parser::lex_hex, lex_escape): Rename and update.
12321         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
12322         (rust_parser::lex_operator): Rename and update.
12323         (rust_parser::lex_number, rustyylex, rustyyerror)
12324         (rust_lex_test_init, rust_lex_test_sequence)
12325         (rust_lex_test_push_back, rust_lex_tests): Update.
12326         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
12327         parameter.
12328         <lexptr, prev_lexptr>: New members.
12329         (lexptr, prev_lexptr): Don't declare.
12330         * parse.c (lexptr, prev_lexptr): Remove globals.
12331         (parse_exp_in_context): Update.
12332         * p-exp.y (yylex, yyerror): Update.
12333         * m2-exp.y (parse_number, yylex, yyerror): Update.
12334         * go-exp.y (lex_one_token, yyerror): Update.
12335         * f-exp.y (match_string_literal, yylex, yyerror): Update.
12336         * d-exp.y (lex_one_token, yyerror): Update.
12337         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
12338         (lex_one_token, yyerror): Update.
12339         * ada-lex.l (YY_INPUT): Update.
12340         (rewind_to_char): Update.
12341         * ada-exp.y (yyerror): Update.
12342
12343 2019-04-04  Tom Tromey  <tom@tromey.com>
12344
12345         * rust-exp.y (rustyylex, rust_lex_tests): Update.
12346         * parser-defs.h (struct parser_state) <parser_state>: Add new
12347         parameter.
12348         <comma_terminates>: New member.
12349         (comma_terminates): Don't declare global.
12350         * parse.c (comma_terminates): Remove global.
12351         (parse_exp_in_context): Update.
12352         * p-exp.y (yylex): Update.
12353         * m2-exp.y (yylex): Update.
12354         * go-exp.y (lex_one_token): Update.
12355         * f-exp.y (yylex): Update.
12356         * d-exp.y (lex_one_token): Update.
12357         * c-exp.y (lex_one_token): Update.
12358         * ada-lex.l: Update.
12359
12360 2019-04-04  Tom Tromey  <tom@tromey.com>
12361
12362         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
12363         (rustyylex, rust_lex_test_init, rust_lex_test_one)
12364         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
12365         * parser-defs.h (paren_depth): Don't declare.
12366         * parse.c (paren_depth): Remove global.
12367         (parse_exp_in_context): Update.
12368         * p-exp.y (paren_depth): New global.
12369         (pascal_parse): Initialize it.
12370         * m2-exp.y (paren_depth): New global.
12371         (m2_parse): Initialize it.
12372         * go-exp.y (paren_depth): New global.
12373         (go_parse): Initialize it.
12374         * f-exp.y (paren_depth): New global.
12375         (f_parse): Initialize it.
12376         * d-exp.y (paren_depth): New global.
12377         (d_parse): Initialize it.
12378         * c-exp.y (paren_depth): New global.
12379         (c_parse): Initialize it.
12380         * ada-lex.l (paren_depth): New global.
12381         (lexer_init): Initialize it.
12382
12383 2019-04-04  Tom Tromey  <tom@tromey.com>
12384
12385         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
12386         (rust_parser::convert_ast_to_type)
12387         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
12388         * parser-defs.h (struct parser_state) <parser_state>: Add
12389         parameters.  Initialize new members.
12390         <expression_context_block, expression_context_pc>: New members.
12391         * parse.c (expression_context_block, expression_context_pc):
12392         Remove globals.
12393         (parse_exp_in_context): Update.
12394         * p-exp.y: Update all rules.
12395         (yylex): Update.
12396         * m2-exp.y: Update all rules.
12397         (yylex): Update.
12398         * go-exp.y (yylex): Update.
12399         * f-exp.y (yylex): Update.
12400         * d-exp.y: Update all rules.
12401         (yylex): Update.
12402         * c-exp.y: Update all rules.
12403         (lex_one_token, classify_name, yylex, c_parse): Update.
12404         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
12405
12406 2019-04-04  Tom Tromey  <tom@tromey.com>
12407
12408         * gdbarch.h, gdbarch.c: Rebuild.
12409         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
12410         * stap-probe.h:
12411         (struct stap_parse_info): Replace "parser_state" with
12412         "expr_builder".
12413         * parser-defs.h (struct expr_builder): Rename from "parser_state".
12414         (parser_state): New class.
12415         * parse.c (expr_builder): Rename.
12416         (expr_builder::release): Rename.
12417         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
12418         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
12419         (write_exp_elt_longcst, write_exp_elt_floatcst)
12420         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
12421         (write_exp_string_vector, write_exp_bitstring)
12422         (write_exp_msymbol, mark_struct_expression)
12423         (write_dollar_variable)
12424         (insert_type_address_space, increase_expout_size): Replace
12425         "parser_state" with "expr_builder".
12426         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
12427         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
12428         "parser_state" with "expr_builder".
12429
12430 2019-04-04  Tom Tromey  <tom@tromey.com>
12431
12432         * rust-exp.y: Replace "parse_language" with method call.
12433         * p-exp.y:
12434         (yylex): Replace "parse_language" with method call.
12435         * m2-exp.y:
12436         (yylex): Replace "parse_language" with method call.
12437         * go-exp.y (classify_name): Replace "parse_language" with method
12438         call.
12439         * f-exp.y (yylex): Replace "parse_language" with method call.
12440         * d-exp.y (lex_one_token): Replace "parse_language" with method
12441         call.
12442         * c-exp.y:
12443         (lex_one_token, classify_name, yylex): Replace "parse_language"
12444         with method call.
12445         * ada-exp.y (find_primitive_type, type_char)
12446         (type_system_address): Replace "parse_language" with method call.
12447
12448 2019-04-04  Tom Tromey  <tom@tromey.com>
12449
12450         * rust-exp.y: Replace "parse_gdbarch" with method call.
12451         * parse.c (write_dollar_variable, insert_type_address_space):
12452         Replace "parse_gdbarch" with method call.
12453         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
12454         call.
12455         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
12456         call.
12457         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
12458         "parse_gdbarch" with method call.
12459         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
12460         with method call.
12461         * f-exp.y (parse_type, parse_f_type, yylex): Replace
12462         "parse_gdbarch" with method call.
12463         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
12464         "parse_gdbarch" with method call.
12465         * c-exp.y (parse_type, parse_number, classify_name): Replace
12466         "parse_gdbarch" with method call.
12467         * ada-lex.l: Replace "parse_gdbarch" with method call.
12468         * ada-exp.y (parse_type, find_primitive_type, type_char)
12469         (type_system_address): Replace "parse_gdbarch" with method call.
12470
12471 2019-04-04  Tom Tromey  <tom@tromey.com>
12472
12473         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
12474         * stap-probe.c (stap_parse_argument): Update.
12475         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
12476         initial_size parameter.
12477         * rust-exp.y (rust_lex_tests): Update.
12478         * parse.c (parser_state): Update.
12479         (parse_exp_in_context): Update.
12480         * parser-defs.h (struct parser_state) <parser_state>: Remove
12481         "initial_size" parameter.
12482
12483 2019-04-04  Tom Tromey  <tom@tromey.com>
12484
12485         * parser-defs.h (increase_expout_size): Don't declare.
12486         * parse.c (increase_expout_size): Now static.
12487
12488 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
12489
12490         * gnu-nat.c (gnu_nat_target::wait): Fix
12491         target_waitstatus_to_string call.
12492
12493 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
12494
12495         * eval.c (evaluate_subexp_standard): Handle internal functions
12496         during Fortran function call handling.
12497
12498 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
12499
12500         * NEWS: Mention new internal functions.
12501         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
12502         (read_base_type): Use dwarf2_init_complex_target_type.
12503         * value.c (creal_internal_fn): New function.
12504         (cimag_internal_fn): New function.
12505         (_initialize_values): Register new internal functions.
12506
12507 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12508
12509         * infrun.c (stop_all_threads): If debug_infrun, always
12510         trace the wait status after wait_one, using
12511         target_waitstatus_to_string and target_pid_to_str.
12512         (handle_inferior_event): Replace various trace of
12513         wait status kind by a single trace.
12514         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
12515         wait status kind image by target_waitstatus_to_string.
12516         * target/waitstatus.c (target_waitstatus_to_string): Fix
12517         obsolete comment.
12518
12519 2019-04-01  Tom Tromey  <tromey@adacore.com>
12520
12521         PR symtab/23331:
12522         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
12523
12524 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
12525             Pedro Alves  <palves@redhat.com>
12526
12527         * top.c (quit_force): Call 'finalize_values'.
12528         * value.c (finalize_values): New function.
12529         * value.h (finalize_values): Declare.
12530
12531 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
12532
12533         * NEWS: Announce $_gdb_major and $_gdb_minor.
12534
12535         * top.c (init_gdb_version_vars): New function.
12536         (gdb_init): Call init_gdb_version_vars.
12537
12538 2019-03-29  Tom Tromey  <tromey@adacore.com>
12539
12540         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
12541         help text.  Remove dead code.
12542
12543 2019-03-29  Keith Seitz  <keiths@redhat.com>
12544
12545         From Siddhesh Poyarekar:
12546         * f-lang.h (f77_get_upperbound): Return LONGEST.
12547         (f77_get_lowerbound): Likewise.
12548         * f-typeprint.c (f_type_print_varspec_suffix): Expand
12549         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
12550         print them.
12551         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
12552         plongest to format print it.
12553         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
12554         (f77_get_upperbound): Likewise.
12555         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
12556         LOWER_BOUND to LONGEST.
12557         (f77_create_arrayprint_offset_tbl): Likewise.
12558
12559 2019-03-29  Keith Seitz  <keiths@redhat.com>
12560
12561         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
12562         %s/pulongest for TYPE_LENGTH instead of %d in format
12563         strings.
12564         * ada-typerint.c (ada_print_type): Likewise.
12565         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
12566         * compile/compile-c-support.c (generate_register_struct): Likewise.
12567         * gdbtypes.c (recursive_dump_type): Likewise.
12568         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
12569         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
12570         instead of %d in format strings.
12571         * riscv-tdep.c (riscv_type_alignment): Cast second argument
12572         to std::min to ULONGEST.
12573         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
12574         instead of %d in format strings.
12575         * tracepoint.c (info_scope_command): Likewise.
12576         * typeprint.c (print_offset_data::update)
12577         (print_offset_data::finish): Likewise.
12578         * xtensa-tdep.c (xtensa_store_return_value)
12579         (xtensa_push_dummy_call): Likewise.
12580
12581 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
12582
12583         * windows-nat.c (display_selector): Fixed format specifications
12584         for 64-bit Cygwin.
12585
12586 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12587
12588         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
12589
12590 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
12591
12592         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
12593         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
12594         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
12595         (nios2_linux_init_abi): Install it.
12596
12597 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
12598
12599         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
12600
12601 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
12602
12603         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
12604
12605 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12606             Tom Tromey  <tromey@adacore.com>
12607
12608         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
12609
12610 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
12611
12612         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
12613         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
12614         method to compute the bounds of range types. Also print "[evaluated]"
12615         if the bounds' values come from a dynamic evaluation.
12616
12617 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
12618
12619         * cp-valprint.c (cp_print_value_fields): Don't print trailing
12620         whitespace when pretty printing is on.
12621
12622 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
12623
12624         * ppc-linux-nat.c: Add include.
12625
12626 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
12627
12628         * NEWS: Mention AArch64 Pointer Authentication.
12629
12630 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
12631
12632         * arm-linux-nat.c: Add include.
12633
12634 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
12635
12636         * source-cache.c (source_cache::get_source_lines): Re-read
12637         fullname after calling open_source_file.
12638
12639 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
12640
12641         * NEWS: Mention TLS support for FreeBSD.
12642
12643 2019-03-25  Tom Tromey  <tromey@adacore.com>
12644
12645         * minsyms.c (BUNCH_SIZE): Update comment.
12646         (~minimal_symbol_reader): Remove old comment.
12647         (compact_minimal_symbols): Update comment.
12648         (minimal_symbol_reader::install): Remove old comment.  Update
12649         other comments.
12650
12651 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
12652
12653         * s390-linux-nat.c: Add include.
12654
12655 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
12656
12657         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
12658         Call linux_get_hwcap.
12659         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
12660         Likewise.
12661         (aarch64_linux_get_hwcap): Remove function.
12662         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
12663         declaration.
12664         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
12665         linux_get_hwcap.
12666         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
12667         * linux-tdep.c (linux_get_hwcap): Add function.
12668         (linux_get_hwcap2): Likewise.
12669         * linux-tdep.h (linux_get_hwcap): Add declaration.
12670         (linux_get_hwcap2): Likewise.
12671         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
12672         (ppc_linux_get_hwcap2): Likewise.
12673         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
12674         linux_get_hwcap.
12675         (ppc_linux_nat_target::insert_watchpoint): Likewise.
12676         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
12677         (ppc_linux_nat_target::read_description): Likewise.
12678         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
12679         * s390-linux-nat.c: Likewise.
12680         * s390-linux-tdep.c (s390_core_read_description): Likewise.
12681
12682 2019-03-24  Tom Tromey  <tom@tromey.com>
12683
12684         * ada-lang.c (standard_lookup): Simplify initialization.
12685         (ada_lookup_symbol_nonlocal): Simplify return.
12686         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
12687         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
12688         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
12689         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
12690         initialization.
12691         * solib.c (solib_global_lookup): Simplify.
12692         * symtab.c (null_block_symbol): Remove.
12693         (symbol_cache_lookup): Simplify returns.
12694         (lookup_language_this): Simplify returns.
12695         (lookup_symbol_aux): Simplify return.
12696         (lookup_local_symbol): Simplify returns.
12697         (lookup_global_symbol_from_objfile): Simplify return.
12698         (lookup_symbol_in_objfile_symtabs)
12699         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
12700         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
12701         (lookup_static_symbol, lookup_global_symbol): Simplify return.
12702         * cp-namespace.c (cp_lookup_bare_symbol)
12703         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
12704         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
12705         (cp_lookup_nested_symbol): Don't use null_block_symbol.
12706         (cp_lookup_symbol_via_imports): Simplify initialization.
12707         (find_symbol_in_baseclass): Likewise.
12708         * symtab.h (null_block_symbol): Remove.
12709         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
12710         (d_lookup_nested_symbol, d_lookup_symbol_imports)
12711         (d_lookup_symbol_module): Likewise.
12712         (find_symbol_in_baseclass): Simplify initialization.
12713
12714 2019-03-24  Tom Tromey  <tom@tromey.com>
12715
12716         * expression.h: Don't include symtab.h.
12717         (struct block): Forward declare.
12718
12719 2019-03-24  Tom Tromey  <tom@tromey.com>
12720
12721         * c-exp.y (typebase): Remove casts.
12722         * gdbtypes.c (lookup_unsigned_typename, )
12723         (lookup_signed_typename): Remove cast.
12724         * eval.c (parse_to_comma_and_eval): Remove cast.
12725         * parse.c (write_dollar_variable): Remove cast.
12726         * block.h (struct block) <superblock>: Now const.
12727         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
12728         * psymtab.c (psym_map_matching_symbols): Make "block" const.
12729         (map_block): Make "block" const.
12730         * symfile.h (struct quick_symbol_functions)
12731         <map_matching_symbols>: Constify block argument to "callback".
12732         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
12733         const.
12734         (find_pc_sect_compunit_symtab): Make "b" const.
12735         (find_symbol_at_address): Likewise.
12736         (search_symbols): Likewise.
12737         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
12738         (dw2_debug_names_lookup_symbol): Likewise.
12739         (dw2_map_matching_symbols): Update.
12740         * p-valprint.c (pascal_val_print): Remove "block".
12741         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
12742         (aux_add_nonlocal_symbols): Make "block" const.
12743         (resolve_subexp): Remove cast.
12744         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
12745         const.
12746         (iterate_over_file_blocks): Likewise.
12747         * f-exp.y (%union) <bval>: Remove.
12748         * coffread.c (patch_opaque_types): Make "b" const.
12749         * spu-tdep.c (spu_catch_start): Make "block" const.
12750         * c-valprint.c (print_unpacked_pointer): Remove "block".
12751         * symmisc.c (dump_symtab_1): Make "b" const.
12752         (block_depth): Make "block" const.
12753         * d-exp.y (%union) <bval>: Remove.
12754         * cp-support.h (cp_lookup_rtti_type): Update.
12755         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
12756         * psymtab.c (psym_lookup_symbol): Make "block" const.
12757         (maintenance_check_psymtabs): Make "b" const.
12758         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
12759         (enumerate_locals, enumerate_args): Update.
12760         * python/py-symtab.c (stpy_global_block): Make "block" const.
12761         (stpy_static_block): Likewise.
12762         * inline-frame.c (block_starting_point_at): Make "new_block"
12763         const.
12764         * block.c (find_block_in_blockvector): Make return type const.
12765         (blockvector_for_pc_sect): Make "b" const.
12766         (find_block_in_blockvector): Make "b" const.
12767
12768 2019-03-23  Tom Tromey  <tom@tromey.com>
12769
12770         * varobj.c (varobj_create): Update.
12771         * symfile.c (clear_symtab_users): Don't reset innermost_block.
12772         * printcmd.c (display_command, do_one_display): Don't reset
12773         innermost_block.
12774         * parser-defs.h (enum innermost_block_tracker_type): Move to
12775         expression.h.
12776         (innermost_block): Update comment.
12777         * parse.c (parse_exp_1): Add tracker_types parameter.
12778         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
12779         tracker_types parameter.  Reset innermost_block.
12780         (parse_exp_in_context): Remove.
12781         (parse_expression_for_completion): Update.
12782         * objfiles.c (~objfile): Don't reset expression_context_block or
12783         innermost_block.
12784         * expression.h (enum innermost_block_tracker_type): Move from
12785         parser-defs.h.
12786         (parse_exp_1): Add tracker_types parameter.
12787         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
12788         reset innermost_block.
12789
12790 2019-03-23  Tom Tromey  <tom@tromey.com>
12791
12792         * objfiles.h: Include bcache.h.
12793
12794 2019-03-23  Tom Tromey  <tom@tromey.com>
12795
12796         * linespec.c (get_current_search_block): Use
12797         scoped_restore_current_language.
12798         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
12799
12800 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
12801             Jiong Wang  <jiong.wang@arm.com>
12802
12803         * aarch64-linux-tdep.c
12804         (aarch64_linux_iterate_over_regset_sections): Check for pauth
12805         section.
12806         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
12807
12808 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
12809             Jiong Wang  <jiong.wang@arm.com>
12810
12811         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
12812         instructions.
12813         (aarch64_analyze_prologue_test): Add PACIASP test.
12814         (aarch64_prologue_prev_register): Unmask PC value.
12815
12816 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
12817             Jiong Wang  <jiong.wang@arm.com>
12818
12819         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
12820         (aarch64_dwarf2_prev_register): Unmask PC value.
12821         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
12822         (aarch64_execute_dwarf_cfa_vendor_op): Check for
12823         DW_CFA_AARCH64_negate_ra_state.
12824         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
12825
12826 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
12827             Jiong Wang  <jiong.wang@arm.com>
12828
12829         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
12830         registers.
12831         (aarch64_pseudo_register_name): Likewise.
12832         (aarch64_pseudo_register_type): Likewise.
12833         (aarch64_pseudo_register_reggroup_p): Likewise.
12834         (aarch64_gdbarch_init): Add pauth registers.
12835         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
12836         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
12837         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
12838         (struct gdbarch_tdep): Add regnum for ra_state.
12839
12840 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
12841             Jiong Wang  <jiong.wang@arm.com>
12842
12843         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
12844
12845 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
12846             Jiong Wang  <jiong.wang@arm.com>
12847
12848         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
12849         function.
12850         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
12851         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
12852         (aarch64_gdbarch_init): Add puth registers.
12853         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
12854         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
12855         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
12856
12857 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
12858             Jiong Wang  <jiong.wang@arm.com>
12859
12860         * aarch64-linux-nat.c
12861         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
12862         * aarch64-linux-tdep.c
12863         (aarch64_linux_core_read_description): Likewise.
12864         (aarch64_linux_get_hwcap): New function.
12865         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
12866         (aarch64_linux_get_hwcap): New declaration.
12867
12868 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
12869             Jiong Wang  <jiong.wang@arm.com>
12870
12871         * aarch64-linux-nat.c
12872         (aarch64_linux_nat_target::read_description): Add pauth param.
12873         * aarch64-linux-tdep.c
12874         (aarch64_linux_core_read_description): Likewise.
12875         * aarch64-tdep.c (struct target_desc): Add in pauth.
12876         (aarch64_read_description): Add pauth param.
12877         (aarch64_gdbarch_init): Likewise.
12878         * aarch64-tdep.h (aarch64_read_description): Likewise.
12879         * arch/aarch64.c (aarch64_create_target_description): Likewise.
12880         * arch/aarch64.h (aarch64_create_target_description): Likewise.
12881         * features/Makefile: Add new files.
12882         * features/aarch64-pauth.c: New file.
12883         * features/aarch64-pauth.xml: New file.
12884
12885 2019-03-20  Tom Tromey  <tromey@adacore.com>
12886
12887         * infrun.c (handle_inferior_event): Rename from
12888         handle_inferior_event_1.  Create a scoped_value_mark.
12889         (handle_inferior_event): Remove.
12890
12891 2019-03-19  Tom Tromey  <tromey@adacore.com>
12892
12893         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
12894         * infrun.h (print_stop_event): Add "displays" parameter.
12895         * infrun.c (print_stop_event): Add "displays" parameter.
12896
12897 2019-03-19  Pedro Alves  <palves@redhat.com>
12898
12899         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
12900         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
12901         to -1.  Fix TABs vs spaces.
12902         (tui_ui_out::tui_ui_out): Don't initialize fields here.
12903         * tui/tui-out.h (tui_ui_out) Add intro comments.
12904         <m_line, m_start_of_line>: In-class initialize, and add describing
12905         comment.
12906
12907 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
12908
12909         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
12910         variable names.
12911         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
12912
12913 2019-03-18  Pedro Alves  <palves@redhat.com>
12914             Eli Zaretskii <eliz@gnu.org>
12915
12916         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
12917         m_line and m_start_of_line.
12918
12919 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
12920
12921         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
12922         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
12923         it returns a newline.  This fixes a regression in TU mode, whereby
12924         the next line is output on the same screen line as the user input.
12925
12926 2019-03-18  Tom Tromey  <tromey@adacore.com>
12927
12928         * minsyms.c (minimal_symbol_reader::install): Remove call to
12929         obstack_blank.
12930
12931 2019-03-18  Pedro Alves  <palves@redhat.com>
12932
12933         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
12934         New globals.
12935         (apply_style): New, factored out from ...
12936         (apply_ansi_escape): ... this.  Handle reverse video mode.
12937         (tui_set_reverse_mode): New function.
12938         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
12939         * tui/tui-winsource.c (tui_show_source_line): Use
12940         tui_set_reverse_mode instead of setting A_STANDOUT.
12941         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
12942         New setter methods.
12943
12944 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
12945
12946         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
12947         Handle tabs.
12948
12949 2019-03-18  Tom Tromey  <tromey@adacore.com>
12950
12951         * ada-lang.c (empty_array): Add "high" parameter.
12952         (ada_evaluate_subexp): Update.
12953
12954 2019-03-17  Sergei Trofimovich <siarheit@google.com>
12955
12956         * unittests/string_view-selftests.c: Define
12957         _initialize_string_view_selftests unconditionally.
12958
12959 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
12960
12961         PR gdb/24350
12962         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
12963
12964 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
12965
12966         PR gdb/24351
12967         * windows-nat.c (display_selector): Fix format specifiers.
12968
12969 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
12970
12971         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
12972         tui_refill_source_window instead of tui_refresh_win, to update the
12973         current execution line.  This fixes redisplay of the current line
12974         when stepping through the code with "next" or "step".
12975
12976 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
12977
12978         * source-cache.c (source_cache::get_source_lines): Call
12979         find_source_lines to initialize s->nlines.  This fixes vertical
12980         scrolling of TUI source window when the DOWN arrow is pressed.
12981
12982 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12983
12984         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
12985         linux-thread-db.c (_initialize_thread_db): Likewise.
12986
12987 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
12988
12989         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
12990         wclrtoeol in tui_show_source_line".  This reverts changes made in
12991         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
12992
12993 2019-03-15  Tom Tromey  <tom@tromey.com>
12994
12995         * symtab.h (struct minimal_symbol): Derive from
12996         general_symbol_info.
12997         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
12998         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
12999         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
13000         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
13001         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
13002         (MSYMBOL_SEARCH_NAME): Update.
13003         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
13004         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
13005         * minsyms.c (minimal_symbol_reader::record_full): Update.
13006
13007 2019-03-15  Tom Tromey  <tom@tromey.com>
13008
13009         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
13010
13011 2019-03-15  Tom Tromey  <tom@tromey.com>
13012
13013         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
13014         unique_xmalloc_ptr.
13015         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
13016         Update.
13017         * minsyms.c (lookup_minimal_symbol_by_pc_section)
13018         (build_minimal_symbol_hash_tables)
13019         (minimal_symbol_reader::install): Update.
13020
13021 2019-03-15  Tom Tromey  <tom@tromey.com>
13022
13023         * symtab.c (create_demangled_names_hash): Update.
13024         (symbol_set_names): Update.
13025         * objfiles.h (struct objfile_per_bfd_storage)
13026         <demangled_names_hash>: Now an htab_up.
13027         * objfiles.c (objfile_per_bfd_storage): Simplify.
13028
13029 2019-03-15  Tom Tromey  <tom@tromey.com>
13030
13031         * objfiles.h (struct objfile_per_bfd_storage): Declare
13032         destructor.
13033         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
13034         New.
13035         (get_objfile_bfd_data): Use new.  Don't initialize
13036         language_of_main.
13037         (free_objfile_per_bfd_storage): Remove.
13038         (objfile_bfd_data_free, objfile::~objfile): Use delete.
13039
13040 2019-03-15  Tom Tromey  <tom@tromey.com>
13041
13042         * symfile.c (reread_symbols): Update.
13043         * objfiles.c (objfile::objfile): Update.
13044         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
13045         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
13046         comment.
13047         (minimal_symbol_reader::install): Update.
13048         (terminate_minimal_symbol_table): Remove.
13049         * jit.c (jit_object_close_impl): Update.
13050
13051 2019-03-15  Tom Tromey  <tom@tromey.com>
13052
13053         * minsyms.c (minimal_symbol_reader::record_full): Remove some
13054         initializations.
13055
13056 2019-03-15  Tom Tromey  <tom@tromey.com>
13057
13058         * objfiles.h (struct objfile_per_bfd_storage)
13059         <demangled_hash_languages>: Now a bitset.
13060         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
13061         (lookup_minimal_symbol): Update.
13062
13063 2019-03-15  Tom Tromey  <tom@tromey.com>
13064
13065         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
13066         Don't return the symbol.
13067         * coffread.c (record_minimal_symbol): Use record_full.
13068
13069 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
13070
13071         The MS-Windows port of ncurses fails to switch to a color pair if
13072         one or both of the colors are the implicit default colors.  This
13073         change records the default colors when TUI is initialized, and
13074         then specifies them explicitly when a color pair uses the default
13075         colors.  This allows color styling in TUI mode on MS-Windows.
13076
13077         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
13078         ncurses_norm_attr.
13079         (tui_initialize_io) [__MINGW32__]: Record the default terminal
13080         colors in ncurses_norm_attr.
13081         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
13082         "none", replace it with the default color recorded in
13083         ncurses_norm_attr.
13084
13085 2019-03-14  Tom Tromey  <tromey@adacore.com>
13086
13087         * source-cache.h (class source_cache) <get_source_lines>: Return
13088         std::string.
13089         * source-cache.c (source_cache::extract_lines): Handle case where
13090         first_pos==npos.  Return std::string.
13091         (source_cache::get_source_lines): Update.
13092
13093 2019-03-14  Tom Tromey  <tromey@adacore.com>
13094
13095         * NEWS: Add item for "style sources" commands.
13096         * source-cache.c (source_cache::get_source_lines): Check
13097         source_styling.
13098         * cli/cli-style.c (source_styling): New global.
13099         (_initialize_cli_style): Add "style sources" commands.
13100         (show_style_sources): New function.
13101         * cli/cli-style.h (source_styling): Declare.
13102
13103 2019-03-14  Pedro Alves  <palves@redhat.com>
13104             Tom Tromey  <tromey@adacore.com>
13105
13106         * tui/tui-winsource.h (tui_refill_source_window): Declare.
13107         * tui/tui-winsource.c (tui_refill_source_window): New function,
13108         from...
13109         (tui_horizontal_source_scroll): ... here.  Move some logic.
13110         * cli/cli-style.c (set_style_enabled): Notify new observable.
13111         * tui/tui-hooks.c (tui_redisplay_source): New function.
13112         (tui_attach_detach_observers): Attach or detach
13113         tui_redisplay_source.
13114         * observable.h (source_styling_changed): New observable.
13115         * observable.c: Define source_styling_changed observable.
13116
13117 2019-03-13  Tom Tromey  <tromey@adacore.com>
13118
13119         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
13120         (i386_gnu_nat_target::store_registers): Update.
13121         * target-debug.h (target_debug_print_std_string): New macro.
13122         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
13123         * windows-tdep.c (display_one_tib): Update.
13124         * tui/tui-stack.c (tui_make_status_line): Update.
13125         * top.c (print_inferior_quit_action): Update.
13126         * thread.c (thr_try_catch_cmd): Update.
13127         (add_thread_with_info): Update.
13128         (thread_target_id_str): Update.
13129         (thr_try_catch_cmd): Update.
13130         (thread_command): Update.
13131         (thread_find_command): Update.
13132         * record-btrace.c (record_btrace_target::info_record)
13133         (record_btrace_resume_thread, record_btrace_target::resume)
13134         (record_btrace_cancel_resume, record_btrace_step_thread)
13135         (record_btrace_target::wait, record_btrace_target::wait)
13136         (record_btrace_target::wait, record_btrace_target::stop): Update.
13137         * progspace.c (print_program_space): Update.
13138         * process-stratum-target.c
13139         (process_stratum_target::thread_address_space): Update.
13140         * linux-fork.c (linux_fork_mourn_inferior)
13141         (detach_checkpoint_command, info_checkpoints_command)
13142         (linux_fork_context): Update.
13143         (linux_fork_detach): Update.
13144         (class scoped_switch_fork_info): Update.
13145         (delete_checkpoint_command): Update.
13146         * infrun.c (follow_fork_inferior): Update.
13147         (follow_fork_inferior): Update.
13148         (proceed_after_vfork_done): Update.
13149         (handle_vfork_child_exec_or_exit): Update.
13150         (follow_exec): Update.
13151         (displaced_step_prepare_throw): Update.
13152         (displaced_step_restore): Update.
13153         (start_step_over): Update.
13154         (resume_1): Update.
13155         (clear_proceed_status_thread): Update.
13156         (proceed): Update.
13157         (print_target_wait_results): Update.
13158         (do_target_wait): Update.
13159         (context_switch): Update.
13160         (stop_all_threads): Update.
13161         (restart_threads): Update.
13162         (finish_step_over): Update.
13163         (handle_signal_stop): Update.
13164         (switch_back_to_stepped_thread): Update.
13165         (keep_going_pass_signal): Update.
13166         (print_exited_reason): Update.
13167         (normal_stop): Update.
13168         * inferior.c (inferior_pid_to_str): Change return type.
13169         (print_selected_inferior): Update.
13170         (add_inferior): Update.
13171         (detach_inferior): Update.
13172         * dummy-frame.c (fprint_dummy_frames): Update.
13173         * dcache.c (dcache_info_1): Update.
13174         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
13175         (btrace_fetch, btrace_clear): Update.
13176         * linux-tdep.c (linux_core_pid_to_str): Change return type.
13177         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
13178         type.
13179         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
13180         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
13181         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
13182         * gdbarch.c, gdbarch.h: Rebuild.
13183         * gdbarch.sh (core_pid_to_str): Change return type.
13184         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
13185         return type.
13186         (windows_nat_target::pid_to_str): Change return type.
13187         (windows_delete_thread): Update.
13188         (windows_nat_target::attach): Update.
13189         (windows_nat_target::files_info): Update.
13190         * target-delegates.c: Rebuild.
13191         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
13192         return type.
13193         (sol_thread_target::pid_to_str): Change return type.
13194         * remote.c (class remote_target) <pid_to_str>: Change return
13195         type.
13196         (remote_target::pid_to_str): Change return type.
13197         (extended_remote_target::attach, remote_target::remote_stop_ns)
13198         (remote_target::remote_notif_remove_queued_reply)
13199         (remote_target::push_stop_reply, remote_target::disable_btrace):
13200         Update.
13201         (extended_remote_target::attach): Update.
13202         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
13203         type.
13204         (gdbsim_target::pid_to_str): Change return type.
13205         * ravenscar-thread.c (struct ravenscar_thread_target)
13206         <pid_to_str>: Change return type.
13207         (ravenscar_thread_target::pid_to_str): Change return type.
13208         * procfs.c (class procfs_target) <pid_to_str>: Change return
13209         type.
13210         (procfs_target::pid_to_str): Change return type.
13211         (procfs_target::attach): Update.
13212         (procfs_target::detach): Update.
13213         (procfs_target::fetch_registers): Update.
13214         (procfs_target::store_registers): Update.
13215         (procfs_target::wait): Update.
13216         (procfs_target::files_info): Update.
13217         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
13218         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
13219         return type.
13220         (nto_procfs_target::pid_to_str): Change return type.
13221         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
13222         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
13223         return type.
13224         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
13225         (exit_lwp): Update.
13226         (attach_proc_task_lwp_callback, get_detach_signal)
13227         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
13228         (linux_nat_target::resume, wait_lwp, stop_callback)
13229         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
13230         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
13231         (linux_nat_wait_1, resume_stopped_resumed_lwps)
13232         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
13233         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
13234         type.
13235         (inf_ptrace_target::attach): Update.
13236         (inf_ptrace_target::files_info): Update.
13237         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
13238         type.
13239         (go32_nat_target::pid_to_str): Change return type.
13240         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
13241         (gnu_nat_target::wait): Update.
13242         (gnu_nat_target::wait): Update.
13243         (gnu_nat_target::resume): Update.
13244         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
13245         (fbsd_nat_target::wait): Update.
13246         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
13247         type.
13248         (darwin_nat_target::attach): Update.
13249         * corelow.c (class core_target) <pid_to_str>: Change return type.
13250         (core_target::pid_to_str): Change return type.
13251         * target.c (normal_pid_to_str): Change return type.
13252         (default_pid_to_str): Likewise.
13253         (target_pid_to_str): Change return type.
13254         (target_translate_tls_address): Update.
13255         (target_announce_detach): Update.
13256         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
13257         return type.
13258         (bsd_uthread_target::pid_to_str): Change return type.
13259         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
13260         type.
13261         (bsd_kvm_target::pid_to_str): Change return type.
13262         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
13263         return type.
13264         (aix_thread_target::pid_to_str): Change return type.
13265         * target.h (struct target_ops) <pid_to_str>: Change return type.
13266         (target_pid_to_str, normal_pid_to_str): Likewise.
13267         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
13268         type.
13269         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
13270         type.
13271         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
13272         return type.
13273         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
13274         type.
13275         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
13276         type.
13277         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
13278         return type.
13279
13280 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
13281
13282         * NEWS: Mention that the new default MI version is 3.  Mention
13283         changes to the output of commands and events that deal with
13284         multi-location breakpoints.
13285         * breakpoint.c: Include "mi/mi-out.h".
13286         (print_one_breakpoint): Change output syntax if using MI version
13287         >= 3.
13288         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
13289         New.
13290         (mi_multi_location_breakpoint_output_fixed): New.
13291         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
13292         (mi_cmd_fix_multi_location_breakpoint_output): New.
13293         (mi_multi_location_breakpoint_output_fixed): New.
13294         * mi/mi-cmds.c (mi_cmds): Register command
13295         -fix-multi-location-breakpoint-output.
13296         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
13297         interpreter "mi".
13298
13299 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
13300
13301         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
13302         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
13303         instantiate mi_ui_out based on interpreter name.
13304         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
13305         * mi/mi-main.c (mi_load_progress): Likewise.
13306
13307 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
13308
13309         * NEWS: Combine separate "New targets" sections for 8.3.
13310
13311 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
13312
13313         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
13314         (ppcfbsd_init_abi): Install gdbarch
13315         "fetch_tls_load_module_address" and "get_thread_local_address"
13316         methods.
13317
13318 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
13319
13320         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
13321         (riscv_fbsd_init_abi): Install gdbarch
13322         "fetch_tls_load_module_address" and "get_thread_local_address"
13323         methods.
13324
13325 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
13326
13327         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
13328         (i386fbsd_init_abi): Install gdbarch
13329         "fetch_tls_load_module_address" and "get_thread_local_address"
13330         methods.
13331
13332 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
13333
13334         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
13335         (amd64fbsd_init_abi): Install gdbarch
13336         "fetch_tls_load_module_address" and "get_thread_local_address"
13337         methods.
13338
13339 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
13340
13341         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
13342         (struct fbsd_pspace_data): New type.
13343         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
13344         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
13345         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
13346         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
13347         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
13348
13349 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
13350
13351         * gdbtypes.c (lookup_struct_elt): New function.
13352         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
13353         * gdbtypes.h (struct struct_elt): New type.
13354         (lookup_struct_elt): New prototype.
13355
13356 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
13357
13358         * gdbtypes.c (lookup_struct_elt_type): Update comment and
13359         remove disabled code block.
13360
13361 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
13362
13363         * gdbarch.sh (get_thread_local_address): New method.
13364         * gdbarch.h, gdbarch.c: Regenerate.
13365         * target.c (target_translate_tls_address): Use
13366         gdbarch_get_thread_local_address if present instead of
13367         target::get_thread_local_address.
13368
13369 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
13370
13371         * target.h (target::get_thread_local_address): Update comment.
13372
13373 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
13374
13375         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
13376         objfile->separate_debug_objfile_backlink if not NULL.
13377
13378 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
13379
13380         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
13381         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
13382         (amd64bsd_store_inferior_registers): Likewise.
13383         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
13384         Enable segment base registers.
13385         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
13386         PT_GETFSBASE and PT_GETGSBASE.
13387         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
13388         PT_SETGSBASE.
13389         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
13390         segment base registers.
13391         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
13392
13393 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
13394
13395         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
13396         Update calls to i386_target_description to add 'segments'
13397         parameter.
13398         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
13399         add segment base registers.
13400         * arch/i386.c (i386_create_target_description): Add 'segments'
13401         parameter to enable segment base registers.
13402         * arch/i386.h (i386_create_target_description): Likewise.
13403         * features/i386/32bit-segments.xml: New file.
13404         * features/i386/32bit-segments.c: Generate.
13405         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
13406         call to i386_target_description to add 'segments' parameter.
13407         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
13408         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
13409         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
13410         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
13411         if feature is present.
13412         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
13413         Add 'segments' parameter to call to i386_target_description.
13414         (i386_target_description): Add 'segments' parameter to enable
13415         segment base registers.
13416         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
13417         to call to i386_target_description.
13418         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
13419         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
13420         Define I386_NUM_REGS.
13421         (i386_target_description): Add 'segments' parameter to enable
13422         segment base registers.
13423
13424 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
13425
13426         PR/24325
13427         * source-cache.c: #undef open and close, to avoid unresolved
13428         externals during linking.
13429
13430 2019-03-12  Tom Tromey  <tromey@adacore.com>
13431
13432         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
13433         const.  Add initializers.
13434         (_initialize_remote): Don't initialize ptid globals.
13435
13436 2019-03-12  Pedro Alves  <palves@redhat.com>
13437
13438         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
13439
13440 2019-03-12  Pedro Alves  <palves@redhat.com>
13441
13442         * cp-name-parser.y (main): Remove unused 'len' variable.
13443
13444 2019-03-12  Tom Tromey  <tromey@adacore.com>
13445
13446         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
13447         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
13448
13449 2019-03-12  Tom Tromey  <tromey@adacore.com>
13450
13451         * linux-nat.c (iterate_over_lwps): Update.
13452         (stop_callback): Remove parameter.
13453         (stop_wait_callback, detach_callback, resume_set_callback)
13454         (select_singlestep_lwp_callback, set_ignore_sigint)
13455         (status_callback, resumed_callback, resume_clear_callback)
13456         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
13457         data parameter.
13458         (linux_nat_target::detach, linux_nat_target::resume)
13459         (linux_stop_and_wait_all_lwps, select_event_lwp)
13460         (linux_nat_filter_event, linux_nat_wait_1)
13461         (linux_nat_target::kill, linux_nat_target::stop)
13462         (linux_nat_target::stop): Update.
13463         (linux_nat_resume_callback): Change type.
13464         (resume_stopped_resumed_lwps, count_events_callback)
13465         (select_event_lwp_callback): Likewise.
13466         (linux_stop_lwp, linux_nat_stop_lwp): Update.
13467         * arm-linux-nat.c (struct update_registers_data): Remove.
13468         (update_registers_callback): Change type.
13469         (arm_linux_insert_hw_breakpoint1): Update.
13470         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
13471         parameter.
13472         (x86_linux_dr_set_addr): Update.
13473         (x86_linux_dr_set_control): Update.
13474         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
13475         (iterate_over_lwps): Use gdb::function_view.
13476         * nat/aarch64-linux-hw-point.c (struct
13477         aarch64_dr_update_callback_param): Remove.
13478         (debug_reg_change_callback): Change type.
13479         (aarch64_notify_debug_reg_change): Update.
13480         * s390-linux-nat.c (s390_refresh_per_info): Update.
13481
13482 2019-03-11  Tom Tromey  <tromey@adacore.com>
13483
13484         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
13485         redundant assignment to "this_cu".
13486
13487 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
13488
13489         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
13490
13491 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
13492
13493         * gdbtypes.c (rank_one_type_parm_set): New function extracted
13494         from...
13495         (rank_one_type): ... this.
13496
13497 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
13498
13499         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
13500         from...
13501         (rank_one_type): ... this.
13502
13503 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
13504
13505         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
13506         from...
13507         (rank_one_type): ... this.
13508
13509 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
13510
13511         * gdbtypes.c (rank_one_type_parm_float): New function extracted
13512         from...
13513         (rank_one_type): ... this.
13514
13515 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
13516
13517         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
13518         from...
13519         (rank_one_type): ... this.
13520
13521 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
13522
13523         * gdbtypes.c (rank_one_type_parm_range): New function extracted
13524         from...
13525         (rank_one_type): ... this.
13526
13527 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
13528
13529         * gdbtypes.c (rank_one_type_parm_char): New function extracted
13530         from...
13531         (rank_one_type): ... this.
13532
13533 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
13534
13535         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
13536         from...
13537         (rank_one_type): ... this.
13538
13539 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
13540
13541         * gdbtypes.c (rank_one_type_parm_int): New function extracted
13542         from...
13543         (rank_one_type): ... this.
13544
13545 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
13546
13547         * gdbtypes.c (rank_one_type_parm_func): New function extracted
13548         from...
13549         (rank_one_type): ... this.
13550
13551 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
13552
13553         * gdbtypes.c (rank_one_type_parm_array): New function extracted
13554         from...
13555         (rank_one_type): ... this.
13556
13557 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
13558
13559         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
13560         from...
13561         (rank_one_type): ... this.
13562
13563 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
13564
13565         * inferior.c (initialize_inferiors): Ensure 'help set/show print
13566         inferior-events' shows the example events.
13567
13568 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
13569
13570         Support styling on native MS-Windows console
13571
13572         PR/24315
13573         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
13574         on MS-Windows if $TERM is not defined.
13575
13576         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
13577
13578         * posix-hdep.c (gdb_console_fputs):
13579         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
13580         functions.
13581         * ui-file.h (gdb_console_fputs): Add prototype.
13582
13583         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
13584         back to fputs only if the former returns zero.
13585
13586 2019-03-07  Tom Tromey  <tom@tromey.com>
13587
13588         * symmisc.c (print_symbol_bcache_statistics): Update.
13589         (print_objfile_statistics): Update.
13590         * symfile.c (allocate_symtab): Update.
13591         * stabsread.c: Don't include bcache.h.
13592         * psymtab.h (struct psymbol_bcache): Don't declare.
13593         (class psymtab_storage) <psymbol_cache>: Now a bcache.
13594         (psymbol_bcache_init, psymbol_bcache_free)
13595         (psymbol_bcache_get_bcache): Don't declare.
13596         * psymtab.c (struct psymbol_bcache): Remove.
13597         (psymtab_storage::psymtab_storage): Update.
13598         (psymtab_storage::~psymtab_storage): Update.
13599         (psymbol_bcache_init, psymbol_bcache_free)
13600         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
13601         (add_psymbol_to_bcache): Update.
13602         (allocate_psymtab): Update.
13603         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
13604         macro_cache>: No longer pointers.
13605         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
13606         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
13607         * macrotab.c (macro_bcache): Update.
13608         * macroexp.c: Don't include bcache.h.
13609         * gdbtypes.c (check_types_worklist): Update.
13610         (types_deeply_equal): Remove TRY/CATCH.  Update.
13611         * elfread.c (elf_symtab_read): Update.
13612         * dwarf2read.c: Don't include bcache.h.
13613         * buildsym.c (buildsym_compunit::get_macro_table): Update.
13614         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
13615         (print_bcache_statistics, bcache_memory_used): Don't declare.
13616         (struct bcache): Move from bcache.c.  Add constructor, destructor,
13617         methods.  Rename all data members.
13618         * bcache.c (struct bcache): Move to bcache.h.
13619         (bcache::expand_hash_table): Rename from expand_hash_table.
13620         (bcache): Remove.
13621         (bcache::insert): Rename from bcache_full.
13622         (bcache::compare): Rename from bcache_compare.
13623         (bcache_xmalloc): Remove.
13624         (bcache::~bcache): Rename from bcache_xfree.
13625         (bcache::print_statistics): Rename from print_bcache_statistics.
13626         (bcache::memory_used): Rename from bcache_memory_used.
13627
13628 2019-03-07  Pedro Alves  <palves@redhat.com>
13629
13630         * infrun.c (normal_stop): Also check for
13631         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
13632
13633 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
13634
13635         * f-lang.c (value_from_host_double): Moved to...
13636         * value.c (value_from_host_double): ...here.
13637         * value.h (value_from_host_double): Declare.
13638         * guile/scm-math.c (vlscm_convert_typed_number): Use
13639         value_from_host_double.
13640         (vlscm_convert_number): Likewise.
13641         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
13642         * python/py-value.c (convert_value_from_python): Likewise.
13643
13644 2019-03-06  Tom Tromey  <tom@tromey.com>
13645
13646         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
13647
13648 2019-03-06  Tom Tromey  <tom@tromey.com>
13649
13650         * utils.h (free_current_contents): Don't declare.
13651         * utils.c (free_current_contents): Remove.
13652
13653 2019-03-06  Tom Tromey  <tom@tromey.com>
13654
13655         * top.c (quit_force): Update.
13656         * main.c (captured_command_loop): Update.
13657         * common/new-op.c (operator new): Update.
13658         * common/common-exceptions.c (struct catcher)
13659         <save_cleanup_chain>: Remove member.
13660         (exceptions_state_mc_init): Update.
13661         (exception_try_scope_entry): Return nullptr.
13662         (exception_try_scope_exit, exception_rethrow)
13663         (throw_exception_sjlj, throw_exception_cxx): Update.
13664         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
13665         (all_cleanups, do_cleanups, discard_cleanups)
13666         (discard_final_cleanups, save_cleanups, save_final_cleanups)
13667         (restore_cleanups, restore_final_cleanups): Don't declare.
13668         (do_final_cleanups): Remove parameter.
13669         * common/cleanups.c (cleanup_chain, make_cleanup)
13670         (make_cleanup_dtor, all_cleanups, do_cleanups)
13671         (discard_my_cleanups, discard_cleanups)
13672         (discard_final_cleanups, save_my_cleanups, save_cleanups)
13673         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
13674         (null_cleanup): Remove.
13675         (do_final_cleanups): Remove parameter.
13676
13677 2019-03-06  Tom Tromey  <tom@tromey.com>
13678
13679         * remote.c (remote_target::remote_parse_stop_reply): Use
13680         unique_xmalloc_ptr.
13681
13682 2019-03-06  Tom Tromey  <tom@tromey.com>
13683
13684         * stabsread.c (struct stabs_field_info): Rename from field_info.
13685         <list, fnlist>: Add initializers.
13686         <obstack>: New member.
13687         (read_member_functions, read_struct_fields, read_baseclasses):
13688         Allocate on obstack.  Don't use cleanups.
13689         (read_one_struct_field, read_member_functions, read_struct_fields)
13690         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
13691         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
13692         (read_struct_type): Update.
13693
13694 2019-03-06  Tom Tromey  <tom@tromey.com>
13695
13696         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
13697         * common/filestuff.h (make_cleanup_close): Don't declare.
13698         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
13699         Remove.
13700
13701 2019-03-06  Tom Tromey  <tom@tromey.com>
13702
13703         * solib-aix.c: Use make_scope_exit.
13704
13705 2019-03-06  Tom Tromey  <tom@tromey.com>
13706
13707         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
13708         Use make_scope_exit.
13709
13710 2019-03-06  Tom Tromey  <tom@tromey.com>
13711
13712         * solib-svr4.c (disable_probes_interface): Remove parameter.
13713         (svr4_handle_solib_event): Use make_scope_exit.
13714
13715 2019-03-06  Tom Tromey  <tom@tromey.com>
13716
13717         * remote.c (struct stop_reply_deleter): Remove.
13718         (stop_reply_up): Update.
13719         (struct stop_reply): Derive from notif_event.  Don't typedef.
13720         <regcache>: Now a std::vector.
13721         (stop_reply_xfree): Remove.
13722         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
13723         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
13724         (remote_target::discard_pending_stop_replies): Use delete.
13725         (remote_target::remote_parse_stop_reply): Update.
13726         (remote_target::process_stop_reply): Update.
13727         * remote-notif.h (struct notif_event): Add virtual destructor.
13728         Remove "dtr" member.
13729         (struct notif_client) <alloc_event>: Return a unique_ptr.
13730         (notif_event_xfree): Don't declare.
13731         (notif_event_up): New typedef.
13732         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
13733         (notif_event_xfree, do_notif_event_xfree): Remove.
13734         (remote_notif_state_xfree): Update.
13735
13736 2019-03-06  Tom Tromey  <tom@tromey.com>
13737
13738         * infrun.c (displaced_step_clear_cleanup): Now a
13739         forward_scope_exit type.
13740         (displaced_step_prepare_throw): Update.
13741         (displaced_step_fixup): Update.
13742
13743 2019-03-06  Tom Tromey  <tom@tromey.com>
13744
13745         * inferior.h (class inferior): Update comment.
13746         * gdbthread.h (class thread_info): Update comment.
13747
13748 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
13749             Tom Tromey  <tom@tromey.com>
13750
13751         * stabsread.h (struct stab_section_list): Remove.
13752         (coffstab_build_psymtabs): Update.
13753         * dbxread.c (symbuf_sections): Now a std::vector.
13754         (sect_idx): New global.
13755         (fill_symbuf): Update.
13756         (coffstab_build_psymtabs): Change type of stabsects parameter.
13757         Update.
13758         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
13759         std::vector.
13760         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
13761         (coff_locate_sections): Update.
13762         (coff_symfile_read): Remove cleanups.  Update.
13763         (init_stringtab): Add storage parameter.
13764         (free_stringtab, free_stringtab_cleanup): Remove.
13765         (init_lineno): Add storage parameter.
13766         (free_linetab, free_linetab_cleanup): Remove.
13767
13768 2019-03-06  Pedro Alves  <palves@redhat.com>
13769
13770         * linux-fork.c (fork_info::clobber_regs): Delete.
13771         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
13772         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
13773         comment.  Adjust.
13774         (scoped_switch_fork_info::scoped_switch_fork_info)
13775         (checkpoint_command, linux_fork_context): Adjust
13776         fork_save_infrun_state calls.
13777
13778 2019-03-06  Pedro Alves  <palves@redhat.com>
13779
13780         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
13781         (inf_has_multiple_threads): Return 'bool' and rewrite using
13782         inferior_info::threads().
13783
13784 2019-03-06  Pedro Alves  <palves@redhat.com>
13785
13786         * linux-fork.c: Include <list>.
13787         (fork_list): Now a std::list instance.
13788         (fork_info): Add ctor, dtor, and in-class initialize all fields.
13789         (forks_exist_p, find_last_fork): Adjust.
13790         (new_fork): Delete.
13791         (one_fork_p): New.
13792         (add_fork): Adjust.
13793         (free_fork): Delete, folded into fork_info::~fork_info().
13794         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
13795         Adjust.
13796         (init_fork_list): Delete.
13797         (linux_fork_killall, linux_fork_mourn_inferior)
13798         (linux_fork_detach, info_checkpoints_command): Adjust.
13799         (_initialize_linux_fork): No longer call init_fork_list.
13800
13801 2019-03-06  Pedro Alves  <palves@redhat.com>
13802
13803         * linux-fork.c (new_fork): New, split out of ...
13804         (add_fork): ... this.  Return void.  Move "first fork" special
13805         case from here, to ...
13806         (checkpoint_command): ... here.
13807         * linux-linux.h (add_fork): Return void.
13808
13809 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
13810
13811         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
13812
13813 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
13814             Chris January  <chris.january@arm.com>
13815             David Lecomber  <david.lecomber@arm.com>
13816
13817         * f-exp.y: New token, UNOP_INTRINSIC.
13818         (exp): New pattern using UNOP_INTRINSIC token.
13819         (f77_keywords): Add 'abs' keyword.
13820         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
13821         (value_from_host_double): New function.
13822         (evaluate_subexp_f): Support UNOP_ABS.
13823
13824 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
13825
13826         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
13827         types.
13828
13829 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
13830
13831         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
13832         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
13833         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
13834
13835 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
13836
13837         * f-exp.y (convert_to_kind_type): Handle more type kinds.
13838
13839 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
13840             Chris January  <chris.january@arm.com>
13841
13842         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
13843         * f-exp.y: Define 'KIND' token.
13844         (exp): New pattern for KIND expressions.
13845         (ptype): Handle types with a kind extension.
13846         (direct_abs_decl): Extend to spot kind extensions.
13847         (f77_keywords): Add 'kind' to the list.
13848         (push_kind_type): New function.
13849         (convert_to_kind_type): New function.
13850         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
13851         * parse.c (operator_length_standard): Likewise.
13852         * parser-defs.h (enum type_pieces): Add tp_kind.
13853         * std-operator.def: Add UNOP_KIND.
13854
13855 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
13856
13857         * f-exp.y (f_parse): Set yydebug.
13858
13859 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
13860
13861         * f-lang.c (evaluate_subexp_f): New function.
13862         (exp_descriptor_f): New global.
13863         (f_language_defn): Use exp_descriptor_f instead of
13864         exp_descriptor_standard.
13865
13866 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
13867
13868         * f-exp.y (struct token): Add comments.
13869         (dot_ops): Remove uppercase versions and the end marker.
13870         (f77_keywords): Likewise.
13871         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
13872         entries in the dot_ops array are case insensitive, and use
13873         strncasecmp to compare strings.  Also some whitespace cleanup in
13874         this area.  Similar for the f77_keywords array, except entries in
13875         this list might be case sensitive.
13876
13877 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
13878
13879         * f-exp.y (struct f77_boolean_val): Add comments.
13880         (boolean_values): Remove uppercase versions, and end marker.
13881         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
13882         and use strncasecmp to achieve case insensitivity.  Additionally,
13883         perform whitespace cleanup around this code.
13884
13885 2019-03-06  Tom Tromey  <tromey@adacore.com>
13886
13887         * remote-sim.c (gdbsim_target_open): Use result of
13888         gdb_argv::release.
13889
13890 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
13891         Dirk Schubert  <dirk.schubert@arm.com>
13892         Chris January  <chris.january@arm.com>
13893
13894         * eval.c (evaluate_subexp_standard): Call Fortran argument
13895         wrapping logic.
13896         * f-lang.c (struct value): A value which can be passed into a
13897         Fortran function call.
13898         (fortran_argument_convert): Wrap Fortran arguments in a pointer
13899         where appropriate.
13900         (struct type): Value ready for a Fortran function call.
13901         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
13902         is needed.
13903         * f-lang.h (fortran_argument_convert): Declaration.
13904         (fortran_preserve_arg_pointer): Declaration.
13905         * infcall.c (value_arg_coerce): Call Fortran argument logic.
13906
13907 2019-03-05  Tom Tromey  <tromey@adacore.com>
13908
13909         * python/py-prettyprint.c (print_string_repr): Remove #if.
13910         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
13911
13912 2019-03-05  Tom Tromey  <tromey@adacore.com>
13913
13914         * target.c (the_dummy_target): Move later.  Change type to
13915         "dummy_target".
13916         (initialize_targets): Don't initialize the_dummy_target.
13917
13918 2019-03-05  Tom Tromey  <tromey@adacore.com>
13919
13920         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
13921         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
13922
13923 2019-03-05  Tom Tromey  <tromey@adacore.com>
13924
13925         * windows-nat.c (windows_nat_target::attach)
13926         (windows_nat_target::detach): Don't call gdb_flush.
13927         * valprint.c (generic_val_print, val_print, val_print_string):
13928         Don't call gdb_flush.
13929         * utils.c (defaulted_query): Don't call gdb_flush.
13930         * typeprint.c (print_type_scalar): Don't call gdb_flush.
13931         * target.c (target_announce_detach): Don't call gdb_flush.
13932         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
13933         * remote.c (extended_remote_target::attach): Don't call
13934         gdb_flush.
13935         * procfs.c (procfs_target::detach): Don't call gdb_flush.
13936         * printcmd.c (do_examine): Don't call gdb_flush.
13937         (info_display_command): Don't call gdb_flush.
13938         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
13939         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
13940         * memattr.c (info_mem_command): Don't call gdb_flush.
13941         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
13942         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
13943         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
13944         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
13945         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
13946         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
13947         (gnu_nat_target::detach): Don't call gdb_flush.
13948         * f-valprint.c (f_val_print): Don't call gdb_flush.
13949         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
13950         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
13951         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
13952         gdb_flush.
13953         * c-valprint.c (c_val_print): Don't call gdb_flush.
13954         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
13955
13956 2019-03-05  Tom Tromey  <tromey@adacore.com>
13957
13958         * varobj.c (update_dynamic_varobj_children): Update.
13959         (install_default_visualizer): Use reset, not release.
13960         * value.c (set_internalvar): Update.
13961         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
13962         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
13963         ATTRIBUTE_UNUSED_RESULT.
13964
13965 2019-03-05  Tom Tromey  <tromey@adacore.com>
13966
13967         * remote.c (class scoped_remote_fd) <release>: Add
13968         ATTRIBUTE_UNUSED_RESULT.
13969
13970 2019-03-05  Tom Tromey  <tromey@adacore.com>
13971
13972         * macroexp.c (struct macro_buffer) <release>: Add
13973         ATTRIBUTE_UNUSED_RESULT.
13974
13975 2019-03-05  Tom Tromey  <tromey@adacore.com>
13976
13977         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
13978         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
13979         ATTRIBUTE_UNUSED_RESULT.
13980
13981 2019-03-05  Tom Tromey  <tromey@adacore.com>
13982
13983         * common/scoped_fd.h (class scoped_fd) <release>: Add
13984         ATTRIBUTE_UNUSED_RESULT.
13985
13986 2019-03-05  Tom Tromey  <tromey@adacore.com>
13987
13988         * parser-defs.h (struct parser_state) <release>: Add
13989         ATTRIBUTE_UNUSED_RESULT.
13990
13991 2019-03-05  Tom Tromey  <tromey@adacore.com>
13992
13993         * utils.h (class gdb_argv) <release>: Add
13994         ATTRIBUTE_UNUSED_RESULT.
13995         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
13996
13997 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
13998
13999         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
14000         for-loop range, to avoid compiler warnings.
14001
14002         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
14003         avoid compiler warnings about unused variables.
14004
14005         * NEWS: Mention end of support for native debugging on MS-Windows
14006         before XP.
14007
14008         PR gdb/24292
14009         * common/netstuff.c:
14010         * gdbserver/gdbreplay.c
14011         * gdbserver/remote-utils.c:
14012         * ser-tcp.c:
14013         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
14014         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
14015         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
14016         'getaddrinfo' and 'freeaddrinfo' were not available before
14017         Windows XP, and mingw.org's MinGW headers by default define
14018         _WIN32_WINNT to 0x500.
14019
14020 2019-03-01  Gary Benson <gbenson@redhat.com>
14021
14022         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
14023
14024 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
14025             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
14026
14027         PR gdb/8527
14028         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
14029         set_sigint_trap, clear_sigint_trap.
14030
14031 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
14032
14033         * target.c (target_detach): Clear the regcache and the
14034         frame cache.
14035
14036 2019-02-27  Pedro Alves  <palves@redhat.com>
14037
14038         * utils.c (set_screen_size): When we cap the height/width sizes,
14039         tweak the corresponding command variable to show "unlimited":
14040
14041 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
14042             Pedro Alves  <palves@redhat.com>
14043
14044         * utils.c (set_screen_size): Reduce "infinite" rows and columns
14045         before calling rl_set_screen_size.
14046
14047 2019-02-27  Tom Tromey  <tromey@adacore.com>
14048
14049         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
14050         define.
14051         * python/py-value.c: Remove Python 2.4 workaround.
14052         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
14053         workaround.
14054         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
14055         Python 2.4 workaround.
14056         * python/python-internal.h: Remove Python 2.4 comment.
14057         (Py_ssize_t): Don't define.
14058         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
14059         (gdb_Py_DECREF): Remove Python 2.4 workaround.
14060         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
14061         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
14062         * python/python.c (do_start_initialization): Remove Python 2.4
14063         workaround.
14064         * python/py-prettyprint.c (class dummy_python_frame): Remove.
14065         (print_children): Remove Python 2.4 workaround.
14066         * python/py-inferior.c (buffer_procs): Remove Python 2.4
14067         workaround.
14068         (CHARBUFFERPROC_NAME): Remove.
14069         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
14070         Python 2.4 workaround.
14071
14072 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
14073
14074         * NEWS: Note minimum Python version.
14075
14076 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
14077
14078         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
14079         code from these functions.  Remove corresponding ifdefs.  Use
14080         Py_buffer_up instead of explicit calls to PyBuffer_Release.
14081         Remove gotos and target of gotos.
14082         (infpy_search_memory): Likewise.
14083
14084 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
14085
14086         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
14087         (hppa_gdbarch_init): Don't register deleted functions with
14088         gdbarch.
14089
14090 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
14091
14092         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
14093         (h8300_unwind_sp): Delete.
14094         (h8300_dummy_id): Delete.
14095         (h8300_gdbarch_init): Don't register deleted functions with
14096         gdbarch.
14097
14098 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
14099
14100         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
14101         (ft32_unwind_pc): Delete.
14102         (ft32_unwind_sp): Delete.
14103         (ft32_gdbarch_init): Don't register deleted functions with
14104         gdbarch.
14105
14106 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
14107
14108         * gdb/frv-tdep.c (frv_dummy_id): Delete.
14109         (frv_unwind_pc): Delete.
14110         (frv_unwind_sp): Delete.
14111         (frv_gdbarch_init): Don't register deleted functions with
14112         gdbarch.
14113
14114 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
14115
14116         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
14117         (riscv_unwind_pc): Delete.
14118         (riscv_unwind_sp): Delete.
14119         (riscv_gdbarch_init): Don't register deleted functions with
14120         gdbarch.
14121
14122 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
14123
14124         * gdb/csky-tdep.c (csky_dummy_id): Delete.
14125         (csky_unwind_pc): Delete.
14126         (csky_unwind_sp): Delete.
14127         (csky_gdbarch_init): Don't register deleted functions with
14128         gdbarch.
14129
14130 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
14131
14132         * gdb/cris-tdep.c (cris_dummy_id): Delete.
14133         (cris_unwind_pc): Delete.
14134         (cris_unwind_sp): Delete.
14135         (cris_gdbarch_init): Don't register deleted functions with
14136         gdbarch.
14137
14138 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
14139
14140         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
14141         (bfin_unwind_pc): Delete.
14142         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
14143
14144 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
14145
14146         * gdb/arm-tdep.c (arm_dummy_id): Delete.
14147         (arm_unwind_pc): Delete.
14148         (arm_unwind_sp): Delete.
14149         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
14150
14151 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
14152
14153         * gdb/arc-tdep.c (arc_dummy_id): Delete.
14154         (arc_unwind_pc): Delete.
14155         (arc_unwind_sp): Delete.
14156         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
14157
14158 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
14159
14160         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
14161         (alpha_unwind_pc): Delete.
14162         (alpha_gdbarch_init): Don't register deleted functions with
14163         gdbarch.
14164
14165 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
14166
14167         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
14168         (aarch64_unwind_pc): Delete.
14169         (aarch64_unwind_sp): Delete.
14170         (aarch64_gdbarch_init): Don't register deleted functions with
14171         gdbarch.
14172
14173 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
14174
14175         * gdbtypes.c (type_align): Don't consider static members when
14176         computing structure alignment.
14177
14178 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
14179
14180         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
14181         return 0 for other types.
14182         * arch-utils.c (default_type_align): Always return 0.
14183         * gdbarch.h: Regenerate.
14184         * gdbarch.sh (type_align): Extend comment.
14185         * gdbtypes.c (type_align): Add additional comments, always call
14186         gdbarch_type_align before applying the default rules.
14187         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
14188         generic code will then apply a suitable default.
14189         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
14190         types, return 0 for other types.
14191
14192 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
14193
14194         * NEWS: Create a new section for the next release branch.
14195         Rename the section of the current branch, now that it has
14196         been cut.
14197
14198 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
14199
14200         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
14201         * version.in: Bump version to 8.3.50.DATE-git.
14202
14203 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
14204
14205         * aix-thread.c (ptid_cmp): Remove unused variable.
14206         (get_signaled_thread): Likewise.
14207         (store_regs_user_thread): Likewise.
14208         (store_regs_kernel_thread): Likewise.
14209         (fetch_regs_kernel_thread): Remove shadowed variable.
14210
14211 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
14212
14213         * features/riscv/32bit-cpu.xml: Add register numbers.
14214         * features/riscv/32bit-fpu.c: Regenerate.
14215         * features/riscv/32bit-fpu.xml: Add register numbers.
14216         * features/riscv/64bit-cpu.xml: Add register numbers.
14217         * features/riscv/64bit-fpu.c: Regenerate.
14218         * features/riscv/64bit-fpu.xml: Add register numbers.
14219
14220 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
14221
14222         * NEWS: Mention two argument form of gdb.Value constructor.
14223         * python/py-value.c (convert_buffer_and_type_to_value): New
14224         function.
14225         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
14226         Add support for handling an optional second argument.  Call
14227         convert_buffer_and_type_to_value as appropriate.
14228         * python/python-internal.h (Py_buffer_deleter): New struct.
14229         (Py_buffer_up): New typedef.
14230
14231 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
14232
14233         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
14234         instead of releasing ownership.
14235
14236 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
14237
14238         * dwarf2read.c (open_and_init_dwp_file): Call
14239         elf_numsections instead of bfd_count_sections to initialize
14240         dwp_file->num_sections.
14241
14242 2019-02-25  Tom Tromey  <tromey@adacore.com>
14243
14244         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
14245
14246 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
14247
14248         * gcore.in: Add '--readnever' option when invoking GDB.
14249
14250 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
14251
14252         * MAINTAINERS: Update my email address.
14253
14254 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
14255
14256         * build-id.c (build_id_to_debug_bfd_1): New function.
14257         (build_id_to_debug_bfd): Look for separate debug file in
14258         sysroot.
14259
14260 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
14261
14262         * gdbarch.sh: Update the copyright year range that is placed into
14263         generated files.
14264
14265 2019-02-22  Keith Seitz  <keiths@redhat.com>
14266
14267         PR symtab/23853
14268         * linespec.c (create_sals_line_offset): Search for the default
14269         symtab's filename instead of its fullname.
14270
14271 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
14272
14273         * NEWS: Update style defaults.
14274
14275 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
14276
14277         * main.c (captured_main_1): Disable styling in batch mode.
14278
14279 2019-02-20  Tom Tromey  <tom@tromey.com>
14280
14281         * symtab.c (symtab_symbol_info): Fix typos.
14282
14283 2019-02-20  Tom Tromey  <tromey@adacore.com>
14284
14285         * findcmd.c (_initialize_mem_search): Use upper case for
14286         metasyntactic variables.
14287
14288 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
14289
14290         * aarch64-tdep.c (aarch64_add_reggroups): New function.
14291         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
14292
14293 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
14294
14295         * top.h (source_file_name): Change to std::string.
14296         * top.c (source_file_name): Likewise.
14297         (command_line_input): Adjust.
14298         * cli/cli-script.c (script_from_file): Adjust.
14299
14300 2019-02-19  Tom Tromey  <tromey@adacore.com>
14301
14302         * ravenscar-thread.c
14303         (ravenscar_thread_target::update_thread_list): Don't call
14304         ada_build_task_list.
14305         * ada-lang.h (ada_build_task_list): Don't declare.
14306         * ada-tasks.c (struct ada_tasks_inferior_data)
14307         <task_list_valid_p>: Now bool.
14308         (read_known_tasks, ada_task_list_changed)
14309         (ada_tasks_invalidate_inferior_data): Update.
14310         (read_known_tasks_array): Return bool.
14311         (read_known_tasks_list): Likewise.
14312         (read_known_tasks): Return void.
14313         (ada_build_task_list): Now static.
14314
14315 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
14316
14317         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
14318         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
14319
14320 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
14321
14322         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
14323         variant for ada_tasks_pspace_data_handle and
14324         ada_tasks_inferior_data_handle.
14325         (ada_tasks_pspace_data_cleanup): New function.
14326         (ada_tasks_inferior_data_cleanup): New function.
14327
14328 2019-02-17  Tom Tromey  <tom@tromey.com>
14329
14330         * macrotab.h (macro_source_fullname): Return a std::string.
14331         * macrotab.c (macro_include, check_for_redefinition)
14332         (macro_undef, macro_lookup_definition, foreach_macro)
14333         (foreach_macro_in_scope): Update.
14334         (macro_source_fullname): Return a std::string.
14335         * macrocmd.c (show_pp_source_pos): Update.
14336
14337 2019-02-17  Tom Tromey  <tom@tromey.com>
14338
14339         * macrocmd.c (show_pp_source_pos): Style the file names.
14340
14341 2019-02-17  Tom Tromey  <tom@tromey.com>
14342
14343         PR tui/24197:
14344         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
14345
14346 2019-02-17  Tom Tromey  <tom@tromey.com>
14347
14348         * ada-lang.c (user_select_syms): Use filtered printing.
14349         * utils.c (wrap_style): New global.
14350         (desired_style): Remove.
14351         (emit_style_escape): Add stream parameter.
14352         (set_output_style, reset_terminal_style, prompt_for_continue):
14353         Update.
14354         (flush_wrap_buffer): Only flush gdb_stdout.
14355         (wrap_here): Set wrap_style.
14356         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
14357         treat escape sequences as a character.  Change when wrap buffer is
14358         flushed.
14359         (fputs_styled): Do not set the output style when the default is
14360         requested.
14361         * ui-style.h (struct ui_file_style) <is_default>: New method.
14362         * source.c (print_source_lines_base): Emit escape sequences in one
14363         piece.
14364
14365 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
14366
14367         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
14368         integers and enumeration types.
14369
14370 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
14371
14372         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
14373         instead of lookup_symbol_in_language
14374         (do_exact_match): New function.
14375         (ada_get_symbol_name_matcher): Return do_exact_match when
14376         doing a verbatim match.
14377
14378 2019-02-15  Tom Tromey  <tromey@adacore.com>
14379
14380         * ravenscar-thread.c (ravenscar_thread_target::resume)
14381         (ravenscar_thread_target::wait): Special case wildcard requests.
14382
14383 2019-02-15  Tom Tromey  <tromey@adacore.com>
14384
14385         * ravenscar-thread.c (base_ptid): Remove.
14386         (struct ravenscar_thread_target) <close>: New method.
14387         <m_base_ptid>: New member.
14388         <update_inferior_ptid, active_task, task_is_currently_active,
14389         runtime_initialized>: Declare methods.
14390         <ravenscar_thread_target>: Add constructor.
14391         (ravenscar_thread_target::task_is_currently_active)
14392         (ravenscar_thread_target::update_inferior_ptid)
14393         (ravenscar_runtime_initialized): Rename.  Now methods.
14394         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
14395         (ravenscar_thread_target::update_thread_list): Update.
14396         (ravenscar_thread_target::active_task): Now method.
14397         (ravenscar_thread_target::store_registers)
14398         (ravenscar_thread_target::prepare_to_store)
14399         (ravenscar_thread_target::prepare_to_store)
14400         (ravenscar_thread_target::mourn_inferior): Update.
14401         (ravenscar_inferior_created): Use "new" to create target.
14402         (ravenscar_thread_target::get_ada_task_ptid): Update.
14403         (_initialize_ravenscar): Don't initialize base_ptid.
14404         (ravenscar_ops): Remove global.
14405
14406 2019-02-15  Tom Tromey  <tromey@adacore.com>
14407
14408         * target.h (push_target): Declare new overload.
14409         * target.c (push_target): New overload, taking an rvalue reference.
14410         * remote.c (remote_target::open_1): Use push_target overload.
14411         * corelow.c (core_target_open): Use push_target overload.
14412
14413 2019-02-15  Tom Tromey  <tromey@adacore.com>
14414
14415         * ravenscar-thread.c (is_ravenscar_task)
14416         (ravenscar_task_is_currently_active): Return bool.
14417         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
14418         (_initialize_ravenscar): Remove "(void)".
14419         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
14420         Return bool.
14421
14422 2019-02-15  Tom Tromey  <tromey@adacore.com>
14423
14424         * ravenscar-thread.c (ravenscar_runtime_initializer)
14425         (has_ravenscar_runtime, get_running_thread_id)
14426         (ravenscar_thread_target::resume): Fix indentation.
14427
14428 2019-02-15  Tom Tromey  <tromey@adacore.com>
14429
14430         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
14431         from ravenscar_arch_ops.
14432         (sparc_ravenscar_ops::fetch_registers)
14433         (sparc_ravenscar_ops::store_registers): Now methods.
14434         (sparc_ravenscar_prepare_to_store): Remove.
14435         (sparc_ravenscar_ops): Redefine.
14436         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
14437         methods and destructor.  Remove members.
14438         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
14439         (ravenscar_thread_target::store_registers)
14440         (ravenscar_thread_target::prepare_to_store): Update.
14441         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
14442         Remove.
14443         (struct ppc_ravenscar_powerpc_ops): Derive from
14444         ravenscar_arch_ops.
14445         (ppc_ravenscar_powerpc_ops::fetch_registers)
14446         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
14447         (ppc_ravenscar_powerpc_ops): Redefine.
14448         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
14449         (ppc_ravenscar_e500_ops::fetch_registers)
14450         (ppc_ravenscar_e500_ops::store_registers): Now methods.
14451         (ppc_ravenscar_e500_ops): Redefine.
14452         * aarch64-ravenscar-thread.c
14453         (aarch64_ravenscar_generic_prepare_to_store): Remove.
14454         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
14455         (aarch64_ravenscar_fetch_registers)
14456         (aarch64_ravenscar_store_registers): Now methods.
14457         (aarch64_ravenscar_ops): Redefine.
14458
14459 2019-02-15  Tom Tromey  <tromey@adacore.com>
14460
14461         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
14462         (ravenscar_thread_target::stopped_by_hw_breakpoint)
14463         (ravenscar_thread_target::stopped_by_watchpoint)
14464         (ravenscar_thread_target::stopped_data_address)
14465         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
14466
14467 2019-02-15  Tom Tromey  <tromey@adacore.com>
14468
14469         * ravenscar-thread.c: Fix some typos.
14470
14471 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
14472             Tom Tromey  <tromey@adacore.com>
14473
14474         * ada-lang.c (ada_exception_sal): Change addr_string to a
14475         std::string.
14476         (create_ada_exception_catchpoint): Update.
14477
14478 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
14479             Tom Tromey  <tromey@adacore.com>
14480
14481         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
14482         (bp_location_ops): Remove.
14483         (base_breakpoint_allocate_location): Update.
14484         (free_bp_location): Update.
14485         * ada-lang.c (class ada_catchpoint_location)
14486         <ada_catchpoint_location>: Remove ops parameter.
14487         (ada_catchpoint_location_dtor): Remove.
14488         (ada_catchpoint_location_ops): Remove.
14489         (allocate_location_exception): Update.
14490         * breakpoint.h (struct bp_location_ops): Remove.
14491         (class bp_location) <bp_location>: Remove bp_location_ops
14492         parameter.
14493         <~bp_location>: Add destructor.
14494         <ops>: Remove.
14495
14496 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
14497             Pedro Alves  <palves@redhat.com>
14498
14499         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
14500         'PATH_MAX'.
14501
14502 2019-02-14  David Michael  <fedora.dm0@gmail.com>
14503             Samuel Thibault  <samuel.thibault@gnu.org>
14504             Thomas Schwinge  <thomas@codesourcery.com>
14505
14506         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
14507         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
14508
14509 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
14510
14511         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
14512         (check_empty): Use "const char *".
14513
14514         * gnu-nat.c (gnu_nat_target::detach): Instead of
14515         'detach_inferior (pid)' call
14516         'detach_inferior (find_inferior_pid (pid))'.
14517
14518         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
14519         'nat/fork-inferior.o'.
14520         * gnu-nat.c: #include "nat/fork-inferior.h".
14521
14522         * gnu-nat.c (gnu_nat_target::detach): Instead of
14523         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
14524         * gnu-nat.h: #include "inf-child.h".
14525         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
14526         'i386_gnu_nat_target::fetch_registers'.
14527         (gnu_store_registers): Rename/move to
14528         'i386_gnu_nat_target::store_registers'.
14529
14530         * config/i386/nm-i386gnu.h: Don't "#include" any files.
14531         * gnu-nat.h (mach_thread_info): New function.
14532         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
14533
14534         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
14535
14536 2019-02-14  Frederic Konrad  <konrad@adacore.com>
14537
14538         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
14539
14540 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
14541
14542         * windows-nat.c (windows_add_thread): Add new parameter
14543         "main_thread_p" with default value set to false.  Update
14544         function documentation as well as all callers.
14545         (windows_delete_thread): Likewise.
14546         (fake_create_process): Update call to windows_add_thread.
14547         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
14548         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
14549         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
14550         call to windows_delete_thread.
14551
14552 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
14553
14554         * MAINTAINERS: Add Andrew Burgess as global maintainer.
14555
14556 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
14557
14558         * symfile.c (find_separate_debug_file): Use canonical path of
14559         sysroot with child_path instead of gdb_sysroot if it is valid.
14560
14561 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
14562
14563         * symfile.c (find_separate_debug_file): Use child_path to
14564         determine if an object file is under a sysroot.
14565
14566 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
14567
14568         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
14569         unittests/child-path-selftests.c.
14570         * common/pathstuff.c (child_path): New function.
14571         * common/pathstuff.h (child_path): New prototype.
14572         * unittests/child-path-selftests.c: New file.
14573
14574 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
14575
14576         * symfile.c (find_separate_debug_file): Look for separate debug
14577         files in debug directories under the sysroot.
14578
14579 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
14580
14581         * symtab.h (struct minimal_symbol data_p): New const method.
14582         (struct minimal_symbol text_p): Likewise.
14583         * symtab.c (output_source_filename): Use file name style
14584         to print file name.
14585         (print_symbol_info): Likewise.
14586         (print_msymbol_info): Use address style to print addresses.
14587         Use function name style to print executable text symbols.
14588         (expand_symtab_containing_pc): Use data_p.
14589         (find_pc_sect_compunit_symtab): Likewise.
14590
14591 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
14592
14593         * breakpoint.c (describe_other_breakpoints): Use address style
14594         to print addresses.
14595         (say_where): Likewise.
14596
14597 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
14598
14599         * ada-typeprint.c (print_func_type): Print function name
14600         style to print function name.
14601         * c-typeprint.c (c_print_type_1): Likewise.
14602
14603 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
14604
14605         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
14606         for execve.
14607
14608 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
14609
14610         * c-exp.y (direct_abs_decl): Use emplace_back to record the
14611         type_stack.
14612
14613 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
14614
14615         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
14616         TYPE_CODE_REF types.
14617
14618 2019-02-08  Jim Wilson  <jimw@sifive.com>
14619
14620         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
14621         (riscv_linux_fregset): New.
14622         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
14623
14624 2019-02-07  Tom Tromey  <tom@tromey.com>
14625
14626         * thread.c (thread_cancel_execution_command): Update.
14627         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
14628         methods.
14629         (struct thread_fsm_ops): Remove.
14630         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
14631         (thread_fsm_should_stop, thread_fsm_return_value)
14632         (thread_fsm_set_finished, thread_fsm_finished_p)
14633         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
14634         Don't declare.
14635         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
14636         * infrun.c (clear_proceed_status_thread)
14637         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
14638         (print_stop_event): Update.
14639         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
14640         Add constructor.
14641         (step_command_fsm_ops): Remove.
14642         (new_step_command_fsm): Remove.
14643         (step_1): Update.
14644         (step_command_fsm::should_stop): Rename from
14645         step_command_fsm_should_stop.
14646         (step_command_fsm::clean_up): Rename from
14647         step_command_fsm_clean_up.
14648         (step_command_fsm::do_async_reply_reason): Rename from
14649         step_command_fsm_async_reply_reason.
14650         (struct until_next_fsm): Inherit from thread_fsm.  Add
14651         constructor.
14652         (until_next_fsm_ops): Remove.
14653         (new_until_next_fsm): Remove.
14654         (until_next_fsm::should_stop): Rename from
14655         until_next_fsm_should_stop.
14656         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
14657         (until_next_fsm::do_async_reply_reason): Rename from
14658         until_next_fsm_async_reply_reason.
14659         (struct finish_command_fsm): Inherit from thread_fsm.  Add
14660         constructor.  Change type of breakpoint.
14661         (finish_command_fsm_ops): Remove.
14662         (new_finish_command_fsm): Remove.
14663         (finish_command_fsm::should_stop): Rename from
14664         finish_command_fsm_should_stop.
14665         (finish_command_fsm::clean_up): Rename from
14666         finish_command_fsm_clean_up.
14667         (finish_command_fsm::return_value): Rename from
14668         finish_command_fsm_return_value.
14669         (finish_command_fsm::do_async_reply_reason): Rename from
14670         finish_command_fsm_async_reply_reason.
14671         (finish_command): Update.
14672         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
14673         Add constructor.
14674         (call_thread_fsm_ops): Remove.
14675         (call_thread_fsm::call_thread_fsm): Rename from
14676         new_call_thread_fsm.
14677         (call_thread_fsm::should_stop): Rename from
14678         call_thread_fsm_should_stop.
14679         (call_thread_fsm::should_notify_stop): Rename from
14680         call_thread_fsm_should_notify_stop.
14681         (run_inferior_call, call_function_by_hand_dummy): Update.
14682         * cli/cli-interp.c (should_print_stop_to_console): Update.
14683         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
14684         Add constructor.  Change type of location_breakpoint,
14685         caller_breakpoint.
14686         (until_break_fsm_ops): Remove.
14687         (new_until_break_fsm): Remove.
14688         (until_break_fsm::should_stop): Rename from
14689         until_break_fsm_should_stop.
14690         (until_break_fsm::clean_up): Rename from
14691         until_break_fsm_clean_up.
14692         (until_break_fsm::do_async_reply_reason): Rename from
14693         until_break_fsm_async_reply_reason.
14694         (until_break_command): Update.
14695         * thread-fsm.c: Remove.
14696         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
14697
14698 2019-02-07  Tom Tromey  <tom@tromey.com>
14699
14700         * yy-remap.h: Add include guard.
14701         * xtensa-tdep.h: Add include guard.
14702         * xcoffread.h: Rename include guard.
14703         * varobj-iter.h: Add include guard.
14704         * tui/tui.h: Rename include guard.
14705         * tui/tui-winsource.h: Rename include guard.
14706         * tui/tui-wingeneral.h: Rename include guard.
14707         * tui/tui-windata.h: Rename include guard.
14708         * tui/tui-win.h: Rename include guard.
14709         * tui/tui-stack.h: Rename include guard.
14710         * tui/tui-source.h: Rename include guard.
14711         * tui/tui-regs.h: Rename include guard.
14712         * tui/tui-out.h: Rename include guard.
14713         * tui/tui-layout.h: Rename include guard.
14714         * tui/tui-io.h: Rename include guard.
14715         * tui/tui-hooks.h: Rename include guard.
14716         * tui/tui-file.h: Rename include guard.
14717         * tui/tui-disasm.h: Rename include guard.
14718         * tui/tui-data.h: Rename include guard.
14719         * tui/tui-command.h: Rename include guard.
14720         * tic6x-tdep.h: Add include guard.
14721         * target/waitstatus.h: Rename include guard.
14722         * target/wait.h: Rename include guard.
14723         * target/target.h: Rename include guard.
14724         * target/resume.h: Rename include guard.
14725         * target-float.h: Rename include guard.
14726         * stabsread.h: Add include guard.
14727         * rs6000-tdep.h: Add include guard.
14728         * riscv-fbsd-tdep.h: Add include guard.
14729         * regformats/regdef.h: Rename include guard.
14730         * record.h: Rename include guard.
14731         * python/python.h: Rename include guard.
14732         * python/python-internal.h: Rename include guard.
14733         * python/py-stopevent.h: Rename include guard.
14734         * python/py-ref.h: Rename include guard.
14735         * python/py-record.h: Rename include guard.
14736         * python/py-record-full.h: Rename include guard.
14737         * python/py-record-btrace.h: Rename include guard.
14738         * python/py-instruction.h: Rename include guard.
14739         * python/py-events.h: Rename include guard.
14740         * python/py-event.h: Rename include guard.
14741         * procfs.h: Add include guard.
14742         * proc-utils.h: Add include guard.
14743         * p-lang.h: Add include guard.
14744         * or1k-tdep.h: Rename include guard.
14745         * observable.h: Rename include guard.
14746         * nto-tdep.h: Rename include guard.
14747         * nat/x86-linux.h: Rename include guard.
14748         * nat/x86-linux-dregs.h: Rename include guard.
14749         * nat/x86-gcc-cpuid.h: Add include guard.
14750         * nat/x86-dregs.h: Rename include guard.
14751         * nat/x86-cpuid.h: Rename include guard.
14752         * nat/ppc-linux.h: Rename include guard.
14753         * nat/mips-linux-watch.h: Rename include guard.
14754         * nat/linux-waitpid.h: Rename include guard.
14755         * nat/linux-ptrace.h: Rename include guard.
14756         * nat/linux-procfs.h: Rename include guard.
14757         * nat/linux-osdata.h: Rename include guard.
14758         * nat/linux-nat.h: Rename include guard.
14759         * nat/linux-namespaces.h: Rename include guard.
14760         * nat/linux-btrace.h: Rename include guard.
14761         * nat/glibc_thread_db.h: Rename include guard.
14762         * nat/gdb_thread_db.h: Rename include guard.
14763         * nat/gdb_ptrace.h: Rename include guard.
14764         * nat/fork-inferior.h: Rename include guard.
14765         * nat/amd64-linux-siginfo.h: Rename include guard.
14766         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
14767         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
14768         * nat/aarch64-linux.h: Rename include guard.
14769         * nat/aarch64-linux-hw-point.h: Rename include guard.
14770         * mn10300-tdep.h: Add include guard.
14771         * mips-linux-tdep.h: Add include guard.
14772         * mi/mi-parse.h: Rename include guard.
14773         * mi/mi-out.h: Rename include guard.
14774         * mi/mi-main.h: Rename include guard.
14775         * mi/mi-interp.h: Rename include guard.
14776         * mi/mi-getopt.h: Rename include guard.
14777         * mi/mi-console.h: Rename include guard.
14778         * mi/mi-common.h: Rename include guard.
14779         * mi/mi-cmds.h: Rename include guard.
14780         * mi/mi-cmd-break.h: Rename include guard.
14781         * m2-lang.h: Add include guard.
14782         * location.h: Rename include guard.
14783         * linux-record.h: Rename include guard.
14784         * linux-nat.h: Add include guard.
14785         * linux-fork.h: Add include guard.
14786         * i386-darwin-tdep.h: Rename include guard.
14787         * hppa-linux-offsets.h: Add include guard.
14788         * guile/guile.h: Rename include guard.
14789         * guile/guile-internal.h: Rename include guard.
14790         * gnu-nat.h: Rename include guard.
14791         * gdb-stabs.h: Rename include guard.
14792         * frv-tdep.h: Add include guard.
14793         * f-lang.h: Add include guard.
14794         * event-loop.h: Add include guard.
14795         * darwin-nat.h: Rename include guard.
14796         * cp-abi.h: Rename include guard.
14797         * config/sparc/nm-sol2.h: Rename include guard.
14798         * config/nm-nto.h: Rename include guard.
14799         * config/nm-linux.h: Add include guard.
14800         * config/i386/nm-i386gnu.h: Rename include guard.
14801         * config/djgpp/nl_types.h: Rename include guard.
14802         * config/djgpp/langinfo.h: Rename include guard.
14803         * compile/gcc-cp-plugin.h: Add include guard.
14804         * compile/gcc-c-plugin.h: Add include guard.
14805         * compile/compile.h: Rename include guard.
14806         * compile/compile-object-run.h: Rename include guard.
14807         * compile/compile-object-load.h: Rename include guard.
14808         * compile/compile-internal.h: Rename include guard.
14809         * compile/compile-cplus.h: Rename include guard.
14810         * compile/compile-c.h: Rename include guard.
14811         * common/xml-utils.h: Rename include guard.
14812         * common/x86-xstate.h: Rename include guard.
14813         * common/version.h: Rename include guard.
14814         * common/vec.h: Rename include guard.
14815         * common/tdesc.h: Rename include guard.
14816         * common/selftest.h: Rename include guard.
14817         * common/scoped_restore.h: Rename include guard.
14818         * common/scoped_mmap.h: Rename include guard.
14819         * common/scoped_fd.h: Rename include guard.
14820         * common/safe-iterator.h: Rename include guard.
14821         * common/run-time-clock.h: Rename include guard.
14822         * common/refcounted-object.h: Rename include guard.
14823         * common/queue.h: Rename include guard.
14824         * common/ptid.h: Rename include guard.
14825         * common/print-utils.h: Rename include guard.
14826         * common/preprocessor.h: Rename include guard.
14827         * common/pathstuff.h: Rename include guard.
14828         * common/observable.h: Rename include guard.
14829         * common/netstuff.h: Rename include guard.
14830         * common/job-control.h: Rename include guard.
14831         * common/host-defs.h: Rename include guard.
14832         * common/gdb_wait.h: Rename include guard.
14833         * common/gdb_vecs.h: Rename include guard.
14834         * common/gdb_unlinker.h: Rename include guard.
14835         * common/gdb_unique_ptr.h: Rename include guard.
14836         * common/gdb_tilde_expand.h: Rename include guard.
14837         * common/gdb_sys_time.h: Rename include guard.
14838         * common/gdb_string_view.h: Rename include guard.
14839         * common/gdb_splay_tree.h: Rename include guard.
14840         * common/gdb_setjmp.h: Rename include guard.
14841         * common/gdb_ref_ptr.h: Rename include guard.
14842         * common/gdb_optional.h: Rename include guard.
14843         * common/gdb_locale.h: Rename include guard.
14844         * common/gdb_assert.h: Rename include guard.
14845         * common/filtered-iterator.h: Rename include guard.
14846         * common/filestuff.h: Rename include guard.
14847         * common/fileio.h: Rename include guard.
14848         * common/environ.h: Rename include guard.
14849         * common/common-utils.h: Rename include guard.
14850         * common/common-types.h: Rename include guard.
14851         * common/common-regcache.h: Rename include guard.
14852         * common/common-inferior.h: Rename include guard.
14853         * common/common-gdbthread.h: Rename include guard.
14854         * common/common-exceptions.h: Rename include guard.
14855         * common/common-defs.h: Rename include guard.
14856         * common/common-debug.h: Rename include guard.
14857         * common/cleanups.h: Rename include guard.
14858         * common/buffer.h: Rename include guard.
14859         * common/btrace-common.h: Rename include guard.
14860         * common/break-common.h: Rename include guard.
14861         * cli/cli-utils.h: Rename include guard.
14862         * cli/cli-style.h: Rename include guard.
14863         * cli/cli-setshow.h: Rename include guard.
14864         * cli/cli-script.h: Rename include guard.
14865         * cli/cli-interp.h: Rename include guard.
14866         * cli/cli-decode.h: Rename include guard.
14867         * cli/cli-cmds.h: Rename include guard.
14868         * charset-list.h: Add include guard.
14869         * buildsym-legacy.h: Rename include guard.
14870         * bfin-tdep.h: Add include guard.
14871         * ax.h: Rename include guard.
14872         * arm-linux-tdep.h: Add include guard.
14873         * arm-fbsd-tdep.h: Add include guard.
14874         * arch/xtensa.h: Rename include guard.
14875         * arch/tic6x.h: Add include guard.
14876         * arch/i386.h: Add include guard.
14877         * arch/arm.h: Rename include guard.
14878         * arch/arm-linux.h: Rename include guard.
14879         * arch/arm-get-next-pcs.h: Rename include guard.
14880         * arch/amd64.h: Add include guard.
14881         * arch/aarch64-insn.h: Rename include guard.
14882         * arch-utils.h: Rename include guard.
14883         * annotate.h: Add include guard.
14884         * amd64-darwin-tdep.h: Rename include guard.
14885         * aarch64-linux-tdep.h: Add include guard.
14886         * aarch64-fbsd-tdep.h: Add include guard.
14887         * aarch32-linux-nat.h: Add include guard.
14888
14889 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
14890
14891         * macrotab.c (macro_define_internal): New function that
14892         factorizes macro_define_object_internal and macro_define_function
14893         code.
14894         (macro_define_object_internal): Use macro_define_internal.
14895         (macro_define_function): Likewise.
14896
14897 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
14898
14899         * macrocmd.c (extract_identifier): Return
14900         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
14901         callers.
14902
14903 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
14904
14905         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
14906
14907 2019-02-05  Tom Tromey  <tom@tromey.com>
14908
14909         * target.c (target_stack::unpush): Move assertion earlier.
14910
14911 2019-01-30  Tom Tromey  <tom@tromey.com>
14912
14913         PR python/23615:
14914         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
14915         (gdbpy_parse_and_eval): Likewise.
14916         * python/python-internal.h (gdbpy_allow_threads): New class.
14917
14918 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
14919
14920         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
14921         (aarch64_fbsd_fpregmap): Move earlier.
14922         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
14923         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
14924         instead of individual calls to trad_frame_set_reg_addr.
14925         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
14926         earlier.
14927         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
14928         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
14929         instead of individual calls to trad_frame_set_reg_addr.
14930
14931 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
14932
14933         * CONTRIBUTE: Replace contribution list with wiki link.
14934
14935 2019-01-25  Tom Tromey  <tom@tromey.com>
14936
14937         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
14938
14939 2019-01-25  Tom Tromey  <tom@tromey.com>
14940
14941         * xtensa-linux-nat.c: Fix common/ includes.
14942         * xml-support.h: Fix common/ includes.
14943         * xml-support.c: Fix common/ includes.
14944         * x86-linux-nat.c: Fix common/ includes.
14945         * windows-nat.c: Fix common/ includes.
14946         * varobj.h: Fix common/ includes.
14947         * varobj.c: Fix common/ includes.
14948         * value.c: Fix common/ includes.
14949         * valops.c: Fix common/ includes.
14950         * utils.c: Fix common/ includes.
14951         * unittests/xml-utils-selftests.c: Fix common/ includes.
14952         * unittests/utils-selftests.c: Fix common/ includes.
14953         * unittests/unpack-selftests.c: Fix common/ includes.
14954         * unittests/tracepoint-selftests.c: Fix common/ includes.
14955         * unittests/style-selftests.c: Fix common/ includes.
14956         * unittests/string_view-selftests.c: Fix common/ includes.
14957         * unittests/scoped_restore-selftests.c: Fix common/ includes.
14958         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
14959         * unittests/scoped_fd-selftests.c: Fix common/ includes.
14960         * unittests/rsp-low-selftests.c: Fix common/ includes.
14961         * unittests/parse-connection-spec-selftests.c: Fix common/
14962         includes.
14963         * unittests/optional-selftests.c: Fix common/ includes.
14964         * unittests/offset-type-selftests.c: Fix common/ includes.
14965         * unittests/observable-selftests.c: Fix common/ includes.
14966         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
14967         * unittests/memrange-selftests.c: Fix common/ includes.
14968         * unittests/memory-map-selftests.c: Fix common/ includes.
14969         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
14970         * unittests/function-view-selftests.c: Fix common/ includes.
14971         * unittests/environ-selftests.c: Fix common/ includes.
14972         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
14973         * unittests/common-utils-selftests.c: Fix common/ includes.
14974         * unittests/cli-utils-selftests.c: Fix common/ includes.
14975         * unittests/array-view-selftests.c: Fix common/ includes.
14976         * ui-file.c: Fix common/ includes.
14977         * tui/tui-io.c: Fix common/ includes.
14978         * tracepoint.h: Fix common/ includes.
14979         * tracepoint.c: Fix common/ includes.
14980         * tracefile-tfile.c: Fix common/ includes.
14981         * top.h: Fix common/ includes.
14982         * top.c: Fix common/ includes.
14983         * thread.c: Fix common/ includes.
14984         * target/waitstatus.h: Fix common/ includes.
14985         * target/waitstatus.c: Fix common/ includes.
14986         * target.h: Fix common/ includes.
14987         * target.c: Fix common/ includes.
14988         * target-memory.c: Fix common/ includes.
14989         * target-descriptions.c: Fix common/ includes.
14990         * symtab.h: Fix common/ includes.
14991         * symfile.c: Fix common/ includes.
14992         * stap-probe.c: Fix common/ includes.
14993         * spu-linux-nat.c: Fix common/ includes.
14994         * sparc-nat.c: Fix common/ includes.
14995         * source.c: Fix common/ includes.
14996         * solib.c: Fix common/ includes.
14997         * solib-target.c: Fix common/ includes.
14998         * ser-unix.c: Fix common/ includes.
14999         * ser-tcp.c: Fix common/ includes.
15000         * ser-pipe.c: Fix common/ includes.
15001         * ser-base.c: Fix common/ includes.
15002         * selftest-arch.c: Fix common/ includes.
15003         * s12z-tdep.c: Fix common/ includes.
15004         * rust-exp.y: Fix common/ includes.
15005         * rs6000-aix-tdep.c: Fix common/ includes.
15006         * riscv-tdep.c: Fix common/ includes.
15007         * remote.c: Fix common/ includes.
15008         * remote-notif.h: Fix common/ includes.
15009         * remote-fileio.h: Fix common/ includes.
15010         * remote-fileio.c: Fix common/ includes.
15011         * regcache.h: Fix common/ includes.
15012         * regcache.c: Fix common/ includes.
15013         * record-btrace.c: Fix common/ includes.
15014         * python/python.c: Fix common/ includes.
15015         * python/py-type.c: Fix common/ includes.
15016         * python/py-inferior.c: Fix common/ includes.
15017         * progspace.h: Fix common/ includes.
15018         * producer.c: Fix common/ includes.
15019         * procfs.c: Fix common/ includes.
15020         * proc-api.c: Fix common/ includes.
15021         * printcmd.c: Fix common/ includes.
15022         * ppc-linux-nat.c: Fix common/ includes.
15023         * parser-defs.h: Fix common/ includes.
15024         * osdata.c: Fix common/ includes.
15025         * obsd-nat.c: Fix common/ includes.
15026         * nat/x86-linux.c: Fix common/ includes.
15027         * nat/x86-linux-dregs.c: Fix common/ includes.
15028         * nat/x86-dregs.h: Fix common/ includes.
15029         * nat/x86-dregs.c: Fix common/ includes.
15030         * nat/ppc-linux.c: Fix common/ includes.
15031         * nat/mips-linux-watch.h: Fix common/ includes.
15032         * nat/mips-linux-watch.c: Fix common/ includes.
15033         * nat/linux-waitpid.c: Fix common/ includes.
15034         * nat/linux-ptrace.h: Fix common/ includes.
15035         * nat/linux-ptrace.c: Fix common/ includes.
15036         * nat/linux-procfs.c: Fix common/ includes.
15037         * nat/linux-personality.c: Fix common/ includes.
15038         * nat/linux-osdata.c: Fix common/ includes.
15039         * nat/linux-namespaces.c: Fix common/ includes.
15040         * nat/linux-btrace.h: Fix common/ includes.
15041         * nat/linux-btrace.c: Fix common/ includes.
15042         * nat/fork-inferior.c: Fix common/ includes.
15043         * nat/amd64-linux-siginfo.c: Fix common/ includes.
15044         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
15045         * nat/aarch64-linux.c: Fix common/ includes.
15046         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
15047         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
15048         * namespace.h: Fix common/ includes.
15049         * mips-linux-tdep.c: Fix common/ includes.
15050         * minsyms.c: Fix common/ includes.
15051         * mi/mi-parse.h: Fix common/ includes.
15052         * mi/mi-main.c: Fix common/ includes.
15053         * mi/mi-cmd-env.c: Fix common/ includes.
15054         * memrange.h: Fix common/ includes.
15055         * memattr.c: Fix common/ includes.
15056         * maint.h: Fix common/ includes.
15057         * maint.c: Fix common/ includes.
15058         * main.c: Fix common/ includes.
15059         * machoread.c: Fix common/ includes.
15060         * location.c: Fix common/ includes.
15061         * linux-thread-db.c: Fix common/ includes.
15062         * linux-nat.c: Fix common/ includes.
15063         * linux-fork.c: Fix common/ includes.
15064         * inline-frame.c: Fix common/ includes.
15065         * infrun.c: Fix common/ includes.
15066         * inflow.c: Fix common/ includes.
15067         * inferior.h: Fix common/ includes.
15068         * inferior.c: Fix common/ includes.
15069         * infcmd.c: Fix common/ includes.
15070         * inf-ptrace.c: Fix common/ includes.
15071         * inf-child.c: Fix common/ includes.
15072         * ia64-linux-nat.c: Fix common/ includes.
15073         * i387-tdep.c: Fix common/ includes.
15074         * i386-tdep.c: Fix common/ includes.
15075         * i386-linux-tdep.c: Fix common/ includes.
15076         * i386-linux-nat.c: Fix common/ includes.
15077         * i386-go32-tdep.c: Fix common/ includes.
15078         * i386-fbsd-tdep.c: Fix common/ includes.
15079         * i386-fbsd-nat.c: Fix common/ includes.
15080         * guile/scm-type.c: Fix common/ includes.
15081         * guile/guile.c: Fix common/ includes.
15082         * go32-nat.c: Fix common/ includes.
15083         * gnu-nat.c: Fix common/ includes.
15084         * gdbthread.h: Fix common/ includes.
15085         * gdbarch-selftests.c: Fix common/ includes.
15086         * gdb_usleep.c: Fix common/ includes.
15087         * gdb_select.h: Fix common/ includes.
15088         * gdb_bfd.c: Fix common/ includes.
15089         * gcore.c: Fix common/ includes.
15090         * fork-child.c: Fix common/ includes.
15091         * findvar.c: Fix common/ includes.
15092         * fbsd-nat.c: Fix common/ includes.
15093         * event-top.c: Fix common/ includes.
15094         * event-loop.c: Fix common/ includes.
15095         * dwarf2read.c: Fix common/ includes.
15096         * dwarf2loc.c: Fix common/ includes.
15097         * dwarf2-frame.c: Fix common/ includes.
15098         * dwarf-index-cache.c: Fix common/ includes.
15099         * dtrace-probe.c: Fix common/ includes.
15100         * disasm-selftests.c: Fix common/ includes.
15101         * defs.h: Fix common/ includes.
15102         * csky-tdep.c: Fix common/ includes.
15103         * cp-valprint.c: Fix common/ includes.
15104         * cp-support.h: Fix common/ includes.
15105         * cp-support.c: Fix common/ includes.
15106         * corelow.c: Fix common/ includes.
15107         * completer.h: Fix common/ includes.
15108         * completer.c: Fix common/ includes.
15109         * compile/compile.c: Fix common/ includes.
15110         * compile/compile-loc2c.c: Fix common/ includes.
15111         * compile/compile-cplus-types.c: Fix common/ includes.
15112         * compile/compile-cplus-symbols.c: Fix common/ includes.
15113         * command.h: Fix common/ includes.
15114         * cli/cli-dump.c: Fix common/ includes.
15115         * cli/cli-cmds.c: Fix common/ includes.
15116         * charset.c: Fix common/ includes.
15117         * build-id.c: Fix common/ includes.
15118         * btrace.h: Fix common/ includes.
15119         * btrace.c: Fix common/ includes.
15120         * breakpoint.h: Fix common/ includes.
15121         * breakpoint.c: Fix common/ includes.
15122         * ax.h:
15123         (enum agent_op): Fix common/ includes.
15124         * ax-general.c (struct aop_map): Fix common/ includes.
15125         * ax-gdb.c: Fix common/ includes.
15126         * auxv.c: Fix common/ includes.
15127         * auto-load.c: Fix common/ includes.
15128         * arm-tdep.c: Fix common/ includes.
15129         * arch/riscv.c: Fix common/ includes.
15130         * arch/ppc-linux-common.c: Fix common/ includes.
15131         * arch/i386.c: Fix common/ includes.
15132         * arch/arm.c: Fix common/ includes.
15133         * arch/arm-linux.c: Fix common/ includes.
15134         * arch/arm-get-next-pcs.c: Fix common/ includes.
15135         * arch/amd64.c: Fix common/ includes.
15136         * arch/aarch64.c: Fix common/ includes.
15137         * arch/aarch64-insn.c: Fix common/ includes.
15138         * arch-utils.c: Fix common/ includes.
15139         * amd64-windows-tdep.c: Fix common/ includes.
15140         * amd64-tdep.c: Fix common/ includes.
15141         * amd64-sol2-tdep.c: Fix common/ includes.
15142         * amd64-obsd-tdep.c: Fix common/ includes.
15143         * amd64-nbsd-tdep.c: Fix common/ includes.
15144         * amd64-linux-tdep.c: Fix common/ includes.
15145         * amd64-linux-nat.c: Fix common/ includes.
15146         * amd64-fbsd-tdep.c: Fix common/ includes.
15147         * amd64-fbsd-nat.c: Fix common/ includes.
15148         * amd64-dicos-tdep.c: Fix common/ includes.
15149         * amd64-darwin-tdep.c: Fix common/ includes.
15150         * agent.c: Fix common/ includes.
15151         * ada-lang.h: Fix common/ includes.
15152         * ada-lang.c: Fix common/ includes.
15153         * aarch64-tdep.c: Fix common/ includes.
15154
15155 2019-01-25  Tom Tromey  <tom@tromey.com>
15156
15157         * common/create-version.sh: Use common/version.h.
15158
15159 2019-01-24  Pedro Alves  <palves@redhat.com>
15160
15161         * infrun.c (signal_stop, signal_print, signal_program)
15162         (signal_catch, signal_pass): Now arrays instead of pointers.
15163         (update_signals_program_target, do_target_resume)
15164         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
15165         * linux-nat.c (linux_nat_target::pass_signals)
15166         (linux_nat_target::create_inferior, linux_nat_target::attach):
15167         Adjust.
15168         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
15169         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
15170         * procfs.c (procfs_target::pass_signals): Adjust.
15171         * record-full.c (record_full_target::resume): Adjust.
15172         * remote.c (remote_target::pass_signals)
15173         (remote_target::program_signals): Adjust.
15174         * target-debug.h (target_debug_print_signals): Now takes a
15175         gdb::array_view as parameter.  Adjust.
15176         * target.h (target_ops) <pass_signals, program_signals>: Replace
15177         pointer and length parameters with gdb::array_view.
15178         (target_pass_signals, target_program_signals): Likewise.
15179         * target-delegates.c: Regenerate.
15180
15181 2019-01-24  Pedro Alves  <palves@redhat.com>
15182
15183         * common/forward-scope-exit.h
15184         (forward_scope_exit::forward_scope_exit): Pass arguments to
15185         m_bind_function directly, instead of creating a std::bind and
15186         copying that.
15187
15188 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
15189
15190         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
15191         for static members.
15192         (pass_in_v_vfp_candidate): Likewise.
15193
15194 2019-01-23  Tom Tromey  <tom@tromey.com>
15195             Pedro Alves  <palves@redhat.com>
15196
15197         * regcache.c (class regcache_invalidator): Remove.
15198         (regcache::raw_write): Use make_scope_exit.
15199
15200 2019-01-23  Tom Tromey  <tom@tromey.com>
15201
15202         * ui-out.h (class ui_out_emit_type): Update comment.
15203
15204 2019-01-23  Tom Tromey  <tom@tromey.com>
15205
15206         * infrun.c (fetch_inferior_event): Update comment.
15207
15208 2019-01-23  Tom Tromey  <tom@tromey.com>
15209             Pedro Alves  <palves@redhat.com>
15210
15211         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
15212         parameter.
15213         (fetch_inferior_event): Use SCOPE_EXIT.
15214
15215
15216 2019-01-23  Tom Tromey  <tom@tromey.com>
15217             Pedro Alves  <palves@redhat.com>
15218
15219         * infrun.c (disable_thread_events): Delete.
15220         (stop_all_threads): Use SCOPE_EXIT.
15221
15222 2019-01-23  Tom Tromey  <tom@tromey.com>
15223             Pedro Alves  <palves@redhat.com>
15224
15225         * symfile.c: Include forward-scope-exit.h.
15226         (clear_symtab_users_cleanup): Replace forward declaration with
15227         a FORWARD_SCOPE_EXIT.
15228         (syms_from_objfile_1): Use the forward_scope_exit and
15229         gdb::optional instead of cleanup_function.
15230         (reread_symbols): Use the forward_scope_exit instead of
15231         cleanup_function.
15232         (clear_symtab_users_cleanup): Remove function.
15233
15234 2019-01-23  Tom Tromey  <tom@tromey.com>
15235             Pedro Alves  <palves@redhat.com>
15236
15237         * linux-nat.c: Include scope-exit.h.
15238         (cleanup_target_stop): Remove.
15239         (linux_nat_target::static_tracepoint_markers_by_strid): Use
15240         SCOPE_EXIT.
15241
15242 2019-01-23  Tom Tromey  <tom@tromey.com>
15243             Pedro Alves  <palves@redhat.com>
15244
15245         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
15246         (call_function_by_hand_dummy): Use SCOPE_EXIT.
15247
15248 2019-01-23  Tom Tromey  <tom@tromey.com>
15249             Andrew Burgess  <andrew.burgess@embecosm.com>
15250             Pedro Alves  <palves@redhat.com>
15251
15252         * infrun.c (fetch_inferior_event): Use scope_exit.
15253         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
15254         * top.c (execute_command): Use scope_exit.
15255         * breakpoint.c (bpstat_do_actions): Use scope_exit.
15256         * utils.c (do_bpstat_clear_actions_cleanup)
15257         (make_bpstat_clear_actions_cleanup): Remove.
15258
15259 2019-01-23  Tom Tromey  <tom@tromey.com>
15260             Pedro Alves  <palves@redhat.com>
15261
15262         * infrun.c: Include "common/scope-exit.h"
15263         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
15264         (wait_for_inferior): Use SCOPE_EXIT.
15265         (fetch_inferior_event): Use scope_exit.
15266
15267 2019-01-23  Tom Tromey  <tom@tromey.com>
15268             Pedro Alves  <palves@redhat.com>
15269
15270         * breakpoint.c (create_breakpoint): Remove cleanup.
15271
15272 2019-01-23  Tom Tromey  <tom@tromey.com>
15273             Andrew Burgess  <andrew.burgess@embecosm.com>
15274             Pedro Alves  <palves@redhat.com>
15275
15276 2019-01-23  Pedro Alves  <palves@redhat.com>
15277
15278         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
15279
15280 2019-01-23  Pedro Alves  <palves@redhat.com>
15281             Andrew Burgess  <andrew.burgess@embecosm.com>
15282
15283         * gdbthread.h: Include "common/forward-scope-exit.h".
15284         (scoped_finish_thread_state): Redefine custom class in terms of
15285         forward_scope_exit.
15286
15287 2019-01-23  Pedro Alves  <palves@redhat.com>
15288             Andrew Burgess  <andrew.burgess@embecosm.com>
15289
15290         * common/forward-scope-exit.h: New file.
15291
15292 2019-01-23  Pedro Alves  <palves@redhat.com>
15293             Andrew Burgess  <andrew.burgess@embecosm.com>
15294             Tom Tromey  <tom@tromey.com>
15295
15296         * common/scope-exit.h: New file.
15297
15298 2019-01-23  Pedro Alves  <palves@redhat.com>
15299
15300         * common/preprocessor.h (ESC): Rename to ...
15301         (ESC_PARENS): ... this.
15302         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
15303         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
15304
15305 2019-01-23  Tom Tromey  <tom@tromey.com>
15306
15307         * language.h (class scoped_switch_to_sym_language_if_auto):
15308         Initialize m_lang in both cases.
15309
15310 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
15311
15312         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
15313         with XCNEW.
15314
15315 2019-01-22  Tom Tromey  <tom@tromey.com>
15316
15317         * corelow.c: Do not include sys/file.h.
15318
15319 2019-01-22  Tom Tromey  <tom@tromey.com>
15320
15321         * tui/tui-wingeneral.h: Include gdb_curses.h.
15322
15323 2019-01-22  Tom Tromey  <tom@tromey.com>
15324
15325         * source-cache.h (class source_cache) <get_source_lines,
15326         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
15327
15328 2019-01-22  Tom Tromey  <tom@tromey.com>
15329
15330         * remote-fileio.h (struct remote_target): Declare.
15331
15332 2019-01-22  Tom Tromey  <tom@tromey.com>
15333
15334         * python/py-arch.c: Do not include py-ref.h.
15335         * python/py-bpevent.c: Do not include py-ref.h.
15336         * python/py-cmd.c: Do not include py-ref.h.
15337         * python/py-continueevent.c: Do not include py-ref.h.
15338         * python/py-event.h: Do not include py-ref.h.
15339         * python/py-evtregistry.c: Do not include py-ref.h.
15340         * python/py-finishbreakpoint.c: Do not include py-ref.h.
15341         * python/py-frame.c: Do not include py-ref.h.
15342         * python/py-framefilter.c: Do not include py-ref.h.
15343         * python/py-function.c: Do not include py-ref.h.
15344         * python/py-infevents.c: Do not include py-ref.h.
15345         * python/py-linetable.c: Do not include py-ref.h.
15346         * python/py-objfile.c: Do not include py-ref.h.
15347         * python/py-param.c: Do not include py-ref.h.
15348         * python/py-prettyprint.c: Do not include py-ref.h.
15349         * python/py-progspace.c: Do not include py-ref.h.
15350         * python/py-symbol.c: Do not include py-ref.h.
15351         * python/py-symtab.c: Do not include py-ref.h.
15352         * python/py-type.c: Do not include py-ref.h.
15353         * python/py-unwind.c: Do not include py-ref.h.
15354         * python/py-utils.c: Do not include py-ref.h.
15355         * python/py-value.c: Do not include py-ref.h.
15356         * python/py-varobj.c: Do not include py-ref.h.
15357         * python/py-xmethods.c: Do not include py-ref.h.
15358         * python/python.c: Do not include py-ref.h.
15359         * varobj.c: Do not include py-ref.h.
15360
15361 2019-01-22  Tom Tromey  <tom@tromey.com>
15362
15363         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
15364         keyword for bcache.
15365
15366 2019-01-22  Tom Tromey  <tom@tromey.com>
15367
15368         * compile/compile-cplus-types.c: Remove a comment by #include.
15369
15370 2019-01-22  Tom Tromey  <tom@tromey.com>
15371
15372         * compile/gcc-c-plugin.h: Include compile-internal.h.
15373
15374 2019-01-22  Tom Tromey  <tom@tromey.com>
15375
15376         * stabsread.c (EXTERN): Do not define.
15377         (symnum, next_symbol_text_func, processing_gcc_compilation)
15378         (within_function, global_sym_chain, global_stabs)
15379         (previous_stab_code, this_object_header_files)
15380         (n_this_object_header_files)
15381         (n_allocated_this_object_header_files): Define.
15382         * stabsread.h (EXTERN): Never define.  Use "extern".
15383
15384 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
15385
15386         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
15387         history_value.
15388
15389 2019-01-21  Tom Tromey  <tom@tromey.com>
15390
15391         * ui-out.c: Fix includes.
15392         * tui/tui-source.c: Fix includes.
15393         * target.c: Fix includes.
15394         * remote.c: Fix includes.
15395         * regcache.c: Fix includes.
15396         * python/py-block.c: Fix includes.
15397         * printcmd.c: Fix includes.
15398         * or1k-tdep.c: Fix includes.
15399         * mi/mi-main.c: Fix includes.
15400         * m32r-tdep.c: Fix includes.
15401         * csky-tdep.c: Fix includes.
15402         * compile/compile-cplus-types.c: Fix includes.
15403         * cli/cli-interp.c: Fix includes.
15404
15405 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
15406
15407         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
15408         for padding.
15409
15410 2019-01-16  Tom Tromey  <tom@tromey.com>
15411
15412         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
15413         earlier.
15414         (struct objfile) <msymbols_range>: Move from top level.
15415         <msymbols>: New method.
15416         (class objfile_msymbols): Remove.
15417         * symtab.c (default_collect_symbol_completion_matches_break_on):
15418         Update.
15419         * symmisc.c (dump_msymbols): Update.
15420         * stabsread.c (scan_file_globals): Update.
15421         * objc-lang.c (info_selectors_command, info_classes_command)
15422         (find_methods): Update.
15423         * minsyms.c (find_solib_trampoline_target): Update.
15424         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
15425         * coffread.c (coff_symfile_read): Update.
15426         * ada-lang.c (ada_lookup_simple_minsym)
15427         (ada_collect_symbol_completion_matches): Update.
15428
15429 2019-01-16  Tom Tromey  <tom@tromey.com>
15430
15431         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
15432         type.  Remove no-argument constructor.
15433         <iterator::operator++>: Simplify.
15434         <begin>: Update.
15435         <end>: Use minimal_symbol_count.
15436
15437 2019-01-16  Tom Tromey  <tom@tromey.com>
15438
15439         * objfiles.h (struct objfile) <psymtabs>: New method.
15440         (class objfile_psymtabs): Remove.
15441         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
15442         typedef.
15443         <range>: New method.
15444         (require_partial_symbols): Change return type.
15445         * psymtab.c (require_partial_symbols)
15446         (psym_expand_symtabs_matching): Update.
15447         * mdebugread.c (parse_partial_symbols): Update.
15448         * dbxread.c (dbx_end_psymtab): Update.
15449
15450 2019-01-15  Tom Tromey  <tom@tromey.com>
15451
15452         * symtab.c (lookup_objfile_from_block)
15453         (lookup_symbol_in_objfile_symtabs)
15454         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
15455         (find_line_symtab, info_sources_command)
15456         (default_collect_symbol_completion_matches_break_on)
15457         (make_source_files_completion_list): Update.
15458         * symmisc.c (print_objfile_statistics, dump_objfile)
15459         (maintenance_print_symbols, maintenance_info_symtabs)
15460         (maintenance_check_symtabs, maintenance_info_line_tables):
15461         Update.
15462         * source.c (select_source_symtab)
15463         (forget_cached_source_info_for_objfile): Update.
15464         * objfiles.h (class objfile_compunits): Remove.
15465         (struct objfile) <compunits_range>: New typedef.
15466         (compunits): New method.
15467         * objfiles.c (objfile_relocate1): Update.
15468         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
15469         * maint.c (count_symtabs_and_blocks): Update.
15470         * linespec.c (iterate_over_all_matching_symtabs): Update.
15471         * cp-support.c (add_symbol_overload_list_qualified): Update.
15472         * coffread.c (coff_symtab_read): Update.
15473         * ada-lang.c (add_nonlocal_symbols)
15474         (ada_collect_symbol_completion_matches)
15475         (ada_add_global_exceptions): Update.
15476
15477 2019-01-15  Tom Tromey  <tom@tromey.com>
15478
15479         * progspace.h (program_space) <objfiles_safe_range>: New
15480         typedef.
15481         <objfiles_safe>: New method.
15482         * objfiles.h (class all_objfiles_safe): Remove.
15483         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
15484         * jit.c (jit_inferior_exit_hook): Update.
15485
15486 2019-01-17  Tom Tromey  <tom@tromey.com>
15487
15488         * progspace.h (program_space) <objfiles_range>: New typedef.
15489         <objfiles>: New method.
15490         <objfiles_head>: Rename from objfiles.
15491         (object_files): Update.
15492         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
15493         * guile/scm-pretty-print.c
15494         (ppscm_find_pretty_printer_from_objfiles): Update.
15495         * guile/scm-objfile.c (gdbscm_objfiles): Update.
15496         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
15497         Update.
15498         * python/py-progspace.c (pspy_get_objfiles): Update.
15499         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
15500         Update.
15501         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
15502         (objfpy_lookup_objfile_by_build_id): Update.
15503         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
15504         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
15505         Update.
15506         * symtab.c (iterate_over_symtabs, matching_obj_sections)
15507         (expand_symtab_containing_pc, lookup_objfile_from_block)
15508         (lookup_static_symbol, basic_lookup_transparent_type)
15509         (find_pc_sect_compunit_symtab, find_symbol_at_address)
15510         (find_line_symtab, info_sources_command)
15511         (default_collect_symbol_completion_matches_break_on)
15512         (make_source_files_completion_list, find_main_name): Update.
15513         * symmisc.c (print_symbol_bcache_statistics)
15514         (print_objfile_statistics, maintenance_print_symbols)
15515         (maintenance_print_msymbols, maintenance_print_objfiles)
15516         (maintenance_info_symtabs, maintenance_check_symtabs)
15517         (maintenance_expand_symtabs, maintenance_info_line_tables):
15518         Update.
15519         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
15520         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
15521         (map_overlay_command, unmap_overlay_command)
15522         (simple_overlay_update, expand_symtabs_matching)
15523         (map_symbol_filenames): Update.
15524         * symfile-debug.c (set_debug_symfile): Update.
15525         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
15526         Update.
15527         * source.c (select_source_symtab, forget_cached_source_info):
15528         Update.
15529         * solib.c (solib_read_symbols): Update.
15530         * solib-spu.c (append_ocl_sos): Update.
15531         * psymtab.c (maintenance_print_psymbols)
15532         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
15533         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
15534         * printcmd.c (info_symbol_command): Update.
15535         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
15536         Update.
15537         * objfiles.h (class all_objfiles): Remove.
15538         * objfiles.c (have_partial_symbols, have_full_symbols)
15539         (have_minimal_symbols, qsort_cmp, update_section_map)
15540         (shared_objfile_contains_address_p)
15541         (default_iterate_over_objfiles_in_search_order): Update.
15542         * objc-lang.c (info_selectors_command, info_classes_command)
15543         (find_methods): Update.
15544         * minsyms.c (find_solib_trampoline_target): Update.
15545         * maint.c (maintenance_info_sections)
15546         (maintenance_translate_address, count_symtabs_and_blocks):
15547         Update.
15548         * main.c (captured_main_1): Update.
15549         * linux-thread-db.c (try_thread_db_load_from_pdir)
15550         (has_libpthread): Update.
15551         * linespec.c (iterate_over_all_matching_symtabs)
15552         (search_minsyms_for_name): Update.
15553         * jit.c (jit_find_objf_with_entry_addr): Update.
15554         * hppa-tdep.c (find_unwind_entry)
15555         (hppa_lookup_stub_minimal_symbol): Update.
15556         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
15557         Update.
15558         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
15559         (elf_gnu_ifunc_resolve_by_got): Update.
15560         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
15561         * dwarf-index-write.c (save_gdb_index_command): Update.
15562         * cp-support.c (add_symbol_overload_list_qualified): Update.
15563         * breakpoint.c (create_overlay_event_breakpoint)
15564         (create_longjmp_master_breakpoint)
15565         (create_std_terminate_master_breakpoint)
15566         (create_exception_master_breakpoint): Update.
15567         * blockframe.c (find_pc_partial_function): Update.
15568         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
15569         (ada_collect_symbol_completion_matches)
15570         (ada_add_global_exceptions): Update.
15571
15572 2019-01-17  Tom Tromey  <tom@tromey.com>
15573
15574         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
15575         declare VEC.
15576         (solib_target_parse_libraries): Change return type.
15577         (library_list_start_segment, library_list_start_section)
15578         (library_list_end_library, library_list_start_library); Update.
15579         (solib_target_free_library_list): Remove.
15580         (solib_target_parse_libraries): Remove cleanup.  Change return
15581         type.
15582         (solib_target_current_sos): Update.
15583
15584 2019-01-17  Tom Tromey  <tromey@bapiya>
15585
15586         * valprint.c: Replace "the the" with "the".
15587         * symtab.c: Replace "the the" with "the".
15588         * solib.c: Replace "the the" with "the".
15589         * solib-dsbt.c: Replace "the the" with "the".
15590         * linespec.c: Replace "the the" with "the".
15591         * dwarf2loc.h: Replace "the the" with "the".
15592         * amd64-windows-tdep.c: Replace "the the" with "the".
15593         * aarch64-tdep.c: Replace "the the" with "the".
15594
15595 2019-01-16  Keith Seitz  <keiths@redhat.com>
15596
15597         PR gdb/23773
15598         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
15599         <builder>: Rename to ..
15600         <m_builder>: ... this and make private.
15601         (dwarf2_cu::get_builder): New method.  Change all users of
15602         `builder' to use this method.
15603         (dwarf2_start_symtab): Move to ...
15604         (dwarf2_cu::start_symtab): ... here.  Update all callers
15605         (setup_type_unit_groups): Move to ...
15606         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
15607         callers.
15608         (dwarf2_cu::reset_builder): New method.
15609         (process_full_compunit, process_full_type_unit): Use
15610         dwarf2_cu::reset_builder.
15611         (follow_die_offset): Record the ancestor CU if it is different
15612         from the followed DIE's CU.
15613         (follow_die_sig_1): Likewise.
15614
15615 2019-01-15  Tom Tromey  <tom@tromey.com>
15616
15617         * remote.c (class remote_state) <buf>: Now a char_vector.
15618         <buf_size>: Remove.
15619         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
15620         parameter.
15621         (remote_target::getpkt_or_notif_sane_1)
15622         (remote_target::getpkt_sane)
15623         (remote_target::getpkt_or_notif_sane): Likewise.
15624         (class remote_target) <putpkt>: New overload.
15625         (remote_target::read_frame): Change type of "buf_p".  Remove
15626         sizeof_p parameter.
15627         (packet_ok): New overload.
15628         (packet_check_result): New overload.
15629         Update all uses.
15630
15631 2019-01-14  Tom Tromey  <tom@tromey.com>
15632
15633         * remote-notif.c (handle_notification, remote_notif_ack)
15634         (remote_notif_parse): Make "buf" const.
15635         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
15636         const.
15637         (remote_notif_parse, remote_notif_ack, handle_notification):
15638         Likewise.
15639         * remote.c (remote_notif_stop_parse): Make "buf" const.
15640         (remote_target::remote_parse_stop_reply): Make "buf" const.
15641         (remote_notif_stop_ack): Make "buf" const.
15642
15643 2019-01-14  Tom Tromey  <tom@tromey.com>
15644
15645         * remote.c (remote_console_output): Make parameter const.
15646
15647 2019-01-14  Tom Tromey  <tom@tromey.com>
15648
15649         * target-debug.h (target_debug_print_signals): Constify.
15650         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
15651         * procfs.c (procfs_target::pass_signals): Update.
15652         * linux-nat.c (linux_nat_target::pass_signals): Update.
15653         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
15654         * target-delegates.c: Rebuild.
15655         * remote.c (remote_target::program_signals): Update.
15656         (remote_target::pass_signals): Update.
15657         * target.c (target_pass_signals): Constify argument.
15658         (target_program_signals): Likewise.
15659         * target.h (struct target_ops) <pass_signals, program_signals>:
15660         Constify argument.
15661         (target_pass_signals, target_program_signals): Constify argument.
15662
15663 2019-01-14  Tom Tromey  <tom@tromey.com>
15664
15665         PR tui/28819:
15666         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
15667
15668 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
15669
15670         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
15671         field.
15672         * rs6000-tdep.c: Include reggroups.h.
15673         (IS_V_ALIAS_PSEUDOREG): Define.
15674         (rs6000_register_name): Return names for the "vX" aliases.
15675         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
15676         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
15677         aliases.  Call default_register_reggroup_p for all other
15678         pseudo-registers.
15679         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
15680         New functions.
15681         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
15682         Handle "vX" aliases.
15683         (v_alias_pseudo_register_collect): New function.
15684         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
15685         (rs6000_gdbarch_init): Initialize "vX" aliases as
15686         pseudo-registers.  Restore registration of
15687         rs6000_pseudo_register_reggroup_p with
15688         set_tdesc_pseudo_register_reggroup_p.
15689
15690 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
15691
15692         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
15693         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
15694         set_gdbarch_num_pseudo_regs.
15695
15696 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
15697
15698         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
15699         Remove arg prefixname, add do_set and do_show.
15700         Add member functions set_list and show_list.
15701         * cli/cli-style.c (class cli_style_option): Update accordingly.
15702         (style_set_list): Move to file scope.
15703         (style_show_list): Likewise.
15704         (set_style): Call help_list.
15705         (show_style): Call cmd_show_list.
15706         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
15707         Update to use the new macro.
15708
15709 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
15710
15711         * ada-lang.c (_initialize_ada_language): Expand the help text
15712         for the "catch exception" command.
15713
15714 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
15715
15716         * symtab.c (matching_obj_sections): Initialize obj,
15717         declare it closer to its usage.
15718
15719 2019-01-10  Tom Tromey  <tom@tromey.com>
15720
15721         * thread-iter.h (inf_threads_iterator): Use next_iterator.
15722         (basic_inf_threads_range): Remove.
15723         (inf_threads_range, inf_non_exited_threads_range)
15724         (safe_inf_threads_range): Use next_adapter.
15725
15726 2019-01-10  Keith Seitz  <keiths@redhat.com>
15727
15728         PR gdb/23712
15729         PR symtab/23010
15730         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
15731         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
15732
15733 2019-01-10  Keith Seitz  <keiths@redhat.com>
15734
15735         PR gdb/23712
15736         PR symtab/23010
15737         * dictionary.c (pending_to_vector): Remove.
15738         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
15739         Remove _1 suffix, replacing functions of the same name.  Update
15740         all callers.
15741         (dict_create_hashed, dict_create_hashed_expandable)
15742         (dict_create_linear, dict_create_linear_expandable, dict_free)
15743         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
15744         Make functions static.
15745
15746 2019-01-10  Keith Seitz  <keiths@redhat.com>
15747
15748         PR gdb/23712
15749         PR symtab/23010
15750         * dictionary.h (struct dictionary): Replace declaration with
15751         multidictionary.
15752         (dict_create_hashed, dict_create_hashed_expandable)
15753         (dict_create_linear, dict_create_linear_expandable)
15754         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
15755         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
15756         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
15757         taking multidictionary argument.
15758         [ALL_DICT_SYMBOLS]: Update for multidictionary.
15759         * block.h (struct block) <dict>: Change to multidictionary
15760         and rename `multidict'.
15761         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
15762         symmisc.c: Update all dictionary references to multidictionary.
15763
15764 2019-01-10  Keith Seitz  <keiths@redhat.com>
15765
15766         PR gdb/23712
15767         PR symtab/23010
15768         * dictionary.c: Include unordered_map.
15769         (pending_to_vector): New function.
15770         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
15771         Rewrite the non-"_1" functions to take vector instead
15772         of linked list.
15773         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
15774         "new" _1 versions of the same name.
15775         (multidictionary): Define.
15776         (std::hash<enum language): New definition.
15777         (collate_pending_symbols_by_language, mdict_create_hashed)
15778         (mdict_create_hashed_expandable, mdict_create_linear)
15779         (mdict_create_linear_expandable, mdict_free)
15780         (find_language_dictionary, create_new_language_dictionary)
15781         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
15782         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
15783         (mdict_size, mdict_empty): New functions.
15784         * dictionary.h (mdict_iterator): Define.
15785
15786 2019-01-10  Pedro Alves  <palves@redhat.com>
15787
15788         * breakpoint.c (read_uploaded_action)
15789         (create_tracepoint_from_upload): Adjust to use
15790         gdb::unique_xmalloc_ptr.
15791         * ctf.c (ctf_write_uploaded_tp):
15792         (SET_ARRAY_FIELD): Use emplace_back.
15793         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
15794         * tracefile-tfile.c (tfile_write_uploaded_tp):
15795         * tracepoint.c (parse_tracepoint_definition): Adjust to use
15796         gdb::unique_xmalloc_ptr.
15797         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
15798         at_string, cond_string, cmd_strings>: Replace char pointers
15799         with gdb::unique_xmalloc_ptr.
15800
15801 2019-01-10  Pedro Alves  <palves@redhat.com>
15802
15803         * solib-target.c (library_list_start_library): Don't xstrdup name.
15804
15805 2019-01-10  Pedro Alves  <palves@redhat.com>
15806
15807         * mdebugread.c (parse_partial_symbols): Use
15808         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
15809
15810 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
15811
15812         * linux-fork.c (scoped_switch_fork_info)
15813         <~scoped_switch_fork_info>: Fix incorrect variable name.
15814
15815 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
15816
15817         * linux-fork.c (scoped_switch_fork_info)
15818         <scoped_switch_fork_info>: Make explicit.
15819         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
15820
15821 2019-01-10  Tom Tromey  <tom@tromey.com>
15822
15823         * objfiles.h (objfile::reset_psymtabs): Update.
15824         * objfiles.c (objfile::objfile): Update.
15825         * psymtab.h (psymtab_storage::obstack): Update.
15826         (psymtab_storage::m_obstack): Use gdb::optional.
15827         (class psymtab_storage): Update comment.  Remove objfile
15828         parameter.
15829         * psymtab.c (psymtab_storage::psymtab_storage): Update.
15830
15831 2019-01-10  Tom Tromey  <tom@tromey.com>
15832
15833         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
15834         <free_psymtabs>: Now private.
15835         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
15836         (allocate_psymtab): Use new method.
15837
15838 2019-01-10  Tom Tromey  <tom@tromey.com>
15839
15840         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
15841         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
15842         * mdebugread.c (parse_partial_symbols): Use
15843         allocate_dependencies.
15844         * dwarf2read.c (dwarf2_create_include_psymtab): Use
15845         allocate_dependencies.
15846         (process_psymtab_comp_unit_reader)
15847         (build_type_psymtab_dependencies): Likewise.
15848         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
15849
15850 2019-01-10  Tom Tromey  <tom@tromey.com>
15851
15852         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
15853         PSYMBOL_SET_LANGUAGE.
15854         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
15855
15856 2019-01-10  Tom Tromey  <tom@tromey.com>
15857
15858         * psymtab.h (psymtab_storage::obstack): New method.
15859         <m_obstack>: Rename from obstack; now private.
15860         * psymtab.c (psymtab_storage): Update.
15861         * dwarf2read.c (create_addrmap_from_index)
15862         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
15863         Update.
15864
15865 2019-01-10  Tom Tromey  <tom@tromey.com>
15866
15867         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
15868         * objfiles.h (objfile::reset_psymtabs): New method.
15869
15870 2019-01-10  Tom Tromey  <tom@tromey.com>
15871
15872         * symmisc.c (print_symbol_bcache_statistics): Update.
15873         (print_objfile_statistics): Update.
15874         * symfile.c (reread_symbols): Update.
15875         * psymtab.h (class psymtab_storage): New.
15876         * psymtab.c (psymtab_storage): New constructor.
15877         (~psymtab_storage): New destructor.
15878         (require_partial_symbols): Update.
15879         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
15880         (find_pc_sect_psymtab, find_pc_sect_psymbol)
15881         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
15882         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
15883         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
15884         (start_psymtab_common, end_psymtab_common)
15885         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
15886         (allocate_psymtab): Update.
15887         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
15888         Update.
15889         (dump_psymtab_addrmap, maintenance_print_psymbols)
15890         (maintenance_check_psymtabs): Update.
15891         (class objfile_psymtabs): Move to objfiles.h.
15892         * psympriv.h (discard_psymtab): Now inline.
15893         (psymtab_discarder::psymtab_discarder): Update.
15894         (psymtab_discarder::~psymtab_discarder): Update.
15895         (ALL_OBJFILE_PSYMTABS): Rewrite.
15896         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
15897         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
15898         Remove fields.
15899         <partial_symtabs>: New field.
15900         (class objfile_psymtabs): Move from psymtab.h.  Update.
15901         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
15902         psymbol_cache.
15903         (objfile::~objfile): Don't destroy psymbol_cache.
15904         * mdebugread.c (parse_partial_symbols): Update.
15905         * dwarf2read.c (create_addrmap_from_index)
15906         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
15907         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
15908         (add_partial_subprogram, dwarf2_ranges_read): Update.
15909         * dwarf-index-write.c (write_address_map)
15910         (write_one_signatured_type, recursively_write_psymbols)
15911         (class debug_names, class debug_names, write_psymtabs_to_index):
15912         Update.
15913
15914 2019-01-10  Tom Tromey  <tom@tromey.com>
15915
15916         * symtab.h (SYMBOL_SET_NAMES): Update.
15917         (symbol_set_names): Update.
15918         (MSYMBOL_SET_NAMES): Update.
15919         * symtab.c (symbol_set_names): Change argument to be an
15920         objfile_per_bfd_storage.
15921         * psymtab.c (add_psymbol_to_bcache): Update.
15922         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
15923
15924 2019-01-10  Tom Tromey  <tom@tromey.com>
15925
15926         * symtab.c (create_demangled_names_hash): Change argument to be an
15927         objfile_per_bfd_storage.
15928         (symbol_set_names): Update.
15929
15930 2019-01-10  Tom Tromey  <tom@tromey.com>
15931
15932         * xcoffread.c (xcoff_initial_scan): Unconditionally call
15933         init_psymbol_list.
15934         * psymtab.c (init_psymbol_list): Do nothing if already called.
15935         * psympriv.h (init_psymbol_list): Add comment.
15936         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
15937         init_psymbol_list.
15938         * dbxread.c (dbx_symfile_read): Unconditionally call
15939         init_psymbol_list.
15940
15941 2019-01-10  Tom Tromey  <tom@tromey.com>
15942
15943         * xcoffread.c (scan_xcoff_symtab): Update.
15944         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
15945         "where".
15946         * mdebugread.c (parse_partial_symbols)
15947         (handle_psymbol_enumerators): Update.
15948         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
15949         * dbxread.c (read_dbx_symtab): Update.
15950         * psympriv.h (psymbol_placement): New enum.
15951         (add_psymbol_to_list): Update.
15952
15953 2019-01-10  Tom Tromey  <tom@tromey.com>
15954
15955         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
15956         static_psymbols parameters.
15957         (scan_xcoff_symtab): Update.
15958         * psymtab.c (start_psymtab_common): Remove global_psymbols and
15959         static_psymbols parameters.
15960         * psympriv.h (start_psymtab_common): Update.
15961         * mdebugread.c (parse_partial_symbols): Update.
15962         * dwarf2read.c (create_partial_symtab): Update.
15963         * dbxread.c (read_dbx_symtab): Update.
15964         (start_psymtab): Remove global_psymbols and static_psymbols
15965         parameters.
15966
15967 2019-01-10  Tom Tromey  <tom@tromey.com>
15968
15969         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
15970         * psymtab.c (allocate_psymtab): Add comment.
15971         * psympriv.h (allocate_psymtab): Add comment.
15972         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
15973         initializations.
15974         * dbxread.c (dbx_end_psymtab): Remove some initializations.
15975
15976 2019-01-10  Tom Tromey  <tom@tromey.com>
15977
15978         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
15979         Don't declare.
15980         * mipsread.c: Include mdebugread.h.
15981         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
15982         Declare.
15983         * elfread.c: Include mdebugread.h.
15984
15985 2019-01-09  Tom Tromey  <tom@tromey.com>
15986
15987         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
15988         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
15989         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
15990         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
15991         (psym_lookup_symbol, psym_find_last_source_symtab)
15992         (psym_forget_cached_source_info, psym_print_stats)
15993         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
15994         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
15995         (psym_map_matching_symbols, psym_expand_symtabs_matching)
15996         (psym_find_compunit_symtab_by_address)
15997         (maintenance_print_psymbols, maintenance_info_psymtabs)
15998         (maintenance_check_psymtabs): Use ranged for.
15999         * psymtab.h (class objfile_psymtabs): New.
16000         (require_partial_symbols): Return objfile_psymtabs.
16001         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
16002
16003 2019-01-09  Tom Tromey  <tom@tromey.com>
16004
16005         * symfile.c (overlay_invalidate_all, find_pc_overlay)
16006         (find_pc_mapped_section, list_overlays_command)
16007         (map_overlay_command, unmap_overlay_command)
16008         (simple_overlay_update): Use all_objfiles.
16009         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
16010         * printcmd.c (info_symbol_command): Use all_objfiles.
16011         * objfiles.h (ALL_OBJSECTIONS): Remove.
16012         * maint.c (maintenance_translate_address): Use all_objfiles.
16013         * gcore.c (gcore_create_callback): Use all_objfiles.
16014         (objfile_find_memory_regions): Likewise.
16015
16016 2019-01-09  Tom Tromey  <tom@tromey.com>
16017
16018         * symtab.c (find_line_symtab, info_sources_command)
16019         (make_source_files_completion_list): Use objfile_compunits.
16020         * source.c (select_source_symtab): Use objfile_compunits.
16021         * objfiles.h (struct objfile): Update comment.
16022         (ALL_OBJFILES): Remove.
16023         (ALL_FILETABS): Remove.
16024         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
16025         objfile_compunits.
16026
16027 2019-01-09  Tom Tromey  <tom@tromey.com>
16028
16029         * symmisc.c (print_objfile_statistics, dump_objfile)
16030         (maintenance_print_symbols): Use compunit_filetabs.
16031         * source.c (forget_cached_source_info_for_objfile): Use
16032         compunit_filetabs.
16033         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
16034         (ALL_FILETABS): Use compunit_filetabs.
16035         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
16036         * coffread.c (coff_symtab_read): Use compunit_filetabs.
16037
16038 2019-01-09  Tom Tromey  <tom@tromey.com>
16039
16040         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
16041         (compunit_filetabs): New.
16042         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
16043         compunit_filetabs.
16044         (info_sources_command, make_source_files_completion_list): Remove
16045         declaration.
16046         * symmisc.c (print_objfile_statistics, dump_objfile)
16047         (maintenance_print_symbols): Remove declaration.
16048         (maintenance_info_symtabs): Use compunit_filetabs.
16049         (maintenance_info_line_tables): Likewise.
16050         * source.c (select_source_symtab): Change local variable name.
16051         (forget_cached_source_info_for_objfile): Remove declaration.
16052         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
16053         * objfiles.c (objfile_relocate1): Remove declaration.
16054         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
16055         declaration.
16056         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
16057         * coffread.c (coff_symtab_read): Remove declaration.
16058         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
16059         compunit_filetabs.
16060
16061 2019-01-09  Tom Tromey  <tom@tromey.com>
16062
16063         * symtab.c (lookup_objfile_from_block)
16064         (find_pc_sect_compunit_symtab, search_symbols)
16065         (default_collect_symbol_completion_matches_break_on): Use
16066         objfile_compunits.
16067         * objfiles.h (ALL_COMPUNITS): Remove.
16068         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
16069         * cp-support.c (add_symbol_overload_list_qualified): Use
16070         objfile_compunits.
16071         * ada-lang.c (ada_collect_symbol_completion_matches)
16072         (ada_add_global_exceptions): Use objfile_compunits.
16073
16074 2019-01-09  Tom Tromey  <tom@tromey.com>
16075
16076         * source.c (select_source_symtab)
16077         (forget_cached_source_info_for_objfile): Remove declaration.
16078         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
16079         declaration.
16080         * maint.c (count_symtabs_and_blocks): Remove declaration.
16081         * cp-support.c (add_symbol_overload_list_qualified): Remove
16082         declaration.
16083         * coffread.c (coff_symtab_read): Remove declaration.
16084         * symtab.c (lookup_symbol_in_objfile_symtabs)
16085         (basic_lookup_transparent_type_1): Use objfile_compunits.
16086         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
16087         (info_sources_command, search_symbols)
16088         (default_collect_symbol_completion_matches_break_on)
16089         (make_source_files_completion_list): Remove declaration.
16090         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
16091         (ada_collect_symbol_completion_matches)
16092         (ada_add_global_exceptions): Remove declaration.
16093         * linespec.c (iterate_over_all_matching_symtabs): Use
16094         objfile_compunits.
16095         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
16096         (class objfile_compunits): New.
16097         (ALL_COMPUNITS): Use objfile_compunits.
16098         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
16099         (maintenance_check_symtabs, maintenance_info_line_tables): Use
16100         objfile_compunits.
16101         * objfiles.c (objfile_relocate1): Use objfile_compunits.
16102
16103 2019-01-09  Tom Tromey  <tom@tromey.com>
16104
16105         * symtab.c (search_symbols)
16106         (default_collect_symbol_completion_matches_break_on): Use
16107         objfile_msymbols.
16108         * ada-lang.c (ada_lookup_simple_minsym)
16109         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
16110         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
16111         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
16112         objfile_msymbols.
16113         * coffread.c (coff_symfile_read): Use objfile_msymbols.
16114         * symmisc.c (dump_msymbols): Use objfile_msymbols.
16115         * objc-lang.c (find_methods): Use objfile_msymbols.
16116         (info_selectors_command, info_classes_command): Likewise.
16117         * stabsread.c (scan_file_globals): Use objfile_msymbols.
16118         * objfiles.h (class objfile_msymbols): New.
16119         (ALL_OBJFILE_MSYMBOLS): Remove.
16120         (ALL_MSYMBOLS): Remove.
16121
16122 2019-01-09  Tom Tromey  <tom@tromey.com>
16123
16124         * common/next-iterator.h (next_adapter): Add Iterator template
16125         parameter.
16126         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
16127         (class all_objfiles_safe): New.
16128         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
16129         * objfiles.c (put_objfile_before): Update comment.
16130         (add_separate_debug_objfile): Likewise.
16131         (free_all_objfiles): Use all_objfiles_safe.
16132         (objfile_purge_solibs): Likewise.
16133
16134 2019-01-09  Tom Tromey  <tom@tromey.com>
16135
16136         * symtab.c (iterate_over_symtabs, matching_obj_sections)
16137         (expand_symtab_containing_pc, lookup_static_symbol)
16138         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
16139         (find_symbol_at_address, find_line_symtab, find_main_name): Use
16140         all_objfiles.
16141         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
16142         * breakpoint.c (create_overlay_event_breakpoint)
16143         (create_longjmp_master_breakpoint)
16144         (create_std_terminate_master_breakpoint)
16145         (create_exception_master_breakpoint): Use all_objfiles.
16146         * linux-thread-db.c (try_thread_db_load_from_pdir)
16147         (has_libpthread): Use all_objfiles.
16148         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
16149         * linespec.c (iterate_over_all_matching_symtabs)
16150         (search_minsyms_for_name): Use all_objfiles.
16151         * maint.c (maintenance_info_sections): Use all_objfiles.
16152         * main.c (captured_main_1): Use all_objfiles.
16153         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
16154         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
16155         * guile/scm-pretty-print.c
16156         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
16157         * solib-spu.c (append_ocl_sos): Use all_objfiles.
16158         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
16159         (maintenance_print_msymbols): Use all_objfiles.
16160         * source.c (select_source_symtab): Use all_objfiles.
16161         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
16162         * symfile.c (remove_symbol_file_command)
16163         (expand_symtabs_matching, map_symbol_filenames): Use
16164         all_objfiles.
16165         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
16166         all_objfiles.
16167         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
16168         * objc-lang.c (find_methods): Use all_objfiles.
16169         * objfiles.c (have_partial_symbols, have_full_symbols)
16170         (have_minimal_symbols, qsort_cmp)
16171         (default_iterate_over_objfiles_in_search_order): Use
16172         all_objfiles.
16173         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
16174         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
16175         (maintenance_check_psymtabs): Use all_objfiles.
16176         (ALL_PSYMTABS): Remove.
16177         * compile/compile-object-run.c (do_module_cleanup): Use
16178         all_objfiles.
16179         * blockframe.c (find_pc_partial_function): Use all_objfiles.
16180         * cp-support.c (add_symbol_overload_list_qualified): Use
16181         all_objfiles.
16182         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
16183         Use all_objfiles.
16184         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
16185         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
16186         all_objfiles.
16187         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
16188         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
16189         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
16190         Uses all_objfiles.
16191         * solib.c (solib_read_symbols): Use all_objfiles
16192
16193 2019-01-09  Tom Tromey  <tom@tromey.com>
16194
16195         * probe.c (parse_probes_in_pspace): Use all_objfiles.
16196         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
16197         all_objfiles.
16198         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
16199         * symmisc.c (print_symbol_bcache_statistics)
16200         (print_objfile_statistics, maintenance_print_objfiles)
16201         (maintenance_info_symtabs, maintenance_check_symtabs)
16202         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
16203         all_objfiles.
16204         * source.c (forget_cached_source_info): Use all_objfiles.
16205         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
16206         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
16207         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
16208         * objfiles.c (update_section_map): Use all_objfiles.
16209         (shared_objfile_contains_address_p): Likewise.
16210         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
16211         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
16212
16213 2019-01-09  Tom Tromey  <tom@tromey.com>
16214
16215         * common/next-iterator.h: New file.
16216         * objfiles.h (class all_objfiles): New.
16217         (struct objfile_iterator): New.
16218
16219 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
16220
16221         * NEWS: Move the description of the changed "frame", "select-frame",
16222          and "info frame" commands to the Changed commands section.
16223
16224 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
16225
16226         * gdbtypes.c (check_stub_method_group): Remove handling of old
16227         mangling schemes.
16228         * linespec.c (find_methods): Likewise.
16229         * stabsread.c (read_member_functions): Likewise.
16230         * valops.c (search_struct_method): Likewise.
16231         (value_struct_elt_for_reference): Likewise.
16232         * NEWS: Mention this change.
16233
16234 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
16235
16236         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
16237         print_source_lines.
16238         * source.c (print_source_lines_base): Update line number check.
16239         (print_source_lines): New function.
16240         (source_lines_range::source_lines_range): New function.
16241         * source.h (class source_lines_range): New class.
16242         (print_source_lines): New declaration.
16243
16244 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
16245
16246         * linespec.c (linespec_state_destructor): Free self->canonical_names.
16247
16248 2019-01-08  Tom Tromey  <tom@tromey.com>
16249             Simon Marchi  <simon.marchi@ericsson.com>
16250
16251         PR gdb/24060
16252         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
16253         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
16254         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
16255         * f-exp.y (DOLLAR_VARIABLE): Likewise.
16256         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
16257         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
16258
16259 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
16260
16261         * source.c (select_source_symtab): Move header comment to
16262         declaration in source.h.
16263         (forget_cached_source_info_for_objfile): Likewise.
16264         (forget_cached_source_info): Likewise.
16265         (identify_source_line): Likewise.
16266         * source.h (identify_source_line): Move declaration from symtab.h
16267         and add comment from source.c
16268         (print_source_lines): Likewise.
16269         (forget_cached_source_info_for_objfile): Likewise.
16270         (forget_cached_source_info): Likewise.
16271         (select_source_symtab): Likewise.
16272         (enum print_source_lines_flag): Move definition from symtab.h.
16273         * symtab.h (identify_source_line): Move declaration to source.h.
16274         (print_source_lines): Likewise.
16275         (forget_cached_source_info_for_objfile): Likewise.
16276         (forget_cached_source_info): Likewise.
16277         (select_source_symtab): Likewise.
16278         (enum print_source_lines_flag): Move definition to source.h.
16279         * tui/tui-hooks.c: Add 'source.h' include.
16280
16281 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
16282
16283         * source.c (print_source_lines_base): Handle requests to print
16284         reverse line number sequences, and guard against empty lines
16285         string.
16286
16287 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
16288
16289         * source.c (print_source_lines_base): Fix skip of '\r' if next
16290         character is '\n'.
16291
16292 2019-01-06  Tom Tromey  <tom@tromey.com>
16293
16294         * c-exp.y (struct c_parse_state) <macro_original_text,
16295         expansion_obstack>: New member.
16296         (macro_original_text, expansion_obstack): Remove globals.
16297         (scan_macro_expansion, scanning_macro_expansion)
16298         (finished_macro_expansion): Update.
16299         (scan_macro_cleanup): Remove.
16300         (yylex, c_parse): Update.
16301
16302 2019-01-06  Tom Tromey  <tom@tromey.com>
16303
16304         * c-exp.y (struct c_parse_state) <strings>: New member.
16305         (operator_stoken): Update.
16306
16307 2019-01-06  Tom Tromey  <tom@tromey.com>
16308
16309         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
16310         (union type_stack_elt) <typelist_val>: Now a pointer to
16311         std::vector.
16312         (type_stack_cleanup): Don't declare.
16313         (push_typelist): Update.
16314         * parse.c (pop_typelist): Return a std::vector.
16315         (push_typelist): Take a std::vector.
16316         (follow_types): Update.  Do not free args.
16317         (type_stack_cleanup): Remove.
16318         * c-exp.y (struct c_parse_state): New.
16319         (cpstate): New global.
16320         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
16321         (nonempty_typelist): Update.
16322         (func_mod): Create a new vector.
16323         (c_parse): Create a c_parse_state.
16324         (check_parameter_typelist): Do not delete params.
16325         (function_method): Update.  Do not delete type_list.
16326
16327 2019-01-06  Tom Tromey  <tom@tromey.com>
16328
16329         PR gdb/28155:
16330         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
16331         check_typedef.
16332         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
16333         (print_return_value): Likewise.
16334
16335 2019-01-05  Tom Tromey  <tom@tromey.com>
16336
16337         * contrib/cleanup_check.py: Remove.
16338         * contrib/gcc-with-excheck: Remove.
16339         * contrib/exsummary.py: Remove.
16340         * contrib/excheck.py: Remove.
16341
16342 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
16343
16344         * thread.c (delete_thread_1): Add gdb_assert that THR is not
16345         NULL. Initialize tpprev to NULL instead of assigning it
16346         to NULL on the next statement.
16347         * windows-nat.c (windows_delete_thread): Remove check for
16348         main_thread_id before printing thread exit notifications.
16349         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
16350         Remove thread ID check against main_thread_id.
16351         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
16352         windows_delete_thread.
16353         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
16354
16355 2019-01-04  Tom Tromey  <tom@tromey.com>
16356
16357         * compile/compile.c (_initialize_compile): Use upper case for
16358         metasyntactic variables.
16359         * symmisc.c (_initialize_symmisc): Use upper case for
16360         metasyntactic variables.
16361         * psymtab.c (_initialize_psymtab): Use upper case for
16362         metasyntactic variables.
16363         * demangle.c (demangle_command): Use upper case for metasyntactic
16364         variables.
16365         (_initialize_demangler): Likewise.
16366         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
16367         variables.
16368
16369 2019-01-03  Tom Tromey  <tom@tromey.com>
16370
16371         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
16372
16373 2019-01-03  Tom Tromey  <tom@tromey.com>
16374
16375         * python/py-symtab.c (salpy_str): Update.
16376         (struct salpy_sal_object) <symtab>: Now a PyObject.
16377         (salpy_dealloc): Update.
16378         (del_objfile_sal): Use gdbpy_ref.
16379
16380 2019-01-03  Tom Tromey  <tom@tromey.com>
16381
16382         * python/py-type.c (convert_field): Use new_reference.  Return
16383         gdbpy_ref.
16384         (make_fielditem): Return gdbpy_ref.
16385         (typy_fields): Update.
16386         (typy_getitem): Update.
16387         (field_name): Return gdbpy_ref.  Use new_reference.
16388         (typy_iterator_iternext): Update.
16389
16390 2019-01-03  Tom Tromey  <tom@tromey.com>
16391
16392         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
16393
16394 2019-01-03  Tom Tromey  <tom@tromey.com>
16395
16396         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
16397         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
16398         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
16399         (pspy_set_frame_filters, pspy_set_frame_unwinders)
16400         (pspy_set_type_printers): Likewise.
16401         * python/py-function.c (fnpy_init): Use gdbpy_ref.
16402         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
16403         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
16404         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
16405         (objfpy_set_type_printers): Likewise.
16406
16407 2019-01-03  Tom Tromey  <tom@tromey.com>
16408
16409         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
16410         (gdbpy_print_stack): Use gdbpy_err_fetch.
16411         * python/python-internal.h (class gdbpy_err_fetch): New class.
16412         (class gdbpy_enter) <m_error_type, m_error_value,
16413         m_error_traceback>: Remove.
16414         <m_error>: New member.
16415         (gdbpy_exception_to_string): Don't declare.
16416         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
16417         * python/py-value.c (convert_value_from_python): Use
16418         gdbpy_err_fetch.
16419         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
16420         gdbpy_exception_to_string.
16421         (gdbpy_handle_exception): Use gdbpy_err_fetch.
16422         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
16423         gdbpy_err_fetch.
16424
16425 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
16426
16427         * linux-nat.c (delete_lwp_cleanup): Delete.
16428         (struct lwp_deleter): New struct.
16429         (lwp_info_up): New typedef.
16430         (linux_nat_target::follow_fork): Delete cleanup, and make use of
16431         lwp_info_up.
16432
16433 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
16434
16435         * linux-fork.c (class scoped_switch_fork_info): New class.
16436         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
16437
16438 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
16439
16440         * valops.c (find_overload_match): Remove use of null_cleanup, and
16441         calls to do_cleanups.
16442
16443 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
16444
16445         * compile/compile-cplus-types.c
16446         (compile_cplus_instance::decl_name): Handle changes to
16447         cp_func_name.
16448         * cp-support.c (cp_func_name): Update header comment, update
16449         return type.
16450         * cp-support.h (cp_func_name): Update return type in declaration.
16451         * valops.c (find_overload_match): Move temp_func local to top
16452         level of function and change its type.  Use temp_func to hold and
16453         delete temporary string obtained from cp_func_name.
16454
16455 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
16456
16457         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
16458         gdb::char_vector, remove cleanup, and update uses of `msg`.
16459
16460 2019-01-03  Jim Wilson  <jimw@sifive.com>
16461
16462         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
16463
16464 2019-01-02  Tom Tromey  <tom@tromey.com>
16465
16466         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
16467         (tdesc_parse_xml): Remove cleanups.
16468         * target-descriptions.h (make_cleanup_free_target_description):
16469         Don't declare.
16470         (target_desc_deleter): New struct.
16471         (target_desc_up): New typedef.
16472         * target-descriptions.c (target_desc_deleter::operator()): Rename
16473         from free_target_description.
16474         (make_cleanup_free_target_description): Remove.
16475
16476 2019-01-02  Tom Tromey  <tom@tromey.com>
16477
16478         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
16479         constructor, destructor.
16480         (linespec_parser): Remove typedef.
16481         (~linespec_parser): Rename from linespec_parser_delete.
16482         (linespec_lex_to_end, linespec_complete_label)
16483         (linespec_complete): Update.
16484         (decode_line_full): Remove cleanups.
16485         (decode_line_1): Update.
16486
16487 2019-01-02  Tom Tromey  <tom@tromey.com>
16488
16489         * python/python-internal.h (inferior_to_inferior_object): Change
16490         return type.
16491         * python/py-exitedevent.c (create_exited_event_object): Update.
16492         * python/py-inferior.c (inferior_to_inferior_object): Return
16493         gdbpy_ref.
16494         (python_new_inferior, python_inferior_deleted)
16495         (thread_to_thread_object, delete_thread_object)
16496         (build_inferior_list, gdbpy_selected_inferior): Update.
16497         * python/py-infthread.c (create_thread_object): Update.  Also fail
16498         if inferior_to_inferior_object fails.
16499
16500 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
16501
16502         * inferior.h (class inferior) <displaced_step_state>: New field.
16503         * infrun.h (struct displaced_step_state): Move here from
16504         infrun.c.  Initialize fields, add constructor.
16505         <inf>: Remove field.
16506         <reset>: New method.
16507         * infrun.c (struct displaced_step_inferior_state): Move to
16508         infrun.h.
16509         (displaced_step_inferior_states): Remove.
16510         (get_displaced_stepping_state): Adust.
16511         (displaced_step_in_progress_any_inferior): Adjust.
16512         (displaced_step_in_progress_thread): Adjust.
16513         (displaced_step_in_progress): Adjust.
16514         (add_displaced_stepping_state): Remove.
16515         (get_displaced_step_closure_by_addr): Adjust.
16516         (remove_displaced_stepping_state): Remove.
16517         (infrun_inferior_exit): Call displaced_step_state.reset.
16518         (use_displaced_stepping): Don't check for NULL.
16519         (displaced_step_prepare_throw): Call
16520         get_displaced_stepping_state.
16521         (displaced_step_fixup): Don't check for NULL.
16522         (prepare_for_detach): Don't check for NULL.
16523
16524 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
16525
16526         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
16527          in case of call that did not complete.
16528
16529 2019-01-02  Andrey Utkin  <autkin@undo.io>
16530
16531         * symfile.c (find_separate_debug_file): Fix search of debug files for
16532         remote debuggee.
16533
16534 2019-01-02  Tom Tromey  <tom@tromey.com>
16535
16536         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
16537         indentation.
16538         * python/py-frame.c (frapy_older): Remove cast.
16539         (frapy_newer): Likewise.
16540         * python/py-breakpoint.c (local_setattro): Remove cast.
16541         * python/py-arch.c (archpy_name): Remove local variable.
16542         * python/py-type.c (gdbpy_lookup_type): Remove cast.
16543
16544 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
16545
16546         * unittests/basic_string_view/element_access/char/empty.cc:
16547         Fix year range in copyright header.
16548
16549 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
16550
16551         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
16552         Delete.
16553         <operator==>: Update with for removed field.
16554         <hash>: Likewise.
16555         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
16556         <isa_features>: ...this.
16557         <abi_features>: New field.
16558         (riscv_isa_flen): Update comment.
16559         (riscv_abi_xlen): New declaration.
16560         (riscv_abi_flen): New declaration.
16561         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
16562         isa_features.
16563         (riscv_abi_xlen): New function.
16564         (riscv_isa_flen): Update to get answer from isa_features.
16565         (riscv_abi_flen): New function.
16566         (riscv_has_fp_abi): Update to get answer from abi_features.
16567         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
16568         xlen and flen.
16569         (riscv_call_info) <xlen, flen>: Update comment.
16570         (riscv_call_arg_struct): Remove invalid assertions
16571         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
16572         is removed.
16573         (riscv_gdbarch_init): Gather isa features and abi features
16574         separately, ensure both match on the gdbarch when reusing an old
16575         gdbarch.  Relax an error check to allow 32-bit abi float to run on
16576         a target with 64-bit float hardware.
16577
16578 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
16579
16580         * source.c (search_command_helper): Stop reverse search
16581         when line 1 has been searched.
16582
16583 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
16584
16585         * record-full.c (record_full_base_target::close): Rewrite
16586         record_full_core_buf_list free logic.
16587
16588 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
16589
16590         * break-catch-syscall.c (print_one_catch_syscall): xfree
16591         the last text.
16592
16593 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
16594
16595         * top.c (print_gdb_version): Update Copyright year in version
16596         message.
16597
16598 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
16599
16600         Update copyright year range in all GDB files.
16601
16602 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
16603
16604         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
16605
16606 For older changes see ChangeLog-2018.
16607 \f
16608 Local Variables:
16609 mode: change-log
16610 left-margin: 8
16611 fill-column: 74
16612 version-control: never
16613 coding: utf-8
16614 End:
16615