gdb/ChangeLog

   1 2019-12-18  Simon Marchi  <simon.marchi@efficios.com>
   2
   3         * c-lang.c (c_get_string, asm_language_defn): Remove space
   4         before tab.
   5
   6 2019-12-18  Tom Tromey  <tromey@adacore.com>
   7
   8         PR build/25250:
   9         * ui-out.c (ui_out::vmessage): Update.
  10         * ui-out.h (enum class field_kind) <FIELD_STRING, FIELD_SIGNED>:
  11         Rename.
  12         (string_field): Update.
  13         (signed_field): Update.
  14
  15 2019-12-18  Simon Marchi  <simon.marchi@efficios.com>
  16
  17         * top.c (print_gdb_configuration): Adjust indentation.
  18
  19 2019-12-17  Christian Biesinger  <cbiesinger@google.com>
  20
  21         * bsd-kvm.c: Include gdbsupport/pathstuff.h.
  22
  23 2019-12-17  Simon Marchi  <simon.marchi@polymtl.ca>
  24
  25         * tui/tui-layout.h (class tui_layout_base): Add virtual
  26         destructor.
  27
  28 2019-12-16  Bernd Edlinger  <bernd.edlinger@hotmail.de>
  29
  30         * infcmd.c (prepare_one_step): Step over skipped inline functions.
  31         * infrun.c (inline_frame_is_marked_for_skip): New helper function.
  32         (process_event_stop_test): Keep stepping over skipped inline functions.
  33
  34 2019-12-16  Simon Marchi  <simon.marchi@polymtl.ca>
  35
  36         * jit.c (struct gdb_block) <next>: Remove field.
  37         (struct gdb_symtab) <~gdb_symtab>: Remove.
  38         <blocks>: Change type to std::forward_list<gdb_block>.
  39         (compare_block): Remove.
  40         (jit_block_open_impl): Adjust to std::forward_list.  Place the new
  41         block at the beginning, don't mind about sorting.
  42         (finalize_symtab): Adjust to std::forward_list, sort the blocks list
  43         before using it.
  44
  45 2019-12-16  Simon Marchi  <simon.marchi@polymtl.ca>
  46
  47         * jit.c (struct gdb_block): Add constructor, initialize
  48         real_block and next fields.
  49         <name>: Change type to gdb::unique_xmalloc_ptr.
  50         (struct gdb_symtab) <~gdb_symtab>: Free blocks with delete.
  51         (jit_block_open_impl): Allocate gdb_block with new.
  52         (finalize_symtab): Adjust to gdb::unique_xmalloc_ptr.
  53
  54 2019-12-16  Simon Marchi  <simon.marchi@polymtl.ca>
  55
  56         * jit.c: Include forward_list.
  57         (struct gdb_symtab) <next>: Remove field.
  58         (struct gdb_object) <symtabs>: Change type to
  59         std::forward_list<gdb_symtab>.
  60         (jit_object_open_impl): Allocate gdb_object with new.
  61         (jit_symtab_open_impl): Adjust to std::forward_list.
  62         (finalize_symtab): Don't delete symtab.
  63         (jit_object_close_impl):  Adjust to std::forward_list.  Free
  64         gdb_object with delete.
  65
  66 2019-12-16  Simon Marchi  <simon.marchi@polymtl.ca>
  67
  68         * jit.c (struct gdb_symtab): Add constructor, destructor,
  69         initialize fields.
  70         <linetable>: Change type to unique_xmalloc_ptr.
  71         <file_name>: Change type to std::string.
  72         (jit_symtab_open_impl): Allocate gdb_symtab with new.
  73         (jit_symtab_line_mapping_add_impl): Adjust.
  74         (finalize_symtab): Adjust, call delete on stab.
  75
  76 2019-12-16  Simon Marchi  <simon.marchi@polymtl.ca>
  77
  78         * jit.c (finalize_symtab): Set gdb_block_iter_tmp in loop.
  79
  80 2019-12-16  Tom Tromey  <tromey@adacore.com>
  81
  82         * windows-nat.c (windows_nat_target::attach): Update.
  83         * remote.c (extended_remote_target::attach): Update.
  84         * procfs.c (procfs_target::attach): Update.
  85         * nto-procfs.c (nto_procfs_target::attach): Update.
  86         (nto_procfs_target::create_inferior): Update.
  87         * inf-ptrace.c (inf_ptrace_target::attach): Update.
  88         * gnu-nat.c (gnu_nat_target::attach): Update.
  89         (gnu_nat_target::detach): Update.
  90         * darwin-nat.c (darwin_nat_target::attach): Update.
  91         * corefile.c (get_exec_file): Constify result.  Remove extraneous
  92         return.
  93         * bsd-kvm.c (bsd_kvm_target_open): Update.
  94         * gdbsupport/common-inferior.h (get_exec_file): Constify result.
  95
  96 2019-12-16  Christian Biesinger  <cbiesinger@google.com>
  97
  98         * gdbsupport/common-defs.h: Remove workaround for a gnulib bug
  99         (we no longer need to include time.h before pathmax.h)
 100
 101 2019-12-15  Christian Biesinger  <cbiesinger@google.com>
 102
 103         * ada-exp.y (write_ambiguous_var): Update.
 104         * coffread.c (process_coff_symbol): Update.
 105         * ctfread.c (ctf_add_enum_member_cb): Update.
 106         (new_symbol): Update.
 107         * dwarf2read.c (fixup_go_packaging): Update.
 108         (new_symbol): Update.
 109         * language.c (language_alloc_type_symbol): Update.
 110         * mdebugread.c (new_symbol): Update.
 111         * minsyms.c (minimal_symbol_reader::record_full): Update.
 112         * psymtab.c (add_psymbol_to_bcache): Update.
 113         * stabsread.c (define_symbol): Update.
 114         (read_enum_type): Update.
 115         * symtab.c (symbol_set_language): Make this a member function...
 116         (general_symbol_info::set_language): ... here.
 117         * symtab.h (struct general_symbol_info) <set_language>: New function.
 118         (SYMBOL_SET_LANGUAGE): Remove.
 119         (symbol_set_language): Remove.
 120
 121 2019-12-15  Christian Biesinger  <cbiesinger@google.com>
 122
 123         * ada-lang.c (ada_add_block_symbols): Update.
 124         (ada_collect_symbol_completion_matches): Update.
 125         * ax-gdb.c (gen_expr): Update.
 126         * block.c (block_lookup_symbol): Update.
 127         (block_lookup_symbol_primary): Update.
 128         (block_find_symbol): Update.
 129         * cp-namespace.c (cp_lookup_symbol_imports_or_template): Update.
 130         * dbxread.c (process_one_symbol): Update.
 131         * dictionary.c (insert_symbol_hashed): Update.
 132         (collate_pending_symbols_by_language): Update.
 133         (mdict_add_symbol): Update.
 134         * dwarf-index-write.c (write_psymbols): Update.
 135         * dwarf2read.c (fixup_go_packaging): Update.
 136         * findvar.c (read_var_value): Update.
 137         * ft32-tdep.c (ft32_skip_prologue): Update.
 138         * go-lang.c (go_symbol_package_name): Update.
 139         * language.h (scoped_switch_to_sym_language_if_auto::
 140         scoped_switch_to_sym_language_if_auto): Update.
 141         * linespec.c (find_method): Update.
 142         (find_label_symbols_in_block): Update.
 143         * mdebugread.c (parse_symbol): Update.
 144         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
 145         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
 146         (minimal_symbol_reader::install): Update.
 147         * moxie-tdep.c (moxie_skip_prologue): Update.
 148         * parse.c (parse_exp_in_context): Update.
 149         * psymtab.c (psymbol_name_matches): Update.
 150         (match_partial_symbol): Update.
 151         (lookup_partial_symbol): Update.
 152         (psymbol_hash): Update.
 153         (psymbol_compare): Update.
 154         * python/py-framefilter.c (extract_sym): Update.
 155         (py_print_single_arg): Update.
 156         * stabsread.c (define_symbol): Update.
 157         * stack.c (print_frame_arg): Update.
 158         (find_frame_funname): Update.
 159         (info_frame_command_core): Update.
 160         * symfile.c (set_initial_language): Update.
 161         * symtab.c (symbol_set_demangled_name): Update.
 162         (symbol_get_demangled_name): Update.
 163         (symbol_set_language): Update.
 164         (symbol_find_demangled_name): Update.
 165         (symbol_set_names): Update.
 166         (general_symbol_info::natural_name): Update.
 167         (general_symbol_info::demangled_name): Update.
 168         (general_symbol_info::search_name): Update.
 169         (symbol_matches_search_name): Update.
 170         (eq_symbol_entry): Update.
 171         (iterate_over_symbols): Update.
 172         (completion_list_add_symbol): Update.
 173         (completion_list_add_msymbol): Update.
 174         (completion_list_add_fields): Update.
 175         * symtab.h (struct general_symbol_info) <language>: New function.
 176         <language>: Rename to...
 177         <m_language>: ...this.
 178         (SYMBOL_LANGUAGE): Remove.
 179         (MSYMBOL_LANGUAGE): Remove.
 180         (struct symbol) <ctor>: Update.
 181         * xstormy16-tdep.c (xstormy16_skip_prologue): Update.
 182
 183 2019-12-15  Christian Biesinger  <cbiesinger@google.com>
 184
 185         * ada-exp.y (write_ambiguous_var): Call symbol_set_language to
 186         set the language of sym.
 187         * language.c (language_alloc_type_symbol): Likewise.
 188
 189 2019-12-14  Sergio Durigan Junior  <sergiodj@redhat.com>
 190
 191         https://bugzilla.redhat.com/show_bug.cgi?id=1728147
 192         PR gdb/23613
 193         * bsd-kvm.c (bsd_kvm_target_open): Use 'gdb_abspath'.
 194         * corelow.c: Include 'gdbsupport/pathstuff.h'.
 195         (core_target_open): Use 'gdb_abspath'.
 196         * gdbsupport/pathstuff.c (gdb_abspath): Guard against
 197         'current_directory == NULL' case.
 198         * gdbsupport/pathstuff.h (gdb_abspath): Expand comment and
 199         explain what happens when 'current_directory' is NULL.
 200         * go32-nat.c (go32_nat_target::wait): Check if
 201         'current_directory' is NULL before call to 'chdir'.
 202         * source.c (add_path): Use 'gdb_abspath'.
 203         * top.c: Include 'gdbsupport/pathstuff.h'.
 204         (init_history): Use 'gdb_abspath'.
 205         (set_history_filename): Likewise.
 206         * tracefile-tfile.c: Include 'gdbsupport/pathstuff.h'.
 207         (tfile_target_open): Use 'gdb_abspath'.
 208
 209 2019-12-13  Tom Tromey  <tromey@adacore.com>
 210
 211         * contrib/ari/gdb_ari.sh: Remove check for multiple calls to
 212         warning or error.
 213
 214 2019-12-13  Tom Tromey  <tromey@adacore.com>
 215
 216         * contrib/ari/gdb_ari.sh: Remove call to "fix" for "long long".
 217
 218 2019-12-13  Tom Tromey  <tromey@adacore.com>
 219
 220         * contrib/ari/gdb_ari.sh: Handle -Wno- prefix.
 221
 222 2019-12-13  Tom Tromey  <tromey@adacore.com>
 223
 224         * contrib/ari/gdb_ari.sh (usage): Use GNU style.
 225
 226 2019-12-13  Tom Tromey  <tromey@adacore.com>
 227
 228         * gdbsupport/common-utils.c (string_printf, string_vprintf)
 229         (string_vappendf): Add ARI comment.
 230
 231 2019-12-13  Tom Tromey  <tromey@adacore.com>
 232
 233         * contrib/ari/gdb_ari.sh: Remove "fix" call for
 234         floatformat_to_double.
 235         * target-float.c (host_float_ops<T>::from_target): Add ARI
 236         comment.
 237
 238 2019-12-13  Tom Tromey  <tromey@adacore.com>
 239
 240         * contrib/ari/gdb_ari.sh: Remove "fix" call for abort.
 241         * utils.c (abort_with_message, dump_core, internal_vproblem): Add
 242         ARI marker to abort.
 243         * event-top.c (handle_sigsegv): Add ARI marker to abort.
 244
 245 2019-12-13  Tom Tromey  <tromey@adacore.com>
 246
 247         * contrib/ari/gdb_ari.sh: Fix floatformat_from_double text.
 248
 249 2019-12-13  Tom Tromey  <tromey@adacore.com>
 250
 251         * contrib/ari/gdb_ari.sh: Remove ATTRIBUTE_UNUSED check.
 252
 253 2019-12-13  Tom Tromey  <tromey@adacore.com>
 254
 255         * contrib/ari/gdb_ari.sh: Remove "boolean" and "var_boolean"
 256         checks.
 257
 258 2019-12-13  Tom Tromey  <tromey@adacore.com>
 259
 260         * gdbsupport/safe-iterator.h (class basic_safe_range) <begin,
 261         end>: No longer "const".
 262
 263 2019-12-13  Simon Marchi  <simon.marchi@polymtl.ca>
 264
 265         * jit.c: Fix indentation, replace spaces with tabs where
 266         applicable.
 267
 268 2019-12-13  Jozef Lawrynowicz  <jozef.l@mittosystems.com>
 269
 270         * configure.tgt: Match msp430-*-elf* targets when configuring GDB.
 271
 272 2019-12-12  Tom Tromey  <tom@tromey.com>
 273
 274         * objfiles.h (struct objfile) <partial_symtabs>: Now a
 275         unique_ptr.
 276
 277 2019-12-12  Tom Tromey  <tom@tromey.com>
 278
 279         * progspace.h (objfile_list): New typedef.
 280         (class unwrapping_objfile_iterator)
 281         (struct unwrapping_objfile_range): Newl
 282         (struct program_space) <objfiles_range>: Change type.
 283         <objfiles>: Change return type.
 284         <add_objfile>: Change type of "objfile" parameter.
 285         <objfiles_list>: Now a list of shared_ptr.
 286         * progspace.c (program_space::add_objfile): Change type of
 287         "objfile".  Update.
 288         (program_space::remove_objfile): Update.
 289         * objfiles.h (struct objfile) <~objfile>: Make public.
 290         * objfiles.c (objfile::make): Update.
 291         (objfile::unlink): Don't call delete.
 292
 293 2019-12-12  Tom Tromey  <tom@tromey.com>
 294
 295         * symfile.c (symbol_file_clear): Update.
 296         * progspace.h (struct program_space) <free_all_objfiles>: Declare
 297         method.
 298         * progspace.c (program_space::free_all_objfiles): New method.
 299         * objfiles.h (free_all_objfiles): Don't declare.
 300         * objfiles.c (free_all_objfiles): Move to program_space.
 301
 302 2019-12-12  Tom Tromey  <tom@tromey.com>
 303
 304         * progspace.c (program_space::add_objfile)
 305         (program_space::remove_objfile): Update.
 306         (program_space::multi_objfile_p): Remove.
 307         * objfiles.h (struct objfile) <next>: Remove.
 308         * objfiles.c (objfile::objfile): Update.
 309         (put_objfile_before): Update.
 310         (unlink_objfile): Update.
 311         * progspace.h (object_files): Remove.
 312         (struct program_space) <objfiles_head>: Remove.
 313         <objfiles_list>: New member.
 314         <objfiles_range, objfiles_safe_range>: Change type.
 315         (objfiles): Change return type.
 316         (objfiles_safe): Update.
 317         (multi_objfile_p): Rewrite and inline.
 318         (object_files): Remove macro.
 319
 320 2019-12-12  Tom Tromey  <tom@tromey.com>
 321
 322         * gdbsupport/safe-iterator.h (basic_safe_iterator): Simplify.  Add
 323         second constructor.
 324         (basic_safe_range): New class.
 325
 326 2019-12-12  Tom Tromey  <tom@tromey.com>
 327
 328         * progspace.c (program_space::multi_objfile_p): New method.
 329         * printcmd.c (info_symbol_command): Update.
 330         * maint.c (maintenance_translate_address): Update.
 331         * objfiles.h (MULTI_OBJFILE_P): Remove.
 332         * progspace.h (struct program_space) <multi_objfile_p>: New
 333         method.
 334
 335 2019-12-12  Tom Tromey  <tom@tromey.com>
 336
 337         * progspace.h (struct program_space) <remove_objfile>: Declare.
 338         * progspace.c (program_space::remove_objfile): New method.
 339         * objfiles.c (unlink_objfile): Remove.
 340         (objfile::unlink): Call remove_objfile.
 341         (objfile): Don't call unlink_objfile.
 342
 343 2019-12-12  Tom Tromey  <tom@tromey.com>
 344
 345         * progspace.h (struct program_space) <add_objfile>: Declare
 346         method.
 347         * progspace.c (program_space::add_objfile): New method.
 348         * objfiles.c (~objfile): Don't unlink objfile.
 349         (put_objfile_before): Remove.
 350         (add_separate_debug_objfile): Don't call put_objfile_before.
 351         (objfile::make): Call add_objfile.  Set new_objfiles_available on
 352         the per-program-space data.
 353
 354 2019-12-12  Tom Tromey  <tom@tromey.com>
 355
 356         * symfile.c (syms_from_objfile_1): Use objfile_up.
 357         (syms_from_objfile_1, remove_symbol_file_command): Call unlink
 358         method.
 359         (reread_symbols): Use objfile_up.
 360         * solib.c (update_solib_list, reload_shared_libraries_1): Call
 361         unlink method.
 362         * objfiles.h (struct objfile) <~objfile>: Now private.
 363         <unlink>: New method.
 364         (struct objfile_deleter): New.
 365         (objfile_up): New typedef.
 366         * objfiles.c (objfile::unlink): New method.
 367         (free_objfile_separate_debug, free_all_objfiles)
 368         (objfile_purge_solibs): Use it.
 369         * jit.c (jit_unregister_code): Remove.
 370         (jit_inferior_exit_hook, jit_event_handler): Call unlink on
 371         objfile.
 372         * compile/compile-object-run.c (do_module_cleanup): Call unlink on
 373         objfile.
 374         * compile/compile-object-load.c (compile_object_load): Use
 375         objfile_up.
 376
 377 2019-12-12  Tom Tromey  <tom@tromey.com>
 378
 379         * symfile.c (symbol_file_add_with_addrs): Pass "parent" to
 380         objfile::make.
 381         * objfiles.h (struct objjfile) <make>: No longer inline.
 382         (add_separate_debug_objfile): Don't declare.
 383         * objfiles.c (add_separate_debug_objfile): Now static.
 384         (objfile::make): Move from objfiles.h.  Call
 385         add_separate_debug_objfile.  Add "parent" parameter.
 386
 387 2019-12-12  Tom Tromey  <tom@tromey.com>
 388
 389         * symfile.c (symbol_file_add_with_addrs): Use objfile::make.
 390         * objfiles.h (struct objfile): Make constructor private.
 391         <make>: New static method.
 392         * jit.c (jit_object_close_impl): Update.
 393
 394 2019-12-12  Simon Marchi  <simon.marchi@polymtl.ca>
 395
 396         * jit.c (jit_reader_try_read_symtab): Replace xmalloc/xfree with
 397         gdb::byte_vector.
 398
 399 2019-12-12  Tom Tromey  <tromey@adacore.com>
 400
 401         * xml-support.c (xml_fetch_content_from_file): Don't call
 402         malloc_failure.
 403         * utils.h (class gdb_argv): Remove malloc_failure comment.
 404         * utils.c (gdb_argv::reset): Don't call malloc_failure.
 405
 406 2019-12-12  Tom Tromey  <tromey@adacore.com>
 407
 408         * Makefile.in (ALL_TARGET_OBS): Add riscv-ravenscar-thread.o.
 409         (HFILES_NO_SRCDIR): Add riscv-ravenscar-thread.h.
 410         (ALLDEPFILES): Add riscv-ravenscar-thread.c.
 411         * configure.tgt (riscv-*-*): Add riscv-ravenscar-thread.o.
 412         * riscv-ravenscar-thread.c: New file.
 413         * riscv-ravenscar-thread.h: New file.
 414         * riscv-tdep.c (riscv_gdbarch_init): Call
 415         register_riscv_ravenscar_ops.
 416
 417 2019-12-12  Tom Tromey  <tromey@adacore.com>
 418
 419         * gdbsupport/thread-pool.c (set_thread_name): Use
 420         ATTRIBUTE_UNUSED.
 421
 422 2019-12-12  Luis Machado  <luis.machado@linaro.org>
 423
 424         * gdbsupport/safe-strerror.c: Don't include diagnostics.h.
 425         (select_strerror_r): Use ATTRIBUTE_UNUSED instead of the diagnostics
 426         macros.
 427
 428 2019-12-11  Tom Tromey  <tom@tromey.com>
 429
 430         * tui/tui-win.c (tui_set_win_height_command): Call
 431         tui_adjust_window_height.
 432         (tui_adjust_win_heights, new_height_ok): Remove.
 433         * tui/tui-layout.h (tui_adjust_window_height): Declare.
 434         * tui/tui-layout.c (tui_adjust_window_height): New function.
 435
 436 2019-12-11  Tom Tromey  <tom@tromey.com>
 437
 438         * tui/tui-win.c (tui_resize_all): Remove code, call
 439         tui_apply_current_layout.
 440
 441 2019-12-11  Tom Tromey  <tom@tromey.com>
 442
 443         * tui/tui-layout.h (tui_apply_current_layout): Declare.
 444         * tui/tui-layout.c (standard_layouts, applied_layout): New
 445         globals.
 446         (tui_apply_current_layout): New function.
 447         (show_layout): Set applied_layout.  Call
 448         tui_apply_current_layout.
 449         (show_source_command, show_disasm_command)
 450         (show_source_disasm_command, show_data)
 451         (show_source_or_disasm_and_command): Remove.
 452         (initialize_layouts): New function.
 453         (_initialize_tui_layout): Call initialize_layouts.
 454
 455 2019-12-11  Tom Tromey  <tom@tromey.com>
 456
 457         * tui/tui-layout.h (class tui_layout_base)
 458         (class tui_layout_window, class tui_layout_split): New.
 459         * tui/tui-layout.c (tui_get_window_by_name)
 460         (tui_layout_window::clone, tui_layout_window::apply)
 461         (tui_layout_window::get_sizes, tui_layout_window::add_split)
 462         (tui_layout_split::add_window, tui_layout_split::clone)
 463         (tui_layout_split::get_sizes)
 464         (tui_layout_split::set_weights_from_heights)
 465         (tui_layout_split::adjust_size, tui_layout_split::apply): New
 466         functions.
 467         (tui_layout_split::add_split, tui_layout_split::add_split)
 468         (tui_layout_split::set_weights_from_heights)
 469         (tui_layout_split::set_weights_from_heights): New functions.
 470
 471 2019-12-11  Tom Tromey  <tom@tromey.com>
 472
 473         * tui/tui-wingeneral.c (tui_gen_win_info::make_window): Update.
 474         * tui/tui-win.c (tui_adjust_win_heights, tui_resize_all): Update.
 475         * tui/tui-layout.c (tui_gen_win_info::resize): Update.
 476         * tui/tui-data.h (struct tui_point): Remove.
 477         (struct tui_gen_win_info) <origin>: Remove.
 478         <x, y>: New fields.
 479         * tui/tui-command.c (tui_cmd_window::resize): Update.
 480
 481 2019-12-11  Tom Tromey  <tom@tromey.com>
 482
 483         * tui/tui-stack.h (struct tui_locator_window) <min_height>:
 484         Implement.
 485         * tui/tui-regs.h (struct tui_data_item_window) <min_height>:
 486         Implement.
 487         * tui/tui-data.h (struct tui_gen_win_info) <min_height>: New
 488         method.
 489         (struct tui_win_info) <min_height>: Implement.
 490
 491 2019-12-11  Tom Tromey  <tom@tromey.com>
 492
 493         * tui/tui-data.h (struct tui_gen_win_info) <can_box>: New method.
 494         (struct tui_win_info) <can_box>: Update.
 495
 496 2019-12-11  Tom Tromey  <tom@tromey.com>
 497
 498         * tui/tui-stack.h (struct tui_locator_window) <max_height>: New
 499         method.
 500         * tui/tui-regs.h (struct tui_data_item_window) <max_height>: New
 501         method.
 502         * tui/tui-data.h (struct tui_gen_win_info) <max_height>: New
 503         method.
 504         (struct tui_win_info) <max_height>: Now override.
 505
 506 2019-12-11  Joel Brobecker  <brobecker@adacore.com>
 507
 508         * NEWS: Create a new section for the next release branch.
 509         Rename the section of the current branch, now that it has
 510         been cut.
 511
 512 2019-12-11  Joel Brobecker  <brobecker@adacore.com>
 513
 514         GDB 9 branch created (27f7b2f64062ac9e52afc60509263c2702a9ebd0):
 515         * version.in: Bump version to 10.0.50.DATE-git.
 516
 517 2019-12-11  Tom Tromey  <tromey@adacore.com>
 518
 519         PR build/25268:
 520         * gdbsupport/thread-pool.c (set_thread_name): New function.
 521         (thread_pool::set_thread_count): Don't call pthread_setname_np.
 522         (thread_pool::thread_function): Call set_thread_name.
 523
 524 2019-12-11  Tom Tromey  <tromey@adacore.com>
 525
 526         * fbsd-tdep.c (fbsd_core_info_proc_status): Cast result of
 527         bfd_get_signed_8.
 528
 529 2019-12-11  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 530
 531         * NEWS: Document -raw-values option and the related setting commands.
 532         * printcmd.c (print_command_parse_format): Do not set opts->raw off,
 533         only set it on when /r is given.
 534         * valprint.c (value_print_option_defs): New element raw-values.
 535         * Makefile.in: Add the new file.
 536
 537 2019-12-10  Christian Biesinger  <cbiesinger@google.com>
 538
 539         * gdbsupport/safe-strerror.c: Supress the unused function warning
 540         for select_strerror_r.
 541
 542 2019-12-10  Christian Biesinger  <cbiesinger@google.com>
 543
 544         * config.in: Regenerate.
 545         * configure: Regenerate.
 546         * gdbsupport/agent.c (gdb_connect_sync_socket): Call
 547         safe_strerror instead of strerror.
 548         * gdbsupport/common.m4: Don't check for strerror.
 549         * gdbsupport/safe-strerror.c: Support both the glibc version
 550         of strerror_r and the XSI version.
 551
 552 2019-12-10  Tom Tromey  <tromey@adacore.com>
 553
 554         * ada-typeprint.c (print_choices): Use a single "?".
 555         (print_variant_part): Print "?" if the discriminant name
 556         is not known.
 557
 558 2019-12-10  George Barrett  <bob@bob131.so>
 559
 560         Fix scripted probe breakpoints.
 561         * breakpoint.c (tracepoint_probe_breakpoint_ops): Move
 562         declaration forward.
 563         (breakpoint_ops_for_event_location_type)
 564         (breakpoint_ops_for_event_location): Add function definitions.
 565         (break_command_1, trace_command): Use
 566         breakpoint_ops_for_event_location.
 567         * breakpoint.h (breakpoint_ops_for_event_location): Add function
 568         declarations.
 569         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Use
 570         breakpoint_ops_for_event_location.
 571         * python/py-breakpoint.c (bppy_init): Use
 572         breakpoint_ops_for_event_location.
 573
 574 2019-12-09  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
 575
 576         * gdbtypes.c (rank_one_type): Return INCOMPATIBLE_TYPE_BADNESS
 577         when ranking an lvalue argument for an rvalue parameter.
 578
 579 2019-12-08  Wataru Ashihara  <wataash@wataash.com>
 580
 581         * darwin-nat.c (darwin_nat_target::create_inferior): Fix
 582         template argument for scoped_restore_tmpl from bool to int.
 583
 584 2019-12-07  Keith Seitz  <keiths@redhat.com>
 585
 586         * build-id.c (build_id_bfd_get): Permit bfd_core, too.
 587         (build_id_to_debug_bfd): Make static, rewriting to use
 588         build_id_to_bfd_suffix.
 589         (build_id_to_bfd_suffix): Copy of build_id_to_debug_bfd,
 590         adding `suffix' parameter. Append SUFFIX to file names
 591         when searching for matching files.
 592         (build_id_to_debug_bfd): Use build_id_to_bfd_suffix.
 593         (build_id_to_exec_bfd): Likewise.
 594         * build-id.h (build_id_to_debug_bfd): Clarify that function
 595         searches for BFD of debug info file.
 596         (build_id_to_exec_bfd): Declare.
 597         * corelow.c: Include build-id.h.
 598         (locate_exec_from_corefile_build_id): New function.
 599         (core_target_open): If no executable BFD is found,
 600         search for a core file BFD using build-id.
 601
 602 2019-12-06  Christian Biesinger  <cbiesinger@google.com>
 603
 604         * bcache.c: Put in namespace gdb.
 605         * bcache.h: Likewise.
 606         * gdbtypes.c (check_types_worklist): Update.
 607         (types_deeply_equal): Update.
 608         * macrotab.c (struct macro_table) <bcache>: Update.
 609         (new_macro_table): Update.
 610         * macrotab.h (struct bcache): Put this forward declaration
 611         inside namespace gdb.
 612         (new_macro_table): Update.
 613         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache>:
 614         Update.
 615         <macro_cache>: Update.
 616         * psymtab.h: (psymtab_storage) <psymbol_cache>: Update.
 617
 618 2019-12-06  Tom de Vries  <tdevries@suse.de>
 619
 620         PR symtab/24971
 621         * block.c (best_symbol, better_symbol): New function.
 622         (block_lookup_symbol_primary, block_lookup_symbol): Prefer def over
 623         decl.
 624
 625 2019-12-06  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
 626
 627         * gdbtypes.h: Define the REFERENCE_SEE_THROUGH_BADNESS value.
 628         * gdbtypes.c (rank_one_type): Use REFERENCE_SEE_THROUGH_BADNESS
 629         for ranking see-through reference cases.
 630
 631 2019-12-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 632         * stack.c (faas_command): Check a command is provided.
 633         * thread.c (taas_command, tfaas_command): Likewise.
 634
 635 2019-12-05  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 636         * inferior.c (prune_inferiors):  Only call delete_inferior,
 637         Do not modify the inferior list.
 638
 639 2019-12-05  Simon Marchi  <simon.marchi@polymtl.ca>
 640
 641         * c-exp.y: Update calls to lookup_typename,
 642         lookup_signed_typename and lookup_unsigned_typename.
 643         * c-lang.c (evaluate_subexp_c): Likewise.
 644         * cp-namespace.c (cp_lookup_symbol_imports_or_template):
 645         Likewise.
 646         * eval.c (binop_promote): Likewise.
 647         * gdbtypes.c (lookup_typename): Remove gdbarch parameter.
 648         (lookup_unsigned_typename): Likewise.
 649         (lookup_signed_typename): Likewise.
 650         * gdbtypes.h (lookup_unsigned_typename): Likewise.
 651         (lookup_signed_typename): Likewise.
 652         (lookup_typename): Likewise.
 653         * guile/scm-type.c (tyscm_lookup_typename): Update calls to
 654         lookup_typename, lookup_signed_typename,
 655         lookup_unsigned_typename.
 656         * m2-exp.y: Likewise.
 657         * printcmd.c (printf_wide_c_string): Likewise.
 658         (ui_printf): Likewise.
 659         * python/py-type.c (typy_lookup_typename): Likewise.
 660         * python/py-xmethods.c (python_xmethod_worker::invoke):
 661         Likewise.
 662         * rust-exp.y: Likewise.
 663
 664 2019-12-04  Christian Biesinger  <cbiesinger@google.com>
 665
 666         * configure.nat (obsd64): Add missing files x86-nat.o and
 667         nat/x86-dregs.o.
 668
 669 2019-12-04  Tom Tromey  <tom@tromey.com>
 670
 671         * valprint.c (val_print_string): Use metadata_style.
 672         * go-valprint.c (print_go_string): Use metadata style.
 673         * p-valprint.c (pascal_object_print_static_field): Use metadata
 674         style.
 675         * cp-valprint.c (cp_print_static_field): Use metadata style.
 676
 677 2019-12-04  Andrew Burgess  <andrew.burgess@embecosm.com>
 678             Chris January  <chris.january@arm.com>
 679
 680         * f-exp.y (COMPLEX_KEYWORD, SINGLE, DOUBLE, PRECISION): New
 681         tokens.
 682         (typebase): New patterns for complex, single/double precision, and
 683         single/double complex.
 684         (f77_keywords): Change token for complex keyword, and add single,
 685         double, and precision keywords.
 686
 687 2019-12-04  Simon Marchi  <simon.marchi@polymtl.ca>
 688
 689         * avr-tdep.c (_initialize_avr_tdep): Improve help of command
 690         "info io_registers".
 691
 692 2019-12-04  Simon Marchi  <simon.marchi@polymtl.ca>
 693
 694         * regcache.c (cooked_read_test): Initialize thread list of
 695         mock_inferior.
 696
 697 2019-12-04  Simon Marchi  <simon.marchi@polymtl.ca>
 698
 699         * aarch64-linux-tdep.c: Remove includes.
 700
 701 2019-12-04  Simon Marchi  <simon.marchi@polymtl.ca>
 702
 703         * aarch64-tdep.c: Remove includes.
 704
 705 2019-12-04  Simon Marchi  <simon.marchi@efficios.com>
 706
 707         * filtered-iterator.h (filtered_iterator) <operator==,
 708         operator!=>: Compare wrapped iterators, not wrapped pointers.
 709         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
 710         unittests/filtered_iterator-selftests.c.
 711         * unittests/filtered_iterator-selftests.c: New file.
 712
 713 2019-12-04  Tom Tromey  <tromey@adacore.com>
 714
 715         * gdbtypes.c (create_range_type): Inherit endianity
 716         from base type.
 717
 718 2019-12-04  Tom Tromey  <tromey@adacore.com>
 719
 720         * ada-lang.c (decode_constrained_packed_array)
 721         (ada_value_assign, value_assign_to_component): Update.
 722         * dwarf2loc.c (rw_pieced_value, access_memory)
 723         (dwarf2_compile_expr_to_ax): Update.
 724         * dwarf2read.c (dwarf2_add_field): Update.
 725         * eval.c (evaluate_subexp_standard): Update.
 726         * gdbarch.c, gdbarch.h: Rebuild.
 727         * gdbarch.sh (bits_big_endian): Remove.
 728         * gdbtypes.h (union field_location): Update comment.
 729         * target-descriptions.c (make_gdb_type): Update.
 730         * valarith.c (value_bit_index): Update.
 731         * value.c (struct value) <bitpos>: Update comment.
 732         (unpack_bits_as_long, modify_field): Update.
 733         * value.h (value_bitpos): Update comment.
 734
 735 2019-12-04  Tom Tromey  <tromey@adacore.com>
 736
 737         * gdbtypes.c (type_byte_order): Move earlier.  Assert for unknown
 738         endian-ness.
 739
 740 2019-12-04  Tom Tromey  <tromey@adacore.com>
 741
 742         * dwarf2read.c (dwarf2_init_float_type)
 743         (dwarf2_init_complex_target_type): Add byte_order parameter.
 744         (read_base_type): Compute byte order earlier.
 745         * gdbtypes.c (init_float_type): Add byte_order parameter.
 746         * gdbtypes.h (init_float_type): Add byte_order parameter.
 747
 748 2019-12-04  Tom Tromey  <tromey@adacore.com>
 749
 750         * unittests/tui-selftests.c: Conditionally include tui-winsource.h.
 751
 752 2019-12-04  Tom Tromey  <tromey@adacore.com>
 753
 754         * dwarf2read.c (process_structure_scope): Initialize
 755         "discr_offset".
 756
 757 2019-12-04  Andrew Burgess  <andrew.burgess@embecosm.com>
 758
 759         * mi/mi-symbol-cmds.c (mi_symbol_info): Take extra parameter, and
 760         add it into the search spec.
 761         (parse_max_results_option): New function.
 762         (mi_info_functions_or_variables): Parse -max-results flag and pass
 763         it to mi_symbol_info.
 764         (mi_cmd_symbol_info_modules): Likewise.
 765         (mi_cmd_symbol_info_types): Likewise.
 766         * symtab.c (global_symbol_searcher::add_matching_symbols): Change
 767         return type to bool, change result container into a set, and don't
 768         add new results if we have enough already.
 769         (global_symbol_searcher::add_matching_msymbols): Change return
 770         type to bool, and don't add new results if we have enough already.
 771         (sort_search_symbols_remove_dups): Delete.
 772         (global_symbol_searcher::search): Early exit from search loop when
 773         we have enough results.  Use a std::set to collect the results
 774         from calling add_matching_symbols.
 775         * symtab.h (global_symbol_searcher) <set_max_seach_results>: New
 776         member function.
 777         (global_symbol_searcher) <m_max_search_results>: New member
 778         variable.
 779         (global_symbol_searcher) <add_matching_symbols>: Update header
 780         comment and change return type to bool.
 781         (global_symbol_searcher) <add_matching_msymbols>: Update header
 782         comment and change return type to bool.
 783
 784 2019-12-04  Andrew Burgess  <andrew.burgess@embecosm.com>
 785
 786         * symtab.c (symbol_search::compare_search_syms): Update header
 787         comment.
 788         (global_symbol_searcher::is_suitable_msymbol): New function.
 789         (global_symbol_searcher::expand_symtabs): New function.
 790         (global_symbol_searcher::add_matching_symbols): New function.
 791         (global_symbol_searcher::add_matching_msymbols): New function.
 792         (global_symbol_searcher::search): Move most of the content
 793         into the new functions above, and call them as needed.
 794         * symtab.h (global_symbol_searcher) <expand_symtabs>: New member
 795         function.
 796         (global_symbol_searcher) <add_matching_symbols>: New member
 797         function.
 798         (global_symbol_searcher) <add_matching_msymbols>: New member
 799         function.
 800         (global_symbol_searcher) <is_suitable_msymbol>: New member
 801         function.
 802
 803 2019-12-04  Andrew Burgess  <andrew.burgess@embecosm.com>
 804
 805         * mi/mi-cmds.c (mi_cmds): Add -symbol-info-module-functions and
 806         -symbol-info-module-variables entries.
 807         * mi/mi-cmds.h (mi_cmd_symbol_info_module_functions): Declare.
 808         (mi_cmd_symbol_info_module_variables): Declare.
 809         * mi/mi-symbol-cmds.c
 810         (module_symbol_search_iterator): New typedef.
 811         (output_module_symbols_in_single_module_and_file): New function.
 812         (output_module_symbols_in_single_module): New function.
 813         (mi_info_module_functions_or_variables): New function.
 814         (mi_cmd_symbol_info_module_functions): New function.
 815         (mi_cmd_symbol_info_module_variables): New function.
 816         * NEWS: Mention new MI command.
 817
 818 2019-12-03  Christian Biesinger  <cbiesinger@google.com>
 819
 820         * bcache.c (hash): Remove.
 821         (hash_continue): Remove.
 822         * bcache.h (hash): Remove.
 823         (hash_continue): Remove.
 824         (struct bcache) <ctor>: Update.
 825         * psymtab.c (psymbol_hash): Update.
 826         * stabsread.c (hashname): Update.
 827         * utils.h (fast_hash): Add an argument for a start value,
 828         defaulting to zero.
 829
 830 2019-12-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 831         * symtab.c (symbol_cache_clear_slot):  Move close to cleared type.
 832         (destroy_block_symbol_cache): New function.
 833         (symbol_cache:~symbol_cache) Call destroy_block_symbol_cache.
 834         (resize_symbol_cache): Likewise.
 835
 836 2019-12-02  Tom Tromey  <tom@tromey.com>
 837
 838         * unittests/tui-selftests.c (run_tests): Make conditional.
 839         (_initialize_tui_selftest): Make conditional.
 840
 841 2019-12-02  Christian Biesinger  <cbiesinger@google.com>
 842
 843         * aix-thread.c (debug_aix_thread): Change type to bool.
 844
 845 2019-12-02  Luis Machado  <luis.machado@linaro.org>
 846
 847         * infrun.c (follow_fork_inferior): Remove outdated FIXME comment.
 848
 849 2019-12-01  Andrew Burgess  <andrew.burgess@embecosm.com>
 850
 851         * dwarf2read.c (read_tag_string_type): Read the fields required to
 852         make a dynamic string, and possibly create a dynamic range for the
 853         string.
 854         (attr_to_dynamic_prop): Setup is_reference based on the type of
 855         attribute being processed.
 856         * gdbtypes.c (is_dynamic_type_internal): Handle TYPE_CODE_STRING.
 857         (resolve_dynamic_array): Rename to...
 858         (resolve_dynamic_array_or_string): ...this, update header comment,
 859         and accept TYPE_CODE_STRING.
 860         (resolve_dynamic_type_internal): Handle TYPE_CODE_STRING.
 861
 862 2019-12-01  Andrew Burgess  <andrew.burgess@embecosm.com>
 863
 864         * dwarf2read.c (dwarf2_per_cu_int_type): New function, takes most
 865         of its implementation from...
 866         (dwarf2_per_cu_addr_sized_int_type): ...here, which now just calls
 867         the new function.
 868
 869 2019-12-01  Andrew Burgess  <andrew.burgess@embecosm.com>
 870
 871         * dwarf2read.c (read_subrange_type): Read bit and byte stride and
 872         create a range with stride where appropriate.
 873         * f-valprint.c: Include 'gdbarch.h'.
 874         (f77_print_array_1): Take the stride into account when walking the
 875         array.  Also convert the stride into addressable units.
 876         * gdbtypes.c (create_range_type): Initialise the stride to
 877         constant zero.
 878         (create_range_type_with_stride): New function, initialise the
 879         range as normal, and then setup the stride.
 880         (has_static_range): Include the stride here.  Also change the
 881         return type to bool.
 882         (create_array_type_with_stride): Consider the range stride if the
 883         array isn't given its own stride.
 884         (resolve_dynamic_range): Resolve the stride if needed.
 885         * gdbtypes.h (struct range_bounds) <stride>: New member variable.
 886         (struct range_bounds) <flag_is_byte_stride>: New member variable.
 887         (TYPE_BIT_STRIDE): Define.
 888         (TYPE_ARRAY_BIT_STRIDE): Define.
 889         (create_range_type_with_stride): Declare.
 890         * valarith.c (value_subscripted_rvalue): Take range stride into
 891         account when walking the array.
 892
 893 2019-12-01  Tom Tromey  <tom@tromey.com>
 894
 895         * tui/tui-win.c (tui_all_windows_info): Treat inactive TUI
 896         specially.
 897
 898 2019-12-01  Tom Tromey  <tom@tromey.com>
 899
 900         * tui/tui-winsource.c (tui_copy_source_line): Don't advance past
 901         \0.
 902         * unittests/tui-selftests.c: New file.
 903         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add tui-selftests.c.
 904
 905 2019-12-01  Tom Tromey  <tom@tromey.com>
 906
 907         * tui/tui.c (tui_enable): Call tui_update_variables earlier.
 908
 909 2019-12-01  Tom Tromey  <tom@tromey.com>
 910
 911         * NEWS: Document new settings.
 912         * tui/tui-wingeneral.c (box_win): Apply appropriate border style.
 913         * tui/tui-win.c (_initialize_tui_win): Add border style
 914         observers.
 915         * tui/tui-io.h (tui_apply_style): Declare.
 916         * tui/tui-io.c (tui_apply_style): Rename from apply_style.  No
 917         longer static.
 918         (apply_ansi_escape, tui_set_reverse_mode): Update.
 919         * cli/cli-style.h (class cli_style_option) <add_setshow_commands>:
 920         Add "skip_intensity" parameter.
 921         <changed>: New member.
 922         <do_set_value>: Declare.
 923         (tui_border_style, tui_active_border_style): Declare.
 924         * cli/cli-style.c (tui_border_style, tui_active_border_style): New
 925         globals.
 926         (cli_style_option): Initialize "changed".
 927         (cli_style_option::do_set_value): New function.
 928         (cli_style_option::add_setshow_commands): Add "skip_intensity"
 929         parameter.  Update.
 930         (STYLE_ADD_SETSHOW_COMMANDS): Add "SKIP" parameter.
 931         (_initialize_cli_style): Update.  Create TUI border style
 932         commands.
 933
 934 2019-12-01  Tom Tromey  <tom@tromey.com>
 935
 936         * tui/tui-winsource.h (tui_copy_source_line): Add "ndigits"
 937         parameter.
 938         * tui/tui-winsource.c (tui_copy_source_line): Add "ndigits"
 939         parameter.
 940         * tui/tui-win.h (compact_source): Declare.
 941         * tui/tui-win.c (compact_source): New global.
 942         (tui_set_compact_source, tui_show_compact_source): New functions.
 943         (_initialize_tui_win): Add "compact-source" setting.
 944         * tui/tui-source.c (tui_source_window::set_contents): Handle
 945         compact_source setting.
 946         * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
 947         * NEWS: Document new setting.
 948
 949 2019-11-30  Tom Tromey  <tom@tromey.com>
 950
 951         * dwarf2read.c (dwarf2_add_field): Include field offset when
 952         computing variant part length.
 953
 954 2019-11-30  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 955         * NEWS:  Mention define-prefix.  Tell that command names can now
 956         contain a . character.
 957
 958 2019-11-30  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 959
 960         * command.h (valid_cmd_char_p): Declare.
 961         * cli/cli-decode.c (valid_cmd_char_p): New function factorizing
 962         the check of valid command char.
 963         (find_command_name_length, valid_user_defined_cmd_name_p): Use
 964         valid_cmd_char_p.
 965         * cli/cli-script.c (validate_comname): Likewise.
 966         * completer.c (gdb_completer_command_word_break_characters):
 967         Do not remove . from the word break char, update comments.
 968         (complete_line_internal_1): Use valid_cmd_char_p.
 969         * guile/scm-cmd.c (gdbscm_parse_command_name): Likewise.
 970         * python/py-cmd.c (gdbpy_parse_command_name): Likewise.
 971
 972 2019-11-30  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 973
 974         * cli/cli-script.c (do_define_command): Ensure a redefined
 975         prefix command is kept as a prefix command.
 976         (define_prefix_command): New function.
 977         (show_user_1): Report user defined prefixes.
 978         (_initialize_cli_script):  Create the new 'define-prefix' command.
 979         Add completers for 'define' and 'document'.
 980         * top.c (execute_command):  If command is a user-defined prefix only
 981         command, report the list of commands for this prefix command.
 982
 983 2019-11-29  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
 984
 985         * valops.c (find_oload_champ): Improve debug output.
 986
 987 2019-11-29  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
 988
 989         * valops.c (find_oload_champ): Print part of debug messages
 990         before the badness vector is std::move'd.
 991
 992 2019-11-28  Tom Tromey  <tom@tromey.com>
 993
 994         * value.c (creal_internal_fn): Fix comment.
 995
 996 2019-11-28  Tom Tromey  <tom@tromey.com>
 997
 998         * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count,
 999         flag_bound_evaluated>: Now unsigned.
1000
1001 2019-11-28  Tom Tromey  <tom@tromey.com>
1002
1003         * guile/guile-internal.h (vlscm_scm_from_value_unsafe): Don't
1004         declare.
1005
1006 2019-11-28  Mihails Strasuns  <mihails.strasuns@intel.com>
1007
1008         * jit.c (jit_bfd_try_read_symtab): Fix printed function name in the
1009         debug output.
1010         * jit.c (jit_unregister_code): Add debug print to match
1011         `jit_register_code`.
1012
1013 2019-11-27  Christian Biesinger  <cbiesinger@google.com>
1014
1015         * NEWS: Mention the new multithreaded symbol loading.
1016
1017 2019-11-27  Christian Biesinger  <cbiesinger@google.com>
1018
1019         * maint.c (n_worker_threads): Default to 0.
1020         (worker_threads_disabled): New function.
1021         * maint.h (worker_threads_disabled): New function.
1022         * minsyms.c (minimal_symbol_reader::record_full): Call symbol_set_names
1023         here if worker_threads_disabled () is true.
1024         (minimal_symbol_reader::install): Skip all threading if
1025         worker_threads_disabled () is true.
1026
1027 2019-11-27  Christian Biesinger  <cbiesinger@google.com>
1028
1029         * minsyms.c (add_minsym_to_hash_table): Use a previously computed
1030         hash code if possible.
1031         (add_minsym_to_demangled_hash_table): Likewise.
1032         (minimal_symbol_reader::install): Compute the hash codes for msymbol
1033         on the background thread.
1034         * symtab.h (struct minimal_symbol) <hash_value, demangled_hash_value>:
1035         Add these fields.
1036
1037 2019-11-27  Christian Biesinger  <cbiesinger@google.com>
1038
1039         * minsyms.c (minimal_symbol_reader::install): Also compute the hash
1040         of the mangled name on the background thread.
1041         * symtab.c (symbol_set_names): Allow passing in the hash of the
1042         linkage_name.
1043         * symtab.h (symbol_set_names): Likewise.
1044
1045 2019-11-27  Kevin Buettner  <kevinb@redhat.com>
1046
1047         * dwarf2read.c (inherit_abstract_dies): Ensure that delayed
1048         physnames are computed for inherited DIEs.
1049
1050 2019-11-27  Tom Tromey  <tromey@adacore.com>
1051
1052         * dwarf2read.h (struct dwarf2_per_objfile): Remove unnecessary
1053         backslashes.
1054         * cp-support.c: Remove unnecessary backslashes.
1055
1056 2019-11-27  Christian Biesinger  <cbiesinger@google.com>
1057
1058         * ada-exp.y (write_ambiguous_var): Replace SYMBOL_SET_LINKAGE_NAME
1059         with sym->set_linkage_name.
1060         * coffread.c (coff_read_enum_type): Likewise.
1061         * mdebugread.c (parse_symbol): Likewise.
1062         * stabsread.c (patch_block_stabs): Likewise.
1063         (define_symbol): Likewise.
1064         (read_enum_type): Likewise.
1065         (common_block_end): Likewise.
1066         * symtab.h (struct general_symbol_info) <set_linkage_name>: New
1067         function.
1068         (SYMBOL_SET_LINKAGE_NAME): Remove.
1069         * xcoffread.c (process_xcoff_symbol): Replace SYMBOL_SET_LINKAGE_NAME
1070         with sym->set_linkage_name.
1071
1072 2019-11-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1073
1074         * mi/mi-cmds.c (mi_cmds): Add 'symbol-info-modules' entry.
1075         * mi/mi-cmds.h (mi_cmd_symbol_info_modules): Declare.
1076         * mi/mi-symbol-cmds.c (mi_cmd_symbol_info_modules): New function.
1077         * NEWS: Mention new MI command.
1078
1079 2019-11-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1080
1081         * mi/mi-cmds.c (mi_cmds): Add '-symbol-info-functions',
1082         '-symbol-info-types', and '-symbol-info-variables'.
1083         * mi/mi-cmds.h (mi_cmd_symbol_info_functions): Declare.
1084         (mi_cmd_symbol_info_types): Declare.
1085         (mi_cmd_symbol_info_variables): Declare.
1086         * mi/mi-symbol-cmds.c: Add 'source.h' and 'mi-getopt.h' includes.
1087         (output_debug_symbol): New function.
1088         (output_nondebug_symbol): New function.
1089         (mi_symbol_info): New function.
1090         (mi_info_functions_or_variables): New function.
1091         (mi_cmd_symbol_info_functions): New function.
1092         (mi_cmd_symbol_info_types): New function.
1093         (mi_cmd_symbol_info_variables): New function.
1094         * NEWS: Mention new commands.
1095
1096 2019-11-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1097
1098         * symtab.c (symbol_to_info_string): New function, most content
1099         moved from print_symbol_info, but updated to return a std::string.
1100         (print_symbol_info): Update to use symbol_to_info_string and print
1101         returned string.
1102         * symtab.h (symbol_to_info_string): Declare new function.
1103
1104 2019-11-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1105
1106         * python/python.c (gdbpy_rbreak): Convert to using
1107         global_symbol_searcher.
1108         * symtab.c (file_matches): Convert return type to bool, change
1109         file list to std::vector, update header comment.
1110         (search_symbols): Rename to...
1111         (global_symbol_searcher::search): ...this and update now its
1112         a member function of global_symbol_searcher.  Take account of the
1113         changes to file_matches.
1114         (symtab_symbol_info): Convert to using global_symbol_searcher.
1115         (rbreak_command): Likewise.
1116         (search_module_symbols): Likewise.
1117         * symtab.h (enum symbol_search): Update comment.
1118         (search_symbols): Remove declaration.
1119         (class global_symbol_searcher): New class.
1120
1121 2019-11-26  Tom Tromey  <tromey@adacore.com>
1122
1123         * cp-support.c (_initialize_cp_support): Conditionally initialize
1124         gdb_demangle_attempt_core_dump.
1125
1126 2019-11-26  Tom Tromey  <tom@tromey.com>
1127
1128         * python/py-function.c (fnpy_init): Update.
1129         * value.h (add_internal_function): Adjust declaration.
1130         * value.c (function_destroyer): Remove.
1131         (do_add_internal_function): Don't set destroyer or copy name.
1132         (add_internal_function): Take unique_xmalloc_ptr<char> for name.
1133         Set name_allocated.
1134         * python/py-cmd.c (cmdpy_destroyer): Don't free "name".
1135         (cmdpy_init): Set name_allocated.
1136         * cli/cli-decode.h (struct cmd_list_element) <name_allocated>: New
1137         member.
1138         (~cmd_list_element): Free "name" if needed.
1139
1140 2019-11-26  Tom Tromey  <tom@tromey.com>
1141
1142         * value.h (add_internal_function): Add new overload.  Move
1143         documentation from value.h.
1144         * value.c (do_add_internal_function): New function.
1145         (add_internal_function): Use it.  Add new overload.
1146         (function_destroyer): Don't free doc.
1147         * python/py-function.c (fnpy_init): Update.
1148
1149 2019-11-26  Tom Tromey  <tom@tromey.com>
1150
1151         * python/py-cmd.c (cmdpy_destroyer): Don't free "doc".
1152         (cmdpy_init): Set "doc_allocated".
1153
1154 2019-11-26  Tom Tromey  <tom@tromey.com>
1155
1156         * gdbsupport/thread-pool.c (thread_pool::set_thread_count): Set
1157         name of worker thread.
1158         * gdbsupport/common.m4 (GDB_AC_COMMON): Check for
1159         pthread_setname_np.
1160         * configure, config.in: Rebuild.
1161
1162 2019-11-26  Tom Tromey  <tom@tromey.com>
1163
1164         * python/python.c (class gdbpy_gil): New.
1165         (struct gdbpy_event): Add constructor, destructor, operator().
1166         (gdbpy_post_event): Use run_on_main_thread.
1167         (gdbpy_initialize_events): Remove.
1168         (do_start_initialization): Update.
1169
1170 2019-11-26  Tom Tromey  <tom@tromey.com>
1171
1172         * NEWS: Add entry.
1173         * maint.c (_initialize_maint_cmds): Add "worker-threads" maint
1174         commands.  Call update_thread_pool_size.
1175         (update_thread_pool_size, maintenance_set_worker_threads): New
1176         functions.
1177         (n_worker_threads): New global.
1178
1179 2019-11-26  Christian Biesinger  <cbiesinger@google.com>
1180             Tom Tromey  <tom@tromey.com>
1181
1182         * minsyms.c (minimal_symbol_reader::install): Use
1183         parallel_for_each.
1184         * gdbsupport/parallel-for.h: New file.
1185         * Makefile.in (HFILES_NO_SRCDIR): Add gdbsupport/parallel-for.h.
1186
1187 2019-11-26  Christian Biesinger  <cbiesinger@google.com>
1188             Tom Tromey  <tom@tromey.com>
1189
1190         * gdbsupport/thread-pool.h: New file.
1191         * gdbsupport/thread-pool.c: New file.
1192         * Makefile.in (COMMON_SFILES): Add thread-pool.c.
1193         (HFILES_NO_SRCDIR): Add thread-pool.h.
1194
1195 2019-11-26  Tom Tromey  <tom@tromey.com>
1196
1197         * event-top.h (thread_local_segv_handler): Declare.
1198         * event-top.c (thread_local_segv_handler): New global.
1199         (install_handle_sigsegv, handle_sigsegv): New functions.
1200         (async_init_signals): Install SIGSEGV handler.
1201         * cp-support.c (gdb_demangle_jmp_buf): Change type.  Now
1202         thread-local.
1203         (report_failed_demangle): New function.
1204         (gdb_demangle): Make core_dump_allowed atomic.  Remove signal
1205         handler-setting code, instead use segv_handler.  Run warning code
1206         on main thread.
1207
1208 2019-11-26  Tom Tromey  <tom@tromey.com>
1209
1210         * run-on-main-thread.c: New file.
1211         * run-on-main-thread.h: New file.
1212         * unittests/main-thread-selftests.c: New file.
1213         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
1214         main-thread-selftests.c.
1215         (HFILES_NO_SRCDIR): Add run-on-main-thread.h.
1216         (COMMON_SFILES): Add run-on-main-thread.c.
1217
1218 2019-11-26  Tom Tromey  <tom@tromey.com>
1219
1220         * main.c (setup_alternate_signal_stack): Remove.
1221         (captured_main_1): Use gdb::alternate_signal_stack.
1222         * gdbsupport/alt-stack.h: New file.
1223
1224 2019-11-26  Tom Tromey  <tom@tromey.com>
1225
1226         * gdbsupport/signals-state-save-restore.c (original_signal_mask):
1227         Remove comment.
1228         (save_original_signals_state, restore_original_signals_state): Use
1229         gdb_sigmask.
1230         * linux-nat.c (block_child_signals, restore_child_signals_mask)
1231         (_initialize_linux_nat): Use gdb_sigmask.
1232         * guile/guile.c (_initialize_guile): Use block_signals.
1233         * Makefile.in (HFILES_NO_SRCDIR): Add gdb-sigmask.h.
1234         * gdbsupport/gdb-sigmask.h: New file.
1235         * event-top.c (async_sigtstp_handler): Use gdb_sigmask.
1236         * cp-support.c (gdb_demangle): Use gdb_sigmask.
1237         * gdbsupport/common.m4 (GDB_AC_COMMON): Check for
1238         pthread_sigmask.
1239         * configure, config.in: Rebuild.
1240         * gdbsupport/block-signals.h: New file.
1241
1242 2019-11-26  Tom Tromey  <tom@tromey.com>
1243
1244         * acinclude.m4: Include ax_pthread.m4.
1245         * Makefile.in (PTHREAD_CFLAGS, PTHREAD_LIBS): New variables.
1246         (INTERNAL_CFLAGS_BASE): Use PTHREAD_CFLAGS.
1247         (CLIBS): Use PTHREAD_LIBS.
1248         (aclocal_m4_deps): Add ax_pthread.m4.
1249         * config.in, configure: Rebuild.
1250         * gdbsupport/common.m4 (GDB_AC_COMMON): Check for std::thread.
1251
1252 2019-11-26  Tom Tromey  <tom@tromey.com>
1253
1254         * symtab.h (struct minimal_symbol) <name_set>: New member.
1255         * minsyms.c (minimal_symbol_reader::record_full): Copy name.
1256         Don't call symbol_set_names.
1257         (minimal_symbol_reader::install): Call symbol_set_names.
1258
1259 2019-11-26  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1260
1261         * python/python.c (gdbpy_enter::~gdbpy_enter): Release GIL after
1262         restore_active_ext_lang, as GIL is needed for (indirectly)
1263         called PyOS_InterruptOccurred.
1264
1265 2019-11-26  Simon Marchi  <simon.marchi@efficios.com>
1266
1267         * sparc-nat.c (sparc_xfer_wcookie): Sync declaration with
1268         definition.
1269
1270 2019-11-26  Simon Marchi  <simon.marchi@efficios.com>
1271
1272         * remote-sim.c (simulator_command): Make static, remove
1273         declaration.
1274
1275 2019-11-26  Simon Marchi  <simon.marchi@efficios.com>
1276
1277         * unittests/array-view-selftests.c (check_ptr_size_ctor2): Make
1278         static.
1279         * unittests/basic_string_view/capacity/1.cc (test01): Likewise.
1280         * unittests/basic_string_view/cons/char/1.cc (test01): Likewise.
1281         (main): Likewise.
1282         * unittests/basic_string_view/cons/char/2.cc (test03): Likewise.
1283         (main): Likewise.
1284         * unittests/basic_string_view/cons/char/3.cc (test05): Likewise.
1285         (main): Likewise.
1286         * unittests/basic_string_view/element_access/char/1.cc (test01):
1287         Likewise.
1288         (main): Likewise.
1289         * unittests/basic_string_view/element_access/char/empty.cc (main):
1290         Likewise.
1291         * unittests/basic_string_view/element_access/char/front_back.cc
1292         (test01): Likewise.
1293         (main): Likewise.
1294         * unittests/basic_string_view/inserters/char/2.cc (test05):
1295         Likewise.
1296         (main): Likewise.
1297         * unittests/basic_string_view/modifiers/remove_prefix/char/1.cc
1298         (test01): Likewise.
1299         (main): Likewise.
1300         * unittests/basic_string_view/modifiers/remove_suffix/char/1.cc
1301         (test01): Likewise.
1302         (main): Likewise.
1303         * unittests/basic_string_view/modifiers/swap/char/1.cc (test01):
1304         Likewise.
1305         * unittests/basic_string_view/operations/compare/char/1.cc
1306         (test01): Likewise.
1307         (main): Likewise.
1308         * unittests/basic_string_view/operations/compare/char/13650.cc
1309         (test01): Likewise.
1310         * unittests/basic_string_view/operations/copy/char/1.cc (test01):
1311         Likewise.
1312         (main): Likewise.
1313         * unittests/basic_string_view/operations/data/char/1.cc (test01):
1314         Likewise.
1315         (main): Likewise.
1316         * unittests/basic_string_view/operations/find/char/1.cc (test01):
1317         Likewise.
1318         (main): Likewise.
1319         * unittests/basic_string_view/operations/find/char/2.cc (test02):
1320         Likewise.
1321         (main): Likewise.
1322         * unittests/basic_string_view/operations/find/char/3.cc (test03):
1323         Likewise.
1324         (main): Likewise.
1325         * unittests/basic_string_view/operations/find/char/4.cc (main):
1326         Likewise.
1327         * unittests/basic_string_view/operations/rfind/char/1.cc (test01):
1328         Likewise.
1329         (main): Likewise.
1330         * unittests/basic_string_view/operations/rfind/char/2.cc (test02):
1331         Likewise.
1332         (main): Likewise.
1333         * unittests/basic_string_view/operations/rfind/char/3.cc (test03):
1334         Likewise.
1335         (main): Likewise.
1336         * unittests/basic_string_view/operations/substr/char/1.cc
1337         (test01): Likewise.
1338         (main): Likewise.
1339         * unittests/basic_string_view/operators/char/2.cc (main):
1340         Likewise.
1341         * unittests/optional/assignment/1.cc (test): Likewise.
1342         * unittests/optional/assignment/2.cc (test): Likewise.
1343         * unittests/optional/assignment/3.cc (test): Likewise.
1344         * unittests/optional/assignment/4.cc (test): Likewise.
1345         * unittests/optional/assignment/5.cc (test): Likewise.
1346         * unittests/optional/assignment/6.cc (test): Likewise.
1347         * unittests/optional/assignment/7.cc (test): Likewise.
1348         * unittests/optional/cons/copy.cc (test): Likewise.
1349         * unittests/optional/cons/default.cc (test): Likewise.
1350         * unittests/optional/cons/move.cc (test): Likewise.
1351         * unittests/optional/cons/value.cc (test): Likewise.
1352         * unittests/optional/in_place.cc (test): Likewise.
1353         * unittests/optional/observers/1.cc (test): Likewise.
1354         * unittests/optional/observers/2.cc (test): Likewise.
1355
1356 2019-11-26  Simon Marchi  <simon.marchi@efficios.com>
1357
1358         * tui-win.h (tui_set_var_cmd): Remove.
1359         * tui-win.c (tui_set_var_cmd): Make static.
1360
1361 2019-11-26  Simon Marchi  <simon.marchi@efficios.com>
1362
1363         * breakpoint.h (hbreak_command_wrapper, thbreak_command_wrapper,
1364         rbreak_command_wrapper): Remove.
1365         * symtab.c (rbreak_command_wrapper): Remove.
1366
1367 2019-11-26  Simon Marchi  <simon.marchi@efficios.com>
1368
1369         * inferior.h (info_terminal_command): Remove declaration.
1370         * inflow.c (info_terminal_command): Make static.
1371
1372 2019-11-26  Simon Marchi  <simon.marchi@efficios.com>
1373
1374         * inferior.c (exit_inferior_silent): Remove.
1375
1376 2019-11-26  Simon Marchi  <simon.marchi@efficios.com>
1377
1378         * dictionary.c (dict_empty, mdict_empty): Remove.
1379         * dictionary.c (mdict_empty): Remove.
1380
1381 2019-11-26  Simon Marchi  <simon.marchi@efficios.com>
1382
1383          * arc-tdep.c (arc_insn_get_memory_base_reg): Make static.
1384          (arc_insn_get_memory_offset): Likewise.
1385          (arc_insn_dump): Likewise.
1386          * cp-support.c (test_cp_symbol_name_matches): Likewise.
1387          * csky-linux-tdep.c (csky_supply_fregset): Likewise.
1388          * dictionary.c (dict_iterator_next): Likewise.
1389          (dict_iter_match_first): Likewise.
1390          (dict_iter_match_next): Likewise.
1391          * f-lang.c (evaluate_subexp_f): Likewise.
1392          * hppa-tdep.c (hppa_read_pc): Likewise.
1393          * i386-tdep.c (i386_floatformat_for_type): Likewise.
1394          * parse.c (write_exp_elt_msym): Likewise.
1395          * ppc-linux-tdep.c (ppc_floatformat_for_type): Likewise.
1396          * remote.c (remote_packet_size): Likewise.
1397          (remote_notif_stop_parse): Likewise.
1398          * rs6000-aix-tdep.c (aix_sighandle_frame_sniffer): Likewise.
1399          * s12z-tdep.c (s12z_disassemble_info): Likewise.
1400          * source.c (prepare_path_for_appending): Likewise.
1401          * sparc64-linux-tdep.c
1402          (sparc64_linux_handle_segmentation_fault); Likewise.
1403          * stack.c (frame_selection_by_function_completer): Likewise.
1404
1405 2019-11-26  Simon Marchi  <simon.marchi@efficios.com>
1406
1407         * completer.c (set_gdb_completion_word_break_characters):
1408         Remove.
1409
1410 2019-11-26  Simon Marchi  <simon.marchi@efficios.com>
1411
1412         * dwarf-index-write.c: Include dwarf-index-write.h.
1413         * mi/mi-interp.c: Include mi/mi-interp.h.
1414
1415 2019-11-26  Simon Marchi  <simon.marchi@efficios.com>
1416
1417         * aarch32-tdep.c: Include aarch32-tdep.h.
1418         * aarch32-tdep.h: Forward-declare struct target_desc.
1419
1420 2019-11-26  Christian Biesinger  <cbiesinger@google.com>
1421
1422         * linux-nat.c (detach_one_lwp): Call safe_strerror instead of
1423         strerror.
1424         * nto-procfs.c (nto_procfs_target::create_inferior): Likewise.
1425         * windows-nat.c (windows_nat_target::create_inferior): Likewise.
1426
1427 2019-11-25  Tom de Vries  <tdevries@suse.de>
1428
1429         * contrib/words.sh: Add -c option.
1430
1431 2019-11-25  Christian Biesinger  <cbiesinger@google.com>
1432
1433         * solib.c (solib_find_1): Change int to bool.
1434         (exec_file_find): Change int to bool.
1435         (solib_find): Change int to bool.
1436         (solib_read_symbols): Change int to bool.
1437         (solib_used): Change int to bool.
1438         (solib_add): Change int to bool.
1439         (info_sharedlibrary_command): Change int to bool.
1440         (solib_contains_address_p): Change int to bool.
1441         (solib_keep_data_in_core): Change int to bool.
1442         (in_solib_dynsym_resolve_code): Change int to bool.
1443         (reload_shared_libraries_1): Change int to bool.
1444         (gdb_sysroot_changed): Change int to bool.
1445         * solib.h (solib_read_symbols): Change int to bool.
1446         (solib_contains_address_p): Change int to bool.
1447         (solib_keep_data_in_core): Change int to bool.
1448         (in_solib_dynsym_resolve_code): Change int to bool.
1449         (libpthread_name_p): Change int to bool.
1450
1451 2019-11-25  Luis Machado  <luis.machado@linaro.org>
1452
1453         * NEWS (New Commands): Mention "set debug remote-packet-max-chars".
1454         * remote.c (REMOTE_DEBUG_MAX_CHAR): Remove.
1455         (remote_packet_max_chars): New static global.
1456         (show_remote_packet_max_chars): New function.
1457         (remote_target::putpkt_binary): Adjust to use new
1458         remote_packet_max_chars option.
1459         (remote_target::getpkt_or_notif_sane_1): Likewise.
1460         (_initialize_remote): Register new remote-packet-max-chars option.
1461
1462 2019-11-24  Simon Marchi  <simon.marchi@efficios.com>
1463
1464         * m68k-linux-nat.c: Include gdbarch.h.
1465
1466 2019-11-24  Tom Tromey  <tom@tromey.com>
1467
1468         * symfile.c (read_symbols): Update.
1469         * psymtab.c (require_partial_symbols): Change type of "verbose" to
1470         bool.
1471         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
1472         (psym_lookup_symbol, psym_find_last_source_symtab)
1473         (psym_forget_cached_source_info, psym_print_stats)
1474         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
1475         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
1476         (psym_map_matching_symbols, psym_expand_symtabs_matching)
1477         (psym_find_compunit_symtab_by_address)
1478         (maintenance_print_psymbols, maintenance_info_psymtabs)
1479         (maintenance_check_psymtabs): Update.
1480         * psymtab.h (require_partial_symbols): Change type of "verbose" to
1481         bool.
1482
1483 2019-11-22  Tom Tromey  <tom@tromey.com>
1484
1485         * observable.h: Update comments.
1486
1487 2019-11-22  Tom Tromey  <tromey@adacore.com>
1488
1489         * ada-tasks.c (ada_task_is_alive): Make parameter const.
1490         (print_ada_task_info): Don't try to fetch thread id if task is not
1491         alive.
1492
1493 2019-11-22  Christian Biesinger  <cbiesinger@google.com>
1494
1495         * ada-exp.y: Update.
1496         * ada-lang.c (sort_choices): Update.
1497         (ada_print_symbol_signature): Update.
1498         (resolve_subexp): Update.
1499         (ada_parse_renaming): Update.
1500         (ada_read_renaming_var_value): Update.
1501         (lesseq_defined_than): Update.
1502         (remove_extra_symbols): Update.
1503         (remove_irrelevant_renamings): Update.
1504         (ada_add_block_symbols): Update.
1505         (ada_collect_symbol_completion_matches): Update.
1506         (ada_is_renaming_symbol): Update.
1507         (aggregate_assign_from_choices): Update.
1508         (ada_evaluate_subexp): Update.
1509         (ada_has_this_exception_support): Update.
1510         (ada_is_non_standard_exception_sym): Update.
1511         (ada_add_exceptions_from_frame): Update.
1512         (ada_add_global_exceptions): Update.
1513         (ada_print_subexp): Update.
1514         * ax-gdb.c (gen_var_ref): Update.
1515         (gen_maybe_namespace_elt): Update.
1516         (gen_expr_for_cast): Update.
1517         (gen_expr): Update.
1518         * block.h: Update.
1519         * blockframe.c (find_pc_partial_function): Update.
1520         * breakpoint.c (print_breakpoint_location): Update.
1521         (update_static_tracepoint): Update.
1522         * btrace.c (ftrace_print_function_name): Update.
1523         (ftrace_function_switched): Update.
1524         * buildsym.c (find_symbol_in_list): Update.
1525         * c-exp.y: Update.
1526         * c-typeprint.c (c_print_typedef): Update.
1527         (c_type_print_template_args): Update.
1528         * cli/cli-cmds.c (edit_command): Update.
1529         (list_command): Update.
1530         (print_sal_location): Update.
1531         * coffread.c (patch_opaque_types): Update.
1532         (process_coff_symbol): Update.
1533         (coff_read_enum_type): Update.
1534         * compile/compile-c-symbols.c (c_symbol_substitution_name): Update.
1535         (convert_one_symbol): Update.
1536         (hash_symname): Update.
1537         (eq_symname): Update.
1538         * compile/compile-cplus-symbols.c (convert_one_symbol): Update.
1539         * compile/compile-cplus-types.c (debug_print_scope): Update.
1540         * compile/compile-loc2c.c (do_compile_dwarf_expr_to_c): Update.
1541         * compile/compile-object-load.c (get_out_value_type): Update.
1542         * cp-namespace.c (cp_scan_for_anonymous_namespaces): Update.
1543         (search_symbol_list): Update.
1544         (cp_lookup_symbol_imports_or_template): Update.
1545         * cp-support.c (overload_list_add_symbol): Update.
1546         * ctfread.c (psymtab_to_symtab): Update.
1547         * dbxread.c (cp_set_block_scope): Update.
1548         * dictionary.c (iter_match_first_hashed): Update.
1549         (iter_match_next_hashed): Update.
1550         (insert_symbol_hashed): Update.
1551         (iter_match_next_linear): Update.
1552         * dictionary.h: Update.
1553         * dwarf2loc.c (func_get_frame_base_dwarf_block): Update.
1554         (locexpr_describe_location_piece): Update.
1555         (locexpr_describe_location_1): Update.
1556         (locexpr_generate_c_location): Update.
1557         (loclist_describe_location): Update.
1558         (loclist_generate_c_location): Update.
1559         * dwarf2read.c (dw2_debug_names_lookup_symbol): Update.
1560         (read_func_scope): Update.
1561         (process_enumeration_scope): Update.
1562         (new_symbol): Update.
1563         (dwarf2_const_value): Update.
1564         (dwarf2_symbol_mark_computed): Update.
1565         * eval.c (evaluate_funcall): Update.
1566         (evaluate_subexp_standard): Update.
1567         * expprint.c (print_subexp_standard): Update.
1568         (dump_subexp_body_standard): Update.
1569         * f-valprint.c (info_common_command_for_block): Update.
1570         * findvar.c (get_hosting_frame): Update.
1571         (default_read_var_value): Update.
1572         * go-lang.c (go_symbol_package_name): Update.
1573         * guile/scm-block.c (bkscm_print_block_smob): Update.
1574         * guile/scm-symbol.c (syscm_print_symbol_smob): Update.
1575         (gdbscm_symbol_name): Update.
1576         (gdbscm_symbol_linkage_name): Update.
1577         (gdbscm_symbol_print_name): Update.
1578         * infcall.c (get_function_name): Update.
1579         * infcmd.c (jump_command): Update.
1580         (finish_command): Update.
1581         * infrun.c (insert_exception_resume_breakpoint): Update.
1582         * linespec.c (canonicalize_linespec): Update.
1583         (create_sals_line_offset): Update.
1584         (convert_linespec_to_sals): Update.
1585         (complete_label): Update.
1586         (find_label_symbols_in_block): Update.
1587         * m2-typeprint.c (m2_print_typedef): Update.
1588         * mdebugread.c (mdebug_reg_to_regnum): Update.
1589         (parse_symbol): Update.
1590         (mylookup_symbol): Update.
1591         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
1592         (list_args_or_locals): Update.
1593         * objc-lang.c (compare_selectors): Update.
1594         (info_selectors_command): Update.
1595         (compare_classes): Update.
1596         (info_classes_command): Update.
1597         (find_imps): Update.
1598         * p-typeprint.c (pascal_print_typedef): Update.
1599         * printcmd.c (build_address_symbolic): Update.
1600         (info_address_command): Update.
1601         (print_variable_and_value): Update.
1602         * python/py-framefilter.c (extract_sym): Update.
1603         (py_print_single_arg): Update.
1604         * python/py-symbol.c (sympy_str): Update.
1605         (sympy_get_name): Update.
1606         (sympy_get_linkage_name): Update.
1607         * python/python.c (gdbpy_rbreak): Update.
1608         * record-btrace.c (btrace_get_bfun_name): Update.
1609         (btrace_call_history): Update.
1610         * rust-lang.c (rust_print_typedef): Update.
1611         * solib-frv.c (frv_fdpic_find_canonical_descriptor): Update.
1612         * stabsread.c (stab_reg_to_regnum): Update.
1613         (define_symbol): Update.
1614         (read_enum_type): Update.
1615         (common_block_end): Update.
1616         (cleanup_undefined_types_1): Update.
1617         (scan_file_globals): Update.
1618         * stack.c (print_frame_arg): Update.
1619         (print_frame_args): Update.
1620         (find_frame_funname): Update.
1621         (info_frame_command_core): Update.
1622         (iterate_over_block_locals): Update.
1623         (print_block_frame_labels): Update.
1624         (do_print_variable_and_value): Update.
1625         (iterate_over_block_arg_vars): Update.
1626         (return_command): Update.
1627         * symmisc.c (dump_symtab_1): Update.
1628         (print_symbol): Update.
1629         * symtab.c (eq_symbol_entry): Update.
1630         (symbol_cache_dump): Update.
1631         (lookup_language_this): Update.
1632         (find_pc_sect_line): Update.
1633         (skip_prologue_sal): Update.
1634         (symbol_search::compare_search_syms): Update.
1635         (treg_matches_sym_type_name): Update.
1636         (search_symbols): Update.
1637         (print_symbol_info): Update.
1638         (rbreak_command): Update.
1639         (completion_list_add_symbol): Update.
1640         (find_gnu_ifunc): Update.
1641         (get_symbol_address): Update.
1642         (search_module_symbols): Update.
1643         (info_module_subcommand): Update.
1644         * symtab.h (SYMBOL_NATURAL_NAME): Remove.
1645         (SYMBOL_LINKAGE_NAME): Remove.
1646         (SYMBOL_DEMANGLED_NAME): Remove.
1647         (SYMBOL_PRINT_NAME): Remove.
1648         (SYMBOL_SEARCH_NAME): Remove.
1649         * tracepoint.c (set_traceframe_context): Update.
1650         (validate_actionline): Update.
1651         (collection_list::collect_symbol): Update.
1652         (encode_actions_1): Update.
1653         (info_scope_command): Update.
1654         (print_one_static_tracepoint_marker): Update.
1655         * typeprint.c (typedef_hash_table::add_template_parameters): Update.
1656         * valops.c (address_of_variable): Update.
1657         (find_overload_match): Update.
1658         (find_oload_champ): Update.
1659
1660 2019-11-22  Christian Biesinger  <cbiesinger@google.com>
1661
1662         * ada-lang.c (ada_lookup_simple_minsym): Update.
1663         (ada_collect_symbol_completion_matches): Update.
1664         * ada-tasks.c (read_atcb): Update.
1665         * amd64-windows-tdep.c (amd64_skip_main_prologue): Update.
1666         (amd64_windows_skip_trampoline_code): Update.
1667         * arm-tdep.c (skip_prologue_function): Update.
1668         (arm_skip_stack_protector): Update.
1669         * arm-wince-tdep.c (arm_pe_skip_trampoline_code): Update.
1670         (arm_wince_skip_main_prologue): Update.
1671         * ax-gdb.c (gen_expr): Update.
1672         * block.c (call_site_for_pc): Update.
1673         * blockframe.c (find_pc_partial_function): Update.
1674         * breakpoint.c (set_breakpoint_location_function): Update.
1675         * btrace.c (ftrace_print_function_name): Update.
1676         (ftrace_function_switched): Update.
1677         * c-valprint.c (print_unpacked_pointer): Update.
1678         * coffread.c (coff_symfile_read): Update.
1679         * compile/compile-c-symbols.c (convert_symbol_bmsym): Update.
1680         * compile/compile-cplus-symbols.c (convert_symbol_bmsym): Update.
1681         * dwarf-index-write.c (write_psymbols): Update.
1682         * dwarf2loc.c (call_site_to_target_addr): Update.
1683         (func_verify_no_selftailcall): Update.
1684         (tailcall_dump): Update.
1685         (call_site_find_chain_1): Update.
1686         (dwarf_expr_reg_to_entry_parameter): Update.
1687         * elfread.c (elf_gnu_ifunc_record_cache): Update.
1688         * eval.c (evaluate_funcall): Update.
1689         (evaluate_subexp_standard): Update.
1690         (evaluate_subexp_for_sizeof): Update.
1691         * expprint.c (print_subexp_standard): Update.
1692         (dump_subexp_body_standard): Update.
1693         * frame.c (get_prev_frame_always_1): Update.
1694         * frv-tdep.c (frv_skip_main_prologue): Update.
1695         * gnu-v2-abi.c (gnuv2_value_rtti_type): Update.
1696         * gnu-v3-abi.c (gnuv3_rtti_type): Update.
1697         (gnuv3_get_typename_from_type_info): Update.
1698         (gnuv3_skip_trampoline): Update.
1699         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
1700         * i386-tdep.c (i386_skip_main_prologue): Update.
1701         (i386_pe_skip_trampoline_code): Update.
1702         * ia64-tdep.c (ia64_convert_from_func_ptr_addr): Update.
1703         * infcall.c (get_function_name): Update.
1704         * linespec.c (minsym_found): Update.
1705         * linux-fork.c (info_checkpoints_command): Update.
1706         * m32c-tdep.c (m32c_m16c_address_to_pointer): Update.
1707         (m32c_m16c_pointer_to_address): Update.
1708         * maint.c (maintenance_translate_address): Update.
1709         * minsyms.c (add_minsym_to_hash_table): Update.
1710         (add_minsym_to_demangled_hash_table): Update.
1711         (lookup_minimal_symbol_mangled): Update.
1712         (lookup_minimal_symbol_demangled): Update.
1713         (lookup_minimal_symbol_linkage): Update.
1714         (lookup_minimal_symbol_text): Update.
1715         (lookup_minimal_symbol_by_pc_name): Update.
1716         (minimal_symbol_is_less_than): Update.
1717         (compact_minimal_symbols): Update.
1718         (build_minimal_symbol_hash_tables): Update.
1719         (find_solib_trampoline_target): Update.
1720         * mips-tdep.c (mips_stub_frame_sniffer): Update.
1721         (mips_skip_pic_trampoline_code): Update.
1722         * msp430-tdep.c (msp430_skip_trampoline_code): Update.
1723         * objc-lang.c (info_selectors_command): Update.
1724         (info_classes_command): Update.
1725         (find_methods): Update.
1726         (find_imps): Update.
1727         * p-valprint.c (pascal_val_print): Update.
1728         * ppc-linux-tdep.c (powerpc_linux_in_dynsym_resolve_code): Update.
1729         * ppc-sysv-tdep.c (convert_code_addr_to_desc_addr): Update.
1730         * printcmd.c (build_address_symbolic): Update.
1731         (info_symbol_command): Update.
1732         * psymtab.c (psymbol_name_matches): Update.
1733         (match_partial_symbol): Update.
1734         (lookup_partial_symbol): Update.
1735         (print_partial_symbols): Update.
1736         (sort_pst_symbols): Update.
1737         (maintenance_check_psymtabs): Update.
1738         * python/py-framefilter.c (py_print_frame): Update.
1739         * python/python.c (gdbpy_rbreak): Update.
1740         * record-btrace.c (btrace_get_bfun_name): Update.
1741         (btrace_call_history): Update.
1742         * rs6000-tdep.c (rs6000_skip_main_prologue): Update.
1743         (rs6000_skip_trampoline_code): Update.
1744         * sol-thread.c (info_cb): Update.
1745         * stabsread.c (scan_file_globals): Update.
1746         * stack.c (find_frame_funname): Update.
1747         (info_frame_command_core): Update.
1748         * symmisc.c (dump_msymbols): Update.
1749         * symtab.c (symbol_natural_name): Rename to..,
1750         (general_symbol_info::natural_name): ...this.
1751         (symbol_demangled_name): Rename to...
1752         (general_symbol_info::demangled_name): ...this.
1753         (symbol_search_name): Rename to...
1754         (general_symbol_info::search_name): ...this.
1755         (symbol_matches_search_name): Update.
1756         (find_pc_sect_line): Update.
1757         (skip_prologue_sal): Update.
1758         (search_symbols): Update.
1759         (print_msymbol_info): Update.
1760         (rbreak_command): Update.
1761         (completion_list_add_msymbol): Update.
1762         (completion_list_objc_symbol): Update.
1763         (get_msymbol_address): Update.
1764         * symtab.h (struct general_symbol_info): Add member functions
1765         natural_name (), linkage_name (), print_name (), demangled_name (),
1766         and search_name ().
1767         (SYMBOL_NATURAL_NAME): Update.
1768         (symbol_natural_name): Move to a member function on general_symbol_info.
1769         (SYMBOL_DEMANGLED_NAME): Update.
1770         (symbol_demangled_name): Move to a member function on
1771         general_symbol_info.
1772         (SYMBOL_SEARCH_NAME): Update.
1773         (symbol_search_name): Move to a member function on general_symbol_info.
1774         (MSYMBOL_NATURAL_NAME): Remove.
1775         (MSYMBOL_LINKAGE_NAME): Remove.
1776         (MSYMBOL_PRINT_NAME): Remove.
1777         (MSYMBOL_DEMANGLED_NAME): Remove.
1778         (MSYMBOL_SEARCH_NAME): Remove.
1779         * x86-tdep.c (x86_in_indirect_branch_thunk): Update.
1780
1781 2019-11-22  Christian Biesinger  <cbiesinger@google.com>
1782
1783         * symtab.c (create_demangled_names_hash): Use per_bfd->
1784         minimal_symbol_count for computing the initial size, if greater
1785         than our default size.
1786
1787 2019-11-22  Tom de Vries  <tdevries@suse.de>
1788
1789         * contrib/words.sh: Improve words extraction.
1790
1791 2019-11-22  Tom de Vries  <tdevries@suse.de>
1792
1793         * contrib/words.sh: Combine sed invocations.
1794
1795 2019-11-21  Christian Biesinger  <cbiesinger@google.com>
1796
1797         * Makefile.in: Update.
1798         * demangle.c: Rename to...
1799         * gdb-demangle.c: ..this.
1800         (is_cplus_marker): Change return type to bool.
1801         (_initialize_demangler): Rename to...
1802         (_initialize_gdb_demangle): ...this.
1803         * gdb-demangle.h (is_cplus_marker): Change return type to bool.
1804         * symtab.h (demangle): Remove declaration; instead include
1805         gdb-demangle.h.
1806
1807 2019-11-21  Tom Tromey  <tromey@adacore.com>
1808
1809         * gdbsupport/format.c (format_pieces): Parse %I64d.
1810         * unittests/format_pieces-selftests.c (test_windows_formats): New
1811         function.
1812         (run_tests): Call it.
1813
1814 2019-11-21  Peeter Joot  <peeter.joot@lzlabs.com>
1815
1816         Byte reverse display of variables with DW_END_big, DW_END_little
1817         (DW_AT_endianity) dwarf attributes if different than the native
1818         byte order.
1819         * ada-lang.c (ada_value_binop):
1820         Use type_byte_order instead of gdbarch_byte_order.
1821         * ada-valprint.c (printstr):
1822         (ada_val_print_string):
1823         * ada-lang.c (value_pointer):
1824         (ada_value_binop):
1825         Use type_byte_order instead of gdbarch_byte_order.
1826         * c-lang.c (c_get_string):
1827         Use type_byte_order instead of gdbarch_byte_order.
1828         * c-valprint.c (c_val_print_array):
1829         Use type_byte_order instead of gdbarch_byte_order.
1830         * cp-valprint.c (cp_print_class_member):
1831         Use type_byte_order instead of gdbarch_byte_order.
1832         * dwarf2loc.c (rw_pieced_value):
1833         Use type_byte_order instead of gdbarch_byte_order.
1834         * dwarf2read.c (read_base_type): Handle DW_END_big,
1835         DW_END_little
1836         * f-lang.c (f_get_encoding):
1837         Use type_byte_order instead of gdbarch_byte_order.
1838         * findvar.c (default_read_var_value):
1839         Use type_byte_order instead of gdbarch_byte_order.
1840         * gdbtypes.c (check_types_equal):
1841         Require matching TYPE_ENDIANITY_NOT_DEFAULT if set.
1842         (recursive_dump_type): Print TYPE_ENDIANITY_BIG,
1843         and TYPE_ENDIANITY_LITTLE if set.
1844         (type_byte_order): new function.
1845         * gdbtypes.h (TYPE_ENDIANITY_NOT_DEFAULT): New macro.
1846         (struct main_type) <flag_endianity_not_default>:
1847         New field.
1848         (type_byte_order): New function.
1849         * infcmd.c (default_print_one_register_info):
1850         Use type_byte_order instead of gdbarch_byte_order.
1851         * p-lang.c (pascal_printstr):
1852         Use type_byte_order instead of gdbarch_byte_order.
1853         * p-valprint.c (pascal_val_print):
1854         Use type_byte_order instead of gdbarch_byte_order.
1855         * printcmd.c (print_scalar_formatted):
1856         Use type_byte_order instead of gdbarch_byte_order.
1857         * solib-darwin.c (darwin_current_sos):
1858         Use type_byte_order instead of gdbarch_byte_order.
1859         * solib-svr4.c (solib_svr4_r_ldsomap):
1860         Use type_byte_order instead of gdbarch_byte_order.
1861         * stap-probe.c (stap_modify_semaphore):
1862         Use type_byte_order instead of gdbarch_byte_order.
1863         * target-float.c (target_float_same_format_p):
1864         Use type_byte_order instead of gdbarch_byte_order.
1865         * valarith.c (scalar_binop):
1866         (value_bit_index):
1867         Use type_byte_order instead of gdbarch_byte_order.
1868         * valops.c (value_cast):
1869         Use type_byte_order instead of gdbarch_byte_order.
1870         * valprint.c (generic_emit_char):
1871         (generic_printstr):
1872         (val_print_string):
1873         Use type_byte_order instead of gdbarch_byte_order.
1874         * value.c (unpack_long):
1875         (unpack_bits_as_long):
1876         (unpack_value_bitfield):
1877         (modify_field):
1878         (pack_long):
1879         (pack_unsigned_long):
1880         Use type_byte_order instead of gdbarch_byte_order.
1881         * findvar.c (unsigned_pointer_to_address):
1882         (signed_pointer_to_address):
1883         (unsigned_address_to_pointer):
1884         (address_to_signed_pointer):
1885         (default_read_var_value):
1886         (default_value_from_register):
1887         Use type_byte_order instead of gdbarch_byte_order.
1888         * gnu-v3-abi.c (gnuv3_make_method_ptr):
1889         Use type_byte_order instead of gdbarch_byte_order.
1890         * riscv-tdep.c (riscv_print_one_register_info):
1891         Use type_byte_order instead of gdbarch_byte_order.
1892
1893 2019-11-21  Simon Marchi  <simon.marchi@polymtl.ca>
1894
1895         * top.c (current_ui_gdb_stdout_ptr): Spell out by hand.
1896         (current_ui_gdb_stdin_ptr): Likewise.
1897         (current_ui_gdb_stderr_ptr): Likewise.
1898         (current_ui_gdb_stdlog_ptr): Likewise.
1899         (current_ui_current_uiout_ptr): Likewise.
1900         (gen_ret_current_ui_field_ptr): Remove.
1901
1902 2019-11-21  Tom de Vries  <tdevries@suse.de>
1903
1904         PR gdb/24956
1905         * cli/cli-script.c (execute_control_command): Only switch to
1906         INTERP_CONSOLE's ui_out when INTERP_MI is active.
1907
1908 2019-11-19  Tom Tromey  <tom@tromey.com>
1909
1910         * tui/tui-win.c (tui_partial_win_by_name): Move from tui-data.c.
1911         Now static.  Change type of "name".
1912         (tui_set_win_height_command): Don't copy "arg".
1913         * tui/tui-data.h (tui_partial_win_by_name): Don't declare.
1914         * tui/tui-data.c (tui_partial_win_by_name): Move to tui-win.c.
1915
1916 2019-11-19  Ali Tamur <tamur@google.com>
1917
1918         * dwarf2read.c (dw2_get_file_names_reader): Replace "if (attr)" with
1919         "if (attr != nullptr)".
1920         (dwarf2_find_base_address): Likewise.
1921         (dwarf2_build_include_psymtabs): Likewise.
1922         (read_cutu_die_from_dwo): Likewise.
1923         (read_func_scope): Likewise.
1924         (read_call_site_scope): Likewise.
1925         (dwarf2_get_pc_bounds): Likewise.
1926         (dwarf2_record_block_ranges): Likewise.
1927         (dwarf2_add_field): Likewise.
1928         (dwarf2_add_member_fn): Likewise.
1929         (read_structure_type): Likewise.
1930         (read_enumeration_type): Likewise.
1931         (read_array_type): Likewise.
1932         (read_array_order): Likewise.
1933         (read_set_type): Likewise.
1934         (read_common_block): Likewise.
1935         (read_tag_reference_type): Likewise.
1936         (read_tag_string_type): Likewise.
1937         (read_subroutine_type): Likewise.
1938         (read_base_type): Likewise.
1939         (read_subrange_type): Likewise.
1940         (new_symbol): Likewise.
1941         (prepare_one_comp_unit): Likewise.
1942
1943 2019-11-19  Tom Tromey  <tromey@adacore.com>
1944
1945         * windows-nat.c (windows_nat_target::attach): Include GetLastError
1946         result in error when DebugActiveProcess fails.
1947
1948 2019-11-18  Sergio Durigan Junior  <sergiodj@redhat.com>
1949             Pedro Alves  <palves@redhat.com>
1950
1951         https://bugzilla.redhat.com/show_bug.cgi?id=1765117
1952         * target.c (target_stack::push): Call 'unpush' if there's a
1953         target on top of the stack.
1954
1955 2019-11-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1956
1957         * python/py-block.c (blpy_dealloc): Call tp_free.
1958         (blpy_block_syms_dealloc): Likewise.
1959         * python/py-finishbreakpoint.c (bpfinishpy_dealloc): Likewise.
1960         * python/py-inferior.c (infpy_dealloc): Likewise.
1961         * python/py-lazy-string.c (stpy_dealloc): Likewise.
1962         * python/py-linetable.c (ltpy_iterator_dealloc): Likewise.
1963         * python/py-symbol.c (sympy_dealloc): Likewise.
1964         * python/py-symtab.c (stpy_dealloc): Likewise.
1965         * python/py-type.c (typy_iterator_dealloc): Likewise.
1966
1967 2019-11-18  Christian Biesinger  <cbiesinger@google.com>
1968
1969         * symtab.h (struct symbol) <owner>: Initialize explicitly in the
1970         constructor instead of using a class initializer.
1971
1972 2019-11-15  Christian Biesinger  <cbiesinger@google.com>
1973
1974         * Makefile.in: Replace {posix,mingw}-strerror.c with safe-strerror.c.
1975         * configure: Regenerate.
1976         * configure.ac: Don't source common.host.
1977         * gdbsupport/common.host: Remove.
1978         * gdbsupport/mingw-strerror.c: Remove.
1979         * gdbsupport/posix-strerror.c: Rename to...
1980         * gdbsupport/safe-strerror.c: ...this.
1981
1982 2019-11-15  Christian Biesinger  <cbiesinger@google.com>
1983
1984         * maint.c (scoped_command_stats::print_time): Use localtime_r
1985         instead of localtime (provided through gnulib if necessary).
1986         * nat/linux-osdata.c (time_from_time_t): Use ctime_r instead
1987         of ctime.
1988
1989 2019-11-15  Christian Biesinger  <cbiesinger@google.com>
1990
1991         * gdbsupport/common-defs.h: Include time.h before pathmax.h to
1992         avoid compile errors.
1993
1994 2019-11-15  Christian Biesinger  <cbiesinger@google.com>
1995
1996         * config.in: Regenerate.
1997         * configure: Regenerate.
1998         * gdbsupport/common.m4: No longer check for strerror_r.
1999         * gdbsupport/posix-strerror.c (safe_strerror): Always call the
2000         POSIX version of strerror_r, now that gnulib provides it if
2001         necessary.
2002
2003 2019-11-14  Christian Biesinger  <cbiesinger@google.com>
2004
2005         * README (`configure' options): Update.
2006
2007 2019-11-14  Tom Tromey  <tromey@adacore.com>
2008
2009         * eval.c (evaluate_subexp_standard) <BINOP_ASSIGN>: Do not pass an
2010         expected type for the RHS if the LHS is a convenience variable.
2011
2012 2019-11-14  Simon Marchi  <simon.marchi@polymtl.ca>
2013
2014         * unittests/vec-utils-selftests.c (unordered_remove_tests::obj):
2015         Provide explicit default and copy constructor.
2016
2017 2019-11-14  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2018
2019         * python/py-finishbreakpoint.c (gdbpy_breakpoint_created):
2020         only call Py_INCREF (newbp) in the bppy_pending_object case.
2021
2022 2019-11-13  Tom Tromey  <tromey@adacore.com>
2023
2024         PR build/25182:
2025         * psympriv.h (partial_symbol): Remove static assert.
2026         * symtab.h (general_symbol_info, symbol): Remove static assert.
2027
2028 2019-11-12  Andrew Burgess  <andrew.burgess@embecosm.com>
2029
2030         * gdbsupport/format.c (format_pieces::format_pieces): Support
2031         printf 'z' size modifier.
2032         * gdbsupport/format.h (enum argclass): Add size_t_arg.
2033         * printcmd.c (ui_printf):  Handle size_t_arg.
2034         * ui-out.c (ui_out::vmessage): Likewise.
2035         * unittests/format_pieces-selftests.c (test_format_int_sizes): New
2036         function.
2037         (run_tests): Call test_format_int_sizes.
2038
2039 2019-11-12  Christian Biesinger  <cbiesinger@google.com>
2040
2041         * ada-exp.y (write_ambiguous_var): Update.
2042         * buildsym.c (add_symbol_to_list): Update.
2043         * dwarf2read.c (read_variable): Update.
2044         (new_symbol): Update.
2045         * jit.c (finalize_symtab): Update.
2046         * language.c (language_alloc_type_symbol): Update.
2047         * symtab.c (fixup_symbol_section): Update.
2048         (initialize_objfile_symbol_1): Move code to...
2049         (initialize_objfile_symbol): ...here. Remove now-unnecessary memset.
2050         (allocate_symbol): Update.
2051         (allocate_template_symbol): Update.
2052         (get_symbol_address): Update.
2053         * symtab.h (struct symbol): Inherit from general_symbol_info instead
2054         of having as a field, and add a constructor.
2055         (SYMBOL_VALUE): Update.
2056         (SYMBOL_VALUE_ADDRESS): Update.
2057         (SET_SYMBOL_VALUE_ADDRESS): Update.
2058         (SYMBOL_VALUE_BYTES): Update.
2059         (SYMBOL_VALUE_COMMON_BLOCK): Update.
2060         (SYMBOL_BLOCK_VALUE): Update.
2061         (SYMBOL_VALUE_CHAIN): Update.
2062         (SYMBOL_LANGUAGE): Update.
2063         (SYMBOL_SECTION): Update.
2064         (SYMBOL_OBJ_SECTION): Update.
2065         (SYMBOL_SET_LANGUAGE): Update.
2066         (SYMBOL_SET_LINKAGE_NAME): Update.
2067         (SYMBOL_SET_NAMES): Update.
2068         (SYMBOL_NATURAL_NAME): Update.
2069         (SYMBOL_LINKAGE_NAME): Update.
2070         (SYMBOL_DEMANGLED_NAME): Update.
2071         (SYMBOL_SEARCH_NAME): Update.
2072         (SYMBOL_MATCHES_SEARCH_NAME): Update.
2073         (struct symbol): Update.
2074         (struct template_symbol): Update.
2075         (struct rust_vtable_symbol): Update.
2076         * xcoffread.c (SYMBOL_DUP): Update.
2077
2078 2019-11-12  Tom Tromey  <tom@tromey.com>
2079
2080         * tui/tui-layout.c (show_layout): Set current_layout.
2081         (show_source_disasm_command, show_data)
2082         (show_source_or_disasm_and_command): Don't set current_layout.
2083
2084 2019-11-12  Tom Tromey  <tom@tromey.com>
2085
2086         * tui/tui-layout.c (_initialize_tui_layout): Move to end.
2087
2088 2019-11-12  Tom Tromey  <tom@tromey.com>
2089
2090         * tui/tui-win.c (resize_message): New global.
2091         (show_tui_resize_message): New function.
2092         (tui_async_resize_screen): Print message if requested.
2093         (_initialize_tui_win): Add tui-resize-message setting.
2094         * NEWS: Add entry for new commands.
2095
2096 2019-11-11  Tom Tromey  <tom@tromey.com>
2097
2098         * tui/tui.c (tui_initialize_readline): Add new bindable readline
2099         functions.
2100
2101 2019-11-11  Christian Biesinger  <cbiesinger@google.com>
2102
2103         * nat/linux-osdata.c (user_from_uid): Use getpwuid_r.
2104
2105 2019-11-10  Andrew Burgess  <andrew.burgess@embecosm.com>
2106
2107         * python/py-symbol.c (gdbpy_lookup_static_symbols): New
2108         function.
2109         * python/python-internal.h (gdbpy_lookup_static_symbols):
2110         Declare new function.
2111         * python/python.c (python_GdbMethods): Add
2112         gdb.lookup_static_symbols method.
2113         * NEWS: Mention gdb.lookup_static_symbols.
2114
2115 2019-11-10  Andrew Burgess  <andrew.burgess@embecosm.com>
2116
2117         * python/py-symbol.c (gdbpy_lookup_static_symbol): Lookup in
2118         static block of current object file first.  Also fix typo in
2119         header comment.
2120
2121 2019-11-10  Andrew Burgess  <andrew.burgess@embecosm.com>
2122
2123         * stack.c (set_last_displayed_sal): Delete.
2124         (last_displayed_sal_valid): Delete.
2125         (last_displayed_pspace): Delete.
2126         (last_displayed_addr): Delete.
2127         (last_displayed_symtab): Delete.
2128         (last_displayed_line): Delete.
2129         (class last_displayed_symtab_info_type): New.
2130         (last_displayed_symtab_info): New static global variable.
2131         (print_frame_info): Call methods on last_displayed_symtab_info.
2132         (clear_last_displayed_sal): Update header comment, and make use of
2133         last_displayed_symtab_info.
2134         (last_displayed_sal_is_valid): Likewise.
2135         (get_last_displayed_pspace): Likewise.
2136         (get_last_displayed_addr): Likewise.
2137         (get_last_displayed_symtab): Likewise.
2138         (get_last_displayed_line): Likewise.
2139         (get_last_displayed_sal): Likewise.
2140         * stack.h (clear_last_displayed_sal): Update header comment.
2141         (last_displayed_sal_is_valid): Likewise.
2142         (get_last_displayed_pspace): Likewise.
2143         (get_last_displayed_addr): Likewise.
2144         (get_last_displayed_symtab): Likewise.
2145         (get_last_displayed_line): Likewise.
2146         (get_last_displayed_sal): Likewise.
2147
2148 2019-11-10  Andrew Burgess  <andrew.burgess@embecosm.com>
2149
2150         * stack.c (frame_show_address): Convert return type to bool.
2151         * stack.h (frame_show_address): Likewise, and update header
2152         comment.
2153
2154 2019-11-10  Andrew Burgess  <andrew.burgess@embecosm.com>
2155
2156         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add new file to the list.
2157         * unittests/vec-utils-selftests.c: New file.
2158         * gdbsupport/gdb_vecs.h (unordered_remove): Avoid self move assign.
2159
2160 2019-11-10  Tom Tromey  <tom@tromey.com>
2161
2162         * tui/tui-wingeneral.c (tui_unhighlight_win): Use can_box.
2163         (tui_highlight_win): Likewise.
2164         (tui_win_info::check_and_display_highlight_if_needed): Likewise.
2165         * tui/tui-data.h (struct tui_win_info) <can_highlight>: Remove.
2166         * tui/tui-command.h (struct tui_cmd_window) <tui_cmd_window>:
2167         Don't set can_highlight.
2168
2169 2019-11-10  Tom Tromey  <tom@tromey.com>
2170
2171         * cli/cli-style.h (class cli_style_option) <cli_style_option>:
2172         Remove unused declaration.
2173
2174 2019-11-08  Tom Tromey  <tromey@adacore.com>
2175
2176         * top.c (read_command_file): Update.
2177         (command_line_input): Make return type const.
2178         * python/py-gdb-readline.c: Update.
2179         * linespec.c (decode_line_2): Update.
2180         * defs.h (command_line_input): Make return type const.
2181         * cli/cli-script.c (read_next_line): Make return type const.
2182         * ada-lang.c (get_selections): Update.
2183
2184 2019-11-06  Christian Biesinger  <cbiesinger@google.com>
2185
2186         * linux-tdep.c (linux_info_proc): Use strtok_r instead of strtok.
2187         * mi/mi-main.c (output_cores): Likewise.
2188         * nat/linux-osdata.c (linux_xfer_osdata_cpus): Likewise.
2189         (linux_xfer_osdata_modules): Likewise.
2190         * remote.c (register_remote_support_xml): Likewise.
2191         * sparc64-tdep.c (adi_is_addr_mapped): Likewise.
2192         * xml-syscall.c (syscall_create_syscall_desc): Likewise.
2193
2194 2019-11-06  Tom Tromey  <tom@tromey.com>
2195
2196         * tui/tui-interp.c: Don't include readline.h.
2197         * tui/tui-hooks.c: Don't include readline.h.
2198         * symmisc.c: Include tilde.h, not readline.h.
2199         * symfile.c: Include tilde.h, not readline.h.
2200         * source.c: Include tilde.h, not readline.h.
2201         * solib.c: Include tilde.h, not readline.h.
2202         * psymtab.c: Include tilde.h, not readline.h.
2203         * exec.c: Include tilde.h, not readline.h.
2204         * corelow.c: Include tilde.h, not readline.h.
2205         * cli/cli-dump.c: Include tilde.h, not readline.h.
2206         * cli/cli-cmds.c: Don't include readline.h.
2207
2208 2019-11-05  Tom Tromey  <tom@tromey.com>
2209
2210         * tui/tui-disasm.c (struct tui_asm_line) <addr_size>: New member.
2211         (tui_disassemble): Set addr_size.
2212         (tui_disasm_window::set_contents): Use addr_size.
2213
2214 2019-11-05  Tom Tromey  <tom@tromey.com>
2215
2216         * rust-lang.c (rust_language_defn): Update.
2217         * python/py-value.c (valpy_string): Call c_get_string.
2218         * p-lang.c (pascal_language_defn): Update.
2219         * opencl-lang.c (opencl_language_defn): Update.
2220         * objc-lang.c (objc_language_defn): Update.
2221         * m2-lang.c (m2_language_defn): Update.
2222         * language.c (unknown_language_defn, auto_language_defn): Update.
2223         (default_get_string): Remove.
2224         * guile/scm-value.c (gdbscm_value_to_string): Use c_get_string.
2225         * go-lang.c (go_language_defn): Update.
2226         * f-lang.c (f_language_defn): Update.
2227         * d-lang.c (d_language_defn): Update.
2228         * c-lang.c (c_language_defn, cplus_language_defn)
2229         (asm_language_defn, minimal_language_defn): Update.
2230         * ada-lang.c (ada_language_defn): Update.
2231         * language.h (struct language_defn) <la_get_string>: Remove.
2232         (LA_GET_STRING): Remove.
2233         (default_get_string): Don't declare.
2234
2235 2019-11-05  Tom Tromey  <tom@tromey.com>
2236
2237         * tui/tui-source.h (struct tui_source_window): Inline
2238         constructor.  Remove destructor.
2239         <style_changed, m_observable>: Move to superclass.
2240         * tui/tui-winsource.h (tui_copy_source_line): Declare.
2241         (struct tui_source_window_base): Move private members to end.
2242         <style_changed, m_observable>: Move from tui_source_window.
2243         * tui/tui-winsource.c (tui_copy_source_line): Move from
2244         tui-source.c.  Rename from copy_source_line.  Add special handling
2245         for negative line number.
2246         (tui_source_window_base::style_changed): Move from
2247         tui_source_window.
2248         (tui_source_window_base): Register observer.
2249         (~tui_source_window_base): New.
2250         * tui/tui-source.c (copy_source_line): Move to tui-winsource.c;
2251         rename.
2252         (tui_source_window::set_contents): Use tui_copy_source_line.
2253         (tui_source_window::tui_source_window): Move to tui-source.h.
2254         (tui_source_window::~tui_source_window): Remove.
2255         (tui_source_window::style_changed): Move to superclass.
2256         * tui/tui-disasm.c (tui_disassemble): Create string file with
2257         styling, when possible.  Add "addr_size" parameter.
2258         (tui_disasm_window::set_contents): Use tui_copy_source_line.
2259         Don't compute maximum size.
2260         (len_without_escapes): New function
2261
2262 2019-11-05  Tom Tromey  <tom@tromey.com>
2263
2264         * tui/tui-winsource.h (struct tui_source_element) <line>: Now a
2265         std::string.
2266         * tui/tui-winsource.c (tui_show_source_line): Update.
2267         * tui/tui-source.c (tui_source_window::set_contents): Update.
2268         * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
2269
2270 2019-11-05  Christian Biesinger  <cbiesinger@google.com>
2271
2272         * symtab.h (gdb_static_assert): Put && operator at the beginning
2273         of the line instead of the end.
2274
2275 2019-11-04  Christian Biesinger  <cbiesinger@google.com>
2276
2277         * psympriv.h: Add static_asserts for sizeof (general_symbol_info)
2278         and sizeof (symbol).
2279         * symtab.h: Add a static_assert for sizeof (partial_symbol).
2280
2281 2019-11-04  Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
2282
2283         * NEWS (Changes since GDB 8.3): Document Solaris 10 removal.
2284         * configure.host: Mark *-*-solaris2.10* obsolete.
2285         * configure.tgt: Mark Solaris < 11 obsolete.
2286         * MAINTAINERS (Target Instruction Set Architectures) <sparc>:
2287         Update target triplet.
2288
2289 2019-11-01  Tom Tromey  <tromey@adacore.com>
2290
2291         * utils.c (print_sys_errmsg): Simplify.
2292
2293 2019-11-01  Tom Tromey  <tromey@adacore.com>
2294
2295         * gdbsupport/mingw-strerror.c (safe_strerror): Constify result.
2296
2297 2019-11-01  Christian Biesinger  <cbiesinger@google.com>
2298
2299         * configure: Regenerate.
2300         * configure.ac: Remove check for strerror_r.
2301         * gdbsupport/common.m4: Check for strerror_r.
2302
2303 2019-11-01  Luis Machado  <luis.machado@linaro.org>
2304
2305         PR gdb/25124
2306
2307         * arm-tdep.c (arm_per_objfile): Rename to ...
2308         (arm_per_bfd): ... this.
2309         (arm_objfile_data_key): Rename to ...
2310         (arm_bfd_data_key): ... this.
2311         (arm_find_mapping_symbol): Adjust access to new bfd_key-based
2312         data.
2313         (arm_record_special_symbol): Likewise.
2314
2315 2019-10-31  Andrew Burgess  <andrew.burgess@embecosm.com>
2316
2317         * ada-typeprint.c (ada_print_typedef): Don't print newline at the
2318         end.
2319         * c-typeprint.c (c_print_typedef): Likewise.
2320         * f-typeprint.c (f_print_typedef): Likewise.
2321         * m2-typeprint.c (m2_print_typedef): Likewise.
2322         * p-typeprint.c (pascal_print_typedef): Likewise.
2323         * rust-lang.c (rust_print_typedef): Likewise.
2324         * symtab.c (print_symbol_info): Print a newline after calling
2325         typedef_print.
2326
2327 2019-10-31  Andrew Burgess  <andrew.burgess@embecosm.com>
2328
2329         * symtab.c (info_module_cmdlist): New variable.
2330         (info_module_command): New function.
2331         (search_module_symbols): New function.
2332         (info_module_subcommand): New function.
2333         (struct info_modules_var_func_options): New struct.
2334         (info_modules_var_func_options_defs): New variable.
2335         (make_info_modules_var_func_options_def_group): New function.
2336         (info_module_functions_command): New function.
2337         (info_module_variables_command): New function.
2338         (info_module_var_func_command_completer): New function.
2339         (_initialize_symtab): Register new 'info module functions' and
2340         'info module variables' commands.
2341         * symtab.h (typedef symbol_search_in_module): New typedef.
2342         (search_module_symbols): Declare new function.
2343         * NEWS: Mention new commands.
2344
2345 2019-10-31  Andrew Burgess  <andrew.burgess@embecosm.com>
2346
2347         * dwarf2read.c (dw2_symtab_iter_next): Handle MODULE_DOMAIN.
2348         (dw2_expand_marked_cus): Handle MODULES_DOMAIN.
2349         (dw2_debug_names_iterator::next): Handle MODULE_DOMAIN and
2350         MODULES_DOMAIN.
2351         (scan_partial_symbols): Only create partial module symbols for non
2352         declarations.
2353         * psymtab.c (recursively_search_psymtabs): Handle MODULE_DOMAIN
2354         and MODULES_DOMAIN.
2355         * symtab.c (search_domain_name): Likewise.
2356         (search_symbols): Likewise.
2357         (print_symbol_info): Likewise.
2358         (symtab_symbol_info): Likewise.
2359         (info_modules_command): New function.
2360         (_initialize_symtab): Register 'info modules' command.
2361         * symtab.h (enum search_domain): Add MODULES_DOMAIN.
2362         * NEWS: Mention new 'info modules' command.
2363
2364 2019-10-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2365
2366         * NEWS: Mention $_gdb_setting, $_gdb_setting_str, $_gdb_maint_setting
2367         and $_gdb_maint_setting_str.
2368
2369 2019-10-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2370
2371         * cli/cli-cmds.c (setting_cmd, value_from_setting)
2372         (gdb_setting_internal_fn, gdb_maint_setting_internal_fn)
2373         (str_value_from_setting, gdb_setting_str_internal_fn)
2374         (gdb_maint_setting_str_internal_fn): New functions.
2375         (_initialize_cli_cmds): Define the new convenience functions.
2376         * gdb/cli/cli-setshow.h (get_setshow_command_value_string): Constify.
2377         * gdb/cli/cli-setshow.c (get_setshow_command_value_string): Constify.
2378
2379 2019-10-31  Christian Biesinger  <cbiesinger@google.com>
2380
2381         * agent.c (set_can_use_agent): When the setting is turned on,
2382         look up agent symbols if we don't have them yet.
2383         (agent_new_objfile): Don't look up agent symbols when the agent
2384         setting is off.
2385
2386 2019-10-31  Christian Biesinger  <cbiesinger@google.com>
2387
2388         * config.in: Regenerate.
2389
2390 2019-10-31  Christian Biesinger  <cbiesinger@google.com>
2391
2392         * configure: Regenerate.
2393         * configure.ac: Check for strerror_r.
2394         * gdbsupport/common-utils.h (safe_strerror): Change return value
2395         to const char * and document that this function is now threadsafe.
2396         * gdbsupport/posix-strerror.c (safe_strerror): Make buf
2397         thread_local and call strerror_r, if available.
2398         * utils.c (perror_string): Update.
2399         (print_sys_errmsg): Update.
2400
2401 2019-10-31  Luis Machado  <luis.machado@linaro.org>
2402
2403         * arm-tdep.c (arm_exidx_data_key): Use bfd_key instead of
2404         objfile_key.
2405         (arm_exidx_new_objfile): Adjust to use objfile->obfd instead of
2406         objfile to fetch per-bfd data.
2407         (arm_find_exidx_entry): Likewise.
2408
2409 2019-10-31  Christian Biesinger  <cbiesinger@google.com>
2410
2411         * gdbsupport/agent.c (debug_agent): Change type to bool.
2412         (use_agent): Likewise.
2413         (all_agent_symbols_look_up): Likewise.
2414         (agent_loaded_p): Change return value to bool.
2415         (agent_look_up_symbols): Update.
2416         (agent_capability_check): Change return value to bool.
2417         * gdbsupport/agent.h (agent_loaded_p): Likewise.
2418         (debug_agent): Change type to bool.
2419         (use_agent): Likewise.
2420         (agent_capability_check): Change return value to bool.
2421
2422 2019-10-30  Christian Biesinger  <cbiesinger@google.com>
2423
2424         * minsyms.c (clear_minimal_symbol_hash_tables): New function.
2425         (build_minimal_symbol_hash_tables): Code to clear the table moved
2426         to clear_minimal_symbol_hash_tables.
2427         (minimal_symbol_reader::install): Call clear_minimal_symbol_hash_tables
2428         when needed.
2429
2430 2019-10-29  Simon Marchi  <simon.marchi@polymtl.ca>
2431
2432         * infcmd.c: Remove includes.
2433         * infrun.c: Remove includes.
2434
2435 2019-10-29  Simon Marchi  <simon.marchi@polymtl.ca>
2436
2437         * ada-lang.h (GROW_VECT): Move to ada-lang.c.
2438         (grow_vect): Remove declaration.
2439         (ada_type_of_array): Remove declaration.
2440         (ada_update_initial_language): Remove declaration.
2441         (ada_fold_name): Remove declaration.
2442         (ada_fill_in_ada_prototype): Remove declaration.
2443         (user_select_syms): Remove declaration.
2444         (get_selections): Remove declaration.
2445         (ada_tag_type): Remove declaration.
2446         (ada_value_tag): Remove declaration.
2447         (ada_is_others_clause): Remove declaration.
2448         (ada_in_variant): Remove declaration.
2449         (ada_value_struct_elt): Remove declaration.
2450         (ada_attribute_name): Remove declaration.
2451         (ada_system_address_type): Remove declaration.
2452         * ada-lang.c (ada_watch_location_expression): Make static.
2453         (GROW_VECT): Move here from ada-lang.h.
2454         (grow_vect): Make static.
2455         (ada_update_initial_language): Make static.
2456         (ada_fold_name): Make static.
2457         (ada_type_of_array): Make static.
2458         (encoded_ordered_before): Move up.
2459         (sort_choices): Move up.
2460         (print_signatures): Move up.
2461         (ada_print_symbol_signature): Move up.
2462         (get_selections): Move up and make static.
2463         (user_select_syms): Move up and make static.
2464         (ada_value_struct_elt): Move up and make static.
2465         (ada_tag_type): Make static.
2466         (ada_value_tag): Make static.
2467         (ada_is_others_clause): Make static.
2468         (ada_in_variant): Make static.
2469         (ada_attribute_name): Make static.
2470
2471 2019-10-29  Simon Marchi  <simon.marchi@polymtl.ca>
2472
2473         * ada-lang.c: Remove includes.
2474         * ada-typeprint.c: Remove includes.
2475         * ada-valprint.c: Remove includes.
2476
2477 2019-10-29  Simon Marchi  <simon.marchi@efficios.com>
2478
2479         * addrmap.c: Add static assertions of type size, moved from
2480         _initialize_addrmap.
2481         (_initialize_addrmap): Remove.
2482
2483 2019-10-29  Christian Biesinger  <cbiesinger@google.com>
2484
2485         * coffread.c (record_minimal_symbol): Update.
2486         (process_coff_symbol): Update.
2487         * dbxread.c (read_dbx_symtab): Update.
2488         * dwarf2read.c (add_partial_symbol): Update.
2489         (fixup_go_packaging): Update.
2490         (load_partial_dies): Update.
2491         (new_symbol): Update.
2492         * elfread.c (record_minimal_symbol): Change signature to use
2493         gdb::string_view instead of name+len.
2494         (elf_symtab_read): Update.
2495         (elf_rel_plt_read): Update.
2496         * mdebugread.c (parse_partial_symbols): Update.
2497         (handle_psymbol_enumerators): Update.
2498         (new_symbol): Update.
2499         * minsyms.c (minimal_symbol_reader::record_full): Change signature
2500         to use gdb::string_view instead of name+len.
2501         * minsyms.h (class minimal_symbol_reader) <record_full>: Likewise.
2502         * psympriv.h (add_psymbol_to_list): Likewise.
2503         * psymtab.c (add_psymbol_to_bcache): Likewise.
2504         (add_psymbol_to_list): Likewise.
2505         * stabsread.c (define_symbol): Update.
2506         * symtab.c (symbol_set_names): Change signature to use gdb::string_view.
2507         * symtab.h (SYMBOL_SET_NAMES): Likewise.
2508         (symbol_set_names): Likewise.
2509         * xcoffread.c (scan_xcoff_symtab): Update.
2510
2511 2019-10-29  Christian Biesinger  <cbiesinger@google.com>
2512
2513         * symtab.h (symbol_set_names): Document that copy_name must be
2514         set to true for non-nullterminated strings.
2515         * symtab.c (symbol_set_names): Only make a nullterminated copy of
2516         linkage_name if the entry was not found and we need to demangle.
2517
2518 2019-10-29  Christian Biesinger  <cbiesinger@google.com>
2519
2520         * Makefile.in (HFILES_NO_SRCDIR): Add gdb_binary_search.h.
2521         * dwarf2-frame.c (bsearch_fde_cmp): Update.
2522         (dwarf2_frame_find_fde): Replace bsearch with gdb::binary_search.
2523         * gdbsupport/gdb_binary_search.h: New file.
2524
2525 2019-10-29  Christian Biesinger  <cbiesinger@google.com>
2526
2527         * NEWS: Mention new --with-system-gdbinit-dir option.
2528         * config.in: Regenerate.
2529         * configure: Regenerate.
2530         * configure.ac: Add new option --with-system-gdbinit-dir.
2531         * extension.c (get_ext_lang_of_file): Return extension_language_gdb
2532         for a ".gdb" suffix.
2533         * main.c (get_init_files): Change system_gdbinit argument to
2534         a vector and return the files in SYSTEM_GDBINIT_DIR in
2535         addition to SYSTEM_GDBINIT.
2536         (captured_main_1): Update.
2537         (print_gdb_help): Update.
2538         * top.c (print_gdb_configuration): Also print the value of
2539         SYSTEM_GDBINIT_DIR.
2540
2541 2019-10-28  Christian Biesinger  <cbiesinger@google.com>
2542
2543         * gdbsupport/common-utils.h (startswith): Add an overloaded version
2544         that takes gdb::string_view arguments.
2545
2546 2019-10-26  Tom de Vries  <tdevries@suse.de>
2547
2548         * aarch64-linux-tdep.c: Fix typos in comments.
2549         * aarch64-tdep.c: Same.
2550         * ada-lang.c: Same.
2551         * amd64-nat.c: Same.
2552         * arc-tdep.c: Same.
2553         * arch/aarch64-insn.c: Same.
2554         * block.c: Same.
2555         * breakpoint.h: Same.
2556         * btrace.h: Same.
2557         * c-varobj.c: Same.
2558         * cli/cli-decode.c: Same.
2559         * cli/cli-script.c: Same.
2560         * cli/cli-utils.h: Same.
2561         * coff-pe-read.c: Same.
2562         * coffread.c: Same.
2563         * compile/compile-cplus-symbols.c: Same.
2564         * compile/compile-object-run.c: Same.
2565         * completer.c: Same.
2566         * corelow.c: Same.
2567         * cp-support.c: Same.
2568         * demangle.c: Same.
2569         * dwarf-index-write.c: Same.
2570         * dwarf2-frame.c: Same.
2571         * dwarf2-frame.h: Same.
2572         * eval.c: Same.
2573         * frame-base.h: Same.
2574         * frame.h: Same.
2575         * gdbcmd.h: Same.
2576         * gdbtypes.h: Same.
2577         * gnu-nat.c: Same.
2578         * guile/scm-objfile.c: Same.
2579         * i386-tdep.c: Same.
2580         * i386-tdep.h: Same.
2581         * infcall.c: Same.
2582         * infcall.h: Same.
2583         * linux-nat.c: Same.
2584         * m68k-tdep.c: Same.
2585         * macroexp.c: Same.
2586         * memattr.c: Same.
2587         * mi/mi-cmd-disas.c: Same.
2588         * mi/mi-getopt.h: Same.
2589         * mi/mi-main.c: Same.
2590         * minsyms.c: Same.
2591         * nat/aarch64-sve-linux-sigcontext.h: Same.
2592         * objfiles.h: Same.
2593         * ppc-linux-nat.c: Same.
2594         * ppc-linux-tdep.c: Same.
2595         * ppc-tdep.h: Same.
2596         * progspace.h: Same.
2597         * prologue-value.h: Same.
2598         * python/py-evtregistry.c: Same.
2599         * python/py-instruction.h: Same.
2600         * record-btrace.c: Same.
2601         * record-full.c: Same.
2602         * remote.c: Same.
2603         * rs6000-tdep.c: Same.
2604         * ser-tcp.c: Same.
2605         * sol-thread.c: Same.
2606         * sparc-sol2-tdep.c: Same.
2607         * sparc64-tdep.c: Same.
2608         * stabsread.c: Same.
2609         * symfile.c: Same.
2610         * symtab.h: Same.
2611         * target.c: Same.
2612         * tracepoint.c: Same.
2613         * tui/tui-data.h: Same.
2614         * tui/tui-io.c: Same.
2615         * tui/tui-win.c: Same.
2616         * tui/tui.c: Same.
2617         * unittests/rsp-low-selftests.c: Same.
2618         * user-regs.h: Same.
2619         * utils.c: Same.
2620         * utils.h: Same.
2621         * valarith.c: Same.
2622         * valops.c: Same.
2623         * valprint.c: Same.
2624         * valprint.h: Same.
2625         * value.c: Same.
2626         * value.h: Same.
2627         * varobj.c: Same.
2628         * x86-nat.h: Same.
2629         * xtensa-tdep.c: Same.
2630
2631 2019-10-25  Ali Tamur <tamur@google.com>
2632
2633         * charset.c (find_charset_names): Reflect API change.
2634
2635 2019-10-25  Christian Biesinger  <cbiesinger@google.com>
2636
2637         * symtab.c (struct demangled_name_entry): Change demangled name
2638         to a unique_xmalloc_ptr<char>, now that we don't allocate it as
2639         part of the struct anymore.
2640         (symbol_set_names): No longer obstack allocate + copy the demangled
2641         name, just store the allocated name from bfd.
2642
2643 2019-10-25  Tom Tromey  <tromey@adacore.com>
2644
2645         * dwarf2-frame.c (dwarf2_cie_table): Now a typedef.
2646         (bsearch_cie_cmp, add_cie): Remove.
2647         (find_cie): Reimplement.
2648         (decode_frame_entry_1, decode_frame_entry): Change type.  Update.
2649         (dwarf2_build_frame_info): Update.
2650
2651 2019-10-24  H.J. Lu  <hongjiu.lu@intel.com>
2652
2653         PR gdb/25126
2654         * symfile.c (reread_symbols): Call forget_cached_source_info to
2655         clear the stale source cache.
2656
2657 2019-10-24  Christian Biesinger  <cbiesinger@google.com>
2658
2659         * configure: Regenerate.
2660         * configure.ac: Remove code that sets python_has_threads.
2661
2662 2019-10-24  Christian Biesinger  <cbiesinger@google.com>
2663
2664         * config.in: Regenerate.
2665         * configure: Regenerate.
2666         * configure.ac: Remove the code that uses sed to get the python
2667         version and defines HAVE_LIBPYTHON2_6 / HAVE_LIBPYTHON2_7.
2668
2669 2019-10-24  Andrew Burgess  <andrew.burgess@embecosm.com>
2670
2671         * python/py-progspace.c (pspy_block_for_pc): Return None for all
2672         error paths.
2673
2674 2019-10-23  Tom Tromey  <tom@tromey.com>
2675
2676         * arc-tdep.c: Remove ".." from include.
2677         * frv-tdep.c: Remove ".." from include.
2678         * lm32-tdep.c: Remove ".." from include.
2679         * microblaze-tdep.c: Remove ".." from include.
2680         * or1k-tdep.h: Remove ".." from include.
2681         * s12z-tdep.c: Remove ".." from include.
2682         * Makefile.in (OPCODES_CFLAGS): Add comment.
2683         (TOP_CFLAGS): New variable.
2684         (INTERNAL_CFLAGS_BASE): Add TOP_CFLAGS.
2685
2686 2019-10-23  Tom Tromey  <tom@tromey.com>
2687
2688         * Makefile.in (READLINE_DIR): Update.
2689
2690 2019-10-23  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
2691
2692         * infcall.c (call_function_by_hand_dummy): Fix the function
2693         comment.  And extract out a code section into...
2694         (reserve_stack_space): ...this new function.
2695
2696 2019-10-23  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
2697
2698         * infcall.c (value_arg_coerce): Remove an unused parameter.
2699         (call_function_by_hand_dummy): Update the call to
2700         'value_arg_coerce'.
2701
2702 2019-10-23  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
2703
2704         * infcall.c (call_function_by_hand_dummy): Refactor.
2705
2706 2019-10-23  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
2707
2708         * MAINTAINERS (Write After Approval): Add Tankut Baris Aktemur.
2709
2710 2019-10-23  Tom Tromey  <tom@tromey.com>
2711
2712         * configure: Rebuild.
2713         * configure.ac: Don't check for sigprocmask.
2714         * gdbsupport/common.m4 (GDB_AC_COMMON): Check for sigprocmask.
2715
2716 2019-10-23  Tom Tromey  <tom@tromey.com>
2717
2718         * configure: Rebuild.
2719         * acinclude.m4: Use m4_include, not sinclude.
2720
2721 2019-10-23  Tom de Vries  <tdevries@suse.de>
2722
2723         PR breakpoints/24687
2724         * symtab.c (iterate_over_some_symtabs): Apply gdb_realpath on fullname.
2725
2726 2019-10-22  Christian Biesinger  <cbiesinger@google.com>
2727
2728         * symtab.c (struct demangled_name_entry) <language>: Change from
2729         bitfield to regular variable.
2730
2731 2019-10-22  Christian Biesinger  <cbiesinger@google.com>
2732
2733         * symtab.c (struct demangled_name_entry): Add a constructor.
2734         (free_demangled_name_entry): New function to call the destructor
2735         for demangled_name_entry.
2736         (create_demangled_names_hash): Pass free_demangled_name_entry to
2737         htab_create_alloc.
2738         (symbol_set_names): Call placement new for demangled_name_entry.
2739         * utils.c: No longer include xxhash.h here, now that fast_hash
2740         is inlined in the header.
2741         * utils.h: Instead, include it here.
2742
2743 2019-10-22  Christian Biesinger  <cbiesinger@google.com>
2744
2745         * Makefile.in: Link with libxxhash.
2746         * config.in: Regenerate.
2747         * configure: Regenerate.
2748         * configure.ac: Search for libxxhash.
2749         * utils.c (fast_hash): Use xxhash if present.
2750
2751 2019-10-22  Christian Biesinger  <cbiesinger@google.com>
2752
2753         * utils.h (fast_hash): New function.
2754         * symtab.c (hash_demangled_name_entry): Call new function
2755         fast_hash.
2756
2757 2019-10-22  Christian Biesinger  <cbiesinger@google.com>
2758
2759         * symtab.c (struct demangled_name_entry): Change type of mangled
2760         to gdb::string_view. Also adds a constructor that takes the
2761         mangled name.
2762         (hash_demangled_name_entry): Update.
2763         (eq_demangled_name_entry): Update.
2764         (free_demangled_name_entry): New function to call the destructor
2765         now that this is not a POD anymore.
2766         (create_demangled_names_hash): Pass free_demangled_name_entry to
2767         htab_create_alloc.
2768         (symbol_set_names): Update.
2769
2770 2019-10-21  Ali Tamur  <tamu@google.com>
2771
2772         * dwarf2read.c (dir_index): Change type.
2773         (file_name_index): Likewise.
2774         (line_header::include_dir_at): Change comment and implementation on
2775         whether it is DWARF 5.
2776         (line_header::is_valid_file_index): New function.
2777         (line_header::file_name_at): Change comment and implementation on
2778         whether it is DWARF 5.
2779         (line_header::file_names): Change to private field renamed as
2780         m_file_names and introduce a new accessor method.
2781         (line_header::file_names_size): New method.
2782         (line_header::include_dirs): Change to private field and rename as
2783         m_include_dirs.
2784         (dw2_get_file_names_reader): Define local var at a smaller scope and
2785         reflect API change.
2786         (dwarf2_cu::setup_type_unit_groups): Reflect API change.
2787         (process_structure_scope): Likewise.
2788         (line_header::add_include_dir): Change message and reflect renaming.
2789         (line_header::add_file_name): Likewise.
2790         (read_formatted_entries): Handle DW_FORM_data16.
2791         (dwarf_decode_line_header): Fix line header length calculation.
2792         (psymtab_include_file_name): Change comment and API.
2793         (lnp_state_machine::m_file): Update comment and reflect type change.
2794         (lnp_state_machine::record_line): Reflect type change.
2795         (dwarf_decode_lines): Reflect API change.
2796         (file_file_name): Likewise.
2797         (file_full_name): Likewise.
2798
2799 2019-10-21  Andrew Burgess  <andrew.burgess@embecosm.com>
2800
2801         * objfiles.c (sort_cmp): Ensure that !(a < a) holds true.
2802
2803 2019-10-21  Tom Tromey  <tom@tromey.com>
2804
2805         * tui/tui-winsource.h (tui_exec_info_content): Remove typedef.
2806
2807 2019-10-21  Tom Tromey  <tom@tromey.com>
2808
2809         * configure.ac (nm.h): Conditionally create nm.h link.  Subst
2810         NM_H.   Use AC_CONFIG_LINKS.
2811         * configure: Rebuild.
2812         * Makefile.in (NM_H): New variable.
2813         (generated_files): Add NM_H.  Remove gcore.
2814         (nm.h, stamp-nmh): New targets.
2815
2816 2019-10-20  Tom Tromey  <tom@tromey.com>
2817
2818         * objfiles.h (unlink_objfile, put_objfile_before): Don't declare.
2819         * objfiles.c (unlink_objfile): Move earlier.  Now static.  Remove
2820         obsolete comment.
2821         (put_objfile_before): Now static.
2822
2823 2019-10-19  Simon Marchi  <simon.marchi@polymtl.ca>
2824
2825         * gdbsupport/common-utils.h (startswith): Change return type to
2826         bool.
2827
2828 2019-10-19  Christian Biesinger  <cbiesinger@google.com>
2829
2830         * bcache.c (bcache::print_statistics): Use std::sort instead of qsort.
2831         * breakpoint.c (bp_locations_compare): Rename to...
2832         (bp_location_is_less_than): ...this, and change to std::sort semantics.
2833         (update_global_location_list): Use std::sort instead of qsort.
2834         * buildsym.c (compare_line_numbers): Rename to...
2835         (lte_is_less_than): ...this, and change to std::sort semantics.
2836         (buildsym_compunit::end_symtab_with_blockvector): Use std::sort
2837         instead of qsort.
2838         * disasm.c (compare_lines): Rename to...
2839         (line_is_less_than): ...this, and change to std::sort semantics.
2840         (do_mixed_source_and_assembly_deprecated): Call std::sort instead
2841         of qsort.
2842         * dwarf2-frame.c (qsort_fde_cmp): Rename to...
2843         (fde_is_less_than): ...this, and change to std::sort semantics.
2844         (dwarf2_build_frame_info): Call std::sort instead of qsort.
2845         * mdebugread.c (compare_blocks):
2846         (block_is_less_than): ...this, and change to std::sort semantics.
2847         (sort_blocks): Call std::sort instead of qsort.
2848         * objfiles.c (qsort_cmp): Rename to...
2849         (sort_cmp): ...this, and change to std::sort semantics.
2850         (update_section_map): Call std::sort instead of qsort.
2851         * remote.c (compare_pnums): Remove.
2852         (map_regcache_remote_table): Call std::sort instead of qsort.
2853         * utils.c (compare_positive_ints): Remove.
2854         * utils.h (compare_positive_ints): Remove.
2855         * xcoffread.c (compare_lte): Remove.
2856         (arrange_linetable): Call std::sort instead of qsort.
2857
2858 2019-10-19  Sergio Durigan Junior  <sergiodj@redhat.com>
2859
2860         * symfile.c (init_entry_point_info): Fix typo.
2861         * i386-darwin-tdep.c (darwin_dwarf_signal_frame_p): Fix typo.
2862
2863 2019-10-18  Tom de Vries  <tdevries@suse.de>
2864
2865         * aarch64-tdep.c: Fix typos in comments.
2866         * ada-lang.c: Same.
2867         * ada-tasks.c: Same.
2868         * alpha-tdep.c: Same.
2869         * alpha-tdep.h: Same.
2870         * amd64-nat.c: Same.
2871         * amd64-windows-tdep.c: Same.
2872         * arc-tdep.c: Same.
2873         * arc-tdep.h: Same.
2874         * arch-utils.c: Same.
2875         * arm-nbsd-tdep.c: Same.
2876         * arm-tdep.c: Same.
2877         * ax-gdb.c: Same.
2878         * blockframe.c: Same.
2879         * btrace.c: Same.
2880         * c-varobj.c: Same.
2881         * coff-pe-read.c: Same.
2882         * coffread.c: Same.
2883         * cris-tdep.c: Same.
2884         * darwin-nat.c: Same.
2885         * dbxread.c: Same.
2886         * dcache.c: Same.
2887         * disasm.c: Same.
2888         * dtrace-probe.c: Same.
2889         * dwarf-index-write.c: Same.
2890         * dwarf2-frame-tailcall.c: Same.
2891         * dwarf2-frame.c: Same.
2892         * dwarf2read.c: Same.
2893         * eval.c: Same.
2894         * exceptions.c: Same.
2895         * fbsd-tdep.c: Same.
2896         * findvar.c: Same.
2897         * frame.c: Same.
2898         * frv-tdep.c: Same.
2899         * gnu-v3-abi.c: Same.
2900         * go32-nat.c: Same.
2901         * h8300-tdep.c: Same.
2902         * hppa-tdep.c: Same.
2903         * i386-linux-tdep.c: Same.
2904         * i386-tdep.c: Same.
2905         * ia64-libunwind-tdep.c: Same.
2906         * ia64-tdep.c: Same.
2907         * infcmd.c: Same.
2908         * infrun.c: Same.
2909         * linespec.c: Same.
2910         * linux-nat.c: Same.
2911         * linux-thread-db.c: Same.
2912         * machoread.c: Same.
2913         * mdebugread.c: Same.
2914         * mep-tdep.c: Same.
2915         * mn10300-tdep.c: Same.
2916         * namespace.c: Same.
2917         * objfiles.c: Same.
2918         * opencl-lang.c: Same.
2919         * or1k-tdep.c: Same.
2920         * osabi.c: Same.
2921         * ppc-linux-nat.c: Same.
2922         * ppc-linux-tdep.c: Same.
2923         * ppc-sysv-tdep.c: Same.
2924         * printcmd.c: Same.
2925         * procfs.c: Same.
2926         * record-btrace.c: Same.
2927         * record-full.c: Same.
2928         * remote-fileio.c: Same.
2929         * remote.c: Same.
2930         * rs6000-tdep.c: Same.
2931         * s12z-tdep.c: Same.
2932         * score-tdep.c: Same.
2933         * ser-base.c: Same.
2934         * ser-go32.c: Same.
2935         * skip.c: Same.
2936         * sol-thread.c: Same.
2937         * solib-svr4.c: Same.
2938         * solib.c: Same.
2939         * source.c: Same.
2940         * sparc-nat.c: Same.
2941         * sparc-sol2-tdep.c: Same.
2942         * sparc-tdep.c: Same.
2943         * sparc64-tdep.c: Same.
2944         * stabsread.c: Same.
2945         * stack.c: Same.
2946         * symfile.c: Same.
2947         * symtab.c: Same.
2948         * target-descriptions.c: Same.
2949         * target-float.c: Same.
2950         * thread.c: Same.
2951         * utils.c: Same.
2952         * valops.c: Same.
2953         * valprint.c: Same.
2954         * value.c: Same.
2955         * varobj.c: Same.
2956         * windows-nat.c: Same.
2957         * xcoffread.c: Same.
2958         * xstormy16-tdep.c: Same.
2959         * xtensa-tdep.c: Same.
2960
2961 2019-10-17  Tom Tromey  <tromey@adacore.com>
2962
2963         * configure: Rebuild.
2964         * configure.ac: Use AC_CONFIG_HEADERS.  Create stamp-h there, not
2965         in AC_CONFIG_FILES invocation.
2966         * Makefile.in (Makefile, data-directory/Makefile, stamp-h): Use
2967         new-style config.status invocation.
2968
2969 2019-10-17  Tom de Vries  <tdevries@suse.de>
2970
2971         * arm-nbsd-nat.c: Fix typos in comments.
2972         * arm-tdep.c: Same.
2973         * darwin-nat-info.c: Same.
2974         * dwarf2read.c: Same.
2975         * elfread.c: Same.
2976         * event-top.c: Same.
2977         * findvar.c: Same.
2978         * gdbtypes.c: Same.
2979         * hppa-tdep.c: Same.
2980         * i386-tdep.c: Same.
2981         * jit.c: Same.
2982         * main.c: Same.
2983         * mdebugread.c: Same.
2984         * moxie-tdep.c: Same.
2985         * nto-procfs.c: Same.
2986         * osabi.c: Same.
2987         * ppc-linux-tdep.c: Same.
2988         * remote.c: Same.
2989         * riscv-tdep.c: Same.
2990         * s390-tdep.c: Same.
2991         * sh-tdep.c: Same.
2992         * sparc-linux-tdep.c: Same.
2993         * sparc-nat.c: Same.
2994         * stack.c: Same.
2995         * target-descriptions.c: Same.
2996         * top.c: Same.
2997         * varobj.c: Same.
2998
2999 2019-10-16  Tom Tromey  <tom@tromey.com>
3000
3001         * objfiles.h (struct objfile) <original_name>: Now const.
3002
3003 2019-10-16  Christian Biesinger  <cbiesinger@google.com>
3004
3005         * gdbsupport/gdb_setjmp.h (SIGSETJMP): Allow passing in the value to
3006         pass on to sigsetjmp's second argument.
3007         * cp-support.c (gdb_demangle): Unblock SIGSEGV if we caught a crash.
3008
3009 2019-10-16  Keith Seitz  <keiths@redhat.com>
3010
3011         PR gdb/23567
3012         * dwarf2read.c (dwarf2_per_objfile::locate_sections): Discard
3013         sections whose size is greater than the file size.
3014
3015 2019-10-16  Jim Wilson  <jimw@sifive.com>
3016
3017         * riscv-tdep.c (riscv_gcc_target_options): New.
3018         (riscv_gnu_triplet_regexp): New.
3019         (riscv_gdbarch_init): Call set_gdbarch_gcc_triplet_options and
3020         set_gdbarch_gnu_triplet_regexp.
3021
3022 2019-10-16  Christian Biesinger  <cbiesinger@google.com>
3023
3024         * Makefile.in: Add xml-builtin.h.
3025         * features/feature_to_c.sh: Add an include for xml-builtin.h
3026         to ensure that the compiler checks that the types match.
3027         * xml-builtin.h: New file.
3028         * xml-support.c (fetch_xml_builtin): Add missing const.
3029         * xml-support.h: Remove declaration of xml_builtins.
3030
3031 2019-10-16  Tom de Vries  <tdevries@suse.de>
3032
3033         PR tdep/25096
3034         * amd64-tdep.c (amd64_classify_aggregate_field): Factor out of ...
3035         (amd64_classify_aggregate): ... here.
3036         (amd64_classify_aggregate_field): Handled fiels of nested structs
3037         recursively.
3038
3039 2019-10-16  Tom de Vries  <tdevries@suse.de>
3040
3041         PR tdep/24104
3042         * amd64-tdep.c (amd64_push_arguments): Handle AMD64_NO_CLASS in loop
3043         that handles 'theclass'.
3044
3045 2019-10-15  Andrew Burgess  <andrew.burgess@embecosm.com>
3046
3047         * linespec.c (decode_digits_ordinary): Update comment.
3048         * make-target-delegates: No longer need to handle VEC case.
3049         * memrange.c (normalize_mem_ranges): Update comment.
3050         * namespace.c (add_using_directive): Update comment.
3051         * objc-lang.c (uniquify_strings): Update comment.
3052         * ppc-linux-nat.c (struct thread_points): Update comment.
3053         * probe.h (find_probes_in_objfile): Update comment.
3054         * target.h (enum flash_preserve_mode): Update comment.
3055         * varobj.c (varobj_restrict_range): Update comment.
3056         * varobj.h (varobj_list_children): Update comment.
3057
3058 2019-10-15  Andrew Burgess  <andrew.burgess@embecosm.com>
3059
3060         * Makefile.in: Remove references to vec.h and vec.c.
3061         * aarch64-tdep.c: No longer include vec.h.
3062         * ada-lang.c: Likewise.
3063         * ada-lang.h: Likewise.
3064         * arm-tdep.c: Likewise.
3065         * ax.h: Likewise.
3066         * breakpoint.h: Likewise.
3067         * charset.c: Likewise.
3068         * cp-support.h: Likewise.
3069         * dtrace-probe.c: Likewise.
3070         * dwarf2read.c: Likewise.
3071         * extension.h: Likewise.
3072         * gdb_bfd.c: Likewise.
3073         * gdbsupport/gdb_vecs.h: Likewise.
3074         * gdbsupport/vec.c: Remove.
3075         * gdbsupport/vec.h: Remove.
3076         * gdbthread.h: Likewise.
3077         * guile/scm-type.c: Likewise.
3078         * inline-frame.c: Likewise.
3079         * machoread.c: Likewise.
3080         * memattr.c: Likewise.
3081         * memrange.h: Likewise.
3082         * namespace.h: Likewise.
3083         * nat/linux-btrace.h: Likewise.
3084         * osdata.c: Likewise.
3085         * parser-defs.h: Likewise.
3086         * progspace.h: Likewise.
3087         * python/py-type.c: Likewise.
3088         * record-btrace.c: Likewise.
3089         * rust-exp.y: Likewise.
3090         * solib-target.c: Likewise.
3091         * stap-probe.c: Likewise.
3092         * target-descriptions.c: Likewise.
3093         * target-memory.c: Likewise.
3094         * target.h: Likewise.
3095         * varobj.c: Likewise.
3096         * varobj.h: Likewise.
3097         * xml-support.h: Likewise.
3098
3099 2019-10-15  Andrew Burgess  <andrew.burgess@embecosm.com>
3100
3101         * gdb/dwarf2read.c (dwarf2_per_objfile::~dwarf2_per_objfile):
3102         Update for new std::vector based implementation.
3103         (process_psymtab_comp_unit_reader): Likewise.
3104         (scan_partial_symbols): Likewise.
3105         (recursively_compute_inclusions): Likewise.
3106         (compute_compunit_symtab_includes): Likewise.
3107         (process_imported_unit_die): Likewise.
3108         (queue_and_load_dwo_tu): Likewise.
3109         (follow_die_sig_1): Likewise.
3110         * gdb/dwarf2read.h: Remove DEF_VEC_P.
3111         (typedef dwarf2_per_cu_ptr): Remove.
3112         (struct dwarf2_per_cu_data) <imported_symtabs_empty>: New
3113         function.
3114         (struct dwarf2_per_cu_data) <imported_symtabs_push>: New function.
3115         (struct dwarf2_per_cu_data) <imported_symtabs_size>: New function.
3116         (struct dwarf2_per_cu_data) <imported_symtabs_free>: New function.
3117         (struct dwarf2_per_cu_data) <imported_symtabs>: Change to
3118         std::vector.
3119
3120 2019-10-15  Tom Tromey  <tromey@adacore.com>
3121
3122         * windows-nat.c (windows_nat_target::resume): Use %x when logging
3123         TID.
3124
3125 2019-10-15  Tom Tromey  <tromey@adacore.com>
3126
3127         * windows-nat.c (windows_nat_target::fetch_registers)
3128         (windows_nat_target::store_registers): Rename "pid" to "tid".
3129
3130 2019-10-15  Tom Tromey  <tromey@adacore.com>
3131
3132         * gdbarch.h, gdbarch.c: Rebuild.
3133         * gdbarch.sh (gcc_target_options): Change return type to
3134         std::string.
3135         * compile/compile.c (get_args): Update.
3136         * nios2-tdep.c (nios2_gcc_target_options): Return std::string.
3137         * arm-linux-tdep.c (arm_linux_gcc_target_options): Return
3138         std::string.
3139         * aarch64-linux-tdep.c (aarch64_linux_gcc_target_options): Return
3140         std::string.
3141         * arch-utils.c (default_gcc_target_options): Return std::string.
3142         * arch-utils.h (default_gcc_target_options): Return std::string.
3143         * s390-tdep.c (s390_gcc_target_options): Return std::string.
3144
3145 2019-10-15  Christian Biesinger  <cbiesinger@google.com>
3146
3147         * breakpoint.c (breakpoint_chain): Make static.
3148         * tui/tui-winsource.c: Call iterate_over_breakpoints instead
3149         of accessing breakpoint_chain.
3150
3151 2019-10-15  Christian Biesinger  <cbiesinger@google.com>
3152
3153         * breakpoint.c (iterate_over_breakpoints): Change function pointer
3154         to a gdb::function_view and return value to bool.
3155         * breakpoint.h (iterate_over_breakpoints): Likewise.
3156         * dummy-frame.c (pop_dummy_frame_bpt): Update.
3157         (pop_dummy_frame): Update.
3158         * guile/scm-breakpoint.c (bpscm_build_bp_list): Update.
3159         (gdbscm_breakpoints): Update.
3160         * python/py-breakpoint.c (build_bp_list): Update.
3161         (gdbpy_breakpoints): Update.
3162         * python/py-finishbreakpoint.c (bpfinishpy_detect_out_scope_cb):
3163         Update.
3164         (bpfinishpy_handle_stop): Update.
3165         (bpfinishpy_handle_exit): Update.
3166         * solib-svr4.c (svr4_update_solib_event_breakpoint): Update.
3167         (svr4_update_solib_event_breakpoints): Update.
3168
3169 2019-10-15  Andreas Arnez  <arnez@linux.ibm.com>
3170
3171         * s390-tdep.c (s390_effective_inner_type): Ignore static fields
3172         when unwrapping single-field structs.
3173
3174 2019-10-14  Simon Marchi  <simon.marchi@polymtl.ca>
3175
3176         * dwarf2read.c: Remove includes.
3177
3178 2019-10-13  Simon Marchi  <simon.marchi@polymtl.ca>
3179
3180         * ui-out.c (ui_out::call_do_message): Silence
3181         -Wformat-nonliteral warning.
3182
3183 2019-10-12  Simon Marchi  <simon.marchi@polymtl.ca>
3184
3185         * breakpoint.c: Remove some includes: continuations.h, skip.h,
3186         mi/mi-main.h, readline/readline.h, readline/history.h.  Add
3187         include: readline/tilde.h.
3188
3189 2019-10-12  Christian Biesinger  <cbiesinger@google.com>
3190
3191         * remote.c (remote_target::get_trace_status): Remove declaration of
3192         trace_regblock_size.
3193
3194 2019-10-12  Christian Biesinger  <cbiesinger@google.com>
3195
3196         * cli/cli-cmds.c (max_user_call_depth): Move comment to header.
3197         (show_user): Remove declaration of cmdlist.
3198         * cli/cli-cmds.h (max_user_call_depth): Declare.
3199         * cli/cli-script.c (execute_user_command): Remove declaration
3200         of max_user_call_depth.
3201
3202 2019-10-11  Jim Wilson  <jimw@sifive.com>
3203
3204         * gdbsupport/print-utils.h (pulongest): Fix comment.
3205         (plongest): Likewise.
3206         (phex): Add missing comment, mention leading zeros.
3207         (phex_nz): Add mention of no leading zeros to comment.
3208
3209         * riscv-tdep.c (riscv_push_dummy_code): Change %lld to %s and use
3210         plongest instead of unsigned long long cast.
3211
3212 2019-10-10  Christian Biesinger  <cbiesinger@google.com>
3213
3214         * main.c (captured_main_1): Include gdbtk.h and remove declarations
3215         for external_editor_command and gdbtk_test.
3216
3217 2019-10-10  Christian Biesinger  <cbiesinger@google.com>
3218
3219         * mi/mi-cmd-var.c (varobjdebug): Remove declaration.
3220         * varobj.c (varobjdebug): Move comment to...
3221         * varobj.h (varobjdebug): ...here, and declare.
3222
3223 2019-10-09  Tom Tromey  <tom@tromey.com>
3224
3225         * tui/tui-regs.c (tui_data_window::show_registers): Don't call
3226         erase_data_content.
3227
3228 2019-10-09  Tom Tromey  <tom@tromey.com>
3229
3230         * tui/tui-wingeneral.h (tui_delete_win): Don't declare.
3231         * tui/tui-stack.c (tui_locator_window::rerender): Update.
3232         * tui/tui-command.c (tui_cmd_window::resize)
3233         (tui_refresh_cmd_win): Update.
3234         * tui/tui-win.c (tui_resize_all, tui_set_focus_command): Update.
3235         * tui/tui.c (tui_rl_other_window, tui_enable): Update.
3236         * tui/tui-data.c (~tui_gen_win_info): Remove.
3237         * tui/tui-layout.c (tui_gen_win_info::resize): Update.
3238         * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
3239         (tui_redisplay_readline, tui_mld_flush)
3240         (tui_mld_erase_entire_line, tui_mld_getc, tui_getc): Update.
3241         * tui/tui-regs.c (tui_data_window::delete_data_content_windows)
3242         (tui_data_window::erase_data_content)
3243         (tui_data_item_window::rerender)
3244         (tui_data_item_window::refresh_window): Update.
3245         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window)
3246         (box_win, tui_gen_win_info::make_window)
3247         (tui_gen_win_info::make_visible): Update.
3248         (tui_delete_win): Remove.
3249         * tui/tui-winsource.c
3250         (tui_source_window_base::do_erase_source_content): Update.
3251         (tui_show_source_line, tui_source_window_base::update_tab_width)
3252         (tui_source_window_base::update_exec_info): Update.
3253         * tui/tui-data.h (struct curses_deleter): New.
3254         (struct tui_gen_win_info) <handle>: Now a unique_ptr.
3255         (struct tui_gen_win_info) <~tui_gen_win_info>: Define.
3256
3257 2019-10-09  Tom Tromey  <tom@tromey.com>
3258
3259         * tui/tui-wingeneral.h (struct tui_gen_win_info): Don't declare.
3260
3261 2019-10-09  Tom Tromey  <tom@tromey.com>
3262
3263         * tui/tui-data.c (tui_win_is_auxiliary): Remove.
3264         * tui/tui-data.h (tui_win_is_auxiliary): Don't declare.
3265
3266 2019-10-09  Tom Tromey  <tom@tromey.com>
3267
3268         * tui/tui-disasm.c (tui_get_low_disassembly_address): Compute
3269         window height directly.
3270         * tui/tui-layout.h (tui_default_win_viewport_height): Don't
3271         declare.
3272         * tui/tui-layout.c (tui_default_win_height): Remove.
3273         (tui_default_win_viewport_height): Remove.
3274
3275 2019-10-09  Tom Tromey  <tom@tromey.com>
3276
3277         * tui/tui.h: Remove comments.
3278
3279 2019-10-09  Tom de Vries  <tdevries@suse.de>
3280
3281         * python/lib/gdb/printer/bound_registers.py: Use
3282         '^builtin_type_bound128' as regexp argument for
3283         add_builtin_pretty_printer.
3284
3285 2019-10-09  Christian Biesinger  <cbiesinger@google.com>
3286
3287         * guile/guile.c (guile_extension_script_ops): Remove forward
3288         declaration and mark as static.
3289         (guile_script_ops): Likewise.
3290         (extension_language_guile): Move further down in the file so
3291         it can reference the definitions for guile_{extension_,}script_ops.
3292
3293 2019-10-09  Andreas Arnez  <arnez@linux.ibm.com>
3294
3295         * s390-tdep.c (390_process_record): Handle new arch13 instructions
3296         except SORTL, DFLTCC, and KDSA.
3297
3298 2019-10-08  Tom Tromey  <tromey@adacore.com>
3299
3300         * windows-nat.c (struct windows_thread_info_struct) <sf>: Remove.
3301         (struct safe_symbol_file_add_args): Remove.
3302
3303 2019-10-08  Tom Tromey  <tromey@adacore.com>
3304
3305         * windows-nat.c: Don't include buildsym-legacy.h.
3306
3307 2019-10-08  Tom Tromey  <tromey@adacore.com>
3308
3309         * contrib/ari/gdb_ari.sh (%p): Allow gdb-specific %p extensions.
3310
3311 2019-10-08  Christian Biesinger  <cbiesinger@google.com>
3312
3313         * gdbtypes.c (overload_debug): Move comment to header.
3314         * gdbtypes.h (overload_debug): Declare.
3315         * valops.c: Remove declaration of overload_debug, instead
3316         include gdbtypes.h.
3317
3318 2019-10-08  Christian Biesinger  <cbiesinger@google.com>
3319
3320         * language.c (show_language_command): Pass lang_frame_mismatch_warn
3321         through _().
3322         (lang_frame_mismatch_warn): Make const, mark with N_(), and
3323         move comment...
3324         * language.h (lang_frame_mismatch_warn): ... here. Also add
3325         declaration.
3326         * top.c (lang_frame_mismatch_warn): Remove declaration.
3327         (check_frame_language_change): Pass lang_frame_mismatch_warn
3328         through _().
3329
3330 2019-10-07  Christian Biesinger  <cbiesinger@google.com>
3331
3332         * c-lang.h (vtbl_ptr_name): Declare.
3333         * cp-valprint.c (vtbl_ptr_name): Remove "extern" now that we get
3334         it from the header.
3335         * stabsread.c (define_symbol): Remove declaration of vtbl_ptr_name.
3336
3337 2019-10-07  Christian Biesinger  <cbiesinger@google.com>
3338
3339         * charset.c (your_gdb_wchar_t_is_bogus): Replace with a
3340         gdb_static_assert.
3341
3342 2019-10-07  Weimin Pan  <weimin.pan@oracle.com>
3343
3344         * ../Makefile.def (dependencies): Add all-libctf to all-gdb
3345         * ../Makefile.in: Add "all-gdb: maybe-all-libctf"
3346         * ctfread.c: New file.
3347         * ctfread.h: New file.
3348         * elfread.c: Include ctfread.h.
3349         (struct elfinfo text_p): New member ctfsect.
3350         (elf_locate_sections): Mark CTF section.
3351         (elf_symfile_read): Call elfctf_build_psymtabs.
3352         * Makefile.in (LIBCTF): Add.
3353         (CLIBS): Use it.
3354         (CDEPS): Likewise.
3355         (DIST): Add ctfread.c.
3356
3357 2019-10-07  Andrew Burgess  <andrew.burgess@embecosm.com>
3358
3359         * ctfread.c (struct nextfield): Renamed to ...
3360         (struct ctf_nextfield): ... this.
3361         (struct field_info): Renamed to ...
3362         (strut ctf_field_info): ... this.
3363         (attach_fields_to_type): Update for renamed structures.
3364         (ctf_add_member_cb): Likewise.
3365         (ctf_add_enum_member_cb): Likewise.
3366         (process_struct_members): Likewise.
3367         (process_enum_type): Likewise.
3368
3369 2019-10-07  Weimin Pan  <weimin.pan@oracle.com>
3370
3371         * tracectf.h: Rename, was ctf.h.
3372         * tracectf.c: Rename, was ctf.c, replace ctf.h with tracectf.h.
3373         * tracefile.c: Likewise.
3374         * tracepoint.c: Remove unused include ctf.h.
3375         * mi/mi-main.c: Likewise.
3376         * Makefile.in Replace ctf.c with tracectf.c.
3377
3378 2019-10-06  Joel Brobecker  <brobecker@adacore.com>
3379
3380         * version.in: Change version number to "9.0.50.DATE-git".
3381
3382 2019-10-03  Tom Tromey  <tom@tromey.com>
3383
3384         PR rust/24976:
3385         * dwarf2read.c (quirk_rust_enum): Handle single-element unions.
3386
3387 2019-10-03  Andrew Burgess  <andrew.burgess@embecosm.com>
3388
3389         * f-lang.c (f_language_defn): Use cp_get_symbol_name_matcher and
3390         cp_search_name_hash.
3391         * NEWS: Add entry about nested function support.
3392
3393 2019-10-03  Bernhard Heckel  <bernhard.heckel@intel.com>
3394             Andrew Burgess  <andrew.burgess@embecosm.com>
3395
3396         * cp-namespace.c (cp_search_static_and_baseclasses): Only search
3397         for nested static variables when searchin VAR_DOMAIN.
3398         * dwarf2read.c (add_partial_symbol): Add nested subroutines to the
3399         global scope, update comment.
3400         (add_partial_subprogram): Call add_partial_subprogram recursively
3401         for nested subroutines when processinng Fortran.
3402         (load_partial_dies): Process the child entities of a subprogram
3403         when processing Fortran.
3404         (partial_die_parent_scope): Handle building scope
3405         for Fortran nested functions.
3406         (process_die): Record that nested functions have a scope.
3407         (new_symbol): Always record Fortran subprograms on the global
3408         symbol list.
3409         (determine_prefix): How to build the prefix for Fortran
3410         subprograms.
3411
3412 2019-10-03  Andrew Burgess  <andrew.burgess@embecosm.com>
3413
3414         * linux-nat.c (linux_nat_filter_event): Don't ignore SIGSTOP if we
3415         have just sent the thread a SIGSTOP and are waiting for it to
3416         arrive.
3417
3418 2019-10-03  Andrew Burgess  <andrew.burgess@embecosm.com>
3419
3420         * btrace.c (btrace_add_pc): Remove whitespace before the template
3421         parameter in 'std::vector <...>'.
3422         (parse_xml_btrace_block): Likewise.
3423         (btrace_maint_decode_pt): Likewise.
3424         (btrace_maint_update_packets): Likewise.
3425         (btrace_maint_print_packets): Likewise.
3426         * btrace.h (struct btrace_maint_info): Likewise.
3427         * dwarf2read.c (struct type_unit_group): Likewise.
3428         (build_type_psymtabs_reader): Likewise.
3429         * gdbsupport/btrace-common.c (btrace_data_append): Likewise.
3430         * gdbsupport/btrace-common.h (struct btrace_data_bts): Likewise.
3431         * nat/linux-btrace.c (perf_event_read_bts): Likewise.
3432
3433 2019-10-03  Tom de Vries  <tdevries@suse.de>
3434
3435         * cli/cli-style.c (_initialize_cli_style): Adding a '.' at the end of
3436         the first line of the help text for set/show style metadata.
3437
3438 2019-10-02  Tom Tromey  <tromey@adacore.com>
3439
3440         * Makefile.in (COMMON_SFILES): Add common-inferior.c.
3441         * gdbsupport/common-inferior.c: New file.
3442         * infcmd.c (startup_with_shell): Don't define.
3443         * nat/fork-inferior.h (startup_with_shell): Don't declare.
3444         * gdbsupport/common-inferior.h (startup_with_shell): Declare.
3445         * inferior.h (startup_with_shell): Don't declare.
3446
3447 2019-10-02  Christian Biesinger  <cbiesinger@google.com>
3448
3449         * gdbsupport/gdb_assert.h: Include errors.h.
3450         * gdbsupport/gdb_string_view.h: Include gdb_assert.h.
3451
3452 2019-10-02  Tom Tromey  <tromey@adacore.com>
3453
3454         * NEWS: Add $_ada_exception entry.
3455         * ada-lang.c (struct ada_catchpoint): Add constructor.
3456         <m_kind>: New member.
3457         (allocate_location_exception, re_set_exception): Remove
3458         "ex" parameter.
3459         (should_stop_exception): Compute $_ada_exception.
3460         (check_status_exception, print_it_exception)
3461         (print_one_exception, print_mention_exception): Remove
3462         "ex" parameter.
3463         (allocate_location_catch_exception, re_set_catch_exception)
3464         (check_status_exception, print_it_catch_exception)
3465         (print_one_catch_exception, print_mention_catch_exception)
3466         (print_recreate_catch_exception)
3467         (allocate_location_catch_exception_unhandled)
3468         (re_set_catch_exception_unhandled)
3469         (check_status_exception, print_it_catch_exception_unhandled)
3470         (print_one_catch_exception_unhandled)
3471         (print_mention_catch_exception_unhandled)
3472         (print_recreate_catch_exception_unhandled)
3473         (allocate_location_catch_assert, re_set_catch_assert)
3474         (check_status_assert, print_it_catch_assert)
3475         (print_one_catch_assert, print_mention_catch_assert)
3476         (print_recreate_catch_assert)
3477         (allocate_location_catch_handlers, re_set_catch_handlers)
3478         (check_status_handlers, print_it_catch_handlers)
3479         (print_one_catch_handlers, print_mention_catch_handlers)
3480         (print_recreate_catch_handlers): Remove.
3481         (create_ada_exception_catchpoint): Update.
3482         (initialize_ada_catchpoint_ops): Update.
3483
3484 2019-10-02  Tom Tromey  <tromey@adacore.com>
3485
3486         * ada-lang.c (ada_lookup_simple_minsyms): Remove.
3487         (create_excep_cond_exprs): Simplify exception string computation.
3488         (ada_exception_catchpoint_cond_string): Likewise.
3489
3490 2019-10-02  Tom Tromey  <tromey@adacore.com>
3491
3492         * symmisc.c (dump_msymbols): Don't use MSYMBOL_VALUE_ADDRESS.
3493         * ada-lang.c (lesseq_defined_than): Handle
3494         LOC_STATIC.
3495         * dwarf2read.c (dwarf2_per_objfile): Add can_copy
3496         parameter.
3497         (dwarf2_has_info): Likewise.
3498         (new_symbol): Set maybe_copied on symbol when
3499         appropriate.
3500         * dwarf2read.h (dwarf2_per_objfile): Add can_copy
3501         parameter.
3502         <can_copy>: New member.
3503         * elfread.c (record_minimal_symbol): Set maybe_copied
3504         on symbol when appropriate.
3505         (elf_symfile_read): Update call to dwarf2_has_info.
3506         * minsyms.c (lookup_minimal_symbol_linkage): New
3507         function.
3508         * minsyms.h (lookup_minimal_symbol_linkage): Declare.
3509         * symtab.c (get_symbol_address, get_msymbol_address):
3510         New functions.
3511         * symtab.h (get_symbol_address, get_msymbol_address):
3512         Declare.
3513         (SYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_ADDRESS): Handle
3514         maybe_copied.
3515         (struct symbol, struct minimal_symbol) <maybe_copied>:
3516         New member.
3517
3518 2019-10-02  Tom Tromey  <tromey@adacore.com>
3519
3520         * source.c (struct current_source_location): New.
3521         (current_source_key): New global.
3522         (current_source_symtab, current_source_line)
3523         (current_source_pspace): Remove.
3524         (get_source_location): New function.
3525         (get_current_source_symtab_and_line)
3526         (set_default_source_symtab_and_line)
3527         (set_current_source_symtab_and_line)
3528         (clear_current_source_symtab_and_line, select_source_symtab)
3529         (info_source_command, print_source_lines_base)
3530         (info_line_command, search_command_helper, _initialize_source):
3531         Update.
3532
3533 2019-10-02  Tom Tromey  <tromey@adacore.com>
3534
3535         * source.c (select_source_symtab): Don't call
3536         decode_line_with_current_source.
3537
3538 2019-10-02  Andrew Burgess  <andrew.burgess@embecosm.com>
3539
3540         * symtab.c (lookup_global_symbol): Search global block.
3541
3542 2019-10-02  Tom Tromey  <tromey@adacore.com>
3543
3544         * coffread.c (process_coff_symbol): Update.
3545         * dwarf2read.c (var_decode_location, new_symbol): Update.
3546         * mdebugread.c (parse_symbol): Update.
3547         * objfiles.c (relocate_one_symbol): Update.
3548         * stabsread.c (define_symbol, fix_common_block)
3549         (scan_file_globals): Update.
3550         * symtab.h (SYMBOL_VALUE_ADDRESS): Expand to an rvalue.
3551         (SET_SYMBOL_VALUE_ADDRESS): New macro.
3552         * xcoffread.c (process_xcoff_symbol): Update.
3553
3554 2019-10-02  Andreas Arnez  <arnez@linux.ibm.com>
3555
3556         * MAINTAINERS: Update my email address.
3557
3558 2019-10-02  Andrew Burgess  <andrew.burgess@embecosm.com>
3559
3560         * dwarf2read.c (struct type_unit_group) <tus>: Convert to
3561         std::vector.
3562         (build_type_psymtabs_reader): Update for std::vector.
3563         (build_type_psymtab_dependencies): Likewise.
3564         * dwarf2read.h: Remove use of DEF_VEC_P.
3565         (typedef sig_type_ptr): Delete.
3566
3567 2019-10-02  Andrew Burgess  <andrew.burgess@embecosm.com>
3568
3569         * btrace.c (btrace_maint_clear): Update to handle change from VEC
3570         to std::vector.
3571         (btrace_maint_decode_pt): Likewise, and move allocation of the
3572         vector outside of the loop.
3573         (btrace_maint_update_packets): Update to handle change from VEC to
3574         std::vector.
3575         (btrace_maint_print_packets): Likewise.
3576         (maint_info_btrace_cmd): Likewise.
3577         * btrace.h: Remove use of DEF_VEC_O.
3578         (typedef btrace_pt_packet_s): Delete.
3579         (struct btrace_maint_info) <packets>: Change fromm VEC to
3580         std::vector.
3581         * gdbsupport/btrace-common.h: Remove 'vec.h' include.
3582
3583 2019-10-02  Andrew Burgess  <andrew.burgess@embecosm.com>
3584
3585         * btrace.c (btrace_compute_ftrace_bts): Update for std::vector,
3586         make accesses into the vector constant references.
3587         (btrace_add_pc): Update for std::vector.
3588         (btrace_stitch_bts): Likewise.
3589         (parse_xml_btrace_block): Likewise.
3590         (btrace_maint_update_packets): Likewise.
3591         (btrace_maint_print_packets): Likewise.
3592         (maint_info_btrace_cmd): Likewise.
3593         * gdbsupport/btrace-common.c (btrace_data::fini): Update for
3594         std::vector.
3595         (btrace_data::empty): Likewise.
3596         (btrace_data_append): Likewise.
3597         * gdbsupport/btrace-common.h: Remove use of DEF_VEC_O.
3598         (typedef btrace_block_s): Delete.
3599         (struct btrace_block): Add constructor.
3600         (struct btrace_data_bts) <blocks>: Change to std::vector.
3601         * nat/linux-btrace.c (perf_event_read_bts): Update for
3602         std::vector.
3603         (linux_read_bts): Likewise.
3604
3605 2019-10-01  Tom Tromey  <tom@tromey.com>
3606
3607         * cli/cli-logging.c (show_logging_filename): Use styled_string.
3608
3609 2019-10-01  Tom Tromey  <tom@tromey.com>
3610
3611         * stack.c (print_frame, info_frame_command_core): Use
3612         styled_string.
3613         * linux-thread-db.c (try_thread_db_load_1)
3614         (try_thread_db_load_from_pdir_1): Use styled_string.
3615         * auto-load.c (file_is_auto_load_safe, execute_script_contents)
3616         (auto_load_section_scripts, info_auto_load_local_gdbinit)
3617         (maybe_print_unsupported_script_warning)
3618         (maybe_print_script_not_found_warning): Use styled_string.
3619         * ada-lang.c (user_select_syms): Use styled_string.
3620
3621 2019-10-01  Tom Tromey  <tom@tromey.com>
3622
3623         * p-lang.c (pascal_printstr): Use metadata style.
3624         * value.c (show_convenience): Use metadata style.
3625         * valprint.c (valprint_check_validity, val_print_optimized_out)
3626         (val_print_not_saved, val_print_unavailable)
3627         (val_print_invalid_address, generic_val_print, val_print)
3628         (value_check_printable, val_print_array_elements): Use metadata
3629         style.
3630         * ui-out.h (class ui_out) <field_fmt>: New overload.
3631         <do_field_fmt>: Add style parameter.
3632         * ui-out.c (ui_out::field_fmt): New overload.
3633         * typeprint.c (type_print_unknown_return_type)
3634         (val_print_not_allocated, val_print_not_associated): Use metadata
3635         style.
3636         * tui/tui-out.h (class tui_ui_out) <do_field_fmt>: Add style
3637         parameter.
3638         * tui/tui-out.c (tui_ui_out::do_field_fmt): Update.
3639         * tracepoint.c (tvariables_info_1): Use metadata style.
3640         * stack.c (print_frame_arg, print_frame_info, print_frame)
3641         (info_frame_command_core): Use metadata style.
3642         * skip.c (info_skip_command): Use metadata style.
3643         * rust-lang.c (rust_print_enum): Use metadata style.
3644         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
3645         metadata style.
3646         * python/py-framefilter.c (py_print_single_arg): Use metadata
3647         style.
3648         * printcmd.c (do_one_display, print_variable_and_value): Use
3649         metadata style.
3650         * p-valprint.c (pascal_val_print)
3651         (pascal_object_print_value_fields): Use metadata style.
3652         * p-typeprint.c (pascal_type_print_base): Use metadata style.
3653         * mi/mi-out.h (class mi_ui_out) <do_field_fmt>: Add style
3654         parameter.
3655         * mi/mi-out.c (mi_ui_out::do_field_fmt): Update.
3656         * m2-valprint.c (m2_print_long_set): Use metadata style.
3657         * m2-typeprint.c (m2_print_type): Use metadata style.
3658         * infcmd.c (print_return_value_1): Use metadata style.
3659         * gnu-v3-abi.c (print_one_vtable): Use metadata style.
3660         * f-valprint.c (info_common_command_for_block): Use metadata
3661         style.
3662         * f-typeprint.c (f_type_print_base): Use metadata style.
3663         * expprint.c (print_subexp_standard): Use metadata style.
3664         * cp-valprint.c (cp_print_value_fields): Use metadata style.
3665         * cli/cli-style.h (class cli_style_option): Add constructor.
3666         (metadata_style): Declare.
3667         * cli/cli-style.c (metadata_style): New global.
3668         (_initialize_cli_style): Register metadata style.
3669         * cli-out.h (class cli_ui_out) <do_field_fmt>: Add style
3670         parameter.
3671         * cli-out.c (cli_ui_out::do_field_fmt): Update.
3672         * c-typeprint.c (c_type_print_base_struct_union)
3673         (c_type_print_base_1): Use metadata style.
3674         * breakpoint.c (watchpoint_value_print)
3675         (print_one_breakpoint_location): Use metadata style.
3676         * break-catch-syscall.c (print_one_catch_syscall): Use metadata
3677         style.
3678         * break-catch-sig.c (signal_catchpoint_print_one): Use metadata
3679         style.
3680         * ada-valprint.c (val_print_packed_array_elements, printstr)
3681         (print_field_values, ada_val_print_ref, ada_val_print): Use
3682         metadata style.
3683         * ada-typeprint.c (print_array_type, ada_print_type): Use metadata
3684         style.
3685         * ada-tasks.c (print_ada_task_info, info_task): Use metadata
3686         style.
3687         * ada-lang.c (user_select_syms): Use metadata style.
3688
3689 2019-10-01  Tom Tromey  <tom@tromey.com>
3690
3691         * cli/cli-cmds.c (pwd_command): Style output.
3692
3693 2019-10-01  Pedro Alves  <palves@redhat.com>
3694             Tom Tromey  <tom@tromey.com>
3695
3696         * symtab.c (print_symbol_info): Use %ps.
3697         (print_msymbol_info): Use %ps.
3698         * symfile.c (symbol_file_add_with_addrs): Use %ps.
3699         * printcmd.c (print_variable_and_value): Use %ps.
3700         * macrocmd.c (show_pp_source_pos): Use %ps.
3701         * infrun.c (print_exited_reason): Use ui_out::message.
3702         * breakpoint.c (watchpoint_check, print_one_breakpoint_location)
3703         (describe_other_breakpoints): Use ui_out::message and new
3704         formats.
3705         (say_where): Use new formats.
3706         (bkpt_print_it, tracepoint_print_one_detail): Use ui_out::message
3707         and new formats.
3708
3709 2019-10-01  Pedro Alves  <palves@redhat.com>
3710             Tom Tromey  <tom@tromey.com>
3711
3712         * unittests/format_pieces-selftests.c: Add gdb_format parameter.
3713         (test_gdb_formats): New function.
3714         (run_tests): Call it.
3715         (test_format_specifier): Update.
3716         * utils.h (fputs_filtered): Update comment.
3717         (vfprintf_styled, vfprintf_styled_no_gdbfmt)
3718         (fputs_styled_unfiltered): Declare.
3719         * utils.c (fputs_styled_unfiltered): New function.
3720         (vfprintf_maybe_filtered): Add gdbfmt parameter.
3721         (vfprintf_filtered): Update.
3722         (vfprintf_unfiltered, vprintf_filtered): Update.
3723         (vfprintf_styled, vfprintf_styled_no_gdbfmt): New functions.
3724         * ui-out.h (enum ui_out_flag) <unfiltered_output,
3725         disallow_ui_out_field>: New constants.
3726         (enum class field_kind): New.
3727         (struct base_field_s, struct signed_field_s): New.
3728         (signed_field): New function.
3729         (struct string_field_s): New.
3730         (string_field): New function.
3731         (struct styled_string_s): New.
3732         (styled_string): New function.
3733         (class ui_out) <message>: Add comment.
3734         <vmessage, call_do_message>: New methods.
3735         <do_message>: Add style parameter.
3736         * ui-out.c (ui_out::call_do_message, ui_out::vmessage): New
3737         methods.
3738         (ui_out::message): Rewrite.
3739         * mi/mi-out.h (class mi_ui_out) <do_message>: Add style
3740         parameter.
3741         * mi/mi-out.c (mi_ui_out::do_message): Add style parameter.
3742         * gdbsupport/format.h (class format_pieces) <format_pieces>: Add
3743         gdb_extensions parameter.
3744         (class format_piece): Add parameter to constructor.
3745         (n_int_args): New field.
3746         * gdbsupport/format.c (format_pieces::format_pieces): Add
3747         gdb_extensions parameter.  Handle '*'.
3748         * cli-out.h (class cli_ui_out) <do_message>: Add style parameter.
3749         * cli-out.c (cli_ui_out::do_message): Add style parameter.  Call
3750         vfprintf_styled_no_gdbfmt.
3751         (cli_ui_out::do_field_string, cli_ui_out::do_spaces)
3752         (cli_ui_out::do_text, cli_ui_out::field_separator): Allow
3753         unfiltered output.
3754         * ui-style.h (struct ui_file_style) <ptr>: New method.
3755
3756 2019-10-01  Tom Tromey  <tom@tromey.com>
3757
3758         * unittests/format_pieces-selftests.c: Update.  Add final format.
3759         * gdbsupport/format.c (format_pieces::format_pieces): Don't add
3760         empty literal pieces.
3761
3762 2019-10-01  Tom Tromey  <tom@tromey.com>
3763
3764         * ui-out.h (enum class ui_out_style_kind): Remove.
3765         (class ui_out) <field_string, field_stsream, do_field_string>:
3766         Change type of "style".
3767         * ui-out.c (ui_out::field_core_addr, ui_out::field_stream)
3768         (ui_out::field_string): Update.
3769         * tui/tui-out.h (class tui_ui_out) <do_field_string>: Change type
3770         of "style".
3771         * tui/tui-out.c (tui_ui_out::do_field_string): Update.
3772         * tracepoint.c (print_one_static_tracepoint_marker): Update.
3773         * stack.c (print_frame_arg, print_frame_info, print_frame):
3774         Update.
3775         * source.c (print_source_lines_base): Update.
3776         * solib.c (info_sharedlibrary_command): Update.
3777         * skip.c (info_skip_command): Update.
3778         * record-btrace.c (btrace_call_history_src_line)
3779         (btrace_call_history): Update.
3780         * python/py-framefilter.c (py_print_frame): Update.
3781         * mi/mi-out.h (class mi_ui_out) <do_field_string>: Change type of
3782         "style".
3783         * mi/mi-out.c (mi_ui_out::do_table_header)
3784         (mi_ui_out::do_field_signed, mi_ui_out::do_field_unsigned)
3785         (mi_ui_out::do_field_string): Update.
3786         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
3787         Update.
3788         * cli-out.h (class cli_ui_out) <do_field_string>: Change type of
3789         "style".
3790         * cli-out.c (cli_ui_out::do_table_header)
3791         (cli_ui_out::do_field_signed, cli_ui_out::do_field_unsigned)
3792         (cli_ui_out::do_field_skip, cli_ui_out::do_field_string)
3793         (cli_ui_out::do_field_fmt): Update.
3794         * breakpoint.c (print_breakpoint_location): Update.
3795         (update_static_tracepoint): Update.
3796
3797 2019-10-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3798
3799         * main.c (relocate_gdbinit_path_maybe_in_datadir): Remove std::string
3800         conversion of gdb_datadir.
3801         (captured_main_1): Remove xstrdup when assigning to gdb_datadir,
3802         remove not needed c_str ().
3803
3804 2019-09-30  Ali Tamur <tamur@google.com>
3805
3806         * dwarf2read.c (skip_one_die): Handle DW_FORM_strx forms.
3807         (dwarf2_string_attr): Likewise.
3808
3809 2019-09-30  Ali Tamur <tamur@google.com>
3810
3811         * dwarf2read.c (process_full_comp_unit): Remove whitespace at the EOL.
3812         (process_full_type_unit): Likewise.
3813         (dump_die_shallow): Likewise.
3814         (cu_debug_loc_section): Likewise.
3815
3816 2019-09-28  Christian Biesinger  <cbiesinger@google.com>
3817
3818         * minsyms.c (compare_minimal_symbols): Rename to...
3819         (minimal_symbol_is_less_than): ...this, and adjust to STL
3820         conventions (return bool, take arguments as references)
3821         (minimal_symbol_reader::install): Call std::sort instead
3822         of qsort.
3823
3824 2019-09-29  Christian Biesinger  <cbiesinger@google.com>
3825
3826         * minsyms.h (msymbol_hash): Document that this is a case-insensitive
3827         hash and why.
3828         * objfiles.h (struct objfile_per_bfd_storage) <demangled_names_hash,
3829         msymbol_hash, msymbol_demangled_hash>: Improve comments.
3830
3831 2019-09-30  Simon Marchi  <simon.marchi@polymtl.ca>
3832
3833         * psymtab.c (add_psymbol_to_list): Move comment to psympriv.h.
3834         * psympriv.h (add_psymbol_to_list): Move comment here and update
3835         it.
3836
3837 2019-09-29  Tom de Vries  <tdevries@suse.de>
3838
3839         * contrib/cc-with-tweaks.sh (get_tmpdir): New function.
3840         Use $tmpdir/$(basename "$output_file").dwz instead of
3841         "${output_file}.dwz".
3842
3843 2019-09-28  Simon Marchi  <simon.marchi@polymtl.ca>
3844
3845         PR gdb/25045
3846         * hppa-linux-nat.c: Include gdbarch.h.
3847
3848 2019-09-26  Christian Biesinger  <cbiesinger@google.com>
3849
3850         * blockframe.c (find_pc_partial_function): Change return type to bool.
3851         * elfread.c (elf_gnu_ifunc_resolve_name): Likewise.
3852         * minsyms.c (in_gnu_ifunc_stub): Likewise.
3853         (stub_gnu_ifunc_resolve_name): Likewise.
3854         * symtab.c (compare_filenames_for_search): Likewise.
3855         (compare_glob_filenames_for_search): Likewise.
3856         (matching_obj_sections): Likewise.
3857         (symbol_matches_domain): Likewise.
3858         (find_line_symtab): Change out param EXACT_MATCH to bool *.
3859         (find_line_pc): Change return type to bool.
3860         (find_line_pc_range): Likewise.
3861         (producer_is_realview): Likewise.
3862         * symtab.h (symbol_matches_domain): Likewise.
3863         (find_pc_partial_function): Likewise.
3864         (find_pc_line_pc_range): Likewise.
3865         (in_gnu_ifunc_stub): Likewise.
3866         (struct gnu_ifunc_fns) <gnu_ifunc_resolve_name>: Likewise.
3867         (find_line_pc): Likewise.
3868         (find_line_pc_range): Likewise.
3869         (matching_obj_sections): Likewise.
3870         (find_line_symtab): Change out parameter to bool.
3871         (producer_is_realview): Change return type to bool.
3872         (compare_filenames_for_search): Likewise.
3873         (compare_glob_filenames_for_search): Likewise.
3874
3875 2019-09-26  Tom Tromey  <tom@tromey.com>
3876
3877         * Makefile.in (COMMON_SFILES): Remove gdb_usleep.c.
3878         (HFILES_NO_SRCDIR): Remove gdb_usleep.h.
3879         * gdb_usleep.h: Remove.
3880         * gdb_usleep.c: Remove.
3881         * utils.c: Don't include gdb_usleep.h.
3882
3883 2019-09-26  Tom Tromey  <tromey@adacore.com>
3884
3885         * python/py-type.c (type_to_type_object): Call check_typedef
3886         for stub types.
3887
3888 2019-09-26  Tom Tromey  <tom@tromey.com>
3889
3890         * utils.h (initialize_utils): Don't declare.
3891         * top.c (gdb_init): Don't call initialize_utils.
3892         * utils.c (initialize_utils): Remove.  Move contents...
3893         (_initialize_utils): ... here.
3894
3895 2019-09-25  Tom Tromey  <tom@tromey.com>
3896
3897         * python/py-objfile.c (objfpy_get_build_id): Use bin2hex.
3898         * utils.h (make_hex_string): Don't declare.
3899         * utils.c (make_hex_string): Remove.
3900
3901 2019-09-24  Tom de Vries  <tdevries@suse.de>
3902
3903         PR gdb/23815
3904         * amd64-linux-nat.c (amd64_linux_nat_target::fetch_registers):
3905         Initialize xstateregs before ptrace PTRACE_GETREGSET call.
3906
3907 2019-09-23  Dimitar Dimitrov  <dimitar@dinux.eu>
3908
3909         * NEWS: Mention new simulator port for PRU.
3910
3911 2019-09-23  Christian Biesinger  <cbiesinger@google.com>
3912
3913         * ada-exp.y (write_object_remaining): Update.
3914         * ada-lang.c (ada_decode): Return a std::string instead of a char*
3915         and eliminate the static buffer.
3916         (ada_decode_symbol): Update.
3917         (ada_la_decode): Update.
3918         (ada_sniff_from_mangled_name): Update.
3919         (is_valid_name_for_wild_match): Update.
3920         (ada_lookup_name_info::matches): Update and simplify.
3921         (name_matches_regex): Update.
3922         (ada_add_global_exceptions): Update.
3923         * ada-lang.h (ada_decode): Update signature.
3924         * ada-varobj.c (ada_varobj_describe_simple_array_child): Update.
3925         * dwarf-index-write.c (debug_names::insert): Update.
3926
3927 2019-09-21  Simon Marchi  <simon.marchi@polymtl.ca>
3928
3929         * solib-svr4.c (svr4_iterate_over_objfiles_in_search_order): Fix
3930         formatting.
3931
3932 2019-09-21  Simon Marchi  <simon.marchi@polymtl.ca>
3933
3934         * breakpoint.h (bp_location) <inserted, permanent, duplicate>:
3935         Change "nonzero" to "true" in documentation.
3936
3937 2019-09-20  Christian Biesinger  <cbiesinger@google.com>
3938
3939         * solib-darwin.c (darwin_lookup_lib_symbol): Remove.
3940         (_initialize_darwin_solib): Don't set
3941         darwin_so_ops.lookup_lib_global_symbol.
3942         * solib-svr4.c (set_solib_svr4_fetch_link_map_offsets): Call
3943         set_gdbarch_iterate_over_objfiles_in_search_order.
3944         (elf_lookup_lib_symbol): Rename to...
3945         (svr4_iterate_over_objfiles_in_search_order): this, and update
3946         to iterate semantics.
3947         (_initialize_svr4_solib): Don't set lookup_lib_global_symbol.
3948         * solib.c (solib_global_lookup): Remove.
3949         * solist.h (struct target_so_ops): Remove lookup_lib_global_symbol.
3950         (solib_global_lookup): Remove.
3951         * symtab.c (lookup_global_or_static_symbol): Remove call to
3952         solib_global_lookup.
3953
3954 2019-09-20  Joel Brobecker  <brobecker@adacore.com>
3955
3956         * NEWS: Move entries about default MI version now being
3957         version 3, and about the GDB/MI fix for multi-location
3958         breakpoints to the "since GDB 8.3" section.
3959
3960 2019-09-20  Joel Brobecker  <brobecker@adacore.com>
3961
3962         GDB 8.3.1 released.
3963
3964 2019-09-20  Ulrich Weigand  <uweigand@de.ibm.com>
3965
3966         * NEWS: Mention that Cell/B.E. debugging support was removed.
3967         * MAINTAINERS: Remove spu target.
3968
3969         * config/djgpp/fnchange.lst: Remove entries for removed files.
3970
3971         * Makefile.in (ALL_TARGET_OBS): Remove solib-spu.o,
3972         spu-multiarch.o, and spu-tdep.o.
3973         (HFILES_NO_SRCDIR): Remove solib-spu.h and spu-tdep.h.
3974         (ALLDEPFILES): Remove solib-spu.c, spu-linux-nat.c,
3975         spu-multiarch.c, and spu-tdep.c.
3976         * spu-linux-nat.c: Remove file.
3977         * spu-multiarch.c: Remove file.
3978         * spu-tdep.c: Remove file.
3979         * spu-tdep.h: Remove file.
3980         * solib-spu.c: Remove file.
3981         * solib-spu.h: Remove file.
3982
3983         * configure.host (powerpc64*-*-linux*): Remove Cell/B.E. support.
3984         * configure.nat (spu-linux): Remove.
3985         * configure.tgt (powerpc*-*-linux*): Remove solib-spu.o and
3986         solib-multiarch.o from gdb_target_obs.
3987         (spu*-*-*): Remove.
3988
3989         * arch/ppc-linux-common.h (struct ppc_linux_features): Remove "cell"
3990         feature flag.
3991         (ppc_linux_no_features): Update.
3992         * arch/ppc-linux-common.c (ppc_linux_match_description): Remove
3993         Cell/B.E. support.
3994         * arch/ppc-linux-tdesc.h (tdesc_powerpc_cell32l): Remove declaration.
3995         (tdesc_powerpc_cell64l): Likewise.
3996         * nat/ppc-linux.h (PPC_FEATURE_CELL): Remove.
3997         * ppc-linux-nat.c (ppc_linux_nat_target::read_description): Remove
3998         Cell/B.E. support.
3999         * ppc-linux-tdep.h: Do not include "solib-spu.h" or "spu-tdep.h".
4000         Do not include "features/rs6000/powerpc-cell32l.c" or
4001         "features/rs6000/powerpc-cell64l.c".
4002         (ppc_linux_spu_section): Remove.
4003         (ppc_linux_core_read_description): Remove Cell/B.E. support.
4004         (spe_context_objfile, spe_context_lm_addr, spe_context_offset,
4005         spe_context_cache_ptid, spe_context_cache_ptid): Remove.
4006         (ppc_linux_spe_context_lookup): Remove.
4007         (ppc_linux_spe_context_inferior_created): Remove.
4008         (ppc_linux_spe_context_solib_loaded): Remove.
4009         (ppc_linux_spe_context_solib_unloaded): Remove.
4010         (ppc_linux_spe_context): Remove.
4011         (struct ppu2spu_cache): Remove.
4012         (ppu2spu_prev_arch, ppu2spu_this_id, ppu2spu_prev_register): Remove.
4013         (struct ppu2spu_data): Remove.
4014         (ppu2spu_unwind_register, ppu2spu_sniffer, ppu2spu_dealloc_cache,
4015         ppu2spu_unwind): Remove.
4016         (ppc_linux_init_abi): Remove Cell/B.E. support.
4017         * rs6000-tdep.h (rs6000_gdbarch_init): Remove Cell/B.E. support.
4018
4019         * features/Makefile (rs6000/powerpc-cell32l-expedite): Remove.
4020         (rs6000/powerpc-cell64l-expedite): Likewise
4021         (WHICH): Remove rs6000/powerpc-cell32l and rs6000/powerpc-cell64l.
4022         (XMLTOC): Remove rs6000/powerpc-cell32l.xml and
4023         rs6000/powerpc-cell64l.xml.
4024         * features/rs6000/powerpc-cell32l.xml: Remove.
4025         * features/rs6000/powerpc-cell64l.xml: Likewise.
4026         * features/rs6000/powerpc-cell32l.c: Remove generated file.
4027         * features/rs6000/powerpc-cell64l.c: Likewise.
4028         * regformats/rs6000/powerpc-cell32l.dat: Remove generated file.
4029         * regformats/rs6000/powerpc-cell64l.dat: Likewise.
4030         * regformats/reg-spu.dat: Remove.
4031
4032         * target.h (enum target_object): Remove TARGET_OBJECT_SPU.
4033         * corelow.c (struct spuid_list): Remove.
4034         (add_to_spuid_list): Remove.
4035         (core_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
4036         * remote.c (PACKET_qXfer_spu_read, PACKET_qXfer_spu_write): Remove.
4037         (remote_protocol_features): Remove associated entries.
4038         (_initialize_remote): No longer initialize them.
4039         (remote_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
4040         * linux-nat.c (SPUFS_MAGIC): Remove.
4041         (linux_proc_xfer_spu): Remove.
4042         (spu_enumerate_spu_ids): Remove.
4043         (linux_nat_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
4044         * linux-tdep.c (-linux_spu_make_corefile_notes): Remove.
4045         (linux_make_corefile_notes): No longer call it.
4046
4047         * regcache.c (cooked_read_test): Remove bfd_arch_spu special case.
4048         (cooked_write_test): Likewise.
4049
4050 2019-09-20  Tom Tromey  <tom@tromey.com>
4051
4052         * NEWS: Mention case-sensitivity of TUI commands.
4053         * tui/tui-win.c (tui_set_focus_command): Now case-sensitive.
4054         (tui_set_win_height_command, parse_scrolling_args): Likewise.
4055         * tui/tui-layout.c (tui_layout_command): Now case-sensitive.
4056
4057 2019-09-20  Tom Tromey  <tom@tromey.com>
4058
4059         * tui/tui-source.c (tui_source_window::set_contents): Use
4060         make_unique_xstrdup.
4061         * tui/tui-disasm.c (tui_disasm_window::set_contents): Use
4062         make_unique_xstrdup.
4063
4064 2019-09-20  Tom Tromey  <tom@tromey.com>
4065
4066         * tui/tui-data.c: Remove separator comments.
4067         * tui/tui-layout.c: Remove separator comments.
4068         * tui/tui-win.c: Remove separator comments.
4069         * tui/tui-wingeneral.c: Remove separator comments.
4070
4071 2019-09-20  Tom Tromey  <tom@tromey.com>
4072
4073         * tui/tui.h (strcat_to_buf): Don't declare.
4074         * tui/tui.c (strcat_to_buf): Remove.
4075
4076 2019-09-20  Tom Tromey  <tom@tromey.com>
4077
4078         * tui/tui-source.h (struct tui_source_window) <m_fullname>: Rename
4079         from "fullname".
4080         * tui/tui-source.c (tui_source_window::set_contents)
4081         (tui_source_window::location_matches_p)
4082         (tui_source_window::maybe_update): Update.
4083
4084 2019-09-20  Tom Tromey  <tom@tromey.com>
4085
4086         * tui/tui-regs.h (struct tui_data_window) <get_current_group>:
4087         Update.
4088         <m_regs_content, m_regs_column_count, m_current_group>: Add "m_"
4089         prefix.
4090         * tui/tui-regs.c (tui_data_window::last_regs_line_no)
4091         (tui_data_window::line_from_reg_element_no)
4092         (tui_data_window::first_reg_element_no_inline)
4093         (tui_data_window::show_registers)
4094         (tui_data_window::show_register_group)
4095         (tui_data_window::display_registers_from)
4096         (tui_data_window::display_registers_from_line)
4097         (tui_data_window::first_data_item_displayed)
4098         (tui_data_window::delete_data_content_windows)
4099         (tui_data_window::erase_data_content)
4100         (tui_data_window::do_scroll_vertical)
4101         (tui_data_window::refresh_window)
4102         (tui_data_window::check_register_values): Update.
4103
4104 2019-09-20  Tom Tromey  <tom@tromey.com>
4105
4106         * tui/tui-stack.h (MAX_LOCATOR_ELEMENT_LEN): Remove define.
4107         (struct tui_locator_window) <full_name, proc_name>: Now
4108         std::string.
4109         * tui/tui-stack.c (tui_locator_window::make_status_line)
4110         (tui_locator_window::set_locator_fullname)
4111         (tui_locator_window::set_locator_info): Update.
4112         * tui/tui-source.c (tui_source_window::set_contents)
4113         (tui_source_window::showing_source_p): Update.
4114
4115 2019-09-20  Tom Tromey  <tom@tromey.com>
4116
4117         * tui/tui-stack.c (tui_locator_window::set_locator_fullname):
4118         Don't call tui_locator_win_info_ptr.
4119
4120 2019-09-20  Tom Tromey  <tom@tromey.com>
4121
4122         * tui/tui-win.c (tui_resize_all): Don't call refresh.
4123
4124 2019-09-20  Tom Tromey  <tom@tromey.com>
4125
4126         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Use 1 as
4127         height for locator.
4128         * tui/tui-stack.c (tui_locator_window::rerender): Call scrollok.
4129         * tui/tui-layout.c (show_source_disasm_command, show_data)
4130         (show_source_or_disasm_and_command): Use 1 as height for locator.
4131
4132 2019-09-20  Tom Tromey  <tom@tromey.com>
4133
4134         * tui/tui.c (tui_enable): Update.
4135         * tui/tui-win.c (tui_sigwinch_handler, tui_async_resize_screen):
4136         Update.
4137         * tui/tui-data.h (tui_win_resized, tui_set_win_resized_to):
4138         Update.
4139         * tui/tui-data.c (win_resized): Now bool.
4140         (tui_win_resized): Return bool.
4141         (tui_set_win_resized_to): Accept a bool.
4142
4143 2019-09-20  Tom Tromey  <tom@tromey.com>
4144
4145         * tui/tui-regs.h (struct tui_data_window) <show_register_group>:
4146         Change type of "refresh_values_only".
4147         * tui/tui-regs.c (tui_data_window::show_register_group): Change
4148         type of "refresh_values_only".
4149
4150 2019-09-20  Tom Tromey  <tom@tromey.com>
4151
4152         * tui/tui-disasm.c (struct tui_asm_line) <addr_string, insn>: Now
4153         std::string.
4154         (tui_disassemble): Add "pos" parameter.
4155         (tui_disasm_window::set_contents): Simplify.
4156
4157 2019-09-20  Tom Tromey  <tom@tromey.com>
4158
4159         * tui/tui-winsource.h (struct tui_source_window_base)
4160         <show_source_content>: Now private.
4161         * tui/tui-winsource.c
4162         (tui_source_window_base::show_source_content): Don't handle empty
4163         content case.
4164
4165 2019-09-20  Tom Tromey  <tom@tromey.com>
4166
4167         * tui/tui-layout.c (show_source_disasm_command)
4168         (show_source_or_disasm_and_command): Don't call
4169         show_source_content.
4170
4171 2019-09-20  Tom Tromey  <tom@tromey.com>
4172
4173         * tui/tui-stack.h (struct tui_locator_window) <make_status_line>:
4174         Declare.
4175         * tui/tui-stack.c (tui_locator_window::make_status_line): Rename
4176         from tui_make_status_line.
4177         (tui_locator_window::rerender): Update.
4178
4179 2019-09-20  Tom Tromey  <tom@tromey.com>
4180
4181         * tui/tui-stack.c (tui_make_status_line): Return std::string.
4182         (tui_locator_window::rerender): Update.
4183
4184 2019-09-20  Tom Tromey  <tom@tromey.com>
4185
4186         * tui/tui-winsource.h (struct tui_source_window_base)
4187         <~tui_source_window_base>: Don't declare.
4188         <fullname>: Remove.
4189         * tui/tui-winsource.c (~tui_source_window_base): Remove.
4190         * tui/tui-source.h (struct tui_source_window) <fullname>: New
4191         member.
4192         * tui/tui-source.c (tui_source_window::set_contents): Update.
4193         (tui_source_window::location_matches_p)
4194         (tui_source_window::maybe_update): Update.
4195
4196 2019-09-20  Tom Tromey  <tom@tromey.com>
4197
4198         * tui/tui-winsource.h (~tui_source_element): Remove.
4199         (tui_source_element): Update.
4200         (struct tui_source_element) <line>: Now a unique_xmalloc_ptr.
4201         * tui/tui-winsource.c (tui_show_source_line): Update.
4202         * tui/tui-source.c (tui_source_window::set_contents): Update.
4203         * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
4204
4205 2019-09-20  Tom Tromey  <tom@tromey.com>
4206
4207         * tui/tui-data.h (tui_clear_source_windows_detail): Don't
4208         declare.
4209         * tui/tui-layout.c (tui_add_win_to_layout): Don't call
4210         tui_clear_source_windows_detail.
4211         * tui/tui-winsource.h (struct tui_source_window_base)
4212         <clear_detail>: Don't declare.
4213         * tui/tui-winsource.c (tui_source_window_base::clear_detail):
4214         Remove.
4215         * tui/tui-data.c (tui_clear_source_windows_detail): Remove.
4216
4217 2019-09-20  Tom Tromey  <tromey@adacore.com>
4218
4219         PR ada/24919:
4220         * block.c (contained_in): Fix final return value.
4221
4222 2019-09-20  Alan Modra  <amodra@gmail.com>
4223
4224         * gdb_bfd.c (gdb_bfd_ref, gdb_bfd_unref): Use bfd_set_usrdata.
4225         * dwarf2read.c (dwarf2_read_gdb_index, dwarf2_read_debug_names),
4226         (read_indirect_string_from_dwz): Use bfd accessor.
4227         * dwarf2read.h (struct dwz_file <filename>): Likewise.
4228         * machoread.c (macho_symfile_read_all_oso): Likewise.
4229         * solib.c (solib_bfd_open): Likewise.
4230
4231 2019-09-19  Christian Biesinger  <cbiesinger@google.com>
4232
4233         * eval.c: Move declaration of overload_resolution to...
4234         * value.h: ...here.
4235
4236 2019-09-19  Christian Biesinger  <cbiesinger@google.com>
4237
4238         * arm-linux-nat.c: Remove extern declaration for arm_apcs_32.
4239         * arm-linux-tdep.c: Likewise.
4240         * arm-nbsd-nat.c: Likewise.
4241         * arm-tdep.h: Declare arm_apcs_32.
4242         * arm-tdep.c: Move documentation for arm_apcs_32 to arm-tdep.h.
4243
4244 2019-09-19  Christian Biesinger  <cbiesinger@google.com>
4245
4246         * dwarf2loc.c: Remove extern declaration of dwarf_always_disassemble.
4247         * dwarf2read.h: Declare dwarf_always_disassemble.
4248
4249 2019-09-19  Tom de Vries  <tdevries@suse.de>
4250
4251         PR gdb/25009
4252         * source-cache.c (source_cache::ensure): Catch exception thrown during
4253         construction of the highlighter.
4254
4255 2019-09-18  Alan Modra  <amodra@gmail.com>
4256
4257         * aarch64-linux-tdep.c, * arm-tdep.c, * auto-load.c,
4258         * coff-pe-read.c, * coffread.c, * corelow.c, * dbxread.c,
4259         * dicos-tdep.c, * dwarf2-frame.c, * dwarf2read.c, * elfread.c,
4260         * exec.c, * fbsd-tdep.c, * gcore.c, * gdb_bfd.c, * gdb_bfd.h,
4261         * hppa-tdep.c, * i386-cygwin-tdep.c, * i386-fbsd-tdep.c,
4262         * i386-linux-tdep.c, * jit.c, * linux-tdep.c, * machoread.c,
4263         * maint.c, * mdebugread.c, * minidebug.c, * mips-linux-tdep.c,
4264         * mips-sde-tdep.c, * mips-tdep.c, * mipsread.c, * nto-tdep.c,
4265         * objfiles.c, * objfiles.h, * osabi.c, * ppc-linux-tdep.c,
4266         * ppc64-tdep.c, * record-btrace.c, * record-full.c, * remote.c,
4267         * rs6000-aix-tdep.c, * rs6000-tdep.c, * s390-linux-tdep.c,
4268         * s390-tdep.c, * solib-aix.c, * solib-dsbt.c, * solib-frv.c,
4269         * solib-spu.c, * solib-svr4.c, * solib-target.c,
4270         * spu-linux-nat.c, * spu-tdep.c, * symfile-mem.c, * symfile.c,
4271         * symmisc.c, * symtab.c, * target.c, * windows-nat.c,
4272         * xcoffread.c, * cli/cli-dump.c, * compile/compile-object-load.c,
4273         * mi/mi-interp.c: Update throughout for bfd section macro and
4274         function changes.
4275         * gcore (gcore_create_callback): Use bfd_set_section_lma.
4276         * spu-tdep.c (spu_overlay_new_objfile): Likewise.
4277
4278 2019-09-18  Tom Tromey  <tom@tromey.com>
4279
4280         * NEWS: Add entry.
4281         * tui/tui.c (tui_initialize_readline): Set name of keymap.  Do not
4282         call rl_initialize.
4283         (tui_enable): Do not call rl_initialize.
4284
4285 2019-09-18  Christian Groessler  <chris@groessler.org>
4286
4287         * alpha-linux-nat.c: Include gdbarch.h.
4288
4289 2019-09-18  Simon Marchi  <simon.marchi@polymtl.ca>
4290
4291         * ui-file.c: Include cli/cli-style.h.
4292         (term_cli_styling): Remove cli_styling declaration.
4293
4294 2019-09-18  Alan Modra  <amodra@gmail.com>
4295
4296         * arm-tdep.c (arm_record_special_symbol): Update bfd_get_section
4297         to bfd_asymbol_section.
4298
4299 2019-09-18  Alan Modra  <amodra@gmail.com>
4300
4301         * amd64-dicos-tdep.c (amd64_dicos_osabi_sniffer): Constify target.
4302         * i386-cygwin-tdep.c (i386_cygwin_init_abi): Likewise.
4303         * i386-dicos-tdep.c (i386_dicos_osabi_sniffer): Likewise.
4304
4305 2019-09-18  Alan Modra  <amodra@gmail.com>
4306
4307         * solib-spu.c (spu_bfd_open): Use bfd_set_filename.
4308         * spu-linux-nat.c (spu_bfd_open): Likewise.
4309
4310 2019-09-18  Christian Biesinger  <cbiesinger@google.com>
4311
4312         * dwarf2loc.c: Change extern declaration of dwarf_always_disassemble
4313         to bool to match definition in dwarf2read.c.
4314
4315 2019-09-17  Christian Biesinger  <cbiesinger@google.com>
4316
4317         * ada-lang.c (ada_ignore_descriptive_types_p): Change to bool.
4318         (print_signatures): Likewise.
4319         (trust_pad_over_xvs): Likewise.
4320         * arch/aarch64-insn.c (aarch64_debug): Likewise.
4321         * arch/aarch64-insn.h (aarch64_debug): Likewise.
4322         * arm-linux-nat.c (arm_apcs_32): Likewise.
4323         * arm-linux-tdep.c (arm_apcs_32): Likewise.
4324         * arm-nbsd-nat.c (arm_apcs_32): Likewise.
4325         * arm-tdep.c (arm_debug): Likewise.
4326         (arm_apcs_32): Likewise.
4327         * auto-load.c (debug_auto_load): Likewise.
4328         (auto_load_gdb_scripts): Likewise.
4329         (global_auto_load): Likewise.
4330         (auto_load_local_gdbinit): Likewise.
4331         (auto_load_local_gdbinit_loaded): Likewise.
4332         * auto-load.h (global_auto_load): Likewise.
4333         (auto_load_local_gdbinit): Likewise.
4334         (auto_load_local_gdbinit_loaded): Likewise.
4335         * breakpoint.c (disconnected_dprintf): Likewise.
4336         (breakpoint_proceeded): Likewise.
4337         (automatic_hardware_breakpoints): Likewise.
4338         (always_inserted_mode): Likewise.
4339         (target_exact_watchpoints): Likewise.
4340         (_initialize_breakpoint): Update.
4341         * breakpoint.h (target_exact_watchpoints): Change to bool.
4342         * btrace.c (maint_btrace_pt_skip_pad): Likewise.
4343         * cli/cli-cmds.c (trace_commands): Likewise.
4344         * cli/cli-cmds.h (trace_commands): Likewise.
4345         * cli/cli-decode.c (add_setshow_boolean_cmd): Change int* argument
4346         to bool*.
4347         * cli/cli-logging.c (logging_overwrite): Change to bool.
4348         (logging_redirect): Likewise.
4349         (debug_redirect): Likewise.
4350         * cli/cli-option.h (option_def) <boolean>: Change return type to bool*.
4351         (struct boolean_option_def) <get_var_address_cb_>: Change return type
4352         to bool.
4353         <boolean_option_def>: Update.
4354         (struct flag_option_def): Change default type of Context to bool
4355         from int.
4356         <flag_option_def>: Change return type of var_address_cb_ to bool*.
4357         * cli/cli-setshow.c (do_set_command): Cast to bool* instead of int*.
4358         (get_setshow_command_value_string): Likewise.
4359         * cli/cli-style.c (cli_styling): Change to bool.
4360         (source_styling): Likewise.
4361         * cli/cli-style.h (source_styling): Likewise.
4362         (cli_styling): Likewise.
4363         * cli/cli-utils.h (struct qcs_flags) <quiet, cont, silent>: Change
4364         to bool.
4365         * command.h (var_types): Update comment.
4366         (add_setshow_boolean_cmd): Change int* var argument to bool*.
4367         * compile/compile-cplus-types.c (debug_compile_cplus_types): Change to
4368         bool.
4369         (debug_compile_cplus_scopes): Likewise.
4370         * compile/compile-internal.h (compile_debug): Likewise.
4371         * compile/compile.c (compile_debug): Likewise.
4372         (struct compile_options) <raw>: Likewise.
4373         * cp-support.c (catch_demangler_crashes): Likewise.
4374         * cris-tdep.c (usr_cmd_cris_version_valid): Likewise.
4375         (usr_cmd_cris_dwarf2_cfi): Likewise.
4376         * csky-tdep.c (csky_debug): Likewise.
4377         * darwin-nat.c (enable_mach_exceptions): Likewise.
4378         * dcache.c (dcache_enabled_p): Likewise.
4379         * defs.h (info_verbose): Likewise.
4380         * demangle.c (demangle): Likewise.
4381         (asm_demangle): Likewise.
4382         * dwarf-index-cache.c (debug_index_cache): Likewise.
4383         * dwarf2-frame.c (dwarf2_frame_unwinders_enabled_p): Likewise.
4384         * dwarf2-frame.h (dwarf2_frame_unwinders_enabled_p): Likewise.
4385         * dwarf2read.c (check_physname): Likewise.
4386         (use_deprecated_index_sections): Likewise.
4387         (dwarf_always_disassemble): Likewise.
4388         * eval.c (overload_resolution): Likewise.
4389         * event-top.c (set_editing_cmd_var): Likewise.
4390         (exec_done_display_p): Likewise.
4391         * event-top.h (set_editing_cmd_var): Likewise.
4392         (exec_done_display_p): Likewise.
4393         * exec.c (write_files): Likewise.
4394         * fbsd-nat.c (debug_fbsd_lwp): Likewise
4395         (debug_fbsd_nat): Likewise.
4396         * frame.h (struct frame_print_options) <print_raw_frame_arguments>:
4397         Likewise.
4398         (struct set_backtrace_options) <backtrace_past_main>: Likewise.
4399         <backtrace_past_entry> Likewise.
4400         * gdb-demangle.h (demangle): Likewise.
4401         (asm_demangle): Likewise.
4402         * gdb_bfd.c (bfd_sharing): Likewise.
4403         * gdbcore.h (write_files): Likewise.
4404         * gdbsupport/common-debug.c (show_debug_regs): Likewise.
4405         * gdbsupport/common-debug.h (show_debug_regs): Likewise.
4406         * gdbthread.h (print_thread_events): Likewise.
4407         * gdbtypes.c (opaque_type_resolution): Likewise.
4408         (strict_type_checking): Likewise.
4409         * gnu-nat.c (gnu_debug_flag): Likewise.
4410         * guile/scm-auto-load.c (auto_load_guile_scripts): Likewise.
4411         * guile/scm-param.c (pascm_variable): Add boolval.
4412         (add_setshow_generic): Update.
4413         (pascm_param_value): Update.
4414         (pascm_set_param_value_x): Update.
4415         * hppa-tdep.c (hppa_debug): Change to bool..
4416         * infcall.c (may_call_functions_p): Likewise.
4417         (coerce_float_to_double_p): Likewise.
4418         (unwind_on_signal_p): Likewise.
4419         (unwind_on_terminating_exception_p): Likewise.
4420         * infcmd.c (startup_with_shell): Likewise.
4421         * inferior.c (print_inferior_events): Likewise.
4422         * inferior.h (startup_with_shell): Likewise.
4423         (print_inferior_events): Likewise.
4424         * infrun.c (step_stop_if_no_debug): Likewise.
4425         (detach_fork): Likewise.
4426         (debug_displaced): Likewise.
4427         (disable_randomization): Likewise.
4428         (non_stop): Likewise.
4429         (non_stop_1): Likewise.
4430         (observer_mode): Likewise.
4431         (observer_mode_1): Likewise.
4432         (set_observer_mode): Update.
4433         (sched_multi): Change to bool.
4434         * infrun.h (debug_displaced): Likewise.
4435         (sched_multi): Likewise.
4436         (step_stop_if_no_debug): Likewise.
4437         (non_stop): Likewise.
4438         (disable_randomization): Likewise.
4439         * linux-tdep.c (use_coredump_filter): Likewise.
4440         (dump_excluded_mappings): Likewise.
4441         * linux-thread-db.c (auto_load_thread_db): Likewise.
4442         (check_thread_db_on_load): Likewise.
4443         * main.c (captured_main_1): Update.
4444         * maint-test-options.c (struct test_options_opts) <flag_opt, xx1_opt,
4445         xx2_opt, boolean_opt>: Change to bool.
4446         * maint-test-settings.c (maintenance_test_settings_boolean): Likewise.
4447         * maint.c (maintenance_profile_p): Likewise.
4448         (per_command_time): Likewise.
4449         (per_command_space): Likewise.
4450         (per_command_symtab): Likewise.
4451         * memattr.c (inaccessible_by_default): Likewise.
4452         * mi/mi-main.c (mi_async): Likewise.
4453         (mi_async_1): Likewise.
4454         * mips-tdep.c (mips64_transfers_32bit_regs_p): Likewise.
4455         * nat/fork-inferior.h (startup_with_shell): Likewise.
4456         * nat/linux-namespaces.c (debug_linux_namespaces): Likewise.
4457         * nat/linux-namespaces.h (debug_linux_namespaces): Likewise.
4458         * nios2-tdep.c (nios2_debug): Likewise.
4459         * or1k-tdep.c (or1k_debug): Likewise.
4460         * parse.c (parser_debug): Likewise.
4461         * parser-defs.h (parser_debug): Likewise.
4462         * printcmd.c (print_symbol_filename): Likewise.
4463         * proc-api.c (procfs_trace): Likewise.
4464         * python/py-auto-load.c (auto_load_python_scripts): Likewise.
4465         * python/py-param.c (union parmpy_variable): Add "bool boolval" field.
4466         (set_parameter_value): Update.
4467         (add_setshow_generic): Update.
4468         * python/py-value.c (copy_py_bool_obj): Change argument from int*
4469         to bool*.
4470         * python/python.c (gdbpy_parameter_value): Cast to bool* instead of
4471         int*.
4472         * ravenscar-thread.c (ravenscar_task_support): Change to bool.
4473         * record-btrace.c (record_btrace_target::store_registers): Update.
4474         * record-full.c (record_full_memory_query): Change to bool.
4475         (record_full_stop_at_limit): Likewise.
4476         * record-full.h (record_full_memory_query): Likewise.
4477         * remote-notif.c (notif_debug): Likewise.
4478         * remote-notif.h (notif_debug): Likewise.
4479         * remote.c (use_range_stepping): Likewise.
4480         (interrupt_on_connect): Likewise.
4481         (remote_break): Likewise.
4482         * ser-tcp.c (tcp_auto_retry): Likewise.
4483         * ser-unix.c (serial_hwflow): Likewise.
4484         * skip.c (debug_skip): Likewise.
4485         * solib-aix.c (solib_aix_debug): Likewise.
4486         * spu-tdep.c (spu_stop_on_load_p): Likewise.
4487         (spu_auto_flush_cache_p): Likewise.
4488         * stack.c (struct backtrace_cmd_options) <full, no_filters, hide>:
4489         Likewise.
4490         (struct info_print_options) <quiet>: Likewise.
4491         * symfile-debug.c (debug_symfile): Likewise.
4492         * symfile.c (auto_solib_add): Likewise.
4493         (separate_debug_file_debug): Likewise.
4494         * symfile.h (auto_solib_add): Likewise.
4495         (separate_debug_file_debug): Likewise.
4496         * symtab.c (basenames_may_differ): Likewise.
4497         (struct filename_partial_match_opts) <dirname, basename>: Likewise.
4498         (struct info_print_options) <quiet, exclude_minsyms>: Likewise.
4499         (struct info_types_options) <quiet>: Likewise.
4500         * symtab.h (demangle): Likewise.
4501         (basenames_may_differ): Likewise.
4502         * target-dcache.c (stack_cache_enabled_1): Likewise.
4503         (code_cache_enabled_1): Likewise.
4504         * target.c (trust_readonly): Likewise.
4505         (may_write_registers): Likewise.
4506         (may_write_memory): Likewise.
4507         (may_insert_breakpoints): Likewise.
4508         (may_insert_tracepoints): Likewise.
4509         (may_insert_fast_tracepoints): Likewise.
4510         (may_stop): Likewise.
4511         (auto_connect_native_target): Likewise.
4512         (target_stop_and_wait): Update.
4513         (target_async_permitted): Change to bool.
4514         (target_async_permitted_1): Likewise.
4515         (may_write_registers_1): Likewise.
4516         (may_write_memory_1): Likewise.
4517         (may_insert_breakpoints_1): Likewise.
4518         (may_insert_tracepoints_1): Likewise.
4519         (may_insert_fast_tracepoints_1): Likewise.
4520         (may_stop_1): Likewise.
4521         * target.h (target_async_permitted): Likewise.
4522         (may_write_registers): Likewise.
4523         (may_write_memory): Likewise.
4524         (may_insert_breakpoints): Likewise.
4525         (may_insert_tracepoints): Likewise.
4526         (may_insert_fast_tracepoints): Likewise.
4527         (may_stop): Likewise.
4528         * thread.c (struct info_threads_opts) <show_global_ids>: Likewise.
4529         (make_thread_apply_all_options_def_group): Change argument from int*
4530         to bool*.
4531         (thread_apply_all_command): Update.
4532         (print_thread_events): Change to bool.
4533         * top.c (confirm): Likewise.
4534         (command_editing_p): Likewise.
4535         (history_expansion_p): Likewise.
4536         (write_history_p): Likewise.
4537         (info_verbose): Likewise.
4538         * top.h (confirm): Likewise.
4539         (history_expansion_p): Likewise.
4540         * tracepoint.c (disconnected_tracing): Likewise.
4541         (circular_trace_buffer): Likewise.
4542         * typeprint.c (print_methods): Likewise.
4543         (print_typedefs): Likewise.
4544         * utils.c (debug_timestamp): Likewise.
4545         (sevenbit_strings): Likewise.
4546         (pagination_enabled): Likewise.
4547         * utils.h (sevenbit_strings): Likewise.
4548         (pagination_enabled): Likewise.
4549         * valops.c (overload_resolution): Likewise.
4550         * valprint.h (struct value_print_options) <prettyformat_arrays,
4551         prettyformat_structs, vtblprint, unionprint, addressprint, objectprint,
4552         stop_print_at_null, print_array_indexes, deref_ref, static_field_print,
4553         pascal_static_field_print, raw, summary, symbol_print, finish_print>:
4554         Likewise.
4555         * windows-nat.c (new_console): Likewise.
4556         (cygwin_exceptions): Likewise.
4557         (new_group): Likewise.
4558         (debug_exec): Likewise.
4559         (debug_events): Likewise.
4560         (debug_memory): Likewise.
4561         (debug_exceptions): Likewise.
4562         (useshell): Likewise.
4563         * windows-tdep.c (maint_display_all_tib): Likewise.
4564         * xml-support.c (debug_xml): Likewise.
4565
4566 2019-09-17  Mike Gulick  <mgulick@mathworks.com>
4567
4568         * source.c (prepare_path_for_appending): New function.
4569         (openp): Make use of new function.
4570         (find_and_open_source): Search for the compilation directory and
4571         source file as a relative path beneath the directory search path.
4572
4573 2019-09-17  Andrew Burgess  <andrew.burgess@embecosm.com>
4574
4575         * source-cache.c (source_cache::get_line_charpos): Catch
4576         exceptions and return false, this matches the behaviour documented
4577         in the header file.
4578
4579 2019-09-17  Joel Brobecker  <brobecker@adacore.com>
4580
4581         * ada-tasks.c (info_task): Remove quoting of the task's name.
4582
4583 2019-09-16  Christian Biesinger  <cbiesinger@google.com>
4584
4585         * symfile.c (auto_solib_add): Replace comment with a reference
4586         to the header file.
4587
4588 2019-09-14  Christian Biesinger  <cbiesinger@google.com>
4589
4590         * NEWS: Mention that gdb can now be compiled with Python 3
4591         on Windows.
4592
4593 2019-09-12  Andrew Burgess  <andrew.burgess@embecosm.com>
4594
4595         * maint.c (maint_print_section_data::maint_print_section_data):
4596         Force use of 'float log10 (float)' by casting the argument to
4597         float.
4598
4599 2019-09-12  Andrew Burgess  <andrew.burgess@embecosm.com>
4600
4601         * maint.c: Add 'cmath' include.
4602         (struct maint_print_section_data): New structure.
4603         (print_section_index): New function.
4604         (print_bfd_section_info): Add header comment, small whitespace
4605         cleanup, and update to call new print_section_index function.
4606         (print_objfile_section_info): Likewise.
4607         (maint_obj_section_from_bfd_section): New function.
4608         (print_bfd_section_info_maybe_relocated): New function.
4609         (maintenance_info_sections): Add header comment, always use
4610         bfd_map_over_sections instead of ALL_OBJFILE_OSECTIONS.
4611
4612 2019-09-12  Andrew Burgess  <andrew.burgess@embecosm.com>
4613
4614         * psymtab.c (find_pc_sect_psymtab): Move baseaddr local into more
4615         inner scope, add check that the objfile has psymtabs before
4616         checking psymtabs_addrmap.
4617         * psymtab.h (psymtab_storage) <psymtabs_addrmap>: Extend comment.
4618
4619 2019-09-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4620
4621         * NEWS: Announce that Ada task names are now shown at more places,
4622         and between quotes (except in info task output).
4623         * gdb/ada-tasks.c (task_to_str): New function.
4624         (display_current_task_id): Call task_to_str.
4625         (task_command_1): Likewise.
4626         (print_ada_task_info): In non-mi mode, Properly align headers and data
4627         when task-id length is > 9 (9 is the default for a 32 bits CORE_ADDR).
4628
4629 2019-09-12  Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
4630
4631         * procfs.c (procfs_target::wait) <PR_FAULTED>: Get signal from
4632         prstatus.pr_lwp.pr_info instead of making it up.
4633
4634 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
4635
4636         * auto-load.c (auto_load_expand_dir_vars): Update.
4637         * defs.h (gdb_datadir): Change to std::string.
4638         (python_libdir): Likewise.
4639         (relocate_gdb_directory): Change return type to std::string.
4640         * guile/guile.c (gdbscm_data_directory): Update.
4641         (initialize_scheme_side): Update.
4642         * jit.c (jit_reader_dir): Change to std::string.
4643         (jit_reader_load_command): Update.
4644         * main.c (gdb_datadir): Change to std::string.
4645         (python_libdir): Likewise.
4646         (set_gdb_data_directory): Update.
4647         (relocate_path): Change to return std::string.
4648         (relocate_gdb_directory): Change to return std::string.
4649         (relocate_gdbinit_path_maybe_in_datadir): Update.
4650         (captured_main_1): Update.
4651         * python/python.c (do_start_initialization): Update.
4652         * top.c (show_gdb_datadir): Update.
4653         * xml-syscall.c (xml_init_syscalls_info): Update.
4654         (init_syscalls_info): Update.
4655
4656 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
4657
4658         * main.c (relocate_gdbinit_path_maybe_in_datadir): Factor this code
4659         out of get_init_files.
4660         (get_init_files): Update.
4661
4662 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
4663
4664         * main.c (get_init_files): Change to use std::string.
4665         (captured_main_1): Update.
4666         (print_gdb_help): Update.
4667
4668 2019-09-11  Ali Tamur  <tamur@google.com>
4669
4670         *gdb/target-float.c (host_float_ops<T>::to_longest): Update
4671         implementation.
4672
4673 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
4674
4675         * dbxread.c (read_dbx_symtab): Update.
4676         * dwarf2read.c (load_partial_dies): Update.
4677         * mdebugread.c (parse_partial_symbols): Update.
4678         (handle_psymbol_enumerators): Update.
4679         * psympriv.h (add_psymbol_to_list): Change type of copy_names to bool.
4680         * psymtab.c (add_psymbol_to_bcache): Likewise.
4681         (add_psymbol_to_list): Likewise.
4682         * symtab.c (symbol_set_names): Likewise.
4683         * symtab.h (symbol_set_names): Likewise.
4684         * xcoffread.c (scan_xcoff_symtab): Update.
4685
4686 2019-09-11  Tom Tromey  <tom@tromey.com>
4687
4688         * symfile-mem.c (symbol_file_add_from_memory): Use
4689         bfd_set_filename.
4690         * solib-darwin.c (darwin_bfd_open): Use bfd_set_filename.
4691         * solib-aix.c (solib_aix_bfd_open): Use bfd_set_filename.
4692
4693 2019-09-10  Tom Tromey  <tromey@adacore.com>
4694
4695         * dwarf-index-write.c (write_psymbols): Extend error message.
4696         (debug_names::insert): Add Ada code.
4697         (debug_names::write_psymbols): Remove Ada check.
4698         (debug_names) <m_string_obstack>: New member.
4699         * dwarf2read.c (gdb_index_symbol_name_matcher): Remove.
4700         (gdb_index_symbol_name_matcher::matches): Remove.
4701         (mapped_index_base::find_name_components_bounds): Add "lang"
4702         parameter.
4703         (mapped_index_base::build_name_components): Also split names
4704         according to Ada syntax.
4705         (dw2_expand_symtabs_matching_symbol): Loop over languages.  Change
4706         type of "match_callback".
4707         (check_match, check_find_bounds_finds)
4708         (dw2_expand_symtabs_matching): Update.
4709         (dw2_debug_names_iterator): Add new constructor.
4710         (dw2_debug_names_map_matching_symbols): New function.
4711         (dw2_debug_names_expand_symtabs_matching): Update.
4712         (dwarf2_debug_names_functions): Use
4713         dw2_debug_names_map_matching_symbols.
4714
4715 2019-09-10  Tom Tromey  <tromey@adacore.com>
4716
4717         * dwarf2read.c (dw2_get_file_names_reader): Add the
4718         CU's file name to the results.
4719
4720 2019-09-10  Tom Tromey  <tromey@adacore.com>
4721
4722         * ada-lang.c (add_nonlocal_symbols): Combine calls to
4723         map_matching_symbols.  Update.
4724         * dwarf2read.c (dw2_map_matching_symbols): Update.
4725         * psymtab.c (match_partial_symbol): Change type; update.
4726         (psym_map_matching_symbols): Likewise.
4727         * symfile-debug.c (debug_qf_map_matching_symbols): Change
4728         type; update.
4729         * symfile.h (struct quick_symbol_functions)
4730         <map_matching_symbols>: Change "name" to be a lookup_name_info.
4731         Remove "match".
4732
4733 2019-09-10  Tom Tromey  <tromey@adacore.com>
4734
4735         * psymtab.c (map_block): Remove.
4736         (psym_map_matching_symbols): Use iterate_over_symbols_terminated.
4737         * symtab.c (iterate_over_symbols_terminated): New function.
4738         * symtab.c (iterate_over_symbols_terminated): Declare.
4739
4740 2019-09-10  Tom Tromey  <tromey@adacore.com>
4741
4742         * ada-lang.c (ada_iterate_over_symbols): Return bool.
4743         * language.h (struct language_defn) <la_iterate_over_symbols>:
4744         Return bool.
4745         * symtab.c (iterate_over_symbols): Return bool.
4746         * symtab.h (iterate_over_symbols): Return bool.
4747
4748 2019-09-10  Tom Tromey  <tromey@adacore.com>
4749
4750         * ada-lang.c (aux_add_nonlocal_symbols): Change type.
4751         (add_nonlocal_symbols): Update.
4752         * dwarf2read.c (dw2_map_matching_symbols): Change type.
4753         * psymtab.c (map_block, psym_map_matching_symbols): Change type.
4754         * symfile-debug.c (debug_qf_map_matching_symbols): Change type.
4755         * symfile.h (struct quick_symbol_functions) <map_matching_symbols>:
4756         Change type of "callback".  Remove "data".
4757
4758
4759 2019-09-09  Ali Tamur  <tamur@google.com>
4760
4761         * dwarf2read.c (comp_unit_head): Update comment.
4762         (dwarf2_dwo_name): New function declaration.
4763         (dwarf_unit_type_name): New function declaration.
4764         (read_comp_unit_head): Add support for new compilation units,
4765         DW_UT_partial, DW_UT_skeleton, DW_UT_split_compile, DW_UT_split_type.
4766         Particularly, DW_UT_skeleton and DW_UT_split_compile have dwo_id
4767         (currently named as "signature") in their header. Also clarify error
4768         messages.
4769         (lookup_dwo_id): New function. Returns the dwo id of the given
4770         compile unit.
4771         (lookup_dwo_unit): Use the new lookup_dwo_id function.
4772         (init_cutu_and_read_dies): Use the new dwarf2_dwo_name and lookup_dwo_id
4773         functions.
4774         (create_dwo_cu_reader): Use the added lookup_dwo_id function.
4775         (dwarf2_dwo_name): Get the dwo name if present.
4776         (dwarf_unit_type_name): Convert DW_UT_* types to string for diagnostic
4777         purposes.
4778
4779 2019-09-09  Tom Tromey  <tom@tromey.com>
4780
4781         * tui/tui-win.c (tui_all_windows_info): Use ui_out.
4782
4783 2019-09-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4784
4785         * python/python.c (do_start_initialization): Make progname_copy static,
4786         to avoid a leak report.
4787
4788 2019-09-08  Tom Tromey  <tom@tromey.com>
4789
4790         * tui/tui-wingeneral.c (box_win): Truncate long window titles.
4791
4792 2019-09-07  Simon Marchi  <simon.marchi@efficios.com>
4793
4794         * dwarf2read.c (struct dw2_symtab_iterator) <block_index>:
4795         Change type to gdb::optional<block_enum>.
4796         (dw2_symtab_iter_init): Change block_index parameter type
4797         to gdb::optional<block_enum>.
4798         (dw2_lookup_symbol): Change block_index parameter
4799         type to block_enum.c
4800         (dw2_debug_names_lookup_symbol): Likewise.
4801         * psymtab.c (psym_lookup_symbol): Likewise.
4802         * symfile-debug.c (debug_qf_lookup_symbol): Likewise.
4803         * symfile.h (struct quick_symbol_functions) <lookup_symbol>:
4804         Likewise.
4805
4806 2019-09-06  Christian Biesinger  <cbiesinger@google.com>
4807
4808         * defs.h (relocate_gdb_directory): Change int to bool in
4809         signature and rename flag to relocatable.
4810         * main.c (relocate_path): Likewise.
4811         (relocate_gdb_directory): Likewise.
4812
4813 2019-09-06  Alan Modra  <amodra@gmail.com>
4814
4815         * coffread.c (coff_symfile_read): Constify filename variable.
4816         * dbxread.c (dbx_symfile_init, coffstab_build_psymtabs),
4817         (elfstab_build_psymtabs, stabsect_build_psymtabs): Likewise.
4818         * gdb_bfd.c (gdb_bfd_close_or_warn): Likewise.
4819         * solib.c (reload_shared_libraries_1): Likewise.
4820         * symfile.c (reread_symbols): Likewise.
4821         * solib-aix.c (solib_aix_bfd_open): Add cast for xfree of filename.
4822         * solib-darwin.c (darwin_bfd_open): Likewise.
4823         * symfile-mem.c (symbol_file_add_from_memory): Likewise.
4824
4825 2019-09-03  Andrew Burgess  <andrew.burgess@embecosm.com>
4826
4827         * psymtab.c (print_partial_symbols): Handle missing domain_enum
4828         values MODULE_DOMAIN and COMMON_BLOCK_DOMAIN.
4829
4830 2019-09-03  Tom Tromey  <tromey@adacore.com>
4831
4832         * ada-valprint.c (ada_val_print_num): Don't recurse for range
4833         types.
4834         (has_negatives): Unbias a range type bound.
4835         * dwarf2read.c (read_subrange_type): Handle DW_AT_GNU_bias.
4836         * gdbtypes.c (operator==): Handle new field.
4837         (create_range_type): Add "bias" parameter.
4838         (create_static_range_type, resolve_dynamic_range): Update.
4839         * gdbtypes.h (struct range_bounds) <bias>: New member.
4840         (create_range_type): Add bias parameter.
4841         * printcmd.c (print_scalar_formatted): Unbias range types.
4842         * value.c (unpack_long): Unbias range types.
4843         (pack_long): Bias range types.
4844
4845 2019-09-02  Alan Hayward  <alan.hayward@arm.com>
4846
4847         * solib-svr4.c (svr4_find_and_create_probe_breakpoints): Check all
4848         probe arguments.
4849
4850 2019-09-02  Alan Hayward  <alan.hayward@arm.com>
4851
4852         * break-catch-throw.c (fetch_probe_arguments): Use gdbarch.
4853         * dtrace-probe.c (dtrace_probe::get_argument_count): Likewise.
4854         * probe.c (probe_safe_evaluate_at_pc) (compute_probe_arg)
4855         (compile_probe_arg): Likewise.
4856         * probe.h (get_argument_count): Likewise.
4857         * solib-svr4.c (solib_event_probe_action): Likewise.
4858         * stap-probe.c (stap_probe::get_argument_count): Likewise.
4859
4860 2019-09-02  Alan Hayward  <alan.hayward@arm.com>
4861
4862         * solib-svr4.c (svr4_find_and_create_probe_breakpoints): Move
4863         code to here...
4864         (svr4_create_solib_event_breakpoints): ...from here.
4865
4866 2019-08-30  Sergio Durigan Junior  <sergiodj@redhat.com>
4867
4868         * nat/fork-inferior.c (trace_start_error): Remove "\nError: "
4869         suffix from warning message.
4870
4871 2019-08-30  Tom Tromey  <tom@tromey.com>
4872
4873         * tui/tui-winsource.h (struct tui_source_window_base)
4874         <refresh_all>: Don't declare.
4875         * tui/tui-winsource.c (tui_source_window_base::refresh_all):
4876         Remove.
4877         * tui/tui-win.c (tui_refresh_all_win): Don't call refresh_all or
4878         tui_show_locator_content.
4879         * tui/tui-regs.h (struct tui_data_window) <refresh_all>: Don't
4880         declare.
4881         * tui/tui-regs.c (tui_data_window::refresh_all): Remove.
4882         * tui/tui-data.h (struct tui_win_info) <refresh_all>: Don't
4883         declare.
4884
4885 2019-08-30  Tom Tromey  <tom@tromey.com>
4886
4887         * tui/tui-io.c (tui_cont_sig): Don't call wrefresh.
4888
4889 2019-08-30  Tom Tromey  <tom@tromey.com>
4890
4891         * tui/tui-stack.c (_initialize_tui_stack): Move later.
4892         Remove unnecessary forward declarations.
4893
4894 2019-08-30  Tom Tromey  <tom@tromey.com>
4895
4896         * tui/tui-stack.c (tui_locator_window::set_locator_fullname): Call
4897         rerender.
4898         (tui_update_locator_fullname, tui_show_frame_info): Don't call
4899         tui_show_locator_content.
4900
4901 2019-08-30  Tom Tromey  <tom@tromey.com>
4902
4903         * tui/tui-stack.c (tui_show_locator_content): Move lower.  Rewrite.
4904         (tui_locator_window::rerender): Rewrite using body of previous
4905         tui_show_locator_content.
4906
4907 2019-08-30  Tom Tromey  <tom@tromey.com>
4908
4909         * tui/tui-stack.h (struct tui_locator_window) <set_locator_info,
4910         set_locator_fullname>: New methods.
4911         * tui/tui-stack.c (tui_locator_window::set_locator_fullname):
4912         Rename from tui_set_locator_fullname.
4913         (tui_locator_window::set_locator_info): Rename from
4914         tui_set_locator_info.  Return bool.
4915         (tui_update_locator_fullname, tui_show_frame_info): Update.
4916
4917 2019-08-30  Tom Tromey  <tom@tromey.com>
4918
4919         * tui/tui-layout.c (show_layout): Don't call tui_refresh_all.
4920
4921 2019-08-30  Tom Tromey  <tom@tromey.com>
4922
4923         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Don't
4924         call touchwin.
4925
4926 2019-08-30  Tom Tromey  <tom@tromey.com>
4927
4928         * tui/tui-wingeneral.c (box_win): Assume win_info and
4929         win_info->handle cannot be NULL.
4930
4931 2019-08-30  Tom Tromey  <tom@tromey.com>
4932
4933         * tui/tui-regs.h (struct tui_data_item_window) <rerender,
4934         refresh_window>: Declare.
4935         * tui/tui-regs.c (tui_data_window::display_registers_from): Call
4936         resize.
4937         (tui_data_item_window::rerender): Rename from
4938         tui_display_register.
4939         (tui_data_item_window::refresh_window): New method.
4940         * tui/tui-layout.c (tui_gen_win_info::resize): Do nothing on
4941         no-op.
4942
4943 2019-08-30  Tom Tromey  <tom@tromey.com>
4944
4945         * tui/tui-regs.h (struct tui_data_window) <regs_content,
4946         regs_column_count, current_group>: Move later.  Now private.
4947         <get_current_group>: New method.
4948         * tui/tui-regs.c (tui_reg_command): Update.
4949         * tui/tui-layout.c (tui_set_layout): Update.
4950
4951 2019-08-30  Tom Tromey  <tom@tromey.com>
4952
4953         * tui/tui-regs.c (tui_data_window::display_registers_from_line)
4954         (tui_data_window::rerender): Don't call
4955         check_and_display_highlight_if_needed.
4956         (tui_data_window::refresh_all): Remove call to
4957         erase_data_content.
4958
4959 2019-08-30  Tom Tromey  <tom@tromey.com>
4960
4961         * tui/tui-regs.c (tui_data_window::last_regs_line_no)
4962         (tui_data_window::display_registers_from)
4963         (tui_data_window::display_reg_element_at_line)
4964         (tui_data_window::display_registers_from_line): Remove checks of
4965         "empty".
4966
4967 2019-08-30  Tom Tromey  <tom@tromey.com>
4968
4969         * tui/tui-regs.h (struct tui_data_window) <display_all_data>:
4970         Don't declare.
4971         * tui/tui-regs.c (tui_data_window::show_registers): Call
4972         rerender.
4973         (tui_data_window::rerender): Rename from display_all_data.
4974         (tui_data_window::rerender): Remove old implementation.
4975
4976 2019-08-30  Tom Tromey  <tom@tromey.com>
4977
4978         * tui/tui-regs.c (tui_data_window::display_all_data): Change
4979         text.
4980         * tui/tui-data.h (NO_DATA_STRING): Remove define.
4981
4982 2019-08-29  Bernhard Wodok  <barto@gmx.net>
4983             Sergio Durigan Junior  <sergiodj@redhat.com>
4984
4985         PR win32/24284
4986         * mingw-hdep.c (gdb_select): Handle case when 'n' is zero.
4987
4988 2019-08-28  Andrew Burgess  <andrew.burgess@embecosm.com>
4989
4990         * symtab.c (search_symbols): Don't include MODULE_DOMAIN symbols
4991         when searching for types.
4992
4993 2019-08-28  Andrew Burgess  <andrew.burgess@embecosm.com>
4994
4995         * f-lang.c (f_language_defn): Use f_print_typedef.
4996         * f-lang.h (f_print_typedef): Declare.
4997         * f-typeprint.c (f_print_typedef): Define.
4998
4999 2019-08-27  Christian Biesinger  <cbiesinger@google.com>
5000
5001         * nat/linux-namespaces.c (mnsh_main): Initialize fd (to -1).
5002
5003 2019-08-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5004
5005         * cli/cli-utils.c (info_print_options_defs): Delete.
5006         (make_info_print_options_def_group): Delete.
5007         (extract_info_print_options): Delete.
5008         (info_print_command_completer): Delete.
5009         (info_print_args_help): Add extra parameter, and optionally
5010         include text about -n flag.
5011         * cli/cli-utils.h (struct info_print_options): Delete.
5012         (extract_info_print_options): Delete declaration.
5013         (info_print_command_completer): Delete declaration.
5014         (info_print_args_help): Add extra parameter, extend header
5015         comment.
5016         * python/python.c (gdbpy_rbreak): Pass additional parameter to
5017         search_symbols.
5018         * stack.c (struct info_print_options): New type.
5019         (info_print_options_defs): New file scoped variable.
5020         (make_info_print_options_def_group): New static function.
5021         (info_print_command_completer): New static function.
5022         (info_locals_command): Update to use new local functions.
5023         (info_args_command): Likewise.
5024         (_initialize_stack): Add extra parameter to calls to
5025         info_print_args_help.
5026         * symtab.c (search_symbols): Add extra parameter, use this to
5027         possibly excluse non-debug symbols.
5028         (symtab_symbol_info): Add extra parameter, which is passed on to
5029         search_symbols.
5030         (struct info_print_options): New type.
5031         (info_print_options_defs): New file scoped variable.
5032         (make_info_print_options_def_group): New static function.
5033         (info_print_command_completer): New static function.
5034         (info_variables_command): Update to use local functions, and pass
5035         extra parameter through to symtab_symbol_info.
5036         (info_functions_command): Likewise.
5037         (info_types_command): Pass additional argument through to
5038         symtab_symbol_info.
5039         (rbreak_command): Pass extra argument to search_symbols.
5040         (_initialize_symtab): Add extra arguments for calls to
5041         info_print_args_help, and update help text for 'info variables',
5042         'whereis', and 'info functions' commands.
5043         * symtab.h (search_symbols): Add extra argument to declaration.
5044         * NEWS: Mention new flags.
5045
5046 2019-08-26  Christian Biesinger  <cbiesinger@google.com>
5047
5048         * symtab.c (lookup_static_symbol): Call the new function (and move
5049         it down to be next to lookup_global_symbol).
5050         (struct global_sym_lookup_data): Add block_enum member and rename to...
5051         (struct global_or_static_sym_lookup_data): ...this.
5052         (lookup_symbol_global_iterator_cb): Pass block_index instead of
5053         GLOBAL_BLOCK to lookup_symbol_in_objfile and rename to...
5054         (lookup_symbol_global_or_static_iterator_cb): ...this.
5055         (lookup_global_or_static_symbol): New function.
5056         (lookup_global_symbol): Call new function.
5057
5058 2019-08-26  Tom de Vries  <tdevries@suse.de>
5059
5060         PR c++/24852
5061         * break-catch-throw.c (fetch_probe_arguments): Improve error mesage
5062         when pc_probe.prob == NULL.
5063
5064 2019-08-25  Simon Marchi  <simon.marchi@efficios.com>
5065
5066         * dwarf2read.c (dw2_debug_names_iterator::next): Rename local
5067         variable symbol_linkage to symbol_linkage_.
5068
5069 2019-08-25  Simon Marchi  <simon.marchi@efficios.com>
5070
5071         * dwarf2read.c (dw2_debug_names_iterator::next): Use enum to
5072         represent whether the symbol is static, dynamic, or we don't
5073         know.
5074
5075 2019-08-25  Yoshinori Sato <ysato@users.sourceforge.jp>
5076
5077         * gdb/rx-tdep.c (rx_register_names): New.
5078         (rx_register_name): Delete.
5079         (rx_psw_type): Delete.
5080         (rx_fpsw_type): Delete.
5081         (rx_register_type): Delete.
5082         (rx_gdbarch_init): Convert target-descriptions.
5083         (_initialize_rx_tdep): Add initialize_tdesc_rx.
5084         * gdb/features/Makefile: Add rx.xml.
5085         * gdb/features/rx.xml: New.
5086         * gdb/features/rx.c: Generated.
5087         * gdb/NEWS: Mention target description support.
5088
5089 2019-08-22  Christian Biesinger  <cbiesinger@google.com>
5090
5091         * symtab.c (symbol_cache_lookup): Always initialize *bsc_ptr and
5092         *slot_ptr.
5093
5094 2019-08-23  Sergio Durigan Junior  <sergiodj@redhat.com>
5095
5096         * configure.ac: Don't check for 'dlfcn.h' (moved to
5097         gdbsupport/common.m4).
5098         * Makefile.in (COMMON_SFILES): Move 'gdb-dlfcn.c' to
5099         'gdbsupport/'.
5100         (HFILES_NO_SRCDIR): Likewise, for 'gdb-dlfcn.h'.
5101         * compile/compile-c-support.c: Include
5102         'gdbsupport/gdb-dlfcn.h'.
5103         * gdbsupport/common.m4: Check for 'dlfcn.h'.
5104         * gdb-dlfcn.c: Move to...
5105         * gdbsupport/gdb-dlfcn.c: ... here.
5106         * gdb-dlfcn.h: Move to...
5107         * gdbsupport/gdb-dlfcn.h: ... here.
5108
5109 2019-08-23  Sandra Loosemore  <sandra@codesourcery.com>
5110
5111         * nios2-tdep.c (struct reg_value): Improve comments.  Make
5112         the offset field signed.
5113
5114 2019-08-22  Christian Biesinger  <cbiesinger@google.com>
5115
5116         * python/lib/gdb/__init__.py (_execute_file): New function.
5117         * python/python.c (python_run_simple_file): Call gdb._execute_file
5118         on Windows.
5119
5120 2019-08-22  Andrew Burgess  <andrew.burgess@embecosm.com>
5121
5122         * f-exp.y (yylex): Remove is_a_field_of_this local variable, and
5123         all uses as this was never set to anything but a zero value.
5124
5125 2019-08-21  Bogdan Harjoc  <harjoc@gmail.com>
5126
5127         * cli/cli-cmds.c (with_command_1): Error out if no arguments.
5128
5129 2019-08-21  Christian Biesinger  <cbiesinger@google.com>
5130
5131         * tui/tui-data.h (tui_gen_win_info): Add an =default
5132         move constructor, required by some GCC versions.
5133
5134 2019-08-21  Jinke Fan  <fanjinke51@yeah.net>
5135
5136         * go32-nat.c (go32_sysinfo): Add hygon_p.
5137
5138 2019-08-20  Tom Tromey  <tom@tromey.com>
5139
5140         * tui/tui-regs.h (struct tui_data_window) <last_regs_line_no,
5141         line_from_reg_element_no, first_reg_element_no_inline,
5142         display_all_data, delete_data_content_windows,
5143         erase_data_content>: Now private.
5144
5145 2019-08-20  Tom Tromey  <tom@tromey.com>
5146
5147         * tui/tui-wingeneral.c (box_win): Change type of highlight_flag.
5148         (tui_unhighlight_win, tui_highlight_win)
5149         (tui_win_info::make_window): Update.
5150         * tui/tui-data.h (HILITE, NO_HILITE): Remove.
5151
5152 2019-08-20  Tom Tromey  <tom@tromey.com>
5153
5154         * tui/tui-data.h (PROC_PREFIX, LINE_PREFIX, PC_PREFIX)
5155         (MIN_LINE_WIDTH, MIN_PROC_WIDTH, MAX_TARGET_WIDTH)
5156         (MAX_PID_WIDTH): Move to tui-stack.c.
5157         * tui/tui-stack.c (PROC_PREFIX, LINE_PREFIX, PC_PREFIX)
5158         (MIN_LINE_WIDTH, MIN_PROC_WIDTH, MAX_TARGET_WIDTH)
5159         (MAX_PID_WIDTH): Move from tui-data.h.
5160
5161 2019-08-20  Tom Tromey  <tom@tromey.com>
5162
5163         * tui/tui-wingeneral.h (tui_make_window): Don't declare.
5164         * tui/tui-wingeneral.c (box_win): Change type of win_info.
5165         (box_win): Update.
5166         (tui_gen_win_info::make_window): Rename from tui_make_window.
5167         (tui_win_info::make_window): New method.
5168         (tui_gen_win_info::make_visible): Update.
5169         * tui/tui-source.c (tui_source_window::set_contents): Update.
5170         * tui/tui-regs.c (tui_data_window::show_register_group): Update.
5171         (tui_data_window::display_registers_from): Update.
5172         * tui/tui-layout.c (tui_gen_win_info::resize): Update.
5173         * tui/tui-data.h (struct tui_gen_win_info) <make_window>:
5174         Declare.
5175         <can_box>: Remove.
5176         <title>: Remove.
5177         (struct tui_win_info) <make_window>: Declare.
5178         <can_box>: Now virtual.
5179         <title>: New member.
5180         * tui/tui-data.c (~tui_gen_win_info): Don't free title.
5181         * tui/tui-command.c (tui_cmd_window::resize): Update.
5182
5183 2019-08-20  Tom Tromey  <tom@tromey.com>
5184
5185         * tui/tui-regs.h (struct tui_data_window) <display_regs>: Remove.
5186         * tui/tui-regs.c (tui_data_window::show_registers): Update.
5187         (tui_data_window::check_register_values): Update.
5188
5189 2019-08-20  Tom Tromey  <tom@tromey.com>
5190
5191         * tui/tui-regs.h (struct tui_data_window): Use
5192         DISABLE_COPY_AND_ASSIGN.
5193         <regs_content>: Change type, removing unique_ptr.
5194         <tui_data_window>: Add move constructor.
5195         * tui/tui-regs.c (tui_data_window::show_registers)
5196         (tui_data_window::show_register_group)
5197         (tui_data_window::display_registers_from)
5198         (tui_data_window::display_registers_from)
5199         (tui_data_window::first_data_item_displayed)
5200         (tui_data_window::delete_data_content_windows)
5201         (tui_data_window::rerender, tui_data_window::refresh_window)
5202         (tui_data_window::check_register_values): Update.
5203
5204 2019-08-20  Tom Tromey  <tom@tromey.com>
5205
5206         * tui/tui-regs.h (struct tui_data_window) <show_registers,
5207         show_register_group>: Declare.
5208         (tui_show_register_group): Don't declare.
5209         * tui/tui-regs.c (tui_data_window::show_registers): Rename from
5210         tui_show_registers.
5211         (tui_data_window::show_register_group): Rename from
5212         tui_show_register_group.
5213         (tui_data_window::check_register_values, tui_reg_command):
5214         Update.
5215         * tui/tui-layout.c (tui_set_layout): Update.
5216
5217 2019-08-20  Tom Tromey  <tom@tromey.com>
5218
5219         * tui/tui-regs.h (struct tui_data_window) <check_register_values>:
5220         Declare.
5221         (tui_check_register_values): Don't declare.
5222         * tui/tui-regs.c (tui_data_window::check_register_values): Rename
5223         from tui_check_register_values.
5224         * tui/tui-hooks.c (tui_register_changed): Update.
5225
5226 2019-08-20  Tom Tromey  <tom@tromey.com>
5227
5228         * tui/tui-regs.c (tui_reg_layout): Move later.
5229         (tui_show_registers): Don't enable TUI mode or change layout.
5230
5231 2019-08-20  Tom Tromey  <tom@tromey.com>
5232
5233         * tui/tui-regs.h (struct tui_data_item_window)
5234         <~tui_data_item_window>: Remove.
5235         <content>: Now a unique_xmalloc_ptr.
5236         * tui/tui-regs.c (tui_register_format): Return a
5237         unique_xmalloc_ptr.
5238         (tui_get_register): Update.
5239         (~tui_data_item_window): Remove.
5240         (tui_data_window::display_registers_from, tui_display_register):
5241         Update.
5242         * tui/tui-io.h (tui_expand_tabs): Update.
5243         * tui/tui-io.c (tui_expand_tabs): Return a unique_xmalloc_ptr.
5244         Remove "col" parameter.
5245
5246 2019-08-20  Tom Tromey  <tom@tromey.com>
5247
5248         * tui/tui-regs.h (struct tui_data_item_window) <value>: Remove
5249         field.
5250         * tui/tui-regs.c (~tui_data_item_window): Update.
5251
5252 2019-08-20  Tom Tromey  <tom@tromey.com>
5253
5254         * tui/tui-regs.c (tui_register_format, tui_get_register): Move
5255         earlier.
5256
5257 2019-08-20  Tom Tromey  <tom@tromey.com>
5258
5259         * tui/tui-regs.c (tui_reg_command): Remove NULL check.
5260
5261 2019-08-20  Tom Tromey  <tom@tromey.com>
5262
5263         * tui/tui-source.h (struct tui_source_window): Update.
5264         * tui/tui-regs.c (tui_show_registers): Update.
5265         * tui/tui-disasm.h (struct tui_disasm_window): Update.
5266         * tui/tui-data.h (NO_SRC_STRING, NO_DISASSEM_STRING)
5267         (NO_REGS_STRING): Remove defines.
5268
5269 2019-08-20  Conrad Meyer  <cem@FreeBSD.org>
5270
5271         * remote.c (remote_target::remote_btrace_maybe_reopen): Avoid
5272         unnecessary thread walk if remote doesn't support the packet.
5273
5274 2019-08-19  Tom Tromey  <tromey@adacore.com>
5275
5276         * python/py-value.c (value_has_field): Fix indentation.
5277
5278 2019-08-19  Tom Tromey  <tromey@adacore.com>
5279
5280         * printcmd.c (do_one_display, info_display_command): Update.
5281         * block.h (contained_in): Return bool.  Add allow_nested
5282         parameter.
5283         * block.c (contained_in): Return bool.  Add allow_nested
5284         parameter.
5285
5286 2019-08-19  Tom Tromey  <tom@tromey.com>
5287
5288         * configure: Rebuild.
5289         * configure.ac: Disallow the combination of -static-libstdc++ and
5290         source highlight.
5291         * source-cache.c (get_language_name): Handle rust.
5292         (source_cache::get_source_lines): Ignore highlighting exceptions.
5293
5294 2019-08-16  Tom Tromey  <tom@tromey.com>
5295
5296         * tui/tui.h (enum tui_win_type) <EXEC_INFO_WIN>: Remove.
5297         * tui/tui-winsource.h (struct tui_exec_info_window): Remove.
5298         (struct tui_source_window_base) <make_visible, refresh_window,
5299         resize>: Remove methods.
5300         <execution_info>: Remove field.
5301         * tui/tui-winsource.c (tui_source_window_base::do_erase_source_content)
5302         (tui_show_source_line, tui_source_window_base)
5303         (~tui_source_window_base): Update.
5304         (tui_source_window_base::resize)
5305         (tui_source_window_base::make_visible)
5306         (tui_source_window_base::refresh_window): Remove.
5307         (tui_source_window_base::update_exec_info): Update.
5308         * tui/tui-source.c (tui_source_window::set_contents): Update.
5309         * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
5310
5311 2019-08-16  Tom Tromey  <tom@tromey.com>
5312
5313         * tui/tui-hooks.c (tui_remove_hooks): Don't set
5314         deprecated_query_hook.
5315
5316 2019-08-16  Tom Tromey  <tom@tromey.com>
5317
5318         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
5319         (tui_update_source_windows_with_line): Update.
5320         * tui/tui-source.h (struct tui_source_window)
5321         <show_symtab_source>: Declare.
5322         (tui_show_symtab_source): Don't declare.
5323         * tui/tui-source.c (tui_show_symtab_source): Rename from
5324         tui_show_symtab_source.
5325
5326 2019-08-16  Tom Tromey  <tom@tromey.com>
5327
5328         * tui/tui-winsource.h (struct tui_source_window_base)
5329         <set_contents>: Declare.
5330         * tui/tui-winsource.c
5331         (tui_source_window_base::update_source_window_as_is): Update.
5332         * tui/tui-source.h (struct tui_source_window) <set_contents>:
5333         Declare.
5334         (tui_set_source_content): Don't declare.
5335         * tui/tui-source.c (tui_source_window::set_contents): Rename from
5336         tui_set_source_content.
5337         * tui/tui-disasm.h (struct tui_disasm_window) <set_contents>:
5338         Declare.
5339         (tui_set_disassem_content): Don't declare.
5340         * tui/tui-disasm.c (tui_disasm_window::set_contents): Rename from
5341         tui_set_disassem_content.
5342
5343 2019-08-16  Tom Tromey  <tom@tromey.com>
5344
5345         * tui/tui-winsource.h (struct tui_source_window_base)
5346         <update_breakpoint_info>: Declare.
5347         (tui_update_breakpoint_info): Don't declare.
5348         * tui/tui-winsource.c (tui_source_window_base::update_source_window_as_is)
5349         (tui_update_all_breakpoint_info): Update.
5350         (tui_source_window_base::update_breakpoint_info): Rename from
5351         tui_update_breakpoint_info.
5352         (tui_source_window_base::update_exec_info): Update.
5353
5354 2019-08-16  Tom Tromey  <tom@tromey.com>
5355
5356         * tui/tui-winsource.h (struct tui_source_window_base)
5357         <update_source_window>: Declare.
5358         (tui_update_source_window): Don't declare.
5359         * tui/tui-winsource.c
5360         (tui_source_window_base::update_source_window): Rename from
5361         tui_update_source_window.
5362         (tui_source_window_base::rerender): Update.
5363         * tui/tui-source.c (tui_source_window::maybe_update): Update.
5364         * tui/tui-disasm.c (tui_show_disassem)
5365         (tui_show_disassem_and_update_source)
5366         (tui_disasm_window::maybe_update): Update.
5367
5368 2019-08-16  Tom Tromey  <tom@tromey.com>
5369
5370         * tui/tui-winsource.h (struct tui_source_window_base)
5371         <update_source_window_as_is>: Declare.
5372         (tui_update_source_window_as_is): Don't declare.
5373         * tui/tui-winsource.c (tui_update_source_window): Update
5374         (tui_source_window_base::update_source_window_as_is): Rename from
5375         tui_update_source_window_as_is.
5376         (tui_source_window_base::refill): Update.
5377         * tui/tui-source.c (tui_show_symtab_source): Update.
5378         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical):
5379         Update.
5380
5381 2019-08-16  Tom Tromey  <tom@tromey.com>
5382
5383         * tui/tui-winsource.h (tui_update_source_window)
5384         (tui_update_source_window_as_is): Remove "noerror" parameter.
5385         * tui/tui-winsource.c (tui_update_source_window)
5386         (tui_update_source_window_as_is): Remove "noerror" parameter.
5387         (tui_update_source_windows_with_addr)
5388         (tui_update_source_windows_with_line)
5389         (tui_source_window_base::rerender)
5390         (tui_source_window_base::refill): Update.
5391         * tui/tui-source.h (tui_set_source_content)
5392         (tui_show_symtab_source): Remove "noerror" parameter.
5393         * tui/tui-source.c (tui_set_source_content): Remove "noerror"
5394         parameter.
5395         (tui_show_symtab_source): Likewise.
5396         (tui_source_window::maybe_update): Update.
5397         * tui/tui-disasm.c (tui_show_disassem)
5398         (tui_show_disassem_and_update_source)
5399         (tui_disasm_window::do_scroll_vertical)
5400         (tui_disasm_window::maybe_update): Update.
5401
5402 2019-08-16  Tom Tromey  <tom@tromey.com>
5403
5404         * tui/tui.c (tui_is_window_visible): Update.
5405         * tui/tui-wingeneral.c (tui_make_window)
5406         (tui_gen_win_info::make_visible, tui_refresh_all): Update.
5407         * tui/tui-win.c (window_name_completer, tui_refresh_all_win)
5408         (tui_set_focus_command, tui_all_windows_info, update_tab_width)
5409         (tui_set_win_height_command, parse_scrolling_args): Update.
5410         * tui/tui-source.c (tui_source_window::style_changed): Update.
5411         * tui/tui-regs.c (tui_show_registers)
5412         (tui_data_window::first_data_item_displayed)
5413         (tui_data_window::delete_data_content_windows)
5414         (tui_check_register_values, tui_reg_command): Update.
5415         * tui/tui-disasm.c (tui_show_disassem): Update.
5416         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: New
5417         method.
5418         <is_visible>: Remove field.
5419         * tui/tui-data.c (tui_next_win, tui_prev_win)
5420         (tui_delete_invisible_windows): Update.
5421
5422 2019-08-16  Tom Tromey  <tom@tromey.com>
5423
5424         * tui/tui-winsource.h (struct tui_source_window_base)
5425         <m_has_locator>: Remove.
5426         * tui/tui-layout.c (show_source_disasm_command, show_data)
5427         (show_source_or_disasm_and_command): Update.
5428
5429 2019-08-16  Alan Hayward  <alan.hayward@arm.com>
5430
5431         * NEWS (Other MI changes): New subsection.
5432         * aarch64-tdep.c (aarch64_get_pc_address_flags): New function.
5433         (aarch64_gdbarch_init): Add aarch64_get_pc_address_flags.
5434         * arch-utils.c (default_get_pc_address_flags): New function.
5435         * arch-utils.h (default_get_pc_address_flags): New declaration.
5436         * gdbarch.sh: Add get_pc_address_flags.
5437         * gdbarch.c: Regenerate.
5438         * gdbarch.h: Likewise.
5439         * stack.c (print_pc): New function.
5440         (print_frame_info) (print_frame): Call print_pc.
5441
5442 2019-08-16  Tom de Vries  <tdevries@suse.de>
5443
5444         * maint.c (maintenance_info_sections): Also handle !ALLOBJ case using
5445         print_objfile_section_info.
5446
5447 2019-08-15  Tom Tromey  <tom@tromey.com>
5448
5449         * tui/tui-io.c (tui_puts_internal): Check TUI_CMD_WIN before
5450         calling update_cmdwin_start_line.
5451         * tui/tui-winsource.h (struct tui_source_window_base)
5452         <do_make_visible_with_new_height, set_new_height>: Don't declare.
5453         <rerender>: Declare.
5454         * tui/tui-winsource.c (tui_source_window_base::update_tab_width):
5455         Call rerender.
5456         (tui_source_window_base::set_new_height): Remove.
5457         (tui_source_window_base::rerender): Rename from
5458         do_make_visible_with_new_height.
5459         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Use
5460         resize method.
5461         (tui_win_info::make_invisible_and_set_new_height)
5462         (tui_win_info::make_visible_with_new_height): Remove.
5463         * tui/tui-stack.h (struct tui_locator_window) <rerender>:
5464         Declare.
5465         * tui/tui-stack.c (tui_locator_window::rerender): New method.
5466         * tui/tui-regs.h (struct tui_data_window) <set_new_height,
5467         do_make_visible_with_new_height>: Don't declare.
5468         <rerender>: Declare.
5469         * tui/tui-regs.c (tui_data_window::rerender): Rename from
5470         set_new_height.
5471         (tui_data_window::do_make_visible_with_new_height): Remove.
5472         * tui/tui-layout.c (show_source_disasm_command, show_data): Don't
5473         call tui_show_locator_content.
5474         (tui_gen_win_info::resize): Call rerender.
5475         (show_source_or_disasm_and_command): Don't call
5476         tui_show_locator_content.
5477         * tui/tui-data.h (struct tui_gen_win_info) <rerender>: New
5478         method.
5479         (struct tui_win_info) <rerender>: Declare.
5480         <set_new_height, make_invisible_and_set_new_height,
5481         make_visible_with_new_height>: Don't declare.
5482         * tui/tui-data.c (tui_win_list::rerender): New method.
5483         * tui/tui-command.h (struct tui_cmd_window)
5484         <do_make_visible_with_new_height>: Don't declare.
5485         * tui/tui-command.c
5486         (tui_cmd_window::do_make_visible_with_new_height): Remove.
5487
5488 2019-08-15  Tom Tromey  <tromey@adacore.com>
5489
5490         * ada-exp.y (convert_char_literal): Handle "Q%c" encoding.
5491         * ada-lang.c (ada_enum_name): Likewise.
5492
5493 2019-08-15  Christian Biesinger  <cbiesinger@google.com>
5494
5495         * python/lib/gdb/__init__.py (GdbOutputFile): Rename to have a
5496         leading underscore.
5497         (GdbOutputErrorFile): Likewise.
5498         (global scope): Adjust constructor calls to GdbOutput{,Error}File
5499         accordingly.
5500         (execute_unwinders): Rename to have a leading underscore.
5501         (auto_load_packages): Likewise.
5502         (global scope): Adjust call to auto_load_packages accordingly.
5503         (GdbSetPythonDirectory): Likewise.
5504         * python/py-unwind.c (pyuw_sniffer): Call _execute_unwinders
5505         instead of execute_unwinders.
5506
5507 2019-08-15  Tom Tromey  <tom@tromey.com>
5508
5509         * tui/tui-layout.c (show_layout, show_source_disasm_command)
5510         (show_data): Don't change window visibility.
5511         (tui_gen_win_info::resize): Remove special case for command
5512         window.  Use wresize, when available.
5513         (show_source_or_disasm_and_command): Don't change window
5514         visibility.
5515         * tui/tui-command.h (struct tui_cmd_window) <resize>: Declare.
5516         <make_visible>: New method.
5517         * tui/tui-command.c (tui_cmd_window::resize): New method.
5518
5519 2019-08-15  Tom Tromey  <tom@tromey.com>
5520
5521         * tui/tui-winsource.h (struct tui_source_window_iterator): New.
5522         (struct tui_source_windows): New.
5523         * tui/tui-winsource.c (tui_display_main): Update.
5524         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
5525         (new_height_ok, parse_scrolling_args): Update.
5526         * tui/tui-layout.c (show_layout, show_data): Update.
5527         * tui/tui-data.h (tui_source_windows, tui_clear_source_windows)
5528         (tui_add_to_source_windows): Don't declare.
5529         * tui/tui-data.c (source_windows, tui_source_windows)
5530         (tui_clear_source_windows, tui_add_to_source_windows): Remove.
5531
5532 2019-08-15  Tom Tromey  <tom@tromey.com>
5533
5534         * tui/tui-winsource.h (struct tui_source_window_base) <resize>:
5535         Rename from reset.
5536         * tui/tui-winsource.c (tui_source_window_base::resize): Rename.
5537         * tui/tui-layout.c (show_source_disasm_command, show_data):
5538         Update.
5539         (tui_gen_win_info::resize): Rename.
5540         (show_source_or_disasm_and_command): Update.
5541         * tui/tui-data.h (struct tui_gen_win_info) <resize>: Rename from
5542         reset.
5543
5544 2019-08-15  Tom Tromey  <tom@tromey.com>
5545
5546         * tui/tui-stack.c (tui_initialize_static_data): Remove.
5547         * tui/tui-interp.c (tui_interp::init): Don't call
5548         tui_initialize_static_data.
5549         * tui/tui-data.h (tui_initialize_static_data): Don't declare.
5550
5551 2019-08-15  Tom Tromey  <tom@tromey.com>
5552
5553         * tui/tui-layout.c (tui_default_win_viewport_height): Don't
5554         examine tui_win_list.
5555
5556 2019-08-15  Tom Tromey  <tom@tromey.com>
5557
5558         * tui/tui-winsource.h (tui_clear_source_content): Don't declare.
5559         * tui/tui-winsource.c (tui_update_source_window_as_is): Don't call
5560         tui_clear_source_content.
5561         (tui_clear_source_content): Remove.
5562         (tui_source_window_base::do_erase_source_content): Hoist call to
5563         content.clear().
5564         * tui/tui-stack.c (tui_show_frame_info): Don't call
5565         tui_clear_source_content.
5566
5567 2019-08-15  Tom Tromey  <tom@tromey.com>
5568
5569         * tui/tui-winsource.h (struct tui_source_window_base)
5570         <do_erase_source_content>: New method.
5571         <erase_source_content>: New method.
5572         (tui_erase_source_content): Don't declare.
5573         * tui/tui-winsource.c (tui_clear_source_content): Update.
5574         (tui_source_window_base::do_erase_source_content): Rename from
5575         tui_erase_source_content.
5576         (tui_source_window_base::show_source_content): Update.
5577         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
5578         * tui/tui-source.h (struct tui_source_window)
5579         <erase_source_content>: New method.
5580         * tui/tui-disasm.h (struct tui_disasm_window)
5581         <erase_source_content>: New method.
5582
5583 2019-08-15  Tom Tromey  <tom@tromey.com>
5584
5585         * tui/tui-winsource.h (tui_alloc_source_buffer): Don't declare.
5586         (struct tui_source_element): Add DISABLE_COPY_AND_ASSIGN, and move
5587         constructor.
5588         * tui/tui-winsource.c (tui_alloc_source_buffer): Remove.
5589         * tui/tui-source.c (tui_set_source_content): Update.
5590         * tui/tui-disasm.c (tui_set_disassem_content): Update.
5591
5592 2019-08-15  Tom Tromey  <tom@tromey.com>
5593
5594         * tui/tui-winsource.h (tui_line_is_displayed): Don't declare.
5595         * tui/tui-winsource.c (tui_line_is_displayed): Move to
5596         tui-source.c.
5597         * tui/tui-source.h (struct tui_source_window) <line_is_displayed>:
5598         Declare.
5599         * tui/tui-source.c (tui_source_window::line_is_displayed): New
5600         method.
5601         (tui_source_window::maybe_update): Update.
5602
5603 2019-08-15  Tom Tromey  <tom@tromey.com>
5604
5605         * tui/tui-winsource.h (tui_addr_is_displayed): Don't declare.
5606         * tui/tui-winsource.c (tui_addr_is_displayed): Move to
5607         tui-disasm.c.
5608         * tui/tui-disasm.h (struct tui_disasm_window) <addr_is_displayed>:
5609         Declare.
5610         * tui/tui-disasm.c (tui_disasm_window::addr_is_displayed): New
5611         method.
5612         (tui_disasm_window::maybe_update): Update.
5613
5614 2019-08-15  Tom Tromey  <tom@tromey.com>
5615
5616         * tui/tui-winsource.h (struct tui_source_window_base)
5617         <maybe_update>: Declare.
5618         * tui/tui-stack.c (tui_show_frame_info): Call maybe_update
5619         method.
5620         * tui/tui-source.h (struct tui_source_window) <maybe_update>:
5621         Declare.
5622         * tui/tui-source.c (tui_source_window::maybe_update): New method.
5623         * tui/tui-disasm.h (struct tui_disasm_window) <maybe_update>:
5624         Declare.
5625         * tui/tui-disasm.c (tui_disasm_window::maybe_update): New method.
5626
5627 2019-08-15  Tom Tromey  <tom@tromey.com>
5628
5629         * tui/tui-stack.c (tui_make_status_line): Use string constructor.
5630
5631 2019-08-15  Tom Tromey  <tom@tromey.com>
5632
5633         * tui/tui-wingeneral.c: Include tui-stack.h.
5634         * tui/tui-stack.h (MAX_LOCATOR_ELEMENT_LEN)
5635         (struct tui_locator_window): Move from tui-data.h.
5636         * tui/tui-stack.c (_locator, tui_locator_win_info_ptr)
5637         (tui_initialize_static_data): Move from tui-data.c.
5638         * tui/tui-data.h (MAX_LOCATOR_ELEMENT_LEN)
5639         (struct tui_locator_window): Move to tui-stack.c.
5640         * tui/tui-data.c (_locator, tui_locator_win_info_ptr)
5641         (tui_initialize_static_data): Move to tui-stack.c.
5642
5643 2019-08-15  Tom Tromey  <tom@tromey.com>
5644
5645         * tui/tui-layout.c (show_source_disasm_command)
5646         (show_source_or_disasm_and_command): Use make_visible method, not
5647         tui_make_window.
5648         * tui/tui-command.h (struct tui_cmd_window) <make_visible>:
5649         Remove.
5650
5651 2019-08-15  Tom Tromey  <tom@tromey.com>
5652
5653         * tui/tui-wingeneral.h (tui_make_window): Update.
5654         * tui/tui-wingeneral.c (tui_make_window): Remove "box_it"
5655         parameter.
5656         (tui_gen_win_info::make_visible): Update.
5657         * tui/tui-regs.c (tui_data_window::display_registers_from):
5658         Update.
5659         * tui/tui-layout.c (show_source_disasm_command)
5660         (show_source_or_disasm_and_command): Update.
5661         * tui/tui-data.h (struct tui_gen_win_info) <can_box>: New method.
5662         (enum tui_box): Remove.
5663         (struct tui_win_info) <can_box>: New method.
5664         * tui/tui-command.h (struct tui_cmd_window) <can_box>: New
5665         method.
5666
5667 2019-08-15  Tom de Vries  <tdevries@suse.de>
5668
5669         * linux-nat-trad.c: Include gdbarch.h.
5670
5671 2019-08-14  Alan Hayward  <alan.hayward@arm.com>
5672
5673         * aarch64-tdep.c (aarch64_analyze_prologue): Allow any valid
5674         register sizes.
5675
5676 2019-08-14  Tom Tromey  <tromey@adacore.com>
5677
5678         * darwin-nat.c: Include gdbarch.h.
5679         * darwin-nat-info.c: Include gdbarch.h.
5680
5681 2019-08-13  Tom Tromey  <tom@tromey.com>
5682
5683         * tui/tui-data.h (struct tui_gen_win_info) <last_visible_line>:
5684         Remove.
5685         * tui/tui-data.c (tui_initialize_static_data): Update.
5686
5687 2019-08-13  Tom Tromey  <tom@tromey.com>
5688
5689         * tui/tui-winsource.h (struct tui_exec_info_window)
5690         <~tui_exec_info_window, maybe_allocate_content, get_content,
5691         m_content>: Remove.
5692         (struct tui_source_window_base) <set_exec_info_content,
5693         show_exec_info_content>: Don't declare.
5694         * tui/tui-winsource.c
5695         (tui_exec_info_window::maybe_allocate_content): Remove.
5696         (tui_source_window_base::update_exec_info): Rename from
5697         set_exec_info_content.
5698         (tui_source_window_base::show_exec_info_content)
5699         (tui_source_window_base::update_exec_info): Remove.
5700
5701 2019-08-13  Tom Tromey  <tom@tromey.com>
5702
5703         * tui/tui-winsource.h (tui_clear_exec_info_content): Don't
5704         declare.
5705         * tui/tui-winsource.c (tui_update_source_window_as_is)
5706         (tui_update_source_windows_with_addr, tui_erase_source_content):
5707         Update.
5708         (tui_clear_exec_info_content): Remove.
5709
5710 2019-08-13  Tom Tromey  <tom@tromey.com>
5711
5712         * tui/tui-winsource.h (tui_erase_exec_info_content): Don't
5713         declare.
5714         * tui/tui-winsource.c (tui_source_window_base::refresh_all): Don't
5715         call tui_erase_exec_info_content.
5716         (tui_clear_exec_info_content): Rename from
5717         tui_erase_exec_info_content.
5718         (tui_clear_exec_info_content): Delete.
5719
5720 2019-08-13  Tom Tromey  <tom@tromey.com>
5721
5722         * tui/tui-winsource.h (struct tui_source_window_base)
5723         <show_exec_info_content>: Declare.
5724         (tui_show_exec_info_content): Don't declare.
5725         * tui/tui-winsource.c
5726         (tui_source_window_base::show_exec_info_content): Rename from
5727         tui_show_exec_info_content.
5728         (tui_source_window_base::update_exec_info): Update.
5729
5730 2019-08-13  Tom Tromey  <tom@tromey.com>
5731
5732         * tui/tui-data.h (enum tui_bp_flag, tui_bp_flags, struct tui_source_element)
5733         (TUI_BP_HIT_POS, TUI_BP_BREAK_POS, TUI_EXEC_POS)
5734         (TUI_EXECINFO_SIZE, tui_exec_info_content): Move ...
5735         * tui/tui-winsource.h (enum tui_bp_flag, tui_bp_flags, struct
5736         tui_source_element, TUI_BP_HIT_POS, TUI_BP_BREAK_POS)
5737         (TUI_EXEC_POS, TUI_EXECINFO_SIZE, tui_exec_info_content):
5738         ... here.
5739
5740 2019-08-13  Tom Tromey  <tom@tromey.com>
5741
5742         * tui/tui-winsource.h (struct tui_source_window_base)
5743         <update_exec_info>: Declare.
5744         (tui_update_exec_info): Don't declare.
5745         * tui/tui-winsource.c (tui_update_source_window_as_is)
5746         (tui_source_window_base::refresh_all)
5747         (tui_update_all_breakpoint_info): Update.
5748         (tui_source_window_base::update_exec_info): Rename from
5749         tui_update_exec_info.
5750         * tui/tui-stack.c (tui_show_frame_info): Update.
5751
5752 2019-08-13  Tom Tromey  <tom@tromey.com>
5753
5754         * tui/tui-winsource.h (struct tui_source_window_base)
5755         <set_exec_info_content>: Declare.
5756         (tui_set_exec_info_content): Don't declare.
5757         * tui/tui-winsource.c
5758         (tui_source_window_base::set_exec_info_content): Rename from
5759         tui_set_exec_info_content.
5760         (tui_update_exec_info): Update.
5761
5762 2019-08-13  Tom Tromey  <tom@tromey.com>
5763
5764         * tui/tui-winsource.h (struct tui_source_window_base)
5765         <show_source_content>: Declare.
5766         (tui_show_source_content): Don't declare.
5767         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
5768         (tui_source_window_base::show_source_content): Rename from
5769         tui_show_source_content.
5770         (tui_source_window_base::refresh_all): Update.
5771         * tui/tui-layout.c (show_source_disasm_command)
5772         (show_source_or_disasm_and_command): Update.
5773
5774 2019-08-13  Tom Tromey  <tom@tromey.com>
5775
5776         * tui/tui-winsource.c (tui_erase_source_content)
5777         (tui_show_source_content, tui_source_window_base::refresh_all):
5778         Update.
5779         * tui/tui-wingeneral.h
5780         (tui_check_and_display_highlight_if_needed): Don't declare.
5781         * tui/tui-wingeneral.c
5782         (tui_win_info::check_and_display_highlight_if_needed): Rename from
5783         check_and_display_highlight_if_needed.
5784         * tui/tui-win.c (tui_rehighlight_all)
5785         (tui_win_info::make_visible_with_new_height): Update.
5786         * tui/tui-regs.c (tui_data_window::display_registers_from_line)
5787         (tui_data_window::erase_data_content)
5788         (tui_data_window::display_all_data): Update.
5789         * tui/tui-data.h (struct tui_win_info)
5790         <check_and_display_highlight_if_needed>: Declare.
5791
5792 2019-08-13  Tom Tromey  <tom@tromey.com>
5793
5794         * tui/tui-win.c (tui_resize_all): Call
5795         tui_delete_invisible_windows.
5796         * tui/tui-layout.c (show_layout): Call
5797         tui_delete_invisible_windows.
5798         * tui/tui-data.h (tui_delete_invisible_windows): Declare.
5799         * tui/tui-data.c (tui_delete_invisible_windows): New function.
5800
5801 2019-08-13  Tom Tromey  <tom@tromey.com>
5802
5803         * tui/tui-disasm.c (tui_show_disassem): Add assertion.  Don't call
5804         tui_add_win_to_layout.
5805
5806 2019-08-13  Tom Tromey  <tom@tromey.com>
5807
5808         * tui/tui-layout.h (tui_default_win_height): Don't declare.
5809         * tui/tui-layout.c (tui_default_win_height): Now static.
5810
5811 2019-08-13  Tom Tromey  <tom@tromey.com>
5812
5813         * tui/tui-layout.c (show_layout): Unify all layout cases into a
5814         single switch.
5815         (show_source_disasm_command, show_source_or_disasm_and_command):
5816         Don't check current layout.
5817
5818 2019-08-13  Tom Tromey  <tom@tromey.com>
5819
5820         * tui/tui-wingeneral.c (make_all_visible): Remove.
5821         (tui_make_all_invisible): Simplify.
5822         * tui/tui-layout.c (tui_make_all_invisible): Move from
5823         tui-wingeneral.c; simplify.
5824         (show_layout): Hoist call to tui_make_all_invisible.
5825         (show_data): Don't call tui_make_all_invisible.
5826
5827 2019-08-13  Tom Tromey  <tom@tromey.com>
5828
5829         * tui/tui-wingeneral.h (tui_make_all_visible): Don't declare.
5830         * tui/tui-wingeneral.c (tui_make_all_visible): Remove.
5831
5832 2019-08-13  Tom Tromey  <tom@tromey.com>
5833
5834         * tui/tui-layout.c (current_layout, tui_current_layout): Move from
5835         tui-data.c.
5836         (show_source_disasm_command, show_data)
5837         (show_source_or_disasm_and_command): Don't use
5838         tui_set_current_layout_to.
5839         * tui/tui-data.h (tui_set_current_layout_to): Don't declare.
5840         * tui/tui-data.c (current_layout, tui_current_layout): Move to
5841         tui-layout.c.
5842         (tui_set_current_layout_to): Remove.
5843
5844 2019-08-13  Tom Tromey  <tom@tromey.com>
5845
5846         * tui/tui-layout.c (tui_set_layout): Update.
5847         * tui/tui-data.h (struct tui_layout_def): Remove.
5848         (tui_layout_def): Don't declare.
5849         * tui/tui-data.c (layout_def): Remove.
5850         (tui_layout_def): Remove.
5851
5852 2019-08-13  Tom Tromey  <tom@tromey.com>
5853
5854         * tui/tui-winsource.h (struct tui_source_window_base)
5855         <clear_detail>: No longer "override".
5856         * tui/tui-regs.h (struct tui_data_window) <clear_detail>: Remove.
5857         * tui/tui-regs.c (tui_data_window::clear_detail): Remove.
5858         * tui/tui-data.h (struct tui_win_info) <clear_detail>: Remove.
5859         * tui/tui-command.h (struct tui_cmd_window) <clear_detail>:
5860         Remove.
5861         * tui/tui-command.c (tui_cmd_window::clear_detail): Remove.
5862
5863 2019-08-13  Tom Tromey  <tromey@adacore.com>
5864
5865         * tracepoint.c: Don't include readline.h or history.h.
5866
5867 2019-08-12  Tom Tromey  <tom@tromey.com>
5868
5869         * configure: Rebuild.
5870         * configure.ac: Check for readline 7.
5871         * NEWS: Mention readline 7 requirement.
5872         * README: Update.
5873
5874 2019-08-12  Tom Tromey  <tom@tromey.com>
5875
5876         * mingw-hdep.c (gdb_select): Remove readline hack.
5877
5878 2019-08-09  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
5879
5880         * blockframe.c (find_pc_partial_function): Set *block to nullptr
5881         when the function fails.
5882
5883 2019-08-09  Andreas Arnez  <arnez@linux.ibm.com>
5884
5885         * s390-tdep.c (s390_type_align): New function.
5886         (s390_gdbarch_init): Set it as type_align gdbarch method.
5887
5888 2019-08-09  Tom de Vries  <tdevries@suse.de>
5889
5890         PR gdb/24591
5891         * dwarf2read.c (dwarf2_fetch_die_loc_sect_off): Adjust pc_high and
5892         pc_low with relocation offset.
5893
5894 2019-08-07  Tom Tromey  <tromey@adacore.com>
5895
5896         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
5897         (print_frame_args): Update.
5898         * python/py-framefilter.c (py_print_single_arg, enumerate_args):
5899         Update.
5900         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
5901         * frame.h (struct frame_arg): Add initializers.
5902         <error>: Now a unique_xmalloc_ptr.
5903
5904 2019-08-07  Alan Hayward  <alan.hayward@arm.com>
5905
5906         * NEWS: Expand the Pointer Authentication entry.
5907         * aarch64-tdep.c (aarch64_frame_unmask_address): Rename from this.
5908         (aarch64_frame_unmask_lr): ... to this.
5909         (aarch64_prologue_prev_register, aarch64_dwarf2_prev_register):
5910         Call aarch64_frame_unmask_lr.
5911         * frame.c (struct frame_info): Add "masked" variable.
5912         (frame_set_previous_pc_masked) (frame_get_pc_masked): New functions.
5913         (fprint_frame): Check for masked pc.
5914         * frame.h (frame_set_previous_pc_masked) (frame_get_pc_masked): New
5915         declarations.
5916         * python/py-framefilter.c (py_print_frame): Check for masked pc.
5917         * stack.c (print_frame): Check for masked pc.
5918
5919 2019-08-06  Tom Tromey  <tom@tromey.com>
5920
5921         * stabsread.c (patch_block_stabs, read_one_struct_field)
5922         (read_enum_type): Use obstack_strndup.
5923         * rust-exp.y (rust_parser::copy_name): Use obstack_strndup.
5924         * gdb_obstack.h (obstack_strndup): Use obstack_strndup.
5925         * dwarf2read.c (guess_full_die_structure_name)
5926         (anonymous_struct_prefix): Use obstack_strndup.
5927         * dbxread.c (cp_set_block_scope): Use obstack_strndup.
5928         * c-exp.y (yylex): Use obstack_strndup.
5929         * ada-exp.y (write_object_renaming, write_ambiguous_var)
5930         (write_var_or_type): Use obstack_strndup.
5931
5932 2019-08-06  Tom Tromey  <tom@tromey.com>
5933
5934         * symfile.c (reread_symbols): Use obstack_strdup.
5935         * stabsread.c (read_type): Use obstack_strdup.
5936         * gdb_obstack.h (obstack_strdup): New overload.
5937         * dwarf2read.c (dwarf2_compute_name, create_dwo_unit_in_dwp_v1)
5938         (create_dwo_unit_in_dwp_v2, build_error_marker_type)
5939         (dwarf2_canonicalize_name): Use obstack_strdup.
5940         * dbxread.c (read_dbx_symtab): Use obstack_strdup.
5941         * cp-support.c (inspect_type, replace_typedefs_qualified_name):
5942         Use obstack_strdup.
5943
5944 2019-08-06  Tom Tromey  <tom@tromey.com>
5945
5946         * gdb_obstack.h (obstack_strdup): Define.
5947         * gdb_obstack.c (obstack_strdup): Don't define.
5948
5949 2019-08-06  Tom Tromey  <tom@tromey.com>
5950
5951         * xcoffread.c (SYMNAME_ALLOC, process_xcoff_symbol): Use
5952         obstack_strdup.
5953         * typeprint.c (typedef_hash_table::find_global_typedef): Use
5954         obstack_strdup.
5955         * symfile.c (allocate_compunit_symtab): Use obstack_strdup.
5956         * stabsread.c (common_block_start): Use obstack_strdup.
5957         * objfiles.c (set_objfile_main_name, objfile): Use
5958         obstack_strdup.
5959         * namespace.c (add_using_directive): Use obstack_strdup.
5960         * mdebugread.c (parse_symbol, parse_type): Use obstack_strdup.
5961         * jit.c (finalize_symtab): Use obstack_strdup.
5962         * dwarf2read.c (fixup_go_packaging, dwarf2_physname)
5963         (guess_partial_die_structure_name, partial_die_info::fixup)
5964         (dwarf2_name): Use obstack_strdup.
5965         * coffread.c (coff_read_struct_type, coff_read_enum_type): Use
5966         obstack_strdup.
5967         * c-exp.y (scan_macro_expansion): Use obstack_strdup.
5968         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
5969         obstack_strdup.
5970         * ada-lang.c (ada_decode_symbol): Use obstack_strdup.
5971
5972 2019-08-07  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5973
5974         * unittests/help-doc-selftests.c: New file.
5975         * Makefile.in: Add the new file.
5976
5977 2019-08-07  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5978
5979         * cli/cli-decode.h (print_doc_line): Add for_value_prefix argument.
5980         * cli/cli-decode.c (print_doc_line): Likewise.  It now prints
5981         the full first line, except when FOR_VALUE_PREFIX.  In this case,
5982         the trailing '.' is not output, and the first character is uppercased.
5983         (print_help_for_command): Update call to print_doc_line.
5984         (print_doc_of_command): Likewise.
5985         * cli/cli-setshow.c (deprecated_show_value_hack): Likewise.
5986         * cli/cli-option.c (append_indented_doc): Do not append newline.
5987         (build_help_option): Append newline after first appended_indented_doc
5988         only if a second call is done.
5989         (build_help): Append 2 new lines before each option, except the first
5990         one.
5991         * compile/compile.c (_initialize_compile): Add new lines after
5992         %OPTIONS%, when not at the end of the help.
5993         Change help doc or code
5994         producing the help doc to respect the invariants.
5995         * maint-test-options.c (_initialize_maint_test_options): Likewise.
5996         Also removed the new line after 'Options:', as all other commands
5997         do not put an empty line between 'Options:' and the first option.
5998         * printcmd.c (_initialize_printcmd): Likewise.
5999         * stack.c (_initialize_stack): Likewise.
6000         * interps.c (interpreter_exec_cmd): Fix "Usage:" line that was
6001         incorrectly telling COMMAND is optional.
6002         * ada-lang.c (_initialize_ada_language): Change help doc or code
6003         producing the help doc to respect the invariants.
6004         * ada-tasks.c (_initialize_ada_tasks): Likewise.
6005         * breakpoint.c (_initialize_breakpoint): Likewise.
6006         * cli/cli-cmds.c (_initialize_cli_cmds): Likewise.
6007         * cli/cli-logging.c (_initialize_cli_logging): Likewise.
6008         * cli/cli-setshow.c (_initialize_cli_setshow): Likewise.
6009         * cli/cli-style.c (cli_style_option::add_setshow_commands,
6010         _initialize_cli_style): Likewise.
6011         * corelow.c (core_target_info): Likewise.
6012         * dwarf-index-cache.c (_initialize_index_cache): Likewise.
6013         * dwarf2read.c (_initialize_dwarf2_read): Likewise.
6014         * filesystem.c (_initialize_filesystem): Likewise.
6015         * frame.c (_initialize_frame): Likewise.
6016         * gnu-nat.c (add_task_commands): Likewise.
6017         * infcall.c (_initialize_infcall): Likewise.
6018         * infcmd.c (_initialize_infcmd): Likewise.
6019         * interps.c (_initialize_interpreter): Likewise.
6020         * language.c (_initialize_language): Likewise.
6021         * linux-fork.c (_initialize_linux_fork): Likewise.
6022         * maint-test-settings.c (_initialize_maint_test_settings): Likewise.
6023         * maint.c (_initialize_maint_cmds): Likewise.
6024         * memattr.c (_initialize_mem): Likewise.
6025         * printcmd.c (_initialize_printcmd): Likewise.
6026         * python/lib/gdb/function/strfns.py (_MemEq, _StrLen, _StrEq,
6027         _RegEx): Likewise.
6028         * ravenscar-thread.c (_initialize_ravenscar): Likewise.
6029         * record-btrace.c (_initialize_record_btrace): Likewise.
6030         * record-full.c (_initialize_record_full): Likewise.
6031         * record.c (_initialize_record): Likewise.
6032         * regcache-dump.c (_initialize_regcache_dump): Likewise.
6033         * regcache.c (_initialize_regcache): Likewise.
6034         * remote.c (add_packet_config_cmd, init_remote_threadtests,
6035         _initialize_remote): Likewise.
6036         * ser-tcp.c (_initialize_ser_tcp): Likewise.
6037         * serial.c (_initialize_serial): Likewise.
6038         * skip.c (_initialize_step_skip): Likewise.
6039         * source.c (_initialize_source): Likewise.
6040         * stack.c (_initialize_stack): Likewise.
6041         * symfile.c (_initialize_symfile): Likewise.
6042         * symtab.c (_initialize_symtab): Likewise.
6043         * target-descriptions.c (_initialize_target_descriptions): Likewise.
6044         * top.c (init_main): Likewise.
6045         * tracefile-tfile.c (tfile_target_info): Likewise.
6046         * tracepoint.c (_initialize_tracepoint): Likewise.
6047         * tui/tui-win.c (_initialize_tui_win): Likewise.
6048         * utils.c (add_internal_problem_command): Likewise.
6049         * valprint.c (value_print_option_defs): Likewise.
6050
6051 2019-08-06  Frank Ch. Eigler  <fche@redhat.com>
6052
6053         PR build/24886
6054         * configure.ac: Drop enable-libmcheck support.
6055         * configure, config.in: Rebuild.
6056         * libmcheck.m4: Remove.
6057         * acinclude.m4: Don't include it.
6058         * Makefile.in: Don't distribute it.
6059         * top.c (print_gdb_configuration): Don't mention it.
6060
6061 2019-08-06  Tom Tromey  <tom@tromey.com>
6062
6063         * utils.c (set_output_style): Sometimes pass stream to
6064         emit_style_escape.
6065         * ui-out.h (class ui_out) <can_emit_style_escape>: Declare.
6066         * record-btrace.c (btrace_insn_history): Update.
6067         * mi/mi-out.h (class mi_ui_out) <can_emit_style_escape>: New
6068         method.
6069         * disasm.h (gdb_pretty_print_disassembler): Add uiout parameter.
6070         Update initializers.
6071         <m_uiout>: New field.
6072         <m_di>: Move lower.
6073         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
6074         Remove "uiout" parameter.
6075         (dump_insns): Update.
6076         * cli-out.h (class cli_ui_out) <can_emit_style_escape>: Declare.
6077         * cli-out.c (cli_ui_out::can_emit_style_escape): New method.
6078
6079 2019-08-06  Christian Biesinger  <cbiesinger@google.com>
6080
6081         * symtab.c (symbol_cache_lookup): Change int to enum block_enum.
6082         (error_in_psymtab_expansion): Likewise.
6083         (lookup_symbol_via_quick_fns): Likewise.
6084         (basic_lookup_transparent_type_quick): Likewise.
6085         (basic_lookup_transparent_type_1): Likewise.
6086
6087 2019-08-06  Tom Tromey  <tromey@adacore.com>
6088
6089         * source.c (last_source_error): Now bool.
6090         (print_source_lines_base): Make "noprint" bool.  Only open
6091         source file when last_source_visited changes.
6092
6093 2019-08-06  Tom Tromey  <tromey@adacore.com>
6094
6095         * annotate.c (annotate_source_line): Use g_source_cache.
6096         * source-cache.c (source_cache::get_plain_source_lines): Change
6097         parameters.  Populate m_offset_cache.
6098         (source_cache::ensure): New method.
6099         (source_cache::get_line_charpos): New method.
6100         (extract_lines): Move lower.  Change parameters.
6101         (source_cache::get_source_lines): Move lower.
6102         * source-cache.h (class source_cache): Update comment.
6103         <get_line_charpos>: New method.
6104         <get_source_lines>: Update comment.
6105         <clear>: Clear m_offset_cache.
6106         <get_plain_source_lines>: Change parameters.
6107         <ensure>: New method
6108         <m_offset_cache>: New member.
6109         * source.c (forget_cached_source_info_for_objfile): Update.
6110         (info_source_command): Use g_source_cache.
6111         (find_source_lines, open_source_file_with_line_charpos): Remove.
6112         (print_source_lines_base, search_command_helper): Use g_source_cache.
6113         * source.h (open_source_file_with_line_charpos): Don't declare.
6114         * symtab.h (struct symtab) <nlines, line_charpos>: Remove.
6115         * tui/tui-source.c (tui_source_window::do_scroll_vertical):
6116         Use g_source_cache.
6117
6118 2019-08-06  Tom Tromey  <tromey@adacore.com>
6119
6120         * source-cache.c (source_cache::get_plain_source_lines):
6121         Remove "first_line" and "last_line" parameters.
6122         (source_cache::get_source_lines): Cache plain text.
6123         * source-cache.h (class source_cache)
6124         <get_plain_source_lines>: Update.
6125
6126 2019-08-06  Tom Tromey  <tromey@adacore.com>
6127
6128         * source-cache.c (extract_lines): No longer a method.
6129         Changed type of parameter.  Include final newline.
6130         (selftests::extract_lines_test): New function.
6131         (_initialize_source_cache): Likewise.
6132         * source-cache.h (class source_cache)
6133         <extract_lines>: Don't declare.
6134
6135 2019-08-06  Tom Tromey  <tromey@adacore.com>
6136
6137         * breakpoint.c (init_breakpoint_sal): Update.
6138         (breakpoint): Update.
6139         * breakpoint.h (struct breakpoint) <filter>: Now a
6140         unique_xmalloc_ptr.
6141
6142 2019-08-05  Christian Biesinger  <cbiesinger@google.com>
6143
6144         * NEWS: Mention dictionary access on blocks.
6145         * python/py-block.c (blpy_getitem): New function.
6146         (block_object_as_mapping): New struct.
6147         (block_object_type): Use new struct for tp_as_mapping field.
6148
6149 2019-08-05  Christian Biesinger  <cbiesinger@google.com>
6150
6151         * objfiles.h (objfile): Add a comment describing partial symbols.
6152
6153 2019-08-05  Tom Tromey  <tromey@adacore.com>
6154
6155         * compile/compile.c (_initialize_compile): Use _(), not N_().
6156         * thread.c (_initialize_thread): Use _(), not N_().
6157         * stack.c (_initialize_stack): Use _(), not N_().
6158         * printcmd.c (_initialize_printcmd): Use _(), not N_().
6159
6160 2019-08-04  Simon Marchi  <simon.marchi@polymtl.ca>
6161
6162         * dwarf2read.c (struct dw2_symtab_iterator):
6163         <want_specific_block>: Remove.
6164         <block_index>: Change type to gdb::optional.
6165         (dw2_symtab_iter_init): Remove WANT_SPECIFIC_BLOCK parameter,
6166         change type of BLOCK_INDEX parameter to gdb::optional.
6167         (dw2_symtab_iter_next): Re-write in function of gdb::optional.
6168         (dw2_lookup_symbol): Don't pass argument for
6169         WANT_SPECIFIC_BLOCK.
6170         (dw2_expand_symtabs_for_function): Don't pass argument for
6171         WANT_SPECIFIC_BLOCK, pass empty optional for BLOCK_INDEX.
6172         (class dw2_debug_names_iterator)
6173         <dw2_debug_names_iterator>: Remove WANT_SPECIFIC_BLOCK
6174         parameter, change BLOCK_INDEX type to gdb::optional.
6175         <m_want_specific_block>: Remove.
6176         <m_block_index>: Change type to gdb::optional.
6177         (dw2_debug_names_iterator::next): Change type of IS_STATIC to
6178         gdb::optional.  Re-write in function of gdb::optional.
6179         (dw2_debug_names_lookup_symbol): Don't pass argument for
6180         WANT_SPECIFIC_BLOCK.
6181         (dw2_debug_names_expand_symtabs_for_function): Don't pass
6182         argument for WANT_SPECIFIC_BLOCK, pass empty optional for
6183         BLOCK_INDEX.
6184
6185 2019-08-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6186
6187         * NEWS: Mention changes to "info sources" command.
6188
6189 2019-08-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6190
6191         * symtab.c (filename_partial_match_opts): New struct type.
6192         (struct output_source_filename_data): New members
6193         regexp, c_regexp, partial_match.
6194         (output_source_filename): Use new members to decide to print file.
6195         (info_sources_option_defs): New variable.
6196         (make_info_sources_options_def_group, print_info_sources_header,
6197         info_sources_command_completer):
6198         New functions.
6199         (info_sources_command): Read new optional arguments.
6200         (_initialize_symtab): Update info sources help.
6201
6202 2019-08-02  Alexandre Oliva <oliva@adacore.com>
6203
6204         * ada-lang.c (exception_support_info_v0): Renamed from...
6205         (default_exception_support_info): ... this.  Create new
6206         definition for v1.
6207         (ada_has_this_exception_support): Look up catch_handlers_sym.
6208         (ada_exception_support_info_sniffer): Try v0 after default.
6209
6210 2019-08-01  Tom Tromey  <tromey@adacore.com>
6211
6212         * ia64-libunwind-tdep.h (struct libunwind_descr): Include
6213         gdbarch.h.
6214
6215 2019-08-01  Christian Biesinger  <cbiesinger@google.com>
6216
6217         * s12z-tdep.c: Fix include path for s12z-opc.h.
6218
6219 2019-08-01  Alan Hayward  <alan.hayward@arm.com>
6220
6221         * NEWS: Require GNU make 3.82.
6222
6223 2019-07-16  Tom Tromey  <tom@tromey.com>
6224
6225         * tui/tui-wingeneral.h (tui_copy_win, tui_box_win): Don't
6226         declare.
6227
6228 2019-07-30  Tom Tromey  <tromey@adacore.com>
6229
6230         * block.c (contained_in): Remove BLOCK_FUNCTION check.
6231
6232 2019-07-30  Kevin Buettner  <kevinb@redhat.com>
6233
6234         * printcmd.c (print_address_symbolic): Print negative offsets.
6235         (build_address_symbolic): Force signed arithmetic when computing
6236         offset.
6237
6238 2019-07-30  Christian Biesinger  <cbiesinger@google.com>
6239
6240         PR/24474: Add a function to lookup static variables.
6241         * NEWS: Mention this new function.
6242         * python/py-symbol.c (gdbpy_lookup_static_symbol): New function.
6243         * python/python-internal.h (gdbpy_lookup_static_symbol): New function.
6244         * python/python.c (python_GdbMethods): Add new function.
6245
6246 2019-07-29  Christian Biesinger  <cbiesinger@google.com>
6247
6248         * NEWS: Mention new functions Objfile.lookup_{global,static}_symbol.
6249         * python/py-objfile.c (objfpy_lookup_global_symbol): New function.
6250         (objfpy_lookup_static_symbol): New function.
6251         (objfile_object_methods): Add new functions.
6252
6253 2019-07-29  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6254
6255         * NEWS: Mention 'set|show print frame-info'.  Mention new
6256         'presence' value for 'frame-arguments'.  Mention new '-frame-info'
6257         backtrace argument.  Mention that python frame filtering code
6258         is now consistent with what 'backtrace' command prints.
6259
6260 2019-07-29  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6261
6262         * frame.h (enum print_what): New value 'SHORT_LOCATION', update
6263         comments.
6264         (print_frame_info_auto, print_frame_info_source_line,
6265         print_frame_info_location, print_frame_info_source_and_location,
6266         print_frame_info_location_and_address, print_frame_info_short_location):
6267         New declarations.
6268         (struct frame_print_options): New member print_frame_info.
6269         * extension.h (enum ext_lang_frame_args): New value CLI_PRESENCE.
6270         * stack.h (get_user_print_what_frame_info): New declaration.
6271         (frame_show_address): New declaration.
6272         * stack.c (print_frame_arguments_choices): New value 'presence'.
6273         (print_frame_info_auto, print_frame_info_source_line,
6274         print_frame_info_location, print_frame_info_source_and_location,
6275         print_frame_info_location_and_address, print_frame_info_short_location,
6276         print_frame_info_choices, print_frame_info_print_what): New definitions.
6277         (print_frame_args): Only print dots for args if print frame-arguments
6278         is 'presence'.
6279         (frame_print_option_defs): New element for "frame-info".
6280         (get_user_print_what_frame_info): New function.
6281         (frame_show_address): Make non static.  Move comment to stack.h.
6282         (print_frame_info_to_print_what): New function.
6283         (print_frame_info): Update comment.  Use fp_opts.print_frame_info
6284         to decide what to print.
6285         (backtrace_command_1): Handle the new print_frame_arguments_presence
6286         value.
6287         (_initialize_stack): Call add_setshow_enum_cmd for frame-info.
6288         * python/py-framefilter.c (py_print_args): Handle CLI_PRESENCE.
6289         (py_print_frame): In non-mi mode, use LOCATION as default for
6290         print_what, similarly to frame information printed directly by
6291         backtrace command. Handle frame-info user option in non MI mode.
6292
6293 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
6294
6295         * linux-thread-db.c (thread_db_target::thread_handle_to_thread_info):
6296         Add case for debugging 32-bit target on 64-bit host.  Revise
6297         comment.
6298
6299 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
6300
6301         * infrun.c (fill_in_stop_func): Use find_pc_partial_function
6302         instead of find_function_entry_range_from_pc.
6303
6304 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
6305
6306         * stack.c (find_frame_funname): Remove code which preferred
6307         minsym over symtab sym in "certain pathological cases".
6308
6309         * valprint.h (build_address_symbolic): Add "prefer_sym_over_minsym"
6310         parameter.  Change type of "do_demangle" to bool.
6311         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
6312         Pass suitable "prefer_sym_over_minsym" flag to
6313         build_address_symbolic().  Don't output "+" for negative offsets.
6314         * printcmd.c (print_address_symbolic): Update invocation of
6315         build_address_symbolic to include a "prefer_sym_over_minsym"
6316         flag.
6317         (build_address_symbolic): Add "prefer_sym_over_minsym" parameter.
6318         Restrict cases in which use of minimal symbol is preferred to that
6319         of a found symbol.  Update comments.
6320
6321         * dwarf2-frame.c (dwarf2_frame_cache): Don't decode FDE instructions
6322         for entry pc when entry pc is out of range for that FDE.
6323
6324 2019-07-26  Brian Callahan  <bcallah@openbsd.org>
6325
6326         PR gdb/24839:
6327         * gdb/obsd-nat.c (obsd_nat_target::pid_to_str): Fix typo in return
6328         type.
6329
6330 2019-07-25  Christian Biesinger  <cbiesinger@google.com>
6331
6332         * python/py-objfile.c (add_separate_debug_file): Fix comment about
6333         this function's Python signature.
6334
6335
6336 2019-07-24  Christian Biesinger  <cbiesinger@google.com>
6337
6338         * compile/compile-object-load.c (compile_object_load): Pass GLOBAL_SCOPE.
6339         * solib-spu.c (spu_lookup_lib_symbol): Pass GLOBAL_SCOPE.
6340         * solib-svr4.c (elf_lookup_lib_symbol): Pass GLOBAL_SCOPE.
6341         * symtab.c (lookup_global_symbol_from_objfile): Add a scope parameter.
6342         * symtab.h (lookup_global_symbol_from_objfile): Likewise.
6343
6344
6345 2019-07-24  Yoshinori Sato  <ysato@users.sourceforge.jp>
6346
6347         * h8300-tdep.c (h8300_register_name_common): New.
6348         h8300_register_name): Use h8300_register_name_common.
6349         (h8300s_register_name): Likewise.
6350         (h8300sx_register_name): Likewise.
6351         (h8300h_register_nam): New.
6352         (h8300_gdbarch_init): Use h8300h_register_name in h8300h machine.
6353
6354
6355 2019-07-23  Srinath Parvathaneni  <srinath.parvathaneni@arm.com>
6356
6357         * arm-tdep.c (arm_skip_cmse_entry): New function.
6358         (arm_is_sgstubs_section): New function.
6359         (arm_skip_stub): Add call to arm_skip_cmse_entry function.
6360
6361 2019-07-22  Tom Tromey  <tom@tromey.com>
6362
6363         * tui/tui-win.c (tui_win_info::make_invisible_and_set_new_height):
6364         Don't self-assign.
6365
6366 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
6367
6368         * c-typeprint.c (c_print_typedef): Pass -1 instead of 0 to
6369         type_print.
6370
6371 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
6372
6373         * symtab.c (search_symbols): Adjust msymbol matching type arrays
6374         so that GDB doesn't match any msymbols when searching in the
6375         TYPES_DOMAIN.
6376         (print_symbol_info): Print using typedef_print or type_print based
6377         on the type of the symbol.  Add updated FIXME comment moved from...
6378         (_initialize_symtab): ... move and update FIXME comment to above.
6379
6380 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
6381
6382         * NEWS: Mention adding -q option to "info types".
6383         * symtab.c (struct info_types_options): New struct.
6384         (info_types_options_defs): New variable.
6385         (make_info_types_options_def_group): New function.
6386         (info_types_command): Use gdb::option framework to parse options.
6387         (info_types_command_completer): New function.
6388         (_initialize_symtab): Extend the help text on "info types" and
6389         register command completer.
6390
6391 2019-07-21  Christian Biesinger  <cbiesinger@google.com>
6392
6393         * symtab.c (lookup_symbol_in_objfile_symtabs): Change int to block_enum.
6394         (lookup_symbol_in_objfile): Change int to block_enum and add a
6395         gdb_assert to make sure block_index is GLOBAL_BLOCK or STATIC_BLOCK.
6396
6397 2019-07-20  Christian Biesinger  <cbiesinger@google.com>
6398
6399         * MAINTAINERS (Write After Approval): Add self.
6400
6401 2019-07-19  Andrew Burgess  <andrew.burgess@embecosm.com>
6402
6403         * riscv-tdep.c (riscv_push_dummy_code): Write a 4-byte nop
6404         instruction to the dummy code region.
6405
6406 2019-07-19  Tom Tromey  <tromey@adacore.com>
6407
6408         * contrib/ari/gdb_ari.sh: Mention C++11, not ISO C 90.
6409         (ARGSUSED, PARAMS, __func__): Remove rules.
6410
6411 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
6412
6413         * arm-tdep.c (_initialize_arm_tdep): Remove xml tests.
6414         * features/arm/arm-with-iwmmxt.c: Remove.
6415         * features/arm/arm-with-iwmmxt.xml: Remove.
6416         * features/arm/arm-with-m-fpa-layout.c: Remove.
6417         * features/arm/arm-with-m-fpa-layout.xml: Remove.
6418         * features/arm/arm-with-m-vfp-d16.c: Remove.
6419         * features/arm/arm-with-m-vfp-d16.xml: Remove.
6420         * features/arm/arm-with-m.c: Remove.
6421         * features/arm/arm-with-m.xml: Remove.
6422         * features/arm/arm-with-neon.c: Remove.
6423         * features/arm/arm-with-neon.xml: Remove.
6424         * features/arm/arm-with-vfpv2.c: Remove.
6425         * features/arm/arm-with-vfpv2.xml: Remove.
6426         * features/arm/arm-with-vfpv3.c: Remove.
6427         * features/arm/arm-with-vfpv3.xml: Remove.
6428
6429 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
6430
6431         * arm-tdep.c (_initialize_arm_tdep): Add xml regression tests.
6432
6433 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
6434
6435         * arch/aarch32.c (aarch32_create_target_description): Create
6436         target descriptions using features.
6437         * arch/arm.c (arm_create_target_description)
6438         (arm_create_mprofile_target_description): Likewise.
6439         * arm-tdep.c (_initialize_arm_tdep): Remove tdesc init calls.
6440
6441 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
6442
6443         * Makefile.in: Add new files.
6444         * aarch32-tdep.c: New file.
6445         * aarch32-tdep.h: New file.
6446         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
6447         Call aarch32_read_description.
6448         * arch/aarch32.c: New file.
6449         * arch/aarch32.h: New file.
6450         * arch/arm.c (arm_create_target_description)
6451         (arm_create_mprofile_target_description): New function.
6452         * arch/arm.h (arm_fp_type, arm_m_profile_type): New enum.
6453         (arm_create_target_description)
6454         (arm_create_mprofile_target_description): New declaration.
6455         * arm-fbsd-tdep.c (arm_fbsd_read_description_auxv): Call
6456         read_description functions.
6457         * arm-linux-nat.c (arm_linux_nat_target::read_description):
6458         Likewise.
6459         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
6460         * arm-tdep.c (tdesc_arm_list): New variable.
6461         (arm_register_g_packet_guesses): Call create description functions.
6462         (arm_read_description) (arm_read_mprofile_description): New
6463         function.
6464         * arm-tdep.h (arm_read_description)
6465         (arm_read_mprofile_description): Add declaration.
6466         * configure.tgt: Add new files.
6467
6468 2019-07-18  Guillaume LABARTHE  <guillaume.labarthe@gmail.com>
6469
6470         * top.c (new_ui_command): Open specified terminal just once.
6471
6472 2019-07-18  Tom Tromey  <tromey@adacore.com>
6473
6474         * symtab.c (main_name): Constify return type.
6475         * symfile.c (set_initial_language): Update.
6476         * symtab.h (main_name): Constify return type.
6477
6478 2019-07-17  Tom Tromey  <tom@tromey.com>
6479
6480         * tui/tui-winsource.c (tui_update_source_window)
6481         (tui_update_source_window_as_is)
6482         (tui_update_source_windows_with_line): Remove return.
6483         * tui/tui-disasm.c (tui_show_disassem)
6484         (tui_show_disassem_and_update_source): Remove return.
6485         * tui/tui.c (tui_reset): Remove return.
6486         * tui/tui-wingeneral.c
6487         (tui_check_and_display_highlight_if_needed): Remove return.
6488
6489 2019-07-17  Tom Tromey  <tom@tromey.com>
6490
6491         * tui/tui-win.c (parse_scrolling_args): Throw separate errors.
6492
6493 2019-07-17  Tom Tromey  <tom@tromey.com>
6494
6495         * tui/tui-winsource.h (struct tui_exec_info_window)
6496         (struct tui_source_window_base): Move from tui-data.h.
6497         * tui/tui-winsource.c: Move many method definitions from
6498         elsewhere.  Remove "structuring" comments.
6499         * tui/tui-wingeneral.c (tui_source_window_base::make_visible)
6500         (tui_source_window_base::refresh_window): Move to
6501         tui-winsource.c.
6502         * tui/tui-win.c (tui_source_window_base::refresh_all)
6503         (tui_source_window_base::update_tab_width)
6504         (tui_source_window_base::set_new_height)
6505         (tui_source_window_base::do_make_visible_with_new_height): Move to
6506         tui-winsource.c.
6507         * tui/tui-source.h: Update.
6508         * tui/tui-source.c (tui_source_window_base::reset): Move to
6509         tui-winsource.c.
6510         * tui/tui-disasm.h: Update.
6511         * tui/tui-data.h (struct tui_exec_info_window): Move to
6512         tui-winsource.h.
6513         (struct tui_source_window_base): Likewise.
6514         * tui/tui-data.c (tui_source_window_base::clear_detail)
6515         (tui_source_window_base, ~tui_source_window_base): Move to
6516         tui-winsource.c.
6517
6518 2019-07-17  Tom Tromey  <tom@tromey.com>
6519
6520         * tui/tui-win.c (tui_resize_all)
6521         (tui_source_window_base::update_tab_width)
6522         (tui_adjust_win_heights): Update.
6523         (tui_win_info::make_invisible_and_set_new_height): Rename from
6524         make_invisible_and_set_new_height.
6525         * tui/tui-data.h (struct tui_win_info)
6526         <make_invisible_and_set_new_height>: New method.
6527
6528 2019-07-17  Tom Tromey  <tom@tromey.com>
6529
6530         * tui/tui.c: Update.
6531         * tui/tui-source.h (struct tui_source_window): Move from
6532         tui-data.h.
6533         * tui/tui-layout.c: Update.
6534         * tui/tui-disasm.c: Update.
6535         * tui/tui-data.h (struct tui_source_window): Move to
6536         tui-source.h.
6537
6538 2019-07-17  Tom Tromey  <tom@tromey.com>
6539
6540         * tui/tui-disasm.h (struct tui_disasm_window): Move from
6541         tui-data.h.
6542         * tui/tui-data.h (struct tui_disasm_window): Move to
6543         tui-disasm.h.
6544
6545 2019-07-17  Tom Tromey  <tom@tromey.com>
6546
6547         * tui/tui-regs.h (struct tui_data_item_window): Move from
6548         tui-data.h.
6549         * tui/tui-regs.c (tui_data_item_window): Move from tui-data.c.
6550         * tui/tui-data.h (struct tui_data_item_window): Move to
6551         tui-regs.h.
6552         * tui/tui-data.c (~tui_data_item_window): Move to tui-regs.c.
6553
6554 2019-07-17  Tom Tromey  <tom@tromey.com>
6555
6556         * tui/tui.c: Update.
6557         * tui/tui-win.c (tui_cmd_window::do_make_visible_with_new_height)
6558         (tui_cmd_window::max_height): Move to tui-command.c.
6559         * tui/tui-layout.c: Update.
6560         * tui/tui-data.h (struct tui_cmd_window): Move to tui-command.h.
6561         * tui/tui-data.c (tui_cmd_window::clear_detail): Move to
6562         tui-command.c.
6563         * tui/tui-command.h (struct tui_cmd_window): Move from
6564         tui-data.h.
6565         * tui/tui-command.c: Remove "structuring" comments.
6566         (tui_cmd_window::clear_detail)
6567         (tui_cmd_window::do_make_visible_with_new_height)
6568         (tui_cmd_window::max_height): Move from elsewhere.
6569
6570 2019-07-17  Tom Tromey  <tom@tromey.com>
6571
6572         * tui/tui-io.c (tui_dispatch_ctrl_char): Move from tui-command.c.
6573         Now static.
6574         * tui/tui-command.h (tui_dispatch_ctrl_char): Don't declare.
6575         * tui/tui-command.c (tui_dispatch_ctrl_char): Move to tui-io.c.
6576
6577 2019-07-17  Tom Tromey  <tom@tromey.com>
6578
6579         * tui/tui.c: Update.
6580         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Move to
6581         tui-regs.c.
6582         * tui/tui-windata.h: Remove file.
6583         * tui/tui-windata.c: Remove file.
6584         * tui/tui-win.c (tui_data_window::set_new_height)
6585         (tui_data_window::do_make_visible_with_new_height): Move to
6586         tui-regs.c.
6587         * tui/tui-regs.h (struct tui_data_window): Move from tui-data.h.
6588         * tui/tui-regs.c: Remove "structuring" comments.
6589         (tui_data_window::first_data_item_displayed)
6590         (tui_data_window::delete_data_content_windows)
6591         (tui_data_window::erase_data_content)
6592         (tui_data_window::display_all_data)
6593         (tui_data_window::refresh_all)
6594         (tui_data_window::do_scroll_vertical)
6595         (tui_data_window::clear_detail, tui_data_window::set_new_height)
6596         (tui_data_window::do_make_visible_with_new_height)
6597         (tui_data_window::refresh_window): Move from elsewhere.
6598         (_initialize_tui_regs): Move to end of file.
6599         * tui/tui-layout.c: Update.
6600         * tui/tui-hooks.c: Update.
6601         * tui/tui-data.h (struct tui_data_window): Move to tui-regs.h.
6602         * tui/tui-data.c (tui_data_window::clear_detail): Move to
6603         tui-regs.c.
6604         * Makefile.in (SUBDIR_TUI_SRCS): Remove tui-windata.c.
6605
6606 2019-07-17  Tom Tromey  <tom@tromey.com>
6607
6608         * tui/tui-io.c (tui_puts_internal): Call wrefresh if newline is
6609         seen.
6610
6611 2019-07-17  Tom Tromey  <tom@tromey.com>
6612
6613         * tui/tui-win.c (tui_source_window_base::set_new_height)
6614         (tui_source_window_base::do_make_visible_with_new_height): Use
6615         m_has_locator field directly.
6616         * tui/tui-data.h (struct tui_win_info) <has_locator>: Remove
6617         method.
6618         (struct tui_source_window_base) <has_locator>: Likewise.
6619
6620 2019-07-17  Tom Tromey  <tom@tromey.com>
6621
6622         * tui/tui-wingeneral.h (tui_make_visible, tui_make_invisible):
6623         Don't declare.
6624         * tui/tui-wingeneral.c (tui_make_visible, tui_make_invisible):
6625         Remove.
6626         * tui/tui-win.c (tui_source_window_base::set_new_height)
6627         (tui_source_window_base::set_new_height)
6628         (make_invisible_and_set_new_height)
6629         (tui_source_window_base::do_make_visible_with_new_height)
6630         (tui_source_window_base::do_make_visible_with_new_height):
6631         Update.
6632         * tui/tui-layout.c (show_source_disasm_command, show_data)
6633         (show_source_or_disasm_and_command): Update.
6634         * tui/tui-layout.c (show_layout): Update.
6635
6636 2019-07-17  Tom Tromey  <tom@tromey.com>
6637
6638         * tui/tui-layout.c (make_data_window): Remove.
6639         (show_data): Unify creation and re-initialization cases.
6640
6641 2019-07-17  Tom Tromey  <tom@tromey.com>
6642
6643         * tui/tui-layout.c (make_source_window, make_disasm_window):
6644         Remove.
6645         (show_data): Unify creation and re-initialization cases.
6646
6647 2019-07-17  Tom Tromey  <tom@tromey.com>
6648
6649         * tui/tui-layout.c (make_command_window): Remove.
6650         (show_source_disasm_command, show_source_or_disasm_and_command):
6651         Unify creation and re-initialization cases.
6652
6653 2019-07-17  Tom Tromey  <tom@tromey.com>
6654
6655         * tui/tui-layout.c (show_source_or_disasm_and_command): Unify
6656         creation and re-initialization cases.
6657
6658 2019-07-17  Tom Tromey  <tom@tromey.com>
6659
6660         * tui/tui-regs.c (tui_get_register): Return void.
6661
6662 2019-07-17  Tom Tromey  <tom@tromey.com>
6663
6664         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible):
6665         Simplify.
6666
6667 2019-07-17  Tom Tromey  <tom@tromey.com>
6668
6669         * tui/tui-layout.c (show_source_disasm_command): Simplify window
6670         resetting.
6671
6672 2019-07-17  Tom Tromey  <tom@tromey.com>
6673
6674         * tui/tui.h (tui_set_layout_by_name): Don't declare.
6675         * tui/tui-regs.c (tui_reg_layout): New function.
6676         (tui_show_registers, tui_reg_command): Use it.
6677         * tui/tui-layout.c (LAYOUT_USAGE): Remove.
6678         (tui_layout_command): Rename from tui_set_layout_by_name.  Change
6679         parameters.
6680         (tui_layout_command): Remove.
6681
6682 2019-07-17  Tom Tromey  <tom@tromey.com>
6683
6684         * tui/tui-layout.h (tui/tui-layout): Return void.
6685         * tui/tui-layout.c (tui_set_layout): Return void.  Add assert.
6686
6687 2019-07-17  Tom Tromey  <tom@tromey.com>
6688
6689         * tui/tui-layout.c (show_source_disasm_command, show_data):
6690         Update.
6691         (reset_locator): Remove.
6692         (show_source_or_disasm_and_command): Update.
6693
6694 2019-07-17  Tom Tromey  <tom@tromey.com>
6695
6696         * tui/tui-source.c (tui_source_window_base::reset): Remove
6697         win_type parameter.
6698         * tui/tui-layout.c (make_command_window, make_source_window)
6699         (make_disasm_window, make_data_window)
6700         (show_source_disasm_command, show_data, tui_gen_win_info::reset)
6701         (reset_locator, show_source_or_disasm_and_command): Update.
6702         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Remove
6703         win_type parameter.
6704         (struct tui_source_window_base) <reset>: Likewise.
6705
6706 2019-07-17  Tom Tromey  <tom@tromey.com>
6707
6708         * tui/tui-layout.c (show_source_disasm_command): Use
6709         reset_locator.
6710         (reset_locator): New function.
6711         (init_and_make_win): Remove.
6712         (show_source_or_disasm_and_command): Use reset_locator.
6713
6714 2019-07-17  Tom Tromey  <tom@tromey.com>
6715
6716         * tui/tui-winsource.c (tui_set_exec_info_content): Remove
6717         condition.
6718         * tui/tui-wingeneral.c (tui_source_window_base::make_visible):
6719         Remove condition.
6720         * tui/tui-source.c (tui_source_window_base::reset): New method.
6721         * tui/tui-layout.c (make_command_window): Don't call
6722         init_and_make_win.
6723         (make_source_window, make_disasm_window): Don't call
6724         make_source_or_disasm_window.
6725         (make_data_window): Don't call init_and_make_win.  Change calling
6726         convention.
6727         (show_source_disasm_command, show_data): Simplify.
6728         (make_source_or_disasm_window): Remove.
6729         (show_source_or_disasm_and_command): Simplify.
6730         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Now virtual.
6731         (struct tui_source_window_base) <reset>: Likewise.
6732         <execution_info>: Remove initializer.
6733         * tui/tui-data.c (tui_source_window_base): Initialize
6734         execution_info.
6735
6736 2019-07-17  Tom Tromey  <tom@tromey.com>
6737
6738         * tui/tui-layout.c (tui_set_layout): Remove regs_populate
6739         variable.
6740
6741 2019-07-17  Tom Tromey  <tom@tromey.com>
6742
6743         * tui/tui.c (tui_rl_other_window): Update.
6744         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Call
6745         superclass method first.  Always iterate over regs_content.
6746         (tui_unhighlight_win, tui_highlight_win): Use refresh_window
6747         method.
6748         * tui/tui-win.c (tui_set_focus_command): Update.
6749
6750 2019-07-17  Tom Tromey  <tom@tromey.com>
6751
6752         * tui/tui-win.c (tui_set_focus_command): Rename from
6753         tui_set_focus.  Call tui_enable.
6754         (tui_set_focus_command): Remove.
6755
6756 2019-07-17  Tom Tromey  <tom@tromey.com>
6757
6758         * tui/tui-winsource.c (tui_show_exec_info_content): Don't call
6759         refresh_window.
6760         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Call
6761         touchwin.
6762         (tui_data_window::refresh_window): Call refresh_window on data
6763         items.  Always call superclass refresh_window.
6764         (tui_win_info::refresh): Remove.
6765         (tui_source_window_base::refresh_window): Update.
6766         (tui_refresh_all): Update.
6767         * tui/tui-layout.c (show_source_disasm_command): Remove call to
6768         refresh_window.
6769         (show_source_or_disasm_and_command): Likewise.
6770         * tui/tui-data.h (struct tui_win_info) <refresh>: Remove.
6771         (struct tui_source_window_base) <refresh>: Likewise.
6772
6773 2019-07-17  Tom Tromey  <tom@tromey.com>
6774
6775         * tui/tui-winsource.c (tui_clear_source_content)
6776         (tui_show_source_content): Update.
6777         * tui/tui-source.c (tui_source_window::showing_source_p): Check
6778         whether content is empty.
6779         * tui/tui-data.h (struct tui_source_window_base) <content_in_use>:
6780         Remove.
6781
6782 2019-07-17  Tom Tromey  <tom@tromey.com>
6783
6784         * tui/tui-winsource.c (tui_erase_source_content): Clear the
6785         window's contents.
6786         * tui/tui-source.h (tui_set_source_content_nil): Don't declare.
6787         * tui/tui-source.c (tui_set_source_content_nil): Remove.
6788
6789 2019-07-17  Tom Tromey  <tom@tromey.com>
6790
6791         * tui/tui-data.h (UNDEFINED_ITEM): Remove define.
6792         (struct tui_data_item_window): Update.
6793
6794 2019-07-17  Tom Tromey  <tom@tromey.com>
6795
6796         * tui/tui-data.h (MAX_CONTENT_COUNT, TUI_NULL_STR)
6797         (DEFAULT_HISTORY_COUNT, WITH_LOCATOR, NO_LOCATOR): Remove
6798         defines.
6799
6800 2019-07-17  Tom Tromey  <tom@tromey.com>
6801
6802         * tui/tui-winsource.h (tui_erase_source_content)
6803         (tui_clear_source_content): Remove "display_prompt" parameter.
6804         * tui/tui-winsource.c (tui_update_source_window_as_is)
6805         (tui_update_source_windows_with_addr): Update.
6806         (tui_clear_source_content): Remove "display_prompt" parameter.
6807         (tui_erase_source_content): Likewise.  Simplify.
6808         (tui_show_source_content): Update.
6809         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
6810         * tui/tui-stack.c (tui_show_frame_info): Update.
6811         * tui/tui-data.h (EMPTY_SOURCE_PROMPT, NO_EMPTY_SOURCE_PROMPT):
6812         Remove defines.
6813
6814 2019-07-17  Tom Tromey  <tom@tromey.com>
6815
6816         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
6817         * tui/tui-disasm.h (tui_set_disassem_content): Add win_info
6818         parameter.
6819         * tui/tui-disasm.c (tui_set_disassem_content): Add win_info
6820         parameter.
6821
6822 2019-07-17  Tom Tromey  <tom@tromey.com>
6823
6824         * tui/tui-winsource.c (tui_clear_source_content)
6825         (tui_show_source_content, tui_show_exec_info_content)
6826         (tui_clear_exec_info_content): Update.
6827         * tui/tui-stack.c (tui_show_locator_content): Update.
6828         (tui_show_frame_info): Update.
6829         * tui/tui-source.h (tui_source_window): Don't declare.
6830         * tui/tui-source.c (tui_source_window::showing_source_p): Rename
6831         from tui_source_is_displayed.
6832         * tui/tui-data.h (struct tui_gen_win_info) <content_in_use>:
6833         Remove field.
6834         (struct tui_source_window_base) <content_in_use>: New field.  Now
6835         bool.
6836         (struct tui_source_window) <showing_source_p>: New method.
6837         (TUI_SRC_WIN): Change cast.
6838         * tui/tui-data.c (tui_initialize_static_data): Update.
6839
6840 2019-07-17  Tom Tromey  <tom@tromey.com>
6841
6842         * tui/tui-winsource.c (tui_update_breakpoint_info): Use
6843         location_matches_p.
6844         * tui/tui-source.c (tui_source_window::location_matches_p): New
6845         method.
6846         * tui/tui-disasm.c (tui_disasm_window::location_matches_p): New
6847         method.
6848         * tui/tui-data.h (struct tui_source_window_base)
6849         <location_matches_p>: New method.
6850         (struct tui_source_window, struct tui_disasm_window)
6851         <location_matches_p>: Likewise.
6852
6853 2019-07-17  Tom Tromey  <tom@tromey.com>
6854
6855         * tui/tui-win.c (tui_set_win_height_command): Rename from
6856         tui_set_win_height.
6857         (tui_set_win_height_command): Remove.
6858
6859 2019-07-17  Tom Tromey  <tom@tromey.com>
6860
6861         * tui/tui-source.c (tui_source_window): New constructor.  Add
6862         observer.
6863         (~tui_source_window): New destructor.
6864         (tui_source_window::style_changed): New method.
6865         * tui/tui-hooks.c (tui_redisplay_source): Remove.
6866         (tui_attach_detach_observers): Update.
6867         * tui/tui-data.h (struct tui_source_window): Make constructor not
6868         inline.  Add destructor.
6869         (struct tui_source_window) <style_changed>: New method.
6870         <m_observable>: New member.
6871
6872 2019-07-17  Tom Tromey  <tom@tromey.com>
6873
6874         * tui/tui-data.c (tui_clear_source_windows_detail): Fix typo.
6875         * tui/tui-win.c (tui_resize_all): Fix typo.
6876
6877 2019-07-17  Tom Tromey  <tom@tromey.com>
6878
6879         * tui/tui-wingeneral.h (tui_refresh_all): Update.
6880         * tui/tui-wingeneral.c (make_all_visible): Use foreach.
6881         (tui_refresh_all): Remove "list" parameter.  Use foreach.
6882         * tui/tui-win.c (window_name_completer): Use foreach.
6883         (tui_refresh_all_win, tui_rehighlight_all, tui_all_windows_info)
6884         (update_tab_width): Likewise.
6885         * tui/tui-layout.c (show_layout): Update.
6886         * tui/tui-data.h (class tui_window_iterator): New.
6887         (struct all_tui_windows): New.
6888         * tui/tui-data.c (tui_partial_win_by_name): Use foreach.
6889
6890 2019-07-17  Tom Tromey  <tom@tromey.com>
6891
6892         * tui/tui-regs.c (tui_reg_next, tui_reg_prev): Add "current_group"
6893         parameter.  Don't reference globals.
6894         (tui_reg_command): Update.
6895
6896 2019-07-17  Tom Tromey  <tom@tromey.com>
6897
6898         * tui/tui-regs.c (tui_show_registers): Simplify.
6899
6900 2019-07-17  Tom Tromey  <tom@tromey.com>
6901
6902         * tui/tui-regs.c (tui_show_registers): Update.
6903         (tui_show_register_group): Add win_info parameter.
6904
6905 2019-07-17  Tom Tromey  <tom@tromey.com>
6906
6907         * tui/tui-regs.c (tui_data_window::display_reg_element_at_line):
6908         Rename from tui_display_reg_element_at_line.
6909         (tui_data_window::display_registers_from_line): Update.
6910         * tui/tui-data.h (struct tui_data_window)
6911         <display_reg_element_at_line>: New method.
6912
6913 2019-07-17  Tom Tromey  <tom@tromey.com>
6914
6915         * tui/tui-regs.h (tui_display_registers_from)
6916         (tui_display_registers_from_line): Don't declare.
6917         * tui/tui-windata.c (tui_data_window::display_all_data)
6918         (tui_data_window::refresh_all)
6919         (tui_data_window::do_scroll_vertical): Update.
6920         * tui/tui-regs.c (tui_data_window::display_registers_from): Rename
6921         from tui_display_registers_from.
6922         (tui_display_reg_element_at_line): Update.
6923         (tui_data_window::display_registers_from_line): Rename from
6924         tui_display_registers_from_line.
6925         * tui/tui-data.h (struct tui_data_window) <display_registers_from,
6926         display_registers_from_line>: New methods.
6927
6928 2019-07-17  Tom Tromey  <tom@tromey.com>
6929
6930         * tui/tui-windata.h (tui_erase_data_content): Don't declare.
6931         * tui/tui-windata.c (tui_data_window::erase_data_content): Rename
6932         from tui_erase_data_content.
6933         (tui_data_window::display_all_data)
6934         (tui_data_window::refresh_all)
6935         (tui_data_window::do_scroll_vertical): Update.
6936         * tui/tui-regs.c (tui_show_registers): Update.
6937         * tui/tui-data.h (struct tui_data_window) <erase_data_content>:
6938         New method.
6939
6940 2019-07-17  Tom Tromey  <tom@tromey.com>
6941
6942         * tui/tui-windata.h (tui_delete_data_content_windows): Don't
6943         declare.
6944         * tui/tui-windata.c
6945         (tui_data_window::delete_data_content_windows): Rename from
6946         tui_delete_data_content_windows.
6947         (tui_data_window::display_all_data)
6948         (tui_data_window::do_scroll_vertical): Update.
6949         * tui/tui-data.h (struct tui_data_window)
6950         <delete_data_content_windows>: New method.
6951
6952 2019-07-17  Tom Tromey  <tom@tromey.com>
6953
6954         * tui/tui-windata.h (tui_refresh_data_win): Don't declare.
6955         * tui/tui-regs.h (tui_first_reg_element_inline): Don't declare.
6956
6957 2019-07-17  Tom Tromey  <tom@tromey.com>
6958
6959         * tui/tui-windata.h (tui_display_all_data): Don't declare.
6960         * tui/tui-windata.c (tui_data_window::display_all_data): Rename
6961         from tui_display_all_data.
6962         * tui/tui-win.c
6963         (tui_data_window::do_make_visible_with_new_height): Update.
6964         * tui/tui-regs.c (tui_show_registers): Update.
6965         * tui/tui-layout.c (tui_set_layout): Update.
6966         * tui/tui-data.h (struct tui_data_window) <display_all_data>: New
6967         method.
6968
6969 2019-07-17  Tom Tromey  <tom@tromey.com>
6970
6971         * tui/tui-windata.h (tui_display_data_from): Don't declare.
6972         * tui/tui-windata.c (tui_display_data_from): Remove.
6973         (tui_data_window::refresh_all): Update.
6974
6975 2019-07-17  Tom Tromey  <tom@tromey.com>
6976
6977         * tui/tui-windata.h (tui_display_data_from_line): Don't declare.
6978         * tui/tui-windata.c (tui_display_data_from_line): Remove.
6979         (tui_display_data_from, tui_data_window::do_scroll_vertical): Call
6980         tui_display_registers_from_line.
6981         * tui/tui-regs.h (tui_display_registers_from_line): Update.
6982         * tui/tui-regs.c (tui_display_registers_from_line): Remove
6983         "force_display" parameter.
6984
6985 2019-07-17  Tom Tromey  <tom@tromey.com>
6986
6987         * tui/tui-regs.h (tui_first_reg_element_no_inline): Don't
6988         declare.
6989         * tui/tui-regs.c (tui_data_window::first_reg_element_no_inline):
6990         Rename from tui_first_reg_element_no_inline.
6991         (tui_display_reg_element_at_line)
6992         (tui_display_registers_from_line): Update.
6993         * tui/tui-data.h (struct tui_data_window)
6994         <first_reg_element_no_inline>: New method.
6995
6996 2019-07-17  Tom Tromey  <tom@tromey.com>
6997
6998         * tui/tui-windata.c (tui_display_data_from)
6999         (tui_data_window::do_scroll_vertical): Update.
7000         * tui/tui-regs.h (tui_line_from_reg_element_no): Don't declare.
7001         * tui/tui-regs.c (tui_data_window::line_from_reg_element_no):
7002         Rename from tui_line_from_reg_element_no.
7003         (tui_display_registers_from_line): Update.
7004         * tui/tui-data.h (struct tui_data_window)
7005         <line_from_reg_element_no>: New method.
7006
7007 2019-07-17  Tom Tromey  <tom@tromey.com>
7008
7009         * tui/tui-regs.h (tui_last_regs_line_no): Don't declare.
7010         * tui/tui-regs.c (tui_data_window::last_regs_line_no): Rename from
7011         tui_last_regs_line_no.
7012         (tui_display_reg_element_at_line)
7013         (tui_display_registers_from_line): Update.
7014         * tui/tui-data.h (struct tui_data_window) <last_regs_line_no>: New
7015         method.
7016
7017 2019-07-17  Tom Tromey  <tom@tromey.com>
7018
7019         PR tui/24722:
7020         * tui/tui-winsource.h (tui_update_all_breakpoint_info)
7021         (tui_update_breakpoint_info): Add "being_deleted" parameter.
7022         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
7023         (tui_update_all_breakpoint_info): Add "being_deleted" parameter.
7024         (tui_update_breakpoint_info): Likewise.
7025         * tui/tui-hooks.c (tui_event_create_breakpoint)
7026         (tui_event_delete_breakpoint, tui_event_modify_breakpoint):
7027         Update.
7028
7029 2019-07-17  Tom Tromey  <tom@tromey.com>
7030
7031         * tui/tui-stack.c (tui_show_frame_info): Consolidate "if"s.
7032
7033 2019-07-17  Tom Tromey  <tom@tromey.com>
7034
7035         * tui/tui-winsource.c (tui_update_source_window_as_is)
7036         (tui_update_source_windows_with_addr): Update.
7037         * tui/tui-source.h (tui_set_source_content)
7038         (tui_show_symtab_source): Add "win_info" parameter.
7039         * tui/tui-source.c (tui_set_source_content): Add "win_info"
7040         parameter.
7041         (tui_show_symtab_source): Likewise.
7042
7043 2019-07-17  Tom Tromey  <tom@tromey.com>
7044
7045         * tui/tui-wingeneral.c
7046         (tui_check_and_display_highlight_if_needed): Check can_highlight.
7047
7048 2019-07-17  Tom Tromey  <tom@tromey.com>
7049
7050         * tui/tui-data.h (struct tui_win_info) <can_scroll>: New method.
7051         (struct tui_cmd_window) <can_scroll>: New method.
7052         * tui/tui-command.c (tui_dispatch_ctrl_char): Use can_scroll
7053         method.
7054
7055 2019-07-17  Tom Tromey  <tromey@adacore.com>
7056
7057         * ui-out.h (class ui_out) <field_signed, field_fmt_signed,
7058         do_field_signed>: Rename.  Change type of "value".
7059         * ui-out.c (ui_out::field_signed): Rename from field_int.
7060         Change type of "value".
7061         (ui_out::field_fmt_signed): Rename from field_fmt_int.  Change
7062         type of "value".
7063         * tui/tui-out.h (class tui_ui_out) <do_field_signed>: Rename from
7064         do_field_int.  Change type of "value".
7065         * tui/tui-out.c (tui_ui_out::do_field_signed): Rename from
7066         do_field_int.  Change type of "value".
7067         * tracepoint.c (trace_status_mi, tfind_1)
7068         (print_one_static_tracepoint_marker): Update.
7069         * thread.c (print_thread_info_1, print_selected_thread_frame):
7070         Update.
7071         * stack.c (print_frame, print_frame_info): Update.
7072         * spu-tdep.c (info_spu_signal_command, info_spu_dma_cmdlist):
7073         Update.
7074         * source.c (print_source_lines_base): Update.
7075         * skip.c (info_skip_command): Update.
7076         * record-btrace.c (btrace_ui_out_decode_error)
7077         (btrace_call_history_src_line): Update.
7078         * python/py-framefilter.c (py_print_single_arg, py_print_frame):
7079         Update.
7080         * progspace.c (print_program_space): Update.
7081         * mi/mi-symbol-cmds.c (mi_cmd_symbol_list_lines): Update.
7082         * mi/mi-out.h (class mi_ui_out) <do_field_signed>: Rename from
7083         do_field_int.  Change type of "value".
7084         * mi/mi-out.c (mi_ui_out::do_table_begin)
7085         (mi_ui_out::do_table_header): Update.
7086         (mi_ui_out::do_field_signed): Rename from do_field_int.  Change
7087         type of "value".
7088         * mi/mi-main.c (mi_cmd_thread_list_ids, print_one_inferior)
7089         (mi_cmd_data_list_changed_registers, output_register)
7090         (mi_cmd_data_read_memory, mi_load_progress)
7091         (mi_cmd_trace_frame_collected): Update.
7092         * mi/mi-interp.c (mi_on_normal_stop_1, mi_output_solib_attribs):
7093         Update.
7094         * mi/mi-cmd-var.c (print_varobj, mi_cmd_var_create)
7095         (mi_cmd_var_delete, mi_cmd_var_info_num_children)
7096         (mi_cmd_var_list_children, varobj_update_one): Update.
7097         * mi/mi-cmd-stack.c (mi_cmd_stack_info_depth)
7098         (mi_cmd_stack_list_args, list_arg_or_local): Update.
7099         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_file): Update.
7100         * inferior.c (print_inferior): Update.
7101         * gdb_bfd.c (print_one_bfd): Update.
7102         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
7103         Update.
7104         * darwin-nat-info.c (darwin_debug_regions_recurse): Update.
7105         * cli-out.h (class cli_ui_out) <do_field_signed>: Rename from
7106         do_field_int.  Change type of "value".
7107         * cli-out.c (cli_ui_out::do_field_signed): Rename from
7108         do_field_int.  Change type of "value".
7109         * breakpoint.c (watchpoint_check, print_breakpoint_location)
7110         (print_one_breakpoint_location, print_it_catch_fork)
7111         (print_one_catch_fork, print_it_catch_vfork)
7112         (print_one_catch_vfork, print_it_catch_solib)
7113         (print_it_catch_exec, print_it_ranged_breakpoint)
7114         (print_mention_watchpoint, print_mention_masked_watchpoint)
7115         (bkpt_print_it, update_static_tracepoint): Update.
7116         * break-catch-throw.c (print_it_exception_catchpoint): Update.
7117         * break-catch-syscall.c (print_it_catch_syscall): Update.
7118         * ada-tasks.c (print_ada_task_info): Update.
7119         * ada-lang.c (print_it_exception, print_mention_exception):
7120         Update.
7121
7122 2019-07-17  Andrew Burgess  <andrew.burgess@embecosm.com>
7123
7124         PR breakpoints/24541
7125         * gdbarch.c: Regenerate.
7126         * gdbarch.h: Regenerate.
7127         * gdbarch.sh: Adjust return type and parameter types for
7128         'stap_adjust_register'.
7129         (i386_stap_adjust_register): Adjust signature and return new
7130         register name.
7131         * stap-probe.c (stap_parse_register_operand): Adjust use of
7132         'gdbarch_stap_adjust_register'.
7133
7134 2019-07-17  Tom Tromey  <tromey@adacore.com>
7135
7136         * s390-linux-nat.c (s390_watch_area): Remove typedef.  Don't
7137         declare VEC.
7138         (struct s390_debug_reg_state) <watch_areas, break_areas>: Now
7139         std::vector.
7140         (struct s390_process_info): Add initializers.
7141         (s390_add_process): Use new.
7142         (s390_linux_nat_target::low_forget_process): Use delete.
7143         (s390_linux_nat_target::low_new_fork)
7144         (s390_linux_nat_target::stopped_by_watchpoint)
7145         (s390_linux_nat_target::low_prepare_to_resume)
7146         (s390_linux_nat_target::insert_watchpoint)
7147         (s390_linux_nat_target::insert_hw_breakpoint)
7148         (s390_linux_nat_target::remove_watchpoint)
7149         (s390_linux_nat_target::remove_hw_breakpoint): Update.
7150
7151 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
7152
7153         * aarch64-fbsd-nat.c: Include regcache.h.
7154         (getregs_supplies, getfpregs_supplies): Remove unused gdbarch
7155         argument.
7156         (aarch64_fbsd_nat_target::fetch_registers)
7157         (aarch64_fbsd_nat_target::store_registers): Remove gdbarch
7158         variable.
7159         * arm-fbsd-nat.c, riscv-fbsd-nat.c: Likewise.
7160
7161 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
7162
7163         * fbsd-nat.c: Include gdbarch.h.
7164
7165 2019-07-15  Tom Tromey  <tromey@adacore.com>
7166
7167         * mi/mi-out.c (mi_ui_out::do_field_int): Use plongest.
7168
7169 2019-07-15  Tom Tromey  <tromey@adacore.com>
7170
7171         * mi/mi-out.h (class mi_ui_out) <do_field_unsigned>: Declare.
7172         * mi/mi-out.c (mi_ui_out::do_field_unsigned): New method.
7173         * cli-out.h (class cli_ui_out) <do_field_unsigned>: Declare.
7174         * cli-out.c (cli_ui_out::do_field_int): New method.
7175         * ui-out.c (ui_out::field_unsigned): New method.
7176         * symfile.c (generic_load): Use field_unsigned.
7177         (print_transfer_performance): Likewise.
7178         * record-btrace.c (ui_out_field_uint): Remove.
7179         (btrace_call_history_insn_range, btrace_call_history): Use
7180         field_unsigned.
7181         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn): Use
7182         field_unsigned.
7183         * ui-out.h (class ui_out) <field_unsigned>: New method.
7184         <do_field_unsigned>: Likewise.
7185
7186 2019-07-15  Tom Tromey  <tromey@adacore.com>
7187
7188         * mi/mi-main.c (list_available_thread_groups): Use field_string.
7189         * mi/mi-interp.c (mi_memory_changed): Use field_string.
7190         * target.c (flash_erase_command): Use field_string.
7191         * infrun.c (print_signal_received_reason): Use field_string.
7192         * i386-tdep.c (i386_mpx_print_bounds): Use field_string.
7193         * breakpoint.c (maybe_print_thread_hit_breakpoint): Use
7194         field_string.
7195         * ada-tasks.c (print_ada_task_info): Use field_string.
7196
7197 2019-07-15  Tom Tromey  <tromey@adacore.com>
7198
7199         * target.c (flash_erase_command): Use field_core_addr.
7200         * symfile.c (generic_load): Use field_core_addr.
7201         * sparc64-linux-tdep.c (sparc64_linux_handle_segmentation_fault):
7202         Use field_core_addr.
7203         * i386-linux-tdep.c (i386_linux_handle_segmentation_fault): Use
7204         field_core_addr.
7205
7206 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
7207
7208         * dwarf2loc.c (dwarf2_evaluate_property): Sign extend property
7209         value if its desired type is smaller than a CORE_ADDR and signed.
7210
7211 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
7212
7213         * dwarf2loc.c (dwarf2_evaluate_property): Update to take account
7214         of changes to field names, and use new is_reference field to
7215         decide if a property is a reference or not.
7216         * dwarf2loc.h (struct dwarf2_locexpr_baton): Add 'is_reference'
7217         field.
7218         (struct dwarf2_property_baton): Update header comment, rename
7219         'referenced_type' to 'property_type' and update comments.
7220         * dwarf2read.c (attr_to_dynamic_prop): Add extra parameter to hold
7221         default property type, store in property baton, update to take
7222         accound of renamed field.
7223         (read_func_scope): Update call to attr_to_dynamic_prop.
7224         (read_array_type): Likewise.
7225         (dwarf2_per_cu_addr_sized_int_type): New function.
7226         (read_subrange_index_type): Move type finding code to
7227         dwarf2_per_cu_addr_sized_int_type.
7228         (read_subrange_type): Update calls to attr_to_dynamic_prop.
7229         (dwarf2_per_cu_addr_type): New function.
7230         (set_die_type): Update calls to attr_to_dynamic_prop.
7231
7232 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
7233
7234         * dwarf2read.c (read_subrange_index_type): New function.
7235         (read_subrange_type): Move code into new function and call it.
7236         * gdbtypes.c (create_range_type): Add some asserts.
7237
7238 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
7239
7240         * dwarf2loc.c (dwarf2_evaluate_property): Change return type, and
7241         update return statements.
7242         * dwarf2loc.h (dwarf2_evaluate_property): Update return type on
7243         declaration, and update comment to match.
7244         * gdbtypes.c (resolve_dynamic_array): Update call to
7245         dwarf2_evaluate_property to match new return type.
7246
7247 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
7248
7249         * valarith.c (value_subscripted_rvalue): Change lowerbound
7250         parameter type from int to LONGEST.
7251         * value.h (value_subscripted_rvalue): Likewise in declaration.
7252
7253 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
7254
7255         * cli/cli-utils.c (info_print_command_completer): New function.
7256         * cli/cli-utils.h: Add 'completer.h' include, and forward
7257         declaration for 'struct cmd_list_element'.
7258         (info_print_command_completer): Declare.
7259         * stack.c (_initialize_stack): Add completer for 'info locals' and
7260         'info args'.
7261         * symtab.c (_initialize_symtab): Add completer for 'info
7262         variables' and 'info functions'.
7263         * NEWS: Mention completion for additional info commands.
7264
7265 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
7266
7267         * cli/cli-utils.c (extract_info_print_args): Delete.
7268         (extract_arg_maybe_quoted): Delete.
7269         (info_print_options_defs): New variable.
7270         (make_info_print_options_def_group): New function.
7271         (extract_info_print_options): Define new function.
7272         * cli/cli-utils.h (extract_info_print_args): Delete.
7273         (struct info_print_options): New structure.
7274         (extract_info_print_options): Declare new function.
7275         * stack.c (info_locals_command): Update to use new
7276         extract_info_print_options, also add a header comment.
7277         (info_args_command): Likewise.
7278         * symtab.c (info_variables_command): Likewise.
7279         (info_functions_command): Likewise.
7280
7281 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
7282
7283         * cli/cli-option.c (parse_option): Use extract_string_maybe_quoted
7284         to extract string arguments.
7285         * common/common-utils.c (extract_string_maybe_quoted): New function.
7286         * common/common-utils.h (extract_string_maybe_quoted): Declare.
7287
7288 2019-07-11  Tom Tromey  <tromey@adacore.com>
7289
7290         * main.c (get_init_files): Use GDBINIT, not gdbinit.
7291         * auto-load.c (file_is_auto_load_safe): Use GDBINIT, not gdbinit.
7292         * top.h (gdbinit): Don't declare.
7293         * cli/cli-cmds.c (init_cli_cmds): Remove, merging contents
7294         into...
7295         (_initialize_cli_cmds): ...here.  Use GDBINIT, not gdbinit.
7296         * top.c (gdb_init): Don't call init_cli_cmds.
7297         (gdbinit): Remove.
7298         * cli/cli-cmds.h (init_cli_cmds): Don't declare.
7299
7300 2019-07-11  Tom Tromey  <tromey@adacore.com>
7301
7302         * python/py-inferior.c (add_thread_object): Don't use thread_obj
7303         after it has been moved.
7304
7305 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
7306
7307         * valops.c (value_must_coerce_to_target): Change return type to
7308         bool.
7309         * value.h (value_must_coerce_to_target): Likewise.
7310
7311 2019-07-10  Simon Marchi  <simon.marchi@efficios.com>
7312
7313         * breakpoint.c (is_hardware_watchpoint): Remove
7314         forward-declaration.
7315         (is_masked_watchpoint): Change return type to bool.
7316         (is_tracepoint): Likewise.
7317         (is_breakpoint): Likewise.
7318         (is_hardware_watchpoint): Likewise.
7319         (is_watchpoint): Likewise.
7320         (is_no_memory_software_watchpoint): Likewise.
7321         (is_catchpoint): Likewise.
7322         (breakpoint_1): Make FILTER parameter's return type bool.
7323         is_masked_watchpoint): Change return type to bool.
7324         (save_breakpoints): Make FILTER parameter's return type bool.
7325         * breakpoint.h (is_breakpoint): Change return type to bool.
7326         (is_watchpoint): Likewise.
7327         (is_catchpoint): Likewise.
7328         (is_tracepoint): Likewise.
7329
7330 2019-07-10  Tom Tromey  <tom@tromey.com>
7331
7332         * defs.h: Don't include gdbarch.h.
7333         * aarch64-ravenscar-thread.c, aarch64-tdep.c, alpha-bsd-tdep.h,
7334         alpha-linux-tdep.c, alpha-mdebug-tdep.c, arch-utils.h, arm-tdep.h,
7335         ax-general.c, btrace.c, buildsym-legacy.c, buildsym.h, c-lang.c,
7336         cli/cli-decode.h, cli/cli-dump.c, cli/cli-script.h,
7337         cli/cli-style.h, coff-pe-read.h, compile/compile-c-support.c,
7338         compile/compile-cplus.h, compile/compile-loc2c.c, corefile.c,
7339         cp-valprint.c, cris-linux-tdep.c, ctf.c, d-lang.c, d-namespace.c,
7340         dcache.c, dicos-tdep.c, dictionary.c, disasm-selftests.c,
7341         dummy-frame.c, dummy-frame.h, dwarf2-frame-tailcall.c,
7342         dwarf2expr.c, expression.h, f-lang.c, frame-base.c,
7343         frame-unwind.c, frv-linux-tdep.c, gdbarch-selftests.c, gdbtypes.h,
7344         go-lang.c, hppa-nbsd-tdep.c, hppa-obsd-tdep.c, i386-dicos-tdep.c,
7345         i386-tdep.h, ia64-vms-tdep.c, interps.h, language.c,
7346         linux-record.c, location.h, m2-lang.c, m32r-linux-tdep.c,
7347         mem-break.c, memattr.c, mn10300-linux-tdep.c, nios2-linux-tdep.c,
7348         objfiles.h, opencl-lang.c, or1k-linux-tdep.c, p-lang.c,
7349         parser-defs.h, ppc-tdep.h, probe.h, python/py-record-btrace.c,
7350         record-btrace.c, record.h, regcache-dump.c, regcache.h,
7351         riscv-fbsd-tdep.c, riscv-linux-tdep.c, rust-exp.y,
7352         sh-linux-tdep.c, sh-nbsd-tdep.c, source-cache.c,
7353         sparc-nbsd-tdep.c, sparc-obsd-tdep.c, sparc-ravenscar-thread.c,
7354         sparc64-fbsd-tdep.c, std-regs.c, target-descriptions.h,
7355         target-float.c, tic6x-linux-tdep.c, tilegx-linux-tdep.c, top.c,
7356         tracefile.c, trad-frame.c, type-stack.h, ui-style.c, utils.c,
7357         utils.h, valarith.c, valprint.c, varobj.c, x86-tdep.c,
7358         xml-support.h, xtensa-linux-tdep.c, cli/cli-cmds.h: Update.
7359         * s390-linux-nat.c, procfs.c, inf-ptrace.c: Likewise.
7360
7361 2019-07-10  Tom Tromey  <tromey@adacore.com>
7362
7363         * ada-lang.h (is_ada_exception_catchpoint): Declare.
7364         * breakpoint.c (init_ada_exception_breakpoint): Register as
7365         bp_catchpoint.
7366         (print_one_breakpoint_location, print_one_breakpoint): Use
7367         is_ada_exception_catchpoint.
7368         * ada-lang.c (class ada_catchpoint_location): Pass
7369         bp_loc_software_breakpoint to bp_location constructor.
7370         (is_ada_exception_catchpoint): New function.
7371
7372 2019-07-10  Tom Tromey  <tromey@adacore.com>
7373
7374         * arm-tdep.c (arm_exidx_entry_s): Remove typedef.  Don't define
7375         VEC.
7376         (struct arm_exidx_entry): New method operator<.
7377         (struct arm_exidx_data) <section_maps>: Change type.
7378         (arm_exidx_data_free): Remove.
7379         (arm_exidx_data_key): Change type.  Move lower.
7380         (arm_exidx_new_objfile): Update.
7381         (arm_compare_exidx_entries): Remove.
7382         (arm_find_exidx_entry, _initialize_arm_tdep)
7383
7384 2019-07-10  Tom Tromey  <tromey@adacore.com>
7385
7386         * solib-spu.c (ocl_program_data_key): Change type.
7387         (append_ocl_sos, ocl_enable_break, _initialize_spu_solib):
7388         Update.
7389
7390 2019-07-10  Tom Tromey  <tromey@adacore.com>
7391
7392         * solib-aix.c (lm_info_aix_p): Remove typedef.  Don't define VEC.
7393         (struct solib_aix_inferior_data) <library_list>: Change type.
7394         (solib_aix_inferior_data_handle): Change type.
7395         (get_solib_aix_inferior_data): Update.
7396         (solib_aix_free_library_list): Remove.
7397         (library_list_start_library): Update.
7398         (solib_aix_parse_libraries, solib_aix_get_library_list): Change
7399         return type.
7400         (solib_aix_get_library_list)
7401         (solib_aix_solib_create_inferior_hook, solib_aix_current_sos)
7402         (solib_aix_normal_stop_observer, _initialize_solib_aix): Update.
7403
7404 2019-07-10  Tom Tromey  <tromey@adacore.com>
7405
7406         * solib-dsbt.c (struct dsbt_info): Add initializers.
7407         (solib_dsbt_pspace_data): Change type.
7408         (dsbt_pspace_data_cleanup): Remove.
7409         (get_dsbt_info, _initialize_dsbt_solib): Update.
7410
7411 2019-07-10  Tom Tromey  <tromey@adacore.com>
7412
7413         * spu-tdep.c (spu_overlay_data): Change type.
7414         (spu_get_overlay_table, spu_overlay_new_objfile)
7415         (_initialize_spu_tdep): Update.
7416
7417 2019-07-10  Tom Tromey  <tromey@adacore.com>
7418
7419         * gdb-stabs.h (struct dbx_symfile_info): Add initializers and
7420         destructor.
7421         (dbx_objfile_data_key): Change type and declare later.
7422         (DBX_SYMFILE_INFO): Rewrite.
7423         * dbxread.c (dbx_objfile_data_key): Change type.
7424         (dbx_symfile_init): Update.
7425         (~dbx_symfile_info): Rename from dbx_free_symfile_info.  Update.
7426         (coffstab_build_psymtabs, elfstab_build_psymtabs)
7427         (stabsect_build_psymtabs, _initialize_dbxread): Update.
7428
7429 2019-07-10  Tom Tromey  <tromey@adacore.com>
7430
7431         * jit.c (jit_program_space_key): Change type.  Move lower.
7432         (get_jit_program_space_data): Update.
7433         (jit_program_space_data_cleanup): Remove.
7434         (jit_breakpoint_deleted, free_objfile_data, _initialize_jit):
7435         Update.
7436         (struct jit_program_space_data): Add initializers.
7437
7438 2019-07-10  Tom Tromey  <tromey@adacore.com>
7439
7440         * solib-darwin.c (struct darwin_info): Add initializers.
7441         (solib_darwin_pspace_data): Change type.
7442         (darwin_pspace_data_cleanup): Remove.
7443         (get_darwin_info, _initialize_darwin_solib): Update.
7444
7445 2019-07-10  Tom Tromey  <tromey@adacore.com>
7446
7447         * remote-sim.c (struct sim_inferior_data): Add initializers,
7448         constructor, and destructor.
7449         (sim_inferior_data_key): Change type.  Move lower.
7450         (check_for_duplicate_sim_descriptor): Update.
7451         (get_sim_inferior_data): Use new.  Update.
7452         (~sim_inferior_data_cleanup): Rename from
7453         sim_inferior_data_cleanup.  Simplify.
7454         (gdbsim_close_inferior, simulator_command)
7455         (sim_command_completer, _initialize_remote_sim): Update.
7456         (next_pid, INITIAL_PID): Move earlier.
7457
7458 2019-07-10  Tom Tromey  <tromey@adacore.com>
7459
7460         * python/python-internal.h (create_thread_object): Return
7461         gdbpy_ref.
7462         * python/py-infthread.c (create_thread_object): Return gdbpy_ref.
7463         * python/py-inferior.c (struct threadlist_entry): Add
7464         constructor.
7465         <thread_obj>: Now a gdbpy_ref.
7466         (thread_to_thread_object): Update.
7467         (add_thread_object): Use new.
7468         (delete_thread_object): Use delete.
7469         (infpy_threads): Update.
7470         (py_free_inferior): Update.  Construct "inf_obj" after acquiring
7471         GIL.
7472
7473 2019-07-10  Tom Tromey  <tromey@adacore.com>
7474
7475         * valops.c (value_cast): Specialize error message for Ada.
7476
7477 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
7478
7479         * breakpoint.c (breakpoint_1): Update doc and parameter names.
7480
7481 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
7482
7483         * breakpoint.h (bpstat_explains_signal, bpstat_causes_stop,
7484         bpstat_should_step): Return bool, adjust comments.
7485         * breakpoint.c (bpstat_explains_signal, bpstat_causes_stop,
7486         bpstat_should_step): Likewise.
7487
7488 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
7489
7490         * features/Makefile: Use feature target descriptions for Arm.
7491         * features/arm/arm-core.c: Generate new file.
7492         * features/arm/arm-fpa.c: Likewise.
7493         * features/arm/arm-m-profile-with-fpa.xml: Likewise.
7494         * features/arm/arm-m-profile.c: Likewise.
7495         * features/arm/arm-vfpv2.c: Likewise.
7496         * features/arm/arm-vfpv3.c: Likewise.
7497         * features/arm/xscale-iwmmxt.c: Likewise.
7498         * target-descriptions.c (maint_print_c_tdesc_cmd): Add Arm.
7499
7500 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
7501
7502         * arm-linux-nat.c (arm_linux_nat_target::read_description): Check
7503         ptrace earlier.
7504
7505 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
7506
7507         * features/aarch64-pauth.c: Regenerate.
7508
7509 2019-07-09  Simon Marchi  <simon.marchi@polymtl.ca>
7510
7511         * breakpoint.h (struct bpstat_what) <is_longjmp>: Change type to
7512         bool.
7513         (bpstat_what): Use false instead of 0.
7514
7515 2019-07-09  Pedro Alves  <palves@redhat.com>
7516
7517         * break-catch-throw.c (is_exception_catchpoint): New.
7518         * breakpoint.c (print_one_breakpoint_location): New parameter
7519         'raw_loc'.  Handle it.  Use
7520         is_watchpoint/is_catchpoint/is_exception_catchpoint instead of
7521         looking at the breakpoint's type.
7522         (print_one_breakpoint): If handling "maint info breakpoints", also
7523         print locations of exception catchpoints.
7524         * breakpoint.h (is_exception_catchpoint): Declare.
7525
7526 2019-07-09  Pedro Alves  <palves@redhat.com>
7527
7528         * break-catch-throw.c (print_one_exception_catchpoint): Skip the
7529         "addr" field.
7530         (allocate_location_exception_catchpoint): New.
7531         (handle_gnu_v3_exceptions): Don't reset 'type' to bp_breakpoint.
7532         (initialize_throw_catchpoint_ops): Install
7533         allocate_location_exception_catchpoint as allocate_location
7534         method.
7535         * breakpoint.c (bpstat_what) <bp_catch>: Set action to
7536         BPSTAT_WHAT_SINGLE if not stopping and the location's type is not
7537         bp_loc_other.
7538         (breakpoint_address_is_meaningful): Delete.
7539         (bl_address_is_meaningful): New.
7540         (breakpoint_locations_match): Adjust comment.
7541         (bp_location_from_bp_type): New, factored out of...
7542         (bp_location::bp_location(breakpoint *)): ... this.
7543         (bp_location::bp_location(breakpoint *, bp_loc_type)): New,
7544         factored out of...
7545         (bp_location::bp_location(breakpoint *)): ... this.  Reimplement.
7546         (bp_loc_is_permanent): Use bl_address_is_meaningful instead of
7547         breakpoint_address_is_meaningful.
7548         (bp_locations_compare): Adjust comment.
7549         (update_global_location_list): Use bl_address_is_meaningful
7550         instead of breakpoint_address_is_meaningful.
7551         * breakpoint.h (bp_location::bp_location(breakpoint *)): New
7552         explicit.
7553         (bp_location::bp_location(breakpoint *, bp_loc_type)): Declare.
7554         * python/py-breakpoint.c (bppy_get_location): No longer check
7555         whether location is null.
7556
7557 2019-07-09  Pedro Alves  <palves@redhat.com>
7558
7559         PR c++/15468
7560         * breakpoint.c (print_one_breakpoint_location): Remove
7561         single-location assert.
7562
7563 2019-07-09  Tom Tromey  <tom@tromey.com>
7564
7565         * contrib/ari/gdb_ari.sh: Change common to gdbsupport.
7566         * configure: Rebuild.
7567         * configure.ac: Change common to gdbsupport.
7568         * gdbsupport: Rename from common.
7569         * acinclude.m4: Change common to gdbsupport.
7570         * Makefile.in (CONFIG_SRC_SUBDIR, COMMON_SFILES)
7571         (HFILES_NO_SRCDIR, stamp-version, ALLDEPFILES): Change common to
7572         gdbsupport.
7573         * aarch64-tdep.c, ada-lang.c, ada-lang.h, agent.c, alloc.c,
7574         amd64-darwin-tdep.c, amd64-dicos-tdep.c, amd64-fbsd-nat.c,
7575         amd64-fbsd-tdep.c, amd64-linux-nat.c, amd64-linux-tdep.c,
7576         amd64-nbsd-tdep.c, amd64-obsd-tdep.c, amd64-sol2-tdep.c,
7577         amd64-tdep.c, amd64-windows-tdep.c, arch-utils.c,
7578         arch/aarch64-insn.c, arch/aarch64.c, arch/aarch64.h, arch/amd64.c,
7579         arch/amd64.h, arch/arm-get-next-pcs.c, arch/arm-linux.c,
7580         arch/arm.c, arch/i386.c, arch/i386.h, arch/ppc-linux-common.c,
7581         arch/riscv.c, arch/riscv.h, arch/tic6x.c, arm-tdep.c, auto-load.c,
7582         auxv.c, ax-gdb.c, ax-general.c, ax.h, breakpoint.c, breakpoint.h,
7583         btrace.c, btrace.h, build-id.c, build-id.h, c-lang.h, charset.c,
7584         charset.h, cli/cli-cmds.c, cli/cli-cmds.h, cli/cli-decode.c,
7585         cli/cli-dump.c, cli/cli-option.h, cli/cli-script.c,
7586         coff-pe-read.c, command.h, compile/compile-c-support.c,
7587         compile/compile-c.h, compile/compile-cplus-symbols.c,
7588         compile/compile-cplus-types.c, compile/compile-cplus.h,
7589         compile/compile-loc2c.c, compile/compile.c, completer.c,
7590         completer.h, contrib/ari/gdb_ari.sh, corefile.c, corelow.c,
7591         cp-support.c, cp-support.h, cp-valprint.c, csky-tdep.c, ctf.c,
7592         darwin-nat.c, debug.c, defs.h, disasm-selftests.c, disasm.c,
7593         disasm.h, dtrace-probe.c, dwarf-index-cache.c,
7594         dwarf-index-cache.h, dwarf-index-write.c, dwarf2-frame.c,
7595         dwarf2expr.c, dwarf2loc.c, dwarf2read.c, event-loop.c,
7596         event-top.c, exceptions.c, exec.c, extension.h, fbsd-nat.c,
7597         features/aarch64-core.c, features/aarch64-fpu.c,
7598         features/aarch64-pauth.c, features/aarch64-sve.c,
7599         features/i386/32bit-avx.c, features/i386/32bit-avx512.c,
7600         features/i386/32bit-core.c, features/i386/32bit-linux.c,
7601         features/i386/32bit-mpx.c, features/i386/32bit-pkeys.c,
7602         features/i386/32bit-segments.c, features/i386/32bit-sse.c,
7603         features/i386/64bit-avx.c, features/i386/64bit-avx512.c,
7604         features/i386/64bit-core.c, features/i386/64bit-linux.c,
7605         features/i386/64bit-mpx.c, features/i386/64bit-pkeys.c,
7606         features/i386/64bit-segments.c, features/i386/64bit-sse.c,
7607         features/i386/x32-core.c, features/riscv/32bit-cpu.c,
7608         features/riscv/32bit-csr.c, features/riscv/32bit-fpu.c,
7609         features/riscv/64bit-cpu.c, features/riscv/64bit-csr.c,
7610         features/riscv/64bit-fpu.c, features/tic6x-c6xp.c,
7611         features/tic6x-core.c, features/tic6x-gp.c, filename-seen-cache.h,
7612         findcmd.c, findvar.c, fork-child.c, gcore.c, gdb_bfd.c, gdb_bfd.h,
7613         gdb_proc_service.h, gdb_regex.c, gdb_select.h, gdb_usleep.c,
7614         gdbarch-selftests.c, gdbthread.h, gdbtypes.h, gnu-nat.c,
7615         go32-nat.c, guile/guile.c, guile/scm-ports.c,
7616         guile/scm-safe-call.c, guile/scm-type.c, i386-fbsd-nat.c,
7617         i386-fbsd-tdep.c, i386-go32-tdep.c, i386-linux-nat.c,
7618         i386-linux-tdep.c, i386-tdep.c, i387-tdep.c,
7619         ia64-libunwind-tdep.c, ia64-linux-nat.c, inf-child.c,
7620         inf-ptrace.c, infcall.c, infcall.h, infcmd.c, inferior-iter.h,
7621         inferior.c, inferior.h, inflow.c, inflow.h, infrun.c, infrun.h,
7622         inline-frame.c, language.h, linespec.c, linux-fork.c, linux-nat.c,
7623         linux-tdep.c, linux-thread-db.c, location.c, machoread.c,
7624         macrotab.h, main.c, maint.c, maint.h, memattr.c, memrange.h,
7625         mi/mi-cmd-break.h, mi/mi-cmd-env.c, mi/mi-cmd-stack.c,
7626         mi/mi-cmd-var.c, mi/mi-interp.c, mi/mi-main.c, mi/mi-parse.h,
7627         minsyms.c, mips-linux-tdep.c, namespace.h,
7628         nat/aarch64-linux-hw-point.c, nat/aarch64-linux-hw-point.h,
7629         nat/aarch64-linux.c, nat/aarch64-sve-linux-ptrace.c,
7630         nat/amd64-linux-siginfo.c, nat/fork-inferior.c,
7631         nat/linux-btrace.c, nat/linux-btrace.h, nat/linux-namespaces.c,
7632         nat/linux-nat.h, nat/linux-osdata.c, nat/linux-personality.c,
7633         nat/linux-procfs.c, nat/linux-ptrace.c, nat/linux-ptrace.h,
7634         nat/linux-waitpid.c, nat/mips-linux-watch.c,
7635         nat/mips-linux-watch.h, nat/ppc-linux.c, nat/x86-dregs.c,
7636         nat/x86-dregs.h, nat/x86-linux-dregs.c, nat/x86-linux.c,
7637         nto-procfs.c, nto-tdep.c, objfile-flags.h, objfiles.c, objfiles.h,
7638         obsd-nat.c, observable.h, osdata.c, p-valprint.c, parse.c,
7639         parser-defs.h, ppc-linux-nat.c, printcmd.c, probe.c, proc-api.c,
7640         procfs.c, producer.c, progspace.h, psymtab.h,
7641         python/py-framefilter.c, python/py-inferior.c, python/py-ref.h,
7642         python/py-type.c, python/python.c, record-btrace.c, record-full.c,
7643         record.c, record.h, regcache-dump.c, regcache.c, regcache.h,
7644         remote-fileio.c, remote-fileio.h, remote-sim.c, remote.c,
7645         riscv-tdep.c, rs6000-aix-tdep.c, rust-exp.y, s12z-tdep.c,
7646         selftest-arch.c, ser-base.c, ser-event.c, ser-pipe.c, ser-tcp.c,
7647         ser-unix.c, skip.c, solib-aix.c, solib-target.c, solib.c,
7648         source-cache.c, source.c, source.h, sparc-nat.c, spu-linux-nat.c,
7649         stack.c, stap-probe.c, symfile-add-flags.h, symfile.c, symfile.h,
7650         symtab.c, symtab.h, target-descriptions.c, target-descriptions.h,
7651         target-memory.c, target.c, target.h, target/waitstatus.c,
7652         target/waitstatus.h, thread-iter.h, thread.c, tilegx-tdep.c,
7653         top.c, top.h, tracefile-tfile.c, tracefile.c, tracepoint.c,
7654         tracepoint.h, tui/tui-io.c, ui-file.c, ui-out.h,
7655         unittests/array-view-selftests.c,
7656         unittests/child-path-selftests.c, unittests/cli-utils-selftests.c,
7657         unittests/common-utils-selftests.c,
7658         unittests/copy_bitwise-selftests.c, unittests/environ-selftests.c,
7659         unittests/format_pieces-selftests.c,
7660         unittests/function-view-selftests.c,
7661         unittests/lookup_name_info-selftests.c,
7662         unittests/memory-map-selftests.c, unittests/memrange-selftests.c,
7663         unittests/mkdir-recursive-selftests.c,
7664         unittests/observable-selftests.c,
7665         unittests/offset-type-selftests.c, unittests/optional-selftests.c,
7666         unittests/parse-connection-spec-selftests.c,
7667         unittests/ptid-selftests.c, unittests/rsp-low-selftests.c,
7668         unittests/scoped_fd-selftests.c,
7669         unittests/scoped_mmap-selftests.c,
7670         unittests/scoped_restore-selftests.c,
7671         unittests/string_view-selftests.c, unittests/style-selftests.c,
7672         unittests/tracepoint-selftests.c, unittests/unpack-selftests.c,
7673         unittests/utils-selftests.c, unittests/xml-utils-selftests.c,
7674         utils.c, utils.h, valarith.c, valops.c, valprint.c, value.c,
7675         value.h, varobj.c, varobj.h, windows-nat.c, x86-linux-nat.c,
7676         xml-support.c, xml-support.h, xml-tdesc.h, xstormy16-tdep.c,
7677         xtensa-linux-nat.c, dwarf2read.h: Change common to gdbsupport.
7678
7679 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
7680
7681         * linespec.c (decode_digits_list_mode): Set explicit_line to a
7682         bool value.
7683         (decode_digits_ordinary): Set explicit_line field in sal.
7684         * symtab.c (skip_prologue_sal): Don't skip prologue for a
7685         symtab_and_line that was set on an explicit line number in
7686         assembler code.  Do always update the recorded symtab and line if
7687         we do skip the prologue.
7688
7689 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
7690
7691         * breakpoint.c (set_breakpoint_location_function): Remove
7692         explicit_loc parameter.
7693         (momentary_breakpoint_from_master): Update call to
7694         set_breakpoint_location_function.
7695         (add_location_to_breakpoint): Likewise.
7696
7697 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
7698
7699         * riscv-tdep.c (riscv_features_from_gdbarch_info): Don't modify
7700         required features based on default bfd type when no specific bfd
7701         is present.
7702
7703 2019-07-08  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7704
7705         * NEWS: Mention that GDB printf and eval commands can now print
7706         C-style and Ada-style convenience var strings without
7707         calling the inferior.
7708         * printcmd.c (printf_c_string): Locally print GDB internal var
7709         instead of transiting via the inferior.
7710         (printf_wide_c_string): Likewise.
7711
7712 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
7713
7714         PR breakpoints/25011
7715         * symfile.c (symbol_file_command): Call solib_create_inferior_hook.
7716
7717 2019-07-04  Tom Tromey  <tom@tromey.com>
7718
7719         PR tui/24724:
7720         * tui/tui-winsource.c (tui_clear_source_content): Update.
7721         (tui_source_window_base::set_is_exec_point_at): Fix comment.
7722         (tui_update_breakpoint_info): Update.
7723         (tui_set_exec_info_content): Update.
7724         * tui/tui-source.c (tui_set_source_content_nil): Update.
7725         * tui/tui-disasm.c (tui_set_disassem_content): Don't set
7726         has_break.
7727         * tui/tui-data.h (enum tui_bp_flag): New.
7728         (tui_bp_flags): New enum flags type.
7729         (struct tui_source_element) <break_mode>: Change type.  Rename
7730         from has_break.
7731         (TUI_BP_ENABLED, TUI_BP_DISABLED, TUI_BP_HIT)
7732         (TUI_BP_CONDITIONAL, TUI_BP_HARDWARE): Don't define.  Now enum
7733         constants.
7734         * tui/tui-winsource.h: Fix comment.
7735
7736 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
7737
7738         * aarch32-linux-nat.h (VFP_REGS_SIZE): Remove define.
7739         * aarch64-linux-nat.c (fetch_fpregs_from_thread)
7740         (store_fpregs_to_thread)
7741         (aarch64_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
7742         * arch/arm.h (IWMMXT_VEC_REGISTER_SIZE, ARM_CORE_REGS_SIZE)
7743         (ARM_FP_REGS_SIZE, ARM_VFP2_REGS_SIZE, ARM_VFP3_REGS_SIZE)
7744         (IWMMXT_REGS_SIZE): Add define.
7745         * arm-linux-nat.c (IWMMXT_REGS_SIZE): Remove define.
7746         (fetch_vfp_regs, store_vfp_regs)
7747         (arm_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
7748         * arm-tdep.c (arm_register_g_packet_guesses): Use new defines.
7749
7750 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
7751
7752         * arch/arm-get-next-pcs.c (thumb_get_next_pcs_raw): Use ARM_
7753         defines.
7754         * arch/arm-linux.c (arm_linux_sigreturn_next_pc_offset): Likewise.
7755         * arch/arm.h (INT_REGISTER_SIZE) Rename from...
7756         (ARM_INT_REGISTER_SIZE): ...to this.
7757         (ARM_FP_REGISTER_SIZE) (ARM_VFP_REGISTER_SIZE): Add define.
7758         * arm-linux-tdep.c (ARM_LINUX_JB_ELEMENT_SIZE)
7759         (ARM_LINUX_SIZEOF_GREGSET, arm_linux_supply_gregset)
7760         (arm_linux_collect_gregset, supply_nwfpe_register)
7761         (collect_nwfpe_register, arm_linux_collect_nwfpe): Use ARM_
7762         defines.
7763         * arm-linux-tdep.h (ARM_LINUX_SIZEOF_NWFPE, NWFPE_FPSR_OFFSET)
7764         (NWFPE_FPCR_OFFSET, NWFPE_TAGS_OFFSET): Likewise
7765         * arm-nbsd-tdep.c (ARM_NBSD_JB_ELEMENT_SIZE): Likewise.
7766         * arm-tdep.c (arm_push_dummy_call, arm_extract_return_value)
7767         (arm_return_in_memory, arm_store_return_value)
7768         (arm_get_longjmp_target, arm_register_g_packet_guesses)
7769         (arm_record_ld_st_multiple): Likewise.
7770         * arm-tdep.h (FP_REGISTER_SIZE, VFP_REGISTER_SIZE): Remove.
7771         * arm-wince-tdep.c (ARM_WINCE_JB_ELEMENT_SIZE): Use ARM_ defines.
7772
7773 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
7774
7775         * aarch64-linux-tdep.c (aarch64_linux_init_abi): Use
7776         AARCH64_DISPLACED_MODIFIED_INSNS.
7777         * aarch64-tdep.c (struct aarch64_displaced_step_data)
7778         (aarch64_displaced_step_copy_insn): Likewise.
7779         * aarch64-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
7780         (AARCH64_DISPLACED_MODIFIED_INSNS): ...to this.
7781         * arm-linux-tdep.c (arm_linux_cleanup_svc): Use
7782         ARM_DISPLACED_MODIFIED_INSNS.
7783         * arm-tdep.c (arm_gdbarch_init): Likewise.
7784         * arm-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
7785         (ARM_DISPLACED_MODIFIED_INSNS): ...to this.
7786         (struct arm_displaced_step_closure): Use
7787         ARM_DISPLACED_MODIFIED_INSNS.
7788
7789 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
7790
7791         * features/Makefile: Remove unused xml files.
7792         * features/aarch64.xml: Remove.
7793         * features/i386/amd64-avx-avx512-linux.xml: Remove.
7794         * features/i386/amd64-avx-avx512.xml: Remove.
7795         * features/i386/amd64-avx-linux.xml: Remove.
7796         * features/i386/amd64-avx-mpx-avx512-pku-linux.xml: Remove.
7797         * features/i386/amd64-avx-mpx-avx512-pku.xml: Remove.
7798         * features/i386/amd64-avx-mpx-linux.xml: Remove.
7799         * features/i386/amd64-avx-mpx.xml: Remove.
7800         * features/i386/amd64-avx.xml: Remove.
7801         * features/i386/amd64-linux.xml: Remove.
7802         * features/i386/amd64-mpx-linux.xml: Remove.
7803         * features/i386/amd64-mpx.xml: Remove.
7804         * features/i386/amd64.xml: Remove.
7805         * features/i386/i386-avx-avx512-linux.xml: Remove.
7806         * features/i386/i386-avx-avx512.xml: Remove.
7807         * features/i386/i386-avx-linux.xml: Remove.
7808         * features/i386/i386-avx-mpx-avx512-pku-linux.xml: Remove.
7809         * features/i386/i386-avx-mpx-avx512-pku.xml: Remove.
7810         * features/i386/i386-avx-mpx-linux.xml: Remove.
7811         * features/i386/i386-avx-mpx.xml: Remove.
7812         * features/i386/i386-avx.xml: Remove.
7813         * features/i386/i386-linux.xml: Remove.
7814         * features/i386/i386-mmx-linux.xml: Remove.
7815         * features/i386/i386-mmx.xml: Remove.
7816         * features/i386/i386-mpx-linux.xml: Remove.
7817         * features/i386/i386-mpx.xml: Remove.
7818         * features/i386/i386.xml: Remove.
7819         * features/i386/x32-avx-avx512-linux.xml: Remove.
7820         * features/i386/x32-avx-linux.xml: Remove.
7821         * features/i386/x32-linux.xml: Remove.
7822
7823 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
7824
7825         * regformats/aarch64.dat: Remove.
7826         * regformats/i386/amd64-avx-avx512-linux.dat: Remove.
7827         * regformats/i386/amd64-avx-linux.dat: Remove.
7828         * regformats/i386/amd64-avx-mpx-avx512-pku-linux.dat: Remove.
7829         * regformats/i386/amd64-avx-mpx-linux.dat: Remove.
7830         * regformats/i386/amd64-linux.dat: Remove.
7831         * regformats/i386/amd64-mpx-linux.dat: Remove.
7832         * regformats/i386/amd64.dat: Remove.
7833         * regformats/i386/i386-avx-avx512-linux.dat: Remove.
7834         * regformats/i386/i386-avx-linux.dat: Remove.
7835         * regformats/i386/i386-avx-mpx-avx512-pku-linux.dat: Remove.
7836         * regformats/i386/i386-avx-mpx-linux.dat: Remove.
7837         * regformats/i386/i386-linux.dat: Remove.
7838         * regformats/i386/i386-mmx-linux.dat: Remove.
7839         * regformats/i386/i386-mpx-linux.dat: Remove.
7840         * regformats/i386/i386.dat: Remove.
7841         * regformats/i386/x32-avx-avx512-linux.dat: Remove.
7842         * regformats/i386/x32-avx-linux.dat: Remove.
7843         * regformats/i386/x32-linux.dat: Remove.
7844
7845 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
7846
7847         * aarch64-tdep.c: Remove xml self tests.
7848         * amd64-linux-tdep.c: Likewise.
7849         * amd64-tdep.c: Likewise.
7850         * i386-linux-tdep.c: Likewise.
7851         * i386-tdep.c: Likewise.
7852
7853 2019-07-03  Pedro Alves  <palves@redhat.com>
7854
7855         PR cli/24732
7856         * cli/cli-cmds.c (struct pipe_cmd_opts): New.
7857         (pipe_cmd_option_defs): New.
7858         (make_pipe_cmd_options_def_group): New.
7859         (pipe_command): Use gdb::option::process_options.
7860         (pipe_command_completer): New function.
7861         (_initialize_cli_cmds): Install completer for "pipe" command.
7862
7863 2019-07-03  Pedro Alves  <palves@redhat.com>
7864
7865         * cli/cli-option.c (union option_value) <string>: New field.
7866         (struct option_def_and_value): Add ctor, move ctor, dtor and
7867         use DISABLE_COPY_AND_ASSIGN.
7868         (option_def_and_value::clear_value): New.
7869         (parse_option, save_option_value_in_ctx, get_val_type_str)
7870         (add_setshow_cmds_for_options): Handle var_string.
7871         * cli-option.h (union option_def::var_address) <string>: New
7872         field.
7873         (struct string_option_def): New.
7874         * maint-test-options.c (struct test_options_opts): Add default
7875         ctor and use DISABLE_COPY_AND_ASSIGN.
7876         <string_opt>: New field.
7877         (test_options_opts::~test_options_opts): New.
7878         (test_options_opts::dump): Also dump "-string".
7879         (test_options_option_defs): Install "string.
7880
7881 2019-07-03  Pedro Alves  <palves@redhat.com>
7882
7883         * cli/cli-option.c (parse_option) <var_enum>: Don't return an
7884         option_value with a null enumeration.
7885         (complete_options): Save the option values in the context.
7886         (save_option_value_in_ctx): New, factored out from ...
7887         (process_options): ... here.
7888         * cli/cli-utils.c (get_ulongest): Don't advance PP until the end
7889         of the function.
7890         * maint-test-options.c (test_options_opts::dump): New, factored
7891         out from ...
7892         (maintenance_test_options_command_mode): ... here.
7893         (maintenance_test_options_command_completion_result): Delete.
7894         (maintenance_test_options_command_completion_text): Update
7895         comment.
7896         (maintenance_show_test_options_completion_result): Change
7897         prototype.  Just print
7898         maintenance_test_options_command_completion_text.
7899         (save_completion_result): New.
7900         (maintenance_test_options_completer_mode): Pass options context to
7901         complete_options, and then save a dump.
7902         (_initialize_maint_test_options): Use add_cmd to install "maint
7903         show test-options-completion-result".
7904
7905 2019-07-03  Pedro Alves  <palves@redhat.com>
7906
7907         * NEWS (New commands): Mention "with" and "maint with".
7908         * cli/cli-cmds.c (with_command_1, with_command_completer_1)
7909         (with_command, with_command_completer): New.
7910         (pipe_command): Adjust to new repeat_previous
7911         interface.
7912         (_initialize_cli_cmds): Install the "with" command and its "w"
7913         alias.
7914         * cli/cli-cmds.h (with_command_1, with_command_completer_1): New
7915         declarations.
7916         * cli/cli-setshow.c (parse_cli_var_uinteger)
7917         (parse_cli_var_zuinteger_unlimited, do_set_command): Handle empty
7918         argument strings for all var_types.
7919         (get_setshow_command_value_string): New, factored out from ...
7920         (do_show_command): ... this.
7921         * cli/cli-setshow.h: Include <string>.
7922         (get_setshow_command_value_string): Declare.
7923         * command.h (repeat_previous): Now returns const char *.  Adjust
7924         comment.
7925         * maint.c: Include "cli/cli-cmds.h".
7926         (maintenance_with_cmd, maintenance_with_cmd_completer): New.
7927         (_initialize_maint_cmds): Register the "maintenance with" command.
7928         * top.c (repeat_previous): Move bits from pipe_command here:
7929         Return the saved command line, if any; error out if there's no
7930         command to relaunch.
7931
7932 2019-07-03  Pedro Alves  <palves@redhat.com>
7933
7934         * NEWS (New commands): Mention "maint set/show test-settings"
7935         instead of "maint test-settings".
7936         * maint-test-settings.c (maintenance_test_settings_list): Delete.
7937         (maintenance_test_settings_set_list): Rename to ...
7938         (maintenance_set_test_settings_list): ... this.
7939         (maintenance_test_settings_show_list): Rename to  ...
7940         (maintenance_show_test_settings_list): ... this.
7941         (maintenance_test_settings_cmd): Delete.
7942         (maintenance_test_settings_set_cmd): ...
7943         (maintenance_set_test_settings_cmd): ... this.
7944         (maintenance_test_settings_show_cmd): ...
7945         (maintenance_show_test_settings_cmd): ... this.
7946         (maintenance_test_settings_show_value_cmd):
7947         (maintenance_show_test_settings_value_cmd): ... this.
7948         (_initialize_maint_test_settings): No longer install the "maint
7949         test-settings" prefix command.  Rename "maint test-settings set"
7950         to "maint set test-settings", and "maint test-settings show" to
7951         "maint show test-settings".  Adjust all subcommands.
7952
7953 2019-07-03  Pedro Alves  <palves@redhat.com>
7954
7955         * maint-test-settings.c: Fix file's intro comment.  Replace all
7956         references to "test-options" with references to "test-settings",
7957         in comments.
7958
7959 2019-07-03  Pedro Alves  <palves@redhat.com>
7960
7961         * maint-test-settings.c (maintenance_test_settings_xxx)
7962         (maintenance_test_settings_yyy, maintenance_test_settings_zzz):
7963         New.
7964         (maintenance_test_settings_enums): Use them.
7965         (maintenance_test_settings_enum): Default to
7966         maintenance_test_settings_xxx.
7967         (_initialize_maint_test_settings): Initialize
7968         MAINTENANCE_TEST_SETTINGS_FILENAME.
7969
7970 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
7971
7972         * breakpoint.h (remove_breakpoints_inf): Change return type to
7973         void, move function documentation here.
7974         * breakpoint.c (remove_breakpoints_inf): Change return type to
7975         void, move function documentation to header.
7976
7977 2019-07-02  Pedro Alves  <palves@redhat.com>
7978
7979         * NEWS (Completion improvements): Mention "info threads".
7980         * thread.c (struct info_threads_opts, info_threads_option_defs)
7981         (make_info_threads_options_def_group): New.
7982         (info_threads_command): Use gdb::option::process_options.
7983         (info_threads_command_completer): New.
7984         (_initialize_thread): Use gdb::option::build_help to build the
7985         help text for "info threads".
7986
7987 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
7988
7989         * defs.h (generic_load): Move from here...
7990         * symfile.h (generic_load): ... to here.  Rename name parameter
7991         to args.
7992         * symfile.c (generic_load): Add comment.
7993
7994 2019-07-01  Tom Tromey  <tromey@adacore.com>
7995
7996         * dwarf2read.c
7997         (dw2_debug_names_iterator::find_vec_in_debug_names): Hoist
7998         declaration of without_params.  Fix formatting.
7999
8000 2019-07-01  Tom Tromey  <tromey@adacore.com>
8001
8002         * ada-exp.y (find_primitive_type): Update.
8003         * ada-lang.h (ada_lookup_symbol): Update.
8004         * ada-lang.c (ada_lookup_symbol): Remove "is_a_field_of_this"
8005         parameter.
8006         (ada_lookup_encoded_symbol, ada_lookup_symbol_nonlocal): Update.
8007
8008 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
8009
8010         PR breakpoints/24541
8011         * gdbarch.c: Regenerate.
8012         * gdbarch.h: Regenerate.
8013         * gdbarch.sh: Add 'stap_adjust_register'.
8014         * i386-tdep.c: Include '<unordered_set>'.
8015         (i386_stap_adjust_register): New function.
8016         (i386_elf_init_abi): Register 'i386_stap_adjust_register'.
8017         * stap-probe.c (stap_parse_register_operand): Call
8018         'gdbarch_stap_adjust_register'.
8019
8020 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
8021
8022         PR python/24742
8023         https://bugzilla.redhat.com/show_bug.cgi?id=1723564
8024         * python/python.c (do_start_initialization): Use 'xmalloc'
8025         instead of 'PyMem_Malloc'.
8026
8027 2019-06-28  Tom Tromey  <tromey@adacore.com>
8028
8029         * dwarf2read.c (partial_die_info::read): Prefer the linkage name
8030         for Ada.
8031
8032 2019-06-27  Tom Tromey  <tromey@adacore.com>
8033
8034         * arm-tdep.c (arm_objfile_data_key): Move lower.  Change type to
8035         objfile_key.
8036         (arm_find_mapping_symbol, arm_record_special_symbol)
8037         (_initialize_arm_tdep): Update.
8038         (arm_objfile_data_free): Remove.
8039
8040 2019-06-27  Tom Tromey  <tromey@adacore.com>
8041
8042         * cp-valprint.c (cp_print_value_fields): Pass opts, not options,
8043         to cp_print_static_field.
8044
8045 2019-06-26  Tom Tromey  <tromey@adacore.com>
8046
8047         * minsyms.c (lookup_minimal_symbol_solib_trampoline): Remove.
8048         * minsyms.h (lookup_minimal_symbol_solib_trampoline): Don't
8049         declare.
8050
8051 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
8052
8053         * features/aarch64-core.c (create_feature_aarch64_core):
8054         Regenerate.
8055         * features/aarch64-core.xml: Add cpsr flags.
8056
8057 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
8058
8059         * arm-tdep.c (arm_gnu_triplet_regexp): New function.
8060         (arm_gdbarch_init): Add arm_gnu_triplet_regexp.
8061
8062 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
8063
8064         * arm-tdep.c (struct arm_per_objfile) <section_maps_sorted>: New
8065         field.
8066         (arm_find_mapping_symbol): Sort mapping symbol vectors on first
8067         use.
8068         (arm_record_special_symbol): Don't insert new symbol in sorted
8069         position, push it at the end.
8070
8071 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
8072
8073         * arm-tdep.c (struct arm_mapping_symbol) (operator <): New.
8074         (arm_mapping_symbol_s): Remove.
8075         (DEF_VEC_O(arm_mapping_symbol_s)): Remove.
8076         (arm_mapping_symbol_vec): New typedef.
8077         (struct arm_per_objfile): Add constructor.
8078         <section_maps>: Change type to
8079         std::unique_ptr<arm_mapping_symbol_vec[]>.
8080         (arm_compare_mapping_symbols): Remove.
8081         (arm_find_mapping_symbol): Adjust to section_maps type change.
8082         (arm_objfile_data_free): Call delete on arm_per_objfile.
8083         (arm_record_special_symbol): Adjust to section_maps type change.
8084         Allocate arm_per_objfile with new.
8085
8086 2019-06-25  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8087
8088         * cli/cli-cmds.c (alias_command): Compare the alias prefix
8089         with the command prefix.
8090
8091 2019-06-25  Tom Tromey  <tom@tromey.com>
8092
8093         * tui/tui-wingeneral.c (tui_delete_win): Remove "return".
8094         * tui/tui-data.c (~tui_gen_win_info): Remove "if".
8095
8096 2019-06-25  Tom Tromey  <tom@tromey.com>
8097
8098         * tui/tui-layout.c (init_and_make_win): Assert on unrecognized
8099         type.
8100         * tui/tui-data.h (struct tui_gen_win_info): Make constructor
8101         protected.
8102
8103 2019-06-25  Tom Tromey  <tom@tromey.com>
8104
8105         * tui/tui-winsource.c
8106         (tui_source_window_base::set_is_exec_point_at): Add check against
8107         LOA_ADDRESS.
8108
8109 2019-06-25  Tom Tromey  <tom@tromey.com>
8110
8111         * tui/tui-source.c (tui_set_source_content): Don't check before
8112         xfree.
8113         * tui/tui-disasm.c (tui_disassemble): Don't check before xfree.
8114
8115 2019-06-25  Tom Tromey  <tom@tromey.com>
8116
8117         * tui/tui-winsource.h (tui_update_source_window_as_is)
8118         (tui_alloc_source_buffer, tui_line_is_displayed)
8119         (tui_addr_is_displayed): Change type of win_info.
8120         * tui/tui-winsource.c (tui_update_source_window_as_is)
8121         (tui_clear_source_content, tui_show_source_line)
8122         (tui_show_source_content, tui_source_window_base::refill)
8123         (tui_source_window_base::set_is_exec_point_at)
8124         (tui_source_window_base::set_is_exec_point_at)
8125         (tui_update_breakpoint_info, tui_set_exec_info_content): Update.
8126         (tui_alloc_source_buffer, tui_line_is_displayed)
8127         (tui_addr_is_displayed): Change type of win_info.  Update.
8128         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
8129         (tui_source_window_base::do_make_visible_with_new_height):
8130         Update.
8131         * tui/tui-source.c (tui_set_source_content)
8132         (tui_set_source_content_nil)
8133         (tui_source_window::do_scroll_vertical): Update.
8134         * tui/tui-layout.c (show_layout): Update.
8135         * tui/tui-disasm.c (tui_set_disassem_content)
8136         (tui_disasm_window::do_scroll_vertical): Update.
8137         * tui/tui-data.h (tui_win_content): Remove.
8138         (struct tui_gen_win_info) <content, content_size>: Remove.
8139         (struct tui_source_element): Add initializers and destructor.
8140         (union tui_which_element, struct tui_win_element): Remove.
8141         (struct tui_source_window_base) <content>: New field.
8142         (struct tui_data_window): Remove destructor.
8143         (tui_alloc_content, tui_free_win_content)
8144         (tui_free_all_source_wins_content): Don't declare.
8145         * tui/tui-data.c (tui_initialize_static_data): Update.
8146         (init_content_element, tui_alloc_content): Remove.
8147         (~tui_gen_win_info): Update.
8148         (~tui_data_window, tui_free_all_source_wins_content)
8149         (tui_free_win_content, free_content, free_content_elements):
8150         Remove.
8151
8152 2019-06-25  Tom Tromey  <tom@tromey.com>
8153
8154         * tui/tui-winsource.h (tui_clear_source_content)
8155         (tui_erase_source_content, tui_show_source_content): Change type
8156         of win_info.
8157         * tui/tui-winsource.c (tui_clear_source_content)
8158         (tui_erase_source_content, tui_show_source_content): Change type
8159         of win_info.
8160         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
8161         * tui/tui-source.h (tui_set_source_content_nil): Change type of
8162         win_info.
8163         * tui/tui-source.c (tui_set_source_content_nil): Change type of
8164         win_info.
8165         * tui/tui-layout.c (show_source_or_disasm_and_command): Update.
8166
8167 2019-06-25  Tom Tromey  <tom@tromey.com>
8168
8169         * tui/tui-winsource.c (tui_clear_source_content)
8170         (tui_source_window_base::set_is_exec_point_at): Update.
8171         * tui/tui-source.c (tui_set_source_content_nil): Update.
8172         * tui/tui-data.h (struct tui_source_element) <is_exec_point>: Now
8173         a bool.
8174         * tui/tui-data.c (init_content_element): Update.
8175
8176 2019-06-25  Tom Tromey  <tom@tromey.com>
8177
8178         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Update.
8179         * tui/tui-win.c (make_invisible_and_set_new_height): Update.
8180         * tui/tui-layout.c (init_and_make_win): Update.
8181         * tui/tui.h (enum tui_win_type): Update.
8182         * tui/tui-data.h (tui_win_is_auxiliary): Rename from
8183         tui_win_is_auxillary.
8184         * tui/tui-data.c (tui_win_is_auxiliary): Rename from
8185         tui_win_is_auxillary.
8186
8187 2019-06-25  Tom Tromey  <tom@tromey.com>
8188
8189         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Update.
8190         * tui/tui-windata.c (tui_data_window::first_data_item_displayed)
8191         (tui_delete_data_content_windows, tui_display_all_data)
8192         (tui_data_window::do_scroll_vertical, tui_display_data_from):
8193         Update.
8194         * tui/tui-win.c (tui_data_window::set_new_height): Simplify.
8195         * tui/tui-regs.c (tui_last_regs_line_no)
8196         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
8197         (tui_show_registers): Update.
8198         (tui_show_register_group): Return void.  Update.
8199         (tui_display_registers_from, tui_display_reg_element_at_line)
8200         (tui_display_registers_from_line, tui_check_register_values):
8201         Update.
8202         * tui/tui-data.h (union tui_which_element) <data_window>: Remove
8203         member.
8204         (struct tui_data_window) <regs_content>: Now a std::vector.
8205         <regs_content_count>: Remove.
8206         (tui_add_content_elements, tui_free_data_content): Don't declare.
8207         * tui/tui-data.c (tui_data_window::clear_detail): Update.
8208         (init_content_element): Remove DATA_WIN case.  Add assert.
8209         (tui_add_content_elements): Remove.
8210         (tui_data_window): Update.
8211         (tui_free_data_content): Remove.
8212         (free_content_elements): Remove DATA_WIN case.
8213
8214 2019-06-25  Tom Tromey  <tom@tromey.com>
8215
8216         * tui/tui-data.c (tui_data_item_window): Update.
8217         * tui/tui-windata.h (tui_check_data_values): Don't declare.
8218         * tui/tui-windata.c (tui_display_all_data)
8219         (tui_display_data_from_line): Update.
8220         (tui_check_data_values): Remove.
8221         * tui/tui-regs.c (tui_show_register_group)
8222         (tui_display_reg_element_at_line): Update.
8223         * tui/tui-hooks.c (tui_register_changed)
8224         (tui_refresh_frame_and_register_information): Call
8225         tui_check_register_values.
8226         * tui/tui-data.h (struct tui_data_window) <data_content,
8227         data_content_count, data_type>: Remove.
8228         (enum tui_data_type): Remove.
8229
8230         * tui/tui-data.c (tui_data_window::clear_detail)
8231         (~tui_data_window): Update.
8232
8233 2019-06-25  Tom Tromey  <tom@tromey.com>
8234
8235         * tui/tui-windata.h (tui_first_data_item_displayed): Don't
8236         declare.
8237         * tui/tui-windata.c (tui_data_window::first_data_item_displayed):
8238         Rename from tui_first_data_item_displayed.  Update.
8239         (tui_data_window::refresh_all)
8240         (tui_data_window::do_scroll_vertical): Update.
8241         * tui/tui-data.h (struct tui_data_window)
8242         <first_data_item_displayed>: Declare new method.
8243
8244 2019-06-25  Tom Tromey  <tom@tromey.com>
8245
8246         * tui/tui-data.h (tui_init_generic_part): Don't declare.
8247         * tui/tui-data.c (tui_init_generic_part): Remove, moving
8248         contents...
8249         (tui_initialize_static_data): ...here.
8250
8251 2019-06-25  Tom Tromey  <tom@tromey.com>
8252
8253         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
8254         (tui_display_registers_from, tui_check_register_values): Update.
8255         (tui_display_register): Remove win_info parameter; update.
8256         (tui_get_register): Change type of parameters.
8257         * tui/tui-data.h (struct tui_data_element): Remove.
8258         (union tui_which_element) <data>: Remove.
8259         <data_window>: Change type.
8260         (struct tui_data_item_window): New.
8261         * tui/tui-data.c (init_content_element): Remove DATA_ITEM_WIN
8262         case.  Add assert.
8263         (~tui_data_item_window): New destructor.
8264         (free_content_elements): Remove DATA_ITEM_WIN case.
8265
8266 2019-06-25  Tom Tromey  <tom@tromey.com>
8267
8268         * tui/tui.h (enum tui_win_type) <MAX_WINDOWS, UNDEFINED_WIN>:
8269         Remove.
8270
8271 2019-06-25  Tom Tromey  <tom@tromey.com>
8272
8273         * tui/tui-data.h (struct tui_command_element): Remove.
8274         (union tui_which_element) <command>: Remove.
8275         * tui/tui-data.c (init_content_element): Remove CMD_WIN case.  Add
8276         assert.
8277         (free_content_elements): Remove CMD_WIN case.
8278
8279 2019-06-25  Tom Tromey  <tom@tromey.com>
8280
8281         * tui/tui-layout.c (tui_set_layout): Update.
8282         * tui/tui-data.h (struct tui_layout_def) <split>: Remove.
8283         * tui/tui-data.c (layout_def): Update.
8284
8285 2019-06-25  Tom Tromey  <tom@tromey.com>
8286
8287         * tui/tui-wingeneral.c (tui_refresh_all): Update.
8288         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
8289         (tui_source_window_base::set_new_height): Update.
8290         * tui/tui-stack.c (tui_make_status_line): Change parameter type.
8291         Update.
8292         (tui_set_locator_fullname, tui_set_locator_info)
8293         (tui_show_frame_info): Update.
8294         * tui/tui-source.c (tui_set_source_content)
8295         (tui_source_is_displayed): Update.
8296         * tui/tui-layout.c (show_source_disasm_command, show_data)
8297         (show_source_or_disasm_and_command): Update.
8298         * tui/tui-disasm.c (tui_set_disassem_content)
8299         (tui_get_begin_asm_address): Update.
8300         * tui/tui-data.h (struct tui_locator_element): Remove.
8301         (union tui_which_element) <locator>: Remove.
8302         (struct tui_locator_window): New.
8303         (tui_locator_win_info_ptr): Change return type.
8304         * tui/tui-data.c (_locator): Change type.
8305         (tui_locator_win_info_ptr): Change return type.
8306         (init_content_element): Remove LOCATOR_WIN case.  Add assert.
8307         (tui_alloc_content): Add assert.
8308
8309 2019-06-25  Tom Tromey  <tom@tromey.com>
8310
8311         * tui/tui-winsource.c
8312         (tui_exec_info_window::maybe_allocate_content): New method.
8313         (tui_set_exec_info_content, tui_show_exec_info_content): Update.
8314         * tui/tui-layout.c (init_and_make_win): Add EXEC_INFO_WIN case.
8315         (make_source_or_disasm_window): Add cast.
8316         * tui/tui-data.h (union tui_which_element) <simple_string>:
8317         Remove.
8318         (struct tui_source_info): New.
8319         (struct tui_source_window_base) <execution_info>: Change type.
8320         * tui/tui-data.c (init_content_element): Remove EXEC_INFO_WIN
8321         case, and add assert.
8322         (tui_alloc_content): Add assert.
8323
8324 2019-06-25  Tom Tromey  <tom@tromey.com>
8325
8326         * tui/tui-data.h (tui_alloc_win_info): Don't declare.
8327         * tui/tui-layout.c (init_and_make_win): Use "new" directly.
8328         * tui/tui-data.c (tui_alloc_win_info): Remove.
8329
8330 2019-06-25  Tom Tromey  <tom@tromey.com>
8331
8332         * tui/tui-win.c (tui_set_win_focus_to): Don't check window type.
8333         * tui/tui-wingeneral.c (tui_unhighlight_win): Check
8334         can_highlight.
8335
8336 2019-06-25  Tom Tromey  <tom@tromey.com>
8337
8338         * tui/tui-win.c (tui_source_window_base::update_tab_width): Call
8339         make_visible_with_new_height method.
8340         (tui_win_info::make_visible_with_new_height): New method.
8341         (tui_source_window_base::do_make_visible_with_new_height)
8342         (tui_data_window::do_make_visible_with_new_height)
8343         (tui_cmd_window::do_make_visible_with_new_height): New methods.
8344         (make_visible_with_new_height): Remove.
8345         (tui_resize_all, tui_adjust_win_heights): Use
8346         make_visible_with_new_height method.
8347         * tui/tui-data.h (struct tui_win_info)
8348         <do_make_visible_with_new_height, make_visible_with_new_height>:
8349         New methods.
8350         (struct tui_source_window_base, struct tui_data_window)
8351         (struct tui_cmd_window) <do_make_visible_with_new_height>: New
8352         methods.
8353
8354 2019-06-25  Tom Tromey  <tom@tromey.com>
8355
8356         * tui/tui-win.c (tui_source_window_base::update_tab_width): New
8357         method.
8358         (update_tab_width): Call update_tab_width method.
8359         * tui/tui-data.h (struct tui_win_info)
8360         (struct tui_source_window_base) <update_tab_width>: New methods.
8361
8362 2019-06-25  Tom Tromey  <tom@tromey.com>
8363
8364         * tui/tui-wingeneral.h (tui_make_window): Change type of "box_it"
8365         parameter.
8366         * tui/tui-wingeneral.c (tui_make_window): Change type of "box_it"
8367         parameter.
8368         (tui_gen_win_info::make_visible): Update.
8369         * tui/tui-layout.c (init_and_make_win): Change type of "box_it"
8370         parameter.
8371         * tui/tui-data.h (enum tui_box): New enum.
8372         (BOX_WINDOW, DONT_BOX_WINDOW): Remove defines.
8373
8374 2019-06-25  Tom Tromey  <tom@tromey.com>
8375
8376         * tui/tui-layout.c (make_source_or_disasm_window): Always use
8377         init_and_make_win for EXEC_INFO_WIN.
8378         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>: No
8379         longer inline.
8380         (struct tui_win_info) <~tui_win_info>: Inline.
8381         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
8382         Don't declare.
8383         * tui/tui-data.c (source_win, disasm_win): Remove globals.
8384         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
8385         Remove.
8386         (tui_initialize_static_data): Update.
8387         (~tui_gen_win_info): Handle more cleanup here.
8388         (~tui_source_window_base): Delete "execution_info".
8389         (~tui_win_info): Move code to ~tui_gen_win_info; remove.
8390
8391 2019-06-25  Tom Tromey  <tom@tromey.com>
8392
8393         * tui/tui-layout.c (make_command_window): Don't set
8394         can_highlight.
8395         (show_source_disasm_command): Call the reset method.
8396         (show_data): Don't set can_highlight.  Call the reset method.
8397         (tui_gen_win_info::reset): Rename from init_gen_win_info
8398         (init_and_make_win): Simplify.  Return tui_gen_win_info.
8399         (show_source_or_disasm_and_command): Call the reset method.
8400         * tui/tui-data.h (struct tui_gen_win_info) <reset>: New method.
8401         (struct tui_cmd_window): Set can_highlight.
8402
8403 2019-06-25  Tom Tromey  <tom@tromey.com>
8404
8405         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Rename
8406         from make_visible.
8407         (tui_make_visible, tui_make_invisible): Rewrite.
8408         (tui_win_info::make_visible): Remove.
8409         (tui_source_window_base::make_visible): Update.
8410         * tui/tui-data.h (struct tui_gen_win_info) <make_visible>: New
8411         method.  Moved from...
8412         (struct tui_win_info) <make_visible>: ...here.
8413
8414 2019-06-25  Tom Tromey  <tom@tromey.com>
8415
8416         * tui/tui-winsource.c
8417         (tui_source_window_base::do_scroll_horizontal): Remove direction
8418         parameter.
8419         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Remove
8420         direction parameter.
8421         * tui/tui-win.c (tui_win_info::forward_scroll)
8422         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
8423         (tui_win_info::right_scroll): Update.
8424         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Remove
8425         direction parameter.
8426         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Remove
8427         direction parameter.
8428         * tui/tui-data.h (enum tui_scroll_direction): Remove.
8429         (struct tui_win_info) <do_scroll_vertical, do_scroll_horizontal>:
8430         Remove direction parameter.
8431         (struct tui_source_window_base, struct tui_source_window)
8432         (struct tui_disasm_window, struct tui_data_window)
8433         (struct tui_cmd_window): Update.
8434
8435 2019-06-25  Tom Tromey  <tom@tromey.com>
8436
8437         * tui/tui-winsource.h (tui_set_exec_info_content)
8438         (tui_show_exec_info_content, tui_erase_exec_info_content)
8439         (tui_clear_exec_info_content, tui_update_exec_info): Change
8440         argument to tui_source_window_base.
8441         * tui/tui-winsource.c (tui_set_exec_info_content)
8442         (tui_show_exec_info_content, tui_erase_exec_info_content)
8443         (tui_clear_exec_info_content, tui_update_exec_info): Change
8444         argument to tui_source_window_base.
8445
8446 2019-06-25  Tom Tromey  <tom@tromey.com>
8447
8448         * tui/tui-winsource.h (tui_set_exec_info_content): Return void.
8449         * tui/tui-winsource.c (tui_set_exec_info_content): Return void.
8450
8451 2019-06-25  Tom Tromey  <tom@tromey.com>
8452
8453         * tui/tui-winsource.c (tui_set_exec_info_content): Remove NULL
8454         check.
8455
8456 2019-06-25  Tom Tromey  <tom@tromey.com>
8457
8458         * tui/tui-winsource.h (tui_alloc_source_buffer): Change return
8459         type to void.
8460         * tui/tui-winsource.c (tui_alloc_source_buffer): Change return
8461         type to void.
8462         * tui/tui-source.c (tui_set_source_content): Update.
8463         * tui/tui-disasm.c (tui_set_disassem_content): Update.
8464
8465 2019-06-25  Tom Tromey  <tom@tromey.com>
8466
8467         * tui/tui-win.c (window_name_completer, tui_set_focus)
8468         (tui_all_windows_info): Use name method.
8469         * tui/tui-data.h (struct tui_gen_win_info)
8470         (struct tui_source_window, struct tui_disasm_window)
8471         (struct tui_data_window, struct tui_cmd_window) <name>: New
8472         method.
8473         (tui_win_name): Don't declare.
8474         * tui/tui-data.c (tui_partial_win_by_name): Use name method.
8475         (tui_win_name): Remove.
8476
8477 2019-06-25  Tom Tromey  <tom@tromey.com>
8478
8479         * tui/tui-winsource.h (tui_update_source_window)
8480         (tui_update_source_window_as_is): Change parameter type.
8481         * tui/tui-winsource.c (tui_update_source_window): Change win_info
8482         to be a tui_source_window_base.
8483         (tui_update_source_window_as_is): Likewise.
8484         * tui/tui-win.c (make_visible_with_new_height): Update.
8485
8486 2019-06-25  Tom Tromey  <tom@tromey.com>
8487
8488         * tui/tui-winsource.c (tui_erase_source_content)
8489         (tui_show_source_content, tui_show_exec_info_content)
8490         (tui_erase_exec_info_content): Use refresh_window method.
8491         * tui/tui-wingeneral.h (tui_refresh_win): Don't declare.
8492         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Rename
8493         from tui_refresh_win.
8494         (tui_data_window::refresh_window): New method.
8495         (tui_win_info::refresh, tui_source_window_base::refresh)
8496         (tui_refresh_all): Use refresh_window method.
8497         * tui/tui-stack.c (tui_show_locator_content): Call refresh_window
8498         method.
8499         * tui/tui-regs.c (tui_display_register): Call refresh_window
8500         method.
8501         * tui/tui-layout.c (show_source_disasm_command)
8502         (show_source_or_disasm_and_command): Call refresh_window method.
8503         * tui/tui-data.h (struct tui_gen_win_info)
8504         (struct tui_data_window, struct tui_cmd_window) <refresh_window>:
8505         New method.
8506
8507 2019-06-25  Tom Tromey  <tom@tromey.com>
8508
8509         * tui/tui.c (tui_rl_other_window, tui_enable)
8510         (tui_is_window_visible, tui_get_command_dimension): Update.
8511         * tui/tui-winsource.c (tui_update_source_window_as_is)
8512         (tui_clear_source_content, tui_erase_source_content)
8513         (tui_show_source_line, tui_source_window_base::refill)
8514         (tui_source_window_base::do_scroll_horizontal)
8515         (tui_source_window_base::set_is_exec_point_at)
8516         (tui_update_breakpoint_info, tui_set_exec_info_content)
8517         (tui_alloc_source_buffer, tui_line_is_displayed)
8518         (tui_addr_is_displayed): Update.
8519         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
8520         (tui_check_and_display_highlight_if_needed)
8521         (tui_win_info::make_visible, tui_win_info::refresh)
8522         (tui_refresh_all): Update.
8523         * tui/tui-windata.c (tui_first_data_item_displayed)
8524         (tui_delete_data_content_windows, tui_erase_data_content)
8525         (tui_display_all_data, tui_data_window::refresh_all)
8526         (tui_check_data_values): Update.
8527         * tui/tui-win.c (window_name_completer, tui_update_gdb_sizes)
8528         (tui_set_win_focus_to, tui_win_info::forward_scroll)
8529         (tui_win_info::backward_scroll, tui_refresh_all_win)
8530         (tui_resize_all, tui_set_focus, tui_all_windows_info)
8531         (update_tab_width, tui_set_win_height, tui_adjust_win_heights)
8532         (tui_source_window_base::set_new_height)
8533         (tui_data_window::set_new_height)
8534         (make_invisible_and_set_new_height)
8535         (make_visible_with_new_height, new_height_ok)
8536         (parse_scrolling_args): Update.
8537         * tui/tui-stack.c (tui_show_frame_info): Update.
8538         * tui/tui-source.c (tui_set_source_content)
8539         (tui_set_source_content_nil, tui_source_is_displayed)
8540         (tui_source_window::do_scroll_vertical): Update.
8541         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
8542         (tui_display_registers_from, tui_display_reg_element_at_line)
8543         (tui_check_register_values, tui_reg_command): Update.
8544         * tui/tui-layout.c (tui_default_win_height)
8545         (show_source_disasm_command, show_data, init_and_make_win)
8546         (show_source_or_disasm_and_command): Update.
8547         * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
8548         (tui_redisplay_readline, tui_mld_flush)
8549         (tui_mld_erase_entire_line, tui_mld_getc, tui_cont_sig)
8550         (tui_getc): Update.
8551         * tui/tui-disasm.c (tui_set_disassem_content)
8552         (tui_disasm_window::do_scroll_vertical): Update.
8553         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>:
8554         Now virtual.
8555         (struct tui_win_info): Derive from tui_gen_win_info.
8556         <~tui_win_info>: Mark as override.
8557         <generic>: Remove member.
8558         * tui/tui-data.c (tui_cmd_window::clear_detail, tui_next_win)
8559         (tui_prev_win, tui_partial_win_by_name, tui_win_info)
8560         (~tui_data_window, ~tui_win_info)
8561         (tui_free_all_source_wins_content): Update.
8562         * tui/tui-command.c (tui_refresh_cmd_win): Update.
8563
8564 2019-06-25  Tom Tromey  <tom@tromey.com>
8565
8566         * tui/tui-layout.c (init_and_make_win): Use new.
8567         * tui/tui-data.h (struct tui_gen_win_info): Add constructor,
8568         destructor, initializers.
8569         (tui_alloc_generic_win_info): Don't declare.
8570         * tui/tui-data.c (_locator): Add argument to constructor.
8571         (source_win, disasm_win): New globals.
8572         (exec_info): Remove.
8573         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
8574         Update.
8575         (tui_alloc_generic_win_info): Remove.
8576         (init_content_element): Use new.
8577         (tui_win_info::tui_win_info): Update.
8578         (free_content_elements) <case DATA_WIN>: Use delete.
8579
8580 2019-06-25  Tom Tromey  <tom@tromey.com>
8581
8582         * tui/tui-wingeneral.c (tui_refresh_win): Update.
8583         * tui/tui-windata.c (tui_first_data_item_displayed)
8584         (tui_delete_data_content_windows): Update.
8585         * tui/tui-win.c (tui_data_window::set_new_height): Update.
8586         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
8587         (tui_display_registers_from, tui_check_register_values): Update.
8588         * tui/tui-data.h (union tui_which_element) <data_window>: Now a
8589         pointer.
8590         * tui/tui-data.c (init_content_element): Update.  Allocate the new
8591         window.
8592         (tui_free_data_content): Update.
8593         (free_content_elements) <case DATA_WIN>: Free the window.
8594
8595 2019-06-25  Tom Tromey  <tom@tromey.com>
8596
8597         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win):
8598         Update.
8599         * tui/tui-layout.c (make_command_window)
8600         (show_source_disasm_command, show_data, init_and_make_win)
8601         (show_source_or_disasm_and_command): Update.
8602         * tui/tui-data.h (struct tui_win_info) <set_highlight>: New
8603         method.
8604         <can_highight, is_highlighted>: Now bool.
8605         (tui_set_win_highlight): Don't declare.
8606         * tui/tui-data.c (tui_set_win_highlight): Remove.
8607
8608 2019-06-25  Tom Tromey  <tom@tromey.com>
8609
8610         * tui/tui-wingeneral.c (make_visible): Remove check of window
8611         type.
8612
8613 2019-06-25  Tom Tromey  <tom@tromey.com>
8614
8615         * tui/tui-win.c (tui_win_info::max_height)
8616         (tui_cmd_window::max_height): New methods.
8617         (new_height_ok): Call max_height.
8618         * tui/tui-data.h (struct tui_win_info, struct tui_cmd_window)
8619         <max_height>: New method.
8620
8621 2019-06-25  Tom Tromey  <tom@tromey.com>
8622
8623         * tui/tui-win.c (tui_source_window_base::set_new_height)
8624         (tui_data_window::set_new_height): New methods.
8625         (make_invisible_and_set_new_height): Call set_new_height method.
8626         * tui/tui-data.h (struct tui_win_info)
8627         (struct tui_source_window_base, struct tui_data_window)
8628         <set_new_height>: New method.
8629
8630 2019-06-25  Tom Tromey  <tom@tromey.com>
8631
8632         * tui/tui.c (tui_rl_other_window): Call the refresh_all method.
8633         * tui/tui-windata.c (tui_data_window::refresh_all): Rename from
8634         tui_refresh_data_win.
8635         * tui/tui-win.c (tui_source_window_base::refresh_all): New
8636         method.
8637         (tui_refresh_all_win): Call the refresh_all method.
8638         (tui_set_focus): Likewise.
8639         * tui/tui-data.h (struct tui_win_info) <refresh_all>: New method.
8640         (struct tui_source_window_base, struct tui_data_window) <refresh>:
8641         Likewise.
8642
8643 2019-06-25  Tom Tromey  <tom@tromey.com>
8644
8645         * tui/tui-winsource.h (tui_refill_source_window)
8646         (tui_set_is_exec_point_at): Don't declare.
8647         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
8648         (tui_source_window_base::refill): Rename from
8649         tui_refill_source_window.
8650         (tui_source_window_base::do_scroll_horizontal): Update.
8651         (tui_source_window_base::set_is_exec_point_at): Rename from
8652         tui_set_is_exec_point_at.
8653         (tui_update_all_breakpoint_info): Update.
8654         * tui/tui-stack.c (tui_show_frame_info): Update.
8655         * tui/tui-layout.c (show_data): Add cast.
8656         * tui/tui-hooks.c (tui_redisplay_source): Call refill method.
8657         * tui/tui-data.h (struct tui_source_window_base) <refill,
8658         set_is_exec_point_at>: New methods.
8659         (tui_source_windows, tui_add_to_source_windows): Update types.
8660         (tui_add_to_source_windows): Remove redundant declaration.
8661         * tui/tui-data.c (source_windows): Store tui_source_window_base.
8662         (tui_source_windows): Change return type.
8663         (tui_clear_source_windows_detail): Update.
8664         (tui_add_to_source_windows): Change type of parameter.
8665         (tui_free_all_source_wins_content): Update.
8666
8667 2019-06-25  Tom Tromey  <tom@tromey.com>
8668
8669         * tui/tui-wingeneral.c (tui_win_info::refresh)
8670         (tui_source_window_base::refresh): New methods.
8671         (tui_refresh_all): Call the refresh method.
8672         * tui/tui-data.h (struct tui_win_info)
8673         (struct tui_source_window_base) <refresh>: New method.
8674
8675 2019-06-25  Tom Tromey  <tom@tromey.com>
8676
8677         * tui/tui.h (tui_is_window_visible): Return bool.
8678         * tui/tui.c (tui_is_window_visible): Return bool.
8679         * tui/tui-wingeneral.c (tui_make_window, make_visible)
8680         (tui_make_visible, tui_make_invisible)
8681         (tui_win_info::make_visible)
8682         (tui_source_window_base::make_visible, make_all_visible)
8683         (tui_make_all_visible, tui_make_all_invisible): Update.
8684         * tui/tui-windata.c (tui_delete_data_content_windows): Update.
8685         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: Now
8686         bool.
8687         (struct tui_win_info, struct tui_source_window_base)
8688         (struct tui_cmd_window) <make_visible>: Change parameter to bool.
8689         * tui/tui-data.c (tui_init_generic_part): Update.
8690
8691 2019-06-25  Tom Tromey  <tom@tromey.com>
8692
8693         * tui/tui-wingeneral.c (tui_win_info::make_visible)
8694         (tui_source_window_base::make_visible): New methods.
8695         (make_all_visible): Make method call.
8696         * tui/tui-data.h (struct tui_win_info) <make_visible>: New method.
8697         (struct tui_source_window_base, struct tui_cmd_window): Override
8698         make_visible.
8699         (tui_win_is_source_type): Don't declare.
8700         * tui/tui-data.c (tui_win_is_source_type): Remove.
8701
8702 2019-06-25  Tom Tromey  <tom@tromey.com>
8703
8704         * tui/tui-layout.c (show_source_or_disasm_and_command): Remove
8705         NULL check.
8706
8707 2019-06-25  Tom Tromey  <tom@tromey.com>
8708
8709         * tui/tui-data.h (struct tui_data_window, struct tui_cmd_window):
8710         Inline constructor.  Add initializers for members.
8711         * tui/tui-data.c (tui_data_window, tui_cmd_window): Remove
8712         constructors; now inline in class.
8713
8714 2019-06-25  Tom Tromey  <tom@tromey.com>
8715
8716         * tui/tui-regs.c (tui_show_registers): Update.
8717         * tui/tui-data.h (struct tui_data_window) <display_regs>: Now
8718         bool.
8719         * tui/tui-data.c (tui_data_window::clear_detail)
8720         (tui_data_window): Update.
8721
8722 2019-06-25  Tom Tromey  <tom@tromey.com>
8723
8724         * tui/tui-windata.c (tui_display_all_data)
8725         (tui_display_data_from_line, tui_display_data_from)
8726         (tui_check_data_values, tui_data_window::do_scroll_vertical):
8727         Update.
8728         * tui/tui-regs.c (tui_last_regs_line_no)
8729         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
8730         (tui_show_registers, tui_show_register_group)
8731         (tui_display_registers_from, tui_display_reg_element_at_line)
8732         (tui_display_registers_from_line, tui_check_register_values)
8733         (tui_reg_next, tui_reg_prev): Update.
8734         * tui/tui-layout.c (tui_set_layout, show_data): Update.
8735         * tui/tui-data.h (struct tui_data_info): Remove.  Move contents to
8736         tui_data_window.
8737         (struct tui_win_info) <detail>: Remove.  Add new fields from
8738         tui_data_info.
8739         (TUI_DATA_WIN): Add cast.
8740         * tui/tui-data.c (tui_data_window::clear_detail, tui_data_window)
8741         (~tui_data_window): Simplify.
8742
8743 2019-06-25  Tom Tromey  <tom@tromey.com>
8744
8745         * tui/tui-layout.c (show_source_disasm_command)
8746         (show_source_or_disasm_and_command): Update.
8747         * tui/tui-io.c (update_cmdwin_start_line)
8748         (tui_redisplay_readline): Update.
8749         * tui/tui-data.h (struct tui_command_info): Remove.
8750         (struct tui_win_info) <detail>: Remove command_info member.
8751         (struct tui_data_window) <start_line>: New member, from
8752         tui_command_info.
8753         (TUI_CMD_WIN): Add casts.
8754
8755 2019-06-25  Tom Tromey  <tom@tromey.com>
8756
8757         * tui/tui-winsource.c (tui_update_source_window)
8758         (tui_refill_source_window)
8759         (tui_source_window_base::do_scroll_horizontal)
8760         (tui_update_breakpoint_info, tui_set_exec_info_content)
8761         (tui_show_exec_info_content, tui_erase_exec_info_content)
8762         (tui_clear_exec_info_content): Update.
8763         * tui/tui-wingeneral.c (make_all_visible, tui_refresh_all):
8764         Update.
8765         * tui/tui-win.c (make_invisible_and_set_new_height)
8766         (make_visible_with_new_height): Update.
8767         * tui/tui-source.c (tui_set_source_content)
8768         (tui_show_symtab_source): Update.
8769         * tui/tui-layout.c (extract_display_start_addr)
8770         (show_source_disasm_command, show_data)
8771         (make_source_or_disasm_window)
8772         (show_source_or_disasm_and_command): Update.
8773         * tui/tui-disasm.c (tui_set_disassem_content): Simplify.
8774         (tui_disasm_window::do_scroll_vertical): Remove shadowing
8775         "gdbarch".
8776         * tui/tui-data.h (struct tui_source_info): Remove.  Move contents
8777         to tui_source_window_base.
8778         (struct tui_win_info) <detail>: Remove source_info member.
8779         (struct tui_source_window_base) <has_locator>: Inline.
8780         Move contents from tui_source_info; rename has_locator member to
8781         m_has_locator.
8782         (TUI_SRC_WIN, TUI_DISASM_WIN): Add casts.
8783         * tui/tui-data.c (tui_source_window_base::has_locator): Move to
8784         header file.
8785         (tui_source_window_base::clear_detail, ~tui_source_window_base):
8786         Simplify.
8787         (tui_free_all_source_wins_content): Cast to
8788         tui_source_window_base.
8789
8790 2019-06-25  Tom Tromey  <tom@tromey.com>
8791
8792         * tui/tui-win.c (make_invisible_and_set_new_height)
8793         (make_visible_with_new_height): Call has_locator method.
8794         * tui/tui-layout.c (show_source_disasm_command, show_data)
8795         (show_source_or_disasm_and_command): Update for bool change.
8796         * tui/tui-data.h (struct tui_source_info) <has_locator>: Now bool.
8797         (tui_win_info) <has_locator>: New method.
8798         (struct tui_source_window_base) <has_locator>: New method.
8799         (tui_win_has_locator): Don't declare.
8800         * tui/tui-data.c (tui_source_window_base::has_locator): Rename
8801         from tui_win_has_locator.
8802         (tui_source_window_base): Use false, not FALSE.
8803
8804 2019-06-25  Tom Tromey  <tom@tromey.com>
8805
8806         * tui/tui-data.h (tui_clear_win_detail): Don't declare.
8807         * tui/tui-data.c (tui_clear_source_windows_detail): Call the
8808         clear_detail method directly.
8809         (tui_clear_win_detail): Remove.
8810
8811 2019-06-25  Tom Tromey  <tom@tromey.com>
8812
8813         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Use
8814         "this", not TUI_DISASM_WIN.
8815
8816 2019-06-25  Tom Tromey  <tom@tromey.com>
8817
8818         * tui/tui-winsource.h (tui_horizontal_source_scroll):  Don't
8819         declare.
8820         * tui/tui-winsource.c
8821         (tui_source_window_base::do_scroll_horizontal): Rename from
8822         tui_horizontal_source_scroll.
8823         * tui/tui-windata.h (tui_vertical_data_scroll): Don't declare.
8824         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Rename
8825         from tui_vertical_data_scroll.
8826         * tui/tui-win.h (tui_scroll): Don't declare.
8827         * tui/tui-win.c (tui_win_info::forward_scroll)
8828         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
8829         (tui_win_info::right_scroll): Rename and update.
8830         (tui_scroll_forward_command, tui_scroll_backward_command)
8831         (tui_scroll_left_command, tui_scroll_right_command): Update.
8832         (tui_scroll): Remove.
8833         * tui/tui-source.h: Don't declare tui_vertical_source_scroll.
8834         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Rename
8835         from tui_vertical_source_scroll.
8836         * tui/tui-disasm.h (tui_vertical_disassem_scroll): Don't declare.
8837         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Rename
8838         from tui_vertical_disassem_scroll.
8839         * tui/tui-data.h (struct tui_win_info) <do_scroll_vertical,
8840         do_scroll_horizontal>: New methods.
8841         <forward_scroll, backward_scroll, left_scroll, right_scroll>:
8842         Likewise.
8843         (struct tui_source_window_base): Add do_scroll_horizontal.
8844         (struct tui_source_window, struct tui_disasm_window): Add
8845         do_scroll_vertical.
8846         (struct tui_data_window, struct tui_cmd_window): Add
8847         do_scroll_horizontal and do_scroll_vertical.
8848         * tui/tui-command.c (tui_dispatch_ctrl_char): Use method calls.
8849
8850 2019-06-25  Tom Tromey  <tom@tromey.com>
8851
8852         * tui/tui-data.h (struct tui_source_window_base): New struct.
8853         (struct tui_source_window): Derive from tui_source_window_base.
8854         (struct tui_disasm_window): New struct.
8855         * tui/tui-data.c (tui_source_window_base::clear_detail): Rename
8856         from tui_source_window::clear_detail.
8857         (tui_source_window_base): Rename from tui_source_window.
8858         (~tui_source_window_base): Rename from ~tui_source_window.
8859         (tui_alloc_win_info): Create a tui_disasm_window.
8860
8861 2019-06-25  Tom Tromey  <tom@tromey.com>
8862
8863         * tui/tui-data.h (struct tui_source_window)
8864         (struct tui_data_window): Declare destructors.
8865         * tui/tui-data.c (~tui_source_window, ~tui_data_window): New
8866         destructors.
8867         (tui_win_info): Simplify.
8868
8869 2019-06-25  Tom Tromey  <tom@tromey.com>
8870
8871         * tui/tui-winsource.c (tui_display_main)
8872         (tui_update_source_windows_with_addr)
8873         (tui_update_all_breakpoint_info): Update.
8874         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
8875         (new_height_ok, parse_scrolling_args): Update.
8876         * tui/tui-stack.c (tui_show_frame_info): Update.
8877         * tui/tui-data.h (struct tui_list): Remove.
8878         (tui_source_windows): Return a reference to a std::vector.
8879         * tui/tui-data.c (source_windows): Now a std::vector.
8880         (tui_source_windows): Change return type.
8881         (tui_clear_source_windows): Rewrite.
8882         (tui_clear_source_windows_detail, tui_add_to_source_windows)
8883         (tui_free_all_source_wins_content): Rewrite.
8884
8885 2019-06-25  Tom Tromey  <tom@tromey.com>
8886
8887         * tui/tui-data.h (struct tui_win_info, struct tui_source_window)
8888         (struct tui_data_window, struct tui_cmd_window): Declare
8889         clear_detail method.
8890         * tui/tui-data.c (tui_source_window::clear_detail)
8891         (tui_cmd_window::clear_detail, tui_data_window::clear_detail): New
8892         methods.
8893         (tui_clear_win_detail): Simplify.
8894
8895 2019-06-25  Tom Tromey  <tom@tromey.com>
8896
8897         * tui/tui-layout.c (make_source_window, make_disasm_window)
8898         (make_source_or_disasm_window): Remove win_info_ptr parameter.
8899         Return the new window.
8900         (show_source_disasm_command, show_data)
8901         (show_source_or_disasm_and_command): Update.
8902
8903 2019-06-25  Tom Tromey  <tom@tromey.com>
8904
8905         * tui/tui-layout.c (make_command_window): Remove win_info_ptr
8906         parameter.  Return the new window.
8907         (show_source_disasm_command): Update and remove NULL check.
8908         (show_source_or_disasm_and_command): Update.
8909
8910 2019-06-25  Tom Tromey  <tom@tromey.com>
8911
8912         * tui/tui-layout.c (init_and_make_win): Remove NULL check.
8913
8914 2019-06-25  Tom Tromey  <tom@tromey.com>
8915
8916         * tui/tui-data.h (struct tui_win_info): Make constructor
8917         protected.  Make destructor virtual.  Add initializers.
8918         (tui_source_window, tui_data_window, tui_cmd_window): New
8919         classes.
8920         * tui/tui-data.c (tui_win_info): Rename from init_win_info.  Now a
8921         constructor.  Add "type" parameter.
8922         (tui_source_window, tui_data_window, tui_cmd_window): New
8923         constructors.
8924         (tui_alloc_win_info): Instantiate the appropriate subclass.
8925
8926 2019-06-25  Tom Tromey  <tom@tromey.com>
8927
8928         * tui/tui-win.c (tui_resize_all): Use delete.
8929         * tui/tui-data.h (struct tui_win_info) <~tui_win_info>: Declare
8930         destructor.
8931         (tui_free_window): Don't declare.
8932         * tui/tui-data.c (~tui_win_info): Rename from tui_free_window.
8933         Update.
8934
8935 2019-06-25  Tom Tromey  <tom@tromey.com>
8936
8937         * tui/tui-data.h (struct tui_win_info): Add constructor.
8938         * tui/tui-data.c (tui_alloc_win_info): Use new.
8939         (tui_free_window): Use delete.
8940
8941 2019-06-22  Tom Tromey  <tom@tromey.com>
8942
8943         * tui/tui-windata.h (tui_first_data_element_no_in_line): Don't
8944         declare.
8945         * tui/tui-windata.c (tui_first_data_element_no_in_line): Remove.
8946
8947 2019-06-22  Tom Tromey  <tom@tromey.com>
8948
8949         * tui/tui-data.h (tui_del_window, tui_del_data_windows): Don't
8950         declare.
8951         * tui/tui-data.c (tui_del_window, tui_del_data_windows): Remove.
8952
8953 2019-06-22  Tom de Vries  <tdevries@suse.de>
8954
8955         * dwarf2read.c (create_addrmap_from_aranges)
8956         (read_debug_names_from_section): Print ptrdiff_t using '%s' and plongest
8957         instead of '%zu'.
8958
8959 2019-06-21  Simon Marchi  <simon.marchi@efficios.com>
8960
8961         * dwarf2read.h (dwarf2_section_info_def): Remove.
8962         (DEF_VEC_O (dwarf2_section_info_def)): Remove.
8963         * dwarf2read.c (struct dwo_sections) <types>: Change type to
8964         std::vector<dwarf2_section_info>.
8965         (struct dwo_file) <~dwo_file>: Remove.
8966         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't manually free
8967         types field.
8968         (dwarf2_per_objfile::locate_sections): Adjust to std::vector.
8969         (dwarf2_read_debug_names): Likewise.
8970         (create_debug_types_hash_table): Change parameter type to
8971         array_view, adjust code accordingly.
8972         (dwarf2_locate_dwo_sections): Adjust to std::vector.
8973         (partial_die_info::fixup): Likewise.
8974         (determine_prefix): Likewise.
8975         * dwarf-index-write.c (write_psymtabs_to_index): Adjust.
8976
8977 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
8978
8979         * dwarf2read.c (struct dwo_file) <dbfd>: Change type to
8980         gdb_bfd_ref_ptr.
8981         <~dwo_file>: Remove call to gdb_bfd_unref.
8982         (open_and_init_dwo_file): Move gdb_bfd_ref_ptr into dbfd field. Call
8983         gdb_bfd_ref_ptr::get.
8984
8985 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
8986
8987         * dwarf2read.h (struct dwarf2_per_objfile) <dwo_files>: Change
8988         type to htab_up.
8989         * dwarf2read.c (struct dwo_file): Initialize fields.
8990         <~dwo_file>: New.
8991         (free_dwo_file): Remove, move content to ~dwo_file.
8992         (struct dwo_file_deleter): Remove.
8993         (dwo_file_up>: Remove custom deleter.
8994         (free_dwo_files): Remove.
8995         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't explicitly free
8996         dwo_files.
8997         (process_skeletonless_type_units): Call unique_ptr::get.
8998         (allocate_dwo_file_hash_table): Add deleter to created hash
8999         table.  Change return type to htab_up.
9000         (lookup_dwo_file_slot): Don't memset dwo_file, call
9001         unique_ptr::get.
9002         (create_dwo_unit_in_dwp_v1): Allocate dwo_file with new.
9003         (create_dwo_unit_in_dwp_v2): Likewise.
9004         (open_and_init_dwo_file): Likewise.
9005         (free_dwo_file_from_slot): Remove.
9006
9007 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
9008
9009         * dwarf2read.h (struct dwarf2_section_info) <readin,
9010         is_virtual>: Change type to bool.
9011         * dwarf2read.c (dwarf2_read_section, create_dwp_v2_section): Use
9012         true instead of 1.
9013
9014 2019-06-19  Tom Tromey  <tom@tromey.com>
9015
9016         * tui/tui-data.h (tui_init_content_element): Don't declare.
9017
9018 2019-06-19  Tom Tromey  <tom@tromey.com>
9019
9020         * tui/tui-data.h (tui_init_win_info): Don't declare.
9021
9022 2019-06-19  Tom de Vries  <tdevries@suse.de>
9023
9024         * dwarf2read.h (abstract_to_concrete): Change type to
9025         std::unordered_map<sect_offset, std::vector<sect_offset>,
9026         gdb::hash_enum<sect_offset>>.
9027
9028 2019-06-19  Tom Tromey  <tromey@adacore.com>
9029
9030         * ada-lang.c (ada_evaluate_subexp) <case OP_ATR_FIRST>: Handle
9031         EVAL_AVOID_SIDE_EFFECTS specially.
9032
9033 2019-06-19  Tom Tromey  <tromey@adacore.com>
9034
9035         * source-cache.c (highlighter): New global.
9036         (source_cache::get_source_lines): Create a highlighter on demand.
9037
9038 2019-06-18  Andrew Burgess  <andrew.burgess@embecosm.com>
9039
9040         * defs.h (deprecated_interactive_hook): Delete declaration.
9041         * interps.c (clear_interpreter_hooks): Remove use of
9042         deprecated_interactive_hook.
9043         * top.c (deprecated_interactive_hook): Delete definition.
9044         * utils.c (maybe_quit): Remove use of deprecated_interactive_hook.
9045
9046 2019-06-18  Tom de Vries  <tdevries@suse.de>
9047
9048         PR gdb/24515
9049         * dwarf2read.h (abstract_to_concrete): Change type from
9050         std::unordered_map<die_info_ptr, std::vector<die_info_ptr>> to
9051         std::unordered_map<sect_offset, std::vector<sect_offset>>.
9052         * dwarf2read.c (read_variable): Update.
9053         (dwarf2_fetch_die_loc_sect_off): Update.
9054
9055 2019-06-17  Tom de Vries  <tdevries@suse.de>
9056
9057         PR gdb/24617
9058         * common/pathstuff.c (child_path): Make sure parent_len > 0 before
9059         accessing parent[parent_len - 1].
9060
9061 2019-06-17  Paul Pluzhnikov  <ppluzhnikov@google.com>
9062
9063         PR gdb/24364
9064         * gdb/dtrace-probe.c (dtrace_static_probe_ops::get_probe): Don't
9065         call dtrace_process_dof with NULL dof.
9066
9067 2019-06-16  Tom de Vries  <tdevries@suse.de>
9068
9069         PR gdb/24445
9070         * contrib/gdb-add-index.sh: Update to handle dwz-m-ed executable.
9071
9072 2019-06-16  Tom Tromey  <tom@tromey.com>
9073
9074         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
9075         (make_all_visible): Use address of member.
9076
9077 2019-06-16  Tom Tromey  <tom@tromey.com>
9078
9079         * tui/tui-data.c (tui_clear_win_detail, init_win_info)
9080         (tui_free_window, free_content, free_content_elements): Remove
9081         unnecessary cast.
9082         * tui/tui-windata.c (tui_display_all_data): Remove unnecessary
9083         cast.
9084         * tui/tui-regs.c (tui_show_register_group)
9085         (tui_display_registers_from, tui_display_reg_element_at_line):
9086         Remove unnecessary cast.
9087
9088 2019-06-16  Andrew Burgess  <andrew.burgess@embecosm.com>
9089
9090         * linux-nat.c (normal_mask): Delete.
9091         (_initialize_linux_nat): Don't initialise normal_mask.
9092
9093 2019-06-16  Simon Marchi  <simon.marchi@polymtl.ca>
9094
9095         PR gdb/24445
9096         * dwarf-index-write.h (write_psymtabs_to_index): Add
9097         dwz_basename parameter.
9098         * dwarf-index-write.c (write_gdbindex): Move file writing to
9099         write_gdbindex_1.  Change return type void.
9100         (assert_file_size): Move up, remove filename parameter.
9101         (write_gdbindex_1): New function.
9102         (write_debug_names): Change return type to void, call
9103         assert_file_size.
9104         (struct index_wip_file): New struct.
9105         (write_psymtabs_to_index): Add dwz_basename parameter.  Move
9106         file logic to index_wip_file.  Write index for dwz file if
9107         needed.
9108         (save_gdb_index_command): Pass basename of dwz file, if present.
9109         * dwarf-index-cache.c (index_cache::store): Obtain and pass
9110         build-id of dwz file, if present.
9111         * dwarf2read.c (struct dwz_file): Move to dwarf2read.h.
9112         (dwarf2_get_dwz_file): Likewise.
9113         * dwarf2read.h (struct dwz_file): Move from dwarf2read.c.
9114         (dwarf2_get_dwz_file): Likewise.
9115
9116 2019-06-16  Tom Tromey  <tom@tromey.com>
9117
9118         * coffread.c (process_coff_symbol): Use xstrdup.
9119         * value.c (create_internalvar): Use xstrdup.
9120
9121 2019-06-16  Tom Tromey  <tom@tromey.com>
9122
9123         * valops.c (value_cast, value_slice): Remove unnecessary cast.
9124         * breakpoint.c (stopin_command, stopat_command)
9125         (until_break_command, decode_location_default): Remove unnecessary
9126         cast.
9127         * utils.c (subset_compare): Remove unnecessary cast.
9128         * ada-lang.c (ada_update_initial_language): Remove unnecessary
9129         cast.
9130         * linespec.c (decode_line_with_last_displayed): Remove unnecessary
9131         cast.
9132         * infcmd.c (path_command): Remove unnecessary cast.
9133         * coffread.c (decode_type): Remove unnecessary cast.
9134         * xcoffread.c (read_xcoff_symtab): Remove unnecessary cast.
9135         * mipsread.c (mipscoff_symfile_read): Remove unnecessary cast.
9136         * tui/tui-stack.c (tui_show_locator_content)
9137         (tui_show_frame_info): Remove unnecessary cast.
9138         * tui/tui-win.c (tui_scroll_forward_command)
9139         (tui_scroll_backward_command, tui_set_focus, tui_set_win_height)
9140         (parse_scrolling_args): Remove unnecessary cast.
9141         * tui/tui-data.c (init_win_info, tui_del_window)
9142         (tui_free_window, tui_del_data_windows, tui_free_data_content)
9143         (free_content_elements): Remove unnecessary cast.
9144         * tui/tui-windata.c (tui_first_data_item_displayed): Remove
9145         unnecessary cast.
9146         * tui/tui-source.c (tui_set_source_content)
9147         (tui_vertical_source_scroll): Remove unnecessary cast.
9148         * tui/tui-layout.c (tui_default_win_height): Remove unnecessary
9149         cast.
9150         * tui/tui-io.c (tui_initialize_io): Remove unnecessary cast.
9151         * tui/tui-regs.c (tui_display_registers_from)
9152         (tui_display_register): Remove unnecessary cast.
9153         * tui/tui-wingeneral.c (tui_refresh_win, tui_delete_win)
9154         (tui_unhighlight_win, tui_highlight_win, tui_make_window)
9155         (make_visible): Remove unnecessary cast.
9156         * tui/tui-winsource.c (tui_erase_source_content)
9157         (tui_update_breakpoint_info, tui_set_exec_info_content): Remove
9158         unnecessary cast.
9159         * ax-gdb.c (agent_command_1): Remove unnecessary cast.
9160         * cli/cli-setshow.c (cmd_show_list): Remove unnecessary cast.
9161         * stabsread.c (read_type, read_array_type, read_range_type):
9162         Remove unnecessary cast.
9163         * mdebugread.c (mdebug_build_psymtabs): Remove unnecessary cast.
9164         (parse_symbol, parse_type, upgrade_type, parse_external)
9165         (parse_partial_symbols, psymtab_to_symtab_1, cross_ref): Remove
9166         unnecessary cast.
9167         * gdb_bfd.c (gdb_bfd_map_section): Remove unnecessary cast.
9168
9169 2019-06-16  Tom Tromey  <tom@tromey.com>
9170
9171         * tui/tui-data.c (tui_alloc_generic_win_info)
9172         (tui_alloc_win_info, tui_add_content_elements): Remove NULL
9173         checks.
9174
9175 2019-06-16  Bernhard Heckel  <bernhard.heckel@intel.com>
9176             Andrew Burgess  <andrew.burgess@embecosm.com>
9177
9178         * f-typeprint.c (f_print_type): Don't return early for not
9179         associated or not allocated types.
9180         (f_type_print_varspec_suffix): Add print_rank parameter and print
9181         ranks of array types in case they dangling.
9182         (f_type_print_base): Add print_rank parameter.
9183
9184 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
9185
9186         * NEWS: Mention new MI commands.
9187         * break-catch-throw.c (enum exception_event_kind): Move to
9188         breakpoint.h.
9189         (print_mention_exception_catchpoint): Output text as a single
9190         message.
9191         (catch_exception_command_1): Rename to...
9192         (catch_exception_event): ...this, make non-static, update header
9193         command, and change some parameter types.
9194         (catch_catch_command): Update for changes to
9195         catch_exception_command_1.
9196         (catch_throw_command): Likewise.
9197         (catch_rethrow_command): Likewise.
9198         * breakpoint.c (enum exception_event_kind): Delete.
9199         * breakpoint.h (enum exception_event_kind): Moved here from
9200         break-catch-throw.c.
9201         (catch_exception_event): Declare.
9202         * mi/mi-cmd-catch.c (mi_cmd_catch_exception_event): New function.
9203         (mi_cmd_catch_throw): New function.
9204         (mi_cmd_catch_rethrow): New function.
9205         (mi_cmd_catch_catch): New function.
9206         * mi/mi-cmds.c (mi_cmds): Add 'catch-throw', 'catch-rethrow', and
9207         'catch-catch' entries.
9208         * mi/mi-cmds.h (mi_cmd_catch_throw): Declare.
9209         (mi_cmd_catch_rethrow): Declare.
9210         (mi_cmd_catch_catch): Declare.
9211
9212 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
9213
9214         * annotate.c (annotate_source_line): Change return type to void,
9215         update implementation to match.
9216         * annotate.h (annotate_source_line): Change return type to void,
9217         update header comment.
9218         * stack.c (print_frame_info): Don't change what frame information
9219         is printed based on whether annotations are on or not.
9220
9221 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
9222
9223         * annotate.c: Add 'source.h' and 'objfiles.h' includes.
9224         (annotate_source): Make static.
9225         (annotate_source_line): Moved from source.c and renamed from
9226         identify_source_line.  Update the return type.
9227         * annotate.h (annotate_source): Delete declaration.
9228         (annotate_source_line): Declaration moved from source.h, and
9229         renamed from identify_source_line.  Return type updated.
9230         * source.c (identify_source_line): Moved to annotate.c and renamed
9231         to annotate_source_line.
9232         (info_line_command): Remove check of annotation_level.
9233         * source.h (identify_source_line): Move declaration to annotate.h
9234         and rename to annotate_source_line.
9235         * stack.c: Add 'annotate.h' include.
9236         (print_frame_info): Remove check of annotation_level before
9237         calling annotate_source_line.
9238
9239 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
9240
9241         * source-cache.c (source_cache::get_plain_source_lines): Use
9242         open_source_file_with_line_charpos instead of just
9243         open_source_file, remove call to find_source_lines.
9244         (source_cache::get_source_lines): Likewise.
9245         * source.c (find_source_lines): Make static.
9246         (get_filename_and_charpos): Renamed into...
9247         (open_source_file_with_line_charpos): ..this along with changes to
9248         return a scoped_fd, and some other minor clean ups.
9249         (identify_source_line): Use open_source_file_with_line_charpos.
9250         (search_command_helper): Use open_source_file_with_line_charpos
9251         instead of just open_source_file, remove call to
9252         find_source_lines.
9253         * source.h (open_source_file_with_line_charpos): Declare new
9254         function.
9255         (find_source_lines): Delete declaration.
9256
9257 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
9258
9259         * source.c (get_filename_and_charpos): Remove fullname
9260         parameter.
9261         (identify_source_line): Update call to get_filename_and_charpos.
9262
9263 2019-06-14  Tom Tromey  <tromey@adacore.com>
9264
9265         PR gdb/24502:
9266         * ui-style.h (skip_ansi_escape): Update comment.
9267         * ui-file.h (class no_terminal_escape_file): New class.
9268         * ui-file.c (no_terminal_escape_file::write)
9269         (no_terminal_escape_file::puts): New methods.
9270         * cli/cli-logging.c (handle_redirections): Use
9271         no_terminal_escape_file.
9272
9273 2019-06-14  Tom Tromey  <tromey@adacore.com>
9274
9275         * NEWS: Move convenience variable news above Python news.
9276
9277 2019-06-14  Tom Tromey  <tom@tromey.com>
9278
9279         * gnulib: Move directory to top-level.
9280         * configure.ac: Don't configure gnulib.
9281         * configure: Rebuild.
9282         * common/common-defs.h: Use new path to gnulib.
9283         * Makefile.in (GNULIB_BUILDDIR): Now ../gnulib.
9284         (GNULIB_H): Remove.
9285         (INCGNU): Look in new gnulib location.
9286         (HFILES_NO_SRCDIR): Remove gnulib files.
9287         (SUBDIR, REQUIRED_SUBDIRS): Remove gnulib.
9288         (generated_files): Remove GNULIB_H.
9289         ($(LIBGNU), all-lib): Remove targets.
9290         (distclean): Don't mention GNULIB_BUILDDIR.
9291         ($(GNULIB_BUILDDIR)/Makefile): Remove target.
9292
9293 2019-06-14  Tom Tromey  <tromey@adacore.com>
9294
9295         * symfile.c (add_symbol_file_command): Remove obsolete comment.
9296         Warn if symbol file does not provide any symbols.
9297
9298 2019-06-14  Tom Tromey  <tromey@adacore.com>
9299
9300         * source.c (find_and_open_source): Respect basenames_may_differ.
9301
9302 2019-06-14  Andrew Burgess  <andrew.burgess@embecosm.com>
9303
9304         * annotate.c (annotate_breakpoints_invalid): Make use of
9305         scoped_restore_terminal_state.
9306         (annotate_frames_invalid): Likewise.
9307
9308 2019-06-14  Tom Tromey  <tromey@adacore.com>
9309
9310         * ada-lang.c (ada_evaluate_subexp) <case BINOP_ASSIGN>: Always
9311         allow assignment to an internalvar.
9312
9313 2019-06-14  Tom Tromey  <tromey@adacore.com>
9314
9315         * ada-lex.l: Allow "_" in attribute names.
9316
9317 2019-06-14  Tom Tromey  <tromey@adacore.com>
9318
9319         PR gdb/24653:
9320         * regcache.c (registers_changed): Don't call alloca.
9321         * top.c (execute_command): Don't call alloca.
9322
9323 2019-06-13  Pedro Alves  <palves@redhat.com>
9324
9325         * cli/cli-setshow.c (cli/cli-setshow.c): New parameter
9326         'expression'.  When parsing an expression, error out if there's
9327         junk after "unlimited".
9328         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
9329         (do_set_command): Adjust calls to is_unlimited_literal.
9330
9331 2019-06-13  Pedro Alves  <palves@redhat.com>
9332
9333         * compile/compile.c (make_compile_options_def_group): Add braces
9334         around array_view initializer.
9335         * thread.c (make_thread_apply_all_options_def_group)
9336         (make_thread_apply_all_options_def_group): Likewise.
9337
9338 2019-06-13  Pedro Alves  <palves@redhat.com>
9339
9340         * NEWS (New commands): Mention "maint test-options
9341         require-delimiter", "maint test-options unknown-is-error", "maint
9342         test-options unknown-is-operand" and "maint show
9343         test-options-completion-result".
9344         (New command options, command completion): New section.
9345         (Completion improvements): New section.
9346         Mention that you can abbreviate "unlimited".
9347
9348 2019-06-13  Pedro Alves  <palves@redhat.com>
9349
9350         * cli/cli-utils.c (parse_flags, parse_flags_qcs): Delete.
9351         * cli/cli-utils.h (parse_flags, parse_flags_qcs): Delete.
9352         * unittests/cli-utils-selftests.c (test_parse_flags)
9353         (test_parse_flags_qcs): Delete.
9354         (test_cli_utils): Don't call deleted functions.
9355
9356 2019-06-13  Pedro Alves  <palves@redhat.com>
9357
9358         * thread.c: Include "cli/cli-option.h".
9359         (tp_array_compar_ascending): Global.
9360         (tp_array_compar): Delete function.
9361         (tp_array_compar_ascending, tp_array_compar_descending): New
9362         functions.
9363         (ascending_option_def, qcs_flag_option_def)
9364         (thr_qcs_flags_option_defs)
9365         (make_thread_apply_all_options_def_group)
9366         (make_thread_apply_options_def_group): New.
9367         (thread_apply_all_command): Use gdb::option::process_options.
9368         (thread_apply_command_completer)
9369         (thread_apply_all_command_completer): New.
9370         (thread_apply_command): Use gdb::option::process_options.
9371         (_initialize_thread): Delete THREAD_APPLY_FLAGS_HELP, replace it
9372         with a new THREAD_APPLY_OPTION_HELP.  Use gdb::option::build_help
9373         to generate help text of "thread apply".  Adjust "taas"'s help.
9374         * tid-parse.c (tid_range_parser::in_thread_range): New method.
9375         * tid-parse.h (tid_range_parser::in_thread_range): New method.
9376
9377 2019-06-13  Pedro Alves  <palves@redhat.com>
9378
9379         * thread.c (thread_apply_command): Check for invalid TID with
9380         isdigit instead of !isalpha.
9381
9382 2019-06-13  Pedro Alves  <palves@redhat.com>
9383
9384         * cli/cli-utils.c (parse_flags_qcs): Use validate_flags_qcs.
9385         (validate_flags_qcs): New.
9386         * cli/cli-utils.h (struct qcs_flags): Change field types to int.
9387         (validate_flags_qcs): Declare.
9388         * stack.c (qcs_flag_option_def, fr_qcs_flags_option_defs): New.
9389         (make_frame_apply_options_def_group): New.
9390         (frame_apply_command_count): Process options with
9391         gdb::option::process_options.
9392         (frame_apply_completer): New.
9393         (frame_apply_level_completer, frame_apply_all_completer)
9394         (frame_apply_completer): New.
9395         (_initialize_stack): Update help of "frame apply", "frame apply
9396         level", "frame apply all" and "faas" to mention supported options
9397         and install command completers.
9398         * stack.h (frame_apply_all_completer): Declare.
9399         * thread.c: Include "stack.h".
9400         (tfaas_command): Add "--".
9401         (_initialize_thread): Update help "tfaas" to mention supported
9402         options and install command completer.
9403
9404 2019-06-13  Pedro Alves  <palves@redhat.com>
9405
9406         * completer.c (complete_nested_command_line): New.
9407         (gdb_completion_word_break_characters_throw): Add assertion.
9408         * completer.h (complete_nested_command_line): Declare.
9409
9410 2019-06-13  Pedro Alves  <palves@redhat.com>
9411
9412         * stack.c (parse_backtrace_qualifiers): New.
9413         (backtrace_command): Use it.
9414         (backtrace_command_completer): Complete on qualifiers.
9415
9416 2019-06-13  Pedro Alves  <palves@redhat.com>
9417
9418         * frame.c: Include "cli/cli-option.h.
9419         (user_set_backtrace_options): New.
9420         (backtrace_past_main, backtrace_past_entry, backtrace_limit):
9421         Delete.
9422         (get_prev_frame): Adjust.
9423         (boolean_option_def, uinteger_option_def)
9424         (set_backtrace_option_defs): New.
9425         (_initialize_frame): Adjust and use
9426         gdb::option::add_setshow_cmds_for_options to install "set
9427         backtrace past-main" and "set backtrace past-entry".
9428         * frame.h: Include "cli/cli-option.h".
9429         (struct frame_print_options): Forward declare.
9430         (print_frame_arguments_all, print_frame_arguments_scalars)
9431         (print_frame_arguments_none): Declare.
9432         (print_entry_values): Delete declaration.
9433         (struct frame_print_options, user_frame_print_options): New.
9434         (struct set_backtrace_options): New.
9435         (set_backtrace_option_defs, user_set_backtrace_options): Declare.
9436         * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
9437         (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
9438         (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
9439         (list_args_or_locals): Add frame_print_options parameter.
9440         (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
9441         * python/py-framefilter.c (enumerate_args): Pass down
9442         USER_FRAME_PRINT_OPTIONS.
9443         * stack.c: Include "cli/cli-option.h".
9444         (print_frame_arguments_all, print_frame_arguments_scalars)
9445         (print_frame_arguments_none): Declare.
9446         (print_raw_frame_arguments, print_entry_values): Delete.
9447         (user_frame_print_options): New.
9448         (boolean_option_def, enum_option_def, frame_print_option_defs):
9449         New.
9450         (struct backtrace_cmd_options): New.
9451         (bt_flag_option_def): New.
9452         (backtrace_command_option_defs): New.
9453         (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
9454         (print_frame_arg, read_frame_arg, print_frame_args)
9455         (print_frame_info, print_frame): Add frame_print_options parameter
9456         and use it.
9457         (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
9458         (backtrace_command_1): Add frame_print_options and
9459         backtrace_cmd_options parameters and use them.
9460         (make_backtrace_options_def_group): New.
9461         (backtrace_command): Process command options with
9462         gdb::option::process_options.
9463         (backtrace_command_completer): New.
9464         (_initialize_stack): Extend "backtrace"'s help to mention
9465         supported options.  Install completer for "backtrace".
9466         Install some settings commands with add_setshow_cmds_for_options.
9467
9468 2019-06-13  Pedro Alves  <palves@redhat.com>
9469
9470         * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
9471         and that "set/show print raw frame-arguments" are now deprecated.
9472
9473         * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
9474         command.
9475         * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
9476         * stack.c (_initialize_stack): Install "set/show print
9477         raw-frame-arguments", and deprecate "set/show print raw
9478         frame-arguments".
9479         * valprint.c (_initialize_valprint): Deprecate "set/show print
9480         raw".
9481
9482 2019-06-13  Pedro Alves  <palves@redhat.com>
9483
9484         * compile/compile.c (struct compile_options): New.
9485         (compile_flag_option_def, compile_command_option_defs)
9486         (make_compile_options_def_group): New.
9487         (compile_file_command): Handle options with
9488         gdb::option::process_options.
9489         (compile_file_command_completer): New function.
9490         (compile_code_command): Handle options with
9491         gdb::option::process_options.
9492         (compile_code_command_completer): New function.
9493         (_initialize_compiler): Install completers for "compile code" and
9494         "compile file".  Mention available options in "compile code" and
9495         "compile code"'s help.
9496         * completer.c (advance_to_completion_word): New, factored out from
9497         ...
9498         (advance_to_expression_complete_word_point): ... this.
9499         (advance_to_filename_complete_word_point): New.
9500         * completer.h (advance_to_filename_complete_word_point): New
9501         declaration.
9502
9503 2019-06-13  Pedro Alves  <palves@redhat.com>
9504
9505         * compile/compile.c: Include "cli/cli-option.h".
9506         (compile_print_value): Scope data pointer is now a
9507         value_print_options pointer; adjust.
9508         (compile_print_command): Process options.  Scope data pointer is
9509         now a value_print_options pointer; adjust.
9510         (_initialize_compile): Update "compile print"'s help to include
9511         supported options.  Install a completer for "compile print".
9512         * cp-valprint.c (show_vtblprint, show_objectprint)
9513         (show_static_field_print): Delete.
9514         (_initialize_cp_valprint): Don't install "set print
9515         static-members", "set print vtbl", "set print object" here.
9516         * printcmd.c: Include "cli/cli-option.h" and
9517         "common/gdb_optional.h".
9518         (print_command_parse_format): Rework to fill in a
9519         value_print_options instead of a format_data.
9520         (print_value): Change parameter type from format_data pointer to
9521         value_print_options reference.  Adjust.
9522         (print_command_1): Process options.  Adjust to pass down a
9523         value_print_options.
9524         (print_command_completer): New.
9525         (_initialize_printcmd): Install print_command_completer as
9526         handle_brkchars completer for the "print" command.  Update
9527         "print"'s help to include supported options.
9528         * valprint.c: Include "cli/cli-option.h".
9529         (show_vtblprint, show_objectprint, show_static_field_print): Moved
9530         here from cp-valprint.c.
9531         (boolean_option_def, uinteger_option_def)
9532         (value_print_option_defs, make_value_print_options_def_group):
9533         New.  Use gdb::option::add_setshow_cmds_for_options to install
9534         "set print elements", "set print null-stop", "set print repeats",
9535         "set print pretty", "set print union", "set print array", "set
9536         print address", "set print symbol", "set print array-indexes".
9537         * valprint.h: Include <string> and "cli/cli-option.h".
9538         (make_value_print_options_def_group): Declare.
9539         (print_value): Change parameter type from format_data pointer to
9540         value_print_options reference.
9541         (print_command_completer): Declare.
9542
9543 2019-06-13  Pedro Alves  <palves@redhat.com>
9544
9545         * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
9546         (COMMON_SFILES): Add maint-test-settings.c.
9547         * cli/cli-decode.c (boolean_enums): New global, factored out from
9548         ...
9549         (add_setshow_boolean_cmd): ... here.
9550         * cli/cli-decode.h (boolean_enums): Declare.
9551         * cli/cli-option.c: New file.
9552         * cli/cli-option.h: New file.
9553         * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
9554         factored out from ...
9555         (parse_cli_boolean_value(const char *)): ... this.
9556         (is_unlimited_literal): Change parameter type to pointer to
9557         pointer.  Adjust and advance ARG pointer.
9558         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
9559         (parse_cli_var_enum): New, factored out from ...
9560         (do_set_command): ... this.  Adjust.
9561         * cli/cli-setshow.h (parse_cli_boolean_value)
9562         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
9563         (parse_cli_var_enum): Declare.
9564         * cli/cli-utils.c: Include "cli/cli-option.h".
9565         (get_ulongest): New.
9566         * cli/cli-utils.h (get_ulongest): Declare.
9567         (check_for_argument): New overloads.
9568         * maint-test-options.c: New file.
9569
9570 2019-06-13  Pedro Alves  <palves@redhat.com>
9571
9572         * cli/cli-utils.c (number_or_range_parser::get_number): Do not
9573         parse a range if "-" is at the end of the string.
9574
9575 2019-06-13  Pedro Alves  <palves@redhat.com>
9576
9577         * cli/cli-setshow.c (parse_auto_binary_operation)
9578         (parse_cli_boolean_value): Don't allow "o".
9579
9580 2019-06-13  Pedro Alves  <palves@redhat.com>
9581
9582         * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
9583         * NEWS: Mention maint test-settings KIND.
9584         * maint-test-settings.c: New file.
9585
9586 2019-06-13  Pedro Alves  <palves@redhat.com>
9587
9588         * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
9589         completer.
9590         (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
9591         "set" completers.
9592
9593 2019-06-13  Pedro Alves  <palves@redhat.com>
9594
9595         * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
9596         after item.
9597
9598 2019-06-13  Pedro Alves  <palves@redhat.com>
9599
9600         * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
9601
9602 2019-06-13  Pedro Alves <palves@redhat.com>
9603
9604         * ax-gdb.c (agent_command_1): Remove skip_spaces call.
9605         * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
9606         call.
9607         * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
9608         * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
9609         calls.
9610         (check_for_argument): Skip spaces after argument.
9611
9612 2019-06-13  Pedro Alves  <palves@redhat.com>
9613
9614         * thread.c (thread_apply_command): Adjust TID parsing.
9615         * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
9616         detected before end of string.
9617         (tid_is_in_list): Error out if LIST is invalid.
9618
9619 2019-06-13  Pedro Alves  <palves@redhat.com>
9620
9621         * completer.c (complete_line_internal_1): Rewind completion word
9622         point.
9623         (completion_tracker::advance_custom_word_point_by): Change
9624         parameter type to int.
9625         * completer.h (completion_tracker::advance_custom_word_point_by):
9626         Likewise.
9627
9628 2019-06-13  Pedro Alves  <palves@redhat.com>
9629
9630         * completer.c (advance_to_completion_word): Handle delimiters.
9631
9632 2019-06-11  Bernhard Heckel  <bernhard.heckel@intel.com>
9633
9634         * dwarf2read.c (add_partial_symbol): Skip nameless modules.
9635
9636 2019-06-11  Tom Tromey  <tom@tromey.com>
9637
9638         * common/common-utils.c (xmalloc, xrealloc, xcalloc)
9639         (xmalloc_failed): Move to alloc.c.
9640         * alloc.c: New file.
9641         * Makefile.in (COMMON_SFILES): Add alloc.c.
9642
9643 2019-06-11  Tom Tromey  <tom@tromey.com>
9644
9645         * nat/linux-waitpid.c: Don't include server.h.
9646         (linux_debug): Remove.
9647         (my_waitpid): Update.
9648
9649 2019-06-11  Tom Tromey  <tromey@adacore.com>
9650
9651         * infcall.c (_initialize_infcall): Remove trailing newline from
9652         help.
9653         * user-regs.c (_initialize_user_regs): Remove trailing newline
9654         from help.
9655         * typeprint.c (_initialize_typeprint): Remove trailing newline
9656         from help.
9657         * reverse.c (_initialize_reverse): Remove trailing newlines from
9658         help.
9659         * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
9660         from help.
9661         * language.c (add_set_language_command): Remove trailing newline
9662         from help.
9663         * infcmd.c (_initialize_infcmd): Remove trailing newlines from
9664         help.
9665         * disasm.c (_initialize_disasm): Remove trailing newline from
9666         help.
9667         * top.c (init_main): Remove trailing newline from help.
9668         * interps.c (_initialize_interpreter): Remove trailing newline
9669         from help.
9670         * btrace.c (_initialize_btrace): Remove trailing newlines from
9671         help.
9672         * breakpoint.c (_initialize_breakpoint): Remove trailing newline
9673         from help.
9674         * python/python.c (_initialize_python): Remove trailing newline
9675         from help.
9676         * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
9677         help.
9678         * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
9679         from help.  Reformat some text.
9680         * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
9681         from help.
9682         * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
9683         newline from help.
9684
9685 2019-06-11  Tom Tromey  <tromey@adacore.com>
9686
9687         * darwin-nat.c (darwin_decode_exception_message)
9688         (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
9689
9690 2019-06-10  Andrew Burgess  <andrew.burgess@embecosm.com>
9691
9692         * valops.c (value_slice): Check for not allocated or not
9693         associated values.
9694
9695 2019-06-10  Tom de Vries  <tdevries@suse.de>
9696
9697         PR gdb/24618
9698         * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
9699         sure an empty slot (defined by a 32-bit zero pair) is recognized as
9700         invalid.
9701
9702 2019-06-10  Tom de Vries  <tdevries@suse.de>
9703
9704         PR gdb/24611
9705         * linespec.c (linespec_lexer_lex_string): Remove incorrect
9706         "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon.  Add assert.
9707
9708 2019-06-10  Tom de Vries  <tdevries@suse.de>
9709
9710         PR symtab/24545
9711         * symtab.c (struct demangled_name_entry): Add language field.
9712         (symbol_set_names):  Revert "[gdb/symtab] Fix language of duplicate
9713         static minimal symbol".  Set and use language field.
9714
9715 2019-06-10  Tom Tromey  <tromey@adacore.com>
9716
9717         * ada-lang.c (_initialize_ada_language): Update help text.
9718
9719 2019-06-10  Tom Tromey  <tromey@adacore.com>
9720
9721         * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
9722         with a newline.
9723         * guile/guile.c (handle_boot_error): Don't end warning with a
9724         newline.
9725         * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
9726         warning with a newline.
9727         * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
9728         newline.
9729         (s12z_frame_cache): Likewise.
9730         * dwarf-index-cache.c (index_cache::store): Don't end warning with
9731         a newline.
9732         * solib-svr4.c (disable_probes_interface): Don't end warning with
9733         a newline.
9734         * nat/fork-inferior.c (fork_inferior): Don't end warning with a
9735         newline.
9736         * python/python.c (do_finish_initialization): Don't end warning
9737         with a newline.
9738
9739 2019-06-10  Tom Tromey  <tom@tromey.com>
9740
9741         * python/py-breakpoint.c (gdbpy_breakpoint_created)
9742         (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
9743         gdbpy_enter.
9744
9745 2019-06-10  Tom Tromey  <tromey@adacore.com>
9746
9747         * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
9748         data.
9749         (elf_new_init): Don't call stabsread_new_init.
9750         * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
9751         (elfstab_build_psymtabs): Likewise.  Call stabsread_new_init.
9752         * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
9753
9754 2019-06-10  Tom de Vries  <tdevries@suse.de>
9755
9756         PR symtab/16264
9757         PR symtab/24517
9758         * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
9759
9760 2019-06-06  Руслан Ижбулатов <lrn1986@gmail.com>
9761
9762         * source.c (find_and_open_source): Also rewrite relative file
9763         names.
9764
9765 2019-04-26  Amos Bird  <amosbird@gmail.com>
9766
9767         * annotate.c (annotate_thread_exited): Add "thread-exited"
9768         annotation.
9769
9770 2019-06-06  Tom Tromey  <tromey@adacore.com>
9771
9772         * maint.h (class scoped_command_stats): Use
9773         DISABLE_COPY_AND_ASSIGN.
9774         <print_time>: New method.
9775         * maint.c (scoped_command_stats, ~scoped_command_stats): Call
9776         print_time.
9777         (scoped_command_stats::print_time): New method.
9778
9779 2019-06-05  Andrew Burgess  <andrew.burgess@embecosm.com>
9780
9781         * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
9782         instructions of lengths 6 or 8 bytes.
9783
9784 2019-06-04  Pedro Alves  <palves@redhat.com>
9785
9786         * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
9787
9788         * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
9789         * breakpoint.c (condition_completer): Likewise.
9790         * cli/cli-dump.c (scan_expression): Likewise.
9791         * common/filestuff.c (mkdir_recursive): Likewise.
9792         * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
9793         * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
9794         (gdb_abspath): Likewise.
9795         * compile/compile-cplus-types.c
9796         (compile_cplus_instance::decl_name): Likewise.
9797         * completer.c (complete_explicit_location):
9798         (signal_completer, reg_or_group_completer_1): Likewise.
9799         * cp-support.c (cp_remove_params_if_any): Likewise.
9800         * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
9801         * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
9802         * infcmd.c (strip_bg_char): Likewise.
9803         * linespec.c (copy_token_string): Likewise.
9804         * mi/mi-main.c (output_cores): Likewise.
9805         * psymtab.c (psymtab_search_name):
9806         * symfile.c (test_set_ext_lang_command): Likewise.
9807         * target.c (target_fileio_read_stralloc): Likewise.
9808         * tui/tui-regs.c (tui_reggroup_completer): Likewise.
9809         * value.c (complete_internalvar): Likewise.
9810
9811 2019-06-04  Christian Biesinger  <cbiesinger@google.com>
9812
9813         Add objfile property to gdb.Type.
9814         * NEWS: Mention Python API addition.
9815         * python/py-type.c (typy_get_objfile): New method.
9816
9817 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9818
9819         * NEWS: Mention the new set|show style [title|highlight].
9820         Mention changes to "show style", "help" and "apropos".
9821
9822 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9823
9824         * cli/cli-decode.h (apropos_cmd): Add verbose argument.
9825         * cli/cli-decode.c (apropos_cmd): Likewise.  Use print_doc_of_command
9826         instead of print_help_for_command.
9827         (print_doc_of_command): New function.
9828         (help_list): Add 'apropos -v word' suggestion.
9829         (print_help_for_command): Style the command name using title style.
9830         * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
9831         (_initialize_cli_cmds): Describe -v in apropos_command help.
9832
9833 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9834
9835         * cli/cli-style.h (cli_style_option): Add name in constructor,
9836         add m_name class member, add constructor with intensity,
9837         add name class function.
9838         (cli_style_option::add_setshow_commands): Remove name argument.
9839         (highlight_style, title_style): New styles.
9840         * cli/cli-style.c (do_show): New function that shows a style
9841         characteristic styling the style name with itself.
9842         (set_style_name): New function.
9843         (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
9844         Update all callers according to the changes in cli/cli-style.h.
9845         * utils.h (fputs_highlighted): New function.
9846         * utils.c (fputs_highlighted): Likewise.
9847
9848 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9849
9850         * NEWS: Mention new pipe command and new convenience variables.
9851
9852 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9853
9854         * cli/cli-cmds.c (pipe_command): New function.
9855         (_initialize_cli_cmds): Call add_com for pipe_command.
9856         Define | as an alias for pipe.
9857         (exit_status_set_internal_vars): New function.
9858         (shell_escape): Call exit_status_set_internal_vars.
9859         cli/cli-decode.c (find_command_name_length): Recognize | as
9860         a single character command.
9861
9862 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9863
9864         * gdbcmd.h (execute_command_to_ui_file): New declaration.
9865         top.c (execute_command_to_ui_file): New function, mostly a copy
9866         of execute_command_to_string.
9867         (execute_command_to_string): Implement by calling
9868         execute_command_to_ui_file.
9869
9870 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9871
9872         * top.h (saved_command_line): Remove declaration.
9873         * top.c (previous_saved_command_line, previous_repeat_arguments):
9874         New variables.
9875         (saved_command_line): Make static, define together with other
9876         'repeat variables'.
9877         (dont_repeat): Clear repeat_arguments.
9878         (repeat_previous, get_saved_command_line, save_command_line):
9879         New functions.
9880         (gdb_init): Initialize saved_command_line
9881         and previous_saved_command_line.
9882         * main.c (captured_main_1): Remove saved_command_line initialization.
9883         * event-top.c (handle_line_of_input): Update to use
9884         the new 'repeat' related functions instead of direct access to
9885         saved_command_line.
9886         * command.h (repeat_previous, get_saved_command_line,
9887         save_command_line): New declarations.
9888         (dont_repeat): Add comment.
9889
9890 2019-05-30  Tom Tromey  <tromey@adacore.com>
9891
9892         * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
9893         Fix comment.
9894         (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
9895
9896 2019-05-30  Jan Vrany  <jan.vrany@fit.cvut.cz>
9897
9898         PR cli/24587
9899         * completer.c (complete): Initialize variable word.
9900
9901 2019-05-29  Sergio Durigan Junior  <sergiodj@redhat.com>
9902
9903         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
9904         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
9905         * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
9906         'body' is NULL to the outter 'if', protecting the '!is_define'
9907         situation as well.
9908
9909 2019-05-29  Tom Tromey  <tromey@adacore.com>
9910
9911         * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
9912         (dwarf_unknown): New function.
9913         (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
9914         (dwarf_type_encoding_name): Use dwarf_unknown.
9915
9916 2019-05-29  Tom Tromey  <tromey@adacore.com>
9917
9918         PR c++/20020:
9919         * cp-valprint.c (cp_print_value_fields): Call
9920         cp_print_static_field inside "try".
9921
9922 2019-05-29  Tom Tromey  <tromey@adacore.com>
9923
9924         * inflow.c (struct terminal_info): Add default operator=.
9925         * configure: Rebuild.
9926         * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
9927         -Wdeprecated-copy-dtor, -Wredundant-move.
9928
9929 2019-05-29  Tom Tromey  <tromey@adacore.com>
9930
9931         * NEWS: Add entry.
9932         * infcmd.c (print_return_value_1): Handle finish_print
9933         option.
9934         (show_print_finish): New function.
9935         (_initialize_infcmd): Add "set/show print finish" commands.
9936         * valprint.c (user_print_options): Initialize new member.
9937         * valprint.h (struct value_print_options) <finish_print>: New
9938         member.
9939
9940 2019-05-28  Tom Tromey  <tromey@adacore.com>
9941
9942         * ada-lang.c (ada_remove_Xbn_suffix)
9943         (find_old_style_renaming_symbol)
9944         (parse_old_style_renaming): Remove.
9945         (ada_find_renaming_symbol): Don't call
9946         find_old_style_renaming_symbol.
9947         (ada_is_renaming_symbol): Rename from
9948         ada_find_renaming_symbol.  Remove "block" parameter.  Return
9949         bool.  Now static.
9950         (ada_read_var_value): Update and simplify.
9951         * ada-exp.y (write_var_or_type): Remove old code.
9952
9953 2019-05-28  Alan Hayward  <alan.hayward@arm.com>
9954
9955         PR gdb/25010
9956         * event-top.c: Remove include comment.
9957         * inflow.c (class scoped_ignore_sigttou): Move from here...
9958         * inflow.h (class scoped_ignore_sigttou): ...to here.
9959         * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
9960         * top.c:  Remove include comment.
9961
9962 2019-05-27  Tom Tromey  <tom@tromey.com>
9963
9964         * NEWS: Fix typo.
9965
9966 2019-05-22  Tom Tromey  <tromey@adacore.com>
9967
9968         * target.c (target_follow_exec): Constify parameter.
9969         * target-delegates.c: Rebuild.
9970         * remote.c (remote_target::follow_exec): Constify parameter.
9971         * infrun.c (follow_exec): Constify parameter.
9972         * target.h (struct target_ops) <follow_exec>: Constify parameter.
9973         (target_follow_exec): Likewise.
9974
9975 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
9976
9977         * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
9978         DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
9979
9980 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
9981
9982         * NEWS: Add debugredirect and testsuite sections.
9983
9984 2019-05-22  Simon Cook  <simon.cook@embecosm.com>
9985
9986         * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
9987         target descriptions using exclusively floating point register name
9988         aliases.
9989
9990 2019-05-21  Andrew Burgess  <andrew.burgess@embecosm.com>
9991
9992         PR gdb/18644:
9993         * f-lang.c (build_fortran_types): Handle the case where
9994         gdbarch_floatformat_for_type returns a nullptr.
9995
9996 2019-05-21  Tom de Vries  <tdevries@suse.de>
9997
9998         PR cli/24587
9999         * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
10000
10001 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
10002
10003         PR gdb/18644:
10004         * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
10005         16-byte floats.
10006         * i386-tdep.c (i386_floatformat_for_type): Use
10007         floatformats_ia64_quad for the 16-byte floating point component
10008         within a fortran 32-byte complex number.
10009
10010 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
10011
10012         * dwarf2read.c (struct cu_partial_die_info): Add constructor,
10013         delete default constructor.
10014         (find_partial_die): Update to return const struct.
10015         (partial_die_parent_scope): Move variable declaration into scope
10016         of its use and change its type to auto.
10017         (guess_partial_die_structure_name): Likewise.
10018         (partial_die_info::fixup): Likewise.
10019
10020 2019-05-17  Tom Tromey  <tromey@adacore.com>
10021
10022         * source.c (find_and_open_source): Remove cast.
10023
10024 2019-05-17  Tom Tromey  <tromey@adacore.com>
10025
10026         * annotate.c (annotate_source): Make "filename" const.
10027         * annotate.h (annotate_source): Use const.
10028
10029 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
10030
10031         * disasm.c (set_disassembler_options): Send errors to stderr.
10032
10033 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
10034
10035         * cli/cli-interp.c (struct saved_output_files): Add saved entry.
10036         (cli_interp_base::set_logging): Check debug_redirect.
10037         * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
10038         * cli/cli-logging.c (debug_redirect): Add static variable.
10039         (pop_output_files): Add default param.
10040         (handle_redirections): Print debug setting.
10041         (show_logging_command): Likewise.
10042         (_initialize_cli_logging): Add debugredirect command.
10043         * interps.c (current_interp_set_logging): Add debug_redirect
10044         parameter.
10045         * interps.h (set_logging): Add debug_redirect parameter.
10046         (current_interp_set_logging): Likewise.
10047         * mi/mi-common.h: Likewise.
10048         * mi/mi-interp.c (mi_interp::set_logging): Likewise.
10049
10050 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
10051             Tom Tromey  <tromey@adacore.com>
10052
10053         * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
10054         directly.
10055         * cli/cli-interp.h (make_logging_output): Remove declaration.
10056         * cli/cli-logging.c (make_logging_output): Remove function.
10057         * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
10058         directly.
10059         * ui-file.c (tee_file::tee_file): Remove bools.
10060         (tee_file::~tee_file): Remove deletes.
10061         * ui-file.h (tee_file): Remove bools.
10062
10063 2019-01-28  Jan Vrany  <jan.vrany@fit.cvut.cz>
10064
10065         * mi/mi-cmds.h (mi_cmd_complete): New function.
10066         * mi/mi-main.c (mi_cmd_complete): Likewise.
10067         * mi/mi-cmds.c: Define new MI command -complete.
10068         * NEWS: Mention new -complete command.
10069
10070 2019-01-24  Jan Vrany  <jan.vrany@fit.cvut.cz>
10071
10072         * completer.h (complete): New function.
10073         * completer.c (complete): Likewise.
10074         * cli/cli-cmds.c: (complete_command): Update to use new complete()
10075         function defined in completer.h.
10076
10077 2019-05-17  Jan Vrany  <jan.vrany@fit.cvut.cz>
10078
10079         * MAINTAINERS (Write After Approval): Add myself.
10080
10081 2019-05-17  Tom de Vries  <tdevries@suse.de>
10082
10083         PR gdb/24094
10084         * dwarf2read.c (struct cu_partial_die_info): New struct.
10085         (find_partial_die): Return cu_partial_die_info.
10086         (partial_die_parent_scope, guess_partial_die_structure_name)
10087         (partial_die_info::fixup): Handle new return type of find_partial_die.
10088
10089 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
10090
10091         PR breakpoints/24541
10092         * stap-probe.c (stap_parse_register_operand): Make "regname" an
10093         "std::string", simplifying the algorithm.
10094
10095 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
10096
10097         * stap-probe.c (handle_stap_probe): Fix complaint formatting.
10098         (stap_static_probe_ops::get_probes): Likewise.
10099
10100 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
10101
10102         * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
10103         '-')" and "else if".
10104         (stap_parse_single_operand): Join checks for
10105         "gdbarch_stap_parse_special_token_p" and
10106         "gdbarch_stap_parse_special_token" in the same "if" statement.
10107         Invert check when verifying for operation on register
10108         displacement.
10109
10110 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
10111
10112         * stap-probe.c (stap_get_opcode): Update comment.
10113         (stap_get_expected_argument_type): Likewise.
10114         (handle_stap_probe): Likewise.
10115
10116 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
10117
10118         * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
10119         return type to 'bool'.  Adjust comment.  Use 'bool' when
10120         appropriate.
10121         (i386_stap_parse_special_token_three_arg_disp): Likewise.
10122         * stap-probe.c (stap_parse_argument_1): Likewise.
10123         (stap_is_operator): Likewise.
10124         (stap_is_generic_prefix): Likewise.
10125         (stap_is_register_prefix): Likewise.
10126         (stap_is_register_indirection_prefix): Likewise.
10127         (stap_is_integer_prefix): Likewise.
10128         (stap_generic_check_suffix): Likewise.
10129         (stap_check_integer_suffix): Likewise.
10130         (stap_check_register_suffix): Likewise.
10131         (stap_check_register_indirection_suffix): Likewise.
10132         (stap_parse_register_operand): Likewise.
10133         (stap_parse_single_operand): Likewise.
10134         (stap_parse_argument_1): Likewise.
10135         (stap_probe::get_argument_count): Likewise.
10136         (stap_is_operator): Likewise.
10137
10138 2019-05-16  Tom Tromey  <tromey@adacore.com>
10139
10140         * darwin-nat.c (thread_info_from_private_thread_info): Add struct
10141         keyword to foreach.
10142
10143 2019-05-15  Simon Marchi  <simon.marchi@efficios.com>
10144
10145         * linux-thread-db.c (try_thread_db_load_1): Change return type
10146         to bool.
10147         (try_thread_db_load): Likewise.
10148         (try_thread_db_load_from_pdir_1): Likewise.
10149         (try_thread_db_load_from_pdir): Likewise.
10150         (try_thread_db_load_from_sdir): Likewise.
10151         (try_thread_db_load_from_dir): Likewise.
10152         (thread_db_load_search): Likewise.
10153         (has_libpthread): Likewise.
10154         (thread_db_load): Likewise.
10155
10156 2019-05-15  Sergio Durigan Junior  <sergiodj@redhat.com>
10157
10158         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
10159         * dwarf2read.c (parse_macro_definition): Check whether 'body' is
10160         NULL, and complain/return if that's the case.
10161
10162 2019-05-15  John Darrington <john@darrington.wattle.id.au>
10163
10164         * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
10165         (advance, posn, abstract_read_memory): New functions.
10166         [struct mem_read_abstraction]: New struct.
10167         (s12z_frame_cache): Use opcodes API to interpret stack frame code.
10168
10169 2019-05-14  Tom Tromey  <tromey@adacore.com>
10170
10171         * ada-lang.c (coerce_unspec_val_to_type): Only set address when
10172         value is not lval_memory.
10173
10174 2019-05-14  Tom Tromey  <tromey@adacore.com>
10175
10176         * solib.c (info_sharedlibrary_command): Style the file name.
10177
10178 2019-05-14  Alan Hayward  <alan.hayward@arm.com>
10179
10180         * aarch64-tdep.c (aarch64_vnh_type): Add half view.
10181         (aarch64_vnv_type): Likewise.
10182         * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
10183         * common/tdesc.c: Likewise.
10184         * common/tdesc.h (enum tdesc_type_kind): Likewise.
10185         * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
10186         * features/aarch64-fpu.xml: Add ieee half view.
10187         * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
10188         * gdbtypes.c (gdbtypes_post_init): Add builtin_half
10189         * gdbtypes.h (struct builtin_type): Likewise.
10190         (struct objfile_type): Likewise.
10191
10192 2019-05-12  Paul Naert  <paul.naert@polymtl.ca>
10193
10194         * language.c (language_sniff_from_mangled_name): Fix "langauge"
10195         typo.
10196         * location.h (string_to_event_location): Likewise.
10197
10198 2019-05-11  Joel Brobecker  <brobecker@adacore.com>
10199
10200         GDB 8.3 released.
10201
10202 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
10203
10204         * breakpoint.h (fix_multi_location_breakpoint_output_globally):
10205         New variable declaration.
10206         * breakpoint.c (fix_multi_location_breakpoint_output_globally):
10207         New variable.
10208         (print_one_breakpoint): Use ui_out::test_flags and new global
10209         variable to compute use_fixed_output.
10210         * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
10211         Remove.
10212         * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
10213         (mi_multi_location_breakpoint_output_fixed): Remove.
10214         (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
10215         new variable.
10216         * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
10217         fix_multi_location_breakpoint_output flag if version >= 3.
10218         * ui-out.h (enum ui_out_flag)
10219         <fix_multi_location_breakpoint_output>: New enumerator.
10220
10221 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
10222
10223         * contrib/cc-with-tweaks.sh: Validate dwz's work.
10224
10225 2019-05-10  Tom Tromey  <tromey@adacore.com>
10226
10227         * ada-lang.c (catch_ada_completer): New function.
10228         (_initialize_ada_language): Use it.
10229
10230 2019-05-10  Tom Tromey  <tromey@adacore.com>
10231
10232         * thread.c (print_thread_info): Make "requested_threads" const.
10233         * gdbthread.h (print_thread_info): Make "requested_threads"
10234         const.
10235         * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
10236         * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
10237
10238 2019-05-08  Tom Tromey  <tom@tromey.com>
10239
10240         * gdbtypes.c (objfile_type_data): Change type.
10241         (objfile_type, _initialize_gdbtypes): Update.
10242
10243 2019-05-08  Tom Tromey  <tom@tromey.com>
10244
10245         * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
10246         (dwarf2_frame_find_fde, dwarf2_build_frame_info)
10247         (_initialize_dwarf2_frame): Update.
10248
10249 2019-05-08  Tom Tromey  <tom@tromey.com>
10250
10251         * objc-lang.c (objc_objfile_data): Change type.
10252         (find_methods): Update.
10253         (_initialize_objc_lang): Remove.
10254
10255 2019-05-08  Tom Tromey  <tom@tromey.com>
10256
10257         * stabsread.c (rs6000_builtin_type_data): Change type.
10258         (rs6000_builtin_type, _initialize_stabsread): Update.
10259
10260 2019-05-08  Tom Tromey  <tom@tromey.com>
10261
10262         * mips-tdep.c (mips_pdr_data): Remove.
10263         (_initialize_mips_tdep): Update.
10264
10265 2019-05-08  Tom Tromey  <tom@tromey.com>
10266
10267         * hppa-tdep.c (hppa_objfile_priv_data): Change type.
10268         (hppa_init_objfile_priv_data, read_unwind_info)
10269         (find_unwind_entry, _initialize_hppa_tdep): Update.
10270
10271 2019-05-08  Tom Tromey  <tom@tromey.com>
10272
10273         * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
10274         (elf_gnu_ifunc_record_cache): Update.  Don't allocate hash table
10275         on obstack.
10276         (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
10277
10278 2019-05-08  Tom Tromey  <tom@tromey.com>
10279
10280         * mdebugread.c (basic_type_data): Change type.
10281         (basic_type, _initialize_mdebugread): Update.
10282
10283 2019-05-08  Tom Tromey  <tom@tromey.com>
10284
10285         * common/gdb_unique_ptr.h (struct noop_deleter): New.
10286
10287 2019-05-08  Tom Tromey  <tom@tromey.com>
10288
10289         * nto-tdep.c (nto_inferior_data_reg): Change type.
10290         (nto_inferior_data): Update.
10291         (nto_inferior_data_cleanup, nto_new_inferior_data)
10292         (_initialize_nto_tdep): Remove.
10293         * nto-tdep.h (struct nto_inferior_data): Add initializers.
10294
10295 2019-05-08  Tom Tromey  <tom@tromey.com>
10296
10297         * ada-lang.c (struct ada_inferior_data): Add initializers.
10298         (ada_inferior_data): Change type.
10299         (ada_inferior_data_cleanup): Remove.
10300         (get_ada_inferior_data, ada_inferior_exit)
10301         (struct ada_pspace_data): Add initializers, destructor.
10302         (ada_pspace_data_handle): Change type.
10303         (get_ada_pspace_data): Update.
10304         (ada_pspace_data_cleanup): Remove.
10305
10306 2019-05-08  Tom Tromey  <tom@tromey.com>
10307
10308         * coffread.c (struct coff_symfile_info): Add initializers.
10309         (coff_objfile_data_key): Move lower.  Change type.
10310         (coff_symfile_init, coff_symfile_read, _initialize_coffread):
10311         Update.
10312         (coff_free_info): Remove.
10313
10314 2019-05-08  Tom Tromey  <tom@tromey.com>
10315
10316         * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
10317         (fbsd_pspace_data_handle): Move lower.  Change type.
10318         (get_fbsd_pspace_data): Update.
10319         (fbsd_pspace_data_cleanup): Remove.
10320         (_initialize_fbsd_tdep): Update.
10321
10322 2019-05-08  Tom Tromey  <tom@tromey.com>
10323
10324         * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
10325         (get_ada_tasks_pspace_data): Update.
10326         (ada_tasks_pspace_data_cleanup): Remove.
10327         (_initialize_tasks): Update.
10328         (ada_tasks_inferior_data_handle): Change type.
10329         (get_ada_tasks_inferior_data): Update.
10330         (ada_tasks_inferior_data_cleanup): Remove.
10331         (struct ada_tasks_pspace_data): Add initializers.
10332
10333 2019-05-08  Tom Tromey  <tom@tromey.com>
10334
10335         * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
10336         * symfile-debug.c (debug_sym_get_probes): Change type.
10337         * stap-probe.c (handle_stap_probe):
10338         (stap_static_probe_ops::get_probes): Change type.
10339         * probe.h (class static_probe_ops) <get_probes>: Change type.
10340         * probe.c (class any_static_probe_ops) <get_probes>: Change type.
10341         (parse_probes_in_pspace): Update.
10342         (find_probes_in_objfile, find_probe_by_pc, collect_probes):
10343         Update.
10344         (any_static_probe_ops::get_probes): Change type.
10345         * elfread.c (elfread_data): New typedef.
10346         (probe_key): Change type.
10347         (elf_get_probes): Likewise.  Update.
10348         (probe_key_free): Remove.
10349         (_initialize_elfread): Update.
10350         * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
10351         Change type.
10352         (dtrace_process_dof_probe, dtrace_process_dof)
10353         (dtrace_static_probe_ops::get_probe): Change type.
10354
10355 2019-05-08  Tom Tromey  <tom@tromey.com>
10356
10357         * xcoffread.c (struct xcoff_symfile_info): Rename from
10358         coff_symfile_info.  Add initializers.
10359         (xcoff_objfile_data_key): Move lower.  Change type.
10360         (XCOFF_DATA): Rewrite.
10361         (xcoff_free_info): Remove.
10362         (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
10363         (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
10364         (xcoff_initial_scan): Update.
10365
10366 2019-05-08  Tom Tromey  <tom@tromey.com>
10367
10368         * solib-svr4.c (struct svr4_info): Add initializers and
10369         destructor.
10370         <probes_table>: Now an htab_up.
10371         (solib_svr4_pspace_data): Change type.
10372         (free_probes_table): Simplify.
10373         (~svr4_info): Rename from svr4_pspace_data_cleanup.
10374         (get_svr4_info, probes_table_htab_remove_objfile_probes)
10375         (probes_table_remove_objfile_probes, register_solib_event_probe)
10376         (solib_event_probe_at, svr4_update_solib_event_breakpoint)
10377         (_initialize_svr4_solib): Update.
10378
10379 2019-05-08  Tom Tromey  <tom@tromey.com>
10380
10381         * remote.c (remote_pspace_data): Change type.
10382         (remote_pspace_data_cleanup): Remove.
10383         (get_remote_exec_file, set_pspace_remote_exec_file)
10384         (_initialize_remote): Update.
10385
10386 2019-05-08  Tom Tromey  <tom@tromey.com>
10387
10388         * breakpoint.c (breakpoint_objfile_key): Change type.
10389         (get_breakpoint_objfile_data): Update.
10390         (free_breakpoint_objfile_data): Remove.
10391         (_initialize_breakpoint): Update.
10392
10393 2019-05-08  Tom Tromey  <tom@tromey.com>
10394
10395         * linux-tdep.c (struct linux_info): Add initializers.
10396         (linux_inferior_data): Move.  Change type.
10397         (invalidate_linux_cache_inf): Update.
10398         (linux_inferior_data_cleanup): Remove.
10399         (get_linux_inferior_data, _initialize_linux_tdep): Update.
10400
10401 2019-05-08  Tom Tromey  <tom@tromey.com>
10402
10403         * auxv.c (auxv_inferior_data): Move.  Change type.
10404         (auxv_inferior_data_cleanup): Remove.
10405         (invalidate_auxv_cache_inf): Rewrite.
10406         (get_auxv_inferior_data, _initialize_auxv): Update.
10407
10408 2019-05-08  Tom Tromey  <tom@tromey.com>
10409
10410         * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
10411         (symfile_debug_objfile_data_key): Change type.
10412         (symfile_debug_installed, debug_qf_has_symbols)
10413         (debug_qf_find_last_source_symtab)
10414         (debug_qf_forget_cached_source_info)
10415         (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
10416         (debug_qf_print_stats, debug_qf_dump)
10417         (debug_qf_expand_symtabs_for_function)
10418         (debug_qf_expand_all_symtabs)
10419         (debug_qf_expand_symtabs_with_fullname)
10420         (debug_qf_map_matching_symbols)
10421         (debug_qf_expand_symtabs_matching)
10422         (debug_qf_find_pc_sect_compunit_symtab)
10423         (debug_qf_map_symbol_filenames)
10424         (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
10425         (debug_sym_new_init, debug_sym_init, debug_sym_read)
10426         (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
10427         (debug_sym_read_linetable, debug_sym_relocate): Update.
10428         (symfile_debug_free_objfile): Remove.
10429         (install_symfile_debug_logging, _initialize_symfile_debug):
10430         Update.
10431
10432 2019-05-08  Tom Tromey  <tom@tromey.com>
10433
10434         * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
10435         allocate_on_obstack.
10436         * dwarf2read.c (dwarf2_objfile_data_key): Change type.
10437         (get_dwarf2_per_objfile): Update.
10438         (set_dwarf2_per_objfile): Remove.
10439         (dwarf2_has_info, dwarf2_get_section_info): Update.
10440         (dwarf2_free_objfile): Remove.
10441         (_initialize_dwarf2_read): Update.
10442
10443 2019-05-08  Tom Tromey  <tom@tromey.com>
10444
10445         * auto-load.c (struct auto_load_pspace_info): Add destructor and
10446         initializers.
10447         <unsupported_script_warning_printed,
10448         script_not_found_warning_printed>: Now bool.
10449         (auto_load_pspace_data): Change type.
10450         (~auto_load_pspace_info): Rename from
10451         auto_load_pspace_data_cleanup.
10452         (get_auto_load_pspace_data, init_loaded_scripts_info)
10453         (clear_section_scripts, maybe_print_unsupported_script_warning)
10454         (maybe_print_script_not_found_warning, _initialize_auto_load):
10455         Update.
10456
10457 2019-05-08  Tom Tromey  <tom@tromey.com>
10458
10459         * objfiles.c (objfile_pspace_info): Add destructor and
10460         initializers.
10461         (objfiles_pspace_data): Change type.
10462         (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
10463         (get_objfile_pspace_data): Update.
10464         (objfiles_bfd_data): Change type.
10465         (get_objfile_bfd_data): Update.
10466         (objfile_bfd_data_free, _initialize_objfiles): Remove.
10467
10468 2019-05-08  Tom Tromey  <tom@tromey.com>
10469
10470         * break-catch-syscall.c (catch_syscall_inferior_data): Move.
10471         Change type.
10472         (get_catch_syscall_inferior_data): Update.
10473         (catch_syscall_inferior_data_cleanup): Remove.
10474         (_initialize_break_catch_syscall): Update.
10475
10476 2019-05-08  Tom Tromey  <tom@tromey.com>
10477
10478         * inflow.c (struct terminal_info): Add destructor and
10479         initializers.
10480         (inflow_inferior_data): Change type.
10481         (~terminal_info): Rename from inflow_inferior_data_cleanup.
10482         (get_inflow_inferior_data, inflow_inferior_exit)
10483         (swap_terminal_info, _initialize_inflow): Update.
10484
10485 2019-05-08  Tom Tromey  <tom@tromey.com>
10486
10487         * target-dcache.c (target_dcache_cleanup): Remove.
10488         (target_dcache_aspace_key): Change type.
10489         (target_dcache_init_p, target_dcache_invalidate)
10490         (target_dcache_get, target_dcache_get_or_init)
10491         (_initialize_target_dcache): Update.
10492         * dcache.h (struct dcache_deleter): New.
10493
10494 2019-05-08  Tom Tromey  <tom@tromey.com>
10495
10496         * symtab.c (struct symbol_cache): Add destructor and
10497         initializers.
10498         (symbol_cache_key): Move.  Change type.
10499         (make_symbol_cache, free_symbol_cache): Remove.
10500         (get_symbol_cache): Update.
10501         (symbol_cache_cleanup): Remove.
10502         (ALL_PSPACES, symbol_cache_flush)
10503         (maintenance_print_symbol_cache)
10504         (maintenance_print_symbol_cache_statistics, _initialize_symtab):
10505         Update.
10506
10507 2019-05-08  Tom Tromey  <tom@tromey.com>
10508
10509         * symtab.c (struct main_info): Add destructor and initializers.
10510         (main_progspace_key): Move.  Change type.
10511         (get_main_info): Update.
10512         (main_info_cleanup): Remove.
10513         (_initialize_symtab): Update.
10514
10515 2019-05-08  Tom Tromey  <tom@tromey.com>
10516
10517         * registry.h (DECLARE_REGISTRY): Define the _key class.
10518
10519 2019-05-08  Andrew Burgess  <andrew.burgess@embecosm.com>
10520
10521         * NEWS: Merge two 'New commands' sections.
10522
10523 2019-05-08  Joel Brobecker  <brobecker@adacore.com>
10524
10525         * ada-valprint.c (ada_val_print_gnat_array): Remove language
10526         parameter and use Ada language definition instead.
10527         (ada_val_print_ptr): Remove unused language parameter.
10528         (ada_val_print_num): Remove language parameter and use Ada language
10529         definition instead.
10530         (ada_val_print_enum, ada_val_print_flt): Remove unused language
10531         parameter.
10532         (ada_val_print_struct_union, ada_val_print_ref): Remove language
10533         parameter and use Ada language definition instead.
10534         (ada_val_print_1): Update all ada_val_print_xxx calls.
10535         Remove language parameter.
10536         (ada_val_print): Update ada_val_print_1 call.
10537
10538 2019-05-08  Tom Tromey  <tromey@adacore.com>
10539
10540         * remote.c (remote_hw_watchpoint_limit)
10541         (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
10542         Now static.
10543
10544 2019-05-08  Tom Tromey  <tromey@adacore.com>
10545
10546         * maint.c (_initialize_maint_cmds): Move initialization code to
10547         remote.c.
10548         (watchdog, show_watchdog): Move to remote.c.
10549         * remote.c (watchdog, show_watchdog): Move from maint.c.  Make
10550         "watchdog" static.
10551         (_initialize_remote): Move initialization code from maint.c.
10552         * defs.h (watchdog): Don't declare.
10553
10554 2019-05-08  Tom Tromey  <tromey@adacore.com>
10555
10556         * tui/tui-interp.c: Include main.h.
10557         * interps.c: Include main.h.
10558         * main.h (interpreter_p): Declare.
10559         * defs.h (interpreter_p): Don't declare.
10560
10561 2019-05-08  Tom Tromey  <tromey@adacore.com>
10562
10563         * dwarf2loc.c: Include dwarf2read.h.
10564         * defs.h (read_unsigned_leb128): Don't declare.
10565         * dwarf2read.h (read_unsigned_leb128): Declare.
10566
10567 2019-05-08  Tom Tromey  <tromey@adacore.com>
10568
10569         * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
10570         method.
10571
10572 2019-05-08  Tom Tromey  <tromey@adacore.com>
10573
10574         * utils.c (fputs_maybe_filtered): Reset style after paging, even
10575         when no wrap column is set.
10576
10577 2019-05-08  Tom Tromey  <tromey@adacore.com>
10578
10579         * c-lang.c (c_get_string): Handle non-C-style arrays.
10580
10581 2019-05-08  Tom Tromey  <tromey@adacore.com>
10582
10583         * typeprint.c (print_offset_data::update): Print the bit offset,
10584         not the number of bits remaining.
10585
10586 2019-05-08  Tom Tromey  <tromey@adacore.com>
10587
10588         * typeprint.c (print_offset_data::maybe_print_hole): Add extra
10589         padding at end of comment.
10590
10591 2019-05-08  Tom Tromey  <tromey@adacore.com>
10592
10593         * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
10594         Compare main types.
10595
10596 2019-05-06  Tom Tromey  <tom@tromey.com>
10597
10598         * common/scoped_mmap.c: Include common-defs.h.
10599         * common/scoped_mmap.h: Don't include config.h.
10600
10601 2019-05-04  Tom Tromey  <tom@tromey.com>
10602
10603         * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
10604         (struct aarch64_call_info): Add initializers.
10605         <si>: Now a std::vector.
10606         (pass_on_stack, aarch64_push_dummy_call): Update.
10607
10608 2019-05-04  Simon Marchi  <simon.marchi@efficios.com>
10609             Tom Tromey  <tom@tromey.com>
10610
10611         * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
10612         (ppc_threads): Now a std::vector.  Now static.
10613         (hwdebug_find_thread_points_by_tid)
10614         (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
10615         Update.
10616
10617 2019-05-04  Tom Tromey  <tom@tromey.com>
10618
10619         * arc-tdep.c (arc_tdesc_init): Return bool.
10620
10621 2019-05-04  Tom Tromey  <tom@tromey.com>
10622
10623         * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
10624         Use gdb_assert_not_reached.
10625
10626 2019-05-04  Tom Tromey  <tom@tromey.com>
10627
10628         * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
10629         "false".
10630
10631 2019-05-04  Tom Tromey  <tom@tromey.com>
10632
10633         * arc-tdep.c (arc_tdesc_init): Use bool.
10634
10635 2019-05-04  Tom Tromey  <tom@tromey.com>
10636
10637         * stack.c (select_frame_for_mi): Use "false", not "FALSE".
10638
10639 2019-05-04  Tom Tromey  <tom@tromey.com>
10640
10641         * cli/cli-cmds.c (valid_command_p): Return bool.
10642
10643 2019-05-04  Tom Tromey  <tom@tromey.com>
10644
10645         * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
10646         * command.h (valid_user_defined_cmd_name_p): Channge return type.
10647
10648 2019-05-04  Raul Tambre  <raul@tambre.ee>
10649
10650         * python/lib/gdb/prompt.py (_ExtendedPrompt)
10651         <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
10652         operator for comparison.
10653
10654 2019-05-04  Tom Tromey  <tom@tromey.com>
10655
10656         * psymtab.c (psymbol_name_matches, match_partial_symbol)
10657         (lookup_partial_symbol, print_partial_symbols)
10658         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
10659         (psymbol_compare): Update.
10660         (add_psymbol_to_bcache): Clear the entire psymbol.
10661         (maintenance_check_psymtabs): Update.
10662         * psympriv.h (struct partial_symbol): Don't derive from
10663         general_symbol_info.
10664         <obj_section, unrelocated_address, address,
10665         set_unrelocated_address>: Update.
10666         <ginfo>: New member.
10667         * dwarf-index-write.c (write_psymbols, debug_names::insert)
10668         (debug_names::write_psymbols): Update.
10669
10670 2019-05-04  Tom de Vries  <tdevries@suse.de>
10671
10672         * contrib/cc-with-tweaks.sh: Support -n arg.
10673
10674 2019-05-04  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10675
10676         * corelow.c (core_target::detach): Ensure frame cache and
10677         register caches are cleared.
10678         inferior.c (exit_inferior_1): Likewise.
10679
10680 2019-05-03  Sandra Loosemore  <sandra@codesourcery.com>
10681             Tom Tromey  <tom@tromey.com>
10682
10683         * dictionary.c (collate_pending_symbols_by_language): Remove
10684         "struct" from foreach.
10685         * symtab.c (lookup_global_symbol_from_objfile)
10686         (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
10687         foreach.
10688         * ser-tcp.c (net_open): Remove "struct" from foreach.
10689         * objfiles.c (objfile_relocate, objfile_rebase)
10690         (objfile_has_symbols): Remove "struct" from foreach.
10691         * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
10692         from foreach.
10693         * dwarf2read.c (handle_struct_member_die): Remove "struct" from
10694         foreach.
10695         * darwin-nat.c (thread_info_from_private_thread_info): Remove
10696         "struct" from foreach.
10697         * ada-lang.c (create_excep_cond_exprs)
10698         (ada_exception_catchpoint_cond_string): Remove "struct" from
10699         foreach.
10700
10701 2019-05-03  Tom Tromey  <tromey@adacore.com>
10702
10703         * ada-exp.y (convert_char_literal): Check suffix of each
10704         enumerator.
10705
10706 2019-05-03  Dilyan Palauzov  <dilyan.palauzov@aegee.org>
10707
10708         PR ada/21406:
10709         * ada-exp.y (yywrap): Don't define.
10710         * ada-lex.l (%option): Add noyywrap
10711         (yywrap): Remove.
10712
10713 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
10714
10715         * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
10716         _WIN32_WINNT to the XP level, unless already defined to a higher
10717         level.
10718
10719         * unittests/parse-connection-spec-selftests.c:
10720         * ser-tcp.c:
10721         * common/netstuff.c [USE_WIN32API]:  Remove the _WIN32_WINNT
10722         override.
10723
10724         * symfile.c (find_separate_debug_file): Remove colon from the
10725         drive spec of DOS/Windows file names of the target, so that the
10726         file name produced from DEBUGDIR and the target's directory will
10727         be valid on DOS/Windows systems.
10728
10729 2019-05-02  Andrew Burgess  <andrew.burgess@embecosm.com>
10730
10731         * rust-lang.c (val_print_struct): Handle printing structures
10732         containing strings.
10733
10734 2019-05-02  Tom Tromey  <tromey@adacore.com>
10735
10736         * valarith.c (_initialize_valarith): Remove.
10737
10738 2019-05-01  Tom Tromey  <tromey@adacore.com>
10739
10740         * ada-lang.c (ada_value_primitive_field): Treat more fields as
10741         bitfields.
10742
10743 2019-05-01  Tom Tromey  <tromey@adacore.com>
10744
10745         * ada-lang.c (ada_value_assign): Correctly compute starting offset
10746         for big-endian copies.
10747
10748 2019-04-30  Ali Tamur  <tamur@google.com>
10749         * gdb/dwarf2read.c (read_3_bytes): New declaration.
10750         (read_attribute_value): Added DW_FORM_strx1-4 cases.
10751         (read_3_bytes): New function.
10752
10753 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
10754
10755         * windows-nat.c (main_thread_id): Delete.
10756         (handle_output_debug_string): Replace main_thread_id by
10757         current_event.dwThreadId.
10758         (fake_create_process): Likewise.
10759         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
10760         Do not set main_thread_id.
10761         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
10762         current_event.dwThreadId.
10763         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
10764
10765 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
10766
10767         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
10768         Use current_event.dwThreadId instead of main_thread_id.
10769
10770 2019-04-30  Tom Tromey  <tromey@adacore.com>
10771
10772         * ada-lang.c (ada_lookup_simple_minsyms): New function.
10773         (create_excep_cond_exprs): Iterate over program spaces.
10774         (ada_exception_catchpoint_cond_string): Examine all minimal
10775         symbols for exception types.
10776
10777 2019-04-30  Tom Tromey  <tromey@adacore.com>
10778
10779         PR c++/24470:
10780         * dwarf2read.c (process_structure_scope): Handle case where type
10781         has template parameters but no symbol was created.
10782
10783 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
10784             Chris January  <chris.january@arm.com>
10785
10786         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
10787         qualifier.
10788         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
10789
10790 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
10791
10792         * f-typeprint.c (f_print_type): Update rules for printing
10793         whitespace.
10794         (f_type_print_varspec_suffix): Likewise.
10795
10796 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
10797             Chris January  <chris.january@arm.com>
10798
10799         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
10800         function arguments.
10801
10802 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
10803
10804         * f-lang.c (build_fortran_types): Change name of void type to
10805         lower case.
10806         * f-typeprint.c (f_type_print_base): Print the name of the void
10807         type, rather than a fixed string.
10808         * f-valprint.c (f_decorations): Use lower case void string.
10809
10810 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
10811             Chris January  <chris.january@arm.com>
10812
10813         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
10814         types for Fortran.
10815
10816 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
10817             Chris January  <chris.january@arm.com>
10818             David Lecomber  <david.lecomber@arm.com>
10819
10820         * f-exp.y (BINOP_INTRINSIC): New token.
10821         (exp): New parser rule handling BINOP_INTRINSIC.
10822         (f77_keywords): Add new builtin procedures.
10823         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
10824         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
10825         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
10826         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
10827         (print_unop_subexp_f): New function.
10828         (print_binop_subexp_f): New function.
10829         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
10830         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
10831         (dump_subexp_body_f): Likewise.
10832         (operator_check_f): Likewise.
10833         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
10834         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
10835
10836 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
10837
10838         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
10839         UNOP_KIND.
10840         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
10841         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
10842         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
10843         (operator_length_f): New fuction.
10844         (print_subexp_f): New function.
10845         (op_name_f): New function.
10846         (dump_subexp_body_f): New function.
10847         (operator_check_f): New function.
10848         (exp_descriptor_f): Replace standard expression handling functions
10849         with new functions.
10850         * gdb/fortran-operator.def: New file.
10851         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
10852         * gdb/std-operator.def: Remove UNOP_KIND.
10853
10854 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
10855
10856         * std-operator.def: Remove unbalanced, stray double quote
10857         character.
10858
10859 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
10860             Chris January  <chris.january@arm.com>
10861             Daniel Everett  <daniel.everett@arm.com>
10862             Nick Forrington  <nick.forrington@arm.com>
10863             Richard Bunt  <richard.bunt@arm.com>
10864
10865         * cp-valprint.c (cp_print_value_fields): Allow an additional level
10866         of depth when printing anonymous structs or unions.
10867         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
10868         Don't print either the top-level value, or the children if the
10869         max-depth is exceeded.
10870         (ppscm_print_children): When printing the key of a map, allow one
10871         extra level of depth.
10872         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
10873         print either the top-level value, or the children if the max-depth
10874         is exceeded.
10875         (print_children): When printing the key of a map, allow one extra
10876         level of depth.
10877         * python/py-value.c (valpy_format_string): Add max_depth keyword.
10878         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
10879         (user_print_options): Initialise max_depth field.
10880         (val_print_scalar_or_string_type_p): New function.
10881         (val_print): Check to see if the max depth has been reached.
10882         (val_print_check_max_depth): Define new function.
10883         (show_print_max_depth): New function.
10884         (_initialize_valprint): Add 'print max-depth' option.
10885         * valprint.h (struct value_print_options) <max_depth>: New field.
10886         (val_print_check_max_depth): Declare new function.
10887         * NEWS: Document new feature.
10888
10889 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
10890
10891         * ada-lang.c (ada_language_defn): Initialise new field.
10892         * c-lang.c (c_is_string_type_p): New function.
10893         (c_language_defn): Initialise new field.
10894         (cplus_language_defn): Initialise new field.
10895         (asm_language_defn): Initialise new field.
10896         (minimal_language_defn): Initialise new field.
10897         * c-lang.h (c_is_string_type_p): Declare new function.
10898         * d-lang.c (d_language_defn): Initialise new field.
10899         * f-lang.c (f_is_string_type_p): New function.
10900         (f_language_defn): Initialise new field.
10901         * go-lang.c (go_is_string_type_p): New function.
10902         (go_language_defn): Initialise new field.
10903         * language.c (default_is_string_type_p): New function.
10904         (unknown_language_defn): Initialise new field.
10905         (auto_language_defn): Initialise new field.
10906         * language.h (struct language_defn) <la_is_string_type_p>: New
10907         member variable.
10908         (default_is_string_type_p): Declare new function.
10909         * m2-lang.c (m2_language_defn): Initialise new field.
10910         * objc-lang.c (objc_language_defn): Initialise new field.
10911         * opencl-lang.c (opencl_language_defn): Initialise new field.
10912         * p-lang.c (pascal_is_string_type_p): New function.
10913         (pascal_language_defn): Initialise new field.
10914         * rust-lang.c (rust_is_string_type_p): New function.
10915         (rust_language_defn): Initialise new field.
10916
10917 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
10918
10919         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
10920         New field.
10921         * ada-lang.c (ada_language_defn): Initialise new field.
10922         * c-lang.c (c_language_defn): Likewise.
10923         (cplus_language_defn): Likewise.
10924         (asm_language_defn): Likewise.
10925         (minimal_language_defn): Likewise.
10926         * d-lang.c (d_language_defn): Likewise.
10927         * f-lang.c (f_language_defn): Likewise.
10928         * go-lang.c (go_language_defn): Likewise.
10929         * language.c (unknown_language_defn): Likewise.
10930         (auto_language_defn): Likewise.
10931         * m2-lang.c (m2_language_defn): Likewise.
10932         * objc-lang.c (objc_language_defn): Likewise.
10933         * opencl-lang.c (opencl_language_defn): Likewise.
10934         * p-lang.c (pascal_language_defn): Likewise.
10935         * rust-lang.c (rust_language_defn): Likewise.
10936
10937 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
10938
10939         * ada-lang.c (ada_is_character_type): Change return type to bool.
10940         (ada_is_string_type): Likewise.
10941         * ada-lang.h (ada_is_character_type): Update declaration
10942         (ada_is_string_type): Likewise.
10943
10944 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10945
10946         Support style in 'frame|thread apply'
10947
10948         * gdbcmd.h (execute_command_to_string): New term_out parameter.
10949         * record.c (record_start, record_stop): Update callers of
10950         execute_command_to_string with false.
10951         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
10952         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
10953         methods.
10954         (class string_file): New constructor with term_out parameter.
10955         Override methods term_out and can_emit_style_escape.  New member
10956         term_out.
10957         (class stdio_file): Override can_emit_style_escape.
10958         (class tee_file): Override term_out and can_emit_style_escape.
10959         * utils.h (can_emit_style_escape): Remove.
10960         * utils.c (can_emit_style_escape): Likewise.
10961         Update all callers of can_emit_style_escape (SOMESTREAM) to
10962         SOMESTREAM->can_emit_style_escape.
10963         * source-cache.c (source_cache::get_source_lines): Likewise.
10964         * stack.c (frame_apply_command_count): Call execute_command_to_string
10965         passing the term_out characteristic of the current gdb_stdout.
10966         * thread.c (thr_try_catch_cmd): Likewise.
10967         * top.c (execute_command_to_string): pass term_out parameter
10968         to construct the string_file for the command output.
10969         * ui-file.c (term_cli_styling): New function (most code moved
10970         from utils.c can_emit_style_escape).
10971         (string_file::string_file, string_file::can_emit_style_escape,
10972         stdio_file::can_emit_style_escape, tee_file::term_out,
10973         tee_file::can_emit_style_escape): New functions.
10974
10975 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10976
10977         * NEWS: Mention the new set|show may-call-functions.
10978         * infcall.c (may_call_functions_p): New variable.
10979         (show_may_call_functions_p): New function.
10980         (call_function_by_hand_dummy): Throws an error if not
10981         may-call-functions.
10982         (_initialize_infcall): Call add_setshow_boolean_cmd for
10983         may-call-functions.
10984
10985 2019-04-25  Keith Seitz  <keiths@redhat.com>
10986
10987         PR c++/24367
10988         * cp-support.c (inspect_type): Don't attempt substitutions
10989         of symbol with the same name.
10990
10991 2019-04-25  Tom Tromey  <tromey@adacore.com>
10992
10993         PR gdb/24475:
10994         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
10995         static.
10996
10997 2019-04-25  Tom Tromey  <tromey@adacore.com>
10998
10999         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
11000         rvalue reference.
11001         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
11002         (gdb_xml_parser::parse): Use std::move.
11003         * python/python-internal.h (gdbpy_convert_exception): Take a const
11004         reference.
11005         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
11006         std::move.
11007         * python/py-utils.c (gdbpy_convert_exception): Take a const
11008         reference.
11009         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
11010         Use std::move.
11011         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
11012         Use std::move.
11013         * mi/mi-main.c (mi_print_exception): Take a const reference.
11014         * main.c (handle_command_errors): Take a const reference.
11015         * linespec.c (parse_linespec): Use std::move.
11016         * infcall.c (run_inferior_call): Use std::move.
11017         (call_function_by_hand_dummy): Use std::move.
11018         * exec.c (try_open_exec_file): Use std::move.
11019         * exceptions.h (exception_print, exception_fprintf)
11020         (exception_print_same): Update.
11021         * exceptions.c (print_exception, exception_print)
11022         (exception_fprintf, exception_print_same): Change parameters to
11023         const reference.
11024         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
11025         * common/new-op.c: Use std::move.
11026         * common/common-exceptions.h (struct gdb_exception): Add move
11027         constructor.
11028         (struct gdb_exception_error, struct gdb_exception_quit, struct
11029         gdb_quit_bad_alloc): Change constructor to move constructor.
11030         (throw_exception): Change parameter to rvalue reference.
11031         * common/common-exceptions.c (throw_exception): Take rvalue
11032         reference.
11033         * cli/cli-interp.c (safe_execute_command): Use std::move.
11034         * breakpoint.c (insert_bp_location, location_to_sals): Use
11035         std::move.
11036
11037 2019-04-25  Tom Tromey  <tromey@adacore.com>
11038
11039         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
11040         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
11041         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
11042         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
11043         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
11044         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
11045         guile/scm-value.c: Use unpack.
11046         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
11047         gdbscm_gdb_exception.
11048         (gdbscm_throw_gdb_exception): Likewise.
11049         (struct gdbscm_gdb_exception): New.
11050         (unpack): New function.
11051         (gdbscm_wrap): Use unpack.
11052
11053 2019-04-25  Tom Tromey  <tromey@adacore.com>
11054
11055         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
11056         (gdb_rl_callback_handler): Use std::move.
11057         * common/common-exceptions.h (struct gdb_exception): Add move
11058         assignment operator.
11059         (throw_exception_sjlj): Change "exception" to const reference.
11060         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
11061         (throw_exception_sjlj): Change "exception" to const reference.
11062
11063 2019-04-25  Tom Tromey  <tromey@adacore.com>
11064
11065         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
11066         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
11067         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
11068         Update.
11069         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
11070         Update.
11071         * mi/mi-interp.c (mi_interp::exec): Update.
11072         * linespec.c (parse_linespec): Update.
11073         * infcall.c (run_inferior_call): Update.
11074         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
11075         * guile/scm-symbol.c (gdbscm_lookup_symbol)
11076         (gdbscm_lookup_global_symbol): Update.
11077         * guile/scm-param.c (gdbscm_parameter_value): Update.
11078         * guile/scm-frame.c (gdbscm_frame_read_register)
11079         (gdbscm_frame_read_var): Update.
11080         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
11081         * exec.c (try_open_exec_file): Update.
11082         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
11083         (gdb_rl_callback_handler): Update.
11084         * common/common-exceptions.h (exception_none): Don't declare.
11085         * common/common-exceptions.c (exception_none): Don't define.
11086         (struct catcher) <exception>: Update.
11087         * cli/cli-interp.c (safe_execute_command): Update.
11088         * breakpoint.c (insert_bp_location, location_to_sals): Update.
11089
11090 2019-04-25  Ali Tamur  <tamur@google.com>
11091
11092         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
11093         (read_attribute_value): Likewise.
11094         (dwarf2_read_addr_index): Update comment.
11095         (read_str_index): Add DW_FORM_strx.
11096         (dwarf2_string_attr): Likewise.
11097         (dwarf2_const_value_attr): Likewise.
11098         (dump_die_shallow): Likewise.
11099         (dwarf2_fetch_constant_bytes): Likewise.
11100         (skip_form_bytes): Likewise.
11101         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
11102
11103 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
11104
11105         PR corefiles/11608
11106         PR corefiles/18187
11107         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
11108         OFFSET.  Verify if current mapping contains an ELF header.
11109         (linux_find_memory_regions_full): Adjust call to
11110         dump_mapping_p.
11111
11112 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
11113             Kang Li <kanglictf@gmail.com>
11114
11115         PR gdb/21600
11116
11117         * dwarf2-frame.c (read_initial_length): Be consistent about using
11118         unsigned representation of length.
11119         (decode_frame_entry_1): Likewise.  Check for wraparound of
11120         end pointer as well as buffer overflow.
11121
11122 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
11123
11124         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
11125         "vq".
11126
11127 2019-04-24  Tom Tromey  <tromey@adacore.com>
11128
11129         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
11130
11131 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11132
11133         * s12z-tdep.c (s12z_unwind_pc): Delete.
11134         (s12z_unwind_sp): Delete.
11135         (s12z_gdbarch_init): Don't register deleted functions with
11136         gdbarch.
11137
11138 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11139
11140         * rl78-tdep.c (rl78_unwind_sp): Delete.
11141         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
11142
11143 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11144
11145         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
11146         (xstormy16_unwind_pc): Delete.
11147         (xstormy16_dummy_id): Delete.
11148         (xstormy16_gdbarch_init): Don't register deleted functions with
11149         gdbarch.
11150
11151 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11152
11153         * vax-tdep.c (vax_unwind_pc): Delete.
11154         (vax_gdbarch_init): Don't register deleted function with gdbarch.
11155
11156 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11157
11158         * v850-tdep.c (v850_unwind_sp): Delete.
11159         (v850_unwind_pc): Delete.
11160         (v850_dummy_id): Delete.
11161         (v850_gdbarch_init): Don't register deleted functions with
11162         gdbarch.
11163
11164 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11165
11166         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
11167         (tilegx_unwind_pc): Delete.
11168         (tilegx_unwind_dummy_id): Delete.
11169         (tilegx_gdbarch_init): Don't register deleted functions with
11170         gdbarch.
11171
11172 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11173
11174         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
11175         (tic6x_dummy_id): Delete.
11176         (tic6x_gdbarch_init): Don't register deleted functions with
11177         gdbarch.
11178
11179 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11180
11181         * sparc-tdep.c (sparc_unwind_pc): Delete.
11182         (sparc32_gdbarch_init): Don't register deleted function with
11183         gdbarch.
11184
11185 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11186
11187         * sh-tdep.c (sh_unwind_sp): Delete.
11188         (sh_unwind_pc): Delete.
11189         (sh_dummy_id): Delete.
11190         (sh_gdbarch_init): Don't register deleted functions with
11191         gdbarch.
11192
11193 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11194
11195         * score-tdep.c (score_unwind_sp): Delete.
11196         (score_unwind_pc): Delete.
11197         (score_dummy_id): Delete.
11198         (score_gdbarch_init): Don't register deleted functions with
11199         gdbarch.
11200
11201 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11202
11203         * rx-tdep.c (rx_unwind_pc): Delete.
11204         (rx_unwind_sp): Delete.
11205         (rx_dummy_id): Delete.
11206         (rx_gdbarch_init): Don't register deleted functions with
11207         gdbarch.  Update comment.
11208
11209 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11210
11211         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
11212         (rs6000_dummy_id): Delete.
11213         (rs6000_gdbarch_init): Don't register deleted functions with
11214         gdbarch.
11215
11216 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11217
11218         * or1k-tdep.c (or1k_dummy_id): Delete.
11219         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
11220
11221 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11222
11223         * nios2-tdep.c (nios2_dummy_id): Delete.
11224         (nios2_unwind_sp): Delete.
11225         (nios2_gdbarch_init): Don't register deleted functions with
11226         gdbarch.
11227
11228 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11229
11230         * nds32-tdep.c (nds32_dummy_id): Delete.
11231         (nds32_unwind_pc): Delete.
11232         (nds32_unwind_sp): Delete.
11233         (nds32_gdbarch_init): Don't register deleted functions with
11234         gdbarch.
11235
11236 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11237
11238         * msp430-tdep.c (msp430_unwind_pc): Delete.
11239         (msp430_unwind_sp): Delete.
11240         (msp430_dummy_id): Delete.
11241         (msp430_gdbarch_init): Don't register deleted functions with
11242         gdbarch.
11243
11244 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11245
11246         * moxie-tdep.c (moxie_unwind_sp): Delete.
11247         (moxie_unwind_pc): Delete.
11248         (moxie_dummy_id): Delete.
11249         (moxie_gdbarch_init): Don't register deleted functions with
11250         gdbarch.
11251
11252 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11253
11254         * mn10300-tdep.c (mn10300_dummy_id): Delete.
11255         (mn10300_unwind_pc): Delete.
11256         (mn10300_unwind_sp): Delete.
11257         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
11258         mn10300_unwind_sp.
11259         (mn10300_frame_unwind_init): Don't register deleted functions with
11260         gdbarch.
11261
11262 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11263
11264         * mep-tdep.c (mep_unwind_pc): Delete.
11265         (mep_unwind_sp): Delete.
11266         (mep_dummy_id): Delete.
11267         (mep_gdbarch_init): Don't register deleted functions with
11268         gdbarch.
11269
11270 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11271
11272         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
11273         (m68hc11_unwind_sp): Delete.
11274         (m68hc11_gdbarch_init): Don't register deleted functions with
11275         gdbarch.
11276
11277 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11278
11279         * m32r-tdep.c (m32r_unwind_sp): Delete.
11280         (m32r_unwind_pc): Delete.
11281         (m32r_dummy_id): Delete.
11282         (m32r_gdbarch_init): Don't register deleted functions with
11283         gdbarch.
11284
11285 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11286
11287         * m32c-tdep.c (m32c_unwind_pc): Delete.
11288         (m32c_unwind_sp): Delete.
11289         (m32c_dummy_id): Delete.
11290         (m32c_gdbarch_init): Don't register deleted functions with
11291         gdbarch.
11292
11293 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11294
11295         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
11296         (lm32_unwind_pc): Delete.
11297         (lm32_dummy_id): Delete.
11298         (lm32_gdbarch_init): Don't register deleted functions with
11299         gdbarch.
11300
11301 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11302
11303         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
11304         (iq2000_unwind_pc): Delete.
11305         (iq2000_dummy_id): Delete.
11306         (iq2000_gdbarch_init): Don't register deleted functions with
11307         gdbarch.
11308
11309 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11310
11311         * nds32-tdep.c (nds32_type_align): Delete.
11312         (nds32_push_dummy_call): Use type_align instead.
11313
11314 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11315
11316         * arm-tdep.c (arm_type_align): Only handle vector override case.
11317         (arm_push_dummy_call): Use type_align.
11318         (arm_gdbarch_init): Register arm_type_align gdbarch function.
11319
11320 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11321
11322         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
11323         case.
11324         (pass_on_stack): Use type_align.
11325         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
11326         function.
11327
11328 2019-04-23  Tom Tromey  <tromey@adacore.com>
11329
11330         * dwarf2read.c (line_header::file_name_at): Remove unused
11331         overload.
11332
11333 2019-04-23  Tom de Vries  <tdevries@suse.de>
11334
11335         PR gdb/24438
11336         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
11337         invocation.
11338
11339
11340 2019-03-27  Ali Tamur  <tamur@google.com>
11341
11342         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
11343         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
11344         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
11345         (dwarf_expr_context::get_addr_index): Likewise
11346         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
11347         (symbol_needs_eval_context::get_addr_index): Likewise
11348         (disassemble_dwarf_expression): Add DW_OP_addrx
11349         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
11350         (read_cutu_die_from_dwo): Update comment
11351         (skip_one_die): Add DW_FORM_addrx
11352         (read_attribute_value): Likewise
11353         (var_decode_location): Add DW_OP_addrx
11354         (dwarf2_const_value_attr): Add DW_FORM_addrx
11355         (dump_die_shallow): Likewise
11356         (dwarf2_fetch_constant_bytes): Likewise
11357         (decode_locdesc): Add DW_OP_addrx
11358         (skip_form_bytes): Add DW_FORM_addrx
11359
11360 2019-04-22  Ali Tamur  <tamur@google.com>
11361
11362         * MAINTAINERS (Write After Approval): Add self.
11363
11364 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
11365
11366         * solib-svr4.c (get_svr4_info): Add pspace parameter.
11367         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
11368         (open_symbol_file_object): Likewise.
11369         (svr4_default_sos): Add info parameter.
11370         (svr4_read_so_list): Likewise.
11371         (svr4_current_sos_direct): Adjust functions calls to pass down
11372         info.
11373         (svr4_current_sos_1): Add info parameter.
11374         (svr4_current_sos): Call get_svr4_info, pass info down to
11375         svr4_current_sos_1.
11376         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
11377         get_svr4_info.
11378         (svr4_in_dynsym_resolve_code): Pass current_program_space to
11379         get_svr4_info.
11380         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
11381         to get_svr4_info.
11382         (probes_table_remove_objfile_probes): Likewise.
11383         (register_solib_event_probe): Add info parameter.
11384         (solist_update_incremental): Pass info parameter down to
11385         svr4_read_so_list.
11386         (disable_probes_interface): Add info parameter.
11387         (svr4_handle_solib_event): Pass current_program_space to
11388         get_svr4_info.  Adjust disable_probes_interface cleanup.
11389         (svr4_create_probe_breakpoints): Add info parameter, pass it
11390         down to register_solib_event_probe.
11391         (svr4_create_solib_event_breakpoints): Add info parameter,
11392         pass it down to svr4_create_probe_breakpoints.
11393         (enable_break): Pass info down to
11394         svr4_create_solib_event_breakpoints.
11395         (svr4_solib_create_inferior_hook): Pass current_program_space to
11396         get_svr4_info.
11397         (svr4_clear_solib): Likewise.
11398
11399 2019-04-22  Pedro Alves  <palves@redhat.com>
11400
11401         * solib-svr4.c (svr4_free_objfile_observer): New.
11402         (probe_and_action::objfile): New field.
11403         (probes_table_htab_remove_objfile_probes)
11404         (probes_table_remove_objfile_probes): New functions.
11405         (register_solib_event_probe): Add 'objfile' parameter.  Store it
11406         in the new probe_and_action.  Don't store the probe in 'lookup'.
11407         (svr4_create_probe_breakpoints): Pass objfile to
11408         register_solib_event_probe.
11409         (_initialize_svr4_solib): Register a free_objfile observer.
11410
11411 2019-04-19  Tom Tromey  <tom@tromey.com>
11412
11413         * common/queue.h: Remove.
11414
11415 2019-04-19  Tom Tromey  <tom@tromey.com>
11416
11417         * event-loop.c: Don't include "common/queue.h".
11418
11419 2019-04-19  Tom Tromey  <tom@tromey.com>
11420
11421         * remote.c (remote_target): Use delete.
11422         * remote-notif.h: Include <list>, not "common/queue.h".
11423         (notif_client_p): Remove typedef.
11424         (remote_notif_state): Add constructor, destructor, initializer.
11425         <notif_queue>: Now a std::list.
11426         (remote_notif_state_xfree): Don't declare.
11427         * remote-notif.c (remote_notif_process, handle_notification)
11428         (remote_notif_state_allocate): Update.
11429         (~remote_notif_state): Rename from remote_notif_state_xfree.
11430
11431 2019-04-19  Tom Tromey  <tom@tromey.com>
11432
11433         * symfile.c (reread_symbols): Update.
11434         * objfiles.c (objfile_register_static_link)
11435         (objfile_lookup_static_link): Update
11436         (~objfile) Don't delete static_links.
11437         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
11438
11439 2019-04-19  Tom Tromey  <tom@tromey.com>
11440
11441         * type-stack.h (struct type_stack) <insert>: Constify string.
11442         * type-stack.c (type_stack::insert): Constify string.
11443         * gdbtypes.h (lookup_template_type): Update.
11444         (address_space_name_to_int): Update.
11445         * gdbtypes.c (address_space_name_to_int): Make space_identifier
11446         const.
11447         (lookup_template_type): Make name const.
11448         * c-exp.y: Update rules.
11449         (lex_one_token, classify_name, classify_inner_name)
11450         (c_print_token): Update.
11451         * p-exp.y: Update rules.
11452         (yylex): Update.
11453         * f-exp.y: Update rules.
11454         (yylex): Update.
11455         * d-exp.y: Update rules.
11456         (lex_one_token, classify_name, classify_inner_name): Update.
11457         * parse.c (write_dollar_variable, copy_name): Return std::string.
11458         * parser-defs.h (copy_name): Change return type.
11459         * m2-exp.y: Update rules.
11460         (yylex): Update.
11461         * go-exp.y (lex_one_token): Update.
11462         Update rules.
11463         (classify_unsafe_function, classify_packaged_name)
11464         (classify_name, yylex): Update.
11465
11466 2019-04-19  Sergei Trofimovich <siarheit@google.com>
11467
11468         * configure.ac: add --enable-source-highlight switch.
11469         * configure: Regenerate.
11470         * top.c (print_gdb_version): plumb --enable-source-highlight
11471         status to "show configuration".
11472
11473 2019-04-19  Tom Tromey  <tromey@adacore.com>
11474
11475         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
11476         Check ADA_TYPE_P.
11477         (empty_record, ada_template_to_fixed_record_type_1)
11478         (template_to_static_fixed_type)
11479         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
11480         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
11481         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
11482         macros.
11483
11484 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
11485
11486         PR symtab/24423:
11487         * source.c (print_source_lines_base): Advance "iter" when a
11488         control character is seen.
11489
11490 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11491
11492         * inferior.h (struct infcall_suspend_state_deleter):
11493         Catch exception in destructor to avoid crash.
11494
11495 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11496
11497         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
11498         close to the add_com "shell".
11499
11500 2019-04-18  Tom Tromey  <tromey@adacore.com>
11501
11502         * process-stratum-target.h (class process_stratum_target)
11503         <stratum>: Add "final".
11504
11505 2019-04-17  Tom Tromey  <tromey@adacore.com>
11506
11507         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
11508         against nullptr before use.
11509
11510 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
11511
11512         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
11513
11514 2019-04-17  Jim Wilson  <jimw@sifive.com>
11515             Andrew Burgess  <andrew.burgess@embecosm.com>
11516
11517         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
11518         code read might fail, assume 4-byte breakpoint in that case.
11519
11520 2019-04-15  Leszek Swirski  <leszeks@google.com>
11521
11522         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
11523         rather than a hand-rolled POD check when checking for forced MEMORY
11524         classification.
11525
11526 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
11527
11528         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
11529         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
11530         function.
11531         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
11532         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
11533         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
11534         declaration.
11535
11536 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
11537
11538         * aarch64-linux-nat.c
11539         (aarch64_linux_nat_target::thread_architecture): Add override.
11540         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
11541         each VQ.
11542
11543 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
11544
11545         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
11546
11547 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
11548
11549         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
11550         target types of size 96-bits, add some additional comments, and
11551         check that the builtin type we found was the correct size.
11552
11553 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
11554
11555         * utils.c (prompt_for_continue): Don't restore the styling at the
11556         end, as applied_style has the wrong value.  This fixes styling in
11557         long lists of file names that are interrupted by the "Continue?"
11558         prompt.
11559
11560 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
11561
11562         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
11563         * c-lang.c (c_language_defn): Likewise.
11564         (cplus_language_defn): Likewise.
11565         (asm_language_defn): Likewise.
11566         (minimal_language_defn): Likewise.
11567         * d-lang.c (d_language_defn): Likewise.
11568         * f-lang.c (f_language_defn): Likewise.
11569         * go-lang.c (go_language_defn): Likewise.
11570         * language.c (unknown_language_defn): Likewise.
11571         (auto_language_defn): Likewise.
11572         * language.h (struct language_defn): Remove la_magic field.
11573         (LANG_MAGIC): Delete.
11574         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
11575         * objc-lang.c (objc_language_defn): Likewise.
11576         * opencl-lang.c (opencl_language_defn): Likewise.
11577         * p-lang.c (pascal_language_defn): Likewise.
11578         * rust-lang.c (rust_language_defn): Likewise.
11579
11580 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
11581
11582         * riscv-tdep.c (riscv_type_align): New function.
11583         (riscv_type_alignment): Delete.
11584         (riscv_arg_location): Use 'type_align'.
11585         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
11586
11587 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
11588
11589         * gdbtypes.c (type_align): A struct with no non-static fields also
11590         has alignment of 1.
11591
11592 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
11593
11594         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
11595         component to 0.
11596         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
11597         member.
11598         (riscv_struct_info::analyse): New implementation using new
11599         analyse_inner member function.
11600         (riscv_struct_info::field_offset): New member function.
11601         (riscv_struct_info::m_offsets): New member variable.
11602         (riscv_struct_info::analyse_inner): New private member function,
11603         takes the old implementation of riscv_struct_info::analyse but
11604         extended to track field offsets.
11605         (riscv_call_arg_struct): Update the struct folding special cases
11606         to handle cases where empty C++ structs, which are non-zero
11607         length, are found.
11608         (riscv_arg_location): Initialise the length of each location, a
11609         non-zero length now indicates the location is in use.
11610         (riscv_push_dummy_call): Allow for the first location having a
11611         non-zero offset when setting up arguments.
11612         (riscv_return_value): Likewise, but for return values.
11613
11614 2019-04-11  Tom Tromey  <tromey@adacore.com>
11615
11616         * utils.c (internal_vproblem): Make "msg" const.
11617
11618 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
11619
11620         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
11621         * trad-frame.c (trad_frame_reset_saved_regs): New function.
11622         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
11623         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
11624
11625 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
11626
11627         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
11628         function.
11629         (fill_gregset): Call amd64_linux_collect_native_gregset instead
11630         of amd64_collect_native_gregset.
11631         (amd64_linux_nat_target::store_registers): Likewise.
11632
11633 2019-04-10  Tom Tromey  <tom@tromey.com>
11634
11635         * symtab.c (lookup_global_symbol_from_objfile)
11636         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
11637         * objfiles.h (class separate_debug_iterator): New.
11638         (class separate_debug_range): New.
11639         (struct objfile) <separate_debug_objfiles>: New method.
11640         (objfile_separate_debug_iterate): Don't declare.
11641         * objfiles.c (separate_debug_iterator::operator++): Rename from
11642         objfile_separate_debug_iterate.
11643         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
11644         iterator.
11645         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
11646         iterator.
11647
11648 2019-04-10  Tom Tromey  <tom@tromey.com>
11649
11650         * symfile.c (reread_symbols): Remove old comment.
11651         * objfiles.c (free_all_objfiles): Fix a typo.
11652
11653 2019-04-10  Tom Tromey  <tom@tromey.com>
11654
11655         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
11656         * minsyms.c (lookup_minimal_symbol): Use foreach.
11657         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
11658         (lookup_minimal_symbol_solib_trampoline): Likewise.
11659         * symfile.c (reread_symbols): Use foreach.
11660
11661 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
11662             Tom Tromey  <tromey@adacore.com>
11663
11664         PR rust/24414:
11665         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
11666         (rust_lex_int_test): Change "value" to be LONGEST.
11667         (rust_lex_tests): Add test for long integer literal.
11668
11669 2019-04-09  Tom Tromey  <tromey@adacore.com>
11670
11671         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
11672         to bool.
11673         (extended_remote_target::attach): Update.
11674         (remote_target::remote_notice_new_inferior): Update.
11675         (remote_target::add_current_inferior_and_thread): Update.
11676         * inferior.c (exit_inferior_1): Use "false".
11677         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
11678
11679 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
11680
11681         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
11682         the "start" command.
11683
11684 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
11685
11686         * python/py-inferior.c (infpy_thread_from_thread_handle):
11687         Adjust comments to reflect renaming of thread_from_thread_handle
11688         to thread_from_handle.  Adjust keywords.  Fix type error message.
11689         (inferior_object_methods): Add thread_from_handle.  Retain
11690         thread_from_thread_handle, but mark it as deprecated.
11691
11692 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
11693
11694         * gdbthread.h (find_thread_by_handle): Revise declaration.
11695         * thread.c (find_thread_by_handle): Likewise.  Adjust
11696         implementation too.
11697         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
11698         support for buffer objects as handles.
11699
11700 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
11701
11702         * python/py-infthread.c (thpy_thread_handle): New function.
11703         (thread_object_methods): Register thpy_thread_handle.
11704
11705 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
11706
11707         * gdbthread.h (thread_to_thread_handle): Declare.
11708         * thread.c (gdbtypes.h): Include.
11709         (thread_to_thread_handle): New function.
11710
11711         * target.h (struct target_ops): Add thread_info_to_thread_handle.
11712         (target_thread_info_to_thread_handle): Declare.
11713         * target.c (target_thread_info_to_thread_handle): New function.
11714         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
11715         * target-delegates.c: Regenerate.
11716
11717         * linux-thread-db.c (class thread_db_target): Add method
11718         thread_info_to_thread_handle.
11719         (thread_db_target::thread_info_to_thread_handle): Define.
11720         * remote.c (class remote_target): Add new method
11721         thread_info_to_thread_handle.
11722         (remote_target::thread_info_to_thread_handle): Define.
11723
11724 2019-04-08  Pedro Alves  <palves@redhat.com>
11725
11726         * common/common-exceptions.c (throw_exception): Don't create
11727         named object to throw; throw directly.
11728         (throw_it): Likewise.  Don't initialize gdb_exception::message
11729         here, with new; pass FMT and AP to the ctor instead.
11730         * common/common-exceptions.h: Include <string>.
11731         (gdb_exception::gdb_exception(enum return_reason, enum errors,
11732         const char *, va_list)): New ctor.  Use std::make_shared.
11733         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
11734         errors)): Delete.
11735         (gdb_exception_error::gdb_exception_error(enum errors, const char
11736         *, va_list)): New.
11737         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
11738         Add assertion.
11739         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
11740         errors)): Delete.
11741         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
11742         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
11743         Add assertion.
11744
11745 2019-04-08  Tom Tromey  <tom@tromey.com>
11746
11747         * valops.c (value_rtti_indirect_type): Replace throw_exception
11748         with throw.
11749         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
11750         with throw.
11751         * thread.c (thr_try_catch_cmd): Replace throw_exception with
11752         throw.
11753         * target.c (target_translate_tls_address): Replace throw_exception
11754         with throw.
11755         * stack.c (frame_apply_command_count): Replace throw_exception
11756         with throw.
11757         * solib-spu.c (append_ocl_sos): Replace throw_exception with
11758         throw.
11759         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
11760         with throw.
11761         * rs6000-tdep.c (rs6000_frame_cache)
11762         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
11763         * remote.c: Replace throw_exception with throw.
11764         * record-full.c (record_full_message, record_full_wait_1)
11765         (record_full_restore): Replace throw_exception with throw.
11766         * record-btrace.c:
11767         (get_thread_current_frame_id, record_btrace_start_replaying)
11768         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
11769         (cmd_record_btrace_start): Replace throw_exception with throw.
11770         * parse.c (parse_exp_in_context_1): Replace throw_exception with
11771         throw.
11772         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
11773         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
11774         * linespec.c:
11775         (find_linespec_symbols): Replace throw_exception with throw.
11776         * infrun.c (displaced_step_prepare, resume): Replace
11777         throw_exception with throw.
11778         * infcmd.c (post_create_inferior): Replace throw_exception with
11779         throw.
11780         * inf-loop.c (inferior_event_handler): Replace throw_exception
11781         with throw.
11782         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
11783         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
11784         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
11785         (get_prev_frame_always, get_frame_pc_if_available)
11786         (get_frame_address_in_block_if_available, get_frame_language):
11787         Replace throw_exception with throw.
11788         * frame-unwind.c (frame_unwind_try_unwinder): Replace
11789         throw_exception with throw.
11790         * eval.c (fetch_subexp_value, evaluate_var_value)
11791         (evaluate_funcall, evaluate_subexp_standard): Replace
11792         throw_exception with throw.
11793         * dwarf2loc.c (call_site_find_chain)
11794         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
11795         Replace throw_exception with throw.
11796         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
11797         with throw.
11798         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
11799         throw.
11800         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
11801         * completer.c (complete_line_internal): Replace throw_exception
11802         with throw.
11803         * compile/compile-object-run.c (compile_object_run): Replace
11804         throw_exception with throw.
11805         * cli/cli-script.c (process_next_line): Replace throw_exception
11806         with throw.
11807         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
11808         (btrace_enable, btrace_maint_update_pt_packets): Replace
11809         throw_exception with throw.
11810         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
11811         throw_exception with throw.
11812         * break-catch-throw.c (re_set_exception_catchpoint): Replace
11813         throw_exception with throw.
11814         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
11815         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
11816         * aarch64-tdep.c (aarch64_make_prologue_cache)
11817         (aarch64_make_stub_cache): Replace throw_exception with throw.
11818
11819 2019-04-08  Tom Tromey  <tom@tromey.com>
11820
11821         * common/common-exceptions.c (throw_exception): Rename from
11822         throw_exception_cxx.  Remove old copy.  Make argument const.
11823         (throw_it): Create and throw exception objects directly.
11824         * common/common-exceptions.h (throw_exception): Make argument
11825         const.
11826         (struct gdb_exception_error): Add constructor.
11827         (struct gdb_exception_quit): Add constructor.
11828
11829 2019-04-08  Tom Tromey  <tom@tromey.com>
11830
11831         * common/common-exceptions.h (exception_rethrow): Don't declare.
11832         (TRY_SJLJ): Update comment.
11833         (TRY, CATCH, END_CATCH): Remove.
11834         * common/common-exceptions.c (exception_rethrow): Remove.
11835
11836 2019-04-08  Tom Tromey  <tom@tromey.com>
11837
11838         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
11839         Remove.
11840         (gdb_exception_error): Rename from
11841         gdb_exception_RETURN_MASK_ERROR.
11842         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
11843         (gdb_quit_bad_alloc): Update.
11844         * aarch64-tdep.c: Update.
11845         * ada-lang.c: Update.
11846         * ada-typeprint.c: Update.
11847         * ada-valprint.c: Update.
11848         * amd64-tdep.c: Update.
11849         * arch-utils.c: Update.
11850         * break-catch-throw.c: Update.
11851         * breakpoint.c: Update.
11852         * btrace.c: Update.
11853         * c-varobj.c: Update.
11854         * cli/cli-cmds.c: Update.
11855         * cli/cli-interp.c: Update.
11856         * cli/cli-script.c: Update.
11857         * common/common-exceptions.c: Update.
11858         * common/new-op.c: Update.
11859         * common/selftest.c: Update.
11860         * compile/compile-c-symbols.c: Update.
11861         * compile/compile-cplus-symbols.c: Update.
11862         * compile/compile-object-load.c: Update.
11863         * compile/compile-object-run.c: Update.
11864         * completer.c: Update.
11865         * corelow.c: Update.
11866         * cp-abi.c: Update.
11867         * cp-support.c: Update.
11868         * cp-valprint.c: Update.
11869         * darwin-nat.c: Update.
11870         * disasm-selftests.c: Update.
11871         * dtrace-probe.c: Update.
11872         * dwarf-index-cache.c: Update.
11873         * dwarf-index-write.c: Update.
11874         * dwarf2-frame-tailcall.c: Update.
11875         * dwarf2-frame.c: Update.
11876         * dwarf2loc.c: Update.
11877         * dwarf2read.c: Update.
11878         * eval.c: Update.
11879         * event-loop.c: Update.
11880         * event-top.c: Update.
11881         * exec.c: Update.
11882         * f-valprint.c: Update.
11883         * fbsd-tdep.c: Update.
11884         * frame-unwind.c: Update.
11885         * frame.c: Update.
11886         * gdbtypes.c: Update.
11887         * gnu-v3-abi.c: Update.
11888         * guile/guile-internal.h: Update.
11889         * guile/scm-block.c: Update.
11890         * guile/scm-breakpoint.c: Update.
11891         * guile/scm-cmd.c: Update.
11892         * guile/scm-disasm.c: Update.
11893         * guile/scm-frame.c: Update.
11894         * guile/scm-lazy-string.c: Update.
11895         * guile/scm-math.c: Update.
11896         * guile/scm-param.c: Update.
11897         * guile/scm-ports.c: Update.
11898         * guile/scm-pretty-print.c: Update.
11899         * guile/scm-symbol.c: Update.
11900         * guile/scm-symtab.c: Update.
11901         * guile/scm-type.c: Update.
11902         * guile/scm-value.c: Update.
11903         * i386-linux-tdep.c: Update.
11904         * i386-tdep.c: Update.
11905         * inf-loop.c: Update.
11906         * infcall.c: Update.
11907         * infcmd.c: Update.
11908         * infrun.c: Update.
11909         * jit.c: Update.
11910         * language.c: Update.
11911         * linespec.c: Update.
11912         * linux-fork.c: Update.
11913         * linux-nat.c: Update.
11914         * linux-tdep.c: Update.
11915         * linux-thread-db.c: Update.
11916         * main.c: Update.
11917         * mi/mi-cmd-break.c: Update.
11918         * mi/mi-cmd-stack.c: Update.
11919         * mi/mi-interp.c: Update.
11920         * mi/mi-main.c: Update.
11921         * objc-lang.c: Update.
11922         * p-valprint.c: Update.
11923         * parse.c: Update.
11924         * ppc-linux-tdep.c: Update.
11925         * printcmd.c: Update.
11926         * python/py-arch.c: Update.
11927         * python/py-breakpoint.c: Update.
11928         * python/py-cmd.c: Update.
11929         * python/py-finishbreakpoint.c: Update.
11930         * python/py-frame.c: Update.
11931         * python/py-framefilter.c: Update.
11932         * python/py-gdb-readline.c: Update.
11933         * python/py-inferior.c: Update.
11934         * python/py-infthread.c: Update.
11935         * python/py-lazy-string.c: Update.
11936         * python/py-linetable.c: Update.
11937         * python/py-objfile.c: Update.
11938         * python/py-param.c: Update.
11939         * python/py-prettyprint.c: Update.
11940         * python/py-progspace.c: Update.
11941         * python/py-record-btrace.c: Update.
11942         * python/py-record.c: Update.
11943         * python/py-symbol.c: Update.
11944         * python/py-type.c: Update.
11945         * python/py-unwind.c: Update.
11946         * python/py-utils.c: Update.
11947         * python/py-value.c: Update.
11948         * python/python.c: Update.
11949         * record-btrace.c: Update.
11950         * record-full.c: Update.
11951         * remote-fileio.c: Update.
11952         * remote.c: Update.
11953         * riscv-tdep.c: Update.
11954         * rs6000-aix-tdep.c: Update.
11955         * rs6000-tdep.c: Update.
11956         * rust-exp.y: Update.
11957         * rust-lang.c: Update.
11958         * s390-tdep.c: Update.
11959         * selftest-arch.c: Update.
11960         * solib-dsbt.c: Update.
11961         * solib-frv.c: Update.
11962         * solib-spu.c: Update.
11963         * solib-svr4.c: Update.
11964         * solib.c: Update.
11965         * sparc64-linux-tdep.c: Update.
11966         * stack.c: Update.
11967         * symfile-mem.c: Update.
11968         * symmisc.c: Update.
11969         * target.c: Update.
11970         * thread.c: Update.
11971         * top.c: Update.
11972         * tracefile-tfile.c: Update.
11973         * tui/tui.c: Update.
11974         * typeprint.c: Update.
11975         * unittests/cli-utils-selftests.c: Update.
11976         * unittests/parse-connection-spec-selftests.c: Update.
11977         * valops.c: Update.
11978         * valprint.c: Update.
11979         * value.c: Update.
11980         * varobj.c: Update.
11981         * windows-nat.c: Update.
11982         * x86-linux-nat.c: Update.
11983         * xml-support.c: Update.
11984
11985 2019-04-08  Tom Tromey  <tom@tromey.com>
11986
11987         * xml-support.c: Use C++ exception handling.
11988         * x86-linux-nat.c: Use C++ exception handling.
11989         * windows-nat.c: Use C++ exception handling.
11990         * varobj.c: Use C++ exception handling.
11991         * value.c: Use C++ exception handling.
11992         * valprint.c: Use C++ exception handling.
11993         * valops.c: Use C++ exception handling.
11994         * unittests/parse-connection-spec-selftests.c: Use C++ exception
11995         handling.
11996         * unittests/cli-utils-selftests.c: Use C++ exception handling.
11997         * typeprint.c: Use C++ exception handling.
11998         * tui/tui.c: Use C++ exception handling.
11999         * tracefile-tfile.c: Use C++ exception handling.
12000         * top.c: Use C++ exception handling.
12001         * thread.c: Use C++ exception handling.
12002         * target.c: Use C++ exception handling.
12003         * symmisc.c: Use C++ exception handling.
12004         * symfile-mem.c: Use C++ exception handling.
12005         * stack.c: Use C++ exception handling.
12006         * sparc64-linux-tdep.c: Use C++ exception handling.
12007         * solib.c: Use C++ exception handling.
12008         * solib-svr4.c: Use C++ exception handling.
12009         * solib-spu.c: Use C++ exception handling.
12010         * solib-frv.c: Use C++ exception handling.
12011         * solib-dsbt.c: Use C++ exception handling.
12012         * selftest-arch.c: Use C++ exception handling.
12013         * s390-tdep.c: Use C++ exception handling.
12014         * rust-lang.c: Use C++ exception handling.
12015         * rust-exp.y: Use C++ exception handling.
12016         * rs6000-tdep.c: Use C++ exception handling.
12017         * rs6000-aix-tdep.c: Use C++ exception handling.
12018         * riscv-tdep.c: Use C++ exception handling.
12019         * remote.c: Use C++ exception handling.
12020         * remote-fileio.c: Use C++ exception handling.
12021         * record-full.c: Use C++ exception handling.
12022         * record-btrace.c: Use C++ exception handling.
12023         * python/python.c: Use C++ exception handling.
12024         * python/py-value.c: Use C++ exception handling.
12025         * python/py-utils.c: Use C++ exception handling.
12026         * python/py-unwind.c: Use C++ exception handling.
12027         * python/py-type.c: Use C++ exception handling.
12028         * python/py-symbol.c: Use C++ exception handling.
12029         * python/py-record.c: Use C++ exception handling.
12030         * python/py-record-btrace.c: Use C++ exception handling.
12031         * python/py-progspace.c: Use C++ exception handling.
12032         * python/py-prettyprint.c: Use C++ exception handling.
12033         * python/py-param.c: Use C++ exception handling.
12034         * python/py-objfile.c: Use C++ exception handling.
12035         * python/py-linetable.c: Use C++ exception handling.
12036         * python/py-lazy-string.c: Use C++ exception handling.
12037         * python/py-infthread.c: Use C++ exception handling.
12038         * python/py-inferior.c: Use C++ exception handling.
12039         * python/py-gdb-readline.c: Use C++ exception handling.
12040         * python/py-framefilter.c: Use C++ exception handling.
12041         * python/py-frame.c: Use C++ exception handling.
12042         * python/py-finishbreakpoint.c: Use C++ exception handling.
12043         * python/py-cmd.c: Use C++ exception handling.
12044         * python/py-breakpoint.c: Use C++ exception handling.
12045         * python/py-arch.c: Use C++ exception handling.
12046         * printcmd.c: Use C++ exception handling.
12047         * ppc-linux-tdep.c: Use C++ exception handling.
12048         * parse.c: Use C++ exception handling.
12049         * p-valprint.c: Use C++ exception handling.
12050         * objc-lang.c: Use C++ exception handling.
12051         * mi/mi-main.c: Use C++ exception handling.
12052         * mi/mi-interp.c: Use C++ exception handling.
12053         * mi/mi-cmd-stack.c: Use C++ exception handling.
12054         * mi/mi-cmd-break.c: Use C++ exception handling.
12055         * main.c: Use C++ exception handling.
12056         * linux-thread-db.c: Use C++ exception handling.
12057         * linux-tdep.c: Use C++ exception handling.
12058         * linux-nat.c: Use C++ exception handling.
12059         * linux-fork.c: Use C++ exception handling.
12060         * linespec.c: Use C++ exception handling.
12061         * language.c: Use C++ exception handling.
12062         * jit.c: Use C++ exception handling.
12063         * infrun.c: Use C++ exception handling.
12064         * infcmd.c: Use C++ exception handling.
12065         * infcall.c: Use C++ exception handling.
12066         * inf-loop.c: Use C++ exception handling.
12067         * i386-tdep.c: Use C++ exception handling.
12068         * i386-linux-tdep.c: Use C++ exception handling.
12069         * guile/scm-value.c: Use C++ exception handling.
12070         * guile/scm-type.c: Use C++ exception handling.
12071         * guile/scm-symtab.c: Use C++ exception handling.
12072         * guile/scm-symbol.c: Use C++ exception handling.
12073         * guile/scm-pretty-print.c: Use C++ exception handling.
12074         * guile/scm-ports.c: Use C++ exception handling.
12075         * guile/scm-param.c: Use C++ exception handling.
12076         * guile/scm-math.c: Use C++ exception handling.
12077         * guile/scm-lazy-string.c: Use C++ exception handling.
12078         * guile/scm-frame.c: Use C++ exception handling.
12079         * guile/scm-disasm.c: Use C++ exception handling.
12080         * guile/scm-cmd.c: Use C++ exception handling.
12081         * guile/scm-breakpoint.c: Use C++ exception handling.
12082         * guile/scm-block.c: Use C++ exception handling.
12083         * guile/guile-internal.h: Use C++ exception handling.
12084         * gnu-v3-abi.c: Use C++ exception handling.
12085         * gdbtypes.c: Use C++ exception handling.
12086         * frame.c: Use C++ exception handling.
12087         * frame-unwind.c: Use C++ exception handling.
12088         * fbsd-tdep.c: Use C++ exception handling.
12089         * f-valprint.c: Use C++ exception handling.
12090         * exec.c: Use C++ exception handling.
12091         * event-top.c: Use C++ exception handling.
12092         * event-loop.c: Use C++ exception handling.
12093         * eval.c: Use C++ exception handling.
12094         * dwarf2read.c: Use C++ exception handling.
12095         * dwarf2loc.c: Use C++ exception handling.
12096         * dwarf2-frame.c: Use C++ exception handling.
12097         * dwarf2-frame-tailcall.c: Use C++ exception handling.
12098         * dwarf-index-write.c: Use C++ exception handling.
12099         * dwarf-index-cache.c: Use C++ exception handling.
12100         * dtrace-probe.c: Use C++ exception handling.
12101         * disasm-selftests.c: Use C++ exception handling.
12102         * darwin-nat.c: Use C++ exception handling.
12103         * cp-valprint.c: Use C++ exception handling.
12104         * cp-support.c: Use C++ exception handling.
12105         * cp-abi.c: Use C++ exception handling.
12106         * corelow.c: Use C++ exception handling.
12107         * completer.c: Use C++ exception handling.
12108         * compile/compile-object-run.c: Use C++ exception handling.
12109         * compile/compile-object-load.c: Use C++ exception handling.
12110         * compile/compile-cplus-symbols.c: Use C++ exception handling.
12111         * compile/compile-c-symbols.c: Use C++ exception handling.
12112         * common/selftest.c: Use C++ exception handling.
12113         * common/new-op.c: Use C++ exception handling.
12114         * cli/cli-script.c: Use C++ exception handling.
12115         * cli/cli-interp.c: Use C++ exception handling.
12116         * cli/cli-cmds.c: Use C++ exception handling.
12117         * c-varobj.c: Use C++ exception handling.
12118         * btrace.c: Use C++ exception handling.
12119         * breakpoint.c: Use C++ exception handling.
12120         * break-catch-throw.c: Use C++ exception handling.
12121         * arch-utils.c: Use C++ exception handling.
12122         * amd64-tdep.c: Use C++ exception handling.
12123         * ada-valprint.c: Use C++ exception handling.
12124         * ada-typeprint.c: Use C++ exception handling.
12125         * ada-lang.c: Use C++ exception handling.
12126         * aarch64-tdep.c: Use C++ exception handling.
12127
12128 2019-04-08  Tom Tromey  <tom@tromey.com>
12129
12130         * xml-support.c (gdb_xml_parser::parse): Update.
12131         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
12132         * value.c (show_convenience): Update.
12133         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
12134         (test_parse_flags_qcs): Update.
12135         * thread.c (thr_try_catch_cmd): Update.
12136         * target.c (target_translate_tls_address): Update.
12137         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
12138         (info_frame_command_core, frame_apply_command_count): Update.
12139         * rust-exp.y (rust_lex_exception_test): Update.
12140         * riscv-tdep.c (riscv_print_one_register_info): Update.
12141         * remote.c (remote_target::enable_btrace): Update.
12142         * record-btrace.c (record_btrace_enable_warn): Update.
12143         * python/py-utils.c (gdbpy_convert_exception): Update.
12144         * printcmd.c (do_one_display, print_variable_and_value): Update.
12145         * mi/mi-main.c (mi_print_exception): Update.
12146         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
12147         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
12148         * linux-nat.c (linux_nat_target::attach): Update.
12149         * linux-fork.c (class scoped_switch_fork_info): Update.
12150         * infrun.c (displaced_step_prepare): Update.
12151         * infcall.c (call_function_by_hand_dummy): Update.
12152         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
12153         * gnu-v3-abi.c (print_one_vtable): Update.
12154         * frame.c (get_prev_frame_always): Update.
12155         * f-valprint.c (info_common_command_for_block): Update.
12156         * exec.c (try_open_exec_file): Update.
12157         * exceptions.c (print_exception, exception_print)
12158         (exception_fprintf, exception_print_same): Update.
12159         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
12160         * dwarf-index-cache.c (index_cache::store)
12161         (index_cache::lookup_gdb_index): Update.
12162         * darwin-nat.c (maybe_cache_shell): Update.
12163         * cp-valprint.c (cp_print_value_fields): Update.
12164         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
12165         (gcc_cplus_symbol_address): Update.
12166         * compile/compile-c-symbols.c (gcc_convert_symbol)
12167         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
12168         * common/selftest.c: Update.
12169         * common/common-exceptions.h (struct gdb_exception) <message>: Now
12170         a std::string.
12171         (exception_try_scope_entry, exception_try_scope_exit): Don't
12172         declare.
12173         (struct exception_try_scope): Remove.
12174         (TRY): Don't use exception_try_scope.
12175         (struct gdb_exception): Add constructor, operator=.
12176         <what>: New method.
12177         (struct gdb_exception_RETURN_MASK_ALL)
12178         (struct gdb_exception_RETURN_MASK_ERROR)
12179         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
12180         (struct gdb_quit_bad_alloc): Update.
12181         * common/common-exceptions.c (exception_none): Change
12182         initializer.
12183         (struct catcher) <state, exception>: Initialize inline.
12184         <prev>: Remove member.
12185         (current_catcher): Remove.
12186         (catchers): New global.
12187         (exceptions_state_mc_init): Simplify.
12188         (catcher_pop): Remove.
12189         (exceptions_state_mc, exceptions_state_mc_catch): Update.
12190         (try_scope_depth, exception_try_scope_entry)
12191         (exception_try_scope_exit): Remove.
12192         (throw_exception_sjlj): Update.
12193         (exception_messages, exception_messages_size): Remove.
12194         (throw_it): Simplify.
12195         (gdb_exception_sliced_copy): Remove.
12196         (throw_exception_cxx): Update.
12197         * cli/cli-script.c (script_from_file): Update.
12198         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
12199         Update.
12200         * ada-valprint.c (ada_val_print): Update.
12201         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
12202         (create_excep_cond_exprs): Update.
12203
12204 2019-04-08  Tom Tromey  <tom@tromey.com>
12205
12206         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
12207         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
12208         (TRY, CATCH, END_CATCH): Remove some definitions.
12209         * common/common-exceptions.c: Don't use GDB_XCPT.
12210         (catcher_list_size): Remove.
12211         (throw_exception, throw_it): Simplify.
12212
12213 2019-04-05  Tom Tromey  <tom@tromey.com>
12214
12215         Revert the header-sorting patch.
12216         * ft32-tdep.c: Revert.
12217         * frv-tdep.c: Revert.
12218         * frv-linux-tdep.c: Revert.
12219         * frame.c: Revert.
12220         * frame-unwind.c: Revert.
12221         * frame-base.c: Revert.
12222         * fork-child.c: Revert.
12223         * findvar.c: Revert.
12224         * findcmd.c: Revert.
12225         * filesystem.c: Revert.
12226         * filename-seen-cache.h: Revert.
12227         * filename-seen-cache.c: Revert.
12228         * fbsd-tdep.c: Revert.
12229         * fbsd-nat.h: Revert.
12230         * fbsd-nat.c: Revert.
12231         * f-valprint.c: Revert.
12232         * f-typeprint.c: Revert.
12233         * f-lang.c: Revert.
12234         * extension.h: Revert.
12235         * extension.c: Revert.
12236         * extension-priv.h: Revert.
12237         * expprint.c: Revert.
12238         * exec.h: Revert.
12239         * exec.c: Revert.
12240         * exceptions.c: Revert.
12241         * event-top.c: Revert.
12242         * event-loop.c: Revert.
12243         * eval.c: Revert.
12244         * elfread.c: Revert.
12245         * dwarf2read.h: Revert.
12246         * dwarf2read.c: Revert.
12247         * dwarf2loc.c: Revert.
12248         * dwarf2expr.h: Revert.
12249         * dwarf2expr.c: Revert.
12250         * dwarf2-frame.c: Revert.
12251         * dwarf2-frame-tailcall.c: Revert.
12252         * dwarf-index-write.h: Revert.
12253         * dwarf-index-write.c: Revert.
12254         * dwarf-index-common.c: Revert.
12255         * dwarf-index-cache.h: Revert.
12256         * dwarf-index-cache.c: Revert.
12257         * dummy-frame.c: Revert.
12258         * dtrace-probe.c: Revert.
12259         * disasm.h: Revert.
12260         * disasm.c: Revert.
12261         * disasm-selftests.c: Revert.
12262         * dictionary.c: Revert.
12263         * dicos-tdep.c: Revert.
12264         * demangle.c: Revert.
12265         * dcache.h: Revert.
12266         * dcache.c: Revert.
12267         * darwin-nat.h: Revert.
12268         * darwin-nat.c: Revert.
12269         * darwin-nat-info.c: Revert.
12270         * d-valprint.c: Revert.
12271         * d-namespace.c: Revert.
12272         * d-lang.c: Revert.
12273         * ctf.c: Revert.
12274         * csky-tdep.c: Revert.
12275         * csky-linux-tdep.c: Revert.
12276         * cris-tdep.c: Revert.
12277         * cris-linux-tdep.c: Revert.
12278         * cp-valprint.c: Revert.
12279         * cp-support.c: Revert.
12280         * cp-namespace.c: Revert.
12281         * cp-abi.c: Revert.
12282         * corelow.c: Revert.
12283         * corefile.c: Revert.
12284         * continuations.c: Revert.
12285         * completer.h: Revert.
12286         * completer.c: Revert.
12287         * complaints.c: Revert.
12288         * coffread.c: Revert.
12289         * coff-pe-read.c: Revert.
12290         * cli-out.h: Revert.
12291         * cli-out.c: Revert.
12292         * charset.c: Revert.
12293         * c-varobj.c: Revert.
12294         * c-valprint.c: Revert.
12295         * c-typeprint.c: Revert.
12296         * c-lang.c: Revert.
12297         * buildsym.c: Revert.
12298         * buildsym-legacy.c: Revert.
12299         * build-id.h: Revert.
12300         * build-id.c: Revert.
12301         * btrace.c: Revert.
12302         * bsd-uthread.c: Revert.
12303         * breakpoint.h: Revert.
12304         * breakpoint.c: Revert.
12305         * break-catch-throw.c: Revert.
12306         * break-catch-syscall.c: Revert.
12307         * break-catch-sig.c: Revert.
12308         * blockframe.c: Revert.
12309         * block.c: Revert.
12310         * bfin-tdep.c: Revert.
12311         * bfin-linux-tdep.c: Revert.
12312         * bfd-target.c: Revert.
12313         * bcache.c: Revert.
12314         * ax-general.c: Revert.
12315         * ax-gdb.h: Revert.
12316         * ax-gdb.c: Revert.
12317         * avr-tdep.c: Revert.
12318         * auxv.c: Revert.
12319         * auto-load.c: Revert.
12320         * arm-wince-tdep.c: Revert.
12321         * arm-tdep.c: Revert.
12322         * arm-symbian-tdep.c: Revert.
12323         * arm-pikeos-tdep.c: Revert.
12324         * arm-obsd-tdep.c: Revert.
12325         * arm-nbsd-tdep.c: Revert.
12326         * arm-nbsd-nat.c: Revert.
12327         * arm-linux-tdep.c: Revert.
12328         * arm-linux-nat.c: Revert.
12329         * arm-fbsd-tdep.c: Revert.
12330         * arm-fbsd-nat.c: Revert.
12331         * arm-bsd-tdep.c: Revert.
12332         * arch-utils.c: Revert.
12333         * arc-tdep.c: Revert.
12334         * arc-newlib-tdep.c: Revert.
12335         * annotate.h: Revert.
12336         * annotate.c: Revert.
12337         * amd64-windows-tdep.c: Revert.
12338         * amd64-windows-nat.c: Revert.
12339         * amd64-tdep.c: Revert.
12340         * amd64-sol2-tdep.c: Revert.
12341         * amd64-obsd-tdep.c: Revert.
12342         * amd64-obsd-nat.c: Revert.
12343         * amd64-nbsd-tdep.c: Revert.
12344         * amd64-nbsd-nat.c: Revert.
12345         * amd64-nat.c: Revert.
12346         * amd64-linux-tdep.c: Revert.
12347         * amd64-linux-nat.c: Revert.
12348         * amd64-fbsd-tdep.c: Revert.
12349         * amd64-fbsd-nat.c: Revert.
12350         * amd64-dicos-tdep.c: Revert.
12351         * amd64-darwin-tdep.c: Revert.
12352         * amd64-bsd-nat.c: Revert.
12353         * alpha-tdep.c: Revert.
12354         * alpha-obsd-tdep.c: Revert.
12355         * alpha-nbsd-tdep.c: Revert.
12356         * alpha-mdebug-tdep.c: Revert.
12357         * alpha-linux-tdep.c: Revert.
12358         * alpha-linux-nat.c: Revert.
12359         * alpha-bsd-tdep.c: Revert.
12360         * alpha-bsd-nat.c: Revert.
12361         * aix-thread.c: Revert.
12362         * agent.c: Revert.
12363         * addrmap.c: Revert.
12364         * ada-varobj.c: Revert.
12365         * ada-valprint.c: Revert.
12366         * ada-typeprint.c: Revert.
12367         * ada-tasks.c: Revert.
12368         * ada-lang.c: Revert.
12369         * aarch64-tdep.c: Revert.
12370         * aarch64-ravenscar-thread.c: Revert.
12371         * aarch64-newlib-tdep.c: Revert.
12372         * aarch64-linux-tdep.c: Revert.
12373         * aarch64-linux-nat.c: Revert.
12374         * aarch64-fbsd-tdep.c: Revert.
12375         * aarch64-fbsd-nat.c: Revert.
12376         * aarch32-linux-nat.c: Revert.
12377
12378 2019-04-05  Tom Tromey  <tom@tromey.com>
12379
12380         * ft32-tdep.c: Sort headers.
12381         * frv-tdep.c: Sort headers.
12382         * frv-linux-tdep.c: Sort headers.
12383         * frame.c: Sort headers.
12384         * frame-unwind.c: Sort headers.
12385         * frame-base.c: Sort headers.
12386         * fork-child.c: Sort headers.
12387         * findvar.c: Sort headers.
12388         * findcmd.c: Sort headers.
12389         * filesystem.c: Sort headers.
12390         * filename-seen-cache.h: Sort headers.
12391         * filename-seen-cache.c: Sort headers.
12392         * fbsd-tdep.c: Sort headers.
12393         * fbsd-nat.h: Sort headers.
12394         * fbsd-nat.c: Sort headers.
12395         * f-valprint.c: Sort headers.
12396         * f-typeprint.c: Sort headers.
12397         * f-lang.c: Sort headers.
12398         * extension.h: Sort headers.
12399         * extension.c: Sort headers.
12400         * extension-priv.h: Sort headers.
12401         * expprint.c: Sort headers.
12402         * exec.h: Sort headers.
12403         * exec.c: Sort headers.
12404         * exceptions.c: Sort headers.
12405         * event-top.c: Sort headers.
12406         * event-loop.c: Sort headers.
12407         * eval.c: Sort headers.
12408         * elfread.c: Sort headers.
12409         * dwarf2read.h: Sort headers.
12410         * dwarf2read.c: Sort headers.
12411         * dwarf2loc.c: Sort headers.
12412         * dwarf2expr.h: Sort headers.
12413         * dwarf2expr.c: Sort headers.
12414         * dwarf2-frame.c: Sort headers.
12415         * dwarf2-frame-tailcall.c: Sort headers.
12416         * dwarf-index-write.h: Sort headers.
12417         * dwarf-index-write.c: Sort headers.
12418         * dwarf-index-common.c: Sort headers.
12419         * dwarf-index-cache.h: Sort headers.
12420         * dwarf-index-cache.c: Sort headers.
12421         * dummy-frame.c: Sort headers.
12422         * dtrace-probe.c: Sort headers.
12423         * disasm.h: Sort headers.
12424         * disasm.c: Sort headers.
12425         * disasm-selftests.c: Sort headers.
12426         * dictionary.c: Sort headers.
12427         * dicos-tdep.c: Sort headers.
12428         * demangle.c: Sort headers.
12429         * dcache.h: Sort headers.
12430         * dcache.c: Sort headers.
12431         * darwin-nat.h: Sort headers.
12432         * darwin-nat.c: Sort headers.
12433         * darwin-nat-info.c: Sort headers.
12434         * d-valprint.c: Sort headers.
12435         * d-namespace.c: Sort headers.
12436         * d-lang.c: Sort headers.
12437         * ctf.c: Sort headers.
12438         * csky-tdep.c: Sort headers.
12439         * csky-linux-tdep.c: Sort headers.
12440         * cris-tdep.c: Sort headers.
12441         * cris-linux-tdep.c: Sort headers.
12442         * cp-valprint.c: Sort headers.
12443         * cp-support.c: Sort headers.
12444         * cp-namespace.c: Sort headers.
12445         * cp-abi.c: Sort headers.
12446         * corelow.c: Sort headers.
12447         * corefile.c: Sort headers.
12448         * continuations.c: Sort headers.
12449         * completer.h: Sort headers.
12450         * completer.c: Sort headers.
12451         * complaints.c: Sort headers.
12452         * coffread.c: Sort headers.
12453         * coff-pe-read.c: Sort headers.
12454         * cli-out.h: Sort headers.
12455         * cli-out.c: Sort headers.
12456         * charset.c: Sort headers.
12457         * c-varobj.c: Sort headers.
12458         * c-valprint.c: Sort headers.
12459         * c-typeprint.c: Sort headers.
12460         * c-lang.c: Sort headers.
12461         * buildsym.c: Sort headers.
12462         * buildsym-legacy.c: Sort headers.
12463         * build-id.h: Sort headers.
12464         * build-id.c: Sort headers.
12465         * btrace.c: Sort headers.
12466         * bsd-uthread.c: Sort headers.
12467         * breakpoint.h: Sort headers.
12468         * breakpoint.c: Sort headers.
12469         * break-catch-throw.c: Sort headers.
12470         * break-catch-syscall.c: Sort headers.
12471         * break-catch-sig.c: Sort headers.
12472         * blockframe.c: Sort headers.
12473         * block.c: Sort headers.
12474         * bfin-tdep.c: Sort headers.
12475         * bfin-linux-tdep.c: Sort headers.
12476         * bfd-target.c: Sort headers.
12477         * bcache.c: Sort headers.
12478         * ax-general.c: Sort headers.
12479         * ax-gdb.h: Sort headers.
12480         * ax-gdb.c: Sort headers.
12481         * avr-tdep.c: Sort headers.
12482         * auxv.c: Sort headers.
12483         * auto-load.c: Sort headers.
12484         * arm-wince-tdep.c: Sort headers.
12485         * arm-tdep.c: Sort headers.
12486         * arm-symbian-tdep.c: Sort headers.
12487         * arm-pikeos-tdep.c: Sort headers.
12488         * arm-obsd-tdep.c: Sort headers.
12489         * arm-nbsd-tdep.c: Sort headers.
12490         * arm-nbsd-nat.c: Sort headers.
12491         * arm-linux-tdep.c: Sort headers.
12492         * arm-linux-nat.c: Sort headers.
12493         * arm-fbsd-tdep.c: Sort headers.
12494         * arm-fbsd-nat.c: Sort headers.
12495         * arm-bsd-tdep.c: Sort headers.
12496         * arch-utils.c: Sort headers.
12497         * arc-tdep.c: Sort headers.
12498         * arc-newlib-tdep.c: Sort headers.
12499         * annotate.h: Sort headers.
12500         * annotate.c: Sort headers.
12501         * amd64-windows-tdep.c: Sort headers.
12502         * amd64-windows-nat.c: Sort headers.
12503         * amd64-tdep.c: Sort headers.
12504         * amd64-sol2-tdep.c: Sort headers.
12505         * amd64-obsd-tdep.c: Sort headers.
12506         * amd64-obsd-nat.c: Sort headers.
12507         * amd64-nbsd-tdep.c: Sort headers.
12508         * amd64-nbsd-nat.c: Sort headers.
12509         * amd64-nat.c: Sort headers.
12510         * amd64-linux-tdep.c: Sort headers.
12511         * amd64-linux-nat.c: Sort headers.
12512         * amd64-fbsd-tdep.c: Sort headers.
12513         * amd64-fbsd-nat.c: Sort headers.
12514         * amd64-dicos-tdep.c: Sort headers.
12515         * amd64-darwin-tdep.c: Sort headers.
12516         * amd64-bsd-nat.c: Sort headers.
12517         * alpha-tdep.c: Sort headers.
12518         * alpha-obsd-tdep.c: Sort headers.
12519         * alpha-nbsd-tdep.c: Sort headers.
12520         * alpha-mdebug-tdep.c: Sort headers.
12521         * alpha-linux-tdep.c: Sort headers.
12522         * alpha-linux-nat.c: Sort headers.
12523         * alpha-bsd-tdep.c: Sort headers.
12524         * alpha-bsd-nat.c: Sort headers.
12525         * aix-thread.c: Sort headers.
12526         * agent.c: Sort headers.
12527         * addrmap.c: Sort headers.
12528         * ada-varobj.c: Sort headers.
12529         * ada-valprint.c: Sort headers.
12530         * ada-typeprint.c: Sort headers.
12531         * ada-tasks.c: Sort headers.
12532         * ada-lang.c: Sort headers.
12533         * aarch64-tdep.c: Sort headers.
12534         * aarch64-ravenscar-thread.c: Sort headers.
12535         * aarch64-newlib-tdep.c: Sort headers.
12536         * aarch64-linux-tdep.c: Sort headers.
12537         * aarch64-linux-nat.c: Sort headers.
12538         * aarch64-fbsd-tdep.c: Sort headers.
12539         * aarch64-fbsd-nat.c: Sort headers.
12540         * aarch32-linux-nat.c: Sort headers.
12541
12542 2019-04-04  Tom Tromey  <tom@tromey.com>
12543
12544         * varobj.c (varobj_create): Update.
12545         * rust-exp.y (struct rust_parser) <update_innermost_block,
12546         lookup_symbol>: New methods.
12547         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
12548         Rename.
12549         (rust_parser::rust_lookup_type)
12550         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
12551         * printcmd.c (display_command, do_one_display): Update.
12552         * parser-defs.h (struct parser_state) <parser_state>: Add
12553         "tracker" parameter.
12554         (block_tracker): New member.
12555         (class innermost_block_tracker) <innermost_block_tracker>: Add
12556         "types" parameter.
12557         <reset>: Remove method.
12558         (innermost_block): Don't declare.
12559         (null_post_parser): Update.
12560         * parse.c (innermost_block): Remove global.
12561         (write_dollar_variable): Update.
12562         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
12563         Remove "tracker_types" parameter.
12564         (parse_expression): Add "tracker" parameter.
12565         (parse_expression_for_completion): Update.
12566         (null_post_parser): Add "tracker" parameter.
12567         * p-exp.y: Update rules.
12568         * m2-exp.y: Update rules.
12569         * language.h (struct language_defn) <la_post_parser>: Add
12570         "tracker" parameter.
12571         * go-exp.y: Update rules.
12572         * f-exp.y: Update rules.
12573         * expression.h (parse_expression, parse_exp_1): Add "tracker"
12574         parameter.
12575         * d-exp.y: Update rules.
12576         * c-exp.y: Update rules.
12577         * breakpoint.c (set_breakpoint_condition): Create an
12578         innermost_block_tracker.
12579         (watch_command_1): Likewise.
12580         * ada-lang.c (resolve): Add "tracker" parameter.
12581         (resolve_subexp): Likewise.
12582         * ada-exp.y (write_var_from_sym): Update.
12583
12584 2019-04-04  Tom Tromey  <tom@tromey.com>
12585
12586         * type-stack.h: New file.
12587         * type-stack.c: New file.
12588         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
12589         type-stack.h.
12590         (insert_into_type_stack, insert_type, push_type, push_type_int)
12591         (insert_type_address_space, pop_type, pop_type_int)
12592         (pop_typelist, pop_type_stack, append_type_stack)
12593         (push_type_stack, get_type_stack, push_typelist)
12594         (follow_type_instance_flags, follow_types): Don't declare.
12595         * parse.c (type_stack): Remove global.
12596         (parse_exp_in_context): Update.
12597         (insert_into_type_stack, insert_type, push_type, push_type_int)
12598         (insert_type_address_space, pop_type, pop_type_int)
12599         (pop_typelist, pop_type_stack, append_type_stack)
12600         (push_type_stack, get_type_stack, push_typelist)
12601         (follow_type_instance_flags, follow_types): Remove (moved to
12602         type-stack.c).
12603         * f-exp.y (type_stack): New global.
12604         Update rules.
12605         (push_kind_type, f_parse): Update.
12606         * d-exp.y (type_stack): New global.
12607         Update rules.
12608         (d_parse): Update.
12609         * c-exp.y (struct c_parse_state) <type_stack>: New member.
12610         Update rules.
12611         * Makefile.in (COMMON_SFILES): Add type-stack.c.
12612         (HFILES_NO_SRCDIR): Add type-stack.h.
12613
12614 2019-04-04  Tom Tromey  <tom@tromey.com>
12615
12616         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
12617         (rust_parser::convert_ast_to_expression, rust_parse)
12618         (rust_lex_test_completion, rust_lex_tests): Update.
12619         * parser-defs.h (struct expr_completion_state): New.
12620         (struct parser_state) <parser_state>: Add completion parameter.
12621         <mark_struct_expression, mark_completion_tag>: New methods.
12622         <parse_completion, m_completion_state>: New members.
12623         (prefixify_expression, null_post_parser): Update.
12624         (mark_struct_expression, mark_completion_tag): Don't declare.
12625         * parse.c (parse_completion, expout_last_struct)
12626         (expout_tag_completion_type, expout_completion_name): Remove
12627         globals.
12628         (parser_state::mark_struct_expression)
12629         (parser_state::mark_completion_tag): Now methods.
12630         (prefixify_expression): Add last_struct parameter.
12631         (prefixify_subexp): Likewise.
12632         (parse_exp_1): Update.
12633         (parse_exp_in_context): Add cstate parameter.  Update.
12634         (parse_expression_for_completion): Create an
12635         expr_completion_state.
12636         (null_post_parser): Add "completion" parameter.
12637         * p-exp.y: Update rules.
12638         (yylex): Update.
12639         * language.h (struct language_defn) <la_post_parser>: Add
12640         "completing" parameter.
12641         * go-exp.y: Update rules.
12642         (lex_one_token): Update.
12643         * expression.h (parse_completion): Don't declare.
12644         * d-exp.y: Update rules.
12645         (lex_one_token): Update rules.
12646         * c-exp.y: Update rules.
12647         (lex_one_token): Update.
12648         * ada-lang.c (resolve): Add "parse_completion" parameter.
12649         (resolve_subexp): Likewise.
12650         (ada_resolve_function): Likewise.
12651
12652 2019-04-04  Tom Tromey  <tom@tromey.com>
12653
12654         * parser-defs.h (struct parser_state) <start_arglist,
12655         end_arglist>: New methods.
12656         <arglist_len, m_funcall_chain>: New members.
12657         (arglist_len, start_arglist, end_arglist): Don't declare.
12658         * parse.c (arglist_len, funcall_chain): Remove global.
12659         (start_arglist, end_arglist): Remove functions.
12660         (parse_exp_in_context): Update.
12661         * p-exp.y: Update rules.
12662         * m2-exp.y: Update rules.
12663         * go-exp.y: Update rules.
12664         * f-exp.y: Update rules.
12665         * d-exp.y: Update rules.
12666         * c-exp.y: Update rules.
12667
12668 2019-04-04  Tom Tromey  <tom@tromey.com>
12669
12670         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
12671         lex_operator, push_back>: New methods.
12672         Update all rules.
12673         (rust_parser::lex_hex, lex_escape): Rename and update.
12674         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
12675         (rust_parser::lex_operator): Rename and update.
12676         (rust_parser::lex_number, rustyylex, rustyyerror)
12677         (rust_lex_test_init, rust_lex_test_sequence)
12678         (rust_lex_test_push_back, rust_lex_tests): Update.
12679         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
12680         parameter.
12681         <lexptr, prev_lexptr>: New members.
12682         (lexptr, prev_lexptr): Don't declare.
12683         * parse.c (lexptr, prev_lexptr): Remove globals.
12684         (parse_exp_in_context): Update.
12685         * p-exp.y (yylex, yyerror): Update.
12686         * m2-exp.y (parse_number, yylex, yyerror): Update.
12687         * go-exp.y (lex_one_token, yyerror): Update.
12688         * f-exp.y (match_string_literal, yylex, yyerror): Update.
12689         * d-exp.y (lex_one_token, yyerror): Update.
12690         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
12691         (lex_one_token, yyerror): Update.
12692         * ada-lex.l (YY_INPUT): Update.
12693         (rewind_to_char): Update.
12694         * ada-exp.y (yyerror): Update.
12695
12696 2019-04-04  Tom Tromey  <tom@tromey.com>
12697
12698         * rust-exp.y (rustyylex, rust_lex_tests): Update.
12699         * parser-defs.h (struct parser_state) <parser_state>: Add new
12700         parameter.
12701         <comma_terminates>: New member.
12702         (comma_terminates): Don't declare global.
12703         * parse.c (comma_terminates): Remove global.
12704         (parse_exp_in_context): Update.
12705         * p-exp.y (yylex): Update.
12706         * m2-exp.y (yylex): Update.
12707         * go-exp.y (lex_one_token): Update.
12708         * f-exp.y (yylex): Update.
12709         * d-exp.y (lex_one_token): Update.
12710         * c-exp.y (lex_one_token): Update.
12711         * ada-lex.l: Update.
12712
12713 2019-04-04  Tom Tromey  <tom@tromey.com>
12714
12715         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
12716         (rustyylex, rust_lex_test_init, rust_lex_test_one)
12717         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
12718         * parser-defs.h (paren_depth): Don't declare.
12719         * parse.c (paren_depth): Remove global.
12720         (parse_exp_in_context): Update.
12721         * p-exp.y (paren_depth): New global.
12722         (pascal_parse): Initialize it.
12723         * m2-exp.y (paren_depth): New global.
12724         (m2_parse): Initialize it.
12725         * go-exp.y (paren_depth): New global.
12726         (go_parse): Initialize it.
12727         * f-exp.y (paren_depth): New global.
12728         (f_parse): Initialize it.
12729         * d-exp.y (paren_depth): New global.
12730         (d_parse): Initialize it.
12731         * c-exp.y (paren_depth): New global.
12732         (c_parse): Initialize it.
12733         * ada-lex.l (paren_depth): New global.
12734         (lexer_init): Initialize it.
12735
12736 2019-04-04  Tom Tromey  <tom@tromey.com>
12737
12738         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
12739         (rust_parser::convert_ast_to_type)
12740         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
12741         * parser-defs.h (struct parser_state) <parser_state>: Add
12742         parameters.  Initialize new members.
12743         <expression_context_block, expression_context_pc>: New members.
12744         * parse.c (expression_context_block, expression_context_pc):
12745         Remove globals.
12746         (parse_exp_in_context): Update.
12747         * p-exp.y: Update all rules.
12748         (yylex): Update.
12749         * m2-exp.y: Update all rules.
12750         (yylex): Update.
12751         * go-exp.y (yylex): Update.
12752         * f-exp.y (yylex): Update.
12753         * d-exp.y: Update all rules.
12754         (yylex): Update.
12755         * c-exp.y: Update all rules.
12756         (lex_one_token, classify_name, yylex, c_parse): Update.
12757         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
12758
12759 2019-04-04  Tom Tromey  <tom@tromey.com>
12760
12761         * gdbarch.h, gdbarch.c: Rebuild.
12762         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
12763         * stap-probe.h:
12764         (struct stap_parse_info): Replace "parser_state" with
12765         "expr_builder".
12766         * parser-defs.h (struct expr_builder): Rename from "parser_state".
12767         (parser_state): New class.
12768         * parse.c (expr_builder): Rename.
12769         (expr_builder::release): Rename.
12770         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
12771         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
12772         (write_exp_elt_longcst, write_exp_elt_floatcst)
12773         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
12774         (write_exp_string_vector, write_exp_bitstring)
12775         (write_exp_msymbol, mark_struct_expression)
12776         (write_dollar_variable)
12777         (insert_type_address_space, increase_expout_size): Replace
12778         "parser_state" with "expr_builder".
12779         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
12780         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
12781         "parser_state" with "expr_builder".
12782
12783 2019-04-04  Tom Tromey  <tom@tromey.com>
12784
12785         * rust-exp.y: Replace "parse_language" with method call.
12786         * p-exp.y:
12787         (yylex): Replace "parse_language" with method call.
12788         * m2-exp.y:
12789         (yylex): Replace "parse_language" with method call.
12790         * go-exp.y (classify_name): Replace "parse_language" with method
12791         call.
12792         * f-exp.y (yylex): Replace "parse_language" with method call.
12793         * d-exp.y (lex_one_token): Replace "parse_language" with method
12794         call.
12795         * c-exp.y:
12796         (lex_one_token, classify_name, yylex): Replace "parse_language"
12797         with method call.
12798         * ada-exp.y (find_primitive_type, type_char)
12799         (type_system_address): Replace "parse_language" with method call.
12800
12801 2019-04-04  Tom Tromey  <tom@tromey.com>
12802
12803         * rust-exp.y: Replace "parse_gdbarch" with method call.
12804         * parse.c (write_dollar_variable, insert_type_address_space):
12805         Replace "parse_gdbarch" with method call.
12806         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
12807         call.
12808         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
12809         call.
12810         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
12811         "parse_gdbarch" with method call.
12812         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
12813         with method call.
12814         * f-exp.y (parse_type, parse_f_type, yylex): Replace
12815         "parse_gdbarch" with method call.
12816         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
12817         "parse_gdbarch" with method call.
12818         * c-exp.y (parse_type, parse_number, classify_name): Replace
12819         "parse_gdbarch" with method call.
12820         * ada-lex.l: Replace "parse_gdbarch" with method call.
12821         * ada-exp.y (parse_type, find_primitive_type, type_char)
12822         (type_system_address): Replace "parse_gdbarch" with method call.
12823
12824 2019-04-04  Tom Tromey  <tom@tromey.com>
12825
12826         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
12827         * stap-probe.c (stap_parse_argument): Update.
12828         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
12829         initial_size parameter.
12830         * rust-exp.y (rust_lex_tests): Update.
12831         * parse.c (parser_state): Update.
12832         (parse_exp_in_context): Update.
12833         * parser-defs.h (struct parser_state) <parser_state>: Remove
12834         "initial_size" parameter.
12835
12836 2019-04-04  Tom Tromey  <tom@tromey.com>
12837
12838         * parser-defs.h (increase_expout_size): Don't declare.
12839         * parse.c (increase_expout_size): Now static.
12840
12841 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
12842
12843         * gnu-nat.c (gnu_nat_target::wait): Fix
12844         target_waitstatus_to_string call.
12845
12846 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
12847
12848         * eval.c (evaluate_subexp_standard): Handle internal functions
12849         during Fortran function call handling.
12850
12851 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
12852
12853         * NEWS: Mention new internal functions.
12854         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
12855         (read_base_type): Use dwarf2_init_complex_target_type.
12856         * value.c (creal_internal_fn): New function.
12857         (cimag_internal_fn): New function.
12858         (_initialize_values): Register new internal functions.
12859
12860 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12861
12862         * infrun.c (stop_all_threads): If debug_infrun, always
12863         trace the wait status after wait_one, using
12864         target_waitstatus_to_string and target_pid_to_str.
12865         (handle_inferior_event): Replace various trace of
12866         wait status kind by a single trace.
12867         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
12868         wait status kind image by target_waitstatus_to_string.
12869         * target/waitstatus.c (target_waitstatus_to_string): Fix
12870         obsolete comment.
12871
12872 2019-04-01  Tom Tromey  <tromey@adacore.com>
12873
12874         PR symtab/23331:
12875         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
12876
12877 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
12878             Pedro Alves  <palves@redhat.com>
12879
12880         * top.c (quit_force): Call 'finalize_values'.
12881         * value.c (finalize_values): New function.
12882         * value.h (finalize_values): Declare.
12883
12884 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
12885
12886         * NEWS: Announce $_gdb_major and $_gdb_minor.
12887
12888         * top.c (init_gdb_version_vars): New function.
12889         (gdb_init): Call init_gdb_version_vars.
12890
12891 2019-03-29  Tom Tromey  <tromey@adacore.com>
12892
12893         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
12894         help text.  Remove dead code.
12895
12896 2019-03-29  Keith Seitz  <keiths@redhat.com>
12897
12898         From Siddhesh Poyarekar:
12899         * f-lang.h (f77_get_upperbound): Return LONGEST.
12900         (f77_get_lowerbound): Likewise.
12901         * f-typeprint.c (f_type_print_varspec_suffix): Expand
12902         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
12903         print them.
12904         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
12905         plongest to format print it.
12906         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
12907         (f77_get_upperbound): Likewise.
12908         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
12909         LOWER_BOUND to LONGEST.
12910         (f77_create_arrayprint_offset_tbl): Likewise.
12911
12912 2019-03-29  Keith Seitz  <keiths@redhat.com>
12913
12914         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
12915         %s/pulongest for TYPE_LENGTH instead of %d in format
12916         strings.
12917         * ada-typerint.c (ada_print_type): Likewise.
12918         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
12919         * compile/compile-c-support.c (generate_register_struct): Likewise.
12920         * gdbtypes.c (recursive_dump_type): Likewise.
12921         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
12922         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
12923         instead of %d in format strings.
12924         * riscv-tdep.c (riscv_type_alignment): Cast second argument
12925         to std::min to ULONGEST.
12926         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
12927         instead of %d in format strings.
12928         * tracepoint.c (info_scope_command): Likewise.
12929         * typeprint.c (print_offset_data::update)
12930         (print_offset_data::finish): Likewise.
12931         * xtensa-tdep.c (xtensa_store_return_value)
12932         (xtensa_push_dummy_call): Likewise.
12933
12934 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
12935
12936         * windows-nat.c (display_selector): Fixed format specifications
12937         for 64-bit Cygwin.
12938
12939 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12940
12941         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
12942
12943 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
12944
12945         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
12946         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
12947         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
12948         (nios2_linux_init_abi): Install it.
12949
12950 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
12951
12952         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
12953
12954 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
12955
12956         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
12957
12958 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12959             Tom Tromey  <tromey@adacore.com>
12960
12961         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
12962
12963 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
12964
12965         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
12966         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
12967         method to compute the bounds of range types. Also print "[evaluated]"
12968         if the bounds' values come from a dynamic evaluation.
12969
12970 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
12971
12972         * cp-valprint.c (cp_print_value_fields): Don't print trailing
12973         whitespace when pretty printing is on.
12974
12975 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
12976
12977         * ppc-linux-nat.c: Add include.
12978
12979 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
12980
12981         * NEWS: Mention AArch64 Pointer Authentication.
12982
12983 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
12984
12985         * arm-linux-nat.c: Add include.
12986
12987 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
12988
12989         * source-cache.c (source_cache::get_source_lines): Re-read
12990         fullname after calling open_source_file.
12991
12992 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
12993
12994         * NEWS: Mention TLS support for FreeBSD.
12995
12996 2019-03-25  Tom Tromey  <tromey@adacore.com>
12997
12998         * minsyms.c (BUNCH_SIZE): Update comment.
12999         (~minimal_symbol_reader): Remove old comment.
13000         (compact_minimal_symbols): Update comment.
13001         (minimal_symbol_reader::install): Remove old comment.  Update
13002         other comments.
13003
13004 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
13005
13006         * s390-linux-nat.c: Add include.
13007
13008 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
13009
13010         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
13011         Call linux_get_hwcap.
13012         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
13013         Likewise.
13014         (aarch64_linux_get_hwcap): Remove function.
13015         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
13016         declaration.
13017         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
13018         linux_get_hwcap.
13019         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
13020         * linux-tdep.c (linux_get_hwcap): Add function.
13021         (linux_get_hwcap2): Likewise.
13022         * linux-tdep.h (linux_get_hwcap): Add declaration.
13023         (linux_get_hwcap2): Likewise.
13024         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
13025         (ppc_linux_get_hwcap2): Likewise.
13026         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
13027         linux_get_hwcap.
13028         (ppc_linux_nat_target::insert_watchpoint): Likewise.
13029         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
13030         (ppc_linux_nat_target::read_description): Likewise.
13031         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
13032         * s390-linux-nat.c: Likewise.
13033         * s390-linux-tdep.c (s390_core_read_description): Likewise.
13034
13035 2019-03-24  Tom Tromey  <tom@tromey.com>
13036
13037         * ada-lang.c (standard_lookup): Simplify initialization.
13038         (ada_lookup_symbol_nonlocal): Simplify return.
13039         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
13040         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
13041         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
13042         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
13043         initialization.
13044         * solib.c (solib_global_lookup): Simplify.
13045         * symtab.c (null_block_symbol): Remove.
13046         (symbol_cache_lookup): Simplify returns.
13047         (lookup_language_this): Simplify returns.
13048         (lookup_symbol_aux): Simplify return.
13049         (lookup_local_symbol): Simplify returns.
13050         (lookup_global_symbol_from_objfile): Simplify return.
13051         (lookup_symbol_in_objfile_symtabs)
13052         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
13053         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
13054         (lookup_static_symbol, lookup_global_symbol): Simplify return.
13055         * cp-namespace.c (cp_lookup_bare_symbol)
13056         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
13057         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
13058         (cp_lookup_nested_symbol): Don't use null_block_symbol.
13059         (cp_lookup_symbol_via_imports): Simplify initialization.
13060         (find_symbol_in_baseclass): Likewise.
13061         * symtab.h (null_block_symbol): Remove.
13062         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
13063         (d_lookup_nested_symbol, d_lookup_symbol_imports)
13064         (d_lookup_symbol_module): Likewise.
13065         (find_symbol_in_baseclass): Simplify initialization.
13066
13067 2019-03-24  Tom Tromey  <tom@tromey.com>
13068
13069         * expression.h: Don't include symtab.h.
13070         (struct block): Forward declare.
13071
13072 2019-03-24  Tom Tromey  <tom@tromey.com>
13073
13074         * c-exp.y (typebase): Remove casts.
13075         * gdbtypes.c (lookup_unsigned_typename, )
13076         (lookup_signed_typename): Remove cast.
13077         * eval.c (parse_to_comma_and_eval): Remove cast.
13078         * parse.c (write_dollar_variable): Remove cast.
13079         * block.h (struct block) <superblock>: Now const.
13080         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
13081         * psymtab.c (psym_map_matching_symbols): Make "block" const.
13082         (map_block): Make "block" const.
13083         * symfile.h (struct quick_symbol_functions)
13084         <map_matching_symbols>: Constify block argument to "callback".
13085         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
13086         const.
13087         (find_pc_sect_compunit_symtab): Make "b" const.
13088         (find_symbol_at_address): Likewise.
13089         (search_symbols): Likewise.
13090         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
13091         (dw2_debug_names_lookup_symbol): Likewise.
13092         (dw2_map_matching_symbols): Update.
13093         * p-valprint.c (pascal_val_print): Remove "block".
13094         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
13095         (aux_add_nonlocal_symbols): Make "block" const.
13096         (resolve_subexp): Remove cast.
13097         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
13098         const.
13099         (iterate_over_file_blocks): Likewise.
13100         * f-exp.y (%union) <bval>: Remove.
13101         * coffread.c (patch_opaque_types): Make "b" const.
13102         * spu-tdep.c (spu_catch_start): Make "block" const.
13103         * c-valprint.c (print_unpacked_pointer): Remove "block".
13104         * symmisc.c (dump_symtab_1): Make "b" const.
13105         (block_depth): Make "block" const.
13106         * d-exp.y (%union) <bval>: Remove.
13107         * cp-support.h (cp_lookup_rtti_type): Update.
13108         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
13109         * psymtab.c (psym_lookup_symbol): Make "block" const.
13110         (maintenance_check_psymtabs): Make "b" const.
13111         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
13112         (enumerate_locals, enumerate_args): Update.
13113         * python/py-symtab.c (stpy_global_block): Make "block" const.
13114         (stpy_static_block): Likewise.
13115         * inline-frame.c (block_starting_point_at): Make "new_block"
13116         const.
13117         * block.c (find_block_in_blockvector): Make return type const.
13118         (blockvector_for_pc_sect): Make "b" const.
13119         (find_block_in_blockvector): Make "b" const.
13120
13121 2019-03-23  Tom Tromey  <tom@tromey.com>
13122
13123         * varobj.c (varobj_create): Update.
13124         * symfile.c (clear_symtab_users): Don't reset innermost_block.
13125         * printcmd.c (display_command, do_one_display): Don't reset
13126         innermost_block.
13127         * parser-defs.h (enum innermost_block_tracker_type): Move to
13128         expression.h.
13129         (innermost_block): Update comment.
13130         * parse.c (parse_exp_1): Add tracker_types parameter.
13131         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
13132         tracker_types parameter.  Reset innermost_block.
13133         (parse_exp_in_context): Remove.
13134         (parse_expression_for_completion): Update.
13135         * objfiles.c (~objfile): Don't reset expression_context_block or
13136         innermost_block.
13137         * expression.h (enum innermost_block_tracker_type): Move from
13138         parser-defs.h.
13139         (parse_exp_1): Add tracker_types parameter.
13140         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
13141         reset innermost_block.
13142
13143 2019-03-23  Tom Tromey  <tom@tromey.com>
13144
13145         * objfiles.h: Include bcache.h.
13146
13147 2019-03-23  Tom Tromey  <tom@tromey.com>
13148
13149         * linespec.c (get_current_search_block): Use
13150         scoped_restore_current_language.
13151         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
13152
13153 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
13154             Jiong Wang  <jiong.wang@arm.com>
13155
13156         * aarch64-linux-tdep.c
13157         (aarch64_linux_iterate_over_regset_sections): Check for pauth
13158         section.
13159         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
13160
13161 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
13162             Jiong Wang  <jiong.wang@arm.com>
13163
13164         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
13165         instructions.
13166         (aarch64_analyze_prologue_test): Add PACIASP test.
13167         (aarch64_prologue_prev_register): Unmask PC value.
13168
13169 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
13170             Jiong Wang  <jiong.wang@arm.com>
13171
13172         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
13173         (aarch64_dwarf2_prev_register): Unmask PC value.
13174         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
13175         (aarch64_execute_dwarf_cfa_vendor_op): Check for
13176         DW_CFA_AARCH64_negate_ra_state.
13177         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
13178
13179 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
13180             Jiong Wang  <jiong.wang@arm.com>
13181
13182         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
13183         registers.
13184         (aarch64_pseudo_register_name): Likewise.
13185         (aarch64_pseudo_register_type): Likewise.
13186         (aarch64_pseudo_register_reggroup_p): Likewise.
13187         (aarch64_gdbarch_init): Add pauth registers.
13188         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
13189         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
13190         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
13191         (struct gdbarch_tdep): Add regnum for ra_state.
13192
13193 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
13194             Jiong Wang  <jiong.wang@arm.com>
13195
13196         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
13197
13198 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
13199             Jiong Wang  <jiong.wang@arm.com>
13200
13201         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
13202         function.
13203         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
13204         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
13205         (aarch64_gdbarch_init): Add puth registers.
13206         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
13207         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
13208         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
13209
13210 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
13211             Jiong Wang  <jiong.wang@arm.com>
13212
13213         * aarch64-linux-nat.c
13214         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
13215         * aarch64-linux-tdep.c
13216         (aarch64_linux_core_read_description): Likewise.
13217         (aarch64_linux_get_hwcap): New function.
13218         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
13219         (aarch64_linux_get_hwcap): New declaration.
13220
13221 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
13222             Jiong Wang  <jiong.wang@arm.com>
13223
13224         * aarch64-linux-nat.c
13225         (aarch64_linux_nat_target::read_description): Add pauth param.
13226         * aarch64-linux-tdep.c
13227         (aarch64_linux_core_read_description): Likewise.
13228         * aarch64-tdep.c (struct target_desc): Add in pauth.
13229         (aarch64_read_description): Add pauth param.
13230         (aarch64_gdbarch_init): Likewise.
13231         * aarch64-tdep.h (aarch64_read_description): Likewise.
13232         * arch/aarch64.c (aarch64_create_target_description): Likewise.
13233         * arch/aarch64.h (aarch64_create_target_description): Likewise.
13234         * features/Makefile: Add new files.
13235         * features/aarch64-pauth.c: New file.
13236         * features/aarch64-pauth.xml: New file.
13237
13238 2019-03-20  Tom Tromey  <tromey@adacore.com>
13239
13240         * infrun.c (handle_inferior_event): Rename from
13241         handle_inferior_event_1.  Create a scoped_value_mark.
13242         (handle_inferior_event): Remove.
13243
13244 2019-03-19  Tom Tromey  <tromey@adacore.com>
13245
13246         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
13247         * infrun.h (print_stop_event): Add "displays" parameter.
13248         * infrun.c (print_stop_event): Add "displays" parameter.
13249
13250 2019-03-19  Pedro Alves  <palves@redhat.com>
13251
13252         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
13253         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
13254         to -1.  Fix TABs vs spaces.
13255         (tui_ui_out::tui_ui_out): Don't initialize fields here.
13256         * tui/tui-out.h (tui_ui_out) Add intro comments.
13257         <m_line, m_start_of_line>: In-class initialize, and add describing
13258         comment.
13259
13260 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
13261
13262         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
13263         variable names.
13264         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
13265
13266 2019-03-18  Pedro Alves  <palves@redhat.com>
13267             Eli Zaretskii <eliz@gnu.org>
13268
13269         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
13270         m_line and m_start_of_line.
13271
13272 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
13273
13274         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
13275         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
13276         it returns a newline.  This fixes a regression in TU mode, whereby
13277         the next line is output on the same screen line as the user input.
13278
13279 2019-03-18  Tom Tromey  <tromey@adacore.com>
13280
13281         * minsyms.c (minimal_symbol_reader::install): Remove call to
13282         obstack_blank.
13283
13284 2019-03-18  Pedro Alves  <palves@redhat.com>
13285
13286         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
13287         New globals.
13288         (apply_style): New, factored out from ...
13289         (apply_ansi_escape): ... this.  Handle reverse video mode.
13290         (tui_set_reverse_mode): New function.
13291         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
13292         * tui/tui-winsource.c (tui_show_source_line): Use
13293         tui_set_reverse_mode instead of setting A_STANDOUT.
13294         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
13295         New setter methods.
13296
13297 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
13298
13299         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
13300         Handle tabs.
13301
13302 2019-03-18  Tom Tromey  <tromey@adacore.com>
13303
13304         * ada-lang.c (empty_array): Add "high" parameter.
13305         (ada_evaluate_subexp): Update.
13306
13307 2019-03-17  Sergei Trofimovich <siarheit@google.com>
13308
13309         * unittests/string_view-selftests.c: Define
13310         _initialize_string_view_selftests unconditionally.
13311
13312 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
13313
13314         PR gdb/24350
13315         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
13316
13317 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
13318
13319         PR gdb/24351
13320         * windows-nat.c (display_selector): Fix format specifiers.
13321
13322 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
13323
13324         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
13325         tui_refill_source_window instead of tui_refresh_win, to update the
13326         current execution line.  This fixes redisplay of the current line
13327         when stepping through the code with "next" or "step".
13328
13329 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
13330
13331         * source-cache.c (source_cache::get_source_lines): Call
13332         find_source_lines to initialize s->nlines.  This fixes vertical
13333         scrolling of TUI source window when the DOWN arrow is pressed.
13334
13335 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
13336
13337         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
13338         linux-thread-db.c (_initialize_thread_db): Likewise.
13339
13340 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
13341
13342         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
13343         wclrtoeol in tui_show_source_line".  This reverts changes made in
13344         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
13345
13346 2019-03-15  Tom Tromey  <tom@tromey.com>
13347
13348         * symtab.h (struct minimal_symbol): Derive from
13349         general_symbol_info.
13350         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
13351         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
13352         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
13353         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
13354         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
13355         (MSYMBOL_SEARCH_NAME): Update.
13356         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
13357         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
13358         * minsyms.c (minimal_symbol_reader::record_full): Update.
13359
13360 2019-03-15  Tom Tromey  <tom@tromey.com>
13361
13362         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
13363
13364 2019-03-15  Tom Tromey  <tom@tromey.com>
13365
13366         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
13367         unique_xmalloc_ptr.
13368         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
13369         Update.
13370         * minsyms.c (lookup_minimal_symbol_by_pc_section)
13371         (build_minimal_symbol_hash_tables)
13372         (minimal_symbol_reader::install): Update.
13373
13374 2019-03-15  Tom Tromey  <tom@tromey.com>
13375
13376         * symtab.c (create_demangled_names_hash): Update.
13377         (symbol_set_names): Update.
13378         * objfiles.h (struct objfile_per_bfd_storage)
13379         <demangled_names_hash>: Now an htab_up.
13380         * objfiles.c (objfile_per_bfd_storage): Simplify.
13381
13382 2019-03-15  Tom Tromey  <tom@tromey.com>
13383
13384         * objfiles.h (struct objfile_per_bfd_storage): Declare
13385         destructor.
13386         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
13387         New.
13388         (get_objfile_bfd_data): Use new.  Don't initialize
13389         language_of_main.
13390         (free_objfile_per_bfd_storage): Remove.
13391         (objfile_bfd_data_free, objfile::~objfile): Use delete.
13392
13393 2019-03-15  Tom Tromey  <tom@tromey.com>
13394
13395         * symfile.c (reread_symbols): Update.
13396         * objfiles.c (objfile::objfile): Update.
13397         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
13398         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
13399         comment.
13400         (minimal_symbol_reader::install): Update.
13401         (terminate_minimal_symbol_table): Remove.
13402         * jit.c (jit_object_close_impl): Update.
13403
13404 2019-03-15  Tom Tromey  <tom@tromey.com>
13405
13406         * minsyms.c (minimal_symbol_reader::record_full): Remove some
13407         initializations.
13408
13409 2019-03-15  Tom Tromey  <tom@tromey.com>
13410
13411         * objfiles.h (struct objfile_per_bfd_storage)
13412         <demangled_hash_languages>: Now a bitset.
13413         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
13414         (lookup_minimal_symbol): Update.
13415
13416 2019-03-15  Tom Tromey  <tom@tromey.com>
13417
13418         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
13419         Don't return the symbol.
13420         * coffread.c (record_minimal_symbol): Use record_full.
13421
13422 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
13423
13424         The MS-Windows port of ncurses fails to switch to a color pair if
13425         one or both of the colors are the implicit default colors.  This
13426         change records the default colors when TUI is initialized, and
13427         then specifies them explicitly when a color pair uses the default
13428         colors.  This allows color styling in TUI mode on MS-Windows.
13429
13430         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
13431         ncurses_norm_attr.
13432         (tui_initialize_io) [__MINGW32__]: Record the default terminal
13433         colors in ncurses_norm_attr.
13434         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
13435         "none", replace it with the default color recorded in
13436         ncurses_norm_attr.
13437
13438 2019-03-14  Tom Tromey  <tromey@adacore.com>
13439
13440         * source-cache.h (class source_cache) <get_source_lines>: Return
13441         std::string.
13442         * source-cache.c (source_cache::extract_lines): Handle case where
13443         first_pos==npos.  Return std::string.
13444         (source_cache::get_source_lines): Update.
13445
13446 2019-03-14  Tom Tromey  <tromey@adacore.com>
13447
13448         * NEWS: Add item for "style sources" commands.
13449         * source-cache.c (source_cache::get_source_lines): Check
13450         source_styling.
13451         * cli/cli-style.c (source_styling): New global.
13452         (_initialize_cli_style): Add "style sources" commands.
13453         (show_style_sources): New function.
13454         * cli/cli-style.h (source_styling): Declare.
13455
13456 2019-03-14  Pedro Alves  <palves@redhat.com>
13457             Tom Tromey  <tromey@adacore.com>
13458
13459         * tui/tui-winsource.h (tui_refill_source_window): Declare.
13460         * tui/tui-winsource.c (tui_refill_source_window): New function,
13461         from...
13462         (tui_horizontal_source_scroll): ... here.  Move some logic.
13463         * cli/cli-style.c (set_style_enabled): Notify new observable.
13464         * tui/tui-hooks.c (tui_redisplay_source): New function.
13465         (tui_attach_detach_observers): Attach or detach
13466         tui_redisplay_source.
13467         * observable.h (source_styling_changed): New observable.
13468         * observable.c: Define source_styling_changed observable.
13469
13470 2019-03-13  Tom Tromey  <tromey@adacore.com>
13471
13472         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
13473         (i386_gnu_nat_target::store_registers): Update.
13474         * target-debug.h (target_debug_print_std_string): New macro.
13475         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
13476         * windows-tdep.c (display_one_tib): Update.
13477         * tui/tui-stack.c (tui_make_status_line): Update.
13478         * top.c (print_inferior_quit_action): Update.
13479         * thread.c (thr_try_catch_cmd): Update.
13480         (add_thread_with_info): Update.
13481         (thread_target_id_str): Update.
13482         (thr_try_catch_cmd): Update.
13483         (thread_command): Update.
13484         (thread_find_command): Update.
13485         * record-btrace.c (record_btrace_target::info_record)
13486         (record_btrace_resume_thread, record_btrace_target::resume)
13487         (record_btrace_cancel_resume, record_btrace_step_thread)
13488         (record_btrace_target::wait, record_btrace_target::wait)
13489         (record_btrace_target::wait, record_btrace_target::stop): Update.
13490         * progspace.c (print_program_space): Update.
13491         * process-stratum-target.c
13492         (process_stratum_target::thread_address_space): Update.
13493         * linux-fork.c (linux_fork_mourn_inferior)
13494         (detach_checkpoint_command, info_checkpoints_command)
13495         (linux_fork_context): Update.
13496         (linux_fork_detach): Update.
13497         (class scoped_switch_fork_info): Update.
13498         (delete_checkpoint_command): Update.
13499         * infrun.c (follow_fork_inferior): Update.
13500         (follow_fork_inferior): Update.
13501         (proceed_after_vfork_done): Update.
13502         (handle_vfork_child_exec_or_exit): Update.
13503         (follow_exec): Update.
13504         (displaced_step_prepare_throw): Update.
13505         (displaced_step_restore): Update.
13506         (start_step_over): Update.
13507         (resume_1): Update.
13508         (clear_proceed_status_thread): Update.
13509         (proceed): Update.
13510         (print_target_wait_results): Update.
13511         (do_target_wait): Update.
13512         (context_switch): Update.
13513         (stop_all_threads): Update.
13514         (restart_threads): Update.
13515         (finish_step_over): Update.
13516         (handle_signal_stop): Update.
13517         (switch_back_to_stepped_thread): Update.
13518         (keep_going_pass_signal): Update.
13519         (print_exited_reason): Update.
13520         (normal_stop): Update.
13521         * inferior.c (inferior_pid_to_str): Change return type.
13522         (print_selected_inferior): Update.
13523         (add_inferior): Update.
13524         (detach_inferior): Update.
13525         * dummy-frame.c (fprint_dummy_frames): Update.
13526         * dcache.c (dcache_info_1): Update.
13527         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
13528         (btrace_fetch, btrace_clear): Update.
13529         * linux-tdep.c (linux_core_pid_to_str): Change return type.
13530         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
13531         type.
13532         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
13533         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
13534         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
13535         * gdbarch.c, gdbarch.h: Rebuild.
13536         * gdbarch.sh (core_pid_to_str): Change return type.
13537         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
13538         return type.
13539         (windows_nat_target::pid_to_str): Change return type.
13540         (windows_delete_thread): Update.
13541         (windows_nat_target::attach): Update.
13542         (windows_nat_target::files_info): Update.
13543         * target-delegates.c: Rebuild.
13544         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
13545         return type.
13546         (sol_thread_target::pid_to_str): Change return type.
13547         * remote.c (class remote_target) <pid_to_str>: Change return
13548         type.
13549         (remote_target::pid_to_str): Change return type.
13550         (extended_remote_target::attach, remote_target::remote_stop_ns)
13551         (remote_target::remote_notif_remove_queued_reply)
13552         (remote_target::push_stop_reply, remote_target::disable_btrace):
13553         Update.
13554         (extended_remote_target::attach): Update.
13555         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
13556         type.
13557         (gdbsim_target::pid_to_str): Change return type.
13558         * ravenscar-thread.c (struct ravenscar_thread_target)
13559         <pid_to_str>: Change return type.
13560         (ravenscar_thread_target::pid_to_str): Change return type.
13561         * procfs.c (class procfs_target) <pid_to_str>: Change return
13562         type.
13563         (procfs_target::pid_to_str): Change return type.
13564         (procfs_target::attach): Update.
13565         (procfs_target::detach): Update.
13566         (procfs_target::fetch_registers): Update.
13567         (procfs_target::store_registers): Update.
13568         (procfs_target::wait): Update.
13569         (procfs_target::files_info): Update.
13570         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
13571         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
13572         return type.
13573         (nto_procfs_target::pid_to_str): Change return type.
13574         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
13575         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
13576         return type.
13577         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
13578         (exit_lwp): Update.
13579         (attach_proc_task_lwp_callback, get_detach_signal)
13580         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
13581         (linux_nat_target::resume, wait_lwp, stop_callback)
13582         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
13583         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
13584         (linux_nat_wait_1, resume_stopped_resumed_lwps)
13585         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
13586         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
13587         type.
13588         (inf_ptrace_target::attach): Update.
13589         (inf_ptrace_target::files_info): Update.
13590         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
13591         type.
13592         (go32_nat_target::pid_to_str): Change return type.
13593         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
13594         (gnu_nat_target::wait): Update.
13595         (gnu_nat_target::wait): Update.
13596         (gnu_nat_target::resume): Update.
13597         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
13598         (fbsd_nat_target::wait): Update.
13599         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
13600         type.
13601         (darwin_nat_target::attach): Update.
13602         * corelow.c (class core_target) <pid_to_str>: Change return type.
13603         (core_target::pid_to_str): Change return type.
13604         * target.c (normal_pid_to_str): Change return type.
13605         (default_pid_to_str): Likewise.
13606         (target_pid_to_str): Change return type.
13607         (target_translate_tls_address): Update.
13608         (target_announce_detach): Update.
13609         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
13610         return type.
13611         (bsd_uthread_target::pid_to_str): Change return type.
13612         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
13613         type.
13614         (bsd_kvm_target::pid_to_str): Change return type.
13615         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
13616         return type.
13617         (aix_thread_target::pid_to_str): Change return type.
13618         * target.h (struct target_ops) <pid_to_str>: Change return type.
13619         (target_pid_to_str, normal_pid_to_str): Likewise.
13620         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
13621         type.
13622         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
13623         type.
13624         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
13625         return type.
13626         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
13627         type.
13628         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
13629         type.
13630         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
13631         return type.
13632
13633 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
13634
13635         * NEWS: Mention that the new default MI version is 3.  Mention
13636         changes to the output of commands and events that deal with
13637         multi-location breakpoints.
13638         * breakpoint.c: Include "mi/mi-out.h".
13639         (print_one_breakpoint): Change output syntax if using MI version
13640         >= 3.
13641         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
13642         New.
13643         (mi_multi_location_breakpoint_output_fixed): New.
13644         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
13645         (mi_cmd_fix_multi_location_breakpoint_output): New.
13646         (mi_multi_location_breakpoint_output_fixed): New.
13647         * mi/mi-cmds.c (mi_cmds): Register command
13648         -fix-multi-location-breakpoint-output.
13649         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
13650         interpreter "mi".
13651
13652 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
13653
13654         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
13655         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
13656         instantiate mi_ui_out based on interpreter name.
13657         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
13658         * mi/mi-main.c (mi_load_progress): Likewise.
13659
13660 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
13661
13662         * NEWS: Combine separate "New targets" sections for 8.3.
13663
13664 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
13665
13666         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
13667         (ppcfbsd_init_abi): Install gdbarch
13668         "fetch_tls_load_module_address" and "get_thread_local_address"
13669         methods.
13670
13671 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
13672
13673         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
13674         (riscv_fbsd_init_abi): Install gdbarch
13675         "fetch_tls_load_module_address" and "get_thread_local_address"
13676         methods.
13677
13678 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
13679
13680         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
13681         (i386fbsd_init_abi): Install gdbarch
13682         "fetch_tls_load_module_address" and "get_thread_local_address"
13683         methods.
13684
13685 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
13686
13687         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
13688         (amd64fbsd_init_abi): Install gdbarch
13689         "fetch_tls_load_module_address" and "get_thread_local_address"
13690         methods.
13691
13692 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
13693
13694         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
13695         (struct fbsd_pspace_data): New type.
13696         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
13697         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
13698         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
13699         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
13700         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
13701
13702 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
13703
13704         * gdbtypes.c (lookup_struct_elt): New function.
13705         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
13706         * gdbtypes.h (struct struct_elt): New type.
13707         (lookup_struct_elt): New prototype.
13708
13709 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
13710
13711         * gdbtypes.c (lookup_struct_elt_type): Update comment and
13712         remove disabled code block.
13713
13714 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
13715
13716         * gdbarch.sh (get_thread_local_address): New method.
13717         * gdbarch.h, gdbarch.c: Regenerate.
13718         * target.c (target_translate_tls_address): Use
13719         gdbarch_get_thread_local_address if present instead of
13720         target::get_thread_local_address.
13721
13722 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
13723
13724         * target.h (target::get_thread_local_address): Update comment.
13725
13726 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
13727
13728         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
13729         objfile->separate_debug_objfile_backlink if not NULL.
13730
13731 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
13732
13733         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
13734         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
13735         (amd64bsd_store_inferior_registers): Likewise.
13736         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
13737         Enable segment base registers.
13738         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
13739         PT_GETFSBASE and PT_GETGSBASE.
13740         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
13741         PT_SETGSBASE.
13742         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
13743         segment base registers.
13744         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
13745
13746 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
13747
13748         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
13749         Update calls to i386_target_description to add 'segments'
13750         parameter.
13751         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
13752         add segment base registers.
13753         * arch/i386.c (i386_create_target_description): Add 'segments'
13754         parameter to enable segment base registers.
13755         * arch/i386.h (i386_create_target_description): Likewise.
13756         * features/i386/32bit-segments.xml: New file.
13757         * features/i386/32bit-segments.c: Generate.
13758         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
13759         call to i386_target_description to add 'segments' parameter.
13760         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
13761         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
13762         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
13763         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
13764         if feature is present.
13765         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
13766         Add 'segments' parameter to call to i386_target_description.
13767         (i386_target_description): Add 'segments' parameter to enable
13768         segment base registers.
13769         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
13770         to call to i386_target_description.
13771         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
13772         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
13773         Define I386_NUM_REGS.
13774         (i386_target_description): Add 'segments' parameter to enable
13775         segment base registers.
13776
13777 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
13778
13779         PR/24325
13780         * source-cache.c: #undef open and close, to avoid unresolved
13781         externals during linking.
13782
13783 2019-03-12  Tom Tromey  <tromey@adacore.com>
13784
13785         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
13786         const.  Add initializers.
13787         (_initialize_remote): Don't initialize ptid globals.
13788
13789 2019-03-12  Pedro Alves  <palves@redhat.com>
13790
13791         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
13792
13793 2019-03-12  Pedro Alves  <palves@redhat.com>
13794
13795         * cp-name-parser.y (main): Remove unused 'len' variable.
13796
13797 2019-03-12  Tom Tromey  <tromey@adacore.com>
13798
13799         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
13800         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
13801
13802 2019-03-12  Tom Tromey  <tromey@adacore.com>
13803
13804         * linux-nat.c (iterate_over_lwps): Update.
13805         (stop_callback): Remove parameter.
13806         (stop_wait_callback, detach_callback, resume_set_callback)
13807         (select_singlestep_lwp_callback, set_ignore_sigint)
13808         (status_callback, resumed_callback, resume_clear_callback)
13809         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
13810         data parameter.
13811         (linux_nat_target::detach, linux_nat_target::resume)
13812         (linux_stop_and_wait_all_lwps, select_event_lwp)
13813         (linux_nat_filter_event, linux_nat_wait_1)
13814         (linux_nat_target::kill, linux_nat_target::stop)
13815         (linux_nat_target::stop): Update.
13816         (linux_nat_resume_callback): Change type.
13817         (resume_stopped_resumed_lwps, count_events_callback)
13818         (select_event_lwp_callback): Likewise.
13819         (linux_stop_lwp, linux_nat_stop_lwp): Update.
13820         * arm-linux-nat.c (struct update_registers_data): Remove.
13821         (update_registers_callback): Change type.
13822         (arm_linux_insert_hw_breakpoint1): Update.
13823         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
13824         parameter.
13825         (x86_linux_dr_set_addr): Update.
13826         (x86_linux_dr_set_control): Update.
13827         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
13828         (iterate_over_lwps): Use gdb::function_view.
13829         * nat/aarch64-linux-hw-point.c (struct
13830         aarch64_dr_update_callback_param): Remove.
13831         (debug_reg_change_callback): Change type.
13832         (aarch64_notify_debug_reg_change): Update.
13833         * s390-linux-nat.c (s390_refresh_per_info): Update.
13834
13835 2019-03-11  Tom Tromey  <tromey@adacore.com>
13836
13837         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
13838         redundant assignment to "this_cu".
13839
13840 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
13841
13842         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
13843
13844 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
13845
13846         * gdbtypes.c (rank_one_type_parm_set): New function extracted
13847         from...
13848         (rank_one_type): ... this.
13849
13850 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
13851
13852         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
13853         from...
13854         (rank_one_type): ... this.
13855
13856 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
13857
13858         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
13859         from...
13860         (rank_one_type): ... this.
13861
13862 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
13863
13864         * gdbtypes.c (rank_one_type_parm_float): New function extracted
13865         from...
13866         (rank_one_type): ... this.
13867
13868 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
13869
13870         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
13871         from...
13872         (rank_one_type): ... this.
13873
13874 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
13875
13876         * gdbtypes.c (rank_one_type_parm_range): New function extracted
13877         from...
13878         (rank_one_type): ... this.
13879
13880 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
13881
13882         * gdbtypes.c (rank_one_type_parm_char): New function extracted
13883         from...
13884         (rank_one_type): ... this.
13885
13886 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
13887
13888         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
13889         from...
13890         (rank_one_type): ... this.
13891
13892 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
13893
13894         * gdbtypes.c (rank_one_type_parm_int): New function extracted
13895         from...
13896         (rank_one_type): ... this.
13897
13898 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
13899
13900         * gdbtypes.c (rank_one_type_parm_func): New function extracted
13901         from...
13902         (rank_one_type): ... this.
13903
13904 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
13905
13906         * gdbtypes.c (rank_one_type_parm_array): New function extracted
13907         from...
13908         (rank_one_type): ... this.
13909
13910 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
13911
13912         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
13913         from...
13914         (rank_one_type): ... this.
13915
13916 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
13917
13918         * inferior.c (initialize_inferiors): Ensure 'help set/show print
13919         inferior-events' shows the example events.
13920
13921 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
13922
13923         Support styling on native MS-Windows console
13924
13925         PR/24315
13926         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
13927         on MS-Windows if $TERM is not defined.
13928
13929         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
13930
13931         * posix-hdep.c (gdb_console_fputs):
13932         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
13933         functions.
13934         * ui-file.h (gdb_console_fputs): Add prototype.
13935
13936         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
13937         back to fputs only if the former returns zero.
13938
13939 2019-03-07  Tom Tromey  <tom@tromey.com>
13940
13941         * symmisc.c (print_symbol_bcache_statistics): Update.
13942         (print_objfile_statistics): Update.
13943         * symfile.c (allocate_symtab): Update.
13944         * stabsread.c: Don't include bcache.h.
13945         * psymtab.h (struct psymbol_bcache): Don't declare.
13946         (class psymtab_storage) <psymbol_cache>: Now a bcache.
13947         (psymbol_bcache_init, psymbol_bcache_free)
13948         (psymbol_bcache_get_bcache): Don't declare.
13949         * psymtab.c (struct psymbol_bcache): Remove.
13950         (psymtab_storage::psymtab_storage): Update.
13951         (psymtab_storage::~psymtab_storage): Update.
13952         (psymbol_bcache_init, psymbol_bcache_free)
13953         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
13954         (add_psymbol_to_bcache): Update.
13955         (allocate_psymtab): Update.
13956         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
13957         macro_cache>: No longer pointers.
13958         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
13959         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
13960         * macrotab.c (macro_bcache): Update.
13961         * macroexp.c: Don't include bcache.h.
13962         * gdbtypes.c (check_types_worklist): Update.
13963         (types_deeply_equal): Remove TRY/CATCH.  Update.
13964         * elfread.c (elf_symtab_read): Update.
13965         * dwarf2read.c: Don't include bcache.h.
13966         * buildsym.c (buildsym_compunit::get_macro_table): Update.
13967         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
13968         (print_bcache_statistics, bcache_memory_used): Don't declare.
13969         (struct bcache): Move from bcache.c.  Add constructor, destructor,
13970         methods.  Rename all data members.
13971         * bcache.c (struct bcache): Move to bcache.h.
13972         (bcache::expand_hash_table): Rename from expand_hash_table.
13973         (bcache): Remove.
13974         (bcache::insert): Rename from bcache_full.
13975         (bcache::compare): Rename from bcache_compare.
13976         (bcache_xmalloc): Remove.
13977         (bcache::~bcache): Rename from bcache_xfree.
13978         (bcache::print_statistics): Rename from print_bcache_statistics.
13979         (bcache::memory_used): Rename from bcache_memory_used.
13980
13981 2019-03-07  Pedro Alves  <palves@redhat.com>
13982
13983         * infrun.c (normal_stop): Also check for
13984         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
13985
13986 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
13987
13988         * f-lang.c (value_from_host_double): Moved to...
13989         * value.c (value_from_host_double): ...here.
13990         * value.h (value_from_host_double): Declare.
13991         * guile/scm-math.c (vlscm_convert_typed_number): Use
13992         value_from_host_double.
13993         (vlscm_convert_number): Likewise.
13994         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
13995         * python/py-value.c (convert_value_from_python): Likewise.
13996
13997 2019-03-06  Tom Tromey  <tom@tromey.com>
13998
13999         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
14000
14001 2019-03-06  Tom Tromey  <tom@tromey.com>
14002
14003         * utils.h (free_current_contents): Don't declare.
14004         * utils.c (free_current_contents): Remove.
14005
14006 2019-03-06  Tom Tromey  <tom@tromey.com>
14007
14008         * top.c (quit_force): Update.
14009         * main.c (captured_command_loop): Update.
14010         * common/new-op.c (operator new): Update.
14011         * common/common-exceptions.c (struct catcher)
14012         <save_cleanup_chain>: Remove member.
14013         (exceptions_state_mc_init): Update.
14014         (exception_try_scope_entry): Return nullptr.
14015         (exception_try_scope_exit, exception_rethrow)
14016         (throw_exception_sjlj, throw_exception_cxx): Update.
14017         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
14018         (all_cleanups, do_cleanups, discard_cleanups)
14019         (discard_final_cleanups, save_cleanups, save_final_cleanups)
14020         (restore_cleanups, restore_final_cleanups): Don't declare.
14021         (do_final_cleanups): Remove parameter.
14022         * common/cleanups.c (cleanup_chain, make_cleanup)
14023         (make_cleanup_dtor, all_cleanups, do_cleanups)
14024         (discard_my_cleanups, discard_cleanups)
14025         (discard_final_cleanups, save_my_cleanups, save_cleanups)
14026         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
14027         (null_cleanup): Remove.
14028         (do_final_cleanups): Remove parameter.
14029
14030 2019-03-06  Tom Tromey  <tom@tromey.com>
14031
14032         * remote.c (remote_target::remote_parse_stop_reply): Use
14033         unique_xmalloc_ptr.
14034
14035 2019-03-06  Tom Tromey  <tom@tromey.com>
14036
14037         * stabsread.c (struct stabs_field_info): Rename from field_info.
14038         <list, fnlist>: Add initializers.
14039         <obstack>: New member.
14040         (read_member_functions, read_struct_fields, read_baseclasses):
14041         Allocate on obstack.  Don't use cleanups.
14042         (read_one_struct_field, read_member_functions, read_struct_fields)
14043         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
14044         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
14045         (read_struct_type): Update.
14046
14047 2019-03-06  Tom Tromey  <tom@tromey.com>
14048
14049         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
14050         * common/filestuff.h (make_cleanup_close): Don't declare.
14051         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
14052         Remove.
14053
14054 2019-03-06  Tom Tromey  <tom@tromey.com>
14055
14056         * solib-aix.c: Use make_scope_exit.
14057
14058 2019-03-06  Tom Tromey  <tom@tromey.com>
14059
14060         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
14061         Use make_scope_exit.
14062
14063 2019-03-06  Tom Tromey  <tom@tromey.com>
14064
14065         * solib-svr4.c (disable_probes_interface): Remove parameter.
14066         (svr4_handle_solib_event): Use make_scope_exit.
14067
14068 2019-03-06  Tom Tromey  <tom@tromey.com>
14069
14070         * remote.c (struct stop_reply_deleter): Remove.
14071         (stop_reply_up): Update.
14072         (struct stop_reply): Derive from notif_event.  Don't typedef.
14073         <regcache>: Now a std::vector.
14074         (stop_reply_xfree): Remove.
14075         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
14076         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
14077         (remote_target::discard_pending_stop_replies): Use delete.
14078         (remote_target::remote_parse_stop_reply): Update.
14079         (remote_target::process_stop_reply): Update.
14080         * remote-notif.h (struct notif_event): Add virtual destructor.
14081         Remove "dtr" member.
14082         (struct notif_client) <alloc_event>: Return a unique_ptr.
14083         (notif_event_xfree): Don't declare.
14084         (notif_event_up): New typedef.
14085         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
14086         (notif_event_xfree, do_notif_event_xfree): Remove.
14087         (remote_notif_state_xfree): Update.
14088
14089 2019-03-06  Tom Tromey  <tom@tromey.com>
14090
14091         * infrun.c (displaced_step_clear_cleanup): Now a
14092         forward_scope_exit type.
14093         (displaced_step_prepare_throw): Update.
14094         (displaced_step_fixup): Update.
14095
14096 2019-03-06  Tom Tromey  <tom@tromey.com>
14097
14098         * inferior.h (class inferior): Update comment.
14099         * gdbthread.h (class thread_info): Update comment.
14100
14101 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
14102             Tom Tromey  <tom@tromey.com>
14103
14104         * stabsread.h (struct stab_section_list): Remove.
14105         (coffstab_build_psymtabs): Update.
14106         * dbxread.c (symbuf_sections): Now a std::vector.
14107         (sect_idx): New global.
14108         (fill_symbuf): Update.
14109         (coffstab_build_psymtabs): Change type of stabsects parameter.
14110         Update.
14111         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
14112         std::vector.
14113         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
14114         (coff_locate_sections): Update.
14115         (coff_symfile_read): Remove cleanups.  Update.
14116         (init_stringtab): Add storage parameter.
14117         (free_stringtab, free_stringtab_cleanup): Remove.
14118         (init_lineno): Add storage parameter.
14119         (free_linetab, free_linetab_cleanup): Remove.
14120
14121 2019-03-06  Pedro Alves  <palves@redhat.com>
14122
14123         * linux-fork.c (fork_info::clobber_regs): Delete.
14124         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
14125         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
14126         comment.  Adjust.
14127         (scoped_switch_fork_info::scoped_switch_fork_info)
14128         (checkpoint_command, linux_fork_context): Adjust
14129         fork_save_infrun_state calls.
14130
14131 2019-03-06  Pedro Alves  <palves@redhat.com>
14132
14133         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
14134         (inf_has_multiple_threads): Return 'bool' and rewrite using
14135         inferior_info::threads().
14136
14137 2019-03-06  Pedro Alves  <palves@redhat.com>
14138
14139         * linux-fork.c: Include <list>.
14140         (fork_list): Now a std::list instance.
14141         (fork_info): Add ctor, dtor, and in-class initialize all fields.
14142         (forks_exist_p, find_last_fork): Adjust.
14143         (new_fork): Delete.
14144         (one_fork_p): New.
14145         (add_fork): Adjust.
14146         (free_fork): Delete, folded into fork_info::~fork_info().
14147         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
14148         Adjust.
14149         (init_fork_list): Delete.
14150         (linux_fork_killall, linux_fork_mourn_inferior)
14151         (linux_fork_detach, info_checkpoints_command): Adjust.
14152         (_initialize_linux_fork): No longer call init_fork_list.
14153
14154 2019-03-06  Pedro Alves  <palves@redhat.com>
14155
14156         * linux-fork.c (new_fork): New, split out of ...
14157         (add_fork): ... this.  Return void.  Move "first fork" special
14158         case from here, to ...
14159         (checkpoint_command): ... here.
14160         * linux-linux.h (add_fork): Return void.
14161
14162 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
14163
14164         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
14165
14166 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
14167             Chris January  <chris.january@arm.com>
14168             David Lecomber  <david.lecomber@arm.com>
14169
14170         * f-exp.y: New token, UNOP_INTRINSIC.
14171         (exp): New pattern using UNOP_INTRINSIC token.
14172         (f77_keywords): Add 'abs' keyword.
14173         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
14174         (value_from_host_double): New function.
14175         (evaluate_subexp_f): Support UNOP_ABS.
14176
14177 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
14178
14179         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
14180         types.
14181
14182 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
14183
14184         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
14185         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
14186         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
14187
14188 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
14189
14190         * f-exp.y (convert_to_kind_type): Handle more type kinds.
14191
14192 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
14193             Chris January  <chris.january@arm.com>
14194
14195         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
14196         * f-exp.y: Define 'KIND' token.
14197         (exp): New pattern for KIND expressions.
14198         (ptype): Handle types with a kind extension.
14199         (direct_abs_decl): Extend to spot kind extensions.
14200         (f77_keywords): Add 'kind' to the list.
14201         (push_kind_type): New function.
14202         (convert_to_kind_type): New function.
14203         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
14204         * parse.c (operator_length_standard): Likewise.
14205         * parser-defs.h (enum type_pieces): Add tp_kind.
14206         * std-operator.def: Add UNOP_KIND.
14207
14208 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
14209
14210         * f-exp.y (f_parse): Set yydebug.
14211
14212 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
14213
14214         * f-lang.c (evaluate_subexp_f): New function.
14215         (exp_descriptor_f): New global.
14216         (f_language_defn): Use exp_descriptor_f instead of
14217         exp_descriptor_standard.
14218
14219 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
14220
14221         * f-exp.y (struct token): Add comments.
14222         (dot_ops): Remove uppercase versions and the end marker.
14223         (f77_keywords): Likewise.
14224         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
14225         entries in the dot_ops array are case insensitive, and use
14226         strncasecmp to compare strings.  Also some whitespace cleanup in
14227         this area.  Similar for the f77_keywords array, except entries in
14228         this list might be case sensitive.
14229
14230 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
14231
14232         * f-exp.y (struct f77_boolean_val): Add comments.
14233         (boolean_values): Remove uppercase versions, and end marker.
14234         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
14235         and use strncasecmp to achieve case insensitivity.  Additionally,
14236         perform whitespace cleanup around this code.
14237
14238 2019-03-06  Tom Tromey  <tromey@adacore.com>
14239
14240         * remote-sim.c (gdbsim_target_open): Use result of
14241         gdb_argv::release.
14242
14243 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
14244         Dirk Schubert  <dirk.schubert@arm.com>
14245         Chris January  <chris.january@arm.com>
14246
14247         * eval.c (evaluate_subexp_standard): Call Fortran argument
14248         wrapping logic.
14249         * f-lang.c (struct value): A value which can be passed into a
14250         Fortran function call.
14251         (fortran_argument_convert): Wrap Fortran arguments in a pointer
14252         where appropriate.
14253         (struct type): Value ready for a Fortran function call.
14254         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
14255         is needed.
14256         * f-lang.h (fortran_argument_convert): Declaration.
14257         (fortran_preserve_arg_pointer): Declaration.
14258         * infcall.c (value_arg_coerce): Call Fortran argument logic.
14259
14260 2019-03-05  Tom Tromey  <tromey@adacore.com>
14261
14262         * python/py-prettyprint.c (print_string_repr): Remove #if.
14263         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
14264
14265 2019-03-05  Tom Tromey  <tromey@adacore.com>
14266
14267         * target.c (the_dummy_target): Move later.  Change type to
14268         "dummy_target".
14269         (initialize_targets): Don't initialize the_dummy_target.
14270
14271 2019-03-05  Tom Tromey  <tromey@adacore.com>
14272
14273         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
14274         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
14275
14276 2019-03-05  Tom Tromey  <tromey@adacore.com>
14277
14278         * windows-nat.c (windows_nat_target::attach)
14279         (windows_nat_target::detach): Don't call gdb_flush.
14280         * valprint.c (generic_val_print, val_print, val_print_string):
14281         Don't call gdb_flush.
14282         * utils.c (defaulted_query): Don't call gdb_flush.
14283         * typeprint.c (print_type_scalar): Don't call gdb_flush.
14284         * target.c (target_announce_detach): Don't call gdb_flush.
14285         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
14286         * remote.c (extended_remote_target::attach): Don't call
14287         gdb_flush.
14288         * procfs.c (procfs_target::detach): Don't call gdb_flush.
14289         * printcmd.c (do_examine): Don't call gdb_flush.
14290         (info_display_command): Don't call gdb_flush.
14291         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
14292         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
14293         * memattr.c (info_mem_command): Don't call gdb_flush.
14294         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
14295         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
14296         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
14297         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
14298         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
14299         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
14300         (gnu_nat_target::detach): Don't call gdb_flush.
14301         * f-valprint.c (f_val_print): Don't call gdb_flush.
14302         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
14303         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
14304         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
14305         gdb_flush.
14306         * c-valprint.c (c_val_print): Don't call gdb_flush.
14307         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
14308
14309 2019-03-05  Tom Tromey  <tromey@adacore.com>
14310
14311         * varobj.c (update_dynamic_varobj_children): Update.
14312         (install_default_visualizer): Use reset, not release.
14313         * value.c (set_internalvar): Update.
14314         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
14315         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
14316         ATTRIBUTE_UNUSED_RESULT.
14317
14318 2019-03-05  Tom Tromey  <tromey@adacore.com>
14319
14320         * remote.c (class scoped_remote_fd) <release>: Add
14321         ATTRIBUTE_UNUSED_RESULT.
14322
14323 2019-03-05  Tom Tromey  <tromey@adacore.com>
14324
14325         * macroexp.c (struct macro_buffer) <release>: Add
14326         ATTRIBUTE_UNUSED_RESULT.
14327
14328 2019-03-05  Tom Tromey  <tromey@adacore.com>
14329
14330         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
14331         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
14332         ATTRIBUTE_UNUSED_RESULT.
14333
14334 2019-03-05  Tom Tromey  <tromey@adacore.com>
14335
14336         * common/scoped_fd.h (class scoped_fd) <release>: Add
14337         ATTRIBUTE_UNUSED_RESULT.
14338
14339 2019-03-05  Tom Tromey  <tromey@adacore.com>
14340
14341         * parser-defs.h (struct parser_state) <release>: Add
14342         ATTRIBUTE_UNUSED_RESULT.
14343
14344 2019-03-05  Tom Tromey  <tromey@adacore.com>
14345
14346         * utils.h (class gdb_argv) <release>: Add
14347         ATTRIBUTE_UNUSED_RESULT.
14348         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
14349
14350 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
14351
14352         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
14353         for-loop range, to avoid compiler warnings.
14354
14355         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
14356         avoid compiler warnings about unused variables.
14357
14358         * NEWS: Mention end of support for native debugging on MS-Windows
14359         before XP.
14360
14361         PR gdb/24292
14362         * common/netstuff.c:
14363         * gdbserver/gdbreplay.c
14364         * gdbserver/remote-utils.c:
14365         * ser-tcp.c:
14366         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
14367         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
14368         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
14369         'getaddrinfo' and 'freeaddrinfo' were not available before
14370         Windows XP, and mingw.org's MinGW headers by default define
14371         _WIN32_WINNT to 0x500.
14372
14373 2019-03-01  Gary Benson <gbenson@redhat.com>
14374
14375         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
14376
14377 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
14378             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
14379
14380         PR gdb/8527
14381         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
14382         set_sigint_trap, clear_sigint_trap.
14383
14384 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
14385
14386         * target.c (target_detach): Clear the regcache and the
14387         frame cache.
14388
14389 2019-02-27  Pedro Alves  <palves@redhat.com>
14390
14391         * utils.c (set_screen_size): When we cap the height/width sizes,
14392         tweak the corresponding command variable to show "unlimited":
14393
14394 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
14395             Pedro Alves  <palves@redhat.com>
14396
14397         * utils.c (set_screen_size): Reduce "infinite" rows and columns
14398         before calling rl_set_screen_size.
14399
14400 2019-02-27  Tom Tromey  <tromey@adacore.com>
14401
14402         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
14403         define.
14404         * python/py-value.c: Remove Python 2.4 workaround.
14405         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
14406         workaround.
14407         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
14408         Python 2.4 workaround.
14409         * python/python-internal.h: Remove Python 2.4 comment.
14410         (Py_ssize_t): Don't define.
14411         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
14412         (gdb_Py_DECREF): Remove Python 2.4 workaround.
14413         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
14414         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
14415         * python/python.c (do_start_initialization): Remove Python 2.4
14416         workaround.
14417         * python/py-prettyprint.c (class dummy_python_frame): Remove.
14418         (print_children): Remove Python 2.4 workaround.
14419         * python/py-inferior.c (buffer_procs): Remove Python 2.4
14420         workaround.
14421         (CHARBUFFERPROC_NAME): Remove.
14422         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
14423         Python 2.4 workaround.
14424
14425 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
14426
14427         * NEWS: Note minimum Python version.
14428
14429 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
14430
14431         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
14432         code from these functions.  Remove corresponding ifdefs.  Use
14433         Py_buffer_up instead of explicit calls to PyBuffer_Release.
14434         Remove gotos and target of gotos.
14435         (infpy_search_memory): Likewise.
14436
14437 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
14438
14439         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
14440         (hppa_gdbarch_init): Don't register deleted functions with
14441         gdbarch.
14442
14443 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
14444
14445         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
14446         (h8300_unwind_sp): Delete.
14447         (h8300_dummy_id): Delete.
14448         (h8300_gdbarch_init): Don't register deleted functions with
14449         gdbarch.
14450
14451 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
14452
14453         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
14454         (ft32_unwind_pc): Delete.
14455         (ft32_unwind_sp): Delete.
14456         (ft32_gdbarch_init): Don't register deleted functions with
14457         gdbarch.
14458
14459 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
14460
14461         * gdb/frv-tdep.c (frv_dummy_id): Delete.
14462         (frv_unwind_pc): Delete.
14463         (frv_unwind_sp): Delete.
14464         (frv_gdbarch_init): Don't register deleted functions with
14465         gdbarch.
14466
14467 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
14468
14469         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
14470         (riscv_unwind_pc): Delete.
14471         (riscv_unwind_sp): Delete.
14472         (riscv_gdbarch_init): Don't register deleted functions with
14473         gdbarch.
14474
14475 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
14476
14477         * gdb/csky-tdep.c (csky_dummy_id): Delete.
14478         (csky_unwind_pc): Delete.
14479         (csky_unwind_sp): Delete.
14480         (csky_gdbarch_init): Don't register deleted functions with
14481         gdbarch.
14482
14483 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
14484
14485         * gdb/cris-tdep.c (cris_dummy_id): Delete.
14486         (cris_unwind_pc): Delete.
14487         (cris_unwind_sp): Delete.
14488         (cris_gdbarch_init): Don't register deleted functions with
14489         gdbarch.
14490
14491 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
14492
14493         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
14494         (bfin_unwind_pc): Delete.
14495         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
14496
14497 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
14498
14499         * gdb/arm-tdep.c (arm_dummy_id): Delete.
14500         (arm_unwind_pc): Delete.
14501         (arm_unwind_sp): Delete.
14502         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
14503
14504 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
14505
14506         * gdb/arc-tdep.c (arc_dummy_id): Delete.
14507         (arc_unwind_pc): Delete.
14508         (arc_unwind_sp): Delete.
14509         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
14510
14511 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
14512
14513         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
14514         (alpha_unwind_pc): Delete.
14515         (alpha_gdbarch_init): Don't register deleted functions with
14516         gdbarch.
14517
14518 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
14519
14520         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
14521         (aarch64_unwind_pc): Delete.
14522         (aarch64_unwind_sp): Delete.
14523         (aarch64_gdbarch_init): Don't register deleted functions with
14524         gdbarch.
14525
14526 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
14527
14528         * gdbtypes.c (type_align): Don't consider static members when
14529         computing structure alignment.
14530
14531 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
14532
14533         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
14534         return 0 for other types.
14535         * arch-utils.c (default_type_align): Always return 0.
14536         * gdbarch.h: Regenerate.
14537         * gdbarch.sh (type_align): Extend comment.
14538         * gdbtypes.c (type_align): Add additional comments, always call
14539         gdbarch_type_align before applying the default rules.
14540         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
14541         generic code will then apply a suitable default.
14542         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
14543         types, return 0 for other types.
14544
14545 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
14546
14547         * NEWS: Create a new section for the next release branch.
14548         Rename the section of the current branch, now that it has
14549         been cut.
14550
14551 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
14552
14553         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
14554         * version.in: Bump version to 8.3.50.DATE-git.
14555
14556 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
14557
14558         * aix-thread.c (ptid_cmp): Remove unused variable.
14559         (get_signaled_thread): Likewise.
14560         (store_regs_user_thread): Likewise.
14561         (store_regs_kernel_thread): Likewise.
14562         (fetch_regs_kernel_thread): Remove shadowed variable.
14563
14564 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
14565
14566         * features/riscv/32bit-cpu.xml: Add register numbers.
14567         * features/riscv/32bit-fpu.c: Regenerate.
14568         * features/riscv/32bit-fpu.xml: Add register numbers.
14569         * features/riscv/64bit-cpu.xml: Add register numbers.
14570         * features/riscv/64bit-fpu.c: Regenerate.
14571         * features/riscv/64bit-fpu.xml: Add register numbers.
14572
14573 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
14574
14575         * NEWS: Mention two argument form of gdb.Value constructor.
14576         * python/py-value.c (convert_buffer_and_type_to_value): New
14577         function.
14578         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
14579         Add support for handling an optional second argument.  Call
14580         convert_buffer_and_type_to_value as appropriate.
14581         * python/python-internal.h (Py_buffer_deleter): New struct.
14582         (Py_buffer_up): New typedef.
14583
14584 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
14585
14586         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
14587         instead of releasing ownership.
14588
14589 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
14590
14591         * dwarf2read.c (open_and_init_dwp_file): Call
14592         elf_numsections instead of bfd_count_sections to initialize
14593         dwp_file->num_sections.
14594
14595 2019-02-25  Tom Tromey  <tromey@adacore.com>
14596
14597         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
14598
14599 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
14600
14601         * gcore.in: Add '--readnever' option when invoking GDB.
14602
14603 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
14604
14605         * MAINTAINERS: Update my email address.
14606
14607 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
14608
14609         * build-id.c (build_id_to_debug_bfd_1): New function.
14610         (build_id_to_debug_bfd): Look for separate debug file in
14611         sysroot.
14612
14613 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
14614
14615         * gdbarch.sh: Update the copyright year range that is placed into
14616         generated files.
14617
14618 2019-02-22  Keith Seitz  <keiths@redhat.com>
14619
14620         PR symtab/23853
14621         * linespec.c (create_sals_line_offset): Search for the default
14622         symtab's filename instead of its fullname.
14623
14624 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
14625
14626         * NEWS: Update style defaults.
14627
14628 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
14629
14630         * main.c (captured_main_1): Disable styling in batch mode.
14631
14632 2019-02-20  Tom Tromey  <tom@tromey.com>
14633
14634         * symtab.c (symtab_symbol_info): Fix typos.
14635
14636 2019-02-20  Tom Tromey  <tromey@adacore.com>
14637
14638         * findcmd.c (_initialize_mem_search): Use upper case for
14639         metasyntactic variables.
14640
14641 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
14642
14643         * aarch64-tdep.c (aarch64_add_reggroups): New function.
14644         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
14645
14646 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
14647
14648         * top.h (source_file_name): Change to std::string.
14649         * top.c (source_file_name): Likewise.
14650         (command_line_input): Adjust.
14651         * cli/cli-script.c (script_from_file): Adjust.
14652
14653 2019-02-19  Tom Tromey  <tromey@adacore.com>
14654
14655         * ravenscar-thread.c
14656         (ravenscar_thread_target::update_thread_list): Don't call
14657         ada_build_task_list.
14658         * ada-lang.h (ada_build_task_list): Don't declare.
14659         * ada-tasks.c (struct ada_tasks_inferior_data)
14660         <task_list_valid_p>: Now bool.
14661         (read_known_tasks, ada_task_list_changed)
14662         (ada_tasks_invalidate_inferior_data): Update.
14663         (read_known_tasks_array): Return bool.
14664         (read_known_tasks_list): Likewise.
14665         (read_known_tasks): Return void.
14666         (ada_build_task_list): Now static.
14667
14668 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
14669
14670         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
14671         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
14672
14673 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
14674
14675         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
14676         variant for ada_tasks_pspace_data_handle and
14677         ada_tasks_inferior_data_handle.
14678         (ada_tasks_pspace_data_cleanup): New function.
14679         (ada_tasks_inferior_data_cleanup): New function.
14680
14681 2019-02-17  Tom Tromey  <tom@tromey.com>
14682
14683         * macrotab.h (macro_source_fullname): Return a std::string.
14684         * macrotab.c (macro_include, check_for_redefinition)
14685         (macro_undef, macro_lookup_definition, foreach_macro)
14686         (foreach_macro_in_scope): Update.
14687         (macro_source_fullname): Return a std::string.
14688         * macrocmd.c (show_pp_source_pos): Update.
14689
14690 2019-02-17  Tom Tromey  <tom@tromey.com>
14691
14692         * macrocmd.c (show_pp_source_pos): Style the file names.
14693
14694 2019-02-17  Tom Tromey  <tom@tromey.com>
14695
14696         PR tui/24197:
14697         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
14698
14699 2019-02-17  Tom Tromey  <tom@tromey.com>
14700
14701         * ada-lang.c (user_select_syms): Use filtered printing.
14702         * utils.c (wrap_style): New global.
14703         (desired_style): Remove.
14704         (emit_style_escape): Add stream parameter.
14705         (set_output_style, reset_terminal_style, prompt_for_continue):
14706         Update.
14707         (flush_wrap_buffer): Only flush gdb_stdout.
14708         (wrap_here): Set wrap_style.
14709         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
14710         treat escape sequences as a character.  Change when wrap buffer is
14711         flushed.
14712         (fputs_styled): Do not set the output style when the default is
14713         requested.
14714         * ui-style.h (struct ui_file_style) <is_default>: New method.
14715         * source.c (print_source_lines_base): Emit escape sequences in one
14716         piece.
14717
14718 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
14719
14720         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
14721         integers and enumeration types.
14722
14723 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
14724
14725         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
14726         instead of lookup_symbol_in_language
14727         (do_exact_match): New function.
14728         (ada_get_symbol_name_matcher): Return do_exact_match when
14729         doing a verbatim match.
14730
14731 2019-02-15  Tom Tromey  <tromey@adacore.com>
14732
14733         * ravenscar-thread.c (ravenscar_thread_target::resume)
14734         (ravenscar_thread_target::wait): Special case wildcard requests.
14735
14736 2019-02-15  Tom Tromey  <tromey@adacore.com>
14737
14738         * ravenscar-thread.c (base_ptid): Remove.
14739         (struct ravenscar_thread_target) <close>: New method.
14740         <m_base_ptid>: New member.
14741         <update_inferior_ptid, active_task, task_is_currently_active,
14742         runtime_initialized>: Declare methods.
14743         <ravenscar_thread_target>: Add constructor.
14744         (ravenscar_thread_target::task_is_currently_active)
14745         (ravenscar_thread_target::update_inferior_ptid)
14746         (ravenscar_runtime_initialized): Rename.  Now methods.
14747         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
14748         (ravenscar_thread_target::update_thread_list): Update.
14749         (ravenscar_thread_target::active_task): Now method.
14750         (ravenscar_thread_target::store_registers)
14751         (ravenscar_thread_target::prepare_to_store)
14752         (ravenscar_thread_target::prepare_to_store)
14753         (ravenscar_thread_target::mourn_inferior): Update.
14754         (ravenscar_inferior_created): Use "new" to create target.
14755         (ravenscar_thread_target::get_ada_task_ptid): Update.
14756         (_initialize_ravenscar): Don't initialize base_ptid.
14757         (ravenscar_ops): Remove global.
14758
14759 2019-02-15  Tom Tromey  <tromey@adacore.com>
14760
14761         * target.h (push_target): Declare new overload.
14762         * target.c (push_target): New overload, taking an rvalue reference.
14763         * remote.c (remote_target::open_1): Use push_target overload.
14764         * corelow.c (core_target_open): Use push_target overload.
14765
14766 2019-02-15  Tom Tromey  <tromey@adacore.com>
14767
14768         * ravenscar-thread.c (is_ravenscar_task)
14769         (ravenscar_task_is_currently_active): Return bool.
14770         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
14771         (_initialize_ravenscar): Remove "(void)".
14772         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
14773         Return bool.
14774
14775 2019-02-15  Tom Tromey  <tromey@adacore.com>
14776
14777         * ravenscar-thread.c (ravenscar_runtime_initializer)
14778         (has_ravenscar_runtime, get_running_thread_id)
14779         (ravenscar_thread_target::resume): Fix indentation.
14780
14781 2019-02-15  Tom Tromey  <tromey@adacore.com>
14782
14783         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
14784         from ravenscar_arch_ops.
14785         (sparc_ravenscar_ops::fetch_registers)
14786         (sparc_ravenscar_ops::store_registers): Now methods.
14787         (sparc_ravenscar_prepare_to_store): Remove.
14788         (sparc_ravenscar_ops): Redefine.
14789         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
14790         methods and destructor.  Remove members.
14791         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
14792         (ravenscar_thread_target::store_registers)
14793         (ravenscar_thread_target::prepare_to_store): Update.
14794         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
14795         Remove.
14796         (struct ppc_ravenscar_powerpc_ops): Derive from
14797         ravenscar_arch_ops.
14798         (ppc_ravenscar_powerpc_ops::fetch_registers)
14799         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
14800         (ppc_ravenscar_powerpc_ops): Redefine.
14801         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
14802         (ppc_ravenscar_e500_ops::fetch_registers)
14803         (ppc_ravenscar_e500_ops::store_registers): Now methods.
14804         (ppc_ravenscar_e500_ops): Redefine.
14805         * aarch64-ravenscar-thread.c
14806         (aarch64_ravenscar_generic_prepare_to_store): Remove.
14807         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
14808         (aarch64_ravenscar_fetch_registers)
14809         (aarch64_ravenscar_store_registers): Now methods.
14810         (aarch64_ravenscar_ops): Redefine.
14811
14812 2019-02-15  Tom Tromey  <tromey@adacore.com>
14813
14814         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
14815         (ravenscar_thread_target::stopped_by_hw_breakpoint)
14816         (ravenscar_thread_target::stopped_by_watchpoint)
14817         (ravenscar_thread_target::stopped_data_address)
14818         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
14819
14820 2019-02-15  Tom Tromey  <tromey@adacore.com>
14821
14822         * ravenscar-thread.c: Fix some typos.
14823
14824 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
14825             Tom Tromey  <tromey@adacore.com>
14826
14827         * ada-lang.c (ada_exception_sal): Change addr_string to a
14828         std::string.
14829         (create_ada_exception_catchpoint): Update.
14830
14831 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
14832             Tom Tromey  <tromey@adacore.com>
14833
14834         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
14835         (bp_location_ops): Remove.
14836         (base_breakpoint_allocate_location): Update.
14837         (free_bp_location): Update.
14838         * ada-lang.c (class ada_catchpoint_location)
14839         <ada_catchpoint_location>: Remove ops parameter.
14840         (ada_catchpoint_location_dtor): Remove.
14841         (ada_catchpoint_location_ops): Remove.
14842         (allocate_location_exception): Update.
14843         * breakpoint.h (struct bp_location_ops): Remove.
14844         (class bp_location) <bp_location>: Remove bp_location_ops
14845         parameter.
14846         <~bp_location>: Add destructor.
14847         <ops>: Remove.
14848
14849 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
14850             Pedro Alves  <palves@redhat.com>
14851
14852         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
14853         'PATH_MAX'.
14854
14855 2019-02-14  David Michael  <fedora.dm0@gmail.com>
14856             Samuel Thibault  <samuel.thibault@gnu.org>
14857             Thomas Schwinge  <thomas@codesourcery.com>
14858
14859         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
14860         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
14861
14862 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
14863
14864         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
14865         (check_empty): Use "const char *".
14866
14867         * gnu-nat.c (gnu_nat_target::detach): Instead of
14868         'detach_inferior (pid)' call
14869         'detach_inferior (find_inferior_pid (pid))'.
14870
14871         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
14872         'nat/fork-inferior.o'.
14873         * gnu-nat.c: #include "nat/fork-inferior.h".
14874
14875         * gnu-nat.c (gnu_nat_target::detach): Instead of
14876         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
14877         * gnu-nat.h: #include "inf-child.h".
14878         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
14879         'i386_gnu_nat_target::fetch_registers'.
14880         (gnu_store_registers): Rename/move to
14881         'i386_gnu_nat_target::store_registers'.
14882
14883         * config/i386/nm-i386gnu.h: Don't "#include" any files.
14884         * gnu-nat.h (mach_thread_info): New function.
14885         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
14886
14887         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
14888
14889 2019-02-14  Frederic Konrad  <konrad@adacore.com>
14890
14891         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
14892
14893 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
14894
14895         * windows-nat.c (windows_add_thread): Add new parameter
14896         "main_thread_p" with default value set to false.  Update
14897         function documentation as well as all callers.
14898         (windows_delete_thread): Likewise.
14899         (fake_create_process): Update call to windows_add_thread.
14900         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
14901         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
14902         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
14903         call to windows_delete_thread.
14904
14905 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
14906
14907         * MAINTAINERS: Add Andrew Burgess as global maintainer.
14908
14909 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
14910
14911         * symfile.c (find_separate_debug_file): Use canonical path of
14912         sysroot with child_path instead of gdb_sysroot if it is valid.
14913
14914 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
14915
14916         * symfile.c (find_separate_debug_file): Use child_path to
14917         determine if an object file is under a sysroot.
14918
14919 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
14920
14921         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
14922         unittests/child-path-selftests.c.
14923         * common/pathstuff.c (child_path): New function.
14924         * common/pathstuff.h (child_path): New prototype.
14925         * unittests/child-path-selftests.c: New file.
14926
14927 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
14928
14929         * symfile.c (find_separate_debug_file): Look for separate debug
14930         files in debug directories under the sysroot.
14931
14932 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
14933
14934         * symtab.h (struct minimal_symbol data_p): New const method.
14935         (struct minimal_symbol text_p): Likewise.
14936         * symtab.c (output_source_filename): Use file name style
14937         to print file name.
14938         (print_symbol_info): Likewise.
14939         (print_msymbol_info): Use address style to print addresses.
14940         Use function name style to print executable text symbols.
14941         (expand_symtab_containing_pc): Use data_p.
14942         (find_pc_sect_compunit_symtab): Likewise.
14943
14944 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
14945
14946         * breakpoint.c (describe_other_breakpoints): Use address style
14947         to print addresses.
14948         (say_where): Likewise.
14949
14950 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
14951
14952         * ada-typeprint.c (print_func_type): Print function name
14953         style to print function name.
14954         * c-typeprint.c (c_print_type_1): Likewise.
14955
14956 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
14957
14958         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
14959         for execve.
14960
14961 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
14962
14963         * c-exp.y (direct_abs_decl): Use emplace_back to record the
14964         type_stack.
14965
14966 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
14967
14968         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
14969         TYPE_CODE_REF types.
14970
14971 2019-02-08  Jim Wilson  <jimw@sifive.com>
14972
14973         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
14974         (riscv_linux_fregset): New.
14975         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
14976
14977 2019-02-07  Tom Tromey  <tom@tromey.com>
14978
14979         * thread.c (thread_cancel_execution_command): Update.
14980         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
14981         methods.
14982         (struct thread_fsm_ops): Remove.
14983         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
14984         (thread_fsm_should_stop, thread_fsm_return_value)
14985         (thread_fsm_set_finished, thread_fsm_finished_p)
14986         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
14987         Don't declare.
14988         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
14989         * infrun.c (clear_proceed_status_thread)
14990         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
14991         (print_stop_event): Update.
14992         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
14993         Add constructor.
14994         (step_command_fsm_ops): Remove.
14995         (new_step_command_fsm): Remove.
14996         (step_1): Update.
14997         (step_command_fsm::should_stop): Rename from
14998         step_command_fsm_should_stop.
14999         (step_command_fsm::clean_up): Rename from
15000         step_command_fsm_clean_up.
15001         (step_command_fsm::do_async_reply_reason): Rename from
15002         step_command_fsm_async_reply_reason.
15003         (struct until_next_fsm): Inherit from thread_fsm.  Add
15004         constructor.
15005         (until_next_fsm_ops): Remove.
15006         (new_until_next_fsm): Remove.
15007         (until_next_fsm::should_stop): Rename from
15008         until_next_fsm_should_stop.
15009         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
15010         (until_next_fsm::do_async_reply_reason): Rename from
15011         until_next_fsm_async_reply_reason.
15012         (struct finish_command_fsm): Inherit from thread_fsm.  Add
15013         constructor.  Change type of breakpoint.
15014         (finish_command_fsm_ops): Remove.
15015         (new_finish_command_fsm): Remove.
15016         (finish_command_fsm::should_stop): Rename from
15017         finish_command_fsm_should_stop.
15018         (finish_command_fsm::clean_up): Rename from
15019         finish_command_fsm_clean_up.
15020         (finish_command_fsm::return_value): Rename from
15021         finish_command_fsm_return_value.
15022         (finish_command_fsm::do_async_reply_reason): Rename from
15023         finish_command_fsm_async_reply_reason.
15024         (finish_command): Update.
15025         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
15026         Add constructor.
15027         (call_thread_fsm_ops): Remove.
15028         (call_thread_fsm::call_thread_fsm): Rename from
15029         new_call_thread_fsm.
15030         (call_thread_fsm::should_stop): Rename from
15031         call_thread_fsm_should_stop.
15032         (call_thread_fsm::should_notify_stop): Rename from
15033         call_thread_fsm_should_notify_stop.
15034         (run_inferior_call, call_function_by_hand_dummy): Update.
15035         * cli/cli-interp.c (should_print_stop_to_console): Update.
15036         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
15037         Add constructor.  Change type of location_breakpoint,
15038         caller_breakpoint.
15039         (until_break_fsm_ops): Remove.
15040         (new_until_break_fsm): Remove.
15041         (until_break_fsm::should_stop): Rename from
15042         until_break_fsm_should_stop.
15043         (until_break_fsm::clean_up): Rename from
15044         until_break_fsm_clean_up.
15045         (until_break_fsm::do_async_reply_reason): Rename from
15046         until_break_fsm_async_reply_reason.
15047         (until_break_command): Update.
15048         * thread-fsm.c: Remove.
15049         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
15050
15051 2019-02-07  Tom Tromey  <tom@tromey.com>
15052
15053         * yy-remap.h: Add include guard.
15054         * xtensa-tdep.h: Add include guard.
15055         * xcoffread.h: Rename include guard.
15056         * varobj-iter.h: Add include guard.
15057         * tui/tui.h: Rename include guard.
15058         * tui/tui-winsource.h: Rename include guard.
15059         * tui/tui-wingeneral.h: Rename include guard.
15060         * tui/tui-windata.h: Rename include guard.
15061         * tui/tui-win.h: Rename include guard.
15062         * tui/tui-stack.h: Rename include guard.
15063         * tui/tui-source.h: Rename include guard.
15064         * tui/tui-regs.h: Rename include guard.
15065         * tui/tui-out.h: Rename include guard.
15066         * tui/tui-layout.h: Rename include guard.
15067         * tui/tui-io.h: Rename include guard.
15068         * tui/tui-hooks.h: Rename include guard.
15069         * tui/tui-file.h: Rename include guard.
15070         * tui/tui-disasm.h: Rename include guard.
15071         * tui/tui-data.h: Rename include guard.
15072         * tui/tui-command.h: Rename include guard.
15073         * tic6x-tdep.h: Add include guard.
15074         * target/waitstatus.h: Rename include guard.
15075         * target/wait.h: Rename include guard.
15076         * target/target.h: Rename include guard.
15077         * target/resume.h: Rename include guard.
15078         * target-float.h: Rename include guard.
15079         * stabsread.h: Add include guard.
15080         * rs6000-tdep.h: Add include guard.
15081         * riscv-fbsd-tdep.h: Add include guard.
15082         * regformats/regdef.h: Rename include guard.
15083         * record.h: Rename include guard.
15084         * python/python.h: Rename include guard.
15085         * python/python-internal.h: Rename include guard.
15086         * python/py-stopevent.h: Rename include guard.
15087         * python/py-ref.h: Rename include guard.
15088         * python/py-record.h: Rename include guard.
15089         * python/py-record-full.h: Rename include guard.
15090         * python/py-record-btrace.h: Rename include guard.
15091         * python/py-instruction.h: Rename include guard.
15092         * python/py-events.h: Rename include guard.
15093         * python/py-event.h: Rename include guard.
15094         * procfs.h: Add include guard.
15095         * proc-utils.h: Add include guard.
15096         * p-lang.h: Add include guard.
15097         * or1k-tdep.h: Rename include guard.
15098         * observable.h: Rename include guard.
15099         * nto-tdep.h: Rename include guard.
15100         * nat/x86-linux.h: Rename include guard.
15101         * nat/x86-linux-dregs.h: Rename include guard.
15102         * nat/x86-gcc-cpuid.h: Add include guard.
15103         * nat/x86-dregs.h: Rename include guard.
15104         * nat/x86-cpuid.h: Rename include guard.
15105         * nat/ppc-linux.h: Rename include guard.
15106         * nat/mips-linux-watch.h: Rename include guard.
15107         * nat/linux-waitpid.h: Rename include guard.
15108         * nat/linux-ptrace.h: Rename include guard.
15109         * nat/linux-procfs.h: Rename include guard.
15110         * nat/linux-osdata.h: Rename include guard.
15111         * nat/linux-nat.h: Rename include guard.
15112         * nat/linux-namespaces.h: Rename include guard.
15113         * nat/linux-btrace.h: Rename include guard.
15114         * nat/glibc_thread_db.h: Rename include guard.
15115         * nat/gdb_thread_db.h: Rename include guard.
15116         * nat/gdb_ptrace.h: Rename include guard.
15117         * nat/fork-inferior.h: Rename include guard.
15118         * nat/amd64-linux-siginfo.h: Rename include guard.
15119         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
15120         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
15121         * nat/aarch64-linux.h: Rename include guard.
15122         * nat/aarch64-linux-hw-point.h: Rename include guard.
15123         * mn10300-tdep.h: Add include guard.
15124         * mips-linux-tdep.h: Add include guard.
15125         * mi/mi-parse.h: Rename include guard.
15126         * mi/mi-out.h: Rename include guard.
15127         * mi/mi-main.h: Rename include guard.
15128         * mi/mi-interp.h: Rename include guard.
15129         * mi/mi-getopt.h: Rename include guard.
15130         * mi/mi-console.h: Rename include guard.
15131         * mi/mi-common.h: Rename include guard.
15132         * mi/mi-cmds.h: Rename include guard.
15133         * mi/mi-cmd-break.h: Rename include guard.
15134         * m2-lang.h: Add include guard.
15135         * location.h: Rename include guard.
15136         * linux-record.h: Rename include guard.
15137         * linux-nat.h: Add include guard.
15138         * linux-fork.h: Add include guard.
15139         * i386-darwin-tdep.h: Rename include guard.
15140         * hppa-linux-offsets.h: Add include guard.
15141         * guile/guile.h: Rename include guard.
15142         * guile/guile-internal.h: Rename include guard.
15143         * gnu-nat.h: Rename include guard.
15144         * gdb-stabs.h: Rename include guard.
15145         * frv-tdep.h: Add include guard.
15146         * f-lang.h: Add include guard.
15147         * event-loop.h: Add include guard.
15148         * darwin-nat.h: Rename include guard.
15149         * cp-abi.h: Rename include guard.
15150         * config/sparc/nm-sol2.h: Rename include guard.
15151         * config/nm-nto.h: Rename include guard.
15152         * config/nm-linux.h: Add include guard.
15153         * config/i386/nm-i386gnu.h: Rename include guard.
15154         * config/djgpp/nl_types.h: Rename include guard.
15155         * config/djgpp/langinfo.h: Rename include guard.
15156         * compile/gcc-cp-plugin.h: Add include guard.
15157         * compile/gcc-c-plugin.h: Add include guard.
15158         * compile/compile.h: Rename include guard.
15159         * compile/compile-object-run.h: Rename include guard.
15160         * compile/compile-object-load.h: Rename include guard.
15161         * compile/compile-internal.h: Rename include guard.
15162         * compile/compile-cplus.h: Rename include guard.
15163         * compile/compile-c.h: Rename include guard.
15164         * common/xml-utils.h: Rename include guard.
15165         * common/x86-xstate.h: Rename include guard.
15166         * common/version.h: Rename include guard.
15167         * common/vec.h: Rename include guard.
15168         * common/tdesc.h: Rename include guard.
15169         * common/selftest.h: Rename include guard.
15170         * common/scoped_restore.h: Rename include guard.
15171         * common/scoped_mmap.h: Rename include guard.
15172         * common/scoped_fd.h: Rename include guard.
15173         * common/safe-iterator.h: Rename include guard.
15174         * common/run-time-clock.h: Rename include guard.
15175         * common/refcounted-object.h: Rename include guard.
15176         * common/queue.h: Rename include guard.
15177         * common/ptid.h: Rename include guard.
15178         * common/print-utils.h: Rename include guard.
15179         * common/preprocessor.h: Rename include guard.
15180         * common/pathstuff.h: Rename include guard.
15181         * common/observable.h: Rename include guard.
15182         * common/netstuff.h: Rename include guard.
15183         * common/job-control.h: Rename include guard.
15184         * common/host-defs.h: Rename include guard.
15185         * common/gdb_wait.h: Rename include guard.
15186         * common/gdb_vecs.h: Rename include guard.
15187         * common/gdb_unlinker.h: Rename include guard.
15188         * common/gdb_unique_ptr.h: Rename include guard.
15189         * common/gdb_tilde_expand.h: Rename include guard.
15190         * common/gdb_sys_time.h: Rename include guard.
15191         * common/gdb_string_view.h: Rename include guard.
15192         * common/gdb_splay_tree.h: Rename include guard.
15193         * common/gdb_setjmp.h: Rename include guard.
15194         * common/gdb_ref_ptr.h: Rename include guard.
15195         * common/gdb_optional.h: Rename include guard.
15196         * common/gdb_locale.h: Rename include guard.
15197         * common/gdb_assert.h: Rename include guard.
15198         * common/filtered-iterator.h: Rename include guard.
15199         * common/filestuff.h: Rename include guard.
15200         * common/fileio.h: Rename include guard.
15201         * common/environ.h: Rename include guard.
15202         * common/common-utils.h: Rename include guard.
15203         * common/common-types.h: Rename include guard.
15204         * common/common-regcache.h: Rename include guard.
15205         * common/common-inferior.h: Rename include guard.
15206         * common/common-gdbthread.h: Rename include guard.
15207         * common/common-exceptions.h: Rename include guard.
15208         * common/common-defs.h: Rename include guard.
15209         * common/common-debug.h: Rename include guard.
15210         * common/cleanups.h: Rename include guard.
15211         * common/buffer.h: Rename include guard.
15212         * common/btrace-common.h: Rename include guard.
15213         * common/break-common.h: Rename include guard.
15214         * cli/cli-utils.h: Rename include guard.
15215         * cli/cli-style.h: Rename include guard.
15216         * cli/cli-setshow.h: Rename include guard.
15217         * cli/cli-script.h: Rename include guard.
15218         * cli/cli-interp.h: Rename include guard.
15219         * cli/cli-decode.h: Rename include guard.
15220         * cli/cli-cmds.h: Rename include guard.
15221         * charset-list.h: Add include guard.
15222         * buildsym-legacy.h: Rename include guard.
15223         * bfin-tdep.h: Add include guard.
15224         * ax.h: Rename include guard.
15225         * arm-linux-tdep.h: Add include guard.
15226         * arm-fbsd-tdep.h: Add include guard.
15227         * arch/xtensa.h: Rename include guard.
15228         * arch/tic6x.h: Add include guard.
15229         * arch/i386.h: Add include guard.
15230         * arch/arm.h: Rename include guard.
15231         * arch/arm-linux.h: Rename include guard.
15232         * arch/arm-get-next-pcs.h: Rename include guard.
15233         * arch/amd64.h: Add include guard.
15234         * arch/aarch64-insn.h: Rename include guard.
15235         * arch-utils.h: Rename include guard.
15236         * annotate.h: Add include guard.
15237         * amd64-darwin-tdep.h: Rename include guard.
15238         * aarch64-linux-tdep.h: Add include guard.
15239         * aarch64-fbsd-tdep.h: Add include guard.
15240         * aarch32-linux-nat.h: Add include guard.
15241
15242 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
15243
15244         * macrotab.c (macro_define_internal): New function that
15245         factorizes macro_define_object_internal and macro_define_function
15246         code.
15247         (macro_define_object_internal): Use macro_define_internal.
15248         (macro_define_function): Likewise.
15249
15250 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
15251
15252         * macrocmd.c (extract_identifier): Return
15253         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
15254         callers.
15255
15256 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
15257
15258         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
15259
15260 2019-02-05  Tom Tromey  <tom@tromey.com>
15261
15262         * target.c (target_stack::unpush): Move assertion earlier.
15263
15264 2019-01-30  Tom Tromey  <tom@tromey.com>
15265
15266         PR python/23615:
15267         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
15268         (gdbpy_parse_and_eval): Likewise.
15269         * python/python-internal.h (gdbpy_allow_threads): New class.
15270
15271 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
15272
15273         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
15274         (aarch64_fbsd_fpregmap): Move earlier.
15275         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
15276         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
15277         instead of individual calls to trad_frame_set_reg_addr.
15278         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
15279         earlier.
15280         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
15281         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
15282         instead of individual calls to trad_frame_set_reg_addr.
15283
15284 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
15285
15286         * CONTRIBUTE: Replace contribution list with wiki link.
15287
15288 2019-01-25  Tom Tromey  <tom@tromey.com>
15289
15290         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
15291
15292 2019-01-25  Tom Tromey  <tom@tromey.com>
15293
15294         * xtensa-linux-nat.c: Fix common/ includes.
15295         * xml-support.h: Fix common/ includes.
15296         * xml-support.c: Fix common/ includes.
15297         * x86-linux-nat.c: Fix common/ includes.
15298         * windows-nat.c: Fix common/ includes.
15299         * varobj.h: Fix common/ includes.
15300         * varobj.c: Fix common/ includes.
15301         * value.c: Fix common/ includes.
15302         * valops.c: Fix common/ includes.
15303         * utils.c: Fix common/ includes.
15304         * unittests/xml-utils-selftests.c: Fix common/ includes.
15305         * unittests/utils-selftests.c: Fix common/ includes.
15306         * unittests/unpack-selftests.c: Fix common/ includes.
15307         * unittests/tracepoint-selftests.c: Fix common/ includes.
15308         * unittests/style-selftests.c: Fix common/ includes.
15309         * unittests/string_view-selftests.c: Fix common/ includes.
15310         * unittests/scoped_restore-selftests.c: Fix common/ includes.
15311         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
15312         * unittests/scoped_fd-selftests.c: Fix common/ includes.
15313         * unittests/rsp-low-selftests.c: Fix common/ includes.
15314         * unittests/parse-connection-spec-selftests.c: Fix common/
15315         includes.
15316         * unittests/optional-selftests.c: Fix common/ includes.
15317         * unittests/offset-type-selftests.c: Fix common/ includes.
15318         * unittests/observable-selftests.c: Fix common/ includes.
15319         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
15320         * unittests/memrange-selftests.c: Fix common/ includes.
15321         * unittests/memory-map-selftests.c: Fix common/ includes.
15322         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
15323         * unittests/function-view-selftests.c: Fix common/ includes.
15324         * unittests/environ-selftests.c: Fix common/ includes.
15325         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
15326         * unittests/common-utils-selftests.c: Fix common/ includes.
15327         * unittests/cli-utils-selftests.c: Fix common/ includes.
15328         * unittests/array-view-selftests.c: Fix common/ includes.
15329         * ui-file.c: Fix common/ includes.
15330         * tui/tui-io.c: Fix common/ includes.
15331         * tracepoint.h: Fix common/ includes.
15332         * tracepoint.c: Fix common/ includes.
15333         * tracefile-tfile.c: Fix common/ includes.
15334         * top.h: Fix common/ includes.
15335         * top.c: Fix common/ includes.
15336         * thread.c: Fix common/ includes.
15337         * target/waitstatus.h: Fix common/ includes.
15338         * target/waitstatus.c: Fix common/ includes.
15339         * target.h: Fix common/ includes.
15340         * target.c: Fix common/ includes.
15341         * target-memory.c: Fix common/ includes.
15342         * target-descriptions.c: Fix common/ includes.
15343         * symtab.h: Fix common/ includes.
15344         * symfile.c: Fix common/ includes.
15345         * stap-probe.c: Fix common/ includes.
15346         * spu-linux-nat.c: Fix common/ includes.
15347         * sparc-nat.c: Fix common/ includes.
15348         * source.c: Fix common/ includes.
15349         * solib.c: Fix common/ includes.
15350         * solib-target.c: Fix common/ includes.
15351         * ser-unix.c: Fix common/ includes.
15352         * ser-tcp.c: Fix common/ includes.
15353         * ser-pipe.c: Fix common/ includes.
15354         * ser-base.c: Fix common/ includes.
15355         * selftest-arch.c: Fix common/ includes.
15356         * s12z-tdep.c: Fix common/ includes.
15357         * rust-exp.y: Fix common/ includes.
15358         * rs6000-aix-tdep.c: Fix common/ includes.
15359         * riscv-tdep.c: Fix common/ includes.
15360         * remote.c: Fix common/ includes.
15361         * remote-notif.h: Fix common/ includes.
15362         * remote-fileio.h: Fix common/ includes.
15363         * remote-fileio.c: Fix common/ includes.
15364         * regcache.h: Fix common/ includes.
15365         * regcache.c: Fix common/ includes.
15366         * record-btrace.c: Fix common/ includes.
15367         * python/python.c: Fix common/ includes.
15368         * python/py-type.c: Fix common/ includes.
15369         * python/py-inferior.c: Fix common/ includes.
15370         * progspace.h: Fix common/ includes.
15371         * producer.c: Fix common/ includes.
15372         * procfs.c: Fix common/ includes.
15373         * proc-api.c: Fix common/ includes.
15374         * printcmd.c: Fix common/ includes.
15375         * ppc-linux-nat.c: Fix common/ includes.
15376         * parser-defs.h: Fix common/ includes.
15377         * osdata.c: Fix common/ includes.
15378         * obsd-nat.c: Fix common/ includes.
15379         * nat/x86-linux.c: Fix common/ includes.
15380         * nat/x86-linux-dregs.c: Fix common/ includes.
15381         * nat/x86-dregs.h: Fix common/ includes.
15382         * nat/x86-dregs.c: Fix common/ includes.
15383         * nat/ppc-linux.c: Fix common/ includes.
15384         * nat/mips-linux-watch.h: Fix common/ includes.
15385         * nat/mips-linux-watch.c: Fix common/ includes.
15386         * nat/linux-waitpid.c: Fix common/ includes.
15387         * nat/linux-ptrace.h: Fix common/ includes.
15388         * nat/linux-ptrace.c: Fix common/ includes.
15389         * nat/linux-procfs.c: Fix common/ includes.
15390         * nat/linux-personality.c: Fix common/ includes.
15391         * nat/linux-osdata.c: Fix common/ includes.
15392         * nat/linux-namespaces.c: Fix common/ includes.
15393         * nat/linux-btrace.h: Fix common/ includes.
15394         * nat/linux-btrace.c: Fix common/ includes.
15395         * nat/fork-inferior.c: Fix common/ includes.
15396         * nat/amd64-linux-siginfo.c: Fix common/ includes.
15397         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
15398         * nat/aarch64-linux.c: Fix common/ includes.
15399         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
15400         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
15401         * namespace.h: Fix common/ includes.
15402         * mips-linux-tdep.c: Fix common/ includes.
15403         * minsyms.c: Fix common/ includes.
15404         * mi/mi-parse.h: Fix common/ includes.
15405         * mi/mi-main.c: Fix common/ includes.
15406         * mi/mi-cmd-env.c: Fix common/ includes.
15407         * memrange.h: Fix common/ includes.
15408         * memattr.c: Fix common/ includes.
15409         * maint.h: Fix common/ includes.
15410         * maint.c: Fix common/ includes.
15411         * main.c: Fix common/ includes.
15412         * machoread.c: Fix common/ includes.
15413         * location.c: Fix common/ includes.
15414         * linux-thread-db.c: Fix common/ includes.
15415         * linux-nat.c: Fix common/ includes.
15416         * linux-fork.c: Fix common/ includes.
15417         * inline-frame.c: Fix common/ includes.
15418         * infrun.c: Fix common/ includes.
15419         * inflow.c: Fix common/ includes.
15420         * inferior.h: Fix common/ includes.
15421         * inferior.c: Fix common/ includes.
15422         * infcmd.c: Fix common/ includes.
15423         * inf-ptrace.c: Fix common/ includes.
15424         * inf-child.c: Fix common/ includes.
15425         * ia64-linux-nat.c: Fix common/ includes.
15426         * i387-tdep.c: Fix common/ includes.
15427         * i386-tdep.c: Fix common/ includes.
15428         * i386-linux-tdep.c: Fix common/ includes.
15429         * i386-linux-nat.c: Fix common/ includes.
15430         * i386-go32-tdep.c: Fix common/ includes.
15431         * i386-fbsd-tdep.c: Fix common/ includes.
15432         * i386-fbsd-nat.c: Fix common/ includes.
15433         * guile/scm-type.c: Fix common/ includes.
15434         * guile/guile.c: Fix common/ includes.
15435         * go32-nat.c: Fix common/ includes.
15436         * gnu-nat.c: Fix common/ includes.
15437         * gdbthread.h: Fix common/ includes.
15438         * gdbarch-selftests.c: Fix common/ includes.
15439         * gdb_usleep.c: Fix common/ includes.
15440         * gdb_select.h: Fix common/ includes.
15441         * gdb_bfd.c: Fix common/ includes.
15442         * gcore.c: Fix common/ includes.
15443         * fork-child.c: Fix common/ includes.
15444         * findvar.c: Fix common/ includes.
15445         * fbsd-nat.c: Fix common/ includes.
15446         * event-top.c: Fix common/ includes.
15447         * event-loop.c: Fix common/ includes.
15448         * dwarf2read.c: Fix common/ includes.
15449         * dwarf2loc.c: Fix common/ includes.
15450         * dwarf2-frame.c: Fix common/ includes.
15451         * dwarf-index-cache.c: Fix common/ includes.
15452         * dtrace-probe.c: Fix common/ includes.
15453         * disasm-selftests.c: Fix common/ includes.
15454         * defs.h: Fix common/ includes.
15455         * csky-tdep.c: Fix common/ includes.
15456         * cp-valprint.c: Fix common/ includes.
15457         * cp-support.h: Fix common/ includes.
15458         * cp-support.c: Fix common/ includes.
15459         * corelow.c: Fix common/ includes.
15460         * completer.h: Fix common/ includes.
15461         * completer.c: Fix common/ includes.
15462         * compile/compile.c: Fix common/ includes.
15463         * compile/compile-loc2c.c: Fix common/ includes.
15464         * compile/compile-cplus-types.c: Fix common/ includes.
15465         * compile/compile-cplus-symbols.c: Fix common/ includes.
15466         * command.h: Fix common/ includes.
15467         * cli/cli-dump.c: Fix common/ includes.
15468         * cli/cli-cmds.c: Fix common/ includes.
15469         * charset.c: Fix common/ includes.
15470         * build-id.c: Fix common/ includes.
15471         * btrace.h: Fix common/ includes.
15472         * btrace.c: Fix common/ includes.
15473         * breakpoint.h: Fix common/ includes.
15474         * breakpoint.c: Fix common/ includes.
15475         * ax.h:
15476         (enum agent_op): Fix common/ includes.
15477         * ax-general.c (struct aop_map): Fix common/ includes.
15478         * ax-gdb.c: Fix common/ includes.
15479         * auxv.c: Fix common/ includes.
15480         * auto-load.c: Fix common/ includes.
15481         * arm-tdep.c: Fix common/ includes.
15482         * arch/riscv.c: Fix common/ includes.
15483         * arch/ppc-linux-common.c: Fix common/ includes.
15484         * arch/i386.c: Fix common/ includes.
15485         * arch/arm.c: Fix common/ includes.
15486         * arch/arm-linux.c: Fix common/ includes.
15487         * arch/arm-get-next-pcs.c: Fix common/ includes.
15488         * arch/amd64.c: Fix common/ includes.
15489         * arch/aarch64.c: Fix common/ includes.
15490         * arch/aarch64-insn.c: Fix common/ includes.
15491         * arch-utils.c: Fix common/ includes.
15492         * amd64-windows-tdep.c: Fix common/ includes.
15493         * amd64-tdep.c: Fix common/ includes.
15494         * amd64-sol2-tdep.c: Fix common/ includes.
15495         * amd64-obsd-tdep.c: Fix common/ includes.
15496         * amd64-nbsd-tdep.c: Fix common/ includes.
15497         * amd64-linux-tdep.c: Fix common/ includes.
15498         * amd64-linux-nat.c: Fix common/ includes.
15499         * amd64-fbsd-tdep.c: Fix common/ includes.
15500         * amd64-fbsd-nat.c: Fix common/ includes.
15501         * amd64-dicos-tdep.c: Fix common/ includes.
15502         * amd64-darwin-tdep.c: Fix common/ includes.
15503         * agent.c: Fix common/ includes.
15504         * ada-lang.h: Fix common/ includes.
15505         * ada-lang.c: Fix common/ includes.
15506         * aarch64-tdep.c: Fix common/ includes.
15507
15508 2019-01-25  Tom Tromey  <tom@tromey.com>
15509
15510         * common/create-version.sh: Use common/version.h.
15511
15512 2019-01-24  Pedro Alves  <palves@redhat.com>
15513
15514         * infrun.c (signal_stop, signal_print, signal_program)
15515         (signal_catch, signal_pass): Now arrays instead of pointers.
15516         (update_signals_program_target, do_target_resume)
15517         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
15518         * linux-nat.c (linux_nat_target::pass_signals)
15519         (linux_nat_target::create_inferior, linux_nat_target::attach):
15520         Adjust.
15521         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
15522         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
15523         * procfs.c (procfs_target::pass_signals): Adjust.
15524         * record-full.c (record_full_target::resume): Adjust.
15525         * remote.c (remote_target::pass_signals)
15526         (remote_target::program_signals): Adjust.
15527         * target-debug.h (target_debug_print_signals): Now takes a
15528         gdb::array_view as parameter.  Adjust.
15529         * target.h (target_ops) <pass_signals, program_signals>: Replace
15530         pointer and length parameters with gdb::array_view.
15531         (target_pass_signals, target_program_signals): Likewise.
15532         * target-delegates.c: Regenerate.
15533
15534 2019-01-24  Pedro Alves  <palves@redhat.com>
15535
15536         * common/forward-scope-exit.h
15537         (forward_scope_exit::forward_scope_exit): Pass arguments to
15538         m_bind_function directly, instead of creating a std::bind and
15539         copying that.
15540
15541 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
15542
15543         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
15544         for static members.
15545         (pass_in_v_vfp_candidate): Likewise.
15546
15547 2019-01-23  Tom Tromey  <tom@tromey.com>
15548             Pedro Alves  <palves@redhat.com>
15549
15550         * regcache.c (class regcache_invalidator): Remove.
15551         (regcache::raw_write): Use make_scope_exit.
15552
15553 2019-01-23  Tom Tromey  <tom@tromey.com>
15554
15555         * ui-out.h (class ui_out_emit_type): Update comment.
15556
15557 2019-01-23  Tom Tromey  <tom@tromey.com>
15558
15559         * infrun.c (fetch_inferior_event): Update comment.
15560
15561 2019-01-23  Tom Tromey  <tom@tromey.com>
15562             Pedro Alves  <palves@redhat.com>
15563
15564         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
15565         parameter.
15566         (fetch_inferior_event): Use SCOPE_EXIT.
15567
15568
15569 2019-01-23  Tom Tromey  <tom@tromey.com>
15570             Pedro Alves  <palves@redhat.com>
15571
15572         * infrun.c (disable_thread_events): Delete.
15573         (stop_all_threads): Use SCOPE_EXIT.
15574
15575 2019-01-23  Tom Tromey  <tom@tromey.com>
15576             Pedro Alves  <palves@redhat.com>
15577
15578         * symfile.c: Include forward-scope-exit.h.
15579         (clear_symtab_users_cleanup): Replace forward declaration with
15580         a FORWARD_SCOPE_EXIT.
15581         (syms_from_objfile_1): Use the forward_scope_exit and
15582         gdb::optional instead of cleanup_function.
15583         (reread_symbols): Use the forward_scope_exit instead of
15584         cleanup_function.
15585         (clear_symtab_users_cleanup): Remove function.
15586
15587 2019-01-23  Tom Tromey  <tom@tromey.com>
15588             Pedro Alves  <palves@redhat.com>
15589
15590         * linux-nat.c: Include scope-exit.h.
15591         (cleanup_target_stop): Remove.
15592         (linux_nat_target::static_tracepoint_markers_by_strid): Use
15593         SCOPE_EXIT.
15594
15595 2019-01-23  Tom Tromey  <tom@tromey.com>
15596             Pedro Alves  <palves@redhat.com>
15597
15598         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
15599         (call_function_by_hand_dummy): Use SCOPE_EXIT.
15600
15601 2019-01-23  Tom Tromey  <tom@tromey.com>
15602             Andrew Burgess  <andrew.burgess@embecosm.com>
15603             Pedro Alves  <palves@redhat.com>
15604
15605         * infrun.c (fetch_inferior_event): Use scope_exit.
15606         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
15607         * top.c (execute_command): Use scope_exit.
15608         * breakpoint.c (bpstat_do_actions): Use scope_exit.
15609         * utils.c (do_bpstat_clear_actions_cleanup)
15610         (make_bpstat_clear_actions_cleanup): Remove.
15611
15612 2019-01-23  Tom Tromey  <tom@tromey.com>
15613             Pedro Alves  <palves@redhat.com>
15614
15615         * infrun.c: Include "common/scope-exit.h"
15616         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
15617         (wait_for_inferior): Use SCOPE_EXIT.
15618         (fetch_inferior_event): Use scope_exit.
15619
15620 2019-01-23  Tom Tromey  <tom@tromey.com>
15621             Pedro Alves  <palves@redhat.com>
15622
15623         * breakpoint.c (create_breakpoint): Remove cleanup.
15624
15625 2019-01-23  Tom Tromey  <tom@tromey.com>
15626             Andrew Burgess  <andrew.burgess@embecosm.com>
15627             Pedro Alves  <palves@redhat.com>
15628
15629 2019-01-23  Pedro Alves  <palves@redhat.com>
15630
15631         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
15632
15633 2019-01-23  Pedro Alves  <palves@redhat.com>
15634             Andrew Burgess  <andrew.burgess@embecosm.com>
15635
15636         * gdbthread.h: Include "common/forward-scope-exit.h".
15637         (scoped_finish_thread_state): Redefine custom class in terms of
15638         forward_scope_exit.
15639
15640 2019-01-23  Pedro Alves  <palves@redhat.com>
15641             Andrew Burgess  <andrew.burgess@embecosm.com>
15642
15643         * common/forward-scope-exit.h: New file.
15644
15645 2019-01-23  Pedro Alves  <palves@redhat.com>
15646             Andrew Burgess  <andrew.burgess@embecosm.com>
15647             Tom Tromey  <tom@tromey.com>
15648
15649         * common/scope-exit.h: New file.
15650
15651 2019-01-23  Pedro Alves  <palves@redhat.com>
15652
15653         * common/preprocessor.h (ESC): Rename to ...
15654         (ESC_PARENS): ... this.
15655         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
15656         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
15657
15658 2019-01-23  Tom Tromey  <tom@tromey.com>
15659
15660         * language.h (class scoped_switch_to_sym_language_if_auto):
15661         Initialize m_lang in both cases.
15662
15663 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
15664
15665         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
15666         with XCNEW.
15667
15668 2019-01-22  Tom Tromey  <tom@tromey.com>
15669
15670         * corelow.c: Do not include sys/file.h.
15671
15672 2019-01-22  Tom Tromey  <tom@tromey.com>
15673
15674         * tui/tui-wingeneral.h: Include gdb_curses.h.
15675
15676 2019-01-22  Tom Tromey  <tom@tromey.com>
15677
15678         * source-cache.h (class source_cache) <get_source_lines,
15679         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
15680
15681 2019-01-22  Tom Tromey  <tom@tromey.com>
15682
15683         * remote-fileio.h (struct remote_target): Declare.
15684
15685 2019-01-22  Tom Tromey  <tom@tromey.com>
15686
15687         * python/py-arch.c: Do not include py-ref.h.
15688         * python/py-bpevent.c: Do not include py-ref.h.
15689         * python/py-cmd.c: Do not include py-ref.h.
15690         * python/py-continueevent.c: Do not include py-ref.h.
15691         * python/py-event.h: Do not include py-ref.h.
15692         * python/py-evtregistry.c: Do not include py-ref.h.
15693         * python/py-finishbreakpoint.c: Do not include py-ref.h.
15694         * python/py-frame.c: Do not include py-ref.h.
15695         * python/py-framefilter.c: Do not include py-ref.h.
15696         * python/py-function.c: Do not include py-ref.h.
15697         * python/py-infevents.c: Do not include py-ref.h.
15698         * python/py-linetable.c: Do not include py-ref.h.
15699         * python/py-objfile.c: Do not include py-ref.h.
15700         * python/py-param.c: Do not include py-ref.h.
15701         * python/py-prettyprint.c: Do not include py-ref.h.
15702         * python/py-progspace.c: Do not include py-ref.h.
15703         * python/py-symbol.c: Do not include py-ref.h.
15704         * python/py-symtab.c: Do not include py-ref.h.
15705         * python/py-type.c: Do not include py-ref.h.
15706         * python/py-unwind.c: Do not include py-ref.h.
15707         * python/py-utils.c: Do not include py-ref.h.
15708         * python/py-value.c: Do not include py-ref.h.
15709         * python/py-varobj.c: Do not include py-ref.h.
15710         * python/py-xmethods.c: Do not include py-ref.h.
15711         * python/python.c: Do not include py-ref.h.
15712         * varobj.c: Do not include py-ref.h.
15713
15714 2019-01-22  Tom Tromey  <tom@tromey.com>
15715
15716         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
15717         keyword for bcache.
15718
15719 2019-01-22  Tom Tromey  <tom@tromey.com>
15720
15721         * compile/compile-cplus-types.c: Remove a comment by #include.
15722
15723 2019-01-22  Tom Tromey  <tom@tromey.com>
15724
15725         * compile/gcc-c-plugin.h: Include compile-internal.h.
15726
15727 2019-01-22  Tom Tromey  <tom@tromey.com>
15728
15729         * stabsread.c (EXTERN): Do not define.
15730         (symnum, next_symbol_text_func, processing_gcc_compilation)
15731         (within_function, global_sym_chain, global_stabs)
15732         (previous_stab_code, this_object_header_files)
15733         (n_this_object_header_files)
15734         (n_allocated_this_object_header_files): Define.
15735         * stabsread.h (EXTERN): Never define.  Use "extern".
15736
15737 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
15738
15739         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
15740         history_value.
15741
15742 2019-01-21  Tom Tromey  <tom@tromey.com>
15743
15744         * ui-out.c: Fix includes.
15745         * tui/tui-source.c: Fix includes.
15746         * target.c: Fix includes.
15747         * remote.c: Fix includes.
15748         * regcache.c: Fix includes.
15749         * python/py-block.c: Fix includes.
15750         * printcmd.c: Fix includes.
15751         * or1k-tdep.c: Fix includes.
15752         * mi/mi-main.c: Fix includes.
15753         * m32r-tdep.c: Fix includes.
15754         * csky-tdep.c: Fix includes.
15755         * compile/compile-cplus-types.c: Fix includes.
15756         * cli/cli-interp.c: Fix includes.
15757
15758 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
15759
15760         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
15761         for padding.
15762
15763 2019-01-16  Tom Tromey  <tom@tromey.com>
15764
15765         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
15766         earlier.
15767         (struct objfile) <msymbols_range>: Move from top level.
15768         <msymbols>: New method.
15769         (class objfile_msymbols): Remove.
15770         * symtab.c (default_collect_symbol_completion_matches_break_on):
15771         Update.
15772         * symmisc.c (dump_msymbols): Update.
15773         * stabsread.c (scan_file_globals): Update.
15774         * objc-lang.c (info_selectors_command, info_classes_command)
15775         (find_methods): Update.
15776         * minsyms.c (find_solib_trampoline_target): Update.
15777         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
15778         * coffread.c (coff_symfile_read): Update.
15779         * ada-lang.c (ada_lookup_simple_minsym)
15780         (ada_collect_symbol_completion_matches): Update.
15781
15782 2019-01-16  Tom Tromey  <tom@tromey.com>
15783
15784         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
15785         type.  Remove no-argument constructor.
15786         <iterator::operator++>: Simplify.
15787         <begin>: Update.
15788         <end>: Use minimal_symbol_count.
15789
15790 2019-01-16  Tom Tromey  <tom@tromey.com>
15791
15792         * objfiles.h (struct objfile) <psymtabs>: New method.
15793         (class objfile_psymtabs): Remove.
15794         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
15795         typedef.
15796         <range>: New method.
15797         (require_partial_symbols): Change return type.
15798         * psymtab.c (require_partial_symbols)
15799         (psym_expand_symtabs_matching): Update.
15800         * mdebugread.c (parse_partial_symbols): Update.
15801         * dbxread.c (dbx_end_psymtab): Update.
15802
15803 2019-01-15  Tom Tromey  <tom@tromey.com>
15804
15805         * symtab.c (lookup_objfile_from_block)
15806         (lookup_symbol_in_objfile_symtabs)
15807         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
15808         (find_line_symtab, info_sources_command)
15809         (default_collect_symbol_completion_matches_break_on)
15810         (make_source_files_completion_list): Update.
15811         * symmisc.c (print_objfile_statistics, dump_objfile)
15812         (maintenance_print_symbols, maintenance_info_symtabs)
15813         (maintenance_check_symtabs, maintenance_info_line_tables):
15814         Update.
15815         * source.c (select_source_symtab)
15816         (forget_cached_source_info_for_objfile): Update.
15817         * objfiles.h (class objfile_compunits): Remove.
15818         (struct objfile) <compunits_range>: New typedef.
15819         (compunits): New method.
15820         * objfiles.c (objfile_relocate1): Update.
15821         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
15822         * maint.c (count_symtabs_and_blocks): Update.
15823         * linespec.c (iterate_over_all_matching_symtabs): Update.
15824         * cp-support.c (add_symbol_overload_list_qualified): Update.
15825         * coffread.c (coff_symtab_read): Update.
15826         * ada-lang.c (add_nonlocal_symbols)
15827         (ada_collect_symbol_completion_matches)
15828         (ada_add_global_exceptions): Update.
15829
15830 2019-01-15  Tom Tromey  <tom@tromey.com>
15831
15832         * progspace.h (program_space) <objfiles_safe_range>: New
15833         typedef.
15834         <objfiles_safe>: New method.
15835         * objfiles.h (class all_objfiles_safe): Remove.
15836         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
15837         * jit.c (jit_inferior_exit_hook): Update.
15838
15839 2019-01-17  Tom Tromey  <tom@tromey.com>
15840
15841         * progspace.h (program_space) <objfiles_range>: New typedef.
15842         <objfiles>: New method.
15843         <objfiles_head>: Rename from objfiles.
15844         (object_files): Update.
15845         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
15846         * guile/scm-pretty-print.c
15847         (ppscm_find_pretty_printer_from_objfiles): Update.
15848         * guile/scm-objfile.c (gdbscm_objfiles): Update.
15849         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
15850         Update.
15851         * python/py-progspace.c (pspy_get_objfiles): Update.
15852         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
15853         Update.
15854         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
15855         (objfpy_lookup_objfile_by_build_id): Update.
15856         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
15857         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
15858         Update.
15859         * symtab.c (iterate_over_symtabs, matching_obj_sections)
15860         (expand_symtab_containing_pc, lookup_objfile_from_block)
15861         (lookup_static_symbol, basic_lookup_transparent_type)
15862         (find_pc_sect_compunit_symtab, find_symbol_at_address)
15863         (find_line_symtab, info_sources_command)
15864         (default_collect_symbol_completion_matches_break_on)
15865         (make_source_files_completion_list, find_main_name): Update.
15866         * symmisc.c (print_symbol_bcache_statistics)
15867         (print_objfile_statistics, maintenance_print_symbols)
15868         (maintenance_print_msymbols, maintenance_print_objfiles)
15869         (maintenance_info_symtabs, maintenance_check_symtabs)
15870         (maintenance_expand_symtabs, maintenance_info_line_tables):
15871         Update.
15872         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
15873         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
15874         (map_overlay_command, unmap_overlay_command)
15875         (simple_overlay_update, expand_symtabs_matching)
15876         (map_symbol_filenames): Update.
15877         * symfile-debug.c (set_debug_symfile): Update.
15878         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
15879         Update.
15880         * source.c (select_source_symtab, forget_cached_source_info):
15881         Update.
15882         * solib.c (solib_read_symbols): Update.
15883         * solib-spu.c (append_ocl_sos): Update.
15884         * psymtab.c (maintenance_print_psymbols)
15885         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
15886         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
15887         * printcmd.c (info_symbol_command): Update.
15888         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
15889         Update.
15890         * objfiles.h (class all_objfiles): Remove.
15891         * objfiles.c (have_partial_symbols, have_full_symbols)
15892         (have_minimal_symbols, qsort_cmp, update_section_map)
15893         (shared_objfile_contains_address_p)
15894         (default_iterate_over_objfiles_in_search_order): Update.
15895         * objc-lang.c (info_selectors_command, info_classes_command)
15896         (find_methods): Update.
15897         * minsyms.c (find_solib_trampoline_target): Update.
15898         * maint.c (maintenance_info_sections)
15899         (maintenance_translate_address, count_symtabs_and_blocks):
15900         Update.
15901         * main.c (captured_main_1): Update.
15902         * linux-thread-db.c (try_thread_db_load_from_pdir)
15903         (has_libpthread): Update.
15904         * linespec.c (iterate_over_all_matching_symtabs)
15905         (search_minsyms_for_name): Update.
15906         * jit.c (jit_find_objf_with_entry_addr): Update.
15907         * hppa-tdep.c (find_unwind_entry)
15908         (hppa_lookup_stub_minimal_symbol): Update.
15909         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
15910         Update.
15911         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
15912         (elf_gnu_ifunc_resolve_by_got): Update.
15913         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
15914         * dwarf-index-write.c (save_gdb_index_command): Update.
15915         * cp-support.c (add_symbol_overload_list_qualified): Update.
15916         * breakpoint.c (create_overlay_event_breakpoint)
15917         (create_longjmp_master_breakpoint)
15918         (create_std_terminate_master_breakpoint)
15919         (create_exception_master_breakpoint): Update.
15920         * blockframe.c (find_pc_partial_function): Update.
15921         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
15922         (ada_collect_symbol_completion_matches)
15923         (ada_add_global_exceptions): Update.
15924
15925 2019-01-17  Tom Tromey  <tom@tromey.com>
15926
15927         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
15928         declare VEC.
15929         (solib_target_parse_libraries): Change return type.
15930         (library_list_start_segment, library_list_start_section)
15931         (library_list_end_library, library_list_start_library); Update.
15932         (solib_target_free_library_list): Remove.
15933         (solib_target_parse_libraries): Remove cleanup.  Change return
15934         type.
15935         (solib_target_current_sos): Update.
15936
15937 2019-01-17  Tom Tromey  <tromey@bapiya>
15938
15939         * valprint.c: Replace "the the" with "the".
15940         * symtab.c: Replace "the the" with "the".
15941         * solib.c: Replace "the the" with "the".
15942         * solib-dsbt.c: Replace "the the" with "the".
15943         * linespec.c: Replace "the the" with "the".
15944         * dwarf2loc.h: Replace "the the" with "the".
15945         * amd64-windows-tdep.c: Replace "the the" with "the".
15946         * aarch64-tdep.c: Replace "the the" with "the".
15947
15948 2019-01-16  Keith Seitz  <keiths@redhat.com>
15949
15950         PR gdb/23773
15951         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
15952         <builder>: Rename to ..
15953         <m_builder>: ... this and make private.
15954         (dwarf2_cu::get_builder): New method.  Change all users of
15955         `builder' to use this method.
15956         (dwarf2_start_symtab): Move to ...
15957         (dwarf2_cu::start_symtab): ... here.  Update all callers
15958         (setup_type_unit_groups): Move to ...
15959         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
15960         callers.
15961         (dwarf2_cu::reset_builder): New method.
15962         (process_full_compunit, process_full_type_unit): Use
15963         dwarf2_cu::reset_builder.
15964         (follow_die_offset): Record the ancestor CU if it is different
15965         from the followed DIE's CU.
15966         (follow_die_sig_1): Likewise.
15967
15968 2019-01-15  Tom Tromey  <tom@tromey.com>
15969
15970         * remote.c (class remote_state) <buf>: Now a char_vector.
15971         <buf_size>: Remove.
15972         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
15973         parameter.
15974         (remote_target::getpkt_or_notif_sane_1)
15975         (remote_target::getpkt_sane)
15976         (remote_target::getpkt_or_notif_sane): Likewise.
15977         (class remote_target) <putpkt>: New overload.
15978         (remote_target::read_frame): Change type of "buf_p".  Remove
15979         sizeof_p parameter.
15980         (packet_ok): New overload.
15981         (packet_check_result): New overload.
15982         Update all uses.
15983
15984 2019-01-14  Tom Tromey  <tom@tromey.com>
15985
15986         * remote-notif.c (handle_notification, remote_notif_ack)
15987         (remote_notif_parse): Make "buf" const.
15988         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
15989         const.
15990         (remote_notif_parse, remote_notif_ack, handle_notification):
15991         Likewise.
15992         * remote.c (remote_notif_stop_parse): Make "buf" const.
15993         (remote_target::remote_parse_stop_reply): Make "buf" const.
15994         (remote_notif_stop_ack): Make "buf" const.
15995
15996 2019-01-14  Tom Tromey  <tom@tromey.com>
15997
15998         * remote.c (remote_console_output): Make parameter const.
15999
16000 2019-01-14  Tom Tromey  <tom@tromey.com>
16001
16002         * target-debug.h (target_debug_print_signals): Constify.
16003         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
16004         * procfs.c (procfs_target::pass_signals): Update.
16005         * linux-nat.c (linux_nat_target::pass_signals): Update.
16006         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
16007         * target-delegates.c: Rebuild.
16008         * remote.c (remote_target::program_signals): Update.
16009         (remote_target::pass_signals): Update.
16010         * target.c (target_pass_signals): Constify argument.
16011         (target_program_signals): Likewise.
16012         * target.h (struct target_ops) <pass_signals, program_signals>:
16013         Constify argument.
16014         (target_pass_signals, target_program_signals): Constify argument.
16015
16016 2019-01-14  Tom Tromey  <tom@tromey.com>
16017
16018         PR tui/28819:
16019         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
16020
16021 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
16022
16023         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
16024         field.
16025         * rs6000-tdep.c: Include reggroups.h.
16026         (IS_V_ALIAS_PSEUDOREG): Define.
16027         (rs6000_register_name): Return names for the "vX" aliases.
16028         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
16029         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
16030         aliases.  Call default_register_reggroup_p for all other
16031         pseudo-registers.
16032         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
16033         New functions.
16034         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
16035         Handle "vX" aliases.
16036         (v_alias_pseudo_register_collect): New function.
16037         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
16038         (rs6000_gdbarch_init): Initialize "vX" aliases as
16039         pseudo-registers.  Restore registration of
16040         rs6000_pseudo_register_reggroup_p with
16041         set_tdesc_pseudo_register_reggroup_p.
16042
16043 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
16044
16045         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
16046         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
16047         set_gdbarch_num_pseudo_regs.
16048
16049 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
16050
16051         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
16052         Remove arg prefixname, add do_set and do_show.
16053         Add member functions set_list and show_list.
16054         * cli/cli-style.c (class cli_style_option): Update accordingly.
16055         (style_set_list): Move to file scope.
16056         (style_show_list): Likewise.
16057         (set_style): Call help_list.
16058         (show_style): Call cmd_show_list.
16059         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
16060         Update to use the new macro.
16061
16062 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
16063
16064         * ada-lang.c (_initialize_ada_language): Expand the help text
16065         for the "catch exception" command.
16066
16067 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
16068
16069         * symtab.c (matching_obj_sections): Initialize obj,
16070         declare it closer to its usage.
16071
16072 2019-01-10  Tom Tromey  <tom@tromey.com>
16073
16074         * thread-iter.h (inf_threads_iterator): Use next_iterator.
16075         (basic_inf_threads_range): Remove.
16076         (inf_threads_range, inf_non_exited_threads_range)
16077         (safe_inf_threads_range): Use next_adapter.
16078
16079 2019-01-10  Keith Seitz  <keiths@redhat.com>
16080
16081         PR gdb/23712
16082         PR symtab/23010
16083         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
16084         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
16085
16086 2019-01-10  Keith Seitz  <keiths@redhat.com>
16087
16088         PR gdb/23712
16089         PR symtab/23010
16090         * dictionary.c (pending_to_vector): Remove.
16091         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
16092         Remove _1 suffix, replacing functions of the same name.  Update
16093         all callers.
16094         (dict_create_hashed, dict_create_hashed_expandable)
16095         (dict_create_linear, dict_create_linear_expandable, dict_free)
16096         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
16097         Make functions static.
16098
16099 2019-01-10  Keith Seitz  <keiths@redhat.com>
16100
16101         PR gdb/23712
16102         PR symtab/23010
16103         * dictionary.h (struct dictionary): Replace declaration with
16104         multidictionary.
16105         (dict_create_hashed, dict_create_hashed_expandable)
16106         (dict_create_linear, dict_create_linear_expandable)
16107         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
16108         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
16109         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
16110         taking multidictionary argument.
16111         [ALL_DICT_SYMBOLS]: Update for multidictionary.
16112         * block.h (struct block) <dict>: Change to multidictionary
16113         and rename `multidict'.
16114         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
16115         symmisc.c: Update all dictionary references to multidictionary.
16116
16117 2019-01-10  Keith Seitz  <keiths@redhat.com>
16118
16119         PR gdb/23712
16120         PR symtab/23010
16121         * dictionary.c: Include unordered_map.
16122         (pending_to_vector): New function.
16123         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
16124         Rewrite the non-"_1" functions to take vector instead
16125         of linked list.
16126         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
16127         "new" _1 versions of the same name.
16128         (multidictionary): Define.
16129         (std::hash<enum language): New definition.
16130         (collate_pending_symbols_by_language, mdict_create_hashed)
16131         (mdict_create_hashed_expandable, mdict_create_linear)
16132         (mdict_create_linear_expandable, mdict_free)
16133         (find_language_dictionary, create_new_language_dictionary)
16134         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
16135         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
16136         (mdict_size, mdict_empty): New functions.
16137         * dictionary.h (mdict_iterator): Define.
16138
16139 2019-01-10  Pedro Alves  <palves@redhat.com>
16140
16141         * breakpoint.c (read_uploaded_action)
16142         (create_tracepoint_from_upload): Adjust to use
16143         gdb::unique_xmalloc_ptr.
16144         * ctf.c (ctf_write_uploaded_tp):
16145         (SET_ARRAY_FIELD): Use emplace_back.
16146         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
16147         * tracefile-tfile.c (tfile_write_uploaded_tp):
16148         * tracepoint.c (parse_tracepoint_definition): Adjust to use
16149         gdb::unique_xmalloc_ptr.
16150         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
16151         at_string, cond_string, cmd_strings>: Replace char pointers
16152         with gdb::unique_xmalloc_ptr.
16153
16154 2019-01-10  Pedro Alves  <palves@redhat.com>
16155
16156         * solib-target.c (library_list_start_library): Don't xstrdup name.
16157
16158 2019-01-10  Pedro Alves  <palves@redhat.com>
16159
16160         * mdebugread.c (parse_partial_symbols): Use
16161         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
16162
16163 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
16164
16165         * linux-fork.c (scoped_switch_fork_info)
16166         <~scoped_switch_fork_info>: Fix incorrect variable name.
16167
16168 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
16169
16170         * linux-fork.c (scoped_switch_fork_info)
16171         <scoped_switch_fork_info>: Make explicit.
16172         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
16173
16174 2019-01-10  Tom Tromey  <tom@tromey.com>
16175
16176         * objfiles.h (objfile::reset_psymtabs): Update.
16177         * objfiles.c (objfile::objfile): Update.
16178         * psymtab.h (psymtab_storage::obstack): Update.
16179         (psymtab_storage::m_obstack): Use gdb::optional.
16180         (class psymtab_storage): Update comment.  Remove objfile
16181         parameter.
16182         * psymtab.c (psymtab_storage::psymtab_storage): Update.
16183
16184 2019-01-10  Tom Tromey  <tom@tromey.com>
16185
16186         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
16187         <free_psymtabs>: Now private.
16188         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
16189         (allocate_psymtab): Use new method.
16190
16191 2019-01-10  Tom Tromey  <tom@tromey.com>
16192
16193         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
16194         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
16195         * mdebugread.c (parse_partial_symbols): Use
16196         allocate_dependencies.
16197         * dwarf2read.c (dwarf2_create_include_psymtab): Use
16198         allocate_dependencies.
16199         (process_psymtab_comp_unit_reader)
16200         (build_type_psymtab_dependencies): Likewise.
16201         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
16202
16203 2019-01-10  Tom Tromey  <tom@tromey.com>
16204
16205         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
16206         PSYMBOL_SET_LANGUAGE.
16207         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
16208
16209 2019-01-10  Tom Tromey  <tom@tromey.com>
16210
16211         * psymtab.h (psymtab_storage::obstack): New method.
16212         <m_obstack>: Rename from obstack; now private.
16213         * psymtab.c (psymtab_storage): Update.
16214         * dwarf2read.c (create_addrmap_from_index)
16215         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
16216         Update.
16217
16218 2019-01-10  Tom Tromey  <tom@tromey.com>
16219
16220         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
16221         * objfiles.h (objfile::reset_psymtabs): New method.
16222
16223 2019-01-10  Tom Tromey  <tom@tromey.com>
16224
16225         * symmisc.c (print_symbol_bcache_statistics): Update.
16226         (print_objfile_statistics): Update.
16227         * symfile.c (reread_symbols): Update.
16228         * psymtab.h (class psymtab_storage): New.
16229         * psymtab.c (psymtab_storage): New constructor.
16230         (~psymtab_storage): New destructor.
16231         (require_partial_symbols): Update.
16232         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
16233         (find_pc_sect_psymtab, find_pc_sect_psymbol)
16234         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
16235         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
16236         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
16237         (start_psymtab_common, end_psymtab_common)
16238         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
16239         (allocate_psymtab): Update.
16240         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
16241         Update.
16242         (dump_psymtab_addrmap, maintenance_print_psymbols)
16243         (maintenance_check_psymtabs): Update.
16244         (class objfile_psymtabs): Move to objfiles.h.
16245         * psympriv.h (discard_psymtab): Now inline.
16246         (psymtab_discarder::psymtab_discarder): Update.
16247         (psymtab_discarder::~psymtab_discarder): Update.
16248         (ALL_OBJFILE_PSYMTABS): Rewrite.
16249         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
16250         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
16251         Remove fields.
16252         <partial_symtabs>: New field.
16253         (class objfile_psymtabs): Move from psymtab.h.  Update.
16254         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
16255         psymbol_cache.
16256         (objfile::~objfile): Don't destroy psymbol_cache.
16257         * mdebugread.c (parse_partial_symbols): Update.
16258         * dwarf2read.c (create_addrmap_from_index)
16259         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
16260         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
16261         (add_partial_subprogram, dwarf2_ranges_read): Update.
16262         * dwarf-index-write.c (write_address_map)
16263         (write_one_signatured_type, recursively_write_psymbols)
16264         (class debug_names, class debug_names, write_psymtabs_to_index):
16265         Update.
16266
16267 2019-01-10  Tom Tromey  <tom@tromey.com>
16268
16269         * symtab.h (SYMBOL_SET_NAMES): Update.
16270         (symbol_set_names): Update.
16271         (MSYMBOL_SET_NAMES): Update.
16272         * symtab.c (symbol_set_names): Change argument to be an
16273         objfile_per_bfd_storage.
16274         * psymtab.c (add_psymbol_to_bcache): Update.
16275         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
16276
16277 2019-01-10  Tom Tromey  <tom@tromey.com>
16278
16279         * symtab.c (create_demangled_names_hash): Change argument to be an
16280         objfile_per_bfd_storage.
16281         (symbol_set_names): Update.
16282
16283 2019-01-10  Tom Tromey  <tom@tromey.com>
16284
16285         * xcoffread.c (xcoff_initial_scan): Unconditionally call
16286         init_psymbol_list.
16287         * psymtab.c (init_psymbol_list): Do nothing if already called.
16288         * psympriv.h (init_psymbol_list): Add comment.
16289         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
16290         init_psymbol_list.
16291         * dbxread.c (dbx_symfile_read): Unconditionally call
16292         init_psymbol_list.
16293
16294 2019-01-10  Tom Tromey  <tom@tromey.com>
16295
16296         * xcoffread.c (scan_xcoff_symtab): Update.
16297         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
16298         "where".
16299         * mdebugread.c (parse_partial_symbols)
16300         (handle_psymbol_enumerators): Update.
16301         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
16302         * dbxread.c (read_dbx_symtab): Update.
16303         * psympriv.h (psymbol_placement): New enum.
16304         (add_psymbol_to_list): Update.
16305
16306 2019-01-10  Tom Tromey  <tom@tromey.com>
16307
16308         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
16309         static_psymbols parameters.
16310         (scan_xcoff_symtab): Update.
16311         * psymtab.c (start_psymtab_common): Remove global_psymbols and
16312         static_psymbols parameters.
16313         * psympriv.h (start_psymtab_common): Update.
16314         * mdebugread.c (parse_partial_symbols): Update.
16315         * dwarf2read.c (create_partial_symtab): Update.
16316         * dbxread.c (read_dbx_symtab): Update.
16317         (start_psymtab): Remove global_psymbols and static_psymbols
16318         parameters.
16319
16320 2019-01-10  Tom Tromey  <tom@tromey.com>
16321
16322         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
16323         * psymtab.c (allocate_psymtab): Add comment.
16324         * psympriv.h (allocate_psymtab): Add comment.
16325         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
16326         initializations.
16327         * dbxread.c (dbx_end_psymtab): Remove some initializations.
16328
16329 2019-01-10  Tom Tromey  <tom@tromey.com>
16330
16331         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
16332         Don't declare.
16333         * mipsread.c: Include mdebugread.h.
16334         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
16335         Declare.
16336         * elfread.c: Include mdebugread.h.
16337
16338 2019-01-09  Tom Tromey  <tom@tromey.com>
16339
16340         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
16341         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
16342         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
16343         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
16344         (psym_lookup_symbol, psym_find_last_source_symtab)
16345         (psym_forget_cached_source_info, psym_print_stats)
16346         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
16347         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
16348         (psym_map_matching_symbols, psym_expand_symtabs_matching)
16349         (psym_find_compunit_symtab_by_address)
16350         (maintenance_print_psymbols, maintenance_info_psymtabs)
16351         (maintenance_check_psymtabs): Use ranged for.
16352         * psymtab.h (class objfile_psymtabs): New.
16353         (require_partial_symbols): Return objfile_psymtabs.
16354         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
16355
16356 2019-01-09  Tom Tromey  <tom@tromey.com>
16357
16358         * symfile.c (overlay_invalidate_all, find_pc_overlay)
16359         (find_pc_mapped_section, list_overlays_command)
16360         (map_overlay_command, unmap_overlay_command)
16361         (simple_overlay_update): Use all_objfiles.
16362         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
16363         * printcmd.c (info_symbol_command): Use all_objfiles.
16364         * objfiles.h (ALL_OBJSECTIONS): Remove.
16365         * maint.c (maintenance_translate_address): Use all_objfiles.
16366         * gcore.c (gcore_create_callback): Use all_objfiles.
16367         (objfile_find_memory_regions): Likewise.
16368
16369 2019-01-09  Tom Tromey  <tom@tromey.com>
16370
16371         * symtab.c (find_line_symtab, info_sources_command)
16372         (make_source_files_completion_list): Use objfile_compunits.
16373         * source.c (select_source_symtab): Use objfile_compunits.
16374         * objfiles.h (struct objfile): Update comment.
16375         (ALL_OBJFILES): Remove.
16376         (ALL_FILETABS): Remove.
16377         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
16378         objfile_compunits.
16379
16380 2019-01-09  Tom Tromey  <tom@tromey.com>
16381
16382         * symmisc.c (print_objfile_statistics, dump_objfile)
16383         (maintenance_print_symbols): Use compunit_filetabs.
16384         * source.c (forget_cached_source_info_for_objfile): Use
16385         compunit_filetabs.
16386         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
16387         (ALL_FILETABS): Use compunit_filetabs.
16388         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
16389         * coffread.c (coff_symtab_read): Use compunit_filetabs.
16390
16391 2019-01-09  Tom Tromey  <tom@tromey.com>
16392
16393         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
16394         (compunit_filetabs): New.
16395         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
16396         compunit_filetabs.
16397         (info_sources_command, make_source_files_completion_list): Remove
16398         declaration.
16399         * symmisc.c (print_objfile_statistics, dump_objfile)
16400         (maintenance_print_symbols): Remove declaration.
16401         (maintenance_info_symtabs): Use compunit_filetabs.
16402         (maintenance_info_line_tables): Likewise.
16403         * source.c (select_source_symtab): Change local variable name.
16404         (forget_cached_source_info_for_objfile): Remove declaration.
16405         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
16406         * objfiles.c (objfile_relocate1): Remove declaration.
16407         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
16408         declaration.
16409         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
16410         * coffread.c (coff_symtab_read): Remove declaration.
16411         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
16412         compunit_filetabs.
16413
16414 2019-01-09  Tom Tromey  <tom@tromey.com>
16415
16416         * symtab.c (lookup_objfile_from_block)
16417         (find_pc_sect_compunit_symtab, search_symbols)
16418         (default_collect_symbol_completion_matches_break_on): Use
16419         objfile_compunits.
16420         * objfiles.h (ALL_COMPUNITS): Remove.
16421         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
16422         * cp-support.c (add_symbol_overload_list_qualified): Use
16423         objfile_compunits.
16424         * ada-lang.c (ada_collect_symbol_completion_matches)
16425         (ada_add_global_exceptions): Use objfile_compunits.
16426
16427 2019-01-09  Tom Tromey  <tom@tromey.com>
16428
16429         * source.c (select_source_symtab)
16430         (forget_cached_source_info_for_objfile): Remove declaration.
16431         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
16432         declaration.
16433         * maint.c (count_symtabs_and_blocks): Remove declaration.
16434         * cp-support.c (add_symbol_overload_list_qualified): Remove
16435         declaration.
16436         * coffread.c (coff_symtab_read): Remove declaration.
16437         * symtab.c (lookup_symbol_in_objfile_symtabs)
16438         (basic_lookup_transparent_type_1): Use objfile_compunits.
16439         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
16440         (info_sources_command, search_symbols)
16441         (default_collect_symbol_completion_matches_break_on)
16442         (make_source_files_completion_list): Remove declaration.
16443         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
16444         (ada_collect_symbol_completion_matches)
16445         (ada_add_global_exceptions): Remove declaration.
16446         * linespec.c (iterate_over_all_matching_symtabs): Use
16447         objfile_compunits.
16448         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
16449         (class objfile_compunits): New.
16450         (ALL_COMPUNITS): Use objfile_compunits.
16451         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
16452         (maintenance_check_symtabs, maintenance_info_line_tables): Use
16453         objfile_compunits.
16454         * objfiles.c (objfile_relocate1): Use objfile_compunits.
16455
16456 2019-01-09  Tom Tromey  <tom@tromey.com>
16457
16458         * symtab.c (search_symbols)
16459         (default_collect_symbol_completion_matches_break_on): Use
16460         objfile_msymbols.
16461         * ada-lang.c (ada_lookup_simple_minsym)
16462         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
16463         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
16464         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
16465         objfile_msymbols.
16466         * coffread.c (coff_symfile_read): Use objfile_msymbols.
16467         * symmisc.c (dump_msymbols): Use objfile_msymbols.
16468         * objc-lang.c (find_methods): Use objfile_msymbols.
16469         (info_selectors_command, info_classes_command): Likewise.
16470         * stabsread.c (scan_file_globals): Use objfile_msymbols.
16471         * objfiles.h (class objfile_msymbols): New.
16472         (ALL_OBJFILE_MSYMBOLS): Remove.
16473         (ALL_MSYMBOLS): Remove.
16474
16475 2019-01-09  Tom Tromey  <tom@tromey.com>
16476
16477         * common/next-iterator.h (next_adapter): Add Iterator template
16478         parameter.
16479         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
16480         (class all_objfiles_safe): New.
16481         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
16482         * objfiles.c (put_objfile_before): Update comment.
16483         (add_separate_debug_objfile): Likewise.
16484         (free_all_objfiles): Use all_objfiles_safe.
16485         (objfile_purge_solibs): Likewise.
16486
16487 2019-01-09  Tom Tromey  <tom@tromey.com>
16488
16489         * symtab.c (iterate_over_symtabs, matching_obj_sections)
16490         (expand_symtab_containing_pc, lookup_static_symbol)
16491         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
16492         (find_symbol_at_address, find_line_symtab, find_main_name): Use
16493         all_objfiles.
16494         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
16495         * breakpoint.c (create_overlay_event_breakpoint)
16496         (create_longjmp_master_breakpoint)
16497         (create_std_terminate_master_breakpoint)
16498         (create_exception_master_breakpoint): Use all_objfiles.
16499         * linux-thread-db.c (try_thread_db_load_from_pdir)
16500         (has_libpthread): Use all_objfiles.
16501         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
16502         * linespec.c (iterate_over_all_matching_symtabs)
16503         (search_minsyms_for_name): Use all_objfiles.
16504         * maint.c (maintenance_info_sections): Use all_objfiles.
16505         * main.c (captured_main_1): Use all_objfiles.
16506         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
16507         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
16508         * guile/scm-pretty-print.c
16509         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
16510         * solib-spu.c (append_ocl_sos): Use all_objfiles.
16511         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
16512         (maintenance_print_msymbols): Use all_objfiles.
16513         * source.c (select_source_symtab): Use all_objfiles.
16514         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
16515         * symfile.c (remove_symbol_file_command)
16516         (expand_symtabs_matching, map_symbol_filenames): Use
16517         all_objfiles.
16518         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
16519         all_objfiles.
16520         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
16521         * objc-lang.c (find_methods): Use all_objfiles.
16522         * objfiles.c (have_partial_symbols, have_full_symbols)
16523         (have_minimal_symbols, qsort_cmp)
16524         (default_iterate_over_objfiles_in_search_order): Use
16525         all_objfiles.
16526         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
16527         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
16528         (maintenance_check_psymtabs): Use all_objfiles.
16529         (ALL_PSYMTABS): Remove.
16530         * compile/compile-object-run.c (do_module_cleanup): Use
16531         all_objfiles.
16532         * blockframe.c (find_pc_partial_function): Use all_objfiles.
16533         * cp-support.c (add_symbol_overload_list_qualified): Use
16534         all_objfiles.
16535         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
16536         Use all_objfiles.
16537         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
16538         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
16539         all_objfiles.
16540         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
16541         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
16542         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
16543         Uses all_objfiles.
16544         * solib.c (solib_read_symbols): Use all_objfiles
16545
16546 2019-01-09  Tom Tromey  <tom@tromey.com>
16547
16548         * probe.c (parse_probes_in_pspace): Use all_objfiles.
16549         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
16550         all_objfiles.
16551         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
16552         * symmisc.c (print_symbol_bcache_statistics)
16553         (print_objfile_statistics, maintenance_print_objfiles)
16554         (maintenance_info_symtabs, maintenance_check_symtabs)
16555         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
16556         all_objfiles.
16557         * source.c (forget_cached_source_info): Use all_objfiles.
16558         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
16559         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
16560         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
16561         * objfiles.c (update_section_map): Use all_objfiles.
16562         (shared_objfile_contains_address_p): Likewise.
16563         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
16564         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
16565
16566 2019-01-09  Tom Tromey  <tom@tromey.com>
16567
16568         * common/next-iterator.h: New file.
16569         * objfiles.h (class all_objfiles): New.
16570         (struct objfile_iterator): New.
16571
16572 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
16573
16574         * NEWS: Move the description of the changed "frame", "select-frame",
16575          and "info frame" commands to the Changed commands section.
16576
16577 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
16578
16579         * gdbtypes.c (check_stub_method_group): Remove handling of old
16580         mangling schemes.
16581         * linespec.c (find_methods): Likewise.
16582         * stabsread.c (read_member_functions): Likewise.
16583         * valops.c (search_struct_method): Likewise.
16584         (value_struct_elt_for_reference): Likewise.
16585         * NEWS: Mention this change.
16586
16587 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
16588
16589         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
16590         print_source_lines.
16591         * source.c (print_source_lines_base): Update line number check.
16592         (print_source_lines): New function.
16593         (source_lines_range::source_lines_range): New function.
16594         * source.h (class source_lines_range): New class.
16595         (print_source_lines): New declaration.
16596
16597 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
16598
16599         * linespec.c (linespec_state_destructor): Free self->canonical_names.
16600
16601 2019-01-08  Tom Tromey  <tom@tromey.com>
16602             Simon Marchi  <simon.marchi@ericsson.com>
16603
16604         PR gdb/24060
16605         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
16606         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
16607         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
16608         * f-exp.y (DOLLAR_VARIABLE): Likewise.
16609         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
16610         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
16611
16612 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
16613
16614         * source.c (select_source_symtab): Move header comment to
16615         declaration in source.h.
16616         (forget_cached_source_info_for_objfile): Likewise.
16617         (forget_cached_source_info): Likewise.
16618         (identify_source_line): Likewise.
16619         * source.h (identify_source_line): Move declaration from symtab.h
16620         and add comment from source.c
16621         (print_source_lines): Likewise.
16622         (forget_cached_source_info_for_objfile): Likewise.
16623         (forget_cached_source_info): Likewise.
16624         (select_source_symtab): Likewise.
16625         (enum print_source_lines_flag): Move definition from symtab.h.
16626         * symtab.h (identify_source_line): Move declaration to source.h.
16627         (print_source_lines): Likewise.
16628         (forget_cached_source_info_for_objfile): Likewise.
16629         (forget_cached_source_info): Likewise.
16630         (select_source_symtab): Likewise.
16631         (enum print_source_lines_flag): Move definition to source.h.
16632         * tui/tui-hooks.c: Add 'source.h' include.
16633
16634 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
16635
16636         * source.c (print_source_lines_base): Handle requests to print
16637         reverse line number sequences, and guard against empty lines
16638         string.
16639
16640 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
16641
16642         * source.c (print_source_lines_base): Fix skip of '\r' if next
16643         character is '\n'.
16644
16645 2019-01-06  Tom Tromey  <tom@tromey.com>
16646
16647         * c-exp.y (struct c_parse_state) <macro_original_text,
16648         expansion_obstack>: New member.
16649         (macro_original_text, expansion_obstack): Remove globals.
16650         (scan_macro_expansion, scanning_macro_expansion)
16651         (finished_macro_expansion): Update.
16652         (scan_macro_cleanup): Remove.
16653         (yylex, c_parse): Update.
16654
16655 2019-01-06  Tom Tromey  <tom@tromey.com>
16656
16657         * c-exp.y (struct c_parse_state) <strings>: New member.
16658         (operator_stoken): Update.
16659
16660 2019-01-06  Tom Tromey  <tom@tromey.com>
16661
16662         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
16663         (union type_stack_elt) <typelist_val>: Now a pointer to
16664         std::vector.
16665         (type_stack_cleanup): Don't declare.
16666         (push_typelist): Update.
16667         * parse.c (pop_typelist): Return a std::vector.
16668         (push_typelist): Take a std::vector.
16669         (follow_types): Update.  Do not free args.
16670         (type_stack_cleanup): Remove.
16671         * c-exp.y (struct c_parse_state): New.
16672         (cpstate): New global.
16673         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
16674         (nonempty_typelist): Update.
16675         (func_mod): Create a new vector.
16676         (c_parse): Create a c_parse_state.
16677         (check_parameter_typelist): Do not delete params.
16678         (function_method): Update.  Do not delete type_list.
16679
16680 2019-01-06  Tom Tromey  <tom@tromey.com>
16681
16682         PR gdb/28155:
16683         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
16684         check_typedef.
16685         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
16686         (print_return_value): Likewise.
16687
16688 2019-01-05  Tom Tromey  <tom@tromey.com>
16689
16690         * contrib/cleanup_check.py: Remove.
16691         * contrib/gcc-with-excheck: Remove.
16692         * contrib/exsummary.py: Remove.
16693         * contrib/excheck.py: Remove.
16694
16695 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
16696
16697         * thread.c (delete_thread_1): Add gdb_assert that THR is not
16698         NULL. Initialize tpprev to NULL instead of assigning it
16699         to NULL on the next statement.
16700         * windows-nat.c (windows_delete_thread): Remove check for
16701         main_thread_id before printing thread exit notifications.
16702         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
16703         Remove thread ID check against main_thread_id.
16704         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
16705         windows_delete_thread.
16706         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
16707
16708 2019-01-04  Tom Tromey  <tom@tromey.com>
16709
16710         * compile/compile.c (_initialize_compile): Use upper case for
16711         metasyntactic variables.
16712         * symmisc.c (_initialize_symmisc): Use upper case for
16713         metasyntactic variables.
16714         * psymtab.c (_initialize_psymtab): Use upper case for
16715         metasyntactic variables.
16716         * demangle.c (demangle_command): Use upper case for metasyntactic
16717         variables.
16718         (_initialize_demangler): Likewise.
16719         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
16720         variables.
16721
16722 2019-01-03  Tom Tromey  <tom@tromey.com>
16723
16724         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
16725
16726 2019-01-03  Tom Tromey  <tom@tromey.com>
16727
16728         * python/py-symtab.c (salpy_str): Update.
16729         (struct salpy_sal_object) <symtab>: Now a PyObject.
16730         (salpy_dealloc): Update.
16731         (del_objfile_sal): Use gdbpy_ref.
16732
16733 2019-01-03  Tom Tromey  <tom@tromey.com>
16734
16735         * python/py-type.c (convert_field): Use new_reference.  Return
16736         gdbpy_ref.
16737         (make_fielditem): Return gdbpy_ref.
16738         (typy_fields): Update.
16739         (typy_getitem): Update.
16740         (field_name): Return gdbpy_ref.  Use new_reference.
16741         (typy_iterator_iternext): Update.
16742
16743 2019-01-03  Tom Tromey  <tom@tromey.com>
16744
16745         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
16746
16747 2019-01-03  Tom Tromey  <tom@tromey.com>
16748
16749         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
16750         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
16751         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
16752         (pspy_set_frame_filters, pspy_set_frame_unwinders)
16753         (pspy_set_type_printers): Likewise.
16754         * python/py-function.c (fnpy_init): Use gdbpy_ref.
16755         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
16756         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
16757         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
16758         (objfpy_set_type_printers): Likewise.
16759
16760 2019-01-03  Tom Tromey  <tom@tromey.com>
16761
16762         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
16763         (gdbpy_print_stack): Use gdbpy_err_fetch.
16764         * python/python-internal.h (class gdbpy_err_fetch): New class.
16765         (class gdbpy_enter) <m_error_type, m_error_value,
16766         m_error_traceback>: Remove.
16767         <m_error>: New member.
16768         (gdbpy_exception_to_string): Don't declare.
16769         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
16770         * python/py-value.c (convert_value_from_python): Use
16771         gdbpy_err_fetch.
16772         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
16773         gdbpy_exception_to_string.
16774         (gdbpy_handle_exception): Use gdbpy_err_fetch.
16775         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
16776         gdbpy_err_fetch.
16777
16778 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
16779
16780         * linux-nat.c (delete_lwp_cleanup): Delete.
16781         (struct lwp_deleter): New struct.
16782         (lwp_info_up): New typedef.
16783         (linux_nat_target::follow_fork): Delete cleanup, and make use of
16784         lwp_info_up.
16785
16786 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
16787
16788         * linux-fork.c (class scoped_switch_fork_info): New class.
16789         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
16790
16791 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
16792
16793         * valops.c (find_overload_match): Remove use of null_cleanup, and
16794         calls to do_cleanups.
16795
16796 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
16797
16798         * compile/compile-cplus-types.c
16799         (compile_cplus_instance::decl_name): Handle changes to
16800         cp_func_name.
16801         * cp-support.c (cp_func_name): Update header comment, update
16802         return type.
16803         * cp-support.h (cp_func_name): Update return type in declaration.
16804         * valops.c (find_overload_match): Move temp_func local to top
16805         level of function and change its type.  Use temp_func to hold and
16806         delete temporary string obtained from cp_func_name.
16807
16808 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
16809
16810         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
16811         gdb::char_vector, remove cleanup, and update uses of `msg`.
16812
16813 2019-01-03  Jim Wilson  <jimw@sifive.com>
16814
16815         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
16816
16817 2019-01-02  Tom Tromey  <tom@tromey.com>
16818
16819         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
16820         (tdesc_parse_xml): Remove cleanups.
16821         * target-descriptions.h (make_cleanup_free_target_description):
16822         Don't declare.
16823         (target_desc_deleter): New struct.
16824         (target_desc_up): New typedef.
16825         * target-descriptions.c (target_desc_deleter::operator()): Rename
16826         from free_target_description.
16827         (make_cleanup_free_target_description): Remove.
16828
16829 2019-01-02  Tom Tromey  <tom@tromey.com>
16830
16831         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
16832         constructor, destructor.
16833         (linespec_parser): Remove typedef.
16834         (~linespec_parser): Rename from linespec_parser_delete.
16835         (linespec_lex_to_end, linespec_complete_label)
16836         (linespec_complete): Update.
16837         (decode_line_full): Remove cleanups.
16838         (decode_line_1): Update.
16839
16840 2019-01-02  Tom Tromey  <tom@tromey.com>
16841
16842         * python/python-internal.h (inferior_to_inferior_object): Change
16843         return type.
16844         * python/py-exitedevent.c (create_exited_event_object): Update.
16845         * python/py-inferior.c (inferior_to_inferior_object): Return
16846         gdbpy_ref.
16847         (python_new_inferior, python_inferior_deleted)
16848         (thread_to_thread_object, delete_thread_object)
16849         (build_inferior_list, gdbpy_selected_inferior): Update.
16850         * python/py-infthread.c (create_thread_object): Update.  Also fail
16851         if inferior_to_inferior_object fails.
16852
16853 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
16854
16855         * inferior.h (class inferior) <displaced_step_state>: New field.
16856         * infrun.h (struct displaced_step_state): Move here from
16857         infrun.c.  Initialize fields, add constructor.
16858         <inf>: Remove field.
16859         <reset>: New method.
16860         * infrun.c (struct displaced_step_inferior_state): Move to
16861         infrun.h.
16862         (displaced_step_inferior_states): Remove.
16863         (get_displaced_stepping_state): Adust.
16864         (displaced_step_in_progress_any_inferior): Adjust.
16865         (displaced_step_in_progress_thread): Adjust.
16866         (displaced_step_in_progress): Adjust.
16867         (add_displaced_stepping_state): Remove.
16868         (get_displaced_step_closure_by_addr): Adjust.
16869         (remove_displaced_stepping_state): Remove.
16870         (infrun_inferior_exit): Call displaced_step_state.reset.
16871         (use_displaced_stepping): Don't check for NULL.
16872         (displaced_step_prepare_throw): Call
16873         get_displaced_stepping_state.
16874         (displaced_step_fixup): Don't check for NULL.
16875         (prepare_for_detach): Don't check for NULL.
16876
16877 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
16878
16879         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
16880          in case of call that did not complete.
16881
16882 2019-01-02  Andrey Utkin  <autkin@undo.io>
16883
16884         * symfile.c (find_separate_debug_file): Fix search of debug files for
16885         remote debuggee.
16886
16887 2019-01-02  Tom Tromey  <tom@tromey.com>
16888
16889         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
16890         indentation.
16891         * python/py-frame.c (frapy_older): Remove cast.
16892         (frapy_newer): Likewise.
16893         * python/py-breakpoint.c (local_setattro): Remove cast.
16894         * python/py-arch.c (archpy_name): Remove local variable.
16895         * python/py-type.c (gdbpy_lookup_type): Remove cast.
16896
16897 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
16898
16899         * unittests/basic_string_view/element_access/char/empty.cc:
16900         Fix year range in copyright header.
16901
16902 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
16903
16904         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
16905         Delete.
16906         <operator==>: Update with for removed field.
16907         <hash>: Likewise.
16908         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
16909         <isa_features>: ...this.
16910         <abi_features>: New field.
16911         (riscv_isa_flen): Update comment.
16912         (riscv_abi_xlen): New declaration.
16913         (riscv_abi_flen): New declaration.
16914         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
16915         isa_features.
16916         (riscv_abi_xlen): New function.
16917         (riscv_isa_flen): Update to get answer from isa_features.
16918         (riscv_abi_flen): New function.
16919         (riscv_has_fp_abi): Update to get answer from abi_features.
16920         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
16921         xlen and flen.
16922         (riscv_call_info) <xlen, flen>: Update comment.
16923         (riscv_call_arg_struct): Remove invalid assertions
16924         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
16925         is removed.
16926         (riscv_gdbarch_init): Gather isa features and abi features
16927         separately, ensure both match on the gdbarch when reusing an old
16928         gdbarch.  Relax an error check to allow 32-bit abi float to run on
16929         a target with 64-bit float hardware.
16930
16931 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
16932
16933         * source.c (search_command_helper): Stop reverse search
16934         when line 1 has been searched.
16935
16936 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
16937
16938         * record-full.c (record_full_base_target::close): Rewrite
16939         record_full_core_buf_list free logic.
16940
16941 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
16942
16943         * break-catch-syscall.c (print_one_catch_syscall): xfree
16944         the last text.
16945
16946 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
16947
16948         * top.c (print_gdb_version): Update Copyright year in version
16949         message.
16950
16951 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
16952
16953         Update copyright year range in all GDB files.
16954
16955 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
16956
16957         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
16958
16959 For older changes see ChangeLog-2018.
16960 \f
16961 Local Variables:
16962 mode: change-log
16963 left-margin: 8
16964 fill-column: 74
16965 version-control: never
16966 coding: utf-8
16967 End:
16968