gdb/ChangeLog

   1 2019-12-17  Simon Marchi  <simon.marchi@polymtl.ca>
   2
   3         * tui/tui-layout.h (class tui_layout_base): Add virtual
   4         destructor.
   5
   6 2019-12-16  Bernd Edlinger  <bernd.edlinger@hotmail.de>
   7
   8         * infcmd.c (prepare_one_step): Step over skipped inline functions.
   9         * infrun.c (inline_frame_is_marked_for_skip): New helper function.
  10         (process_event_stop_test): Keep stepping over skipped inline functions.
  11
  12 2019-12-16  Simon Marchi  <simon.marchi@polymtl.ca>
  13
  14         * jit.c (struct gdb_block) <next>: Remove field.
  15         (struct gdb_symtab) <~gdb_symtab>: Remove.
  16         <blocks>: Change type to std::forward_list<gdb_block>.
  17         (compare_block): Remove.
  18         (jit_block_open_impl): Adjust to std::forward_list.  Place the new
  19         block at the beginning, don't mind about sorting.
  20         (finalize_symtab): Adjust to std::forward_list, sort the blocks list
  21         before using it.
  22
  23 2019-12-16  Simon Marchi  <simon.marchi@polymtl.ca>
  24
  25         * jit.c (struct gdb_block): Add constructor, initialize
  26         real_block and next fields.
  27         <name>: Change type to gdb::unique_xmalloc_ptr.
  28         (struct gdb_symtab) <~gdb_symtab>: Free blocks with delete.
  29         (jit_block_open_impl): Allocate gdb_block with new.
  30         (finalize_symtab): Adjust to gdb::unique_xmalloc_ptr.
  31
  32 2019-12-16  Simon Marchi  <simon.marchi@polymtl.ca>
  33
  34         * jit.c: Include forward_list.
  35         (struct gdb_symtab) <next>: Remove field.
  36         (struct gdb_object) <symtabs>: Change type to
  37         std::forward_list<gdb_symtab>.
  38         (jit_object_open_impl): Allocate gdb_object with new.
  39         (jit_symtab_open_impl): Adjust to std::forward_list.
  40         (finalize_symtab): Don't delete symtab.
  41         (jit_object_close_impl):  Adjust to std::forward_list.  Free
  42         gdb_object with delete.
  43
  44 2019-12-16  Simon Marchi  <simon.marchi@polymtl.ca>
  45
  46         * jit.c (struct gdb_symtab): Add constructor, destructor,
  47         initialize fields.
  48         <linetable>: Change type to unique_xmalloc_ptr.
  49         <file_name>: Change type to std::string.
  50         (jit_symtab_open_impl): Allocate gdb_symtab with new.
  51         (jit_symtab_line_mapping_add_impl): Adjust.
  52         (finalize_symtab): Adjust, call delete on stab.
  53
  54 2019-12-16  Simon Marchi  <simon.marchi@polymtl.ca>
  55
  56         * jit.c (finalize_symtab): Set gdb_block_iter_tmp in loop.
  57
  58 2019-12-16  Tom Tromey  <tromey@adacore.com>
  59
  60         * windows-nat.c (windows_nat_target::attach): Update.
  61         * remote.c (extended_remote_target::attach): Update.
  62         * procfs.c (procfs_target::attach): Update.
  63         * nto-procfs.c (nto_procfs_target::attach): Update.
  64         (nto_procfs_target::create_inferior): Update.
  65         * inf-ptrace.c (inf_ptrace_target::attach): Update.
  66         * gnu-nat.c (gnu_nat_target::attach): Update.
  67         (gnu_nat_target::detach): Update.
  68         * darwin-nat.c (darwin_nat_target::attach): Update.
  69         * corefile.c (get_exec_file): Constify result.  Remove extraneous
  70         return.
  71         * bsd-kvm.c (bsd_kvm_target_open): Update.
  72         * gdbsupport/common-inferior.h (get_exec_file): Constify result.
  73
  74 2019-12-16  Christian Biesinger  <cbiesinger@google.com>
  75
  76         * gdbsupport/common-defs.h: Remove workaround for a gnulib bug
  77         (we no longer need to include time.h before pathmax.h)
  78
  79 2019-12-15  Christian Biesinger  <cbiesinger@google.com>
  80
  81         * ada-exp.y (write_ambiguous_var): Update.
  82         * coffread.c (process_coff_symbol): Update.
  83         * ctfread.c (ctf_add_enum_member_cb): Update.
  84         (new_symbol): Update.
  85         * dwarf2read.c (fixup_go_packaging): Update.
  86         (new_symbol): Update.
  87         * language.c (language_alloc_type_symbol): Update.
  88         * mdebugread.c (new_symbol): Update.
  89         * minsyms.c (minimal_symbol_reader::record_full): Update.
  90         * psymtab.c (add_psymbol_to_bcache): Update.
  91         * stabsread.c (define_symbol): Update.
  92         (read_enum_type): Update.
  93         * symtab.c (symbol_set_language): Make this a member function...
  94         (general_symbol_info::set_language): ... here.
  95         * symtab.h (struct general_symbol_info) <set_language>: New function.
  96         (SYMBOL_SET_LANGUAGE): Remove.
  97         (symbol_set_language): Remove.
  98
  99 2019-12-15  Christian Biesinger  <cbiesinger@google.com>
 100
 101         * ada-lang.c (ada_add_block_symbols): Update.
 102         (ada_collect_symbol_completion_matches): Update.
 103         * ax-gdb.c (gen_expr): Update.
 104         * block.c (block_lookup_symbol): Update.
 105         (block_lookup_symbol_primary): Update.
 106         (block_find_symbol): Update.
 107         * cp-namespace.c (cp_lookup_symbol_imports_or_template): Update.
 108         * dbxread.c (process_one_symbol): Update.
 109         * dictionary.c (insert_symbol_hashed): Update.
 110         (collate_pending_symbols_by_language): Update.
 111         (mdict_add_symbol): Update.
 112         * dwarf-index-write.c (write_psymbols): Update.
 113         * dwarf2read.c (fixup_go_packaging): Update.
 114         * findvar.c (read_var_value): Update.
 115         * ft32-tdep.c (ft32_skip_prologue): Update.
 116         * go-lang.c (go_symbol_package_name): Update.
 117         * language.h (scoped_switch_to_sym_language_if_auto::
 118         scoped_switch_to_sym_language_if_auto): Update.
 119         * linespec.c (find_method): Update.
 120         (find_label_symbols_in_block): Update.
 121         * mdebugread.c (parse_symbol): Update.
 122         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
 123         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
 124         (minimal_symbol_reader::install): Update.
 125         * moxie-tdep.c (moxie_skip_prologue): Update.
 126         * parse.c (parse_exp_in_context): Update.
 127         * psymtab.c (psymbol_name_matches): Update.
 128         (match_partial_symbol): Update.
 129         (lookup_partial_symbol): Update.
 130         (psymbol_hash): Update.
 131         (psymbol_compare): Update.
 132         * python/py-framefilter.c (extract_sym): Update.
 133         (py_print_single_arg): Update.
 134         * stabsread.c (define_symbol): Update.
 135         * stack.c (print_frame_arg): Update.
 136         (find_frame_funname): Update.
 137         (info_frame_command_core): Update.
 138         * symfile.c (set_initial_language): Update.
 139         * symtab.c (symbol_set_demangled_name): Update.
 140         (symbol_get_demangled_name): Update.
 141         (symbol_set_language): Update.
 142         (symbol_find_demangled_name): Update.
 143         (symbol_set_names): Update.
 144         (general_symbol_info::natural_name): Update.
 145         (general_symbol_info::demangled_name): Update.
 146         (general_symbol_info::search_name): Update.
 147         (symbol_matches_search_name): Update.
 148         (eq_symbol_entry): Update.
 149         (iterate_over_symbols): Update.
 150         (completion_list_add_symbol): Update.
 151         (completion_list_add_msymbol): Update.
 152         (completion_list_add_fields): Update.
 153         * symtab.h (struct general_symbol_info) <language>: New function.
 154         <language>: Rename to...
 155         <m_language>: ...this.
 156         (SYMBOL_LANGUAGE): Remove.
 157         (MSYMBOL_LANGUAGE): Remove.
 158         (struct symbol) <ctor>: Update.
 159         * xstormy16-tdep.c (xstormy16_skip_prologue): Update.
 160
 161 2019-12-15  Christian Biesinger  <cbiesinger@google.com>
 162
 163         * ada-exp.y (write_ambiguous_var): Call symbol_set_language to
 164         set the language of sym.
 165         * language.c (language_alloc_type_symbol): Likewise.
 166
 167 2019-12-14  Sergio Durigan Junior  <sergiodj@redhat.com>
 168
 169         https://bugzilla.redhat.com/show_bug.cgi?id=1728147
 170         PR gdb/23613
 171         * bsd-kvm.c (bsd_kvm_target_open): Use 'gdb_abspath'.
 172         * corelow.c: Include 'gdbsupport/pathstuff.h'.
 173         (core_target_open): Use 'gdb_abspath'.
 174         * gdbsupport/pathstuff.c (gdb_abspath): Guard against
 175         'current_directory == NULL' case.
 176         * gdbsupport/pathstuff.h (gdb_abspath): Expand comment and
 177         explain what happens when 'current_directory' is NULL.
 178         * go32-nat.c (go32_nat_target::wait): Check if
 179         'current_directory' is NULL before call to 'chdir'.
 180         * source.c (add_path): Use 'gdb_abspath'.
 181         * top.c: Include 'gdbsupport/pathstuff.h'.
 182         (init_history): Use 'gdb_abspath'.
 183         (set_history_filename): Likewise.
 184         * tracefile-tfile.c: Include 'gdbsupport/pathstuff.h'.
 185         (tfile_target_open): Use 'gdb_abspath'.
 186
 187 2019-12-13  Tom Tromey  <tromey@adacore.com>
 188
 189         * contrib/ari/gdb_ari.sh: Remove check for multiple calls to
 190         warning or error.
 191
 192 2019-12-13  Tom Tromey  <tromey@adacore.com>
 193
 194         * contrib/ari/gdb_ari.sh: Remove call to "fix" for "long long".
 195
 196 2019-12-13  Tom Tromey  <tromey@adacore.com>
 197
 198         * contrib/ari/gdb_ari.sh: Handle -Wno- prefix.
 199
 200 2019-12-13  Tom Tromey  <tromey@adacore.com>
 201
 202         * contrib/ari/gdb_ari.sh (usage): Use GNU style.
 203
 204 2019-12-13  Tom Tromey  <tromey@adacore.com>
 205
 206         * gdbsupport/common-utils.c (string_printf, string_vprintf)
 207         (string_vappendf): Add ARI comment.
 208
 209 2019-12-13  Tom Tromey  <tromey@adacore.com>
 210
 211         * contrib/ari/gdb_ari.sh: Remove "fix" call for
 212         floatformat_to_double.
 213         * target-float.c (host_float_ops<T>::from_target): Add ARI
 214         comment.
 215
 216 2019-12-13  Tom Tromey  <tromey@adacore.com>
 217
 218         * contrib/ari/gdb_ari.sh: Remove "fix" call for abort.
 219         * utils.c (abort_with_message, dump_core, internal_vproblem): Add
 220         ARI marker to abort.
 221         * event-top.c (handle_sigsegv): Add ARI marker to abort.
 222
 223 2019-12-13  Tom Tromey  <tromey@adacore.com>
 224
 225         * contrib/ari/gdb_ari.sh: Fix floatformat_from_double text.
 226
 227 2019-12-13  Tom Tromey  <tromey@adacore.com>
 228
 229         * contrib/ari/gdb_ari.sh: Remove ATTRIBUTE_UNUSED check.
 230
 231 2019-12-13  Tom Tromey  <tromey@adacore.com>
 232
 233         * contrib/ari/gdb_ari.sh: Remove "boolean" and "var_boolean"
 234         checks.
 235
 236 2019-12-13  Tom Tromey  <tromey@adacore.com>
 237
 238         * gdbsupport/safe-iterator.h (class basic_safe_range) <begin,
 239         end>: No longer "const".
 240
 241 2019-12-13  Simon Marchi  <simon.marchi@polymtl.ca>
 242
 243         * jit.c: Fix indentation, replace spaces with tabs where
 244         applicable.
 245
 246 2019-12-13  Jozef Lawrynowicz  <jozef.l@mittosystems.com>
 247
 248         * configure.tgt: Match msp430-*-elf* targets when configuring GDB.
 249
 250 2019-12-12  Tom Tromey  <tom@tromey.com>
 251
 252         * objfiles.h (struct objfile) <partial_symtabs>: Now a
 253         unique_ptr.
 254
 255 2019-12-12  Tom Tromey  <tom@tromey.com>
 256
 257         * progspace.h (objfile_list): New typedef.
 258         (class unwrapping_objfile_iterator)
 259         (struct unwrapping_objfile_range): Newl
 260         (struct program_space) <objfiles_range>: Change type.
 261         <objfiles>: Change return type.
 262         <add_objfile>: Change type of "objfile" parameter.
 263         <objfiles_list>: Now a list of shared_ptr.
 264         * progspace.c (program_space::add_objfile): Change type of
 265         "objfile".  Update.
 266         (program_space::remove_objfile): Update.
 267         * objfiles.h (struct objfile) <~objfile>: Make public.
 268         * objfiles.c (objfile::make): Update.
 269         (objfile::unlink): Don't call delete.
 270
 271 2019-12-12  Tom Tromey  <tom@tromey.com>
 272
 273         * symfile.c (symbol_file_clear): Update.
 274         * progspace.h (struct program_space) <free_all_objfiles>: Declare
 275         method.
 276         * progspace.c (program_space::free_all_objfiles): New method.
 277         * objfiles.h (free_all_objfiles): Don't declare.
 278         * objfiles.c (free_all_objfiles): Move to program_space.
 279
 280 2019-12-12  Tom Tromey  <tom@tromey.com>
 281
 282         * progspace.c (program_space::add_objfile)
 283         (program_space::remove_objfile): Update.
 284         (program_space::multi_objfile_p): Remove.
 285         * objfiles.h (struct objfile) <next>: Remove.
 286         * objfiles.c (objfile::objfile): Update.
 287         (put_objfile_before): Update.
 288         (unlink_objfile): Update.
 289         * progspace.h (object_files): Remove.
 290         (struct program_space) <objfiles_head>: Remove.
 291         <objfiles_list>: New member.
 292         <objfiles_range, objfiles_safe_range>: Change type.
 293         (objfiles): Change return type.
 294         (objfiles_safe): Update.
 295         (multi_objfile_p): Rewrite and inline.
 296         (object_files): Remove macro.
 297
 298 2019-12-12  Tom Tromey  <tom@tromey.com>
 299
 300         * gdbsupport/safe-iterator.h (basic_safe_iterator): Simplify.  Add
 301         second constructor.
 302         (basic_safe_range): New class.
 303
 304 2019-12-12  Tom Tromey  <tom@tromey.com>
 305
 306         * progspace.c (program_space::multi_objfile_p): New method.
 307         * printcmd.c (info_symbol_command): Update.
 308         * maint.c (maintenance_translate_address): Update.
 309         * objfiles.h (MULTI_OBJFILE_P): Remove.
 310         * progspace.h (struct program_space) <multi_objfile_p>: New
 311         method.
 312
 313 2019-12-12  Tom Tromey  <tom@tromey.com>
 314
 315         * progspace.h (struct program_space) <remove_objfile>: Declare.
 316         * progspace.c (program_space::remove_objfile): New method.
 317         * objfiles.c (unlink_objfile): Remove.
 318         (objfile::unlink): Call remove_objfile.
 319         (objfile): Don't call unlink_objfile.
 320
 321 2019-12-12  Tom Tromey  <tom@tromey.com>
 322
 323         * progspace.h (struct program_space) <add_objfile>: Declare
 324         method.
 325         * progspace.c (program_space::add_objfile): New method.
 326         * objfiles.c (~objfile): Don't unlink objfile.
 327         (put_objfile_before): Remove.
 328         (add_separate_debug_objfile): Don't call put_objfile_before.
 329         (objfile::make): Call add_objfile.  Set new_objfiles_available on
 330         the per-program-space data.
 331
 332 2019-12-12  Tom Tromey  <tom@tromey.com>
 333
 334         * symfile.c (syms_from_objfile_1): Use objfile_up.
 335         (syms_from_objfile_1, remove_symbol_file_command): Call unlink
 336         method.
 337         (reread_symbols): Use objfile_up.
 338         * solib.c (update_solib_list, reload_shared_libraries_1): Call
 339         unlink method.
 340         * objfiles.h (struct objfile) <~objfile>: Now private.
 341         <unlink>: New method.
 342         (struct objfile_deleter): New.
 343         (objfile_up): New typedef.
 344         * objfiles.c (objfile::unlink): New method.
 345         (free_objfile_separate_debug, free_all_objfiles)
 346         (objfile_purge_solibs): Use it.
 347         * jit.c (jit_unregister_code): Remove.
 348         (jit_inferior_exit_hook, jit_event_handler): Call unlink on
 349         objfile.
 350         * compile/compile-object-run.c (do_module_cleanup): Call unlink on
 351         objfile.
 352         * compile/compile-object-load.c (compile_object_load): Use
 353         objfile_up.
 354
 355 2019-12-12  Tom Tromey  <tom@tromey.com>
 356
 357         * symfile.c (symbol_file_add_with_addrs): Pass "parent" to
 358         objfile::make.
 359         * objfiles.h (struct objjfile) <make>: No longer inline.
 360         (add_separate_debug_objfile): Don't declare.
 361         * objfiles.c (add_separate_debug_objfile): Now static.
 362         (objfile::make): Move from objfiles.h.  Call
 363         add_separate_debug_objfile.  Add "parent" parameter.
 364
 365 2019-12-12  Tom Tromey  <tom@tromey.com>
 366
 367         * symfile.c (symbol_file_add_with_addrs): Use objfile::make.
 368         * objfiles.h (struct objfile): Make constructor private.
 369         <make>: New static method.
 370         * jit.c (jit_object_close_impl): Update.
 371
 372 2019-12-12  Simon Marchi  <simon.marchi@polymtl.ca>
 373
 374         * jit.c (jit_reader_try_read_symtab): Replace xmalloc/xfree with
 375         gdb::byte_vector.
 376
 377 2019-12-12  Tom Tromey  <tromey@adacore.com>
 378
 379         * xml-support.c (xml_fetch_content_from_file): Don't call
 380         malloc_failure.
 381         * utils.h (class gdb_argv): Remove malloc_failure comment.
 382         * utils.c (gdb_argv::reset): Don't call malloc_failure.
 383
 384 2019-12-12  Tom Tromey  <tromey@adacore.com>
 385
 386         * Makefile.in (ALL_TARGET_OBS): Add riscv-ravenscar-thread.o.
 387         (HFILES_NO_SRCDIR): Add riscv-ravenscar-thread.h.
 388         (ALLDEPFILES): Add riscv-ravenscar-thread.c.
 389         * configure.tgt (riscv-*-*): Add riscv-ravenscar-thread.o.
 390         * riscv-ravenscar-thread.c: New file.
 391         * riscv-ravenscar-thread.h: New file.
 392         * riscv-tdep.c (riscv_gdbarch_init): Call
 393         register_riscv_ravenscar_ops.
 394
 395 2019-12-12  Tom Tromey  <tromey@adacore.com>
 396
 397         * gdbsupport/thread-pool.c (set_thread_name): Use
 398         ATTRIBUTE_UNUSED.
 399
 400 2019-12-12  Luis Machado  <luis.machado@linaro.org>
 401
 402         * gdbsupport/safe-strerror.c: Don't include diagnostics.h.
 403         (select_strerror_r): Use ATTRIBUTE_UNUSED instead of the diagnostics
 404         macros.
 405
 406 2019-12-11  Tom Tromey  <tom@tromey.com>
 407
 408         * tui/tui-win.c (tui_set_win_height_command): Call
 409         tui_adjust_window_height.
 410         (tui_adjust_win_heights, new_height_ok): Remove.
 411         * tui/tui-layout.h (tui_adjust_window_height): Declare.
 412         * tui/tui-layout.c (tui_adjust_window_height): New function.
 413
 414 2019-12-11  Tom Tromey  <tom@tromey.com>
 415
 416         * tui/tui-win.c (tui_resize_all): Remove code, call
 417         tui_apply_current_layout.
 418
 419 2019-12-11  Tom Tromey  <tom@tromey.com>
 420
 421         * tui/tui-layout.h (tui_apply_current_layout): Declare.
 422         * tui/tui-layout.c (standard_layouts, applied_layout): New
 423         globals.
 424         (tui_apply_current_layout): New function.
 425         (show_layout): Set applied_layout.  Call
 426         tui_apply_current_layout.
 427         (show_source_command, show_disasm_command)
 428         (show_source_disasm_command, show_data)
 429         (show_source_or_disasm_and_command): Remove.
 430         (initialize_layouts): New function.
 431         (_initialize_tui_layout): Call initialize_layouts.
 432
 433 2019-12-11  Tom Tromey  <tom@tromey.com>
 434
 435         * tui/tui-layout.h (class tui_layout_base)
 436         (class tui_layout_window, class tui_layout_split): New.
 437         * tui/tui-layout.c (tui_get_window_by_name)
 438         (tui_layout_window::clone, tui_layout_window::apply)
 439         (tui_layout_window::get_sizes, tui_layout_window::add_split)
 440         (tui_layout_split::add_window, tui_layout_split::clone)
 441         (tui_layout_split::get_sizes)
 442         (tui_layout_split::set_weights_from_heights)
 443         (tui_layout_split::adjust_size, tui_layout_split::apply): New
 444         functions.
 445         (tui_layout_split::add_split, tui_layout_split::add_split)
 446         (tui_layout_split::set_weights_from_heights)
 447         (tui_layout_split::set_weights_from_heights): New functions.
 448
 449 2019-12-11  Tom Tromey  <tom@tromey.com>
 450
 451         * tui/tui-wingeneral.c (tui_gen_win_info::make_window): Update.
 452         * tui/tui-win.c (tui_adjust_win_heights, tui_resize_all): Update.
 453         * tui/tui-layout.c (tui_gen_win_info::resize): Update.
 454         * tui/tui-data.h (struct tui_point): Remove.
 455         (struct tui_gen_win_info) <origin>: Remove.
 456         <x, y>: New fields.
 457         * tui/tui-command.c (tui_cmd_window::resize): Update.
 458
 459 2019-12-11  Tom Tromey  <tom@tromey.com>
 460
 461         * tui/tui-stack.h (struct tui_locator_window) <min_height>:
 462         Implement.
 463         * tui/tui-regs.h (struct tui_data_item_window) <min_height>:
 464         Implement.
 465         * tui/tui-data.h (struct tui_gen_win_info) <min_height>: New
 466         method.
 467         (struct tui_win_info) <min_height>: Implement.
 468
 469 2019-12-11  Tom Tromey  <tom@tromey.com>
 470
 471         * tui/tui-data.h (struct tui_gen_win_info) <can_box>: New method.
 472         (struct tui_win_info) <can_box>: Update.
 473
 474 2019-12-11  Tom Tromey  <tom@tromey.com>
 475
 476         * tui/tui-stack.h (struct tui_locator_window) <max_height>: New
 477         method.
 478         * tui/tui-regs.h (struct tui_data_item_window) <max_height>: New
 479         method.
 480         * tui/tui-data.h (struct tui_gen_win_info) <max_height>: New
 481         method.
 482         (struct tui_win_info) <max_height>: Now override.
 483
 484 2019-12-11  Joel Brobecker  <brobecker@adacore.com>
 485
 486         * NEWS: Create a new section for the next release branch.
 487         Rename the section of the current branch, now that it has
 488         been cut.
 489
 490 2019-12-11  Joel Brobecker  <brobecker@adacore.com>
 491
 492         GDB 9 branch created (27f7b2f64062ac9e52afc60509263c2702a9ebd0):
 493         * version.in: Bump version to 10.0.50.DATE-git.
 494
 495 2019-12-11  Tom Tromey  <tromey@adacore.com>
 496
 497         PR build/25268:
 498         * gdbsupport/thread-pool.c (set_thread_name): New function.
 499         (thread_pool::set_thread_count): Don't call pthread_setname_np.
 500         (thread_pool::thread_function): Call set_thread_name.
 501
 502 2019-12-11  Tom Tromey  <tromey@adacore.com>
 503
 504         * fbsd-tdep.c (fbsd_core_info_proc_status): Cast result of
 505         bfd_get_signed_8.
 506
 507 2019-12-11  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 508
 509         * NEWS: Document -raw-values option and the related setting commands.
 510         * printcmd.c (print_command_parse_format): Do not set opts->raw off,
 511         only set it on when /r is given.
 512         * valprint.c (value_print_option_defs): New element raw-values.
 513         * Makefile.in: Add the new file.
 514
 515 2019-12-10  Christian Biesinger  <cbiesinger@google.com>
 516
 517         * gdbsupport/safe-strerror.c: Supress the unused function warning
 518         for select_strerror_r.
 519
 520 2019-12-10  Christian Biesinger  <cbiesinger@google.com>
 521
 522         * config.in: Regenerate.
 523         * configure: Regenerate.
 524         * gdbsupport/agent.c (gdb_connect_sync_socket): Call
 525         safe_strerror instead of strerror.
 526         * gdbsupport/common.m4: Don't check for strerror.
 527         * gdbsupport/safe-strerror.c: Support both the glibc version
 528         of strerror_r and the XSI version.
 529
 530 2019-12-10  Tom Tromey  <tromey@adacore.com>
 531
 532         * ada-typeprint.c (print_choices): Use a single "?".
 533         (print_variant_part): Print "?" if the discriminant name
 534         is not known.
 535
 536 2019-12-10  George Barrett  <bob@bob131.so>
 537
 538         Fix scripted probe breakpoints.
 539         * breakpoint.c (tracepoint_probe_breakpoint_ops): Move
 540         declaration forward.
 541         (breakpoint_ops_for_event_location_type)
 542         (breakpoint_ops_for_event_location): Add function definitions.
 543         (break_command_1, trace_command): Use
 544         breakpoint_ops_for_event_location.
 545         * breakpoint.h (breakpoint_ops_for_event_location): Add function
 546         declarations.
 547         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Use
 548         breakpoint_ops_for_event_location.
 549         * python/py-breakpoint.c (bppy_init): Use
 550         breakpoint_ops_for_event_location.
 551
 552 2019-12-09  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
 553
 554         * gdbtypes.c (rank_one_type): Return INCOMPATIBLE_TYPE_BADNESS
 555         when ranking an lvalue argument for an rvalue parameter.
 556
 557 2019-12-08  Wataru Ashihara  <wataash@wataash.com>
 558
 559         * darwin-nat.c (darwin_nat_target::create_inferior): Fix
 560         template argument for scoped_restore_tmpl from bool to int.
 561
 562 2019-12-07  Keith Seitz  <keiths@redhat.com>
 563
 564         * build-id.c (build_id_bfd_get): Permit bfd_core, too.
 565         (build_id_to_debug_bfd): Make static, rewriting to use
 566         build_id_to_bfd_suffix.
 567         (build_id_to_bfd_suffix): Copy of build_id_to_debug_bfd,
 568         adding `suffix' parameter. Append SUFFIX to file names
 569         when searching for matching files.
 570         (build_id_to_debug_bfd): Use build_id_to_bfd_suffix.
 571         (build_id_to_exec_bfd): Likewise.
 572         * build-id.h (build_id_to_debug_bfd): Clarify that function
 573         searches for BFD of debug info file.
 574         (build_id_to_exec_bfd): Declare.
 575         * corelow.c: Include build-id.h.
 576         (locate_exec_from_corefile_build_id): New function.
 577         (core_target_open): If no executable BFD is found,
 578         search for a core file BFD using build-id.
 579
 580 2019-12-06  Christian Biesinger  <cbiesinger@google.com>
 581
 582         * bcache.c: Put in namespace gdb.
 583         * bcache.h: Likewise.
 584         * gdbtypes.c (check_types_worklist): Update.
 585         (types_deeply_equal): Update.
 586         * macrotab.c (struct macro_table) <bcache>: Update.
 587         (new_macro_table): Update.
 588         * macrotab.h (struct bcache): Put this forward declaration
 589         inside namespace gdb.
 590         (new_macro_table): Update.
 591         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache>:
 592         Update.
 593         <macro_cache>: Update.
 594         * psymtab.h: (psymtab_storage) <psymbol_cache>: Update.
 595
 596 2019-12-06  Tom de Vries  <tdevries@suse.de>
 597
 598         PR symtab/24971
 599         * block.c (best_symbol, better_symbol): New function.
 600         (block_lookup_symbol_primary, block_lookup_symbol): Prefer def over
 601         decl.
 602
 603 2019-12-06  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
 604
 605         * gdbtypes.h: Define the REFERENCE_SEE_THROUGH_BADNESS value.
 606         * gdbtypes.c (rank_one_type): Use REFERENCE_SEE_THROUGH_BADNESS
 607         for ranking see-through reference cases.
 608
 609 2019-12-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 610         * stack.c (faas_command): Check a command is provided.
 611         * thread.c (taas_command, tfaas_command): Likewise.
 612
 613 2019-12-05  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 614         * inferior.c (prune_inferiors):  Only call delete_inferior,
 615         Do not modify the inferior list.
 616
 617 2019-12-05  Simon Marchi  <simon.marchi@polymtl.ca>
 618
 619         * c-exp.y: Update calls to lookup_typename,
 620         lookup_signed_typename and lookup_unsigned_typename.
 621         * c-lang.c (evaluate_subexp_c): Likewise.
 622         * cp-namespace.c (cp_lookup_symbol_imports_or_template):
 623         Likewise.
 624         * eval.c (binop_promote): Likewise.
 625         * gdbtypes.c (lookup_typename): Remove gdbarch parameter.
 626         (lookup_unsigned_typename): Likewise.
 627         (lookup_signed_typename): Likewise.
 628         * gdbtypes.h (lookup_unsigned_typename): Likewise.
 629         (lookup_signed_typename): Likewise.
 630         (lookup_typename): Likewise.
 631         * guile/scm-type.c (tyscm_lookup_typename): Update calls to
 632         lookup_typename, lookup_signed_typename,
 633         lookup_unsigned_typename.
 634         * m2-exp.y: Likewise.
 635         * printcmd.c (printf_wide_c_string): Likewise.
 636         (ui_printf): Likewise.
 637         * python/py-type.c (typy_lookup_typename): Likewise.
 638         * python/py-xmethods.c (python_xmethod_worker::invoke):
 639         Likewise.
 640         * rust-exp.y: Likewise.
 641
 642 2019-12-04  Christian Biesinger  <cbiesinger@google.com>
 643
 644         * configure.nat (obsd64): Add missing files x86-nat.o and
 645         nat/x86-dregs.o.
 646
 647 2019-12-04  Tom Tromey  <tom@tromey.com>
 648
 649         * valprint.c (val_print_string): Use metadata_style.
 650         * go-valprint.c (print_go_string): Use metadata style.
 651         * p-valprint.c (pascal_object_print_static_field): Use metadata
 652         style.
 653         * cp-valprint.c (cp_print_static_field): Use metadata style.
 654
 655 2019-12-04  Andrew Burgess  <andrew.burgess@embecosm.com>
 656             Chris January  <chris.january@arm.com>
 657
 658         * f-exp.y (COMPLEX_KEYWORD, SINGLE, DOUBLE, PRECISION): New
 659         tokens.
 660         (typebase): New patterns for complex, single/double precision, and
 661         single/double complex.
 662         (f77_keywords): Change token for complex keyword, and add single,
 663         double, and precision keywords.
 664
 665 2019-12-04  Simon Marchi  <simon.marchi@polymtl.ca>
 666
 667         * avr-tdep.c (_initialize_avr_tdep): Improve help of command
 668         "info io_registers".
 669
 670 2019-12-04  Simon Marchi  <simon.marchi@polymtl.ca>
 671
 672         * regcache.c (cooked_read_test): Initialize thread list of
 673         mock_inferior.
 674
 675 2019-12-04  Simon Marchi  <simon.marchi@polymtl.ca>
 676
 677         * aarch64-linux-tdep.c: Remove includes.
 678
 679 2019-12-04  Simon Marchi  <simon.marchi@polymtl.ca>
 680
 681         * aarch64-tdep.c: Remove includes.
 682
 683 2019-12-04  Simon Marchi  <simon.marchi@efficios.com>
 684
 685         * filtered-iterator.h (filtered_iterator) <operator==,
 686         operator!=>: Compare wrapped iterators, not wrapped pointers.
 687         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
 688         unittests/filtered_iterator-selftests.c.
 689         * unittests/filtered_iterator-selftests.c: New file.
 690
 691 2019-12-04  Tom Tromey  <tromey@adacore.com>
 692
 693         * gdbtypes.c (create_range_type): Inherit endianity
 694         from base type.
 695
 696 2019-12-04  Tom Tromey  <tromey@adacore.com>
 697
 698         * ada-lang.c (decode_constrained_packed_array)
 699         (ada_value_assign, value_assign_to_component): Update.
 700         * dwarf2loc.c (rw_pieced_value, access_memory)
 701         (dwarf2_compile_expr_to_ax): Update.
 702         * dwarf2read.c (dwarf2_add_field): Update.
 703         * eval.c (evaluate_subexp_standard): Update.
 704         * gdbarch.c, gdbarch.h: Rebuild.
 705         * gdbarch.sh (bits_big_endian): Remove.
 706         * gdbtypes.h (union field_location): Update comment.
 707         * target-descriptions.c (make_gdb_type): Update.
 708         * valarith.c (value_bit_index): Update.
 709         * value.c (struct value) <bitpos>: Update comment.
 710         (unpack_bits_as_long, modify_field): Update.
 711         * value.h (value_bitpos): Update comment.
 712
 713 2019-12-04  Tom Tromey  <tromey@adacore.com>
 714
 715         * gdbtypes.c (type_byte_order): Move earlier.  Assert for unknown
 716         endian-ness.
 717
 718 2019-12-04  Tom Tromey  <tromey@adacore.com>
 719
 720         * dwarf2read.c (dwarf2_init_float_type)
 721         (dwarf2_init_complex_target_type): Add byte_order parameter.
 722         (read_base_type): Compute byte order earlier.
 723         * gdbtypes.c (init_float_type): Add byte_order parameter.
 724         * gdbtypes.h (init_float_type): Add byte_order parameter.
 725
 726 2019-12-04  Tom Tromey  <tromey@adacore.com>
 727
 728         * unittests/tui-selftests.c: Conditionally include tui-winsource.h.
 729
 730 2019-12-04  Tom Tromey  <tromey@adacore.com>
 731
 732         * dwarf2read.c (process_structure_scope): Initialize
 733         "discr_offset".
 734
 735 2019-12-04  Andrew Burgess  <andrew.burgess@embecosm.com>
 736
 737         * mi/mi-symbol-cmds.c (mi_symbol_info): Take extra parameter, and
 738         add it into the search spec.
 739         (parse_max_results_option): New function.
 740         (mi_info_functions_or_variables): Parse -max-results flag and pass
 741         it to mi_symbol_info.
 742         (mi_cmd_symbol_info_modules): Likewise.
 743         (mi_cmd_symbol_info_types): Likewise.
 744         * symtab.c (global_symbol_searcher::add_matching_symbols): Change
 745         return type to bool, change result container into a set, and don't
 746         add new results if we have enough already.
 747         (global_symbol_searcher::add_matching_msymbols): Change return
 748         type to bool, and don't add new results if we have enough already.
 749         (sort_search_symbols_remove_dups): Delete.
 750         (global_symbol_searcher::search): Early exit from search loop when
 751         we have enough results.  Use a std::set to collect the results
 752         from calling add_matching_symbols.
 753         * symtab.h (global_symbol_searcher) <set_max_seach_results>: New
 754         member function.
 755         (global_symbol_searcher) <m_max_search_results>: New member
 756         variable.
 757         (global_symbol_searcher) <add_matching_symbols>: Update header
 758         comment and change return type to bool.
 759         (global_symbol_searcher) <add_matching_msymbols>: Update header
 760         comment and change return type to bool.
 761
 762 2019-12-04  Andrew Burgess  <andrew.burgess@embecosm.com>
 763
 764         * symtab.c (symbol_search::compare_search_syms): Update header
 765         comment.
 766         (global_symbol_searcher::is_suitable_msymbol): New function.
 767         (global_symbol_searcher::expand_symtabs): New function.
 768         (global_symbol_searcher::add_matching_symbols): New function.
 769         (global_symbol_searcher::add_matching_msymbols): New function.
 770         (global_symbol_searcher::search): Move most of the content
 771         into the new functions above, and call them as needed.
 772         * symtab.h (global_symbol_searcher) <expand_symtabs>: New member
 773         function.
 774         (global_symbol_searcher) <add_matching_symbols>: New member
 775         function.
 776         (global_symbol_searcher) <add_matching_msymbols>: New member
 777         function.
 778         (global_symbol_searcher) <is_suitable_msymbol>: New member
 779         function.
 780
 781 2019-12-04  Andrew Burgess  <andrew.burgess@embecosm.com>
 782
 783         * mi/mi-cmds.c (mi_cmds): Add -symbol-info-module-functions and
 784         -symbol-info-module-variables entries.
 785         * mi/mi-cmds.h (mi_cmd_symbol_info_module_functions): Declare.
 786         (mi_cmd_symbol_info_module_variables): Declare.
 787         * mi/mi-symbol-cmds.c
 788         (module_symbol_search_iterator): New typedef.
 789         (output_module_symbols_in_single_module_and_file): New function.
 790         (output_module_symbols_in_single_module): New function.
 791         (mi_info_module_functions_or_variables): New function.
 792         (mi_cmd_symbol_info_module_functions): New function.
 793         (mi_cmd_symbol_info_module_variables): New function.
 794         * NEWS: Mention new MI command.
 795
 796 2019-12-03  Christian Biesinger  <cbiesinger@google.com>
 797
 798         * bcache.c (hash): Remove.
 799         (hash_continue): Remove.
 800         * bcache.h (hash): Remove.
 801         (hash_continue): Remove.
 802         (struct bcache) <ctor>: Update.
 803         * psymtab.c (psymbol_hash): Update.
 804         * stabsread.c (hashname): Update.
 805         * utils.h (fast_hash): Add an argument for a start value,
 806         defaulting to zero.
 807
 808 2019-12-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 809         * symtab.c (symbol_cache_clear_slot):  Move close to cleared type.
 810         (destroy_block_symbol_cache): New function.
 811         (symbol_cache:~symbol_cache) Call destroy_block_symbol_cache.
 812         (resize_symbol_cache): Likewise.
 813
 814 2019-12-02  Tom Tromey  <tom@tromey.com>
 815
 816         * unittests/tui-selftests.c (run_tests): Make conditional.
 817         (_initialize_tui_selftest): Make conditional.
 818
 819 2019-12-02  Christian Biesinger  <cbiesinger@google.com>
 820
 821         * aix-thread.c (debug_aix_thread): Change type to bool.
 822
 823 2019-12-02  Luis Machado  <luis.machado@linaro.org>
 824
 825         * infrun.c (follow_fork_inferior): Remove outdated FIXME comment.
 826
 827 2019-12-01  Andrew Burgess  <andrew.burgess@embecosm.com>
 828
 829         * dwarf2read.c (read_tag_string_type): Read the fields required to
 830         make a dynamic string, and possibly create a dynamic range for the
 831         string.
 832         (attr_to_dynamic_prop): Setup is_reference based on the type of
 833         attribute being processed.
 834         * gdbtypes.c (is_dynamic_type_internal): Handle TYPE_CODE_STRING.
 835         (resolve_dynamic_array): Rename to...
 836         (resolve_dynamic_array_or_string): ...this, update header comment,
 837         and accept TYPE_CODE_STRING.
 838         (resolve_dynamic_type_internal): Handle TYPE_CODE_STRING.
 839
 840 2019-12-01  Andrew Burgess  <andrew.burgess@embecosm.com>
 841
 842         * dwarf2read.c (dwarf2_per_cu_int_type): New function, takes most
 843         of its implementation from...
 844         (dwarf2_per_cu_addr_sized_int_type): ...here, which now just calls
 845         the new function.
 846
 847 2019-12-01  Andrew Burgess  <andrew.burgess@embecosm.com>
 848
 849         * dwarf2read.c (read_subrange_type): Read bit and byte stride and
 850         create a range with stride where appropriate.
 851         * f-valprint.c: Include 'gdbarch.h'.
 852         (f77_print_array_1): Take the stride into account when walking the
 853         array.  Also convert the stride into addressable units.
 854         * gdbtypes.c (create_range_type): Initialise the stride to
 855         constant zero.
 856         (create_range_type_with_stride): New function, initialise the
 857         range as normal, and then setup the stride.
 858         (has_static_range): Include the stride here.  Also change the
 859         return type to bool.
 860         (create_array_type_with_stride): Consider the range stride if the
 861         array isn't given its own stride.
 862         (resolve_dynamic_range): Resolve the stride if needed.
 863         * gdbtypes.h (struct range_bounds) <stride>: New member variable.
 864         (struct range_bounds) <flag_is_byte_stride>: New member variable.
 865         (TYPE_BIT_STRIDE): Define.
 866         (TYPE_ARRAY_BIT_STRIDE): Define.
 867         (create_range_type_with_stride): Declare.
 868         * valarith.c (value_subscripted_rvalue): Take range stride into
 869         account when walking the array.
 870
 871 2019-12-01  Tom Tromey  <tom@tromey.com>
 872
 873         * tui/tui-win.c (tui_all_windows_info): Treat inactive TUI
 874         specially.
 875
 876 2019-12-01  Tom Tromey  <tom@tromey.com>
 877
 878         * tui/tui-winsource.c (tui_copy_source_line): Don't advance past
 879         \0.
 880         * unittests/tui-selftests.c: New file.
 881         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add tui-selftests.c.
 882
 883 2019-12-01  Tom Tromey  <tom@tromey.com>
 884
 885         * tui/tui.c (tui_enable): Call tui_update_variables earlier.
 886
 887 2019-12-01  Tom Tromey  <tom@tromey.com>
 888
 889         * NEWS: Document new settings.
 890         * tui/tui-wingeneral.c (box_win): Apply appropriate border style.
 891         * tui/tui-win.c (_initialize_tui_win): Add border style
 892         observers.
 893         * tui/tui-io.h (tui_apply_style): Declare.
 894         * tui/tui-io.c (tui_apply_style): Rename from apply_style.  No
 895         longer static.
 896         (apply_ansi_escape, tui_set_reverse_mode): Update.
 897         * cli/cli-style.h (class cli_style_option) <add_setshow_commands>:
 898         Add "skip_intensity" parameter.
 899         <changed>: New member.
 900         <do_set_value>: Declare.
 901         (tui_border_style, tui_active_border_style): Declare.
 902         * cli/cli-style.c (tui_border_style, tui_active_border_style): New
 903         globals.
 904         (cli_style_option): Initialize "changed".
 905         (cli_style_option::do_set_value): New function.
 906         (cli_style_option::add_setshow_commands): Add "skip_intensity"
 907         parameter.  Update.
 908         (STYLE_ADD_SETSHOW_COMMANDS): Add "SKIP" parameter.
 909         (_initialize_cli_style): Update.  Create TUI border style
 910         commands.
 911
 912 2019-12-01  Tom Tromey  <tom@tromey.com>
 913
 914         * tui/tui-winsource.h (tui_copy_source_line): Add "ndigits"
 915         parameter.
 916         * tui/tui-winsource.c (tui_copy_source_line): Add "ndigits"
 917         parameter.
 918         * tui/tui-win.h (compact_source): Declare.
 919         * tui/tui-win.c (compact_source): New global.
 920         (tui_set_compact_source, tui_show_compact_source): New functions.
 921         (_initialize_tui_win): Add "compact-source" setting.
 922         * tui/tui-source.c (tui_source_window::set_contents): Handle
 923         compact_source setting.
 924         * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
 925         * NEWS: Document new setting.
 926
 927 2019-11-30  Tom Tromey  <tom@tromey.com>
 928
 929         * dwarf2read.c (dwarf2_add_field): Include field offset when
 930         computing variant part length.
 931
 932 2019-11-30  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 933         * NEWS:  Mention define-prefix.  Tell that command names can now
 934         contain a . character.
 935
 936 2019-11-30  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 937
 938         * command.h (valid_cmd_char_p): Declare.
 939         * cli/cli-decode.c (valid_cmd_char_p): New function factorizing
 940         the check of valid command char.
 941         (find_command_name_length, valid_user_defined_cmd_name_p): Use
 942         valid_cmd_char_p.
 943         * cli/cli-script.c (validate_comname): Likewise.
 944         * completer.c (gdb_completer_command_word_break_characters):
 945         Do not remove . from the word break char, update comments.
 946         (complete_line_internal_1): Use valid_cmd_char_p.
 947         * guile/scm-cmd.c (gdbscm_parse_command_name): Likewise.
 948         * python/py-cmd.c (gdbpy_parse_command_name): Likewise.
 949
 950 2019-11-30  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 951
 952         * cli/cli-script.c (do_define_command): Ensure a redefined
 953         prefix command is kept as a prefix command.
 954         (define_prefix_command): New function.
 955         (show_user_1): Report user defined prefixes.
 956         (_initialize_cli_script):  Create the new 'define-prefix' command.
 957         Add completers for 'define' and 'document'.
 958         * top.c (execute_command):  If command is a user-defined prefix only
 959         command, report the list of commands for this prefix command.
 960
 961 2019-11-29  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
 962
 963         * valops.c (find_oload_champ): Improve debug output.
 964
 965 2019-11-29  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
 966
 967         * valops.c (find_oload_champ): Print part of debug messages
 968         before the badness vector is std::move'd.
 969
 970 2019-11-28  Tom Tromey  <tom@tromey.com>
 971
 972         * value.c (creal_internal_fn): Fix comment.
 973
 974 2019-11-28  Tom Tromey  <tom@tromey.com>
 975
 976         * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count,
 977         flag_bound_evaluated>: Now unsigned.
 978
 979 2019-11-28  Tom Tromey  <tom@tromey.com>
 980
 981         * guile/guile-internal.h (vlscm_scm_from_value_unsafe): Don't
 982         declare.
 983
 984 2019-11-28  Mihails Strasuns  <mihails.strasuns@intel.com>
 985
 986         * jit.c (jit_bfd_try_read_symtab): Fix printed function name in the
 987         debug output.
 988         * jit.c (jit_unregister_code): Add debug print to match
 989         `jit_register_code`.
 990
 991 2019-11-27  Christian Biesinger  <cbiesinger@google.com>
 992
 993         * NEWS: Mention the new multithreaded symbol loading.
 994
 995 2019-11-27  Christian Biesinger  <cbiesinger@google.com>
 996
 997         * maint.c (n_worker_threads): Default to 0.
 998         (worker_threads_disabled): New function.
 999         * maint.h (worker_threads_disabled): New function.
1000         * minsyms.c (minimal_symbol_reader::record_full): Call symbol_set_names
1001         here if worker_threads_disabled () is true.
1002         (minimal_symbol_reader::install): Skip all threading if
1003         worker_threads_disabled () is true.
1004
1005 2019-11-27  Christian Biesinger  <cbiesinger@google.com>
1006
1007         * minsyms.c (add_minsym_to_hash_table): Use a previously computed
1008         hash code if possible.
1009         (add_minsym_to_demangled_hash_table): Likewise.
1010         (minimal_symbol_reader::install): Compute the hash codes for msymbol
1011         on the background thread.
1012         * symtab.h (struct minimal_symbol) <hash_value, demangled_hash_value>:
1013         Add these fields.
1014
1015 2019-11-27  Christian Biesinger  <cbiesinger@google.com>
1016
1017         * minsyms.c (minimal_symbol_reader::install): Also compute the hash
1018         of the mangled name on the background thread.
1019         * symtab.c (symbol_set_names): Allow passing in the hash of the
1020         linkage_name.
1021         * symtab.h (symbol_set_names): Likewise.
1022
1023 2019-11-27  Kevin Buettner  <kevinb@redhat.com>
1024
1025         * dwarf2read.c (inherit_abstract_dies): Ensure that delayed
1026         physnames are computed for inherited DIEs.
1027
1028 2019-11-27  Tom Tromey  <tromey@adacore.com>
1029
1030         * dwarf2read.h (struct dwarf2_per_objfile): Remove unnecessary
1031         backslashes.
1032         * cp-support.c: Remove unnecessary backslashes.
1033
1034 2019-11-27  Christian Biesinger  <cbiesinger@google.com>
1035
1036         * ada-exp.y (write_ambiguous_var): Replace SYMBOL_SET_LINKAGE_NAME
1037         with sym->set_linkage_name.
1038         * coffread.c (coff_read_enum_type): Likewise.
1039         * mdebugread.c (parse_symbol): Likewise.
1040         * stabsread.c (patch_block_stabs): Likewise.
1041         (define_symbol): Likewise.
1042         (read_enum_type): Likewise.
1043         (common_block_end): Likewise.
1044         * symtab.h (struct general_symbol_info) <set_linkage_name>: New
1045         function.
1046         (SYMBOL_SET_LINKAGE_NAME): Remove.
1047         * xcoffread.c (process_xcoff_symbol): Replace SYMBOL_SET_LINKAGE_NAME
1048         with sym->set_linkage_name.
1049
1050 2019-11-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1051
1052         * mi/mi-cmds.c (mi_cmds): Add 'symbol-info-modules' entry.
1053         * mi/mi-cmds.h (mi_cmd_symbol_info_modules): Declare.
1054         * mi/mi-symbol-cmds.c (mi_cmd_symbol_info_modules): New function.
1055         * NEWS: Mention new MI command.
1056
1057 2019-11-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1058
1059         * mi/mi-cmds.c (mi_cmds): Add '-symbol-info-functions',
1060         '-symbol-info-types', and '-symbol-info-variables'.
1061         * mi/mi-cmds.h (mi_cmd_symbol_info_functions): Declare.
1062         (mi_cmd_symbol_info_types): Declare.
1063         (mi_cmd_symbol_info_variables): Declare.
1064         * mi/mi-symbol-cmds.c: Add 'source.h' and 'mi-getopt.h' includes.
1065         (output_debug_symbol): New function.
1066         (output_nondebug_symbol): New function.
1067         (mi_symbol_info): New function.
1068         (mi_info_functions_or_variables): New function.
1069         (mi_cmd_symbol_info_functions): New function.
1070         (mi_cmd_symbol_info_types): New function.
1071         (mi_cmd_symbol_info_variables): New function.
1072         * NEWS: Mention new commands.
1073
1074 2019-11-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1075
1076         * symtab.c (symbol_to_info_string): New function, most content
1077         moved from print_symbol_info, but updated to return a std::string.
1078         (print_symbol_info): Update to use symbol_to_info_string and print
1079         returned string.
1080         * symtab.h (symbol_to_info_string): Declare new function.
1081
1082 2019-11-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1083
1084         * python/python.c (gdbpy_rbreak): Convert to using
1085         global_symbol_searcher.
1086         * symtab.c (file_matches): Convert return type to bool, change
1087         file list to std::vector, update header comment.
1088         (search_symbols): Rename to...
1089         (global_symbol_searcher::search): ...this and update now its
1090         a member function of global_symbol_searcher.  Take account of the
1091         changes to file_matches.
1092         (symtab_symbol_info): Convert to using global_symbol_searcher.
1093         (rbreak_command): Likewise.
1094         (search_module_symbols): Likewise.
1095         * symtab.h (enum symbol_search): Update comment.
1096         (search_symbols): Remove declaration.
1097         (class global_symbol_searcher): New class.
1098
1099 2019-11-26  Tom Tromey  <tromey@adacore.com>
1100
1101         * cp-support.c (_initialize_cp_support): Conditionally initialize
1102         gdb_demangle_attempt_core_dump.
1103
1104 2019-11-26  Tom Tromey  <tom@tromey.com>
1105
1106         * python/py-function.c (fnpy_init): Update.
1107         * value.h (add_internal_function): Adjust declaration.
1108         * value.c (function_destroyer): Remove.
1109         (do_add_internal_function): Don't set destroyer or copy name.
1110         (add_internal_function): Take unique_xmalloc_ptr<char> for name.
1111         Set name_allocated.
1112         * python/py-cmd.c (cmdpy_destroyer): Don't free "name".
1113         (cmdpy_init): Set name_allocated.
1114         * cli/cli-decode.h (struct cmd_list_element) <name_allocated>: New
1115         member.
1116         (~cmd_list_element): Free "name" if needed.
1117
1118 2019-11-26  Tom Tromey  <tom@tromey.com>
1119
1120         * value.h (add_internal_function): Add new overload.  Move
1121         documentation from value.h.
1122         * value.c (do_add_internal_function): New function.
1123         (add_internal_function): Use it.  Add new overload.
1124         (function_destroyer): Don't free doc.
1125         * python/py-function.c (fnpy_init): Update.
1126
1127 2019-11-26  Tom Tromey  <tom@tromey.com>
1128
1129         * python/py-cmd.c (cmdpy_destroyer): Don't free "doc".
1130         (cmdpy_init): Set "doc_allocated".
1131
1132 2019-11-26  Tom Tromey  <tom@tromey.com>
1133
1134         * gdbsupport/thread-pool.c (thread_pool::set_thread_count): Set
1135         name of worker thread.
1136         * gdbsupport/common.m4 (GDB_AC_COMMON): Check for
1137         pthread_setname_np.
1138         * configure, config.in: Rebuild.
1139
1140 2019-11-26  Tom Tromey  <tom@tromey.com>
1141
1142         * python/python.c (class gdbpy_gil): New.
1143         (struct gdbpy_event): Add constructor, destructor, operator().
1144         (gdbpy_post_event): Use run_on_main_thread.
1145         (gdbpy_initialize_events): Remove.
1146         (do_start_initialization): Update.
1147
1148 2019-11-26  Tom Tromey  <tom@tromey.com>
1149
1150         * NEWS: Add entry.
1151         * maint.c (_initialize_maint_cmds): Add "worker-threads" maint
1152         commands.  Call update_thread_pool_size.
1153         (update_thread_pool_size, maintenance_set_worker_threads): New
1154         functions.
1155         (n_worker_threads): New global.
1156
1157 2019-11-26  Christian Biesinger  <cbiesinger@google.com>
1158             Tom Tromey  <tom@tromey.com>
1159
1160         * minsyms.c (minimal_symbol_reader::install): Use
1161         parallel_for_each.
1162         * gdbsupport/parallel-for.h: New file.
1163         * Makefile.in (HFILES_NO_SRCDIR): Add gdbsupport/parallel-for.h.
1164
1165 2019-11-26  Christian Biesinger  <cbiesinger@google.com>
1166             Tom Tromey  <tom@tromey.com>
1167
1168         * gdbsupport/thread-pool.h: New file.
1169         * gdbsupport/thread-pool.c: New file.
1170         * Makefile.in (COMMON_SFILES): Add thread-pool.c.
1171         (HFILES_NO_SRCDIR): Add thread-pool.h.
1172
1173 2019-11-26  Tom Tromey  <tom@tromey.com>
1174
1175         * event-top.h (thread_local_segv_handler): Declare.
1176         * event-top.c (thread_local_segv_handler): New global.
1177         (install_handle_sigsegv, handle_sigsegv): New functions.
1178         (async_init_signals): Install SIGSEGV handler.
1179         * cp-support.c (gdb_demangle_jmp_buf): Change type.  Now
1180         thread-local.
1181         (report_failed_demangle): New function.
1182         (gdb_demangle): Make core_dump_allowed atomic.  Remove signal
1183         handler-setting code, instead use segv_handler.  Run warning code
1184         on main thread.
1185
1186 2019-11-26  Tom Tromey  <tom@tromey.com>
1187
1188         * run-on-main-thread.c: New file.
1189         * run-on-main-thread.h: New file.
1190         * unittests/main-thread-selftests.c: New file.
1191         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
1192         main-thread-selftests.c.
1193         (HFILES_NO_SRCDIR): Add run-on-main-thread.h.
1194         (COMMON_SFILES): Add run-on-main-thread.c.
1195
1196 2019-11-26  Tom Tromey  <tom@tromey.com>
1197
1198         * main.c (setup_alternate_signal_stack): Remove.
1199         (captured_main_1): Use gdb::alternate_signal_stack.
1200         * gdbsupport/alt-stack.h: New file.
1201
1202 2019-11-26  Tom Tromey  <tom@tromey.com>
1203
1204         * gdbsupport/signals-state-save-restore.c (original_signal_mask):
1205         Remove comment.
1206         (save_original_signals_state, restore_original_signals_state): Use
1207         gdb_sigmask.
1208         * linux-nat.c (block_child_signals, restore_child_signals_mask)
1209         (_initialize_linux_nat): Use gdb_sigmask.
1210         * guile/guile.c (_initialize_guile): Use block_signals.
1211         * Makefile.in (HFILES_NO_SRCDIR): Add gdb-sigmask.h.
1212         * gdbsupport/gdb-sigmask.h: New file.
1213         * event-top.c (async_sigtstp_handler): Use gdb_sigmask.
1214         * cp-support.c (gdb_demangle): Use gdb_sigmask.
1215         * gdbsupport/common.m4 (GDB_AC_COMMON): Check for
1216         pthread_sigmask.
1217         * configure, config.in: Rebuild.
1218         * gdbsupport/block-signals.h: New file.
1219
1220 2019-11-26  Tom Tromey  <tom@tromey.com>
1221
1222         * acinclude.m4: Include ax_pthread.m4.
1223         * Makefile.in (PTHREAD_CFLAGS, PTHREAD_LIBS): New variables.
1224         (INTERNAL_CFLAGS_BASE): Use PTHREAD_CFLAGS.
1225         (CLIBS): Use PTHREAD_LIBS.
1226         (aclocal_m4_deps): Add ax_pthread.m4.
1227         * config.in, configure: Rebuild.
1228         * gdbsupport/common.m4 (GDB_AC_COMMON): Check for std::thread.
1229
1230 2019-11-26  Tom Tromey  <tom@tromey.com>
1231
1232         * symtab.h (struct minimal_symbol) <name_set>: New member.
1233         * minsyms.c (minimal_symbol_reader::record_full): Copy name.
1234         Don't call symbol_set_names.
1235         (minimal_symbol_reader::install): Call symbol_set_names.
1236
1237 2019-11-26  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1238
1239         * python/python.c (gdbpy_enter::~gdbpy_enter): Release GIL after
1240         restore_active_ext_lang, as GIL is needed for (indirectly)
1241         called PyOS_InterruptOccurred.
1242
1243 2019-11-26  Simon Marchi  <simon.marchi@efficios.com>
1244
1245         * sparc-nat.c (sparc_xfer_wcookie): Sync declaration with
1246         definition.
1247
1248 2019-11-26  Simon Marchi  <simon.marchi@efficios.com>
1249
1250         * remote-sim.c (simulator_command): Make static, remove
1251         declaration.
1252
1253 2019-11-26  Simon Marchi  <simon.marchi@efficios.com>
1254
1255         * unittests/array-view-selftests.c (check_ptr_size_ctor2): Make
1256         static.
1257         * unittests/basic_string_view/capacity/1.cc (test01): Likewise.
1258         * unittests/basic_string_view/cons/char/1.cc (test01): Likewise.
1259         (main): Likewise.
1260         * unittests/basic_string_view/cons/char/2.cc (test03): Likewise.
1261         (main): Likewise.
1262         * unittests/basic_string_view/cons/char/3.cc (test05): Likewise.
1263         (main): Likewise.
1264         * unittests/basic_string_view/element_access/char/1.cc (test01):
1265         Likewise.
1266         (main): Likewise.
1267         * unittests/basic_string_view/element_access/char/empty.cc (main):
1268         Likewise.
1269         * unittests/basic_string_view/element_access/char/front_back.cc
1270         (test01): Likewise.
1271         (main): Likewise.
1272         * unittests/basic_string_view/inserters/char/2.cc (test05):
1273         Likewise.
1274         (main): Likewise.
1275         * unittests/basic_string_view/modifiers/remove_prefix/char/1.cc
1276         (test01): Likewise.
1277         (main): Likewise.
1278         * unittests/basic_string_view/modifiers/remove_suffix/char/1.cc
1279         (test01): Likewise.
1280         (main): Likewise.
1281         * unittests/basic_string_view/modifiers/swap/char/1.cc (test01):
1282         Likewise.
1283         * unittests/basic_string_view/operations/compare/char/1.cc
1284         (test01): Likewise.
1285         (main): Likewise.
1286         * unittests/basic_string_view/operations/compare/char/13650.cc
1287         (test01): Likewise.
1288         * unittests/basic_string_view/operations/copy/char/1.cc (test01):
1289         Likewise.
1290         (main): Likewise.
1291         * unittests/basic_string_view/operations/data/char/1.cc (test01):
1292         Likewise.
1293         (main): Likewise.
1294         * unittests/basic_string_view/operations/find/char/1.cc (test01):
1295         Likewise.
1296         (main): Likewise.
1297         * unittests/basic_string_view/operations/find/char/2.cc (test02):
1298         Likewise.
1299         (main): Likewise.
1300         * unittests/basic_string_view/operations/find/char/3.cc (test03):
1301         Likewise.
1302         (main): Likewise.
1303         * unittests/basic_string_view/operations/find/char/4.cc (main):
1304         Likewise.
1305         * unittests/basic_string_view/operations/rfind/char/1.cc (test01):
1306         Likewise.
1307         (main): Likewise.
1308         * unittests/basic_string_view/operations/rfind/char/2.cc (test02):
1309         Likewise.
1310         (main): Likewise.
1311         * unittests/basic_string_view/operations/rfind/char/3.cc (test03):
1312         Likewise.
1313         (main): Likewise.
1314         * unittests/basic_string_view/operations/substr/char/1.cc
1315         (test01): Likewise.
1316         (main): Likewise.
1317         * unittests/basic_string_view/operators/char/2.cc (main):
1318         Likewise.
1319         * unittests/optional/assignment/1.cc (test): Likewise.
1320         * unittests/optional/assignment/2.cc (test): Likewise.
1321         * unittests/optional/assignment/3.cc (test): Likewise.
1322         * unittests/optional/assignment/4.cc (test): Likewise.
1323         * unittests/optional/assignment/5.cc (test): Likewise.
1324         * unittests/optional/assignment/6.cc (test): Likewise.
1325         * unittests/optional/assignment/7.cc (test): Likewise.
1326         * unittests/optional/cons/copy.cc (test): Likewise.
1327         * unittests/optional/cons/default.cc (test): Likewise.
1328         * unittests/optional/cons/move.cc (test): Likewise.
1329         * unittests/optional/cons/value.cc (test): Likewise.
1330         * unittests/optional/in_place.cc (test): Likewise.
1331         * unittests/optional/observers/1.cc (test): Likewise.
1332         * unittests/optional/observers/2.cc (test): Likewise.
1333
1334 2019-11-26  Simon Marchi  <simon.marchi@efficios.com>
1335
1336         * tui-win.h (tui_set_var_cmd): Remove.
1337         * tui-win.c (tui_set_var_cmd): Make static.
1338
1339 2019-11-26  Simon Marchi  <simon.marchi@efficios.com>
1340
1341         * breakpoint.h (hbreak_command_wrapper, thbreak_command_wrapper,
1342         rbreak_command_wrapper): Remove.
1343         * symtab.c (rbreak_command_wrapper): Remove.
1344
1345 2019-11-26  Simon Marchi  <simon.marchi@efficios.com>
1346
1347         * inferior.h (info_terminal_command): Remove declaration.
1348         * inflow.c (info_terminal_command): Make static.
1349
1350 2019-11-26  Simon Marchi  <simon.marchi@efficios.com>
1351
1352         * inferior.c (exit_inferior_silent): Remove.
1353
1354 2019-11-26  Simon Marchi  <simon.marchi@efficios.com>
1355
1356         * dictionary.c (dict_empty, mdict_empty): Remove.
1357         * dictionary.c (mdict_empty): Remove.
1358
1359 2019-11-26  Simon Marchi  <simon.marchi@efficios.com>
1360
1361          * arc-tdep.c (arc_insn_get_memory_base_reg): Make static.
1362          (arc_insn_get_memory_offset): Likewise.
1363          (arc_insn_dump): Likewise.
1364          * cp-support.c (test_cp_symbol_name_matches): Likewise.
1365          * csky-linux-tdep.c (csky_supply_fregset): Likewise.
1366          * dictionary.c (dict_iterator_next): Likewise.
1367          (dict_iter_match_first): Likewise.
1368          (dict_iter_match_next): Likewise.
1369          * f-lang.c (evaluate_subexp_f): Likewise.
1370          * hppa-tdep.c (hppa_read_pc): Likewise.
1371          * i386-tdep.c (i386_floatformat_for_type): Likewise.
1372          * parse.c (write_exp_elt_msym): Likewise.
1373          * ppc-linux-tdep.c (ppc_floatformat_for_type): Likewise.
1374          * remote.c (remote_packet_size): Likewise.
1375          (remote_notif_stop_parse): Likewise.
1376          * rs6000-aix-tdep.c (aix_sighandle_frame_sniffer): Likewise.
1377          * s12z-tdep.c (s12z_disassemble_info): Likewise.
1378          * source.c (prepare_path_for_appending): Likewise.
1379          * sparc64-linux-tdep.c
1380          (sparc64_linux_handle_segmentation_fault); Likewise.
1381          * stack.c (frame_selection_by_function_completer): Likewise.
1382
1383 2019-11-26  Simon Marchi  <simon.marchi@efficios.com>
1384
1385         * completer.c (set_gdb_completion_word_break_characters):
1386         Remove.
1387
1388 2019-11-26  Simon Marchi  <simon.marchi@efficios.com>
1389
1390         * dwarf-index-write.c: Include dwarf-index-write.h.
1391         * mi/mi-interp.c: Include mi/mi-interp.h.
1392
1393 2019-11-26  Simon Marchi  <simon.marchi@efficios.com>
1394
1395         * aarch32-tdep.c: Include aarch32-tdep.h.
1396         * aarch32-tdep.h: Forward-declare struct target_desc.
1397
1398 2019-11-26  Christian Biesinger  <cbiesinger@google.com>
1399
1400         * linux-nat.c (detach_one_lwp): Call safe_strerror instead of
1401         strerror.
1402         * nto-procfs.c (nto_procfs_target::create_inferior): Likewise.
1403         * windows-nat.c (windows_nat_target::create_inferior): Likewise.
1404
1405 2019-11-25  Tom de Vries  <tdevries@suse.de>
1406
1407         * contrib/words.sh: Add -c option.
1408
1409 2019-11-25  Christian Biesinger  <cbiesinger@google.com>
1410
1411         * solib.c (solib_find_1): Change int to bool.
1412         (exec_file_find): Change int to bool.
1413         (solib_find): Change int to bool.
1414         (solib_read_symbols): Change int to bool.
1415         (solib_used): Change int to bool.
1416         (solib_add): Change int to bool.
1417         (info_sharedlibrary_command): Change int to bool.
1418         (solib_contains_address_p): Change int to bool.
1419         (solib_keep_data_in_core): Change int to bool.
1420         (in_solib_dynsym_resolve_code): Change int to bool.
1421         (reload_shared_libraries_1): Change int to bool.
1422         (gdb_sysroot_changed): Change int to bool.
1423         * solib.h (solib_read_symbols): Change int to bool.
1424         (solib_contains_address_p): Change int to bool.
1425         (solib_keep_data_in_core): Change int to bool.
1426         (in_solib_dynsym_resolve_code): Change int to bool.
1427         (libpthread_name_p): Change int to bool.
1428
1429 2019-11-25  Luis Machado  <luis.machado@linaro.org>
1430
1431         * NEWS (New Commands): Mention "set debug remote-packet-max-chars".
1432         * remote.c (REMOTE_DEBUG_MAX_CHAR): Remove.
1433         (remote_packet_max_chars): New static global.
1434         (show_remote_packet_max_chars): New function.
1435         (remote_target::putpkt_binary): Adjust to use new
1436         remote_packet_max_chars option.
1437         (remote_target::getpkt_or_notif_sane_1): Likewise.
1438         (_initialize_remote): Register new remote-packet-max-chars option.
1439
1440 2019-11-24  Simon Marchi  <simon.marchi@efficios.com>
1441
1442         * m68k-linux-nat.c: Include gdbarch.h.
1443
1444 2019-11-24  Tom Tromey  <tom@tromey.com>
1445
1446         * symfile.c (read_symbols): Update.
1447         * psymtab.c (require_partial_symbols): Change type of "verbose" to
1448         bool.
1449         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
1450         (psym_lookup_symbol, psym_find_last_source_symtab)
1451         (psym_forget_cached_source_info, psym_print_stats)
1452         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
1453         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
1454         (psym_map_matching_symbols, psym_expand_symtabs_matching)
1455         (psym_find_compunit_symtab_by_address)
1456         (maintenance_print_psymbols, maintenance_info_psymtabs)
1457         (maintenance_check_psymtabs): Update.
1458         * psymtab.h (require_partial_symbols): Change type of "verbose" to
1459         bool.
1460
1461 2019-11-22  Tom Tromey  <tom@tromey.com>
1462
1463         * observable.h: Update comments.
1464
1465 2019-11-22  Tom Tromey  <tromey@adacore.com>
1466
1467         * ada-tasks.c (ada_task_is_alive): Make parameter const.
1468         (print_ada_task_info): Don't try to fetch thread id if task is not
1469         alive.
1470
1471 2019-11-22  Christian Biesinger  <cbiesinger@google.com>
1472
1473         * ada-exp.y: Update.
1474         * ada-lang.c (sort_choices): Update.
1475         (ada_print_symbol_signature): Update.
1476         (resolve_subexp): Update.
1477         (ada_parse_renaming): Update.
1478         (ada_read_renaming_var_value): Update.
1479         (lesseq_defined_than): Update.
1480         (remove_extra_symbols): Update.
1481         (remove_irrelevant_renamings): Update.
1482         (ada_add_block_symbols): Update.
1483         (ada_collect_symbol_completion_matches): Update.
1484         (ada_is_renaming_symbol): Update.
1485         (aggregate_assign_from_choices): Update.
1486         (ada_evaluate_subexp): Update.
1487         (ada_has_this_exception_support): Update.
1488         (ada_is_non_standard_exception_sym): Update.
1489         (ada_add_exceptions_from_frame): Update.
1490         (ada_add_global_exceptions): Update.
1491         (ada_print_subexp): Update.
1492         * ax-gdb.c (gen_var_ref): Update.
1493         (gen_maybe_namespace_elt): Update.
1494         (gen_expr_for_cast): Update.
1495         (gen_expr): Update.
1496         * block.h: Update.
1497         * blockframe.c (find_pc_partial_function): Update.
1498         * breakpoint.c (print_breakpoint_location): Update.
1499         (update_static_tracepoint): Update.
1500         * btrace.c (ftrace_print_function_name): Update.
1501         (ftrace_function_switched): Update.
1502         * buildsym.c (find_symbol_in_list): Update.
1503         * c-exp.y: Update.
1504         * c-typeprint.c (c_print_typedef): Update.
1505         (c_type_print_template_args): Update.
1506         * cli/cli-cmds.c (edit_command): Update.
1507         (list_command): Update.
1508         (print_sal_location): Update.
1509         * coffread.c (patch_opaque_types): Update.
1510         (process_coff_symbol): Update.
1511         (coff_read_enum_type): Update.
1512         * compile/compile-c-symbols.c (c_symbol_substitution_name): Update.
1513         (convert_one_symbol): Update.
1514         (hash_symname): Update.
1515         (eq_symname): Update.
1516         * compile/compile-cplus-symbols.c (convert_one_symbol): Update.
1517         * compile/compile-cplus-types.c (debug_print_scope): Update.
1518         * compile/compile-loc2c.c (do_compile_dwarf_expr_to_c): Update.
1519         * compile/compile-object-load.c (get_out_value_type): Update.
1520         * cp-namespace.c (cp_scan_for_anonymous_namespaces): Update.
1521         (search_symbol_list): Update.
1522         (cp_lookup_symbol_imports_or_template): Update.
1523         * cp-support.c (overload_list_add_symbol): Update.
1524         * ctfread.c (psymtab_to_symtab): Update.
1525         * dbxread.c (cp_set_block_scope): Update.
1526         * dictionary.c (iter_match_first_hashed): Update.
1527         (iter_match_next_hashed): Update.
1528         (insert_symbol_hashed): Update.
1529         (iter_match_next_linear): Update.
1530         * dictionary.h: Update.
1531         * dwarf2loc.c (func_get_frame_base_dwarf_block): Update.
1532         (locexpr_describe_location_piece): Update.
1533         (locexpr_describe_location_1): Update.
1534         (locexpr_generate_c_location): Update.
1535         (loclist_describe_location): Update.
1536         (loclist_generate_c_location): Update.
1537         * dwarf2read.c (dw2_debug_names_lookup_symbol): Update.
1538         (read_func_scope): Update.
1539         (process_enumeration_scope): Update.
1540         (new_symbol): Update.
1541         (dwarf2_const_value): Update.
1542         (dwarf2_symbol_mark_computed): Update.
1543         * eval.c (evaluate_funcall): Update.
1544         (evaluate_subexp_standard): Update.
1545         * expprint.c (print_subexp_standard): Update.
1546         (dump_subexp_body_standard): Update.
1547         * f-valprint.c (info_common_command_for_block): Update.
1548         * findvar.c (get_hosting_frame): Update.
1549         (default_read_var_value): Update.
1550         * go-lang.c (go_symbol_package_name): Update.
1551         * guile/scm-block.c (bkscm_print_block_smob): Update.
1552         * guile/scm-symbol.c (syscm_print_symbol_smob): Update.
1553         (gdbscm_symbol_name): Update.
1554         (gdbscm_symbol_linkage_name): Update.
1555         (gdbscm_symbol_print_name): Update.
1556         * infcall.c (get_function_name): Update.
1557         * infcmd.c (jump_command): Update.
1558         (finish_command): Update.
1559         * infrun.c (insert_exception_resume_breakpoint): Update.
1560         * linespec.c (canonicalize_linespec): Update.
1561         (create_sals_line_offset): Update.
1562         (convert_linespec_to_sals): Update.
1563         (complete_label): Update.
1564         (find_label_symbols_in_block): Update.
1565         * m2-typeprint.c (m2_print_typedef): Update.
1566         * mdebugread.c (mdebug_reg_to_regnum): Update.
1567         (parse_symbol): Update.
1568         (mylookup_symbol): Update.
1569         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
1570         (list_args_or_locals): Update.
1571         * objc-lang.c (compare_selectors): Update.
1572         (info_selectors_command): Update.
1573         (compare_classes): Update.
1574         (info_classes_command): Update.
1575         (find_imps): Update.
1576         * p-typeprint.c (pascal_print_typedef): Update.
1577         * printcmd.c (build_address_symbolic): Update.
1578         (info_address_command): Update.
1579         (print_variable_and_value): Update.
1580         * python/py-framefilter.c (extract_sym): Update.
1581         (py_print_single_arg): Update.
1582         * python/py-symbol.c (sympy_str): Update.
1583         (sympy_get_name): Update.
1584         (sympy_get_linkage_name): Update.
1585         * python/python.c (gdbpy_rbreak): Update.
1586         * record-btrace.c (btrace_get_bfun_name): Update.
1587         (btrace_call_history): Update.
1588         * rust-lang.c (rust_print_typedef): Update.
1589         * solib-frv.c (frv_fdpic_find_canonical_descriptor): Update.
1590         * stabsread.c (stab_reg_to_regnum): Update.
1591         (define_symbol): Update.
1592         (read_enum_type): Update.
1593         (common_block_end): Update.
1594         (cleanup_undefined_types_1): Update.
1595         (scan_file_globals): Update.
1596         * stack.c (print_frame_arg): Update.
1597         (print_frame_args): Update.
1598         (find_frame_funname): Update.
1599         (info_frame_command_core): Update.
1600         (iterate_over_block_locals): Update.
1601         (print_block_frame_labels): Update.
1602         (do_print_variable_and_value): Update.
1603         (iterate_over_block_arg_vars): Update.
1604         (return_command): Update.
1605         * symmisc.c (dump_symtab_1): Update.
1606         (print_symbol): Update.
1607         * symtab.c (eq_symbol_entry): Update.
1608         (symbol_cache_dump): Update.
1609         (lookup_language_this): Update.
1610         (find_pc_sect_line): Update.
1611         (skip_prologue_sal): Update.
1612         (symbol_search::compare_search_syms): Update.
1613         (treg_matches_sym_type_name): Update.
1614         (search_symbols): Update.
1615         (print_symbol_info): Update.
1616         (rbreak_command): Update.
1617         (completion_list_add_symbol): Update.
1618         (find_gnu_ifunc): Update.
1619         (get_symbol_address): Update.
1620         (search_module_symbols): Update.
1621         (info_module_subcommand): Update.
1622         * symtab.h (SYMBOL_NATURAL_NAME): Remove.
1623         (SYMBOL_LINKAGE_NAME): Remove.
1624         (SYMBOL_DEMANGLED_NAME): Remove.
1625         (SYMBOL_PRINT_NAME): Remove.
1626         (SYMBOL_SEARCH_NAME): Remove.
1627         * tracepoint.c (set_traceframe_context): Update.
1628         (validate_actionline): Update.
1629         (collection_list::collect_symbol): Update.
1630         (encode_actions_1): Update.
1631         (info_scope_command): Update.
1632         (print_one_static_tracepoint_marker): Update.
1633         * typeprint.c (typedef_hash_table::add_template_parameters): Update.
1634         * valops.c (address_of_variable): Update.
1635         (find_overload_match): Update.
1636         (find_oload_champ): Update.
1637
1638 2019-11-22  Christian Biesinger  <cbiesinger@google.com>
1639
1640         * ada-lang.c (ada_lookup_simple_minsym): Update.
1641         (ada_collect_symbol_completion_matches): Update.
1642         * ada-tasks.c (read_atcb): Update.
1643         * amd64-windows-tdep.c (amd64_skip_main_prologue): Update.
1644         (amd64_windows_skip_trampoline_code): Update.
1645         * arm-tdep.c (skip_prologue_function): Update.
1646         (arm_skip_stack_protector): Update.
1647         * arm-wince-tdep.c (arm_pe_skip_trampoline_code): Update.
1648         (arm_wince_skip_main_prologue): Update.
1649         * ax-gdb.c (gen_expr): Update.
1650         * block.c (call_site_for_pc): Update.
1651         * blockframe.c (find_pc_partial_function): Update.
1652         * breakpoint.c (set_breakpoint_location_function): Update.
1653         * btrace.c (ftrace_print_function_name): Update.
1654         (ftrace_function_switched): Update.
1655         * c-valprint.c (print_unpacked_pointer): Update.
1656         * coffread.c (coff_symfile_read): Update.
1657         * compile/compile-c-symbols.c (convert_symbol_bmsym): Update.
1658         * compile/compile-cplus-symbols.c (convert_symbol_bmsym): Update.
1659         * dwarf-index-write.c (write_psymbols): Update.
1660         * dwarf2loc.c (call_site_to_target_addr): Update.
1661         (func_verify_no_selftailcall): Update.
1662         (tailcall_dump): Update.
1663         (call_site_find_chain_1): Update.
1664         (dwarf_expr_reg_to_entry_parameter): Update.
1665         * elfread.c (elf_gnu_ifunc_record_cache): Update.
1666         * eval.c (evaluate_funcall): Update.
1667         (evaluate_subexp_standard): Update.
1668         (evaluate_subexp_for_sizeof): Update.
1669         * expprint.c (print_subexp_standard): Update.
1670         (dump_subexp_body_standard): Update.
1671         * frame.c (get_prev_frame_always_1): Update.
1672         * frv-tdep.c (frv_skip_main_prologue): Update.
1673         * gnu-v2-abi.c (gnuv2_value_rtti_type): Update.
1674         * gnu-v3-abi.c (gnuv3_rtti_type): Update.
1675         (gnuv3_get_typename_from_type_info): Update.
1676         (gnuv3_skip_trampoline): Update.
1677         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
1678         * i386-tdep.c (i386_skip_main_prologue): Update.
1679         (i386_pe_skip_trampoline_code): Update.
1680         * ia64-tdep.c (ia64_convert_from_func_ptr_addr): Update.
1681         * infcall.c (get_function_name): Update.
1682         * linespec.c (minsym_found): Update.
1683         * linux-fork.c (info_checkpoints_command): Update.
1684         * m32c-tdep.c (m32c_m16c_address_to_pointer): Update.
1685         (m32c_m16c_pointer_to_address): Update.
1686         * maint.c (maintenance_translate_address): Update.
1687         * minsyms.c (add_minsym_to_hash_table): Update.
1688         (add_minsym_to_demangled_hash_table): Update.
1689         (lookup_minimal_symbol_mangled): Update.
1690         (lookup_minimal_symbol_demangled): Update.
1691         (lookup_minimal_symbol_linkage): Update.
1692         (lookup_minimal_symbol_text): Update.
1693         (lookup_minimal_symbol_by_pc_name): Update.
1694         (minimal_symbol_is_less_than): Update.
1695         (compact_minimal_symbols): Update.
1696         (build_minimal_symbol_hash_tables): Update.
1697         (find_solib_trampoline_target): Update.
1698         * mips-tdep.c (mips_stub_frame_sniffer): Update.
1699         (mips_skip_pic_trampoline_code): Update.
1700         * msp430-tdep.c (msp430_skip_trampoline_code): Update.
1701         * objc-lang.c (info_selectors_command): Update.
1702         (info_classes_command): Update.
1703         (find_methods): Update.
1704         (find_imps): Update.
1705         * p-valprint.c (pascal_val_print): Update.
1706         * ppc-linux-tdep.c (powerpc_linux_in_dynsym_resolve_code): Update.
1707         * ppc-sysv-tdep.c (convert_code_addr_to_desc_addr): Update.
1708         * printcmd.c (build_address_symbolic): Update.
1709         (info_symbol_command): Update.
1710         * psymtab.c (psymbol_name_matches): Update.
1711         (match_partial_symbol): Update.
1712         (lookup_partial_symbol): Update.
1713         (print_partial_symbols): Update.
1714         (sort_pst_symbols): Update.
1715         (maintenance_check_psymtabs): Update.
1716         * python/py-framefilter.c (py_print_frame): Update.
1717         * python/python.c (gdbpy_rbreak): Update.
1718         * record-btrace.c (btrace_get_bfun_name): Update.
1719         (btrace_call_history): Update.
1720         * rs6000-tdep.c (rs6000_skip_main_prologue): Update.
1721         (rs6000_skip_trampoline_code): Update.
1722         * sol-thread.c (info_cb): Update.
1723         * stabsread.c (scan_file_globals): Update.
1724         * stack.c (find_frame_funname): Update.
1725         (info_frame_command_core): Update.
1726         * symmisc.c (dump_msymbols): Update.
1727         * symtab.c (symbol_natural_name): Rename to..,
1728         (general_symbol_info::natural_name): ...this.
1729         (symbol_demangled_name): Rename to...
1730         (general_symbol_info::demangled_name): ...this.
1731         (symbol_search_name): Rename to...
1732         (general_symbol_info::search_name): ...this.
1733         (symbol_matches_search_name): Update.
1734         (find_pc_sect_line): Update.
1735         (skip_prologue_sal): Update.
1736         (search_symbols): Update.
1737         (print_msymbol_info): Update.
1738         (rbreak_command): Update.
1739         (completion_list_add_msymbol): Update.
1740         (completion_list_objc_symbol): Update.
1741         (get_msymbol_address): Update.
1742         * symtab.h (struct general_symbol_info): Add member functions
1743         natural_name (), linkage_name (), print_name (), demangled_name (),
1744         and search_name ().
1745         (SYMBOL_NATURAL_NAME): Update.
1746         (symbol_natural_name): Move to a member function on general_symbol_info.
1747         (SYMBOL_DEMANGLED_NAME): Update.
1748         (symbol_demangled_name): Move to a member function on
1749         general_symbol_info.
1750         (SYMBOL_SEARCH_NAME): Update.
1751         (symbol_search_name): Move to a member function on general_symbol_info.
1752         (MSYMBOL_NATURAL_NAME): Remove.
1753         (MSYMBOL_LINKAGE_NAME): Remove.
1754         (MSYMBOL_PRINT_NAME): Remove.
1755         (MSYMBOL_DEMANGLED_NAME): Remove.
1756         (MSYMBOL_SEARCH_NAME): Remove.
1757         * x86-tdep.c (x86_in_indirect_branch_thunk): Update.
1758
1759 2019-11-22  Christian Biesinger  <cbiesinger@google.com>
1760
1761         * symtab.c (create_demangled_names_hash): Use per_bfd->
1762         minimal_symbol_count for computing the initial size, if greater
1763         than our default size.
1764
1765 2019-11-22  Tom de Vries  <tdevries@suse.de>
1766
1767         * contrib/words.sh: Improve words extraction.
1768
1769 2019-11-22  Tom de Vries  <tdevries@suse.de>
1770
1771         * contrib/words.sh: Combine sed invocations.
1772
1773 2019-11-21  Christian Biesinger  <cbiesinger@google.com>
1774
1775         * Makefile.in: Update.
1776         * demangle.c: Rename to...
1777         * gdb-demangle.c: ..this.
1778         (is_cplus_marker): Change return type to bool.
1779         (_initialize_demangler): Rename to...
1780         (_initialize_gdb_demangle): ...this.
1781         * gdb-demangle.h (is_cplus_marker): Change return type to bool.
1782         * symtab.h (demangle): Remove declaration; instead include
1783         gdb-demangle.h.
1784
1785 2019-11-21  Tom Tromey  <tromey@adacore.com>
1786
1787         * gdbsupport/format.c (format_pieces): Parse %I64d.
1788         * unittests/format_pieces-selftests.c (test_windows_formats): New
1789         function.
1790         (run_tests): Call it.
1791
1792 2019-11-21  Peeter Joot  <peeter.joot@lzlabs.com>
1793
1794         Byte reverse display of variables with DW_END_big, DW_END_little
1795         (DW_AT_endianity) dwarf attributes if different than the native
1796         byte order.
1797         * ada-lang.c (ada_value_binop):
1798         Use type_byte_order instead of gdbarch_byte_order.
1799         * ada-valprint.c (printstr):
1800         (ada_val_print_string):
1801         * ada-lang.c (value_pointer):
1802         (ada_value_binop):
1803         Use type_byte_order instead of gdbarch_byte_order.
1804         * c-lang.c (c_get_string):
1805         Use type_byte_order instead of gdbarch_byte_order.
1806         * c-valprint.c (c_val_print_array):
1807         Use type_byte_order instead of gdbarch_byte_order.
1808         * cp-valprint.c (cp_print_class_member):
1809         Use type_byte_order instead of gdbarch_byte_order.
1810         * dwarf2loc.c (rw_pieced_value):
1811         Use type_byte_order instead of gdbarch_byte_order.
1812         * dwarf2read.c (read_base_type): Handle DW_END_big,
1813         DW_END_little
1814         * f-lang.c (f_get_encoding):
1815         Use type_byte_order instead of gdbarch_byte_order.
1816         * findvar.c (default_read_var_value):
1817         Use type_byte_order instead of gdbarch_byte_order.
1818         * gdbtypes.c (check_types_equal):
1819         Require matching TYPE_ENDIANITY_NOT_DEFAULT if set.
1820         (recursive_dump_type): Print TYPE_ENDIANITY_BIG,
1821         and TYPE_ENDIANITY_LITTLE if set.
1822         (type_byte_order): new function.
1823         * gdbtypes.h (TYPE_ENDIANITY_NOT_DEFAULT): New macro.
1824         (struct main_type) <flag_endianity_not_default>:
1825         New field.
1826         (type_byte_order): New function.
1827         * infcmd.c (default_print_one_register_info):
1828         Use type_byte_order instead of gdbarch_byte_order.
1829         * p-lang.c (pascal_printstr):
1830         Use type_byte_order instead of gdbarch_byte_order.
1831         * p-valprint.c (pascal_val_print):
1832         Use type_byte_order instead of gdbarch_byte_order.
1833         * printcmd.c (print_scalar_formatted):
1834         Use type_byte_order instead of gdbarch_byte_order.
1835         * solib-darwin.c (darwin_current_sos):
1836         Use type_byte_order instead of gdbarch_byte_order.
1837         * solib-svr4.c (solib_svr4_r_ldsomap):
1838         Use type_byte_order instead of gdbarch_byte_order.
1839         * stap-probe.c (stap_modify_semaphore):
1840         Use type_byte_order instead of gdbarch_byte_order.
1841         * target-float.c (target_float_same_format_p):
1842         Use type_byte_order instead of gdbarch_byte_order.
1843         * valarith.c (scalar_binop):
1844         (value_bit_index):
1845         Use type_byte_order instead of gdbarch_byte_order.
1846         * valops.c (value_cast):
1847         Use type_byte_order instead of gdbarch_byte_order.
1848         * valprint.c (generic_emit_char):
1849         (generic_printstr):
1850         (val_print_string):
1851         Use type_byte_order instead of gdbarch_byte_order.
1852         * value.c (unpack_long):
1853         (unpack_bits_as_long):
1854         (unpack_value_bitfield):
1855         (modify_field):
1856         (pack_long):
1857         (pack_unsigned_long):
1858         Use type_byte_order instead of gdbarch_byte_order.
1859         * findvar.c (unsigned_pointer_to_address):
1860         (signed_pointer_to_address):
1861         (unsigned_address_to_pointer):
1862         (address_to_signed_pointer):
1863         (default_read_var_value):
1864         (default_value_from_register):
1865         Use type_byte_order instead of gdbarch_byte_order.
1866         * gnu-v3-abi.c (gnuv3_make_method_ptr):
1867         Use type_byte_order instead of gdbarch_byte_order.
1868         * riscv-tdep.c (riscv_print_one_register_info):
1869         Use type_byte_order instead of gdbarch_byte_order.
1870
1871 2019-11-21  Simon Marchi  <simon.marchi@polymtl.ca>
1872
1873         * top.c (current_ui_gdb_stdout_ptr): Spell out by hand.
1874         (current_ui_gdb_stdin_ptr): Likewise.
1875         (current_ui_gdb_stderr_ptr): Likewise.
1876         (current_ui_gdb_stdlog_ptr): Likewise.
1877         (current_ui_current_uiout_ptr): Likewise.
1878         (gen_ret_current_ui_field_ptr): Remove.
1879
1880 2019-11-21  Tom de Vries  <tdevries@suse.de>
1881
1882         PR gdb/24956
1883         * cli/cli-script.c (execute_control_command): Only switch to
1884         INTERP_CONSOLE's ui_out when INTERP_MI is active.
1885
1886 2019-11-19  Tom Tromey  <tom@tromey.com>
1887
1888         * tui/tui-win.c (tui_partial_win_by_name): Move from tui-data.c.
1889         Now static.  Change type of "name".
1890         (tui_set_win_height_command): Don't copy "arg".
1891         * tui/tui-data.h (tui_partial_win_by_name): Don't declare.
1892         * tui/tui-data.c (tui_partial_win_by_name): Move to tui-win.c.
1893
1894 2019-11-19  Ali Tamur <tamur@google.com>
1895
1896         * dwarf2read.c (dw2_get_file_names_reader): Replace "if (attr)" with
1897         "if (attr != nullptr)".
1898         (dwarf2_find_base_address): Likewise.
1899         (dwarf2_build_include_psymtabs): Likewise.
1900         (read_cutu_die_from_dwo): Likewise.
1901         (read_func_scope): Likewise.
1902         (read_call_site_scope): Likewise.
1903         (dwarf2_get_pc_bounds): Likewise.
1904         (dwarf2_record_block_ranges): Likewise.
1905         (dwarf2_add_field): Likewise.
1906         (dwarf2_add_member_fn): Likewise.
1907         (read_structure_type): Likewise.
1908         (read_enumeration_type): Likewise.
1909         (read_array_type): Likewise.
1910         (read_array_order): Likewise.
1911         (read_set_type): Likewise.
1912         (read_common_block): Likewise.
1913         (read_tag_reference_type): Likewise.
1914         (read_tag_string_type): Likewise.
1915         (read_subroutine_type): Likewise.
1916         (read_base_type): Likewise.
1917         (read_subrange_type): Likewise.
1918         (new_symbol): Likewise.
1919         (prepare_one_comp_unit): Likewise.
1920
1921 2019-11-19  Tom Tromey  <tromey@adacore.com>
1922
1923         * windows-nat.c (windows_nat_target::attach): Include GetLastError
1924         result in error when DebugActiveProcess fails.
1925
1926 2019-11-18  Sergio Durigan Junior  <sergiodj@redhat.com>
1927             Pedro Alves  <palves@redhat.com>
1928
1929         https://bugzilla.redhat.com/show_bug.cgi?id=1765117
1930         * target.c (target_stack::push): Call 'unpush' if there's a
1931         target on top of the stack.
1932
1933 2019-11-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1934
1935         * python/py-block.c (blpy_dealloc): Call tp_free.
1936         (blpy_block_syms_dealloc): Likewise.
1937         * python/py-finishbreakpoint.c (bpfinishpy_dealloc): Likewise.
1938         * python/py-inferior.c (infpy_dealloc): Likewise.
1939         * python/py-lazy-string.c (stpy_dealloc): Likewise.
1940         * python/py-linetable.c (ltpy_iterator_dealloc): Likewise.
1941         * python/py-symbol.c (sympy_dealloc): Likewise.
1942         * python/py-symtab.c (stpy_dealloc): Likewise.
1943         * python/py-type.c (typy_iterator_dealloc): Likewise.
1944
1945 2019-11-18  Christian Biesinger  <cbiesinger@google.com>
1946
1947         * symtab.h (struct symbol) <owner>: Initialize explicitly in the
1948         constructor instead of using a class initializer.
1949
1950 2019-11-15  Christian Biesinger  <cbiesinger@google.com>
1951
1952         * Makefile.in: Replace {posix,mingw}-strerror.c with safe-strerror.c.
1953         * configure: Regenerate.
1954         * configure.ac: Don't source common.host.
1955         * gdbsupport/common.host: Remove.
1956         * gdbsupport/mingw-strerror.c: Remove.
1957         * gdbsupport/posix-strerror.c: Rename to...
1958         * gdbsupport/safe-strerror.c: ...this.
1959
1960 2019-11-15  Christian Biesinger  <cbiesinger@google.com>
1961
1962         * maint.c (scoped_command_stats::print_time): Use localtime_r
1963         instead of localtime (provided through gnulib if necessary).
1964         * nat/linux-osdata.c (time_from_time_t): Use ctime_r instead
1965         of ctime.
1966
1967 2019-11-15  Christian Biesinger  <cbiesinger@google.com>
1968
1969         * gdbsupport/common-defs.h: Include time.h before pathmax.h to
1970         avoid compile errors.
1971
1972 2019-11-15  Christian Biesinger  <cbiesinger@google.com>
1973
1974         * config.in: Regenerate.
1975         * configure: Regenerate.
1976         * gdbsupport/common.m4: No longer check for strerror_r.
1977         * gdbsupport/posix-strerror.c (safe_strerror): Always call the
1978         POSIX version of strerror_r, now that gnulib provides it if
1979         necessary.
1980
1981 2019-11-14  Christian Biesinger  <cbiesinger@google.com>
1982
1983         * README (`configure' options): Update.
1984
1985 2019-11-14  Tom Tromey  <tromey@adacore.com>
1986
1987         * eval.c (evaluate_subexp_standard) <BINOP_ASSIGN>: Do not pass an
1988         expected type for the RHS if the LHS is a convenience variable.
1989
1990 2019-11-14  Simon Marchi  <simon.marchi@polymtl.ca>
1991
1992         * unittests/vec-utils-selftests.c (unordered_remove_tests::obj):
1993         Provide explicit default and copy constructor.
1994
1995 2019-11-14  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1996
1997         * python/py-finishbreakpoint.c (gdbpy_breakpoint_created):
1998         only call Py_INCREF (newbp) in the bppy_pending_object case.
1999
2000 2019-11-13  Tom Tromey  <tromey@adacore.com>
2001
2002         PR build/25182:
2003         * psympriv.h (partial_symbol): Remove static assert.
2004         * symtab.h (general_symbol_info, symbol): Remove static assert.
2005
2006 2019-11-12  Andrew Burgess  <andrew.burgess@embecosm.com>
2007
2008         * gdbsupport/format.c (format_pieces::format_pieces): Support
2009         printf 'z' size modifier.
2010         * gdbsupport/format.h (enum argclass): Add size_t_arg.
2011         * printcmd.c (ui_printf):  Handle size_t_arg.
2012         * ui-out.c (ui_out::vmessage): Likewise.
2013         * unittests/format_pieces-selftests.c (test_format_int_sizes): New
2014         function.
2015         (run_tests): Call test_format_int_sizes.
2016
2017 2019-11-12  Christian Biesinger  <cbiesinger@google.com>
2018
2019         * ada-exp.y (write_ambiguous_var): Update.
2020         * buildsym.c (add_symbol_to_list): Update.
2021         * dwarf2read.c (read_variable): Update.
2022         (new_symbol): Update.
2023         * jit.c (finalize_symtab): Update.
2024         * language.c (language_alloc_type_symbol): Update.
2025         * symtab.c (fixup_symbol_section): Update.
2026         (initialize_objfile_symbol_1): Move code to...
2027         (initialize_objfile_symbol): ...here. Remove now-unnecessary memset.
2028         (allocate_symbol): Update.
2029         (allocate_template_symbol): Update.
2030         (get_symbol_address): Update.
2031         * symtab.h (struct symbol): Inherit from general_symbol_info instead
2032         of having as a field, and add a constructor.
2033         (SYMBOL_VALUE): Update.
2034         (SYMBOL_VALUE_ADDRESS): Update.
2035         (SET_SYMBOL_VALUE_ADDRESS): Update.
2036         (SYMBOL_VALUE_BYTES): Update.
2037         (SYMBOL_VALUE_COMMON_BLOCK): Update.
2038         (SYMBOL_BLOCK_VALUE): Update.
2039         (SYMBOL_VALUE_CHAIN): Update.
2040         (SYMBOL_LANGUAGE): Update.
2041         (SYMBOL_SECTION): Update.
2042         (SYMBOL_OBJ_SECTION): Update.
2043         (SYMBOL_SET_LANGUAGE): Update.
2044         (SYMBOL_SET_LINKAGE_NAME): Update.
2045         (SYMBOL_SET_NAMES): Update.
2046         (SYMBOL_NATURAL_NAME): Update.
2047         (SYMBOL_LINKAGE_NAME): Update.
2048         (SYMBOL_DEMANGLED_NAME): Update.
2049         (SYMBOL_SEARCH_NAME): Update.
2050         (SYMBOL_MATCHES_SEARCH_NAME): Update.
2051         (struct symbol): Update.
2052         (struct template_symbol): Update.
2053         (struct rust_vtable_symbol): Update.
2054         * xcoffread.c (SYMBOL_DUP): Update.
2055
2056 2019-11-12  Tom Tromey  <tom@tromey.com>
2057
2058         * tui/tui-layout.c (show_layout): Set current_layout.
2059         (show_source_disasm_command, show_data)
2060         (show_source_or_disasm_and_command): Don't set current_layout.
2061
2062 2019-11-12  Tom Tromey  <tom@tromey.com>
2063
2064         * tui/tui-layout.c (_initialize_tui_layout): Move to end.
2065
2066 2019-11-12  Tom Tromey  <tom@tromey.com>
2067
2068         * tui/tui-win.c (resize_message): New global.
2069         (show_tui_resize_message): New function.
2070         (tui_async_resize_screen): Print message if requested.
2071         (_initialize_tui_win): Add tui-resize-message setting.
2072         * NEWS: Add entry for new commands.
2073
2074 2019-11-11  Tom Tromey  <tom@tromey.com>
2075
2076         * tui/tui.c (tui_initialize_readline): Add new bindable readline
2077         functions.
2078
2079 2019-11-11  Christian Biesinger  <cbiesinger@google.com>
2080
2081         * nat/linux-osdata.c (user_from_uid): Use getpwuid_r.
2082
2083 2019-11-10  Andrew Burgess  <andrew.burgess@embecosm.com>
2084
2085         * python/py-symbol.c (gdbpy_lookup_static_symbols): New
2086         function.
2087         * python/python-internal.h (gdbpy_lookup_static_symbols):
2088         Declare new function.
2089         * python/python.c (python_GdbMethods): Add
2090         gdb.lookup_static_symbols method.
2091         * NEWS: Mention gdb.lookup_static_symbols.
2092
2093 2019-11-10  Andrew Burgess  <andrew.burgess@embecosm.com>
2094
2095         * python/py-symbol.c (gdbpy_lookup_static_symbol): Lookup in
2096         static block of current object file first.  Also fix typo in
2097         header comment.
2098
2099 2019-11-10  Andrew Burgess  <andrew.burgess@embecosm.com>
2100
2101         * stack.c (set_last_displayed_sal): Delete.
2102         (last_displayed_sal_valid): Delete.
2103         (last_displayed_pspace): Delete.
2104         (last_displayed_addr): Delete.
2105         (last_displayed_symtab): Delete.
2106         (last_displayed_line): Delete.
2107         (class last_displayed_symtab_info_type): New.
2108         (last_displayed_symtab_info): New static global variable.
2109         (print_frame_info): Call methods on last_displayed_symtab_info.
2110         (clear_last_displayed_sal): Update header comment, and make use of
2111         last_displayed_symtab_info.
2112         (last_displayed_sal_is_valid): Likewise.
2113         (get_last_displayed_pspace): Likewise.
2114         (get_last_displayed_addr): Likewise.
2115         (get_last_displayed_symtab): Likewise.
2116         (get_last_displayed_line): Likewise.
2117         (get_last_displayed_sal): Likewise.
2118         * stack.h (clear_last_displayed_sal): Update header comment.
2119         (last_displayed_sal_is_valid): Likewise.
2120         (get_last_displayed_pspace): Likewise.
2121         (get_last_displayed_addr): Likewise.
2122         (get_last_displayed_symtab): Likewise.
2123         (get_last_displayed_line): Likewise.
2124         (get_last_displayed_sal): Likewise.
2125
2126 2019-11-10  Andrew Burgess  <andrew.burgess@embecosm.com>
2127
2128         * stack.c (frame_show_address): Convert return type to bool.
2129         * stack.h (frame_show_address): Likewise, and update header
2130         comment.
2131
2132 2019-11-10  Andrew Burgess  <andrew.burgess@embecosm.com>
2133
2134         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add new file to the list.
2135         * unittests/vec-utils-selftests.c: New file.
2136         * gdbsupport/gdb_vecs.h (unordered_remove): Avoid self move assign.
2137
2138 2019-11-10  Tom Tromey  <tom@tromey.com>
2139
2140         * tui/tui-wingeneral.c (tui_unhighlight_win): Use can_box.
2141         (tui_highlight_win): Likewise.
2142         (tui_win_info::check_and_display_highlight_if_needed): Likewise.
2143         * tui/tui-data.h (struct tui_win_info) <can_highlight>: Remove.
2144         * tui/tui-command.h (struct tui_cmd_window) <tui_cmd_window>:
2145         Don't set can_highlight.
2146
2147 2019-11-10  Tom Tromey  <tom@tromey.com>
2148
2149         * cli/cli-style.h (class cli_style_option) <cli_style_option>:
2150         Remove unused declaration.
2151
2152 2019-11-08  Tom Tromey  <tromey@adacore.com>
2153
2154         * top.c (read_command_file): Update.
2155         (command_line_input): Make return type const.
2156         * python/py-gdb-readline.c: Update.
2157         * linespec.c (decode_line_2): Update.
2158         * defs.h (command_line_input): Make return type const.
2159         * cli/cli-script.c (read_next_line): Make return type const.
2160         * ada-lang.c (get_selections): Update.
2161
2162 2019-11-06  Christian Biesinger  <cbiesinger@google.com>
2163
2164         * linux-tdep.c (linux_info_proc): Use strtok_r instead of strtok.
2165         * mi/mi-main.c (output_cores): Likewise.
2166         * nat/linux-osdata.c (linux_xfer_osdata_cpus): Likewise.
2167         (linux_xfer_osdata_modules): Likewise.
2168         * remote.c (register_remote_support_xml): Likewise.
2169         * sparc64-tdep.c (adi_is_addr_mapped): Likewise.
2170         * xml-syscall.c (syscall_create_syscall_desc): Likewise.
2171
2172 2019-11-06  Tom Tromey  <tom@tromey.com>
2173
2174         * tui/tui-interp.c: Don't include readline.h.
2175         * tui/tui-hooks.c: Don't include readline.h.
2176         * symmisc.c: Include tilde.h, not readline.h.
2177         * symfile.c: Include tilde.h, not readline.h.
2178         * source.c: Include tilde.h, not readline.h.
2179         * solib.c: Include tilde.h, not readline.h.
2180         * psymtab.c: Include tilde.h, not readline.h.
2181         * exec.c: Include tilde.h, not readline.h.
2182         * corelow.c: Include tilde.h, not readline.h.
2183         * cli/cli-dump.c: Include tilde.h, not readline.h.
2184         * cli/cli-cmds.c: Don't include readline.h.
2185
2186 2019-11-05  Tom Tromey  <tom@tromey.com>
2187
2188         * tui/tui-disasm.c (struct tui_asm_line) <addr_size>: New member.
2189         (tui_disassemble): Set addr_size.
2190         (tui_disasm_window::set_contents): Use addr_size.
2191
2192 2019-11-05  Tom Tromey  <tom@tromey.com>
2193
2194         * rust-lang.c (rust_language_defn): Update.
2195         * python/py-value.c (valpy_string): Call c_get_string.
2196         * p-lang.c (pascal_language_defn): Update.
2197         * opencl-lang.c (opencl_language_defn): Update.
2198         * objc-lang.c (objc_language_defn): Update.
2199         * m2-lang.c (m2_language_defn): Update.
2200         * language.c (unknown_language_defn, auto_language_defn): Update.
2201         (default_get_string): Remove.
2202         * guile/scm-value.c (gdbscm_value_to_string): Use c_get_string.
2203         * go-lang.c (go_language_defn): Update.
2204         * f-lang.c (f_language_defn): Update.
2205         * d-lang.c (d_language_defn): Update.
2206         * c-lang.c (c_language_defn, cplus_language_defn)
2207         (asm_language_defn, minimal_language_defn): Update.
2208         * ada-lang.c (ada_language_defn): Update.
2209         * language.h (struct language_defn) <la_get_string>: Remove.
2210         (LA_GET_STRING): Remove.
2211         (default_get_string): Don't declare.
2212
2213 2019-11-05  Tom Tromey  <tom@tromey.com>
2214
2215         * tui/tui-source.h (struct tui_source_window): Inline
2216         constructor.  Remove destructor.
2217         <style_changed, m_observable>: Move to superclass.
2218         * tui/tui-winsource.h (tui_copy_source_line): Declare.
2219         (struct tui_source_window_base): Move private members to end.
2220         <style_changed, m_observable>: Move from tui_source_window.
2221         * tui/tui-winsource.c (tui_copy_source_line): Move from
2222         tui-source.c.  Rename from copy_source_line.  Add special handling
2223         for negative line number.
2224         (tui_source_window_base::style_changed): Move from
2225         tui_source_window.
2226         (tui_source_window_base): Register observer.
2227         (~tui_source_window_base): New.
2228         * tui/tui-source.c (copy_source_line): Move to tui-winsource.c;
2229         rename.
2230         (tui_source_window::set_contents): Use tui_copy_source_line.
2231         (tui_source_window::tui_source_window): Move to tui-source.h.
2232         (tui_source_window::~tui_source_window): Remove.
2233         (tui_source_window::style_changed): Move to superclass.
2234         * tui/tui-disasm.c (tui_disassemble): Create string file with
2235         styling, when possible.  Add "addr_size" parameter.
2236         (tui_disasm_window::set_contents): Use tui_copy_source_line.
2237         Don't compute maximum size.
2238         (len_without_escapes): New function
2239
2240 2019-11-05  Tom Tromey  <tom@tromey.com>
2241
2242         * tui/tui-winsource.h (struct tui_source_element) <line>: Now a
2243         std::string.
2244         * tui/tui-winsource.c (tui_show_source_line): Update.
2245         * tui/tui-source.c (tui_source_window::set_contents): Update.
2246         * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
2247
2248 2019-11-05  Christian Biesinger  <cbiesinger@google.com>
2249
2250         * symtab.h (gdb_static_assert): Put && operator at the beginning
2251         of the line instead of the end.
2252
2253 2019-11-04  Christian Biesinger  <cbiesinger@google.com>
2254
2255         * psympriv.h: Add static_asserts for sizeof (general_symbol_info)
2256         and sizeof (symbol).
2257         * symtab.h: Add a static_assert for sizeof (partial_symbol).
2258
2259 2019-11-04  Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
2260
2261         * NEWS (Changes since GDB 8.3): Document Solaris 10 removal.
2262         * configure.host: Mark *-*-solaris2.10* obsolete.
2263         * configure.tgt: Mark Solaris < 11 obsolete.
2264         * MAINTAINERS (Target Instruction Set Architectures) <sparc>:
2265         Update target triplet.
2266
2267 2019-11-01  Tom Tromey  <tromey@adacore.com>
2268
2269         * utils.c (print_sys_errmsg): Simplify.
2270
2271 2019-11-01  Tom Tromey  <tromey@adacore.com>
2272
2273         * gdbsupport/mingw-strerror.c (safe_strerror): Constify result.
2274
2275 2019-11-01  Christian Biesinger  <cbiesinger@google.com>
2276
2277         * configure: Regenerate.
2278         * configure.ac: Remove check for strerror_r.
2279         * gdbsupport/common.m4: Check for strerror_r.
2280
2281 2019-11-01  Luis Machado  <luis.machado@linaro.org>
2282
2283         PR gdb/25124
2284
2285         * arm-tdep.c (arm_per_objfile): Rename to ...
2286         (arm_per_bfd): ... this.
2287         (arm_objfile_data_key): Rename to ...
2288         (arm_bfd_data_key): ... this.
2289         (arm_find_mapping_symbol): Adjust access to new bfd_key-based
2290         data.
2291         (arm_record_special_symbol): Likewise.
2292
2293 2019-10-31  Andrew Burgess  <andrew.burgess@embecosm.com>
2294
2295         * ada-typeprint.c (ada_print_typedef): Don't print newline at the
2296         end.
2297         * c-typeprint.c (c_print_typedef): Likewise.
2298         * f-typeprint.c (f_print_typedef): Likewise.
2299         * m2-typeprint.c (m2_print_typedef): Likewise.
2300         * p-typeprint.c (pascal_print_typedef): Likewise.
2301         * rust-lang.c (rust_print_typedef): Likewise.
2302         * symtab.c (print_symbol_info): Print a newline after calling
2303         typedef_print.
2304
2305 2019-10-31  Andrew Burgess  <andrew.burgess@embecosm.com>
2306
2307         * symtab.c (info_module_cmdlist): New variable.
2308         (info_module_command): New function.
2309         (search_module_symbols): New function.
2310         (info_module_subcommand): New function.
2311         (struct info_modules_var_func_options): New struct.
2312         (info_modules_var_func_options_defs): New variable.
2313         (make_info_modules_var_func_options_def_group): New function.
2314         (info_module_functions_command): New function.
2315         (info_module_variables_command): New function.
2316         (info_module_var_func_command_completer): New function.
2317         (_initialize_symtab): Register new 'info module functions' and
2318         'info module variables' commands.
2319         * symtab.h (typedef symbol_search_in_module): New typedef.
2320         (search_module_symbols): Declare new function.
2321         * NEWS: Mention new commands.
2322
2323 2019-10-31  Andrew Burgess  <andrew.burgess@embecosm.com>
2324
2325         * dwarf2read.c (dw2_symtab_iter_next): Handle MODULE_DOMAIN.
2326         (dw2_expand_marked_cus): Handle MODULES_DOMAIN.
2327         (dw2_debug_names_iterator::next): Handle MODULE_DOMAIN and
2328         MODULES_DOMAIN.
2329         (scan_partial_symbols): Only create partial module symbols for non
2330         declarations.
2331         * psymtab.c (recursively_search_psymtabs): Handle MODULE_DOMAIN
2332         and MODULES_DOMAIN.
2333         * symtab.c (search_domain_name): Likewise.
2334         (search_symbols): Likewise.
2335         (print_symbol_info): Likewise.
2336         (symtab_symbol_info): Likewise.
2337         (info_modules_command): New function.
2338         (_initialize_symtab): Register 'info modules' command.
2339         * symtab.h (enum search_domain): Add MODULES_DOMAIN.
2340         * NEWS: Mention new 'info modules' command.
2341
2342 2019-10-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2343
2344         * NEWS: Mention $_gdb_setting, $_gdb_setting_str, $_gdb_maint_setting
2345         and $_gdb_maint_setting_str.
2346
2347 2019-10-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2348
2349         * cli/cli-cmds.c (setting_cmd, value_from_setting)
2350         (gdb_setting_internal_fn, gdb_maint_setting_internal_fn)
2351         (str_value_from_setting, gdb_setting_str_internal_fn)
2352         (gdb_maint_setting_str_internal_fn): New functions.
2353         (_initialize_cli_cmds): Define the new convenience functions.
2354         * gdb/cli/cli-setshow.h (get_setshow_command_value_string): Constify.
2355         * gdb/cli/cli-setshow.c (get_setshow_command_value_string): Constify.
2356
2357 2019-10-31  Christian Biesinger  <cbiesinger@google.com>
2358
2359         * agent.c (set_can_use_agent): When the setting is turned on,
2360         look up agent symbols if we don't have them yet.
2361         (agent_new_objfile): Don't look up agent symbols when the agent
2362         setting is off.
2363
2364 2019-10-31  Christian Biesinger  <cbiesinger@google.com>
2365
2366         * config.in: Regenerate.
2367
2368 2019-10-31  Christian Biesinger  <cbiesinger@google.com>
2369
2370         * configure: Regenerate.
2371         * configure.ac: Check for strerror_r.
2372         * gdbsupport/common-utils.h (safe_strerror): Change return value
2373         to const char * and document that this function is now threadsafe.
2374         * gdbsupport/posix-strerror.c (safe_strerror): Make buf
2375         thread_local and call strerror_r, if available.
2376         * utils.c (perror_string): Update.
2377         (print_sys_errmsg): Update.
2378
2379 2019-10-31  Luis Machado  <luis.machado@linaro.org>
2380
2381         * arm-tdep.c (arm_exidx_data_key): Use bfd_key instead of
2382         objfile_key.
2383         (arm_exidx_new_objfile): Adjust to use objfile->obfd instead of
2384         objfile to fetch per-bfd data.
2385         (arm_find_exidx_entry): Likewise.
2386
2387 2019-10-31  Christian Biesinger  <cbiesinger@google.com>
2388
2389         * gdbsupport/agent.c (debug_agent): Change type to bool.
2390         (use_agent): Likewise.
2391         (all_agent_symbols_look_up): Likewise.
2392         (agent_loaded_p): Change return value to bool.
2393         (agent_look_up_symbols): Update.
2394         (agent_capability_check): Change return value to bool.
2395         * gdbsupport/agent.h (agent_loaded_p): Likewise.
2396         (debug_agent): Change type to bool.
2397         (use_agent): Likewise.
2398         (agent_capability_check): Change return value to bool.
2399
2400 2019-10-30  Christian Biesinger  <cbiesinger@google.com>
2401
2402         * minsyms.c (clear_minimal_symbol_hash_tables): New function.
2403         (build_minimal_symbol_hash_tables): Code to clear the table moved
2404         to clear_minimal_symbol_hash_tables.
2405         (minimal_symbol_reader::install): Call clear_minimal_symbol_hash_tables
2406         when needed.
2407
2408 2019-10-29  Simon Marchi  <simon.marchi@polymtl.ca>
2409
2410         * infcmd.c: Remove includes.
2411         * infrun.c: Remove includes.
2412
2413 2019-10-29  Simon Marchi  <simon.marchi@polymtl.ca>
2414
2415         * ada-lang.h (GROW_VECT): Move to ada-lang.c.
2416         (grow_vect): Remove declaration.
2417         (ada_type_of_array): Remove declaration.
2418         (ada_update_initial_language): Remove declaration.
2419         (ada_fold_name): Remove declaration.
2420         (ada_fill_in_ada_prototype): Remove declaration.
2421         (user_select_syms): Remove declaration.
2422         (get_selections): Remove declaration.
2423         (ada_tag_type): Remove declaration.
2424         (ada_value_tag): Remove declaration.
2425         (ada_is_others_clause): Remove declaration.
2426         (ada_in_variant): Remove declaration.
2427         (ada_value_struct_elt): Remove declaration.
2428         (ada_attribute_name): Remove declaration.
2429         (ada_system_address_type): Remove declaration.
2430         * ada-lang.c (ada_watch_location_expression): Make static.
2431         (GROW_VECT): Move here from ada-lang.h.
2432         (grow_vect): Make static.
2433         (ada_update_initial_language): Make static.
2434         (ada_fold_name): Make static.
2435         (ada_type_of_array): Make static.
2436         (encoded_ordered_before): Move up.
2437         (sort_choices): Move up.
2438         (print_signatures): Move up.
2439         (ada_print_symbol_signature): Move up.
2440         (get_selections): Move up and make static.
2441         (user_select_syms): Move up and make static.
2442         (ada_value_struct_elt): Move up and make static.
2443         (ada_tag_type): Make static.
2444         (ada_value_tag): Make static.
2445         (ada_is_others_clause): Make static.
2446         (ada_in_variant): Make static.
2447         (ada_attribute_name): Make static.
2448
2449 2019-10-29  Simon Marchi  <simon.marchi@polymtl.ca>
2450
2451         * ada-lang.c: Remove includes.
2452         * ada-typeprint.c: Remove includes.
2453         * ada-valprint.c: Remove includes.
2454
2455 2019-10-29  Simon Marchi  <simon.marchi@efficios.com>
2456
2457         * addrmap.c: Add static assertions of type size, moved from
2458         _initialize_addrmap.
2459         (_initialize_addrmap): Remove.
2460
2461 2019-10-29  Christian Biesinger  <cbiesinger@google.com>
2462
2463         * coffread.c (record_minimal_symbol): Update.
2464         (process_coff_symbol): Update.
2465         * dbxread.c (read_dbx_symtab): Update.
2466         * dwarf2read.c (add_partial_symbol): Update.
2467         (fixup_go_packaging): Update.
2468         (load_partial_dies): Update.
2469         (new_symbol): Update.
2470         * elfread.c (record_minimal_symbol): Change signature to use
2471         gdb::string_view instead of name+len.
2472         (elf_symtab_read): Update.
2473         (elf_rel_plt_read): Update.
2474         * mdebugread.c (parse_partial_symbols): Update.
2475         (handle_psymbol_enumerators): Update.
2476         (new_symbol): Update.
2477         * minsyms.c (minimal_symbol_reader::record_full): Change signature
2478         to use gdb::string_view instead of name+len.
2479         * minsyms.h (class minimal_symbol_reader) <record_full>: Likewise.
2480         * psympriv.h (add_psymbol_to_list): Likewise.
2481         * psymtab.c (add_psymbol_to_bcache): Likewise.
2482         (add_psymbol_to_list): Likewise.
2483         * stabsread.c (define_symbol): Update.
2484         * symtab.c (symbol_set_names): Change signature to use gdb::string_view.
2485         * symtab.h (SYMBOL_SET_NAMES): Likewise.
2486         (symbol_set_names): Likewise.
2487         * xcoffread.c (scan_xcoff_symtab): Update.
2488
2489 2019-10-29  Christian Biesinger  <cbiesinger@google.com>
2490
2491         * symtab.h (symbol_set_names): Document that copy_name must be
2492         set to true for non-nullterminated strings.
2493         * symtab.c (symbol_set_names): Only make a nullterminated copy of
2494         linkage_name if the entry was not found and we need to demangle.
2495
2496 2019-10-29  Christian Biesinger  <cbiesinger@google.com>
2497
2498         * Makefile.in (HFILES_NO_SRCDIR): Add gdb_binary_search.h.
2499         * dwarf2-frame.c (bsearch_fde_cmp): Update.
2500         (dwarf2_frame_find_fde): Replace bsearch with gdb::binary_search.
2501         * gdbsupport/gdb_binary_search.h: New file.
2502
2503 2019-10-29  Christian Biesinger  <cbiesinger@google.com>
2504
2505         * NEWS: Mention new --with-system-gdbinit-dir option.
2506         * config.in: Regenerate.
2507         * configure: Regenerate.
2508         * configure.ac: Add new option --with-system-gdbinit-dir.
2509         * extension.c (get_ext_lang_of_file): Return extension_language_gdb
2510         for a ".gdb" suffix.
2511         * main.c (get_init_files): Change system_gdbinit argument to
2512         a vector and return the files in SYSTEM_GDBINIT_DIR in
2513         addition to SYSTEM_GDBINIT.
2514         (captured_main_1): Update.
2515         (print_gdb_help): Update.
2516         * top.c (print_gdb_configuration): Also print the value of
2517         SYSTEM_GDBINIT_DIR.
2518
2519 2019-10-28  Christian Biesinger  <cbiesinger@google.com>
2520
2521         * gdbsupport/common-utils.h (startswith): Add an overloaded version
2522         that takes gdb::string_view arguments.
2523
2524 2019-10-26  Tom de Vries  <tdevries@suse.de>
2525
2526         * aarch64-linux-tdep.c: Fix typos in comments.
2527         * aarch64-tdep.c: Same.
2528         * ada-lang.c: Same.
2529         * amd64-nat.c: Same.
2530         * arc-tdep.c: Same.
2531         * arch/aarch64-insn.c: Same.
2532         * block.c: Same.
2533         * breakpoint.h: Same.
2534         * btrace.h: Same.
2535         * c-varobj.c: Same.
2536         * cli/cli-decode.c: Same.
2537         * cli/cli-script.c: Same.
2538         * cli/cli-utils.h: Same.
2539         * coff-pe-read.c: Same.
2540         * coffread.c: Same.
2541         * compile/compile-cplus-symbols.c: Same.
2542         * compile/compile-object-run.c: Same.
2543         * completer.c: Same.
2544         * corelow.c: Same.
2545         * cp-support.c: Same.
2546         * demangle.c: Same.
2547         * dwarf-index-write.c: Same.
2548         * dwarf2-frame.c: Same.
2549         * dwarf2-frame.h: Same.
2550         * eval.c: Same.
2551         * frame-base.h: Same.
2552         * frame.h: Same.
2553         * gdbcmd.h: Same.
2554         * gdbtypes.h: Same.
2555         * gnu-nat.c: Same.
2556         * guile/scm-objfile.c: Same.
2557         * i386-tdep.c: Same.
2558         * i386-tdep.h: Same.
2559         * infcall.c: Same.
2560         * infcall.h: Same.
2561         * linux-nat.c: Same.
2562         * m68k-tdep.c: Same.
2563         * macroexp.c: Same.
2564         * memattr.c: Same.
2565         * mi/mi-cmd-disas.c: Same.
2566         * mi/mi-getopt.h: Same.
2567         * mi/mi-main.c: Same.
2568         * minsyms.c: Same.
2569         * nat/aarch64-sve-linux-sigcontext.h: Same.
2570         * objfiles.h: Same.
2571         * ppc-linux-nat.c: Same.
2572         * ppc-linux-tdep.c: Same.
2573         * ppc-tdep.h: Same.
2574         * progspace.h: Same.
2575         * prologue-value.h: Same.
2576         * python/py-evtregistry.c: Same.
2577         * python/py-instruction.h: Same.
2578         * record-btrace.c: Same.
2579         * record-full.c: Same.
2580         * remote.c: Same.
2581         * rs6000-tdep.c: Same.
2582         * ser-tcp.c: Same.
2583         * sol-thread.c: Same.
2584         * sparc-sol2-tdep.c: Same.
2585         * sparc64-tdep.c: Same.
2586         * stabsread.c: Same.
2587         * symfile.c: Same.
2588         * symtab.h: Same.
2589         * target.c: Same.
2590         * tracepoint.c: Same.
2591         * tui/tui-data.h: Same.
2592         * tui/tui-io.c: Same.
2593         * tui/tui-win.c: Same.
2594         * tui/tui.c: Same.
2595         * unittests/rsp-low-selftests.c: Same.
2596         * user-regs.h: Same.
2597         * utils.c: Same.
2598         * utils.h: Same.
2599         * valarith.c: Same.
2600         * valops.c: Same.
2601         * valprint.c: Same.
2602         * valprint.h: Same.
2603         * value.c: Same.
2604         * value.h: Same.
2605         * varobj.c: Same.
2606         * x86-nat.h: Same.
2607         * xtensa-tdep.c: Same.
2608
2609 2019-10-25  Ali Tamur <tamur@google.com>
2610
2611         * charset.c (find_charset_names): Reflect API change.
2612
2613 2019-10-25  Christian Biesinger  <cbiesinger@google.com>
2614
2615         * symtab.c (struct demangled_name_entry): Change demangled name
2616         to a unique_xmalloc_ptr<char>, now that we don't allocate it as
2617         part of the struct anymore.
2618         (symbol_set_names): No longer obstack allocate + copy the demangled
2619         name, just store the allocated name from bfd.
2620
2621 2019-10-25  Tom Tromey  <tromey@adacore.com>
2622
2623         * dwarf2-frame.c (dwarf2_cie_table): Now a typedef.
2624         (bsearch_cie_cmp, add_cie): Remove.
2625         (find_cie): Reimplement.
2626         (decode_frame_entry_1, decode_frame_entry): Change type.  Update.
2627         (dwarf2_build_frame_info): Update.
2628
2629 2019-10-24  H.J. Lu  <hongjiu.lu@intel.com>
2630
2631         PR gdb/25126
2632         * symfile.c (reread_symbols): Call forget_cached_source_info to
2633         clear the stale source cache.
2634
2635 2019-10-24  Christian Biesinger  <cbiesinger@google.com>
2636
2637         * configure: Regenerate.
2638         * configure.ac: Remove code that sets python_has_threads.
2639
2640 2019-10-24  Christian Biesinger  <cbiesinger@google.com>
2641
2642         * config.in: Regenerate.
2643         * configure: Regenerate.
2644         * configure.ac: Remove the code that uses sed to get the python
2645         version and defines HAVE_LIBPYTHON2_6 / HAVE_LIBPYTHON2_7.
2646
2647 2019-10-24  Andrew Burgess  <andrew.burgess@embecosm.com>
2648
2649         * python/py-progspace.c (pspy_block_for_pc): Return None for all
2650         error paths.
2651
2652 2019-10-23  Tom Tromey  <tom@tromey.com>
2653
2654         * arc-tdep.c: Remove ".." from include.
2655         * frv-tdep.c: Remove ".." from include.
2656         * lm32-tdep.c: Remove ".." from include.
2657         * microblaze-tdep.c: Remove ".." from include.
2658         * or1k-tdep.h: Remove ".." from include.
2659         * s12z-tdep.c: Remove ".." from include.
2660         * Makefile.in (OPCODES_CFLAGS): Add comment.
2661         (TOP_CFLAGS): New variable.
2662         (INTERNAL_CFLAGS_BASE): Add TOP_CFLAGS.
2663
2664 2019-10-23  Tom Tromey  <tom@tromey.com>
2665
2666         * Makefile.in (READLINE_DIR): Update.
2667
2668 2019-10-23  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
2669
2670         * infcall.c (call_function_by_hand_dummy): Fix the function
2671         comment.  And extract out a code section into...
2672         (reserve_stack_space): ...this new function.
2673
2674 2019-10-23  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
2675
2676         * infcall.c (value_arg_coerce): Remove an unused parameter.
2677         (call_function_by_hand_dummy): Update the call to
2678         'value_arg_coerce'.
2679
2680 2019-10-23  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
2681
2682         * infcall.c (call_function_by_hand_dummy): Refactor.
2683
2684 2019-10-23  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
2685
2686         * MAINTAINERS (Write After Approval): Add Tankut Baris Aktemur.
2687
2688 2019-10-23  Tom Tromey  <tom@tromey.com>
2689
2690         * configure: Rebuild.
2691         * configure.ac: Don't check for sigprocmask.
2692         * gdbsupport/common.m4 (GDB_AC_COMMON): Check for sigprocmask.
2693
2694 2019-10-23  Tom Tromey  <tom@tromey.com>
2695
2696         * configure: Rebuild.
2697         * acinclude.m4: Use m4_include, not sinclude.
2698
2699 2019-10-23  Tom de Vries  <tdevries@suse.de>
2700
2701         PR breakpoints/24687
2702         * symtab.c (iterate_over_some_symtabs): Apply gdb_realpath on fullname.
2703
2704 2019-10-22  Christian Biesinger  <cbiesinger@google.com>
2705
2706         * symtab.c (struct demangled_name_entry) <language>: Change from
2707         bitfield to regular variable.
2708
2709 2019-10-22  Christian Biesinger  <cbiesinger@google.com>
2710
2711         * symtab.c (struct demangled_name_entry): Add a constructor.
2712         (free_demangled_name_entry): New function to call the destructor
2713         for demangled_name_entry.
2714         (create_demangled_names_hash): Pass free_demangled_name_entry to
2715         htab_create_alloc.
2716         (symbol_set_names): Call placement new for demangled_name_entry.
2717         * utils.c: No longer include xxhash.h here, now that fast_hash
2718         is inlined in the header.
2719         * utils.h: Instead, include it here.
2720
2721 2019-10-22  Christian Biesinger  <cbiesinger@google.com>
2722
2723         * Makefile.in: Link with libxxhash.
2724         * config.in: Regenerate.
2725         * configure: Regenerate.
2726         * configure.ac: Search for libxxhash.
2727         * utils.c (fast_hash): Use xxhash if present.
2728
2729 2019-10-22  Christian Biesinger  <cbiesinger@google.com>
2730
2731         * utils.h (fast_hash): New function.
2732         * symtab.c (hash_demangled_name_entry): Call new function
2733         fast_hash.
2734
2735 2019-10-22  Christian Biesinger  <cbiesinger@google.com>
2736
2737         * symtab.c (struct demangled_name_entry): Change type of mangled
2738         to gdb::string_view. Also adds a constructor that takes the
2739         mangled name.
2740         (hash_demangled_name_entry): Update.
2741         (eq_demangled_name_entry): Update.
2742         (free_demangled_name_entry): New function to call the destructor
2743         now that this is not a POD anymore.
2744         (create_demangled_names_hash): Pass free_demangled_name_entry to
2745         htab_create_alloc.
2746         (symbol_set_names): Update.
2747
2748 2019-10-21  Ali Tamur  <tamu@google.com>
2749
2750         * dwarf2read.c (dir_index): Change type.
2751         (file_name_index): Likewise.
2752         (line_header::include_dir_at): Change comment and implementation on
2753         whether it is DWARF 5.
2754         (line_header::is_valid_file_index): New function.
2755         (line_header::file_name_at): Change comment and implementation on
2756         whether it is DWARF 5.
2757         (line_header::file_names): Change to private field renamed as
2758         m_file_names and introduce a new accessor method.
2759         (line_header::file_names_size): New method.
2760         (line_header::include_dirs): Change to private field and rename as
2761         m_include_dirs.
2762         (dw2_get_file_names_reader): Define local var at a smaller scope and
2763         reflect API change.
2764         (dwarf2_cu::setup_type_unit_groups): Reflect API change.
2765         (process_structure_scope): Likewise.
2766         (line_header::add_include_dir): Change message and reflect renaming.
2767         (line_header::add_file_name): Likewise.
2768         (read_formatted_entries): Handle DW_FORM_data16.
2769         (dwarf_decode_line_header): Fix line header length calculation.
2770         (psymtab_include_file_name): Change comment and API.
2771         (lnp_state_machine::m_file): Update comment and reflect type change.
2772         (lnp_state_machine::record_line): Reflect type change.
2773         (dwarf_decode_lines): Reflect API change.
2774         (file_file_name): Likewise.
2775         (file_full_name): Likewise.
2776
2777 2019-10-21  Andrew Burgess  <andrew.burgess@embecosm.com>
2778
2779         * objfiles.c (sort_cmp): Ensure that !(a < a) holds true.
2780
2781 2019-10-21  Tom Tromey  <tom@tromey.com>
2782
2783         * tui/tui-winsource.h (tui_exec_info_content): Remove typedef.
2784
2785 2019-10-21  Tom Tromey  <tom@tromey.com>
2786
2787         * configure.ac (nm.h): Conditionally create nm.h link.  Subst
2788         NM_H.   Use AC_CONFIG_LINKS.
2789         * configure: Rebuild.
2790         * Makefile.in (NM_H): New variable.
2791         (generated_files): Add NM_H.  Remove gcore.
2792         (nm.h, stamp-nmh): New targets.
2793
2794 2019-10-20  Tom Tromey  <tom@tromey.com>
2795
2796         * objfiles.h (unlink_objfile, put_objfile_before): Don't declare.
2797         * objfiles.c (unlink_objfile): Move earlier.  Now static.  Remove
2798         obsolete comment.
2799         (put_objfile_before): Now static.
2800
2801 2019-10-19  Simon Marchi  <simon.marchi@polymtl.ca>
2802
2803         * gdbsupport/common-utils.h (startswith): Change return type to
2804         bool.
2805
2806 2019-10-19  Christian Biesinger  <cbiesinger@google.com>
2807
2808         * bcache.c (bcache::print_statistics): Use std::sort instead of qsort.
2809         * breakpoint.c (bp_locations_compare): Rename to...
2810         (bp_location_is_less_than): ...this, and change to std::sort semantics.
2811         (update_global_location_list): Use std::sort instead of qsort.
2812         * buildsym.c (compare_line_numbers): Rename to...
2813         (lte_is_less_than): ...this, and change to std::sort semantics.
2814         (buildsym_compunit::end_symtab_with_blockvector): Use std::sort
2815         instead of qsort.
2816         * disasm.c (compare_lines): Rename to...
2817         (line_is_less_than): ...this, and change to std::sort semantics.
2818         (do_mixed_source_and_assembly_deprecated): Call std::sort instead
2819         of qsort.
2820         * dwarf2-frame.c (qsort_fde_cmp): Rename to...
2821         (fde_is_less_than): ...this, and change to std::sort semantics.
2822         (dwarf2_build_frame_info): Call std::sort instead of qsort.
2823         * mdebugread.c (compare_blocks):
2824         (block_is_less_than): ...this, and change to std::sort semantics.
2825         (sort_blocks): Call std::sort instead of qsort.
2826         * objfiles.c (qsort_cmp): Rename to...
2827         (sort_cmp): ...this, and change to std::sort semantics.
2828         (update_section_map): Call std::sort instead of qsort.
2829         * remote.c (compare_pnums): Remove.
2830         (map_regcache_remote_table): Call std::sort instead of qsort.
2831         * utils.c (compare_positive_ints): Remove.
2832         * utils.h (compare_positive_ints): Remove.
2833         * xcoffread.c (compare_lte): Remove.
2834         (arrange_linetable): Call std::sort instead of qsort.
2835
2836 2019-10-19  Sergio Durigan Junior  <sergiodj@redhat.com>
2837
2838         * symfile.c (init_entry_point_info): Fix typo.
2839         * i386-darwin-tdep.c (darwin_dwarf_signal_frame_p): Fix typo.
2840
2841 2019-10-18  Tom de Vries  <tdevries@suse.de>
2842
2843         * aarch64-tdep.c: Fix typos in comments.
2844         * ada-lang.c: Same.
2845         * ada-tasks.c: Same.
2846         * alpha-tdep.c: Same.
2847         * alpha-tdep.h: Same.
2848         * amd64-nat.c: Same.
2849         * amd64-windows-tdep.c: Same.
2850         * arc-tdep.c: Same.
2851         * arc-tdep.h: Same.
2852         * arch-utils.c: Same.
2853         * arm-nbsd-tdep.c: Same.
2854         * arm-tdep.c: Same.
2855         * ax-gdb.c: Same.
2856         * blockframe.c: Same.
2857         * btrace.c: Same.
2858         * c-varobj.c: Same.
2859         * coff-pe-read.c: Same.
2860         * coffread.c: Same.
2861         * cris-tdep.c: Same.
2862         * darwin-nat.c: Same.
2863         * dbxread.c: Same.
2864         * dcache.c: Same.
2865         * disasm.c: Same.
2866         * dtrace-probe.c: Same.
2867         * dwarf-index-write.c: Same.
2868         * dwarf2-frame-tailcall.c: Same.
2869         * dwarf2-frame.c: Same.
2870         * dwarf2read.c: Same.
2871         * eval.c: Same.
2872         * exceptions.c: Same.
2873         * fbsd-tdep.c: Same.
2874         * findvar.c: Same.
2875         * frame.c: Same.
2876         * frv-tdep.c: Same.
2877         * gnu-v3-abi.c: Same.
2878         * go32-nat.c: Same.
2879         * h8300-tdep.c: Same.
2880         * hppa-tdep.c: Same.
2881         * i386-linux-tdep.c: Same.
2882         * i386-tdep.c: Same.
2883         * ia64-libunwind-tdep.c: Same.
2884         * ia64-tdep.c: Same.
2885         * infcmd.c: Same.
2886         * infrun.c: Same.
2887         * linespec.c: Same.
2888         * linux-nat.c: Same.
2889         * linux-thread-db.c: Same.
2890         * machoread.c: Same.
2891         * mdebugread.c: Same.
2892         * mep-tdep.c: Same.
2893         * mn10300-tdep.c: Same.
2894         * namespace.c: Same.
2895         * objfiles.c: Same.
2896         * opencl-lang.c: Same.
2897         * or1k-tdep.c: Same.
2898         * osabi.c: Same.
2899         * ppc-linux-nat.c: Same.
2900         * ppc-linux-tdep.c: Same.
2901         * ppc-sysv-tdep.c: Same.
2902         * printcmd.c: Same.
2903         * procfs.c: Same.
2904         * record-btrace.c: Same.
2905         * record-full.c: Same.
2906         * remote-fileio.c: Same.
2907         * remote.c: Same.
2908         * rs6000-tdep.c: Same.
2909         * s12z-tdep.c: Same.
2910         * score-tdep.c: Same.
2911         * ser-base.c: Same.
2912         * ser-go32.c: Same.
2913         * skip.c: Same.
2914         * sol-thread.c: Same.
2915         * solib-svr4.c: Same.
2916         * solib.c: Same.
2917         * source.c: Same.
2918         * sparc-nat.c: Same.
2919         * sparc-sol2-tdep.c: Same.
2920         * sparc-tdep.c: Same.
2921         * sparc64-tdep.c: Same.
2922         * stabsread.c: Same.
2923         * stack.c: Same.
2924         * symfile.c: Same.
2925         * symtab.c: Same.
2926         * target-descriptions.c: Same.
2927         * target-float.c: Same.
2928         * thread.c: Same.
2929         * utils.c: Same.
2930         * valops.c: Same.
2931         * valprint.c: Same.
2932         * value.c: Same.
2933         * varobj.c: Same.
2934         * windows-nat.c: Same.
2935         * xcoffread.c: Same.
2936         * xstormy16-tdep.c: Same.
2937         * xtensa-tdep.c: Same.
2938
2939 2019-10-17  Tom Tromey  <tromey@adacore.com>
2940
2941         * configure: Rebuild.
2942         * configure.ac: Use AC_CONFIG_HEADERS.  Create stamp-h there, not
2943         in AC_CONFIG_FILES invocation.
2944         * Makefile.in (Makefile, data-directory/Makefile, stamp-h): Use
2945         new-style config.status invocation.
2946
2947 2019-10-17  Tom de Vries  <tdevries@suse.de>
2948
2949         * arm-nbsd-nat.c: Fix typos in comments.
2950         * arm-tdep.c: Same.
2951         * darwin-nat-info.c: Same.
2952         * dwarf2read.c: Same.
2953         * elfread.c: Same.
2954         * event-top.c: Same.
2955         * findvar.c: Same.
2956         * gdbtypes.c: Same.
2957         * hppa-tdep.c: Same.
2958         * i386-tdep.c: Same.
2959         * jit.c: Same.
2960         * main.c: Same.
2961         * mdebugread.c: Same.
2962         * moxie-tdep.c: Same.
2963         * nto-procfs.c: Same.
2964         * osabi.c: Same.
2965         * ppc-linux-tdep.c: Same.
2966         * remote.c: Same.
2967         * riscv-tdep.c: Same.
2968         * s390-tdep.c: Same.
2969         * sh-tdep.c: Same.
2970         * sparc-linux-tdep.c: Same.
2971         * sparc-nat.c: Same.
2972         * stack.c: Same.
2973         * target-descriptions.c: Same.
2974         * top.c: Same.
2975         * varobj.c: Same.
2976
2977 2019-10-16  Tom Tromey  <tom@tromey.com>
2978
2979         * objfiles.h (struct objfile) <original_name>: Now const.
2980
2981 2019-10-16  Christian Biesinger  <cbiesinger@google.com>
2982
2983         * gdbsupport/gdb_setjmp.h (SIGSETJMP): Allow passing in the value to
2984         pass on to sigsetjmp's second argument.
2985         * cp-support.c (gdb_demangle): Unblock SIGSEGV if we caught a crash.
2986
2987 2019-10-16  Keith Seitz  <keiths@redhat.com>
2988
2989         PR gdb/23567
2990         * dwarf2read.c (dwarf2_per_objfile::locate_sections): Discard
2991         sections whose size is greater than the file size.
2992
2993 2019-10-16  Jim Wilson  <jimw@sifive.com>
2994
2995         * riscv-tdep.c (riscv_gcc_target_options): New.
2996         (riscv_gnu_triplet_regexp): New.
2997         (riscv_gdbarch_init): Call set_gdbarch_gcc_triplet_options and
2998         set_gdbarch_gnu_triplet_regexp.
2999
3000 2019-10-16  Christian Biesinger  <cbiesinger@google.com>
3001
3002         * Makefile.in: Add xml-builtin.h.
3003         * features/feature_to_c.sh: Add an include for xml-builtin.h
3004         to ensure that the compiler checks that the types match.
3005         * xml-builtin.h: New file.
3006         * xml-support.c (fetch_xml_builtin): Add missing const.
3007         * xml-support.h: Remove declaration of xml_builtins.
3008
3009 2019-10-16  Tom de Vries  <tdevries@suse.de>
3010
3011         PR tdep/25096
3012         * amd64-tdep.c (amd64_classify_aggregate_field): Factor out of ...
3013         (amd64_classify_aggregate): ... here.
3014         (amd64_classify_aggregate_field): Handled fiels of nested structs
3015         recursively.
3016
3017 2019-10-16  Tom de Vries  <tdevries@suse.de>
3018
3019         PR tdep/24104
3020         * amd64-tdep.c (amd64_push_arguments): Handle AMD64_NO_CLASS in loop
3021         that handles 'theclass'.
3022
3023 2019-10-15  Andrew Burgess  <andrew.burgess@embecosm.com>
3024
3025         * linespec.c (decode_digits_ordinary): Update comment.
3026         * make-target-delegates: No longer need to handle VEC case.
3027         * memrange.c (normalize_mem_ranges): Update comment.
3028         * namespace.c (add_using_directive): Update comment.
3029         * objc-lang.c (uniquify_strings): Update comment.
3030         * ppc-linux-nat.c (struct thread_points): Update comment.
3031         * probe.h (find_probes_in_objfile): Update comment.
3032         * target.h (enum flash_preserve_mode): Update comment.
3033         * varobj.c (varobj_restrict_range): Update comment.
3034         * varobj.h (varobj_list_children): Update comment.
3035
3036 2019-10-15  Andrew Burgess  <andrew.burgess@embecosm.com>
3037
3038         * Makefile.in: Remove references to vec.h and vec.c.
3039         * aarch64-tdep.c: No longer include vec.h.
3040         * ada-lang.c: Likewise.
3041         * ada-lang.h: Likewise.
3042         * arm-tdep.c: Likewise.
3043         * ax.h: Likewise.
3044         * breakpoint.h: Likewise.
3045         * charset.c: Likewise.
3046         * cp-support.h: Likewise.
3047         * dtrace-probe.c: Likewise.
3048         * dwarf2read.c: Likewise.
3049         * extension.h: Likewise.
3050         * gdb_bfd.c: Likewise.
3051         * gdbsupport/gdb_vecs.h: Likewise.
3052         * gdbsupport/vec.c: Remove.
3053         * gdbsupport/vec.h: Remove.
3054         * gdbthread.h: Likewise.
3055         * guile/scm-type.c: Likewise.
3056         * inline-frame.c: Likewise.
3057         * machoread.c: Likewise.
3058         * memattr.c: Likewise.
3059         * memrange.h: Likewise.
3060         * namespace.h: Likewise.
3061         * nat/linux-btrace.h: Likewise.
3062         * osdata.c: Likewise.
3063         * parser-defs.h: Likewise.
3064         * progspace.h: Likewise.
3065         * python/py-type.c: Likewise.
3066         * record-btrace.c: Likewise.
3067         * rust-exp.y: Likewise.
3068         * solib-target.c: Likewise.
3069         * stap-probe.c: Likewise.
3070         * target-descriptions.c: Likewise.
3071         * target-memory.c: Likewise.
3072         * target.h: Likewise.
3073         * varobj.c: Likewise.
3074         * varobj.h: Likewise.
3075         * xml-support.h: Likewise.
3076
3077 2019-10-15  Andrew Burgess  <andrew.burgess@embecosm.com>
3078
3079         * gdb/dwarf2read.c (dwarf2_per_objfile::~dwarf2_per_objfile):
3080         Update for new std::vector based implementation.
3081         (process_psymtab_comp_unit_reader): Likewise.
3082         (scan_partial_symbols): Likewise.
3083         (recursively_compute_inclusions): Likewise.
3084         (compute_compunit_symtab_includes): Likewise.
3085         (process_imported_unit_die): Likewise.
3086         (queue_and_load_dwo_tu): Likewise.
3087         (follow_die_sig_1): Likewise.
3088         * gdb/dwarf2read.h: Remove DEF_VEC_P.
3089         (typedef dwarf2_per_cu_ptr): Remove.
3090         (struct dwarf2_per_cu_data) <imported_symtabs_empty>: New
3091         function.
3092         (struct dwarf2_per_cu_data) <imported_symtabs_push>: New function.
3093         (struct dwarf2_per_cu_data) <imported_symtabs_size>: New function.
3094         (struct dwarf2_per_cu_data) <imported_symtabs_free>: New function.
3095         (struct dwarf2_per_cu_data) <imported_symtabs>: Change to
3096         std::vector.
3097
3098 2019-10-15  Tom Tromey  <tromey@adacore.com>
3099
3100         * windows-nat.c (windows_nat_target::resume): Use %x when logging
3101         TID.
3102
3103 2019-10-15  Tom Tromey  <tromey@adacore.com>
3104
3105         * windows-nat.c (windows_nat_target::fetch_registers)
3106         (windows_nat_target::store_registers): Rename "pid" to "tid".
3107
3108 2019-10-15  Tom Tromey  <tromey@adacore.com>
3109
3110         * gdbarch.h, gdbarch.c: Rebuild.
3111         * gdbarch.sh (gcc_target_options): Change return type to
3112         std::string.
3113         * compile/compile.c (get_args): Update.
3114         * nios2-tdep.c (nios2_gcc_target_options): Return std::string.
3115         * arm-linux-tdep.c (arm_linux_gcc_target_options): Return
3116         std::string.
3117         * aarch64-linux-tdep.c (aarch64_linux_gcc_target_options): Return
3118         std::string.
3119         * arch-utils.c (default_gcc_target_options): Return std::string.
3120         * arch-utils.h (default_gcc_target_options): Return std::string.
3121         * s390-tdep.c (s390_gcc_target_options): Return std::string.
3122
3123 2019-10-15  Christian Biesinger  <cbiesinger@google.com>
3124
3125         * breakpoint.c (breakpoint_chain): Make static.
3126         * tui/tui-winsource.c: Call iterate_over_breakpoints instead
3127         of accessing breakpoint_chain.
3128
3129 2019-10-15  Christian Biesinger  <cbiesinger@google.com>
3130
3131         * breakpoint.c (iterate_over_breakpoints): Change function pointer
3132         to a gdb::function_view and return value to bool.
3133         * breakpoint.h (iterate_over_breakpoints): Likewise.
3134         * dummy-frame.c (pop_dummy_frame_bpt): Update.
3135         (pop_dummy_frame): Update.
3136         * guile/scm-breakpoint.c (bpscm_build_bp_list): Update.
3137         (gdbscm_breakpoints): Update.
3138         * python/py-breakpoint.c (build_bp_list): Update.
3139         (gdbpy_breakpoints): Update.
3140         * python/py-finishbreakpoint.c (bpfinishpy_detect_out_scope_cb):
3141         Update.
3142         (bpfinishpy_handle_stop): Update.
3143         (bpfinishpy_handle_exit): Update.
3144         * solib-svr4.c (svr4_update_solib_event_breakpoint): Update.
3145         (svr4_update_solib_event_breakpoints): Update.
3146
3147 2019-10-15  Andreas Arnez  <arnez@linux.ibm.com>
3148
3149         * s390-tdep.c (s390_effective_inner_type): Ignore static fields
3150         when unwrapping single-field structs.
3151
3152 2019-10-14  Simon Marchi  <simon.marchi@polymtl.ca>
3153
3154         * dwarf2read.c: Remove includes.
3155
3156 2019-10-13  Simon Marchi  <simon.marchi@polymtl.ca>
3157
3158         * ui-out.c (ui_out::call_do_message): Silence
3159         -Wformat-nonliteral warning.
3160
3161 2019-10-12  Simon Marchi  <simon.marchi@polymtl.ca>
3162
3163         * breakpoint.c: Remove some includes: continuations.h, skip.h,
3164         mi/mi-main.h, readline/readline.h, readline/history.h.  Add
3165         include: readline/tilde.h.
3166
3167 2019-10-12  Christian Biesinger  <cbiesinger@google.com>
3168
3169         * remote.c (remote_target::get_trace_status): Remove declaration of
3170         trace_regblock_size.
3171
3172 2019-10-12  Christian Biesinger  <cbiesinger@google.com>
3173
3174         * cli/cli-cmds.c (max_user_call_depth): Move comment to header.
3175         (show_user): Remove declaration of cmdlist.
3176         * cli/cli-cmds.h (max_user_call_depth): Declare.
3177         * cli/cli-script.c (execute_user_command): Remove declaration
3178         of max_user_call_depth.
3179
3180 2019-10-11  Jim Wilson  <jimw@sifive.com>
3181
3182         * gdbsupport/print-utils.h (pulongest): Fix comment.
3183         (plongest): Likewise.
3184         (phex): Add missing comment, mention leading zeros.
3185         (phex_nz): Add mention of no leading zeros to comment.
3186
3187         * riscv-tdep.c (riscv_push_dummy_code): Change %lld to %s and use
3188         plongest instead of unsigned long long cast.
3189
3190 2019-10-10  Christian Biesinger  <cbiesinger@google.com>
3191
3192         * main.c (captured_main_1): Include gdbtk.h and remove declarations
3193         for external_editor_command and gdbtk_test.
3194
3195 2019-10-10  Christian Biesinger  <cbiesinger@google.com>
3196
3197         * mi/mi-cmd-var.c (varobjdebug): Remove declaration.
3198         * varobj.c (varobjdebug): Move comment to...
3199         * varobj.h (varobjdebug): ...here, and declare.
3200
3201 2019-10-09  Tom Tromey  <tom@tromey.com>
3202
3203         * tui/tui-regs.c (tui_data_window::show_registers): Don't call
3204         erase_data_content.
3205
3206 2019-10-09  Tom Tromey  <tom@tromey.com>
3207
3208         * tui/tui-wingeneral.h (tui_delete_win): Don't declare.
3209         * tui/tui-stack.c (tui_locator_window::rerender): Update.
3210         * tui/tui-command.c (tui_cmd_window::resize)
3211         (tui_refresh_cmd_win): Update.
3212         * tui/tui-win.c (tui_resize_all, tui_set_focus_command): Update.
3213         * tui/tui.c (tui_rl_other_window, tui_enable): Update.
3214         * tui/tui-data.c (~tui_gen_win_info): Remove.
3215         * tui/tui-layout.c (tui_gen_win_info::resize): Update.
3216         * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
3217         (tui_redisplay_readline, tui_mld_flush)
3218         (tui_mld_erase_entire_line, tui_mld_getc, tui_getc): Update.
3219         * tui/tui-regs.c (tui_data_window::delete_data_content_windows)
3220         (tui_data_window::erase_data_content)
3221         (tui_data_item_window::rerender)
3222         (tui_data_item_window::refresh_window): Update.
3223         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window)
3224         (box_win, tui_gen_win_info::make_window)
3225         (tui_gen_win_info::make_visible): Update.
3226         (tui_delete_win): Remove.
3227         * tui/tui-winsource.c
3228         (tui_source_window_base::do_erase_source_content): Update.
3229         (tui_show_source_line, tui_source_window_base::update_tab_width)
3230         (tui_source_window_base::update_exec_info): Update.
3231         * tui/tui-data.h (struct curses_deleter): New.
3232         (struct tui_gen_win_info) <handle>: Now a unique_ptr.
3233         (struct tui_gen_win_info) <~tui_gen_win_info>: Define.
3234
3235 2019-10-09  Tom Tromey  <tom@tromey.com>
3236
3237         * tui/tui-wingeneral.h (struct tui_gen_win_info): Don't declare.
3238
3239 2019-10-09  Tom Tromey  <tom@tromey.com>
3240
3241         * tui/tui-data.c (tui_win_is_auxiliary): Remove.
3242         * tui/tui-data.h (tui_win_is_auxiliary): Don't declare.
3243
3244 2019-10-09  Tom Tromey  <tom@tromey.com>
3245
3246         * tui/tui-disasm.c (tui_get_low_disassembly_address): Compute
3247         window height directly.
3248         * tui/tui-layout.h (tui_default_win_viewport_height): Don't
3249         declare.
3250         * tui/tui-layout.c (tui_default_win_height): Remove.
3251         (tui_default_win_viewport_height): Remove.
3252
3253 2019-10-09  Tom Tromey  <tom@tromey.com>
3254
3255         * tui/tui.h: Remove comments.
3256
3257 2019-10-09  Tom de Vries  <tdevries@suse.de>
3258
3259         * python/lib/gdb/printer/bound_registers.py: Use
3260         '^builtin_type_bound128' as regexp argument for
3261         add_builtin_pretty_printer.
3262
3263 2019-10-09  Christian Biesinger  <cbiesinger@google.com>
3264
3265         * guile/guile.c (guile_extension_script_ops): Remove forward
3266         declaration and mark as static.
3267         (guile_script_ops): Likewise.
3268         (extension_language_guile): Move further down in the file so
3269         it can reference the definitions for guile_{extension_,}script_ops.
3270
3271 2019-10-09  Andreas Arnez  <arnez@linux.ibm.com>
3272
3273         * s390-tdep.c (390_process_record): Handle new arch13 instructions
3274         except SORTL, DFLTCC, and KDSA.
3275
3276 2019-10-08  Tom Tromey  <tromey@adacore.com>
3277
3278         * windows-nat.c (struct windows_thread_info_struct) <sf>: Remove.
3279         (struct safe_symbol_file_add_args): Remove.
3280
3281 2019-10-08  Tom Tromey  <tromey@adacore.com>
3282
3283         * windows-nat.c: Don't include buildsym-legacy.h.
3284
3285 2019-10-08  Tom Tromey  <tromey@adacore.com>
3286
3287         * contrib/ari/gdb_ari.sh (%p): Allow gdb-specific %p extensions.
3288
3289 2019-10-08  Christian Biesinger  <cbiesinger@google.com>
3290
3291         * gdbtypes.c (overload_debug): Move comment to header.
3292         * gdbtypes.h (overload_debug): Declare.
3293         * valops.c: Remove declaration of overload_debug, instead
3294         include gdbtypes.h.
3295
3296 2019-10-08  Christian Biesinger  <cbiesinger@google.com>
3297
3298         * language.c (show_language_command): Pass lang_frame_mismatch_warn
3299         through _().
3300         (lang_frame_mismatch_warn): Make const, mark with N_(), and
3301         move comment...
3302         * language.h (lang_frame_mismatch_warn): ... here. Also add
3303         declaration.
3304         * top.c (lang_frame_mismatch_warn): Remove declaration.
3305         (check_frame_language_change): Pass lang_frame_mismatch_warn
3306         through _().
3307
3308 2019-10-07  Christian Biesinger  <cbiesinger@google.com>
3309
3310         * c-lang.h (vtbl_ptr_name): Declare.
3311         * cp-valprint.c (vtbl_ptr_name): Remove "extern" now that we get
3312         it from the header.
3313         * stabsread.c (define_symbol): Remove declaration of vtbl_ptr_name.
3314
3315 2019-10-07  Christian Biesinger  <cbiesinger@google.com>
3316
3317         * charset.c (your_gdb_wchar_t_is_bogus): Replace with a
3318         gdb_static_assert.
3319
3320 2019-10-07  Weimin Pan  <weimin.pan@oracle.com>
3321
3322         * ../Makefile.def (dependencies): Add all-libctf to all-gdb
3323         * ../Makefile.in: Add "all-gdb: maybe-all-libctf"
3324         * ctfread.c: New file.
3325         * ctfread.h: New file.
3326         * elfread.c: Include ctfread.h.
3327         (struct elfinfo text_p): New member ctfsect.
3328         (elf_locate_sections): Mark CTF section.
3329         (elf_symfile_read): Call elfctf_build_psymtabs.
3330         * Makefile.in (LIBCTF): Add.
3331         (CLIBS): Use it.
3332         (CDEPS): Likewise.
3333         (DIST): Add ctfread.c.
3334
3335 2019-10-07  Andrew Burgess  <andrew.burgess@embecosm.com>
3336
3337         * ctfread.c (struct nextfield): Renamed to ...
3338         (struct ctf_nextfield): ... this.
3339         (struct field_info): Renamed to ...
3340         (strut ctf_field_info): ... this.
3341         (attach_fields_to_type): Update for renamed structures.
3342         (ctf_add_member_cb): Likewise.
3343         (ctf_add_enum_member_cb): Likewise.
3344         (process_struct_members): Likewise.
3345         (process_enum_type): Likewise.
3346
3347 2019-10-07  Weimin Pan  <weimin.pan@oracle.com>
3348
3349         * tracectf.h: Rename, was ctf.h.
3350         * tracectf.c: Rename, was ctf.c, replace ctf.h with tracectf.h.
3351         * tracefile.c: Likewise.
3352         * tracepoint.c: Remove unused include ctf.h.
3353         * mi/mi-main.c: Likewise.
3354         * Makefile.in Replace ctf.c with tracectf.c.
3355
3356 2019-10-06  Joel Brobecker  <brobecker@adacore.com>
3357
3358         * version.in: Change version number to "9.0.50.DATE-git".
3359
3360 2019-10-03  Tom Tromey  <tom@tromey.com>
3361
3362         PR rust/24976:
3363         * dwarf2read.c (quirk_rust_enum): Handle single-element unions.
3364
3365 2019-10-03  Andrew Burgess  <andrew.burgess@embecosm.com>
3366
3367         * f-lang.c (f_language_defn): Use cp_get_symbol_name_matcher and
3368         cp_search_name_hash.
3369         * NEWS: Add entry about nested function support.
3370
3371 2019-10-03  Bernhard Heckel  <bernhard.heckel@intel.com>
3372             Andrew Burgess  <andrew.burgess@embecosm.com>
3373
3374         * cp-namespace.c (cp_search_static_and_baseclasses): Only search
3375         for nested static variables when searchin VAR_DOMAIN.
3376         * dwarf2read.c (add_partial_symbol): Add nested subroutines to the
3377         global scope, update comment.
3378         (add_partial_subprogram): Call add_partial_subprogram recursively
3379         for nested subroutines when processinng Fortran.
3380         (load_partial_dies): Process the child entities of a subprogram
3381         when processing Fortran.
3382         (partial_die_parent_scope): Handle building scope
3383         for Fortran nested functions.
3384         (process_die): Record that nested functions have a scope.
3385         (new_symbol): Always record Fortran subprograms on the global
3386         symbol list.
3387         (determine_prefix): How to build the prefix for Fortran
3388         subprograms.
3389
3390 2019-10-03  Andrew Burgess  <andrew.burgess@embecosm.com>
3391
3392         * linux-nat.c (linux_nat_filter_event): Don't ignore SIGSTOP if we
3393         have just sent the thread a SIGSTOP and are waiting for it to
3394         arrive.
3395
3396 2019-10-03  Andrew Burgess  <andrew.burgess@embecosm.com>
3397
3398         * btrace.c (btrace_add_pc): Remove whitespace before the template
3399         parameter in 'std::vector <...>'.
3400         (parse_xml_btrace_block): Likewise.
3401         (btrace_maint_decode_pt): Likewise.
3402         (btrace_maint_update_packets): Likewise.
3403         (btrace_maint_print_packets): Likewise.
3404         * btrace.h (struct btrace_maint_info): Likewise.
3405         * dwarf2read.c (struct type_unit_group): Likewise.
3406         (build_type_psymtabs_reader): Likewise.
3407         * gdbsupport/btrace-common.c (btrace_data_append): Likewise.
3408         * gdbsupport/btrace-common.h (struct btrace_data_bts): Likewise.
3409         * nat/linux-btrace.c (perf_event_read_bts): Likewise.
3410
3411 2019-10-03  Tom de Vries  <tdevries@suse.de>
3412
3413         * cli/cli-style.c (_initialize_cli_style): Adding a '.' at the end of
3414         the first line of the help text for set/show style metadata.
3415
3416 2019-10-02  Tom Tromey  <tromey@adacore.com>
3417
3418         * Makefile.in (COMMON_SFILES): Add common-inferior.c.
3419         * gdbsupport/common-inferior.c: New file.
3420         * infcmd.c (startup_with_shell): Don't define.
3421         * nat/fork-inferior.h (startup_with_shell): Don't declare.
3422         * gdbsupport/common-inferior.h (startup_with_shell): Declare.
3423         * inferior.h (startup_with_shell): Don't declare.
3424
3425 2019-10-02  Christian Biesinger  <cbiesinger@google.com>
3426
3427         * gdbsupport/gdb_assert.h: Include errors.h.
3428         * gdbsupport/gdb_string_view.h: Include gdb_assert.h.
3429
3430 2019-10-02  Tom Tromey  <tromey@adacore.com>
3431
3432         * NEWS: Add $_ada_exception entry.
3433         * ada-lang.c (struct ada_catchpoint): Add constructor.
3434         <m_kind>: New member.
3435         (allocate_location_exception, re_set_exception): Remove
3436         "ex" parameter.
3437         (should_stop_exception): Compute $_ada_exception.
3438         (check_status_exception, print_it_exception)
3439         (print_one_exception, print_mention_exception): Remove
3440         "ex" parameter.
3441         (allocate_location_catch_exception, re_set_catch_exception)
3442         (check_status_exception, print_it_catch_exception)
3443         (print_one_catch_exception, print_mention_catch_exception)
3444         (print_recreate_catch_exception)
3445         (allocate_location_catch_exception_unhandled)
3446         (re_set_catch_exception_unhandled)
3447         (check_status_exception, print_it_catch_exception_unhandled)
3448         (print_one_catch_exception_unhandled)
3449         (print_mention_catch_exception_unhandled)
3450         (print_recreate_catch_exception_unhandled)
3451         (allocate_location_catch_assert, re_set_catch_assert)
3452         (check_status_assert, print_it_catch_assert)
3453         (print_one_catch_assert, print_mention_catch_assert)
3454         (print_recreate_catch_assert)
3455         (allocate_location_catch_handlers, re_set_catch_handlers)
3456         (check_status_handlers, print_it_catch_handlers)
3457         (print_one_catch_handlers, print_mention_catch_handlers)
3458         (print_recreate_catch_handlers): Remove.
3459         (create_ada_exception_catchpoint): Update.
3460         (initialize_ada_catchpoint_ops): Update.
3461
3462 2019-10-02  Tom Tromey  <tromey@adacore.com>
3463
3464         * ada-lang.c (ada_lookup_simple_minsyms): Remove.
3465         (create_excep_cond_exprs): Simplify exception string computation.
3466         (ada_exception_catchpoint_cond_string): Likewise.
3467
3468 2019-10-02  Tom Tromey  <tromey@adacore.com>
3469
3470         * symmisc.c (dump_msymbols): Don't use MSYMBOL_VALUE_ADDRESS.
3471         * ada-lang.c (lesseq_defined_than): Handle
3472         LOC_STATIC.
3473         * dwarf2read.c (dwarf2_per_objfile): Add can_copy
3474         parameter.
3475         (dwarf2_has_info): Likewise.
3476         (new_symbol): Set maybe_copied on symbol when
3477         appropriate.
3478         * dwarf2read.h (dwarf2_per_objfile): Add can_copy
3479         parameter.
3480         <can_copy>: New member.
3481         * elfread.c (record_minimal_symbol): Set maybe_copied
3482         on symbol when appropriate.
3483         (elf_symfile_read): Update call to dwarf2_has_info.
3484         * minsyms.c (lookup_minimal_symbol_linkage): New
3485         function.
3486         * minsyms.h (lookup_minimal_symbol_linkage): Declare.
3487         * symtab.c (get_symbol_address, get_msymbol_address):
3488         New functions.
3489         * symtab.h (get_symbol_address, get_msymbol_address):
3490         Declare.
3491         (SYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_ADDRESS): Handle
3492         maybe_copied.
3493         (struct symbol, struct minimal_symbol) <maybe_copied>:
3494         New member.
3495
3496 2019-10-02  Tom Tromey  <tromey@adacore.com>
3497
3498         * source.c (struct current_source_location): New.
3499         (current_source_key): New global.
3500         (current_source_symtab, current_source_line)
3501         (current_source_pspace): Remove.
3502         (get_source_location): New function.
3503         (get_current_source_symtab_and_line)
3504         (set_default_source_symtab_and_line)
3505         (set_current_source_symtab_and_line)
3506         (clear_current_source_symtab_and_line, select_source_symtab)
3507         (info_source_command, print_source_lines_base)
3508         (info_line_command, search_command_helper, _initialize_source):
3509         Update.
3510
3511 2019-10-02  Tom Tromey  <tromey@adacore.com>
3512
3513         * source.c (select_source_symtab): Don't call
3514         decode_line_with_current_source.
3515
3516 2019-10-02  Andrew Burgess  <andrew.burgess@embecosm.com>
3517
3518         * symtab.c (lookup_global_symbol): Search global block.
3519
3520 2019-10-02  Tom Tromey  <tromey@adacore.com>
3521
3522         * coffread.c (process_coff_symbol): Update.
3523         * dwarf2read.c (var_decode_location, new_symbol): Update.
3524         * mdebugread.c (parse_symbol): Update.
3525         * objfiles.c (relocate_one_symbol): Update.
3526         * stabsread.c (define_symbol, fix_common_block)
3527         (scan_file_globals): Update.
3528         * symtab.h (SYMBOL_VALUE_ADDRESS): Expand to an rvalue.
3529         (SET_SYMBOL_VALUE_ADDRESS): New macro.
3530         * xcoffread.c (process_xcoff_symbol): Update.
3531
3532 2019-10-02  Andreas Arnez  <arnez@linux.ibm.com>
3533
3534         * MAINTAINERS: Update my email address.
3535
3536 2019-10-02  Andrew Burgess  <andrew.burgess@embecosm.com>
3537
3538         * dwarf2read.c (struct type_unit_group) <tus>: Convert to
3539         std::vector.
3540         (build_type_psymtabs_reader): Update for std::vector.
3541         (build_type_psymtab_dependencies): Likewise.
3542         * dwarf2read.h: Remove use of DEF_VEC_P.
3543         (typedef sig_type_ptr): Delete.
3544
3545 2019-10-02  Andrew Burgess  <andrew.burgess@embecosm.com>
3546
3547         * btrace.c (btrace_maint_clear): Update to handle change from VEC
3548         to std::vector.
3549         (btrace_maint_decode_pt): Likewise, and move allocation of the
3550         vector outside of the loop.
3551         (btrace_maint_update_packets): Update to handle change from VEC to
3552         std::vector.
3553         (btrace_maint_print_packets): Likewise.
3554         (maint_info_btrace_cmd): Likewise.
3555         * btrace.h: Remove use of DEF_VEC_O.
3556         (typedef btrace_pt_packet_s): Delete.
3557         (struct btrace_maint_info) <packets>: Change fromm VEC to
3558         std::vector.
3559         * gdbsupport/btrace-common.h: Remove 'vec.h' include.
3560
3561 2019-10-02  Andrew Burgess  <andrew.burgess@embecosm.com>
3562
3563         * btrace.c (btrace_compute_ftrace_bts): Update for std::vector,
3564         make accesses into the vector constant references.
3565         (btrace_add_pc): Update for std::vector.
3566         (btrace_stitch_bts): Likewise.
3567         (parse_xml_btrace_block): Likewise.
3568         (btrace_maint_update_packets): Likewise.
3569         (btrace_maint_print_packets): Likewise.
3570         (maint_info_btrace_cmd): Likewise.
3571         * gdbsupport/btrace-common.c (btrace_data::fini): Update for
3572         std::vector.
3573         (btrace_data::empty): Likewise.
3574         (btrace_data_append): Likewise.
3575         * gdbsupport/btrace-common.h: Remove use of DEF_VEC_O.
3576         (typedef btrace_block_s): Delete.
3577         (struct btrace_block): Add constructor.
3578         (struct btrace_data_bts) <blocks>: Change to std::vector.
3579         * nat/linux-btrace.c (perf_event_read_bts): Update for
3580         std::vector.
3581         (linux_read_bts): Likewise.
3582
3583 2019-10-01  Tom Tromey  <tom@tromey.com>
3584
3585         * cli/cli-logging.c (show_logging_filename): Use styled_string.
3586
3587 2019-10-01  Tom Tromey  <tom@tromey.com>
3588
3589         * stack.c (print_frame, info_frame_command_core): Use
3590         styled_string.
3591         * linux-thread-db.c (try_thread_db_load_1)
3592         (try_thread_db_load_from_pdir_1): Use styled_string.
3593         * auto-load.c (file_is_auto_load_safe, execute_script_contents)
3594         (auto_load_section_scripts, info_auto_load_local_gdbinit)
3595         (maybe_print_unsupported_script_warning)
3596         (maybe_print_script_not_found_warning): Use styled_string.
3597         * ada-lang.c (user_select_syms): Use styled_string.
3598
3599 2019-10-01  Tom Tromey  <tom@tromey.com>
3600
3601         * p-lang.c (pascal_printstr): Use metadata style.
3602         * value.c (show_convenience): Use metadata style.
3603         * valprint.c (valprint_check_validity, val_print_optimized_out)
3604         (val_print_not_saved, val_print_unavailable)
3605         (val_print_invalid_address, generic_val_print, val_print)
3606         (value_check_printable, val_print_array_elements): Use metadata
3607         style.
3608         * ui-out.h (class ui_out) <field_fmt>: New overload.
3609         <do_field_fmt>: Add style parameter.
3610         * ui-out.c (ui_out::field_fmt): New overload.
3611         * typeprint.c (type_print_unknown_return_type)
3612         (val_print_not_allocated, val_print_not_associated): Use metadata
3613         style.
3614         * tui/tui-out.h (class tui_ui_out) <do_field_fmt>: Add style
3615         parameter.
3616         * tui/tui-out.c (tui_ui_out::do_field_fmt): Update.
3617         * tracepoint.c (tvariables_info_1): Use metadata style.
3618         * stack.c (print_frame_arg, print_frame_info, print_frame)
3619         (info_frame_command_core): Use metadata style.
3620         * skip.c (info_skip_command): Use metadata style.
3621         * rust-lang.c (rust_print_enum): Use metadata style.
3622         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
3623         metadata style.
3624         * python/py-framefilter.c (py_print_single_arg): Use metadata
3625         style.
3626         * printcmd.c (do_one_display, print_variable_and_value): Use
3627         metadata style.
3628         * p-valprint.c (pascal_val_print)
3629         (pascal_object_print_value_fields): Use metadata style.
3630         * p-typeprint.c (pascal_type_print_base): Use metadata style.
3631         * mi/mi-out.h (class mi_ui_out) <do_field_fmt>: Add style
3632         parameter.
3633         * mi/mi-out.c (mi_ui_out::do_field_fmt): Update.
3634         * m2-valprint.c (m2_print_long_set): Use metadata style.
3635         * m2-typeprint.c (m2_print_type): Use metadata style.
3636         * infcmd.c (print_return_value_1): Use metadata style.
3637         * gnu-v3-abi.c (print_one_vtable): Use metadata style.
3638         * f-valprint.c (info_common_command_for_block): Use metadata
3639         style.
3640         * f-typeprint.c (f_type_print_base): Use metadata style.
3641         * expprint.c (print_subexp_standard): Use metadata style.
3642         * cp-valprint.c (cp_print_value_fields): Use metadata style.
3643         * cli/cli-style.h (class cli_style_option): Add constructor.
3644         (metadata_style): Declare.
3645         * cli/cli-style.c (metadata_style): New global.
3646         (_initialize_cli_style): Register metadata style.
3647         * cli-out.h (class cli_ui_out) <do_field_fmt>: Add style
3648         parameter.
3649         * cli-out.c (cli_ui_out::do_field_fmt): Update.
3650         * c-typeprint.c (c_type_print_base_struct_union)
3651         (c_type_print_base_1): Use metadata style.
3652         * breakpoint.c (watchpoint_value_print)
3653         (print_one_breakpoint_location): Use metadata style.
3654         * break-catch-syscall.c (print_one_catch_syscall): Use metadata
3655         style.
3656         * break-catch-sig.c (signal_catchpoint_print_one): Use metadata
3657         style.
3658         * ada-valprint.c (val_print_packed_array_elements, printstr)
3659         (print_field_values, ada_val_print_ref, ada_val_print): Use
3660         metadata style.
3661         * ada-typeprint.c (print_array_type, ada_print_type): Use metadata
3662         style.
3663         * ada-tasks.c (print_ada_task_info, info_task): Use metadata
3664         style.
3665         * ada-lang.c (user_select_syms): Use metadata style.
3666
3667 2019-10-01  Tom Tromey  <tom@tromey.com>
3668
3669         * cli/cli-cmds.c (pwd_command): Style output.
3670
3671 2019-10-01  Pedro Alves  <palves@redhat.com>
3672             Tom Tromey  <tom@tromey.com>
3673
3674         * symtab.c (print_symbol_info): Use %ps.
3675         (print_msymbol_info): Use %ps.
3676         * symfile.c (symbol_file_add_with_addrs): Use %ps.
3677         * printcmd.c (print_variable_and_value): Use %ps.
3678         * macrocmd.c (show_pp_source_pos): Use %ps.
3679         * infrun.c (print_exited_reason): Use ui_out::message.
3680         * breakpoint.c (watchpoint_check, print_one_breakpoint_location)
3681         (describe_other_breakpoints): Use ui_out::message and new
3682         formats.
3683         (say_where): Use new formats.
3684         (bkpt_print_it, tracepoint_print_one_detail): Use ui_out::message
3685         and new formats.
3686
3687 2019-10-01  Pedro Alves  <palves@redhat.com>
3688             Tom Tromey  <tom@tromey.com>
3689
3690         * unittests/format_pieces-selftests.c: Add gdb_format parameter.
3691         (test_gdb_formats): New function.
3692         (run_tests): Call it.
3693         (test_format_specifier): Update.
3694         * utils.h (fputs_filtered): Update comment.
3695         (vfprintf_styled, vfprintf_styled_no_gdbfmt)
3696         (fputs_styled_unfiltered): Declare.
3697         * utils.c (fputs_styled_unfiltered): New function.
3698         (vfprintf_maybe_filtered): Add gdbfmt parameter.
3699         (vfprintf_filtered): Update.
3700         (vfprintf_unfiltered, vprintf_filtered): Update.
3701         (vfprintf_styled, vfprintf_styled_no_gdbfmt): New functions.
3702         * ui-out.h (enum ui_out_flag) <unfiltered_output,
3703         disallow_ui_out_field>: New constants.
3704         (enum class field_kind): New.
3705         (struct base_field_s, struct signed_field_s): New.
3706         (signed_field): New function.
3707         (struct string_field_s): New.
3708         (string_field): New function.
3709         (struct styled_string_s): New.
3710         (styled_string): New function.
3711         (class ui_out) <message>: Add comment.
3712         <vmessage, call_do_message>: New methods.
3713         <do_message>: Add style parameter.
3714         * ui-out.c (ui_out::call_do_message, ui_out::vmessage): New
3715         methods.
3716         (ui_out::message): Rewrite.
3717         * mi/mi-out.h (class mi_ui_out) <do_message>: Add style
3718         parameter.
3719         * mi/mi-out.c (mi_ui_out::do_message): Add style parameter.
3720         * gdbsupport/format.h (class format_pieces) <format_pieces>: Add
3721         gdb_extensions parameter.
3722         (class format_piece): Add parameter to constructor.
3723         (n_int_args): New field.
3724         * gdbsupport/format.c (format_pieces::format_pieces): Add
3725         gdb_extensions parameter.  Handle '*'.
3726         * cli-out.h (class cli_ui_out) <do_message>: Add style parameter.
3727         * cli-out.c (cli_ui_out::do_message): Add style parameter.  Call
3728         vfprintf_styled_no_gdbfmt.
3729         (cli_ui_out::do_field_string, cli_ui_out::do_spaces)
3730         (cli_ui_out::do_text, cli_ui_out::field_separator): Allow
3731         unfiltered output.
3732         * ui-style.h (struct ui_file_style) <ptr>: New method.
3733
3734 2019-10-01  Tom Tromey  <tom@tromey.com>
3735
3736         * unittests/format_pieces-selftests.c: Update.  Add final format.
3737         * gdbsupport/format.c (format_pieces::format_pieces): Don't add
3738         empty literal pieces.
3739
3740 2019-10-01  Tom Tromey  <tom@tromey.com>
3741
3742         * ui-out.h (enum class ui_out_style_kind): Remove.
3743         (class ui_out) <field_string, field_stsream, do_field_string>:
3744         Change type of "style".
3745         * ui-out.c (ui_out::field_core_addr, ui_out::field_stream)
3746         (ui_out::field_string): Update.
3747         * tui/tui-out.h (class tui_ui_out) <do_field_string>: Change type
3748         of "style".
3749         * tui/tui-out.c (tui_ui_out::do_field_string): Update.
3750         * tracepoint.c (print_one_static_tracepoint_marker): Update.
3751         * stack.c (print_frame_arg, print_frame_info, print_frame):
3752         Update.
3753         * source.c (print_source_lines_base): Update.
3754         * solib.c (info_sharedlibrary_command): Update.
3755         * skip.c (info_skip_command): Update.
3756         * record-btrace.c (btrace_call_history_src_line)
3757         (btrace_call_history): Update.
3758         * python/py-framefilter.c (py_print_frame): Update.
3759         * mi/mi-out.h (class mi_ui_out) <do_field_string>: Change type of
3760         "style".
3761         * mi/mi-out.c (mi_ui_out::do_table_header)
3762         (mi_ui_out::do_field_signed, mi_ui_out::do_field_unsigned)
3763         (mi_ui_out::do_field_string): Update.
3764         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
3765         Update.
3766         * cli-out.h (class cli_ui_out) <do_field_string>: Change type of
3767         "style".
3768         * cli-out.c (cli_ui_out::do_table_header)
3769         (cli_ui_out::do_field_signed, cli_ui_out::do_field_unsigned)
3770         (cli_ui_out::do_field_skip, cli_ui_out::do_field_string)
3771         (cli_ui_out::do_field_fmt): Update.
3772         * breakpoint.c (print_breakpoint_location): Update.
3773         (update_static_tracepoint): Update.
3774
3775 2019-10-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3776
3777         * main.c (relocate_gdbinit_path_maybe_in_datadir): Remove std::string
3778         conversion of gdb_datadir.
3779         (captured_main_1): Remove xstrdup when assigning to gdb_datadir,
3780         remove not needed c_str ().
3781
3782 2019-09-30  Ali Tamur <tamur@google.com>
3783
3784         * dwarf2read.c (skip_one_die): Handle DW_FORM_strx forms.
3785         (dwarf2_string_attr): Likewise.
3786
3787 2019-09-30  Ali Tamur <tamur@google.com>
3788
3789         * dwarf2read.c (process_full_comp_unit): Remove whitespace at the EOL.
3790         (process_full_type_unit): Likewise.
3791         (dump_die_shallow): Likewise.
3792         (cu_debug_loc_section): Likewise.
3793
3794 2019-09-28  Christian Biesinger  <cbiesinger@google.com>
3795
3796         * minsyms.c (compare_minimal_symbols): Rename to...
3797         (minimal_symbol_is_less_than): ...this, and adjust to STL
3798         conventions (return bool, take arguments as references)
3799         (minimal_symbol_reader::install): Call std::sort instead
3800         of qsort.
3801
3802 2019-09-29  Christian Biesinger  <cbiesinger@google.com>
3803
3804         * minsyms.h (msymbol_hash): Document that this is a case-insensitive
3805         hash and why.
3806         * objfiles.h (struct objfile_per_bfd_storage) <demangled_names_hash,
3807         msymbol_hash, msymbol_demangled_hash>: Improve comments.
3808
3809 2019-09-30  Simon Marchi  <simon.marchi@polymtl.ca>
3810
3811         * psymtab.c (add_psymbol_to_list): Move comment to psympriv.h.
3812         * psympriv.h (add_psymbol_to_list): Move comment here and update
3813         it.
3814
3815 2019-09-29  Tom de Vries  <tdevries@suse.de>
3816
3817         * contrib/cc-with-tweaks.sh (get_tmpdir): New function.
3818         Use $tmpdir/$(basename "$output_file").dwz instead of
3819         "${output_file}.dwz".
3820
3821 2019-09-28  Simon Marchi  <simon.marchi@polymtl.ca>
3822
3823         PR gdb/25045
3824         * hppa-linux-nat.c: Include gdbarch.h.
3825
3826 2019-09-26  Christian Biesinger  <cbiesinger@google.com>
3827
3828         * blockframe.c (find_pc_partial_function): Change return type to bool.
3829         * elfread.c (elf_gnu_ifunc_resolve_name): Likewise.
3830         * minsyms.c (in_gnu_ifunc_stub): Likewise.
3831         (stub_gnu_ifunc_resolve_name): Likewise.
3832         * symtab.c (compare_filenames_for_search): Likewise.
3833         (compare_glob_filenames_for_search): Likewise.
3834         (matching_obj_sections): Likewise.
3835         (symbol_matches_domain): Likewise.
3836         (find_line_symtab): Change out param EXACT_MATCH to bool *.
3837         (find_line_pc): Change return type to bool.
3838         (find_line_pc_range): Likewise.
3839         (producer_is_realview): Likewise.
3840         * symtab.h (symbol_matches_domain): Likewise.
3841         (find_pc_partial_function): Likewise.
3842         (find_pc_line_pc_range): Likewise.
3843         (in_gnu_ifunc_stub): Likewise.
3844         (struct gnu_ifunc_fns) <gnu_ifunc_resolve_name>: Likewise.
3845         (find_line_pc): Likewise.
3846         (find_line_pc_range): Likewise.
3847         (matching_obj_sections): Likewise.
3848         (find_line_symtab): Change out parameter to bool.
3849         (producer_is_realview): Change return type to bool.
3850         (compare_filenames_for_search): Likewise.
3851         (compare_glob_filenames_for_search): Likewise.
3852
3853 2019-09-26  Tom Tromey  <tom@tromey.com>
3854
3855         * Makefile.in (COMMON_SFILES): Remove gdb_usleep.c.
3856         (HFILES_NO_SRCDIR): Remove gdb_usleep.h.
3857         * gdb_usleep.h: Remove.
3858         * gdb_usleep.c: Remove.
3859         * utils.c: Don't include gdb_usleep.h.
3860
3861 2019-09-26  Tom Tromey  <tromey@adacore.com>
3862
3863         * python/py-type.c (type_to_type_object): Call check_typedef
3864         for stub types.
3865
3866 2019-09-26  Tom Tromey  <tom@tromey.com>
3867
3868         * utils.h (initialize_utils): Don't declare.
3869         * top.c (gdb_init): Don't call initialize_utils.
3870         * utils.c (initialize_utils): Remove.  Move contents...
3871         (_initialize_utils): ... here.
3872
3873 2019-09-25  Tom Tromey  <tom@tromey.com>
3874
3875         * python/py-objfile.c (objfpy_get_build_id): Use bin2hex.
3876         * utils.h (make_hex_string): Don't declare.
3877         * utils.c (make_hex_string): Remove.
3878
3879 2019-09-24  Tom de Vries  <tdevries@suse.de>
3880
3881         PR gdb/23815
3882         * amd64-linux-nat.c (amd64_linux_nat_target::fetch_registers):
3883         Initialize xstateregs before ptrace PTRACE_GETREGSET call.
3884
3885 2019-09-23  Dimitar Dimitrov  <dimitar@dinux.eu>
3886
3887         * NEWS: Mention new simulator port for PRU.
3888
3889 2019-09-23  Christian Biesinger  <cbiesinger@google.com>
3890
3891         * ada-exp.y (write_object_remaining): Update.
3892         * ada-lang.c (ada_decode): Return a std::string instead of a char*
3893         and eliminate the static buffer.
3894         (ada_decode_symbol): Update.
3895         (ada_la_decode): Update.
3896         (ada_sniff_from_mangled_name): Update.
3897         (is_valid_name_for_wild_match): Update.
3898         (ada_lookup_name_info::matches): Update and simplify.
3899         (name_matches_regex): Update.
3900         (ada_add_global_exceptions): Update.
3901         * ada-lang.h (ada_decode): Update signature.
3902         * ada-varobj.c (ada_varobj_describe_simple_array_child): Update.
3903         * dwarf-index-write.c (debug_names::insert): Update.
3904
3905 2019-09-21  Simon Marchi  <simon.marchi@polymtl.ca>
3906
3907         * solib-svr4.c (svr4_iterate_over_objfiles_in_search_order): Fix
3908         formatting.
3909
3910 2019-09-21  Simon Marchi  <simon.marchi@polymtl.ca>
3911
3912         * breakpoint.h (bp_location) <inserted, permanent, duplicate>:
3913         Change "nonzero" to "true" in documentation.
3914
3915 2019-09-20  Christian Biesinger  <cbiesinger@google.com>
3916
3917         * solib-darwin.c (darwin_lookup_lib_symbol): Remove.
3918         (_initialize_darwin_solib): Don't set
3919         darwin_so_ops.lookup_lib_global_symbol.
3920         * solib-svr4.c (set_solib_svr4_fetch_link_map_offsets): Call
3921         set_gdbarch_iterate_over_objfiles_in_search_order.
3922         (elf_lookup_lib_symbol): Rename to...
3923         (svr4_iterate_over_objfiles_in_search_order): this, and update
3924         to iterate semantics.
3925         (_initialize_svr4_solib): Don't set lookup_lib_global_symbol.
3926         * solib.c (solib_global_lookup): Remove.
3927         * solist.h (struct target_so_ops): Remove lookup_lib_global_symbol.
3928         (solib_global_lookup): Remove.
3929         * symtab.c (lookup_global_or_static_symbol): Remove call to
3930         solib_global_lookup.
3931
3932 2019-09-20  Joel Brobecker  <brobecker@adacore.com>
3933
3934         * NEWS: Move entries about default MI version now being
3935         version 3, and about the GDB/MI fix for multi-location
3936         breakpoints to the "since GDB 8.3" section.
3937
3938 2019-09-20  Joel Brobecker  <brobecker@adacore.com>
3939
3940         GDB 8.3.1 released.
3941
3942 2019-09-20  Ulrich Weigand  <uweigand@de.ibm.com>
3943
3944         * NEWS: Mention that Cell/B.E. debugging support was removed.
3945         * MAINTAINERS: Remove spu target.
3946
3947         * config/djgpp/fnchange.lst: Remove entries for removed files.
3948
3949         * Makefile.in (ALL_TARGET_OBS): Remove solib-spu.o,
3950         spu-multiarch.o, and spu-tdep.o.
3951         (HFILES_NO_SRCDIR): Remove solib-spu.h and spu-tdep.h.
3952         (ALLDEPFILES): Remove solib-spu.c, spu-linux-nat.c,
3953         spu-multiarch.c, and spu-tdep.c.
3954         * spu-linux-nat.c: Remove file.
3955         * spu-multiarch.c: Remove file.
3956         * spu-tdep.c: Remove file.
3957         * spu-tdep.h: Remove file.
3958         * solib-spu.c: Remove file.
3959         * solib-spu.h: Remove file.
3960
3961         * configure.host (powerpc64*-*-linux*): Remove Cell/B.E. support.
3962         * configure.nat (spu-linux): Remove.
3963         * configure.tgt (powerpc*-*-linux*): Remove solib-spu.o and
3964         solib-multiarch.o from gdb_target_obs.
3965         (spu*-*-*): Remove.
3966
3967         * arch/ppc-linux-common.h (struct ppc_linux_features): Remove "cell"
3968         feature flag.
3969         (ppc_linux_no_features): Update.
3970         * arch/ppc-linux-common.c (ppc_linux_match_description): Remove
3971         Cell/B.E. support.
3972         * arch/ppc-linux-tdesc.h (tdesc_powerpc_cell32l): Remove declaration.
3973         (tdesc_powerpc_cell64l): Likewise.
3974         * nat/ppc-linux.h (PPC_FEATURE_CELL): Remove.
3975         * ppc-linux-nat.c (ppc_linux_nat_target::read_description): Remove
3976         Cell/B.E. support.
3977         * ppc-linux-tdep.h: Do not include "solib-spu.h" or "spu-tdep.h".
3978         Do not include "features/rs6000/powerpc-cell32l.c" or
3979         "features/rs6000/powerpc-cell64l.c".
3980         (ppc_linux_spu_section): Remove.
3981         (ppc_linux_core_read_description): Remove Cell/B.E. support.
3982         (spe_context_objfile, spe_context_lm_addr, spe_context_offset,
3983         spe_context_cache_ptid, spe_context_cache_ptid): Remove.
3984         (ppc_linux_spe_context_lookup): Remove.
3985         (ppc_linux_spe_context_inferior_created): Remove.
3986         (ppc_linux_spe_context_solib_loaded): Remove.
3987         (ppc_linux_spe_context_solib_unloaded): Remove.
3988         (ppc_linux_spe_context): Remove.
3989         (struct ppu2spu_cache): Remove.
3990         (ppu2spu_prev_arch, ppu2spu_this_id, ppu2spu_prev_register): Remove.
3991         (struct ppu2spu_data): Remove.
3992         (ppu2spu_unwind_register, ppu2spu_sniffer, ppu2spu_dealloc_cache,
3993         ppu2spu_unwind): Remove.
3994         (ppc_linux_init_abi): Remove Cell/B.E. support.
3995         * rs6000-tdep.h (rs6000_gdbarch_init): Remove Cell/B.E. support.
3996
3997         * features/Makefile (rs6000/powerpc-cell32l-expedite): Remove.
3998         (rs6000/powerpc-cell64l-expedite): Likewise
3999         (WHICH): Remove rs6000/powerpc-cell32l and rs6000/powerpc-cell64l.
4000         (XMLTOC): Remove rs6000/powerpc-cell32l.xml and
4001         rs6000/powerpc-cell64l.xml.
4002         * features/rs6000/powerpc-cell32l.xml: Remove.
4003         * features/rs6000/powerpc-cell64l.xml: Likewise.
4004         * features/rs6000/powerpc-cell32l.c: Remove generated file.
4005         * features/rs6000/powerpc-cell64l.c: Likewise.
4006         * regformats/rs6000/powerpc-cell32l.dat: Remove generated file.
4007         * regformats/rs6000/powerpc-cell64l.dat: Likewise.
4008         * regformats/reg-spu.dat: Remove.
4009
4010         * target.h (enum target_object): Remove TARGET_OBJECT_SPU.
4011         * corelow.c (struct spuid_list): Remove.
4012         (add_to_spuid_list): Remove.
4013         (core_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
4014         * remote.c (PACKET_qXfer_spu_read, PACKET_qXfer_spu_write): Remove.
4015         (remote_protocol_features): Remove associated entries.
4016         (_initialize_remote): No longer initialize them.
4017         (remote_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
4018         * linux-nat.c (SPUFS_MAGIC): Remove.
4019         (linux_proc_xfer_spu): Remove.
4020         (spu_enumerate_spu_ids): Remove.
4021         (linux_nat_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
4022         * linux-tdep.c (-linux_spu_make_corefile_notes): Remove.
4023         (linux_make_corefile_notes): No longer call it.
4024
4025         * regcache.c (cooked_read_test): Remove bfd_arch_spu special case.
4026         (cooked_write_test): Likewise.
4027
4028 2019-09-20  Tom Tromey  <tom@tromey.com>
4029
4030         * NEWS: Mention case-sensitivity of TUI commands.
4031         * tui/tui-win.c (tui_set_focus_command): Now case-sensitive.
4032         (tui_set_win_height_command, parse_scrolling_args): Likewise.
4033         * tui/tui-layout.c (tui_layout_command): Now case-sensitive.
4034
4035 2019-09-20  Tom Tromey  <tom@tromey.com>
4036
4037         * tui/tui-source.c (tui_source_window::set_contents): Use
4038         make_unique_xstrdup.
4039         * tui/tui-disasm.c (tui_disasm_window::set_contents): Use
4040         make_unique_xstrdup.
4041
4042 2019-09-20  Tom Tromey  <tom@tromey.com>
4043
4044         * tui/tui-data.c: Remove separator comments.
4045         * tui/tui-layout.c: Remove separator comments.
4046         * tui/tui-win.c: Remove separator comments.
4047         * tui/tui-wingeneral.c: Remove separator comments.
4048
4049 2019-09-20  Tom Tromey  <tom@tromey.com>
4050
4051         * tui/tui.h (strcat_to_buf): Don't declare.
4052         * tui/tui.c (strcat_to_buf): Remove.
4053
4054 2019-09-20  Tom Tromey  <tom@tromey.com>
4055
4056         * tui/tui-source.h (struct tui_source_window) <m_fullname>: Rename
4057         from "fullname".
4058         * tui/tui-source.c (tui_source_window::set_contents)
4059         (tui_source_window::location_matches_p)
4060         (tui_source_window::maybe_update): Update.
4061
4062 2019-09-20  Tom Tromey  <tom@tromey.com>
4063
4064         * tui/tui-regs.h (struct tui_data_window) <get_current_group>:
4065         Update.
4066         <m_regs_content, m_regs_column_count, m_current_group>: Add "m_"
4067         prefix.
4068         * tui/tui-regs.c (tui_data_window::last_regs_line_no)
4069         (tui_data_window::line_from_reg_element_no)
4070         (tui_data_window::first_reg_element_no_inline)
4071         (tui_data_window::show_registers)
4072         (tui_data_window::show_register_group)
4073         (tui_data_window::display_registers_from)
4074         (tui_data_window::display_registers_from_line)
4075         (tui_data_window::first_data_item_displayed)
4076         (tui_data_window::delete_data_content_windows)
4077         (tui_data_window::erase_data_content)
4078         (tui_data_window::do_scroll_vertical)
4079         (tui_data_window::refresh_window)
4080         (tui_data_window::check_register_values): Update.
4081
4082 2019-09-20  Tom Tromey  <tom@tromey.com>
4083
4084         * tui/tui-stack.h (MAX_LOCATOR_ELEMENT_LEN): Remove define.
4085         (struct tui_locator_window) <full_name, proc_name>: Now
4086         std::string.
4087         * tui/tui-stack.c (tui_locator_window::make_status_line)
4088         (tui_locator_window::set_locator_fullname)
4089         (tui_locator_window::set_locator_info): Update.
4090         * tui/tui-source.c (tui_source_window::set_contents)
4091         (tui_source_window::showing_source_p): Update.
4092
4093 2019-09-20  Tom Tromey  <tom@tromey.com>
4094
4095         * tui/tui-stack.c (tui_locator_window::set_locator_fullname):
4096         Don't call tui_locator_win_info_ptr.
4097
4098 2019-09-20  Tom Tromey  <tom@tromey.com>
4099
4100         * tui/tui-win.c (tui_resize_all): Don't call refresh.
4101
4102 2019-09-20  Tom Tromey  <tom@tromey.com>
4103
4104         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Use 1 as
4105         height for locator.
4106         * tui/tui-stack.c (tui_locator_window::rerender): Call scrollok.
4107         * tui/tui-layout.c (show_source_disasm_command, show_data)
4108         (show_source_or_disasm_and_command): Use 1 as height for locator.
4109
4110 2019-09-20  Tom Tromey  <tom@tromey.com>
4111
4112         * tui/tui.c (tui_enable): Update.
4113         * tui/tui-win.c (tui_sigwinch_handler, tui_async_resize_screen):
4114         Update.
4115         * tui/tui-data.h (tui_win_resized, tui_set_win_resized_to):
4116         Update.
4117         * tui/tui-data.c (win_resized): Now bool.
4118         (tui_win_resized): Return bool.
4119         (tui_set_win_resized_to): Accept a bool.
4120
4121 2019-09-20  Tom Tromey  <tom@tromey.com>
4122
4123         * tui/tui-regs.h (struct tui_data_window) <show_register_group>:
4124         Change type of "refresh_values_only".
4125         * tui/tui-regs.c (tui_data_window::show_register_group): Change
4126         type of "refresh_values_only".
4127
4128 2019-09-20  Tom Tromey  <tom@tromey.com>
4129
4130         * tui/tui-disasm.c (struct tui_asm_line) <addr_string, insn>: Now
4131         std::string.
4132         (tui_disassemble): Add "pos" parameter.
4133         (tui_disasm_window::set_contents): Simplify.
4134
4135 2019-09-20  Tom Tromey  <tom@tromey.com>
4136
4137         * tui/tui-winsource.h (struct tui_source_window_base)
4138         <show_source_content>: Now private.
4139         * tui/tui-winsource.c
4140         (tui_source_window_base::show_source_content): Don't handle empty
4141         content case.
4142
4143 2019-09-20  Tom Tromey  <tom@tromey.com>
4144
4145         * tui/tui-layout.c (show_source_disasm_command)
4146         (show_source_or_disasm_and_command): Don't call
4147         show_source_content.
4148
4149 2019-09-20  Tom Tromey  <tom@tromey.com>
4150
4151         * tui/tui-stack.h (struct tui_locator_window) <make_status_line>:
4152         Declare.
4153         * tui/tui-stack.c (tui_locator_window::make_status_line): Rename
4154         from tui_make_status_line.
4155         (tui_locator_window::rerender): Update.
4156
4157 2019-09-20  Tom Tromey  <tom@tromey.com>
4158
4159         * tui/tui-stack.c (tui_make_status_line): Return std::string.
4160         (tui_locator_window::rerender): Update.
4161
4162 2019-09-20  Tom Tromey  <tom@tromey.com>
4163
4164         * tui/tui-winsource.h (struct tui_source_window_base)
4165         <~tui_source_window_base>: Don't declare.
4166         <fullname>: Remove.
4167         * tui/tui-winsource.c (~tui_source_window_base): Remove.
4168         * tui/tui-source.h (struct tui_source_window) <fullname>: New
4169         member.
4170         * tui/tui-source.c (tui_source_window::set_contents): Update.
4171         (tui_source_window::location_matches_p)
4172         (tui_source_window::maybe_update): Update.
4173
4174 2019-09-20  Tom Tromey  <tom@tromey.com>
4175
4176         * tui/tui-winsource.h (~tui_source_element): Remove.
4177         (tui_source_element): Update.
4178         (struct tui_source_element) <line>: Now a unique_xmalloc_ptr.
4179         * tui/tui-winsource.c (tui_show_source_line): Update.
4180         * tui/tui-source.c (tui_source_window::set_contents): Update.
4181         * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
4182
4183 2019-09-20  Tom Tromey  <tom@tromey.com>
4184
4185         * tui/tui-data.h (tui_clear_source_windows_detail): Don't
4186         declare.
4187         * tui/tui-layout.c (tui_add_win_to_layout): Don't call
4188         tui_clear_source_windows_detail.
4189         * tui/tui-winsource.h (struct tui_source_window_base)
4190         <clear_detail>: Don't declare.
4191         * tui/tui-winsource.c (tui_source_window_base::clear_detail):
4192         Remove.
4193         * tui/tui-data.c (tui_clear_source_windows_detail): Remove.
4194
4195 2019-09-20  Tom Tromey  <tromey@adacore.com>
4196
4197         PR ada/24919:
4198         * block.c (contained_in): Fix final return value.
4199
4200 2019-09-20  Alan Modra  <amodra@gmail.com>
4201
4202         * gdb_bfd.c (gdb_bfd_ref, gdb_bfd_unref): Use bfd_set_usrdata.
4203         * dwarf2read.c (dwarf2_read_gdb_index, dwarf2_read_debug_names),
4204         (read_indirect_string_from_dwz): Use bfd accessor.
4205         * dwarf2read.h (struct dwz_file <filename>): Likewise.
4206         * machoread.c (macho_symfile_read_all_oso): Likewise.
4207         * solib.c (solib_bfd_open): Likewise.
4208
4209 2019-09-19  Christian Biesinger  <cbiesinger@google.com>
4210
4211         * eval.c: Move declaration of overload_resolution to...
4212         * value.h: ...here.
4213
4214 2019-09-19  Christian Biesinger  <cbiesinger@google.com>
4215
4216         * arm-linux-nat.c: Remove extern declaration for arm_apcs_32.
4217         * arm-linux-tdep.c: Likewise.
4218         * arm-nbsd-nat.c: Likewise.
4219         * arm-tdep.h: Declare arm_apcs_32.
4220         * arm-tdep.c: Move documentation for arm_apcs_32 to arm-tdep.h.
4221
4222 2019-09-19  Christian Biesinger  <cbiesinger@google.com>
4223
4224         * dwarf2loc.c: Remove extern declaration of dwarf_always_disassemble.
4225         * dwarf2read.h: Declare dwarf_always_disassemble.
4226
4227 2019-09-19  Tom de Vries  <tdevries@suse.de>
4228
4229         PR gdb/25009
4230         * source-cache.c (source_cache::ensure): Catch exception thrown during
4231         construction of the highlighter.
4232
4233 2019-09-18  Alan Modra  <amodra@gmail.com>
4234
4235         * aarch64-linux-tdep.c, * arm-tdep.c, * auto-load.c,
4236         * coff-pe-read.c, * coffread.c, * corelow.c, * dbxread.c,
4237         * dicos-tdep.c, * dwarf2-frame.c, * dwarf2read.c, * elfread.c,
4238         * exec.c, * fbsd-tdep.c, * gcore.c, * gdb_bfd.c, * gdb_bfd.h,
4239         * hppa-tdep.c, * i386-cygwin-tdep.c, * i386-fbsd-tdep.c,
4240         * i386-linux-tdep.c, * jit.c, * linux-tdep.c, * machoread.c,
4241         * maint.c, * mdebugread.c, * minidebug.c, * mips-linux-tdep.c,
4242         * mips-sde-tdep.c, * mips-tdep.c, * mipsread.c, * nto-tdep.c,
4243         * objfiles.c, * objfiles.h, * osabi.c, * ppc-linux-tdep.c,
4244         * ppc64-tdep.c, * record-btrace.c, * record-full.c, * remote.c,
4245         * rs6000-aix-tdep.c, * rs6000-tdep.c, * s390-linux-tdep.c,
4246         * s390-tdep.c, * solib-aix.c, * solib-dsbt.c, * solib-frv.c,
4247         * solib-spu.c, * solib-svr4.c, * solib-target.c,
4248         * spu-linux-nat.c, * spu-tdep.c, * symfile-mem.c, * symfile.c,
4249         * symmisc.c, * symtab.c, * target.c, * windows-nat.c,
4250         * xcoffread.c, * cli/cli-dump.c, * compile/compile-object-load.c,
4251         * mi/mi-interp.c: Update throughout for bfd section macro and
4252         function changes.
4253         * gcore (gcore_create_callback): Use bfd_set_section_lma.
4254         * spu-tdep.c (spu_overlay_new_objfile): Likewise.
4255
4256 2019-09-18  Tom Tromey  <tom@tromey.com>
4257
4258         * NEWS: Add entry.
4259         * tui/tui.c (tui_initialize_readline): Set name of keymap.  Do not
4260         call rl_initialize.
4261         (tui_enable): Do not call rl_initialize.
4262
4263 2019-09-18  Christian Groessler  <chris@groessler.org>
4264
4265         * alpha-linux-nat.c: Include gdbarch.h.
4266
4267 2019-09-18  Simon Marchi  <simon.marchi@polymtl.ca>
4268
4269         * ui-file.c: Include cli/cli-style.h.
4270         (term_cli_styling): Remove cli_styling declaration.
4271
4272 2019-09-18  Alan Modra  <amodra@gmail.com>
4273
4274         * arm-tdep.c (arm_record_special_symbol): Update bfd_get_section
4275         to bfd_asymbol_section.
4276
4277 2019-09-18  Alan Modra  <amodra@gmail.com>
4278
4279         * amd64-dicos-tdep.c (amd64_dicos_osabi_sniffer): Constify target.
4280         * i386-cygwin-tdep.c (i386_cygwin_init_abi): Likewise.
4281         * i386-dicos-tdep.c (i386_dicos_osabi_sniffer): Likewise.
4282
4283 2019-09-18  Alan Modra  <amodra@gmail.com>
4284
4285         * solib-spu.c (spu_bfd_open): Use bfd_set_filename.
4286         * spu-linux-nat.c (spu_bfd_open): Likewise.
4287
4288 2019-09-18  Christian Biesinger  <cbiesinger@google.com>
4289
4290         * dwarf2loc.c: Change extern declaration of dwarf_always_disassemble
4291         to bool to match definition in dwarf2read.c.
4292
4293 2019-09-17  Christian Biesinger  <cbiesinger@google.com>
4294
4295         * ada-lang.c (ada_ignore_descriptive_types_p): Change to bool.
4296         (print_signatures): Likewise.
4297         (trust_pad_over_xvs): Likewise.
4298         * arch/aarch64-insn.c (aarch64_debug): Likewise.
4299         * arch/aarch64-insn.h (aarch64_debug): Likewise.
4300         * arm-linux-nat.c (arm_apcs_32): Likewise.
4301         * arm-linux-tdep.c (arm_apcs_32): Likewise.
4302         * arm-nbsd-nat.c (arm_apcs_32): Likewise.
4303         * arm-tdep.c (arm_debug): Likewise.
4304         (arm_apcs_32): Likewise.
4305         * auto-load.c (debug_auto_load): Likewise.
4306         (auto_load_gdb_scripts): Likewise.
4307         (global_auto_load): Likewise.
4308         (auto_load_local_gdbinit): Likewise.
4309         (auto_load_local_gdbinit_loaded): Likewise.
4310         * auto-load.h (global_auto_load): Likewise.
4311         (auto_load_local_gdbinit): Likewise.
4312         (auto_load_local_gdbinit_loaded): Likewise.
4313         * breakpoint.c (disconnected_dprintf): Likewise.
4314         (breakpoint_proceeded): Likewise.
4315         (automatic_hardware_breakpoints): Likewise.
4316         (always_inserted_mode): Likewise.
4317         (target_exact_watchpoints): Likewise.
4318         (_initialize_breakpoint): Update.
4319         * breakpoint.h (target_exact_watchpoints): Change to bool.
4320         * btrace.c (maint_btrace_pt_skip_pad): Likewise.
4321         * cli/cli-cmds.c (trace_commands): Likewise.
4322         * cli/cli-cmds.h (trace_commands): Likewise.
4323         * cli/cli-decode.c (add_setshow_boolean_cmd): Change int* argument
4324         to bool*.
4325         * cli/cli-logging.c (logging_overwrite): Change to bool.
4326         (logging_redirect): Likewise.
4327         (debug_redirect): Likewise.
4328         * cli/cli-option.h (option_def) <boolean>: Change return type to bool*.
4329         (struct boolean_option_def) <get_var_address_cb_>: Change return type
4330         to bool.
4331         <boolean_option_def>: Update.
4332         (struct flag_option_def): Change default type of Context to bool
4333         from int.
4334         <flag_option_def>: Change return type of var_address_cb_ to bool*.
4335         * cli/cli-setshow.c (do_set_command): Cast to bool* instead of int*.
4336         (get_setshow_command_value_string): Likewise.
4337         * cli/cli-style.c (cli_styling): Change to bool.
4338         (source_styling): Likewise.
4339         * cli/cli-style.h (source_styling): Likewise.
4340         (cli_styling): Likewise.
4341         * cli/cli-utils.h (struct qcs_flags) <quiet, cont, silent>: Change
4342         to bool.
4343         * command.h (var_types): Update comment.
4344         (add_setshow_boolean_cmd): Change int* var argument to bool*.
4345         * compile/compile-cplus-types.c (debug_compile_cplus_types): Change to
4346         bool.
4347         (debug_compile_cplus_scopes): Likewise.
4348         * compile/compile-internal.h (compile_debug): Likewise.
4349         * compile/compile.c (compile_debug): Likewise.
4350         (struct compile_options) <raw>: Likewise.
4351         * cp-support.c (catch_demangler_crashes): Likewise.
4352         * cris-tdep.c (usr_cmd_cris_version_valid): Likewise.
4353         (usr_cmd_cris_dwarf2_cfi): Likewise.
4354         * csky-tdep.c (csky_debug): Likewise.
4355         * darwin-nat.c (enable_mach_exceptions): Likewise.
4356         * dcache.c (dcache_enabled_p): Likewise.
4357         * defs.h (info_verbose): Likewise.
4358         * demangle.c (demangle): Likewise.
4359         (asm_demangle): Likewise.
4360         * dwarf-index-cache.c (debug_index_cache): Likewise.
4361         * dwarf2-frame.c (dwarf2_frame_unwinders_enabled_p): Likewise.
4362         * dwarf2-frame.h (dwarf2_frame_unwinders_enabled_p): Likewise.
4363         * dwarf2read.c (check_physname): Likewise.
4364         (use_deprecated_index_sections): Likewise.
4365         (dwarf_always_disassemble): Likewise.
4366         * eval.c (overload_resolution): Likewise.
4367         * event-top.c (set_editing_cmd_var): Likewise.
4368         (exec_done_display_p): Likewise.
4369         * event-top.h (set_editing_cmd_var): Likewise.
4370         (exec_done_display_p): Likewise.
4371         * exec.c (write_files): Likewise.
4372         * fbsd-nat.c (debug_fbsd_lwp): Likewise
4373         (debug_fbsd_nat): Likewise.
4374         * frame.h (struct frame_print_options) <print_raw_frame_arguments>:
4375         Likewise.
4376         (struct set_backtrace_options) <backtrace_past_main>: Likewise.
4377         <backtrace_past_entry> Likewise.
4378         * gdb-demangle.h (demangle): Likewise.
4379         (asm_demangle): Likewise.
4380         * gdb_bfd.c (bfd_sharing): Likewise.
4381         * gdbcore.h (write_files): Likewise.
4382         * gdbsupport/common-debug.c (show_debug_regs): Likewise.
4383         * gdbsupport/common-debug.h (show_debug_regs): Likewise.
4384         * gdbthread.h (print_thread_events): Likewise.
4385         * gdbtypes.c (opaque_type_resolution): Likewise.
4386         (strict_type_checking): Likewise.
4387         * gnu-nat.c (gnu_debug_flag): Likewise.
4388         * guile/scm-auto-load.c (auto_load_guile_scripts): Likewise.
4389         * guile/scm-param.c (pascm_variable): Add boolval.
4390         (add_setshow_generic): Update.
4391         (pascm_param_value): Update.
4392         (pascm_set_param_value_x): Update.
4393         * hppa-tdep.c (hppa_debug): Change to bool..
4394         * infcall.c (may_call_functions_p): Likewise.
4395         (coerce_float_to_double_p): Likewise.
4396         (unwind_on_signal_p): Likewise.
4397         (unwind_on_terminating_exception_p): Likewise.
4398         * infcmd.c (startup_with_shell): Likewise.
4399         * inferior.c (print_inferior_events): Likewise.
4400         * inferior.h (startup_with_shell): Likewise.
4401         (print_inferior_events): Likewise.
4402         * infrun.c (step_stop_if_no_debug): Likewise.
4403         (detach_fork): Likewise.
4404         (debug_displaced): Likewise.
4405         (disable_randomization): Likewise.
4406         (non_stop): Likewise.
4407         (non_stop_1): Likewise.
4408         (observer_mode): Likewise.
4409         (observer_mode_1): Likewise.
4410         (set_observer_mode): Update.
4411         (sched_multi): Change to bool.
4412         * infrun.h (debug_displaced): Likewise.
4413         (sched_multi): Likewise.
4414         (step_stop_if_no_debug): Likewise.
4415         (non_stop): Likewise.
4416         (disable_randomization): Likewise.
4417         * linux-tdep.c (use_coredump_filter): Likewise.
4418         (dump_excluded_mappings): Likewise.
4419         * linux-thread-db.c (auto_load_thread_db): Likewise.
4420         (check_thread_db_on_load): Likewise.
4421         * main.c (captured_main_1): Update.
4422         * maint-test-options.c (struct test_options_opts) <flag_opt, xx1_opt,
4423         xx2_opt, boolean_opt>: Change to bool.
4424         * maint-test-settings.c (maintenance_test_settings_boolean): Likewise.
4425         * maint.c (maintenance_profile_p): Likewise.
4426         (per_command_time): Likewise.
4427         (per_command_space): Likewise.
4428         (per_command_symtab): Likewise.
4429         * memattr.c (inaccessible_by_default): Likewise.
4430         * mi/mi-main.c (mi_async): Likewise.
4431         (mi_async_1): Likewise.
4432         * mips-tdep.c (mips64_transfers_32bit_regs_p): Likewise.
4433         * nat/fork-inferior.h (startup_with_shell): Likewise.
4434         * nat/linux-namespaces.c (debug_linux_namespaces): Likewise.
4435         * nat/linux-namespaces.h (debug_linux_namespaces): Likewise.
4436         * nios2-tdep.c (nios2_debug): Likewise.
4437         * or1k-tdep.c (or1k_debug): Likewise.
4438         * parse.c (parser_debug): Likewise.
4439         * parser-defs.h (parser_debug): Likewise.
4440         * printcmd.c (print_symbol_filename): Likewise.
4441         * proc-api.c (procfs_trace): Likewise.
4442         * python/py-auto-load.c (auto_load_python_scripts): Likewise.
4443         * python/py-param.c (union parmpy_variable): Add "bool boolval" field.
4444         (set_parameter_value): Update.
4445         (add_setshow_generic): Update.
4446         * python/py-value.c (copy_py_bool_obj): Change argument from int*
4447         to bool*.
4448         * python/python.c (gdbpy_parameter_value): Cast to bool* instead of
4449         int*.
4450         * ravenscar-thread.c (ravenscar_task_support): Change to bool.
4451         * record-btrace.c (record_btrace_target::store_registers): Update.
4452         * record-full.c (record_full_memory_query): Change to bool.
4453         (record_full_stop_at_limit): Likewise.
4454         * record-full.h (record_full_memory_query): Likewise.
4455         * remote-notif.c (notif_debug): Likewise.
4456         * remote-notif.h (notif_debug): Likewise.
4457         * remote.c (use_range_stepping): Likewise.
4458         (interrupt_on_connect): Likewise.
4459         (remote_break): Likewise.
4460         * ser-tcp.c (tcp_auto_retry): Likewise.
4461         * ser-unix.c (serial_hwflow): Likewise.
4462         * skip.c (debug_skip): Likewise.
4463         * solib-aix.c (solib_aix_debug): Likewise.
4464         * spu-tdep.c (spu_stop_on_load_p): Likewise.
4465         (spu_auto_flush_cache_p): Likewise.
4466         * stack.c (struct backtrace_cmd_options) <full, no_filters, hide>:
4467         Likewise.
4468         (struct info_print_options) <quiet>: Likewise.
4469         * symfile-debug.c (debug_symfile): Likewise.
4470         * symfile.c (auto_solib_add): Likewise.
4471         (separate_debug_file_debug): Likewise.
4472         * symfile.h (auto_solib_add): Likewise.
4473         (separate_debug_file_debug): Likewise.
4474         * symtab.c (basenames_may_differ): Likewise.
4475         (struct filename_partial_match_opts) <dirname, basename>: Likewise.
4476         (struct info_print_options) <quiet, exclude_minsyms>: Likewise.
4477         (struct info_types_options) <quiet>: Likewise.
4478         * symtab.h (demangle): Likewise.
4479         (basenames_may_differ): Likewise.
4480         * target-dcache.c (stack_cache_enabled_1): Likewise.
4481         (code_cache_enabled_1): Likewise.
4482         * target.c (trust_readonly): Likewise.
4483         (may_write_registers): Likewise.
4484         (may_write_memory): Likewise.
4485         (may_insert_breakpoints): Likewise.
4486         (may_insert_tracepoints): Likewise.
4487         (may_insert_fast_tracepoints): Likewise.
4488         (may_stop): Likewise.
4489         (auto_connect_native_target): Likewise.
4490         (target_stop_and_wait): Update.
4491         (target_async_permitted): Change to bool.
4492         (target_async_permitted_1): Likewise.
4493         (may_write_registers_1): Likewise.
4494         (may_write_memory_1): Likewise.
4495         (may_insert_breakpoints_1): Likewise.
4496         (may_insert_tracepoints_1): Likewise.
4497         (may_insert_fast_tracepoints_1): Likewise.
4498         (may_stop_1): Likewise.
4499         * target.h (target_async_permitted): Likewise.
4500         (may_write_registers): Likewise.
4501         (may_write_memory): Likewise.
4502         (may_insert_breakpoints): Likewise.
4503         (may_insert_tracepoints): Likewise.
4504         (may_insert_fast_tracepoints): Likewise.
4505         (may_stop): Likewise.
4506         * thread.c (struct info_threads_opts) <show_global_ids>: Likewise.
4507         (make_thread_apply_all_options_def_group): Change argument from int*
4508         to bool*.
4509         (thread_apply_all_command): Update.
4510         (print_thread_events): Change to bool.
4511         * top.c (confirm): Likewise.
4512         (command_editing_p): Likewise.
4513         (history_expansion_p): Likewise.
4514         (write_history_p): Likewise.
4515         (info_verbose): Likewise.
4516         * top.h (confirm): Likewise.
4517         (history_expansion_p): Likewise.
4518         * tracepoint.c (disconnected_tracing): Likewise.
4519         (circular_trace_buffer): Likewise.
4520         * typeprint.c (print_methods): Likewise.
4521         (print_typedefs): Likewise.
4522         * utils.c (debug_timestamp): Likewise.
4523         (sevenbit_strings): Likewise.
4524         (pagination_enabled): Likewise.
4525         * utils.h (sevenbit_strings): Likewise.
4526         (pagination_enabled): Likewise.
4527         * valops.c (overload_resolution): Likewise.
4528         * valprint.h (struct value_print_options) <prettyformat_arrays,
4529         prettyformat_structs, vtblprint, unionprint, addressprint, objectprint,
4530         stop_print_at_null, print_array_indexes, deref_ref, static_field_print,
4531         pascal_static_field_print, raw, summary, symbol_print, finish_print>:
4532         Likewise.
4533         * windows-nat.c (new_console): Likewise.
4534         (cygwin_exceptions): Likewise.
4535         (new_group): Likewise.
4536         (debug_exec): Likewise.
4537         (debug_events): Likewise.
4538         (debug_memory): Likewise.
4539         (debug_exceptions): Likewise.
4540         (useshell): Likewise.
4541         * windows-tdep.c (maint_display_all_tib): Likewise.
4542         * xml-support.c (debug_xml): Likewise.
4543
4544 2019-09-17  Mike Gulick  <mgulick@mathworks.com>
4545
4546         * source.c (prepare_path_for_appending): New function.
4547         (openp): Make use of new function.
4548         (find_and_open_source): Search for the compilation directory and
4549         source file as a relative path beneath the directory search path.
4550
4551 2019-09-17  Andrew Burgess  <andrew.burgess@embecosm.com>
4552
4553         * source-cache.c (source_cache::get_line_charpos): Catch
4554         exceptions and return false, this matches the behaviour documented
4555         in the header file.
4556
4557 2019-09-17  Joel Brobecker  <brobecker@adacore.com>
4558
4559         * ada-tasks.c (info_task): Remove quoting of the task's name.
4560
4561 2019-09-16  Christian Biesinger  <cbiesinger@google.com>
4562
4563         * symfile.c (auto_solib_add): Replace comment with a reference
4564         to the header file.
4565
4566 2019-09-14  Christian Biesinger  <cbiesinger@google.com>
4567
4568         * NEWS: Mention that gdb can now be compiled with Python 3
4569         on Windows.
4570
4571 2019-09-12  Andrew Burgess  <andrew.burgess@embecosm.com>
4572
4573         * maint.c (maint_print_section_data::maint_print_section_data):
4574         Force use of 'float log10 (float)' by casting the argument to
4575         float.
4576
4577 2019-09-12  Andrew Burgess  <andrew.burgess@embecosm.com>
4578
4579         * maint.c: Add 'cmath' include.
4580         (struct maint_print_section_data): New structure.
4581         (print_section_index): New function.
4582         (print_bfd_section_info): Add header comment, small whitespace
4583         cleanup, and update to call new print_section_index function.
4584         (print_objfile_section_info): Likewise.
4585         (maint_obj_section_from_bfd_section): New function.
4586         (print_bfd_section_info_maybe_relocated): New function.
4587         (maintenance_info_sections): Add header comment, always use
4588         bfd_map_over_sections instead of ALL_OBJFILE_OSECTIONS.
4589
4590 2019-09-12  Andrew Burgess  <andrew.burgess@embecosm.com>
4591
4592         * psymtab.c (find_pc_sect_psymtab): Move baseaddr local into more
4593         inner scope, add check that the objfile has psymtabs before
4594         checking psymtabs_addrmap.
4595         * psymtab.h (psymtab_storage) <psymtabs_addrmap>: Extend comment.
4596
4597 2019-09-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4598
4599         * NEWS: Announce that Ada task names are now shown at more places,
4600         and between quotes (except in info task output).
4601         * gdb/ada-tasks.c (task_to_str): New function.
4602         (display_current_task_id): Call task_to_str.
4603         (task_command_1): Likewise.
4604         (print_ada_task_info): In non-mi mode, Properly align headers and data
4605         when task-id length is > 9 (9 is the default for a 32 bits CORE_ADDR).
4606
4607 2019-09-12  Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
4608
4609         * procfs.c (procfs_target::wait) <PR_FAULTED>: Get signal from
4610         prstatus.pr_lwp.pr_info instead of making it up.
4611
4612 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
4613
4614         * auto-load.c (auto_load_expand_dir_vars): Update.
4615         * defs.h (gdb_datadir): Change to std::string.
4616         (python_libdir): Likewise.
4617         (relocate_gdb_directory): Change return type to std::string.
4618         * guile/guile.c (gdbscm_data_directory): Update.
4619         (initialize_scheme_side): Update.
4620         * jit.c (jit_reader_dir): Change to std::string.
4621         (jit_reader_load_command): Update.
4622         * main.c (gdb_datadir): Change to std::string.
4623         (python_libdir): Likewise.
4624         (set_gdb_data_directory): Update.
4625         (relocate_path): Change to return std::string.
4626         (relocate_gdb_directory): Change to return std::string.
4627         (relocate_gdbinit_path_maybe_in_datadir): Update.
4628         (captured_main_1): Update.
4629         * python/python.c (do_start_initialization): Update.
4630         * top.c (show_gdb_datadir): Update.
4631         * xml-syscall.c (xml_init_syscalls_info): Update.
4632         (init_syscalls_info): Update.
4633
4634 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
4635
4636         * main.c (relocate_gdbinit_path_maybe_in_datadir): Factor this code
4637         out of get_init_files.
4638         (get_init_files): Update.
4639
4640 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
4641
4642         * main.c (get_init_files): Change to use std::string.
4643         (captured_main_1): Update.
4644         (print_gdb_help): Update.
4645
4646 2019-09-11  Ali Tamur  <tamur@google.com>
4647
4648         *gdb/target-float.c (host_float_ops<T>::to_longest): Update
4649         implementation.
4650
4651 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
4652
4653         * dbxread.c (read_dbx_symtab): Update.
4654         * dwarf2read.c (load_partial_dies): Update.
4655         * mdebugread.c (parse_partial_symbols): Update.
4656         (handle_psymbol_enumerators): Update.
4657         * psympriv.h (add_psymbol_to_list): Change type of copy_names to bool.
4658         * psymtab.c (add_psymbol_to_bcache): Likewise.
4659         (add_psymbol_to_list): Likewise.
4660         * symtab.c (symbol_set_names): Likewise.
4661         * symtab.h (symbol_set_names): Likewise.
4662         * xcoffread.c (scan_xcoff_symtab): Update.
4663
4664 2019-09-11  Tom Tromey  <tom@tromey.com>
4665
4666         * symfile-mem.c (symbol_file_add_from_memory): Use
4667         bfd_set_filename.
4668         * solib-darwin.c (darwin_bfd_open): Use bfd_set_filename.
4669         * solib-aix.c (solib_aix_bfd_open): Use bfd_set_filename.
4670
4671 2019-09-10  Tom Tromey  <tromey@adacore.com>
4672
4673         * dwarf-index-write.c (write_psymbols): Extend error message.
4674         (debug_names::insert): Add Ada code.
4675         (debug_names::write_psymbols): Remove Ada check.
4676         (debug_names) <m_string_obstack>: New member.
4677         * dwarf2read.c (gdb_index_symbol_name_matcher): Remove.
4678         (gdb_index_symbol_name_matcher::matches): Remove.
4679         (mapped_index_base::find_name_components_bounds): Add "lang"
4680         parameter.
4681         (mapped_index_base::build_name_components): Also split names
4682         according to Ada syntax.
4683         (dw2_expand_symtabs_matching_symbol): Loop over languages.  Change
4684         type of "match_callback".
4685         (check_match, check_find_bounds_finds)
4686         (dw2_expand_symtabs_matching): Update.
4687         (dw2_debug_names_iterator): Add new constructor.
4688         (dw2_debug_names_map_matching_symbols): New function.
4689         (dw2_debug_names_expand_symtabs_matching): Update.
4690         (dwarf2_debug_names_functions): Use
4691         dw2_debug_names_map_matching_symbols.
4692
4693 2019-09-10  Tom Tromey  <tromey@adacore.com>
4694
4695         * dwarf2read.c (dw2_get_file_names_reader): Add the
4696         CU's file name to the results.
4697
4698 2019-09-10  Tom Tromey  <tromey@adacore.com>
4699
4700         * ada-lang.c (add_nonlocal_symbols): Combine calls to
4701         map_matching_symbols.  Update.
4702         * dwarf2read.c (dw2_map_matching_symbols): Update.
4703         * psymtab.c (match_partial_symbol): Change type; update.
4704         (psym_map_matching_symbols): Likewise.
4705         * symfile-debug.c (debug_qf_map_matching_symbols): Change
4706         type; update.
4707         * symfile.h (struct quick_symbol_functions)
4708         <map_matching_symbols>: Change "name" to be a lookup_name_info.
4709         Remove "match".
4710
4711 2019-09-10  Tom Tromey  <tromey@adacore.com>
4712
4713         * psymtab.c (map_block): Remove.
4714         (psym_map_matching_symbols): Use iterate_over_symbols_terminated.
4715         * symtab.c (iterate_over_symbols_terminated): New function.
4716         * symtab.c (iterate_over_symbols_terminated): Declare.
4717
4718 2019-09-10  Tom Tromey  <tromey@adacore.com>
4719
4720         * ada-lang.c (ada_iterate_over_symbols): Return bool.
4721         * language.h (struct language_defn) <la_iterate_over_symbols>:
4722         Return bool.
4723         * symtab.c (iterate_over_symbols): Return bool.
4724         * symtab.h (iterate_over_symbols): Return bool.
4725
4726 2019-09-10  Tom Tromey  <tromey@adacore.com>
4727
4728         * ada-lang.c (aux_add_nonlocal_symbols): Change type.
4729         (add_nonlocal_symbols): Update.
4730         * dwarf2read.c (dw2_map_matching_symbols): Change type.
4731         * psymtab.c (map_block, psym_map_matching_symbols): Change type.
4732         * symfile-debug.c (debug_qf_map_matching_symbols): Change type.
4733         * symfile.h (struct quick_symbol_functions) <map_matching_symbols>:
4734         Change type of "callback".  Remove "data".
4735
4736
4737 2019-09-09  Ali Tamur  <tamur@google.com>
4738
4739         * dwarf2read.c (comp_unit_head): Update comment.
4740         (dwarf2_dwo_name): New function declaration.
4741         (dwarf_unit_type_name): New function declaration.
4742         (read_comp_unit_head): Add support for new compilation units,
4743         DW_UT_partial, DW_UT_skeleton, DW_UT_split_compile, DW_UT_split_type.
4744         Particularly, DW_UT_skeleton and DW_UT_split_compile have dwo_id
4745         (currently named as "signature") in their header. Also clarify error
4746         messages.
4747         (lookup_dwo_id): New function. Returns the dwo id of the given
4748         compile unit.
4749         (lookup_dwo_unit): Use the new lookup_dwo_id function.
4750         (init_cutu_and_read_dies): Use the new dwarf2_dwo_name and lookup_dwo_id
4751         functions.
4752         (create_dwo_cu_reader): Use the added lookup_dwo_id function.
4753         (dwarf2_dwo_name): Get the dwo name if present.
4754         (dwarf_unit_type_name): Convert DW_UT_* types to string for diagnostic
4755         purposes.
4756
4757 2019-09-09  Tom Tromey  <tom@tromey.com>
4758
4759         * tui/tui-win.c (tui_all_windows_info): Use ui_out.
4760
4761 2019-09-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4762
4763         * python/python.c (do_start_initialization): Make progname_copy static,
4764         to avoid a leak report.
4765
4766 2019-09-08  Tom Tromey  <tom@tromey.com>
4767
4768         * tui/tui-wingeneral.c (box_win): Truncate long window titles.
4769
4770 2019-09-07  Simon Marchi  <simon.marchi@efficios.com>
4771
4772         * dwarf2read.c (struct dw2_symtab_iterator) <block_index>:
4773         Change type to gdb::optional<block_enum>.
4774         (dw2_symtab_iter_init): Change block_index parameter type
4775         to gdb::optional<block_enum>.
4776         (dw2_lookup_symbol): Change block_index parameter
4777         type to block_enum.c
4778         (dw2_debug_names_lookup_symbol): Likewise.
4779         * psymtab.c (psym_lookup_symbol): Likewise.
4780         * symfile-debug.c (debug_qf_lookup_symbol): Likewise.
4781         * symfile.h (struct quick_symbol_functions) <lookup_symbol>:
4782         Likewise.
4783
4784 2019-09-06  Christian Biesinger  <cbiesinger@google.com>
4785
4786         * defs.h (relocate_gdb_directory): Change int to bool in
4787         signature and rename flag to relocatable.
4788         * main.c (relocate_path): Likewise.
4789         (relocate_gdb_directory): Likewise.
4790
4791 2019-09-06  Alan Modra  <amodra@gmail.com>
4792
4793         * coffread.c (coff_symfile_read): Constify filename variable.
4794         * dbxread.c (dbx_symfile_init, coffstab_build_psymtabs),
4795         (elfstab_build_psymtabs, stabsect_build_psymtabs): Likewise.
4796         * gdb_bfd.c (gdb_bfd_close_or_warn): Likewise.
4797         * solib.c (reload_shared_libraries_1): Likewise.
4798         * symfile.c (reread_symbols): Likewise.
4799         * solib-aix.c (solib_aix_bfd_open): Add cast for xfree of filename.
4800         * solib-darwin.c (darwin_bfd_open): Likewise.
4801         * symfile-mem.c (symbol_file_add_from_memory): Likewise.
4802
4803 2019-09-03  Andrew Burgess  <andrew.burgess@embecosm.com>
4804
4805         * psymtab.c (print_partial_symbols): Handle missing domain_enum
4806         values MODULE_DOMAIN and COMMON_BLOCK_DOMAIN.
4807
4808 2019-09-03  Tom Tromey  <tromey@adacore.com>
4809
4810         * ada-valprint.c (ada_val_print_num): Don't recurse for range
4811         types.
4812         (has_negatives): Unbias a range type bound.
4813         * dwarf2read.c (read_subrange_type): Handle DW_AT_GNU_bias.
4814         * gdbtypes.c (operator==): Handle new field.
4815         (create_range_type): Add "bias" parameter.
4816         (create_static_range_type, resolve_dynamic_range): Update.
4817         * gdbtypes.h (struct range_bounds) <bias>: New member.
4818         (create_range_type): Add bias parameter.
4819         * printcmd.c (print_scalar_formatted): Unbias range types.
4820         * value.c (unpack_long): Unbias range types.
4821         (pack_long): Bias range types.
4822
4823 2019-09-02  Alan Hayward  <alan.hayward@arm.com>
4824
4825         * solib-svr4.c (svr4_find_and_create_probe_breakpoints): Check all
4826         probe arguments.
4827
4828 2019-09-02  Alan Hayward  <alan.hayward@arm.com>
4829
4830         * break-catch-throw.c (fetch_probe_arguments): Use gdbarch.
4831         * dtrace-probe.c (dtrace_probe::get_argument_count): Likewise.
4832         * probe.c (probe_safe_evaluate_at_pc) (compute_probe_arg)
4833         (compile_probe_arg): Likewise.
4834         * probe.h (get_argument_count): Likewise.
4835         * solib-svr4.c (solib_event_probe_action): Likewise.
4836         * stap-probe.c (stap_probe::get_argument_count): Likewise.
4837
4838 2019-09-02  Alan Hayward  <alan.hayward@arm.com>
4839
4840         * solib-svr4.c (svr4_find_and_create_probe_breakpoints): Move
4841         code to here...
4842         (svr4_create_solib_event_breakpoints): ...from here.
4843
4844 2019-08-30  Sergio Durigan Junior  <sergiodj@redhat.com>
4845
4846         * nat/fork-inferior.c (trace_start_error): Remove "\nError: "
4847         suffix from warning message.
4848
4849 2019-08-30  Tom Tromey  <tom@tromey.com>
4850
4851         * tui/tui-winsource.h (struct tui_source_window_base)
4852         <refresh_all>: Don't declare.
4853         * tui/tui-winsource.c (tui_source_window_base::refresh_all):
4854         Remove.
4855         * tui/tui-win.c (tui_refresh_all_win): Don't call refresh_all or
4856         tui_show_locator_content.
4857         * tui/tui-regs.h (struct tui_data_window) <refresh_all>: Don't
4858         declare.
4859         * tui/tui-regs.c (tui_data_window::refresh_all): Remove.
4860         * tui/tui-data.h (struct tui_win_info) <refresh_all>: Don't
4861         declare.
4862
4863 2019-08-30  Tom Tromey  <tom@tromey.com>
4864
4865         * tui/tui-io.c (tui_cont_sig): Don't call wrefresh.
4866
4867 2019-08-30  Tom Tromey  <tom@tromey.com>
4868
4869         * tui/tui-stack.c (_initialize_tui_stack): Move later.
4870         Remove unnecessary forward declarations.
4871
4872 2019-08-30  Tom Tromey  <tom@tromey.com>
4873
4874         * tui/tui-stack.c (tui_locator_window::set_locator_fullname): Call
4875         rerender.
4876         (tui_update_locator_fullname, tui_show_frame_info): Don't call
4877         tui_show_locator_content.
4878
4879 2019-08-30  Tom Tromey  <tom@tromey.com>
4880
4881         * tui/tui-stack.c (tui_show_locator_content): Move lower.  Rewrite.
4882         (tui_locator_window::rerender): Rewrite using body of previous
4883         tui_show_locator_content.
4884
4885 2019-08-30  Tom Tromey  <tom@tromey.com>
4886
4887         * tui/tui-stack.h (struct tui_locator_window) <set_locator_info,
4888         set_locator_fullname>: New methods.
4889         * tui/tui-stack.c (tui_locator_window::set_locator_fullname):
4890         Rename from tui_set_locator_fullname.
4891         (tui_locator_window::set_locator_info): Rename from
4892         tui_set_locator_info.  Return bool.
4893         (tui_update_locator_fullname, tui_show_frame_info): Update.
4894
4895 2019-08-30  Tom Tromey  <tom@tromey.com>
4896
4897         * tui/tui-layout.c (show_layout): Don't call tui_refresh_all.
4898
4899 2019-08-30  Tom Tromey  <tom@tromey.com>
4900
4901         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Don't
4902         call touchwin.
4903
4904 2019-08-30  Tom Tromey  <tom@tromey.com>
4905
4906         * tui/tui-wingeneral.c (box_win): Assume win_info and
4907         win_info->handle cannot be NULL.
4908
4909 2019-08-30  Tom Tromey  <tom@tromey.com>
4910
4911         * tui/tui-regs.h (struct tui_data_item_window) <rerender,
4912         refresh_window>: Declare.
4913         * tui/tui-regs.c (tui_data_window::display_registers_from): Call
4914         resize.
4915         (tui_data_item_window::rerender): Rename from
4916         tui_display_register.
4917         (tui_data_item_window::refresh_window): New method.
4918         * tui/tui-layout.c (tui_gen_win_info::resize): Do nothing on
4919         no-op.
4920
4921 2019-08-30  Tom Tromey  <tom@tromey.com>
4922
4923         * tui/tui-regs.h (struct tui_data_window) <regs_content,
4924         regs_column_count, current_group>: Move later.  Now private.
4925         <get_current_group>: New method.
4926         * tui/tui-regs.c (tui_reg_command): Update.
4927         * tui/tui-layout.c (tui_set_layout): Update.
4928
4929 2019-08-30  Tom Tromey  <tom@tromey.com>
4930
4931         * tui/tui-regs.c (tui_data_window::display_registers_from_line)
4932         (tui_data_window::rerender): Don't call
4933         check_and_display_highlight_if_needed.
4934         (tui_data_window::refresh_all): Remove call to
4935         erase_data_content.
4936
4937 2019-08-30  Tom Tromey  <tom@tromey.com>
4938
4939         * tui/tui-regs.c (tui_data_window::last_regs_line_no)
4940         (tui_data_window::display_registers_from)
4941         (tui_data_window::display_reg_element_at_line)
4942         (tui_data_window::display_registers_from_line): Remove checks of
4943         "empty".
4944
4945 2019-08-30  Tom Tromey  <tom@tromey.com>
4946
4947         * tui/tui-regs.h (struct tui_data_window) <display_all_data>:
4948         Don't declare.
4949         * tui/tui-regs.c (tui_data_window::show_registers): Call
4950         rerender.
4951         (tui_data_window::rerender): Rename from display_all_data.
4952         (tui_data_window::rerender): Remove old implementation.
4953
4954 2019-08-30  Tom Tromey  <tom@tromey.com>
4955
4956         * tui/tui-regs.c (tui_data_window::display_all_data): Change
4957         text.
4958         * tui/tui-data.h (NO_DATA_STRING): Remove define.
4959
4960 2019-08-29  Bernhard Wodok  <barto@gmx.net>
4961             Sergio Durigan Junior  <sergiodj@redhat.com>
4962
4963         PR win32/24284
4964         * mingw-hdep.c (gdb_select): Handle case when 'n' is zero.
4965
4966 2019-08-28  Andrew Burgess  <andrew.burgess@embecosm.com>
4967
4968         * symtab.c (search_symbols): Don't include MODULE_DOMAIN symbols
4969         when searching for types.
4970
4971 2019-08-28  Andrew Burgess  <andrew.burgess@embecosm.com>
4972
4973         * f-lang.c (f_language_defn): Use f_print_typedef.
4974         * f-lang.h (f_print_typedef): Declare.
4975         * f-typeprint.c (f_print_typedef): Define.
4976
4977 2019-08-27  Christian Biesinger  <cbiesinger@google.com>
4978
4979         * nat/linux-namespaces.c (mnsh_main): Initialize fd (to -1).
4980
4981 2019-08-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4982
4983         * cli/cli-utils.c (info_print_options_defs): Delete.
4984         (make_info_print_options_def_group): Delete.
4985         (extract_info_print_options): Delete.
4986         (info_print_command_completer): Delete.
4987         (info_print_args_help): Add extra parameter, and optionally
4988         include text about -n flag.
4989         * cli/cli-utils.h (struct info_print_options): Delete.
4990         (extract_info_print_options): Delete declaration.
4991         (info_print_command_completer): Delete declaration.
4992         (info_print_args_help): Add extra parameter, extend header
4993         comment.
4994         * python/python.c (gdbpy_rbreak): Pass additional parameter to
4995         search_symbols.
4996         * stack.c (struct info_print_options): New type.
4997         (info_print_options_defs): New file scoped variable.
4998         (make_info_print_options_def_group): New static function.
4999         (info_print_command_completer): New static function.
5000         (info_locals_command): Update to use new local functions.
5001         (info_args_command): Likewise.
5002         (_initialize_stack): Add extra parameter to calls to
5003         info_print_args_help.
5004         * symtab.c (search_symbols): Add extra parameter, use this to
5005         possibly excluse non-debug symbols.
5006         (symtab_symbol_info): Add extra parameter, which is passed on to
5007         search_symbols.
5008         (struct info_print_options): New type.
5009         (info_print_options_defs): New file scoped variable.
5010         (make_info_print_options_def_group): New static function.
5011         (info_print_command_completer): New static function.
5012         (info_variables_command): Update to use local functions, and pass
5013         extra parameter through to symtab_symbol_info.
5014         (info_functions_command): Likewise.
5015         (info_types_command): Pass additional argument through to
5016         symtab_symbol_info.
5017         (rbreak_command): Pass extra argument to search_symbols.
5018         (_initialize_symtab): Add extra arguments for calls to
5019         info_print_args_help, and update help text for 'info variables',
5020         'whereis', and 'info functions' commands.
5021         * symtab.h (search_symbols): Add extra argument to declaration.
5022         * NEWS: Mention new flags.
5023
5024 2019-08-26  Christian Biesinger  <cbiesinger@google.com>
5025
5026         * symtab.c (lookup_static_symbol): Call the new function (and move
5027         it down to be next to lookup_global_symbol).
5028         (struct global_sym_lookup_data): Add block_enum member and rename to...
5029         (struct global_or_static_sym_lookup_data): ...this.
5030         (lookup_symbol_global_iterator_cb): Pass block_index instead of
5031         GLOBAL_BLOCK to lookup_symbol_in_objfile and rename to...
5032         (lookup_symbol_global_or_static_iterator_cb): ...this.
5033         (lookup_global_or_static_symbol): New function.
5034         (lookup_global_symbol): Call new function.
5035
5036 2019-08-26  Tom de Vries  <tdevries@suse.de>
5037
5038         PR c++/24852
5039         * break-catch-throw.c (fetch_probe_arguments): Improve error mesage
5040         when pc_probe.prob == NULL.
5041
5042 2019-08-25  Simon Marchi  <simon.marchi@efficios.com>
5043
5044         * dwarf2read.c (dw2_debug_names_iterator::next): Rename local
5045         variable symbol_linkage to symbol_linkage_.
5046
5047 2019-08-25  Simon Marchi  <simon.marchi@efficios.com>
5048
5049         * dwarf2read.c (dw2_debug_names_iterator::next): Use enum to
5050         represent whether the symbol is static, dynamic, or we don't
5051         know.
5052
5053 2019-08-25  Yoshinori Sato <ysato@users.sourceforge.jp>
5054
5055         * gdb/rx-tdep.c (rx_register_names): New.
5056         (rx_register_name): Delete.
5057         (rx_psw_type): Delete.
5058         (rx_fpsw_type): Delete.
5059         (rx_register_type): Delete.
5060         (rx_gdbarch_init): Convert target-descriptions.
5061         (_initialize_rx_tdep): Add initialize_tdesc_rx.
5062         * gdb/features/Makefile: Add rx.xml.
5063         * gdb/features/rx.xml: New.
5064         * gdb/features/rx.c: Generated.
5065         * gdb/NEWS: Mention target description support.
5066
5067 2019-08-22  Christian Biesinger  <cbiesinger@google.com>
5068
5069         * symtab.c (symbol_cache_lookup): Always initialize *bsc_ptr and
5070         *slot_ptr.
5071
5072 2019-08-23  Sergio Durigan Junior  <sergiodj@redhat.com>
5073
5074         * configure.ac: Don't check for 'dlfcn.h' (moved to
5075         gdbsupport/common.m4).
5076         * Makefile.in (COMMON_SFILES): Move 'gdb-dlfcn.c' to
5077         'gdbsupport/'.
5078         (HFILES_NO_SRCDIR): Likewise, for 'gdb-dlfcn.h'.
5079         * compile/compile-c-support.c: Include
5080         'gdbsupport/gdb-dlfcn.h'.
5081         * gdbsupport/common.m4: Check for 'dlfcn.h'.
5082         * gdb-dlfcn.c: Move to...
5083         * gdbsupport/gdb-dlfcn.c: ... here.
5084         * gdb-dlfcn.h: Move to...
5085         * gdbsupport/gdb-dlfcn.h: ... here.
5086
5087 2019-08-23  Sandra Loosemore  <sandra@codesourcery.com>
5088
5089         * nios2-tdep.c (struct reg_value): Improve comments.  Make
5090         the offset field signed.
5091
5092 2019-08-22  Christian Biesinger  <cbiesinger@google.com>
5093
5094         * python/lib/gdb/__init__.py (_execute_file): New function.
5095         * python/python.c (python_run_simple_file): Call gdb._execute_file
5096         on Windows.
5097
5098 2019-08-22  Andrew Burgess  <andrew.burgess@embecosm.com>
5099
5100         * f-exp.y (yylex): Remove is_a_field_of_this local variable, and
5101         all uses as this was never set to anything but a zero value.
5102
5103 2019-08-21  Bogdan Harjoc  <harjoc@gmail.com>
5104
5105         * cli/cli-cmds.c (with_command_1): Error out if no arguments.
5106
5107 2019-08-21  Christian Biesinger  <cbiesinger@google.com>
5108
5109         * tui/tui-data.h (tui_gen_win_info): Add an =default
5110         move constructor, required by some GCC versions.
5111
5112 2019-08-21  Jinke Fan  <fanjinke51@yeah.net>
5113
5114         * go32-nat.c (go32_sysinfo): Add hygon_p.
5115
5116 2019-08-20  Tom Tromey  <tom@tromey.com>
5117
5118         * tui/tui-regs.h (struct tui_data_window) <last_regs_line_no,
5119         line_from_reg_element_no, first_reg_element_no_inline,
5120         display_all_data, delete_data_content_windows,
5121         erase_data_content>: Now private.
5122
5123 2019-08-20  Tom Tromey  <tom@tromey.com>
5124
5125         * tui/tui-wingeneral.c (box_win): Change type of highlight_flag.
5126         (tui_unhighlight_win, tui_highlight_win)
5127         (tui_win_info::make_window): Update.
5128         * tui/tui-data.h (HILITE, NO_HILITE): Remove.
5129
5130 2019-08-20  Tom Tromey  <tom@tromey.com>
5131
5132         * tui/tui-data.h (PROC_PREFIX, LINE_PREFIX, PC_PREFIX)
5133         (MIN_LINE_WIDTH, MIN_PROC_WIDTH, MAX_TARGET_WIDTH)
5134         (MAX_PID_WIDTH): Move to tui-stack.c.
5135         * tui/tui-stack.c (PROC_PREFIX, LINE_PREFIX, PC_PREFIX)
5136         (MIN_LINE_WIDTH, MIN_PROC_WIDTH, MAX_TARGET_WIDTH)
5137         (MAX_PID_WIDTH): Move from tui-data.h.
5138
5139 2019-08-20  Tom Tromey  <tom@tromey.com>
5140
5141         * tui/tui-wingeneral.h (tui_make_window): Don't declare.
5142         * tui/tui-wingeneral.c (box_win): Change type of win_info.
5143         (box_win): Update.
5144         (tui_gen_win_info::make_window): Rename from tui_make_window.
5145         (tui_win_info::make_window): New method.
5146         (tui_gen_win_info::make_visible): Update.
5147         * tui/tui-source.c (tui_source_window::set_contents): Update.
5148         * tui/tui-regs.c (tui_data_window::show_register_group): Update.
5149         (tui_data_window::display_registers_from): Update.
5150         * tui/tui-layout.c (tui_gen_win_info::resize): Update.
5151         * tui/tui-data.h (struct tui_gen_win_info) <make_window>:
5152         Declare.
5153         <can_box>: Remove.
5154         <title>: Remove.
5155         (struct tui_win_info) <make_window>: Declare.
5156         <can_box>: Now virtual.
5157         <title>: New member.
5158         * tui/tui-data.c (~tui_gen_win_info): Don't free title.
5159         * tui/tui-command.c (tui_cmd_window::resize): Update.
5160
5161 2019-08-20  Tom Tromey  <tom@tromey.com>
5162
5163         * tui/tui-regs.h (struct tui_data_window) <display_regs>: Remove.
5164         * tui/tui-regs.c (tui_data_window::show_registers): Update.
5165         (tui_data_window::check_register_values): Update.
5166
5167 2019-08-20  Tom Tromey  <tom@tromey.com>
5168
5169         * tui/tui-regs.h (struct tui_data_window): Use
5170         DISABLE_COPY_AND_ASSIGN.
5171         <regs_content>: Change type, removing unique_ptr.
5172         <tui_data_window>: Add move constructor.
5173         * tui/tui-regs.c (tui_data_window::show_registers)
5174         (tui_data_window::show_register_group)
5175         (tui_data_window::display_registers_from)
5176         (tui_data_window::display_registers_from)
5177         (tui_data_window::first_data_item_displayed)
5178         (tui_data_window::delete_data_content_windows)
5179         (tui_data_window::rerender, tui_data_window::refresh_window)
5180         (tui_data_window::check_register_values): Update.
5181
5182 2019-08-20  Tom Tromey  <tom@tromey.com>
5183
5184         * tui/tui-regs.h (struct tui_data_window) <show_registers,
5185         show_register_group>: Declare.
5186         (tui_show_register_group): Don't declare.
5187         * tui/tui-regs.c (tui_data_window::show_registers): Rename from
5188         tui_show_registers.
5189         (tui_data_window::show_register_group): Rename from
5190         tui_show_register_group.
5191         (tui_data_window::check_register_values, tui_reg_command):
5192         Update.
5193         * tui/tui-layout.c (tui_set_layout): Update.
5194
5195 2019-08-20  Tom Tromey  <tom@tromey.com>
5196
5197         * tui/tui-regs.h (struct tui_data_window) <check_register_values>:
5198         Declare.
5199         (tui_check_register_values): Don't declare.
5200         * tui/tui-regs.c (tui_data_window::check_register_values): Rename
5201         from tui_check_register_values.
5202         * tui/tui-hooks.c (tui_register_changed): Update.
5203
5204 2019-08-20  Tom Tromey  <tom@tromey.com>
5205
5206         * tui/tui-regs.c (tui_reg_layout): Move later.
5207         (tui_show_registers): Don't enable TUI mode or change layout.
5208
5209 2019-08-20  Tom Tromey  <tom@tromey.com>
5210
5211         * tui/tui-regs.h (struct tui_data_item_window)
5212         <~tui_data_item_window>: Remove.
5213         <content>: Now a unique_xmalloc_ptr.
5214         * tui/tui-regs.c (tui_register_format): Return a
5215         unique_xmalloc_ptr.
5216         (tui_get_register): Update.
5217         (~tui_data_item_window): Remove.
5218         (tui_data_window::display_registers_from, tui_display_register):
5219         Update.
5220         * tui/tui-io.h (tui_expand_tabs): Update.
5221         * tui/tui-io.c (tui_expand_tabs): Return a unique_xmalloc_ptr.
5222         Remove "col" parameter.
5223
5224 2019-08-20  Tom Tromey  <tom@tromey.com>
5225
5226         * tui/tui-regs.h (struct tui_data_item_window) <value>: Remove
5227         field.
5228         * tui/tui-regs.c (~tui_data_item_window): Update.
5229
5230 2019-08-20  Tom Tromey  <tom@tromey.com>
5231
5232         * tui/tui-regs.c (tui_register_format, tui_get_register): Move
5233         earlier.
5234
5235 2019-08-20  Tom Tromey  <tom@tromey.com>
5236
5237         * tui/tui-regs.c (tui_reg_command): Remove NULL check.
5238
5239 2019-08-20  Tom Tromey  <tom@tromey.com>
5240
5241         * tui/tui-source.h (struct tui_source_window): Update.
5242         * tui/tui-regs.c (tui_show_registers): Update.
5243         * tui/tui-disasm.h (struct tui_disasm_window): Update.
5244         * tui/tui-data.h (NO_SRC_STRING, NO_DISASSEM_STRING)
5245         (NO_REGS_STRING): Remove defines.
5246
5247 2019-08-20  Conrad Meyer  <cem@FreeBSD.org>
5248
5249         * remote.c (remote_target::remote_btrace_maybe_reopen): Avoid
5250         unnecessary thread walk if remote doesn't support the packet.
5251
5252 2019-08-19  Tom Tromey  <tromey@adacore.com>
5253
5254         * python/py-value.c (value_has_field): Fix indentation.
5255
5256 2019-08-19  Tom Tromey  <tromey@adacore.com>
5257
5258         * printcmd.c (do_one_display, info_display_command): Update.
5259         * block.h (contained_in): Return bool.  Add allow_nested
5260         parameter.
5261         * block.c (contained_in): Return bool.  Add allow_nested
5262         parameter.
5263
5264 2019-08-19  Tom Tromey  <tom@tromey.com>
5265
5266         * configure: Rebuild.
5267         * configure.ac: Disallow the combination of -static-libstdc++ and
5268         source highlight.
5269         * source-cache.c (get_language_name): Handle rust.
5270         (source_cache::get_source_lines): Ignore highlighting exceptions.
5271
5272 2019-08-16  Tom Tromey  <tom@tromey.com>
5273
5274         * tui/tui.h (enum tui_win_type) <EXEC_INFO_WIN>: Remove.
5275         * tui/tui-winsource.h (struct tui_exec_info_window): Remove.
5276         (struct tui_source_window_base) <make_visible, refresh_window,
5277         resize>: Remove methods.
5278         <execution_info>: Remove field.
5279         * tui/tui-winsource.c (tui_source_window_base::do_erase_source_content)
5280         (tui_show_source_line, tui_source_window_base)
5281         (~tui_source_window_base): Update.
5282         (tui_source_window_base::resize)
5283         (tui_source_window_base::make_visible)
5284         (tui_source_window_base::refresh_window): Remove.
5285         (tui_source_window_base::update_exec_info): Update.
5286         * tui/tui-source.c (tui_source_window::set_contents): Update.
5287         * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
5288
5289 2019-08-16  Tom Tromey  <tom@tromey.com>
5290
5291         * tui/tui-hooks.c (tui_remove_hooks): Don't set
5292         deprecated_query_hook.
5293
5294 2019-08-16  Tom Tromey  <tom@tromey.com>
5295
5296         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
5297         (tui_update_source_windows_with_line): Update.
5298         * tui/tui-source.h (struct tui_source_window)
5299         <show_symtab_source>: Declare.
5300         (tui_show_symtab_source): Don't declare.
5301         * tui/tui-source.c (tui_show_symtab_source): Rename from
5302         tui_show_symtab_source.
5303
5304 2019-08-16  Tom Tromey  <tom@tromey.com>
5305
5306         * tui/tui-winsource.h (struct tui_source_window_base)
5307         <set_contents>: Declare.
5308         * tui/tui-winsource.c
5309         (tui_source_window_base::update_source_window_as_is): Update.
5310         * tui/tui-source.h (struct tui_source_window) <set_contents>:
5311         Declare.
5312         (tui_set_source_content): Don't declare.
5313         * tui/tui-source.c (tui_source_window::set_contents): Rename from
5314         tui_set_source_content.
5315         * tui/tui-disasm.h (struct tui_disasm_window) <set_contents>:
5316         Declare.
5317         (tui_set_disassem_content): Don't declare.
5318         * tui/tui-disasm.c (tui_disasm_window::set_contents): Rename from
5319         tui_set_disassem_content.
5320
5321 2019-08-16  Tom Tromey  <tom@tromey.com>
5322
5323         * tui/tui-winsource.h (struct tui_source_window_base)
5324         <update_breakpoint_info>: Declare.
5325         (tui_update_breakpoint_info): Don't declare.
5326         * tui/tui-winsource.c (tui_source_window_base::update_source_window_as_is)
5327         (tui_update_all_breakpoint_info): Update.
5328         (tui_source_window_base::update_breakpoint_info): Rename from
5329         tui_update_breakpoint_info.
5330         (tui_source_window_base::update_exec_info): Update.
5331
5332 2019-08-16  Tom Tromey  <tom@tromey.com>
5333
5334         * tui/tui-winsource.h (struct tui_source_window_base)
5335         <update_source_window>: Declare.
5336         (tui_update_source_window): Don't declare.
5337         * tui/tui-winsource.c
5338         (tui_source_window_base::update_source_window): Rename from
5339         tui_update_source_window.
5340         (tui_source_window_base::rerender): Update.
5341         * tui/tui-source.c (tui_source_window::maybe_update): Update.
5342         * tui/tui-disasm.c (tui_show_disassem)
5343         (tui_show_disassem_and_update_source)
5344         (tui_disasm_window::maybe_update): Update.
5345
5346 2019-08-16  Tom Tromey  <tom@tromey.com>
5347
5348         * tui/tui-winsource.h (struct tui_source_window_base)
5349         <update_source_window_as_is>: Declare.
5350         (tui_update_source_window_as_is): Don't declare.
5351         * tui/tui-winsource.c (tui_update_source_window): Update
5352         (tui_source_window_base::update_source_window_as_is): Rename from
5353         tui_update_source_window_as_is.
5354         (tui_source_window_base::refill): Update.
5355         * tui/tui-source.c (tui_show_symtab_source): Update.
5356         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical):
5357         Update.
5358
5359 2019-08-16  Tom Tromey  <tom@tromey.com>
5360
5361         * tui/tui-winsource.h (tui_update_source_window)
5362         (tui_update_source_window_as_is): Remove "noerror" parameter.
5363         * tui/tui-winsource.c (tui_update_source_window)
5364         (tui_update_source_window_as_is): Remove "noerror" parameter.
5365         (tui_update_source_windows_with_addr)
5366         (tui_update_source_windows_with_line)
5367         (tui_source_window_base::rerender)
5368         (tui_source_window_base::refill): Update.
5369         * tui/tui-source.h (tui_set_source_content)
5370         (tui_show_symtab_source): Remove "noerror" parameter.
5371         * tui/tui-source.c (tui_set_source_content): Remove "noerror"
5372         parameter.
5373         (tui_show_symtab_source): Likewise.
5374         (tui_source_window::maybe_update): Update.
5375         * tui/tui-disasm.c (tui_show_disassem)
5376         (tui_show_disassem_and_update_source)
5377         (tui_disasm_window::do_scroll_vertical)
5378         (tui_disasm_window::maybe_update): Update.
5379
5380 2019-08-16  Tom Tromey  <tom@tromey.com>
5381
5382         * tui/tui.c (tui_is_window_visible): Update.
5383         * tui/tui-wingeneral.c (tui_make_window)
5384         (tui_gen_win_info::make_visible, tui_refresh_all): Update.
5385         * tui/tui-win.c (window_name_completer, tui_refresh_all_win)
5386         (tui_set_focus_command, tui_all_windows_info, update_tab_width)
5387         (tui_set_win_height_command, parse_scrolling_args): Update.
5388         * tui/tui-source.c (tui_source_window::style_changed): Update.
5389         * tui/tui-regs.c (tui_show_registers)
5390         (tui_data_window::first_data_item_displayed)
5391         (tui_data_window::delete_data_content_windows)
5392         (tui_check_register_values, tui_reg_command): Update.
5393         * tui/tui-disasm.c (tui_show_disassem): Update.
5394         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: New
5395         method.
5396         <is_visible>: Remove field.
5397         * tui/tui-data.c (tui_next_win, tui_prev_win)
5398         (tui_delete_invisible_windows): Update.
5399
5400 2019-08-16  Tom Tromey  <tom@tromey.com>
5401
5402         * tui/tui-winsource.h (struct tui_source_window_base)
5403         <m_has_locator>: Remove.
5404         * tui/tui-layout.c (show_source_disasm_command, show_data)
5405         (show_source_or_disasm_and_command): Update.
5406
5407 2019-08-16  Alan Hayward  <alan.hayward@arm.com>
5408
5409         * NEWS (Other MI changes): New subsection.
5410         * aarch64-tdep.c (aarch64_get_pc_address_flags): New function.
5411         (aarch64_gdbarch_init): Add aarch64_get_pc_address_flags.
5412         * arch-utils.c (default_get_pc_address_flags): New function.
5413         * arch-utils.h (default_get_pc_address_flags): New declaration.
5414         * gdbarch.sh: Add get_pc_address_flags.
5415         * gdbarch.c: Regenerate.
5416         * gdbarch.h: Likewise.
5417         * stack.c (print_pc): New function.
5418         (print_frame_info) (print_frame): Call print_pc.
5419
5420 2019-08-16  Tom de Vries  <tdevries@suse.de>
5421
5422         * maint.c (maintenance_info_sections): Also handle !ALLOBJ case using
5423         print_objfile_section_info.
5424
5425 2019-08-15  Tom Tromey  <tom@tromey.com>
5426
5427         * tui/tui-io.c (tui_puts_internal): Check TUI_CMD_WIN before
5428         calling update_cmdwin_start_line.
5429         * tui/tui-winsource.h (struct tui_source_window_base)
5430         <do_make_visible_with_new_height, set_new_height>: Don't declare.
5431         <rerender>: Declare.
5432         * tui/tui-winsource.c (tui_source_window_base::update_tab_width):
5433         Call rerender.
5434         (tui_source_window_base::set_new_height): Remove.
5435         (tui_source_window_base::rerender): Rename from
5436         do_make_visible_with_new_height.
5437         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Use
5438         resize method.
5439         (tui_win_info::make_invisible_and_set_new_height)
5440         (tui_win_info::make_visible_with_new_height): Remove.
5441         * tui/tui-stack.h (struct tui_locator_window) <rerender>:
5442         Declare.
5443         * tui/tui-stack.c (tui_locator_window::rerender): New method.
5444         * tui/tui-regs.h (struct tui_data_window) <set_new_height,
5445         do_make_visible_with_new_height>: Don't declare.
5446         <rerender>: Declare.
5447         * tui/tui-regs.c (tui_data_window::rerender): Rename from
5448         set_new_height.
5449         (tui_data_window::do_make_visible_with_new_height): Remove.
5450         * tui/tui-layout.c (show_source_disasm_command, show_data): Don't
5451         call tui_show_locator_content.
5452         (tui_gen_win_info::resize): Call rerender.
5453         (show_source_or_disasm_and_command): Don't call
5454         tui_show_locator_content.
5455         * tui/tui-data.h (struct tui_gen_win_info) <rerender>: New
5456         method.
5457         (struct tui_win_info) <rerender>: Declare.
5458         <set_new_height, make_invisible_and_set_new_height,
5459         make_visible_with_new_height>: Don't declare.
5460         * tui/tui-data.c (tui_win_list::rerender): New method.
5461         * tui/tui-command.h (struct tui_cmd_window)
5462         <do_make_visible_with_new_height>: Don't declare.
5463         * tui/tui-command.c
5464         (tui_cmd_window::do_make_visible_with_new_height): Remove.
5465
5466 2019-08-15  Tom Tromey  <tromey@adacore.com>
5467
5468         * ada-exp.y (convert_char_literal): Handle "Q%c" encoding.
5469         * ada-lang.c (ada_enum_name): Likewise.
5470
5471 2019-08-15  Christian Biesinger  <cbiesinger@google.com>
5472
5473         * python/lib/gdb/__init__.py (GdbOutputFile): Rename to have a
5474         leading underscore.
5475         (GdbOutputErrorFile): Likewise.
5476         (global scope): Adjust constructor calls to GdbOutput{,Error}File
5477         accordingly.
5478         (execute_unwinders): Rename to have a leading underscore.
5479         (auto_load_packages): Likewise.
5480         (global scope): Adjust call to auto_load_packages accordingly.
5481         (GdbSetPythonDirectory): Likewise.
5482         * python/py-unwind.c (pyuw_sniffer): Call _execute_unwinders
5483         instead of execute_unwinders.
5484
5485 2019-08-15  Tom Tromey  <tom@tromey.com>
5486
5487         * tui/tui-layout.c (show_layout, show_source_disasm_command)
5488         (show_data): Don't change window visibility.
5489         (tui_gen_win_info::resize): Remove special case for command
5490         window.  Use wresize, when available.
5491         (show_source_or_disasm_and_command): Don't change window
5492         visibility.
5493         * tui/tui-command.h (struct tui_cmd_window) <resize>: Declare.
5494         <make_visible>: New method.
5495         * tui/tui-command.c (tui_cmd_window::resize): New method.
5496
5497 2019-08-15  Tom Tromey  <tom@tromey.com>
5498
5499         * tui/tui-winsource.h (struct tui_source_window_iterator): New.
5500         (struct tui_source_windows): New.
5501         * tui/tui-winsource.c (tui_display_main): Update.
5502         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
5503         (new_height_ok, parse_scrolling_args): Update.
5504         * tui/tui-layout.c (show_layout, show_data): Update.
5505         * tui/tui-data.h (tui_source_windows, tui_clear_source_windows)
5506         (tui_add_to_source_windows): Don't declare.
5507         * tui/tui-data.c (source_windows, tui_source_windows)
5508         (tui_clear_source_windows, tui_add_to_source_windows): Remove.
5509
5510 2019-08-15  Tom Tromey  <tom@tromey.com>
5511
5512         * tui/tui-winsource.h (struct tui_source_window_base) <resize>:
5513         Rename from reset.
5514         * tui/tui-winsource.c (tui_source_window_base::resize): Rename.
5515         * tui/tui-layout.c (show_source_disasm_command, show_data):
5516         Update.
5517         (tui_gen_win_info::resize): Rename.
5518         (show_source_or_disasm_and_command): Update.
5519         * tui/tui-data.h (struct tui_gen_win_info) <resize>: Rename from
5520         reset.
5521
5522 2019-08-15  Tom Tromey  <tom@tromey.com>
5523
5524         * tui/tui-stack.c (tui_initialize_static_data): Remove.
5525         * tui/tui-interp.c (tui_interp::init): Don't call
5526         tui_initialize_static_data.
5527         * tui/tui-data.h (tui_initialize_static_data): Don't declare.
5528
5529 2019-08-15  Tom Tromey  <tom@tromey.com>
5530
5531         * tui/tui-layout.c (tui_default_win_viewport_height): Don't
5532         examine tui_win_list.
5533
5534 2019-08-15  Tom Tromey  <tom@tromey.com>
5535
5536         * tui/tui-winsource.h (tui_clear_source_content): Don't declare.
5537         * tui/tui-winsource.c (tui_update_source_window_as_is): Don't call
5538         tui_clear_source_content.
5539         (tui_clear_source_content): Remove.
5540         (tui_source_window_base::do_erase_source_content): Hoist call to
5541         content.clear().
5542         * tui/tui-stack.c (tui_show_frame_info): Don't call
5543         tui_clear_source_content.
5544
5545 2019-08-15  Tom Tromey  <tom@tromey.com>
5546
5547         * tui/tui-winsource.h (struct tui_source_window_base)
5548         <do_erase_source_content>: New method.
5549         <erase_source_content>: New method.
5550         (tui_erase_source_content): Don't declare.
5551         * tui/tui-winsource.c (tui_clear_source_content): Update.
5552         (tui_source_window_base::do_erase_source_content): Rename from
5553         tui_erase_source_content.
5554         (tui_source_window_base::show_source_content): Update.
5555         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
5556         * tui/tui-source.h (struct tui_source_window)
5557         <erase_source_content>: New method.
5558         * tui/tui-disasm.h (struct tui_disasm_window)
5559         <erase_source_content>: New method.
5560
5561 2019-08-15  Tom Tromey  <tom@tromey.com>
5562
5563         * tui/tui-winsource.h (tui_alloc_source_buffer): Don't declare.
5564         (struct tui_source_element): Add DISABLE_COPY_AND_ASSIGN, and move
5565         constructor.
5566         * tui/tui-winsource.c (tui_alloc_source_buffer): Remove.
5567         * tui/tui-source.c (tui_set_source_content): Update.
5568         * tui/tui-disasm.c (tui_set_disassem_content): Update.
5569
5570 2019-08-15  Tom Tromey  <tom@tromey.com>
5571
5572         * tui/tui-winsource.h (tui_line_is_displayed): Don't declare.
5573         * tui/tui-winsource.c (tui_line_is_displayed): Move to
5574         tui-source.c.
5575         * tui/tui-source.h (struct tui_source_window) <line_is_displayed>:
5576         Declare.
5577         * tui/tui-source.c (tui_source_window::line_is_displayed): New
5578         method.
5579         (tui_source_window::maybe_update): Update.
5580
5581 2019-08-15  Tom Tromey  <tom@tromey.com>
5582
5583         * tui/tui-winsource.h (tui_addr_is_displayed): Don't declare.
5584         * tui/tui-winsource.c (tui_addr_is_displayed): Move to
5585         tui-disasm.c.
5586         * tui/tui-disasm.h (struct tui_disasm_window) <addr_is_displayed>:
5587         Declare.
5588         * tui/tui-disasm.c (tui_disasm_window::addr_is_displayed): New
5589         method.
5590         (tui_disasm_window::maybe_update): Update.
5591
5592 2019-08-15  Tom Tromey  <tom@tromey.com>
5593
5594         * tui/tui-winsource.h (struct tui_source_window_base)
5595         <maybe_update>: Declare.
5596         * tui/tui-stack.c (tui_show_frame_info): Call maybe_update
5597         method.
5598         * tui/tui-source.h (struct tui_source_window) <maybe_update>:
5599         Declare.
5600         * tui/tui-source.c (tui_source_window::maybe_update): New method.
5601         * tui/tui-disasm.h (struct tui_disasm_window) <maybe_update>:
5602         Declare.
5603         * tui/tui-disasm.c (tui_disasm_window::maybe_update): New method.
5604
5605 2019-08-15  Tom Tromey  <tom@tromey.com>
5606
5607         * tui/tui-stack.c (tui_make_status_line): Use string constructor.
5608
5609 2019-08-15  Tom Tromey  <tom@tromey.com>
5610
5611         * tui/tui-wingeneral.c: Include tui-stack.h.
5612         * tui/tui-stack.h (MAX_LOCATOR_ELEMENT_LEN)
5613         (struct tui_locator_window): Move from tui-data.h.
5614         * tui/tui-stack.c (_locator, tui_locator_win_info_ptr)
5615         (tui_initialize_static_data): Move from tui-data.c.
5616         * tui/tui-data.h (MAX_LOCATOR_ELEMENT_LEN)
5617         (struct tui_locator_window): Move to tui-stack.c.
5618         * tui/tui-data.c (_locator, tui_locator_win_info_ptr)
5619         (tui_initialize_static_data): Move to tui-stack.c.
5620
5621 2019-08-15  Tom Tromey  <tom@tromey.com>
5622
5623         * tui/tui-layout.c (show_source_disasm_command)
5624         (show_source_or_disasm_and_command): Use make_visible method, not
5625         tui_make_window.
5626         * tui/tui-command.h (struct tui_cmd_window) <make_visible>:
5627         Remove.
5628
5629 2019-08-15  Tom Tromey  <tom@tromey.com>
5630
5631         * tui/tui-wingeneral.h (tui_make_window): Update.
5632         * tui/tui-wingeneral.c (tui_make_window): Remove "box_it"
5633         parameter.
5634         (tui_gen_win_info::make_visible): Update.
5635         * tui/tui-regs.c (tui_data_window::display_registers_from):
5636         Update.
5637         * tui/tui-layout.c (show_source_disasm_command)
5638         (show_source_or_disasm_and_command): Update.
5639         * tui/tui-data.h (struct tui_gen_win_info) <can_box>: New method.
5640         (enum tui_box): Remove.
5641         (struct tui_win_info) <can_box>: New method.
5642         * tui/tui-command.h (struct tui_cmd_window) <can_box>: New
5643         method.
5644
5645 2019-08-15  Tom de Vries  <tdevries@suse.de>
5646
5647         * linux-nat-trad.c: Include gdbarch.h.
5648
5649 2019-08-14  Alan Hayward  <alan.hayward@arm.com>
5650
5651         * aarch64-tdep.c (aarch64_analyze_prologue): Allow any valid
5652         register sizes.
5653
5654 2019-08-14  Tom Tromey  <tromey@adacore.com>
5655
5656         * darwin-nat.c: Include gdbarch.h.
5657         * darwin-nat-info.c: Include gdbarch.h.
5658
5659 2019-08-13  Tom Tromey  <tom@tromey.com>
5660
5661         * tui/tui-data.h (struct tui_gen_win_info) <last_visible_line>:
5662         Remove.
5663         * tui/tui-data.c (tui_initialize_static_data): Update.
5664
5665 2019-08-13  Tom Tromey  <tom@tromey.com>
5666
5667         * tui/tui-winsource.h (struct tui_exec_info_window)
5668         <~tui_exec_info_window, maybe_allocate_content, get_content,
5669         m_content>: Remove.
5670         (struct tui_source_window_base) <set_exec_info_content,
5671         show_exec_info_content>: Don't declare.
5672         * tui/tui-winsource.c
5673         (tui_exec_info_window::maybe_allocate_content): Remove.
5674         (tui_source_window_base::update_exec_info): Rename from
5675         set_exec_info_content.
5676         (tui_source_window_base::show_exec_info_content)
5677         (tui_source_window_base::update_exec_info): Remove.
5678
5679 2019-08-13  Tom Tromey  <tom@tromey.com>
5680
5681         * tui/tui-winsource.h (tui_clear_exec_info_content): Don't
5682         declare.
5683         * tui/tui-winsource.c (tui_update_source_window_as_is)
5684         (tui_update_source_windows_with_addr, tui_erase_source_content):
5685         Update.
5686         (tui_clear_exec_info_content): Remove.
5687
5688 2019-08-13  Tom Tromey  <tom@tromey.com>
5689
5690         * tui/tui-winsource.h (tui_erase_exec_info_content): Don't
5691         declare.
5692         * tui/tui-winsource.c (tui_source_window_base::refresh_all): Don't
5693         call tui_erase_exec_info_content.
5694         (tui_clear_exec_info_content): Rename from
5695         tui_erase_exec_info_content.
5696         (tui_clear_exec_info_content): Delete.
5697
5698 2019-08-13  Tom Tromey  <tom@tromey.com>
5699
5700         * tui/tui-winsource.h (struct tui_source_window_base)
5701         <show_exec_info_content>: Declare.
5702         (tui_show_exec_info_content): Don't declare.
5703         * tui/tui-winsource.c
5704         (tui_source_window_base::show_exec_info_content): Rename from
5705         tui_show_exec_info_content.
5706         (tui_source_window_base::update_exec_info): Update.
5707
5708 2019-08-13  Tom Tromey  <tom@tromey.com>
5709
5710         * tui/tui-data.h (enum tui_bp_flag, tui_bp_flags, struct tui_source_element)
5711         (TUI_BP_HIT_POS, TUI_BP_BREAK_POS, TUI_EXEC_POS)
5712         (TUI_EXECINFO_SIZE, tui_exec_info_content): Move ...
5713         * tui/tui-winsource.h (enum tui_bp_flag, tui_bp_flags, struct
5714         tui_source_element, TUI_BP_HIT_POS, TUI_BP_BREAK_POS)
5715         (TUI_EXEC_POS, TUI_EXECINFO_SIZE, tui_exec_info_content):
5716         ... here.
5717
5718 2019-08-13  Tom Tromey  <tom@tromey.com>
5719
5720         * tui/tui-winsource.h (struct tui_source_window_base)
5721         <update_exec_info>: Declare.
5722         (tui_update_exec_info): Don't declare.
5723         * tui/tui-winsource.c (tui_update_source_window_as_is)
5724         (tui_source_window_base::refresh_all)
5725         (tui_update_all_breakpoint_info): Update.
5726         (tui_source_window_base::update_exec_info): Rename from
5727         tui_update_exec_info.
5728         * tui/tui-stack.c (tui_show_frame_info): Update.
5729
5730 2019-08-13  Tom Tromey  <tom@tromey.com>
5731
5732         * tui/tui-winsource.h (struct tui_source_window_base)
5733         <set_exec_info_content>: Declare.
5734         (tui_set_exec_info_content): Don't declare.
5735         * tui/tui-winsource.c
5736         (tui_source_window_base::set_exec_info_content): Rename from
5737         tui_set_exec_info_content.
5738         (tui_update_exec_info): Update.
5739
5740 2019-08-13  Tom Tromey  <tom@tromey.com>
5741
5742         * tui/tui-winsource.h (struct tui_source_window_base)
5743         <show_source_content>: Declare.
5744         (tui_show_source_content): Don't declare.
5745         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
5746         (tui_source_window_base::show_source_content): Rename from
5747         tui_show_source_content.
5748         (tui_source_window_base::refresh_all): Update.
5749         * tui/tui-layout.c (show_source_disasm_command)
5750         (show_source_or_disasm_and_command): Update.
5751
5752 2019-08-13  Tom Tromey  <tom@tromey.com>
5753
5754         * tui/tui-winsource.c (tui_erase_source_content)
5755         (tui_show_source_content, tui_source_window_base::refresh_all):
5756         Update.
5757         * tui/tui-wingeneral.h
5758         (tui_check_and_display_highlight_if_needed): Don't declare.
5759         * tui/tui-wingeneral.c
5760         (tui_win_info::check_and_display_highlight_if_needed): Rename from
5761         check_and_display_highlight_if_needed.
5762         * tui/tui-win.c (tui_rehighlight_all)
5763         (tui_win_info::make_visible_with_new_height): Update.
5764         * tui/tui-regs.c (tui_data_window::display_registers_from_line)
5765         (tui_data_window::erase_data_content)
5766         (tui_data_window::display_all_data): Update.
5767         * tui/tui-data.h (struct tui_win_info)
5768         <check_and_display_highlight_if_needed>: Declare.
5769
5770 2019-08-13  Tom Tromey  <tom@tromey.com>
5771
5772         * tui/tui-win.c (tui_resize_all): Call
5773         tui_delete_invisible_windows.
5774         * tui/tui-layout.c (show_layout): Call
5775         tui_delete_invisible_windows.
5776         * tui/tui-data.h (tui_delete_invisible_windows): Declare.
5777         * tui/tui-data.c (tui_delete_invisible_windows): New function.
5778
5779 2019-08-13  Tom Tromey  <tom@tromey.com>
5780
5781         * tui/tui-disasm.c (tui_show_disassem): Add assertion.  Don't call
5782         tui_add_win_to_layout.
5783
5784 2019-08-13  Tom Tromey  <tom@tromey.com>
5785
5786         * tui/tui-layout.h (tui_default_win_height): Don't declare.
5787         * tui/tui-layout.c (tui_default_win_height): Now static.
5788
5789 2019-08-13  Tom Tromey  <tom@tromey.com>
5790
5791         * tui/tui-layout.c (show_layout): Unify all layout cases into a
5792         single switch.
5793         (show_source_disasm_command, show_source_or_disasm_and_command):
5794         Don't check current layout.
5795
5796 2019-08-13  Tom Tromey  <tom@tromey.com>
5797
5798         * tui/tui-wingeneral.c (make_all_visible): Remove.
5799         (tui_make_all_invisible): Simplify.
5800         * tui/tui-layout.c (tui_make_all_invisible): Move from
5801         tui-wingeneral.c; simplify.
5802         (show_layout): Hoist call to tui_make_all_invisible.
5803         (show_data): Don't call tui_make_all_invisible.
5804
5805 2019-08-13  Tom Tromey  <tom@tromey.com>
5806
5807         * tui/tui-wingeneral.h (tui_make_all_visible): Don't declare.
5808         * tui/tui-wingeneral.c (tui_make_all_visible): Remove.
5809
5810 2019-08-13  Tom Tromey  <tom@tromey.com>
5811
5812         * tui/tui-layout.c (current_layout, tui_current_layout): Move from
5813         tui-data.c.
5814         (show_source_disasm_command, show_data)
5815         (show_source_or_disasm_and_command): Don't use
5816         tui_set_current_layout_to.
5817         * tui/tui-data.h (tui_set_current_layout_to): Don't declare.
5818         * tui/tui-data.c (current_layout, tui_current_layout): Move to
5819         tui-layout.c.
5820         (tui_set_current_layout_to): Remove.
5821
5822 2019-08-13  Tom Tromey  <tom@tromey.com>
5823
5824         * tui/tui-layout.c (tui_set_layout): Update.
5825         * tui/tui-data.h (struct tui_layout_def): Remove.
5826         (tui_layout_def): Don't declare.
5827         * tui/tui-data.c (layout_def): Remove.
5828         (tui_layout_def): Remove.
5829
5830 2019-08-13  Tom Tromey  <tom@tromey.com>
5831
5832         * tui/tui-winsource.h (struct tui_source_window_base)
5833         <clear_detail>: No longer "override".
5834         * tui/tui-regs.h (struct tui_data_window) <clear_detail>: Remove.
5835         * tui/tui-regs.c (tui_data_window::clear_detail): Remove.
5836         * tui/tui-data.h (struct tui_win_info) <clear_detail>: Remove.
5837         * tui/tui-command.h (struct tui_cmd_window) <clear_detail>:
5838         Remove.
5839         * tui/tui-command.c (tui_cmd_window::clear_detail): Remove.
5840
5841 2019-08-13  Tom Tromey  <tromey@adacore.com>
5842
5843         * tracepoint.c: Don't include readline.h or history.h.
5844
5845 2019-08-12  Tom Tromey  <tom@tromey.com>
5846
5847         * configure: Rebuild.
5848         * configure.ac: Check for readline 7.
5849         * NEWS: Mention readline 7 requirement.
5850         * README: Update.
5851
5852 2019-08-12  Tom Tromey  <tom@tromey.com>
5853
5854         * mingw-hdep.c (gdb_select): Remove readline hack.
5855
5856 2019-08-09  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
5857
5858         * blockframe.c (find_pc_partial_function): Set *block to nullptr
5859         when the function fails.
5860
5861 2019-08-09  Andreas Arnez  <arnez@linux.ibm.com>
5862
5863         * s390-tdep.c (s390_type_align): New function.
5864         (s390_gdbarch_init): Set it as type_align gdbarch method.
5865
5866 2019-08-09  Tom de Vries  <tdevries@suse.de>
5867
5868         PR gdb/24591
5869         * dwarf2read.c (dwarf2_fetch_die_loc_sect_off): Adjust pc_high and
5870         pc_low with relocation offset.
5871
5872 2019-08-07  Tom Tromey  <tromey@adacore.com>
5873
5874         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
5875         (print_frame_args): Update.
5876         * python/py-framefilter.c (py_print_single_arg, enumerate_args):
5877         Update.
5878         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
5879         * frame.h (struct frame_arg): Add initializers.
5880         <error>: Now a unique_xmalloc_ptr.
5881
5882 2019-08-07  Alan Hayward  <alan.hayward@arm.com>
5883
5884         * NEWS: Expand the Pointer Authentication entry.
5885         * aarch64-tdep.c (aarch64_frame_unmask_address): Rename from this.
5886         (aarch64_frame_unmask_lr): ... to this.
5887         (aarch64_prologue_prev_register, aarch64_dwarf2_prev_register):
5888         Call aarch64_frame_unmask_lr.
5889         * frame.c (struct frame_info): Add "masked" variable.
5890         (frame_set_previous_pc_masked) (frame_get_pc_masked): New functions.
5891         (fprint_frame): Check for masked pc.
5892         * frame.h (frame_set_previous_pc_masked) (frame_get_pc_masked): New
5893         declarations.
5894         * python/py-framefilter.c (py_print_frame): Check for masked pc.
5895         * stack.c (print_frame): Check for masked pc.
5896
5897 2019-08-06  Tom Tromey  <tom@tromey.com>
5898
5899         * stabsread.c (patch_block_stabs, read_one_struct_field)
5900         (read_enum_type): Use obstack_strndup.
5901         * rust-exp.y (rust_parser::copy_name): Use obstack_strndup.
5902         * gdb_obstack.h (obstack_strndup): Use obstack_strndup.
5903         * dwarf2read.c (guess_full_die_structure_name)
5904         (anonymous_struct_prefix): Use obstack_strndup.
5905         * dbxread.c (cp_set_block_scope): Use obstack_strndup.
5906         * c-exp.y (yylex): Use obstack_strndup.
5907         * ada-exp.y (write_object_renaming, write_ambiguous_var)
5908         (write_var_or_type): Use obstack_strndup.
5909
5910 2019-08-06  Tom Tromey  <tom@tromey.com>
5911
5912         * symfile.c (reread_symbols): Use obstack_strdup.
5913         * stabsread.c (read_type): Use obstack_strdup.
5914         * gdb_obstack.h (obstack_strdup): New overload.
5915         * dwarf2read.c (dwarf2_compute_name, create_dwo_unit_in_dwp_v1)
5916         (create_dwo_unit_in_dwp_v2, build_error_marker_type)
5917         (dwarf2_canonicalize_name): Use obstack_strdup.
5918         * dbxread.c (read_dbx_symtab): Use obstack_strdup.
5919         * cp-support.c (inspect_type, replace_typedefs_qualified_name):
5920         Use obstack_strdup.
5921
5922 2019-08-06  Tom Tromey  <tom@tromey.com>
5923
5924         * gdb_obstack.h (obstack_strdup): Define.
5925         * gdb_obstack.c (obstack_strdup): Don't define.
5926
5927 2019-08-06  Tom Tromey  <tom@tromey.com>
5928
5929         * xcoffread.c (SYMNAME_ALLOC, process_xcoff_symbol): Use
5930         obstack_strdup.
5931         * typeprint.c (typedef_hash_table::find_global_typedef): Use
5932         obstack_strdup.
5933         * symfile.c (allocate_compunit_symtab): Use obstack_strdup.
5934         * stabsread.c (common_block_start): Use obstack_strdup.
5935         * objfiles.c (set_objfile_main_name, objfile): Use
5936         obstack_strdup.
5937         * namespace.c (add_using_directive): Use obstack_strdup.
5938         * mdebugread.c (parse_symbol, parse_type): Use obstack_strdup.
5939         * jit.c (finalize_symtab): Use obstack_strdup.
5940         * dwarf2read.c (fixup_go_packaging, dwarf2_physname)
5941         (guess_partial_die_structure_name, partial_die_info::fixup)
5942         (dwarf2_name): Use obstack_strdup.
5943         * coffread.c (coff_read_struct_type, coff_read_enum_type): Use
5944         obstack_strdup.
5945         * c-exp.y (scan_macro_expansion): Use obstack_strdup.
5946         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
5947         obstack_strdup.
5948         * ada-lang.c (ada_decode_symbol): Use obstack_strdup.
5949
5950 2019-08-07  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5951
5952         * unittests/help-doc-selftests.c: New file.
5953         * Makefile.in: Add the new file.
5954
5955 2019-08-07  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5956
5957         * cli/cli-decode.h (print_doc_line): Add for_value_prefix argument.
5958         * cli/cli-decode.c (print_doc_line): Likewise.  It now prints
5959         the full first line, except when FOR_VALUE_PREFIX.  In this case,
5960         the trailing '.' is not output, and the first character is uppercased.
5961         (print_help_for_command): Update call to print_doc_line.
5962         (print_doc_of_command): Likewise.
5963         * cli/cli-setshow.c (deprecated_show_value_hack): Likewise.
5964         * cli/cli-option.c (append_indented_doc): Do not append newline.
5965         (build_help_option): Append newline after first appended_indented_doc
5966         only if a second call is done.
5967         (build_help): Append 2 new lines before each option, except the first
5968         one.
5969         * compile/compile.c (_initialize_compile): Add new lines after
5970         %OPTIONS%, when not at the end of the help.
5971         Change help doc or code
5972         producing the help doc to respect the invariants.
5973         * maint-test-options.c (_initialize_maint_test_options): Likewise.
5974         Also removed the new line after 'Options:', as all other commands
5975         do not put an empty line between 'Options:' and the first option.
5976         * printcmd.c (_initialize_printcmd): Likewise.
5977         * stack.c (_initialize_stack): Likewise.
5978         * interps.c (interpreter_exec_cmd): Fix "Usage:" line that was
5979         incorrectly telling COMMAND is optional.
5980         * ada-lang.c (_initialize_ada_language): Change help doc or code
5981         producing the help doc to respect the invariants.
5982         * ada-tasks.c (_initialize_ada_tasks): Likewise.
5983         * breakpoint.c (_initialize_breakpoint): Likewise.
5984         * cli/cli-cmds.c (_initialize_cli_cmds): Likewise.
5985         * cli/cli-logging.c (_initialize_cli_logging): Likewise.
5986         * cli/cli-setshow.c (_initialize_cli_setshow): Likewise.
5987         * cli/cli-style.c (cli_style_option::add_setshow_commands,
5988         _initialize_cli_style): Likewise.
5989         * corelow.c (core_target_info): Likewise.
5990         * dwarf-index-cache.c (_initialize_index_cache): Likewise.
5991         * dwarf2read.c (_initialize_dwarf2_read): Likewise.
5992         * filesystem.c (_initialize_filesystem): Likewise.
5993         * frame.c (_initialize_frame): Likewise.
5994         * gnu-nat.c (add_task_commands): Likewise.
5995         * infcall.c (_initialize_infcall): Likewise.
5996         * infcmd.c (_initialize_infcmd): Likewise.
5997         * interps.c (_initialize_interpreter): Likewise.
5998         * language.c (_initialize_language): Likewise.
5999         * linux-fork.c (_initialize_linux_fork): Likewise.
6000         * maint-test-settings.c (_initialize_maint_test_settings): Likewise.
6001         * maint.c (_initialize_maint_cmds): Likewise.
6002         * memattr.c (_initialize_mem): Likewise.
6003         * printcmd.c (_initialize_printcmd): Likewise.
6004         * python/lib/gdb/function/strfns.py (_MemEq, _StrLen, _StrEq,
6005         _RegEx): Likewise.
6006         * ravenscar-thread.c (_initialize_ravenscar): Likewise.
6007         * record-btrace.c (_initialize_record_btrace): Likewise.
6008         * record-full.c (_initialize_record_full): Likewise.
6009         * record.c (_initialize_record): Likewise.
6010         * regcache-dump.c (_initialize_regcache_dump): Likewise.
6011         * regcache.c (_initialize_regcache): Likewise.
6012         * remote.c (add_packet_config_cmd, init_remote_threadtests,
6013         _initialize_remote): Likewise.
6014         * ser-tcp.c (_initialize_ser_tcp): Likewise.
6015         * serial.c (_initialize_serial): Likewise.
6016         * skip.c (_initialize_step_skip): Likewise.
6017         * source.c (_initialize_source): Likewise.
6018         * stack.c (_initialize_stack): Likewise.
6019         * symfile.c (_initialize_symfile): Likewise.
6020         * symtab.c (_initialize_symtab): Likewise.
6021         * target-descriptions.c (_initialize_target_descriptions): Likewise.
6022         * top.c (init_main): Likewise.
6023         * tracefile-tfile.c (tfile_target_info): Likewise.
6024         * tracepoint.c (_initialize_tracepoint): Likewise.
6025         * tui/tui-win.c (_initialize_tui_win): Likewise.
6026         * utils.c (add_internal_problem_command): Likewise.
6027         * valprint.c (value_print_option_defs): Likewise.
6028
6029 2019-08-06  Frank Ch. Eigler  <fche@redhat.com>
6030
6031         PR build/24886
6032         * configure.ac: Drop enable-libmcheck support.
6033         * configure, config.in: Rebuild.
6034         * libmcheck.m4: Remove.
6035         * acinclude.m4: Don't include it.
6036         * Makefile.in: Don't distribute it.
6037         * top.c (print_gdb_configuration): Don't mention it.
6038
6039 2019-08-06  Tom Tromey  <tom@tromey.com>
6040
6041         * utils.c (set_output_style): Sometimes pass stream to
6042         emit_style_escape.
6043         * ui-out.h (class ui_out) <can_emit_style_escape>: Declare.
6044         * record-btrace.c (btrace_insn_history): Update.
6045         * mi/mi-out.h (class mi_ui_out) <can_emit_style_escape>: New
6046         method.
6047         * disasm.h (gdb_pretty_print_disassembler): Add uiout parameter.
6048         Update initializers.
6049         <m_uiout>: New field.
6050         <m_di>: Move lower.
6051         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
6052         Remove "uiout" parameter.
6053         (dump_insns): Update.
6054         * cli-out.h (class cli_ui_out) <can_emit_style_escape>: Declare.
6055         * cli-out.c (cli_ui_out::can_emit_style_escape): New method.
6056
6057 2019-08-06  Christian Biesinger  <cbiesinger@google.com>
6058
6059         * symtab.c (symbol_cache_lookup): Change int to enum block_enum.
6060         (error_in_psymtab_expansion): Likewise.
6061         (lookup_symbol_via_quick_fns): Likewise.
6062         (basic_lookup_transparent_type_quick): Likewise.
6063         (basic_lookup_transparent_type_1): Likewise.
6064
6065 2019-08-06  Tom Tromey  <tromey@adacore.com>
6066
6067         * source.c (last_source_error): Now bool.
6068         (print_source_lines_base): Make "noprint" bool.  Only open
6069         source file when last_source_visited changes.
6070
6071 2019-08-06  Tom Tromey  <tromey@adacore.com>
6072
6073         * annotate.c (annotate_source_line): Use g_source_cache.
6074         * source-cache.c (source_cache::get_plain_source_lines): Change
6075         parameters.  Populate m_offset_cache.
6076         (source_cache::ensure): New method.
6077         (source_cache::get_line_charpos): New method.
6078         (extract_lines): Move lower.  Change parameters.
6079         (source_cache::get_source_lines): Move lower.
6080         * source-cache.h (class source_cache): Update comment.
6081         <get_line_charpos>: New method.
6082         <get_source_lines>: Update comment.
6083         <clear>: Clear m_offset_cache.
6084         <get_plain_source_lines>: Change parameters.
6085         <ensure>: New method
6086         <m_offset_cache>: New member.
6087         * source.c (forget_cached_source_info_for_objfile): Update.
6088         (info_source_command): Use g_source_cache.
6089         (find_source_lines, open_source_file_with_line_charpos): Remove.
6090         (print_source_lines_base, search_command_helper): Use g_source_cache.
6091         * source.h (open_source_file_with_line_charpos): Don't declare.
6092         * symtab.h (struct symtab) <nlines, line_charpos>: Remove.
6093         * tui/tui-source.c (tui_source_window::do_scroll_vertical):
6094         Use g_source_cache.
6095
6096 2019-08-06  Tom Tromey  <tromey@adacore.com>
6097
6098         * source-cache.c (source_cache::get_plain_source_lines):
6099         Remove "first_line" and "last_line" parameters.
6100         (source_cache::get_source_lines): Cache plain text.
6101         * source-cache.h (class source_cache)
6102         <get_plain_source_lines>: Update.
6103
6104 2019-08-06  Tom Tromey  <tromey@adacore.com>
6105
6106         * source-cache.c (extract_lines): No longer a method.
6107         Changed type of parameter.  Include final newline.
6108         (selftests::extract_lines_test): New function.
6109         (_initialize_source_cache): Likewise.
6110         * source-cache.h (class source_cache)
6111         <extract_lines>: Don't declare.
6112
6113 2019-08-06  Tom Tromey  <tromey@adacore.com>
6114
6115         * breakpoint.c (init_breakpoint_sal): Update.
6116         (breakpoint): Update.
6117         * breakpoint.h (struct breakpoint) <filter>: Now a
6118         unique_xmalloc_ptr.
6119
6120 2019-08-05  Christian Biesinger  <cbiesinger@google.com>
6121
6122         * NEWS: Mention dictionary access on blocks.
6123         * python/py-block.c (blpy_getitem): New function.
6124         (block_object_as_mapping): New struct.
6125         (block_object_type): Use new struct for tp_as_mapping field.
6126
6127 2019-08-05  Christian Biesinger  <cbiesinger@google.com>
6128
6129         * objfiles.h (objfile): Add a comment describing partial symbols.
6130
6131 2019-08-05  Tom Tromey  <tromey@adacore.com>
6132
6133         * compile/compile.c (_initialize_compile): Use _(), not N_().
6134         * thread.c (_initialize_thread): Use _(), not N_().
6135         * stack.c (_initialize_stack): Use _(), not N_().
6136         * printcmd.c (_initialize_printcmd): Use _(), not N_().
6137
6138 2019-08-04  Simon Marchi  <simon.marchi@polymtl.ca>
6139
6140         * dwarf2read.c (struct dw2_symtab_iterator):
6141         <want_specific_block>: Remove.
6142         <block_index>: Change type to gdb::optional.
6143         (dw2_symtab_iter_init): Remove WANT_SPECIFIC_BLOCK parameter,
6144         change type of BLOCK_INDEX parameter to gdb::optional.
6145         (dw2_symtab_iter_next): Re-write in function of gdb::optional.
6146         (dw2_lookup_symbol): Don't pass argument for
6147         WANT_SPECIFIC_BLOCK.
6148         (dw2_expand_symtabs_for_function): Don't pass argument for
6149         WANT_SPECIFIC_BLOCK, pass empty optional for BLOCK_INDEX.
6150         (class dw2_debug_names_iterator)
6151         <dw2_debug_names_iterator>: Remove WANT_SPECIFIC_BLOCK
6152         parameter, change BLOCK_INDEX type to gdb::optional.
6153         <m_want_specific_block>: Remove.
6154         <m_block_index>: Change type to gdb::optional.
6155         (dw2_debug_names_iterator::next): Change type of IS_STATIC to
6156         gdb::optional.  Re-write in function of gdb::optional.
6157         (dw2_debug_names_lookup_symbol): Don't pass argument for
6158         WANT_SPECIFIC_BLOCK.
6159         (dw2_debug_names_expand_symtabs_for_function): Don't pass
6160         argument for WANT_SPECIFIC_BLOCK, pass empty optional for
6161         BLOCK_INDEX.
6162
6163 2019-08-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6164
6165         * NEWS: Mention changes to "info sources" command.
6166
6167 2019-08-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6168
6169         * symtab.c (filename_partial_match_opts): New struct type.
6170         (struct output_source_filename_data): New members
6171         regexp, c_regexp, partial_match.
6172         (output_source_filename): Use new members to decide to print file.
6173         (info_sources_option_defs): New variable.
6174         (make_info_sources_options_def_group, print_info_sources_header,
6175         info_sources_command_completer):
6176         New functions.
6177         (info_sources_command): Read new optional arguments.
6178         (_initialize_symtab): Update info sources help.
6179
6180 2019-08-02  Alexandre Oliva <oliva@adacore.com>
6181
6182         * ada-lang.c (exception_support_info_v0): Renamed from...
6183         (default_exception_support_info): ... this.  Create new
6184         definition for v1.
6185         (ada_has_this_exception_support): Look up catch_handlers_sym.
6186         (ada_exception_support_info_sniffer): Try v0 after default.
6187
6188 2019-08-01  Tom Tromey  <tromey@adacore.com>
6189
6190         * ia64-libunwind-tdep.h (struct libunwind_descr): Include
6191         gdbarch.h.
6192
6193 2019-08-01  Christian Biesinger  <cbiesinger@google.com>
6194
6195         * s12z-tdep.c: Fix include path for s12z-opc.h.
6196
6197 2019-08-01  Alan Hayward  <alan.hayward@arm.com>
6198
6199         * NEWS: Require GNU make 3.82.
6200
6201 2019-07-16  Tom Tromey  <tom@tromey.com>
6202
6203         * tui/tui-wingeneral.h (tui_copy_win, tui_box_win): Don't
6204         declare.
6205
6206 2019-07-30  Tom Tromey  <tromey@adacore.com>
6207
6208         * block.c (contained_in): Remove BLOCK_FUNCTION check.
6209
6210 2019-07-30  Kevin Buettner  <kevinb@redhat.com>
6211
6212         * printcmd.c (print_address_symbolic): Print negative offsets.
6213         (build_address_symbolic): Force signed arithmetic when computing
6214         offset.
6215
6216 2019-07-30  Christian Biesinger  <cbiesinger@google.com>
6217
6218         PR/24474: Add a function to lookup static variables.
6219         * NEWS: Mention this new function.
6220         * python/py-symbol.c (gdbpy_lookup_static_symbol): New function.
6221         * python/python-internal.h (gdbpy_lookup_static_symbol): New function.
6222         * python/python.c (python_GdbMethods): Add new function.
6223
6224 2019-07-29  Christian Biesinger  <cbiesinger@google.com>
6225
6226         * NEWS: Mention new functions Objfile.lookup_{global,static}_symbol.
6227         * python/py-objfile.c (objfpy_lookup_global_symbol): New function.
6228         (objfpy_lookup_static_symbol): New function.
6229         (objfile_object_methods): Add new functions.
6230
6231 2019-07-29  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6232
6233         * NEWS: Mention 'set|show print frame-info'.  Mention new
6234         'presence' value for 'frame-arguments'.  Mention new '-frame-info'
6235         backtrace argument.  Mention that python frame filtering code
6236         is now consistent with what 'backtrace' command prints.
6237
6238 2019-07-29  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6239
6240         * frame.h (enum print_what): New value 'SHORT_LOCATION', update
6241         comments.
6242         (print_frame_info_auto, print_frame_info_source_line,
6243         print_frame_info_location, print_frame_info_source_and_location,
6244         print_frame_info_location_and_address, print_frame_info_short_location):
6245         New declarations.
6246         (struct frame_print_options): New member print_frame_info.
6247         * extension.h (enum ext_lang_frame_args): New value CLI_PRESENCE.
6248         * stack.h (get_user_print_what_frame_info): New declaration.
6249         (frame_show_address): New declaration.
6250         * stack.c (print_frame_arguments_choices): New value 'presence'.
6251         (print_frame_info_auto, print_frame_info_source_line,
6252         print_frame_info_location, print_frame_info_source_and_location,
6253         print_frame_info_location_and_address, print_frame_info_short_location,
6254         print_frame_info_choices, print_frame_info_print_what): New definitions.
6255         (print_frame_args): Only print dots for args if print frame-arguments
6256         is 'presence'.
6257         (frame_print_option_defs): New element for "frame-info".
6258         (get_user_print_what_frame_info): New function.
6259         (frame_show_address): Make non static.  Move comment to stack.h.
6260         (print_frame_info_to_print_what): New function.
6261         (print_frame_info): Update comment.  Use fp_opts.print_frame_info
6262         to decide what to print.
6263         (backtrace_command_1): Handle the new print_frame_arguments_presence
6264         value.
6265         (_initialize_stack): Call add_setshow_enum_cmd for frame-info.
6266         * python/py-framefilter.c (py_print_args): Handle CLI_PRESENCE.
6267         (py_print_frame): In non-mi mode, use LOCATION as default for
6268         print_what, similarly to frame information printed directly by
6269         backtrace command. Handle frame-info user option in non MI mode.
6270
6271 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
6272
6273         * linux-thread-db.c (thread_db_target::thread_handle_to_thread_info):
6274         Add case for debugging 32-bit target on 64-bit host.  Revise
6275         comment.
6276
6277 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
6278
6279         * infrun.c (fill_in_stop_func): Use find_pc_partial_function
6280         instead of find_function_entry_range_from_pc.
6281
6282 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
6283
6284         * stack.c (find_frame_funname): Remove code which preferred
6285         minsym over symtab sym in "certain pathological cases".
6286
6287         * valprint.h (build_address_symbolic): Add "prefer_sym_over_minsym"
6288         parameter.  Change type of "do_demangle" to bool.
6289         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
6290         Pass suitable "prefer_sym_over_minsym" flag to
6291         build_address_symbolic().  Don't output "+" for negative offsets.
6292         * printcmd.c (print_address_symbolic): Update invocation of
6293         build_address_symbolic to include a "prefer_sym_over_minsym"
6294         flag.
6295         (build_address_symbolic): Add "prefer_sym_over_minsym" parameter.
6296         Restrict cases in which use of minimal symbol is preferred to that
6297         of a found symbol.  Update comments.
6298
6299         * dwarf2-frame.c (dwarf2_frame_cache): Don't decode FDE instructions
6300         for entry pc when entry pc is out of range for that FDE.
6301
6302 2019-07-26  Brian Callahan  <bcallah@openbsd.org>
6303
6304         PR gdb/24839:
6305         * gdb/obsd-nat.c (obsd_nat_target::pid_to_str): Fix typo in return
6306         type.
6307
6308 2019-07-25  Christian Biesinger  <cbiesinger@google.com>
6309
6310         * python/py-objfile.c (add_separate_debug_file): Fix comment about
6311         this function's Python signature.
6312
6313
6314 2019-07-24  Christian Biesinger  <cbiesinger@google.com>
6315
6316         * compile/compile-object-load.c (compile_object_load): Pass GLOBAL_SCOPE.
6317         * solib-spu.c (spu_lookup_lib_symbol): Pass GLOBAL_SCOPE.
6318         * solib-svr4.c (elf_lookup_lib_symbol): Pass GLOBAL_SCOPE.
6319         * symtab.c (lookup_global_symbol_from_objfile): Add a scope parameter.
6320         * symtab.h (lookup_global_symbol_from_objfile): Likewise.
6321
6322
6323 2019-07-24  Yoshinori Sato  <ysato@users.sourceforge.jp>
6324
6325         * h8300-tdep.c (h8300_register_name_common): New.
6326         h8300_register_name): Use h8300_register_name_common.
6327         (h8300s_register_name): Likewise.
6328         (h8300sx_register_name): Likewise.
6329         (h8300h_register_nam): New.
6330         (h8300_gdbarch_init): Use h8300h_register_name in h8300h machine.
6331
6332
6333 2019-07-23  Srinath Parvathaneni  <srinath.parvathaneni@arm.com>
6334
6335         * arm-tdep.c (arm_skip_cmse_entry): New function.
6336         (arm_is_sgstubs_section): New function.
6337         (arm_skip_stub): Add call to arm_skip_cmse_entry function.
6338
6339 2019-07-22  Tom Tromey  <tom@tromey.com>
6340
6341         * tui/tui-win.c (tui_win_info::make_invisible_and_set_new_height):
6342         Don't self-assign.
6343
6344 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
6345
6346         * c-typeprint.c (c_print_typedef): Pass -1 instead of 0 to
6347         type_print.
6348
6349 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
6350
6351         * symtab.c (search_symbols): Adjust msymbol matching type arrays
6352         so that GDB doesn't match any msymbols when searching in the
6353         TYPES_DOMAIN.
6354         (print_symbol_info): Print using typedef_print or type_print based
6355         on the type of the symbol.  Add updated FIXME comment moved from...
6356         (_initialize_symtab): ... move and update FIXME comment to above.
6357
6358 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
6359
6360         * NEWS: Mention adding -q option to "info types".
6361         * symtab.c (struct info_types_options): New struct.
6362         (info_types_options_defs): New variable.
6363         (make_info_types_options_def_group): New function.
6364         (info_types_command): Use gdb::option framework to parse options.
6365         (info_types_command_completer): New function.
6366         (_initialize_symtab): Extend the help text on "info types" and
6367         register command completer.
6368
6369 2019-07-21  Christian Biesinger  <cbiesinger@google.com>
6370
6371         * symtab.c (lookup_symbol_in_objfile_symtabs): Change int to block_enum.
6372         (lookup_symbol_in_objfile): Change int to block_enum and add a
6373         gdb_assert to make sure block_index is GLOBAL_BLOCK or STATIC_BLOCK.
6374
6375 2019-07-20  Christian Biesinger  <cbiesinger@google.com>
6376
6377         * MAINTAINERS (Write After Approval): Add self.
6378
6379 2019-07-19  Andrew Burgess  <andrew.burgess@embecosm.com>
6380
6381         * riscv-tdep.c (riscv_push_dummy_code): Write a 4-byte nop
6382         instruction to the dummy code region.
6383
6384 2019-07-19  Tom Tromey  <tromey@adacore.com>
6385
6386         * contrib/ari/gdb_ari.sh: Mention C++11, not ISO C 90.
6387         (ARGSUSED, PARAMS, __func__): Remove rules.
6388
6389 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
6390
6391         * arm-tdep.c (_initialize_arm_tdep): Remove xml tests.
6392         * features/arm/arm-with-iwmmxt.c: Remove.
6393         * features/arm/arm-with-iwmmxt.xml: Remove.
6394         * features/arm/arm-with-m-fpa-layout.c: Remove.
6395         * features/arm/arm-with-m-fpa-layout.xml: Remove.
6396         * features/arm/arm-with-m-vfp-d16.c: Remove.
6397         * features/arm/arm-with-m-vfp-d16.xml: Remove.
6398         * features/arm/arm-with-m.c: Remove.
6399         * features/arm/arm-with-m.xml: Remove.
6400         * features/arm/arm-with-neon.c: Remove.
6401         * features/arm/arm-with-neon.xml: Remove.
6402         * features/arm/arm-with-vfpv2.c: Remove.
6403         * features/arm/arm-with-vfpv2.xml: Remove.
6404         * features/arm/arm-with-vfpv3.c: Remove.
6405         * features/arm/arm-with-vfpv3.xml: Remove.
6406
6407 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
6408
6409         * arm-tdep.c (_initialize_arm_tdep): Add xml regression tests.
6410
6411 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
6412
6413         * arch/aarch32.c (aarch32_create_target_description): Create
6414         target descriptions using features.
6415         * arch/arm.c (arm_create_target_description)
6416         (arm_create_mprofile_target_description): Likewise.
6417         * arm-tdep.c (_initialize_arm_tdep): Remove tdesc init calls.
6418
6419 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
6420
6421         * Makefile.in: Add new files.
6422         * aarch32-tdep.c: New file.
6423         * aarch32-tdep.h: New file.
6424         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
6425         Call aarch32_read_description.
6426         * arch/aarch32.c: New file.
6427         * arch/aarch32.h: New file.
6428         * arch/arm.c (arm_create_target_description)
6429         (arm_create_mprofile_target_description): New function.
6430         * arch/arm.h (arm_fp_type, arm_m_profile_type): New enum.
6431         (arm_create_target_description)
6432         (arm_create_mprofile_target_description): New declaration.
6433         * arm-fbsd-tdep.c (arm_fbsd_read_description_auxv): Call
6434         read_description functions.
6435         * arm-linux-nat.c (arm_linux_nat_target::read_description):
6436         Likewise.
6437         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
6438         * arm-tdep.c (tdesc_arm_list): New variable.
6439         (arm_register_g_packet_guesses): Call create description functions.
6440         (arm_read_description) (arm_read_mprofile_description): New
6441         function.
6442         * arm-tdep.h (arm_read_description)
6443         (arm_read_mprofile_description): Add declaration.
6444         * configure.tgt: Add new files.
6445
6446 2019-07-18  Guillaume LABARTHE  <guillaume.labarthe@gmail.com>
6447
6448         * top.c (new_ui_command): Open specified terminal just once.
6449
6450 2019-07-18  Tom Tromey  <tromey@adacore.com>
6451
6452         * symtab.c (main_name): Constify return type.
6453         * symfile.c (set_initial_language): Update.
6454         * symtab.h (main_name): Constify return type.
6455
6456 2019-07-17  Tom Tromey  <tom@tromey.com>
6457
6458         * tui/tui-winsource.c (tui_update_source_window)
6459         (tui_update_source_window_as_is)
6460         (tui_update_source_windows_with_line): Remove return.
6461         * tui/tui-disasm.c (tui_show_disassem)
6462         (tui_show_disassem_and_update_source): Remove return.
6463         * tui/tui.c (tui_reset): Remove return.
6464         * tui/tui-wingeneral.c
6465         (tui_check_and_display_highlight_if_needed): Remove return.
6466
6467 2019-07-17  Tom Tromey  <tom@tromey.com>
6468
6469         * tui/tui-win.c (parse_scrolling_args): Throw separate errors.
6470
6471 2019-07-17  Tom Tromey  <tom@tromey.com>
6472
6473         * tui/tui-winsource.h (struct tui_exec_info_window)
6474         (struct tui_source_window_base): Move from tui-data.h.
6475         * tui/tui-winsource.c: Move many method definitions from
6476         elsewhere.  Remove "structuring" comments.
6477         * tui/tui-wingeneral.c (tui_source_window_base::make_visible)
6478         (tui_source_window_base::refresh_window): Move to
6479         tui-winsource.c.
6480         * tui/tui-win.c (tui_source_window_base::refresh_all)
6481         (tui_source_window_base::update_tab_width)
6482         (tui_source_window_base::set_new_height)
6483         (tui_source_window_base::do_make_visible_with_new_height): Move to
6484         tui-winsource.c.
6485         * tui/tui-source.h: Update.
6486         * tui/tui-source.c (tui_source_window_base::reset): Move to
6487         tui-winsource.c.
6488         * tui/tui-disasm.h: Update.
6489         * tui/tui-data.h (struct tui_exec_info_window): Move to
6490         tui-winsource.h.
6491         (struct tui_source_window_base): Likewise.
6492         * tui/tui-data.c (tui_source_window_base::clear_detail)
6493         (tui_source_window_base, ~tui_source_window_base): Move to
6494         tui-winsource.c.
6495
6496 2019-07-17  Tom Tromey  <tom@tromey.com>
6497
6498         * tui/tui-win.c (tui_resize_all)
6499         (tui_source_window_base::update_tab_width)
6500         (tui_adjust_win_heights): Update.
6501         (tui_win_info::make_invisible_and_set_new_height): Rename from
6502         make_invisible_and_set_new_height.
6503         * tui/tui-data.h (struct tui_win_info)
6504         <make_invisible_and_set_new_height>: New method.
6505
6506 2019-07-17  Tom Tromey  <tom@tromey.com>
6507
6508         * tui/tui.c: Update.
6509         * tui/tui-source.h (struct tui_source_window): Move from
6510         tui-data.h.
6511         * tui/tui-layout.c: Update.
6512         * tui/tui-disasm.c: Update.
6513         * tui/tui-data.h (struct tui_source_window): Move to
6514         tui-source.h.
6515
6516 2019-07-17  Tom Tromey  <tom@tromey.com>
6517
6518         * tui/tui-disasm.h (struct tui_disasm_window): Move from
6519         tui-data.h.
6520         * tui/tui-data.h (struct tui_disasm_window): Move to
6521         tui-disasm.h.
6522
6523 2019-07-17  Tom Tromey  <tom@tromey.com>
6524
6525         * tui/tui-regs.h (struct tui_data_item_window): Move from
6526         tui-data.h.
6527         * tui/tui-regs.c (tui_data_item_window): Move from tui-data.c.
6528         * tui/tui-data.h (struct tui_data_item_window): Move to
6529         tui-regs.h.
6530         * tui/tui-data.c (~tui_data_item_window): Move to tui-regs.c.
6531
6532 2019-07-17  Tom Tromey  <tom@tromey.com>
6533
6534         * tui/tui.c: Update.
6535         * tui/tui-win.c (tui_cmd_window::do_make_visible_with_new_height)
6536         (tui_cmd_window::max_height): Move to tui-command.c.
6537         * tui/tui-layout.c: Update.
6538         * tui/tui-data.h (struct tui_cmd_window): Move to tui-command.h.
6539         * tui/tui-data.c (tui_cmd_window::clear_detail): Move to
6540         tui-command.c.
6541         * tui/tui-command.h (struct tui_cmd_window): Move from
6542         tui-data.h.
6543         * tui/tui-command.c: Remove "structuring" comments.
6544         (tui_cmd_window::clear_detail)
6545         (tui_cmd_window::do_make_visible_with_new_height)
6546         (tui_cmd_window::max_height): Move from elsewhere.
6547
6548 2019-07-17  Tom Tromey  <tom@tromey.com>
6549
6550         * tui/tui-io.c (tui_dispatch_ctrl_char): Move from tui-command.c.
6551         Now static.
6552         * tui/tui-command.h (tui_dispatch_ctrl_char): Don't declare.
6553         * tui/tui-command.c (tui_dispatch_ctrl_char): Move to tui-io.c.
6554
6555 2019-07-17  Tom Tromey  <tom@tromey.com>
6556
6557         * tui/tui.c: Update.
6558         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Move to
6559         tui-regs.c.
6560         * tui/tui-windata.h: Remove file.
6561         * tui/tui-windata.c: Remove file.
6562         * tui/tui-win.c (tui_data_window::set_new_height)
6563         (tui_data_window::do_make_visible_with_new_height): Move to
6564         tui-regs.c.
6565         * tui/tui-regs.h (struct tui_data_window): Move from tui-data.h.
6566         * tui/tui-regs.c: Remove "structuring" comments.
6567         (tui_data_window::first_data_item_displayed)
6568         (tui_data_window::delete_data_content_windows)
6569         (tui_data_window::erase_data_content)
6570         (tui_data_window::display_all_data)
6571         (tui_data_window::refresh_all)
6572         (tui_data_window::do_scroll_vertical)
6573         (tui_data_window::clear_detail, tui_data_window::set_new_height)
6574         (tui_data_window::do_make_visible_with_new_height)
6575         (tui_data_window::refresh_window): Move from elsewhere.
6576         (_initialize_tui_regs): Move to end of file.
6577         * tui/tui-layout.c: Update.
6578         * tui/tui-hooks.c: Update.
6579         * tui/tui-data.h (struct tui_data_window): Move to tui-regs.h.
6580         * tui/tui-data.c (tui_data_window::clear_detail): Move to
6581         tui-regs.c.
6582         * Makefile.in (SUBDIR_TUI_SRCS): Remove tui-windata.c.
6583
6584 2019-07-17  Tom Tromey  <tom@tromey.com>
6585
6586         * tui/tui-io.c (tui_puts_internal): Call wrefresh if newline is
6587         seen.
6588
6589 2019-07-17  Tom Tromey  <tom@tromey.com>
6590
6591         * tui/tui-win.c (tui_source_window_base::set_new_height)
6592         (tui_source_window_base::do_make_visible_with_new_height): Use
6593         m_has_locator field directly.
6594         * tui/tui-data.h (struct tui_win_info) <has_locator>: Remove
6595         method.
6596         (struct tui_source_window_base) <has_locator>: Likewise.
6597
6598 2019-07-17  Tom Tromey  <tom@tromey.com>
6599
6600         * tui/tui-wingeneral.h (tui_make_visible, tui_make_invisible):
6601         Don't declare.
6602         * tui/tui-wingeneral.c (tui_make_visible, tui_make_invisible):
6603         Remove.
6604         * tui/tui-win.c (tui_source_window_base::set_new_height)
6605         (tui_source_window_base::set_new_height)
6606         (make_invisible_and_set_new_height)
6607         (tui_source_window_base::do_make_visible_with_new_height)
6608         (tui_source_window_base::do_make_visible_with_new_height):
6609         Update.
6610         * tui/tui-layout.c (show_source_disasm_command, show_data)
6611         (show_source_or_disasm_and_command): Update.
6612         * tui/tui-layout.c (show_layout): Update.
6613
6614 2019-07-17  Tom Tromey  <tom@tromey.com>
6615
6616         * tui/tui-layout.c (make_data_window): Remove.
6617         (show_data): Unify creation and re-initialization cases.
6618
6619 2019-07-17  Tom Tromey  <tom@tromey.com>
6620
6621         * tui/tui-layout.c (make_source_window, make_disasm_window):
6622         Remove.
6623         (show_data): Unify creation and re-initialization cases.
6624
6625 2019-07-17  Tom Tromey  <tom@tromey.com>
6626
6627         * tui/tui-layout.c (make_command_window): Remove.
6628         (show_source_disasm_command, show_source_or_disasm_and_command):
6629         Unify creation and re-initialization cases.
6630
6631 2019-07-17  Tom Tromey  <tom@tromey.com>
6632
6633         * tui/tui-layout.c (show_source_or_disasm_and_command): Unify
6634         creation and re-initialization cases.
6635
6636 2019-07-17  Tom Tromey  <tom@tromey.com>
6637
6638         * tui/tui-regs.c (tui_get_register): Return void.
6639
6640 2019-07-17  Tom Tromey  <tom@tromey.com>
6641
6642         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible):
6643         Simplify.
6644
6645 2019-07-17  Tom Tromey  <tom@tromey.com>
6646
6647         * tui/tui-layout.c (show_source_disasm_command): Simplify window
6648         resetting.
6649
6650 2019-07-17  Tom Tromey  <tom@tromey.com>
6651
6652         * tui/tui.h (tui_set_layout_by_name): Don't declare.
6653         * tui/tui-regs.c (tui_reg_layout): New function.
6654         (tui_show_registers, tui_reg_command): Use it.
6655         * tui/tui-layout.c (LAYOUT_USAGE): Remove.
6656         (tui_layout_command): Rename from tui_set_layout_by_name.  Change
6657         parameters.
6658         (tui_layout_command): Remove.
6659
6660 2019-07-17  Tom Tromey  <tom@tromey.com>
6661
6662         * tui/tui-layout.h (tui/tui-layout): Return void.
6663         * tui/tui-layout.c (tui_set_layout): Return void.  Add assert.
6664
6665 2019-07-17  Tom Tromey  <tom@tromey.com>
6666
6667         * tui/tui-layout.c (show_source_disasm_command, show_data):
6668         Update.
6669         (reset_locator): Remove.
6670         (show_source_or_disasm_and_command): Update.
6671
6672 2019-07-17  Tom Tromey  <tom@tromey.com>
6673
6674         * tui/tui-source.c (tui_source_window_base::reset): Remove
6675         win_type parameter.
6676         * tui/tui-layout.c (make_command_window, make_source_window)
6677         (make_disasm_window, make_data_window)
6678         (show_source_disasm_command, show_data, tui_gen_win_info::reset)
6679         (reset_locator, show_source_or_disasm_and_command): Update.
6680         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Remove
6681         win_type parameter.
6682         (struct tui_source_window_base) <reset>: Likewise.
6683
6684 2019-07-17  Tom Tromey  <tom@tromey.com>
6685
6686         * tui/tui-layout.c (show_source_disasm_command): Use
6687         reset_locator.
6688         (reset_locator): New function.
6689         (init_and_make_win): Remove.
6690         (show_source_or_disasm_and_command): Use reset_locator.
6691
6692 2019-07-17  Tom Tromey  <tom@tromey.com>
6693
6694         * tui/tui-winsource.c (tui_set_exec_info_content): Remove
6695         condition.
6696         * tui/tui-wingeneral.c (tui_source_window_base::make_visible):
6697         Remove condition.
6698         * tui/tui-source.c (tui_source_window_base::reset): New method.
6699         * tui/tui-layout.c (make_command_window): Don't call
6700         init_and_make_win.
6701         (make_source_window, make_disasm_window): Don't call
6702         make_source_or_disasm_window.
6703         (make_data_window): Don't call init_and_make_win.  Change calling
6704         convention.
6705         (show_source_disasm_command, show_data): Simplify.
6706         (make_source_or_disasm_window): Remove.
6707         (show_source_or_disasm_and_command): Simplify.
6708         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Now virtual.
6709         (struct tui_source_window_base) <reset>: Likewise.
6710         <execution_info>: Remove initializer.
6711         * tui/tui-data.c (tui_source_window_base): Initialize
6712         execution_info.
6713
6714 2019-07-17  Tom Tromey  <tom@tromey.com>
6715
6716         * tui/tui-layout.c (tui_set_layout): Remove regs_populate
6717         variable.
6718
6719 2019-07-17  Tom Tromey  <tom@tromey.com>
6720
6721         * tui/tui.c (tui_rl_other_window): Update.
6722         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Call
6723         superclass method first.  Always iterate over regs_content.
6724         (tui_unhighlight_win, tui_highlight_win): Use refresh_window
6725         method.
6726         * tui/tui-win.c (tui_set_focus_command): Update.
6727
6728 2019-07-17  Tom Tromey  <tom@tromey.com>
6729
6730         * tui/tui-win.c (tui_set_focus_command): Rename from
6731         tui_set_focus.  Call tui_enable.
6732         (tui_set_focus_command): Remove.
6733
6734 2019-07-17  Tom Tromey  <tom@tromey.com>
6735
6736         * tui/tui-winsource.c (tui_show_exec_info_content): Don't call
6737         refresh_window.
6738         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Call
6739         touchwin.
6740         (tui_data_window::refresh_window): Call refresh_window on data
6741         items.  Always call superclass refresh_window.
6742         (tui_win_info::refresh): Remove.
6743         (tui_source_window_base::refresh_window): Update.
6744         (tui_refresh_all): Update.
6745         * tui/tui-layout.c (show_source_disasm_command): Remove call to
6746         refresh_window.
6747         (show_source_or_disasm_and_command): Likewise.
6748         * tui/tui-data.h (struct tui_win_info) <refresh>: Remove.
6749         (struct tui_source_window_base) <refresh>: Likewise.
6750
6751 2019-07-17  Tom Tromey  <tom@tromey.com>
6752
6753         * tui/tui-winsource.c (tui_clear_source_content)
6754         (tui_show_source_content): Update.
6755         * tui/tui-source.c (tui_source_window::showing_source_p): Check
6756         whether content is empty.
6757         * tui/tui-data.h (struct tui_source_window_base) <content_in_use>:
6758         Remove.
6759
6760 2019-07-17  Tom Tromey  <tom@tromey.com>
6761
6762         * tui/tui-winsource.c (tui_erase_source_content): Clear the
6763         window's contents.
6764         * tui/tui-source.h (tui_set_source_content_nil): Don't declare.
6765         * tui/tui-source.c (tui_set_source_content_nil): Remove.
6766
6767 2019-07-17  Tom Tromey  <tom@tromey.com>
6768
6769         * tui/tui-data.h (UNDEFINED_ITEM): Remove define.
6770         (struct tui_data_item_window): Update.
6771
6772 2019-07-17  Tom Tromey  <tom@tromey.com>
6773
6774         * tui/tui-data.h (MAX_CONTENT_COUNT, TUI_NULL_STR)
6775         (DEFAULT_HISTORY_COUNT, WITH_LOCATOR, NO_LOCATOR): Remove
6776         defines.
6777
6778 2019-07-17  Tom Tromey  <tom@tromey.com>
6779
6780         * tui/tui-winsource.h (tui_erase_source_content)
6781         (tui_clear_source_content): Remove "display_prompt" parameter.
6782         * tui/tui-winsource.c (tui_update_source_window_as_is)
6783         (tui_update_source_windows_with_addr): Update.
6784         (tui_clear_source_content): Remove "display_prompt" parameter.
6785         (tui_erase_source_content): Likewise.  Simplify.
6786         (tui_show_source_content): Update.
6787         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
6788         * tui/tui-stack.c (tui_show_frame_info): Update.
6789         * tui/tui-data.h (EMPTY_SOURCE_PROMPT, NO_EMPTY_SOURCE_PROMPT):
6790         Remove defines.
6791
6792 2019-07-17  Tom Tromey  <tom@tromey.com>
6793
6794         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
6795         * tui/tui-disasm.h (tui_set_disassem_content): Add win_info
6796         parameter.
6797         * tui/tui-disasm.c (tui_set_disassem_content): Add win_info
6798         parameter.
6799
6800 2019-07-17  Tom Tromey  <tom@tromey.com>
6801
6802         * tui/tui-winsource.c (tui_clear_source_content)
6803         (tui_show_source_content, tui_show_exec_info_content)
6804         (tui_clear_exec_info_content): Update.
6805         * tui/tui-stack.c (tui_show_locator_content): Update.
6806         (tui_show_frame_info): Update.
6807         * tui/tui-source.h (tui_source_window): Don't declare.
6808         * tui/tui-source.c (tui_source_window::showing_source_p): Rename
6809         from tui_source_is_displayed.
6810         * tui/tui-data.h (struct tui_gen_win_info) <content_in_use>:
6811         Remove field.
6812         (struct tui_source_window_base) <content_in_use>: New field.  Now
6813         bool.
6814         (struct tui_source_window) <showing_source_p>: New method.
6815         (TUI_SRC_WIN): Change cast.
6816         * tui/tui-data.c (tui_initialize_static_data): Update.
6817
6818 2019-07-17  Tom Tromey  <tom@tromey.com>
6819
6820         * tui/tui-winsource.c (tui_update_breakpoint_info): Use
6821         location_matches_p.
6822         * tui/tui-source.c (tui_source_window::location_matches_p): New
6823         method.
6824         * tui/tui-disasm.c (tui_disasm_window::location_matches_p): New
6825         method.
6826         * tui/tui-data.h (struct tui_source_window_base)
6827         <location_matches_p>: New method.
6828         (struct tui_source_window, struct tui_disasm_window)
6829         <location_matches_p>: Likewise.
6830
6831 2019-07-17  Tom Tromey  <tom@tromey.com>
6832
6833         * tui/tui-win.c (tui_set_win_height_command): Rename from
6834         tui_set_win_height.
6835         (tui_set_win_height_command): Remove.
6836
6837 2019-07-17  Tom Tromey  <tom@tromey.com>
6838
6839         * tui/tui-source.c (tui_source_window): New constructor.  Add
6840         observer.
6841         (~tui_source_window): New destructor.
6842         (tui_source_window::style_changed): New method.
6843         * tui/tui-hooks.c (tui_redisplay_source): Remove.
6844         (tui_attach_detach_observers): Update.
6845         * tui/tui-data.h (struct tui_source_window): Make constructor not
6846         inline.  Add destructor.
6847         (struct tui_source_window) <style_changed>: New method.
6848         <m_observable>: New member.
6849
6850 2019-07-17  Tom Tromey  <tom@tromey.com>
6851
6852         * tui/tui-data.c (tui_clear_source_windows_detail): Fix typo.
6853         * tui/tui-win.c (tui_resize_all): Fix typo.
6854
6855 2019-07-17  Tom Tromey  <tom@tromey.com>
6856
6857         * tui/tui-wingeneral.h (tui_refresh_all): Update.
6858         * tui/tui-wingeneral.c (make_all_visible): Use foreach.
6859         (tui_refresh_all): Remove "list" parameter.  Use foreach.
6860         * tui/tui-win.c (window_name_completer): Use foreach.
6861         (tui_refresh_all_win, tui_rehighlight_all, tui_all_windows_info)
6862         (update_tab_width): Likewise.
6863         * tui/tui-layout.c (show_layout): Update.
6864         * tui/tui-data.h (class tui_window_iterator): New.
6865         (struct all_tui_windows): New.
6866         * tui/tui-data.c (tui_partial_win_by_name): Use foreach.
6867
6868 2019-07-17  Tom Tromey  <tom@tromey.com>
6869
6870         * tui/tui-regs.c (tui_reg_next, tui_reg_prev): Add "current_group"
6871         parameter.  Don't reference globals.
6872         (tui_reg_command): Update.
6873
6874 2019-07-17  Tom Tromey  <tom@tromey.com>
6875
6876         * tui/tui-regs.c (tui_show_registers): Simplify.
6877
6878 2019-07-17  Tom Tromey  <tom@tromey.com>
6879
6880         * tui/tui-regs.c (tui_show_registers): Update.
6881         (tui_show_register_group): Add win_info parameter.
6882
6883 2019-07-17  Tom Tromey  <tom@tromey.com>
6884
6885         * tui/tui-regs.c (tui_data_window::display_reg_element_at_line):
6886         Rename from tui_display_reg_element_at_line.
6887         (tui_data_window::display_registers_from_line): Update.
6888         * tui/tui-data.h (struct tui_data_window)
6889         <display_reg_element_at_line>: New method.
6890
6891 2019-07-17  Tom Tromey  <tom@tromey.com>
6892
6893         * tui/tui-regs.h (tui_display_registers_from)
6894         (tui_display_registers_from_line): Don't declare.
6895         * tui/tui-windata.c (tui_data_window::display_all_data)
6896         (tui_data_window::refresh_all)
6897         (tui_data_window::do_scroll_vertical): Update.
6898         * tui/tui-regs.c (tui_data_window::display_registers_from): Rename
6899         from tui_display_registers_from.
6900         (tui_display_reg_element_at_line): Update.
6901         (tui_data_window::display_registers_from_line): Rename from
6902         tui_display_registers_from_line.
6903         * tui/tui-data.h (struct tui_data_window) <display_registers_from,
6904         display_registers_from_line>: New methods.
6905
6906 2019-07-17  Tom Tromey  <tom@tromey.com>
6907
6908         * tui/tui-windata.h (tui_erase_data_content): Don't declare.
6909         * tui/tui-windata.c (tui_data_window::erase_data_content): Rename
6910         from tui_erase_data_content.
6911         (tui_data_window::display_all_data)
6912         (tui_data_window::refresh_all)
6913         (tui_data_window::do_scroll_vertical): Update.
6914         * tui/tui-regs.c (tui_show_registers): Update.
6915         * tui/tui-data.h (struct tui_data_window) <erase_data_content>:
6916         New method.
6917
6918 2019-07-17  Tom Tromey  <tom@tromey.com>
6919
6920         * tui/tui-windata.h (tui_delete_data_content_windows): Don't
6921         declare.
6922         * tui/tui-windata.c
6923         (tui_data_window::delete_data_content_windows): Rename from
6924         tui_delete_data_content_windows.
6925         (tui_data_window::display_all_data)
6926         (tui_data_window::do_scroll_vertical): Update.
6927         * tui/tui-data.h (struct tui_data_window)
6928         <delete_data_content_windows>: New method.
6929
6930 2019-07-17  Tom Tromey  <tom@tromey.com>
6931
6932         * tui/tui-windata.h (tui_refresh_data_win): Don't declare.
6933         * tui/tui-regs.h (tui_first_reg_element_inline): Don't declare.
6934
6935 2019-07-17  Tom Tromey  <tom@tromey.com>
6936
6937         * tui/tui-windata.h (tui_display_all_data): Don't declare.
6938         * tui/tui-windata.c (tui_data_window::display_all_data): Rename
6939         from tui_display_all_data.
6940         * tui/tui-win.c
6941         (tui_data_window::do_make_visible_with_new_height): Update.
6942         * tui/tui-regs.c (tui_show_registers): Update.
6943         * tui/tui-layout.c (tui_set_layout): Update.
6944         * tui/tui-data.h (struct tui_data_window) <display_all_data>: New
6945         method.
6946
6947 2019-07-17  Tom Tromey  <tom@tromey.com>
6948
6949         * tui/tui-windata.h (tui_display_data_from): Don't declare.
6950         * tui/tui-windata.c (tui_display_data_from): Remove.
6951         (tui_data_window::refresh_all): Update.
6952
6953 2019-07-17  Tom Tromey  <tom@tromey.com>
6954
6955         * tui/tui-windata.h (tui_display_data_from_line): Don't declare.
6956         * tui/tui-windata.c (tui_display_data_from_line): Remove.
6957         (tui_display_data_from, tui_data_window::do_scroll_vertical): Call
6958         tui_display_registers_from_line.
6959         * tui/tui-regs.h (tui_display_registers_from_line): Update.
6960         * tui/tui-regs.c (tui_display_registers_from_line): Remove
6961         "force_display" parameter.
6962
6963 2019-07-17  Tom Tromey  <tom@tromey.com>
6964
6965         * tui/tui-regs.h (tui_first_reg_element_no_inline): Don't
6966         declare.
6967         * tui/tui-regs.c (tui_data_window::first_reg_element_no_inline):
6968         Rename from tui_first_reg_element_no_inline.
6969         (tui_display_reg_element_at_line)
6970         (tui_display_registers_from_line): Update.
6971         * tui/tui-data.h (struct tui_data_window)
6972         <first_reg_element_no_inline>: New method.
6973
6974 2019-07-17  Tom Tromey  <tom@tromey.com>
6975
6976         * tui/tui-windata.c (tui_display_data_from)
6977         (tui_data_window::do_scroll_vertical): Update.
6978         * tui/tui-regs.h (tui_line_from_reg_element_no): Don't declare.
6979         * tui/tui-regs.c (tui_data_window::line_from_reg_element_no):
6980         Rename from tui_line_from_reg_element_no.
6981         (tui_display_registers_from_line): Update.
6982         * tui/tui-data.h (struct tui_data_window)
6983         <line_from_reg_element_no>: New method.
6984
6985 2019-07-17  Tom Tromey  <tom@tromey.com>
6986
6987         * tui/tui-regs.h (tui_last_regs_line_no): Don't declare.
6988         * tui/tui-regs.c (tui_data_window::last_regs_line_no): Rename from
6989         tui_last_regs_line_no.
6990         (tui_display_reg_element_at_line)
6991         (tui_display_registers_from_line): Update.
6992         * tui/tui-data.h (struct tui_data_window) <last_regs_line_no>: New
6993         method.
6994
6995 2019-07-17  Tom Tromey  <tom@tromey.com>
6996
6997         PR tui/24722:
6998         * tui/tui-winsource.h (tui_update_all_breakpoint_info)
6999         (tui_update_breakpoint_info): Add "being_deleted" parameter.
7000         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
7001         (tui_update_all_breakpoint_info): Add "being_deleted" parameter.
7002         (tui_update_breakpoint_info): Likewise.
7003         * tui/tui-hooks.c (tui_event_create_breakpoint)
7004         (tui_event_delete_breakpoint, tui_event_modify_breakpoint):
7005         Update.
7006
7007 2019-07-17  Tom Tromey  <tom@tromey.com>
7008
7009         * tui/tui-stack.c (tui_show_frame_info): Consolidate "if"s.
7010
7011 2019-07-17  Tom Tromey  <tom@tromey.com>
7012
7013         * tui/tui-winsource.c (tui_update_source_window_as_is)
7014         (tui_update_source_windows_with_addr): Update.
7015         * tui/tui-source.h (tui_set_source_content)
7016         (tui_show_symtab_source): Add "win_info" parameter.
7017         * tui/tui-source.c (tui_set_source_content): Add "win_info"
7018         parameter.
7019         (tui_show_symtab_source): Likewise.
7020
7021 2019-07-17  Tom Tromey  <tom@tromey.com>
7022
7023         * tui/tui-wingeneral.c
7024         (tui_check_and_display_highlight_if_needed): Check can_highlight.
7025
7026 2019-07-17  Tom Tromey  <tom@tromey.com>
7027
7028         * tui/tui-data.h (struct tui_win_info) <can_scroll>: New method.
7029         (struct tui_cmd_window) <can_scroll>: New method.
7030         * tui/tui-command.c (tui_dispatch_ctrl_char): Use can_scroll
7031         method.
7032
7033 2019-07-17  Tom Tromey  <tromey@adacore.com>
7034
7035         * ui-out.h (class ui_out) <field_signed, field_fmt_signed,
7036         do_field_signed>: Rename.  Change type of "value".
7037         * ui-out.c (ui_out::field_signed): Rename from field_int.
7038         Change type of "value".
7039         (ui_out::field_fmt_signed): Rename from field_fmt_int.  Change
7040         type of "value".
7041         * tui/tui-out.h (class tui_ui_out) <do_field_signed>: Rename from
7042         do_field_int.  Change type of "value".
7043         * tui/tui-out.c (tui_ui_out::do_field_signed): Rename from
7044         do_field_int.  Change type of "value".
7045         * tracepoint.c (trace_status_mi, tfind_1)
7046         (print_one_static_tracepoint_marker): Update.
7047         * thread.c (print_thread_info_1, print_selected_thread_frame):
7048         Update.
7049         * stack.c (print_frame, print_frame_info): Update.
7050         * spu-tdep.c (info_spu_signal_command, info_spu_dma_cmdlist):
7051         Update.
7052         * source.c (print_source_lines_base): Update.
7053         * skip.c (info_skip_command): Update.
7054         * record-btrace.c (btrace_ui_out_decode_error)
7055         (btrace_call_history_src_line): Update.
7056         * python/py-framefilter.c (py_print_single_arg, py_print_frame):
7057         Update.
7058         * progspace.c (print_program_space): Update.
7059         * mi/mi-symbol-cmds.c (mi_cmd_symbol_list_lines): Update.
7060         * mi/mi-out.h (class mi_ui_out) <do_field_signed>: Rename from
7061         do_field_int.  Change type of "value".
7062         * mi/mi-out.c (mi_ui_out::do_table_begin)
7063         (mi_ui_out::do_table_header): Update.
7064         (mi_ui_out::do_field_signed): Rename from do_field_int.  Change
7065         type of "value".
7066         * mi/mi-main.c (mi_cmd_thread_list_ids, print_one_inferior)
7067         (mi_cmd_data_list_changed_registers, output_register)
7068         (mi_cmd_data_read_memory, mi_load_progress)
7069         (mi_cmd_trace_frame_collected): Update.
7070         * mi/mi-interp.c (mi_on_normal_stop_1, mi_output_solib_attribs):
7071         Update.
7072         * mi/mi-cmd-var.c (print_varobj, mi_cmd_var_create)
7073         (mi_cmd_var_delete, mi_cmd_var_info_num_children)
7074         (mi_cmd_var_list_children, varobj_update_one): Update.
7075         * mi/mi-cmd-stack.c (mi_cmd_stack_info_depth)
7076         (mi_cmd_stack_list_args, list_arg_or_local): Update.
7077         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_file): Update.
7078         * inferior.c (print_inferior): Update.
7079         * gdb_bfd.c (print_one_bfd): Update.
7080         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
7081         Update.
7082         * darwin-nat-info.c (darwin_debug_regions_recurse): Update.
7083         * cli-out.h (class cli_ui_out) <do_field_signed>: Rename from
7084         do_field_int.  Change type of "value".
7085         * cli-out.c (cli_ui_out::do_field_signed): Rename from
7086         do_field_int.  Change type of "value".
7087         * breakpoint.c (watchpoint_check, print_breakpoint_location)
7088         (print_one_breakpoint_location, print_it_catch_fork)
7089         (print_one_catch_fork, print_it_catch_vfork)
7090         (print_one_catch_vfork, print_it_catch_solib)
7091         (print_it_catch_exec, print_it_ranged_breakpoint)
7092         (print_mention_watchpoint, print_mention_masked_watchpoint)
7093         (bkpt_print_it, update_static_tracepoint): Update.
7094         * break-catch-throw.c (print_it_exception_catchpoint): Update.
7095         * break-catch-syscall.c (print_it_catch_syscall): Update.
7096         * ada-tasks.c (print_ada_task_info): Update.
7097         * ada-lang.c (print_it_exception, print_mention_exception):
7098         Update.
7099
7100 2019-07-17  Andrew Burgess  <andrew.burgess@embecosm.com>
7101
7102         PR breakpoints/24541
7103         * gdbarch.c: Regenerate.
7104         * gdbarch.h: Regenerate.
7105         * gdbarch.sh: Adjust return type and parameter types for
7106         'stap_adjust_register'.
7107         (i386_stap_adjust_register): Adjust signature and return new
7108         register name.
7109         * stap-probe.c (stap_parse_register_operand): Adjust use of
7110         'gdbarch_stap_adjust_register'.
7111
7112 2019-07-17  Tom Tromey  <tromey@adacore.com>
7113
7114         * s390-linux-nat.c (s390_watch_area): Remove typedef.  Don't
7115         declare VEC.
7116         (struct s390_debug_reg_state) <watch_areas, break_areas>: Now
7117         std::vector.
7118         (struct s390_process_info): Add initializers.
7119         (s390_add_process): Use new.
7120         (s390_linux_nat_target::low_forget_process): Use delete.
7121         (s390_linux_nat_target::low_new_fork)
7122         (s390_linux_nat_target::stopped_by_watchpoint)
7123         (s390_linux_nat_target::low_prepare_to_resume)
7124         (s390_linux_nat_target::insert_watchpoint)
7125         (s390_linux_nat_target::insert_hw_breakpoint)
7126         (s390_linux_nat_target::remove_watchpoint)
7127         (s390_linux_nat_target::remove_hw_breakpoint): Update.
7128
7129 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
7130
7131         * aarch64-fbsd-nat.c: Include regcache.h.
7132         (getregs_supplies, getfpregs_supplies): Remove unused gdbarch
7133         argument.
7134         (aarch64_fbsd_nat_target::fetch_registers)
7135         (aarch64_fbsd_nat_target::store_registers): Remove gdbarch
7136         variable.
7137         * arm-fbsd-nat.c, riscv-fbsd-nat.c: Likewise.
7138
7139 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
7140
7141         * fbsd-nat.c: Include gdbarch.h.
7142
7143 2019-07-15  Tom Tromey  <tromey@adacore.com>
7144
7145         * mi/mi-out.c (mi_ui_out::do_field_int): Use plongest.
7146
7147 2019-07-15  Tom Tromey  <tromey@adacore.com>
7148
7149         * mi/mi-out.h (class mi_ui_out) <do_field_unsigned>: Declare.
7150         * mi/mi-out.c (mi_ui_out::do_field_unsigned): New method.
7151         * cli-out.h (class cli_ui_out) <do_field_unsigned>: Declare.
7152         * cli-out.c (cli_ui_out::do_field_int): New method.
7153         * ui-out.c (ui_out::field_unsigned): New method.
7154         * symfile.c (generic_load): Use field_unsigned.
7155         (print_transfer_performance): Likewise.
7156         * record-btrace.c (ui_out_field_uint): Remove.
7157         (btrace_call_history_insn_range, btrace_call_history): Use
7158         field_unsigned.
7159         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn): Use
7160         field_unsigned.
7161         * ui-out.h (class ui_out) <field_unsigned>: New method.
7162         <do_field_unsigned>: Likewise.
7163
7164 2019-07-15  Tom Tromey  <tromey@adacore.com>
7165
7166         * mi/mi-main.c (list_available_thread_groups): Use field_string.
7167         * mi/mi-interp.c (mi_memory_changed): Use field_string.
7168         * target.c (flash_erase_command): Use field_string.
7169         * infrun.c (print_signal_received_reason): Use field_string.
7170         * i386-tdep.c (i386_mpx_print_bounds): Use field_string.
7171         * breakpoint.c (maybe_print_thread_hit_breakpoint): Use
7172         field_string.
7173         * ada-tasks.c (print_ada_task_info): Use field_string.
7174
7175 2019-07-15  Tom Tromey  <tromey@adacore.com>
7176
7177         * target.c (flash_erase_command): Use field_core_addr.
7178         * symfile.c (generic_load): Use field_core_addr.
7179         * sparc64-linux-tdep.c (sparc64_linux_handle_segmentation_fault):
7180         Use field_core_addr.
7181         * i386-linux-tdep.c (i386_linux_handle_segmentation_fault): Use
7182         field_core_addr.
7183
7184 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
7185
7186         * dwarf2loc.c (dwarf2_evaluate_property): Sign extend property
7187         value if its desired type is smaller than a CORE_ADDR and signed.
7188
7189 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
7190
7191         * dwarf2loc.c (dwarf2_evaluate_property): Update to take account
7192         of changes to field names, and use new is_reference field to
7193         decide if a property is a reference or not.
7194         * dwarf2loc.h (struct dwarf2_locexpr_baton): Add 'is_reference'
7195         field.
7196         (struct dwarf2_property_baton): Update header comment, rename
7197         'referenced_type' to 'property_type' and update comments.
7198         * dwarf2read.c (attr_to_dynamic_prop): Add extra parameter to hold
7199         default property type, store in property baton, update to take
7200         accound of renamed field.
7201         (read_func_scope): Update call to attr_to_dynamic_prop.
7202         (read_array_type): Likewise.
7203         (dwarf2_per_cu_addr_sized_int_type): New function.
7204         (read_subrange_index_type): Move type finding code to
7205         dwarf2_per_cu_addr_sized_int_type.
7206         (read_subrange_type): Update calls to attr_to_dynamic_prop.
7207         (dwarf2_per_cu_addr_type): New function.
7208         (set_die_type): Update calls to attr_to_dynamic_prop.
7209
7210 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
7211
7212         * dwarf2read.c (read_subrange_index_type): New function.
7213         (read_subrange_type): Move code into new function and call it.
7214         * gdbtypes.c (create_range_type): Add some asserts.
7215
7216 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
7217
7218         * dwarf2loc.c (dwarf2_evaluate_property): Change return type, and
7219         update return statements.
7220         * dwarf2loc.h (dwarf2_evaluate_property): Update return type on
7221         declaration, and update comment to match.
7222         * gdbtypes.c (resolve_dynamic_array): Update call to
7223         dwarf2_evaluate_property to match new return type.
7224
7225 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
7226
7227         * valarith.c (value_subscripted_rvalue): Change lowerbound
7228         parameter type from int to LONGEST.
7229         * value.h (value_subscripted_rvalue): Likewise in declaration.
7230
7231 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
7232
7233         * cli/cli-utils.c (info_print_command_completer): New function.
7234         * cli/cli-utils.h: Add 'completer.h' include, and forward
7235         declaration for 'struct cmd_list_element'.
7236         (info_print_command_completer): Declare.
7237         * stack.c (_initialize_stack): Add completer for 'info locals' and
7238         'info args'.
7239         * symtab.c (_initialize_symtab): Add completer for 'info
7240         variables' and 'info functions'.
7241         * NEWS: Mention completion for additional info commands.
7242
7243 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
7244
7245         * cli/cli-utils.c (extract_info_print_args): Delete.
7246         (extract_arg_maybe_quoted): Delete.
7247         (info_print_options_defs): New variable.
7248         (make_info_print_options_def_group): New function.
7249         (extract_info_print_options): Define new function.
7250         * cli/cli-utils.h (extract_info_print_args): Delete.
7251         (struct info_print_options): New structure.
7252         (extract_info_print_options): Declare new function.
7253         * stack.c (info_locals_command): Update to use new
7254         extract_info_print_options, also add a header comment.
7255         (info_args_command): Likewise.
7256         * symtab.c (info_variables_command): Likewise.
7257         (info_functions_command): Likewise.
7258
7259 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
7260
7261         * cli/cli-option.c (parse_option): Use extract_string_maybe_quoted
7262         to extract string arguments.
7263         * common/common-utils.c (extract_string_maybe_quoted): New function.
7264         * common/common-utils.h (extract_string_maybe_quoted): Declare.
7265
7266 2019-07-11  Tom Tromey  <tromey@adacore.com>
7267
7268         * main.c (get_init_files): Use GDBINIT, not gdbinit.
7269         * auto-load.c (file_is_auto_load_safe): Use GDBINIT, not gdbinit.
7270         * top.h (gdbinit): Don't declare.
7271         * cli/cli-cmds.c (init_cli_cmds): Remove, merging contents
7272         into...
7273         (_initialize_cli_cmds): ...here.  Use GDBINIT, not gdbinit.
7274         * top.c (gdb_init): Don't call init_cli_cmds.
7275         (gdbinit): Remove.
7276         * cli/cli-cmds.h (init_cli_cmds): Don't declare.
7277
7278 2019-07-11  Tom Tromey  <tromey@adacore.com>
7279
7280         * python/py-inferior.c (add_thread_object): Don't use thread_obj
7281         after it has been moved.
7282
7283 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
7284
7285         * valops.c (value_must_coerce_to_target): Change return type to
7286         bool.
7287         * value.h (value_must_coerce_to_target): Likewise.
7288
7289 2019-07-10  Simon Marchi  <simon.marchi@efficios.com>
7290
7291         * breakpoint.c (is_hardware_watchpoint): Remove
7292         forward-declaration.
7293         (is_masked_watchpoint): Change return type to bool.
7294         (is_tracepoint): Likewise.
7295         (is_breakpoint): Likewise.
7296         (is_hardware_watchpoint): Likewise.
7297         (is_watchpoint): Likewise.
7298         (is_no_memory_software_watchpoint): Likewise.
7299         (is_catchpoint): Likewise.
7300         (breakpoint_1): Make FILTER parameter's return type bool.
7301         is_masked_watchpoint): Change return type to bool.
7302         (save_breakpoints): Make FILTER parameter's return type bool.
7303         * breakpoint.h (is_breakpoint): Change return type to bool.
7304         (is_watchpoint): Likewise.
7305         (is_catchpoint): Likewise.
7306         (is_tracepoint): Likewise.
7307
7308 2019-07-10  Tom Tromey  <tom@tromey.com>
7309
7310         * defs.h: Don't include gdbarch.h.
7311         * aarch64-ravenscar-thread.c, aarch64-tdep.c, alpha-bsd-tdep.h,
7312         alpha-linux-tdep.c, alpha-mdebug-tdep.c, arch-utils.h, arm-tdep.h,
7313         ax-general.c, btrace.c, buildsym-legacy.c, buildsym.h, c-lang.c,
7314         cli/cli-decode.h, cli/cli-dump.c, cli/cli-script.h,
7315         cli/cli-style.h, coff-pe-read.h, compile/compile-c-support.c,
7316         compile/compile-cplus.h, compile/compile-loc2c.c, corefile.c,
7317         cp-valprint.c, cris-linux-tdep.c, ctf.c, d-lang.c, d-namespace.c,
7318         dcache.c, dicos-tdep.c, dictionary.c, disasm-selftests.c,
7319         dummy-frame.c, dummy-frame.h, dwarf2-frame-tailcall.c,
7320         dwarf2expr.c, expression.h, f-lang.c, frame-base.c,
7321         frame-unwind.c, frv-linux-tdep.c, gdbarch-selftests.c, gdbtypes.h,
7322         go-lang.c, hppa-nbsd-tdep.c, hppa-obsd-tdep.c, i386-dicos-tdep.c,
7323         i386-tdep.h, ia64-vms-tdep.c, interps.h, language.c,
7324         linux-record.c, location.h, m2-lang.c, m32r-linux-tdep.c,
7325         mem-break.c, memattr.c, mn10300-linux-tdep.c, nios2-linux-tdep.c,
7326         objfiles.h, opencl-lang.c, or1k-linux-tdep.c, p-lang.c,
7327         parser-defs.h, ppc-tdep.h, probe.h, python/py-record-btrace.c,
7328         record-btrace.c, record.h, regcache-dump.c, regcache.h,
7329         riscv-fbsd-tdep.c, riscv-linux-tdep.c, rust-exp.y,
7330         sh-linux-tdep.c, sh-nbsd-tdep.c, source-cache.c,
7331         sparc-nbsd-tdep.c, sparc-obsd-tdep.c, sparc-ravenscar-thread.c,
7332         sparc64-fbsd-tdep.c, std-regs.c, target-descriptions.h,
7333         target-float.c, tic6x-linux-tdep.c, tilegx-linux-tdep.c, top.c,
7334         tracefile.c, trad-frame.c, type-stack.h, ui-style.c, utils.c,
7335         utils.h, valarith.c, valprint.c, varobj.c, x86-tdep.c,
7336         xml-support.h, xtensa-linux-tdep.c, cli/cli-cmds.h: Update.
7337         * s390-linux-nat.c, procfs.c, inf-ptrace.c: Likewise.
7338
7339 2019-07-10  Tom Tromey  <tromey@adacore.com>
7340
7341         * ada-lang.h (is_ada_exception_catchpoint): Declare.
7342         * breakpoint.c (init_ada_exception_breakpoint): Register as
7343         bp_catchpoint.
7344         (print_one_breakpoint_location, print_one_breakpoint): Use
7345         is_ada_exception_catchpoint.
7346         * ada-lang.c (class ada_catchpoint_location): Pass
7347         bp_loc_software_breakpoint to bp_location constructor.
7348         (is_ada_exception_catchpoint): New function.
7349
7350 2019-07-10  Tom Tromey  <tromey@adacore.com>
7351
7352         * arm-tdep.c (arm_exidx_entry_s): Remove typedef.  Don't define
7353         VEC.
7354         (struct arm_exidx_entry): New method operator<.
7355         (struct arm_exidx_data) <section_maps>: Change type.
7356         (arm_exidx_data_free): Remove.
7357         (arm_exidx_data_key): Change type.  Move lower.
7358         (arm_exidx_new_objfile): Update.
7359         (arm_compare_exidx_entries): Remove.
7360         (arm_find_exidx_entry, _initialize_arm_tdep)
7361
7362 2019-07-10  Tom Tromey  <tromey@adacore.com>
7363
7364         * solib-spu.c (ocl_program_data_key): Change type.
7365         (append_ocl_sos, ocl_enable_break, _initialize_spu_solib):
7366         Update.
7367
7368 2019-07-10  Tom Tromey  <tromey@adacore.com>
7369
7370         * solib-aix.c (lm_info_aix_p): Remove typedef.  Don't define VEC.
7371         (struct solib_aix_inferior_data) <library_list>: Change type.
7372         (solib_aix_inferior_data_handle): Change type.
7373         (get_solib_aix_inferior_data): Update.
7374         (solib_aix_free_library_list): Remove.
7375         (library_list_start_library): Update.
7376         (solib_aix_parse_libraries, solib_aix_get_library_list): Change
7377         return type.
7378         (solib_aix_get_library_list)
7379         (solib_aix_solib_create_inferior_hook, solib_aix_current_sos)
7380         (solib_aix_normal_stop_observer, _initialize_solib_aix): Update.
7381
7382 2019-07-10  Tom Tromey  <tromey@adacore.com>
7383
7384         * solib-dsbt.c (struct dsbt_info): Add initializers.
7385         (solib_dsbt_pspace_data): Change type.
7386         (dsbt_pspace_data_cleanup): Remove.
7387         (get_dsbt_info, _initialize_dsbt_solib): Update.
7388
7389 2019-07-10  Tom Tromey  <tromey@adacore.com>
7390
7391         * spu-tdep.c (spu_overlay_data): Change type.
7392         (spu_get_overlay_table, spu_overlay_new_objfile)
7393         (_initialize_spu_tdep): Update.
7394
7395 2019-07-10  Tom Tromey  <tromey@adacore.com>
7396
7397         * gdb-stabs.h (struct dbx_symfile_info): Add initializers and
7398         destructor.
7399         (dbx_objfile_data_key): Change type and declare later.
7400         (DBX_SYMFILE_INFO): Rewrite.
7401         * dbxread.c (dbx_objfile_data_key): Change type.
7402         (dbx_symfile_init): Update.
7403         (~dbx_symfile_info): Rename from dbx_free_symfile_info.  Update.
7404         (coffstab_build_psymtabs, elfstab_build_psymtabs)
7405         (stabsect_build_psymtabs, _initialize_dbxread): Update.
7406
7407 2019-07-10  Tom Tromey  <tromey@adacore.com>
7408
7409         * jit.c (jit_program_space_key): Change type.  Move lower.
7410         (get_jit_program_space_data): Update.
7411         (jit_program_space_data_cleanup): Remove.
7412         (jit_breakpoint_deleted, free_objfile_data, _initialize_jit):
7413         Update.
7414         (struct jit_program_space_data): Add initializers.
7415
7416 2019-07-10  Tom Tromey  <tromey@adacore.com>
7417
7418         * solib-darwin.c (struct darwin_info): Add initializers.
7419         (solib_darwin_pspace_data): Change type.
7420         (darwin_pspace_data_cleanup): Remove.
7421         (get_darwin_info, _initialize_darwin_solib): Update.
7422
7423 2019-07-10  Tom Tromey  <tromey@adacore.com>
7424
7425         * remote-sim.c (struct sim_inferior_data): Add initializers,
7426         constructor, and destructor.
7427         (sim_inferior_data_key): Change type.  Move lower.
7428         (check_for_duplicate_sim_descriptor): Update.
7429         (get_sim_inferior_data): Use new.  Update.
7430         (~sim_inferior_data_cleanup): Rename from
7431         sim_inferior_data_cleanup.  Simplify.
7432         (gdbsim_close_inferior, simulator_command)
7433         (sim_command_completer, _initialize_remote_sim): Update.
7434         (next_pid, INITIAL_PID): Move earlier.
7435
7436 2019-07-10  Tom Tromey  <tromey@adacore.com>
7437
7438         * python/python-internal.h (create_thread_object): Return
7439         gdbpy_ref.
7440         * python/py-infthread.c (create_thread_object): Return gdbpy_ref.
7441         * python/py-inferior.c (struct threadlist_entry): Add
7442         constructor.
7443         <thread_obj>: Now a gdbpy_ref.
7444         (thread_to_thread_object): Update.
7445         (add_thread_object): Use new.
7446         (delete_thread_object): Use delete.
7447         (infpy_threads): Update.
7448         (py_free_inferior): Update.  Construct "inf_obj" after acquiring
7449         GIL.
7450
7451 2019-07-10  Tom Tromey  <tromey@adacore.com>
7452
7453         * valops.c (value_cast): Specialize error message for Ada.
7454
7455 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
7456
7457         * breakpoint.c (breakpoint_1): Update doc and parameter names.
7458
7459 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
7460
7461         * breakpoint.h (bpstat_explains_signal, bpstat_causes_stop,
7462         bpstat_should_step): Return bool, adjust comments.
7463         * breakpoint.c (bpstat_explains_signal, bpstat_causes_stop,
7464         bpstat_should_step): Likewise.
7465
7466 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
7467
7468         * features/Makefile: Use feature target descriptions for Arm.
7469         * features/arm/arm-core.c: Generate new file.
7470         * features/arm/arm-fpa.c: Likewise.
7471         * features/arm/arm-m-profile-with-fpa.xml: Likewise.
7472         * features/arm/arm-m-profile.c: Likewise.
7473         * features/arm/arm-vfpv2.c: Likewise.
7474         * features/arm/arm-vfpv3.c: Likewise.
7475         * features/arm/xscale-iwmmxt.c: Likewise.
7476         * target-descriptions.c (maint_print_c_tdesc_cmd): Add Arm.
7477
7478 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
7479
7480         * arm-linux-nat.c (arm_linux_nat_target::read_description): Check
7481         ptrace earlier.
7482
7483 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
7484
7485         * features/aarch64-pauth.c: Regenerate.
7486
7487 2019-07-09  Simon Marchi  <simon.marchi@polymtl.ca>
7488
7489         * breakpoint.h (struct bpstat_what) <is_longjmp>: Change type to
7490         bool.
7491         (bpstat_what): Use false instead of 0.
7492
7493 2019-07-09  Pedro Alves  <palves@redhat.com>
7494
7495         * break-catch-throw.c (is_exception_catchpoint): New.
7496         * breakpoint.c (print_one_breakpoint_location): New parameter
7497         'raw_loc'.  Handle it.  Use
7498         is_watchpoint/is_catchpoint/is_exception_catchpoint instead of
7499         looking at the breakpoint's type.
7500         (print_one_breakpoint): If handling "maint info breakpoints", also
7501         print locations of exception catchpoints.
7502         * breakpoint.h (is_exception_catchpoint): Declare.
7503
7504 2019-07-09  Pedro Alves  <palves@redhat.com>
7505
7506         * break-catch-throw.c (print_one_exception_catchpoint): Skip the
7507         "addr" field.
7508         (allocate_location_exception_catchpoint): New.
7509         (handle_gnu_v3_exceptions): Don't reset 'type' to bp_breakpoint.
7510         (initialize_throw_catchpoint_ops): Install
7511         allocate_location_exception_catchpoint as allocate_location
7512         method.
7513         * breakpoint.c (bpstat_what) <bp_catch>: Set action to
7514         BPSTAT_WHAT_SINGLE if not stopping and the location's type is not
7515         bp_loc_other.
7516         (breakpoint_address_is_meaningful): Delete.
7517         (bl_address_is_meaningful): New.
7518         (breakpoint_locations_match): Adjust comment.
7519         (bp_location_from_bp_type): New, factored out of...
7520         (bp_location::bp_location(breakpoint *)): ... this.
7521         (bp_location::bp_location(breakpoint *, bp_loc_type)): New,
7522         factored out of...
7523         (bp_location::bp_location(breakpoint *)): ... this.  Reimplement.
7524         (bp_loc_is_permanent): Use bl_address_is_meaningful instead of
7525         breakpoint_address_is_meaningful.
7526         (bp_locations_compare): Adjust comment.
7527         (update_global_location_list): Use bl_address_is_meaningful
7528         instead of breakpoint_address_is_meaningful.
7529         * breakpoint.h (bp_location::bp_location(breakpoint *)): New
7530         explicit.
7531         (bp_location::bp_location(breakpoint *, bp_loc_type)): Declare.
7532         * python/py-breakpoint.c (bppy_get_location): No longer check
7533         whether location is null.
7534
7535 2019-07-09  Pedro Alves  <palves@redhat.com>
7536
7537         PR c++/15468
7538         * breakpoint.c (print_one_breakpoint_location): Remove
7539         single-location assert.
7540
7541 2019-07-09  Tom Tromey  <tom@tromey.com>
7542
7543         * contrib/ari/gdb_ari.sh: Change common to gdbsupport.
7544         * configure: Rebuild.
7545         * configure.ac: Change common to gdbsupport.
7546         * gdbsupport: Rename from common.
7547         * acinclude.m4: Change common to gdbsupport.
7548         * Makefile.in (CONFIG_SRC_SUBDIR, COMMON_SFILES)
7549         (HFILES_NO_SRCDIR, stamp-version, ALLDEPFILES): Change common to
7550         gdbsupport.
7551         * aarch64-tdep.c, ada-lang.c, ada-lang.h, agent.c, alloc.c,
7552         amd64-darwin-tdep.c, amd64-dicos-tdep.c, amd64-fbsd-nat.c,
7553         amd64-fbsd-tdep.c, amd64-linux-nat.c, amd64-linux-tdep.c,
7554         amd64-nbsd-tdep.c, amd64-obsd-tdep.c, amd64-sol2-tdep.c,
7555         amd64-tdep.c, amd64-windows-tdep.c, arch-utils.c,
7556         arch/aarch64-insn.c, arch/aarch64.c, arch/aarch64.h, arch/amd64.c,
7557         arch/amd64.h, arch/arm-get-next-pcs.c, arch/arm-linux.c,
7558         arch/arm.c, arch/i386.c, arch/i386.h, arch/ppc-linux-common.c,
7559         arch/riscv.c, arch/riscv.h, arch/tic6x.c, arm-tdep.c, auto-load.c,
7560         auxv.c, ax-gdb.c, ax-general.c, ax.h, breakpoint.c, breakpoint.h,
7561         btrace.c, btrace.h, build-id.c, build-id.h, c-lang.h, charset.c,
7562         charset.h, cli/cli-cmds.c, cli/cli-cmds.h, cli/cli-decode.c,
7563         cli/cli-dump.c, cli/cli-option.h, cli/cli-script.c,
7564         coff-pe-read.c, command.h, compile/compile-c-support.c,
7565         compile/compile-c.h, compile/compile-cplus-symbols.c,
7566         compile/compile-cplus-types.c, compile/compile-cplus.h,
7567         compile/compile-loc2c.c, compile/compile.c, completer.c,
7568         completer.h, contrib/ari/gdb_ari.sh, corefile.c, corelow.c,
7569         cp-support.c, cp-support.h, cp-valprint.c, csky-tdep.c, ctf.c,
7570         darwin-nat.c, debug.c, defs.h, disasm-selftests.c, disasm.c,
7571         disasm.h, dtrace-probe.c, dwarf-index-cache.c,
7572         dwarf-index-cache.h, dwarf-index-write.c, dwarf2-frame.c,
7573         dwarf2expr.c, dwarf2loc.c, dwarf2read.c, event-loop.c,
7574         event-top.c, exceptions.c, exec.c, extension.h, fbsd-nat.c,
7575         features/aarch64-core.c, features/aarch64-fpu.c,
7576         features/aarch64-pauth.c, features/aarch64-sve.c,
7577         features/i386/32bit-avx.c, features/i386/32bit-avx512.c,
7578         features/i386/32bit-core.c, features/i386/32bit-linux.c,
7579         features/i386/32bit-mpx.c, features/i386/32bit-pkeys.c,
7580         features/i386/32bit-segments.c, features/i386/32bit-sse.c,
7581         features/i386/64bit-avx.c, features/i386/64bit-avx512.c,
7582         features/i386/64bit-core.c, features/i386/64bit-linux.c,
7583         features/i386/64bit-mpx.c, features/i386/64bit-pkeys.c,
7584         features/i386/64bit-segments.c, features/i386/64bit-sse.c,
7585         features/i386/x32-core.c, features/riscv/32bit-cpu.c,
7586         features/riscv/32bit-csr.c, features/riscv/32bit-fpu.c,
7587         features/riscv/64bit-cpu.c, features/riscv/64bit-csr.c,
7588         features/riscv/64bit-fpu.c, features/tic6x-c6xp.c,
7589         features/tic6x-core.c, features/tic6x-gp.c, filename-seen-cache.h,
7590         findcmd.c, findvar.c, fork-child.c, gcore.c, gdb_bfd.c, gdb_bfd.h,
7591         gdb_proc_service.h, gdb_regex.c, gdb_select.h, gdb_usleep.c,
7592         gdbarch-selftests.c, gdbthread.h, gdbtypes.h, gnu-nat.c,
7593         go32-nat.c, guile/guile.c, guile/scm-ports.c,
7594         guile/scm-safe-call.c, guile/scm-type.c, i386-fbsd-nat.c,
7595         i386-fbsd-tdep.c, i386-go32-tdep.c, i386-linux-nat.c,
7596         i386-linux-tdep.c, i386-tdep.c, i387-tdep.c,
7597         ia64-libunwind-tdep.c, ia64-linux-nat.c, inf-child.c,
7598         inf-ptrace.c, infcall.c, infcall.h, infcmd.c, inferior-iter.h,
7599         inferior.c, inferior.h, inflow.c, inflow.h, infrun.c, infrun.h,
7600         inline-frame.c, language.h, linespec.c, linux-fork.c, linux-nat.c,
7601         linux-tdep.c, linux-thread-db.c, location.c, machoread.c,
7602         macrotab.h, main.c, maint.c, maint.h, memattr.c, memrange.h,
7603         mi/mi-cmd-break.h, mi/mi-cmd-env.c, mi/mi-cmd-stack.c,
7604         mi/mi-cmd-var.c, mi/mi-interp.c, mi/mi-main.c, mi/mi-parse.h,
7605         minsyms.c, mips-linux-tdep.c, namespace.h,
7606         nat/aarch64-linux-hw-point.c, nat/aarch64-linux-hw-point.h,
7607         nat/aarch64-linux.c, nat/aarch64-sve-linux-ptrace.c,
7608         nat/amd64-linux-siginfo.c, nat/fork-inferior.c,
7609         nat/linux-btrace.c, nat/linux-btrace.h, nat/linux-namespaces.c,
7610         nat/linux-nat.h, nat/linux-osdata.c, nat/linux-personality.c,
7611         nat/linux-procfs.c, nat/linux-ptrace.c, nat/linux-ptrace.h,
7612         nat/linux-waitpid.c, nat/mips-linux-watch.c,
7613         nat/mips-linux-watch.h, nat/ppc-linux.c, nat/x86-dregs.c,
7614         nat/x86-dregs.h, nat/x86-linux-dregs.c, nat/x86-linux.c,
7615         nto-procfs.c, nto-tdep.c, objfile-flags.h, objfiles.c, objfiles.h,
7616         obsd-nat.c, observable.h, osdata.c, p-valprint.c, parse.c,
7617         parser-defs.h, ppc-linux-nat.c, printcmd.c, probe.c, proc-api.c,
7618         procfs.c, producer.c, progspace.h, psymtab.h,
7619         python/py-framefilter.c, python/py-inferior.c, python/py-ref.h,
7620         python/py-type.c, python/python.c, record-btrace.c, record-full.c,
7621         record.c, record.h, regcache-dump.c, regcache.c, regcache.h,
7622         remote-fileio.c, remote-fileio.h, remote-sim.c, remote.c,
7623         riscv-tdep.c, rs6000-aix-tdep.c, rust-exp.y, s12z-tdep.c,
7624         selftest-arch.c, ser-base.c, ser-event.c, ser-pipe.c, ser-tcp.c,
7625         ser-unix.c, skip.c, solib-aix.c, solib-target.c, solib.c,
7626         source-cache.c, source.c, source.h, sparc-nat.c, spu-linux-nat.c,
7627         stack.c, stap-probe.c, symfile-add-flags.h, symfile.c, symfile.h,
7628         symtab.c, symtab.h, target-descriptions.c, target-descriptions.h,
7629         target-memory.c, target.c, target.h, target/waitstatus.c,
7630         target/waitstatus.h, thread-iter.h, thread.c, tilegx-tdep.c,
7631         top.c, top.h, tracefile-tfile.c, tracefile.c, tracepoint.c,
7632         tracepoint.h, tui/tui-io.c, ui-file.c, ui-out.h,
7633         unittests/array-view-selftests.c,
7634         unittests/child-path-selftests.c, unittests/cli-utils-selftests.c,
7635         unittests/common-utils-selftests.c,
7636         unittests/copy_bitwise-selftests.c, unittests/environ-selftests.c,
7637         unittests/format_pieces-selftests.c,
7638         unittests/function-view-selftests.c,
7639         unittests/lookup_name_info-selftests.c,
7640         unittests/memory-map-selftests.c, unittests/memrange-selftests.c,
7641         unittests/mkdir-recursive-selftests.c,
7642         unittests/observable-selftests.c,
7643         unittests/offset-type-selftests.c, unittests/optional-selftests.c,
7644         unittests/parse-connection-spec-selftests.c,
7645         unittests/ptid-selftests.c, unittests/rsp-low-selftests.c,
7646         unittests/scoped_fd-selftests.c,
7647         unittests/scoped_mmap-selftests.c,
7648         unittests/scoped_restore-selftests.c,
7649         unittests/string_view-selftests.c, unittests/style-selftests.c,
7650         unittests/tracepoint-selftests.c, unittests/unpack-selftests.c,
7651         unittests/utils-selftests.c, unittests/xml-utils-selftests.c,
7652         utils.c, utils.h, valarith.c, valops.c, valprint.c, value.c,
7653         value.h, varobj.c, varobj.h, windows-nat.c, x86-linux-nat.c,
7654         xml-support.c, xml-support.h, xml-tdesc.h, xstormy16-tdep.c,
7655         xtensa-linux-nat.c, dwarf2read.h: Change common to gdbsupport.
7656
7657 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
7658
7659         * linespec.c (decode_digits_list_mode): Set explicit_line to a
7660         bool value.
7661         (decode_digits_ordinary): Set explicit_line field in sal.
7662         * symtab.c (skip_prologue_sal): Don't skip prologue for a
7663         symtab_and_line that was set on an explicit line number in
7664         assembler code.  Do always update the recorded symtab and line if
7665         we do skip the prologue.
7666
7667 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
7668
7669         * breakpoint.c (set_breakpoint_location_function): Remove
7670         explicit_loc parameter.
7671         (momentary_breakpoint_from_master): Update call to
7672         set_breakpoint_location_function.
7673         (add_location_to_breakpoint): Likewise.
7674
7675 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
7676
7677         * riscv-tdep.c (riscv_features_from_gdbarch_info): Don't modify
7678         required features based on default bfd type when no specific bfd
7679         is present.
7680
7681 2019-07-08  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7682
7683         * NEWS: Mention that GDB printf and eval commands can now print
7684         C-style and Ada-style convenience var strings without
7685         calling the inferior.
7686         * printcmd.c (printf_c_string): Locally print GDB internal var
7687         instead of transiting via the inferior.
7688         (printf_wide_c_string): Likewise.
7689
7690 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
7691
7692         PR breakpoints/25011
7693         * symfile.c (symbol_file_command): Call solib_create_inferior_hook.
7694
7695 2019-07-04  Tom Tromey  <tom@tromey.com>
7696
7697         PR tui/24724:
7698         * tui/tui-winsource.c (tui_clear_source_content): Update.
7699         (tui_source_window_base::set_is_exec_point_at): Fix comment.
7700         (tui_update_breakpoint_info): Update.
7701         (tui_set_exec_info_content): Update.
7702         * tui/tui-source.c (tui_set_source_content_nil): Update.
7703         * tui/tui-disasm.c (tui_set_disassem_content): Don't set
7704         has_break.
7705         * tui/tui-data.h (enum tui_bp_flag): New.
7706         (tui_bp_flags): New enum flags type.
7707         (struct tui_source_element) <break_mode>: Change type.  Rename
7708         from has_break.
7709         (TUI_BP_ENABLED, TUI_BP_DISABLED, TUI_BP_HIT)
7710         (TUI_BP_CONDITIONAL, TUI_BP_HARDWARE): Don't define.  Now enum
7711         constants.
7712         * tui/tui-winsource.h: Fix comment.
7713
7714 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
7715
7716         * aarch32-linux-nat.h (VFP_REGS_SIZE): Remove define.
7717         * aarch64-linux-nat.c (fetch_fpregs_from_thread)
7718         (store_fpregs_to_thread)
7719         (aarch64_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
7720         * arch/arm.h (IWMMXT_VEC_REGISTER_SIZE, ARM_CORE_REGS_SIZE)
7721         (ARM_FP_REGS_SIZE, ARM_VFP2_REGS_SIZE, ARM_VFP3_REGS_SIZE)
7722         (IWMMXT_REGS_SIZE): Add define.
7723         * arm-linux-nat.c (IWMMXT_REGS_SIZE): Remove define.
7724         (fetch_vfp_regs, store_vfp_regs)
7725         (arm_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
7726         * arm-tdep.c (arm_register_g_packet_guesses): Use new defines.
7727
7728 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
7729
7730         * arch/arm-get-next-pcs.c (thumb_get_next_pcs_raw): Use ARM_
7731         defines.
7732         * arch/arm-linux.c (arm_linux_sigreturn_next_pc_offset): Likewise.
7733         * arch/arm.h (INT_REGISTER_SIZE) Rename from...
7734         (ARM_INT_REGISTER_SIZE): ...to this.
7735         (ARM_FP_REGISTER_SIZE) (ARM_VFP_REGISTER_SIZE): Add define.
7736         * arm-linux-tdep.c (ARM_LINUX_JB_ELEMENT_SIZE)
7737         (ARM_LINUX_SIZEOF_GREGSET, arm_linux_supply_gregset)
7738         (arm_linux_collect_gregset, supply_nwfpe_register)
7739         (collect_nwfpe_register, arm_linux_collect_nwfpe): Use ARM_
7740         defines.
7741         * arm-linux-tdep.h (ARM_LINUX_SIZEOF_NWFPE, NWFPE_FPSR_OFFSET)
7742         (NWFPE_FPCR_OFFSET, NWFPE_TAGS_OFFSET): Likewise
7743         * arm-nbsd-tdep.c (ARM_NBSD_JB_ELEMENT_SIZE): Likewise.
7744         * arm-tdep.c (arm_push_dummy_call, arm_extract_return_value)
7745         (arm_return_in_memory, arm_store_return_value)
7746         (arm_get_longjmp_target, arm_register_g_packet_guesses)
7747         (arm_record_ld_st_multiple): Likewise.
7748         * arm-tdep.h (FP_REGISTER_SIZE, VFP_REGISTER_SIZE): Remove.
7749         * arm-wince-tdep.c (ARM_WINCE_JB_ELEMENT_SIZE): Use ARM_ defines.
7750
7751 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
7752
7753         * aarch64-linux-tdep.c (aarch64_linux_init_abi): Use
7754         AARCH64_DISPLACED_MODIFIED_INSNS.
7755         * aarch64-tdep.c (struct aarch64_displaced_step_data)
7756         (aarch64_displaced_step_copy_insn): Likewise.
7757         * aarch64-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
7758         (AARCH64_DISPLACED_MODIFIED_INSNS): ...to this.
7759         * arm-linux-tdep.c (arm_linux_cleanup_svc): Use
7760         ARM_DISPLACED_MODIFIED_INSNS.
7761         * arm-tdep.c (arm_gdbarch_init): Likewise.
7762         * arm-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
7763         (ARM_DISPLACED_MODIFIED_INSNS): ...to this.
7764         (struct arm_displaced_step_closure): Use
7765         ARM_DISPLACED_MODIFIED_INSNS.
7766
7767 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
7768
7769         * features/Makefile: Remove unused xml files.
7770         * features/aarch64.xml: Remove.
7771         * features/i386/amd64-avx-avx512-linux.xml: Remove.
7772         * features/i386/amd64-avx-avx512.xml: Remove.
7773         * features/i386/amd64-avx-linux.xml: Remove.
7774         * features/i386/amd64-avx-mpx-avx512-pku-linux.xml: Remove.
7775         * features/i386/amd64-avx-mpx-avx512-pku.xml: Remove.
7776         * features/i386/amd64-avx-mpx-linux.xml: Remove.
7777         * features/i386/amd64-avx-mpx.xml: Remove.
7778         * features/i386/amd64-avx.xml: Remove.
7779         * features/i386/amd64-linux.xml: Remove.
7780         * features/i386/amd64-mpx-linux.xml: Remove.
7781         * features/i386/amd64-mpx.xml: Remove.
7782         * features/i386/amd64.xml: Remove.
7783         * features/i386/i386-avx-avx512-linux.xml: Remove.
7784         * features/i386/i386-avx-avx512.xml: Remove.
7785         * features/i386/i386-avx-linux.xml: Remove.
7786         * features/i386/i386-avx-mpx-avx512-pku-linux.xml: Remove.
7787         * features/i386/i386-avx-mpx-avx512-pku.xml: Remove.
7788         * features/i386/i386-avx-mpx-linux.xml: Remove.
7789         * features/i386/i386-avx-mpx.xml: Remove.
7790         * features/i386/i386-avx.xml: Remove.
7791         * features/i386/i386-linux.xml: Remove.
7792         * features/i386/i386-mmx-linux.xml: Remove.
7793         * features/i386/i386-mmx.xml: Remove.
7794         * features/i386/i386-mpx-linux.xml: Remove.
7795         * features/i386/i386-mpx.xml: Remove.
7796         * features/i386/i386.xml: Remove.
7797         * features/i386/x32-avx-avx512-linux.xml: Remove.
7798         * features/i386/x32-avx-linux.xml: Remove.
7799         * features/i386/x32-linux.xml: Remove.
7800
7801 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
7802
7803         * regformats/aarch64.dat: Remove.
7804         * regformats/i386/amd64-avx-avx512-linux.dat: Remove.
7805         * regformats/i386/amd64-avx-linux.dat: Remove.
7806         * regformats/i386/amd64-avx-mpx-avx512-pku-linux.dat: Remove.
7807         * regformats/i386/amd64-avx-mpx-linux.dat: Remove.
7808         * regformats/i386/amd64-linux.dat: Remove.
7809         * regformats/i386/amd64-mpx-linux.dat: Remove.
7810         * regformats/i386/amd64.dat: Remove.
7811         * regformats/i386/i386-avx-avx512-linux.dat: Remove.
7812         * regformats/i386/i386-avx-linux.dat: Remove.
7813         * regformats/i386/i386-avx-mpx-avx512-pku-linux.dat: Remove.
7814         * regformats/i386/i386-avx-mpx-linux.dat: Remove.
7815         * regformats/i386/i386-linux.dat: Remove.
7816         * regformats/i386/i386-mmx-linux.dat: Remove.
7817         * regformats/i386/i386-mpx-linux.dat: Remove.
7818         * regformats/i386/i386.dat: Remove.
7819         * regformats/i386/x32-avx-avx512-linux.dat: Remove.
7820         * regformats/i386/x32-avx-linux.dat: Remove.
7821         * regformats/i386/x32-linux.dat: Remove.
7822
7823 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
7824
7825         * aarch64-tdep.c: Remove xml self tests.
7826         * amd64-linux-tdep.c: Likewise.
7827         * amd64-tdep.c: Likewise.
7828         * i386-linux-tdep.c: Likewise.
7829         * i386-tdep.c: Likewise.
7830
7831 2019-07-03  Pedro Alves  <palves@redhat.com>
7832
7833         PR cli/24732
7834         * cli/cli-cmds.c (struct pipe_cmd_opts): New.
7835         (pipe_cmd_option_defs): New.
7836         (make_pipe_cmd_options_def_group): New.
7837         (pipe_command): Use gdb::option::process_options.
7838         (pipe_command_completer): New function.
7839         (_initialize_cli_cmds): Install completer for "pipe" command.
7840
7841 2019-07-03  Pedro Alves  <palves@redhat.com>
7842
7843         * cli/cli-option.c (union option_value) <string>: New field.
7844         (struct option_def_and_value): Add ctor, move ctor, dtor and
7845         use DISABLE_COPY_AND_ASSIGN.
7846         (option_def_and_value::clear_value): New.
7847         (parse_option, save_option_value_in_ctx, get_val_type_str)
7848         (add_setshow_cmds_for_options): Handle var_string.
7849         * cli-option.h (union option_def::var_address) <string>: New
7850         field.
7851         (struct string_option_def): New.
7852         * maint-test-options.c (struct test_options_opts): Add default
7853         ctor and use DISABLE_COPY_AND_ASSIGN.
7854         <string_opt>: New field.
7855         (test_options_opts::~test_options_opts): New.
7856         (test_options_opts::dump): Also dump "-string".
7857         (test_options_option_defs): Install "string.
7858
7859 2019-07-03  Pedro Alves  <palves@redhat.com>
7860
7861         * cli/cli-option.c (parse_option) <var_enum>: Don't return an
7862         option_value with a null enumeration.
7863         (complete_options): Save the option values in the context.
7864         (save_option_value_in_ctx): New, factored out from ...
7865         (process_options): ... here.
7866         * cli/cli-utils.c (get_ulongest): Don't advance PP until the end
7867         of the function.
7868         * maint-test-options.c (test_options_opts::dump): New, factored
7869         out from ...
7870         (maintenance_test_options_command_mode): ... here.
7871         (maintenance_test_options_command_completion_result): Delete.
7872         (maintenance_test_options_command_completion_text): Update
7873         comment.
7874         (maintenance_show_test_options_completion_result): Change
7875         prototype.  Just print
7876         maintenance_test_options_command_completion_text.
7877         (save_completion_result): New.
7878         (maintenance_test_options_completer_mode): Pass options context to
7879         complete_options, and then save a dump.
7880         (_initialize_maint_test_options): Use add_cmd to install "maint
7881         show test-options-completion-result".
7882
7883 2019-07-03  Pedro Alves  <palves@redhat.com>
7884
7885         * NEWS (New commands): Mention "with" and "maint with".
7886         * cli/cli-cmds.c (with_command_1, with_command_completer_1)
7887         (with_command, with_command_completer): New.
7888         (pipe_command): Adjust to new repeat_previous
7889         interface.
7890         (_initialize_cli_cmds): Install the "with" command and its "w"
7891         alias.
7892         * cli/cli-cmds.h (with_command_1, with_command_completer_1): New
7893         declarations.
7894         * cli/cli-setshow.c (parse_cli_var_uinteger)
7895         (parse_cli_var_zuinteger_unlimited, do_set_command): Handle empty
7896         argument strings for all var_types.
7897         (get_setshow_command_value_string): New, factored out from ...
7898         (do_show_command): ... this.
7899         * cli/cli-setshow.h: Include <string>.
7900         (get_setshow_command_value_string): Declare.
7901         * command.h (repeat_previous): Now returns const char *.  Adjust
7902         comment.
7903         * maint.c: Include "cli/cli-cmds.h".
7904         (maintenance_with_cmd, maintenance_with_cmd_completer): New.
7905         (_initialize_maint_cmds): Register the "maintenance with" command.
7906         * top.c (repeat_previous): Move bits from pipe_command here:
7907         Return the saved command line, if any; error out if there's no
7908         command to relaunch.
7909
7910 2019-07-03  Pedro Alves  <palves@redhat.com>
7911
7912         * NEWS (New commands): Mention "maint set/show test-settings"
7913         instead of "maint test-settings".
7914         * maint-test-settings.c (maintenance_test_settings_list): Delete.
7915         (maintenance_test_settings_set_list): Rename to ...
7916         (maintenance_set_test_settings_list): ... this.
7917         (maintenance_test_settings_show_list): Rename to  ...
7918         (maintenance_show_test_settings_list): ... this.
7919         (maintenance_test_settings_cmd): Delete.
7920         (maintenance_test_settings_set_cmd): ...
7921         (maintenance_set_test_settings_cmd): ... this.
7922         (maintenance_test_settings_show_cmd): ...
7923         (maintenance_show_test_settings_cmd): ... this.
7924         (maintenance_test_settings_show_value_cmd):
7925         (maintenance_show_test_settings_value_cmd): ... this.
7926         (_initialize_maint_test_settings): No longer install the "maint
7927         test-settings" prefix command.  Rename "maint test-settings set"
7928         to "maint set test-settings", and "maint test-settings show" to
7929         "maint show test-settings".  Adjust all subcommands.
7930
7931 2019-07-03  Pedro Alves  <palves@redhat.com>
7932
7933         * maint-test-settings.c: Fix file's intro comment.  Replace all
7934         references to "test-options" with references to "test-settings",
7935         in comments.
7936
7937 2019-07-03  Pedro Alves  <palves@redhat.com>
7938
7939         * maint-test-settings.c (maintenance_test_settings_xxx)
7940         (maintenance_test_settings_yyy, maintenance_test_settings_zzz):
7941         New.
7942         (maintenance_test_settings_enums): Use them.
7943         (maintenance_test_settings_enum): Default to
7944         maintenance_test_settings_xxx.
7945         (_initialize_maint_test_settings): Initialize
7946         MAINTENANCE_TEST_SETTINGS_FILENAME.
7947
7948 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
7949
7950         * breakpoint.h (remove_breakpoints_inf): Change return type to
7951         void, move function documentation here.
7952         * breakpoint.c (remove_breakpoints_inf): Change return type to
7953         void, move function documentation to header.
7954
7955 2019-07-02  Pedro Alves  <palves@redhat.com>
7956
7957         * NEWS (Completion improvements): Mention "info threads".
7958         * thread.c (struct info_threads_opts, info_threads_option_defs)
7959         (make_info_threads_options_def_group): New.
7960         (info_threads_command): Use gdb::option::process_options.
7961         (info_threads_command_completer): New.
7962         (_initialize_thread): Use gdb::option::build_help to build the
7963         help text for "info threads".
7964
7965 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
7966
7967         * defs.h (generic_load): Move from here...
7968         * symfile.h (generic_load): ... to here.  Rename name parameter
7969         to args.
7970         * symfile.c (generic_load): Add comment.
7971
7972 2019-07-01  Tom Tromey  <tromey@adacore.com>
7973
7974         * dwarf2read.c
7975         (dw2_debug_names_iterator::find_vec_in_debug_names): Hoist
7976         declaration of without_params.  Fix formatting.
7977
7978 2019-07-01  Tom Tromey  <tromey@adacore.com>
7979
7980         * ada-exp.y (find_primitive_type): Update.
7981         * ada-lang.h (ada_lookup_symbol): Update.
7982         * ada-lang.c (ada_lookup_symbol): Remove "is_a_field_of_this"
7983         parameter.
7984         (ada_lookup_encoded_symbol, ada_lookup_symbol_nonlocal): Update.
7985
7986 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
7987
7988         PR breakpoints/24541
7989         * gdbarch.c: Regenerate.
7990         * gdbarch.h: Regenerate.
7991         * gdbarch.sh: Add 'stap_adjust_register'.
7992         * i386-tdep.c: Include '<unordered_set>'.
7993         (i386_stap_adjust_register): New function.
7994         (i386_elf_init_abi): Register 'i386_stap_adjust_register'.
7995         * stap-probe.c (stap_parse_register_operand): Call
7996         'gdbarch_stap_adjust_register'.
7997
7998 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
7999
8000         PR python/24742
8001         https://bugzilla.redhat.com/show_bug.cgi?id=1723564
8002         * python/python.c (do_start_initialization): Use 'xmalloc'
8003         instead of 'PyMem_Malloc'.
8004
8005 2019-06-28  Tom Tromey  <tromey@adacore.com>
8006
8007         * dwarf2read.c (partial_die_info::read): Prefer the linkage name
8008         for Ada.
8009
8010 2019-06-27  Tom Tromey  <tromey@adacore.com>
8011
8012         * arm-tdep.c (arm_objfile_data_key): Move lower.  Change type to
8013         objfile_key.
8014         (arm_find_mapping_symbol, arm_record_special_symbol)
8015         (_initialize_arm_tdep): Update.
8016         (arm_objfile_data_free): Remove.
8017
8018 2019-06-27  Tom Tromey  <tromey@adacore.com>
8019
8020         * cp-valprint.c (cp_print_value_fields): Pass opts, not options,
8021         to cp_print_static_field.
8022
8023 2019-06-26  Tom Tromey  <tromey@adacore.com>
8024
8025         * minsyms.c (lookup_minimal_symbol_solib_trampoline): Remove.
8026         * minsyms.h (lookup_minimal_symbol_solib_trampoline): Don't
8027         declare.
8028
8029 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
8030
8031         * features/aarch64-core.c (create_feature_aarch64_core):
8032         Regenerate.
8033         * features/aarch64-core.xml: Add cpsr flags.
8034
8035 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
8036
8037         * arm-tdep.c (arm_gnu_triplet_regexp): New function.
8038         (arm_gdbarch_init): Add arm_gnu_triplet_regexp.
8039
8040 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
8041
8042         * arm-tdep.c (struct arm_per_objfile) <section_maps_sorted>: New
8043         field.
8044         (arm_find_mapping_symbol): Sort mapping symbol vectors on first
8045         use.
8046         (arm_record_special_symbol): Don't insert new symbol in sorted
8047         position, push it at the end.
8048
8049 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
8050
8051         * arm-tdep.c (struct arm_mapping_symbol) (operator <): New.
8052         (arm_mapping_symbol_s): Remove.
8053         (DEF_VEC_O(arm_mapping_symbol_s)): Remove.
8054         (arm_mapping_symbol_vec): New typedef.
8055         (struct arm_per_objfile): Add constructor.
8056         <section_maps>: Change type to
8057         std::unique_ptr<arm_mapping_symbol_vec[]>.
8058         (arm_compare_mapping_symbols): Remove.
8059         (arm_find_mapping_symbol): Adjust to section_maps type change.
8060         (arm_objfile_data_free): Call delete on arm_per_objfile.
8061         (arm_record_special_symbol): Adjust to section_maps type change.
8062         Allocate arm_per_objfile with new.
8063
8064 2019-06-25  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8065
8066         * cli/cli-cmds.c (alias_command): Compare the alias prefix
8067         with the command prefix.
8068
8069 2019-06-25  Tom Tromey  <tom@tromey.com>
8070
8071         * tui/tui-wingeneral.c (tui_delete_win): Remove "return".
8072         * tui/tui-data.c (~tui_gen_win_info): Remove "if".
8073
8074 2019-06-25  Tom Tromey  <tom@tromey.com>
8075
8076         * tui/tui-layout.c (init_and_make_win): Assert on unrecognized
8077         type.
8078         * tui/tui-data.h (struct tui_gen_win_info): Make constructor
8079         protected.
8080
8081 2019-06-25  Tom Tromey  <tom@tromey.com>
8082
8083         * tui/tui-winsource.c
8084         (tui_source_window_base::set_is_exec_point_at): Add check against
8085         LOA_ADDRESS.
8086
8087 2019-06-25  Tom Tromey  <tom@tromey.com>
8088
8089         * tui/tui-source.c (tui_set_source_content): Don't check before
8090         xfree.
8091         * tui/tui-disasm.c (tui_disassemble): Don't check before xfree.
8092
8093 2019-06-25  Tom Tromey  <tom@tromey.com>
8094
8095         * tui/tui-winsource.h (tui_update_source_window_as_is)
8096         (tui_alloc_source_buffer, tui_line_is_displayed)
8097         (tui_addr_is_displayed): Change type of win_info.
8098         * tui/tui-winsource.c (tui_update_source_window_as_is)
8099         (tui_clear_source_content, tui_show_source_line)
8100         (tui_show_source_content, tui_source_window_base::refill)
8101         (tui_source_window_base::set_is_exec_point_at)
8102         (tui_source_window_base::set_is_exec_point_at)
8103         (tui_update_breakpoint_info, tui_set_exec_info_content): Update.
8104         (tui_alloc_source_buffer, tui_line_is_displayed)
8105         (tui_addr_is_displayed): Change type of win_info.  Update.
8106         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
8107         (tui_source_window_base::do_make_visible_with_new_height):
8108         Update.
8109         * tui/tui-source.c (tui_set_source_content)
8110         (tui_set_source_content_nil)
8111         (tui_source_window::do_scroll_vertical): Update.
8112         * tui/tui-layout.c (show_layout): Update.
8113         * tui/tui-disasm.c (tui_set_disassem_content)
8114         (tui_disasm_window::do_scroll_vertical): Update.
8115         * tui/tui-data.h (tui_win_content): Remove.
8116         (struct tui_gen_win_info) <content, content_size>: Remove.
8117         (struct tui_source_element): Add initializers and destructor.
8118         (union tui_which_element, struct tui_win_element): Remove.
8119         (struct tui_source_window_base) <content>: New field.
8120         (struct tui_data_window): Remove destructor.
8121         (tui_alloc_content, tui_free_win_content)
8122         (tui_free_all_source_wins_content): Don't declare.
8123         * tui/tui-data.c (tui_initialize_static_data): Update.
8124         (init_content_element, tui_alloc_content): Remove.
8125         (~tui_gen_win_info): Update.
8126         (~tui_data_window, tui_free_all_source_wins_content)
8127         (tui_free_win_content, free_content, free_content_elements):
8128         Remove.
8129
8130 2019-06-25  Tom Tromey  <tom@tromey.com>
8131
8132         * tui/tui-winsource.h (tui_clear_source_content)
8133         (tui_erase_source_content, tui_show_source_content): Change type
8134         of win_info.
8135         * tui/tui-winsource.c (tui_clear_source_content)
8136         (tui_erase_source_content, tui_show_source_content): Change type
8137         of win_info.
8138         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
8139         * tui/tui-source.h (tui_set_source_content_nil): Change type of
8140         win_info.
8141         * tui/tui-source.c (tui_set_source_content_nil): Change type of
8142         win_info.
8143         * tui/tui-layout.c (show_source_or_disasm_and_command): Update.
8144
8145 2019-06-25  Tom Tromey  <tom@tromey.com>
8146
8147         * tui/tui-winsource.c (tui_clear_source_content)
8148         (tui_source_window_base::set_is_exec_point_at): Update.
8149         * tui/tui-source.c (tui_set_source_content_nil): Update.
8150         * tui/tui-data.h (struct tui_source_element) <is_exec_point>: Now
8151         a bool.
8152         * tui/tui-data.c (init_content_element): Update.
8153
8154 2019-06-25  Tom Tromey  <tom@tromey.com>
8155
8156         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Update.
8157         * tui/tui-win.c (make_invisible_and_set_new_height): Update.
8158         * tui/tui-layout.c (init_and_make_win): Update.
8159         * tui/tui.h (enum tui_win_type): Update.
8160         * tui/tui-data.h (tui_win_is_auxiliary): Rename from
8161         tui_win_is_auxillary.
8162         * tui/tui-data.c (tui_win_is_auxiliary): Rename from
8163         tui_win_is_auxillary.
8164
8165 2019-06-25  Tom Tromey  <tom@tromey.com>
8166
8167         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Update.
8168         * tui/tui-windata.c (tui_data_window::first_data_item_displayed)
8169         (tui_delete_data_content_windows, tui_display_all_data)
8170         (tui_data_window::do_scroll_vertical, tui_display_data_from):
8171         Update.
8172         * tui/tui-win.c (tui_data_window::set_new_height): Simplify.
8173         * tui/tui-regs.c (tui_last_regs_line_no)
8174         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
8175         (tui_show_registers): Update.
8176         (tui_show_register_group): Return void.  Update.
8177         (tui_display_registers_from, tui_display_reg_element_at_line)
8178         (tui_display_registers_from_line, tui_check_register_values):
8179         Update.
8180         * tui/tui-data.h (union tui_which_element) <data_window>: Remove
8181         member.
8182         (struct tui_data_window) <regs_content>: Now a std::vector.
8183         <regs_content_count>: Remove.
8184         (tui_add_content_elements, tui_free_data_content): Don't declare.
8185         * tui/tui-data.c (tui_data_window::clear_detail): Update.
8186         (init_content_element): Remove DATA_WIN case.  Add assert.
8187         (tui_add_content_elements): Remove.
8188         (tui_data_window): Update.
8189         (tui_free_data_content): Remove.
8190         (free_content_elements): Remove DATA_WIN case.
8191
8192 2019-06-25  Tom Tromey  <tom@tromey.com>
8193
8194         * tui/tui-data.c (tui_data_item_window): Update.
8195         * tui/tui-windata.h (tui_check_data_values): Don't declare.
8196         * tui/tui-windata.c (tui_display_all_data)
8197         (tui_display_data_from_line): Update.
8198         (tui_check_data_values): Remove.
8199         * tui/tui-regs.c (tui_show_register_group)
8200         (tui_display_reg_element_at_line): Update.
8201         * tui/tui-hooks.c (tui_register_changed)
8202         (tui_refresh_frame_and_register_information): Call
8203         tui_check_register_values.
8204         * tui/tui-data.h (struct tui_data_window) <data_content,
8205         data_content_count, data_type>: Remove.
8206         (enum tui_data_type): Remove.
8207
8208         * tui/tui-data.c (tui_data_window::clear_detail)
8209         (~tui_data_window): Update.
8210
8211 2019-06-25  Tom Tromey  <tom@tromey.com>
8212
8213         * tui/tui-windata.h (tui_first_data_item_displayed): Don't
8214         declare.
8215         * tui/tui-windata.c (tui_data_window::first_data_item_displayed):
8216         Rename from tui_first_data_item_displayed.  Update.
8217         (tui_data_window::refresh_all)
8218         (tui_data_window::do_scroll_vertical): Update.
8219         * tui/tui-data.h (struct tui_data_window)
8220         <first_data_item_displayed>: Declare new method.
8221
8222 2019-06-25  Tom Tromey  <tom@tromey.com>
8223
8224         * tui/tui-data.h (tui_init_generic_part): Don't declare.
8225         * tui/tui-data.c (tui_init_generic_part): Remove, moving
8226         contents...
8227         (tui_initialize_static_data): ...here.
8228
8229 2019-06-25  Tom Tromey  <tom@tromey.com>
8230
8231         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
8232         (tui_display_registers_from, tui_check_register_values): Update.
8233         (tui_display_register): Remove win_info parameter; update.
8234         (tui_get_register): Change type of parameters.
8235         * tui/tui-data.h (struct tui_data_element): Remove.
8236         (union tui_which_element) <data>: Remove.
8237         <data_window>: Change type.
8238         (struct tui_data_item_window): New.
8239         * tui/tui-data.c (init_content_element): Remove DATA_ITEM_WIN
8240         case.  Add assert.
8241         (~tui_data_item_window): New destructor.
8242         (free_content_elements): Remove DATA_ITEM_WIN case.
8243
8244 2019-06-25  Tom Tromey  <tom@tromey.com>
8245
8246         * tui/tui.h (enum tui_win_type) <MAX_WINDOWS, UNDEFINED_WIN>:
8247         Remove.
8248
8249 2019-06-25  Tom Tromey  <tom@tromey.com>
8250
8251         * tui/tui-data.h (struct tui_command_element): Remove.
8252         (union tui_which_element) <command>: Remove.
8253         * tui/tui-data.c (init_content_element): Remove CMD_WIN case.  Add
8254         assert.
8255         (free_content_elements): Remove CMD_WIN case.
8256
8257 2019-06-25  Tom Tromey  <tom@tromey.com>
8258
8259         * tui/tui-layout.c (tui_set_layout): Update.
8260         * tui/tui-data.h (struct tui_layout_def) <split>: Remove.
8261         * tui/tui-data.c (layout_def): Update.
8262
8263 2019-06-25  Tom Tromey  <tom@tromey.com>
8264
8265         * tui/tui-wingeneral.c (tui_refresh_all): Update.
8266         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
8267         (tui_source_window_base::set_new_height): Update.
8268         * tui/tui-stack.c (tui_make_status_line): Change parameter type.
8269         Update.
8270         (tui_set_locator_fullname, tui_set_locator_info)
8271         (tui_show_frame_info): Update.
8272         * tui/tui-source.c (tui_set_source_content)
8273         (tui_source_is_displayed): Update.
8274         * tui/tui-layout.c (show_source_disasm_command, show_data)
8275         (show_source_or_disasm_and_command): Update.
8276         * tui/tui-disasm.c (tui_set_disassem_content)
8277         (tui_get_begin_asm_address): Update.
8278         * tui/tui-data.h (struct tui_locator_element): Remove.
8279         (union tui_which_element) <locator>: Remove.
8280         (struct tui_locator_window): New.
8281         (tui_locator_win_info_ptr): Change return type.
8282         * tui/tui-data.c (_locator): Change type.
8283         (tui_locator_win_info_ptr): Change return type.
8284         (init_content_element): Remove LOCATOR_WIN case.  Add assert.
8285         (tui_alloc_content): Add assert.
8286
8287 2019-06-25  Tom Tromey  <tom@tromey.com>
8288
8289         * tui/tui-winsource.c
8290         (tui_exec_info_window::maybe_allocate_content): New method.
8291         (tui_set_exec_info_content, tui_show_exec_info_content): Update.
8292         * tui/tui-layout.c (init_and_make_win): Add EXEC_INFO_WIN case.
8293         (make_source_or_disasm_window): Add cast.
8294         * tui/tui-data.h (union tui_which_element) <simple_string>:
8295         Remove.
8296         (struct tui_source_info): New.
8297         (struct tui_source_window_base) <execution_info>: Change type.
8298         * tui/tui-data.c (init_content_element): Remove EXEC_INFO_WIN
8299         case, and add assert.
8300         (tui_alloc_content): Add assert.
8301
8302 2019-06-25  Tom Tromey  <tom@tromey.com>
8303
8304         * tui/tui-data.h (tui_alloc_win_info): Don't declare.
8305         * tui/tui-layout.c (init_and_make_win): Use "new" directly.
8306         * tui/tui-data.c (tui_alloc_win_info): Remove.
8307
8308 2019-06-25  Tom Tromey  <tom@tromey.com>
8309
8310         * tui/tui-win.c (tui_set_win_focus_to): Don't check window type.
8311         * tui/tui-wingeneral.c (tui_unhighlight_win): Check
8312         can_highlight.
8313
8314 2019-06-25  Tom Tromey  <tom@tromey.com>
8315
8316         * tui/tui-win.c (tui_source_window_base::update_tab_width): Call
8317         make_visible_with_new_height method.
8318         (tui_win_info::make_visible_with_new_height): New method.
8319         (tui_source_window_base::do_make_visible_with_new_height)
8320         (tui_data_window::do_make_visible_with_new_height)
8321         (tui_cmd_window::do_make_visible_with_new_height): New methods.
8322         (make_visible_with_new_height): Remove.
8323         (tui_resize_all, tui_adjust_win_heights): Use
8324         make_visible_with_new_height method.
8325         * tui/tui-data.h (struct tui_win_info)
8326         <do_make_visible_with_new_height, make_visible_with_new_height>:
8327         New methods.
8328         (struct tui_source_window_base, struct tui_data_window)
8329         (struct tui_cmd_window) <do_make_visible_with_new_height>: New
8330         methods.
8331
8332 2019-06-25  Tom Tromey  <tom@tromey.com>
8333
8334         * tui/tui-win.c (tui_source_window_base::update_tab_width): New
8335         method.
8336         (update_tab_width): Call update_tab_width method.
8337         * tui/tui-data.h (struct tui_win_info)
8338         (struct tui_source_window_base) <update_tab_width>: New methods.
8339
8340 2019-06-25  Tom Tromey  <tom@tromey.com>
8341
8342         * tui/tui-wingeneral.h (tui_make_window): Change type of "box_it"
8343         parameter.
8344         * tui/tui-wingeneral.c (tui_make_window): Change type of "box_it"
8345         parameter.
8346         (tui_gen_win_info::make_visible): Update.
8347         * tui/tui-layout.c (init_and_make_win): Change type of "box_it"
8348         parameter.
8349         * tui/tui-data.h (enum tui_box): New enum.
8350         (BOX_WINDOW, DONT_BOX_WINDOW): Remove defines.
8351
8352 2019-06-25  Tom Tromey  <tom@tromey.com>
8353
8354         * tui/tui-layout.c (make_source_or_disasm_window): Always use
8355         init_and_make_win for EXEC_INFO_WIN.
8356         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>: No
8357         longer inline.
8358         (struct tui_win_info) <~tui_win_info>: Inline.
8359         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
8360         Don't declare.
8361         * tui/tui-data.c (source_win, disasm_win): Remove globals.
8362         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
8363         Remove.
8364         (tui_initialize_static_data): Update.
8365         (~tui_gen_win_info): Handle more cleanup here.
8366         (~tui_source_window_base): Delete "execution_info".
8367         (~tui_win_info): Move code to ~tui_gen_win_info; remove.
8368
8369 2019-06-25  Tom Tromey  <tom@tromey.com>
8370
8371         * tui/tui-layout.c (make_command_window): Don't set
8372         can_highlight.
8373         (show_source_disasm_command): Call the reset method.
8374         (show_data): Don't set can_highlight.  Call the reset method.
8375         (tui_gen_win_info::reset): Rename from init_gen_win_info
8376         (init_and_make_win): Simplify.  Return tui_gen_win_info.
8377         (show_source_or_disasm_and_command): Call the reset method.
8378         * tui/tui-data.h (struct tui_gen_win_info) <reset>: New method.
8379         (struct tui_cmd_window): Set can_highlight.
8380
8381 2019-06-25  Tom Tromey  <tom@tromey.com>
8382
8383         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Rename
8384         from make_visible.
8385         (tui_make_visible, tui_make_invisible): Rewrite.
8386         (tui_win_info::make_visible): Remove.
8387         (tui_source_window_base::make_visible): Update.
8388         * tui/tui-data.h (struct tui_gen_win_info) <make_visible>: New
8389         method.  Moved from...
8390         (struct tui_win_info) <make_visible>: ...here.
8391
8392 2019-06-25  Tom Tromey  <tom@tromey.com>
8393
8394         * tui/tui-winsource.c
8395         (tui_source_window_base::do_scroll_horizontal): Remove direction
8396         parameter.
8397         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Remove
8398         direction parameter.
8399         * tui/tui-win.c (tui_win_info::forward_scroll)
8400         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
8401         (tui_win_info::right_scroll): Update.
8402         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Remove
8403         direction parameter.
8404         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Remove
8405         direction parameter.
8406         * tui/tui-data.h (enum tui_scroll_direction): Remove.
8407         (struct tui_win_info) <do_scroll_vertical, do_scroll_horizontal>:
8408         Remove direction parameter.
8409         (struct tui_source_window_base, struct tui_source_window)
8410         (struct tui_disasm_window, struct tui_data_window)
8411         (struct tui_cmd_window): Update.
8412
8413 2019-06-25  Tom Tromey  <tom@tromey.com>
8414
8415         * tui/tui-winsource.h (tui_set_exec_info_content)
8416         (tui_show_exec_info_content, tui_erase_exec_info_content)
8417         (tui_clear_exec_info_content, tui_update_exec_info): Change
8418         argument to tui_source_window_base.
8419         * tui/tui-winsource.c (tui_set_exec_info_content)
8420         (tui_show_exec_info_content, tui_erase_exec_info_content)
8421         (tui_clear_exec_info_content, tui_update_exec_info): Change
8422         argument to tui_source_window_base.
8423
8424 2019-06-25  Tom Tromey  <tom@tromey.com>
8425
8426         * tui/tui-winsource.h (tui_set_exec_info_content): Return void.
8427         * tui/tui-winsource.c (tui_set_exec_info_content): Return void.
8428
8429 2019-06-25  Tom Tromey  <tom@tromey.com>
8430
8431         * tui/tui-winsource.c (tui_set_exec_info_content): Remove NULL
8432         check.
8433
8434 2019-06-25  Tom Tromey  <tom@tromey.com>
8435
8436         * tui/tui-winsource.h (tui_alloc_source_buffer): Change return
8437         type to void.
8438         * tui/tui-winsource.c (tui_alloc_source_buffer): Change return
8439         type to void.
8440         * tui/tui-source.c (tui_set_source_content): Update.
8441         * tui/tui-disasm.c (tui_set_disassem_content): Update.
8442
8443 2019-06-25  Tom Tromey  <tom@tromey.com>
8444
8445         * tui/tui-win.c (window_name_completer, tui_set_focus)
8446         (tui_all_windows_info): Use name method.
8447         * tui/tui-data.h (struct tui_gen_win_info)
8448         (struct tui_source_window, struct tui_disasm_window)
8449         (struct tui_data_window, struct tui_cmd_window) <name>: New
8450         method.
8451         (tui_win_name): Don't declare.
8452         * tui/tui-data.c (tui_partial_win_by_name): Use name method.
8453         (tui_win_name): Remove.
8454
8455 2019-06-25  Tom Tromey  <tom@tromey.com>
8456
8457         * tui/tui-winsource.h (tui_update_source_window)
8458         (tui_update_source_window_as_is): Change parameter type.
8459         * tui/tui-winsource.c (tui_update_source_window): Change win_info
8460         to be a tui_source_window_base.
8461         (tui_update_source_window_as_is): Likewise.
8462         * tui/tui-win.c (make_visible_with_new_height): Update.
8463
8464 2019-06-25  Tom Tromey  <tom@tromey.com>
8465
8466         * tui/tui-winsource.c (tui_erase_source_content)
8467         (tui_show_source_content, tui_show_exec_info_content)
8468         (tui_erase_exec_info_content): Use refresh_window method.
8469         * tui/tui-wingeneral.h (tui_refresh_win): Don't declare.
8470         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Rename
8471         from tui_refresh_win.
8472         (tui_data_window::refresh_window): New method.
8473         (tui_win_info::refresh, tui_source_window_base::refresh)
8474         (tui_refresh_all): Use refresh_window method.
8475         * tui/tui-stack.c (tui_show_locator_content): Call refresh_window
8476         method.
8477         * tui/tui-regs.c (tui_display_register): Call refresh_window
8478         method.
8479         * tui/tui-layout.c (show_source_disasm_command)
8480         (show_source_or_disasm_and_command): Call refresh_window method.
8481         * tui/tui-data.h (struct tui_gen_win_info)
8482         (struct tui_data_window, struct tui_cmd_window) <refresh_window>:
8483         New method.
8484
8485 2019-06-25  Tom Tromey  <tom@tromey.com>
8486
8487         * tui/tui.c (tui_rl_other_window, tui_enable)
8488         (tui_is_window_visible, tui_get_command_dimension): Update.
8489         * tui/tui-winsource.c (tui_update_source_window_as_is)
8490         (tui_clear_source_content, tui_erase_source_content)
8491         (tui_show_source_line, tui_source_window_base::refill)
8492         (tui_source_window_base::do_scroll_horizontal)
8493         (tui_source_window_base::set_is_exec_point_at)
8494         (tui_update_breakpoint_info, tui_set_exec_info_content)
8495         (tui_alloc_source_buffer, tui_line_is_displayed)
8496         (tui_addr_is_displayed): Update.
8497         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
8498         (tui_check_and_display_highlight_if_needed)
8499         (tui_win_info::make_visible, tui_win_info::refresh)
8500         (tui_refresh_all): Update.
8501         * tui/tui-windata.c (tui_first_data_item_displayed)
8502         (tui_delete_data_content_windows, tui_erase_data_content)
8503         (tui_display_all_data, tui_data_window::refresh_all)
8504         (tui_check_data_values): Update.
8505         * tui/tui-win.c (window_name_completer, tui_update_gdb_sizes)
8506         (tui_set_win_focus_to, tui_win_info::forward_scroll)
8507         (tui_win_info::backward_scroll, tui_refresh_all_win)
8508         (tui_resize_all, tui_set_focus, tui_all_windows_info)
8509         (update_tab_width, tui_set_win_height, tui_adjust_win_heights)
8510         (tui_source_window_base::set_new_height)
8511         (tui_data_window::set_new_height)
8512         (make_invisible_and_set_new_height)
8513         (make_visible_with_new_height, new_height_ok)
8514         (parse_scrolling_args): Update.
8515         * tui/tui-stack.c (tui_show_frame_info): Update.
8516         * tui/tui-source.c (tui_set_source_content)
8517         (tui_set_source_content_nil, tui_source_is_displayed)
8518         (tui_source_window::do_scroll_vertical): Update.
8519         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
8520         (tui_display_registers_from, tui_display_reg_element_at_line)
8521         (tui_check_register_values, tui_reg_command): Update.
8522         * tui/tui-layout.c (tui_default_win_height)
8523         (show_source_disasm_command, show_data, init_and_make_win)
8524         (show_source_or_disasm_and_command): Update.
8525         * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
8526         (tui_redisplay_readline, tui_mld_flush)
8527         (tui_mld_erase_entire_line, tui_mld_getc, tui_cont_sig)
8528         (tui_getc): Update.
8529         * tui/tui-disasm.c (tui_set_disassem_content)
8530         (tui_disasm_window::do_scroll_vertical): Update.
8531         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>:
8532         Now virtual.
8533         (struct tui_win_info): Derive from tui_gen_win_info.
8534         <~tui_win_info>: Mark as override.
8535         <generic>: Remove member.
8536         * tui/tui-data.c (tui_cmd_window::clear_detail, tui_next_win)
8537         (tui_prev_win, tui_partial_win_by_name, tui_win_info)
8538         (~tui_data_window, ~tui_win_info)
8539         (tui_free_all_source_wins_content): Update.
8540         * tui/tui-command.c (tui_refresh_cmd_win): Update.
8541
8542 2019-06-25  Tom Tromey  <tom@tromey.com>
8543
8544         * tui/tui-layout.c (init_and_make_win): Use new.
8545         * tui/tui-data.h (struct tui_gen_win_info): Add constructor,
8546         destructor, initializers.
8547         (tui_alloc_generic_win_info): Don't declare.
8548         * tui/tui-data.c (_locator): Add argument to constructor.
8549         (source_win, disasm_win): New globals.
8550         (exec_info): Remove.
8551         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
8552         Update.
8553         (tui_alloc_generic_win_info): Remove.
8554         (init_content_element): Use new.
8555         (tui_win_info::tui_win_info): Update.
8556         (free_content_elements) <case DATA_WIN>: Use delete.
8557
8558 2019-06-25  Tom Tromey  <tom@tromey.com>
8559
8560         * tui/tui-wingeneral.c (tui_refresh_win): Update.
8561         * tui/tui-windata.c (tui_first_data_item_displayed)
8562         (tui_delete_data_content_windows): Update.
8563         * tui/tui-win.c (tui_data_window::set_new_height): Update.
8564         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
8565         (tui_display_registers_from, tui_check_register_values): Update.
8566         * tui/tui-data.h (union tui_which_element) <data_window>: Now a
8567         pointer.
8568         * tui/tui-data.c (init_content_element): Update.  Allocate the new
8569         window.
8570         (tui_free_data_content): Update.
8571         (free_content_elements) <case DATA_WIN>: Free the window.
8572
8573 2019-06-25  Tom Tromey  <tom@tromey.com>
8574
8575         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win):
8576         Update.
8577         * tui/tui-layout.c (make_command_window)
8578         (show_source_disasm_command, show_data, init_and_make_win)
8579         (show_source_or_disasm_and_command): Update.
8580         * tui/tui-data.h (struct tui_win_info) <set_highlight>: New
8581         method.
8582         <can_highight, is_highlighted>: Now bool.
8583         (tui_set_win_highlight): Don't declare.
8584         * tui/tui-data.c (tui_set_win_highlight): Remove.
8585
8586 2019-06-25  Tom Tromey  <tom@tromey.com>
8587
8588         * tui/tui-wingeneral.c (make_visible): Remove check of window
8589         type.
8590
8591 2019-06-25  Tom Tromey  <tom@tromey.com>
8592
8593         * tui/tui-win.c (tui_win_info::max_height)
8594         (tui_cmd_window::max_height): New methods.
8595         (new_height_ok): Call max_height.
8596         * tui/tui-data.h (struct tui_win_info, struct tui_cmd_window)
8597         <max_height>: New method.
8598
8599 2019-06-25  Tom Tromey  <tom@tromey.com>
8600
8601         * tui/tui-win.c (tui_source_window_base::set_new_height)
8602         (tui_data_window::set_new_height): New methods.
8603         (make_invisible_and_set_new_height): Call set_new_height method.
8604         * tui/tui-data.h (struct tui_win_info)
8605         (struct tui_source_window_base, struct tui_data_window)
8606         <set_new_height>: New method.
8607
8608 2019-06-25  Tom Tromey  <tom@tromey.com>
8609
8610         * tui/tui.c (tui_rl_other_window): Call the refresh_all method.
8611         * tui/tui-windata.c (tui_data_window::refresh_all): Rename from
8612         tui_refresh_data_win.
8613         * tui/tui-win.c (tui_source_window_base::refresh_all): New
8614         method.
8615         (tui_refresh_all_win): Call the refresh_all method.
8616         (tui_set_focus): Likewise.
8617         * tui/tui-data.h (struct tui_win_info) <refresh_all>: New method.
8618         (struct tui_source_window_base, struct tui_data_window) <refresh>:
8619         Likewise.
8620
8621 2019-06-25  Tom Tromey  <tom@tromey.com>
8622
8623         * tui/tui-winsource.h (tui_refill_source_window)
8624         (tui_set_is_exec_point_at): Don't declare.
8625         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
8626         (tui_source_window_base::refill): Rename from
8627         tui_refill_source_window.
8628         (tui_source_window_base::do_scroll_horizontal): Update.
8629         (tui_source_window_base::set_is_exec_point_at): Rename from
8630         tui_set_is_exec_point_at.
8631         (tui_update_all_breakpoint_info): Update.
8632         * tui/tui-stack.c (tui_show_frame_info): Update.
8633         * tui/tui-layout.c (show_data): Add cast.
8634         * tui/tui-hooks.c (tui_redisplay_source): Call refill method.
8635         * tui/tui-data.h (struct tui_source_window_base) <refill,
8636         set_is_exec_point_at>: New methods.
8637         (tui_source_windows, tui_add_to_source_windows): Update types.
8638         (tui_add_to_source_windows): Remove redundant declaration.
8639         * tui/tui-data.c (source_windows): Store tui_source_window_base.
8640         (tui_source_windows): Change return type.
8641         (tui_clear_source_windows_detail): Update.
8642         (tui_add_to_source_windows): Change type of parameter.
8643         (tui_free_all_source_wins_content): Update.
8644
8645 2019-06-25  Tom Tromey  <tom@tromey.com>
8646
8647         * tui/tui-wingeneral.c (tui_win_info::refresh)
8648         (tui_source_window_base::refresh): New methods.
8649         (tui_refresh_all): Call the refresh method.
8650         * tui/tui-data.h (struct tui_win_info)
8651         (struct tui_source_window_base) <refresh>: New method.
8652
8653 2019-06-25  Tom Tromey  <tom@tromey.com>
8654
8655         * tui/tui.h (tui_is_window_visible): Return bool.
8656         * tui/tui.c (tui_is_window_visible): Return bool.
8657         * tui/tui-wingeneral.c (tui_make_window, make_visible)
8658         (tui_make_visible, tui_make_invisible)
8659         (tui_win_info::make_visible)
8660         (tui_source_window_base::make_visible, make_all_visible)
8661         (tui_make_all_visible, tui_make_all_invisible): Update.
8662         * tui/tui-windata.c (tui_delete_data_content_windows): Update.
8663         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: Now
8664         bool.
8665         (struct tui_win_info, struct tui_source_window_base)
8666         (struct tui_cmd_window) <make_visible>: Change parameter to bool.
8667         * tui/tui-data.c (tui_init_generic_part): Update.
8668
8669 2019-06-25  Tom Tromey  <tom@tromey.com>
8670
8671         * tui/tui-wingeneral.c (tui_win_info::make_visible)
8672         (tui_source_window_base::make_visible): New methods.
8673         (make_all_visible): Make method call.
8674         * tui/tui-data.h (struct tui_win_info) <make_visible>: New method.
8675         (struct tui_source_window_base, struct tui_cmd_window): Override
8676         make_visible.
8677         (tui_win_is_source_type): Don't declare.
8678         * tui/tui-data.c (tui_win_is_source_type): Remove.
8679
8680 2019-06-25  Tom Tromey  <tom@tromey.com>
8681
8682         * tui/tui-layout.c (show_source_or_disasm_and_command): Remove
8683         NULL check.
8684
8685 2019-06-25  Tom Tromey  <tom@tromey.com>
8686
8687         * tui/tui-data.h (struct tui_data_window, struct tui_cmd_window):
8688         Inline constructor.  Add initializers for members.
8689         * tui/tui-data.c (tui_data_window, tui_cmd_window): Remove
8690         constructors; now inline in class.
8691
8692 2019-06-25  Tom Tromey  <tom@tromey.com>
8693
8694         * tui/tui-regs.c (tui_show_registers): Update.
8695         * tui/tui-data.h (struct tui_data_window) <display_regs>: Now
8696         bool.
8697         * tui/tui-data.c (tui_data_window::clear_detail)
8698         (tui_data_window): Update.
8699
8700 2019-06-25  Tom Tromey  <tom@tromey.com>
8701
8702         * tui/tui-windata.c (tui_display_all_data)
8703         (tui_display_data_from_line, tui_display_data_from)
8704         (tui_check_data_values, tui_data_window::do_scroll_vertical):
8705         Update.
8706         * tui/tui-regs.c (tui_last_regs_line_no)
8707         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
8708         (tui_show_registers, tui_show_register_group)
8709         (tui_display_registers_from, tui_display_reg_element_at_line)
8710         (tui_display_registers_from_line, tui_check_register_values)
8711         (tui_reg_next, tui_reg_prev): Update.
8712         * tui/tui-layout.c (tui_set_layout, show_data): Update.
8713         * tui/tui-data.h (struct tui_data_info): Remove.  Move contents to
8714         tui_data_window.
8715         (struct tui_win_info) <detail>: Remove.  Add new fields from
8716         tui_data_info.
8717         (TUI_DATA_WIN): Add cast.
8718         * tui/tui-data.c (tui_data_window::clear_detail, tui_data_window)
8719         (~tui_data_window): Simplify.
8720
8721 2019-06-25  Tom Tromey  <tom@tromey.com>
8722
8723         * tui/tui-layout.c (show_source_disasm_command)
8724         (show_source_or_disasm_and_command): Update.
8725         * tui/tui-io.c (update_cmdwin_start_line)
8726         (tui_redisplay_readline): Update.
8727         * tui/tui-data.h (struct tui_command_info): Remove.
8728         (struct tui_win_info) <detail>: Remove command_info member.
8729         (struct tui_data_window) <start_line>: New member, from
8730         tui_command_info.
8731         (TUI_CMD_WIN): Add casts.
8732
8733 2019-06-25  Tom Tromey  <tom@tromey.com>
8734
8735         * tui/tui-winsource.c (tui_update_source_window)
8736         (tui_refill_source_window)
8737         (tui_source_window_base::do_scroll_horizontal)
8738         (tui_update_breakpoint_info, tui_set_exec_info_content)
8739         (tui_show_exec_info_content, tui_erase_exec_info_content)
8740         (tui_clear_exec_info_content): Update.
8741         * tui/tui-wingeneral.c (make_all_visible, tui_refresh_all):
8742         Update.
8743         * tui/tui-win.c (make_invisible_and_set_new_height)
8744         (make_visible_with_new_height): Update.
8745         * tui/tui-source.c (tui_set_source_content)
8746         (tui_show_symtab_source): Update.
8747         * tui/tui-layout.c (extract_display_start_addr)
8748         (show_source_disasm_command, show_data)
8749         (make_source_or_disasm_window)
8750         (show_source_or_disasm_and_command): Update.
8751         * tui/tui-disasm.c (tui_set_disassem_content): Simplify.
8752         (tui_disasm_window::do_scroll_vertical): Remove shadowing
8753         "gdbarch".
8754         * tui/tui-data.h (struct tui_source_info): Remove.  Move contents
8755         to tui_source_window_base.
8756         (struct tui_win_info) <detail>: Remove source_info member.
8757         (struct tui_source_window_base) <has_locator>: Inline.
8758         Move contents from tui_source_info; rename has_locator member to
8759         m_has_locator.
8760         (TUI_SRC_WIN, TUI_DISASM_WIN): Add casts.
8761         * tui/tui-data.c (tui_source_window_base::has_locator): Move to
8762         header file.
8763         (tui_source_window_base::clear_detail, ~tui_source_window_base):
8764         Simplify.
8765         (tui_free_all_source_wins_content): Cast to
8766         tui_source_window_base.
8767
8768 2019-06-25  Tom Tromey  <tom@tromey.com>
8769
8770         * tui/tui-win.c (make_invisible_and_set_new_height)
8771         (make_visible_with_new_height): Call has_locator method.
8772         * tui/tui-layout.c (show_source_disasm_command, show_data)
8773         (show_source_or_disasm_and_command): Update for bool change.
8774         * tui/tui-data.h (struct tui_source_info) <has_locator>: Now bool.
8775         (tui_win_info) <has_locator>: New method.
8776         (struct tui_source_window_base) <has_locator>: New method.
8777         (tui_win_has_locator): Don't declare.
8778         * tui/tui-data.c (tui_source_window_base::has_locator): Rename
8779         from tui_win_has_locator.
8780         (tui_source_window_base): Use false, not FALSE.
8781
8782 2019-06-25  Tom Tromey  <tom@tromey.com>
8783
8784         * tui/tui-data.h (tui_clear_win_detail): Don't declare.
8785         * tui/tui-data.c (tui_clear_source_windows_detail): Call the
8786         clear_detail method directly.
8787         (tui_clear_win_detail): Remove.
8788
8789 2019-06-25  Tom Tromey  <tom@tromey.com>
8790
8791         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Use
8792         "this", not TUI_DISASM_WIN.
8793
8794 2019-06-25  Tom Tromey  <tom@tromey.com>
8795
8796         * tui/tui-winsource.h (tui_horizontal_source_scroll):  Don't
8797         declare.
8798         * tui/tui-winsource.c
8799         (tui_source_window_base::do_scroll_horizontal): Rename from
8800         tui_horizontal_source_scroll.
8801         * tui/tui-windata.h (tui_vertical_data_scroll): Don't declare.
8802         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Rename
8803         from tui_vertical_data_scroll.
8804         * tui/tui-win.h (tui_scroll): Don't declare.
8805         * tui/tui-win.c (tui_win_info::forward_scroll)
8806         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
8807         (tui_win_info::right_scroll): Rename and update.
8808         (tui_scroll_forward_command, tui_scroll_backward_command)
8809         (tui_scroll_left_command, tui_scroll_right_command): Update.
8810         (tui_scroll): Remove.
8811         * tui/tui-source.h: Don't declare tui_vertical_source_scroll.
8812         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Rename
8813         from tui_vertical_source_scroll.
8814         * tui/tui-disasm.h (tui_vertical_disassem_scroll): Don't declare.
8815         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Rename
8816         from tui_vertical_disassem_scroll.
8817         * tui/tui-data.h (struct tui_win_info) <do_scroll_vertical,
8818         do_scroll_horizontal>: New methods.
8819         <forward_scroll, backward_scroll, left_scroll, right_scroll>:
8820         Likewise.
8821         (struct tui_source_window_base): Add do_scroll_horizontal.
8822         (struct tui_source_window, struct tui_disasm_window): Add
8823         do_scroll_vertical.
8824         (struct tui_data_window, struct tui_cmd_window): Add
8825         do_scroll_horizontal and do_scroll_vertical.
8826         * tui/tui-command.c (tui_dispatch_ctrl_char): Use method calls.
8827
8828 2019-06-25  Tom Tromey  <tom@tromey.com>
8829
8830         * tui/tui-data.h (struct tui_source_window_base): New struct.
8831         (struct tui_source_window): Derive from tui_source_window_base.
8832         (struct tui_disasm_window): New struct.
8833         * tui/tui-data.c (tui_source_window_base::clear_detail): Rename
8834         from tui_source_window::clear_detail.
8835         (tui_source_window_base): Rename from tui_source_window.
8836         (~tui_source_window_base): Rename from ~tui_source_window.
8837         (tui_alloc_win_info): Create a tui_disasm_window.
8838
8839 2019-06-25  Tom Tromey  <tom@tromey.com>
8840
8841         * tui/tui-data.h (struct tui_source_window)
8842         (struct tui_data_window): Declare destructors.
8843         * tui/tui-data.c (~tui_source_window, ~tui_data_window): New
8844         destructors.
8845         (tui_win_info): Simplify.
8846
8847 2019-06-25  Tom Tromey  <tom@tromey.com>
8848
8849         * tui/tui-winsource.c (tui_display_main)
8850         (tui_update_source_windows_with_addr)
8851         (tui_update_all_breakpoint_info): Update.
8852         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
8853         (new_height_ok, parse_scrolling_args): Update.
8854         * tui/tui-stack.c (tui_show_frame_info): Update.
8855         * tui/tui-data.h (struct tui_list): Remove.
8856         (tui_source_windows): Return a reference to a std::vector.
8857         * tui/tui-data.c (source_windows): Now a std::vector.
8858         (tui_source_windows): Change return type.
8859         (tui_clear_source_windows): Rewrite.
8860         (tui_clear_source_windows_detail, tui_add_to_source_windows)
8861         (tui_free_all_source_wins_content): Rewrite.
8862
8863 2019-06-25  Tom Tromey  <tom@tromey.com>
8864
8865         * tui/tui-data.h (struct tui_win_info, struct tui_source_window)
8866         (struct tui_data_window, struct tui_cmd_window): Declare
8867         clear_detail method.
8868         * tui/tui-data.c (tui_source_window::clear_detail)
8869         (tui_cmd_window::clear_detail, tui_data_window::clear_detail): New
8870         methods.
8871         (tui_clear_win_detail): Simplify.
8872
8873 2019-06-25  Tom Tromey  <tom@tromey.com>
8874
8875         * tui/tui-layout.c (make_source_window, make_disasm_window)
8876         (make_source_or_disasm_window): Remove win_info_ptr parameter.
8877         Return the new window.
8878         (show_source_disasm_command, show_data)
8879         (show_source_or_disasm_and_command): Update.
8880
8881 2019-06-25  Tom Tromey  <tom@tromey.com>
8882
8883         * tui/tui-layout.c (make_command_window): Remove win_info_ptr
8884         parameter.  Return the new window.
8885         (show_source_disasm_command): Update and remove NULL check.
8886         (show_source_or_disasm_and_command): Update.
8887
8888 2019-06-25  Tom Tromey  <tom@tromey.com>
8889
8890         * tui/tui-layout.c (init_and_make_win): Remove NULL check.
8891
8892 2019-06-25  Tom Tromey  <tom@tromey.com>
8893
8894         * tui/tui-data.h (struct tui_win_info): Make constructor
8895         protected.  Make destructor virtual.  Add initializers.
8896         (tui_source_window, tui_data_window, tui_cmd_window): New
8897         classes.
8898         * tui/tui-data.c (tui_win_info): Rename from init_win_info.  Now a
8899         constructor.  Add "type" parameter.
8900         (tui_source_window, tui_data_window, tui_cmd_window): New
8901         constructors.
8902         (tui_alloc_win_info): Instantiate the appropriate subclass.
8903
8904 2019-06-25  Tom Tromey  <tom@tromey.com>
8905
8906         * tui/tui-win.c (tui_resize_all): Use delete.
8907         * tui/tui-data.h (struct tui_win_info) <~tui_win_info>: Declare
8908         destructor.
8909         (tui_free_window): Don't declare.
8910         * tui/tui-data.c (~tui_win_info): Rename from tui_free_window.
8911         Update.
8912
8913 2019-06-25  Tom Tromey  <tom@tromey.com>
8914
8915         * tui/tui-data.h (struct tui_win_info): Add constructor.
8916         * tui/tui-data.c (tui_alloc_win_info): Use new.
8917         (tui_free_window): Use delete.
8918
8919 2019-06-22  Tom Tromey  <tom@tromey.com>
8920
8921         * tui/tui-windata.h (tui_first_data_element_no_in_line): Don't
8922         declare.
8923         * tui/tui-windata.c (tui_first_data_element_no_in_line): Remove.
8924
8925 2019-06-22  Tom Tromey  <tom@tromey.com>
8926
8927         * tui/tui-data.h (tui_del_window, tui_del_data_windows): Don't
8928         declare.
8929         * tui/tui-data.c (tui_del_window, tui_del_data_windows): Remove.
8930
8931 2019-06-22  Tom de Vries  <tdevries@suse.de>
8932
8933         * dwarf2read.c (create_addrmap_from_aranges)
8934         (read_debug_names_from_section): Print ptrdiff_t using '%s' and plongest
8935         instead of '%zu'.
8936
8937 2019-06-21  Simon Marchi  <simon.marchi@efficios.com>
8938
8939         * dwarf2read.h (dwarf2_section_info_def): Remove.
8940         (DEF_VEC_O (dwarf2_section_info_def)): Remove.
8941         * dwarf2read.c (struct dwo_sections) <types>: Change type to
8942         std::vector<dwarf2_section_info>.
8943         (struct dwo_file) <~dwo_file>: Remove.
8944         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't manually free
8945         types field.
8946         (dwarf2_per_objfile::locate_sections): Adjust to std::vector.
8947         (dwarf2_read_debug_names): Likewise.
8948         (create_debug_types_hash_table): Change parameter type to
8949         array_view, adjust code accordingly.
8950         (dwarf2_locate_dwo_sections): Adjust to std::vector.
8951         (partial_die_info::fixup): Likewise.
8952         (determine_prefix): Likewise.
8953         * dwarf-index-write.c (write_psymtabs_to_index): Adjust.
8954
8955 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
8956
8957         * dwarf2read.c (struct dwo_file) <dbfd>: Change type to
8958         gdb_bfd_ref_ptr.
8959         <~dwo_file>: Remove call to gdb_bfd_unref.
8960         (open_and_init_dwo_file): Move gdb_bfd_ref_ptr into dbfd field. Call
8961         gdb_bfd_ref_ptr::get.
8962
8963 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
8964
8965         * dwarf2read.h (struct dwarf2_per_objfile) <dwo_files>: Change
8966         type to htab_up.
8967         * dwarf2read.c (struct dwo_file): Initialize fields.
8968         <~dwo_file>: New.
8969         (free_dwo_file): Remove, move content to ~dwo_file.
8970         (struct dwo_file_deleter): Remove.
8971         (dwo_file_up>: Remove custom deleter.
8972         (free_dwo_files): Remove.
8973         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't explicitly free
8974         dwo_files.
8975         (process_skeletonless_type_units): Call unique_ptr::get.
8976         (allocate_dwo_file_hash_table): Add deleter to created hash
8977         table.  Change return type to htab_up.
8978         (lookup_dwo_file_slot): Don't memset dwo_file, call
8979         unique_ptr::get.
8980         (create_dwo_unit_in_dwp_v1): Allocate dwo_file with new.
8981         (create_dwo_unit_in_dwp_v2): Likewise.
8982         (open_and_init_dwo_file): Likewise.
8983         (free_dwo_file_from_slot): Remove.
8984
8985 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
8986
8987         * dwarf2read.h (struct dwarf2_section_info) <readin,
8988         is_virtual>: Change type to bool.
8989         * dwarf2read.c (dwarf2_read_section, create_dwp_v2_section): Use
8990         true instead of 1.
8991
8992 2019-06-19  Tom Tromey  <tom@tromey.com>
8993
8994         * tui/tui-data.h (tui_init_content_element): Don't declare.
8995
8996 2019-06-19  Tom Tromey  <tom@tromey.com>
8997
8998         * tui/tui-data.h (tui_init_win_info): Don't declare.
8999
9000 2019-06-19  Tom de Vries  <tdevries@suse.de>
9001
9002         * dwarf2read.h (abstract_to_concrete): Change type to
9003         std::unordered_map<sect_offset, std::vector<sect_offset>,
9004         gdb::hash_enum<sect_offset>>.
9005
9006 2019-06-19  Tom Tromey  <tromey@adacore.com>
9007
9008         * ada-lang.c (ada_evaluate_subexp) <case OP_ATR_FIRST>: Handle
9009         EVAL_AVOID_SIDE_EFFECTS specially.
9010
9011 2019-06-19  Tom Tromey  <tromey@adacore.com>
9012
9013         * source-cache.c (highlighter): New global.
9014         (source_cache::get_source_lines): Create a highlighter on demand.
9015
9016 2019-06-18  Andrew Burgess  <andrew.burgess@embecosm.com>
9017
9018         * defs.h (deprecated_interactive_hook): Delete declaration.
9019         * interps.c (clear_interpreter_hooks): Remove use of
9020         deprecated_interactive_hook.
9021         * top.c (deprecated_interactive_hook): Delete definition.
9022         * utils.c (maybe_quit): Remove use of deprecated_interactive_hook.
9023
9024 2019-06-18  Tom de Vries  <tdevries@suse.de>
9025
9026         PR gdb/24515
9027         * dwarf2read.h (abstract_to_concrete): Change type from
9028         std::unordered_map<die_info_ptr, std::vector<die_info_ptr>> to
9029         std::unordered_map<sect_offset, std::vector<sect_offset>>.
9030         * dwarf2read.c (read_variable): Update.
9031         (dwarf2_fetch_die_loc_sect_off): Update.
9032
9033 2019-06-17  Tom de Vries  <tdevries@suse.de>
9034
9035         PR gdb/24617
9036         * common/pathstuff.c (child_path): Make sure parent_len > 0 before
9037         accessing parent[parent_len - 1].
9038
9039 2019-06-17  Paul Pluzhnikov  <ppluzhnikov@google.com>
9040
9041         PR gdb/24364
9042         * gdb/dtrace-probe.c (dtrace_static_probe_ops::get_probe): Don't
9043         call dtrace_process_dof with NULL dof.
9044
9045 2019-06-16  Tom de Vries  <tdevries@suse.de>
9046
9047         PR gdb/24445
9048         * contrib/gdb-add-index.sh: Update to handle dwz-m-ed executable.
9049
9050 2019-06-16  Tom Tromey  <tom@tromey.com>
9051
9052         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
9053         (make_all_visible): Use address of member.
9054
9055 2019-06-16  Tom Tromey  <tom@tromey.com>
9056
9057         * tui/tui-data.c (tui_clear_win_detail, init_win_info)
9058         (tui_free_window, free_content, free_content_elements): Remove
9059         unnecessary cast.
9060         * tui/tui-windata.c (tui_display_all_data): Remove unnecessary
9061         cast.
9062         * tui/tui-regs.c (tui_show_register_group)
9063         (tui_display_registers_from, tui_display_reg_element_at_line):
9064         Remove unnecessary cast.
9065
9066 2019-06-16  Andrew Burgess  <andrew.burgess@embecosm.com>
9067
9068         * linux-nat.c (normal_mask): Delete.
9069         (_initialize_linux_nat): Don't initialise normal_mask.
9070
9071 2019-06-16  Simon Marchi  <simon.marchi@polymtl.ca>
9072
9073         PR gdb/24445
9074         * dwarf-index-write.h (write_psymtabs_to_index): Add
9075         dwz_basename parameter.
9076         * dwarf-index-write.c (write_gdbindex): Move file writing to
9077         write_gdbindex_1.  Change return type void.
9078         (assert_file_size): Move up, remove filename parameter.
9079         (write_gdbindex_1): New function.
9080         (write_debug_names): Change return type to void, call
9081         assert_file_size.
9082         (struct index_wip_file): New struct.
9083         (write_psymtabs_to_index): Add dwz_basename parameter.  Move
9084         file logic to index_wip_file.  Write index for dwz file if
9085         needed.
9086         (save_gdb_index_command): Pass basename of dwz file, if present.
9087         * dwarf-index-cache.c (index_cache::store): Obtain and pass
9088         build-id of dwz file, if present.
9089         * dwarf2read.c (struct dwz_file): Move to dwarf2read.h.
9090         (dwarf2_get_dwz_file): Likewise.
9091         * dwarf2read.h (struct dwz_file): Move from dwarf2read.c.
9092         (dwarf2_get_dwz_file): Likewise.
9093
9094 2019-06-16  Tom Tromey  <tom@tromey.com>
9095
9096         * coffread.c (process_coff_symbol): Use xstrdup.
9097         * value.c (create_internalvar): Use xstrdup.
9098
9099 2019-06-16  Tom Tromey  <tom@tromey.com>
9100
9101         * valops.c (value_cast, value_slice): Remove unnecessary cast.
9102         * breakpoint.c (stopin_command, stopat_command)
9103         (until_break_command, decode_location_default): Remove unnecessary
9104         cast.
9105         * utils.c (subset_compare): Remove unnecessary cast.
9106         * ada-lang.c (ada_update_initial_language): Remove unnecessary
9107         cast.
9108         * linespec.c (decode_line_with_last_displayed): Remove unnecessary
9109         cast.
9110         * infcmd.c (path_command): Remove unnecessary cast.
9111         * coffread.c (decode_type): Remove unnecessary cast.
9112         * xcoffread.c (read_xcoff_symtab): Remove unnecessary cast.
9113         * mipsread.c (mipscoff_symfile_read): Remove unnecessary cast.
9114         * tui/tui-stack.c (tui_show_locator_content)
9115         (tui_show_frame_info): Remove unnecessary cast.
9116         * tui/tui-win.c (tui_scroll_forward_command)
9117         (tui_scroll_backward_command, tui_set_focus, tui_set_win_height)
9118         (parse_scrolling_args): Remove unnecessary cast.
9119         * tui/tui-data.c (init_win_info, tui_del_window)
9120         (tui_free_window, tui_del_data_windows, tui_free_data_content)
9121         (free_content_elements): Remove unnecessary cast.
9122         * tui/tui-windata.c (tui_first_data_item_displayed): Remove
9123         unnecessary cast.
9124         * tui/tui-source.c (tui_set_source_content)
9125         (tui_vertical_source_scroll): Remove unnecessary cast.
9126         * tui/tui-layout.c (tui_default_win_height): Remove unnecessary
9127         cast.
9128         * tui/tui-io.c (tui_initialize_io): Remove unnecessary cast.
9129         * tui/tui-regs.c (tui_display_registers_from)
9130         (tui_display_register): Remove unnecessary cast.
9131         * tui/tui-wingeneral.c (tui_refresh_win, tui_delete_win)
9132         (tui_unhighlight_win, tui_highlight_win, tui_make_window)
9133         (make_visible): Remove unnecessary cast.
9134         * tui/tui-winsource.c (tui_erase_source_content)
9135         (tui_update_breakpoint_info, tui_set_exec_info_content): Remove
9136         unnecessary cast.
9137         * ax-gdb.c (agent_command_1): Remove unnecessary cast.
9138         * cli/cli-setshow.c (cmd_show_list): Remove unnecessary cast.
9139         * stabsread.c (read_type, read_array_type, read_range_type):
9140         Remove unnecessary cast.
9141         * mdebugread.c (mdebug_build_psymtabs): Remove unnecessary cast.
9142         (parse_symbol, parse_type, upgrade_type, parse_external)
9143         (parse_partial_symbols, psymtab_to_symtab_1, cross_ref): Remove
9144         unnecessary cast.
9145         * gdb_bfd.c (gdb_bfd_map_section): Remove unnecessary cast.
9146
9147 2019-06-16  Tom Tromey  <tom@tromey.com>
9148
9149         * tui/tui-data.c (tui_alloc_generic_win_info)
9150         (tui_alloc_win_info, tui_add_content_elements): Remove NULL
9151         checks.
9152
9153 2019-06-16  Bernhard Heckel  <bernhard.heckel@intel.com>
9154             Andrew Burgess  <andrew.burgess@embecosm.com>
9155
9156         * f-typeprint.c (f_print_type): Don't return early for not
9157         associated or not allocated types.
9158         (f_type_print_varspec_suffix): Add print_rank parameter and print
9159         ranks of array types in case they dangling.
9160         (f_type_print_base): Add print_rank parameter.
9161
9162 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
9163
9164         * NEWS: Mention new MI commands.
9165         * break-catch-throw.c (enum exception_event_kind): Move to
9166         breakpoint.h.
9167         (print_mention_exception_catchpoint): Output text as a single
9168         message.
9169         (catch_exception_command_1): Rename to...
9170         (catch_exception_event): ...this, make non-static, update header
9171         command, and change some parameter types.
9172         (catch_catch_command): Update for changes to
9173         catch_exception_command_1.
9174         (catch_throw_command): Likewise.
9175         (catch_rethrow_command): Likewise.
9176         * breakpoint.c (enum exception_event_kind): Delete.
9177         * breakpoint.h (enum exception_event_kind): Moved here from
9178         break-catch-throw.c.
9179         (catch_exception_event): Declare.
9180         * mi/mi-cmd-catch.c (mi_cmd_catch_exception_event): New function.
9181         (mi_cmd_catch_throw): New function.
9182         (mi_cmd_catch_rethrow): New function.
9183         (mi_cmd_catch_catch): New function.
9184         * mi/mi-cmds.c (mi_cmds): Add 'catch-throw', 'catch-rethrow', and
9185         'catch-catch' entries.
9186         * mi/mi-cmds.h (mi_cmd_catch_throw): Declare.
9187         (mi_cmd_catch_rethrow): Declare.
9188         (mi_cmd_catch_catch): Declare.
9189
9190 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
9191
9192         * annotate.c (annotate_source_line): Change return type to void,
9193         update implementation to match.
9194         * annotate.h (annotate_source_line): Change return type to void,
9195         update header comment.
9196         * stack.c (print_frame_info): Don't change what frame information
9197         is printed based on whether annotations are on or not.
9198
9199 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
9200
9201         * annotate.c: Add 'source.h' and 'objfiles.h' includes.
9202         (annotate_source): Make static.
9203         (annotate_source_line): Moved from source.c and renamed from
9204         identify_source_line.  Update the return type.
9205         * annotate.h (annotate_source): Delete declaration.
9206         (annotate_source_line): Declaration moved from source.h, and
9207         renamed from identify_source_line.  Return type updated.
9208         * source.c (identify_source_line): Moved to annotate.c and renamed
9209         to annotate_source_line.
9210         (info_line_command): Remove check of annotation_level.
9211         * source.h (identify_source_line): Move declaration to annotate.h
9212         and rename to annotate_source_line.
9213         * stack.c: Add 'annotate.h' include.
9214         (print_frame_info): Remove check of annotation_level before
9215         calling annotate_source_line.
9216
9217 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
9218
9219         * source-cache.c (source_cache::get_plain_source_lines): Use
9220         open_source_file_with_line_charpos instead of just
9221         open_source_file, remove call to find_source_lines.
9222         (source_cache::get_source_lines): Likewise.
9223         * source.c (find_source_lines): Make static.
9224         (get_filename_and_charpos): Renamed into...
9225         (open_source_file_with_line_charpos): ..this along with changes to
9226         return a scoped_fd, and some other minor clean ups.
9227         (identify_source_line): Use open_source_file_with_line_charpos.
9228         (search_command_helper): Use open_source_file_with_line_charpos
9229         instead of just open_source_file, remove call to
9230         find_source_lines.
9231         * source.h (open_source_file_with_line_charpos): Declare new
9232         function.
9233         (find_source_lines): Delete declaration.
9234
9235 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
9236
9237         * source.c (get_filename_and_charpos): Remove fullname
9238         parameter.
9239         (identify_source_line): Update call to get_filename_and_charpos.
9240
9241 2019-06-14  Tom Tromey  <tromey@adacore.com>
9242
9243         PR gdb/24502:
9244         * ui-style.h (skip_ansi_escape): Update comment.
9245         * ui-file.h (class no_terminal_escape_file): New class.
9246         * ui-file.c (no_terminal_escape_file::write)
9247         (no_terminal_escape_file::puts): New methods.
9248         * cli/cli-logging.c (handle_redirections): Use
9249         no_terminal_escape_file.
9250
9251 2019-06-14  Tom Tromey  <tromey@adacore.com>
9252
9253         * NEWS: Move convenience variable news above Python news.
9254
9255 2019-06-14  Tom Tromey  <tom@tromey.com>
9256
9257         * gnulib: Move directory to top-level.
9258         * configure.ac: Don't configure gnulib.
9259         * configure: Rebuild.
9260         * common/common-defs.h: Use new path to gnulib.
9261         * Makefile.in (GNULIB_BUILDDIR): Now ../gnulib.
9262         (GNULIB_H): Remove.
9263         (INCGNU): Look in new gnulib location.
9264         (HFILES_NO_SRCDIR): Remove gnulib files.
9265         (SUBDIR, REQUIRED_SUBDIRS): Remove gnulib.
9266         (generated_files): Remove GNULIB_H.
9267         ($(LIBGNU), all-lib): Remove targets.
9268         (distclean): Don't mention GNULIB_BUILDDIR.
9269         ($(GNULIB_BUILDDIR)/Makefile): Remove target.
9270
9271 2019-06-14  Tom Tromey  <tromey@adacore.com>
9272
9273         * symfile.c (add_symbol_file_command): Remove obsolete comment.
9274         Warn if symbol file does not provide any symbols.
9275
9276 2019-06-14  Tom Tromey  <tromey@adacore.com>
9277
9278         * source.c (find_and_open_source): Respect basenames_may_differ.
9279
9280 2019-06-14  Andrew Burgess  <andrew.burgess@embecosm.com>
9281
9282         * annotate.c (annotate_breakpoints_invalid): Make use of
9283         scoped_restore_terminal_state.
9284         (annotate_frames_invalid): Likewise.
9285
9286 2019-06-14  Tom Tromey  <tromey@adacore.com>
9287
9288         * ada-lang.c (ada_evaluate_subexp) <case BINOP_ASSIGN>: Always
9289         allow assignment to an internalvar.
9290
9291 2019-06-14  Tom Tromey  <tromey@adacore.com>
9292
9293         * ada-lex.l: Allow "_" in attribute names.
9294
9295 2019-06-14  Tom Tromey  <tromey@adacore.com>
9296
9297         PR gdb/24653:
9298         * regcache.c (registers_changed): Don't call alloca.
9299         * top.c (execute_command): Don't call alloca.
9300
9301 2019-06-13  Pedro Alves  <palves@redhat.com>
9302
9303         * cli/cli-setshow.c (cli/cli-setshow.c): New parameter
9304         'expression'.  When parsing an expression, error out if there's
9305         junk after "unlimited".
9306         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
9307         (do_set_command): Adjust calls to is_unlimited_literal.
9308
9309 2019-06-13  Pedro Alves  <palves@redhat.com>
9310
9311         * compile/compile.c (make_compile_options_def_group): Add braces
9312         around array_view initializer.
9313         * thread.c (make_thread_apply_all_options_def_group)
9314         (make_thread_apply_all_options_def_group): Likewise.
9315
9316 2019-06-13  Pedro Alves  <palves@redhat.com>
9317
9318         * NEWS (New commands): Mention "maint test-options
9319         require-delimiter", "maint test-options unknown-is-error", "maint
9320         test-options unknown-is-operand" and "maint show
9321         test-options-completion-result".
9322         (New command options, command completion): New section.
9323         (Completion improvements): New section.
9324         Mention that you can abbreviate "unlimited".
9325
9326 2019-06-13  Pedro Alves  <palves@redhat.com>
9327
9328         * cli/cli-utils.c (parse_flags, parse_flags_qcs): Delete.
9329         * cli/cli-utils.h (parse_flags, parse_flags_qcs): Delete.
9330         * unittests/cli-utils-selftests.c (test_parse_flags)
9331         (test_parse_flags_qcs): Delete.
9332         (test_cli_utils): Don't call deleted functions.
9333
9334 2019-06-13  Pedro Alves  <palves@redhat.com>
9335
9336         * thread.c: Include "cli/cli-option.h".
9337         (tp_array_compar_ascending): Global.
9338         (tp_array_compar): Delete function.
9339         (tp_array_compar_ascending, tp_array_compar_descending): New
9340         functions.
9341         (ascending_option_def, qcs_flag_option_def)
9342         (thr_qcs_flags_option_defs)
9343         (make_thread_apply_all_options_def_group)
9344         (make_thread_apply_options_def_group): New.
9345         (thread_apply_all_command): Use gdb::option::process_options.
9346         (thread_apply_command_completer)
9347         (thread_apply_all_command_completer): New.
9348         (thread_apply_command): Use gdb::option::process_options.
9349         (_initialize_thread): Delete THREAD_APPLY_FLAGS_HELP, replace it
9350         with a new THREAD_APPLY_OPTION_HELP.  Use gdb::option::build_help
9351         to generate help text of "thread apply".  Adjust "taas"'s help.
9352         * tid-parse.c (tid_range_parser::in_thread_range): New method.
9353         * tid-parse.h (tid_range_parser::in_thread_range): New method.
9354
9355 2019-06-13  Pedro Alves  <palves@redhat.com>
9356
9357         * thread.c (thread_apply_command): Check for invalid TID with
9358         isdigit instead of !isalpha.
9359
9360 2019-06-13  Pedro Alves  <palves@redhat.com>
9361
9362         * cli/cli-utils.c (parse_flags_qcs): Use validate_flags_qcs.
9363         (validate_flags_qcs): New.
9364         * cli/cli-utils.h (struct qcs_flags): Change field types to int.
9365         (validate_flags_qcs): Declare.
9366         * stack.c (qcs_flag_option_def, fr_qcs_flags_option_defs): New.
9367         (make_frame_apply_options_def_group): New.
9368         (frame_apply_command_count): Process options with
9369         gdb::option::process_options.
9370         (frame_apply_completer): New.
9371         (frame_apply_level_completer, frame_apply_all_completer)
9372         (frame_apply_completer): New.
9373         (_initialize_stack): Update help of "frame apply", "frame apply
9374         level", "frame apply all" and "faas" to mention supported options
9375         and install command completers.
9376         * stack.h (frame_apply_all_completer): Declare.
9377         * thread.c: Include "stack.h".
9378         (tfaas_command): Add "--".
9379         (_initialize_thread): Update help "tfaas" to mention supported
9380         options and install command completer.
9381
9382 2019-06-13  Pedro Alves  <palves@redhat.com>
9383
9384         * completer.c (complete_nested_command_line): New.
9385         (gdb_completion_word_break_characters_throw): Add assertion.
9386         * completer.h (complete_nested_command_line): Declare.
9387
9388 2019-06-13  Pedro Alves  <palves@redhat.com>
9389
9390         * stack.c (parse_backtrace_qualifiers): New.
9391         (backtrace_command): Use it.
9392         (backtrace_command_completer): Complete on qualifiers.
9393
9394 2019-06-13  Pedro Alves  <palves@redhat.com>
9395
9396         * frame.c: Include "cli/cli-option.h.
9397         (user_set_backtrace_options): New.
9398         (backtrace_past_main, backtrace_past_entry, backtrace_limit):
9399         Delete.
9400         (get_prev_frame): Adjust.
9401         (boolean_option_def, uinteger_option_def)
9402         (set_backtrace_option_defs): New.
9403         (_initialize_frame): Adjust and use
9404         gdb::option::add_setshow_cmds_for_options to install "set
9405         backtrace past-main" and "set backtrace past-entry".
9406         * frame.h: Include "cli/cli-option.h".
9407         (struct frame_print_options): Forward declare.
9408         (print_frame_arguments_all, print_frame_arguments_scalars)
9409         (print_frame_arguments_none): Declare.
9410         (print_entry_values): Delete declaration.
9411         (struct frame_print_options, user_frame_print_options): New.
9412         (struct set_backtrace_options): New.
9413         (set_backtrace_option_defs, user_set_backtrace_options): Declare.
9414         * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
9415         (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
9416         (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
9417         (list_args_or_locals): Add frame_print_options parameter.
9418         (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
9419         * python/py-framefilter.c (enumerate_args): Pass down
9420         USER_FRAME_PRINT_OPTIONS.
9421         * stack.c: Include "cli/cli-option.h".
9422         (print_frame_arguments_all, print_frame_arguments_scalars)
9423         (print_frame_arguments_none): Declare.
9424         (print_raw_frame_arguments, print_entry_values): Delete.
9425         (user_frame_print_options): New.
9426         (boolean_option_def, enum_option_def, frame_print_option_defs):
9427         New.
9428         (struct backtrace_cmd_options): New.
9429         (bt_flag_option_def): New.
9430         (backtrace_command_option_defs): New.
9431         (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
9432         (print_frame_arg, read_frame_arg, print_frame_args)
9433         (print_frame_info, print_frame): Add frame_print_options parameter
9434         and use it.
9435         (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
9436         (backtrace_command_1): Add frame_print_options and
9437         backtrace_cmd_options parameters and use them.
9438         (make_backtrace_options_def_group): New.
9439         (backtrace_command): Process command options with
9440         gdb::option::process_options.
9441         (backtrace_command_completer): New.
9442         (_initialize_stack): Extend "backtrace"'s help to mention
9443         supported options.  Install completer for "backtrace".
9444         Install some settings commands with add_setshow_cmds_for_options.
9445
9446 2019-06-13  Pedro Alves  <palves@redhat.com>
9447
9448         * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
9449         and that "set/show print raw frame-arguments" are now deprecated.
9450
9451         * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
9452         command.
9453         * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
9454         * stack.c (_initialize_stack): Install "set/show print
9455         raw-frame-arguments", and deprecate "set/show print raw
9456         frame-arguments".
9457         * valprint.c (_initialize_valprint): Deprecate "set/show print
9458         raw".
9459
9460 2019-06-13  Pedro Alves  <palves@redhat.com>
9461
9462         * compile/compile.c (struct compile_options): New.
9463         (compile_flag_option_def, compile_command_option_defs)
9464         (make_compile_options_def_group): New.
9465         (compile_file_command): Handle options with
9466         gdb::option::process_options.
9467         (compile_file_command_completer): New function.
9468         (compile_code_command): Handle options with
9469         gdb::option::process_options.
9470         (compile_code_command_completer): New function.
9471         (_initialize_compiler): Install completers for "compile code" and
9472         "compile file".  Mention available options in "compile code" and
9473         "compile code"'s help.
9474         * completer.c (advance_to_completion_word): New, factored out from
9475         ...
9476         (advance_to_expression_complete_word_point): ... this.
9477         (advance_to_filename_complete_word_point): New.
9478         * completer.h (advance_to_filename_complete_word_point): New
9479         declaration.
9480
9481 2019-06-13  Pedro Alves  <palves@redhat.com>
9482
9483         * compile/compile.c: Include "cli/cli-option.h".
9484         (compile_print_value): Scope data pointer is now a
9485         value_print_options pointer; adjust.
9486         (compile_print_command): Process options.  Scope data pointer is
9487         now a value_print_options pointer; adjust.
9488         (_initialize_compile): Update "compile print"'s help to include
9489         supported options.  Install a completer for "compile print".
9490         * cp-valprint.c (show_vtblprint, show_objectprint)
9491         (show_static_field_print): Delete.
9492         (_initialize_cp_valprint): Don't install "set print
9493         static-members", "set print vtbl", "set print object" here.
9494         * printcmd.c: Include "cli/cli-option.h" and
9495         "common/gdb_optional.h".
9496         (print_command_parse_format): Rework to fill in a
9497         value_print_options instead of a format_data.
9498         (print_value): Change parameter type from format_data pointer to
9499         value_print_options reference.  Adjust.
9500         (print_command_1): Process options.  Adjust to pass down a
9501         value_print_options.
9502         (print_command_completer): New.
9503         (_initialize_printcmd): Install print_command_completer as
9504         handle_brkchars completer for the "print" command.  Update
9505         "print"'s help to include supported options.
9506         * valprint.c: Include "cli/cli-option.h".
9507         (show_vtblprint, show_objectprint, show_static_field_print): Moved
9508         here from cp-valprint.c.
9509         (boolean_option_def, uinteger_option_def)
9510         (value_print_option_defs, make_value_print_options_def_group):
9511         New.  Use gdb::option::add_setshow_cmds_for_options to install
9512         "set print elements", "set print null-stop", "set print repeats",
9513         "set print pretty", "set print union", "set print array", "set
9514         print address", "set print symbol", "set print array-indexes".
9515         * valprint.h: Include <string> and "cli/cli-option.h".
9516         (make_value_print_options_def_group): Declare.
9517         (print_value): Change parameter type from format_data pointer to
9518         value_print_options reference.
9519         (print_command_completer): Declare.
9520
9521 2019-06-13  Pedro Alves  <palves@redhat.com>
9522
9523         * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
9524         (COMMON_SFILES): Add maint-test-settings.c.
9525         * cli/cli-decode.c (boolean_enums): New global, factored out from
9526         ...
9527         (add_setshow_boolean_cmd): ... here.
9528         * cli/cli-decode.h (boolean_enums): Declare.
9529         * cli/cli-option.c: New file.
9530         * cli/cli-option.h: New file.
9531         * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
9532         factored out from ...
9533         (parse_cli_boolean_value(const char *)): ... this.
9534         (is_unlimited_literal): Change parameter type to pointer to
9535         pointer.  Adjust and advance ARG pointer.
9536         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
9537         (parse_cli_var_enum): New, factored out from ...
9538         (do_set_command): ... this.  Adjust.
9539         * cli/cli-setshow.h (parse_cli_boolean_value)
9540         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
9541         (parse_cli_var_enum): Declare.
9542         * cli/cli-utils.c: Include "cli/cli-option.h".
9543         (get_ulongest): New.
9544         * cli/cli-utils.h (get_ulongest): Declare.
9545         (check_for_argument): New overloads.
9546         * maint-test-options.c: New file.
9547
9548 2019-06-13  Pedro Alves  <palves@redhat.com>
9549
9550         * cli/cli-utils.c (number_or_range_parser::get_number): Do not
9551         parse a range if "-" is at the end of the string.
9552
9553 2019-06-13  Pedro Alves  <palves@redhat.com>
9554
9555         * cli/cli-setshow.c (parse_auto_binary_operation)
9556         (parse_cli_boolean_value): Don't allow "o".
9557
9558 2019-06-13  Pedro Alves  <palves@redhat.com>
9559
9560         * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
9561         * NEWS: Mention maint test-settings KIND.
9562         * maint-test-settings.c: New file.
9563
9564 2019-06-13  Pedro Alves  <palves@redhat.com>
9565
9566         * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
9567         completer.
9568         (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
9569         "set" completers.
9570
9571 2019-06-13  Pedro Alves  <palves@redhat.com>
9572
9573         * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
9574         after item.
9575
9576 2019-06-13  Pedro Alves  <palves@redhat.com>
9577
9578         * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
9579
9580 2019-06-13  Pedro Alves <palves@redhat.com>
9581
9582         * ax-gdb.c (agent_command_1): Remove skip_spaces call.
9583         * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
9584         call.
9585         * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
9586         * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
9587         calls.
9588         (check_for_argument): Skip spaces after argument.
9589
9590 2019-06-13  Pedro Alves  <palves@redhat.com>
9591
9592         * thread.c (thread_apply_command): Adjust TID parsing.
9593         * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
9594         detected before end of string.
9595         (tid_is_in_list): Error out if LIST is invalid.
9596
9597 2019-06-13  Pedro Alves  <palves@redhat.com>
9598
9599         * completer.c (complete_line_internal_1): Rewind completion word
9600         point.
9601         (completion_tracker::advance_custom_word_point_by): Change
9602         parameter type to int.
9603         * completer.h (completion_tracker::advance_custom_word_point_by):
9604         Likewise.
9605
9606 2019-06-13  Pedro Alves  <palves@redhat.com>
9607
9608         * completer.c (advance_to_completion_word): Handle delimiters.
9609
9610 2019-06-11  Bernhard Heckel  <bernhard.heckel@intel.com>
9611
9612         * dwarf2read.c (add_partial_symbol): Skip nameless modules.
9613
9614 2019-06-11  Tom Tromey  <tom@tromey.com>
9615
9616         * common/common-utils.c (xmalloc, xrealloc, xcalloc)
9617         (xmalloc_failed): Move to alloc.c.
9618         * alloc.c: New file.
9619         * Makefile.in (COMMON_SFILES): Add alloc.c.
9620
9621 2019-06-11  Tom Tromey  <tom@tromey.com>
9622
9623         * nat/linux-waitpid.c: Don't include server.h.
9624         (linux_debug): Remove.
9625         (my_waitpid): Update.
9626
9627 2019-06-11  Tom Tromey  <tromey@adacore.com>
9628
9629         * infcall.c (_initialize_infcall): Remove trailing newline from
9630         help.
9631         * user-regs.c (_initialize_user_regs): Remove trailing newline
9632         from help.
9633         * typeprint.c (_initialize_typeprint): Remove trailing newline
9634         from help.
9635         * reverse.c (_initialize_reverse): Remove trailing newlines from
9636         help.
9637         * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
9638         from help.
9639         * language.c (add_set_language_command): Remove trailing newline
9640         from help.
9641         * infcmd.c (_initialize_infcmd): Remove trailing newlines from
9642         help.
9643         * disasm.c (_initialize_disasm): Remove trailing newline from
9644         help.
9645         * top.c (init_main): Remove trailing newline from help.
9646         * interps.c (_initialize_interpreter): Remove trailing newline
9647         from help.
9648         * btrace.c (_initialize_btrace): Remove trailing newlines from
9649         help.
9650         * breakpoint.c (_initialize_breakpoint): Remove trailing newline
9651         from help.
9652         * python/python.c (_initialize_python): Remove trailing newline
9653         from help.
9654         * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
9655         help.
9656         * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
9657         from help.  Reformat some text.
9658         * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
9659         from help.
9660         * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
9661         newline from help.
9662
9663 2019-06-11  Tom Tromey  <tromey@adacore.com>
9664
9665         * darwin-nat.c (darwin_decode_exception_message)
9666         (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
9667
9668 2019-06-10  Andrew Burgess  <andrew.burgess@embecosm.com>
9669
9670         * valops.c (value_slice): Check for not allocated or not
9671         associated values.
9672
9673 2019-06-10  Tom de Vries  <tdevries@suse.de>
9674
9675         PR gdb/24618
9676         * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
9677         sure an empty slot (defined by a 32-bit zero pair) is recognized as
9678         invalid.
9679
9680 2019-06-10  Tom de Vries  <tdevries@suse.de>
9681
9682         PR gdb/24611
9683         * linespec.c (linespec_lexer_lex_string): Remove incorrect
9684         "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon.  Add assert.
9685
9686 2019-06-10  Tom de Vries  <tdevries@suse.de>
9687
9688         PR symtab/24545
9689         * symtab.c (struct demangled_name_entry): Add language field.
9690         (symbol_set_names):  Revert "[gdb/symtab] Fix language of duplicate
9691         static minimal symbol".  Set and use language field.
9692
9693 2019-06-10  Tom Tromey  <tromey@adacore.com>
9694
9695         * ada-lang.c (_initialize_ada_language): Update help text.
9696
9697 2019-06-10  Tom Tromey  <tromey@adacore.com>
9698
9699         * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
9700         with a newline.
9701         * guile/guile.c (handle_boot_error): Don't end warning with a
9702         newline.
9703         * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
9704         warning with a newline.
9705         * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
9706         newline.
9707         (s12z_frame_cache): Likewise.
9708         * dwarf-index-cache.c (index_cache::store): Don't end warning with
9709         a newline.
9710         * solib-svr4.c (disable_probes_interface): Don't end warning with
9711         a newline.
9712         * nat/fork-inferior.c (fork_inferior): Don't end warning with a
9713         newline.
9714         * python/python.c (do_finish_initialization): Don't end warning
9715         with a newline.
9716
9717 2019-06-10  Tom Tromey  <tom@tromey.com>
9718
9719         * python/py-breakpoint.c (gdbpy_breakpoint_created)
9720         (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
9721         gdbpy_enter.
9722
9723 2019-06-10  Tom Tromey  <tromey@adacore.com>
9724
9725         * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
9726         data.
9727         (elf_new_init): Don't call stabsread_new_init.
9728         * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
9729         (elfstab_build_psymtabs): Likewise.  Call stabsread_new_init.
9730         * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
9731
9732 2019-06-10  Tom de Vries  <tdevries@suse.de>
9733
9734         PR symtab/16264
9735         PR symtab/24517
9736         * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
9737
9738 2019-06-06  Руслан Ижбулатов <lrn1986@gmail.com>
9739
9740         * source.c (find_and_open_source): Also rewrite relative file
9741         names.
9742
9743 2019-04-26  Amos Bird  <amosbird@gmail.com>
9744
9745         * annotate.c (annotate_thread_exited): Add "thread-exited"
9746         annotation.
9747
9748 2019-06-06  Tom Tromey  <tromey@adacore.com>
9749
9750         * maint.h (class scoped_command_stats): Use
9751         DISABLE_COPY_AND_ASSIGN.
9752         <print_time>: New method.
9753         * maint.c (scoped_command_stats, ~scoped_command_stats): Call
9754         print_time.
9755         (scoped_command_stats::print_time): New method.
9756
9757 2019-06-05  Andrew Burgess  <andrew.burgess@embecosm.com>
9758
9759         * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
9760         instructions of lengths 6 or 8 bytes.
9761
9762 2019-06-04  Pedro Alves  <palves@redhat.com>
9763
9764         * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
9765
9766         * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
9767         * breakpoint.c (condition_completer): Likewise.
9768         * cli/cli-dump.c (scan_expression): Likewise.
9769         * common/filestuff.c (mkdir_recursive): Likewise.
9770         * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
9771         * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
9772         (gdb_abspath): Likewise.
9773         * compile/compile-cplus-types.c
9774         (compile_cplus_instance::decl_name): Likewise.
9775         * completer.c (complete_explicit_location):
9776         (signal_completer, reg_or_group_completer_1): Likewise.
9777         * cp-support.c (cp_remove_params_if_any): Likewise.
9778         * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
9779         * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
9780         * infcmd.c (strip_bg_char): Likewise.
9781         * linespec.c (copy_token_string): Likewise.
9782         * mi/mi-main.c (output_cores): Likewise.
9783         * psymtab.c (psymtab_search_name):
9784         * symfile.c (test_set_ext_lang_command): Likewise.
9785         * target.c (target_fileio_read_stralloc): Likewise.
9786         * tui/tui-regs.c (tui_reggroup_completer): Likewise.
9787         * value.c (complete_internalvar): Likewise.
9788
9789 2019-06-04  Christian Biesinger  <cbiesinger@google.com>
9790
9791         Add objfile property to gdb.Type.
9792         * NEWS: Mention Python API addition.
9793         * python/py-type.c (typy_get_objfile): New method.
9794
9795 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9796
9797         * NEWS: Mention the new set|show style [title|highlight].
9798         Mention changes to "show style", "help" and "apropos".
9799
9800 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9801
9802         * cli/cli-decode.h (apropos_cmd): Add verbose argument.
9803         * cli/cli-decode.c (apropos_cmd): Likewise.  Use print_doc_of_command
9804         instead of print_help_for_command.
9805         (print_doc_of_command): New function.
9806         (help_list): Add 'apropos -v word' suggestion.
9807         (print_help_for_command): Style the command name using title style.
9808         * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
9809         (_initialize_cli_cmds): Describe -v in apropos_command help.
9810
9811 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9812
9813         * cli/cli-style.h (cli_style_option): Add name in constructor,
9814         add m_name class member, add constructor with intensity,
9815         add name class function.
9816         (cli_style_option::add_setshow_commands): Remove name argument.
9817         (highlight_style, title_style): New styles.
9818         * cli/cli-style.c (do_show): New function that shows a style
9819         characteristic styling the style name with itself.
9820         (set_style_name): New function.
9821         (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
9822         Update all callers according to the changes in cli/cli-style.h.
9823         * utils.h (fputs_highlighted): New function.
9824         * utils.c (fputs_highlighted): Likewise.
9825
9826 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9827
9828         * NEWS: Mention new pipe command and new convenience variables.
9829
9830 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9831
9832         * cli/cli-cmds.c (pipe_command): New function.
9833         (_initialize_cli_cmds): Call add_com for pipe_command.
9834         Define | as an alias for pipe.
9835         (exit_status_set_internal_vars): New function.
9836         (shell_escape): Call exit_status_set_internal_vars.
9837         cli/cli-decode.c (find_command_name_length): Recognize | as
9838         a single character command.
9839
9840 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9841
9842         * gdbcmd.h (execute_command_to_ui_file): New declaration.
9843         top.c (execute_command_to_ui_file): New function, mostly a copy
9844         of execute_command_to_string.
9845         (execute_command_to_string): Implement by calling
9846         execute_command_to_ui_file.
9847
9848 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9849
9850         * top.h (saved_command_line): Remove declaration.
9851         * top.c (previous_saved_command_line, previous_repeat_arguments):
9852         New variables.
9853         (saved_command_line): Make static, define together with other
9854         'repeat variables'.
9855         (dont_repeat): Clear repeat_arguments.
9856         (repeat_previous, get_saved_command_line, save_command_line):
9857         New functions.
9858         (gdb_init): Initialize saved_command_line
9859         and previous_saved_command_line.
9860         * main.c (captured_main_1): Remove saved_command_line initialization.
9861         * event-top.c (handle_line_of_input): Update to use
9862         the new 'repeat' related functions instead of direct access to
9863         saved_command_line.
9864         * command.h (repeat_previous, get_saved_command_line,
9865         save_command_line): New declarations.
9866         (dont_repeat): Add comment.
9867
9868 2019-05-30  Tom Tromey  <tromey@adacore.com>
9869
9870         * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
9871         Fix comment.
9872         (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
9873
9874 2019-05-30  Jan Vrany  <jan.vrany@fit.cvut.cz>
9875
9876         PR cli/24587
9877         * completer.c (complete): Initialize variable word.
9878
9879 2019-05-29  Sergio Durigan Junior  <sergiodj@redhat.com>
9880
9881         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
9882         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
9883         * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
9884         'body' is NULL to the outter 'if', protecting the '!is_define'
9885         situation as well.
9886
9887 2019-05-29  Tom Tromey  <tromey@adacore.com>
9888
9889         * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
9890         (dwarf_unknown): New function.
9891         (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
9892         (dwarf_type_encoding_name): Use dwarf_unknown.
9893
9894 2019-05-29  Tom Tromey  <tromey@adacore.com>
9895
9896         PR c++/20020:
9897         * cp-valprint.c (cp_print_value_fields): Call
9898         cp_print_static_field inside "try".
9899
9900 2019-05-29  Tom Tromey  <tromey@adacore.com>
9901
9902         * inflow.c (struct terminal_info): Add default operator=.
9903         * configure: Rebuild.
9904         * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
9905         -Wdeprecated-copy-dtor, -Wredundant-move.
9906
9907 2019-05-29  Tom Tromey  <tromey@adacore.com>
9908
9909         * NEWS: Add entry.
9910         * infcmd.c (print_return_value_1): Handle finish_print
9911         option.
9912         (show_print_finish): New function.
9913         (_initialize_infcmd): Add "set/show print finish" commands.
9914         * valprint.c (user_print_options): Initialize new member.
9915         * valprint.h (struct value_print_options) <finish_print>: New
9916         member.
9917
9918 2019-05-28  Tom Tromey  <tromey@adacore.com>
9919
9920         * ada-lang.c (ada_remove_Xbn_suffix)
9921         (find_old_style_renaming_symbol)
9922         (parse_old_style_renaming): Remove.
9923         (ada_find_renaming_symbol): Don't call
9924         find_old_style_renaming_symbol.
9925         (ada_is_renaming_symbol): Rename from
9926         ada_find_renaming_symbol.  Remove "block" parameter.  Return
9927         bool.  Now static.
9928         (ada_read_var_value): Update and simplify.
9929         * ada-exp.y (write_var_or_type): Remove old code.
9930
9931 2019-05-28  Alan Hayward  <alan.hayward@arm.com>
9932
9933         PR gdb/25010
9934         * event-top.c: Remove include comment.
9935         * inflow.c (class scoped_ignore_sigttou): Move from here...
9936         * inflow.h (class scoped_ignore_sigttou): ...to here.
9937         * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
9938         * top.c:  Remove include comment.
9939
9940 2019-05-27  Tom Tromey  <tom@tromey.com>
9941
9942         * NEWS: Fix typo.
9943
9944 2019-05-22  Tom Tromey  <tromey@adacore.com>
9945
9946         * target.c (target_follow_exec): Constify parameter.
9947         * target-delegates.c: Rebuild.
9948         * remote.c (remote_target::follow_exec): Constify parameter.
9949         * infrun.c (follow_exec): Constify parameter.
9950         * target.h (struct target_ops) <follow_exec>: Constify parameter.
9951         (target_follow_exec): Likewise.
9952
9953 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
9954
9955         * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
9956         DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
9957
9958 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
9959
9960         * NEWS: Add debugredirect and testsuite sections.
9961
9962 2019-05-22  Simon Cook  <simon.cook@embecosm.com>
9963
9964         * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
9965         target descriptions using exclusively floating point register name
9966         aliases.
9967
9968 2019-05-21  Andrew Burgess  <andrew.burgess@embecosm.com>
9969
9970         PR gdb/18644:
9971         * f-lang.c (build_fortran_types): Handle the case where
9972         gdbarch_floatformat_for_type returns a nullptr.
9973
9974 2019-05-21  Tom de Vries  <tdevries@suse.de>
9975
9976         PR cli/24587
9977         * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
9978
9979 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
9980
9981         PR gdb/18644:
9982         * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
9983         16-byte floats.
9984         * i386-tdep.c (i386_floatformat_for_type): Use
9985         floatformats_ia64_quad for the 16-byte floating point component
9986         within a fortran 32-byte complex number.
9987
9988 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
9989
9990         * dwarf2read.c (struct cu_partial_die_info): Add constructor,
9991         delete default constructor.
9992         (find_partial_die): Update to return const struct.
9993         (partial_die_parent_scope): Move variable declaration into scope
9994         of its use and change its type to auto.
9995         (guess_partial_die_structure_name): Likewise.
9996         (partial_die_info::fixup): Likewise.
9997
9998 2019-05-17  Tom Tromey  <tromey@adacore.com>
9999
10000         * source.c (find_and_open_source): Remove cast.
10001
10002 2019-05-17  Tom Tromey  <tromey@adacore.com>
10003
10004         * annotate.c (annotate_source): Make "filename" const.
10005         * annotate.h (annotate_source): Use const.
10006
10007 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
10008
10009         * disasm.c (set_disassembler_options): Send errors to stderr.
10010
10011 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
10012
10013         * cli/cli-interp.c (struct saved_output_files): Add saved entry.
10014         (cli_interp_base::set_logging): Check debug_redirect.
10015         * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
10016         * cli/cli-logging.c (debug_redirect): Add static variable.
10017         (pop_output_files): Add default param.
10018         (handle_redirections): Print debug setting.
10019         (show_logging_command): Likewise.
10020         (_initialize_cli_logging): Add debugredirect command.
10021         * interps.c (current_interp_set_logging): Add debug_redirect
10022         parameter.
10023         * interps.h (set_logging): Add debug_redirect parameter.
10024         (current_interp_set_logging): Likewise.
10025         * mi/mi-common.h: Likewise.
10026         * mi/mi-interp.c (mi_interp::set_logging): Likewise.
10027
10028 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
10029             Tom Tromey  <tromey@adacore.com>
10030
10031         * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
10032         directly.
10033         * cli/cli-interp.h (make_logging_output): Remove declaration.
10034         * cli/cli-logging.c (make_logging_output): Remove function.
10035         * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
10036         directly.
10037         * ui-file.c (tee_file::tee_file): Remove bools.
10038         (tee_file::~tee_file): Remove deletes.
10039         * ui-file.h (tee_file): Remove bools.
10040
10041 2019-01-28  Jan Vrany  <jan.vrany@fit.cvut.cz>
10042
10043         * mi/mi-cmds.h (mi_cmd_complete): New function.
10044         * mi/mi-main.c (mi_cmd_complete): Likewise.
10045         * mi/mi-cmds.c: Define new MI command -complete.
10046         * NEWS: Mention new -complete command.
10047
10048 2019-01-24  Jan Vrany  <jan.vrany@fit.cvut.cz>
10049
10050         * completer.h (complete): New function.
10051         * completer.c (complete): Likewise.
10052         * cli/cli-cmds.c: (complete_command): Update to use new complete()
10053         function defined in completer.h.
10054
10055 2019-05-17  Jan Vrany  <jan.vrany@fit.cvut.cz>
10056
10057         * MAINTAINERS (Write After Approval): Add myself.
10058
10059 2019-05-17  Tom de Vries  <tdevries@suse.de>
10060
10061         PR gdb/24094
10062         * dwarf2read.c (struct cu_partial_die_info): New struct.
10063         (find_partial_die): Return cu_partial_die_info.
10064         (partial_die_parent_scope, guess_partial_die_structure_name)
10065         (partial_die_info::fixup): Handle new return type of find_partial_die.
10066
10067 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
10068
10069         PR breakpoints/24541
10070         * stap-probe.c (stap_parse_register_operand): Make "regname" an
10071         "std::string", simplifying the algorithm.
10072
10073 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
10074
10075         * stap-probe.c (handle_stap_probe): Fix complaint formatting.
10076         (stap_static_probe_ops::get_probes): Likewise.
10077
10078 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
10079
10080         * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
10081         '-')" and "else if".
10082         (stap_parse_single_operand): Join checks for
10083         "gdbarch_stap_parse_special_token_p" and
10084         "gdbarch_stap_parse_special_token" in the same "if" statement.
10085         Invert check when verifying for operation on register
10086         displacement.
10087
10088 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
10089
10090         * stap-probe.c (stap_get_opcode): Update comment.
10091         (stap_get_expected_argument_type): Likewise.
10092         (handle_stap_probe): Likewise.
10093
10094 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
10095
10096         * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
10097         return type to 'bool'.  Adjust comment.  Use 'bool' when
10098         appropriate.
10099         (i386_stap_parse_special_token_three_arg_disp): Likewise.
10100         * stap-probe.c (stap_parse_argument_1): Likewise.
10101         (stap_is_operator): Likewise.
10102         (stap_is_generic_prefix): Likewise.
10103         (stap_is_register_prefix): Likewise.
10104         (stap_is_register_indirection_prefix): Likewise.
10105         (stap_is_integer_prefix): Likewise.
10106         (stap_generic_check_suffix): Likewise.
10107         (stap_check_integer_suffix): Likewise.
10108         (stap_check_register_suffix): Likewise.
10109         (stap_check_register_indirection_suffix): Likewise.
10110         (stap_parse_register_operand): Likewise.
10111         (stap_parse_single_operand): Likewise.
10112         (stap_parse_argument_1): Likewise.
10113         (stap_probe::get_argument_count): Likewise.
10114         (stap_is_operator): Likewise.
10115
10116 2019-05-16  Tom Tromey  <tromey@adacore.com>
10117
10118         * darwin-nat.c (thread_info_from_private_thread_info): Add struct
10119         keyword to foreach.
10120
10121 2019-05-15  Simon Marchi  <simon.marchi@efficios.com>
10122
10123         * linux-thread-db.c (try_thread_db_load_1): Change return type
10124         to bool.
10125         (try_thread_db_load): Likewise.
10126         (try_thread_db_load_from_pdir_1): Likewise.
10127         (try_thread_db_load_from_pdir): Likewise.
10128         (try_thread_db_load_from_sdir): Likewise.
10129         (try_thread_db_load_from_dir): Likewise.
10130         (thread_db_load_search): Likewise.
10131         (has_libpthread): Likewise.
10132         (thread_db_load): Likewise.
10133
10134 2019-05-15  Sergio Durigan Junior  <sergiodj@redhat.com>
10135
10136         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
10137         * dwarf2read.c (parse_macro_definition): Check whether 'body' is
10138         NULL, and complain/return if that's the case.
10139
10140 2019-05-15  John Darrington <john@darrington.wattle.id.au>
10141
10142         * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
10143         (advance, posn, abstract_read_memory): New functions.
10144         [struct mem_read_abstraction]: New struct.
10145         (s12z_frame_cache): Use opcodes API to interpret stack frame code.
10146
10147 2019-05-14  Tom Tromey  <tromey@adacore.com>
10148
10149         * ada-lang.c (coerce_unspec_val_to_type): Only set address when
10150         value is not lval_memory.
10151
10152 2019-05-14  Tom Tromey  <tromey@adacore.com>
10153
10154         * solib.c (info_sharedlibrary_command): Style the file name.
10155
10156 2019-05-14  Alan Hayward  <alan.hayward@arm.com>
10157
10158         * aarch64-tdep.c (aarch64_vnh_type): Add half view.
10159         (aarch64_vnv_type): Likewise.
10160         * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
10161         * common/tdesc.c: Likewise.
10162         * common/tdesc.h (enum tdesc_type_kind): Likewise.
10163         * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
10164         * features/aarch64-fpu.xml: Add ieee half view.
10165         * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
10166         * gdbtypes.c (gdbtypes_post_init): Add builtin_half
10167         * gdbtypes.h (struct builtin_type): Likewise.
10168         (struct objfile_type): Likewise.
10169
10170 2019-05-12  Paul Naert  <paul.naert@polymtl.ca>
10171
10172         * language.c (language_sniff_from_mangled_name): Fix "langauge"
10173         typo.
10174         * location.h (string_to_event_location): Likewise.
10175
10176 2019-05-11  Joel Brobecker  <brobecker@adacore.com>
10177
10178         GDB 8.3 released.
10179
10180 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
10181
10182         * breakpoint.h (fix_multi_location_breakpoint_output_globally):
10183         New variable declaration.
10184         * breakpoint.c (fix_multi_location_breakpoint_output_globally):
10185         New variable.
10186         (print_one_breakpoint): Use ui_out::test_flags and new global
10187         variable to compute use_fixed_output.
10188         * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
10189         Remove.
10190         * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
10191         (mi_multi_location_breakpoint_output_fixed): Remove.
10192         (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
10193         new variable.
10194         * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
10195         fix_multi_location_breakpoint_output flag if version >= 3.
10196         * ui-out.h (enum ui_out_flag)
10197         <fix_multi_location_breakpoint_output>: New enumerator.
10198
10199 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
10200
10201         * contrib/cc-with-tweaks.sh: Validate dwz's work.
10202
10203 2019-05-10  Tom Tromey  <tromey@adacore.com>
10204
10205         * ada-lang.c (catch_ada_completer): New function.
10206         (_initialize_ada_language): Use it.
10207
10208 2019-05-10  Tom Tromey  <tromey@adacore.com>
10209
10210         * thread.c (print_thread_info): Make "requested_threads" const.
10211         * gdbthread.h (print_thread_info): Make "requested_threads"
10212         const.
10213         * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
10214         * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
10215
10216 2019-05-08  Tom Tromey  <tom@tromey.com>
10217
10218         * gdbtypes.c (objfile_type_data): Change type.
10219         (objfile_type, _initialize_gdbtypes): Update.
10220
10221 2019-05-08  Tom Tromey  <tom@tromey.com>
10222
10223         * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
10224         (dwarf2_frame_find_fde, dwarf2_build_frame_info)
10225         (_initialize_dwarf2_frame): Update.
10226
10227 2019-05-08  Tom Tromey  <tom@tromey.com>
10228
10229         * objc-lang.c (objc_objfile_data): Change type.
10230         (find_methods): Update.
10231         (_initialize_objc_lang): Remove.
10232
10233 2019-05-08  Tom Tromey  <tom@tromey.com>
10234
10235         * stabsread.c (rs6000_builtin_type_data): Change type.
10236         (rs6000_builtin_type, _initialize_stabsread): Update.
10237
10238 2019-05-08  Tom Tromey  <tom@tromey.com>
10239
10240         * mips-tdep.c (mips_pdr_data): Remove.
10241         (_initialize_mips_tdep): Update.
10242
10243 2019-05-08  Tom Tromey  <tom@tromey.com>
10244
10245         * hppa-tdep.c (hppa_objfile_priv_data): Change type.
10246         (hppa_init_objfile_priv_data, read_unwind_info)
10247         (find_unwind_entry, _initialize_hppa_tdep): Update.
10248
10249 2019-05-08  Tom Tromey  <tom@tromey.com>
10250
10251         * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
10252         (elf_gnu_ifunc_record_cache): Update.  Don't allocate hash table
10253         on obstack.
10254         (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
10255
10256 2019-05-08  Tom Tromey  <tom@tromey.com>
10257
10258         * mdebugread.c (basic_type_data): Change type.
10259         (basic_type, _initialize_mdebugread): Update.
10260
10261 2019-05-08  Tom Tromey  <tom@tromey.com>
10262
10263         * common/gdb_unique_ptr.h (struct noop_deleter): New.
10264
10265 2019-05-08  Tom Tromey  <tom@tromey.com>
10266
10267         * nto-tdep.c (nto_inferior_data_reg): Change type.
10268         (nto_inferior_data): Update.
10269         (nto_inferior_data_cleanup, nto_new_inferior_data)
10270         (_initialize_nto_tdep): Remove.
10271         * nto-tdep.h (struct nto_inferior_data): Add initializers.
10272
10273 2019-05-08  Tom Tromey  <tom@tromey.com>
10274
10275         * ada-lang.c (struct ada_inferior_data): Add initializers.
10276         (ada_inferior_data): Change type.
10277         (ada_inferior_data_cleanup): Remove.
10278         (get_ada_inferior_data, ada_inferior_exit)
10279         (struct ada_pspace_data): Add initializers, destructor.
10280         (ada_pspace_data_handle): Change type.
10281         (get_ada_pspace_data): Update.
10282         (ada_pspace_data_cleanup): Remove.
10283
10284 2019-05-08  Tom Tromey  <tom@tromey.com>
10285
10286         * coffread.c (struct coff_symfile_info): Add initializers.
10287         (coff_objfile_data_key): Move lower.  Change type.
10288         (coff_symfile_init, coff_symfile_read, _initialize_coffread):
10289         Update.
10290         (coff_free_info): Remove.
10291
10292 2019-05-08  Tom Tromey  <tom@tromey.com>
10293
10294         * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
10295         (fbsd_pspace_data_handle): Move lower.  Change type.
10296         (get_fbsd_pspace_data): Update.
10297         (fbsd_pspace_data_cleanup): Remove.
10298         (_initialize_fbsd_tdep): Update.
10299
10300 2019-05-08  Tom Tromey  <tom@tromey.com>
10301
10302         * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
10303         (get_ada_tasks_pspace_data): Update.
10304         (ada_tasks_pspace_data_cleanup): Remove.
10305         (_initialize_tasks): Update.
10306         (ada_tasks_inferior_data_handle): Change type.
10307         (get_ada_tasks_inferior_data): Update.
10308         (ada_tasks_inferior_data_cleanup): Remove.
10309         (struct ada_tasks_pspace_data): Add initializers.
10310
10311 2019-05-08  Tom Tromey  <tom@tromey.com>
10312
10313         * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
10314         * symfile-debug.c (debug_sym_get_probes): Change type.
10315         * stap-probe.c (handle_stap_probe):
10316         (stap_static_probe_ops::get_probes): Change type.
10317         * probe.h (class static_probe_ops) <get_probes>: Change type.
10318         * probe.c (class any_static_probe_ops) <get_probes>: Change type.
10319         (parse_probes_in_pspace): Update.
10320         (find_probes_in_objfile, find_probe_by_pc, collect_probes):
10321         Update.
10322         (any_static_probe_ops::get_probes): Change type.
10323         * elfread.c (elfread_data): New typedef.
10324         (probe_key): Change type.
10325         (elf_get_probes): Likewise.  Update.
10326         (probe_key_free): Remove.
10327         (_initialize_elfread): Update.
10328         * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
10329         Change type.
10330         (dtrace_process_dof_probe, dtrace_process_dof)
10331         (dtrace_static_probe_ops::get_probe): Change type.
10332
10333 2019-05-08  Tom Tromey  <tom@tromey.com>
10334
10335         * xcoffread.c (struct xcoff_symfile_info): Rename from
10336         coff_symfile_info.  Add initializers.
10337         (xcoff_objfile_data_key): Move lower.  Change type.
10338         (XCOFF_DATA): Rewrite.
10339         (xcoff_free_info): Remove.
10340         (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
10341         (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
10342         (xcoff_initial_scan): Update.
10343
10344 2019-05-08  Tom Tromey  <tom@tromey.com>
10345
10346         * solib-svr4.c (struct svr4_info): Add initializers and
10347         destructor.
10348         <probes_table>: Now an htab_up.
10349         (solib_svr4_pspace_data): Change type.
10350         (free_probes_table): Simplify.
10351         (~svr4_info): Rename from svr4_pspace_data_cleanup.
10352         (get_svr4_info, probes_table_htab_remove_objfile_probes)
10353         (probes_table_remove_objfile_probes, register_solib_event_probe)
10354         (solib_event_probe_at, svr4_update_solib_event_breakpoint)
10355         (_initialize_svr4_solib): Update.
10356
10357 2019-05-08  Tom Tromey  <tom@tromey.com>
10358
10359         * remote.c (remote_pspace_data): Change type.
10360         (remote_pspace_data_cleanup): Remove.
10361         (get_remote_exec_file, set_pspace_remote_exec_file)
10362         (_initialize_remote): Update.
10363
10364 2019-05-08  Tom Tromey  <tom@tromey.com>
10365
10366         * breakpoint.c (breakpoint_objfile_key): Change type.
10367         (get_breakpoint_objfile_data): Update.
10368         (free_breakpoint_objfile_data): Remove.
10369         (_initialize_breakpoint): Update.
10370
10371 2019-05-08  Tom Tromey  <tom@tromey.com>
10372
10373         * linux-tdep.c (struct linux_info): Add initializers.
10374         (linux_inferior_data): Move.  Change type.
10375         (invalidate_linux_cache_inf): Update.
10376         (linux_inferior_data_cleanup): Remove.
10377         (get_linux_inferior_data, _initialize_linux_tdep): Update.
10378
10379 2019-05-08  Tom Tromey  <tom@tromey.com>
10380
10381         * auxv.c (auxv_inferior_data): Move.  Change type.
10382         (auxv_inferior_data_cleanup): Remove.
10383         (invalidate_auxv_cache_inf): Rewrite.
10384         (get_auxv_inferior_data, _initialize_auxv): Update.
10385
10386 2019-05-08  Tom Tromey  <tom@tromey.com>
10387
10388         * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
10389         (symfile_debug_objfile_data_key): Change type.
10390         (symfile_debug_installed, debug_qf_has_symbols)
10391         (debug_qf_find_last_source_symtab)
10392         (debug_qf_forget_cached_source_info)
10393         (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
10394         (debug_qf_print_stats, debug_qf_dump)
10395         (debug_qf_expand_symtabs_for_function)
10396         (debug_qf_expand_all_symtabs)
10397         (debug_qf_expand_symtabs_with_fullname)
10398         (debug_qf_map_matching_symbols)
10399         (debug_qf_expand_symtabs_matching)
10400         (debug_qf_find_pc_sect_compunit_symtab)
10401         (debug_qf_map_symbol_filenames)
10402         (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
10403         (debug_sym_new_init, debug_sym_init, debug_sym_read)
10404         (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
10405         (debug_sym_read_linetable, debug_sym_relocate): Update.
10406         (symfile_debug_free_objfile): Remove.
10407         (install_symfile_debug_logging, _initialize_symfile_debug):
10408         Update.
10409
10410 2019-05-08  Tom Tromey  <tom@tromey.com>
10411
10412         * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
10413         allocate_on_obstack.
10414         * dwarf2read.c (dwarf2_objfile_data_key): Change type.
10415         (get_dwarf2_per_objfile): Update.
10416         (set_dwarf2_per_objfile): Remove.
10417         (dwarf2_has_info, dwarf2_get_section_info): Update.
10418         (dwarf2_free_objfile): Remove.
10419         (_initialize_dwarf2_read): Update.
10420
10421 2019-05-08  Tom Tromey  <tom@tromey.com>
10422
10423         * auto-load.c (struct auto_load_pspace_info): Add destructor and
10424         initializers.
10425         <unsupported_script_warning_printed,
10426         script_not_found_warning_printed>: Now bool.
10427         (auto_load_pspace_data): Change type.
10428         (~auto_load_pspace_info): Rename from
10429         auto_load_pspace_data_cleanup.
10430         (get_auto_load_pspace_data, init_loaded_scripts_info)
10431         (clear_section_scripts, maybe_print_unsupported_script_warning)
10432         (maybe_print_script_not_found_warning, _initialize_auto_load):
10433         Update.
10434
10435 2019-05-08  Tom Tromey  <tom@tromey.com>
10436
10437         * objfiles.c (objfile_pspace_info): Add destructor and
10438         initializers.
10439         (objfiles_pspace_data): Change type.
10440         (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
10441         (get_objfile_pspace_data): Update.
10442         (objfiles_bfd_data): Change type.
10443         (get_objfile_bfd_data): Update.
10444         (objfile_bfd_data_free, _initialize_objfiles): Remove.
10445
10446 2019-05-08  Tom Tromey  <tom@tromey.com>
10447
10448         * break-catch-syscall.c (catch_syscall_inferior_data): Move.
10449         Change type.
10450         (get_catch_syscall_inferior_data): Update.
10451         (catch_syscall_inferior_data_cleanup): Remove.
10452         (_initialize_break_catch_syscall): Update.
10453
10454 2019-05-08  Tom Tromey  <tom@tromey.com>
10455
10456         * inflow.c (struct terminal_info): Add destructor and
10457         initializers.
10458         (inflow_inferior_data): Change type.
10459         (~terminal_info): Rename from inflow_inferior_data_cleanup.
10460         (get_inflow_inferior_data, inflow_inferior_exit)
10461         (swap_terminal_info, _initialize_inflow): Update.
10462
10463 2019-05-08  Tom Tromey  <tom@tromey.com>
10464
10465         * target-dcache.c (target_dcache_cleanup): Remove.
10466         (target_dcache_aspace_key): Change type.
10467         (target_dcache_init_p, target_dcache_invalidate)
10468         (target_dcache_get, target_dcache_get_or_init)
10469         (_initialize_target_dcache): Update.
10470         * dcache.h (struct dcache_deleter): New.
10471
10472 2019-05-08  Tom Tromey  <tom@tromey.com>
10473
10474         * symtab.c (struct symbol_cache): Add destructor and
10475         initializers.
10476         (symbol_cache_key): Move.  Change type.
10477         (make_symbol_cache, free_symbol_cache): Remove.
10478         (get_symbol_cache): Update.
10479         (symbol_cache_cleanup): Remove.
10480         (ALL_PSPACES, symbol_cache_flush)
10481         (maintenance_print_symbol_cache)
10482         (maintenance_print_symbol_cache_statistics, _initialize_symtab):
10483         Update.
10484
10485 2019-05-08  Tom Tromey  <tom@tromey.com>
10486
10487         * symtab.c (struct main_info): Add destructor and initializers.
10488         (main_progspace_key): Move.  Change type.
10489         (get_main_info): Update.
10490         (main_info_cleanup): Remove.
10491         (_initialize_symtab): Update.
10492
10493 2019-05-08  Tom Tromey  <tom@tromey.com>
10494
10495         * registry.h (DECLARE_REGISTRY): Define the _key class.
10496
10497 2019-05-08  Andrew Burgess  <andrew.burgess@embecosm.com>
10498
10499         * NEWS: Merge two 'New commands' sections.
10500
10501 2019-05-08  Joel Brobecker  <brobecker@adacore.com>
10502
10503         * ada-valprint.c (ada_val_print_gnat_array): Remove language
10504         parameter and use Ada language definition instead.
10505         (ada_val_print_ptr): Remove unused language parameter.
10506         (ada_val_print_num): Remove language parameter and use Ada language
10507         definition instead.
10508         (ada_val_print_enum, ada_val_print_flt): Remove unused language
10509         parameter.
10510         (ada_val_print_struct_union, ada_val_print_ref): Remove language
10511         parameter and use Ada language definition instead.
10512         (ada_val_print_1): Update all ada_val_print_xxx calls.
10513         Remove language parameter.
10514         (ada_val_print): Update ada_val_print_1 call.
10515
10516 2019-05-08  Tom Tromey  <tromey@adacore.com>
10517
10518         * remote.c (remote_hw_watchpoint_limit)
10519         (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
10520         Now static.
10521
10522 2019-05-08  Tom Tromey  <tromey@adacore.com>
10523
10524         * maint.c (_initialize_maint_cmds): Move initialization code to
10525         remote.c.
10526         (watchdog, show_watchdog): Move to remote.c.
10527         * remote.c (watchdog, show_watchdog): Move from maint.c.  Make
10528         "watchdog" static.
10529         (_initialize_remote): Move initialization code from maint.c.
10530         * defs.h (watchdog): Don't declare.
10531
10532 2019-05-08  Tom Tromey  <tromey@adacore.com>
10533
10534         * tui/tui-interp.c: Include main.h.
10535         * interps.c: Include main.h.
10536         * main.h (interpreter_p): Declare.
10537         * defs.h (interpreter_p): Don't declare.
10538
10539 2019-05-08  Tom Tromey  <tromey@adacore.com>
10540
10541         * dwarf2loc.c: Include dwarf2read.h.
10542         * defs.h (read_unsigned_leb128): Don't declare.
10543         * dwarf2read.h (read_unsigned_leb128): Declare.
10544
10545 2019-05-08  Tom Tromey  <tromey@adacore.com>
10546
10547         * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
10548         method.
10549
10550 2019-05-08  Tom Tromey  <tromey@adacore.com>
10551
10552         * utils.c (fputs_maybe_filtered): Reset style after paging, even
10553         when no wrap column is set.
10554
10555 2019-05-08  Tom Tromey  <tromey@adacore.com>
10556
10557         * c-lang.c (c_get_string): Handle non-C-style arrays.
10558
10559 2019-05-08  Tom Tromey  <tromey@adacore.com>
10560
10561         * typeprint.c (print_offset_data::update): Print the bit offset,
10562         not the number of bits remaining.
10563
10564 2019-05-08  Tom Tromey  <tromey@adacore.com>
10565
10566         * typeprint.c (print_offset_data::maybe_print_hole): Add extra
10567         padding at end of comment.
10568
10569 2019-05-08  Tom Tromey  <tromey@adacore.com>
10570
10571         * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
10572         Compare main types.
10573
10574 2019-05-06  Tom Tromey  <tom@tromey.com>
10575
10576         * common/scoped_mmap.c: Include common-defs.h.
10577         * common/scoped_mmap.h: Don't include config.h.
10578
10579 2019-05-04  Tom Tromey  <tom@tromey.com>
10580
10581         * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
10582         (struct aarch64_call_info): Add initializers.
10583         <si>: Now a std::vector.
10584         (pass_on_stack, aarch64_push_dummy_call): Update.
10585
10586 2019-05-04  Simon Marchi  <simon.marchi@efficios.com>
10587             Tom Tromey  <tom@tromey.com>
10588
10589         * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
10590         (ppc_threads): Now a std::vector.  Now static.
10591         (hwdebug_find_thread_points_by_tid)
10592         (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
10593         Update.
10594
10595 2019-05-04  Tom Tromey  <tom@tromey.com>
10596
10597         * arc-tdep.c (arc_tdesc_init): Return bool.
10598
10599 2019-05-04  Tom Tromey  <tom@tromey.com>
10600
10601         * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
10602         Use gdb_assert_not_reached.
10603
10604 2019-05-04  Tom Tromey  <tom@tromey.com>
10605
10606         * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
10607         "false".
10608
10609 2019-05-04  Tom Tromey  <tom@tromey.com>
10610
10611         * arc-tdep.c (arc_tdesc_init): Use bool.
10612
10613 2019-05-04  Tom Tromey  <tom@tromey.com>
10614
10615         * stack.c (select_frame_for_mi): Use "false", not "FALSE".
10616
10617 2019-05-04  Tom Tromey  <tom@tromey.com>
10618
10619         * cli/cli-cmds.c (valid_command_p): Return bool.
10620
10621 2019-05-04  Tom Tromey  <tom@tromey.com>
10622
10623         * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
10624         * command.h (valid_user_defined_cmd_name_p): Channge return type.
10625
10626 2019-05-04  Raul Tambre  <raul@tambre.ee>
10627
10628         * python/lib/gdb/prompt.py (_ExtendedPrompt)
10629         <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
10630         operator for comparison.
10631
10632 2019-05-04  Tom Tromey  <tom@tromey.com>
10633
10634         * psymtab.c (psymbol_name_matches, match_partial_symbol)
10635         (lookup_partial_symbol, print_partial_symbols)
10636         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
10637         (psymbol_compare): Update.
10638         (add_psymbol_to_bcache): Clear the entire psymbol.
10639         (maintenance_check_psymtabs): Update.
10640         * psympriv.h (struct partial_symbol): Don't derive from
10641         general_symbol_info.
10642         <obj_section, unrelocated_address, address,
10643         set_unrelocated_address>: Update.
10644         <ginfo>: New member.
10645         * dwarf-index-write.c (write_psymbols, debug_names::insert)
10646         (debug_names::write_psymbols): Update.
10647
10648 2019-05-04  Tom de Vries  <tdevries@suse.de>
10649
10650         * contrib/cc-with-tweaks.sh: Support -n arg.
10651
10652 2019-05-04  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10653
10654         * corelow.c (core_target::detach): Ensure frame cache and
10655         register caches are cleared.
10656         inferior.c (exit_inferior_1): Likewise.
10657
10658 2019-05-03  Sandra Loosemore  <sandra@codesourcery.com>
10659             Tom Tromey  <tom@tromey.com>
10660
10661         * dictionary.c (collate_pending_symbols_by_language): Remove
10662         "struct" from foreach.
10663         * symtab.c (lookup_global_symbol_from_objfile)
10664         (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
10665         foreach.
10666         * ser-tcp.c (net_open): Remove "struct" from foreach.
10667         * objfiles.c (objfile_relocate, objfile_rebase)
10668         (objfile_has_symbols): Remove "struct" from foreach.
10669         * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
10670         from foreach.
10671         * dwarf2read.c (handle_struct_member_die): Remove "struct" from
10672         foreach.
10673         * darwin-nat.c (thread_info_from_private_thread_info): Remove
10674         "struct" from foreach.
10675         * ada-lang.c (create_excep_cond_exprs)
10676         (ada_exception_catchpoint_cond_string): Remove "struct" from
10677         foreach.
10678
10679 2019-05-03  Tom Tromey  <tromey@adacore.com>
10680
10681         * ada-exp.y (convert_char_literal): Check suffix of each
10682         enumerator.
10683
10684 2019-05-03  Dilyan Palauzov  <dilyan.palauzov@aegee.org>
10685
10686         PR ada/21406:
10687         * ada-exp.y (yywrap): Don't define.
10688         * ada-lex.l (%option): Add noyywrap
10689         (yywrap): Remove.
10690
10691 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
10692
10693         * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
10694         _WIN32_WINNT to the XP level, unless already defined to a higher
10695         level.
10696
10697         * unittests/parse-connection-spec-selftests.c:
10698         * ser-tcp.c:
10699         * common/netstuff.c [USE_WIN32API]:  Remove the _WIN32_WINNT
10700         override.
10701
10702         * symfile.c (find_separate_debug_file): Remove colon from the
10703         drive spec of DOS/Windows file names of the target, so that the
10704         file name produced from DEBUGDIR and the target's directory will
10705         be valid on DOS/Windows systems.
10706
10707 2019-05-02  Andrew Burgess  <andrew.burgess@embecosm.com>
10708
10709         * rust-lang.c (val_print_struct): Handle printing structures
10710         containing strings.
10711
10712 2019-05-02  Tom Tromey  <tromey@adacore.com>
10713
10714         * valarith.c (_initialize_valarith): Remove.
10715
10716 2019-05-01  Tom Tromey  <tromey@adacore.com>
10717
10718         * ada-lang.c (ada_value_primitive_field): Treat more fields as
10719         bitfields.
10720
10721 2019-05-01  Tom Tromey  <tromey@adacore.com>
10722
10723         * ada-lang.c (ada_value_assign): Correctly compute starting offset
10724         for big-endian copies.
10725
10726 2019-04-30  Ali Tamur  <tamur@google.com>
10727         * gdb/dwarf2read.c (read_3_bytes): New declaration.
10728         (read_attribute_value): Added DW_FORM_strx1-4 cases.
10729         (read_3_bytes): New function.
10730
10731 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
10732
10733         * windows-nat.c (main_thread_id): Delete.
10734         (handle_output_debug_string): Replace main_thread_id by
10735         current_event.dwThreadId.
10736         (fake_create_process): Likewise.
10737         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
10738         Do not set main_thread_id.
10739         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
10740         current_event.dwThreadId.
10741         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
10742
10743 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
10744
10745         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
10746         Use current_event.dwThreadId instead of main_thread_id.
10747
10748 2019-04-30  Tom Tromey  <tromey@adacore.com>
10749
10750         * ada-lang.c (ada_lookup_simple_minsyms): New function.
10751         (create_excep_cond_exprs): Iterate over program spaces.
10752         (ada_exception_catchpoint_cond_string): Examine all minimal
10753         symbols for exception types.
10754
10755 2019-04-30  Tom Tromey  <tromey@adacore.com>
10756
10757         PR c++/24470:
10758         * dwarf2read.c (process_structure_scope): Handle case where type
10759         has template parameters but no symbol was created.
10760
10761 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
10762             Chris January  <chris.january@arm.com>
10763
10764         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
10765         qualifier.
10766         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
10767
10768 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
10769
10770         * f-typeprint.c (f_print_type): Update rules for printing
10771         whitespace.
10772         (f_type_print_varspec_suffix): Likewise.
10773
10774 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
10775             Chris January  <chris.january@arm.com>
10776
10777         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
10778         function arguments.
10779
10780 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
10781
10782         * f-lang.c (build_fortran_types): Change name of void type to
10783         lower case.
10784         * f-typeprint.c (f_type_print_base): Print the name of the void
10785         type, rather than a fixed string.
10786         * f-valprint.c (f_decorations): Use lower case void string.
10787
10788 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
10789             Chris January  <chris.january@arm.com>
10790
10791         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
10792         types for Fortran.
10793
10794 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
10795             Chris January  <chris.january@arm.com>
10796             David Lecomber  <david.lecomber@arm.com>
10797
10798         * f-exp.y (BINOP_INTRINSIC): New token.
10799         (exp): New parser rule handling BINOP_INTRINSIC.
10800         (f77_keywords): Add new builtin procedures.
10801         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
10802         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
10803         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
10804         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
10805         (print_unop_subexp_f): New function.
10806         (print_binop_subexp_f): New function.
10807         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
10808         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
10809         (dump_subexp_body_f): Likewise.
10810         (operator_check_f): Likewise.
10811         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
10812         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
10813
10814 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
10815
10816         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
10817         UNOP_KIND.
10818         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
10819         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
10820         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
10821         (operator_length_f): New fuction.
10822         (print_subexp_f): New function.
10823         (op_name_f): New function.
10824         (dump_subexp_body_f): New function.
10825         (operator_check_f): New function.
10826         (exp_descriptor_f): Replace standard expression handling functions
10827         with new functions.
10828         * gdb/fortran-operator.def: New file.
10829         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
10830         * gdb/std-operator.def: Remove UNOP_KIND.
10831
10832 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
10833
10834         * std-operator.def: Remove unbalanced, stray double quote
10835         character.
10836
10837 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
10838             Chris January  <chris.january@arm.com>
10839             Daniel Everett  <daniel.everett@arm.com>
10840             Nick Forrington  <nick.forrington@arm.com>
10841             Richard Bunt  <richard.bunt@arm.com>
10842
10843         * cp-valprint.c (cp_print_value_fields): Allow an additional level
10844         of depth when printing anonymous structs or unions.
10845         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
10846         Don't print either the top-level value, or the children if the
10847         max-depth is exceeded.
10848         (ppscm_print_children): When printing the key of a map, allow one
10849         extra level of depth.
10850         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
10851         print either the top-level value, or the children if the max-depth
10852         is exceeded.
10853         (print_children): When printing the key of a map, allow one extra
10854         level of depth.
10855         * python/py-value.c (valpy_format_string): Add max_depth keyword.
10856         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
10857         (user_print_options): Initialise max_depth field.
10858         (val_print_scalar_or_string_type_p): New function.
10859         (val_print): Check to see if the max depth has been reached.
10860         (val_print_check_max_depth): Define new function.
10861         (show_print_max_depth): New function.
10862         (_initialize_valprint): Add 'print max-depth' option.
10863         * valprint.h (struct value_print_options) <max_depth>: New field.
10864         (val_print_check_max_depth): Declare new function.
10865         * NEWS: Document new feature.
10866
10867 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
10868
10869         * ada-lang.c (ada_language_defn): Initialise new field.
10870         * c-lang.c (c_is_string_type_p): New function.
10871         (c_language_defn): Initialise new field.
10872         (cplus_language_defn): Initialise new field.
10873         (asm_language_defn): Initialise new field.
10874         (minimal_language_defn): Initialise new field.
10875         * c-lang.h (c_is_string_type_p): Declare new function.
10876         * d-lang.c (d_language_defn): Initialise new field.
10877         * f-lang.c (f_is_string_type_p): New function.
10878         (f_language_defn): Initialise new field.
10879         * go-lang.c (go_is_string_type_p): New function.
10880         (go_language_defn): Initialise new field.
10881         * language.c (default_is_string_type_p): New function.
10882         (unknown_language_defn): Initialise new field.
10883         (auto_language_defn): Initialise new field.
10884         * language.h (struct language_defn) <la_is_string_type_p>: New
10885         member variable.
10886         (default_is_string_type_p): Declare new function.
10887         * m2-lang.c (m2_language_defn): Initialise new field.
10888         * objc-lang.c (objc_language_defn): Initialise new field.
10889         * opencl-lang.c (opencl_language_defn): Initialise new field.
10890         * p-lang.c (pascal_is_string_type_p): New function.
10891         (pascal_language_defn): Initialise new field.
10892         * rust-lang.c (rust_is_string_type_p): New function.
10893         (rust_language_defn): Initialise new field.
10894
10895 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
10896
10897         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
10898         New field.
10899         * ada-lang.c (ada_language_defn): Initialise new field.
10900         * c-lang.c (c_language_defn): Likewise.
10901         (cplus_language_defn): Likewise.
10902         (asm_language_defn): Likewise.
10903         (minimal_language_defn): Likewise.
10904         * d-lang.c (d_language_defn): Likewise.
10905         * f-lang.c (f_language_defn): Likewise.
10906         * go-lang.c (go_language_defn): Likewise.
10907         * language.c (unknown_language_defn): Likewise.
10908         (auto_language_defn): Likewise.
10909         * m2-lang.c (m2_language_defn): Likewise.
10910         * objc-lang.c (objc_language_defn): Likewise.
10911         * opencl-lang.c (opencl_language_defn): Likewise.
10912         * p-lang.c (pascal_language_defn): Likewise.
10913         * rust-lang.c (rust_language_defn): Likewise.
10914
10915 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
10916
10917         * ada-lang.c (ada_is_character_type): Change return type to bool.
10918         (ada_is_string_type): Likewise.
10919         * ada-lang.h (ada_is_character_type): Update declaration
10920         (ada_is_string_type): Likewise.
10921
10922 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10923
10924         Support style in 'frame|thread apply'
10925
10926         * gdbcmd.h (execute_command_to_string): New term_out parameter.
10927         * record.c (record_start, record_stop): Update callers of
10928         execute_command_to_string with false.
10929         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
10930         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
10931         methods.
10932         (class string_file): New constructor with term_out parameter.
10933         Override methods term_out and can_emit_style_escape.  New member
10934         term_out.
10935         (class stdio_file): Override can_emit_style_escape.
10936         (class tee_file): Override term_out and can_emit_style_escape.
10937         * utils.h (can_emit_style_escape): Remove.
10938         * utils.c (can_emit_style_escape): Likewise.
10939         Update all callers of can_emit_style_escape (SOMESTREAM) to
10940         SOMESTREAM->can_emit_style_escape.
10941         * source-cache.c (source_cache::get_source_lines): Likewise.
10942         * stack.c (frame_apply_command_count): Call execute_command_to_string
10943         passing the term_out characteristic of the current gdb_stdout.
10944         * thread.c (thr_try_catch_cmd): Likewise.
10945         * top.c (execute_command_to_string): pass term_out parameter
10946         to construct the string_file for the command output.
10947         * ui-file.c (term_cli_styling): New function (most code moved
10948         from utils.c can_emit_style_escape).
10949         (string_file::string_file, string_file::can_emit_style_escape,
10950         stdio_file::can_emit_style_escape, tee_file::term_out,
10951         tee_file::can_emit_style_escape): New functions.
10952
10953 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10954
10955         * NEWS: Mention the new set|show may-call-functions.
10956         * infcall.c (may_call_functions_p): New variable.
10957         (show_may_call_functions_p): New function.
10958         (call_function_by_hand_dummy): Throws an error if not
10959         may-call-functions.
10960         (_initialize_infcall): Call add_setshow_boolean_cmd for
10961         may-call-functions.
10962
10963 2019-04-25  Keith Seitz  <keiths@redhat.com>
10964
10965         PR c++/24367
10966         * cp-support.c (inspect_type): Don't attempt substitutions
10967         of symbol with the same name.
10968
10969 2019-04-25  Tom Tromey  <tromey@adacore.com>
10970
10971         PR gdb/24475:
10972         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
10973         static.
10974
10975 2019-04-25  Tom Tromey  <tromey@adacore.com>
10976
10977         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
10978         rvalue reference.
10979         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
10980         (gdb_xml_parser::parse): Use std::move.
10981         * python/python-internal.h (gdbpy_convert_exception): Take a const
10982         reference.
10983         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
10984         std::move.
10985         * python/py-utils.c (gdbpy_convert_exception): Take a const
10986         reference.
10987         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
10988         Use std::move.
10989         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
10990         Use std::move.
10991         * mi/mi-main.c (mi_print_exception): Take a const reference.
10992         * main.c (handle_command_errors): Take a const reference.
10993         * linespec.c (parse_linespec): Use std::move.
10994         * infcall.c (run_inferior_call): Use std::move.
10995         (call_function_by_hand_dummy): Use std::move.
10996         * exec.c (try_open_exec_file): Use std::move.
10997         * exceptions.h (exception_print, exception_fprintf)
10998         (exception_print_same): Update.
10999         * exceptions.c (print_exception, exception_print)
11000         (exception_fprintf, exception_print_same): Change parameters to
11001         const reference.
11002         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
11003         * common/new-op.c: Use std::move.
11004         * common/common-exceptions.h (struct gdb_exception): Add move
11005         constructor.
11006         (struct gdb_exception_error, struct gdb_exception_quit, struct
11007         gdb_quit_bad_alloc): Change constructor to move constructor.
11008         (throw_exception): Change parameter to rvalue reference.
11009         * common/common-exceptions.c (throw_exception): Take rvalue
11010         reference.
11011         * cli/cli-interp.c (safe_execute_command): Use std::move.
11012         * breakpoint.c (insert_bp_location, location_to_sals): Use
11013         std::move.
11014
11015 2019-04-25  Tom Tromey  <tromey@adacore.com>
11016
11017         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
11018         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
11019         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
11020         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
11021         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
11022         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
11023         guile/scm-value.c: Use unpack.
11024         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
11025         gdbscm_gdb_exception.
11026         (gdbscm_throw_gdb_exception): Likewise.
11027         (struct gdbscm_gdb_exception): New.
11028         (unpack): New function.
11029         (gdbscm_wrap): Use unpack.
11030
11031 2019-04-25  Tom Tromey  <tromey@adacore.com>
11032
11033         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
11034         (gdb_rl_callback_handler): Use std::move.
11035         * common/common-exceptions.h (struct gdb_exception): Add move
11036         assignment operator.
11037         (throw_exception_sjlj): Change "exception" to const reference.
11038         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
11039         (throw_exception_sjlj): Change "exception" to const reference.
11040
11041 2019-04-25  Tom Tromey  <tromey@adacore.com>
11042
11043         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
11044         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
11045         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
11046         Update.
11047         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
11048         Update.
11049         * mi/mi-interp.c (mi_interp::exec): Update.
11050         * linespec.c (parse_linespec): Update.
11051         * infcall.c (run_inferior_call): Update.
11052         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
11053         * guile/scm-symbol.c (gdbscm_lookup_symbol)
11054         (gdbscm_lookup_global_symbol): Update.
11055         * guile/scm-param.c (gdbscm_parameter_value): Update.
11056         * guile/scm-frame.c (gdbscm_frame_read_register)
11057         (gdbscm_frame_read_var): Update.
11058         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
11059         * exec.c (try_open_exec_file): Update.
11060         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
11061         (gdb_rl_callback_handler): Update.
11062         * common/common-exceptions.h (exception_none): Don't declare.
11063         * common/common-exceptions.c (exception_none): Don't define.
11064         (struct catcher) <exception>: Update.
11065         * cli/cli-interp.c (safe_execute_command): Update.
11066         * breakpoint.c (insert_bp_location, location_to_sals): Update.
11067
11068 2019-04-25  Ali Tamur  <tamur@google.com>
11069
11070         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
11071         (read_attribute_value): Likewise.
11072         (dwarf2_read_addr_index): Update comment.
11073         (read_str_index): Add DW_FORM_strx.
11074         (dwarf2_string_attr): Likewise.
11075         (dwarf2_const_value_attr): Likewise.
11076         (dump_die_shallow): Likewise.
11077         (dwarf2_fetch_constant_bytes): Likewise.
11078         (skip_form_bytes): Likewise.
11079         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
11080
11081 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
11082
11083         PR corefiles/11608
11084         PR corefiles/18187
11085         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
11086         OFFSET.  Verify if current mapping contains an ELF header.
11087         (linux_find_memory_regions_full): Adjust call to
11088         dump_mapping_p.
11089
11090 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
11091             Kang Li <kanglictf@gmail.com>
11092
11093         PR gdb/21600
11094
11095         * dwarf2-frame.c (read_initial_length): Be consistent about using
11096         unsigned representation of length.
11097         (decode_frame_entry_1): Likewise.  Check for wraparound of
11098         end pointer as well as buffer overflow.
11099
11100 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
11101
11102         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
11103         "vq".
11104
11105 2019-04-24  Tom Tromey  <tromey@adacore.com>
11106
11107         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
11108
11109 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11110
11111         * s12z-tdep.c (s12z_unwind_pc): Delete.
11112         (s12z_unwind_sp): Delete.
11113         (s12z_gdbarch_init): Don't register deleted functions with
11114         gdbarch.
11115
11116 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11117
11118         * rl78-tdep.c (rl78_unwind_sp): Delete.
11119         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
11120
11121 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11122
11123         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
11124         (xstormy16_unwind_pc): Delete.
11125         (xstormy16_dummy_id): Delete.
11126         (xstormy16_gdbarch_init): Don't register deleted functions with
11127         gdbarch.
11128
11129 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11130
11131         * vax-tdep.c (vax_unwind_pc): Delete.
11132         (vax_gdbarch_init): Don't register deleted function with gdbarch.
11133
11134 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11135
11136         * v850-tdep.c (v850_unwind_sp): Delete.
11137         (v850_unwind_pc): Delete.
11138         (v850_dummy_id): Delete.
11139         (v850_gdbarch_init): Don't register deleted functions with
11140         gdbarch.
11141
11142 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11143
11144         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
11145         (tilegx_unwind_pc): Delete.
11146         (tilegx_unwind_dummy_id): Delete.
11147         (tilegx_gdbarch_init): Don't register deleted functions with
11148         gdbarch.
11149
11150 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11151
11152         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
11153         (tic6x_dummy_id): Delete.
11154         (tic6x_gdbarch_init): Don't register deleted functions with
11155         gdbarch.
11156
11157 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11158
11159         * sparc-tdep.c (sparc_unwind_pc): Delete.
11160         (sparc32_gdbarch_init): Don't register deleted function with
11161         gdbarch.
11162
11163 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11164
11165         * sh-tdep.c (sh_unwind_sp): Delete.
11166         (sh_unwind_pc): Delete.
11167         (sh_dummy_id): Delete.
11168         (sh_gdbarch_init): Don't register deleted functions with
11169         gdbarch.
11170
11171 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11172
11173         * score-tdep.c (score_unwind_sp): Delete.
11174         (score_unwind_pc): Delete.
11175         (score_dummy_id): Delete.
11176         (score_gdbarch_init): Don't register deleted functions with
11177         gdbarch.
11178
11179 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11180
11181         * rx-tdep.c (rx_unwind_pc): Delete.
11182         (rx_unwind_sp): Delete.
11183         (rx_dummy_id): Delete.
11184         (rx_gdbarch_init): Don't register deleted functions with
11185         gdbarch.  Update comment.
11186
11187 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11188
11189         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
11190         (rs6000_dummy_id): Delete.
11191         (rs6000_gdbarch_init): Don't register deleted functions with
11192         gdbarch.
11193
11194 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11195
11196         * or1k-tdep.c (or1k_dummy_id): Delete.
11197         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
11198
11199 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11200
11201         * nios2-tdep.c (nios2_dummy_id): Delete.
11202         (nios2_unwind_sp): Delete.
11203         (nios2_gdbarch_init): Don't register deleted functions with
11204         gdbarch.
11205
11206 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11207
11208         * nds32-tdep.c (nds32_dummy_id): Delete.
11209         (nds32_unwind_pc): Delete.
11210         (nds32_unwind_sp): Delete.
11211         (nds32_gdbarch_init): Don't register deleted functions with
11212         gdbarch.
11213
11214 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11215
11216         * msp430-tdep.c (msp430_unwind_pc): Delete.
11217         (msp430_unwind_sp): Delete.
11218         (msp430_dummy_id): Delete.
11219         (msp430_gdbarch_init): Don't register deleted functions with
11220         gdbarch.
11221
11222 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11223
11224         * moxie-tdep.c (moxie_unwind_sp): Delete.
11225         (moxie_unwind_pc): Delete.
11226         (moxie_dummy_id): Delete.
11227         (moxie_gdbarch_init): Don't register deleted functions with
11228         gdbarch.
11229
11230 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11231
11232         * mn10300-tdep.c (mn10300_dummy_id): Delete.
11233         (mn10300_unwind_pc): Delete.
11234         (mn10300_unwind_sp): Delete.
11235         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
11236         mn10300_unwind_sp.
11237         (mn10300_frame_unwind_init): Don't register deleted functions with
11238         gdbarch.
11239
11240 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11241
11242         * mep-tdep.c (mep_unwind_pc): Delete.
11243         (mep_unwind_sp): Delete.
11244         (mep_dummy_id): Delete.
11245         (mep_gdbarch_init): Don't register deleted functions with
11246         gdbarch.
11247
11248 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11249
11250         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
11251         (m68hc11_unwind_sp): Delete.
11252         (m68hc11_gdbarch_init): Don't register deleted functions with
11253         gdbarch.
11254
11255 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11256
11257         * m32r-tdep.c (m32r_unwind_sp): Delete.
11258         (m32r_unwind_pc): Delete.
11259         (m32r_dummy_id): Delete.
11260         (m32r_gdbarch_init): Don't register deleted functions with
11261         gdbarch.
11262
11263 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11264
11265         * m32c-tdep.c (m32c_unwind_pc): Delete.
11266         (m32c_unwind_sp): Delete.
11267         (m32c_dummy_id): Delete.
11268         (m32c_gdbarch_init): Don't register deleted functions with
11269         gdbarch.
11270
11271 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11272
11273         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
11274         (lm32_unwind_pc): Delete.
11275         (lm32_dummy_id): Delete.
11276         (lm32_gdbarch_init): Don't register deleted functions with
11277         gdbarch.
11278
11279 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11280
11281         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
11282         (iq2000_unwind_pc): Delete.
11283         (iq2000_dummy_id): Delete.
11284         (iq2000_gdbarch_init): Don't register deleted functions with
11285         gdbarch.
11286
11287 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11288
11289         * nds32-tdep.c (nds32_type_align): Delete.
11290         (nds32_push_dummy_call): Use type_align instead.
11291
11292 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11293
11294         * arm-tdep.c (arm_type_align): Only handle vector override case.
11295         (arm_push_dummy_call): Use type_align.
11296         (arm_gdbarch_init): Register arm_type_align gdbarch function.
11297
11298 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11299
11300         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
11301         case.
11302         (pass_on_stack): Use type_align.
11303         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
11304         function.
11305
11306 2019-04-23  Tom Tromey  <tromey@adacore.com>
11307
11308         * dwarf2read.c (line_header::file_name_at): Remove unused
11309         overload.
11310
11311 2019-04-23  Tom de Vries  <tdevries@suse.de>
11312
11313         PR gdb/24438
11314         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
11315         invocation.
11316
11317
11318 2019-03-27  Ali Tamur  <tamur@google.com>
11319
11320         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
11321         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
11322         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
11323         (dwarf_expr_context::get_addr_index): Likewise
11324         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
11325         (symbol_needs_eval_context::get_addr_index): Likewise
11326         (disassemble_dwarf_expression): Add DW_OP_addrx
11327         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
11328         (read_cutu_die_from_dwo): Update comment
11329         (skip_one_die): Add DW_FORM_addrx
11330         (read_attribute_value): Likewise
11331         (var_decode_location): Add DW_OP_addrx
11332         (dwarf2_const_value_attr): Add DW_FORM_addrx
11333         (dump_die_shallow): Likewise
11334         (dwarf2_fetch_constant_bytes): Likewise
11335         (decode_locdesc): Add DW_OP_addrx
11336         (skip_form_bytes): Add DW_FORM_addrx
11337
11338 2019-04-22  Ali Tamur  <tamur@google.com>
11339
11340         * MAINTAINERS (Write After Approval): Add self.
11341
11342 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
11343
11344         * solib-svr4.c (get_svr4_info): Add pspace parameter.
11345         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
11346         (open_symbol_file_object): Likewise.
11347         (svr4_default_sos): Add info parameter.
11348         (svr4_read_so_list): Likewise.
11349         (svr4_current_sos_direct): Adjust functions calls to pass down
11350         info.
11351         (svr4_current_sos_1): Add info parameter.
11352         (svr4_current_sos): Call get_svr4_info, pass info down to
11353         svr4_current_sos_1.
11354         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
11355         get_svr4_info.
11356         (svr4_in_dynsym_resolve_code): Pass current_program_space to
11357         get_svr4_info.
11358         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
11359         to get_svr4_info.
11360         (probes_table_remove_objfile_probes): Likewise.
11361         (register_solib_event_probe): Add info parameter.
11362         (solist_update_incremental): Pass info parameter down to
11363         svr4_read_so_list.
11364         (disable_probes_interface): Add info parameter.
11365         (svr4_handle_solib_event): Pass current_program_space to
11366         get_svr4_info.  Adjust disable_probes_interface cleanup.
11367         (svr4_create_probe_breakpoints): Add info parameter, pass it
11368         down to register_solib_event_probe.
11369         (svr4_create_solib_event_breakpoints): Add info parameter,
11370         pass it down to svr4_create_probe_breakpoints.
11371         (enable_break): Pass info down to
11372         svr4_create_solib_event_breakpoints.
11373         (svr4_solib_create_inferior_hook): Pass current_program_space to
11374         get_svr4_info.
11375         (svr4_clear_solib): Likewise.
11376
11377 2019-04-22  Pedro Alves  <palves@redhat.com>
11378
11379         * solib-svr4.c (svr4_free_objfile_observer): New.
11380         (probe_and_action::objfile): New field.
11381         (probes_table_htab_remove_objfile_probes)
11382         (probes_table_remove_objfile_probes): New functions.
11383         (register_solib_event_probe): Add 'objfile' parameter.  Store it
11384         in the new probe_and_action.  Don't store the probe in 'lookup'.
11385         (svr4_create_probe_breakpoints): Pass objfile to
11386         register_solib_event_probe.
11387         (_initialize_svr4_solib): Register a free_objfile observer.
11388
11389 2019-04-19  Tom Tromey  <tom@tromey.com>
11390
11391         * common/queue.h: Remove.
11392
11393 2019-04-19  Tom Tromey  <tom@tromey.com>
11394
11395         * event-loop.c: Don't include "common/queue.h".
11396
11397 2019-04-19  Tom Tromey  <tom@tromey.com>
11398
11399         * remote.c (remote_target): Use delete.
11400         * remote-notif.h: Include <list>, not "common/queue.h".
11401         (notif_client_p): Remove typedef.
11402         (remote_notif_state): Add constructor, destructor, initializer.
11403         <notif_queue>: Now a std::list.
11404         (remote_notif_state_xfree): Don't declare.
11405         * remote-notif.c (remote_notif_process, handle_notification)
11406         (remote_notif_state_allocate): Update.
11407         (~remote_notif_state): Rename from remote_notif_state_xfree.
11408
11409 2019-04-19  Tom Tromey  <tom@tromey.com>
11410
11411         * symfile.c (reread_symbols): Update.
11412         * objfiles.c (objfile_register_static_link)
11413         (objfile_lookup_static_link): Update
11414         (~objfile) Don't delete static_links.
11415         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
11416
11417 2019-04-19  Tom Tromey  <tom@tromey.com>
11418
11419         * type-stack.h (struct type_stack) <insert>: Constify string.
11420         * type-stack.c (type_stack::insert): Constify string.
11421         * gdbtypes.h (lookup_template_type): Update.
11422         (address_space_name_to_int): Update.
11423         * gdbtypes.c (address_space_name_to_int): Make space_identifier
11424         const.
11425         (lookup_template_type): Make name const.
11426         * c-exp.y: Update rules.
11427         (lex_one_token, classify_name, classify_inner_name)
11428         (c_print_token): Update.
11429         * p-exp.y: Update rules.
11430         (yylex): Update.
11431         * f-exp.y: Update rules.
11432         (yylex): Update.
11433         * d-exp.y: Update rules.
11434         (lex_one_token, classify_name, classify_inner_name): Update.
11435         * parse.c (write_dollar_variable, copy_name): Return std::string.
11436         * parser-defs.h (copy_name): Change return type.
11437         * m2-exp.y: Update rules.
11438         (yylex): Update.
11439         * go-exp.y (lex_one_token): Update.
11440         Update rules.
11441         (classify_unsafe_function, classify_packaged_name)
11442         (classify_name, yylex): Update.
11443
11444 2019-04-19  Sergei Trofimovich <siarheit@google.com>
11445
11446         * configure.ac: add --enable-source-highlight switch.
11447         * configure: Regenerate.
11448         * top.c (print_gdb_version): plumb --enable-source-highlight
11449         status to "show configuration".
11450
11451 2019-04-19  Tom Tromey  <tromey@adacore.com>
11452
11453         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
11454         Check ADA_TYPE_P.
11455         (empty_record, ada_template_to_fixed_record_type_1)
11456         (template_to_static_fixed_type)
11457         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
11458         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
11459         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
11460         macros.
11461
11462 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
11463
11464         PR symtab/24423:
11465         * source.c (print_source_lines_base): Advance "iter" when a
11466         control character is seen.
11467
11468 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11469
11470         * inferior.h (struct infcall_suspend_state_deleter):
11471         Catch exception in destructor to avoid crash.
11472
11473 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11474
11475         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
11476         close to the add_com "shell".
11477
11478 2019-04-18  Tom Tromey  <tromey@adacore.com>
11479
11480         * process-stratum-target.h (class process_stratum_target)
11481         <stratum>: Add "final".
11482
11483 2019-04-17  Tom Tromey  <tromey@adacore.com>
11484
11485         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
11486         against nullptr before use.
11487
11488 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
11489
11490         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
11491
11492 2019-04-17  Jim Wilson  <jimw@sifive.com>
11493             Andrew Burgess  <andrew.burgess@embecosm.com>
11494
11495         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
11496         code read might fail, assume 4-byte breakpoint in that case.
11497
11498 2019-04-15  Leszek Swirski  <leszeks@google.com>
11499
11500         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
11501         rather than a hand-rolled POD check when checking for forced MEMORY
11502         classification.
11503
11504 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
11505
11506         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
11507         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
11508         function.
11509         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
11510         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
11511         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
11512         declaration.
11513
11514 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
11515
11516         * aarch64-linux-nat.c
11517         (aarch64_linux_nat_target::thread_architecture): Add override.
11518         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
11519         each VQ.
11520
11521 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
11522
11523         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
11524
11525 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
11526
11527         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
11528         target types of size 96-bits, add some additional comments, and
11529         check that the builtin type we found was the correct size.
11530
11531 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
11532
11533         * utils.c (prompt_for_continue): Don't restore the styling at the
11534         end, as applied_style has the wrong value.  This fixes styling in
11535         long lists of file names that are interrupted by the "Continue?"
11536         prompt.
11537
11538 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
11539
11540         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
11541         * c-lang.c (c_language_defn): Likewise.
11542         (cplus_language_defn): Likewise.
11543         (asm_language_defn): Likewise.
11544         (minimal_language_defn): Likewise.
11545         * d-lang.c (d_language_defn): Likewise.
11546         * f-lang.c (f_language_defn): Likewise.
11547         * go-lang.c (go_language_defn): Likewise.
11548         * language.c (unknown_language_defn): Likewise.
11549         (auto_language_defn): Likewise.
11550         * language.h (struct language_defn): Remove la_magic field.
11551         (LANG_MAGIC): Delete.
11552         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
11553         * objc-lang.c (objc_language_defn): Likewise.
11554         * opencl-lang.c (opencl_language_defn): Likewise.
11555         * p-lang.c (pascal_language_defn): Likewise.
11556         * rust-lang.c (rust_language_defn): Likewise.
11557
11558 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
11559
11560         * riscv-tdep.c (riscv_type_align): New function.
11561         (riscv_type_alignment): Delete.
11562         (riscv_arg_location): Use 'type_align'.
11563         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
11564
11565 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
11566
11567         * gdbtypes.c (type_align): A struct with no non-static fields also
11568         has alignment of 1.
11569
11570 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
11571
11572         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
11573         component to 0.
11574         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
11575         member.
11576         (riscv_struct_info::analyse): New implementation using new
11577         analyse_inner member function.
11578         (riscv_struct_info::field_offset): New member function.
11579         (riscv_struct_info::m_offsets): New member variable.
11580         (riscv_struct_info::analyse_inner): New private member function,
11581         takes the old implementation of riscv_struct_info::analyse but
11582         extended to track field offsets.
11583         (riscv_call_arg_struct): Update the struct folding special cases
11584         to handle cases where empty C++ structs, which are non-zero
11585         length, are found.
11586         (riscv_arg_location): Initialise the length of each location, a
11587         non-zero length now indicates the location is in use.
11588         (riscv_push_dummy_call): Allow for the first location having a
11589         non-zero offset when setting up arguments.
11590         (riscv_return_value): Likewise, but for return values.
11591
11592 2019-04-11  Tom Tromey  <tromey@adacore.com>
11593
11594         * utils.c (internal_vproblem): Make "msg" const.
11595
11596 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
11597
11598         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
11599         * trad-frame.c (trad_frame_reset_saved_regs): New function.
11600         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
11601         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
11602
11603 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
11604
11605         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
11606         function.
11607         (fill_gregset): Call amd64_linux_collect_native_gregset instead
11608         of amd64_collect_native_gregset.
11609         (amd64_linux_nat_target::store_registers): Likewise.
11610
11611 2019-04-10  Tom Tromey  <tom@tromey.com>
11612
11613         * symtab.c (lookup_global_symbol_from_objfile)
11614         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
11615         * objfiles.h (class separate_debug_iterator): New.
11616         (class separate_debug_range): New.
11617         (struct objfile) <separate_debug_objfiles>: New method.
11618         (objfile_separate_debug_iterate): Don't declare.
11619         * objfiles.c (separate_debug_iterator::operator++): Rename from
11620         objfile_separate_debug_iterate.
11621         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
11622         iterator.
11623         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
11624         iterator.
11625
11626 2019-04-10  Tom Tromey  <tom@tromey.com>
11627
11628         * symfile.c (reread_symbols): Remove old comment.
11629         * objfiles.c (free_all_objfiles): Fix a typo.
11630
11631 2019-04-10  Tom Tromey  <tom@tromey.com>
11632
11633         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
11634         * minsyms.c (lookup_minimal_symbol): Use foreach.
11635         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
11636         (lookup_minimal_symbol_solib_trampoline): Likewise.
11637         * symfile.c (reread_symbols): Use foreach.
11638
11639 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
11640             Tom Tromey  <tromey@adacore.com>
11641
11642         PR rust/24414:
11643         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
11644         (rust_lex_int_test): Change "value" to be LONGEST.
11645         (rust_lex_tests): Add test for long integer literal.
11646
11647 2019-04-09  Tom Tromey  <tromey@adacore.com>
11648
11649         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
11650         to bool.
11651         (extended_remote_target::attach): Update.
11652         (remote_target::remote_notice_new_inferior): Update.
11653         (remote_target::add_current_inferior_and_thread): Update.
11654         * inferior.c (exit_inferior_1): Use "false".
11655         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
11656
11657 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
11658
11659         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
11660         the "start" command.
11661
11662 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
11663
11664         * python/py-inferior.c (infpy_thread_from_thread_handle):
11665         Adjust comments to reflect renaming of thread_from_thread_handle
11666         to thread_from_handle.  Adjust keywords.  Fix type error message.
11667         (inferior_object_methods): Add thread_from_handle.  Retain
11668         thread_from_thread_handle, but mark it as deprecated.
11669
11670 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
11671
11672         * gdbthread.h (find_thread_by_handle): Revise declaration.
11673         * thread.c (find_thread_by_handle): Likewise.  Adjust
11674         implementation too.
11675         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
11676         support for buffer objects as handles.
11677
11678 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
11679
11680         * python/py-infthread.c (thpy_thread_handle): New function.
11681         (thread_object_methods): Register thpy_thread_handle.
11682
11683 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
11684
11685         * gdbthread.h (thread_to_thread_handle): Declare.
11686         * thread.c (gdbtypes.h): Include.
11687         (thread_to_thread_handle): New function.
11688
11689         * target.h (struct target_ops): Add thread_info_to_thread_handle.
11690         (target_thread_info_to_thread_handle): Declare.
11691         * target.c (target_thread_info_to_thread_handle): New function.
11692         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
11693         * target-delegates.c: Regenerate.
11694
11695         * linux-thread-db.c (class thread_db_target): Add method
11696         thread_info_to_thread_handle.
11697         (thread_db_target::thread_info_to_thread_handle): Define.
11698         * remote.c (class remote_target): Add new method
11699         thread_info_to_thread_handle.
11700         (remote_target::thread_info_to_thread_handle): Define.
11701
11702 2019-04-08  Pedro Alves  <palves@redhat.com>
11703
11704         * common/common-exceptions.c (throw_exception): Don't create
11705         named object to throw; throw directly.
11706         (throw_it): Likewise.  Don't initialize gdb_exception::message
11707         here, with new; pass FMT and AP to the ctor instead.
11708         * common/common-exceptions.h: Include <string>.
11709         (gdb_exception::gdb_exception(enum return_reason, enum errors,
11710         const char *, va_list)): New ctor.  Use std::make_shared.
11711         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
11712         errors)): Delete.
11713         (gdb_exception_error::gdb_exception_error(enum errors, const char
11714         *, va_list)): New.
11715         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
11716         Add assertion.
11717         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
11718         errors)): Delete.
11719         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
11720         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
11721         Add assertion.
11722
11723 2019-04-08  Tom Tromey  <tom@tromey.com>
11724
11725         * valops.c (value_rtti_indirect_type): Replace throw_exception
11726         with throw.
11727         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
11728         with throw.
11729         * thread.c (thr_try_catch_cmd): Replace throw_exception with
11730         throw.
11731         * target.c (target_translate_tls_address): Replace throw_exception
11732         with throw.
11733         * stack.c (frame_apply_command_count): Replace throw_exception
11734         with throw.
11735         * solib-spu.c (append_ocl_sos): Replace throw_exception with
11736         throw.
11737         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
11738         with throw.
11739         * rs6000-tdep.c (rs6000_frame_cache)
11740         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
11741         * remote.c: Replace throw_exception with throw.
11742         * record-full.c (record_full_message, record_full_wait_1)
11743         (record_full_restore): Replace throw_exception with throw.
11744         * record-btrace.c:
11745         (get_thread_current_frame_id, record_btrace_start_replaying)
11746         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
11747         (cmd_record_btrace_start): Replace throw_exception with throw.
11748         * parse.c (parse_exp_in_context_1): Replace throw_exception with
11749         throw.
11750         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
11751         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
11752         * linespec.c:
11753         (find_linespec_symbols): Replace throw_exception with throw.
11754         * infrun.c (displaced_step_prepare, resume): Replace
11755         throw_exception with throw.
11756         * infcmd.c (post_create_inferior): Replace throw_exception with
11757         throw.
11758         * inf-loop.c (inferior_event_handler): Replace throw_exception
11759         with throw.
11760         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
11761         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
11762         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
11763         (get_prev_frame_always, get_frame_pc_if_available)
11764         (get_frame_address_in_block_if_available, get_frame_language):
11765         Replace throw_exception with throw.
11766         * frame-unwind.c (frame_unwind_try_unwinder): Replace
11767         throw_exception with throw.
11768         * eval.c (fetch_subexp_value, evaluate_var_value)
11769         (evaluate_funcall, evaluate_subexp_standard): Replace
11770         throw_exception with throw.
11771         * dwarf2loc.c (call_site_find_chain)
11772         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
11773         Replace throw_exception with throw.
11774         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
11775         with throw.
11776         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
11777         throw.
11778         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
11779         * completer.c (complete_line_internal): Replace throw_exception
11780         with throw.
11781         * compile/compile-object-run.c (compile_object_run): Replace
11782         throw_exception with throw.
11783         * cli/cli-script.c (process_next_line): Replace throw_exception
11784         with throw.
11785         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
11786         (btrace_enable, btrace_maint_update_pt_packets): Replace
11787         throw_exception with throw.
11788         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
11789         throw_exception with throw.
11790         * break-catch-throw.c (re_set_exception_catchpoint): Replace
11791         throw_exception with throw.
11792         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
11793         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
11794         * aarch64-tdep.c (aarch64_make_prologue_cache)
11795         (aarch64_make_stub_cache): Replace throw_exception with throw.
11796
11797 2019-04-08  Tom Tromey  <tom@tromey.com>
11798
11799         * common/common-exceptions.c (throw_exception): Rename from
11800         throw_exception_cxx.  Remove old copy.  Make argument const.
11801         (throw_it): Create and throw exception objects directly.
11802         * common/common-exceptions.h (throw_exception): Make argument
11803         const.
11804         (struct gdb_exception_error): Add constructor.
11805         (struct gdb_exception_quit): Add constructor.
11806
11807 2019-04-08  Tom Tromey  <tom@tromey.com>
11808
11809         * common/common-exceptions.h (exception_rethrow): Don't declare.
11810         (TRY_SJLJ): Update comment.
11811         (TRY, CATCH, END_CATCH): Remove.
11812         * common/common-exceptions.c (exception_rethrow): Remove.
11813
11814 2019-04-08  Tom Tromey  <tom@tromey.com>
11815
11816         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
11817         Remove.
11818         (gdb_exception_error): Rename from
11819         gdb_exception_RETURN_MASK_ERROR.
11820         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
11821         (gdb_quit_bad_alloc): Update.
11822         * aarch64-tdep.c: Update.
11823         * ada-lang.c: Update.
11824         * ada-typeprint.c: Update.
11825         * ada-valprint.c: Update.
11826         * amd64-tdep.c: Update.
11827         * arch-utils.c: Update.
11828         * break-catch-throw.c: Update.
11829         * breakpoint.c: Update.
11830         * btrace.c: Update.
11831         * c-varobj.c: Update.
11832         * cli/cli-cmds.c: Update.
11833         * cli/cli-interp.c: Update.
11834         * cli/cli-script.c: Update.
11835         * common/common-exceptions.c: Update.
11836         * common/new-op.c: Update.
11837         * common/selftest.c: Update.
11838         * compile/compile-c-symbols.c: Update.
11839         * compile/compile-cplus-symbols.c: Update.
11840         * compile/compile-object-load.c: Update.
11841         * compile/compile-object-run.c: Update.
11842         * completer.c: Update.
11843         * corelow.c: Update.
11844         * cp-abi.c: Update.
11845         * cp-support.c: Update.
11846         * cp-valprint.c: Update.
11847         * darwin-nat.c: Update.
11848         * disasm-selftests.c: Update.
11849         * dtrace-probe.c: Update.
11850         * dwarf-index-cache.c: Update.
11851         * dwarf-index-write.c: Update.
11852         * dwarf2-frame-tailcall.c: Update.
11853         * dwarf2-frame.c: Update.
11854         * dwarf2loc.c: Update.
11855         * dwarf2read.c: Update.
11856         * eval.c: Update.
11857         * event-loop.c: Update.
11858         * event-top.c: Update.
11859         * exec.c: Update.
11860         * f-valprint.c: Update.
11861         * fbsd-tdep.c: Update.
11862         * frame-unwind.c: Update.
11863         * frame.c: Update.
11864         * gdbtypes.c: Update.
11865         * gnu-v3-abi.c: Update.
11866         * guile/guile-internal.h: Update.
11867         * guile/scm-block.c: Update.
11868         * guile/scm-breakpoint.c: Update.
11869         * guile/scm-cmd.c: Update.
11870         * guile/scm-disasm.c: Update.
11871         * guile/scm-frame.c: Update.
11872         * guile/scm-lazy-string.c: Update.
11873         * guile/scm-math.c: Update.
11874         * guile/scm-param.c: Update.
11875         * guile/scm-ports.c: Update.
11876         * guile/scm-pretty-print.c: Update.
11877         * guile/scm-symbol.c: Update.
11878         * guile/scm-symtab.c: Update.
11879         * guile/scm-type.c: Update.
11880         * guile/scm-value.c: Update.
11881         * i386-linux-tdep.c: Update.
11882         * i386-tdep.c: Update.
11883         * inf-loop.c: Update.
11884         * infcall.c: Update.
11885         * infcmd.c: Update.
11886         * infrun.c: Update.
11887         * jit.c: Update.
11888         * language.c: Update.
11889         * linespec.c: Update.
11890         * linux-fork.c: Update.
11891         * linux-nat.c: Update.
11892         * linux-tdep.c: Update.
11893         * linux-thread-db.c: Update.
11894         * main.c: Update.
11895         * mi/mi-cmd-break.c: Update.
11896         * mi/mi-cmd-stack.c: Update.
11897         * mi/mi-interp.c: Update.
11898         * mi/mi-main.c: Update.
11899         * objc-lang.c: Update.
11900         * p-valprint.c: Update.
11901         * parse.c: Update.
11902         * ppc-linux-tdep.c: Update.
11903         * printcmd.c: Update.
11904         * python/py-arch.c: Update.
11905         * python/py-breakpoint.c: Update.
11906         * python/py-cmd.c: Update.
11907         * python/py-finishbreakpoint.c: Update.
11908         * python/py-frame.c: Update.
11909         * python/py-framefilter.c: Update.
11910         * python/py-gdb-readline.c: Update.
11911         * python/py-inferior.c: Update.
11912         * python/py-infthread.c: Update.
11913         * python/py-lazy-string.c: Update.
11914         * python/py-linetable.c: Update.
11915         * python/py-objfile.c: Update.
11916         * python/py-param.c: Update.
11917         * python/py-prettyprint.c: Update.
11918         * python/py-progspace.c: Update.
11919         * python/py-record-btrace.c: Update.
11920         * python/py-record.c: Update.
11921         * python/py-symbol.c: Update.
11922         * python/py-type.c: Update.
11923         * python/py-unwind.c: Update.
11924         * python/py-utils.c: Update.
11925         * python/py-value.c: Update.
11926         * python/python.c: Update.
11927         * record-btrace.c: Update.
11928         * record-full.c: Update.
11929         * remote-fileio.c: Update.
11930         * remote.c: Update.
11931         * riscv-tdep.c: Update.
11932         * rs6000-aix-tdep.c: Update.
11933         * rs6000-tdep.c: Update.
11934         * rust-exp.y: Update.
11935         * rust-lang.c: Update.
11936         * s390-tdep.c: Update.
11937         * selftest-arch.c: Update.
11938         * solib-dsbt.c: Update.
11939         * solib-frv.c: Update.
11940         * solib-spu.c: Update.
11941         * solib-svr4.c: Update.
11942         * solib.c: Update.
11943         * sparc64-linux-tdep.c: Update.
11944         * stack.c: Update.
11945         * symfile-mem.c: Update.
11946         * symmisc.c: Update.
11947         * target.c: Update.
11948         * thread.c: Update.
11949         * top.c: Update.
11950         * tracefile-tfile.c: Update.
11951         * tui/tui.c: Update.
11952         * typeprint.c: Update.
11953         * unittests/cli-utils-selftests.c: Update.
11954         * unittests/parse-connection-spec-selftests.c: Update.
11955         * valops.c: Update.
11956         * valprint.c: Update.
11957         * value.c: Update.
11958         * varobj.c: Update.
11959         * windows-nat.c: Update.
11960         * x86-linux-nat.c: Update.
11961         * xml-support.c: Update.
11962
11963 2019-04-08  Tom Tromey  <tom@tromey.com>
11964
11965         * xml-support.c: Use C++ exception handling.
11966         * x86-linux-nat.c: Use C++ exception handling.
11967         * windows-nat.c: Use C++ exception handling.
11968         * varobj.c: Use C++ exception handling.
11969         * value.c: Use C++ exception handling.
11970         * valprint.c: Use C++ exception handling.
11971         * valops.c: Use C++ exception handling.
11972         * unittests/parse-connection-spec-selftests.c: Use C++ exception
11973         handling.
11974         * unittests/cli-utils-selftests.c: Use C++ exception handling.
11975         * typeprint.c: Use C++ exception handling.
11976         * tui/tui.c: Use C++ exception handling.
11977         * tracefile-tfile.c: Use C++ exception handling.
11978         * top.c: Use C++ exception handling.
11979         * thread.c: Use C++ exception handling.
11980         * target.c: Use C++ exception handling.
11981         * symmisc.c: Use C++ exception handling.
11982         * symfile-mem.c: Use C++ exception handling.
11983         * stack.c: Use C++ exception handling.
11984         * sparc64-linux-tdep.c: Use C++ exception handling.
11985         * solib.c: Use C++ exception handling.
11986         * solib-svr4.c: Use C++ exception handling.
11987         * solib-spu.c: Use C++ exception handling.
11988         * solib-frv.c: Use C++ exception handling.
11989         * solib-dsbt.c: Use C++ exception handling.
11990         * selftest-arch.c: Use C++ exception handling.
11991         * s390-tdep.c: Use C++ exception handling.
11992         * rust-lang.c: Use C++ exception handling.
11993         * rust-exp.y: Use C++ exception handling.
11994         * rs6000-tdep.c: Use C++ exception handling.
11995         * rs6000-aix-tdep.c: Use C++ exception handling.
11996         * riscv-tdep.c: Use C++ exception handling.
11997         * remote.c: Use C++ exception handling.
11998         * remote-fileio.c: Use C++ exception handling.
11999         * record-full.c: Use C++ exception handling.
12000         * record-btrace.c: Use C++ exception handling.
12001         * python/python.c: Use C++ exception handling.
12002         * python/py-value.c: Use C++ exception handling.
12003         * python/py-utils.c: Use C++ exception handling.
12004         * python/py-unwind.c: Use C++ exception handling.
12005         * python/py-type.c: Use C++ exception handling.
12006         * python/py-symbol.c: Use C++ exception handling.
12007         * python/py-record.c: Use C++ exception handling.
12008         * python/py-record-btrace.c: Use C++ exception handling.
12009         * python/py-progspace.c: Use C++ exception handling.
12010         * python/py-prettyprint.c: Use C++ exception handling.
12011         * python/py-param.c: Use C++ exception handling.
12012         * python/py-objfile.c: Use C++ exception handling.
12013         * python/py-linetable.c: Use C++ exception handling.
12014         * python/py-lazy-string.c: Use C++ exception handling.
12015         * python/py-infthread.c: Use C++ exception handling.
12016         * python/py-inferior.c: Use C++ exception handling.
12017         * python/py-gdb-readline.c: Use C++ exception handling.
12018         * python/py-framefilter.c: Use C++ exception handling.
12019         * python/py-frame.c: Use C++ exception handling.
12020         * python/py-finishbreakpoint.c: Use C++ exception handling.
12021         * python/py-cmd.c: Use C++ exception handling.
12022         * python/py-breakpoint.c: Use C++ exception handling.
12023         * python/py-arch.c: Use C++ exception handling.
12024         * printcmd.c: Use C++ exception handling.
12025         * ppc-linux-tdep.c: Use C++ exception handling.
12026         * parse.c: Use C++ exception handling.
12027         * p-valprint.c: Use C++ exception handling.
12028         * objc-lang.c: Use C++ exception handling.
12029         * mi/mi-main.c: Use C++ exception handling.
12030         * mi/mi-interp.c: Use C++ exception handling.
12031         * mi/mi-cmd-stack.c: Use C++ exception handling.
12032         * mi/mi-cmd-break.c: Use C++ exception handling.
12033         * main.c: Use C++ exception handling.
12034         * linux-thread-db.c: Use C++ exception handling.
12035         * linux-tdep.c: Use C++ exception handling.
12036         * linux-nat.c: Use C++ exception handling.
12037         * linux-fork.c: Use C++ exception handling.
12038         * linespec.c: Use C++ exception handling.
12039         * language.c: Use C++ exception handling.
12040         * jit.c: Use C++ exception handling.
12041         * infrun.c: Use C++ exception handling.
12042         * infcmd.c: Use C++ exception handling.
12043         * infcall.c: Use C++ exception handling.
12044         * inf-loop.c: Use C++ exception handling.
12045         * i386-tdep.c: Use C++ exception handling.
12046         * i386-linux-tdep.c: Use C++ exception handling.
12047         * guile/scm-value.c: Use C++ exception handling.
12048         * guile/scm-type.c: Use C++ exception handling.
12049         * guile/scm-symtab.c: Use C++ exception handling.
12050         * guile/scm-symbol.c: Use C++ exception handling.
12051         * guile/scm-pretty-print.c: Use C++ exception handling.
12052         * guile/scm-ports.c: Use C++ exception handling.
12053         * guile/scm-param.c: Use C++ exception handling.
12054         * guile/scm-math.c: Use C++ exception handling.
12055         * guile/scm-lazy-string.c: Use C++ exception handling.
12056         * guile/scm-frame.c: Use C++ exception handling.
12057         * guile/scm-disasm.c: Use C++ exception handling.
12058         * guile/scm-cmd.c: Use C++ exception handling.
12059         * guile/scm-breakpoint.c: Use C++ exception handling.
12060         * guile/scm-block.c: Use C++ exception handling.
12061         * guile/guile-internal.h: Use C++ exception handling.
12062         * gnu-v3-abi.c: Use C++ exception handling.
12063         * gdbtypes.c: Use C++ exception handling.
12064         * frame.c: Use C++ exception handling.
12065         * frame-unwind.c: Use C++ exception handling.
12066         * fbsd-tdep.c: Use C++ exception handling.
12067         * f-valprint.c: Use C++ exception handling.
12068         * exec.c: Use C++ exception handling.
12069         * event-top.c: Use C++ exception handling.
12070         * event-loop.c: Use C++ exception handling.
12071         * eval.c: Use C++ exception handling.
12072         * dwarf2read.c: Use C++ exception handling.
12073         * dwarf2loc.c: Use C++ exception handling.
12074         * dwarf2-frame.c: Use C++ exception handling.
12075         * dwarf2-frame-tailcall.c: Use C++ exception handling.
12076         * dwarf-index-write.c: Use C++ exception handling.
12077         * dwarf-index-cache.c: Use C++ exception handling.
12078         * dtrace-probe.c: Use C++ exception handling.
12079         * disasm-selftests.c: Use C++ exception handling.
12080         * darwin-nat.c: Use C++ exception handling.
12081         * cp-valprint.c: Use C++ exception handling.
12082         * cp-support.c: Use C++ exception handling.
12083         * cp-abi.c: Use C++ exception handling.
12084         * corelow.c: Use C++ exception handling.
12085         * completer.c: Use C++ exception handling.
12086         * compile/compile-object-run.c: Use C++ exception handling.
12087         * compile/compile-object-load.c: Use C++ exception handling.
12088         * compile/compile-cplus-symbols.c: Use C++ exception handling.
12089         * compile/compile-c-symbols.c: Use C++ exception handling.
12090         * common/selftest.c: Use C++ exception handling.
12091         * common/new-op.c: Use C++ exception handling.
12092         * cli/cli-script.c: Use C++ exception handling.
12093         * cli/cli-interp.c: Use C++ exception handling.
12094         * cli/cli-cmds.c: Use C++ exception handling.
12095         * c-varobj.c: Use C++ exception handling.
12096         * btrace.c: Use C++ exception handling.
12097         * breakpoint.c: Use C++ exception handling.
12098         * break-catch-throw.c: Use C++ exception handling.
12099         * arch-utils.c: Use C++ exception handling.
12100         * amd64-tdep.c: Use C++ exception handling.
12101         * ada-valprint.c: Use C++ exception handling.
12102         * ada-typeprint.c: Use C++ exception handling.
12103         * ada-lang.c: Use C++ exception handling.
12104         * aarch64-tdep.c: Use C++ exception handling.
12105
12106 2019-04-08  Tom Tromey  <tom@tromey.com>
12107
12108         * xml-support.c (gdb_xml_parser::parse): Update.
12109         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
12110         * value.c (show_convenience): Update.
12111         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
12112         (test_parse_flags_qcs): Update.
12113         * thread.c (thr_try_catch_cmd): Update.
12114         * target.c (target_translate_tls_address): Update.
12115         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
12116         (info_frame_command_core, frame_apply_command_count): Update.
12117         * rust-exp.y (rust_lex_exception_test): Update.
12118         * riscv-tdep.c (riscv_print_one_register_info): Update.
12119         * remote.c (remote_target::enable_btrace): Update.
12120         * record-btrace.c (record_btrace_enable_warn): Update.
12121         * python/py-utils.c (gdbpy_convert_exception): Update.
12122         * printcmd.c (do_one_display, print_variable_and_value): Update.
12123         * mi/mi-main.c (mi_print_exception): Update.
12124         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
12125         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
12126         * linux-nat.c (linux_nat_target::attach): Update.
12127         * linux-fork.c (class scoped_switch_fork_info): Update.
12128         * infrun.c (displaced_step_prepare): Update.
12129         * infcall.c (call_function_by_hand_dummy): Update.
12130         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
12131         * gnu-v3-abi.c (print_one_vtable): Update.
12132         * frame.c (get_prev_frame_always): Update.
12133         * f-valprint.c (info_common_command_for_block): Update.
12134         * exec.c (try_open_exec_file): Update.
12135         * exceptions.c (print_exception, exception_print)
12136         (exception_fprintf, exception_print_same): Update.
12137         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
12138         * dwarf-index-cache.c (index_cache::store)
12139         (index_cache::lookup_gdb_index): Update.
12140         * darwin-nat.c (maybe_cache_shell): Update.
12141         * cp-valprint.c (cp_print_value_fields): Update.
12142         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
12143         (gcc_cplus_symbol_address): Update.
12144         * compile/compile-c-symbols.c (gcc_convert_symbol)
12145         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
12146         * common/selftest.c: Update.
12147         * common/common-exceptions.h (struct gdb_exception) <message>: Now
12148         a std::string.
12149         (exception_try_scope_entry, exception_try_scope_exit): Don't
12150         declare.
12151         (struct exception_try_scope): Remove.
12152         (TRY): Don't use exception_try_scope.
12153         (struct gdb_exception): Add constructor, operator=.
12154         <what>: New method.
12155         (struct gdb_exception_RETURN_MASK_ALL)
12156         (struct gdb_exception_RETURN_MASK_ERROR)
12157         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
12158         (struct gdb_quit_bad_alloc): Update.
12159         * common/common-exceptions.c (exception_none): Change
12160         initializer.
12161         (struct catcher) <state, exception>: Initialize inline.
12162         <prev>: Remove member.
12163         (current_catcher): Remove.
12164         (catchers): New global.
12165         (exceptions_state_mc_init): Simplify.
12166         (catcher_pop): Remove.
12167         (exceptions_state_mc, exceptions_state_mc_catch): Update.
12168         (try_scope_depth, exception_try_scope_entry)
12169         (exception_try_scope_exit): Remove.
12170         (throw_exception_sjlj): Update.
12171         (exception_messages, exception_messages_size): Remove.
12172         (throw_it): Simplify.
12173         (gdb_exception_sliced_copy): Remove.
12174         (throw_exception_cxx): Update.
12175         * cli/cli-script.c (script_from_file): Update.
12176         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
12177         Update.
12178         * ada-valprint.c (ada_val_print): Update.
12179         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
12180         (create_excep_cond_exprs): Update.
12181
12182 2019-04-08  Tom Tromey  <tom@tromey.com>
12183
12184         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
12185         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
12186         (TRY, CATCH, END_CATCH): Remove some definitions.
12187         * common/common-exceptions.c: Don't use GDB_XCPT.
12188         (catcher_list_size): Remove.
12189         (throw_exception, throw_it): Simplify.
12190
12191 2019-04-05  Tom Tromey  <tom@tromey.com>
12192
12193         Revert the header-sorting patch.
12194         * ft32-tdep.c: Revert.
12195         * frv-tdep.c: Revert.
12196         * frv-linux-tdep.c: Revert.
12197         * frame.c: Revert.
12198         * frame-unwind.c: Revert.
12199         * frame-base.c: Revert.
12200         * fork-child.c: Revert.
12201         * findvar.c: Revert.
12202         * findcmd.c: Revert.
12203         * filesystem.c: Revert.
12204         * filename-seen-cache.h: Revert.
12205         * filename-seen-cache.c: Revert.
12206         * fbsd-tdep.c: Revert.
12207         * fbsd-nat.h: Revert.
12208         * fbsd-nat.c: Revert.
12209         * f-valprint.c: Revert.
12210         * f-typeprint.c: Revert.
12211         * f-lang.c: Revert.
12212         * extension.h: Revert.
12213         * extension.c: Revert.
12214         * extension-priv.h: Revert.
12215         * expprint.c: Revert.
12216         * exec.h: Revert.
12217         * exec.c: Revert.
12218         * exceptions.c: Revert.
12219         * event-top.c: Revert.
12220         * event-loop.c: Revert.
12221         * eval.c: Revert.
12222         * elfread.c: Revert.
12223         * dwarf2read.h: Revert.
12224         * dwarf2read.c: Revert.
12225         * dwarf2loc.c: Revert.
12226         * dwarf2expr.h: Revert.
12227         * dwarf2expr.c: Revert.
12228         * dwarf2-frame.c: Revert.
12229         * dwarf2-frame-tailcall.c: Revert.
12230         * dwarf-index-write.h: Revert.
12231         * dwarf-index-write.c: Revert.
12232         * dwarf-index-common.c: Revert.
12233         * dwarf-index-cache.h: Revert.
12234         * dwarf-index-cache.c: Revert.
12235         * dummy-frame.c: Revert.
12236         * dtrace-probe.c: Revert.
12237         * disasm.h: Revert.
12238         * disasm.c: Revert.
12239         * disasm-selftests.c: Revert.
12240         * dictionary.c: Revert.
12241         * dicos-tdep.c: Revert.
12242         * demangle.c: Revert.
12243         * dcache.h: Revert.
12244         * dcache.c: Revert.
12245         * darwin-nat.h: Revert.
12246         * darwin-nat.c: Revert.
12247         * darwin-nat-info.c: Revert.
12248         * d-valprint.c: Revert.
12249         * d-namespace.c: Revert.
12250         * d-lang.c: Revert.
12251         * ctf.c: Revert.
12252         * csky-tdep.c: Revert.
12253         * csky-linux-tdep.c: Revert.
12254         * cris-tdep.c: Revert.
12255         * cris-linux-tdep.c: Revert.
12256         * cp-valprint.c: Revert.
12257         * cp-support.c: Revert.
12258         * cp-namespace.c: Revert.
12259         * cp-abi.c: Revert.
12260         * corelow.c: Revert.
12261         * corefile.c: Revert.
12262         * continuations.c: Revert.
12263         * completer.h: Revert.
12264         * completer.c: Revert.
12265         * complaints.c: Revert.
12266         * coffread.c: Revert.
12267         * coff-pe-read.c: Revert.
12268         * cli-out.h: Revert.
12269         * cli-out.c: Revert.
12270         * charset.c: Revert.
12271         * c-varobj.c: Revert.
12272         * c-valprint.c: Revert.
12273         * c-typeprint.c: Revert.
12274         * c-lang.c: Revert.
12275         * buildsym.c: Revert.
12276         * buildsym-legacy.c: Revert.
12277         * build-id.h: Revert.
12278         * build-id.c: Revert.
12279         * btrace.c: Revert.
12280         * bsd-uthread.c: Revert.
12281         * breakpoint.h: Revert.
12282         * breakpoint.c: Revert.
12283         * break-catch-throw.c: Revert.
12284         * break-catch-syscall.c: Revert.
12285         * break-catch-sig.c: Revert.
12286         * blockframe.c: Revert.
12287         * block.c: Revert.
12288         * bfin-tdep.c: Revert.
12289         * bfin-linux-tdep.c: Revert.
12290         * bfd-target.c: Revert.
12291         * bcache.c: Revert.
12292         * ax-general.c: Revert.
12293         * ax-gdb.h: Revert.
12294         * ax-gdb.c: Revert.
12295         * avr-tdep.c: Revert.
12296         * auxv.c: Revert.
12297         * auto-load.c: Revert.
12298         * arm-wince-tdep.c: Revert.
12299         * arm-tdep.c: Revert.
12300         * arm-symbian-tdep.c: Revert.
12301         * arm-pikeos-tdep.c: Revert.
12302         * arm-obsd-tdep.c: Revert.
12303         * arm-nbsd-tdep.c: Revert.
12304         * arm-nbsd-nat.c: Revert.
12305         * arm-linux-tdep.c: Revert.
12306         * arm-linux-nat.c: Revert.
12307         * arm-fbsd-tdep.c: Revert.
12308         * arm-fbsd-nat.c: Revert.
12309         * arm-bsd-tdep.c: Revert.
12310         * arch-utils.c: Revert.
12311         * arc-tdep.c: Revert.
12312         * arc-newlib-tdep.c: Revert.
12313         * annotate.h: Revert.
12314         * annotate.c: Revert.
12315         * amd64-windows-tdep.c: Revert.
12316         * amd64-windows-nat.c: Revert.
12317         * amd64-tdep.c: Revert.
12318         * amd64-sol2-tdep.c: Revert.
12319         * amd64-obsd-tdep.c: Revert.
12320         * amd64-obsd-nat.c: Revert.
12321         * amd64-nbsd-tdep.c: Revert.
12322         * amd64-nbsd-nat.c: Revert.
12323         * amd64-nat.c: Revert.
12324         * amd64-linux-tdep.c: Revert.
12325         * amd64-linux-nat.c: Revert.
12326         * amd64-fbsd-tdep.c: Revert.
12327         * amd64-fbsd-nat.c: Revert.
12328         * amd64-dicos-tdep.c: Revert.
12329         * amd64-darwin-tdep.c: Revert.
12330         * amd64-bsd-nat.c: Revert.
12331         * alpha-tdep.c: Revert.
12332         * alpha-obsd-tdep.c: Revert.
12333         * alpha-nbsd-tdep.c: Revert.
12334         * alpha-mdebug-tdep.c: Revert.
12335         * alpha-linux-tdep.c: Revert.
12336         * alpha-linux-nat.c: Revert.
12337         * alpha-bsd-tdep.c: Revert.
12338         * alpha-bsd-nat.c: Revert.
12339         * aix-thread.c: Revert.
12340         * agent.c: Revert.
12341         * addrmap.c: Revert.
12342         * ada-varobj.c: Revert.
12343         * ada-valprint.c: Revert.
12344         * ada-typeprint.c: Revert.
12345         * ada-tasks.c: Revert.
12346         * ada-lang.c: Revert.
12347         * aarch64-tdep.c: Revert.
12348         * aarch64-ravenscar-thread.c: Revert.
12349         * aarch64-newlib-tdep.c: Revert.
12350         * aarch64-linux-tdep.c: Revert.
12351         * aarch64-linux-nat.c: Revert.
12352         * aarch64-fbsd-tdep.c: Revert.
12353         * aarch64-fbsd-nat.c: Revert.
12354         * aarch32-linux-nat.c: Revert.
12355
12356 2019-04-05  Tom Tromey  <tom@tromey.com>
12357
12358         * ft32-tdep.c: Sort headers.
12359         * frv-tdep.c: Sort headers.
12360         * frv-linux-tdep.c: Sort headers.
12361         * frame.c: Sort headers.
12362         * frame-unwind.c: Sort headers.
12363         * frame-base.c: Sort headers.
12364         * fork-child.c: Sort headers.
12365         * findvar.c: Sort headers.
12366         * findcmd.c: Sort headers.
12367         * filesystem.c: Sort headers.
12368         * filename-seen-cache.h: Sort headers.
12369         * filename-seen-cache.c: Sort headers.
12370         * fbsd-tdep.c: Sort headers.
12371         * fbsd-nat.h: Sort headers.
12372         * fbsd-nat.c: Sort headers.
12373         * f-valprint.c: Sort headers.
12374         * f-typeprint.c: Sort headers.
12375         * f-lang.c: Sort headers.
12376         * extension.h: Sort headers.
12377         * extension.c: Sort headers.
12378         * extension-priv.h: Sort headers.
12379         * expprint.c: Sort headers.
12380         * exec.h: Sort headers.
12381         * exec.c: Sort headers.
12382         * exceptions.c: Sort headers.
12383         * event-top.c: Sort headers.
12384         * event-loop.c: Sort headers.
12385         * eval.c: Sort headers.
12386         * elfread.c: Sort headers.
12387         * dwarf2read.h: Sort headers.
12388         * dwarf2read.c: Sort headers.
12389         * dwarf2loc.c: Sort headers.
12390         * dwarf2expr.h: Sort headers.
12391         * dwarf2expr.c: Sort headers.
12392         * dwarf2-frame.c: Sort headers.
12393         * dwarf2-frame-tailcall.c: Sort headers.
12394         * dwarf-index-write.h: Sort headers.
12395         * dwarf-index-write.c: Sort headers.
12396         * dwarf-index-common.c: Sort headers.
12397         * dwarf-index-cache.h: Sort headers.
12398         * dwarf-index-cache.c: Sort headers.
12399         * dummy-frame.c: Sort headers.
12400         * dtrace-probe.c: Sort headers.
12401         * disasm.h: Sort headers.
12402         * disasm.c: Sort headers.
12403         * disasm-selftests.c: Sort headers.
12404         * dictionary.c: Sort headers.
12405         * dicos-tdep.c: Sort headers.
12406         * demangle.c: Sort headers.
12407         * dcache.h: Sort headers.
12408         * dcache.c: Sort headers.
12409         * darwin-nat.h: Sort headers.
12410         * darwin-nat.c: Sort headers.
12411         * darwin-nat-info.c: Sort headers.
12412         * d-valprint.c: Sort headers.
12413         * d-namespace.c: Sort headers.
12414         * d-lang.c: Sort headers.
12415         * ctf.c: Sort headers.
12416         * csky-tdep.c: Sort headers.
12417         * csky-linux-tdep.c: Sort headers.
12418         * cris-tdep.c: Sort headers.
12419         * cris-linux-tdep.c: Sort headers.
12420         * cp-valprint.c: Sort headers.
12421         * cp-support.c: Sort headers.
12422         * cp-namespace.c: Sort headers.
12423         * cp-abi.c: Sort headers.
12424         * corelow.c: Sort headers.
12425         * corefile.c: Sort headers.
12426         * continuations.c: Sort headers.
12427         * completer.h: Sort headers.
12428         * completer.c: Sort headers.
12429         * complaints.c: Sort headers.
12430         * coffread.c: Sort headers.
12431         * coff-pe-read.c: Sort headers.
12432         * cli-out.h: Sort headers.
12433         * cli-out.c: Sort headers.
12434         * charset.c: Sort headers.
12435         * c-varobj.c: Sort headers.
12436         * c-valprint.c: Sort headers.
12437         * c-typeprint.c: Sort headers.
12438         * c-lang.c: Sort headers.
12439         * buildsym.c: Sort headers.
12440         * buildsym-legacy.c: Sort headers.
12441         * build-id.h: Sort headers.
12442         * build-id.c: Sort headers.
12443         * btrace.c: Sort headers.
12444         * bsd-uthread.c: Sort headers.
12445         * breakpoint.h: Sort headers.
12446         * breakpoint.c: Sort headers.
12447         * break-catch-throw.c: Sort headers.
12448         * break-catch-syscall.c: Sort headers.
12449         * break-catch-sig.c: Sort headers.
12450         * blockframe.c: Sort headers.
12451         * block.c: Sort headers.
12452         * bfin-tdep.c: Sort headers.
12453         * bfin-linux-tdep.c: Sort headers.
12454         * bfd-target.c: Sort headers.
12455         * bcache.c: Sort headers.
12456         * ax-general.c: Sort headers.
12457         * ax-gdb.h: Sort headers.
12458         * ax-gdb.c: Sort headers.
12459         * avr-tdep.c: Sort headers.
12460         * auxv.c: Sort headers.
12461         * auto-load.c: Sort headers.
12462         * arm-wince-tdep.c: Sort headers.
12463         * arm-tdep.c: Sort headers.
12464         * arm-symbian-tdep.c: Sort headers.
12465         * arm-pikeos-tdep.c: Sort headers.
12466         * arm-obsd-tdep.c: Sort headers.
12467         * arm-nbsd-tdep.c: Sort headers.
12468         * arm-nbsd-nat.c: Sort headers.
12469         * arm-linux-tdep.c: Sort headers.
12470         * arm-linux-nat.c: Sort headers.
12471         * arm-fbsd-tdep.c: Sort headers.
12472         * arm-fbsd-nat.c: Sort headers.
12473         * arm-bsd-tdep.c: Sort headers.
12474         * arch-utils.c: Sort headers.
12475         * arc-tdep.c: Sort headers.
12476         * arc-newlib-tdep.c: Sort headers.
12477         * annotate.h: Sort headers.
12478         * annotate.c: Sort headers.
12479         * amd64-windows-tdep.c: Sort headers.
12480         * amd64-windows-nat.c: Sort headers.
12481         * amd64-tdep.c: Sort headers.
12482         * amd64-sol2-tdep.c: Sort headers.
12483         * amd64-obsd-tdep.c: Sort headers.
12484         * amd64-obsd-nat.c: Sort headers.
12485         * amd64-nbsd-tdep.c: Sort headers.
12486         * amd64-nbsd-nat.c: Sort headers.
12487         * amd64-nat.c: Sort headers.
12488         * amd64-linux-tdep.c: Sort headers.
12489         * amd64-linux-nat.c: Sort headers.
12490         * amd64-fbsd-tdep.c: Sort headers.
12491         * amd64-fbsd-nat.c: Sort headers.
12492         * amd64-dicos-tdep.c: Sort headers.
12493         * amd64-darwin-tdep.c: Sort headers.
12494         * amd64-bsd-nat.c: Sort headers.
12495         * alpha-tdep.c: Sort headers.
12496         * alpha-obsd-tdep.c: Sort headers.
12497         * alpha-nbsd-tdep.c: Sort headers.
12498         * alpha-mdebug-tdep.c: Sort headers.
12499         * alpha-linux-tdep.c: Sort headers.
12500         * alpha-linux-nat.c: Sort headers.
12501         * alpha-bsd-tdep.c: Sort headers.
12502         * alpha-bsd-nat.c: Sort headers.
12503         * aix-thread.c: Sort headers.
12504         * agent.c: Sort headers.
12505         * addrmap.c: Sort headers.
12506         * ada-varobj.c: Sort headers.
12507         * ada-valprint.c: Sort headers.
12508         * ada-typeprint.c: Sort headers.
12509         * ada-tasks.c: Sort headers.
12510         * ada-lang.c: Sort headers.
12511         * aarch64-tdep.c: Sort headers.
12512         * aarch64-ravenscar-thread.c: Sort headers.
12513         * aarch64-newlib-tdep.c: Sort headers.
12514         * aarch64-linux-tdep.c: Sort headers.
12515         * aarch64-linux-nat.c: Sort headers.
12516         * aarch64-fbsd-tdep.c: Sort headers.
12517         * aarch64-fbsd-nat.c: Sort headers.
12518         * aarch32-linux-nat.c: Sort headers.
12519
12520 2019-04-04  Tom Tromey  <tom@tromey.com>
12521
12522         * varobj.c (varobj_create): Update.
12523         * rust-exp.y (struct rust_parser) <update_innermost_block,
12524         lookup_symbol>: New methods.
12525         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
12526         Rename.
12527         (rust_parser::rust_lookup_type)
12528         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
12529         * printcmd.c (display_command, do_one_display): Update.
12530         * parser-defs.h (struct parser_state) <parser_state>: Add
12531         "tracker" parameter.
12532         (block_tracker): New member.
12533         (class innermost_block_tracker) <innermost_block_tracker>: Add
12534         "types" parameter.
12535         <reset>: Remove method.
12536         (innermost_block): Don't declare.
12537         (null_post_parser): Update.
12538         * parse.c (innermost_block): Remove global.
12539         (write_dollar_variable): Update.
12540         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
12541         Remove "tracker_types" parameter.
12542         (parse_expression): Add "tracker" parameter.
12543         (parse_expression_for_completion): Update.
12544         (null_post_parser): Add "tracker" parameter.
12545         * p-exp.y: Update rules.
12546         * m2-exp.y: Update rules.
12547         * language.h (struct language_defn) <la_post_parser>: Add
12548         "tracker" parameter.
12549         * go-exp.y: Update rules.
12550         * f-exp.y: Update rules.
12551         * expression.h (parse_expression, parse_exp_1): Add "tracker"
12552         parameter.
12553         * d-exp.y: Update rules.
12554         * c-exp.y: Update rules.
12555         * breakpoint.c (set_breakpoint_condition): Create an
12556         innermost_block_tracker.
12557         (watch_command_1): Likewise.
12558         * ada-lang.c (resolve): Add "tracker" parameter.
12559         (resolve_subexp): Likewise.
12560         * ada-exp.y (write_var_from_sym): Update.
12561
12562 2019-04-04  Tom Tromey  <tom@tromey.com>
12563
12564         * type-stack.h: New file.
12565         * type-stack.c: New file.
12566         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
12567         type-stack.h.
12568         (insert_into_type_stack, insert_type, push_type, push_type_int)
12569         (insert_type_address_space, pop_type, pop_type_int)
12570         (pop_typelist, pop_type_stack, append_type_stack)
12571         (push_type_stack, get_type_stack, push_typelist)
12572         (follow_type_instance_flags, follow_types): Don't declare.
12573         * parse.c (type_stack): Remove global.
12574         (parse_exp_in_context): Update.
12575         (insert_into_type_stack, insert_type, push_type, push_type_int)
12576         (insert_type_address_space, pop_type, pop_type_int)
12577         (pop_typelist, pop_type_stack, append_type_stack)
12578         (push_type_stack, get_type_stack, push_typelist)
12579         (follow_type_instance_flags, follow_types): Remove (moved to
12580         type-stack.c).
12581         * f-exp.y (type_stack): New global.
12582         Update rules.
12583         (push_kind_type, f_parse): Update.
12584         * d-exp.y (type_stack): New global.
12585         Update rules.
12586         (d_parse): Update.
12587         * c-exp.y (struct c_parse_state) <type_stack>: New member.
12588         Update rules.
12589         * Makefile.in (COMMON_SFILES): Add type-stack.c.
12590         (HFILES_NO_SRCDIR): Add type-stack.h.
12591
12592 2019-04-04  Tom Tromey  <tom@tromey.com>
12593
12594         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
12595         (rust_parser::convert_ast_to_expression, rust_parse)
12596         (rust_lex_test_completion, rust_lex_tests): Update.
12597         * parser-defs.h (struct expr_completion_state): New.
12598         (struct parser_state) <parser_state>: Add completion parameter.
12599         <mark_struct_expression, mark_completion_tag>: New methods.
12600         <parse_completion, m_completion_state>: New members.
12601         (prefixify_expression, null_post_parser): Update.
12602         (mark_struct_expression, mark_completion_tag): Don't declare.
12603         * parse.c (parse_completion, expout_last_struct)
12604         (expout_tag_completion_type, expout_completion_name): Remove
12605         globals.
12606         (parser_state::mark_struct_expression)
12607         (parser_state::mark_completion_tag): Now methods.
12608         (prefixify_expression): Add last_struct parameter.
12609         (prefixify_subexp): Likewise.
12610         (parse_exp_1): Update.
12611         (parse_exp_in_context): Add cstate parameter.  Update.
12612         (parse_expression_for_completion): Create an
12613         expr_completion_state.
12614         (null_post_parser): Add "completion" parameter.
12615         * p-exp.y: Update rules.
12616         (yylex): Update.
12617         * language.h (struct language_defn) <la_post_parser>: Add
12618         "completing" parameter.
12619         * go-exp.y: Update rules.
12620         (lex_one_token): Update.
12621         * expression.h (parse_completion): Don't declare.
12622         * d-exp.y: Update rules.
12623         (lex_one_token): Update rules.
12624         * c-exp.y: Update rules.
12625         (lex_one_token): Update.
12626         * ada-lang.c (resolve): Add "parse_completion" parameter.
12627         (resolve_subexp): Likewise.
12628         (ada_resolve_function): Likewise.
12629
12630 2019-04-04  Tom Tromey  <tom@tromey.com>
12631
12632         * parser-defs.h (struct parser_state) <start_arglist,
12633         end_arglist>: New methods.
12634         <arglist_len, m_funcall_chain>: New members.
12635         (arglist_len, start_arglist, end_arglist): Don't declare.
12636         * parse.c (arglist_len, funcall_chain): Remove global.
12637         (start_arglist, end_arglist): Remove functions.
12638         (parse_exp_in_context): Update.
12639         * p-exp.y: Update rules.
12640         * m2-exp.y: Update rules.
12641         * go-exp.y: Update rules.
12642         * f-exp.y: Update rules.
12643         * d-exp.y: Update rules.
12644         * c-exp.y: Update rules.
12645
12646 2019-04-04  Tom Tromey  <tom@tromey.com>
12647
12648         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
12649         lex_operator, push_back>: New methods.
12650         Update all rules.
12651         (rust_parser::lex_hex, lex_escape): Rename and update.
12652         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
12653         (rust_parser::lex_operator): Rename and update.
12654         (rust_parser::lex_number, rustyylex, rustyyerror)
12655         (rust_lex_test_init, rust_lex_test_sequence)
12656         (rust_lex_test_push_back, rust_lex_tests): Update.
12657         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
12658         parameter.
12659         <lexptr, prev_lexptr>: New members.
12660         (lexptr, prev_lexptr): Don't declare.
12661         * parse.c (lexptr, prev_lexptr): Remove globals.
12662         (parse_exp_in_context): Update.
12663         * p-exp.y (yylex, yyerror): Update.
12664         * m2-exp.y (parse_number, yylex, yyerror): Update.
12665         * go-exp.y (lex_one_token, yyerror): Update.
12666         * f-exp.y (match_string_literal, yylex, yyerror): Update.
12667         * d-exp.y (lex_one_token, yyerror): Update.
12668         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
12669         (lex_one_token, yyerror): Update.
12670         * ada-lex.l (YY_INPUT): Update.
12671         (rewind_to_char): Update.
12672         * ada-exp.y (yyerror): Update.
12673
12674 2019-04-04  Tom Tromey  <tom@tromey.com>
12675
12676         * rust-exp.y (rustyylex, rust_lex_tests): Update.
12677         * parser-defs.h (struct parser_state) <parser_state>: Add new
12678         parameter.
12679         <comma_terminates>: New member.
12680         (comma_terminates): Don't declare global.
12681         * parse.c (comma_terminates): Remove global.
12682         (parse_exp_in_context): Update.
12683         * p-exp.y (yylex): Update.
12684         * m2-exp.y (yylex): Update.
12685         * go-exp.y (lex_one_token): Update.
12686         * f-exp.y (yylex): Update.
12687         * d-exp.y (lex_one_token): Update.
12688         * c-exp.y (lex_one_token): Update.
12689         * ada-lex.l: Update.
12690
12691 2019-04-04  Tom Tromey  <tom@tromey.com>
12692
12693         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
12694         (rustyylex, rust_lex_test_init, rust_lex_test_one)
12695         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
12696         * parser-defs.h (paren_depth): Don't declare.
12697         * parse.c (paren_depth): Remove global.
12698         (parse_exp_in_context): Update.
12699         * p-exp.y (paren_depth): New global.
12700         (pascal_parse): Initialize it.
12701         * m2-exp.y (paren_depth): New global.
12702         (m2_parse): Initialize it.
12703         * go-exp.y (paren_depth): New global.
12704         (go_parse): Initialize it.
12705         * f-exp.y (paren_depth): New global.
12706         (f_parse): Initialize it.
12707         * d-exp.y (paren_depth): New global.
12708         (d_parse): Initialize it.
12709         * c-exp.y (paren_depth): New global.
12710         (c_parse): Initialize it.
12711         * ada-lex.l (paren_depth): New global.
12712         (lexer_init): Initialize it.
12713
12714 2019-04-04  Tom Tromey  <tom@tromey.com>
12715
12716         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
12717         (rust_parser::convert_ast_to_type)
12718         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
12719         * parser-defs.h (struct parser_state) <parser_state>: Add
12720         parameters.  Initialize new members.
12721         <expression_context_block, expression_context_pc>: New members.
12722         * parse.c (expression_context_block, expression_context_pc):
12723         Remove globals.
12724         (parse_exp_in_context): Update.
12725         * p-exp.y: Update all rules.
12726         (yylex): Update.
12727         * m2-exp.y: Update all rules.
12728         (yylex): Update.
12729         * go-exp.y (yylex): Update.
12730         * f-exp.y (yylex): Update.
12731         * d-exp.y: Update all rules.
12732         (yylex): Update.
12733         * c-exp.y: Update all rules.
12734         (lex_one_token, classify_name, yylex, c_parse): Update.
12735         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
12736
12737 2019-04-04  Tom Tromey  <tom@tromey.com>
12738
12739         * gdbarch.h, gdbarch.c: Rebuild.
12740         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
12741         * stap-probe.h:
12742         (struct stap_parse_info): Replace "parser_state" with
12743         "expr_builder".
12744         * parser-defs.h (struct expr_builder): Rename from "parser_state".
12745         (parser_state): New class.
12746         * parse.c (expr_builder): Rename.
12747         (expr_builder::release): Rename.
12748         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
12749         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
12750         (write_exp_elt_longcst, write_exp_elt_floatcst)
12751         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
12752         (write_exp_string_vector, write_exp_bitstring)
12753         (write_exp_msymbol, mark_struct_expression)
12754         (write_dollar_variable)
12755         (insert_type_address_space, increase_expout_size): Replace
12756         "parser_state" with "expr_builder".
12757         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
12758         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
12759         "parser_state" with "expr_builder".
12760
12761 2019-04-04  Tom Tromey  <tom@tromey.com>
12762
12763         * rust-exp.y: Replace "parse_language" with method call.
12764         * p-exp.y:
12765         (yylex): Replace "parse_language" with method call.
12766         * m2-exp.y:
12767         (yylex): Replace "parse_language" with method call.
12768         * go-exp.y (classify_name): Replace "parse_language" with method
12769         call.
12770         * f-exp.y (yylex): Replace "parse_language" with method call.
12771         * d-exp.y (lex_one_token): Replace "parse_language" with method
12772         call.
12773         * c-exp.y:
12774         (lex_one_token, classify_name, yylex): Replace "parse_language"
12775         with method call.
12776         * ada-exp.y (find_primitive_type, type_char)
12777         (type_system_address): Replace "parse_language" with method call.
12778
12779 2019-04-04  Tom Tromey  <tom@tromey.com>
12780
12781         * rust-exp.y: Replace "parse_gdbarch" with method call.
12782         * parse.c (write_dollar_variable, insert_type_address_space):
12783         Replace "parse_gdbarch" with method call.
12784         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
12785         call.
12786         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
12787         call.
12788         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
12789         "parse_gdbarch" with method call.
12790         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
12791         with method call.
12792         * f-exp.y (parse_type, parse_f_type, yylex): Replace
12793         "parse_gdbarch" with method call.
12794         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
12795         "parse_gdbarch" with method call.
12796         * c-exp.y (parse_type, parse_number, classify_name): Replace
12797         "parse_gdbarch" with method call.
12798         * ada-lex.l: Replace "parse_gdbarch" with method call.
12799         * ada-exp.y (parse_type, find_primitive_type, type_char)
12800         (type_system_address): Replace "parse_gdbarch" with method call.
12801
12802 2019-04-04  Tom Tromey  <tom@tromey.com>
12803
12804         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
12805         * stap-probe.c (stap_parse_argument): Update.
12806         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
12807         initial_size parameter.
12808         * rust-exp.y (rust_lex_tests): Update.
12809         * parse.c (parser_state): Update.
12810         (parse_exp_in_context): Update.
12811         * parser-defs.h (struct parser_state) <parser_state>: Remove
12812         "initial_size" parameter.
12813
12814 2019-04-04  Tom Tromey  <tom@tromey.com>
12815
12816         * parser-defs.h (increase_expout_size): Don't declare.
12817         * parse.c (increase_expout_size): Now static.
12818
12819 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
12820
12821         * gnu-nat.c (gnu_nat_target::wait): Fix
12822         target_waitstatus_to_string call.
12823
12824 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
12825
12826         * eval.c (evaluate_subexp_standard): Handle internal functions
12827         during Fortran function call handling.
12828
12829 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
12830
12831         * NEWS: Mention new internal functions.
12832         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
12833         (read_base_type): Use dwarf2_init_complex_target_type.
12834         * value.c (creal_internal_fn): New function.
12835         (cimag_internal_fn): New function.
12836         (_initialize_values): Register new internal functions.
12837
12838 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12839
12840         * infrun.c (stop_all_threads): If debug_infrun, always
12841         trace the wait status after wait_one, using
12842         target_waitstatus_to_string and target_pid_to_str.
12843         (handle_inferior_event): Replace various trace of
12844         wait status kind by a single trace.
12845         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
12846         wait status kind image by target_waitstatus_to_string.
12847         * target/waitstatus.c (target_waitstatus_to_string): Fix
12848         obsolete comment.
12849
12850 2019-04-01  Tom Tromey  <tromey@adacore.com>
12851
12852         PR symtab/23331:
12853         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
12854
12855 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
12856             Pedro Alves  <palves@redhat.com>
12857
12858         * top.c (quit_force): Call 'finalize_values'.
12859         * value.c (finalize_values): New function.
12860         * value.h (finalize_values): Declare.
12861
12862 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
12863
12864         * NEWS: Announce $_gdb_major and $_gdb_minor.
12865
12866         * top.c (init_gdb_version_vars): New function.
12867         (gdb_init): Call init_gdb_version_vars.
12868
12869 2019-03-29  Tom Tromey  <tromey@adacore.com>
12870
12871         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
12872         help text.  Remove dead code.
12873
12874 2019-03-29  Keith Seitz  <keiths@redhat.com>
12875
12876         From Siddhesh Poyarekar:
12877         * f-lang.h (f77_get_upperbound): Return LONGEST.
12878         (f77_get_lowerbound): Likewise.
12879         * f-typeprint.c (f_type_print_varspec_suffix): Expand
12880         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
12881         print them.
12882         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
12883         plongest to format print it.
12884         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
12885         (f77_get_upperbound): Likewise.
12886         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
12887         LOWER_BOUND to LONGEST.
12888         (f77_create_arrayprint_offset_tbl): Likewise.
12889
12890 2019-03-29  Keith Seitz  <keiths@redhat.com>
12891
12892         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
12893         %s/pulongest for TYPE_LENGTH instead of %d in format
12894         strings.
12895         * ada-typerint.c (ada_print_type): Likewise.
12896         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
12897         * compile/compile-c-support.c (generate_register_struct): Likewise.
12898         * gdbtypes.c (recursive_dump_type): Likewise.
12899         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
12900         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
12901         instead of %d in format strings.
12902         * riscv-tdep.c (riscv_type_alignment): Cast second argument
12903         to std::min to ULONGEST.
12904         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
12905         instead of %d in format strings.
12906         * tracepoint.c (info_scope_command): Likewise.
12907         * typeprint.c (print_offset_data::update)
12908         (print_offset_data::finish): Likewise.
12909         * xtensa-tdep.c (xtensa_store_return_value)
12910         (xtensa_push_dummy_call): Likewise.
12911
12912 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
12913
12914         * windows-nat.c (display_selector): Fixed format specifications
12915         for 64-bit Cygwin.
12916
12917 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12918
12919         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
12920
12921 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
12922
12923         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
12924         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
12925         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
12926         (nios2_linux_init_abi): Install it.
12927
12928 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
12929
12930         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
12931
12932 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
12933
12934         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
12935
12936 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12937             Tom Tromey  <tromey@adacore.com>
12938
12939         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
12940
12941 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
12942
12943         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
12944         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
12945         method to compute the bounds of range types. Also print "[evaluated]"
12946         if the bounds' values come from a dynamic evaluation.
12947
12948 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
12949
12950         * cp-valprint.c (cp_print_value_fields): Don't print trailing
12951         whitespace when pretty printing is on.
12952
12953 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
12954
12955         * ppc-linux-nat.c: Add include.
12956
12957 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
12958
12959         * NEWS: Mention AArch64 Pointer Authentication.
12960
12961 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
12962
12963         * arm-linux-nat.c: Add include.
12964
12965 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
12966
12967         * source-cache.c (source_cache::get_source_lines): Re-read
12968         fullname after calling open_source_file.
12969
12970 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
12971
12972         * NEWS: Mention TLS support for FreeBSD.
12973
12974 2019-03-25  Tom Tromey  <tromey@adacore.com>
12975
12976         * minsyms.c (BUNCH_SIZE): Update comment.
12977         (~minimal_symbol_reader): Remove old comment.
12978         (compact_minimal_symbols): Update comment.
12979         (minimal_symbol_reader::install): Remove old comment.  Update
12980         other comments.
12981
12982 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
12983
12984         * s390-linux-nat.c: Add include.
12985
12986 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
12987
12988         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
12989         Call linux_get_hwcap.
12990         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
12991         Likewise.
12992         (aarch64_linux_get_hwcap): Remove function.
12993         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
12994         declaration.
12995         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
12996         linux_get_hwcap.
12997         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
12998         * linux-tdep.c (linux_get_hwcap): Add function.
12999         (linux_get_hwcap2): Likewise.
13000         * linux-tdep.h (linux_get_hwcap): Add declaration.
13001         (linux_get_hwcap2): Likewise.
13002         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
13003         (ppc_linux_get_hwcap2): Likewise.
13004         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
13005         linux_get_hwcap.
13006         (ppc_linux_nat_target::insert_watchpoint): Likewise.
13007         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
13008         (ppc_linux_nat_target::read_description): Likewise.
13009         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
13010         * s390-linux-nat.c: Likewise.
13011         * s390-linux-tdep.c (s390_core_read_description): Likewise.
13012
13013 2019-03-24  Tom Tromey  <tom@tromey.com>
13014
13015         * ada-lang.c (standard_lookup): Simplify initialization.
13016         (ada_lookup_symbol_nonlocal): Simplify return.
13017         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
13018         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
13019         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
13020         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
13021         initialization.
13022         * solib.c (solib_global_lookup): Simplify.
13023         * symtab.c (null_block_symbol): Remove.
13024         (symbol_cache_lookup): Simplify returns.
13025         (lookup_language_this): Simplify returns.
13026         (lookup_symbol_aux): Simplify return.
13027         (lookup_local_symbol): Simplify returns.
13028         (lookup_global_symbol_from_objfile): Simplify return.
13029         (lookup_symbol_in_objfile_symtabs)
13030         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
13031         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
13032         (lookup_static_symbol, lookup_global_symbol): Simplify return.
13033         * cp-namespace.c (cp_lookup_bare_symbol)
13034         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
13035         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
13036         (cp_lookup_nested_symbol): Don't use null_block_symbol.
13037         (cp_lookup_symbol_via_imports): Simplify initialization.
13038         (find_symbol_in_baseclass): Likewise.
13039         * symtab.h (null_block_symbol): Remove.
13040         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
13041         (d_lookup_nested_symbol, d_lookup_symbol_imports)
13042         (d_lookup_symbol_module): Likewise.
13043         (find_symbol_in_baseclass): Simplify initialization.
13044
13045 2019-03-24  Tom Tromey  <tom@tromey.com>
13046
13047         * expression.h: Don't include symtab.h.
13048         (struct block): Forward declare.
13049
13050 2019-03-24  Tom Tromey  <tom@tromey.com>
13051
13052         * c-exp.y (typebase): Remove casts.
13053         * gdbtypes.c (lookup_unsigned_typename, )
13054         (lookup_signed_typename): Remove cast.
13055         * eval.c (parse_to_comma_and_eval): Remove cast.
13056         * parse.c (write_dollar_variable): Remove cast.
13057         * block.h (struct block) <superblock>: Now const.
13058         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
13059         * psymtab.c (psym_map_matching_symbols): Make "block" const.
13060         (map_block): Make "block" const.
13061         * symfile.h (struct quick_symbol_functions)
13062         <map_matching_symbols>: Constify block argument to "callback".
13063         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
13064         const.
13065         (find_pc_sect_compunit_symtab): Make "b" const.
13066         (find_symbol_at_address): Likewise.
13067         (search_symbols): Likewise.
13068         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
13069         (dw2_debug_names_lookup_symbol): Likewise.
13070         (dw2_map_matching_symbols): Update.
13071         * p-valprint.c (pascal_val_print): Remove "block".
13072         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
13073         (aux_add_nonlocal_symbols): Make "block" const.
13074         (resolve_subexp): Remove cast.
13075         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
13076         const.
13077         (iterate_over_file_blocks): Likewise.
13078         * f-exp.y (%union) <bval>: Remove.
13079         * coffread.c (patch_opaque_types): Make "b" const.
13080         * spu-tdep.c (spu_catch_start): Make "block" const.
13081         * c-valprint.c (print_unpacked_pointer): Remove "block".
13082         * symmisc.c (dump_symtab_1): Make "b" const.
13083         (block_depth): Make "block" const.
13084         * d-exp.y (%union) <bval>: Remove.
13085         * cp-support.h (cp_lookup_rtti_type): Update.
13086         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
13087         * psymtab.c (psym_lookup_symbol): Make "block" const.
13088         (maintenance_check_psymtabs): Make "b" const.
13089         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
13090         (enumerate_locals, enumerate_args): Update.
13091         * python/py-symtab.c (stpy_global_block): Make "block" const.
13092         (stpy_static_block): Likewise.
13093         * inline-frame.c (block_starting_point_at): Make "new_block"
13094         const.
13095         * block.c (find_block_in_blockvector): Make return type const.
13096         (blockvector_for_pc_sect): Make "b" const.
13097         (find_block_in_blockvector): Make "b" const.
13098
13099 2019-03-23  Tom Tromey  <tom@tromey.com>
13100
13101         * varobj.c (varobj_create): Update.
13102         * symfile.c (clear_symtab_users): Don't reset innermost_block.
13103         * printcmd.c (display_command, do_one_display): Don't reset
13104         innermost_block.
13105         * parser-defs.h (enum innermost_block_tracker_type): Move to
13106         expression.h.
13107         (innermost_block): Update comment.
13108         * parse.c (parse_exp_1): Add tracker_types parameter.
13109         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
13110         tracker_types parameter.  Reset innermost_block.
13111         (parse_exp_in_context): Remove.
13112         (parse_expression_for_completion): Update.
13113         * objfiles.c (~objfile): Don't reset expression_context_block or
13114         innermost_block.
13115         * expression.h (enum innermost_block_tracker_type): Move from
13116         parser-defs.h.
13117         (parse_exp_1): Add tracker_types parameter.
13118         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
13119         reset innermost_block.
13120
13121 2019-03-23  Tom Tromey  <tom@tromey.com>
13122
13123         * objfiles.h: Include bcache.h.
13124
13125 2019-03-23  Tom Tromey  <tom@tromey.com>
13126
13127         * linespec.c (get_current_search_block): Use
13128         scoped_restore_current_language.
13129         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
13130
13131 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
13132             Jiong Wang  <jiong.wang@arm.com>
13133
13134         * aarch64-linux-tdep.c
13135         (aarch64_linux_iterate_over_regset_sections): Check for pauth
13136         section.
13137         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
13138
13139 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
13140             Jiong Wang  <jiong.wang@arm.com>
13141
13142         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
13143         instructions.
13144         (aarch64_analyze_prologue_test): Add PACIASP test.
13145         (aarch64_prologue_prev_register): Unmask PC value.
13146
13147 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
13148             Jiong Wang  <jiong.wang@arm.com>
13149
13150         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
13151         (aarch64_dwarf2_prev_register): Unmask PC value.
13152         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
13153         (aarch64_execute_dwarf_cfa_vendor_op): Check for
13154         DW_CFA_AARCH64_negate_ra_state.
13155         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
13156
13157 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
13158             Jiong Wang  <jiong.wang@arm.com>
13159
13160         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
13161         registers.
13162         (aarch64_pseudo_register_name): Likewise.
13163         (aarch64_pseudo_register_type): Likewise.
13164         (aarch64_pseudo_register_reggroup_p): Likewise.
13165         (aarch64_gdbarch_init): Add pauth registers.
13166         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
13167         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
13168         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
13169         (struct gdbarch_tdep): Add regnum for ra_state.
13170
13171 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
13172             Jiong Wang  <jiong.wang@arm.com>
13173
13174         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
13175
13176 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
13177             Jiong Wang  <jiong.wang@arm.com>
13178
13179         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
13180         function.
13181         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
13182         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
13183         (aarch64_gdbarch_init): Add puth registers.
13184         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
13185         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
13186         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
13187
13188 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
13189             Jiong Wang  <jiong.wang@arm.com>
13190
13191         * aarch64-linux-nat.c
13192         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
13193         * aarch64-linux-tdep.c
13194         (aarch64_linux_core_read_description): Likewise.
13195         (aarch64_linux_get_hwcap): New function.
13196         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
13197         (aarch64_linux_get_hwcap): New declaration.
13198
13199 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
13200             Jiong Wang  <jiong.wang@arm.com>
13201
13202         * aarch64-linux-nat.c
13203         (aarch64_linux_nat_target::read_description): Add pauth param.
13204         * aarch64-linux-tdep.c
13205         (aarch64_linux_core_read_description): Likewise.
13206         * aarch64-tdep.c (struct target_desc): Add in pauth.
13207         (aarch64_read_description): Add pauth param.
13208         (aarch64_gdbarch_init): Likewise.
13209         * aarch64-tdep.h (aarch64_read_description): Likewise.
13210         * arch/aarch64.c (aarch64_create_target_description): Likewise.
13211         * arch/aarch64.h (aarch64_create_target_description): Likewise.
13212         * features/Makefile: Add new files.
13213         * features/aarch64-pauth.c: New file.
13214         * features/aarch64-pauth.xml: New file.
13215
13216 2019-03-20  Tom Tromey  <tromey@adacore.com>
13217
13218         * infrun.c (handle_inferior_event): Rename from
13219         handle_inferior_event_1.  Create a scoped_value_mark.
13220         (handle_inferior_event): Remove.
13221
13222 2019-03-19  Tom Tromey  <tromey@adacore.com>
13223
13224         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
13225         * infrun.h (print_stop_event): Add "displays" parameter.
13226         * infrun.c (print_stop_event): Add "displays" parameter.
13227
13228 2019-03-19  Pedro Alves  <palves@redhat.com>
13229
13230         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
13231         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
13232         to -1.  Fix TABs vs spaces.
13233         (tui_ui_out::tui_ui_out): Don't initialize fields here.
13234         * tui/tui-out.h (tui_ui_out) Add intro comments.
13235         <m_line, m_start_of_line>: In-class initialize, and add describing
13236         comment.
13237
13238 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
13239
13240         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
13241         variable names.
13242         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
13243
13244 2019-03-18  Pedro Alves  <palves@redhat.com>
13245             Eli Zaretskii <eliz@gnu.org>
13246
13247         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
13248         m_line and m_start_of_line.
13249
13250 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
13251
13252         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
13253         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
13254         it returns a newline.  This fixes a regression in TU mode, whereby
13255         the next line is output on the same screen line as the user input.
13256
13257 2019-03-18  Tom Tromey  <tromey@adacore.com>
13258
13259         * minsyms.c (minimal_symbol_reader::install): Remove call to
13260         obstack_blank.
13261
13262 2019-03-18  Pedro Alves  <palves@redhat.com>
13263
13264         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
13265         New globals.
13266         (apply_style): New, factored out from ...
13267         (apply_ansi_escape): ... this.  Handle reverse video mode.
13268         (tui_set_reverse_mode): New function.
13269         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
13270         * tui/tui-winsource.c (tui_show_source_line): Use
13271         tui_set_reverse_mode instead of setting A_STANDOUT.
13272         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
13273         New setter methods.
13274
13275 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
13276
13277         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
13278         Handle tabs.
13279
13280 2019-03-18  Tom Tromey  <tromey@adacore.com>
13281
13282         * ada-lang.c (empty_array): Add "high" parameter.
13283         (ada_evaluate_subexp): Update.
13284
13285 2019-03-17  Sergei Trofimovich <siarheit@google.com>
13286
13287         * unittests/string_view-selftests.c: Define
13288         _initialize_string_view_selftests unconditionally.
13289
13290 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
13291
13292         PR gdb/24350
13293         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
13294
13295 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
13296
13297         PR gdb/24351
13298         * windows-nat.c (display_selector): Fix format specifiers.
13299
13300 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
13301
13302         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
13303         tui_refill_source_window instead of tui_refresh_win, to update the
13304         current execution line.  This fixes redisplay of the current line
13305         when stepping through the code with "next" or "step".
13306
13307 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
13308
13309         * source-cache.c (source_cache::get_source_lines): Call
13310         find_source_lines to initialize s->nlines.  This fixes vertical
13311         scrolling of TUI source window when the DOWN arrow is pressed.
13312
13313 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
13314
13315         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
13316         linux-thread-db.c (_initialize_thread_db): Likewise.
13317
13318 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
13319
13320         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
13321         wclrtoeol in tui_show_source_line".  This reverts changes made in
13322         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
13323
13324 2019-03-15  Tom Tromey  <tom@tromey.com>
13325
13326         * symtab.h (struct minimal_symbol): Derive from
13327         general_symbol_info.
13328         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
13329         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
13330         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
13331         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
13332         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
13333         (MSYMBOL_SEARCH_NAME): Update.
13334         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
13335         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
13336         * minsyms.c (minimal_symbol_reader::record_full): Update.
13337
13338 2019-03-15  Tom Tromey  <tom@tromey.com>
13339
13340         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
13341
13342 2019-03-15  Tom Tromey  <tom@tromey.com>
13343
13344         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
13345         unique_xmalloc_ptr.
13346         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
13347         Update.
13348         * minsyms.c (lookup_minimal_symbol_by_pc_section)
13349         (build_minimal_symbol_hash_tables)
13350         (minimal_symbol_reader::install): Update.
13351
13352 2019-03-15  Tom Tromey  <tom@tromey.com>
13353
13354         * symtab.c (create_demangled_names_hash): Update.
13355         (symbol_set_names): Update.
13356         * objfiles.h (struct objfile_per_bfd_storage)
13357         <demangled_names_hash>: Now an htab_up.
13358         * objfiles.c (objfile_per_bfd_storage): Simplify.
13359
13360 2019-03-15  Tom Tromey  <tom@tromey.com>
13361
13362         * objfiles.h (struct objfile_per_bfd_storage): Declare
13363         destructor.
13364         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
13365         New.
13366         (get_objfile_bfd_data): Use new.  Don't initialize
13367         language_of_main.
13368         (free_objfile_per_bfd_storage): Remove.
13369         (objfile_bfd_data_free, objfile::~objfile): Use delete.
13370
13371 2019-03-15  Tom Tromey  <tom@tromey.com>
13372
13373         * symfile.c (reread_symbols): Update.
13374         * objfiles.c (objfile::objfile): Update.
13375         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
13376         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
13377         comment.
13378         (minimal_symbol_reader::install): Update.
13379         (terminate_minimal_symbol_table): Remove.
13380         * jit.c (jit_object_close_impl): Update.
13381
13382 2019-03-15  Tom Tromey  <tom@tromey.com>
13383
13384         * minsyms.c (minimal_symbol_reader::record_full): Remove some
13385         initializations.
13386
13387 2019-03-15  Tom Tromey  <tom@tromey.com>
13388
13389         * objfiles.h (struct objfile_per_bfd_storage)
13390         <demangled_hash_languages>: Now a bitset.
13391         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
13392         (lookup_minimal_symbol): Update.
13393
13394 2019-03-15  Tom Tromey  <tom@tromey.com>
13395
13396         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
13397         Don't return the symbol.
13398         * coffread.c (record_minimal_symbol): Use record_full.
13399
13400 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
13401
13402         The MS-Windows port of ncurses fails to switch to a color pair if
13403         one or both of the colors are the implicit default colors.  This
13404         change records the default colors when TUI is initialized, and
13405         then specifies them explicitly when a color pair uses the default
13406         colors.  This allows color styling in TUI mode on MS-Windows.
13407
13408         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
13409         ncurses_norm_attr.
13410         (tui_initialize_io) [__MINGW32__]: Record the default terminal
13411         colors in ncurses_norm_attr.
13412         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
13413         "none", replace it with the default color recorded in
13414         ncurses_norm_attr.
13415
13416 2019-03-14  Tom Tromey  <tromey@adacore.com>
13417
13418         * source-cache.h (class source_cache) <get_source_lines>: Return
13419         std::string.
13420         * source-cache.c (source_cache::extract_lines): Handle case where
13421         first_pos==npos.  Return std::string.
13422         (source_cache::get_source_lines): Update.
13423
13424 2019-03-14  Tom Tromey  <tromey@adacore.com>
13425
13426         * NEWS: Add item for "style sources" commands.
13427         * source-cache.c (source_cache::get_source_lines): Check
13428         source_styling.
13429         * cli/cli-style.c (source_styling): New global.
13430         (_initialize_cli_style): Add "style sources" commands.
13431         (show_style_sources): New function.
13432         * cli/cli-style.h (source_styling): Declare.
13433
13434 2019-03-14  Pedro Alves  <palves@redhat.com>
13435             Tom Tromey  <tromey@adacore.com>
13436
13437         * tui/tui-winsource.h (tui_refill_source_window): Declare.
13438         * tui/tui-winsource.c (tui_refill_source_window): New function,
13439         from...
13440         (tui_horizontal_source_scroll): ... here.  Move some logic.
13441         * cli/cli-style.c (set_style_enabled): Notify new observable.
13442         * tui/tui-hooks.c (tui_redisplay_source): New function.
13443         (tui_attach_detach_observers): Attach or detach
13444         tui_redisplay_source.
13445         * observable.h (source_styling_changed): New observable.
13446         * observable.c: Define source_styling_changed observable.
13447
13448 2019-03-13  Tom Tromey  <tromey@adacore.com>
13449
13450         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
13451         (i386_gnu_nat_target::store_registers): Update.
13452         * target-debug.h (target_debug_print_std_string): New macro.
13453         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
13454         * windows-tdep.c (display_one_tib): Update.
13455         * tui/tui-stack.c (tui_make_status_line): Update.
13456         * top.c (print_inferior_quit_action): Update.
13457         * thread.c (thr_try_catch_cmd): Update.
13458         (add_thread_with_info): Update.
13459         (thread_target_id_str): Update.
13460         (thr_try_catch_cmd): Update.
13461         (thread_command): Update.
13462         (thread_find_command): Update.
13463         * record-btrace.c (record_btrace_target::info_record)
13464         (record_btrace_resume_thread, record_btrace_target::resume)
13465         (record_btrace_cancel_resume, record_btrace_step_thread)
13466         (record_btrace_target::wait, record_btrace_target::wait)
13467         (record_btrace_target::wait, record_btrace_target::stop): Update.
13468         * progspace.c (print_program_space): Update.
13469         * process-stratum-target.c
13470         (process_stratum_target::thread_address_space): Update.
13471         * linux-fork.c (linux_fork_mourn_inferior)
13472         (detach_checkpoint_command, info_checkpoints_command)
13473         (linux_fork_context): Update.
13474         (linux_fork_detach): Update.
13475         (class scoped_switch_fork_info): Update.
13476         (delete_checkpoint_command): Update.
13477         * infrun.c (follow_fork_inferior): Update.
13478         (follow_fork_inferior): Update.
13479         (proceed_after_vfork_done): Update.
13480         (handle_vfork_child_exec_or_exit): Update.
13481         (follow_exec): Update.
13482         (displaced_step_prepare_throw): Update.
13483         (displaced_step_restore): Update.
13484         (start_step_over): Update.
13485         (resume_1): Update.
13486         (clear_proceed_status_thread): Update.
13487         (proceed): Update.
13488         (print_target_wait_results): Update.
13489         (do_target_wait): Update.
13490         (context_switch): Update.
13491         (stop_all_threads): Update.
13492         (restart_threads): Update.
13493         (finish_step_over): Update.
13494         (handle_signal_stop): Update.
13495         (switch_back_to_stepped_thread): Update.
13496         (keep_going_pass_signal): Update.
13497         (print_exited_reason): Update.
13498         (normal_stop): Update.
13499         * inferior.c (inferior_pid_to_str): Change return type.
13500         (print_selected_inferior): Update.
13501         (add_inferior): Update.
13502         (detach_inferior): Update.
13503         * dummy-frame.c (fprint_dummy_frames): Update.
13504         * dcache.c (dcache_info_1): Update.
13505         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
13506         (btrace_fetch, btrace_clear): Update.
13507         * linux-tdep.c (linux_core_pid_to_str): Change return type.
13508         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
13509         type.
13510         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
13511         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
13512         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
13513         * gdbarch.c, gdbarch.h: Rebuild.
13514         * gdbarch.sh (core_pid_to_str): Change return type.
13515         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
13516         return type.
13517         (windows_nat_target::pid_to_str): Change return type.
13518         (windows_delete_thread): Update.
13519         (windows_nat_target::attach): Update.
13520         (windows_nat_target::files_info): Update.
13521         * target-delegates.c: Rebuild.
13522         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
13523         return type.
13524         (sol_thread_target::pid_to_str): Change return type.
13525         * remote.c (class remote_target) <pid_to_str>: Change return
13526         type.
13527         (remote_target::pid_to_str): Change return type.
13528         (extended_remote_target::attach, remote_target::remote_stop_ns)
13529         (remote_target::remote_notif_remove_queued_reply)
13530         (remote_target::push_stop_reply, remote_target::disable_btrace):
13531         Update.
13532         (extended_remote_target::attach): Update.
13533         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
13534         type.
13535         (gdbsim_target::pid_to_str): Change return type.
13536         * ravenscar-thread.c (struct ravenscar_thread_target)
13537         <pid_to_str>: Change return type.
13538         (ravenscar_thread_target::pid_to_str): Change return type.
13539         * procfs.c (class procfs_target) <pid_to_str>: Change return
13540         type.
13541         (procfs_target::pid_to_str): Change return type.
13542         (procfs_target::attach): Update.
13543         (procfs_target::detach): Update.
13544         (procfs_target::fetch_registers): Update.
13545         (procfs_target::store_registers): Update.
13546         (procfs_target::wait): Update.
13547         (procfs_target::files_info): Update.
13548         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
13549         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
13550         return type.
13551         (nto_procfs_target::pid_to_str): Change return type.
13552         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
13553         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
13554         return type.
13555         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
13556         (exit_lwp): Update.
13557         (attach_proc_task_lwp_callback, get_detach_signal)
13558         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
13559         (linux_nat_target::resume, wait_lwp, stop_callback)
13560         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
13561         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
13562         (linux_nat_wait_1, resume_stopped_resumed_lwps)
13563         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
13564         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
13565         type.
13566         (inf_ptrace_target::attach): Update.
13567         (inf_ptrace_target::files_info): Update.
13568         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
13569         type.
13570         (go32_nat_target::pid_to_str): Change return type.
13571         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
13572         (gnu_nat_target::wait): Update.
13573         (gnu_nat_target::wait): Update.
13574         (gnu_nat_target::resume): Update.
13575         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
13576         (fbsd_nat_target::wait): Update.
13577         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
13578         type.
13579         (darwin_nat_target::attach): Update.
13580         * corelow.c (class core_target) <pid_to_str>: Change return type.
13581         (core_target::pid_to_str): Change return type.
13582         * target.c (normal_pid_to_str): Change return type.
13583         (default_pid_to_str): Likewise.
13584         (target_pid_to_str): Change return type.
13585         (target_translate_tls_address): Update.
13586         (target_announce_detach): Update.
13587         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
13588         return type.
13589         (bsd_uthread_target::pid_to_str): Change return type.
13590         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
13591         type.
13592         (bsd_kvm_target::pid_to_str): Change return type.
13593         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
13594         return type.
13595         (aix_thread_target::pid_to_str): Change return type.
13596         * target.h (struct target_ops) <pid_to_str>: Change return type.
13597         (target_pid_to_str, normal_pid_to_str): Likewise.
13598         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
13599         type.
13600         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
13601         type.
13602         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
13603         return type.
13604         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
13605         type.
13606         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
13607         type.
13608         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
13609         return type.
13610
13611 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
13612
13613         * NEWS: Mention that the new default MI version is 3.  Mention
13614         changes to the output of commands and events that deal with
13615         multi-location breakpoints.
13616         * breakpoint.c: Include "mi/mi-out.h".
13617         (print_one_breakpoint): Change output syntax if using MI version
13618         >= 3.
13619         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
13620         New.
13621         (mi_multi_location_breakpoint_output_fixed): New.
13622         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
13623         (mi_cmd_fix_multi_location_breakpoint_output): New.
13624         (mi_multi_location_breakpoint_output_fixed): New.
13625         * mi/mi-cmds.c (mi_cmds): Register command
13626         -fix-multi-location-breakpoint-output.
13627         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
13628         interpreter "mi".
13629
13630 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
13631
13632         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
13633         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
13634         instantiate mi_ui_out based on interpreter name.
13635         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
13636         * mi/mi-main.c (mi_load_progress): Likewise.
13637
13638 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
13639
13640         * NEWS: Combine separate "New targets" sections for 8.3.
13641
13642 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
13643
13644         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
13645         (ppcfbsd_init_abi): Install gdbarch
13646         "fetch_tls_load_module_address" and "get_thread_local_address"
13647         methods.
13648
13649 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
13650
13651         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
13652         (riscv_fbsd_init_abi): Install gdbarch
13653         "fetch_tls_load_module_address" and "get_thread_local_address"
13654         methods.
13655
13656 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
13657
13658         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
13659         (i386fbsd_init_abi): Install gdbarch
13660         "fetch_tls_load_module_address" and "get_thread_local_address"
13661         methods.
13662
13663 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
13664
13665         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
13666         (amd64fbsd_init_abi): Install gdbarch
13667         "fetch_tls_load_module_address" and "get_thread_local_address"
13668         methods.
13669
13670 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
13671
13672         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
13673         (struct fbsd_pspace_data): New type.
13674         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
13675         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
13676         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
13677         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
13678         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
13679
13680 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
13681
13682         * gdbtypes.c (lookup_struct_elt): New function.
13683         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
13684         * gdbtypes.h (struct struct_elt): New type.
13685         (lookup_struct_elt): New prototype.
13686
13687 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
13688
13689         * gdbtypes.c (lookup_struct_elt_type): Update comment and
13690         remove disabled code block.
13691
13692 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
13693
13694         * gdbarch.sh (get_thread_local_address): New method.
13695         * gdbarch.h, gdbarch.c: Regenerate.
13696         * target.c (target_translate_tls_address): Use
13697         gdbarch_get_thread_local_address if present instead of
13698         target::get_thread_local_address.
13699
13700 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
13701
13702         * target.h (target::get_thread_local_address): Update comment.
13703
13704 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
13705
13706         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
13707         objfile->separate_debug_objfile_backlink if not NULL.
13708
13709 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
13710
13711         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
13712         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
13713         (amd64bsd_store_inferior_registers): Likewise.
13714         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
13715         Enable segment base registers.
13716         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
13717         PT_GETFSBASE and PT_GETGSBASE.
13718         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
13719         PT_SETGSBASE.
13720         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
13721         segment base registers.
13722         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
13723
13724 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
13725
13726         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
13727         Update calls to i386_target_description to add 'segments'
13728         parameter.
13729         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
13730         add segment base registers.
13731         * arch/i386.c (i386_create_target_description): Add 'segments'
13732         parameter to enable segment base registers.
13733         * arch/i386.h (i386_create_target_description): Likewise.
13734         * features/i386/32bit-segments.xml: New file.
13735         * features/i386/32bit-segments.c: Generate.
13736         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
13737         call to i386_target_description to add 'segments' parameter.
13738         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
13739         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
13740         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
13741         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
13742         if feature is present.
13743         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
13744         Add 'segments' parameter to call to i386_target_description.
13745         (i386_target_description): Add 'segments' parameter to enable
13746         segment base registers.
13747         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
13748         to call to i386_target_description.
13749         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
13750         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
13751         Define I386_NUM_REGS.
13752         (i386_target_description): Add 'segments' parameter to enable
13753         segment base registers.
13754
13755 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
13756
13757         PR/24325
13758         * source-cache.c: #undef open and close, to avoid unresolved
13759         externals during linking.
13760
13761 2019-03-12  Tom Tromey  <tromey@adacore.com>
13762
13763         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
13764         const.  Add initializers.
13765         (_initialize_remote): Don't initialize ptid globals.
13766
13767 2019-03-12  Pedro Alves  <palves@redhat.com>
13768
13769         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
13770
13771 2019-03-12  Pedro Alves  <palves@redhat.com>
13772
13773         * cp-name-parser.y (main): Remove unused 'len' variable.
13774
13775 2019-03-12  Tom Tromey  <tromey@adacore.com>
13776
13777         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
13778         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
13779
13780 2019-03-12  Tom Tromey  <tromey@adacore.com>
13781
13782         * linux-nat.c (iterate_over_lwps): Update.
13783         (stop_callback): Remove parameter.
13784         (stop_wait_callback, detach_callback, resume_set_callback)
13785         (select_singlestep_lwp_callback, set_ignore_sigint)
13786         (status_callback, resumed_callback, resume_clear_callback)
13787         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
13788         data parameter.
13789         (linux_nat_target::detach, linux_nat_target::resume)
13790         (linux_stop_and_wait_all_lwps, select_event_lwp)
13791         (linux_nat_filter_event, linux_nat_wait_1)
13792         (linux_nat_target::kill, linux_nat_target::stop)
13793         (linux_nat_target::stop): Update.
13794         (linux_nat_resume_callback): Change type.
13795         (resume_stopped_resumed_lwps, count_events_callback)
13796         (select_event_lwp_callback): Likewise.
13797         (linux_stop_lwp, linux_nat_stop_lwp): Update.
13798         * arm-linux-nat.c (struct update_registers_data): Remove.
13799         (update_registers_callback): Change type.
13800         (arm_linux_insert_hw_breakpoint1): Update.
13801         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
13802         parameter.
13803         (x86_linux_dr_set_addr): Update.
13804         (x86_linux_dr_set_control): Update.
13805         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
13806         (iterate_over_lwps): Use gdb::function_view.
13807         * nat/aarch64-linux-hw-point.c (struct
13808         aarch64_dr_update_callback_param): Remove.
13809         (debug_reg_change_callback): Change type.
13810         (aarch64_notify_debug_reg_change): Update.
13811         * s390-linux-nat.c (s390_refresh_per_info): Update.
13812
13813 2019-03-11  Tom Tromey  <tromey@adacore.com>
13814
13815         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
13816         redundant assignment to "this_cu".
13817
13818 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
13819
13820         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
13821
13822 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
13823
13824         * gdbtypes.c (rank_one_type_parm_set): New function extracted
13825         from...
13826         (rank_one_type): ... this.
13827
13828 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
13829
13830         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
13831         from...
13832         (rank_one_type): ... this.
13833
13834 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
13835
13836         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
13837         from...
13838         (rank_one_type): ... this.
13839
13840 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
13841
13842         * gdbtypes.c (rank_one_type_parm_float): New function extracted
13843         from...
13844         (rank_one_type): ... this.
13845
13846 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
13847
13848         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
13849         from...
13850         (rank_one_type): ... this.
13851
13852 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
13853
13854         * gdbtypes.c (rank_one_type_parm_range): New function extracted
13855         from...
13856         (rank_one_type): ... this.
13857
13858 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
13859
13860         * gdbtypes.c (rank_one_type_parm_char): New function extracted
13861         from...
13862         (rank_one_type): ... this.
13863
13864 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
13865
13866         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
13867         from...
13868         (rank_one_type): ... this.
13869
13870 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
13871
13872         * gdbtypes.c (rank_one_type_parm_int): New function extracted
13873         from...
13874         (rank_one_type): ... this.
13875
13876 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
13877
13878         * gdbtypes.c (rank_one_type_parm_func): New function extracted
13879         from...
13880         (rank_one_type): ... this.
13881
13882 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
13883
13884         * gdbtypes.c (rank_one_type_parm_array): New function extracted
13885         from...
13886         (rank_one_type): ... this.
13887
13888 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
13889
13890         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
13891         from...
13892         (rank_one_type): ... this.
13893
13894 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
13895
13896         * inferior.c (initialize_inferiors): Ensure 'help set/show print
13897         inferior-events' shows the example events.
13898
13899 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
13900
13901         Support styling on native MS-Windows console
13902
13903         PR/24315
13904         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
13905         on MS-Windows if $TERM is not defined.
13906
13907         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
13908
13909         * posix-hdep.c (gdb_console_fputs):
13910         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
13911         functions.
13912         * ui-file.h (gdb_console_fputs): Add prototype.
13913
13914         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
13915         back to fputs only if the former returns zero.
13916
13917 2019-03-07  Tom Tromey  <tom@tromey.com>
13918
13919         * symmisc.c (print_symbol_bcache_statistics): Update.
13920         (print_objfile_statistics): Update.
13921         * symfile.c (allocate_symtab): Update.
13922         * stabsread.c: Don't include bcache.h.
13923         * psymtab.h (struct psymbol_bcache): Don't declare.
13924         (class psymtab_storage) <psymbol_cache>: Now a bcache.
13925         (psymbol_bcache_init, psymbol_bcache_free)
13926         (psymbol_bcache_get_bcache): Don't declare.
13927         * psymtab.c (struct psymbol_bcache): Remove.
13928         (psymtab_storage::psymtab_storage): Update.
13929         (psymtab_storage::~psymtab_storage): Update.
13930         (psymbol_bcache_init, psymbol_bcache_free)
13931         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
13932         (add_psymbol_to_bcache): Update.
13933         (allocate_psymtab): Update.
13934         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
13935         macro_cache>: No longer pointers.
13936         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
13937         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
13938         * macrotab.c (macro_bcache): Update.
13939         * macroexp.c: Don't include bcache.h.
13940         * gdbtypes.c (check_types_worklist): Update.
13941         (types_deeply_equal): Remove TRY/CATCH.  Update.
13942         * elfread.c (elf_symtab_read): Update.
13943         * dwarf2read.c: Don't include bcache.h.
13944         * buildsym.c (buildsym_compunit::get_macro_table): Update.
13945         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
13946         (print_bcache_statistics, bcache_memory_used): Don't declare.
13947         (struct bcache): Move from bcache.c.  Add constructor, destructor,
13948         methods.  Rename all data members.
13949         * bcache.c (struct bcache): Move to bcache.h.
13950         (bcache::expand_hash_table): Rename from expand_hash_table.
13951         (bcache): Remove.
13952         (bcache::insert): Rename from bcache_full.
13953         (bcache::compare): Rename from bcache_compare.
13954         (bcache_xmalloc): Remove.
13955         (bcache::~bcache): Rename from bcache_xfree.
13956         (bcache::print_statistics): Rename from print_bcache_statistics.
13957         (bcache::memory_used): Rename from bcache_memory_used.
13958
13959 2019-03-07  Pedro Alves  <palves@redhat.com>
13960
13961         * infrun.c (normal_stop): Also check for
13962         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
13963
13964 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
13965
13966         * f-lang.c (value_from_host_double): Moved to...
13967         * value.c (value_from_host_double): ...here.
13968         * value.h (value_from_host_double): Declare.
13969         * guile/scm-math.c (vlscm_convert_typed_number): Use
13970         value_from_host_double.
13971         (vlscm_convert_number): Likewise.
13972         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
13973         * python/py-value.c (convert_value_from_python): Likewise.
13974
13975 2019-03-06  Tom Tromey  <tom@tromey.com>
13976
13977         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
13978
13979 2019-03-06  Tom Tromey  <tom@tromey.com>
13980
13981         * utils.h (free_current_contents): Don't declare.
13982         * utils.c (free_current_contents): Remove.
13983
13984 2019-03-06  Tom Tromey  <tom@tromey.com>
13985
13986         * top.c (quit_force): Update.
13987         * main.c (captured_command_loop): Update.
13988         * common/new-op.c (operator new): Update.
13989         * common/common-exceptions.c (struct catcher)
13990         <save_cleanup_chain>: Remove member.
13991         (exceptions_state_mc_init): Update.
13992         (exception_try_scope_entry): Return nullptr.
13993         (exception_try_scope_exit, exception_rethrow)
13994         (throw_exception_sjlj, throw_exception_cxx): Update.
13995         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
13996         (all_cleanups, do_cleanups, discard_cleanups)
13997         (discard_final_cleanups, save_cleanups, save_final_cleanups)
13998         (restore_cleanups, restore_final_cleanups): Don't declare.
13999         (do_final_cleanups): Remove parameter.
14000         * common/cleanups.c (cleanup_chain, make_cleanup)
14001         (make_cleanup_dtor, all_cleanups, do_cleanups)
14002         (discard_my_cleanups, discard_cleanups)
14003         (discard_final_cleanups, save_my_cleanups, save_cleanups)
14004         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
14005         (null_cleanup): Remove.
14006         (do_final_cleanups): Remove parameter.
14007
14008 2019-03-06  Tom Tromey  <tom@tromey.com>
14009
14010         * remote.c (remote_target::remote_parse_stop_reply): Use
14011         unique_xmalloc_ptr.
14012
14013 2019-03-06  Tom Tromey  <tom@tromey.com>
14014
14015         * stabsread.c (struct stabs_field_info): Rename from field_info.
14016         <list, fnlist>: Add initializers.
14017         <obstack>: New member.
14018         (read_member_functions, read_struct_fields, read_baseclasses):
14019         Allocate on obstack.  Don't use cleanups.
14020         (read_one_struct_field, read_member_functions, read_struct_fields)
14021         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
14022         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
14023         (read_struct_type): Update.
14024
14025 2019-03-06  Tom Tromey  <tom@tromey.com>
14026
14027         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
14028         * common/filestuff.h (make_cleanup_close): Don't declare.
14029         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
14030         Remove.
14031
14032 2019-03-06  Tom Tromey  <tom@tromey.com>
14033
14034         * solib-aix.c: Use make_scope_exit.
14035
14036 2019-03-06  Tom Tromey  <tom@tromey.com>
14037
14038         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
14039         Use make_scope_exit.
14040
14041 2019-03-06  Tom Tromey  <tom@tromey.com>
14042
14043         * solib-svr4.c (disable_probes_interface): Remove parameter.
14044         (svr4_handle_solib_event): Use make_scope_exit.
14045
14046 2019-03-06  Tom Tromey  <tom@tromey.com>
14047
14048         * remote.c (struct stop_reply_deleter): Remove.
14049         (stop_reply_up): Update.
14050         (struct stop_reply): Derive from notif_event.  Don't typedef.
14051         <regcache>: Now a std::vector.
14052         (stop_reply_xfree): Remove.
14053         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
14054         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
14055         (remote_target::discard_pending_stop_replies): Use delete.
14056         (remote_target::remote_parse_stop_reply): Update.
14057         (remote_target::process_stop_reply): Update.
14058         * remote-notif.h (struct notif_event): Add virtual destructor.
14059         Remove "dtr" member.
14060         (struct notif_client) <alloc_event>: Return a unique_ptr.
14061         (notif_event_xfree): Don't declare.
14062         (notif_event_up): New typedef.
14063         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
14064         (notif_event_xfree, do_notif_event_xfree): Remove.
14065         (remote_notif_state_xfree): Update.
14066
14067 2019-03-06  Tom Tromey  <tom@tromey.com>
14068
14069         * infrun.c (displaced_step_clear_cleanup): Now a
14070         forward_scope_exit type.
14071         (displaced_step_prepare_throw): Update.
14072         (displaced_step_fixup): Update.
14073
14074 2019-03-06  Tom Tromey  <tom@tromey.com>
14075
14076         * inferior.h (class inferior): Update comment.
14077         * gdbthread.h (class thread_info): Update comment.
14078
14079 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
14080             Tom Tromey  <tom@tromey.com>
14081
14082         * stabsread.h (struct stab_section_list): Remove.
14083         (coffstab_build_psymtabs): Update.
14084         * dbxread.c (symbuf_sections): Now a std::vector.
14085         (sect_idx): New global.
14086         (fill_symbuf): Update.
14087         (coffstab_build_psymtabs): Change type of stabsects parameter.
14088         Update.
14089         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
14090         std::vector.
14091         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
14092         (coff_locate_sections): Update.
14093         (coff_symfile_read): Remove cleanups.  Update.
14094         (init_stringtab): Add storage parameter.
14095         (free_stringtab, free_stringtab_cleanup): Remove.
14096         (init_lineno): Add storage parameter.
14097         (free_linetab, free_linetab_cleanup): Remove.
14098
14099 2019-03-06  Pedro Alves  <palves@redhat.com>
14100
14101         * linux-fork.c (fork_info::clobber_regs): Delete.
14102         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
14103         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
14104         comment.  Adjust.
14105         (scoped_switch_fork_info::scoped_switch_fork_info)
14106         (checkpoint_command, linux_fork_context): Adjust
14107         fork_save_infrun_state calls.
14108
14109 2019-03-06  Pedro Alves  <palves@redhat.com>
14110
14111         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
14112         (inf_has_multiple_threads): Return 'bool' and rewrite using
14113         inferior_info::threads().
14114
14115 2019-03-06  Pedro Alves  <palves@redhat.com>
14116
14117         * linux-fork.c: Include <list>.
14118         (fork_list): Now a std::list instance.
14119         (fork_info): Add ctor, dtor, and in-class initialize all fields.
14120         (forks_exist_p, find_last_fork): Adjust.
14121         (new_fork): Delete.
14122         (one_fork_p): New.
14123         (add_fork): Adjust.
14124         (free_fork): Delete, folded into fork_info::~fork_info().
14125         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
14126         Adjust.
14127         (init_fork_list): Delete.
14128         (linux_fork_killall, linux_fork_mourn_inferior)
14129         (linux_fork_detach, info_checkpoints_command): Adjust.
14130         (_initialize_linux_fork): No longer call init_fork_list.
14131
14132 2019-03-06  Pedro Alves  <palves@redhat.com>
14133
14134         * linux-fork.c (new_fork): New, split out of ...
14135         (add_fork): ... this.  Return void.  Move "first fork" special
14136         case from here, to ...
14137         (checkpoint_command): ... here.
14138         * linux-linux.h (add_fork): Return void.
14139
14140 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
14141
14142         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
14143
14144 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
14145             Chris January  <chris.january@arm.com>
14146             David Lecomber  <david.lecomber@arm.com>
14147
14148         * f-exp.y: New token, UNOP_INTRINSIC.
14149         (exp): New pattern using UNOP_INTRINSIC token.
14150         (f77_keywords): Add 'abs' keyword.
14151         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
14152         (value_from_host_double): New function.
14153         (evaluate_subexp_f): Support UNOP_ABS.
14154
14155 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
14156
14157         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
14158         types.
14159
14160 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
14161
14162         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
14163         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
14164         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
14165
14166 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
14167
14168         * f-exp.y (convert_to_kind_type): Handle more type kinds.
14169
14170 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
14171             Chris January  <chris.january@arm.com>
14172
14173         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
14174         * f-exp.y: Define 'KIND' token.
14175         (exp): New pattern for KIND expressions.
14176         (ptype): Handle types with a kind extension.
14177         (direct_abs_decl): Extend to spot kind extensions.
14178         (f77_keywords): Add 'kind' to the list.
14179         (push_kind_type): New function.
14180         (convert_to_kind_type): New function.
14181         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
14182         * parse.c (operator_length_standard): Likewise.
14183         * parser-defs.h (enum type_pieces): Add tp_kind.
14184         * std-operator.def: Add UNOP_KIND.
14185
14186 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
14187
14188         * f-exp.y (f_parse): Set yydebug.
14189
14190 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
14191
14192         * f-lang.c (evaluate_subexp_f): New function.
14193         (exp_descriptor_f): New global.
14194         (f_language_defn): Use exp_descriptor_f instead of
14195         exp_descriptor_standard.
14196
14197 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
14198
14199         * f-exp.y (struct token): Add comments.
14200         (dot_ops): Remove uppercase versions and the end marker.
14201         (f77_keywords): Likewise.
14202         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
14203         entries in the dot_ops array are case insensitive, and use
14204         strncasecmp to compare strings.  Also some whitespace cleanup in
14205         this area.  Similar for the f77_keywords array, except entries in
14206         this list might be case sensitive.
14207
14208 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
14209
14210         * f-exp.y (struct f77_boolean_val): Add comments.
14211         (boolean_values): Remove uppercase versions, and end marker.
14212         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
14213         and use strncasecmp to achieve case insensitivity.  Additionally,
14214         perform whitespace cleanup around this code.
14215
14216 2019-03-06  Tom Tromey  <tromey@adacore.com>
14217
14218         * remote-sim.c (gdbsim_target_open): Use result of
14219         gdb_argv::release.
14220
14221 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
14222         Dirk Schubert  <dirk.schubert@arm.com>
14223         Chris January  <chris.january@arm.com>
14224
14225         * eval.c (evaluate_subexp_standard): Call Fortran argument
14226         wrapping logic.
14227         * f-lang.c (struct value): A value which can be passed into a
14228         Fortran function call.
14229         (fortran_argument_convert): Wrap Fortran arguments in a pointer
14230         where appropriate.
14231         (struct type): Value ready for a Fortran function call.
14232         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
14233         is needed.
14234         * f-lang.h (fortran_argument_convert): Declaration.
14235         (fortran_preserve_arg_pointer): Declaration.
14236         * infcall.c (value_arg_coerce): Call Fortran argument logic.
14237
14238 2019-03-05  Tom Tromey  <tromey@adacore.com>
14239
14240         * python/py-prettyprint.c (print_string_repr): Remove #if.
14241         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
14242
14243 2019-03-05  Tom Tromey  <tromey@adacore.com>
14244
14245         * target.c (the_dummy_target): Move later.  Change type to
14246         "dummy_target".
14247         (initialize_targets): Don't initialize the_dummy_target.
14248
14249 2019-03-05  Tom Tromey  <tromey@adacore.com>
14250
14251         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
14252         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
14253
14254 2019-03-05  Tom Tromey  <tromey@adacore.com>
14255
14256         * windows-nat.c (windows_nat_target::attach)
14257         (windows_nat_target::detach): Don't call gdb_flush.
14258         * valprint.c (generic_val_print, val_print, val_print_string):
14259         Don't call gdb_flush.
14260         * utils.c (defaulted_query): Don't call gdb_flush.
14261         * typeprint.c (print_type_scalar): Don't call gdb_flush.
14262         * target.c (target_announce_detach): Don't call gdb_flush.
14263         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
14264         * remote.c (extended_remote_target::attach): Don't call
14265         gdb_flush.
14266         * procfs.c (procfs_target::detach): Don't call gdb_flush.
14267         * printcmd.c (do_examine): Don't call gdb_flush.
14268         (info_display_command): Don't call gdb_flush.
14269         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
14270         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
14271         * memattr.c (info_mem_command): Don't call gdb_flush.
14272         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
14273         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
14274         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
14275         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
14276         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
14277         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
14278         (gnu_nat_target::detach): Don't call gdb_flush.
14279         * f-valprint.c (f_val_print): Don't call gdb_flush.
14280         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
14281         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
14282         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
14283         gdb_flush.
14284         * c-valprint.c (c_val_print): Don't call gdb_flush.
14285         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
14286
14287 2019-03-05  Tom Tromey  <tromey@adacore.com>
14288
14289         * varobj.c (update_dynamic_varobj_children): Update.
14290         (install_default_visualizer): Use reset, not release.
14291         * value.c (set_internalvar): Update.
14292         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
14293         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
14294         ATTRIBUTE_UNUSED_RESULT.
14295
14296 2019-03-05  Tom Tromey  <tromey@adacore.com>
14297
14298         * remote.c (class scoped_remote_fd) <release>: Add
14299         ATTRIBUTE_UNUSED_RESULT.
14300
14301 2019-03-05  Tom Tromey  <tromey@adacore.com>
14302
14303         * macroexp.c (struct macro_buffer) <release>: Add
14304         ATTRIBUTE_UNUSED_RESULT.
14305
14306 2019-03-05  Tom Tromey  <tromey@adacore.com>
14307
14308         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
14309         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
14310         ATTRIBUTE_UNUSED_RESULT.
14311
14312 2019-03-05  Tom Tromey  <tromey@adacore.com>
14313
14314         * common/scoped_fd.h (class scoped_fd) <release>: Add
14315         ATTRIBUTE_UNUSED_RESULT.
14316
14317 2019-03-05  Tom Tromey  <tromey@adacore.com>
14318
14319         * parser-defs.h (struct parser_state) <release>: Add
14320         ATTRIBUTE_UNUSED_RESULT.
14321
14322 2019-03-05  Tom Tromey  <tromey@adacore.com>
14323
14324         * utils.h (class gdb_argv) <release>: Add
14325         ATTRIBUTE_UNUSED_RESULT.
14326         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
14327
14328 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
14329
14330         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
14331         for-loop range, to avoid compiler warnings.
14332
14333         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
14334         avoid compiler warnings about unused variables.
14335
14336         * NEWS: Mention end of support for native debugging on MS-Windows
14337         before XP.
14338
14339         PR gdb/24292
14340         * common/netstuff.c:
14341         * gdbserver/gdbreplay.c
14342         * gdbserver/remote-utils.c:
14343         * ser-tcp.c:
14344         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
14345         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
14346         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
14347         'getaddrinfo' and 'freeaddrinfo' were not available before
14348         Windows XP, and mingw.org's MinGW headers by default define
14349         _WIN32_WINNT to 0x500.
14350
14351 2019-03-01  Gary Benson <gbenson@redhat.com>
14352
14353         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
14354
14355 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
14356             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
14357
14358         PR gdb/8527
14359         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
14360         set_sigint_trap, clear_sigint_trap.
14361
14362 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
14363
14364         * target.c (target_detach): Clear the regcache and the
14365         frame cache.
14366
14367 2019-02-27  Pedro Alves  <palves@redhat.com>
14368
14369         * utils.c (set_screen_size): When we cap the height/width sizes,
14370         tweak the corresponding command variable to show "unlimited":
14371
14372 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
14373             Pedro Alves  <palves@redhat.com>
14374
14375         * utils.c (set_screen_size): Reduce "infinite" rows and columns
14376         before calling rl_set_screen_size.
14377
14378 2019-02-27  Tom Tromey  <tromey@adacore.com>
14379
14380         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
14381         define.
14382         * python/py-value.c: Remove Python 2.4 workaround.
14383         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
14384         workaround.
14385         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
14386         Python 2.4 workaround.
14387         * python/python-internal.h: Remove Python 2.4 comment.
14388         (Py_ssize_t): Don't define.
14389         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
14390         (gdb_Py_DECREF): Remove Python 2.4 workaround.
14391         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
14392         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
14393         * python/python.c (do_start_initialization): Remove Python 2.4
14394         workaround.
14395         * python/py-prettyprint.c (class dummy_python_frame): Remove.
14396         (print_children): Remove Python 2.4 workaround.
14397         * python/py-inferior.c (buffer_procs): Remove Python 2.4
14398         workaround.
14399         (CHARBUFFERPROC_NAME): Remove.
14400         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
14401         Python 2.4 workaround.
14402
14403 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
14404
14405         * NEWS: Note minimum Python version.
14406
14407 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
14408
14409         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
14410         code from these functions.  Remove corresponding ifdefs.  Use
14411         Py_buffer_up instead of explicit calls to PyBuffer_Release.
14412         Remove gotos and target of gotos.
14413         (infpy_search_memory): Likewise.
14414
14415 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
14416
14417         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
14418         (hppa_gdbarch_init): Don't register deleted functions with
14419         gdbarch.
14420
14421 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
14422
14423         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
14424         (h8300_unwind_sp): Delete.
14425         (h8300_dummy_id): Delete.
14426         (h8300_gdbarch_init): Don't register deleted functions with
14427         gdbarch.
14428
14429 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
14430
14431         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
14432         (ft32_unwind_pc): Delete.
14433         (ft32_unwind_sp): Delete.
14434         (ft32_gdbarch_init): Don't register deleted functions with
14435         gdbarch.
14436
14437 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
14438
14439         * gdb/frv-tdep.c (frv_dummy_id): Delete.
14440         (frv_unwind_pc): Delete.
14441         (frv_unwind_sp): Delete.
14442         (frv_gdbarch_init): Don't register deleted functions with
14443         gdbarch.
14444
14445 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
14446
14447         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
14448         (riscv_unwind_pc): Delete.
14449         (riscv_unwind_sp): Delete.
14450         (riscv_gdbarch_init): Don't register deleted functions with
14451         gdbarch.
14452
14453 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
14454
14455         * gdb/csky-tdep.c (csky_dummy_id): Delete.
14456         (csky_unwind_pc): Delete.
14457         (csky_unwind_sp): Delete.
14458         (csky_gdbarch_init): Don't register deleted functions with
14459         gdbarch.
14460
14461 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
14462
14463         * gdb/cris-tdep.c (cris_dummy_id): Delete.
14464         (cris_unwind_pc): Delete.
14465         (cris_unwind_sp): Delete.
14466         (cris_gdbarch_init): Don't register deleted functions with
14467         gdbarch.
14468
14469 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
14470
14471         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
14472         (bfin_unwind_pc): Delete.
14473         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
14474
14475 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
14476
14477         * gdb/arm-tdep.c (arm_dummy_id): Delete.
14478         (arm_unwind_pc): Delete.
14479         (arm_unwind_sp): Delete.
14480         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
14481
14482 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
14483
14484         * gdb/arc-tdep.c (arc_dummy_id): Delete.
14485         (arc_unwind_pc): Delete.
14486         (arc_unwind_sp): Delete.
14487         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
14488
14489 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
14490
14491         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
14492         (alpha_unwind_pc): Delete.
14493         (alpha_gdbarch_init): Don't register deleted functions with
14494         gdbarch.
14495
14496 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
14497
14498         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
14499         (aarch64_unwind_pc): Delete.
14500         (aarch64_unwind_sp): Delete.
14501         (aarch64_gdbarch_init): Don't register deleted functions with
14502         gdbarch.
14503
14504 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
14505
14506         * gdbtypes.c (type_align): Don't consider static members when
14507         computing structure alignment.
14508
14509 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
14510
14511         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
14512         return 0 for other types.
14513         * arch-utils.c (default_type_align): Always return 0.
14514         * gdbarch.h: Regenerate.
14515         * gdbarch.sh (type_align): Extend comment.
14516         * gdbtypes.c (type_align): Add additional comments, always call
14517         gdbarch_type_align before applying the default rules.
14518         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
14519         generic code will then apply a suitable default.
14520         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
14521         types, return 0 for other types.
14522
14523 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
14524
14525         * NEWS: Create a new section for the next release branch.
14526         Rename the section of the current branch, now that it has
14527         been cut.
14528
14529 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
14530
14531         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
14532         * version.in: Bump version to 8.3.50.DATE-git.
14533
14534 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
14535
14536         * aix-thread.c (ptid_cmp): Remove unused variable.
14537         (get_signaled_thread): Likewise.
14538         (store_regs_user_thread): Likewise.
14539         (store_regs_kernel_thread): Likewise.
14540         (fetch_regs_kernel_thread): Remove shadowed variable.
14541
14542 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
14543
14544         * features/riscv/32bit-cpu.xml: Add register numbers.
14545         * features/riscv/32bit-fpu.c: Regenerate.
14546         * features/riscv/32bit-fpu.xml: Add register numbers.
14547         * features/riscv/64bit-cpu.xml: Add register numbers.
14548         * features/riscv/64bit-fpu.c: Regenerate.
14549         * features/riscv/64bit-fpu.xml: Add register numbers.
14550
14551 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
14552
14553         * NEWS: Mention two argument form of gdb.Value constructor.
14554         * python/py-value.c (convert_buffer_and_type_to_value): New
14555         function.
14556         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
14557         Add support for handling an optional second argument.  Call
14558         convert_buffer_and_type_to_value as appropriate.
14559         * python/python-internal.h (Py_buffer_deleter): New struct.
14560         (Py_buffer_up): New typedef.
14561
14562 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
14563
14564         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
14565         instead of releasing ownership.
14566
14567 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
14568
14569         * dwarf2read.c (open_and_init_dwp_file): Call
14570         elf_numsections instead of bfd_count_sections to initialize
14571         dwp_file->num_sections.
14572
14573 2019-02-25  Tom Tromey  <tromey@adacore.com>
14574
14575         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
14576
14577 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
14578
14579         * gcore.in: Add '--readnever' option when invoking GDB.
14580
14581 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
14582
14583         * MAINTAINERS: Update my email address.
14584
14585 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
14586
14587         * build-id.c (build_id_to_debug_bfd_1): New function.
14588         (build_id_to_debug_bfd): Look for separate debug file in
14589         sysroot.
14590
14591 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
14592
14593         * gdbarch.sh: Update the copyright year range that is placed into
14594         generated files.
14595
14596 2019-02-22  Keith Seitz  <keiths@redhat.com>
14597
14598         PR symtab/23853
14599         * linespec.c (create_sals_line_offset): Search for the default
14600         symtab's filename instead of its fullname.
14601
14602 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
14603
14604         * NEWS: Update style defaults.
14605
14606 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
14607
14608         * main.c (captured_main_1): Disable styling in batch mode.
14609
14610 2019-02-20  Tom Tromey  <tom@tromey.com>
14611
14612         * symtab.c (symtab_symbol_info): Fix typos.
14613
14614 2019-02-20  Tom Tromey  <tromey@adacore.com>
14615
14616         * findcmd.c (_initialize_mem_search): Use upper case for
14617         metasyntactic variables.
14618
14619 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
14620
14621         * aarch64-tdep.c (aarch64_add_reggroups): New function.
14622         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
14623
14624 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
14625
14626         * top.h (source_file_name): Change to std::string.
14627         * top.c (source_file_name): Likewise.
14628         (command_line_input): Adjust.
14629         * cli/cli-script.c (script_from_file): Adjust.
14630
14631 2019-02-19  Tom Tromey  <tromey@adacore.com>
14632
14633         * ravenscar-thread.c
14634         (ravenscar_thread_target::update_thread_list): Don't call
14635         ada_build_task_list.
14636         * ada-lang.h (ada_build_task_list): Don't declare.
14637         * ada-tasks.c (struct ada_tasks_inferior_data)
14638         <task_list_valid_p>: Now bool.
14639         (read_known_tasks, ada_task_list_changed)
14640         (ada_tasks_invalidate_inferior_data): Update.
14641         (read_known_tasks_array): Return bool.
14642         (read_known_tasks_list): Likewise.
14643         (read_known_tasks): Return void.
14644         (ada_build_task_list): Now static.
14645
14646 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
14647
14648         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
14649         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
14650
14651 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
14652
14653         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
14654         variant for ada_tasks_pspace_data_handle and
14655         ada_tasks_inferior_data_handle.
14656         (ada_tasks_pspace_data_cleanup): New function.
14657         (ada_tasks_inferior_data_cleanup): New function.
14658
14659 2019-02-17  Tom Tromey  <tom@tromey.com>
14660
14661         * macrotab.h (macro_source_fullname): Return a std::string.
14662         * macrotab.c (macro_include, check_for_redefinition)
14663         (macro_undef, macro_lookup_definition, foreach_macro)
14664         (foreach_macro_in_scope): Update.
14665         (macro_source_fullname): Return a std::string.
14666         * macrocmd.c (show_pp_source_pos): Update.
14667
14668 2019-02-17  Tom Tromey  <tom@tromey.com>
14669
14670         * macrocmd.c (show_pp_source_pos): Style the file names.
14671
14672 2019-02-17  Tom Tromey  <tom@tromey.com>
14673
14674         PR tui/24197:
14675         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
14676
14677 2019-02-17  Tom Tromey  <tom@tromey.com>
14678
14679         * ada-lang.c (user_select_syms): Use filtered printing.
14680         * utils.c (wrap_style): New global.
14681         (desired_style): Remove.
14682         (emit_style_escape): Add stream parameter.
14683         (set_output_style, reset_terminal_style, prompt_for_continue):
14684         Update.
14685         (flush_wrap_buffer): Only flush gdb_stdout.
14686         (wrap_here): Set wrap_style.
14687         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
14688         treat escape sequences as a character.  Change when wrap buffer is
14689         flushed.
14690         (fputs_styled): Do not set the output style when the default is
14691         requested.
14692         * ui-style.h (struct ui_file_style) <is_default>: New method.
14693         * source.c (print_source_lines_base): Emit escape sequences in one
14694         piece.
14695
14696 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
14697
14698         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
14699         integers and enumeration types.
14700
14701 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
14702
14703         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
14704         instead of lookup_symbol_in_language
14705         (do_exact_match): New function.
14706         (ada_get_symbol_name_matcher): Return do_exact_match when
14707         doing a verbatim match.
14708
14709 2019-02-15  Tom Tromey  <tromey@adacore.com>
14710
14711         * ravenscar-thread.c (ravenscar_thread_target::resume)
14712         (ravenscar_thread_target::wait): Special case wildcard requests.
14713
14714 2019-02-15  Tom Tromey  <tromey@adacore.com>
14715
14716         * ravenscar-thread.c (base_ptid): Remove.
14717         (struct ravenscar_thread_target) <close>: New method.
14718         <m_base_ptid>: New member.
14719         <update_inferior_ptid, active_task, task_is_currently_active,
14720         runtime_initialized>: Declare methods.
14721         <ravenscar_thread_target>: Add constructor.
14722         (ravenscar_thread_target::task_is_currently_active)
14723         (ravenscar_thread_target::update_inferior_ptid)
14724         (ravenscar_runtime_initialized): Rename.  Now methods.
14725         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
14726         (ravenscar_thread_target::update_thread_list): Update.
14727         (ravenscar_thread_target::active_task): Now method.
14728         (ravenscar_thread_target::store_registers)
14729         (ravenscar_thread_target::prepare_to_store)
14730         (ravenscar_thread_target::prepare_to_store)
14731         (ravenscar_thread_target::mourn_inferior): Update.
14732         (ravenscar_inferior_created): Use "new" to create target.
14733         (ravenscar_thread_target::get_ada_task_ptid): Update.
14734         (_initialize_ravenscar): Don't initialize base_ptid.
14735         (ravenscar_ops): Remove global.
14736
14737 2019-02-15  Tom Tromey  <tromey@adacore.com>
14738
14739         * target.h (push_target): Declare new overload.
14740         * target.c (push_target): New overload, taking an rvalue reference.
14741         * remote.c (remote_target::open_1): Use push_target overload.
14742         * corelow.c (core_target_open): Use push_target overload.
14743
14744 2019-02-15  Tom Tromey  <tromey@adacore.com>
14745
14746         * ravenscar-thread.c (is_ravenscar_task)
14747         (ravenscar_task_is_currently_active): Return bool.
14748         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
14749         (_initialize_ravenscar): Remove "(void)".
14750         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
14751         Return bool.
14752
14753 2019-02-15  Tom Tromey  <tromey@adacore.com>
14754
14755         * ravenscar-thread.c (ravenscar_runtime_initializer)
14756         (has_ravenscar_runtime, get_running_thread_id)
14757         (ravenscar_thread_target::resume): Fix indentation.
14758
14759 2019-02-15  Tom Tromey  <tromey@adacore.com>
14760
14761         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
14762         from ravenscar_arch_ops.
14763         (sparc_ravenscar_ops::fetch_registers)
14764         (sparc_ravenscar_ops::store_registers): Now methods.
14765         (sparc_ravenscar_prepare_to_store): Remove.
14766         (sparc_ravenscar_ops): Redefine.
14767         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
14768         methods and destructor.  Remove members.
14769         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
14770         (ravenscar_thread_target::store_registers)
14771         (ravenscar_thread_target::prepare_to_store): Update.
14772         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
14773         Remove.
14774         (struct ppc_ravenscar_powerpc_ops): Derive from
14775         ravenscar_arch_ops.
14776         (ppc_ravenscar_powerpc_ops::fetch_registers)
14777         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
14778         (ppc_ravenscar_powerpc_ops): Redefine.
14779         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
14780         (ppc_ravenscar_e500_ops::fetch_registers)
14781         (ppc_ravenscar_e500_ops::store_registers): Now methods.
14782         (ppc_ravenscar_e500_ops): Redefine.
14783         * aarch64-ravenscar-thread.c
14784         (aarch64_ravenscar_generic_prepare_to_store): Remove.
14785         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
14786         (aarch64_ravenscar_fetch_registers)
14787         (aarch64_ravenscar_store_registers): Now methods.
14788         (aarch64_ravenscar_ops): Redefine.
14789
14790 2019-02-15  Tom Tromey  <tromey@adacore.com>
14791
14792         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
14793         (ravenscar_thread_target::stopped_by_hw_breakpoint)
14794         (ravenscar_thread_target::stopped_by_watchpoint)
14795         (ravenscar_thread_target::stopped_data_address)
14796         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
14797
14798 2019-02-15  Tom Tromey  <tromey@adacore.com>
14799
14800         * ravenscar-thread.c: Fix some typos.
14801
14802 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
14803             Tom Tromey  <tromey@adacore.com>
14804
14805         * ada-lang.c (ada_exception_sal): Change addr_string to a
14806         std::string.
14807         (create_ada_exception_catchpoint): Update.
14808
14809 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
14810             Tom Tromey  <tromey@adacore.com>
14811
14812         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
14813         (bp_location_ops): Remove.
14814         (base_breakpoint_allocate_location): Update.
14815         (free_bp_location): Update.
14816         * ada-lang.c (class ada_catchpoint_location)
14817         <ada_catchpoint_location>: Remove ops parameter.
14818         (ada_catchpoint_location_dtor): Remove.
14819         (ada_catchpoint_location_ops): Remove.
14820         (allocate_location_exception): Update.
14821         * breakpoint.h (struct bp_location_ops): Remove.
14822         (class bp_location) <bp_location>: Remove bp_location_ops
14823         parameter.
14824         <~bp_location>: Add destructor.
14825         <ops>: Remove.
14826
14827 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
14828             Pedro Alves  <palves@redhat.com>
14829
14830         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
14831         'PATH_MAX'.
14832
14833 2019-02-14  David Michael  <fedora.dm0@gmail.com>
14834             Samuel Thibault  <samuel.thibault@gnu.org>
14835             Thomas Schwinge  <thomas@codesourcery.com>
14836
14837         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
14838         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
14839
14840 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
14841
14842         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
14843         (check_empty): Use "const char *".
14844
14845         * gnu-nat.c (gnu_nat_target::detach): Instead of
14846         'detach_inferior (pid)' call
14847         'detach_inferior (find_inferior_pid (pid))'.
14848
14849         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
14850         'nat/fork-inferior.o'.
14851         * gnu-nat.c: #include "nat/fork-inferior.h".
14852
14853         * gnu-nat.c (gnu_nat_target::detach): Instead of
14854         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
14855         * gnu-nat.h: #include "inf-child.h".
14856         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
14857         'i386_gnu_nat_target::fetch_registers'.
14858         (gnu_store_registers): Rename/move to
14859         'i386_gnu_nat_target::store_registers'.
14860
14861         * config/i386/nm-i386gnu.h: Don't "#include" any files.
14862         * gnu-nat.h (mach_thread_info): New function.
14863         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
14864
14865         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
14866
14867 2019-02-14  Frederic Konrad  <konrad@adacore.com>
14868
14869         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
14870
14871 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
14872
14873         * windows-nat.c (windows_add_thread): Add new parameter
14874         "main_thread_p" with default value set to false.  Update
14875         function documentation as well as all callers.
14876         (windows_delete_thread): Likewise.
14877         (fake_create_process): Update call to windows_add_thread.
14878         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
14879         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
14880         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
14881         call to windows_delete_thread.
14882
14883 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
14884
14885         * MAINTAINERS: Add Andrew Burgess as global maintainer.
14886
14887 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
14888
14889         * symfile.c (find_separate_debug_file): Use canonical path of
14890         sysroot with child_path instead of gdb_sysroot if it is valid.
14891
14892 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
14893
14894         * symfile.c (find_separate_debug_file): Use child_path to
14895         determine if an object file is under a sysroot.
14896
14897 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
14898
14899         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
14900         unittests/child-path-selftests.c.
14901         * common/pathstuff.c (child_path): New function.
14902         * common/pathstuff.h (child_path): New prototype.
14903         * unittests/child-path-selftests.c: New file.
14904
14905 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
14906
14907         * symfile.c (find_separate_debug_file): Look for separate debug
14908         files in debug directories under the sysroot.
14909
14910 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
14911
14912         * symtab.h (struct minimal_symbol data_p): New const method.
14913         (struct minimal_symbol text_p): Likewise.
14914         * symtab.c (output_source_filename): Use file name style
14915         to print file name.
14916         (print_symbol_info): Likewise.
14917         (print_msymbol_info): Use address style to print addresses.
14918         Use function name style to print executable text symbols.
14919         (expand_symtab_containing_pc): Use data_p.
14920         (find_pc_sect_compunit_symtab): Likewise.
14921
14922 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
14923
14924         * breakpoint.c (describe_other_breakpoints): Use address style
14925         to print addresses.
14926         (say_where): Likewise.
14927
14928 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
14929
14930         * ada-typeprint.c (print_func_type): Print function name
14931         style to print function name.
14932         * c-typeprint.c (c_print_type_1): Likewise.
14933
14934 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
14935
14936         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
14937         for execve.
14938
14939 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
14940
14941         * c-exp.y (direct_abs_decl): Use emplace_back to record the
14942         type_stack.
14943
14944 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
14945
14946         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
14947         TYPE_CODE_REF types.
14948
14949 2019-02-08  Jim Wilson  <jimw@sifive.com>
14950
14951         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
14952         (riscv_linux_fregset): New.
14953         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
14954
14955 2019-02-07  Tom Tromey  <tom@tromey.com>
14956
14957         * thread.c (thread_cancel_execution_command): Update.
14958         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
14959         methods.
14960         (struct thread_fsm_ops): Remove.
14961         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
14962         (thread_fsm_should_stop, thread_fsm_return_value)
14963         (thread_fsm_set_finished, thread_fsm_finished_p)
14964         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
14965         Don't declare.
14966         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
14967         * infrun.c (clear_proceed_status_thread)
14968         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
14969         (print_stop_event): Update.
14970         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
14971         Add constructor.
14972         (step_command_fsm_ops): Remove.
14973         (new_step_command_fsm): Remove.
14974         (step_1): Update.
14975         (step_command_fsm::should_stop): Rename from
14976         step_command_fsm_should_stop.
14977         (step_command_fsm::clean_up): Rename from
14978         step_command_fsm_clean_up.
14979         (step_command_fsm::do_async_reply_reason): Rename from
14980         step_command_fsm_async_reply_reason.
14981         (struct until_next_fsm): Inherit from thread_fsm.  Add
14982         constructor.
14983         (until_next_fsm_ops): Remove.
14984         (new_until_next_fsm): Remove.
14985         (until_next_fsm::should_stop): Rename from
14986         until_next_fsm_should_stop.
14987         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
14988         (until_next_fsm::do_async_reply_reason): Rename from
14989         until_next_fsm_async_reply_reason.
14990         (struct finish_command_fsm): Inherit from thread_fsm.  Add
14991         constructor.  Change type of breakpoint.
14992         (finish_command_fsm_ops): Remove.
14993         (new_finish_command_fsm): Remove.
14994         (finish_command_fsm::should_stop): Rename from
14995         finish_command_fsm_should_stop.
14996         (finish_command_fsm::clean_up): Rename from
14997         finish_command_fsm_clean_up.
14998         (finish_command_fsm::return_value): Rename from
14999         finish_command_fsm_return_value.
15000         (finish_command_fsm::do_async_reply_reason): Rename from
15001         finish_command_fsm_async_reply_reason.
15002         (finish_command): Update.
15003         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
15004         Add constructor.
15005         (call_thread_fsm_ops): Remove.
15006         (call_thread_fsm::call_thread_fsm): Rename from
15007         new_call_thread_fsm.
15008         (call_thread_fsm::should_stop): Rename from
15009         call_thread_fsm_should_stop.
15010         (call_thread_fsm::should_notify_stop): Rename from
15011         call_thread_fsm_should_notify_stop.
15012         (run_inferior_call, call_function_by_hand_dummy): Update.
15013         * cli/cli-interp.c (should_print_stop_to_console): Update.
15014         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
15015         Add constructor.  Change type of location_breakpoint,
15016         caller_breakpoint.
15017         (until_break_fsm_ops): Remove.
15018         (new_until_break_fsm): Remove.
15019         (until_break_fsm::should_stop): Rename from
15020         until_break_fsm_should_stop.
15021         (until_break_fsm::clean_up): Rename from
15022         until_break_fsm_clean_up.
15023         (until_break_fsm::do_async_reply_reason): Rename from
15024         until_break_fsm_async_reply_reason.
15025         (until_break_command): Update.
15026         * thread-fsm.c: Remove.
15027         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
15028
15029 2019-02-07  Tom Tromey  <tom@tromey.com>
15030
15031         * yy-remap.h: Add include guard.
15032         * xtensa-tdep.h: Add include guard.
15033         * xcoffread.h: Rename include guard.
15034         * varobj-iter.h: Add include guard.
15035         * tui/tui.h: Rename include guard.
15036         * tui/tui-winsource.h: Rename include guard.
15037         * tui/tui-wingeneral.h: Rename include guard.
15038         * tui/tui-windata.h: Rename include guard.
15039         * tui/tui-win.h: Rename include guard.
15040         * tui/tui-stack.h: Rename include guard.
15041         * tui/tui-source.h: Rename include guard.
15042         * tui/tui-regs.h: Rename include guard.
15043         * tui/tui-out.h: Rename include guard.
15044         * tui/tui-layout.h: Rename include guard.
15045         * tui/tui-io.h: Rename include guard.
15046         * tui/tui-hooks.h: Rename include guard.
15047         * tui/tui-file.h: Rename include guard.
15048         * tui/tui-disasm.h: Rename include guard.
15049         * tui/tui-data.h: Rename include guard.
15050         * tui/tui-command.h: Rename include guard.
15051         * tic6x-tdep.h: Add include guard.
15052         * target/waitstatus.h: Rename include guard.
15053         * target/wait.h: Rename include guard.
15054         * target/target.h: Rename include guard.
15055         * target/resume.h: Rename include guard.
15056         * target-float.h: Rename include guard.
15057         * stabsread.h: Add include guard.
15058         * rs6000-tdep.h: Add include guard.
15059         * riscv-fbsd-tdep.h: Add include guard.
15060         * regformats/regdef.h: Rename include guard.
15061         * record.h: Rename include guard.
15062         * python/python.h: Rename include guard.
15063         * python/python-internal.h: Rename include guard.
15064         * python/py-stopevent.h: Rename include guard.
15065         * python/py-ref.h: Rename include guard.
15066         * python/py-record.h: Rename include guard.
15067         * python/py-record-full.h: Rename include guard.
15068         * python/py-record-btrace.h: Rename include guard.
15069         * python/py-instruction.h: Rename include guard.
15070         * python/py-events.h: Rename include guard.
15071         * python/py-event.h: Rename include guard.
15072         * procfs.h: Add include guard.
15073         * proc-utils.h: Add include guard.
15074         * p-lang.h: Add include guard.
15075         * or1k-tdep.h: Rename include guard.
15076         * observable.h: Rename include guard.
15077         * nto-tdep.h: Rename include guard.
15078         * nat/x86-linux.h: Rename include guard.
15079         * nat/x86-linux-dregs.h: Rename include guard.
15080         * nat/x86-gcc-cpuid.h: Add include guard.
15081         * nat/x86-dregs.h: Rename include guard.
15082         * nat/x86-cpuid.h: Rename include guard.
15083         * nat/ppc-linux.h: Rename include guard.
15084         * nat/mips-linux-watch.h: Rename include guard.
15085         * nat/linux-waitpid.h: Rename include guard.
15086         * nat/linux-ptrace.h: Rename include guard.
15087         * nat/linux-procfs.h: Rename include guard.
15088         * nat/linux-osdata.h: Rename include guard.
15089         * nat/linux-nat.h: Rename include guard.
15090         * nat/linux-namespaces.h: Rename include guard.
15091         * nat/linux-btrace.h: Rename include guard.
15092         * nat/glibc_thread_db.h: Rename include guard.
15093         * nat/gdb_thread_db.h: Rename include guard.
15094         * nat/gdb_ptrace.h: Rename include guard.
15095         * nat/fork-inferior.h: Rename include guard.
15096         * nat/amd64-linux-siginfo.h: Rename include guard.
15097         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
15098         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
15099         * nat/aarch64-linux.h: Rename include guard.
15100         * nat/aarch64-linux-hw-point.h: Rename include guard.
15101         * mn10300-tdep.h: Add include guard.
15102         * mips-linux-tdep.h: Add include guard.
15103         * mi/mi-parse.h: Rename include guard.
15104         * mi/mi-out.h: Rename include guard.
15105         * mi/mi-main.h: Rename include guard.
15106         * mi/mi-interp.h: Rename include guard.
15107         * mi/mi-getopt.h: Rename include guard.
15108         * mi/mi-console.h: Rename include guard.
15109         * mi/mi-common.h: Rename include guard.
15110         * mi/mi-cmds.h: Rename include guard.
15111         * mi/mi-cmd-break.h: Rename include guard.
15112         * m2-lang.h: Add include guard.
15113         * location.h: Rename include guard.
15114         * linux-record.h: Rename include guard.
15115         * linux-nat.h: Add include guard.
15116         * linux-fork.h: Add include guard.
15117         * i386-darwin-tdep.h: Rename include guard.
15118         * hppa-linux-offsets.h: Add include guard.
15119         * guile/guile.h: Rename include guard.
15120         * guile/guile-internal.h: Rename include guard.
15121         * gnu-nat.h: Rename include guard.
15122         * gdb-stabs.h: Rename include guard.
15123         * frv-tdep.h: Add include guard.
15124         * f-lang.h: Add include guard.
15125         * event-loop.h: Add include guard.
15126         * darwin-nat.h: Rename include guard.
15127         * cp-abi.h: Rename include guard.
15128         * config/sparc/nm-sol2.h: Rename include guard.
15129         * config/nm-nto.h: Rename include guard.
15130         * config/nm-linux.h: Add include guard.
15131         * config/i386/nm-i386gnu.h: Rename include guard.
15132         * config/djgpp/nl_types.h: Rename include guard.
15133         * config/djgpp/langinfo.h: Rename include guard.
15134         * compile/gcc-cp-plugin.h: Add include guard.
15135         * compile/gcc-c-plugin.h: Add include guard.
15136         * compile/compile.h: Rename include guard.
15137         * compile/compile-object-run.h: Rename include guard.
15138         * compile/compile-object-load.h: Rename include guard.
15139         * compile/compile-internal.h: Rename include guard.
15140         * compile/compile-cplus.h: Rename include guard.
15141         * compile/compile-c.h: Rename include guard.
15142         * common/xml-utils.h: Rename include guard.
15143         * common/x86-xstate.h: Rename include guard.
15144         * common/version.h: Rename include guard.
15145         * common/vec.h: Rename include guard.
15146         * common/tdesc.h: Rename include guard.
15147         * common/selftest.h: Rename include guard.
15148         * common/scoped_restore.h: Rename include guard.
15149         * common/scoped_mmap.h: Rename include guard.
15150         * common/scoped_fd.h: Rename include guard.
15151         * common/safe-iterator.h: Rename include guard.
15152         * common/run-time-clock.h: Rename include guard.
15153         * common/refcounted-object.h: Rename include guard.
15154         * common/queue.h: Rename include guard.
15155         * common/ptid.h: Rename include guard.
15156         * common/print-utils.h: Rename include guard.
15157         * common/preprocessor.h: Rename include guard.
15158         * common/pathstuff.h: Rename include guard.
15159         * common/observable.h: Rename include guard.
15160         * common/netstuff.h: Rename include guard.
15161         * common/job-control.h: Rename include guard.
15162         * common/host-defs.h: Rename include guard.
15163         * common/gdb_wait.h: Rename include guard.
15164         * common/gdb_vecs.h: Rename include guard.
15165         * common/gdb_unlinker.h: Rename include guard.
15166         * common/gdb_unique_ptr.h: Rename include guard.
15167         * common/gdb_tilde_expand.h: Rename include guard.
15168         * common/gdb_sys_time.h: Rename include guard.
15169         * common/gdb_string_view.h: Rename include guard.
15170         * common/gdb_splay_tree.h: Rename include guard.
15171         * common/gdb_setjmp.h: Rename include guard.
15172         * common/gdb_ref_ptr.h: Rename include guard.
15173         * common/gdb_optional.h: Rename include guard.
15174         * common/gdb_locale.h: Rename include guard.
15175         * common/gdb_assert.h: Rename include guard.
15176         * common/filtered-iterator.h: Rename include guard.
15177         * common/filestuff.h: Rename include guard.
15178         * common/fileio.h: Rename include guard.
15179         * common/environ.h: Rename include guard.
15180         * common/common-utils.h: Rename include guard.
15181         * common/common-types.h: Rename include guard.
15182         * common/common-regcache.h: Rename include guard.
15183         * common/common-inferior.h: Rename include guard.
15184         * common/common-gdbthread.h: Rename include guard.
15185         * common/common-exceptions.h: Rename include guard.
15186         * common/common-defs.h: Rename include guard.
15187         * common/common-debug.h: Rename include guard.
15188         * common/cleanups.h: Rename include guard.
15189         * common/buffer.h: Rename include guard.
15190         * common/btrace-common.h: Rename include guard.
15191         * common/break-common.h: Rename include guard.
15192         * cli/cli-utils.h: Rename include guard.
15193         * cli/cli-style.h: Rename include guard.
15194         * cli/cli-setshow.h: Rename include guard.
15195         * cli/cli-script.h: Rename include guard.
15196         * cli/cli-interp.h: Rename include guard.
15197         * cli/cli-decode.h: Rename include guard.
15198         * cli/cli-cmds.h: Rename include guard.
15199         * charset-list.h: Add include guard.
15200         * buildsym-legacy.h: Rename include guard.
15201         * bfin-tdep.h: Add include guard.
15202         * ax.h: Rename include guard.
15203         * arm-linux-tdep.h: Add include guard.
15204         * arm-fbsd-tdep.h: Add include guard.
15205         * arch/xtensa.h: Rename include guard.
15206         * arch/tic6x.h: Add include guard.
15207         * arch/i386.h: Add include guard.
15208         * arch/arm.h: Rename include guard.
15209         * arch/arm-linux.h: Rename include guard.
15210         * arch/arm-get-next-pcs.h: Rename include guard.
15211         * arch/amd64.h: Add include guard.
15212         * arch/aarch64-insn.h: Rename include guard.
15213         * arch-utils.h: Rename include guard.
15214         * annotate.h: Add include guard.
15215         * amd64-darwin-tdep.h: Rename include guard.
15216         * aarch64-linux-tdep.h: Add include guard.
15217         * aarch64-fbsd-tdep.h: Add include guard.
15218         * aarch32-linux-nat.h: Add include guard.
15219
15220 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
15221
15222         * macrotab.c (macro_define_internal): New function that
15223         factorizes macro_define_object_internal and macro_define_function
15224         code.
15225         (macro_define_object_internal): Use macro_define_internal.
15226         (macro_define_function): Likewise.
15227
15228 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
15229
15230         * macrocmd.c (extract_identifier): Return
15231         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
15232         callers.
15233
15234 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
15235
15236         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
15237
15238 2019-02-05  Tom Tromey  <tom@tromey.com>
15239
15240         * target.c (target_stack::unpush): Move assertion earlier.
15241
15242 2019-01-30  Tom Tromey  <tom@tromey.com>
15243
15244         PR python/23615:
15245         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
15246         (gdbpy_parse_and_eval): Likewise.
15247         * python/python-internal.h (gdbpy_allow_threads): New class.
15248
15249 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
15250
15251         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
15252         (aarch64_fbsd_fpregmap): Move earlier.
15253         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
15254         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
15255         instead of individual calls to trad_frame_set_reg_addr.
15256         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
15257         earlier.
15258         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
15259         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
15260         instead of individual calls to trad_frame_set_reg_addr.
15261
15262 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
15263
15264         * CONTRIBUTE: Replace contribution list with wiki link.
15265
15266 2019-01-25  Tom Tromey  <tom@tromey.com>
15267
15268         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
15269
15270 2019-01-25  Tom Tromey  <tom@tromey.com>
15271
15272         * xtensa-linux-nat.c: Fix common/ includes.
15273         * xml-support.h: Fix common/ includes.
15274         * xml-support.c: Fix common/ includes.
15275         * x86-linux-nat.c: Fix common/ includes.
15276         * windows-nat.c: Fix common/ includes.
15277         * varobj.h: Fix common/ includes.
15278         * varobj.c: Fix common/ includes.
15279         * value.c: Fix common/ includes.
15280         * valops.c: Fix common/ includes.
15281         * utils.c: Fix common/ includes.
15282         * unittests/xml-utils-selftests.c: Fix common/ includes.
15283         * unittests/utils-selftests.c: Fix common/ includes.
15284         * unittests/unpack-selftests.c: Fix common/ includes.
15285         * unittests/tracepoint-selftests.c: Fix common/ includes.
15286         * unittests/style-selftests.c: Fix common/ includes.
15287         * unittests/string_view-selftests.c: Fix common/ includes.
15288         * unittests/scoped_restore-selftests.c: Fix common/ includes.
15289         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
15290         * unittests/scoped_fd-selftests.c: Fix common/ includes.
15291         * unittests/rsp-low-selftests.c: Fix common/ includes.
15292         * unittests/parse-connection-spec-selftests.c: Fix common/
15293         includes.
15294         * unittests/optional-selftests.c: Fix common/ includes.
15295         * unittests/offset-type-selftests.c: Fix common/ includes.
15296         * unittests/observable-selftests.c: Fix common/ includes.
15297         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
15298         * unittests/memrange-selftests.c: Fix common/ includes.
15299         * unittests/memory-map-selftests.c: Fix common/ includes.
15300         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
15301         * unittests/function-view-selftests.c: Fix common/ includes.
15302         * unittests/environ-selftests.c: Fix common/ includes.
15303         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
15304         * unittests/common-utils-selftests.c: Fix common/ includes.
15305         * unittests/cli-utils-selftests.c: Fix common/ includes.
15306         * unittests/array-view-selftests.c: Fix common/ includes.
15307         * ui-file.c: Fix common/ includes.
15308         * tui/tui-io.c: Fix common/ includes.
15309         * tracepoint.h: Fix common/ includes.
15310         * tracepoint.c: Fix common/ includes.
15311         * tracefile-tfile.c: Fix common/ includes.
15312         * top.h: Fix common/ includes.
15313         * top.c: Fix common/ includes.
15314         * thread.c: Fix common/ includes.
15315         * target/waitstatus.h: Fix common/ includes.
15316         * target/waitstatus.c: Fix common/ includes.
15317         * target.h: Fix common/ includes.
15318         * target.c: Fix common/ includes.
15319         * target-memory.c: Fix common/ includes.
15320         * target-descriptions.c: Fix common/ includes.
15321         * symtab.h: Fix common/ includes.
15322         * symfile.c: Fix common/ includes.
15323         * stap-probe.c: Fix common/ includes.
15324         * spu-linux-nat.c: Fix common/ includes.
15325         * sparc-nat.c: Fix common/ includes.
15326         * source.c: Fix common/ includes.
15327         * solib.c: Fix common/ includes.
15328         * solib-target.c: Fix common/ includes.
15329         * ser-unix.c: Fix common/ includes.
15330         * ser-tcp.c: Fix common/ includes.
15331         * ser-pipe.c: Fix common/ includes.
15332         * ser-base.c: Fix common/ includes.
15333         * selftest-arch.c: Fix common/ includes.
15334         * s12z-tdep.c: Fix common/ includes.
15335         * rust-exp.y: Fix common/ includes.
15336         * rs6000-aix-tdep.c: Fix common/ includes.
15337         * riscv-tdep.c: Fix common/ includes.
15338         * remote.c: Fix common/ includes.
15339         * remote-notif.h: Fix common/ includes.
15340         * remote-fileio.h: Fix common/ includes.
15341         * remote-fileio.c: Fix common/ includes.
15342         * regcache.h: Fix common/ includes.
15343         * regcache.c: Fix common/ includes.
15344         * record-btrace.c: Fix common/ includes.
15345         * python/python.c: Fix common/ includes.
15346         * python/py-type.c: Fix common/ includes.
15347         * python/py-inferior.c: Fix common/ includes.
15348         * progspace.h: Fix common/ includes.
15349         * producer.c: Fix common/ includes.
15350         * procfs.c: Fix common/ includes.
15351         * proc-api.c: Fix common/ includes.
15352         * printcmd.c: Fix common/ includes.
15353         * ppc-linux-nat.c: Fix common/ includes.
15354         * parser-defs.h: Fix common/ includes.
15355         * osdata.c: Fix common/ includes.
15356         * obsd-nat.c: Fix common/ includes.
15357         * nat/x86-linux.c: Fix common/ includes.
15358         * nat/x86-linux-dregs.c: Fix common/ includes.
15359         * nat/x86-dregs.h: Fix common/ includes.
15360         * nat/x86-dregs.c: Fix common/ includes.
15361         * nat/ppc-linux.c: Fix common/ includes.
15362         * nat/mips-linux-watch.h: Fix common/ includes.
15363         * nat/mips-linux-watch.c: Fix common/ includes.
15364         * nat/linux-waitpid.c: Fix common/ includes.
15365         * nat/linux-ptrace.h: Fix common/ includes.
15366         * nat/linux-ptrace.c: Fix common/ includes.
15367         * nat/linux-procfs.c: Fix common/ includes.
15368         * nat/linux-personality.c: Fix common/ includes.
15369         * nat/linux-osdata.c: Fix common/ includes.
15370         * nat/linux-namespaces.c: Fix common/ includes.
15371         * nat/linux-btrace.h: Fix common/ includes.
15372         * nat/linux-btrace.c: Fix common/ includes.
15373         * nat/fork-inferior.c: Fix common/ includes.
15374         * nat/amd64-linux-siginfo.c: Fix common/ includes.
15375         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
15376         * nat/aarch64-linux.c: Fix common/ includes.
15377         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
15378         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
15379         * namespace.h: Fix common/ includes.
15380         * mips-linux-tdep.c: Fix common/ includes.
15381         * minsyms.c: Fix common/ includes.
15382         * mi/mi-parse.h: Fix common/ includes.
15383         * mi/mi-main.c: Fix common/ includes.
15384         * mi/mi-cmd-env.c: Fix common/ includes.
15385         * memrange.h: Fix common/ includes.
15386         * memattr.c: Fix common/ includes.
15387         * maint.h: Fix common/ includes.
15388         * maint.c: Fix common/ includes.
15389         * main.c: Fix common/ includes.
15390         * machoread.c: Fix common/ includes.
15391         * location.c: Fix common/ includes.
15392         * linux-thread-db.c: Fix common/ includes.
15393         * linux-nat.c: Fix common/ includes.
15394         * linux-fork.c: Fix common/ includes.
15395         * inline-frame.c: Fix common/ includes.
15396         * infrun.c: Fix common/ includes.
15397         * inflow.c: Fix common/ includes.
15398         * inferior.h: Fix common/ includes.
15399         * inferior.c: Fix common/ includes.
15400         * infcmd.c: Fix common/ includes.
15401         * inf-ptrace.c: Fix common/ includes.
15402         * inf-child.c: Fix common/ includes.
15403         * ia64-linux-nat.c: Fix common/ includes.
15404         * i387-tdep.c: Fix common/ includes.
15405         * i386-tdep.c: Fix common/ includes.
15406         * i386-linux-tdep.c: Fix common/ includes.
15407         * i386-linux-nat.c: Fix common/ includes.
15408         * i386-go32-tdep.c: Fix common/ includes.
15409         * i386-fbsd-tdep.c: Fix common/ includes.
15410         * i386-fbsd-nat.c: Fix common/ includes.
15411         * guile/scm-type.c: Fix common/ includes.
15412         * guile/guile.c: Fix common/ includes.
15413         * go32-nat.c: Fix common/ includes.
15414         * gnu-nat.c: Fix common/ includes.
15415         * gdbthread.h: Fix common/ includes.
15416         * gdbarch-selftests.c: Fix common/ includes.
15417         * gdb_usleep.c: Fix common/ includes.
15418         * gdb_select.h: Fix common/ includes.
15419         * gdb_bfd.c: Fix common/ includes.
15420         * gcore.c: Fix common/ includes.
15421         * fork-child.c: Fix common/ includes.
15422         * findvar.c: Fix common/ includes.
15423         * fbsd-nat.c: Fix common/ includes.
15424         * event-top.c: Fix common/ includes.
15425         * event-loop.c: Fix common/ includes.
15426         * dwarf2read.c: Fix common/ includes.
15427         * dwarf2loc.c: Fix common/ includes.
15428         * dwarf2-frame.c: Fix common/ includes.
15429         * dwarf-index-cache.c: Fix common/ includes.
15430         * dtrace-probe.c: Fix common/ includes.
15431         * disasm-selftests.c: Fix common/ includes.
15432         * defs.h: Fix common/ includes.
15433         * csky-tdep.c: Fix common/ includes.
15434         * cp-valprint.c: Fix common/ includes.
15435         * cp-support.h: Fix common/ includes.
15436         * cp-support.c: Fix common/ includes.
15437         * corelow.c: Fix common/ includes.
15438         * completer.h: Fix common/ includes.
15439         * completer.c: Fix common/ includes.
15440         * compile/compile.c: Fix common/ includes.
15441         * compile/compile-loc2c.c: Fix common/ includes.
15442         * compile/compile-cplus-types.c: Fix common/ includes.
15443         * compile/compile-cplus-symbols.c: Fix common/ includes.
15444         * command.h: Fix common/ includes.
15445         * cli/cli-dump.c: Fix common/ includes.
15446         * cli/cli-cmds.c: Fix common/ includes.
15447         * charset.c: Fix common/ includes.
15448         * build-id.c: Fix common/ includes.
15449         * btrace.h: Fix common/ includes.
15450         * btrace.c: Fix common/ includes.
15451         * breakpoint.h: Fix common/ includes.
15452         * breakpoint.c: Fix common/ includes.
15453         * ax.h:
15454         (enum agent_op): Fix common/ includes.
15455         * ax-general.c (struct aop_map): Fix common/ includes.
15456         * ax-gdb.c: Fix common/ includes.
15457         * auxv.c: Fix common/ includes.
15458         * auto-load.c: Fix common/ includes.
15459         * arm-tdep.c: Fix common/ includes.
15460         * arch/riscv.c: Fix common/ includes.
15461         * arch/ppc-linux-common.c: Fix common/ includes.
15462         * arch/i386.c: Fix common/ includes.
15463         * arch/arm.c: Fix common/ includes.
15464         * arch/arm-linux.c: Fix common/ includes.
15465         * arch/arm-get-next-pcs.c: Fix common/ includes.
15466         * arch/amd64.c: Fix common/ includes.
15467         * arch/aarch64.c: Fix common/ includes.
15468         * arch/aarch64-insn.c: Fix common/ includes.
15469         * arch-utils.c: Fix common/ includes.
15470         * amd64-windows-tdep.c: Fix common/ includes.
15471         * amd64-tdep.c: Fix common/ includes.
15472         * amd64-sol2-tdep.c: Fix common/ includes.
15473         * amd64-obsd-tdep.c: Fix common/ includes.
15474         * amd64-nbsd-tdep.c: Fix common/ includes.
15475         * amd64-linux-tdep.c: Fix common/ includes.
15476         * amd64-linux-nat.c: Fix common/ includes.
15477         * amd64-fbsd-tdep.c: Fix common/ includes.
15478         * amd64-fbsd-nat.c: Fix common/ includes.
15479         * amd64-dicos-tdep.c: Fix common/ includes.
15480         * amd64-darwin-tdep.c: Fix common/ includes.
15481         * agent.c: Fix common/ includes.
15482         * ada-lang.h: Fix common/ includes.
15483         * ada-lang.c: Fix common/ includes.
15484         * aarch64-tdep.c: Fix common/ includes.
15485
15486 2019-01-25  Tom Tromey  <tom@tromey.com>
15487
15488         * common/create-version.sh: Use common/version.h.
15489
15490 2019-01-24  Pedro Alves  <palves@redhat.com>
15491
15492         * infrun.c (signal_stop, signal_print, signal_program)
15493         (signal_catch, signal_pass): Now arrays instead of pointers.
15494         (update_signals_program_target, do_target_resume)
15495         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
15496         * linux-nat.c (linux_nat_target::pass_signals)
15497         (linux_nat_target::create_inferior, linux_nat_target::attach):
15498         Adjust.
15499         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
15500         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
15501         * procfs.c (procfs_target::pass_signals): Adjust.
15502         * record-full.c (record_full_target::resume): Adjust.
15503         * remote.c (remote_target::pass_signals)
15504         (remote_target::program_signals): Adjust.
15505         * target-debug.h (target_debug_print_signals): Now takes a
15506         gdb::array_view as parameter.  Adjust.
15507         * target.h (target_ops) <pass_signals, program_signals>: Replace
15508         pointer and length parameters with gdb::array_view.
15509         (target_pass_signals, target_program_signals): Likewise.
15510         * target-delegates.c: Regenerate.
15511
15512 2019-01-24  Pedro Alves  <palves@redhat.com>
15513
15514         * common/forward-scope-exit.h
15515         (forward_scope_exit::forward_scope_exit): Pass arguments to
15516         m_bind_function directly, instead of creating a std::bind and
15517         copying that.
15518
15519 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
15520
15521         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
15522         for static members.
15523         (pass_in_v_vfp_candidate): Likewise.
15524
15525 2019-01-23  Tom Tromey  <tom@tromey.com>
15526             Pedro Alves  <palves@redhat.com>
15527
15528         * regcache.c (class regcache_invalidator): Remove.
15529         (regcache::raw_write): Use make_scope_exit.
15530
15531 2019-01-23  Tom Tromey  <tom@tromey.com>
15532
15533         * ui-out.h (class ui_out_emit_type): Update comment.
15534
15535 2019-01-23  Tom Tromey  <tom@tromey.com>
15536
15537         * infrun.c (fetch_inferior_event): Update comment.
15538
15539 2019-01-23  Tom Tromey  <tom@tromey.com>
15540             Pedro Alves  <palves@redhat.com>
15541
15542         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
15543         parameter.
15544         (fetch_inferior_event): Use SCOPE_EXIT.
15545
15546
15547 2019-01-23  Tom Tromey  <tom@tromey.com>
15548             Pedro Alves  <palves@redhat.com>
15549
15550         * infrun.c (disable_thread_events): Delete.
15551         (stop_all_threads): Use SCOPE_EXIT.
15552
15553 2019-01-23  Tom Tromey  <tom@tromey.com>
15554             Pedro Alves  <palves@redhat.com>
15555
15556         * symfile.c: Include forward-scope-exit.h.
15557         (clear_symtab_users_cleanup): Replace forward declaration with
15558         a FORWARD_SCOPE_EXIT.
15559         (syms_from_objfile_1): Use the forward_scope_exit and
15560         gdb::optional instead of cleanup_function.
15561         (reread_symbols): Use the forward_scope_exit instead of
15562         cleanup_function.
15563         (clear_symtab_users_cleanup): Remove function.
15564
15565 2019-01-23  Tom Tromey  <tom@tromey.com>
15566             Pedro Alves  <palves@redhat.com>
15567
15568         * linux-nat.c: Include scope-exit.h.
15569         (cleanup_target_stop): Remove.
15570         (linux_nat_target::static_tracepoint_markers_by_strid): Use
15571         SCOPE_EXIT.
15572
15573 2019-01-23  Tom Tromey  <tom@tromey.com>
15574             Pedro Alves  <palves@redhat.com>
15575
15576         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
15577         (call_function_by_hand_dummy): Use SCOPE_EXIT.
15578
15579 2019-01-23  Tom Tromey  <tom@tromey.com>
15580             Andrew Burgess  <andrew.burgess@embecosm.com>
15581             Pedro Alves  <palves@redhat.com>
15582
15583         * infrun.c (fetch_inferior_event): Use scope_exit.
15584         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
15585         * top.c (execute_command): Use scope_exit.
15586         * breakpoint.c (bpstat_do_actions): Use scope_exit.
15587         * utils.c (do_bpstat_clear_actions_cleanup)
15588         (make_bpstat_clear_actions_cleanup): Remove.
15589
15590 2019-01-23  Tom Tromey  <tom@tromey.com>
15591             Pedro Alves  <palves@redhat.com>
15592
15593         * infrun.c: Include "common/scope-exit.h"
15594         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
15595         (wait_for_inferior): Use SCOPE_EXIT.
15596         (fetch_inferior_event): Use scope_exit.
15597
15598 2019-01-23  Tom Tromey  <tom@tromey.com>
15599             Pedro Alves  <palves@redhat.com>
15600
15601         * breakpoint.c (create_breakpoint): Remove cleanup.
15602
15603 2019-01-23  Tom Tromey  <tom@tromey.com>
15604             Andrew Burgess  <andrew.burgess@embecosm.com>
15605             Pedro Alves  <palves@redhat.com>
15606
15607 2019-01-23  Pedro Alves  <palves@redhat.com>
15608
15609         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
15610
15611 2019-01-23  Pedro Alves  <palves@redhat.com>
15612             Andrew Burgess  <andrew.burgess@embecosm.com>
15613
15614         * gdbthread.h: Include "common/forward-scope-exit.h".
15615         (scoped_finish_thread_state): Redefine custom class in terms of
15616         forward_scope_exit.
15617
15618 2019-01-23  Pedro Alves  <palves@redhat.com>
15619             Andrew Burgess  <andrew.burgess@embecosm.com>
15620
15621         * common/forward-scope-exit.h: New file.
15622
15623 2019-01-23  Pedro Alves  <palves@redhat.com>
15624             Andrew Burgess  <andrew.burgess@embecosm.com>
15625             Tom Tromey  <tom@tromey.com>
15626
15627         * common/scope-exit.h: New file.
15628
15629 2019-01-23  Pedro Alves  <palves@redhat.com>
15630
15631         * common/preprocessor.h (ESC): Rename to ...
15632         (ESC_PARENS): ... this.
15633         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
15634         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
15635
15636 2019-01-23  Tom Tromey  <tom@tromey.com>
15637
15638         * language.h (class scoped_switch_to_sym_language_if_auto):
15639         Initialize m_lang in both cases.
15640
15641 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
15642
15643         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
15644         with XCNEW.
15645
15646 2019-01-22  Tom Tromey  <tom@tromey.com>
15647
15648         * corelow.c: Do not include sys/file.h.
15649
15650 2019-01-22  Tom Tromey  <tom@tromey.com>
15651
15652         * tui/tui-wingeneral.h: Include gdb_curses.h.
15653
15654 2019-01-22  Tom Tromey  <tom@tromey.com>
15655
15656         * source-cache.h (class source_cache) <get_source_lines,
15657         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
15658
15659 2019-01-22  Tom Tromey  <tom@tromey.com>
15660
15661         * remote-fileio.h (struct remote_target): Declare.
15662
15663 2019-01-22  Tom Tromey  <tom@tromey.com>
15664
15665         * python/py-arch.c: Do not include py-ref.h.
15666         * python/py-bpevent.c: Do not include py-ref.h.
15667         * python/py-cmd.c: Do not include py-ref.h.
15668         * python/py-continueevent.c: Do not include py-ref.h.
15669         * python/py-event.h: Do not include py-ref.h.
15670         * python/py-evtregistry.c: Do not include py-ref.h.
15671         * python/py-finishbreakpoint.c: Do not include py-ref.h.
15672         * python/py-frame.c: Do not include py-ref.h.
15673         * python/py-framefilter.c: Do not include py-ref.h.
15674         * python/py-function.c: Do not include py-ref.h.
15675         * python/py-infevents.c: Do not include py-ref.h.
15676         * python/py-linetable.c: Do not include py-ref.h.
15677         * python/py-objfile.c: Do not include py-ref.h.
15678         * python/py-param.c: Do not include py-ref.h.
15679         * python/py-prettyprint.c: Do not include py-ref.h.
15680         * python/py-progspace.c: Do not include py-ref.h.
15681         * python/py-symbol.c: Do not include py-ref.h.
15682         * python/py-symtab.c: Do not include py-ref.h.
15683         * python/py-type.c: Do not include py-ref.h.
15684         * python/py-unwind.c: Do not include py-ref.h.
15685         * python/py-utils.c: Do not include py-ref.h.
15686         * python/py-value.c: Do not include py-ref.h.
15687         * python/py-varobj.c: Do not include py-ref.h.
15688         * python/py-xmethods.c: Do not include py-ref.h.
15689         * python/python.c: Do not include py-ref.h.
15690         * varobj.c: Do not include py-ref.h.
15691
15692 2019-01-22  Tom Tromey  <tom@tromey.com>
15693
15694         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
15695         keyword for bcache.
15696
15697 2019-01-22  Tom Tromey  <tom@tromey.com>
15698
15699         * compile/compile-cplus-types.c: Remove a comment by #include.
15700
15701 2019-01-22  Tom Tromey  <tom@tromey.com>
15702
15703         * compile/gcc-c-plugin.h: Include compile-internal.h.
15704
15705 2019-01-22  Tom Tromey  <tom@tromey.com>
15706
15707         * stabsread.c (EXTERN): Do not define.
15708         (symnum, next_symbol_text_func, processing_gcc_compilation)
15709         (within_function, global_sym_chain, global_stabs)
15710         (previous_stab_code, this_object_header_files)
15711         (n_this_object_header_files)
15712         (n_allocated_this_object_header_files): Define.
15713         * stabsread.h (EXTERN): Never define.  Use "extern".
15714
15715 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
15716
15717         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
15718         history_value.
15719
15720 2019-01-21  Tom Tromey  <tom@tromey.com>
15721
15722         * ui-out.c: Fix includes.
15723         * tui/tui-source.c: Fix includes.
15724         * target.c: Fix includes.
15725         * remote.c: Fix includes.
15726         * regcache.c: Fix includes.
15727         * python/py-block.c: Fix includes.
15728         * printcmd.c: Fix includes.
15729         * or1k-tdep.c: Fix includes.
15730         * mi/mi-main.c: Fix includes.
15731         * m32r-tdep.c: Fix includes.
15732         * csky-tdep.c: Fix includes.
15733         * compile/compile-cplus-types.c: Fix includes.
15734         * cli/cli-interp.c: Fix includes.
15735
15736 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
15737
15738         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
15739         for padding.
15740
15741 2019-01-16  Tom Tromey  <tom@tromey.com>
15742
15743         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
15744         earlier.
15745         (struct objfile) <msymbols_range>: Move from top level.
15746         <msymbols>: New method.
15747         (class objfile_msymbols): Remove.
15748         * symtab.c (default_collect_symbol_completion_matches_break_on):
15749         Update.
15750         * symmisc.c (dump_msymbols): Update.
15751         * stabsread.c (scan_file_globals): Update.
15752         * objc-lang.c (info_selectors_command, info_classes_command)
15753         (find_methods): Update.
15754         * minsyms.c (find_solib_trampoline_target): Update.
15755         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
15756         * coffread.c (coff_symfile_read): Update.
15757         * ada-lang.c (ada_lookup_simple_minsym)
15758         (ada_collect_symbol_completion_matches): Update.
15759
15760 2019-01-16  Tom Tromey  <tom@tromey.com>
15761
15762         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
15763         type.  Remove no-argument constructor.
15764         <iterator::operator++>: Simplify.
15765         <begin>: Update.
15766         <end>: Use minimal_symbol_count.
15767
15768 2019-01-16  Tom Tromey  <tom@tromey.com>
15769
15770         * objfiles.h (struct objfile) <psymtabs>: New method.
15771         (class objfile_psymtabs): Remove.
15772         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
15773         typedef.
15774         <range>: New method.
15775         (require_partial_symbols): Change return type.
15776         * psymtab.c (require_partial_symbols)
15777         (psym_expand_symtabs_matching): Update.
15778         * mdebugread.c (parse_partial_symbols): Update.
15779         * dbxread.c (dbx_end_psymtab): Update.
15780
15781 2019-01-15  Tom Tromey  <tom@tromey.com>
15782
15783         * symtab.c (lookup_objfile_from_block)
15784         (lookup_symbol_in_objfile_symtabs)
15785         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
15786         (find_line_symtab, info_sources_command)
15787         (default_collect_symbol_completion_matches_break_on)
15788         (make_source_files_completion_list): Update.
15789         * symmisc.c (print_objfile_statistics, dump_objfile)
15790         (maintenance_print_symbols, maintenance_info_symtabs)
15791         (maintenance_check_symtabs, maintenance_info_line_tables):
15792         Update.
15793         * source.c (select_source_symtab)
15794         (forget_cached_source_info_for_objfile): Update.
15795         * objfiles.h (class objfile_compunits): Remove.
15796         (struct objfile) <compunits_range>: New typedef.
15797         (compunits): New method.
15798         * objfiles.c (objfile_relocate1): Update.
15799         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
15800         * maint.c (count_symtabs_and_blocks): Update.
15801         * linespec.c (iterate_over_all_matching_symtabs): Update.
15802         * cp-support.c (add_symbol_overload_list_qualified): Update.
15803         * coffread.c (coff_symtab_read): Update.
15804         * ada-lang.c (add_nonlocal_symbols)
15805         (ada_collect_symbol_completion_matches)
15806         (ada_add_global_exceptions): Update.
15807
15808 2019-01-15  Tom Tromey  <tom@tromey.com>
15809
15810         * progspace.h (program_space) <objfiles_safe_range>: New
15811         typedef.
15812         <objfiles_safe>: New method.
15813         * objfiles.h (class all_objfiles_safe): Remove.
15814         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
15815         * jit.c (jit_inferior_exit_hook): Update.
15816
15817 2019-01-17  Tom Tromey  <tom@tromey.com>
15818
15819         * progspace.h (program_space) <objfiles_range>: New typedef.
15820         <objfiles>: New method.
15821         <objfiles_head>: Rename from objfiles.
15822         (object_files): Update.
15823         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
15824         * guile/scm-pretty-print.c
15825         (ppscm_find_pretty_printer_from_objfiles): Update.
15826         * guile/scm-objfile.c (gdbscm_objfiles): Update.
15827         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
15828         Update.
15829         * python/py-progspace.c (pspy_get_objfiles): Update.
15830         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
15831         Update.
15832         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
15833         (objfpy_lookup_objfile_by_build_id): Update.
15834         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
15835         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
15836         Update.
15837         * symtab.c (iterate_over_symtabs, matching_obj_sections)
15838         (expand_symtab_containing_pc, lookup_objfile_from_block)
15839         (lookup_static_symbol, basic_lookup_transparent_type)
15840         (find_pc_sect_compunit_symtab, find_symbol_at_address)
15841         (find_line_symtab, info_sources_command)
15842         (default_collect_symbol_completion_matches_break_on)
15843         (make_source_files_completion_list, find_main_name): Update.
15844         * symmisc.c (print_symbol_bcache_statistics)
15845         (print_objfile_statistics, maintenance_print_symbols)
15846         (maintenance_print_msymbols, maintenance_print_objfiles)
15847         (maintenance_info_symtabs, maintenance_check_symtabs)
15848         (maintenance_expand_symtabs, maintenance_info_line_tables):
15849         Update.
15850         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
15851         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
15852         (map_overlay_command, unmap_overlay_command)
15853         (simple_overlay_update, expand_symtabs_matching)
15854         (map_symbol_filenames): Update.
15855         * symfile-debug.c (set_debug_symfile): Update.
15856         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
15857         Update.
15858         * source.c (select_source_symtab, forget_cached_source_info):
15859         Update.
15860         * solib.c (solib_read_symbols): Update.
15861         * solib-spu.c (append_ocl_sos): Update.
15862         * psymtab.c (maintenance_print_psymbols)
15863         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
15864         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
15865         * printcmd.c (info_symbol_command): Update.
15866         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
15867         Update.
15868         * objfiles.h (class all_objfiles): Remove.
15869         * objfiles.c (have_partial_symbols, have_full_symbols)
15870         (have_minimal_symbols, qsort_cmp, update_section_map)
15871         (shared_objfile_contains_address_p)
15872         (default_iterate_over_objfiles_in_search_order): Update.
15873         * objc-lang.c (info_selectors_command, info_classes_command)
15874         (find_methods): Update.
15875         * minsyms.c (find_solib_trampoline_target): Update.
15876         * maint.c (maintenance_info_sections)
15877         (maintenance_translate_address, count_symtabs_and_blocks):
15878         Update.
15879         * main.c (captured_main_1): Update.
15880         * linux-thread-db.c (try_thread_db_load_from_pdir)
15881         (has_libpthread): Update.
15882         * linespec.c (iterate_over_all_matching_symtabs)
15883         (search_minsyms_for_name): Update.
15884         * jit.c (jit_find_objf_with_entry_addr): Update.
15885         * hppa-tdep.c (find_unwind_entry)
15886         (hppa_lookup_stub_minimal_symbol): Update.
15887         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
15888         Update.
15889         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
15890         (elf_gnu_ifunc_resolve_by_got): Update.
15891         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
15892         * dwarf-index-write.c (save_gdb_index_command): Update.
15893         * cp-support.c (add_symbol_overload_list_qualified): Update.
15894         * breakpoint.c (create_overlay_event_breakpoint)
15895         (create_longjmp_master_breakpoint)
15896         (create_std_terminate_master_breakpoint)
15897         (create_exception_master_breakpoint): Update.
15898         * blockframe.c (find_pc_partial_function): Update.
15899         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
15900         (ada_collect_symbol_completion_matches)
15901         (ada_add_global_exceptions): Update.
15902
15903 2019-01-17  Tom Tromey  <tom@tromey.com>
15904
15905         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
15906         declare VEC.
15907         (solib_target_parse_libraries): Change return type.
15908         (library_list_start_segment, library_list_start_section)
15909         (library_list_end_library, library_list_start_library); Update.
15910         (solib_target_free_library_list): Remove.
15911         (solib_target_parse_libraries): Remove cleanup.  Change return
15912         type.
15913         (solib_target_current_sos): Update.
15914
15915 2019-01-17  Tom Tromey  <tromey@bapiya>
15916
15917         * valprint.c: Replace "the the" with "the".
15918         * symtab.c: Replace "the the" with "the".
15919         * solib.c: Replace "the the" with "the".
15920         * solib-dsbt.c: Replace "the the" with "the".
15921         * linespec.c: Replace "the the" with "the".
15922         * dwarf2loc.h: Replace "the the" with "the".
15923         * amd64-windows-tdep.c: Replace "the the" with "the".
15924         * aarch64-tdep.c: Replace "the the" with "the".
15925
15926 2019-01-16  Keith Seitz  <keiths@redhat.com>
15927
15928         PR gdb/23773
15929         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
15930         <builder>: Rename to ..
15931         <m_builder>: ... this and make private.
15932         (dwarf2_cu::get_builder): New method.  Change all users of
15933         `builder' to use this method.
15934         (dwarf2_start_symtab): Move to ...
15935         (dwarf2_cu::start_symtab): ... here.  Update all callers
15936         (setup_type_unit_groups): Move to ...
15937         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
15938         callers.
15939         (dwarf2_cu::reset_builder): New method.
15940         (process_full_compunit, process_full_type_unit): Use
15941         dwarf2_cu::reset_builder.
15942         (follow_die_offset): Record the ancestor CU if it is different
15943         from the followed DIE's CU.
15944         (follow_die_sig_1): Likewise.
15945
15946 2019-01-15  Tom Tromey  <tom@tromey.com>
15947
15948         * remote.c (class remote_state) <buf>: Now a char_vector.
15949         <buf_size>: Remove.
15950         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
15951         parameter.
15952         (remote_target::getpkt_or_notif_sane_1)
15953         (remote_target::getpkt_sane)
15954         (remote_target::getpkt_or_notif_sane): Likewise.
15955         (class remote_target) <putpkt>: New overload.
15956         (remote_target::read_frame): Change type of "buf_p".  Remove
15957         sizeof_p parameter.
15958         (packet_ok): New overload.
15959         (packet_check_result): New overload.
15960         Update all uses.
15961
15962 2019-01-14  Tom Tromey  <tom@tromey.com>
15963
15964         * remote-notif.c (handle_notification, remote_notif_ack)
15965         (remote_notif_parse): Make "buf" const.
15966         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
15967         const.
15968         (remote_notif_parse, remote_notif_ack, handle_notification):
15969         Likewise.
15970         * remote.c (remote_notif_stop_parse): Make "buf" const.
15971         (remote_target::remote_parse_stop_reply): Make "buf" const.
15972         (remote_notif_stop_ack): Make "buf" const.
15973
15974 2019-01-14  Tom Tromey  <tom@tromey.com>
15975
15976         * remote.c (remote_console_output): Make parameter const.
15977
15978 2019-01-14  Tom Tromey  <tom@tromey.com>
15979
15980         * target-debug.h (target_debug_print_signals): Constify.
15981         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
15982         * procfs.c (procfs_target::pass_signals): Update.
15983         * linux-nat.c (linux_nat_target::pass_signals): Update.
15984         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
15985         * target-delegates.c: Rebuild.
15986         * remote.c (remote_target::program_signals): Update.
15987         (remote_target::pass_signals): Update.
15988         * target.c (target_pass_signals): Constify argument.
15989         (target_program_signals): Likewise.
15990         * target.h (struct target_ops) <pass_signals, program_signals>:
15991         Constify argument.
15992         (target_pass_signals, target_program_signals): Constify argument.
15993
15994 2019-01-14  Tom Tromey  <tom@tromey.com>
15995
15996         PR tui/28819:
15997         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
15998
15999 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
16000
16001         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
16002         field.
16003         * rs6000-tdep.c: Include reggroups.h.
16004         (IS_V_ALIAS_PSEUDOREG): Define.
16005         (rs6000_register_name): Return names for the "vX" aliases.
16006         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
16007         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
16008         aliases.  Call default_register_reggroup_p for all other
16009         pseudo-registers.
16010         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
16011         New functions.
16012         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
16013         Handle "vX" aliases.
16014         (v_alias_pseudo_register_collect): New function.
16015         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
16016         (rs6000_gdbarch_init): Initialize "vX" aliases as
16017         pseudo-registers.  Restore registration of
16018         rs6000_pseudo_register_reggroup_p with
16019         set_tdesc_pseudo_register_reggroup_p.
16020
16021 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
16022
16023         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
16024         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
16025         set_gdbarch_num_pseudo_regs.
16026
16027 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
16028
16029         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
16030         Remove arg prefixname, add do_set and do_show.
16031         Add member functions set_list and show_list.
16032         * cli/cli-style.c (class cli_style_option): Update accordingly.
16033         (style_set_list): Move to file scope.
16034         (style_show_list): Likewise.
16035         (set_style): Call help_list.
16036         (show_style): Call cmd_show_list.
16037         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
16038         Update to use the new macro.
16039
16040 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
16041
16042         * ada-lang.c (_initialize_ada_language): Expand the help text
16043         for the "catch exception" command.
16044
16045 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
16046
16047         * symtab.c (matching_obj_sections): Initialize obj,
16048         declare it closer to its usage.
16049
16050 2019-01-10  Tom Tromey  <tom@tromey.com>
16051
16052         * thread-iter.h (inf_threads_iterator): Use next_iterator.
16053         (basic_inf_threads_range): Remove.
16054         (inf_threads_range, inf_non_exited_threads_range)
16055         (safe_inf_threads_range): Use next_adapter.
16056
16057 2019-01-10  Keith Seitz  <keiths@redhat.com>
16058
16059         PR gdb/23712
16060         PR symtab/23010
16061         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
16062         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
16063
16064 2019-01-10  Keith Seitz  <keiths@redhat.com>
16065
16066         PR gdb/23712
16067         PR symtab/23010
16068         * dictionary.c (pending_to_vector): Remove.
16069         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
16070         Remove _1 suffix, replacing functions of the same name.  Update
16071         all callers.
16072         (dict_create_hashed, dict_create_hashed_expandable)
16073         (dict_create_linear, dict_create_linear_expandable, dict_free)
16074         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
16075         Make functions static.
16076
16077 2019-01-10  Keith Seitz  <keiths@redhat.com>
16078
16079         PR gdb/23712
16080         PR symtab/23010
16081         * dictionary.h (struct dictionary): Replace declaration with
16082         multidictionary.
16083         (dict_create_hashed, dict_create_hashed_expandable)
16084         (dict_create_linear, dict_create_linear_expandable)
16085         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
16086         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
16087         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
16088         taking multidictionary argument.
16089         [ALL_DICT_SYMBOLS]: Update for multidictionary.
16090         * block.h (struct block) <dict>: Change to multidictionary
16091         and rename `multidict'.
16092         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
16093         symmisc.c: Update all dictionary references to multidictionary.
16094
16095 2019-01-10  Keith Seitz  <keiths@redhat.com>
16096
16097         PR gdb/23712
16098         PR symtab/23010
16099         * dictionary.c: Include unordered_map.
16100         (pending_to_vector): New function.
16101         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
16102         Rewrite the non-"_1" functions to take vector instead
16103         of linked list.
16104         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
16105         "new" _1 versions of the same name.
16106         (multidictionary): Define.
16107         (std::hash<enum language): New definition.
16108         (collate_pending_symbols_by_language, mdict_create_hashed)
16109         (mdict_create_hashed_expandable, mdict_create_linear)
16110         (mdict_create_linear_expandable, mdict_free)
16111         (find_language_dictionary, create_new_language_dictionary)
16112         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
16113         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
16114         (mdict_size, mdict_empty): New functions.
16115         * dictionary.h (mdict_iterator): Define.
16116
16117 2019-01-10  Pedro Alves  <palves@redhat.com>
16118
16119         * breakpoint.c (read_uploaded_action)
16120         (create_tracepoint_from_upload): Adjust to use
16121         gdb::unique_xmalloc_ptr.
16122         * ctf.c (ctf_write_uploaded_tp):
16123         (SET_ARRAY_FIELD): Use emplace_back.
16124         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
16125         * tracefile-tfile.c (tfile_write_uploaded_tp):
16126         * tracepoint.c (parse_tracepoint_definition): Adjust to use
16127         gdb::unique_xmalloc_ptr.
16128         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
16129         at_string, cond_string, cmd_strings>: Replace char pointers
16130         with gdb::unique_xmalloc_ptr.
16131
16132 2019-01-10  Pedro Alves  <palves@redhat.com>
16133
16134         * solib-target.c (library_list_start_library): Don't xstrdup name.
16135
16136 2019-01-10  Pedro Alves  <palves@redhat.com>
16137
16138         * mdebugread.c (parse_partial_symbols): Use
16139         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
16140
16141 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
16142
16143         * linux-fork.c (scoped_switch_fork_info)
16144         <~scoped_switch_fork_info>: Fix incorrect variable name.
16145
16146 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
16147
16148         * linux-fork.c (scoped_switch_fork_info)
16149         <scoped_switch_fork_info>: Make explicit.
16150         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
16151
16152 2019-01-10  Tom Tromey  <tom@tromey.com>
16153
16154         * objfiles.h (objfile::reset_psymtabs): Update.
16155         * objfiles.c (objfile::objfile): Update.
16156         * psymtab.h (psymtab_storage::obstack): Update.
16157         (psymtab_storage::m_obstack): Use gdb::optional.
16158         (class psymtab_storage): Update comment.  Remove objfile
16159         parameter.
16160         * psymtab.c (psymtab_storage::psymtab_storage): Update.
16161
16162 2019-01-10  Tom Tromey  <tom@tromey.com>
16163
16164         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
16165         <free_psymtabs>: Now private.
16166         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
16167         (allocate_psymtab): Use new method.
16168
16169 2019-01-10  Tom Tromey  <tom@tromey.com>
16170
16171         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
16172         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
16173         * mdebugread.c (parse_partial_symbols): Use
16174         allocate_dependencies.
16175         * dwarf2read.c (dwarf2_create_include_psymtab): Use
16176         allocate_dependencies.
16177         (process_psymtab_comp_unit_reader)
16178         (build_type_psymtab_dependencies): Likewise.
16179         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
16180
16181 2019-01-10  Tom Tromey  <tom@tromey.com>
16182
16183         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
16184         PSYMBOL_SET_LANGUAGE.
16185         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
16186
16187 2019-01-10  Tom Tromey  <tom@tromey.com>
16188
16189         * psymtab.h (psymtab_storage::obstack): New method.
16190         <m_obstack>: Rename from obstack; now private.
16191         * psymtab.c (psymtab_storage): Update.
16192         * dwarf2read.c (create_addrmap_from_index)
16193         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
16194         Update.
16195
16196 2019-01-10  Tom Tromey  <tom@tromey.com>
16197
16198         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
16199         * objfiles.h (objfile::reset_psymtabs): New method.
16200
16201 2019-01-10  Tom Tromey  <tom@tromey.com>
16202
16203         * symmisc.c (print_symbol_bcache_statistics): Update.
16204         (print_objfile_statistics): Update.
16205         * symfile.c (reread_symbols): Update.
16206         * psymtab.h (class psymtab_storage): New.
16207         * psymtab.c (psymtab_storage): New constructor.
16208         (~psymtab_storage): New destructor.
16209         (require_partial_symbols): Update.
16210         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
16211         (find_pc_sect_psymtab, find_pc_sect_psymbol)
16212         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
16213         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
16214         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
16215         (start_psymtab_common, end_psymtab_common)
16216         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
16217         (allocate_psymtab): Update.
16218         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
16219         Update.
16220         (dump_psymtab_addrmap, maintenance_print_psymbols)
16221         (maintenance_check_psymtabs): Update.
16222         (class objfile_psymtabs): Move to objfiles.h.
16223         * psympriv.h (discard_psymtab): Now inline.
16224         (psymtab_discarder::psymtab_discarder): Update.
16225         (psymtab_discarder::~psymtab_discarder): Update.
16226         (ALL_OBJFILE_PSYMTABS): Rewrite.
16227         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
16228         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
16229         Remove fields.
16230         <partial_symtabs>: New field.
16231         (class objfile_psymtabs): Move from psymtab.h.  Update.
16232         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
16233         psymbol_cache.
16234         (objfile::~objfile): Don't destroy psymbol_cache.
16235         * mdebugread.c (parse_partial_symbols): Update.
16236         * dwarf2read.c (create_addrmap_from_index)
16237         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
16238         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
16239         (add_partial_subprogram, dwarf2_ranges_read): Update.
16240         * dwarf-index-write.c (write_address_map)
16241         (write_one_signatured_type, recursively_write_psymbols)
16242         (class debug_names, class debug_names, write_psymtabs_to_index):
16243         Update.
16244
16245 2019-01-10  Tom Tromey  <tom@tromey.com>
16246
16247         * symtab.h (SYMBOL_SET_NAMES): Update.
16248         (symbol_set_names): Update.
16249         (MSYMBOL_SET_NAMES): Update.
16250         * symtab.c (symbol_set_names): Change argument to be an
16251         objfile_per_bfd_storage.
16252         * psymtab.c (add_psymbol_to_bcache): Update.
16253         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
16254
16255 2019-01-10  Tom Tromey  <tom@tromey.com>
16256
16257         * symtab.c (create_demangled_names_hash): Change argument to be an
16258         objfile_per_bfd_storage.
16259         (symbol_set_names): Update.
16260
16261 2019-01-10  Tom Tromey  <tom@tromey.com>
16262
16263         * xcoffread.c (xcoff_initial_scan): Unconditionally call
16264         init_psymbol_list.
16265         * psymtab.c (init_psymbol_list): Do nothing if already called.
16266         * psympriv.h (init_psymbol_list): Add comment.
16267         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
16268         init_psymbol_list.
16269         * dbxread.c (dbx_symfile_read): Unconditionally call
16270         init_psymbol_list.
16271
16272 2019-01-10  Tom Tromey  <tom@tromey.com>
16273
16274         * xcoffread.c (scan_xcoff_symtab): Update.
16275         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
16276         "where".
16277         * mdebugread.c (parse_partial_symbols)
16278         (handle_psymbol_enumerators): Update.
16279         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
16280         * dbxread.c (read_dbx_symtab): Update.
16281         * psympriv.h (psymbol_placement): New enum.
16282         (add_psymbol_to_list): Update.
16283
16284 2019-01-10  Tom Tromey  <tom@tromey.com>
16285
16286         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
16287         static_psymbols parameters.
16288         (scan_xcoff_symtab): Update.
16289         * psymtab.c (start_psymtab_common): Remove global_psymbols and
16290         static_psymbols parameters.
16291         * psympriv.h (start_psymtab_common): Update.
16292         * mdebugread.c (parse_partial_symbols): Update.
16293         * dwarf2read.c (create_partial_symtab): Update.
16294         * dbxread.c (read_dbx_symtab): Update.
16295         (start_psymtab): Remove global_psymbols and static_psymbols
16296         parameters.
16297
16298 2019-01-10  Tom Tromey  <tom@tromey.com>
16299
16300         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
16301         * psymtab.c (allocate_psymtab): Add comment.
16302         * psympriv.h (allocate_psymtab): Add comment.
16303         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
16304         initializations.
16305         * dbxread.c (dbx_end_psymtab): Remove some initializations.
16306
16307 2019-01-10  Tom Tromey  <tom@tromey.com>
16308
16309         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
16310         Don't declare.
16311         * mipsread.c: Include mdebugread.h.
16312         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
16313         Declare.
16314         * elfread.c: Include mdebugread.h.
16315
16316 2019-01-09  Tom Tromey  <tom@tromey.com>
16317
16318         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
16319         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
16320         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
16321         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
16322         (psym_lookup_symbol, psym_find_last_source_symtab)
16323         (psym_forget_cached_source_info, psym_print_stats)
16324         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
16325         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
16326         (psym_map_matching_symbols, psym_expand_symtabs_matching)
16327         (psym_find_compunit_symtab_by_address)
16328         (maintenance_print_psymbols, maintenance_info_psymtabs)
16329         (maintenance_check_psymtabs): Use ranged for.
16330         * psymtab.h (class objfile_psymtabs): New.
16331         (require_partial_symbols): Return objfile_psymtabs.
16332         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
16333
16334 2019-01-09  Tom Tromey  <tom@tromey.com>
16335
16336         * symfile.c (overlay_invalidate_all, find_pc_overlay)
16337         (find_pc_mapped_section, list_overlays_command)
16338         (map_overlay_command, unmap_overlay_command)
16339         (simple_overlay_update): Use all_objfiles.
16340         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
16341         * printcmd.c (info_symbol_command): Use all_objfiles.
16342         * objfiles.h (ALL_OBJSECTIONS): Remove.
16343         * maint.c (maintenance_translate_address): Use all_objfiles.
16344         * gcore.c (gcore_create_callback): Use all_objfiles.
16345         (objfile_find_memory_regions): Likewise.
16346
16347 2019-01-09  Tom Tromey  <tom@tromey.com>
16348
16349         * symtab.c (find_line_symtab, info_sources_command)
16350         (make_source_files_completion_list): Use objfile_compunits.
16351         * source.c (select_source_symtab): Use objfile_compunits.
16352         * objfiles.h (struct objfile): Update comment.
16353         (ALL_OBJFILES): Remove.
16354         (ALL_FILETABS): Remove.
16355         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
16356         objfile_compunits.
16357
16358 2019-01-09  Tom Tromey  <tom@tromey.com>
16359
16360         * symmisc.c (print_objfile_statistics, dump_objfile)
16361         (maintenance_print_symbols): Use compunit_filetabs.
16362         * source.c (forget_cached_source_info_for_objfile): Use
16363         compunit_filetabs.
16364         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
16365         (ALL_FILETABS): Use compunit_filetabs.
16366         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
16367         * coffread.c (coff_symtab_read): Use compunit_filetabs.
16368
16369 2019-01-09  Tom Tromey  <tom@tromey.com>
16370
16371         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
16372         (compunit_filetabs): New.
16373         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
16374         compunit_filetabs.
16375         (info_sources_command, make_source_files_completion_list): Remove
16376         declaration.
16377         * symmisc.c (print_objfile_statistics, dump_objfile)
16378         (maintenance_print_symbols): Remove declaration.
16379         (maintenance_info_symtabs): Use compunit_filetabs.
16380         (maintenance_info_line_tables): Likewise.
16381         * source.c (select_source_symtab): Change local variable name.
16382         (forget_cached_source_info_for_objfile): Remove declaration.
16383         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
16384         * objfiles.c (objfile_relocate1): Remove declaration.
16385         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
16386         declaration.
16387         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
16388         * coffread.c (coff_symtab_read): Remove declaration.
16389         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
16390         compunit_filetabs.
16391
16392 2019-01-09  Tom Tromey  <tom@tromey.com>
16393
16394         * symtab.c (lookup_objfile_from_block)
16395         (find_pc_sect_compunit_symtab, search_symbols)
16396         (default_collect_symbol_completion_matches_break_on): Use
16397         objfile_compunits.
16398         * objfiles.h (ALL_COMPUNITS): Remove.
16399         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
16400         * cp-support.c (add_symbol_overload_list_qualified): Use
16401         objfile_compunits.
16402         * ada-lang.c (ada_collect_symbol_completion_matches)
16403         (ada_add_global_exceptions): Use objfile_compunits.
16404
16405 2019-01-09  Tom Tromey  <tom@tromey.com>
16406
16407         * source.c (select_source_symtab)
16408         (forget_cached_source_info_for_objfile): Remove declaration.
16409         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
16410         declaration.
16411         * maint.c (count_symtabs_and_blocks): Remove declaration.
16412         * cp-support.c (add_symbol_overload_list_qualified): Remove
16413         declaration.
16414         * coffread.c (coff_symtab_read): Remove declaration.
16415         * symtab.c (lookup_symbol_in_objfile_symtabs)
16416         (basic_lookup_transparent_type_1): Use objfile_compunits.
16417         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
16418         (info_sources_command, search_symbols)
16419         (default_collect_symbol_completion_matches_break_on)
16420         (make_source_files_completion_list): Remove declaration.
16421         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
16422         (ada_collect_symbol_completion_matches)
16423         (ada_add_global_exceptions): Remove declaration.
16424         * linespec.c (iterate_over_all_matching_symtabs): Use
16425         objfile_compunits.
16426         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
16427         (class objfile_compunits): New.
16428         (ALL_COMPUNITS): Use objfile_compunits.
16429         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
16430         (maintenance_check_symtabs, maintenance_info_line_tables): Use
16431         objfile_compunits.
16432         * objfiles.c (objfile_relocate1): Use objfile_compunits.
16433
16434 2019-01-09  Tom Tromey  <tom@tromey.com>
16435
16436         * symtab.c (search_symbols)
16437         (default_collect_symbol_completion_matches_break_on): Use
16438         objfile_msymbols.
16439         * ada-lang.c (ada_lookup_simple_minsym)
16440         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
16441         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
16442         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
16443         objfile_msymbols.
16444         * coffread.c (coff_symfile_read): Use objfile_msymbols.
16445         * symmisc.c (dump_msymbols): Use objfile_msymbols.
16446         * objc-lang.c (find_methods): Use objfile_msymbols.
16447         (info_selectors_command, info_classes_command): Likewise.
16448         * stabsread.c (scan_file_globals): Use objfile_msymbols.
16449         * objfiles.h (class objfile_msymbols): New.
16450         (ALL_OBJFILE_MSYMBOLS): Remove.
16451         (ALL_MSYMBOLS): Remove.
16452
16453 2019-01-09  Tom Tromey  <tom@tromey.com>
16454
16455         * common/next-iterator.h (next_adapter): Add Iterator template
16456         parameter.
16457         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
16458         (class all_objfiles_safe): New.
16459         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
16460         * objfiles.c (put_objfile_before): Update comment.
16461         (add_separate_debug_objfile): Likewise.
16462         (free_all_objfiles): Use all_objfiles_safe.
16463         (objfile_purge_solibs): Likewise.
16464
16465 2019-01-09  Tom Tromey  <tom@tromey.com>
16466
16467         * symtab.c (iterate_over_symtabs, matching_obj_sections)
16468         (expand_symtab_containing_pc, lookup_static_symbol)
16469         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
16470         (find_symbol_at_address, find_line_symtab, find_main_name): Use
16471         all_objfiles.
16472         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
16473         * breakpoint.c (create_overlay_event_breakpoint)
16474         (create_longjmp_master_breakpoint)
16475         (create_std_terminate_master_breakpoint)
16476         (create_exception_master_breakpoint): Use all_objfiles.
16477         * linux-thread-db.c (try_thread_db_load_from_pdir)
16478         (has_libpthread): Use all_objfiles.
16479         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
16480         * linespec.c (iterate_over_all_matching_symtabs)
16481         (search_minsyms_for_name): Use all_objfiles.
16482         * maint.c (maintenance_info_sections): Use all_objfiles.
16483         * main.c (captured_main_1): Use all_objfiles.
16484         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
16485         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
16486         * guile/scm-pretty-print.c
16487         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
16488         * solib-spu.c (append_ocl_sos): Use all_objfiles.
16489         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
16490         (maintenance_print_msymbols): Use all_objfiles.
16491         * source.c (select_source_symtab): Use all_objfiles.
16492         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
16493         * symfile.c (remove_symbol_file_command)
16494         (expand_symtabs_matching, map_symbol_filenames): Use
16495         all_objfiles.
16496         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
16497         all_objfiles.
16498         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
16499         * objc-lang.c (find_methods): Use all_objfiles.
16500         * objfiles.c (have_partial_symbols, have_full_symbols)
16501         (have_minimal_symbols, qsort_cmp)
16502         (default_iterate_over_objfiles_in_search_order): Use
16503         all_objfiles.
16504         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
16505         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
16506         (maintenance_check_psymtabs): Use all_objfiles.
16507         (ALL_PSYMTABS): Remove.
16508         * compile/compile-object-run.c (do_module_cleanup): Use
16509         all_objfiles.
16510         * blockframe.c (find_pc_partial_function): Use all_objfiles.
16511         * cp-support.c (add_symbol_overload_list_qualified): Use
16512         all_objfiles.
16513         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
16514         Use all_objfiles.
16515         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
16516         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
16517         all_objfiles.
16518         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
16519         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
16520         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
16521         Uses all_objfiles.
16522         * solib.c (solib_read_symbols): Use all_objfiles
16523
16524 2019-01-09  Tom Tromey  <tom@tromey.com>
16525
16526         * probe.c (parse_probes_in_pspace): Use all_objfiles.
16527         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
16528         all_objfiles.
16529         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
16530         * symmisc.c (print_symbol_bcache_statistics)
16531         (print_objfile_statistics, maintenance_print_objfiles)
16532         (maintenance_info_symtabs, maintenance_check_symtabs)
16533         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
16534         all_objfiles.
16535         * source.c (forget_cached_source_info): Use all_objfiles.
16536         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
16537         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
16538         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
16539         * objfiles.c (update_section_map): Use all_objfiles.
16540         (shared_objfile_contains_address_p): Likewise.
16541         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
16542         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
16543
16544 2019-01-09  Tom Tromey  <tom@tromey.com>
16545
16546         * common/next-iterator.h: New file.
16547         * objfiles.h (class all_objfiles): New.
16548         (struct objfile_iterator): New.
16549
16550 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
16551
16552         * NEWS: Move the description of the changed "frame", "select-frame",
16553          and "info frame" commands to the Changed commands section.
16554
16555 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
16556
16557         * gdbtypes.c (check_stub_method_group): Remove handling of old
16558         mangling schemes.
16559         * linespec.c (find_methods): Likewise.
16560         * stabsread.c (read_member_functions): Likewise.
16561         * valops.c (search_struct_method): Likewise.
16562         (value_struct_elt_for_reference): Likewise.
16563         * NEWS: Mention this change.
16564
16565 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
16566
16567         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
16568         print_source_lines.
16569         * source.c (print_source_lines_base): Update line number check.
16570         (print_source_lines): New function.
16571         (source_lines_range::source_lines_range): New function.
16572         * source.h (class source_lines_range): New class.
16573         (print_source_lines): New declaration.
16574
16575 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
16576
16577         * linespec.c (linespec_state_destructor): Free self->canonical_names.
16578
16579 2019-01-08  Tom Tromey  <tom@tromey.com>
16580             Simon Marchi  <simon.marchi@ericsson.com>
16581
16582         PR gdb/24060
16583         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
16584         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
16585         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
16586         * f-exp.y (DOLLAR_VARIABLE): Likewise.
16587         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
16588         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
16589
16590 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
16591
16592         * source.c (select_source_symtab): Move header comment to
16593         declaration in source.h.
16594         (forget_cached_source_info_for_objfile): Likewise.
16595         (forget_cached_source_info): Likewise.
16596         (identify_source_line): Likewise.
16597         * source.h (identify_source_line): Move declaration from symtab.h
16598         and add comment from source.c
16599         (print_source_lines): Likewise.
16600         (forget_cached_source_info_for_objfile): Likewise.
16601         (forget_cached_source_info): Likewise.
16602         (select_source_symtab): Likewise.
16603         (enum print_source_lines_flag): Move definition from symtab.h.
16604         * symtab.h (identify_source_line): Move declaration to source.h.
16605         (print_source_lines): Likewise.
16606         (forget_cached_source_info_for_objfile): Likewise.
16607         (forget_cached_source_info): Likewise.
16608         (select_source_symtab): Likewise.
16609         (enum print_source_lines_flag): Move definition to source.h.
16610         * tui/tui-hooks.c: Add 'source.h' include.
16611
16612 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
16613
16614         * source.c (print_source_lines_base): Handle requests to print
16615         reverse line number sequences, and guard against empty lines
16616         string.
16617
16618 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
16619
16620         * source.c (print_source_lines_base): Fix skip of '\r' if next
16621         character is '\n'.
16622
16623 2019-01-06  Tom Tromey  <tom@tromey.com>
16624
16625         * c-exp.y (struct c_parse_state) <macro_original_text,
16626         expansion_obstack>: New member.
16627         (macro_original_text, expansion_obstack): Remove globals.
16628         (scan_macro_expansion, scanning_macro_expansion)
16629         (finished_macro_expansion): Update.
16630         (scan_macro_cleanup): Remove.
16631         (yylex, c_parse): Update.
16632
16633 2019-01-06  Tom Tromey  <tom@tromey.com>
16634
16635         * c-exp.y (struct c_parse_state) <strings>: New member.
16636         (operator_stoken): Update.
16637
16638 2019-01-06  Tom Tromey  <tom@tromey.com>
16639
16640         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
16641         (union type_stack_elt) <typelist_val>: Now a pointer to
16642         std::vector.
16643         (type_stack_cleanup): Don't declare.
16644         (push_typelist): Update.
16645         * parse.c (pop_typelist): Return a std::vector.
16646         (push_typelist): Take a std::vector.
16647         (follow_types): Update.  Do not free args.
16648         (type_stack_cleanup): Remove.
16649         * c-exp.y (struct c_parse_state): New.
16650         (cpstate): New global.
16651         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
16652         (nonempty_typelist): Update.
16653         (func_mod): Create a new vector.
16654         (c_parse): Create a c_parse_state.
16655         (check_parameter_typelist): Do not delete params.
16656         (function_method): Update.  Do not delete type_list.
16657
16658 2019-01-06  Tom Tromey  <tom@tromey.com>
16659
16660         PR gdb/28155:
16661         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
16662         check_typedef.
16663         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
16664         (print_return_value): Likewise.
16665
16666 2019-01-05  Tom Tromey  <tom@tromey.com>
16667
16668         * contrib/cleanup_check.py: Remove.
16669         * contrib/gcc-with-excheck: Remove.
16670         * contrib/exsummary.py: Remove.
16671         * contrib/excheck.py: Remove.
16672
16673 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
16674
16675         * thread.c (delete_thread_1): Add gdb_assert that THR is not
16676         NULL. Initialize tpprev to NULL instead of assigning it
16677         to NULL on the next statement.
16678         * windows-nat.c (windows_delete_thread): Remove check for
16679         main_thread_id before printing thread exit notifications.
16680         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
16681         Remove thread ID check against main_thread_id.
16682         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
16683         windows_delete_thread.
16684         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
16685
16686 2019-01-04  Tom Tromey  <tom@tromey.com>
16687
16688         * compile/compile.c (_initialize_compile): Use upper case for
16689         metasyntactic variables.
16690         * symmisc.c (_initialize_symmisc): Use upper case for
16691         metasyntactic variables.
16692         * psymtab.c (_initialize_psymtab): Use upper case for
16693         metasyntactic variables.
16694         * demangle.c (demangle_command): Use upper case for metasyntactic
16695         variables.
16696         (_initialize_demangler): Likewise.
16697         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
16698         variables.
16699
16700 2019-01-03  Tom Tromey  <tom@tromey.com>
16701
16702         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
16703
16704 2019-01-03  Tom Tromey  <tom@tromey.com>
16705
16706         * python/py-symtab.c (salpy_str): Update.
16707         (struct salpy_sal_object) <symtab>: Now a PyObject.
16708         (salpy_dealloc): Update.
16709         (del_objfile_sal): Use gdbpy_ref.
16710
16711 2019-01-03  Tom Tromey  <tom@tromey.com>
16712
16713         * python/py-type.c (convert_field): Use new_reference.  Return
16714         gdbpy_ref.
16715         (make_fielditem): Return gdbpy_ref.
16716         (typy_fields): Update.
16717         (typy_getitem): Update.
16718         (field_name): Return gdbpy_ref.  Use new_reference.
16719         (typy_iterator_iternext): Update.
16720
16721 2019-01-03  Tom Tromey  <tom@tromey.com>
16722
16723         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
16724
16725 2019-01-03  Tom Tromey  <tom@tromey.com>
16726
16727         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
16728         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
16729         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
16730         (pspy_set_frame_filters, pspy_set_frame_unwinders)
16731         (pspy_set_type_printers): Likewise.
16732         * python/py-function.c (fnpy_init): Use gdbpy_ref.
16733         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
16734         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
16735         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
16736         (objfpy_set_type_printers): Likewise.
16737
16738 2019-01-03  Tom Tromey  <tom@tromey.com>
16739
16740         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
16741         (gdbpy_print_stack): Use gdbpy_err_fetch.
16742         * python/python-internal.h (class gdbpy_err_fetch): New class.
16743         (class gdbpy_enter) <m_error_type, m_error_value,
16744         m_error_traceback>: Remove.
16745         <m_error>: New member.
16746         (gdbpy_exception_to_string): Don't declare.
16747         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
16748         * python/py-value.c (convert_value_from_python): Use
16749         gdbpy_err_fetch.
16750         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
16751         gdbpy_exception_to_string.
16752         (gdbpy_handle_exception): Use gdbpy_err_fetch.
16753         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
16754         gdbpy_err_fetch.
16755
16756 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
16757
16758         * linux-nat.c (delete_lwp_cleanup): Delete.
16759         (struct lwp_deleter): New struct.
16760         (lwp_info_up): New typedef.
16761         (linux_nat_target::follow_fork): Delete cleanup, and make use of
16762         lwp_info_up.
16763
16764 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
16765
16766         * linux-fork.c (class scoped_switch_fork_info): New class.
16767         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
16768
16769 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
16770
16771         * valops.c (find_overload_match): Remove use of null_cleanup, and
16772         calls to do_cleanups.
16773
16774 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
16775
16776         * compile/compile-cplus-types.c
16777         (compile_cplus_instance::decl_name): Handle changes to
16778         cp_func_name.
16779         * cp-support.c (cp_func_name): Update header comment, update
16780         return type.
16781         * cp-support.h (cp_func_name): Update return type in declaration.
16782         * valops.c (find_overload_match): Move temp_func local to top
16783         level of function and change its type.  Use temp_func to hold and
16784         delete temporary string obtained from cp_func_name.
16785
16786 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
16787
16788         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
16789         gdb::char_vector, remove cleanup, and update uses of `msg`.
16790
16791 2019-01-03  Jim Wilson  <jimw@sifive.com>
16792
16793         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
16794
16795 2019-01-02  Tom Tromey  <tom@tromey.com>
16796
16797         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
16798         (tdesc_parse_xml): Remove cleanups.
16799         * target-descriptions.h (make_cleanup_free_target_description):
16800         Don't declare.
16801         (target_desc_deleter): New struct.
16802         (target_desc_up): New typedef.
16803         * target-descriptions.c (target_desc_deleter::operator()): Rename
16804         from free_target_description.
16805         (make_cleanup_free_target_description): Remove.
16806
16807 2019-01-02  Tom Tromey  <tom@tromey.com>
16808
16809         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
16810         constructor, destructor.
16811         (linespec_parser): Remove typedef.
16812         (~linespec_parser): Rename from linespec_parser_delete.
16813         (linespec_lex_to_end, linespec_complete_label)
16814         (linespec_complete): Update.
16815         (decode_line_full): Remove cleanups.
16816         (decode_line_1): Update.
16817
16818 2019-01-02  Tom Tromey  <tom@tromey.com>
16819
16820         * python/python-internal.h (inferior_to_inferior_object): Change
16821         return type.
16822         * python/py-exitedevent.c (create_exited_event_object): Update.
16823         * python/py-inferior.c (inferior_to_inferior_object): Return
16824         gdbpy_ref.
16825         (python_new_inferior, python_inferior_deleted)
16826         (thread_to_thread_object, delete_thread_object)
16827         (build_inferior_list, gdbpy_selected_inferior): Update.
16828         * python/py-infthread.c (create_thread_object): Update.  Also fail
16829         if inferior_to_inferior_object fails.
16830
16831 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
16832
16833         * inferior.h (class inferior) <displaced_step_state>: New field.
16834         * infrun.h (struct displaced_step_state): Move here from
16835         infrun.c.  Initialize fields, add constructor.
16836         <inf>: Remove field.
16837         <reset>: New method.
16838         * infrun.c (struct displaced_step_inferior_state): Move to
16839         infrun.h.
16840         (displaced_step_inferior_states): Remove.
16841         (get_displaced_stepping_state): Adust.
16842         (displaced_step_in_progress_any_inferior): Adjust.
16843         (displaced_step_in_progress_thread): Adjust.
16844         (displaced_step_in_progress): Adjust.
16845         (add_displaced_stepping_state): Remove.
16846         (get_displaced_step_closure_by_addr): Adjust.
16847         (remove_displaced_stepping_state): Remove.
16848         (infrun_inferior_exit): Call displaced_step_state.reset.
16849         (use_displaced_stepping): Don't check for NULL.
16850         (displaced_step_prepare_throw): Call
16851         get_displaced_stepping_state.
16852         (displaced_step_fixup): Don't check for NULL.
16853         (prepare_for_detach): Don't check for NULL.
16854
16855 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
16856
16857         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
16858          in case of call that did not complete.
16859
16860 2019-01-02  Andrey Utkin  <autkin@undo.io>
16861
16862         * symfile.c (find_separate_debug_file): Fix search of debug files for
16863         remote debuggee.
16864
16865 2019-01-02  Tom Tromey  <tom@tromey.com>
16866
16867         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
16868         indentation.
16869         * python/py-frame.c (frapy_older): Remove cast.
16870         (frapy_newer): Likewise.
16871         * python/py-breakpoint.c (local_setattro): Remove cast.
16872         * python/py-arch.c (archpy_name): Remove local variable.
16873         * python/py-type.c (gdbpy_lookup_type): Remove cast.
16874
16875 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
16876
16877         * unittests/basic_string_view/element_access/char/empty.cc:
16878         Fix year range in copyright header.
16879
16880 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
16881
16882         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
16883         Delete.
16884         <operator==>: Update with for removed field.
16885         <hash>: Likewise.
16886         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
16887         <isa_features>: ...this.
16888         <abi_features>: New field.
16889         (riscv_isa_flen): Update comment.
16890         (riscv_abi_xlen): New declaration.
16891         (riscv_abi_flen): New declaration.
16892         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
16893         isa_features.
16894         (riscv_abi_xlen): New function.
16895         (riscv_isa_flen): Update to get answer from isa_features.
16896         (riscv_abi_flen): New function.
16897         (riscv_has_fp_abi): Update to get answer from abi_features.
16898         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
16899         xlen and flen.
16900         (riscv_call_info) <xlen, flen>: Update comment.
16901         (riscv_call_arg_struct): Remove invalid assertions
16902         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
16903         is removed.
16904         (riscv_gdbarch_init): Gather isa features and abi features
16905         separately, ensure both match on the gdbarch when reusing an old
16906         gdbarch.  Relax an error check to allow 32-bit abi float to run on
16907         a target with 64-bit float hardware.
16908
16909 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
16910
16911         * source.c (search_command_helper): Stop reverse search
16912         when line 1 has been searched.
16913
16914 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
16915
16916         * record-full.c (record_full_base_target::close): Rewrite
16917         record_full_core_buf_list free logic.
16918
16919 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
16920
16921         * break-catch-syscall.c (print_one_catch_syscall): xfree
16922         the last text.
16923
16924 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
16925
16926         * top.c (print_gdb_version): Update Copyright year in version
16927         message.
16928
16929 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
16930
16931         Update copyright year range in all GDB files.
16932
16933 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
16934
16935         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
16936
16937 For older changes see ChangeLog-2018.
16938 \f
16939 Local Variables:
16940 mode: change-log
16941 left-margin: 8
16942 fill-column: 74
16943 version-control: never
16944 coding: utf-8
16945 End:
16946