AArch64: Set the correct ELF class for AArch64 stubs (PR/25210)
authorTamar Christina <tamar.christina@arm.com>
Thu, 2 Jan 2020 14:06:01 +0000 (14:06 +0000)
committerTamar Christina <tamar.christina@arm.com>
Thu, 2 Jan 2020 14:08:27 +0000 (14:08 +0000)
commit0db131fb835e4c4f6a024e86743467e7e01c965e
tree46301a70ff4b14310b46dd329b1d8679be65fae1
parenta65b5de624a20f37f0fed484d6208d014f10a6f8
AArch64: Set the correct ELF class for AArch64 stubs (PR/25210)

This fixes PR 25210 by specifying the the correct ELF class for AArch64 stubs.
After doing this the stub section starts behaving like a normal object file
loaded from disk.  That is SEC_LINKER_CREATED causes us to have to write the
section manually.

This flag was added as a fix for PR 24753.  I believe that
fix to still be correct as linker created sections don't have a size on disk
and it fixes the Arm bootstrap regression. But in this case specifying the
correct section class also makes the stub section not be considered by
compress.c.

So I'm partially revert this change so that we don't have to manage the section
manually as implied by SEC_LINKER_CREATED.

bfd/ChangeLog:

PR 25210
PR 24753
* elfnn-aarch64.c (_bfd_aarch64_create_stub_section): Set ELF class.

ld/ChangeLog:

PR 25210
PR 24753
* emultempl/aarch64elf.em (elf${ELFSIZE}_aarch64_add_stub_section):
Remove SEC_LINKER_CREATED.
* testsuite/ld-aarch64/aarch64-elf.exp: Add erratum835769-843419.
* testsuite/ld-aarch64/erratum835769-843419.d: New test.
bfd/ChangeLog
bfd/elfnn-aarch64.c
ld/ChangeLog
ld/emultempl/aarch64elf.em
ld/testsuite/ld-aarch64/aarch64-elf.exp
ld/testsuite/ld-aarch64/erratum835769-843419.d [new file with mode: 0644]
This page took 0.02459 seconds and 4 git commands to generate.