[gdb] Fix 'not in executable format' error message
authorTom de Vries <tdevries@suse.de>
Mon, 23 Aug 2021 19:08:51 +0000 (21:08 +0200)
committerTom de Vries <tdevries@suse.de>
Mon, 23 Aug 2021 19:08:51 +0000 (21:08 +0200)
commit2840a1862bc1b86ecd77e65608c0b8d819ed6901
tree927c881d9bfd4d39c8b349926b1807637e1ddf26
parent61bdb9457a8e3f2662bb622a7152df8fac08cdb9
[gdb] Fix 'not in executable format' error message

With trying to load a non-executable file into gdb, we run into PR26880:
...
$ gdb -q -batch test.c
"0x7ffc87bfc8d0s": not in executable format: \
  file format not recognized
...

The problem is caused by using %ps in combination with the error function
(note that confusingly, it does work in combination with the warning
function).

Fix this by using plain "%s" instead.

Tested on x86_64-linux.

gdb/ChangeLog:

2021-08-23  Tom de Vries  <tdevries@suse.de>

PR gdb/26880
* gdb/exec.c (exec_file_attach): Use %s instead of %ps in call to
error function.

gdb/testsuite/ChangeLog:

2021-08-23  Tom de Vries  <tdevries@suse.de>

PR gdb/26880
* gdb.base/non-executable.exp: New file.
gdb/ChangeLog
gdb/exec.c
gdb/testsuite/ChangeLog
gdb/testsuite/gdb.base/non-executable.exp [new file with mode: 0644]
This page took 0.026367 seconds and 4 git commands to generate.