Fix latent bug with custom word point completers
authorPedro Alves <palves@redhat.com>
Wed, 12 Jun 2019 23:06:52 +0000 (00:06 +0100)
committerPedro Alves <palves@redhat.com>
Wed, 12 Jun 2019 23:07:37 +0000 (00:07 +0100)
commit3844e605e61777555aed09ab8ce88db2da95bc0b
tree6efaa3b3e032c0672cdd9d07bf8b0fc122415e1f
parent00b56dbe7016bc33f882525a47faab943fdeda9a
Fix latent bug with custom word point completers

Completion routines that use a custom word point, and that then
recurse into complete_line (e.g., if we make "thread apply" a custom
word point completer, and complete on the command passed as argument),
we stumble on this latent bug:

 (gdb) thread apply all pri[TAB]
 (gdb) thread apply all priprint

The problem is that there's a spot in complete_line_internal_1 that
rewinds the completion word but does not reflect that change in the
custom word point in the tracker.  This patch fixes it.

gdb/ChangeLog:
2019-06-13  Pedro Alves  <palves@redhat.com>

* completer.c (complete_line_internal_1): Rewind completion word
point.
(completion_tracker::advance_custom_word_point_by): Change
parameter type to int.
* completer.h (completion_tracker::advance_custom_word_point_by):
Likewise.
gdb/ChangeLog
gdb/completer.c
gdb/completer.h
This page took 0.025485 seconds and 4 git commands to generate.