Move readline to the readline/readline subdirectory
authorTom Tromey <tom@tromey.com>
Sat, 5 Oct 2019 22:39:44 +0000 (16:39 -0600)
committerTom Tromey <tom@tromey.com>
Wed, 23 Oct 2019 21:16:48 +0000 (15:16 -0600)
commit6999161a2a3b3cbd918570e094199184331d4f81
tree4c20bbd8c1c19e2e7ebcc55d821957e22c4ab9e8
parent12e7c35ec3c09793ed9613cdf696b9f0f4dd86ec
Move readline to the readline/readline subdirectory

readline turns out to be a bit of a stumbling block for the project to
move gdbsupport (and then gdbserver) to the top-level.

The issue is that readline headers are intended to be included with
names like "readline/readline.h".  To support this, gdb effectively
adds a -I option pointing to the top-level source directory -- but,
importantly, this option is not used when the system readline is used.

For gdbsupport, a -I option like this would always be needed, but that
in turn would break the system readline case.  This was PR build/17077,
fixed in commit a8a5dbcab8df0b3a9e04745d4fe8d64740acb323.

Previously, we had discussed this on the gdb-patches list in terms of
removing readline from the tree

    https://sourceware.org/ml/gdb-patches/2019-09/msg00317.html

However, Eli expressed some concerns, and Joel did as well (off-list).

Given those concerns, and the fact that a patch-free local readline is
relatively new in gdb (it was locally patched for years), I changed my
mind and decided to handle this situation by moving the readline
sources down a level.

That is, upstream readline is now in readline/readline, and the
top-level readline directory just contains the minimal configury
needed to build that.

This fixes the problem because, when gdb unconditionally adds a
-I$(top_srcdir), this will not find readline headers.  A separate -I
will be needed instead, which is exactly what's needed for
--with-system-readline.

gdb/ChangeLog
2019-10-23  Tom Tromey  <tom@tromey.com>

* Makefile.in (READLINE_DIR): Update.

gdb/doc/ChangeLog
2019-10-23  Tom Tromey  <tom@tromey.com>

* Makefile.in (READLINE_DIR): Update.

readline/ChangeLog
2019-10-23  Tom Tromey  <tom@tromey.com>

Move old contents to readline/ subdirectory.
* aclocal.m4, configure, configure.ac, .gitignore, Makefile.am,
Makefile.in, README: New files.

Change-Id: Ice156a2ee09ea68722b48f64d97146d7428ea9e4
286 files changed:
gdb/ChangeLog
gdb/Makefile.in
gdb/doc/ChangeLog
gdb/doc/Makefile.in
readline/.gitignore
readline/CHANGELOG [deleted file]
readline/CHANGES [deleted file]
readline/COPYING [deleted file]
readline/ChangeLog [new file with mode: 0644]
readline/ChangeLog.gdb [deleted file]
readline/INSTALL [deleted file]
readline/MANIFEST [deleted file]
readline/Makefile.am [new file with mode: 0644]
readline/Makefile.in
readline/NEWS [deleted file]
readline/README
readline/USAGE [deleted file]
readline/aclocal.m4
readline/ansi_stdlib.h [deleted file]
readline/bind.c [deleted file]
readline/callback.c [deleted file]
readline/chardefs.h [deleted file]
readline/colors.c [deleted file]
readline/colors.h [deleted file]
readline/compat.c [deleted file]
readline/complete.c [deleted file]
readline/config.h.in [deleted file]
readline/configure
readline/configure.ac
readline/cross-build/cygwin.cache [deleted file]
readline/display.c [deleted file]
readline/doc/ChangeLog.gdb [deleted file]
readline/doc/Makefile.in [deleted file]
readline/doc/fdl.texi [deleted file]
readline/doc/history.3 [deleted file]
readline/doc/history.texi [deleted file]
readline/doc/hstech.texi [deleted file]
readline/doc/hsuser.texi [deleted file]
readline/doc/readline.3 [deleted file]
readline/doc/rlman.texi [deleted file]
readline/doc/rltech.texi [deleted file]
readline/doc/rluser.texi [deleted file]
readline/doc/rluserman.texi [deleted file]
readline/doc/texi2dvi [deleted file]
readline/doc/texi2html [deleted file]
readline/doc/version.texi [deleted file]
readline/emacs_keymap.c [deleted file]
readline/examples/ChangeLog.gdb [deleted file]
readline/examples/Inputrc [deleted file]
readline/examples/Makefile.in [deleted file]
readline/examples/autoconf/BASH_CHECK_LIB_TERMCAP [deleted file]
readline/examples/autoconf/RL_LIB_READLINE_VERSION [deleted file]
readline/examples/autoconf/wi_LIB_READLINE [deleted file]
readline/examples/excallback.c [deleted file]
readline/examples/fileman.c [deleted file]
readline/examples/hist_erasedups.c [deleted file]
readline/examples/hist_purgecmd.c [deleted file]
readline/examples/histexamp.c [deleted file]
readline/examples/manexamp.c [deleted file]
readline/examples/readlinebuf.h [deleted file]
readline/examples/rl-callbacktest.c [deleted file]
readline/examples/rl-fgets.c [deleted file]
readline/examples/rl.c [deleted file]
readline/examples/rlbasic.c [deleted file]
readline/examples/rlcat.c [deleted file]
readline/examples/rlevent.c [deleted file]
readline/examples/rlfe/ChangeLog [deleted file]
readline/examples/rlfe/ChangeLog.gdb [deleted file]
readline/examples/rlfe/Makefile.in [deleted file]
readline/examples/rlfe/README [deleted file]
readline/examples/rlfe/config.h.in [deleted file]
readline/examples/rlfe/configure [deleted file]
readline/examples/rlfe/configure.in [deleted file]
readline/examples/rlfe/extern.h [deleted file]
readline/examples/rlfe/os.h [deleted file]
readline/examples/rlfe/pty.c [deleted file]
readline/examples/rlfe/rlfe.c [deleted file]
readline/examples/rlfe/screen.h [deleted file]
readline/examples/rlkeymaps.c [deleted file]
readline/examples/rlptytest.c [deleted file]
readline/examples/rltest.c [deleted file]
readline/examples/rlversion.c [deleted file]
readline/funmap.c [deleted file]
readline/histexpand.c [deleted file]
readline/histfile.c [deleted file]
readline/histlib.h [deleted file]
readline/history.c [deleted file]
readline/history.h [deleted file]
readline/histsearch.c [deleted file]
readline/input.c [deleted file]
readline/isearch.c [deleted file]
readline/keymaps.c [deleted file]
readline/keymaps.h [deleted file]
readline/kill.c [deleted file]
readline/macro.c [deleted file]
readline/mbutil.c [deleted file]
readline/misc.c [deleted file]
readline/nls.c [deleted file]
readline/parens.c [deleted file]
readline/parse-colors.c [deleted file]
readline/parse-colors.h [deleted file]
readline/patchlevel [deleted file]
readline/posixdir.h [deleted file]
readline/posixjmp.h [deleted file]
readline/posixselect.h [deleted file]
readline/posixstat.h [deleted file]
readline/readline.c [deleted file]
readline/readline.h [deleted file]
readline/readline.pc.in [deleted file]
readline/readline/.gitignore [new file with mode: 0644]
readline/readline/CHANGELOG [new file with mode: 0644]
readline/readline/CHANGES [new file with mode: 0644]
readline/readline/COPYING [new file with mode: 0644]
readline/readline/ChangeLog.gdb [new file with mode: 0644]
readline/readline/INSTALL [new file with mode: 0644]
readline/readline/MANIFEST [new file with mode: 0644]
readline/readline/Makefile.in [new file with mode: 0644]
readline/readline/NEWS [new file with mode: 0644]
readline/readline/README [new file with mode: 0644]
readline/readline/USAGE [new file with mode: 0644]
readline/readline/aclocal.m4 [new file with mode: 0644]
readline/readline/ansi_stdlib.h [new file with mode: 0644]
readline/readline/bind.c [new file with mode: 0644]
readline/readline/callback.c [new file with mode: 0644]
readline/readline/chardefs.h [new file with mode: 0644]
readline/readline/colors.c [new file with mode: 0644]
readline/readline/colors.h [new file with mode: 0644]
readline/readline/compat.c [new file with mode: 0644]
readline/readline/complete.c [new file with mode: 0644]
readline/readline/config.h.in [new file with mode: 0644]
readline/readline/configure [new file with mode: 0755]
readline/readline/configure.ac [new file with mode: 0644]
readline/readline/cross-build/cygwin.cache [new file with mode: 0644]
readline/readline/display.c [new file with mode: 0644]
readline/readline/doc/ChangeLog.gdb [new file with mode: 0644]
readline/readline/doc/Makefile.in [new file with mode: 0644]
readline/readline/doc/fdl.texi [new file with mode: 0644]
readline/readline/doc/history.3 [new file with mode: 0644]
readline/readline/doc/history.texi [new file with mode: 0644]
readline/readline/doc/hstech.texi [new file with mode: 0644]
readline/readline/doc/hsuser.texi [new file with mode: 0644]
readline/readline/doc/readline.3 [new file with mode: 0644]
readline/readline/doc/rlman.texi [new file with mode: 0644]
readline/readline/doc/rltech.texi [new file with mode: 0644]
readline/readline/doc/rluser.texi [new file with mode: 0644]
readline/readline/doc/rluserman.texi [new file with mode: 0644]
readline/readline/doc/texi2dvi [new file with mode: 0755]
readline/readline/doc/texi2html [new file with mode: 0755]
readline/readline/doc/version.texi [new file with mode: 0644]
readline/readline/emacs_keymap.c [new file with mode: 0644]
readline/readline/examples/ChangeLog.gdb [new file with mode: 0644]
readline/readline/examples/Inputrc [new file with mode: 0644]
readline/readline/examples/Makefile.in [new file with mode: 0644]
readline/readline/examples/autoconf/BASH_CHECK_LIB_TERMCAP [new file with mode: 0644]
readline/readline/examples/autoconf/RL_LIB_READLINE_VERSION [new file with mode: 0644]
readline/readline/examples/autoconf/wi_LIB_READLINE [new file with mode: 0644]
readline/readline/examples/excallback.c [new file with mode: 0644]
readline/readline/examples/fileman.c [new file with mode: 0644]
readline/readline/examples/hist_erasedups.c [new file with mode: 0644]
readline/readline/examples/hist_purgecmd.c [new file with mode: 0644]
readline/readline/examples/histexamp.c [new file with mode: 0644]
readline/readline/examples/manexamp.c [new file with mode: 0644]
readline/readline/examples/readlinebuf.h [new file with mode: 0644]
readline/readline/examples/rl-callbacktest.c [new file with mode: 0644]
readline/readline/examples/rl-fgets.c [new file with mode: 0644]
readline/readline/examples/rl.c [new file with mode: 0644]
readline/readline/examples/rlbasic.c [new file with mode: 0644]
readline/readline/examples/rlcat.c [new file with mode: 0644]
readline/readline/examples/rlevent.c [new file with mode: 0644]
readline/readline/examples/rlfe/ChangeLog [new file with mode: 0644]
readline/readline/examples/rlfe/ChangeLog.gdb [new file with mode: 0644]
readline/readline/examples/rlfe/Makefile.in [new file with mode: 0644]
readline/readline/examples/rlfe/README [new file with mode: 0644]
readline/readline/examples/rlfe/config.h.in [new file with mode: 0644]
readline/readline/examples/rlfe/configure [new file with mode: 0755]
readline/readline/examples/rlfe/configure.in [new file with mode: 0644]
readline/readline/examples/rlfe/extern.h [new file with mode: 0644]
readline/readline/examples/rlfe/os.h [new file with mode: 0644]
readline/readline/examples/rlfe/pty.c [new file with mode: 0644]
readline/readline/examples/rlfe/rlfe.c [new file with mode: 0644]
readline/readline/examples/rlfe/screen.h [new file with mode: 0644]
readline/readline/examples/rlkeymaps.c [new file with mode: 0644]
readline/readline/examples/rlptytest.c [new file with mode: 0644]
readline/readline/examples/rltest.c [new file with mode: 0644]
readline/readline/examples/rlversion.c [new file with mode: 0644]
readline/readline/funmap.c [new file with mode: 0644]
readline/readline/histexpand.c [new file with mode: 0644]
readline/readline/histfile.c [new file with mode: 0644]
readline/readline/histlib.h [new file with mode: 0644]
readline/readline/history.c [new file with mode: 0644]
readline/readline/history.h [new file with mode: 0644]
readline/readline/histsearch.c [new file with mode: 0644]
readline/readline/input.c [new file with mode: 0644]
readline/readline/isearch.c [new file with mode: 0644]
readline/readline/keymaps.c [new file with mode: 0644]
readline/readline/keymaps.h [new file with mode: 0644]
readline/readline/kill.c [new file with mode: 0644]
readline/readline/macro.c [new file with mode: 0644]
readline/readline/mbutil.c [new file with mode: 0644]
readline/readline/misc.c [new file with mode: 0644]
readline/readline/nls.c [new file with mode: 0644]
readline/readline/parens.c [new file with mode: 0644]
readline/readline/parse-colors.c [new file with mode: 0644]
readline/readline/parse-colors.h [new file with mode: 0644]
readline/readline/patchlevel [new file with mode: 0644]
readline/readline/posixdir.h [new file with mode: 0644]
readline/readline/posixjmp.h [new file with mode: 0644]
readline/readline/posixselect.h [new file with mode: 0644]
readline/readline/posixstat.h [new file with mode: 0644]
readline/readline/readline.c [new file with mode: 0644]
readline/readline/readline.h [new file with mode: 0644]
readline/readline/readline.pc.in [new file with mode: 0644]
readline/readline/rlconf.h [new file with mode: 0644]
readline/readline/rldefs.h [new file with mode: 0644]
readline/readline/rlmbutil.h [new file with mode: 0644]
readline/readline/rlprivate.h [new file with mode: 0644]
readline/readline/rlshell.h [new file with mode: 0644]
readline/readline/rlstdc.h [new file with mode: 0644]
readline/readline/rltty.c [new file with mode: 0644]
readline/readline/rltty.h [new file with mode: 0644]
readline/readline/rltypedefs.h [new file with mode: 0644]
readline/readline/rlwinsize.h [new file with mode: 0644]
readline/readline/savestring.c [new file with mode: 0644]
readline/readline/search.c [new file with mode: 0644]
readline/readline/shell.c [new file with mode: 0644]
readline/readline/shlib/Makefile.in [new file with mode: 0644]
readline/readline/signals.c [new file with mode: 0644]
readline/readline/support/config.guess [new file with mode: 0755]
readline/readline/support/config.rpath [new file with mode: 0755]
readline/readline/support/config.sub [new file with mode: 0755]
readline/readline/support/install.sh [new file with mode: 0755]
readline/readline/support/mkdirs [new file with mode: 0755]
readline/readline/support/mkdist [new file with mode: 0755]
readline/readline/support/mkinstalldirs [new file with mode: 0755]
readline/readline/support/shlib-install [new file with mode: 0755]
readline/readline/support/shobj-conf [new file with mode: 0755]
readline/readline/support/wcwidth.c [new file with mode: 0644]
readline/readline/tcap.h [new file with mode: 0644]
readline/readline/terminal.c [new file with mode: 0644]
readline/readline/text.c [new file with mode: 0644]
readline/readline/tilde.c [new file with mode: 0644]
readline/readline/tilde.h [new file with mode: 0644]
readline/readline/undo.c [new file with mode: 0644]
readline/readline/util.c [new file with mode: 0644]
readline/readline/vi_keymap.c [new file with mode: 0644]
readline/readline/vi_mode.c [new file with mode: 0644]
readline/readline/xfree.c [new file with mode: 0644]
readline/readline/xmalloc.c [new file with mode: 0644]
readline/readline/xmalloc.h [new file with mode: 0644]
readline/rlconf.h [deleted file]
readline/rldefs.h [deleted file]
readline/rlmbutil.h [deleted file]
readline/rlprivate.h [deleted file]
readline/rlshell.h [deleted file]
readline/rlstdc.h [deleted file]
readline/rltty.c [deleted file]
readline/rltty.h [deleted file]
readline/rltypedefs.h [deleted file]
readline/rlwinsize.h [deleted file]
readline/savestring.c [deleted file]
readline/search.c [deleted file]
readline/shell.c [deleted file]
readline/shlib/Makefile.in [deleted file]
readline/signals.c [deleted file]
readline/support/config.guess [deleted file]
readline/support/config.rpath [deleted file]
readline/support/config.sub [deleted file]
readline/support/install.sh [deleted file]
readline/support/mkdirs [deleted file]
readline/support/mkdist [deleted file]
readline/support/mkinstalldirs [deleted file]
readline/support/shlib-install [deleted file]
readline/support/shobj-conf [deleted file]
readline/support/wcwidth.c [deleted file]
readline/tcap.h [deleted file]
readline/terminal.c [deleted file]
readline/text.c [deleted file]
readline/tilde.c [deleted file]
readline/tilde.h [deleted file]
readline/undo.c [deleted file]
readline/util.c [deleted file]
readline/vi_keymap.c [deleted file]
readline/vi_mode.c [deleted file]
readline/xfree.c [deleted file]
readline/xmalloc.c [deleted file]
readline/xmalloc.h [deleted file]
This page took 0.043288 seconds and 4 git commands to generate.