Fix warning on gdb/compile/compile.c (C++-ify "triplet_rx")
authorSergio Durigan Junior <sergiodj@redhat.com>
Tue, 16 Jan 2018 19:41:17 +0000 (14:41 -0500)
committerSergio Durigan Junior <sergiodj@redhat.com>
Wed, 17 Jan 2018 23:05:42 +0000 (18:05 -0500)
commit7d937cad0acdccd0ff485435fbe16f005e994c66
tree340f66ce28771a9797fc001b61ee42a858c8dd77
parente925c834ecdb4a0ce595ad8d3da9c7d4f499ede0
Fix warning on gdb/compile/compile.c (C++-ify "triplet_rx")

This fixes a GCC warning that happens when compiling
gdb/compile/compile.c on some GCC versions (e.g., "gcc (GCC) 7.2.1
20180104 (Red Hat 7.2.1-6)"):

../../gdb/compile/compile.c: In function 'void eval_compile_command(command_line*, const char*, compile_i_scope_types, void*)':
../../gdb/compile/compile.c:548:19: warning: 'triplet_rx' may be used uninitialized in this function [-Wmaybe-uninitialized]
     error_message = compiler->fe->ops->set_arguments_v0 (compiler->fe, triplet_rx,
     ~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
         argc, argv);
         ~~~~~~~~~~~
../../gdb/compile/compile.c:466:9: note: 'triplet_rx' was declared here
   char *triplet_rx;
         ^~~~~~~~~~

It's a simple patch that converts "triplet_rx" from "char *" to
"std::string", thus guaranteeing that it will be always initialized.

I've regtested this patch and did not find any regressions.  OK to
apply on both master and 8.1 (after creating a bug for it)?

gdb/ChangeLog:
2018-01-17  Sergio Durigan Junior  <sergiodj@redhat.com>

* compile/compile.c (compile_to_object): Convert "triplet_rx"
to "std::string".
gdb/ChangeLog
gdb/compile/compile.c
This page took 0.025426 seconds and 4 git commands to generate.