Remove assert on exec_bfd in cris_delayed_get_disassembler
authorYao Qi <yao.qi@linaro.org>
Mon, 12 Dec 2016 09:09:43 +0000 (09:09 +0000)
committerYao Qi <yao.qi@linaro.org>
Mon, 12 Dec 2016 09:09:43 +0000 (09:09 +0000)
commitd36cab83a963f5bb3773e0218cc02f63b0851d0b
tree9b58509f75e45f551aba1180a78c8d5250d142e8
parent029e9d52de3ac7fe984dc079ebd24506fd1eace7
Remove assert on exec_bfd in cris_delayed_get_disassembler

cris_delayed_get_disassembler has an assert that exec_bfd can't be
NULL, but this assert can be triggered like this,

(gdb) set architecture cris
The target architecture is assumed to be cris
(gdb) disassemble 0x0,+4
Dump of assembler code from 0x0 to 0x4:
   0x00000000:
../../binutils-gdb/gdb/cris-tdep.c:3798: internal-error: int cris_delayed_get_disassembler(bfd_vma, disassemble_info*): Assertion `exec_bfd != NULL' failed.
A problem internal to GDB has been detected,
further debugging may prove unreliable.

however, cris_get_disassembler does have code to handle the case that
bfd is NULL,

  /* If there's no bfd in sight, we return what is valid as input in all
     contexts if fed back to the assembler: disassembly *with* register
     prefix.  Unfortunately this will be totally wrong for v32.  */
  if (abfd == NULL)
    return print_insn_cris_with_register_prefix;

This patch is to remove this assert.

gdb:

2016-12-12  Yao Qi  <yao.qi@linaro.org>

PR tdep/20955
* cris-tdep.c (cris_delayed_get_disassembler): Remove the
assert.
gdb/ChangeLog
gdb/cris-tdep.c
This page took 0.024585 seconds and 4 git commands to generate.