From c6cbf900d42cf8f2ebbcf33d799c52c54b9aa9f0 Mon Sep 17 00:00:00 2001 From: Tom Tromey Date: Thu, 5 Dec 2019 08:11:31 -0700 Subject: [PATCH] Silence ARI warning about floatformat_to_double This silences ARI at the one spot that is permitted to call floatformat_to_double, and also removes the corresponding "fix" call from gdb_ari.sh -- it was incorrect, and now is not needed. gdb/ChangeLog 2019-12-13 Tom Tromey * contrib/ari/gdb_ari.sh: Remove "fix" call for floatformat_to_double. * target-float.c (host_float_ops::from_target): Add ARI comment. Change-Id: I778a17a04da417c113194004dd7de3b1df381266 --- gdb/ChangeLog | 7 +++++++ gdb/contrib/ari/gdb_ari.sh | 1 - gdb/target-float.c | 4 ++-- 3 files changed, 9 insertions(+), 3 deletions(-) diff --git a/gdb/ChangeLog b/gdb/ChangeLog index 44bb65ffcc..d107b6cea7 100644 --- a/gdb/ChangeLog +++ b/gdb/ChangeLog @@ -1,3 +1,10 @@ +2019-12-13 Tom Tromey + + * contrib/ari/gdb_ari.sh: Remove "fix" call for + floatformat_to_double. + * target-float.c (host_float_ops::from_target): Add ARI + comment. + 2019-12-13 Tom Tromey * contrib/ari/gdb_ari.sh: Remove "fix" call for abort. diff --git a/gdb/contrib/ari/gdb_ari.sh b/gdb/contrib/ari/gdb_ari.sh index 300ed761f1..9a5b941d23 100755 --- a/gdb/contrib/ari/gdb_ari.sh +++ b/gdb/contrib/ari/gdb_ari.sh @@ -810,7 +810,6 @@ get_frame_locals_address, or get_frame_args_address." BEGIN { doc["floatformat_to_double"] = "\ Do not use floatformat_to_double() from libierty, \ instead use floatformat_to_doublest()" - fix("floatformat_to_double", "gdb/doublest.c", 1) category["floatformat_to_double"] = ari_regression } /(^|[^_[:alnum:]])floatformat_to_double[[:space:]]*\(/ { diff --git a/gdb/target-float.c b/gdb/target-float.c index caa6943395..ddf20c8906 100644 --- a/gdb/target-float.c +++ b/gdb/target-float.c @@ -647,8 +647,8 @@ host_float_ops::from_target (const struct floatformat *fmt, { double dto; - floatformat_to_double (fmt->split_half ? fmt->split_half : fmt, - from, &dto); + floatformat_to_double /* ARI: floatformat_to_double */ + (fmt->split_half ? fmt->split_half : fmt, from, &dto); *to = (T) dto; return; } -- 2.34.1