net: mvneta: bm: clarify dependencies
authorArnd Bergmann <arnd@arndb.de>
Tue, 15 Mar 2016 21:47:14 +0000 (22:47 +0100)
committerDavid S. Miller <davem@davemloft.net>
Fri, 18 Mar 2016 23:36:48 +0000 (19:36 -0400)
commit019ded3aa7c9799fbe6533baeac9aafc7063bd39
tree7884ee1a41450c3831ebed60cae62a80d3e9283f
parent3a461da1d03e7a857edfa6a002040d07e118c639
net: mvneta: bm: clarify dependencies

MVNETA_BM has a dependency on MVNETA, so we can only select the former
if the latter is enabled. However, the code dependency is the reverse:
The mvneta module can call into the mvneta_bm module, so mvneta cannot
be a built-in if mvneta_bm is a module, or we get a link error:

drivers/net/built-in.o: In function `mvneta_remove':
drivers/net/ethernet/marvell/mvneta.c:4211: undefined reference to `mvneta_bm_pool_destroy'
drivers/net/built-in.o: In function `mvneta_bm_update_mtu':
drivers/net/ethernet/marvell/mvneta.c:1034: undefined reference to `mvneta_bm_bufs_free'

This avoids the problem by further clarifying the dependency so that
MVNETA_BM is a silent Kconfig option that gets turned on by the
new MVNETA_BM_ENABLE option. This way both the core HWBM module and
the MVNETA_BM code are always built-in when needed.

Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Fixes: dc35a10f68d3 ("net: mvneta: bm: add support for hardware buffer management")
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/marvell/Kconfig
This page took 0.024838 seconds and 5 git commands to generate.