video: ARM CLCD: fix endpoint lookup logic
authorArnd Bergmann <arnd@arndb.de>
Fri, 26 Aug 2016 15:25:43 +0000 (17:25 +0200)
committerTomi Valkeinen <tomi.valkeinen@ti.com>
Tue, 30 Aug 2016 08:31:22 +0000 (11:31 +0300)
commit1121a418b2083038e9981ab9e2401db9fb8fdd7e
tree0a94bd58c9fa72aee225a62ba50e6d09adadcb46
parente0299908d606a99e7ffb467bc3c11dfe54133af3
video: ARM CLCD: fix endpoint lookup logic

The addition of the Nomadik support in this driver introduced
a bug in clcdfb_of_init_display(), which now calls init_panel
with an uninitialized 'endpoint' pointer, as "gcc -Wmaybe-uninitialized"
warns:

drivers/video/fbdev/amba-clcd.c: In function 'clcdfb_of_init_display':
drivers/video/fbdev/amba-clcd.c:785:5: error: 'endpoint' may be used uninitialized in this function [-Werror=maybe-uninitialized]

This reverts the broken part of the function to what it was before
the patch, which is the best guess I have to what it should be.
I assume this was left over from an attempted rework of the
code that was partially backed out.

Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Fixes: 046ad6cdeb3f ("video: ARM CLCD: support Nomadik variant")
Cc: Linus Walleij <linus.walleij@linaro.org>
Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
Reported-by: Colin Ian King <colin.king@canonical.com>
Signed-off-by: Tomi Valkeinen <tomi.valkeinen@ti.com>
drivers/video/fbdev/amba-clcd.c
This page took 0.027582 seconds and 5 git commands to generate.