i40e/i40evf: Limit TSO to 7 descriptors for payload instead of 8 per packet
authorAlexander Duyck <aduyck@mirantis.com>
Wed, 30 Mar 2016 23:15:37 +0000 (16:15 -0700)
committerJeff Kirsher <jeffrey.t.kirsher@intel.com>
Thu, 14 Apr 2016 02:59:23 +0000 (19:59 -0700)
commit3f3f7cb875c0f621485644d4fd7453b0d37f00e4
tree64d4eca1728ae968d25225d983f4b639c2048699
parenta6d37131c02f15463daa00e2f1da6824e8e00de2
i40e/i40evf: Limit TSO to 7 descriptors for payload instead of 8 per packet

This patch addresses a bug introduced based on my interpretation of the
XL710 datasheet.  Specifically section 8.4.1 states that "A single transmit
packet may span up to 8 buffers (up to 8 data descriptors per packet
including both the header and payload buffers)."  It then later goes on to
say that each segment for a TSO obeys the previous rule, however it then
refers to TSO header and the segment payload buffers.

I believe the actual limit for fragments with TSO and a skbuff that has
payload data in the header portion of the buffer is actually only 7
fragments as the skb->data portion counts as 2 buffers, one for the TSO
header, and one for a segment payload buffer.

Fixes: 2d37490b82af ("i40e/i40evf: Rewrite logic for 8 descriptor per packet check")
Reported-by: Sowmini Varadhan <sowmini.varadhan@oracle.com>
Signed-off-by: Alexander Duyck <aduyck@mirantis.com>
Acked-by: Jesse Brandeburg <jesse.brandeburg@intel.com>
Tested-by: Sowmini Varadhan <sowmini.varadhan@oracle.com>
Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
drivers/net/ethernet/intel/i40e/i40e_txrx.c
drivers/net/ethernet/intel/i40e/i40e_txrx.h
drivers/net/ethernet/intel/i40evf/i40e_txrx.c
drivers/net/ethernet/intel/i40evf/i40e_txrx.h
This page took 0.027884 seconds and 5 git commands to generate.