sched/deadline: Always calculate end of period on sched_yield()
authorPeter Zijlstra <peterz@infradead.org>
Tue, 23 Feb 2016 12:28:22 +0000 (13:28 +0100)
committerIngo Molnar <mingo@kernel.org>
Mon, 29 Feb 2016 08:41:51 +0000 (09:41 +0100)
commit48be3a67da7413d62e5efbcf2c73a9dddf61fb96
treec1ab0dc2ddaa29ab337a0ae79e857ab2e1129955
parent6fe1f348b3dd1f700f9630562b7d38afd6949568
sched/deadline: Always calculate end of period on sched_yield()

Steven noticed that occasionally a sched_yield() call would not result
in a wait for the next period edge as expected.

It turns out that when we call update_curr_dl() and end up with
delta_exec <= 0, we will bail early and fail to throttle.

Further inspection of the yield code revealed that yield_task_dl()
clearing dl.runtime is wrong too, it will not account the last bit of
runtime which could result in dl.runtime < 0, which in turn means that
replenish would gift us with too much runtime.

Fix both issues by not relying on the dl.runtime value for yield.

Reported-by: Steven Rostedt <rostedt@goodmis.org>
Tested-by: Steven Rostedt <rostedt@goodmis.org>
Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Cc: Clark Williams <williams@redhat.com>
Cc: Daniel Bristot de Oliveira <bristot@redhat.com>
Cc: John Kacur <jkacur@redhat.com>
Cc: Juri Lelli <juri.lelli@gmail.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Thomas Gleixner <tglx@linutronix.de>
Link: http://lkml.kernel.org/r/20160223122822.GP6357@twins.programming.kicks-ass.net
Signed-off-by: Ingo Molnar <mingo@kernel.org>
kernel/sched/deadline.c
This page took 0.024425 seconds and 5 git commands to generate.