sparc64: fix incorrect sign extension in sys_sparc64_personality
authorDmitry V. Levin <ldv@altlinux.org>
Sat, 26 Dec 2015 23:13:27 +0000 (02:13 +0300)
committerDavid S. Miller <davem@davemloft.net>
Thu, 14 Jan 2016 18:06:09 +0000 (13:06 -0500)
commit525fd5a94e1be0776fa652df5c687697db508c91
tree11abdf7711fb6e14cc54f546762ef0754bd9933d
parent7fdec82af6a9e190e53d07a1463d2a9ac49a8750
sparc64: fix incorrect sign extension in sys_sparc64_personality

The value returned by sys_personality has type "long int".
It is saved to a variable of type "int", which is not a problem
yet because the type of task_struct->pesonality is "unsigned int".
The problem is the sign extension from "int" to "long int"
that happens on return from sys_sparc64_personality.

For example, a userspace call personality((unsigned) -EINVAL) will
result to any subsequent personality call, including absolutely
harmless read-only personality(0xffffffff) call, failing with
errno set to EINVAL.

Signed-off-by: Dmitry V. Levin <ldv@altlinux.org>
Cc: <stable@vger.kernel.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
arch/sparc/kernel/sys_sparc_64.c
This page took 0.02371 seconds and 5 git commands to generate.