usb: musb/ux500: remove duplicate check for dma_is_compatible
authorArnd Bergmann <arnd@arndb.de>
Thu, 28 Jan 2016 16:23:15 +0000 (17:23 +0100)
committerFelipe Balbi <balbi@kernel.org>
Fri, 4 Mar 2016 13:14:30 +0000 (15:14 +0200)
commit62a6abdd427b5fc4d8aad5dac874904e96273e6d
tree962ce540183163b5f329423a803873378c97dbee
parent3ec08ddf13d50ad188ac5122d74284df67beb02e
usb: musb/ux500: remove duplicate check for dma_is_compatible

When dma_addr_t is 64-bit, we get a warning about an invalid cast
in the call to ux500_dma_is_compatible() from ux500_dma_channel_program():

drivers/usb/musb/ux500_dma.c: In function 'ux500_dma_channel_program':
drivers/usb/musb/ux500_dma.c:210:51: error: cast to pointer from integer of different size [-Werror=int-to-pointer-cast]
  if (!ux500_dma_is_compatible(channel, packet_sz, (void *)dma_addr, len))

The problem is that ux500_dma_is_compatible() is called from the
main musb driver on the virtual address, but here we pass in a
DMA address, so the types are fundamentally different but it works
because the function only checks the alignment of the buffer and
that is the same.

We could work around this by adding another cast, but I have checked
that the buffer we get passed here is already checked before it
gets mapped, so the second check seems completely unnecessary
and removing it must be the cleanest solution.

Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Signed-off-by: Felipe Balbi <balbi@kernel.org>
drivers/usb/musb/ux500_dma.c
This page took 0.026285 seconds and 5 git commands to generate.