irqchip/mips-gic: Cleanup chip and handler setup
authorPaul Burton <paul.burton@imgtec.com>
Fri, 19 Aug 2016 17:07:14 +0000 (18:07 +0100)
committerThomas Gleixner <tglx@linutronix.de>
Mon, 22 Aug 2016 16:37:51 +0000 (18:37 +0200)
commit6a33fa2b87513fee44cb8f0cd17b1acd6316bc6b
tree18dc3a7448a3db01cd41025bab34ce0317307c55
parent3ee0ce2a54dff07d09440723594df89bc1a12e79
irqchip/mips-gic: Cleanup chip and handler setup

gic_shared_irq_domain_map() is called from gic_irq_domain_alloc() where
the wrong chip has been set, and is then overwritten. Tidy this up by
setting the correct chip the first time, and setting the
handle_level_irq handler from gic_irq_domain_alloc() too.

gic_shared_irq_domain_map() is also called from gic_irq_domain_map(),
which now calls irq_set_chip_and_handler() to retain its previous
behaviour.

This patch prepares for a follow-on which will call
gic_shared_irq_domain_map() from a callback where the lock on the struct
irq_desc is held, which without this change would cause the call to
irq_set_chip_and_handler() to lead to a deadlock.

Fixes: c98c1822ee13 ("irqchip/mips-gic: Add device hierarchy domain")
Signed-off-by: Paul Burton <paul.burton@imgtec.com>
Cc: linux-mips@linux-mips.org
Cc: Jason Cooper <jason@lakedaemon.net>
Cc: Marc Zyngier <marc.zyngier@arm.com>
Cc: stable@vger.kernel.org
Link: http://lkml.kernel.org/r/20160819170715.27820-1-paul.burton@imgtec.com
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
drivers/irqchip/irq-mips-gic.c
This page took 0.024651 seconds and 5 git commands to generate.