ipv4: Fix ip_queue_xmit to pass sk into ip_local_out_sk
authorEric W. Biederman <ebiederm@xmission.com>
Wed, 7 Oct 2015 21:48:33 +0000 (16:48 -0500)
committerDavid S. Miller <davem@davemloft.net>
Thu, 8 Oct 2015 11:26:52 +0000 (04:26 -0700)
commit850dcc4d4dd7d5da5c1b2a780c5e649c3b649545
tree623983d4d59ea7de05c200006e112e2640d4fb2c
parentfd2874b3bbe832e90ac480971a7a8bd736b629b9
ipv4: Fix ip_queue_xmit to pass sk into ip_local_out_sk

After a packet has been encapsulated by a tunnel we should use the
tunnel sockets local multicast loopback flag to control if the
encapsulated packet should be locally loopback back.

Pass sk into ip_local_out_sk so that in the rare case we are dealing
with a tunneled packet whose tunnel destination address is a multicast
address the kernel properly decides to loopback this packet.

In practice I don't think this matters as ip_queue_xmit is used by
tcp, l2tp and sctp none of which I am aware of uses ip level
multicasting as they are all point to point communications protocols.
Let's fix this before someone uses ip_queue_xmit for a tunnel protocol
that does use multicast.

Fixes: aad88724c9d5 ("ipv4: add a sock pointer to dst->output() path.")
Fixes: b0270e91014d ("ipv4: add a sock pointer to ip_queue_xmit()")
Signed-off-by: "Eric W. Biederman" <ebiederm@xmission.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/ipv4/ip_output.c
This page took 0.024835 seconds and 5 git commands to generate.