RDS-TCP: Recover correctly from pskb_pull()/pksb_trim() failure in rds_tcp_data_recv
authorSowmini Varadhan <sowmini.varadhan@oracle.com>
Mon, 26 Oct 2015 16:46:37 +0000 (12:46 -0400)
committerDavid S. Miller <davem@davemloft.net>
Wed, 28 Oct 2015 02:46:34 +0000 (19:46 -0700)
commit8ce675ff39b9958d1c10f86cf58e357efaafc856
tree6c8a9da5a3659ea06537c0b49a84620168985fc6
parent0b7c874348ea14ec3c358fe95e56d6f830540248
RDS-TCP: Recover correctly from pskb_pull()/pksb_trim() failure in rds_tcp_data_recv

Either of pskb_pull() or pskb_trim() may fail under low memory conditions.
If rds_tcp_data_recv() ignores such failures, the application will
receive corrupted data because the skb has not been correctly
carved to the RDS datagram size.

Avoid this by handling pskb_pull/pskb_trim failure in the same
manner as the skb_clone failure: bail out of rds_tcp_data_recv(), and
retry via the deferred call to rds_send_worker() that gets set up on
ENOMEM from rds_tcp_read_sock()

Signed-off-by: Sowmini Varadhan <sowmini.varadhan@oracle.com>
Acked-by: Santosh Shilimkar <santosh.shilimkar@oracle.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/rds/tcp_recv.c
This page took 0.024008 seconds and 5 git commands to generate.