ALSA: pcm: Bail out when chmap is already present
authorTakashi Iwai <tiwai@suse.de>
Tue, 10 May 2016 14:07:40 +0000 (16:07 +0200)
committerTakashi Iwai <tiwai@suse.de>
Tue, 10 May 2016 15:05:16 +0000 (17:05 +0200)
commit8d879be882ba5a8bd4c2bc39bd2c336392564e13
tree14d5315cd45c1cc60fa04cc8435cadaec5f25d9a
parent62f00e40b0718ebd8bd54fc7a9e89e873524d495
ALSA: pcm: Bail out when chmap is already present

When snd_pcm_add_chmap_ctls() is called to the PCM stream to which a
chmap has been already assigned, it returns as an error due to the
conflicting snd_ctl_add() result.  However, this also clears the
already assigned chmap_kctl field via pcm_chmap_ctl_private_free(),
and becomes inconsistent in the later operation.

This patch adds the check of the conflicting chmap kctl before
actually trying to allocate / assign.  The check failure is treated as
a kernel warning, as the double call of snd_pcm_add_chmap_ctls() is
basically a driver bug and having the stack trace would help
developers to figure out the bad code path.

Signed-off-by: Takashi Iwai <tiwai@suse.de>
sound/core/pcm_lib.c
This page took 0.025455 seconds and 5 git commands to generate.