mfd: 88pm80x: Double shifting bug in suspend/resume
authorDan Carpenter <dan.carpenter@oracle.com>
Thu, 4 Aug 2016 05:26:56 +0000 (08:26 +0300)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sun, 16 Oct 2016 16:03:38 +0000 (18:03 +0200)
commitceeddeea91552a88740212224df7f425a0e9f1f6
tree53ad725a51a1e631ca98bb6e55b5f423203579de
parent0187dcdecf86887b011a3a0fce23b48e049b7ece
mfd: 88pm80x: Double shifting bug in suspend/resume

commit 9a6dc644512fd083400a96ac4a035ac154fe6b8d upstream.

set_bit() and clear_bit() take the bit number so this code is really
doing "1 << (1 << irq)" which is a double shift bug.  It's done
consistently so it won't cause a problem unless "irq" is more than 4.

Fixes: 70c6cce04066 ('mfd: Support 88pm80x in 80x driver')
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Lee Jones <lee.jones@linaro.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
include/linux/mfd/88pm80x.h
This page took 0.025972 seconds and 5 git commands to generate.