net: dsa: bcm_sf2: Do not override speed settings
authorFlorian Fainelli <f.fainelli@gmail.com>
Tue, 21 Jul 2015 00:49:55 +0000 (17:49 -0700)
committerDavid S. Miller <davem@davemloft.net>
Tue, 21 Jul 2015 23:12:55 +0000 (16:12 -0700)
commitd2eac98f7d1b950b762a7eca05a9ce0ea1d878d2
tree133fcf20ed36c541c7b7cd021b4ac91a85b7d6fc
parente181a5430491f038c198f0eacc3142d6e871c2da
net: dsa: bcm_sf2: Do not override speed settings

The SF2 driver currently overrides speed settings for its port
configured using a fixed PHY, this is both unnecessary and incorrect,
because we keep feedback to the hardware parameters that we read from
the PHY device, which in the case of a fixed PHY cannot possibly change
speed.

This is a required change to allow the fixed PHY code to allow
registering a PHY with a link configured as DOWN by default and avoid
some sort of circular dependency where we require the link_update
callback to run to program the hardware, and we then utilize the fixed
PHY parameters to program the hardware with the same settings.

Fixes: 246d7f773c13 ("net: dsa: add Broadcom SF2 switch driver")
Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/dsa/bcm_sf2.c
This page took 0.024289 seconds and 5 git commands to generate.