[media] v4l: vsp1: Fix crash when resetting pipeline
authorLaurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
Wed, 18 May 2016 23:01:21 +0000 (20:01 -0300)
committerMauro Carvalho Chehab <mchehab@s-opensource.com>
Tue, 28 Jun 2016 14:59:43 +0000 (11:59 -0300)
commitd69e40fade97b6b19837c1772efa516bc28cc870
tree7e2dd33b0069729777f245f0bd782203676f58bc
parent398e3d4f1e0baecb926315673a6740f2573b07ae
[media] v4l: vsp1: Fix crash when resetting pipeline

The vsp1_pipeline_reset() function loops over pipeline inputs and output
and resets them. When doing so it assumes both that the pipeline has
been correctly configured with an output, and that inputs are are stored
in the pipe inputs array at positions 0 to num_inputs-1.

Both the assumptions are incorrect. The pipeline might need to be reset
after a failed attempts to configure it, without any output specified.
Furthermore, inputs are stored in a positiong equal to their RPF index,
possibly creating holes in the inputs array if the RPFs are not used in
sequence.

Fix both issues by looping over the whole inputs array and skipping
unused entries, and ignoring the output when not set.

Fixes: ff7e97c94d9f ("[media] v4l: vsp1: Store pipeline pointer in rwpf")
Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@s-opensource.com>
drivers/media/platform/vsp1/vsp1_pipe.c
This page took 0.02513 seconds and 5 git commands to generate.