KVM: arm64: vgic-its: Make updates to propbaser/pendbaser atomic
authorChristoffer Dall <christoffer.dall@linaro.org>
Wed, 3 Aug 2016 16:03:44 +0000 (18:03 +0200)
committerChristoffer Dall <christoffer.dall@linaro.org>
Mon, 15 Aug 2016 21:00:20 +0000 (23:00 +0200)
commitd9ae449b3d14d7c55f69af329972f175d180e68d
treec9b04b65130b96654d275cb550568748a4087f08
parent2cccbb368a2bf27d98cf36bb424fbbf5572c0fab
KVM: arm64: vgic-its: Make updates to propbaser/pendbaser atomic

There are two problems with the current implementation of the MMIO
handlers for the propbaser and pendbaser:

First, the write to the value itself is not guaranteed to be an atomic
64-bit write so two concurrent writes to the structure field could be
intermixed.

Second, because we do a read-modify-update operation without any
synchronization, if we have two 32-bit accesses to separate parts of the
register, we can loose one of them.

By using the atomic cmpxchg64 we should cover both issues above.

Reviewed-by: Andre Przywara <andre.przywara@arm.com>
Signed-off-by: Christoffer Dall <christoffer.dall@linaro.org>
virt/kvm/arm/vgic/vgic-mmio-v3.c
This page took 0.024486 seconds and 5 git commands to generate.