ASoC: cs35l32: avoid uninitialized variable access
authorArnd Bergmann <arnd@arndb.de>
Mon, 14 Mar 2016 14:49:54 +0000 (15:49 +0100)
committerMark Brown <broonie@kernel.org>
Tue, 15 Mar 2016 09:23:35 +0000 (09:23 +0000)
commitdd5dc001581a7cf6f563e188c302caae1be998c2
treea2352a4b9c8a047336eaa3280ab9a4a56bae4285
parentd4a6360f19c1c551afcba42be98df04651fab31b
ASoC: cs35l32: avoid uninitialized variable access

gcc warns about the possibilty of accessing a property read from
devicetree in cs35l32_i2c_probe() when it has not been initialized
because CONFIG_OF is disabled:

sound/soc/codecs/cs35l32.c: In function 'cs35l32_i2c_probe':
sound/soc/codecs/cs35l32.c:278:2: warning: 'val' may be used uninitialized in this function [-Wmaybe-uninitialized]

The code is actually correct because it checks the dev->of_node
variable first and we know this is NULL here when CONFIG_OF
is disabled, but Russell King noticed that it's broken when
we probe the device using DT, and the properties are absent.

The code already has some checking for incorrect values, and
I keep that checking unchanged here, but add an additional
check for an error returned by the property accessor functions
that now gets handled the same way as incorrect data in the
properties.

Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Acked-by: Brian Austin <brian.austin@cirrus.com>
Signed-off-by: Mark Brown <broonie@kernel.org>
sound/soc/codecs/cs35l32.c
This page took 0.026598 seconds and 5 git commands to generate.