arm64: entry: remove pointless SPSR mode check
authorMark Rutland <mark.rutland@arm.com>
Tue, 5 Jan 2016 17:33:34 +0000 (17:33 +0000)
committerWill Deacon <will.deacon@arm.com>
Wed, 6 Jan 2016 15:40:38 +0000 (15:40 +0000)
commitee03353bc04f8e460cc4e3da80d9721d9ecb89f1
tree7079b34f326357afdc3aff8af868f327684ac31f
parent39b5be9b4233a9f212b98242bddf008f379b5122
arm64: entry: remove pointless SPSR mode check

In work_pending, we may skip work if the stacked SPSR value represents
anything other than an EL0 context. We then immediately invoke the
kernel_exit 0 macro as part of ret_to_user, assuming a return to EL0.
This is somewhat confusing.

We use work_pending as part of the ret_to_user/ret_fast_syscall state
machine. We only use ret_fast_syscall in the return from an SVC issued
from EL0. We use ret_to_user for return from EL0 exception handlers and
also for return from ret_from_fork in the case the task was not a kernel
thread (i.e. it is a user task).

Thus in all cases the stacked SPSR value must represent an EL0 context,
and the check is redundant. This patch removes it, along with the now
unused no_work_pending label.

Cc: Chris Metcalf <cmetcalf@ezchip.com>
Acked-by: Catalin Marinas <catalin.marinas@arm.com>
Signed-off-by: Mark Rutland <mark.rutland@arm.com>
Signed-off-by: Will Deacon <will.deacon@arm.com>
arch/arm64/kernel/entry.S
This page took 0.02619 seconds and 5 git commands to generate.