vmxnet3: fix lock imbalance in vmxnet3_tq_xmit()
authorArnd Bergmann <arnd@arndb.de>
Mon, 14 Mar 2016 14:53:57 +0000 (15:53 +0100)
committerDavid S. Miller <davem@davemloft.net>
Mon, 14 Mar 2016 17:10:29 +0000 (13:10 -0400)
commitefc21d95067f658a20e51e24c4c86d68f23b7f7f
tree67836a34b5fd852007bfc3b0315e99ca767bc864
parent888506a967fe428bd776d2b9f540393963fc5bdd
vmxnet3: fix lock imbalance in vmxnet3_tq_xmit()

A recent bug fix rearranged the code in vmxnet3_tq_xmit() in a
way that left the error handling for oversized headers unlock
a lock that had not been taken yet. Gcc warns about the incorrect
use of the 'flags' variable because of that:

drivers/net/vmxnet3/vmxnet3_drv.c: In function 'vmxnet3_tq_xmit.constprop':
include/linux/spinlock.h:246:3: error: 'flags' may be used uninitialized in this function [-Werror=maybe-uninitialized]

This changes the error handling path to 'goto' the end of the function
beyond the lock/unlock pair.

Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Fixes: cec05562fb1d ("vmxnet3: avoid calling pskb_may_pull with interrupts disabled")
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/vmxnet3/vmxnet3_drv.c
This page took 0.025632 seconds and 5 git commands to generate.