video: ARM CLCD: export symbols for driver module
authorArnd Bergmann <arnd@arndb.de>
Fri, 26 Aug 2016 15:34:29 +0000 (17:34 +0200)
committerTomi Valkeinen <tomi.valkeinen@ti.com>
Tue, 30 Aug 2016 08:54:23 +0000 (11:54 +0300)
commitffe439d644d387c460f2e0a8e80d3ff8a05ee532
treee73647cdc6764e236323892edeef3bf2e86b6466
parent9986908d38736ad6fde46c9b8f651d6c82da07b9
video: ARM CLCD: export symbols for driver module

The amba-clcd-versatile.c code is always built-in and has to
be done that way because it gets called by platform code that is
also built-in. However, it now also gets called from the
core CLCD driver through the .init_panel callback function,
which leads to a build error when the framebuffer is configured
as a loadable module:

ERROR: "versatile_clcd_init_panel" [drivers/video/fbdev/amba-clcd-mod.ko] undefined!

The same thing happens for the nomadik driver, although that
could be linked into the core module if we want to:

ERROR: "nomadik_clcd_init_panel" [drivers/video/fbdev/amba-clcd.ko] undefined!
ERROR: "nomadik_clcd_init_board" [drivers/video/fbdev/amba-clcd.ko] undefined!

For consistency, I'm taking the same approach in both cases here
and just export the functions to make them usable by the driver.

Alternatively, we could split out the CONFIG_OF-code from amba-clcd-versatile.c
into a new file and link those two together with the core driver as one
module.

Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Fixes: 1d3f0cbe0d3a ("video: ARM CLCD: add special board and panel hooks for Nomadik")
Fixes: 25348160e9a4 ("video: ARM CLCD: add special panel hook for Versatiles")
Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
Signed-off-by: Tomi Valkeinen <tomi.valkeinen@ti.com>
drivers/video/fbdev/amba-clcd-nomadik.c
drivers/video/fbdev/amba-clcd-versatile.c
This page took 0.027559 seconds and 5 git commands to generate.