[media] tuner.h: rename TUNER_PAD_IF_OUTPUT to TUNER_PAD_OUTPUT

The output of a tuner is not only IF frequencies. They may also
output audio on some of its pins, and may even be a zero-IF tuner,
with outputs a baseband. So, rename the PAD name to make it
clearer and add a proper documentation about that at tuner.h.

No functional changes.

Signed-off-by: Mauro Carvalho Chehab <mchehab@osg.samsung.com>

diff --git a/drivers/media/dvb-core/dvbdev.c b/drivers/media/dvb-core/dvbdev.c
index 560450a0b32a5b2399196aa2a9a8d0ff161534e9..a7de62ebc4157e8651ea0d8febc21b31b6e97368 100644 (file)
--- a/drivers/media/dvb-core/dvbdev.c
+++ b/drivers/media/dvb-core/dvbdev.c
@@ -661,7 +661,7 @@ int dvb_create_media_graph(struct dvb_adapter *adap,
        if (ntuner && ndemod) {
                ret = media_create_pad_links(mdev,
                                             MEDIA_ENT_F_TUNER,
-                                            tuner, TUNER_PAD_IF_OUTPUT,
+                                            tuner, TUNER_PAD_OUTPUT,
                                             MEDIA_ENT_F_DTV_DEMOD,
                                             demod, 0, MEDIA_LNK_FL_ENABLED,
                                             false);

diff --git a/drivers/media/usb/au0828/au0828-core.c b/drivers/media/usb/au0828/au0828-core.c
index 9e29e70a78d7b20f8b250cbde914c2a589a82052..df2bc3f732b697b359ef4574bd7db1e9f297bd1f 100644 (file)
--- a/drivers/media/usb/au0828/au0828-core.c
+++ b/drivers/media/usb/au0828/au0828-core.c
@@ -276,7 +276,7 @@ static int au0828_create_media_graph(struct au0828_dev *dev)
                return -EINVAL;
 
        if (tuner) {
-               ret = media_create_pad_link(tuner, TUNER_PAD_IF_OUTPUT,
+               ret = media_create_pad_link(tuner, TUNER_PAD_OUTPUT,
                                            decoder, 0,
                                            MEDIA_LNK_FL_ENABLED);
                if (ret)

diff --git a/drivers/media/usb/cx231xx/cx231xx-cards.c b/drivers/media/usb/cx231xx/cx231xx-cards.c
index 620b83d03f75a1c6952f4982d2a85c53fe0e54aa..54e43fe13e6d35da096e2b0faf08be166cc404b8 100644 (file)
--- a/drivers/media/usb/cx231xx/cx231xx-cards.c
+++ b/drivers/media/usb/cx231xx/cx231xx-cards.c
@@ -1259,7 +1259,7 @@ static int cx231xx_create_media_graph(struct cx231xx *dev)
                return 0;
 
        if (tuner) {
-               ret = media_create_pad_link(tuner, TUNER_PAD_IF_OUTPUT, decoder, 0,
+               ret = media_create_pad_link(tuner, TUNER_PAD_OUTPUT, decoder, 0,
                                            MEDIA_LNK_FL_ENABLED);
                if (ret < 0)
                        return ret;

diff --git a/drivers/media/usb/dvb-usb-v2/mxl111sf.c b/drivers/media/usb/dvb-usb-v2/mxl111sf.c
index b669deccc34c64065e801ee29a68d85b05c8dedc..e7978e4e40ea45c663f6207e37e99045a25cc9ce 100644 (file)
--- a/drivers/media/usb/dvb-usb-v2/mxl111sf.c
+++ b/drivers/media/usb/dvb-usb-v2/mxl111sf.c
@@ -888,7 +888,7 @@ static int mxl111sf_attach_tuner(struct dvb_usb_adapter *adap)
        state->tuner.function = MEDIA_ENT_F_TUNER;
        state->tuner.name = "mxl111sf tuner";
        state->tuner_pads[TUNER_PAD_RF_INPUT].flags = MEDIA_PAD_FL_SINK;
-       state->tuner_pads[TUNER_PAD_IF_OUTPUT].flags = MEDIA_PAD_FL_SOURCE;
+       state->tuner_pads[TUNER_PAD_OUTPUT].flags = MEDIA_PAD_FL_SOURCE;
 
        ret = media_entity_pads_init(&state->tuner,
                                     TUNER_NUM_PADS, state->tuner_pads);

diff --git a/drivers/media/v4l2-core/tuner-core.c b/drivers/media/v4l2-core/tuner-core.c
index 76496fd282aa532da3e84960ea7dddeedc013ccf..a1f858b341876f7d129c0c9136a94e2ac58e48f1 100644 (file)
--- a/drivers/media/v4l2-core/tuner-core.c
+++ b/drivers/media/v4l2-core/tuner-core.c
@@ -697,7 +697,7 @@ static int tuner_probe(struct i2c_client *client,
 register_client:
 #if defined(CONFIG_MEDIA_CONTROLLER)
        t->pad[TUNER_PAD_RF_INPUT].flags = MEDIA_PAD_FL_SINK;
-       t->pad[TUNER_PAD_IF_OUTPUT].flags = MEDIA_PAD_FL_SOURCE;
+       t->pad[TUNER_PAD_OUTPUT].flags = MEDIA_PAD_FL_SOURCE;
        t->sd.entity.function = MEDIA_ENT_F_TUNER;
        t->sd.entity.name = t->name;
 

diff --git a/include/media/tuner.h b/include/media/tuner.h
index e5321fda548935e1bab99fbce565dc7a018d52e9..c5994fe865a06c2bf30c7ef5c86d927d7e56010b 100644 (file)
--- a/include/media/tuner.h
+++ b/include/media/tuner.h
@@ -21,11 +21,26 @@
 
 #include <linux/videodev2.h>
 
-/* Tuner PADs */
-/* FIXME: is this the right place for it? */
+/**
+ * enum tuner_pad_index - tuner pad index
+ *
+ * @TUNER_PAD_RF_INPUT:        Radiofrequency (RF) sink pad, usually linked to a
+ *                     RF connector entity.
+ * @TUNER_PAD_OUTPUT:  Tuner output pad. This is actually more complex than
+ *                     a single pad output, as, in addition to luminance and
+ *                     chrominance IF a tuner may have internally an
+ *                     audio decoder (like xc3028) or it may produce an audio
+ *                     IF that will be used by an audio decoder like msp34xx.
+ *                     It may also have an IF-PLL demodulator on it, like
+ *                     tuners with tda9887. Yet, currently, we don't need to
+ *                     represent all the dirty details, as this is transparent
+ *                     for the V4L2 API usage. So, let's represent all kinds
+ *                     of different outputs as a single source pad.
+ * @TUNER_NUM_PADS:    Number of pads of the tuner.
+ */
 enum tuner_pad_index {
        TUNER_PAD_RF_INPUT,
-       TUNER_PAD_IF_OUTPUT,
+       TUNER_PAD_OUTPUT,
        TUNER_NUM_PADS
 };