mm-swap-add-swap_cluster_list-checkpatch-fixes
authorAndrew Morton <akpm@linux-foundation.org>
Sat, 10 Sep 2016 10:34:08 +0000 (20:34 +1000)
committerStephen Rothwell <sfr@canb.auug.org.au>
Sat, 10 Sep 2016 10:34:08 +0000 (20:34 +1000)
WARNING: Missing a blank line after declarations
#91: FILE: mm/swapfile.c:285:
+ unsigned int tail = cluster_next(&list->tail);
+ cluster_set_next(&ci[tail], idx);

WARNING: line over 80 characters
#261: FILE: mm/swapfile.c:2347:
+ cluster_list_add_tail(&p->free_clusters, cluster_info, idx);

total: 0 errors, 2 warnings, 222 lines checked

NOTE: For some of the reported defects, checkpatch may be able to
      mechanically convert to the typical style using --fix or --fix-inplace.

./patches/mm-swap-add-swap_cluster_list.patch has style problems, please review.

NOTE: If any of the errors are false positives, please report
      them to the maintainer, see CHECKPATCH in MAINTAINERS.

Please run checkpatch prior to sending patches

Cc: Huang Ying <ying.huang@intel.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
mm/swapfile.c

index f9892a3d38770954744fd596e3f01b98a5d41ccf..8f1b97d6cd45e7ebba9835910dbab0200e6af4dd 100644 (file)
@@ -282,6 +282,7 @@ static void cluster_list_add_tail(struct swap_cluster_list *list,
                cluster_set_next_flag(&list->tail, idx, 0);
        } else {
                unsigned int tail = cluster_next(&list->tail);
+
                cluster_set_next(&ci[tail], idx);
                cluster_set_next_flag(&list->tail, idx, 0);
        }
@@ -2344,7 +2345,8 @@ static int setup_swap_map_and_extents(struct swap_info_struct *p,
        for (i = 0; i < nr_clusters; i++) {
                if (!cluster_count(&cluster_info[idx])) {
                        cluster_set_flag(&cluster_info[idx], CLUSTER_FLAG_FREE);
-                       cluster_list_add_tail(&p->free_clusters, cluster_info, idx);
+                       cluster_list_add_tail(&p->free_clusters, cluster_info,
+                                             idx);
                }
                idx++;
                if (idx == nr_clusters)
This page took 0.027338 seconds and 5 git commands to generate.