deliverable/lttng-modules.git
7 years agoConnect sched_set_prio probe sched_set_prio
Julien Desfossez [Fri, 13 May 2016 18:59:56 +0000 (14:59 -0400)] 
Connect sched_set_prio probe

Signed-off-by: Julien Desfossez <jdesfossez@efficios.com>
7 years agoMerge branch 'master' of git://git.lttng.org/lttng-modules
Julien Desfossez [Mon, 20 Jun 2016 20:02:12 +0000 (16:02 -0400)] 
Merge branch 'master' of git://git.lttng.org/lttng-modules

7 years agoFix: annotate bytecode interpreter for kernel stack validator
Mathieu Desnoyers [Wed, 15 Jun 2016 18:39:41 +0000 (14:39 -0400)] 
Fix: annotate bytecode interpreter for kernel stack validator

With gcc 6.1.1, kernel 4.6, with
CONFIG_STACK_VALIDATION=y, building lttng-modules master
at commit 6c09dd94 gives this warning:

lttng-modules/lttng-filter-interpreter.o: warning: objtool:
lttng_filter_interpret_bytecode()+0x58: sibling call from
callable instruction with changed frame pointer

This object implements a bytecode interpreter using an explicit
jump table.

If we define "INTERPRETER_USE_SWITCH" at the top of the file,
thus using the switch-case fallback implementation, the
warning vanishes.

We use an explicit jump table rather than a switch case whenever
possible for performance reasons.

Unfortunately objtool doesn't know how to validate this type of jump
table. So to avoid the warning we need to add an annotation to tell
objtool to ignore it.

Kernel developers has to annotate __bpf_prog_run() in the kernel for the
same reason.

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
7 years agoMerge branch 'master' of git://git.lttng.org/lttng-modules
Julien Desfossez [Mon, 13 Jun 2016 19:29:38 +0000 (15:29 -0400)] 
Merge branch 'master' of git://git.lttng.org/lttng-modules

7 years agoUpdate version to 2.9.0-pre
Michael Jeanson [Tue, 24 May 2016 20:11:11 +0000 (16:11 -0400)] 
Update version to 2.9.0-pre

Signed-off-by: Michael Jeanson <mjeanson@efficios.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
7 years agoMerge branch 'master' of git://git.lttng.org/lttng-modules
Julien Desfossez [Fri, 20 May 2016 13:38:55 +0000 (09:38 -0400)] 
Merge branch 'master' of git://git.lttng.org/lttng-modules

7 years agoFix: ring buffer: honor switch parameter type in remote switch
Mathieu Desnoyers [Fri, 20 May 2016 01:32:06 +0000 (21:32 -0400)] 
Fix: ring buffer: honor switch parameter type in remote switch

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
7 years agoFix: only flush non-metadata channels
Mathieu Desnoyers [Fri, 20 May 2016 01:31:07 +0000 (21:31 -0400)] 
Fix: only flush non-metadata channels

Issue introduced by commit
"Fix: do not generate packet at destroy after stop".

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
7 years agoFix: don't perform extra flush on metadata channel
Mathieu Desnoyers [Fri, 20 May 2016 00:30:07 +0000 (20:30 -0400)] 
Fix: don't perform extra flush on metadata channel

The metadata channel requires that the LTTng client layer and the ring
buffer keep a notion of the amount of data produced in the channel.

This issue has been introduced recently by commit
"Fix: flush empty packets on snapshot channel".

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
7 years agoselect, poll and epoll_wait overrides on ARM 32-bit
Julien Desfossez [Mon, 16 May 2016 19:36:11 +0000 (15:36 -0400)] 
select, poll and epoll_wait overrides on ARM 32-bit

The syscalls select, poll and epoll_wait exist on ARM 32-bit as well,
the overrides work on this platform.

Signed-off-by: Julien Desfossez <jdesfossez@efficios.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
7 years agoFix: flush empty packets on snapshot channel
Mathieu Desnoyers [Wed, 18 May 2016 01:24:46 +0000 (21:24 -0400)] 
Fix: flush empty packets on snapshot channel

Snapshot operation on a non-stopped stream should use a "final" flush to
ensure empty packets are flushed, so we gather timestamps at the moment
where the snapshot is taken. This is important for streams that have a
low amount of activity.

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
7 years agoFix: do not generate packet at destroy after stop
Mathieu Desnoyers [Wed, 18 May 2016 01:23:24 +0000 (21:23 -0400)] 
Fix: do not generate packet at destroy after stop

In the following scenario:
- create, enable events (kernel),
- start
- ...
- stop (await for data_pending to complete)
- destroy
- rm the trace directory

We would expect that the "rm" operation would not conflict with the
consumer daemon trying to output data into the trace files, since the
"stop" operation ensured that there was no data_pending.

However, the "destroy" operation currently generates an extra packet
after the data_pending check. This causes the consumer daemon to try to
perform trace file rotation concurrently with the trace directory
removal in the scenario above, which triggers errors. The main reason
why this empty packet is generated by "destroy" is to deal with trace
start/stop scenario which would otherwise generate a completely empty
stream.

Therefore, introduce the concept of a "quiescent stream". It is
initialized at false on stream creation (first packet is empty). When
tracing is started, it is set to false (for cases of start/stop/start).
When tracing is stopped, if the stream is not quiescent, perform a
"final" flush (which will generate an empty packet if the current packet
was empty), and set quiescent to true.  On "destroy" stream: if the
stream is not quiescent, perform a "final" flush, and set the quiescent
state to true.

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
7 years agoFix: compat ioctl for flush/get metadata version
Mathieu Desnoyers [Wed, 18 May 2016 01:16:22 +0000 (21:16 -0400)] 
Fix: compat ioctl for flush/get metadata version

Unlike the non-compat version, the compat ioctl lttng ABI code for the
ring buffer flush operation does not invoke
lttng_metadata_output_channel before calling the ring buffer operation.
This could lead to incomplete metadata on 64-bit kernels running with
32-bit lttng userland.

There is also a discrepancy between the non-compat and compat code: the
GET_METADATA_VERSION operation is performed before calling the ring
buffer code. Ensure both non-compat and compat code are alike.

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
7 years agoFix: ctf_string() should handle NULL pointers
Mathieu Desnoyers [Mon, 16 May 2016 20:45:24 +0000 (16:45 -0400)] 
Fix: ctf_string() should handle NULL pointers

The regmap instrumentation can send a NULL string (e.g. on ARM32).

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
7 years agoselect, poll and epoll_wait overrides on ARM 32-bit
Julien Desfossez [Mon, 16 May 2016 19:33:22 +0000 (15:33 -0400)] 
select, poll and epoll_wait overrides on ARM 32-bit

The syscalls select, poll and epoll_wait exist on ARM 32-bit as well,
the overrides work on this platform.

Signed-off-by: Julien Desfossez <jdesfossez@efficios.com>
7 years agoMerge branch 'master' of git://git.lttng.org/lttng-modules
Julien Desfossez [Mon, 16 May 2016 19:31:46 +0000 (15:31 -0400)] 
Merge branch 'master' of git://git.lttng.org/lttng-modules

7 years agoFix: portability: no arith on void pointer
Mathieu Desnoyers [Mon, 16 May 2016 19:08:02 +0000 (15:08 -0400)] 
Fix: portability: no arith on void pointer

Reported by cppcheck.

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
7 years agoMerge branch 'master' of git://git.lttng.org/lttng-modules
Julien Desfossez [Fri, 13 May 2016 19:00:21 +0000 (15:00 -0400)] 
Merge branch 'master' of git://git.lttng.org/lttng-modules

7 years agoFix: add missing tests/Kbuild
Mathieu Desnoyers [Wed, 11 May 2016 23:35:06 +0000 (19:35 -0400)] 
Fix: add missing tests/Kbuild

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
7 years agoTest clock override plugin
Mathieu Desnoyers [Wed, 11 May 2016 14:10:17 +0000 (10:10 -0400)] 
Test clock override plugin

Fixes: #939
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
7 years agoFix: add modules target to base Makefile
Michael Jeanson [Wed, 11 May 2016 14:38:06 +0000 (10:38 -0400)] 
Fix: add modules target to base Makefile

This way running 'make modules' will indeed build the modules
like in the upstream build system.

Signed-off-by: Michael Jeanson <mjeanson@efficios.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
7 years agoFix: make clean does not include dot-config
Mathieu Desnoyers [Wed, 11 May 2016 14:37:12 +0000 (10:37 -0400)] 
Fix: make clean does not include dot-config

Skip the CONFIG_TRACEPOINT test if dot-config has not been included.

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
7 years agoFix: trigger build error if CONFIG_TRACEPOINTS is not set
Mathieu Desnoyers [Wed, 11 May 2016 02:04:12 +0000 (22:04 -0400)] 
Fix: trigger build error if CONFIG_TRACEPOINTS is not set

Fixes: #1015
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
7 years agoDocumentation: document that CONFIG_MODULES not required when builtin
Mathieu Desnoyers [Wed, 11 May 2016 02:03:23 +0000 (22:03 -0400)] 
Documentation: document that CONFIG_MODULES not required when builtin

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
7 years agoFix: add missing errno include in random wrapper
Mathieu Desnoyers [Wed, 11 May 2016 00:49:01 +0000 (20:49 -0400)] 
Fix: add missing errno include in random wrapper

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
7 years agoFix: mm_page_alloc_extfrag instrumentation for kernel 3.16.35
Michael Jeanson [Thu, 5 May 2016 20:10:36 +0000 (16:10 -0400)] 
Fix: mm_page_alloc_extfrag instrumentation for kernel 3.16.35

Signed-off-by: Michael Jeanson <mjeanson@efficios.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
7 years agoFix: copy_from_user size when limited allocation
Julien Desfossez [Mon, 2 May 2016 20:48:08 +0000 (16:48 -0400)] 
Fix: copy_from_user size when limited allocation

We restrict the memory allocation to one page, but in two syscalls we were
using the wrong size in the copy_from_user.

Signed-off-by: Julien Desfossez <jdesfossez@efficios.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
7 years agoFix: copy_from_user size when limited allocation
Julien Desfossez [Mon, 2 May 2016 20:45:01 +0000 (16:45 -0400)] 
Fix: copy_from_user size when limited allocation

We restrict the allocation to one page, but in two syscalls we were
using the wrong size in the copy_from_user.

Signed-off-by: Julien Desfossez <jdesfossez@efficios.com>
7 years agoExtract the payload of epoll_wait/epoll_pwait
Julien Desfossez [Sat, 30 Apr 2016 15:09:30 +0000 (11:09 -0400)] 
Extract the payload of epoll_wait/epoll_pwait

When epoll_wait returns, extract the content of the "events" field
(events set and data payload).

Here is an example output:
syscall_entry_epoll_wait: { epfd = 3, maxevents = 32, timeout = 100 }
syscall_exit_epoll_wait: { ret = 1, fds_length = 1,
  fds = [ [0] = { raw_events = 0x1,
    events = { EPOLLIN = 1, EPOLLPRI = 0, EPOLLOUT = 0, EPOLLERR = 0,
      padding = 0 },
    data_union = { u64 = 0x100000005, fd = 5 } } ]
}

Signed-off-by: Julien Desfossez <jdesfossez@efficios.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
7 years agoExtract the payload for epoll_ctl
Julien Desfossez [Sat, 30 Apr 2016 15:09:29 +0000 (11:09 -0400)] 
Extract the payload for epoll_ctl

Map the operation to its name (EPOLL_CTL_*), extract the standard event
flags (EPOLL*) and output the data in two different formats: FD as an
int in decimal, and u64 in hex. The less standard event flags are not
extracted yet, but we extract the raw value in hex for more advanced
analyses.

Here is an example output:
syscall_entry_epoll_ctl: {
  epfd = 4, op_enum = ( "EPOLL_CTL_ADD" : container = 1 ),
  fd = 0, event = { raw_events = 0x80000003,
  events = { EPOLLIN = 1, EPOLLPRI = 1, EPOLLOUT = 0, EPOLLERR = 0,
    padding = 0 },
  data_union = { u64 = 0x0, fd = 0 } }
}

syscall_exit_epoll_ctl: { ret = 0 }

Signed-off-by: Julien Desfossez <jdesfossez@efficios.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
7 years agoExtract the FDs and flags from poll and ppoll
Julien Desfossez [Sat, 30 Apr 2016 15:09:28 +0000 (11:09 -0400)] 
Extract the FDs and flags from poll and ppoll

Instead of printing the pointer address of the poll set, extract all the
FDs and flags from the poll set. For now, we only output the
standardized set of events to limit the verbosity of the output, we also
extract the raw value. When we switch to CTF2 we will be able to hide
unset fields and then we will extract all the fields.

Here is an example of output with one FD:
syscall_entry_poll: {
  timeout_msecs = -1, nfds = 1, fds_length = 1,
  fds = [
    [0] = { fd = 4, raw_events = 0x5, events = { POLLIN = 1, POLLPRI = 0,
            POLLOUT = 1, POLLERR = 0, POLLHUP = 0, padding = 0 } } ]
}

syscall_exit_poll: {
  ret = 1, nfds = 1, fds_length = 1,
  fds = [ [0] = { fd = 4, raw_events = 0x4, events = { POLLIN = 0,
  POLLPRI = 0, POLLOUT = 1, POLLERR = 0, POLLHUP = 0, padding = 0 } } ] }

Signed-off-by: Julien Desfossez <jdesfossez@efficios.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
7 years agoExtract the FD sets in select and pselect6
Julien Desfossez [Sat, 30 Apr 2016 15:09:27 +0000 (11:09 -0400)] 
Extract the FD sets in select and pselect6

Instead of extracting the user-space pointers of the 3 fd_set, we now
extract the bitmask of the FDs in the sets (in, out, ex) in the form of
an array of uint8_t (1024 FDs is the limit in the kernel).

In this example, we select in input FDs 5 to 19 (0xFFFF0), it returns
that one FD is ready: FD 12 (0x1000).

syscall_entry_select: {
  n = 20,
  _fdset_in_length = 3, fdset_in = [ [0] = 0xF0, [1] = 0xFF, [2] = 0xF ],
  _fdset_out_length = 0, fdset_out = [ ],
  _fdset_ex_length = 0, fdset_ex = [ ],
  tvp = 0
 }

syscall_exit_select: {
  ret = 1,
  _fdset_in_length = 3, fdset_in = [ [0] = 0x0, [1] = 0x10, [2] = 0x0 ],
  _fdset_out_length = 0, fdset_out = [ ],
  _fdset_ex_length = 0, fdset_ex = [ ],
  tvp = 0
}

Signed-off-by: Julien Desfossez <jdesfossez@efficios.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
7 years agoAdd ctf_integer_bitfield_type
Julien Desfossez [Fri, 29 Apr 2016 22:53:20 +0000 (18:53 -0400)] 
Add ctf_integer_bitfield_type

Signed-off-by: Julien Desfossez <jdesfossez@efficios.com>
Acked-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
7 years agoImplement enumeration type
Mathieu Desnoyers [Fri, 18 Mar 2016 20:01:54 +0000 (16:01 -0400)] 
Implement enumeration type

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
7 years agoImplement custom field support
Mathieu Desnoyers [Mon, 2 May 2016 16:33:13 +0000 (12:33 -0400)] 
Implement custom field support

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
7 years agoImplement variant type
Mathieu Desnoyers [Fri, 18 Mar 2016 19:52:18 +0000 (15:52 -0400)] 
Implement variant type

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
7 years agoImplement shadow stack for dynamic len
Mathieu Desnoyers [Thu, 17 Mar 2016 22:09:32 +0000 (18:09 -0400)] 
Implement shadow stack for dynamic len

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
7 years agolibringbuffer: implement event too big API
Mathieu Desnoyers [Sat, 19 Mar 2016 15:34:22 +0000 (11:34 -0400)] 
libringbuffer: implement event too big API

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
7 years agoImplement structure, compound array/sequence types
Mathieu Desnoyers [Thu, 17 Mar 2016 16:16:09 +0000 (12:16 -0400)] 
Implement structure, compound array/sequence types

Only supports structure, and compound array/sequences
containing structures at this point.

Only supported within event fields, not contexts yet.

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
7 years agoFix: integer endianness metadata generation
Mathieu Desnoyers [Mon, 2 May 2016 16:32:48 +0000 (12:32 -0400)] 
Fix: integer endianness metadata generation

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
7 years agoFix: endianness of integers received by filter
Mathieu Desnoyers [Tue, 26 Apr 2016 22:41:04 +0000 (18:41 -0400)] 
Fix: endianness of integers received by filter

We need to byteswap integers passed to the filter when they are tagged
as being in an endianness which differs from the architecture
endianness, so the integer comparisons make sense in terms of value
rather than raw bytes for those fields.

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
7 years agoFix: writeback probe on RHEL >= 3.10.0-327.10.1
Michael Jeanson [Thu, 21 Apr 2016 20:11:04 +0000 (16:11 -0400)] 
Fix: writeback probe on RHEL >= 3.10.0-327.10.1

Signed-off-by: Michael Jeanson <mjeanson@efficios.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
7 years agoFix: RHEL kernel 3.10.0-327.13.1 compat
Michael Jeanson [Wed, 20 Apr 2016 21:50:05 +0000 (17:50 -0400)] 
Fix: RHEL kernel 3.10.0-327.13.1 compat

Signed-off-by: Michael Jeanson <mjeanson@efficios.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
7 years agoFix: ctf_user_integer should not trigger page fault
Mathieu Desnoyers [Wed, 20 Apr 2016 21:58:33 +0000 (17:58 -0400)] 
Fix: ctf_user_integer should not trigger page fault

It is not used by the instrumentation currently, but fix it
nevertheless.

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
7 years agoFix: lib_ring_buffer_copy_from_user_inatomic error handling
Mathieu Desnoyers [Wed, 20 Apr 2016 21:56:45 +0000 (17:56 -0400)] 
Fix: lib_ring_buffer_copy_from_user_inatomic error handling

It should treat nonzero return value of
lib_ring_buffer_do_copy_from_user_inatomic() as errors, 0 as success.

It is currently unused by the instrumentation.

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
8 years agoAdd comment describing ioctl number duplication
Mathieu Desnoyers [Thu, 14 Apr 2016 19:29:01 +0000 (15:29 -0400)] 
Add comment describing ioctl number duplication

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
8 years agoFix: remove unused gfpflags.h from btrfs and compaction instrumentation
Mathieu Desnoyers [Tue, 5 Apr 2016 19:25:20 +0000 (15:25 -0400)] 
Fix: remove unused gfpflags.h from btrfs and compaction instrumentation

Its content is unused, and this file disappears in Linux 4.6-rc.

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
8 years agoFix: Remove dead code from filter interpreter
Mathieu Desnoyers [Tue, 5 Apr 2016 13:26:51 +0000 (09:26 -0400)] 
Fix: Remove dead code from filter interpreter

Detected by Coverity:
** CID 1353794:  Control flow issues  (DEADCODE)
/lttng-filter-interpreter.c: 123 in stack_strcmp()

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
8 years agoFix: x86 kvm mmutrace instrumentation for kernel < 3.6
Mathieu Desnoyers [Tue, 5 Apr 2016 12:36:44 +0000 (08:36 -0400)] 
Fix: x86 kvm mmutrace instrumentation for kernel < 3.6

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
8 years agoFix: mm_vmscan instrumentation: remove unused gfpflags.h include
Mathieu Desnoyers [Tue, 5 Apr 2016 12:09:13 +0000 (08:09 -0400)] 
Fix: mm_vmscan instrumentation: remove unused gfpflags.h include

This header disappears in kernel 4.6, but we don't actually use it, so
remove its include.

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
8 years agoFix: use of uninitialized ret value in lttng_abi_create_event
Mathieu Desnoyers [Tue, 5 Apr 2016 12:05:42 +0000 (08:05 -0400)] 
Fix: use of uninitialized ret value in lttng_abi_create_event

Fixes the following compiler warning:

/home/jenkins/workspace/lttng-modules_VERSION_param-build/arch/x86-32/src/lttng-modules/lttng-abi.c: In function â€˜lttng_abi_create_event’:
/home/jenkins/workspace/lttng-modules_VERSION_param-build/arch/x86-32/src/lttng-modules/lttng-abi.c:987:16: warning: â€˜ret’ may be used uninitialized in this function [-Wmaybe-uninitialized]
  int event_fd, ret;

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
8 years agoFix: kmem instrumentation: remove unused gfpflags.h include
Mathieu Desnoyers [Mon, 4 Apr 2016 19:57:24 +0000 (15:57 -0400)] 
Fix: kmem instrumentation: remove unused gfpflags.h include

This header disappears in kernel 4.6, but we don't actually use it, so
remove its include.

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
8 years agoFix: 4.6 kernel: use in_compat_syscall
Mathieu Desnoyers [Mon, 4 Apr 2016 19:55:28 +0000 (15:55 -0400)] 
Fix: 4.6 kernel: use in_compat_syscall

in_compat_sycall appears in kernel 4.6. Use it instead of
is_compat_task(), but use is_compat_task() as fallback.

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
8 years agoFix: use BUG_ON instead of accessing array subscript above array bounds
Mathieu Desnoyers [Mon, 4 Apr 2016 18:39:16 +0000 (14:39 -0400)] 
Fix: use BUG_ON instead of accessing array subscript above array bounds

Building lttng-modules lttng-filter-interpreter.c on a 4.6-rc kernel
triggers the following gcc warning:

In file included from /home/compudj/git/lttng-modules/lttng-filter-interpreter.c:25:0:
/home/compudj/git/lttng-modules/lttng-filter-interpreter.c: In function â€˜lttng_filter_interpret_bytecode’:
/home/compudj/git/lttng-modules/lttng-filter.h:144:14: warning: array subscript is above array bounds [-Warray-bounds]
   &(stack)->e[top];    \
              ^
/home/compudj/git/lttng-modules/lttng-filter-interpreter.c:714:4: note: in expansion of macro â€˜estack_ax’
    estack_ax(stack, top)->u.s.str = insn->data;
    ^
/home/compudj/git/lttng-modules/lttng-filter.h:144:14: warning: array subscript is above array bounds [-Warray-bounds]
   &(stack)->e[top];    \
              ^
/home/compudj/git/lttng-modules/lttng-filter-interpreter.c:715:4: note: in expansion of macro â€˜estack_ax’
    estack_ax(stack, top)->u.s.seq_len = UINT_MAX;

This is because the bound checking is performed in a prior validation
phase (which the compiler does not know about), and we only
WARN_ON_ONCE() if the interpreter sees values that don't fit in array
range.

Use BUG_ON() in the interpreter instead, which ensures we never, ever
reach the out-of-bound condition from a compiler perspective.

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
8 years agoFix: Add granularity to RHEL kernel version checks
Michael Jeanson [Tue, 29 Mar 2016 23:32:19 +0000 (19:32 -0400)] 
Fix: Add granularity to RHEL kernel version checks

Our RHEL kernel version macros were based on the major and minor version
of the distribution version like "7.2" instead of the full kernel version
like "327.4.4". This prevented us from adding compatibility changes with
sufficient granularity.

Signed-off-by: Michael Jeanson <mjeanson@efficios.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
8 years agoVersion 2.8.0-rc1
Mathieu Desnoyers [Fri, 18 Mar 2016 22:21:44 +0000 (18:21 -0400)] 
Version 2.8.0-rc1

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
8 years agoBump minor tracer ABI version
Mathieu Desnoyers [Fri, 18 Mar 2016 21:32:21 +0000 (17:32 -0400)] 
Bump minor tracer ABI version

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
8 years agoFix: build against out-of-tree kernel build
Mathieu Desnoyers [Wed, 16 Mar 2016 15:23:43 +0000 (11:23 -0400)] 
Fix: build against out-of-tree kernel build

Fix following system header include modifications.

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
8 years agoprobes/Kbuild: remove upper level header path
Mathieu Desnoyers [Tue, 15 Mar 2016 16:24:12 +0000 (12:24 -0400)] 
probes/Kbuild: remove upper level header path

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
8 years agoMove leftover relative include paths to system paths
Mathieu Desnoyers [Tue, 15 Mar 2016 16:12:46 +0000 (12:12 -0400)] 
Move leftover relative include paths to system paths

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
8 years agosyscall instrumentation: use system headers
Mathieu Desnoyers [Tue, 15 Mar 2016 16:02:27 +0000 (12:02 -0400)] 
syscall instrumentation: use system headers

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
8 years agotracepoint event instrumentation: use system headers
Mathieu Desnoyers [Tue, 15 Mar 2016 15:56:24 +0000 (11:56 -0400)] 
tracepoint event instrumentation: use system headers

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
8 years agoUse system include path in wrappers
Mathieu Desnoyers [Tue, 15 Mar 2016 15:45:00 +0000 (11:45 -0400)] 
Use system include path in wrappers

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
8 years agolibs: use system include paths
Mathieu Desnoyers [Tue, 15 Mar 2016 15:41:09 +0000 (11:41 -0400)] 
libs: use system include paths

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
8 years agoUse system header paths in core implementation files
Mathieu Desnoyers [Tue, 15 Mar 2016 15:35:47 +0000 (11:35 -0400)] 
Use system header paths in core implementation files

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
8 years agoUse system include paths in root directory headers
Mathieu Desnoyers [Tue, 15 Mar 2016 15:27:52 +0000 (11:27 -0400)] 
Use system include paths in root directory headers

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
8 years agoUse system include paths in probes
Mathieu Desnoyers [Tue, 15 Mar 2016 15:16:43 +0000 (11:16 -0400)] 
Use system include paths in probes

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
8 years agoUpdate gitignore
Mathieu Desnoyers [Tue, 15 Mar 2016 15:03:08 +0000 (11:03 -0400)] 
Update gitignore

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
8 years agoUse system include paths in lttng-types.h
Mathieu Desnoyers [Tue, 15 Mar 2016 15:02:33 +0000 (11:02 -0400)] 
Use system include paths in lttng-types.h

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
8 years agoUse system include paths in lttng-tracepoint-event-impl.h
Mathieu Desnoyers [Tue, 15 Mar 2016 15:01:32 +0000 (11:01 -0400)] 
Use system include paths in lttng-tracepoint-event-impl.h

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
8 years agoUse system include path in probes/define_trace.h
Mathieu Desnoyers [Tue, 15 Mar 2016 14:59:47 +0000 (10:59 -0400)] 
Use system include path in probes/define_trace.h

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
8 years agoUse system include paths in probes/lttng-tracepoint-event-impl.h
Mathieu Desnoyers [Tue, 15 Mar 2016 14:58:45 +0000 (10:58 -0400)] 
Use system include paths in probes/lttng-tracepoint-event-impl.h

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
8 years agoRename probes/lttng-events.h to probes/lttng-tracepoint-event-impl.h
Mathieu Desnoyers [Tue, 15 Mar 2016 14:57:39 +0000 (10:57 -0400)] 
Rename probes/lttng-events.h to probes/lttng-tracepoint-event-impl.h

Ensure we don't have a duplicated header file name in the tree.

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
8 years agoAdd makefile directory to include path
Mathieu Desnoyers [Tue, 15 Mar 2016 14:45:44 +0000 (10:45 -0400)] 
Add makefile directory to include path

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
8 years agoFix: event ctx get size should be after chan ctx
Mathieu Desnoyers [Thu, 10 Mar 2016 01:21:42 +0000 (20:21 -0500)] 
Fix: event ctx get size should be after chan ctx

Match the record functions, and the CTF spec. This has no impact
currently because event contexts are not implemented.

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
8 years agoFix: filter interpreter with userspace strings
Mathieu Desnoyers [Tue, 8 Mar 2016 16:34:01 +0000 (11:34 -0500)] 
Fix: filter interpreter with userspace strings

The filter interpreter is populating the "str" register field, but the
string comparison functions expect to use the "user_str" register field
whenever it deals with a userspace string ("user" flag set to 1).

Since we are using __copy_from_user_inatomic(), this is typically
bailing out on anything that requires to read the string (except the '*'
wildcard).

Fixes #943

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
8 years agoFix: rename kvm x86 TRACE_SYSTEM to avoid name clash
Mathieu Desnoyers [Tue, 8 Mar 2016 15:49:52 +0000 (10:49 -0500)] 
Fix: rename kvm x86 TRACE_SYSTEM to avoid name clash

The lttng-probe-kvm and lttng-probe-kvm-x86 have the same TRACE_SYSTEM
string. Because of that, both modules can't be loaded at the same time.
The second module fails to load silently. Rename the TRACE_SYSTEM of
lttng-probe-kvm-x86 to avoid the clash.

We need to use the LTTNG_TRACEPOINT_EVENT_MAP to perform this
namespacing while still hooking onto the kernel tracepoints.

Fixes #895

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
8 years agoFix: format address fields as hexadecimal
Mathieu Desnoyers [Tue, 8 Mar 2016 15:30:33 +0000 (10:30 -0500)] 
Fix: format address fields as hexadecimal

Fixes #947

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
8 years agoPowerPC-64 ABIv1: add build error if KALLSYMS_ALL is missing
Mathieu Desnoyers [Mon, 7 Mar 2016 23:24:25 +0000 (18:24 -0500)] 
PowerPC-64 ABIv1: add build error if KALLSYMS_ALL is missing

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
8 years agoFix: system call instrumentation overrides
Mathieu Desnoyers [Thu, 25 Feb 2016 15:46:54 +0000 (10:46 -0500)] 
Fix: system call instrumentation overrides

* All architectures

- For mmap, print the "ret" value as an hexadecimal integer (rather than
  base 10), which better suits a pointer.
- Add missing "clone" override define, which ensures the clone
  system call override is used rather than leaving it as an
  "unknown" system call.

* ARM32

- Add missing output return values to arm_fadvise64_64,
  sync_file_range2.
- Handle the 64-bit parameters of both arm_fadvise64_64 and
  sync_file_range2 correctly on arm32, on big and little endian builds.
- Move the mmap2 system call instrumentation from "pointers" to
  "integers" override header, and add the missing return value
  (sc_exit).

* PPC32

- Add sync_file_range2 system call instrumentation. Handle the
  64-bit parameters on big and little endian builds.
- Move the mmap2 system call instrumentation from "pointers" to
  "integers" override header, and add the missing return value
  (sc_exit).

* PPC64 compat

- Include compatibility (ppc32) header in ppc64 build to trace compat
  system calls on PPC64 big endian.

* x86-32

- Add mmap2 system call instrumentation override.
- Add sync_file_range instrumentation override, correctly combining
  the low/high parts of offset and nbytes into 64-bit fields.

Tested-by: Jonathan Rajotte <jonathan.rajotte-julien@efficios.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
8 years agoFix: page_alloc wrapper incorrect parenthesis
Mathieu Desnoyers [Fri, 4 Mar 2016 01:00:50 +0000 (20:00 -0500)] 
Fix: page_alloc wrapper incorrect parenthesis

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
8 years agoFix: system call tracing for arm-64 compat !CONFIG_UID16
Mathieu Desnoyers [Mon, 22 Feb 2016 21:57:37 +0000 (16:57 -0500)] 
Fix: system call tracing for arm-64 compat !CONFIG_UID16

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
8 years agoFix: add struct user_msghdr forward declaration for older kernels
Mathieu Desnoyers [Sat, 20 Feb 2016 00:00:20 +0000 (19:00 -0500)] 
Fix: add struct user_msghdr forward declaration for older kernels

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
8 years agoCleanup: Remove unused lttng-types module
Michael Jeanson [Fri, 12 Feb 2016 20:26:23 +0000 (15:26 -0500)] 
Cleanup: Remove unused lttng-types module

Signed-off-by: Michael Jeanson <mjeanson@efficios.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
8 years agoFix: add missing versions and init call for page_alloc wrapper
Mathieu Desnoyers [Fri, 12 Feb 2016 20:11:04 +0000 (15:11 -0500)] 
Fix: add missing versions and init call for page_alloc wrapper

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
8 years agoFix: Define lttng-tracer metadata only once
Michael Jeanson [Wed, 10 Feb 2016 16:08:14 +0000 (11:08 -0500)] 
Fix: Define lttng-tracer metadata only once

Fixes sysfs trying to create the lttng-tracer module version node
multiple times.

Signed-off-by: Michael Jeanson <mjeanson@efficios.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
8 years agoFix: Add CONFIG_LTTNG to modules_install target
Michael Jeanson [Tue, 9 Feb 2016 20:16:56 +0000 (15:16 -0500)] 
Fix: Add CONFIG_LTTNG to modules_install target

Signed-off-by: Michael Jeanson <mjeanson@efficios.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
8 years agoFix: Use kbuild env instead of a custom var KERNELDIR
Michael Jeanson [Mon, 8 Feb 2016 21:33:17 +0000 (16:33 -0500)] 
Fix: Use kbuild env instead of a custom var KERNELDIR

We currently use the custom variables KERNELDIR and LTTNG_KERNELDIR
to pass the kernel source tree directory to helper scripts. We should
instead use the built-in Kbuild variable CURDIR which is available in
all sub makefiles and always points to the kernel sources.

Signed-off-by: Michael Jeanson <mjeanson@efficios.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
8 years agoUpdate clock offset comment
Mathieu Desnoyers [Mon, 8 Feb 2016 21:58:32 +0000 (16:58 -0500)] 
Update clock offset comment

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
8 years agoclock offset: print negative value in metadata
Mathieu Desnoyers [Mon, 8 Feb 2016 21:52:05 +0000 (16:52 -0500)] 
clock offset: print negative value in metadata

In the upcoming 2.8, we can print the negative value of clock offset in
the metadata, and expect users to update their viewers to correct any
bug that could prevent them from handling those negative values.

This happens only in cases where the system sets CLOCK_REALTIME to 0
after boot, thus leading to a negative clock offset value between
realtime and monotonic clocks.

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
8 years agoFix: handle negative clock offset
Mathieu Desnoyers [Mon, 8 Feb 2016 21:38:46 +0000 (16:38 -0500)] 
Fix: handle negative clock offset

In the unlikely situation where a system sets its hardware clock
(CLOCK_REALTIME) to 0 (Epoch) after boot, the difference

  monotonic - realtime

becomes negative.

Fixup this situation by returning a 0 offset in this case.

This ensures that trace viewer implementations (e.g. babeltrace) which
currently cannot handle the negative offset (known bug) still work with
the generated traces.

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
8 years agoFix: sched instrumentation for 4.1-rt11
Michael Jeanson [Fri, 5 Feb 2016 22:53:07 +0000 (17:53 -0500)] 
Fix: sched instrumentation for 4.1-rt11

Signed-off-by: Michael Jeanson <mjeanson@efficios.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
8 years agoAdd RT patch version macros
Michael Jeanson [Fri, 5 Feb 2016 22:53:06 +0000 (17:53 -0500)] 
Add RT patch version macros

Signed-off-by: Michael Jeanson <mjeanson@efficios.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
8 years agoExpect filter context identifiers starting with $ctx.
Mathieu Desnoyers [Thu, 4 Feb 2016 00:17:35 +0000 (19:17 -0500)] 
Expect filter context identifiers starting with $ctx.

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
8 years agoARM64: wire up compat system calls
Mathieu Desnoyers [Wed, 3 Feb 2016 14:29:15 +0000 (09:29 -0500)] 
ARM64: wire up compat system calls

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
8 years agoAdd support for arm64 syscalls
Jan Willeke [Wed, 3 Feb 2016 13:04:12 +0000 (14:04 +0100)] 
Add support for arm64 syscalls

[ Edit by Mathieu Desnoyers: rename "x86_64" strings to "arm64" in
  comments. ]

Signed-off-by: Jan Willeke <jan.willeke@harman.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
8 years agoFix: Ubuntu kernel range for block_rq_complete
Michael Jeanson [Fri, 29 Jan 2016 22:46:03 +0000 (17:46 -0500)] 
Fix: Ubuntu kernel range for block_rq_complete

Signed-off-by: Michael Jeanson <mjeanson@efficios.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
8 years agoFix: Ubuntu kernel range for mm_page_alloc_extfrag
Michael Jeanson [Fri, 29 Jan 2016 22:46:02 +0000 (17:46 -0500)] 
Fix: Ubuntu kernel range for mm_page_alloc_extfrag

Signed-off-by: Michael Jeanson <mjeanson@efficios.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
8 years agoFix: update vmscan instrumentation for kernel 4.5
Mathieu Desnoyers [Mon, 25 Jan 2016 19:23:43 +0000 (14:23 -0500)] 
Fix: update vmscan instrumentation for kernel 4.5

The following tracepoint changes made their way into Linux 4.5-rc1:

commit 3aa2385111168187f24a6db04697c6fab0fab9b4
Author: yalin wang <yalin.wang2010@gmail.com>
Date:   Thu Jan 14 15:18:30 2016 -0800

    mm/vmscan.c: change trace_mm_vmscan_writepage() proto type

and

commit ba5e9579433aefcdccdec207601e124d3bdf2a71
Author: yalin wang <yalin.wang2010@gmail.com>
Date:   Thu Jan 14 15:18:48 2016 -0800

    mm: change mm_vmscan_lru_shrink_inactive() proto types

Update the lttng-modules instrumentation to match those changes.

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
8 years agoFix: check reference counts for overflow
Mathieu Desnoyers [Tue, 19 Jan 2016 14:51:55 +0000 (09:51 -0500)] 
Fix: check reference counts for overflow

Linux kernel CVE-2016-0728 is a use-after-free based on overflow of the
reference counting mechanism.

Implement a kref wrapper in lttng that validates overflows, and use it
instead of kref_get(). Also check explicitly for overflows on file
fcount counters.

This should not be an issue in practice in lttng-modules because the ABI
is only exposed to root, but let's err on the safe side.

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
This page took 0.042256 seconds and 5 git commands to generate.