From e2bd33a56b81656d9994b4699e521cb7309f8827 Mon Sep 17 00:00:00 2001 From: Jonathan Rajotte Date: Mon, 21 Sep 2015 14:31:33 -0400 Subject: [PATCH] Cleanup: Unnecessary bit shift Reported by cppcheck [1]. [1] https://ci.lttng.org/view/Code%20quality/job/lttng-ust_master_cppcheck/5/cppcheckResult/source.10/ Proposed-by: Michael Jeanson Signed-off-by: Jonathan Rajotte Signed-off-by: Mathieu Desnoyers --- libringbuffer/backend_internal.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libringbuffer/backend_internal.h b/libringbuffer/backend_internal.h index 344784fe..79f8bdea 100644 --- a/libringbuffer/backend_internal.h +++ b/libringbuffer/backend_internal.h @@ -485,7 +485,7 @@ static inline int lttng_ust_fls(unsigned int x) r -= 2; } if (!(x & 0x80000000U)) { - x <<= 1; + /* No need to bit shift on last operation */ r -= 1; } return r; -- 2.34.1