tmf: Remove function name from ITmfCallsite
authorAlexandre Montplaisir <alexmonthy@efficios.com>
Mon, 18 Jul 2016 21:17:24 +0000 (17:17 -0400)
committerAlexandre Montplaisir <alexmonthy@efficios.com>
Wed, 27 Jul 2016 18:19:22 +0000 (14:19 -0400)
commit0c65e46128b131e08cbb8ec7e61f6676b4ac9454
treed4f4ffe803609a55b3db87cf79dc8fbf8a5c6559
parentd14f3c148d2be8e7d08b39226d886576390e2b75
tmf: Remove function name from ITmfCallsite

It just so happens today that the UST Debug-info analysis makes
use of addr2line to retrieve the source code location AND the
function names, but those two are completely separate concepts.

Since "function name" is not relevant for source lookup, it
should be removed from the concept of what is a call site.
ISymbolProvider should be the sole provider of function names,
especially now that it has been decoupled from ITmfCallsite.

While at it, add a new version of #getLineNumber() which returns
a "@Nullable Long", since it's very possible for callsites to
have a file name but no line number available.

Change-Id: I9b7407876166d9cc1e174804145937388306137d
Signed-off-by: Alexandre Montplaisir <alexmonthy@efficios.com>
Reviewed-on: https://git.eclipse.org/r/77554
Reviewed-by: Hudson CI
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Patrick Tasse <patrick.tasse@gmail.com>
14 files changed:
lttng/org.eclipse.tracecompass.lttng2.ust.core/.settings/.api_filters [new file with mode: 0644]
lttng/org.eclipse.tracecompass.lttng2.ust.core/META-INF/MANIFEST.MF
lttng/org.eclipse.tracecompass.lttng2.ust.core/src/org/eclipse/tracecompass/internal/lttng2/ust/core/analysis/debuginfo/FileOffsetMapper.java
lttng/org.eclipse.tracecompass.lttng2.ust.core/src/org/eclipse/tracecompass/lttng2/ust/core/analysis/debuginfo/FunctionLocation.java
lttng/org.eclipse.tracecompass.lttng2.ust.core/src/org/eclipse/tracecompass/lttng2/ust/core/analysis/debuginfo/SourceCallsite.java
lttng/org.eclipse.tracecompass.lttng2.ust.core/src/org/eclipse/tracecompass/lttng2/ust/core/analysis/debuginfo/UstDebugInfoFunctionAspect.java
lttng/org.eclipse.tracecompass.lttng2.ust.core/src/org/eclipse/tracecompass/lttng2/ust/core/analysis/debuginfo/UstDebugInfoSourceAspect.java
lttng/org.eclipse.tracecompass.lttng2.ust.ui/src/org/eclipse/tracecompass/internal/lttng2/ust/ui/analysis/debuginfo/UstDebugInfoSymbolProvider.java
tmf/org.eclipse.tracecompass.tmf.core.tests/src/org/eclipse/tracecompass/tmf/core/tests/event/lookup/TmfCallsiteTest.java
tmf/org.eclipse.tracecompass.tmf.core.tests/stubs/org/eclipse/tracecompass/tmf/tests/stubs/trace/text/SyslogEvent.java
tmf/org.eclipse.tracecompass.tmf.core/src/org/eclipse/tracecompass/tmf/core/event/lookup/ITmfCallsite.java
tmf/org.eclipse.tracecompass.tmf.core/src/org/eclipse/tracecompass/tmf/core/event/lookup/TmfCallsite.java
tmf/org.eclipse.tracecompass.tmf.ui/src/org/eclipse/tracecompass/tmf/ui/viewers/events/TmfEventPropertySource.java
tmf/org.eclipse.tracecompass.tmf.ui/src/org/eclipse/tracecompass/tmf/ui/viewers/events/TmfEventsTable.java
This page took 0.027133 seconds and 5 git commands to generate.