tmf.ui: fix potential priority inversion in symbol providers.
authorMatthew Khouzam <matthew.khouzam@ericsson.com>
Wed, 10 Aug 2016 13:47:14 +0000 (09:47 -0400)
committerMatthew Khouzam <matthew.khouzam@ericsson.com>
Thu, 11 Aug 2016 00:19:42 +0000 (20:19 -0400)
commita54f9c9d4cf523e7c56bcedb1166b8abe6a87194
tree2f8b6552436d1be497f45c2b37b16f4c19c32d38
parentf5f4ffc387e67bc057aa331d3318e5f3198251d6
tmf.ui: fix potential priority inversion in symbol providers.

It is a common practice to set a priorty of -Long.MIN_VALUE to an item to
make sure it is last. With the current implementation, it will always be
first, appearing before even Long.MAX_VALUE.

This patch fixes that issue.

Also, the constructor could fail out with an exception in several paths.
Now this is done by the factory method. This avoids having partial
objects in the heap which can be a security issue.

Change-Id: I392205a0b1a0557c168a2ae547b57915ee57f6f3
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/78758
Reviewed-by: Alexandre Montplaisir <alexmonthy@efficios.com>
Tested-by: Alexandre Montplaisir <alexmonthy@efficios.com>
Reviewed-by: Hudson CI
tmf/org.eclipse.tracecompass.tmf.ui/src/org/eclipse/tracecompass/tmf/ui/symbols/SymbolProviderManager.java
This page took 0.026162 seconds and 5 git commands to generate.