control: partly revert commit 0e7ea8ac and use clone in handlers
authorBernd Hufmann <Bernd.Hufmann@ericsson.com>
Fri, 27 Nov 2015 18:41:48 +0000 (13:41 -0500)
committerBernd Hufmann <bernd.hufmann@ericsson.com>
Mon, 30 Nov 2015 19:47:07 +0000 (14:47 -0500)
commitb8dbc09c769c3ccb420f220169876939e89586a4
tree8812d584e70a8c54093f79d4979eb6916dbc3649
parentc66ca500716a3a549b31befaa286d17371f1a0f8
control: partly revert commit 0e7ea8ac and use clone in handlers

The patch that will be reverted here used copy constructors instead
of clone. However, using copy constructors the class type gets lost
in certain cases and this will cause different errors to happen.

For example, add context on a UST channel will send the command with
-k instead of -u. This is because a instanceof check for
ChannelCommandParameter fails since the object to check is a
CommandParameter instance and not ChannelCommandParameter.

I'll add a subsequent patch with a unit test for the add context case.

Change-Id: I01177bc1fad7eb100b204997b4572bf14cb5be61
Signed-off-by: Bernd Hufmann <Bernd.Hufmann@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/61491
Reviewed-by: Hudson CI
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Patrick Tasse <patrick.tasse@gmail.com>
lttng/org.eclipse.tracecompass.lttng2.control.ui/src/org/eclipse/tracecompass/internal/lttng2/control/ui/views/handlers/BaseAddContextHandler.java
lttng/org.eclipse.tracecompass.lttng2.control.ui/src/org/eclipse/tracecompass/internal/lttng2/control/ui/views/handlers/BaseEnableChannelHandler.java
lttng/org.eclipse.tracecompass.lttng2.control.ui/src/org/eclipse/tracecompass/internal/lttng2/control/ui/views/handlers/BaseEnableEventHandler.java
lttng/org.eclipse.tracecompass.lttng2.control.ui/src/org/eclipse/tracecompass/internal/lttng2/control/ui/views/handlers/CalibrateHandler.java
lttng/org.eclipse.tracecompass.lttng2.control.ui/src/org/eclipse/tracecompass/internal/lttng2/control/ui/views/handlers/ChannelCommandParameter.java
lttng/org.eclipse.tracecompass.lttng2.control.ui/src/org/eclipse/tracecompass/internal/lttng2/control/ui/views/handlers/CommandParameter.java
lttng/org.eclipse.tracecompass.lttng2.control.ui/src/org/eclipse/tracecompass/internal/lttng2/control/ui/views/handlers/DomainCommandParameter.java
lttng/org.eclipse.tracecompass.lttng2.control.ui/src/org/eclipse/tracecompass/internal/lttng2/control/ui/views/handlers/EventCommandParameter.java
lttng/org.eclipse.tracecompass.lttng2.control.ui/src/org/eclipse/tracecompass/internal/lttng2/control/ui/views/handlers/ImportHandler.java
This page took 0.026334 seconds and 5 git commands to generate.