lttng.ust: Add the build-ID to the key of cache of addr2line calls
authorAlexandre Montplaisir <alexmonthy@efficios.com>
Wed, 6 Apr 2016 22:40:54 +0000 (18:40 -0400)
committerAlexandre Montplaisir <alexmonthy@efficios.com>
Mon, 2 May 2016 22:18:00 +0000 (18:18 -0400)
commitc84cc3ccdb3a7d4ee78a270b398f2783b8db13a6
treee11177e465b9a03279a4545829681f321281a5c8
parent5c727157f22f0299163c40ed1e189467fcbb788c
lttng.ust: Add the build-ID to the key of cache of addr2line calls

Before calling addr2line, we should also verify that the buildId
we got from the trace matches the file on disk we are about to
look at.

This buildId is already present in the UstDebugInfoBinaryFile
objects returned by the analysis, it is just a matter of
passing it down to the FileOffsetMapper call.

This way we can use it as part of the key for the cache of
calls, so that eventually calling it on different binaries
yields separate calls.

The actual verification is not done at the moment, as this
would require calling a separate process (like "eu-readelf").
There is not much gain in doing it yet anyway, because we only
look for one possible file (the one at the expected path). If
eventually the analysis is extended to look through several
different files for a given path - using separate debug symbol
files for examples - then the surrounding code won't have to
be modified.

Change-Id: I11f42a4295c88f66ad4a685198e30181daf0a1ba
Signed-off-by: Alexandre Montplaisir <alexmonthy@efficios.com>
Reviewed-on: https://git.eclipse.org/r/70306
Reviewed-by: Hudson CI
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
lttng/org.eclipse.tracecompass.lttng2.ust.core/src/org/eclipse/tracecompass/internal/lttng2/ust/core/analysis/debuginfo/FileOffsetMapper.java
lttng/org.eclipse.tracecompass.lttng2.ust.core/src/org/eclipse/tracecompass/lttng2/ust/core/analysis/debuginfo/BinaryCallsite.java
lttng/org.eclipse.tracecompass.lttng2.ust.core/src/org/eclipse/tracecompass/lttng2/ust/core/analysis/debuginfo/UstDebugInfoBinaryAspect.java
lttng/org.eclipse.tracecompass.lttng2.ust.core/src/org/eclipse/tracecompass/lttng2/ust/core/analysis/debuginfo/UstDebugInfoSourceAspect.java
This page took 0.025637 seconds and 5 git commands to generate.