btf: Remove AutoCloseable from BtfTrace
authorAlexandre Montplaisir <alexmonthy@voxpopuli.im>
Tue, 7 Jul 2015 20:00:17 +0000 (16:00 -0400)
committerAlexandre Montplaisir <alexmonthy@voxpopuli.im>
Tue, 8 Sep 2015 18:42:11 +0000 (14:42 -0400)
commitd9aa847c586f48108e0843c9a042c0c0418dfa7c
tree04de285185dfea962bbb814164c111802453e8aa
parentfc4a373fbf79553dd63cb40572123940d8e737f4
btf: Remove AutoCloseable from BtfTrace

Despite many great advantages, AutoCloseable does not work well
with subclasses of ITmfTrace, because it would imply that such
objects are not exposed publicly by other objects tracking them.

This is not the case in TMF, as many objects expose ITmfTrace's
through getters. Using instead TmfTrace's standard dispose()
method is more appropriate in subclasses.

Change-Id: I1d342d15dba7f8f6e75985f8aee6ed159838d424
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/51540
Reviewed-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
btf/org.eclipse.tracecompass.btf.core.tests/src/org/eclipse/tracecompass/btf/core/tests/trace/BtfTraceTest.java
btf/org.eclipse.tracecompass.btf.core.tests/src/org/eclipse/tracecompass/btf/core/tests/utils/TestBtfTrace.java
btf/org.eclipse.tracecompass.btf.core/META-INF/MANIFEST.MF
btf/org.eclipse.tracecompass.btf.core/pom.xml
btf/org.eclipse.tracecompass.btf.core/src/org/eclipse/tracecompass/btf/core/trace/BtfTrace.java
This page took 0.02488 seconds and 5 git commands to generate.