tmf.xml: Fix children in time graph view

Commit 7c094b3e0710bef7c69040d2d544f4e8781eaa4a changed the behavior of
the addChild(int, entry) of TimeGraphEntry. The parent should not be set
before calling this method anymore.

Change-Id: Ie716e9a5502f445dd6ef755adce42688ed000bbd
Signed-off-by: Geneviève Bastien <gbastien+lttng@versatic.net>
Reviewed-on: https://git.eclipse.org/r/85065
Reviewed-by: Hudson CI
Reviewed-by: Jean-Christian Kouame <jean-christian.kouame@ericsson.com>
Tested-by: Jean-Christian Kouame <jean-christian.kouame@ericsson.com>

diff --git a/tmf/org.eclipse.tracecompass.tmf.analysis.xml.ui/src/org/eclipse/tracecompass/internal/tmf/analysis/xml/ui/views/timegraph/XmlEntry.java b/tmf/org.eclipse.tracecompass.tmf.analysis.xml.ui/src/org/eclipse/tracecompass/internal/tmf/analysis/xml/ui/views/timegraph/XmlEntry.java
index b5783c9f39297baf005c4d898199d0d839629a14..69b039a95dd6c5180e7adb1358afd5a4d8a2fb3f 100644 (file)
--- a/tmf/org.eclipse.tracecompass.tmf.analysis.xml.ui/src/org/eclipse/tracecompass/internal/tmf/analysis/xml/ui/views/timegraph/XmlEntry.java
+++ b/tmf/org.eclipse.tracecompass.tmf.analysis.xml.ui/src/org/eclipse/tracecompass/internal/tmf/analysis/xml/ui/views/timegraph/XmlEntry.java
@@ -229,7 +229,7 @@ public class XmlEntry extends TimeGraphEntry implements IXmlStateSystemContainer
      * @param entry
      *            The entry to add
      */
-    public void addChild(XmlEntry entry) {
+    public void addChild(@NonNull XmlEntry entry) {
         int index;
         for (index = 0; index < getChildren().size(); index++) {
             XmlEntry other = (XmlEntry) getChildren().get(index);
@@ -242,7 +242,6 @@ public class XmlEntry extends TimeGraphEntry implements IXmlStateSystemContainer
             }
         }
 
-        entry.setParent(this);
         addChild(index, entry);
     }