From: Wassim <wassim.nasrallah.36@gmail.com>
Date: Fri, 27 May 2016 00:30:16 +0000 (-0400)
Subject: ctf.core: making some classes final
X-Git-Url: http://git.efficios.com/?p=deliverable%2Ftracecompass.git;a=commitdiff_plain;h=266c4d511bd4c26ca6e5063b53715d9c9ecea674

ctf.core: making some classes final

This patch is to make some classes final in ctf.core component.
It should be final to improve readability and since you should never
extend it. It also allows the jvm to inline methods and improve performance.

Change-Id: I6e9bef701898716978c6e7b4b20254eabc8cd6c8
Signed-off-by: Wassim <wassim.nasrallah.36@gmail.com>
Reviewed-on: https://git.eclipse.org/r/73771
Reviewed-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-by: Genevieve Bastien <gbastien+lttng@versatic.net>
Tested-by: Genevieve Bastien <gbastien+lttng@versatic.net>
---

diff --git a/ctf/org.eclipse.tracecompass.ctf.core/src/org/eclipse/tracecompass/ctf/core/event/types/EnumDeclaration.java b/ctf/org.eclipse.tracecompass.ctf.core/src/org/eclipse/tracecompass/ctf/core/event/types/EnumDeclaration.java
index 30155e142f..5fe01bbfb0 100644
--- a/ctf/org.eclipse.tracecompass.ctf.core/src/org/eclipse/tracecompass/ctf/core/event/types/EnumDeclaration.java
+++ b/ctf/org.eclipse.tracecompass.ctf.core/src/org/eclipse/tracecompass/ctf/core/event/types/EnumDeclaration.java
@@ -44,7 +44,7 @@ public final class EnumDeclaration extends Declaration implements ISimpleDatatyp
      *
      * @since 1.1
      */
-    public static class Pair {
+    public static final class Pair {
         private final long fFirst;
         private final long fSecond;
 
diff --git a/ctf/org.eclipse.tracecompass.ctf.core/src/org/eclipse/tracecompass/ctf/core/event/types/StringDeclaration.java b/ctf/org.eclipse.tracecompass.ctf.core/src/org/eclipse/tracecompass/ctf/core/event/types/StringDeclaration.java
index 4e6afd0bba..f94b9083df 100644
--- a/ctf/org.eclipse.tracecompass.ctf.core/src/org/eclipse/tracecompass/ctf/core/event/types/StringDeclaration.java
+++ b/ctf/org.eclipse.tracecompass.ctf.core/src/org/eclipse/tracecompass/ctf/core/event/types/StringDeclaration.java
@@ -30,7 +30,7 @@ import org.eclipse.tracecompass.ctf.core.event.scope.IDefinitionScope;
  * @author Simon Marchi
  */
 @NonNullByDefault
-public class StringDeclaration extends Declaration {
+public final class StringDeclaration extends Declaration {
 
     private static final StringDeclaration STRING_DEC_UTF8 = new StringDeclaration(Encoding.UTF8);
     private static final StringDeclaration STRING_DEC_ASCII = new StringDeclaration(Encoding.ASCII);
diff --git a/ctf/org.eclipse.tracecompass.ctf.core/src/org/eclipse/tracecompass/internal/ctf/core/SafeMappedByteBuffer.java b/ctf/org.eclipse.tracecompass.ctf.core/src/org/eclipse/tracecompass/internal/ctf/core/SafeMappedByteBuffer.java
index 7f25796d88..5b14099e6b 100644
--- a/ctf/org.eclipse.tracecompass.ctf.core/src/org/eclipse/tracecompass/internal/ctf/core/SafeMappedByteBuffer.java
+++ b/ctf/org.eclipse.tracecompass.ctf.core/src/org/eclipse/tracecompass/internal/ctf/core/SafeMappedByteBuffer.java
@@ -24,7 +24,7 @@ import java.nio.channels.FileChannel;
  *
  * http://bugs.java.com/view_bug.do?bug_id=4715154
  */
-public class SafeMappedByteBuffer {
+public final class SafeMappedByteBuffer {
 
     private static final boolean IS_WIN32 = System.getProperty("os.name").startsWith("Windows");  //$NON-NLS-1$//$NON-NLS-2$