From: Wassim <wassim.nasrallah.36@gmail.com>
Date: Fri, 3 Jun 2016 19:22:09 +0000 (-0400)
Subject: kernel.core: making some classes final
X-Git-Url: http://git.efficios.com/?p=deliverable%2Ftracecompass.git;a=commitdiff_plain;h=927809302f934ca559af1fe21a202f68a0c1ff8c

kernel.core: making some classes final

This patch is to make some classes final in kernel.core component.
It should be final to improve readability and since you should never
extend it. It also allows the jvm to inline methods and improve
performance.

Change-Id: Ie74fb3a6a36075cd355bdc58f4fe1deb3fc4a82a
Signed-off-by: Wassim <wassim.nasrallah.36@gmail.com>
Reviewed-on: https://git.eclipse.org/r/74558
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-by: Hudson CI
Reviewed-by: Genevieve Bastien <gbastien+lttng@versatic.net>
Tested-by: Genevieve Bastien <gbastien+lttng@versatic.net>
---

diff --git a/lttng/org.eclipse.tracecompass.lttng2.kernel.core/src/org/eclipse/tracecompass/internal/lttng2/kernel/core/analysis/vm/model/VirtualCPU.java b/lttng/org.eclipse.tracecompass.lttng2.kernel.core/src/org/eclipse/tracecompass/internal/lttng2/kernel/core/analysis/vm/model/VirtualCPU.java
index 7f7922c601..4e1aaac3b0 100644
--- a/lttng/org.eclipse.tracecompass.lttng2.kernel.core/src/org/eclipse/tracecompass/internal/lttng2/kernel/core/analysis/vm/model/VirtualCPU.java
+++ b/lttng/org.eclipse.tracecompass.lttng2.kernel.core/src/org/eclipse/tracecompass/internal/lttng2/kernel/core/analysis/vm/model/VirtualCPU.java
@@ -23,7 +23,7 @@ import com.google.common.collect.Table;
  *
  * @author Geneviève Bastien
  */
-public class VirtualCPU {
+public final class VirtualCPU {
 
     private static final Table<VirtualMachine, Long, @Nullable VirtualCPU> VIRTUAL_CPU_TABLE = HashBasedTable.create();
 
diff --git a/lttng/org.eclipse.tracecompass.lttng2.kernel.core/src/org/eclipse/tracecompass/internal/lttng2/kernel/core/analysis/vm/model/VirtualMachine.java b/lttng/org.eclipse.tracecompass.lttng2.kernel.core/src/org/eclipse/tracecompass/internal/lttng2/kernel/core/analysis/vm/model/VirtualMachine.java
index bf5d54e0ba..dbf3153262 100644
--- a/lttng/org.eclipse.tracecompass.lttng2.kernel.core/src/org/eclipse/tracecompass/internal/lttng2/kernel/core/analysis/vm/model/VirtualMachine.java
+++ b/lttng/org.eclipse.tracecompass.lttng2.kernel.core/src/org/eclipse/tracecompass/internal/lttng2/kernel/core/analysis/vm/model/VirtualMachine.java
@@ -18,7 +18,7 @@ package org.eclipse.tracecompass.internal.lttng2.kernel.core.analysis.vm.model;
  *
  * @author Geneviève Bastien
  */
-public class VirtualMachine {
+public final class VirtualMachine {
 
     private static enum MachineType {
         HOST,
diff --git a/lttng/org.eclipse.tracecompass.lttng2.kernel.core/src/org/eclipse/tracecompass/internal/lttng2/kernel/core/trace/layout/PerfEventLayout.java b/lttng/org.eclipse.tracecompass.lttng2.kernel.core/src/org/eclipse/tracecompass/internal/lttng2/kernel/core/trace/layout/PerfEventLayout.java
index 6b83e5aea6..d43f40b65a 100644
--- a/lttng/org.eclipse.tracecompass.lttng2.kernel.core/src/org/eclipse/tracecompass/internal/lttng2/kernel/core/trace/layout/PerfEventLayout.java
+++ b/lttng/org.eclipse.tracecompass.lttng2.kernel.core/src/org/eclipse/tracecompass/internal/lttng2/kernel/core/trace/layout/PerfEventLayout.java
@@ -24,7 +24,7 @@ import com.google.common.collect.ImmutableList;
  *
  * @author Alexandre Montplaisir
  */
-public class PerfEventLayout implements IKernelAnalysisEventLayout {
+public final class PerfEventLayout implements IKernelAnalysisEventLayout {
 
     private PerfEventLayout() {}