control: Bug 486586: Allow snapshots in inactive state

Change-Id: Iee0e5a53169f5d573865df4a634da900eaad71cc
Signed-off-by: Bernd Hufmann <Bernd.Hufmann@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/65215
Reviewed-by: Hudson CI
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>

Change unnecessary declaration of thrown exception to warning in tests

Change-Id: I4c5fe96c227b3cf89d26b46ded8dc318eb62060b
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/64410
Reviewed-by: Hudson CI
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>

ctf: remove StructDeclaration#getFields()

this exposes an internal map and can be dangerous

Change-Id: Icc1d5ecbd7d5dc5eab472b314669312ffe26a8a6
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/64118
Reviewed-by: Hudson CI
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>

ctf: enhance unit tests around EnumDeclaration

Change-Id: If6f6cc514e13a8dbe50738cb6a7c41cd0c47f351
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/64429
Reviewed-by: Hudson CI
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>

tmf.ui: add test for Control Flow view dialogs

Change-Id: I433af57a2a2e713bc1c74a712d7d1b927c48c838
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/64119
Reviewed-by: Hudson CI
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>

xml: bug 486434 bring analysis module source back to core plugin

Change-Id: I2ead4d309cdd8e633b2990b020bbaf05bd08775c
Signed-off-by: Geneviève Bastien <gbastien+lttng@versatic.net>
Reviewed-on: https://git.eclipse.org/r/65116
Reviewed-by: Hudson CI
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>

xml: remove dependency to ui element from the module source

The TmfXmlAnalysisOutputSource class is now advertised with the 'listener'
element of the analysis extension point.

Change-Id: I7ac2be77774f029e29eabd643e6fd891317bd898
Signed-off-by: Geneviève Bastien <gbastien+lttng@versatic.net>
Reviewed-on: https://git.eclipse.org/r/65115
Reviewed-by: Hudson CI
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>

tmf: Add a listener element to the analysis extension point

This element allows to add listener classes that will be registered to
the
analysis manager.

Change-Id: I65fc1949350156ec945db6c2a48020f8aec3e9f7
Signed-off-by: Geneviève Bastien <gbastien+lttng@versatic.net>
Reviewed-on: https://git.eclipse.org/r/65114
Reviewed-by: Hudson CI
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>

xml: remove dead store of value in XmlPresentationProvider.java

Change-Id: I50bf309c3aa38b8bf4d09ada185cb4be52708410
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/64702
Reviewed-by: Hudson CI
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>

analysis: Fix sonar warnings in CFV column sorting code

Change-Id: I4f4bb7e367946e9b9acb46414962722eb156eb87
Signed-off-by: Bernd Hufmann <Bernd.Hufmann@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/65105
Reviewed-by: Hudson CI
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>

lttng: Handle compat_syscall_exit_* events correctly

The compatibility layer syscall entry events were handled correctly,
but not the corresponding exit ones.

Bug: 486351

Change-Id: I2709a406eec805a8410651972fac618dcaf27dc4
Signed-off-by: Alexandre Montplaisir <alexmonthy@efficios.com>
Reviewed-on: https://git.eclipse.org/r/65134
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-by: Hudson CI

lttng: Remove unneeded @Nullable annotations in KernelStateProvider

The event name can not be null, so these utility methods could use
@NonNull parameters.

Change-Id: Ib651dc89e1e3da434c6e5bed2cb222f764346868
Signed-off-by: Alexandre Montplaisir <alexmonthy@efficios.com>
Reviewed-on: https://git.eclipse.org/r/65133
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-by: Hudson CI
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>

Improvements to Oomph setup

-The Eclipse ini redirection makes your IDE use the local setup from
your git clone for that IDE's setup. This way you can edit your setup,
test the changes locally, and then commit it.
-Add features necessary in the Eclipse installation so that you can use
any Eclipse package to develop Trace Compass. For example, you can
select Eclipse for C/C++ and it will still install PDE, etc.

Change-Id: I06a2700a79b724ade54f5c961f64835ddc5a8dd0
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/64815
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-by: Hudson CI

ctf: Speed up TestInvalidCtfTrace

- Do not delete project every test
- Do not delay when opening the editor

Change-Id: I40032167cfec2ea8d99fc81974d142ab82befb3a
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/64942
Reviewed-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>

ctf: Speed up StandardImportAndReadSmokeTest

- Only clear the trace folder at the end of a test
- Only do the views sanity check for a couple of tests

Change-Id: I731bc8a59b704c86dca87cfa74365d5b09bc3e56
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/64941
Reviewed-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>

Replace references to TreeSet with NavigableSet in InMemoryBackend

Change-Id: I74f6fc7d6292406a552abd6ba20d5538fabbf8a4
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/65034
Reviewed-by: Hudson CI
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>

Remove references to ArrayList<> in fields of TimeChartView

Change-Id: Icb4bc0a248b93c7e83540a2d0cf66c8b672de7ae
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/65035
Reviewed-by: Hudson CI
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>

Make some inner classes static

These classes are inner classes, but they do not use its embedded
reference to the object which created them.  This reference makes
the instances of the class larger, and may keep the reference to
the creator object alive longer than necessary.

The classes should be static.

Change-Id: I76982a42e10fa89ea7e18524914605d60016fbf3
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/65036
Reviewed-by: Hudson CI
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>

analysis: Add context switch core tests

Change-Id: I8b044f66608a0aa36393cdda2fc89f1724a6f42c
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/56487
Reviewed-by: Hudson CI
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>

analysis: introduce context switch analysis

Change-Id: Iccde08930c6111b93e16bab7d6d3e1b894c9c557
Signed-off-by: Alexis Cabana-Loriaux <alex021994@gmail.com>
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/53413
Reviewed-by: Hudson CI
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>

Make LostEventDeclaration final

Classes with only private constructors should be final.

Change-Id: Ib4d9344fcf5c65449eb84e04d970b90016d683af
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/64944
Reviewed-by: Hudson CI
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>

vm: change private method to take a List instead of ArrayList

Declarations should use Java collection interfaces such as "List"
rather than specific implementation classes such as "LinkedList"

The purpose of the Java Collections API is to provide a well defined
hierarchy of interfaces in order to hide implementation details.

Implementing classes must be used to instantiate new collections,
but the result of an instantiation should ideally be stored in a
variable whose type is a Java Collection interface.

Change-Id: I380287ab4b425167e6378f1b0c4d9aa1af4a8b02
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/64943
Reviewed-by: Hudson CI
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>

documentation: Add documentation for Latency views

Change-Id: If3c4366e4e2f0c8aa876833ae85467a98e71ca3a
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/64610
Reviewed-by: Hudson CI
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Patrick Tasse <patrick.tasse@gmail.com>

analysis: support for sorting of control flow view columns

Each column in the control flow view can be now sorted by clicking on
the column header. By default, it's sorted by birth time. For an
experiment the traces are sorted independently. The tree hierarchy is
kept, i.e. tree level is sorted separately.

An API has been added to support sorting of time graph entries
(ITimeGraphEntry) generically.

Change-Id: I05631ca69ea5cd57cdd97b3815cc263e7de9e43e
Signed-off-by: Bernd Hufmann <Bernd.Hufmann@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/64403
Reviewed-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Patrick Tasse <patrick.tasse@gmail.com>

lttng: Fix thread ordering in virtual machine view

Threads in the virtual machine view are now ordered by their numeric thread IDs
instead of the corresponding string which makes it more intuitive.

Change-Id: I681e3423dcea9e946b74bebe4e2d0416680ccfa9
Signed-off-by: Geneviève Bastien <gbastien+lttng@versatic.net>
Reviewed-on: https://git.eclipse.org/r/64205
Reviewed-by: Hudson CI

rcp: Add profile to build only one rcp (one environment)

When running validation builds (Gerrit trigger), we don't need
to build all environments. A failure to assemble the product on
only one platform is highly unlikely and would be caught by the
nightly build, at worse.

This patch adds a profile so that only one environment is built
(Linux 64).

Change-Id: Icba6d6a1b01da605db6fe19cceb2e3a2b3694315
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/64784
Reviewed-by: Hudson CI

lttng: VirtualMachineView: extract some methods to simplify the class

This fixes some sonar warnings that methods were too complex. Some
repeated code was also extracted to a method so that both thread and CPU
entries can make use of it.

Change-Id: I18af32bfb2d16d63ee80e0bb1aba0664728ca633
Signed-off-by: Geneviève Bastien <gbastien+lttng@versatic.net>
Reviewed-on: https://git.eclipse.org/r/64617
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-by: Hudson CI

tmf : Improve toString() in TmfXmlStateValue and TmfXmlCondition

Change-Id: I25dc5961d71c84a6c3af82d6669a45fedcaa1504
Signed-off-by: Jean-Christian Kouame <jean-christian.kouame@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/64804
Reviewed-by: Hudson CI
Reviewed-by: Genevieve Bastien <gbastien+lttng@versatic.net>
Tested-by: Genevieve Bastien <gbastien+lttng@versatic.net>
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>

ctf: Introduce IEventDefinition

This interface is extracted from EventDefinition. It allows all of
IEventDeclaration to return only the interface and leave the internals
in the internal folder.

This should improve the maintainability of the CTF plugin without impacting
performance or testability.

Change-Id: I398c4440c67738eaa80a2e63e6d562352d0d64a8
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/64412
Reviewed-by: Hudson CI
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>

tmf.ui: Fix dead store in TimeAlignmentSynchronizer

The algorithm in getReferenceView should pick the view with left-most
time-axis position (to maximize viewing area). It was written like
that originally but a break statement snuck in.

Change-Id: I177c512d9b6553fb553d8eda6e2ab833aa3867c9
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/64716
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-by: Hudson CI

lttng: Fix sonar warnings in VirtualMachinePresentationProvider

Change-Id: I27d475f49da87af2e81337e4ad8ea856b6722d4f
Signed-off-by: Geneviève Bastien <gbastien+lttng@versatic.net>
Reviewed-on: https://git.eclipse.org/r/64616
Reviewed-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>

lttng: Fix sonar warnings in VirtualMachineViewEntry

Change-Id: I85b1bd21b93aaa5680af56bc80468ae70242438e
Signed-off-by: Geneviève Bastien <gbastien+lttng@versatic.net>
Reviewed-on: https://git.eclipse.org/r/64615
Reviewed-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>

tmf.ui: ensure that the Histogram's text label is layouted

Change-Id: I399c98892b96953c7a310cc0c90ffea53103014e
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/64714
Reviewed-by: Hudson CI
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-by: Jean-Christian Kouame <jean-christian.kouame@ericsson.com>

Print some environment information at the start of SWTBot

This will help us investigate failing tests in the case where the
environment differs from what is known to work.

Change-Id: I4b6cf42355050bf57d420a5a95df4e1b35618fe2
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/64723
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-by: Hudson CI

tmf.ui: avoid dead store in deleteHandler

Change-Id: I5918ccd5408502fceda12c447d0d40d27c9e218c
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/64715
Reviewed-by: Hudson CI
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>

Fix typo in System call density vs time title

Change-Id: I587a9af2bc01d6b5a74e69c42c53fbd4d8f88bb1
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/64608
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-by: Hudson CI

tmf : fix the 'Not' condition in TmfXmlCondition

Now, a 'Not' condition "Not X" will create a subcondition using its
first children instead of itself; which was actually creating the
condition "X".
Also, this patch update TmfXmlConditionTest to validate the fix.

Change-Id: I5b14d345c652a8eb553728c56ba6933b87a56ddd
Signed-off-by: Jean-Christian Kouame <jean-christian.kouame@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/64309
Reviewed-by: Hudson CI
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>

ctf: no longer rely on default character encoding in Metadata.java

Change-Id: I0aac8cbcef9871352545101978c09916278e59c5
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/64411
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-by: Hudson CI

ctf: no longer invoke new String() in Metadata.java

Change-Id: Iba97dcb55d36fbb2a641f6597dbf04fb4544a8fa
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/64408
Reviewed-by: Hudson CI
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>

ctf: fix Modifier order to always be static final

Change-Id: I8ec44295ad279240e41af6e3442d5b9aa3de7dfd
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/64407
Reviewed-by: Hudson CI
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>

ctf: make all parser implementations final classes

Change-Id: I9c7bff1388e02832c3bcee80ee891faa91a0f5ed
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/64406
Reviewed-by: Hudson CI
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>

analysis: Add grid in density viewer

Change-Id: Ic497fc36386f2ad0daaddc5cb263f16cd21b7676
Signed-off-by: Bernd Hufmann <Bernd.Hufmann@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/64500
Reviewed-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>

Exclude more Sonar rules that are not working with jdt.annotation

A recent update to the Sonarqube server introduced a few new rules
that are not working with jdt.annotation. This is similar to the
previous ones that were disabled. See
https://git.eclipse.org/r/#/c/61292/
and
http://sourceforge.net/p/findbugs/bugs/1425/

Change-Id: I983d1656d667f8c8fd48489273d33f49761f22f1
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/64427
Reviewed-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>

releng: Update test-traces to 1.2.0

This new version contains the perf-CTF trace from Bug 484854.

Change-Id: Iedcecf76d7dc3731e4a50726e2f749a2ea7e593b
Signed-off-by: Alexandre Montplaisir <alexmonthy@efficios.com>
Reviewed-on: https://git.eclipse.org/r/64428
Reviewed-by: Hudson CI
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>

tmf: Make columns in TimeGraphCombos moveable by default

An example implementation is the Control Flow view.

Change-Id: I9d801a8c30b6ae3c8a0b30e2bf0eb28d761d1833
Signed-off-by: Bernd Hufmann <Bernd.Hufmann@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/64404
Reviewed-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>

Revert "tmf: Remove an annotation temporarily to work around Sonarqube bug"

This reverts commit d0da59edb3bd54ed5d8e8d2f81649b67755efebd.

The bug was fixed in Sonarqube (sonar-java 3.9) so this commit can be reverted.

Change-Id: Ic6e003f957f72b8f1d705037da116d1895370c35
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/64085
Reviewed-by: Hudson CI

LTTng: Add a virtual CPU view for the virtual machine analysis

This view shows for each guest the status of its virtual CPUs (running or
preempted) as well as a modified view of the threads running on them to
highlight when it was thought to be running, but was actually preempted on the
host.

Change-Id: Id260abc6d43e868ba261714de64c5530596de7ff
Signed-off-by: Mohamad Gebai <mohamad.gebai@polymtl.ca>
Signed-off-by: Geneviève Bastien <gbastien+lttng@versatic.net>
Reviewed-on: https://git.eclipse.org/r/37602
Reviewed-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>

ctf: split up IOStructGen into 44 files

IOstructGen is a very large file, it is hard to test and maintain, this patch
splits it into 42 files.

This patch has several benefits. It does the following:
* decreases the complexity of the file IOStructGen.
* improves the modularity of the TSDL parser.
* is very friendly to code navigators as the links of who calls who
    are more obvious.
* improve testability of the parser.
* improve navigability in code.
* use a single pattern so each section is drop-in replaceable.
* add null checks at strategic places.
* ridiculously improve javadoc.
* add null annotations
* improve validation of data

Performance is similar.

Change-Id: Ie13ab1673d40b36087e7ce78d81b5379063ea3a1
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/56740
Reviewed-by: Hudson CI
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>

ss: Bug 485304: Incorrect interval returned in history tree full query

Change-Id: Ic68f991a168d5156a2d7a22dbc62b63b307f432f
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/63687
Reviewed-by: Alexandre Montplaisir <alexmonthy@efficios.com>
Reviewed-by: Hudson CI

Update sonar-maven-plugin to 2.7.1

This fixes a bug that I was experiencing on a different Hudson server
https://jira.sonarsource.com/browse/MSONAR-122

Change-Id: Iee0aa27b1d025bc25b843432892bbff428bc8d69
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/64383
Reviewed-by: Hudson CI
Reviewed-by: Alexandre Montplaisir <alexmonthy@efficios.com>

tmf: Try expanding a second time when tree expand fails

This will stabilize StandardImportAndReadSmokeTest.
Sometimes in a JFace TreeViewer, it expands to nothing.
It looks like a timing issue with an update job started by the viewer.
This is a work around until we can investigate some more.

Change-Id: I01ead54ec7ff7baaf64e1184c3a5cae8906b86a9
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/60677
Reviewed-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>

analysis: Update unit formatter for segment store

Change-Id: I5bd654504e4fb91f9c5b66ffac9737dd69e1ad5a
Signed-off-by: Bernd Hufmann <Bernd.Hufmann@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/64302
Reviewed-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>

xml: bug 484257: allow to define values anywhere in the file

Values and locations do not have to be defined at the beginning of the file.
They should however precede any eventHandler related to it.

Change-Id: I27ce894f03b093d180d651a00325608228308273
Signed-off-by: Geneviève Bastien <gbastien+lttng@versatic.net>
Reviewed-on: https://git.eclipse.org/r/64139
Reviewed-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>

analysis: make scatter charts y axis use a human readable time format

Change-Id: I450dbf1e931420288f66e7b1c3c08e3d2d772191
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/63798
Reviewed-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>

analysis: make statistics show standard deviation

Also format time in a readable manner. Warning, this changes the behavior
of HumanReadibleTimeFormat. It now shows its decimals all the time.

Change-Id: If810ed09462fdaa09924945a2e5930debd7990e5
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/63788
Reviewed-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>

analysis: make statistics view use a more legible format

statistics will now display times using units and 3 significant
decimals as opposed to the way they were displayed before (unitless
left-aligned nanoseconds)

Change-Id: I35cfeeb7d038ac2b9f52f3648c3e4337a6ec279c
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/63787
Reviewed-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>

analysis: rename DensityTimeFormat to SubSecondTimeWithUnitFormat

Make it public.

Change-Id: I6adf91b7b15ccc96105f35940641d65704b1ab3d
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/63786
Reviewed-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>

ss: Bug 485463: Incorrect parent sequence number in HTNode

When creating a new 'latest branch' in HistoryTree.addNewRootNode(), the
new nodes' parent sequence number is incorrectly set to their parent's
parent sequence number instead of their parent's sequence number.

The toString() implementation of HTNode used for debugging purposes is
augmented to show the sequence number of parent and children nodes. This
helps in debugging problems such as this one.

Change-Id: Ie6ec689bb28c72eda612d4279b6d27ead7ecc42c
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Signed-off-by: Alexandre Montplaisir <alexmonthy@efficios.com>
Reviewed-on: https://git.eclipse.org/r/63898
Reviewed-by: Hudson CI

control: Update MI parsing for configured event filters

The MI for filter element contains true if a filter has been configured
and false if not.

Change-Id: I146c7b1da4ecdd8aa3df66f443bd7fe9d9772813
Signed-off-by: Bernd Hufmann <Bernd.Hufmann@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/63870
Reviewed-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>

control: Improve check for empty strings

Change-Id: I1d1c6d6e6bf33a3d2eb424683f702d170cde5746
Signed-off-by: Bernd Hufmann <Bernd.Hufmann@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/63861
Reviewed-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>

analysis: Move timing analysis ui classes in own java packages

With this patch, the timing analysis base classes for table, scatter
density and statistics are in their own java packages.

Change-Id: I2a2892c4aec8f649dbec8fa159c0b2344fc5803e
Signed-off-by: Bernd Hufmann <Bernd.Hufmann@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/64010
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-by: Hudson CI

control: remove calibrate command

This feature never really was fully implemented in LTTng runtime and
because of that should not be there in the Control view.

Change-Id: I7573bcacf0fcf05f86d688d9ef7b4aafec735a9a
Signed-off-by: Bernd Hufmann <Bernd.Hufmann@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/64029
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-by: Hudson CI

control: Remove remaining AllTests.java from test plug-ins

Change-Id: I119996728bd32a6b9d689457d1d60952939107ac
Signed-off-by: Bernd Hufmann <Bernd.Hufmann@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/63756
Reviewed-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>

tmf: Fix IllegalArgumentException in TimeGraphCombo

Change-Id: I4e2dcba654d1da9b0fa41c7686b0a0095506f28c
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/63663
Reviewed-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>

StateSystem: Aesthetic changes to HT_IO.java

Make CACHE_SIZE have a pre-cached MASK.
Add comments.
Rename variables.
Remove "this" references.

Change-Id: Ib3b7c6421b614008f61312b6e22073d2c5c51d94
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/63896
Reviewed-by: Hudson CI
Reviewed-by: Alexandre Montplaisir <alexmonthy@efficios.com>

Bug 483621: Move segment store statistics into timing analysis plug-ins

Also, o.e.t.analysis.timing.core.tests is introduced.

Keep packages internal for now since APIs not finalized.

Change-Id: I5a5d4abfd409ff8498d304f97f3c123e0b7a421b
Signed-off-by: Bernd Hufmann <Bernd.Hufmann@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/63891
Reviewed-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>

tmf: Make font depend on item height in time graph

The font used for drawing item names and state labels is now dependent
on each item's height.

The time graph combo no longer has to adjust the time graph control's
font when zooming vertically.

A map of fonts per height is used.

The item state rectangles are adjusted to use less margin height when
the item height is decreased.

Change-Id: I1838855d864e76646bc8e387682ca0cb3c28c418
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/62980
Reviewed-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>

doc: Correct lttng session load description for conflicting profiles

Change-Id: Ic99b0e9503d00291072c5cac29feedd7fa3a1e13
Signed-off-by: Bernd Hufmann <Bernd.Hufmann@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/63760
Reviewed-by: Hudson CI
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Patrick Tasse <patrick.tasse@gmail.com>

Use pom-less plugins where we can

Tycho 0.24 introduced pom-less builds [1]. With this, we can
remove the pom.xml in any plugin, test or feature plugin that
uses the default configuration.

This bumps the minimum required version of Maven to 3.3.

Some plugins have extra specific configuration in their pom,
like ctf or pcap traces that call maven-antrun-plugin to
download test traces. These will still need their usual pom.xml
file.

For test plugins, the top-level pom defines the configuration
used for *core* tests. UI and SWTBot tests use slightly
different parameters. Instead of repeating this information in
every single plugin, we can define profiles that are only
activated in those plugins.

Using empty files to selectively enable these profiles looks a
bit clunky, but it is the simplest solution I have found.
Suggestions welcome!

[1] https://wiki.eclipse.org/Tycho/Release_Notes/0.24#POM-less_Tycho_builds

Change-Id: Ibd379905ca52cd1535b8f5a92e58e1f1fb311a19
Signed-off-by: Alexandre Montplaisir <alexmonthy@efficios.com>
Reviewed-on: https://git.eclipse.org/r/63050
Reviewed-by: Hudson CI

doc: update user guide for kernel event filtering in Control view

Change-Id: I05da02b91b5b9bf1d73a4ae8c038f559d1744c87
Signed-off-by: Bernd Hufmann <Bernd.Hufmann@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/63648
Reviewed-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>

control: add SWTBot test to test kernel filtering for events

Change-Id: I5de303ba182942b42cccb94db3995f0877cee5bd
Signed-off-by: Bernd Hufmann <Bernd.Hufmann@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/63592
Reviewed-by: Hudson CI
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>

control: Support for filtering of kernel events

This feature is supported since LTTng Tools v2.7.0.

Change-Id: I1a17d6cc3807050bc15c8dd0eb6a763bbe4fb699
Signed-off-by: Bernd Hufmann <Bernd.Hufmann@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/63591
Reviewed-by: Hudson CI
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>

analysis.test: add basic swtbot test for scatter charts

Change-Id: I35c19e240c66628a892646ae19ec6706324f2400
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/63682
Reviewed-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>

analysis.test: add basic tests for SWTChart in DensityViewerTest

Change-Id: I0efc9c1ebe7ef32fad7e4a455f75c64ce9e07447
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/63680
Reviewed-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>

analysis.test: add SWTBot test to Density view

Change-Id: I1f0932ebabb40ee15b45ed0b363b7883d069bcc6
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/63596
Reviewed-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>

TMF: Bug 454283: Initialize all analysis modules before executing them

Analysis modules are first initialized, then automatic ones are executed when
the traceOpened signal is received. This makes sure any dependent module
exists for a trace before the execution takes place.

Change-Id: Ica4d77ca5805b37ec73a42af2b9bc5f15c9e21cd
Signed-off-by: Geneviève Bastien <gbastien+lttng@versatic.net>
Reviewed-on: https://git.eclipse.org/r/37698
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-by: Hudson CI

Remove API tooling from test plugins

We do not track the API of test plugins so it is not necessary to have
them configured for API tooling. This could lead to errors in the case
where the API baseline contained some test plugins. In Oomph, for
example, the API baseline is just a zip of the complete update site, so
it does contain the test plugins and this triggers errors.

Change-Id: I6bd735c2890ae5eaf329316d4f1bae43348c2281
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/61839
Reviewed-by: Hudson CI
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Patrick Tasse <patrick.tasse@gmail.com>

doc: Add user guide for LTTng session profiles

Change-Id: I42f7de09aa21d66e9e137ee89f15d275f7d3b47f
Signed-off-by: Bernd Hufmann <Bernd.Hufmann@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/63665
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-by: Hudson CI

analsysis: Remove lingering alltest.java

Change-Id: I036ecf7c79a477cd75a149123af5d7e0a6fd1dbb
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/63593
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Reviewed-by: Hudson CI

analysis: fix Loose Coupling and int division to double conversion

AbstractSegmentStoreDensityViewer is fixed and made more portable.

Change-Id: Ic7ca60aefb308eaa4a00c914cb7dff6b274c4bb7
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/63646
Reviewed-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>

analysis: fix modifier order for AbstractSegmemtStoreDensityView

Change-Id: Ibd1dc5a4a55f1063c5fda0624597cab06be49ed4
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/63651
Reviewed-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>

tmf : add of a range selection from other sources for the tmfEventsTable

Only the events within the range will be selected. If there is no event
within the range of the selection, we select the next event outside of
the range. For a single selection, the event at or the next event after
the requested timestamp is selected.

Change-Id: I1294da7e5d653477502ca45f9430a5e5c8583187
Signed-off-by: Jean-Christian Kouame <jean-christian.kouame@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/57526
Reviewed-by: Hudson CI
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Patrick Tasse <patrick.tasse@gmail.com>

analysis: simplify perSyscallStats iteration

Change-Id: Ibac78c3912ac647ec90add64f2a2f16ce90539ef
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/63496
Reviewed-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>

Latency: introduce latency density view

This patch introduces a view to view segment densities. The
view is based on SWTChart's bar graph. Its x axis is NOT
time aligned as it is not on the main timeline. It takes
the liberty to display time in a more "human readable"
form showing a scale and up to 3 decimals max. (1.234 ms)

There is a second part to this view: a selection table.
This table shows the selected segments from a drag operation.

Follow up tasks for this can be to introduce other filters and
improve the tooltips.

An example implementation is provided for the SystemCall analysis.

Change-Id: I238a61dc8eeeefdca0da107424686a64fb63d8c3
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/57573
Reviewed-by: Hudson CI
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Patrick Tasse <patrick.tasse@gmail.com>

Some cleanups related to investigating redundant null checks

Change-Id: I6c71c90c2d61fe4c4c3d30c8b1fb1cb0c9eac2f2
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/61197
Reviewed-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>

tmf: Avoid recursion in AbstractSegmentStoreTableViewer pack listener

In the SWT.SetData listener TableColumn.pack() is called. This requires
all visible items from being filled in order to pack the column. For
each visible item a SWT.SetData event is fired which triggers another
TableColumn.pack().

In Windows, after 12 such iterations in the stack, the table somehow
behaves badly and the OS incorrectly returns an item count of zero,
which causes ArrayIndexOutOfBoundsException and other problems.

Since the intention is to pack the columns only once, the SWT.SetData
listener is removed before the pack instead of after the pack, thus
avoiding the recursive calls.

Change-Id: Id44c54a474ed6e04aa2d79c051d863011f55a8aa
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/63513
Reviewed-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>

analysis: fix @NonNull issues with SystemCallLatencyStatisticsViewer

Change-Id: I2d14203943774a9447f618a76d300e509a2e212d
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/63495
Reviewed-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>

tmf: Fix remote.ui test on Windows due to line separators

This can happen when core.autocrlf is set to false in the git config.
The file containing an expected string is then not converted to crlf and
since the generated string in the test contains crlf, the comparison
fails.

To make tests consistent everywhere, I suggest to disable the autocrlf
of git directly in the Git repository using .gitattributes, see
http://git-scm.com/docs/gitattributes

And to fix the test on Windows, we can always convert the generated
String to lf line endings.

Change-Id: Ife8912ace7895ebca4d19adb53c6ba169ca2d003
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/63080
Reviewed-by: Hudson CI
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Patrick Tasse <patrick.tasse@gmail.com>

tmf: Fix failure in StandardImportGzipTraceTest related to test ordering

If TmfAlignTimeAxisTest ran before, and the window size was small
enough, it was possible for the test to be running in an "Align 1"
perspective with insufficient height for the events table. Because of
that, the expected content in the table could not be found. The tests in
TmfAlignTimeAxisTest switch to generated perspectives without returning
to a "normal" perspective. It makes sense that the tests "cleanup" by
returning to a more normal perspective like the Tracing perspective.

Also switch to Tracing perspective explicitly in
StandardImportGzipTraceTest which is more consistent with the other
tests and is somewhat less error prone.

Change-Id: I0d28af39266bdcdc81e765b5522c92a4a8085602
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/63081
Reviewed-by: Hudson CI
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Patrick Tasse <patrick.tasse@gmail.com>

Clean up top-level pom.xml

Re-arrange entries, fix indentation and add spacing to make the
whole file more readable.

Also specify <project.reporting.outputEncoding> (removes a
warning in the build output).

Change-Id: Ia508f2b24de0813fbaf8d9db1e79e755e351ac5f
Signed-off-by: Alexandre Montplaisir <alexmonthy@efficios.com>
Reviewed-on: https://git.eclipse.org/r/62348
Reviewed-by: Hudson CI
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>

rcp: Update RCP product plugin's ID

It was simply "tracing", typically our artifactIds include the
whole symbolic name of the plugin.

Change-Id: I46a0faf45f18c64bf8005ad90cf2744e8bcb53d9
Signed-off-by: Alexandre Montplaisir <alexmonthy@efficios.com>
Reviewed-on: https://git.eclipse.org/r/63059
Reviewed-by: Hudson CI
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>

ctf: make computeAttributeMap return a Map instead of ImmutableMap

Change-Id: Iba609c83c20f11b26bd7b4db7deb2242ad41cdf6
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/63058
Reviewed-by: Alexandre Montplaisir <alexmonthy@efficios.com>
Reviewed-by: Hudson CI

ctf: fix modifier order of @Nullable annotation

Change-Id: Ib5f40b243b6ecae25fda50dd09ef7c8df16e36f7
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/62951
Reviewed-by: Hudson CI
Reviewed-by: Alexandre Montplaisir <alexmonthy@efficios.com>

Fix main shell not active using Xvfb

There seems to be problems on some system where the main shell is not in
focus initially. This was seen using Xvfb and Xephyr on some occasions.

Change-Id: Ib6dda93e856deb96cf865dce6253b48c99171184
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/62979
Reviewed-by: Hudson CI
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>

tmf.ctf: Accelerate ByteArrayDefintion parsing

Make BADs no longer need to generate definitions uselessly.

This patch yields a 15-50% acceleration in Synchronization benchmarks,
a 5% acceleration in the Kernel Analysis benchmark, and an average event
size reduction of 33%.

Change-Id: Ie581abaecf1d8b188de9f1acc3010fe3f7a65d7a
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/52024
Reviewed-by: Hudson CI
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>

ctf: Collapse if statement in StructDefinition

Change-Id: I2736507e0ebbee70a172930cd4315c89872eb001
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/51857
Reviewed-by: Hudson CI
Reviewed-by: Francis Giraldeau <francis.giraldeau@gmail.com>

Remove all "AllTests" suites

tycho-surefire-plugin's default configuration is to look for @Tests
in classes that start or end with "Test", or end with "TestCase".

We can make use of this and avoid all the nested AllTests.java suites
found in every single test package in the tree. This also avoids
the need for most custom configuration in each test plugin's pom.xml.

To run a complete test plugin from within Eclipse, one can still
right-click on the plugin itself, and choose
Run As -> Junit Plug-in Test.
(Doing this before this patch would actually run all tests twice!)

Note: this breaks the suites in the "alltests" plugin, but those could
be brought back by using something like ClasspathSuite, if desired.

Change-Id: Ibf960df37c5d3c98dc0e0dd722d7c9fe5c0b9d4f
Signed-off-by: Alexandre Montplaisir <alexmonthy@efficios.com>
Reviewed-on: https://git.eclipse.org/r/59442
Reviewed-by: Hudson CI
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>

tmf: Fix GTK bug when setting top item after changing tree font

Change-Id: If2658c1bdcd98f6a34ce31a76af0dc57c959de2c
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/62953
Reviewed-by: Hudson CI
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>

analysis: Make SystemCallLatencyTableAnalysisTest more stable

Even if the jobs are finished, the table is not necessarily filled yet.
The update could be pending as a event in the UI thread queue, etc. We
can wait until cells are filled instead.

Also export the package so that it can be used elsewhere, (alltests
stress test for example).

Change-Id: I8177c7e6b7e487d59b248e0279c6bcd8da43b515
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/62959
Reviewed-by: Hudson CI
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Patrick Tasse <patrick.tasse@gmail.com>

tmf: Support vertical zoom in time graph with Shift+Ctrl+Mouse Wheel

Change-Id: Ie5486855cd29c95ee3b0d7caad0ceac6c184d725
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/62534
Reviewed-by: Francis Giraldeau <francis.giraldeau@gmail.com>
Reviewed-by: Hudson CI