tmf: bug 493661 Return analyses who apply to experiment

When the requested traceclass is TmfExperiment, the analysis who have
appliesExperiment set to true will be returned.

Change-Id: Icfc3201029d8b04237287c693f8cbe1708827b56
Signed-off-by: Geneviève Bastien <gbastien+lttng@versatic.net>
Reviewed-on: https://git.eclipse.org/r/72984
Reviewed-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>

linux.ui: make Kernel Memory view handle out of range requests

This is a common use case with experiments that have multiple nodes

Change-Id: I3a2bcd583473cb9bd9fa6f5a2d69eecb9e4fb291
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/71105
Reviewed-by: Hudson CI
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>

linux.ui: make CPU usage view support experiments with kernels.

Time queries now clamped to the range of the state system.

Change-Id: Ifa4750bbfe57d5e2df34cc418553644d3891c377
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/72855
Reviewed-by: Hudson CI
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>

lami: add NLS to Exception message

Change-Id: I8bc41b9590d9955eb87f4f36417c0ff317b07f1e
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/73687
Reviewed-by: Hudson CI
Reviewed-by: Jean-Christian Kouame <jean-christian.kouame@ericsson.com>
Reviewed-by: Genevieve Bastien <gbastien+lttng@versatic.net>
Tested-by: Genevieve Bastien <gbastien+lttng@versatic.net>

tmf: fix bug 489217. Use of ArrayListStore instead of TreeMapStore

Use of ArrayListStore instead of TreeMapStore for the pattern analysis

Change-Id: Ie247297936a4cf89b8bdf7b53b48625ce3cf34cd
Signed-off-by: Jean-Christian Kouame <jean-christian.kouame@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/73306
Reviewed-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>

linux.core: Intern SystemCall name string

This patch makes SystemCall mutable.

This is a tricky situation. This object is serializable.
In order to internalize the string (name) the object needs
to have a custom readObject().

This means we need to either make the name field mutable or
use reflexion to make the field modifyable. If we are using
reflexion, the point of making an object immutable is moot.

Here are the main reasons for an immutable object:

* immutable objects are simpler to construct, test, and use
* truly immutable objects are always thread-safe
* they help to avoid temporal coupling
* their usage is side-effect free (no defensive copies)
* identity mutability problem is avoided
* they always have failure atomicity
* they are much easier to cache
* they prevent NULL references, which are bad

As SystemCall has no setters, and the class is now final,
its fields are in practice immutable.

This begs the question though, would having no "final" keyword
on a field affect performance. Unfortunately no. Final classes
can be inlined, but final fields yield no advantage other than
code clarity.

We should still strive to have final fields whenever it is
possible, but this should not cause ideological objections,
as it breaks clean serialization.

This partially addresses bug 489217

Change-Id: I80a99128dffebe1fb3c0561ab76beabea2cc7775
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/72995
Reviewed-by: Hudson CI

releng: Update targets for Neon RC2

Change-Id: I5050420978f8b3e69e55a6ad7cb7f4586eae00c2
Signed-off-by: Bernd Hufmann <Bernd.Hufmann@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/73581
Reviewed-by: Hudson CI
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>

analysis: add Latency Statistics UI test

This tests the total, the number of distinct syscalls
and tests some random nodes.

Change-Id: Ied0aab3958b75de20eb2368d0beafb1c123c6987
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/62555
Reviewed-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>

tmf: Bug 494197: Empty event list for CallStackEntry when no process

The three-level deep loop to populate the event list from the build
thread did not reach the third level if a trace did not have processes
or threads. The loops are replaced with a recursive consumer.

Change-Id: Ie7eebb57f562bad0c6620ae08fcde8b585c52ca9
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/72916
Reviewed-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>

ctf: Add test for 8-byte integer sign extension bug

The added test highlights bug 491382.

Change-Id: I1e9c1f458ef64145e4f4a6dc9d9b6c0521b1065d
Signed-off-by: Alexandre Montplaisir <alexmonthy@efficios.com>
Reviewed-on: https://git.eclipse.org/r/70312
Reviewed-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>

ctf: fix bug 491382. Properly display bytefields

Display byte arrays as signed or unsigned and
thus properly sign extend them.

Note: the order or precendence for Integer Arrays is:
* Strings
* Byte Arrays
* Other Ints

Change-Id: I6d9537f4866648094f20419de87a64478c17e2c9
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/72672
Reviewed-by: Hudson CI
Reviewed-by: Alexandre Montplaisir <alexmonthy@efficios.com>

analysis.lami: Replace OnDemandAnalysisException with CoreException

We may want to pass additional information to the exceptions thrown
when a LAMI analysis does not complete succesfully, like what
type of error should be displayed.

CoreException and IStatus are made exactly for that, and they hook
nicely into ErrorMessage to display, for example, a command-line
stderr output as additional Details in the dialog.

That way, a message like "no results returned" won't look like
a scary error.

Bug: 493941

Change-Id: Id3e6711ac410c3d993b4928a350dc1bdbcf89f5a
Signed-off-by: Alexandre Montplaisir <alexmonthy@efficios.com>
Reviewed-on: https://git.eclipse.org/r/72242
Reviewed-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>

Revert "TMF: Fix behavior of XML time graph views with experiments"

This reverts commit 836d7c77cd2daccf7107d52e6e4bb78891a6ecb3.

The code was no longer needed as the experiments now give their
children's analyses.

Bug 494052

Change-Id: Id4c1d6757733938c67a5dd65827a6e09f30dbdc2
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/73090
Reviewed-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>

analysis.lami: Correctly set axis name if it is defined by one aspect

Bug: 493941

Change-Id: Idc91ef8ff923b1e569ff7e4823ef84c1f94f38b1
Signed-off-by: Jonathan Rajotte <jonathan.rajotte-julien@efficios.com>
Reviewed-on: https://git.eclipse.org/r/72246
Reviewed-by: Hudson CI
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-by: Alexandre Montplaisir <alexmonthy@efficios.com>

analysis.lami: Fix timestamp label not showing on Y axis

The fix is the same as the custom label since it is the same
problem. Put tick angle to 1.

Bug: 493941

Change-Id: I8b302a24474d47dd3c899d0e05e452cec5663cba
Signed-off-by: Jonathan Rajotte <jonathan.rajotte-julien@efficios.com>
Reviewed-on: https://git.eclipse.org/r/72245
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-by: Hudson CI
Reviewed-by: Alexandre Montplaisir <alexmonthy@efficios.com>

linux.core: fix break in build.

Syscall analysis was internalized before the patch was approved.

Change-Id: I254660d5fa28354d4e5f58c84fea39364077c047
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/73225
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-by: Hudson CI

releng: Update targets for Neon RC1

launchbar doesn't have a RC1, only M7.

Change-Id: I8d96a17195439797ffad96bf2c822e7d9ca2b39e
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/73098
Reviewed-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>

analysis: Introduce syscall statistics analysis test

This extracts the kernelCtfTraceStub to allow both tests to use it.

Change-Id: I8cbd51e691d9e9f3ae2d51e2f64e74a9ec6c6176
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/62546
Reviewed-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>

analysis: test System call analysis

This tests the system call latency analysis without the UI.

Change-Id: I15b409a89de59cce4fc03596ab62790387dfea75
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/62323
Reviewed-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>

rcp: Sign the RCP on Mac

The mac signing has to happen between materialize-products and
archive-products goals. Because we only want to do it when the
signing profile is enabled (eclipse.org server), we have to duplicate
some xml to fit the macsigner between the two. I did extract some
variables in order to make the duplication less error prone.

Bug: 488873
Change-Id: I65168e010dc866ef48b643f6aaf30aa94aedefda
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/72976
Reviewed-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>

analysis.lami: Add toolbar to custom charts

For now only a close button action is present. This will
allow removing a single chart, and not all of them.

Bug: 493941

Change-Id: I24c8ee2d64bc9e8da93788f34f380bda4e7a88b8
Signed-off-by: Jonathan Rajotte <jonathan.rajotte-julien@efficios.com>
Reviewed-on: https://git.eclipse.org/r/72244
Reviewed-by: Hudson CI
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-by: Alexandre Montplaisir <alexmonthy@efficios.com>

analysis.lami: Add tests for the LAMI JSON protocol parsing

Some classes and methods were made more public so that they
can be accessed by the test plugin.

Bug: 493941

Change-Id: Ida5567a1257cb643962bf357250325eca200b296
Signed-off-by: Michael Jeanson <mjeanson@efficios.com>
Reviewed-on: https://git.eclipse.org/r/72102
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-by: Hudson CI
Reviewed-by: Alexandre Montplaisir <alexmonthy@efficios.com>
Tested-by: Alexandre Montplaisir <alexmonthy@efficios.com>

releng: Use non-composite repository for Derby

This speeds up the build time by having to do less http requests.
The improvement is even greater when contacting the server gets
occasionally very slow when building on eclipse.org slave.

Change-Id: Idfda43ade332bc61fad11df30810c948391f6407
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/73122
Reviewed-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>

ss: Replace AttributeNotFoundException with IOOBE for quark parameters

Methods that take a quark integer as parameter are changed to throw a
runtime IndexOutOfBoundsException instead of a checked
AttributeNotFoundException.

This makes those methods consistent with other methods that already
throw IOOBE when the quark is out of range.

Many occurrences were already swallowing the exception or re-throwing a
runtime exception.

Change-Id: I943b407e07bbc226c6b7c03306cd6d00f783bca2
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/72198
Reviewed-by: Alexandre Montplaisir <alexmonthy@efficios.com>
Reviewed-by: Hudson CI

lttng: Add System Call Analysis benchmarks

This benchmarks the build time and memory usage of system call latency analysis
on some lttng kernel traces

Change-Id: Ib88063a1468c21b7856f12c00a4d12ce70b6958c
Signed-off-by: Geneviève Bastien <gbastien+lttng@versatic.net>
Reviewed-on: https://git.eclipse.org/r/72974
Reviewed-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>

timing.core: add ArrayListStore implementing ISegmentStore

This store is made for a corner case where we want a slightly more
memory efficient datastore.

This is used by the timing analysis to save a bit of memory at the
expense of intersection times.

This partially addresses bug 489217

Change-Id: I364d498526ac46d357d9788714cea25816efd536
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/72968
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Reviewed-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>

timing.core: Bug 493897 show correct system call columns in density view

Change-Id: Ic98ba2723bb3c2136dfc2adffc36c1f67f38f2b7
Signed-off-by: Bernd Hufmann <Bernd.Hufmann@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/73045
Reviewed-by: Hudson CI
Reviewed-by: Jean-Christian Kouame <jean-christian.kouame@ericsson.com>
Tested-by: Jean-Christian Kouame <jean-christian.kouame@ericsson.com>

tmf.xml: Fix condition ordering to avoid IndexOutOfBoundsException in FSM

If a scenario is not set as initial scenario, then no scenario is created and
the isNewScenarioAllowed method throws a IndexOutOfBoundsException. This patch
reorders the condition so it is first verified that the scenario count is more
than 0

Change-Id: I034e049ce6e1655fccbf6caf03978515285e9b73
Signed-off-by: Geneviève Bastien <gbastien+lttng@versatic.net>
Reviewed-on: https://git.eclipse.org/r/72035
Reviewed-by: Hudson CI
Reviewed-by: Jean-Christian Kouame <jean-christian.kouame@ericsson.com>
Tested-by: Jean-Christian Kouame <jean-christian.kouame@ericsson.com>

linux.core: optimize system calls for memory usage

Drop the arguments and return value and internalize the
Strings.

Change-Id: Id8ab76df2679917e1bcd3e76457ee8f6632bb5b0
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/72939
Reviewed-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Reviewed-by: Genevieve Bastien <gbastien+lttng@versatic.net>
Tested-by: Genevieve Bastien <gbastien+lttng@versatic.net>

segStore: Add a close method to ISegmentStore

This method will close the segment store backend at the end of the analysis or
delete the files that were created if the analysis did not create correctly.

This method will be useful when there is multiple segment store backends, so
that each one can take care of its own saving actions and cleanup.

Change-Id: I7c2bd4c21b9141b0b4f0f3eed2495895299d3dc8
Signed-off-by: Geneviève Bastien <gbastien+lttng@versatic.net>
Reviewed-on: https://git.eclipse.org/r/72931
Reviewed-by: Hudson CI
Reviewed-by: Jean-Christian Kouame <jean-christian.kouame@ericsson.com>
Tested-by: Jean-Christian Kouame <jean-christian.kouame@ericsson.com>
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>

analysis.lami: Show one view per report

Multiple tables in a report will be shown as multiple tabs
in the view. Each tab will have its own graphs. This will
allow naming the views with the report names, so it will be
easier to match a given view to its report.

Change-Id: Ieeef337079d385dfd79f3cc26a3574b800e7754c
Signed-off-by: Alexandre Montplaisir <alexmonthy@efficios.com>
Reviewed-on: https://git.eclipse.org/r/72243
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-by: Hudson CI

analysis.lami: Add support for user-defined LAMI analyses

This patch adds support for adding user-defined LAMI analyses,
as well as removing them, through the UI (project explorer).

A .properties file is created in the workspace for each added
user-defined analysis.

To add a new external analysis, right-click the External Analyses
item in the Project Explorer View, and click Add External Analysis.

To remove an external analysis, right-click the item to remove,
and click Remove External Analysis.

Change-Id: I067f0faf679d2384121a32845864d886ee64e241
Signed-off-by: Philippe Proulx <pproulx@efficios.com>
Signed-off-by: Alexandre Montplaisir <alexmonthy@efficios.com>
Reviewed-on: https://git.eclipse.org/r/72103
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-by: Hudson CI

Adjust @since tags to 1.2 release

Some tags were set to 2.0 temporarily but the API was really added
in 1.2.

Change-Id: I5e2768741bb2f65e5479aac79a035dac59d76074
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/72866
Reviewed-by: Hudson CI

doc: Update documentation for Resources view for execution context

Now the Resources view show IRQs under CPUs and CPUs under IRQs.

https://git.eclipse.org/r/#/c/65609/

Change-Id: I36fe7156e66fdb6dec2c580be024c27a1c67ba74
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/72581
Reviewed-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>

linux.core: internalize System Call Analysis

This analysis is an implementation of the segment store, it should be
internal

Change-Id: Ifc246608b65c5f09ae11ac2386ee31d462bce825
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/72938
Reviewed-by: Genevieve Bastien <gbastien+lttng@versatic.net>
Reviewed-by: Hudson CI
Tested-by: Genevieve Bastien <gbastien+lttng@versatic.net>
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>

tmf: Bug 433518: Add support for unit of seconds in TmfTimestampFormat

The T pattern can be augmented with a suffix to indicate the unit of
seconds to be used by the format. The following patterns are supported:
T (sec), Td (deci), Tc (centi), Tm (milli), Tu (micro), Tn (nano).

The S pattern is modified to represent fractions of this unit.

Change-Id: I81014132b7579093da7761861babe0447fd30b0b
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/72840
Reviewed-by: Hudson CI
Reviewed-by: Genevieve Bastien <gbastien+lttng@versatic.net>
Tested-by: Genevieve Bastien <gbastien+lttng@versatic.net>
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>

lttng: Add configuration files to call LTTng-Analyses scripts

This patch implements configuration files to offer calling
LTTng-Analyses scripts [1] from Trace Compass.

The `index.properties` file contains a single property, `analyses`,
which is a whitespace-separated list of names of configuration files,
without the extension, to load in order to create as many LAMI
analyses.

Each configuration file contains two properties:

  * `name`: Display name of the analysis.
  * `command`: Full command to run. This string supports
    double-quoted arguments to allow arguments with whitespaces,
    or empty arguments. The `\` and `"` characters must be
    escaped with `\`.

Both properties are mandatory.

LTTng-Analyses 0.4 is supported, however 0.5 and up are recommended
since these will offer a proper progress bar and cancellation
mechanism.

[1] https://github.com/lttng/lttng-analyses

Change-Id: I3e3f7c0e8b29f1714df1f2e3acd685fc23b51e7d
Signed-off-by: Philippe Proulx <pproulx@efficios.com>
Signed-off-by: Alexandre Montplaisir <alexmonthy@efficios.com>
Reviewed-on: https://git.eclipse.org/r/72101
Reviewed-by: Hudson CI

ss: Add support for custom state values

This patch allows users to register their own state types and
they will be written to intervals.

Change-Id: If3228f4819039689f6aa3b18b8959c42a2ab7d87
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Signed-off-by: Genevieve Bastien <gbastien+lttng@versatic.net>
Reviewed-on: https://git.eclipse.org/r/69253
Reviewed-by: Hudson CI
Reviewed-by: Jean-Christian Kouame <jean-christian.kouame@ericsson.com>
Tested-by: Jean-Christian Kouame <jean-christian.kouame@ericsson.com>
Reviewed-by: Alexandre Montplaisir <alexmonthy@efficios.com>

ss: Introduce a safe byte buffer wrapper for use by custom state values

This byte buffer wrapper safely wraps a ByteBuffer inside a class that does not
allow to pass the limit or change the position so that custom state values can
safely write directly to it, without passing by byte arrays.

Change-Id: I428ee4406aa2a913d91ebc2c075bc92861286b3f
Signed-off-by: Geneviève Bastien <gbastien+lttng@versatic.net>
Reviewed-on: https://git.eclipse.org/r/72359
Reviewed-by: Jean-Christian Kouame <jean-christian.kouame@ericsson.com>
Tested-by: Jean-Christian Kouame <jean-christian.kouame@ericsson.com>
Reviewed-by: Hudson CI
Reviewed-by: Alexandre Montplaisir <alexmonthy@efficios.com>

analysis.lami: Implementation of LAMI plugins

If pre-defined scripts are present on the user's system (and on the
$PATH), options under the "External Analyses" trace sub-tree element
become available. Right-clicking on those allows running the specified
analysis, and will import the results as Reports in Trace Compass.

Reports are opened automatically when created, and will initially
display a table of the results returned by the external analysis.
The toolbar menu can then be used to generate charts from this data,
either Histograms or XY scatter plots.

Clicking on chart elemnents highlights the corresponding column in the
table, and vice versa. Also, if the data table rows contain a time
range or timestamp, integration via standard time selection signal
is done.

To not commit to final APIs yet, we've used the "internal.provisional"
naming, as described in [1].

Full user documentation and additional unit tests will follow.

Current limitations:
- The RunAnalysisHandler and others are specific to LAMI analyses,
  which means other types of OnDemandAnalyses would have to define
  their own way of being started (which may not even be through
  a right-click menu option).

[1] https://wiki.eclipse.org/Provisional_API_Guidelines

Change-Id: I188116fa2c0c9a485aabd89d49cae0d6e73136b8
Signed-off-by: Alexandre Montplaisir <alexmonthy@efficios.com>
Signed-off-by: Jonathan Rajotte <jonathan.rajotte-julien@efficios.com>
Signed-off-by: Michael Jeanson <mjeanson@efficios.com>
Signed-off-by: Philippe Proulx <pproulx@efficios.com>
Reviewed-on: https://git.eclipse.org/r/71565
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-by: Genevieve Bastien <gbastien+lttng@versatic.net>
Tested-by: Genevieve Bastien <gbastien+lttng@versatic.net>
Reviewed-by: Hudson CI

tmf: Make process and thread names optional in call stack state provider

- Update call stack state provider to allow the optional specification
of the process name for an event.

- Make the specification of the thread name for an event optional.

- Use the process id (or UKNOWN) as attribute name if the process name
is unspecified.

- Use the thread id as attribute name if the thread name is unspecified.

- Store the process id as int state value of the process attribute in
the default state provider implementation.

- Update call stack view to use the process attribute's int state value
for the process id if available, otherwise try to use the attribute name
parsed as an int.

- Use the thread attribute's long state value for the thread id if
available, otherwise try to use the attribute name parsed as a long.

Change-Id: I91fc5d3eaebaaeed6f44009a1e2185a0bfe6a878
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/71824
Reviewed-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>

lttng.ui: Add ID to LTTngCallStackAnalysis

Having the ID string makes it easier to call it up programatically.

Change-Id: I5ceb36e570a9002d3153e28154c3fbd87800e257
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/72841
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-by: Hudson CI

tmf: make checkpoint indexer return a failed status if the request fails.

Trace compass uses the TmfIndexingJob for every trace, propagating errors
in the trace reading could be done here. Before this patch, running the
job would always return Status#OK_STATUS. Now, if there is an error that
occured (the request fails) it will propagate the error instead of
swallowing it.

Change-Id: I7247de99af4c32c6747f0100d1c07275783264fd
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/67918
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Reviewed-by: Hudson CI

tmf: Make processes and threads optional in Call Stack view

- Update call stack analysis module to support possibly empty processes
pattern and threads pattern.

- Update call stack view tree structure to make process entries and
thread entries optional.

- Add icon for process entries.

- Incorporate update of call stack entry selection into
synchingToTime().

- Update synchingToTime() to use a recursive Consumer and to use cached
full states.

Change-Id: I1f850186e04f2470c8e4889c6396217373e7f923
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/71823
Reviewed-by: Hudson CI

lttng2: Move the arrows to the right of the Advanced button

Change-Id: I2198e6ec29b66070c80b9821b4940d2fecbb52cd
Signed-off-by: Bruno Roy <bruno.roy@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/72518
Reviewed-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>

doc: Updating the image for creating a session in Snapshot Mode

Change-Id: I31bc64935caa584cd5d0e8e33deef7ed098ae52b
Signed-off-by: Bruno Roy <bruno.roy@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/72549
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Reviewed-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>

doc: Update documentation of keyboard shortcuts for expand/collapse

Some keyboard shortcuts were added for expanding and collapsing
entries so we need to update the documentation.

See https://git.eclipse.org/r/#/c/70583/

Change-Id: I8ffdf4654e5dd7c6cbfd6bc9f95405a5495b9a49
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/72566
Reviewed-by: Jean-Christian Kouame <jean-christian.kouame@ericsson.com>
Tested-by: Jean-Christian Kouame <jean-christian.kouame@ericsson.com>

tmf.ui: make State System Explorer manually get analyses.

SSE already gets all analyses for every child, this patch eschews
using helper functions. Using them would actually make things more
complicated.

Change-Id: I6b72a10c38f4404d112fa88ed86e06752a39ec4d
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/72572
Reviewed-by: Hudson CI
Reviewed-by: Genevieve Bastien <gbastien+lttng@versatic.net>

analysis: Add root trace entries to Control Flow view

- Trace entries are added as root entries in the time graph tree, and
all control flow entries are now under their respective trace entry (in
hierarchical or flat presentation)

- Remove the Trace column

- Remove the trace column comparator

- The root trace entries can be sorted by name or birth time (ascending
or descending) but when sorting by TID or PTID the trace entries are
always sorted by ascending birth time.

- Remove the trace name from the ControlFlowEntry pattern matcher

- Add method to remove child from TimeGraphEntry

Change-Id: I6717855f3da727d4ca8f0ac834b2153edbb12c5c
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/72424
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Reviewed-by: Hudson CI

pcap: allow pcap StreamListView to work with experiments

Change-Id: I93e96a5f1bc5ffff00f75d790ea3b8b13c0062d9
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/71101
Reviewed-by: Hudson CI
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>

tmf: Remove unused local variable

Change-Id: I67c9c4406c1f1cb56114ee783109df71dbb0a7e9
Signed-off-by: Sonia Farrah <sonia.farrah@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/72091
Reviewed-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>

remote: remove useless String.toString()

This makes the code more efficient and also makes it clear that we are
dealing with a string.

Change-Id: Ifd88e285a4696d1fff8197ec6475665091f3de67
Signed-off-by: Sonia Farrah <sonia.farrah@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/72744
Reviewed-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>

tmf.core: make Analyses with experiments add children analyses when available.

This is a feature that allows experiments to use the analyses of their children.
The analyses are in a list so that the parent trace is always the first one.

Change-Id: I0f6ba6d38fecb49e4575bd0a4dd1d8602970f4d6
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/71100
Reviewed-by: Hudson CI
Reviewed-by: Genevieve Bastien <gbastien+lttng@versatic.net>
Tested-by: Genevieve Bastien <gbastien+lttng@versatic.net>

tmf.core: add exception logging to event requests

This is the first step towards being able to properly show errors
that occur during a trace read. The TmfEventThread already logs all
Exceptions, now the request will get the said exception.

It can then be accessed by "Request#getFailCause()" and the results
can either be handled accordingly or displayed.

Change-Id: I99242dbf6eed25c4138239dd465c16fee62bb752
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/67774
Reviewed-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>

ss: Improve getQuarks() functionality

Add support for getQuarks() relative to a starting node quark.

Add support for multiple wildcards "*" in pattern.

Add support for parent ".." in pattern.

Change-Id: Ie8d389f7f22fc74912303e1a8bd50c5d8cdfa284
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/71822
Reviewed-by: Hudson CI
Reviewed-by: Alexandre Montplaisir <alexmonthy@efficios.com>
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>

lttng: Remove lttng2.control from required plugins of kernel.core

Change-Id: Ida90534d8a107a75410712f1780f4998f00d3db9
Signed-off-by: Geneviève Bastien <gbastien+lttng@versatic.net>
Reviewed-on: https://git.eclipse.org/r/69091
Reviewed-by: Hudson CI
Reviewed-by: Jean-Christian Kouame <jean-christian.kouame@ericsson.com>
Tested-by: Jean-Christian Kouame <jean-christian.kouame@ericsson.com>

linux.core: Add messages to IllegalStateExceptions

Analysis modules now declare why they fail.

Change-Id: Idf4ec5ac0a0c7b96317512432ca8d9ab0ee4c61c
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/68875
Reviewed-by: Hudson CI
Reviewed-by: Jean-Christian Kouame <jean-christian.kouame@ericsson.com>
Tested-by: Jean-Christian Kouame <jean-christian.kouame@ericsson.com>

tmf: Add SWTBot test for the pattern latency density view

Change-Id: Iedd414c71f6511cf2fdf41da1aa2756fc9e8a049
Signed-off-by: Jean-Christian Kouame <jean-christian.kouame@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/72552
Reviewed-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>

tmf: Add SWTBot test for the pattern latency scatter chart

Change-Id: I5e73bc68a5ddf5e3cd30c0feb580338b27df4439
Signed-off-by: Jean-Christian Kouame <jean-christian.kouame@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/72551
Reviewed-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>

tmf: Add SWTBot test for the pattern latency table

Change-Id: I2573eb2add87409f40bec309ef4eb5ac386f3089
Signed-off-by: Jean-Christian Kouame <jean-christian.kouame@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/72545
Reviewed-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>

tmf: Add test suite for pattern analysis module

Change-Id: I2ae1eb7276b626c0623cdb322ddd47f7efd72c75
Signed-off-by: Jean-Christian Kouame <jean-christian.kouame@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/72373
Reviewed-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>

tmf : Add test suite for XML pattern analysis providers

Change-Id: Ic6a5cc85897e657296446bfdc86eb69cc365f2e7
Signed-off-by: Jean-Christian Kouame <jean-christian.kouame@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/72326
Reviewed-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>

tmf : Update the XML valid pattern test file

Change-Id: I5b4bd363f4ac47423e5799ed33cdd3b1981f9d08
Signed-off-by: Jean-Christian Kouame <jean-christian.kouame@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/72325
Reviewed-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>

common.core: No longer swallow exceptions in bbq

IllegalStateExceptions now propagate the parent exceptions.

Change-Id: I0cfb47c19d4462a04b9a009e72b1df372736cc6f
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/68874
Reviewed-by: Hudson CI
Reviewed-by: Jean-Christian Kouame <jean-christian.kouame@ericsson.com>

ctf: Better explain IllegalStateException

Show a reason for the illegal state exception.

Change-Id: Ibf99b1bc6b3bc94c20fab6307b62d35d21e12096
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/68873
Reviewed-by: Hudson CI
Reviewed-by: Jean-Christian Kouame <jean-christian.kouame@ericsson.com>

analysis: internalize segment store stats messages

Change-Id: I62d9de2df0f0b24ce41485bf31d96a2b62ee47c1
Signed-off-by: Bernd Hufmann <Bernd.Hufmann@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/72496
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-by: Hudson CI

tmf: Fix possible overflows in TmfXmlTimestampCondition

Change-Id: I64754ecb61a8026a711d705ccf7855280aaa400a
Signed-off-by: Jean-Christian Kouame <jean-christian.kouame@ericsson.com>

analysis: add menu to go to min or max from the segment start stats

Change-Id: Ia8d66fdc69a60f93c6e87d417e4798b415a31884
Signed-off-by: Bernd Hufmann <Bernd.Hufmann@ericsson.com>

requirements: Implement all level for event names and fields

All requirement priority levels are implemented for the 2 built-in types of
requirement: TmfAnalysisEventRequirement and TmfAnalysisEventFieldRequirement

Change-Id: I513f9a767ac32c23d8fa27702834271008a65d51
Signed-off-by: Geneviève Bastien <gbastien+lttng@versatic.net>

requirements: make TmfAnalysisRequirement abstract

Change-Id: I87d7e2d1da00fb1ac023fdeb4b38734e10aa6807
Signed-off-by: Geneviève Bastien <gbastien+lttng@versatic.net>

lttng.ust: Update callstack requirement with composite requirements

This also allows to verify that entry and exit events match

Change-Id: I4d59ea02d6d4c376b4f8d1b92e3b899d874c8d8e
Signed-off-by: Geneviève Bastien <gbastien+lttng@versatic.net>

requirements: Add a composite requirement

This allows to group requirement together with one of the defined priority
level.

Change-Id: Ic88fe6c6d679f107244bd366d4d37816c9508b19
Signed-off-by: Geneviève Bastien <gbastien+lttng@versatic.net>

requirements: Clean up the API of TmfAnalysisRequirement

* Remove the 'fType' field in favor of sub-classing
* Remove the possibility to merge requirements, a composite requirement will
be added in a later patch
* Have the priority level be for the whole requirement instead of per-values
* Values cannot be added except at the constructor
* Remove requirement helper class and tests: the methods there referred to the
type which does not exist anymore.

Change-Id: I01897cd705452833cbdbe6c57dd819a5a1ecfd22
Signed-off-by: Geneviève Bastien <gbastien+lttng@versatic.net>

tmf: fix displaying of analysis properties in Properties view

With this fix the analysis properties, e.g. ID, size on disk or
backend type (for state system analyses) are shown again.

Change-Id: Iea1a673e56f66405ed8e265d0763003aef7c4979
Signed-off-by: Bernd Hufmann <Bernd.Hufmann@ericsson.com>

lttng.ui: Add SWTBot test for CPU selection signals.

This changes the behavior of the TmfTreeViewer by converting
a thread to a job.

Change-Id: I4369c8ef9cddf7b64dc1e526cce401a0e2472bec
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>

ss: Add a custom state value type

This patch just adds the type and updates all the switch cases.

It does nothing else for now, but it reduces the noise of the
other patch which actually adds the behavior of the custom value.

Change-Id: Ie16b2ff851968edc581f14abce175f0c0f2c6cc3
Signed-off-by: Genevieve Bastien <gbastien+lttng@versatic.net>
Reviewed-on: https://git.eclipse.org/r/70173
Reviewed-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-by: Alexandre Montplaisir <alexmonthy@efficios.com>

tmf: add experiment type ID property to be displayed in Properties view

This information is needed when creating XML analysis once it's
supported by the data-driven analysis.

Change-Id: I0cc632e040595082610afdc8ed07cbb7051d664e
Signed-off-by: Bernd Hufmann <Bernd.Hufmann@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/72083
Reviewed-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>

tmf: add trace type ID property to be displayed in Properties view

This information is needed when creating XML analysis. User have no
other way to know the ID (unless looking into Trace Compass source
code)

Change-Id: I7463c84ed0e7b480ba52984e485fe7354ed4d2cd
Signed-off-by: Bernd Hufmann <Bernd.Hufmann@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/72082
Reviewed-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>

tmf: Replace IllegalStateException with Activator.logError()

IllegalStateException was raised when the action cannot be found. This
patch avoids to block the UI when the problem happens.

Change-Id: Ied85dd924a6fa330b165d5d10027c92f20e2f14d
Signed-off-by: Jean-Christian Kouame <jean-christian.kouame@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/71529
Reviewed-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>

common: Make data size and speed formatters static

They cannot be constructed anymore, they can be retrieved through a

Also fix the format when the type is not a Number, it should still append the
value to the string.

Change-Id: I42968def6be830589caac3c824d85a5056121f30
Signed-off-by: Geneviève Bastien <gbastien+lttng@versatic.net>
Reviewed-on: https://git.eclipse.org/r/71172
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-by: Hudson CI

tmf: Bug 484042: Fix source code lookup within the workspace

If the source code is not found using the path provided by the
source callsite the workspace will be searched using the file name
instead.

Change-Id: I033e7d87ef0918f796f9010d54f3d9f378856078
Signed-off-by: Bernd Hufmann <Bernd.Hufmann@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/71735
Reviewed-by: Alexandre Montplaisir <alexmonthy@efficios.com>
Reviewed-by: Hudson CI
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>

analysis.io: Make the main package internal for now

This analysis was added very close to API freeze and it is not ready yet to be
made API, so for now, it should be kept x-friend only with tests and ui

Change-Id: I923f38f6c8915b3f47ae934d01221397b0fefc7d
Signed-off-by: Geneviève Bastien <gbastien+lttng@versatic.net>
Reviewed-on: https://git.eclipse.org/r/71703
Reviewed-by: Hudson CI

tmf: Disable StateSystemAnalysisModuleTest#testIsQueryableCancel

Times out on Hudson, probably due to a race condition. Failed on
https://git.eclipse.org/r/#/c/71565/ 4 times in a row.

Change-Id: I125dc94002ec21161f6bee05fa2dd2820df59406
Signed-off-by: Alexandre Montplaisir <alexmonthy@efficios.com>
Reviewed-on: https://git.eclipse.org/r/72353
Reviewed-by: Hudson CI

linux.ui: Fix typo in chart title.

Change-Id: Ia5c4caa301df61c7b72b32546263b695342f1751
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/72356
Reviewed-by: Hudson CI
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>

analysis.os: bug 488757: Let the KernelTidAspect block if not queryable

This aspect implements the blocking resolve method and, if the caller
wishes, will block until the analysis is ready to be queried at the
time of the event. A progress monitor is used to allow for cancelling
the blocking call.

This patch updates the system call latency analysis to block.

Change-Id: Ie858bb4ed8984f6320af443030db4950ab5f7927
Signed-off-by: Geneviève Bastien <gbastien+lttng@versatic.net>
Reviewed-on: https://git.eclipse.org/r/71604
Reviewed-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>

tmf.core: Add a resolve method to IEventAspect with a block parameter

That method can be implemented by aspects whose resolution depend on an
analysis and the result of the resolve may not be available at the time of
query.

Change-Id: I01f05b1eff4a5a6d56b9fd6375ba9ee7636e1a11
Signed-off-by: Geneviève Bastien <gbastien+lttng@versatic.net>
Reviewed-on: https://git.eclipse.org/r/71603
Reviewed-by: Hudson CI
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>

analysis.kernel: bug 491276 Add a getPriority method to KernelThreadInformationProvider

This removes the need to x-friend internal.analysis.os.linux.core.kernel with
lttng2.kernel.core

Change-Id: I75d18c42e9da5bef884cd76209b63ad5db6a7e8c
Signed-off-by: Geneviève Bastien <gbastien+lttng@versatic.net>
Reviewed-on: https://git.eclipse.org/r/71180
Reviewed-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>

lttng: Update statedump event names for UST 2.8

LTTng 2.8 RC2 changes the name of the "soinfo" event to "bin_info".
Also, its "sopath" field becomes just "path".

No point supporting the older names since it was never part of a
released version.

See https://lists.lttng.org/pipermail/lttng-dev/2016-April/025764.html

Update corresponding tests to use the new DEBUG_INFO3 which has
the updated event names.

Change-Id: Ibfe5701d7cc281d2a055f36eb5f0a1a90caab6ec
Signed-off-by: Alexandre Montplaisir <alexmonthy@efficios.com>
Reviewed-on: https://git.eclipse.org/r/72241
Reviewed-by: Hudson CI
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>

releng: Update to tracecompass-test-traces 1.4.0

It contains an updated test for the LTTng-UST Debug Info
feature. The previous one is now deprecated.

Change-Id: Icfe36bc4d8e9283bd1631aa5750522d816abed6a
Signed-off-by: Alexandre Montplaisir <alexmonthy@efficios.com>
Reviewed-on: https://git.eclipse.org/r/72240
Reviewed-by: Hudson CI
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>

lttng: Handle unknown line numbers in addr2line output

addr2line can return "filename.c:?" when it knows a file name
but not its number. Do not attempt to parse "?" as a Long, you
will fail miserably.

Also change the odd/even flip to the start of the loop: the
presence of "continue" statements could skip that operation.

Change-Id: Ia685e91833c6c472decfd3fd21acf7ad70d1ae34
Signed-off-by: Alexandre Montplaisir <alexmonthy@efficios.com>
Reviewed-on: https://git.eclipse.org/r/72118
Reviewed-by: Hudson CI
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>

tmf: update icon for views project element

Change-Id: I66a01867c6ddef95d7db4b6b9f452273bf85b59c
Signed-off-by: Bernd Hufmann <Bernd.Hufmann@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/72210
Reviewed-by: Hudson CI
Reviewed-by: Alexandre Montplaisir <alexmonthy@efficios.com>
Tested-by: Alexandre Montplaisir <alexmonthy@efficios.com>

tmf.tests: Add tests for TmfStateSystemModule#isQueryable(long)

This forces to add behavior to the test state provider so it is possible to
fine tune the event processing by adding a method to process events one at a
time and signal the provider to process the next event.

Change-Id: I999ccd8494c90efce42ba1dc9d59d73b8d018a84
Signed-off-by: Geneviève Bastien <gbastien+lttng@versatic.net>
Reviewed-on: https://git.eclipse.org/r/71153
Reviewed-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>

tmf: Do not define base aspects in the interface

Instead, create a class with static getters for those aspects

This avoids initialization exceptions when adding a default method in the
interface

Change-Id: I490755e95dedaebaebd0439710c14077010907eb
Signed-off-by: Geneviève Bastien <gbastien+lttng@versatic.net>
Reviewed-on: https://git.eclipse.org/r/71798
Reviewed-by: Hudson CI
Reviewed-by: Alexandre Montplaisir <alexmonthy@efficios.com>
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>

analysis: Bug 492404 Make ThreadInformationProvider support TID 0

This helps virtual cpu view that was broken by the thread 0_x tid patch

Change-Id: I27971a1c21c5d325d014baeb3d19211ad34a70f5
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/71372
Reviewed-by: Michael Jeanson <mjeanson@efficios.com>
Reviewed-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>

tmf: Fix SWTException in TimeGraphCombo

The combo can get disposed while an async Runnable has been queued.

Change-Id: I942337d2ffcd34e9281f942a5a387058094386b0
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/72209
Reviewed-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>

analysis.lami: Add a plugin for core tests

Change-Id: I49bb641ea07225d5036976593958da5400a302e0
Signed-off-by: Alexandre Montplaisir <alexmonthy@efficios.com>
Reviewed-on: https://git.eclipse.org/r/71567
Reviewed-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>

lttng2: Simplify boolean expression

Change-Id: I368354e936be2af10b6abcb6160fab8e45a9ee44
Signed-off-by: Sonia Farrah <sonia.farrah@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/72099
Reviewed-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>

linux.ui: Add Threads Presentation to View Menu of the CFV

This patch adds a threads presentation item to the view menu
(the triangular menu in the top right corner of the view) of
the control flow view, in order to select which presentation
mode is needed.

At the moment, the options offered are:
 * Hierarchical
 * Flat

Others may come later such as clamping by time...

These menus are the first step towards grouping threads by
affinity.

Change-Id: I65a71ad4a5eb6489f668f8b5806f12702f43edbc
Signed-off-by: Mahdi Zolnouri <mzolnouri@yahoo.com>
Signed-off-by: Samuel Gagnon <samuel.gagnon92@gmail.com>
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/68231
Reviewed-by: Hudson CI

tmf: make CallstackProvider entry and exit return TmfStates

This allows certain callstacks to return simpler long or int
states instead of a string. Expect SIGNIFICANT space savings.

In an example application, ls was traced (coreutils 8
with -finstrument-functions)

For a 149 mb trace with no lost events.

State system size
before:
233 mb
after:
25mb

Total time for trace compass fullscreen (1920x1080)

read the trace and build the state systems:
before:
61.5 sec
after:
44.0 sec

average seek time (100ms window, 10 random locations)
before:
1.2 sec
after:
0.6 s

Change-Id: Ic868829296d92d854cda7b78784b6ee3be4d5a51
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/70719
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-by: Hudson CI

tmf: Bug492895: Avoid unnecessary refreshes during import operation

This is achieved by using the TmfWorkspaceModifyOperation which
defers the refresh to the end of the operation. Also, setting a trace
type won't refresh the project explorer anymore. The refresh will
be handled at the end of the operation.

Change-Id: I302d54d18b8640b833fc964d5fe74eca06057c15
Signed-off-by: Bernd Hufmann <Bernd.Hufmann@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/71908
Reviewed-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Patrick Tasse <patrick.tasse@gmail.com>