From 1ad849b8ebf8c33b682f5a7999c133208915e2d4 Mon Sep 17 00:00:00 2001 From: Wassim Date: Wed, 25 May 2016 17:36:26 -0400 Subject: [PATCH] pcap.core: making some classes final This patch is to make some classes final in pcap.core component. It should be final to improve readability and since you should never extend it. It also allows the jvm to inline methods and improve performance. Change-Id: I7288b25324cb343a33cf6536b80cdaae3619211f Signed-off-by: Wassim Reviewed-on: https://git.eclipse.org/r/73671 Reviewed-by: Hudson CI Reviewed-by: Matthew Khouzam Tested-by: Matthew Khouzam Reviewed-by: Genevieve Bastien Tested-by: Genevieve Bastien --- .../tmf/pcap/core/event/aspect/PcapDestinationAspect.java | 2 +- .../internal/tmf/pcap/core/event/aspect/PcapProtocolAspect.java | 2 +- .../tmf/pcap/core/event/aspect/PcapReferenceAspect.java | 2 +- .../internal/tmf/pcap/core/event/aspect/PcapSourceAspect.java | 2 +- .../internal/tmf/pcap/core/util/PcapEventFactory.java | 2 +- 5 files changed, 5 insertions(+), 5 deletions(-) diff --git a/pcap/org.eclipse.tracecompass.tmf.pcap.core/src/org/eclipse/tracecompass/internal/tmf/pcap/core/event/aspect/PcapDestinationAspect.java b/pcap/org.eclipse.tracecompass.tmf.pcap.core/src/org/eclipse/tracecompass/internal/tmf/pcap/core/event/aspect/PcapDestinationAspect.java index f25e13d3e7..815dc14780 100644 --- a/pcap/org.eclipse.tracecompass.tmf.pcap.core/src/org/eclipse/tracecompass/internal/tmf/pcap/core/event/aspect/PcapDestinationAspect.java +++ b/pcap/org.eclipse.tracecompass.tmf.pcap.core/src/org/eclipse/tracecompass/internal/tmf/pcap/core/event/aspect/PcapDestinationAspect.java @@ -25,7 +25,7 @@ import org.eclipse.tracecompass.tmf.core.event.aspect.ITmfEventAspect; * * @author Alexandre Montplaisir */ -public class PcapDestinationAspect implements ITmfEventAspect { +public final class PcapDestinationAspect implements ITmfEventAspect { /** Singleton instance */ public static final PcapDestinationAspect INSTANCE = new PcapDestinationAspect(); diff --git a/pcap/org.eclipse.tracecompass.tmf.pcap.core/src/org/eclipse/tracecompass/internal/tmf/pcap/core/event/aspect/PcapProtocolAspect.java b/pcap/org.eclipse.tracecompass.tmf.pcap.core/src/org/eclipse/tracecompass/internal/tmf/pcap/core/event/aspect/PcapProtocolAspect.java index 304a240195..eef3821f4a 100644 --- a/pcap/org.eclipse.tracecompass.tmf.pcap.core/src/org/eclipse/tracecompass/internal/tmf/pcap/core/event/aspect/PcapProtocolAspect.java +++ b/pcap/org.eclipse.tracecompass.tmf.pcap.core/src/org/eclipse/tracecompass/internal/tmf/pcap/core/event/aspect/PcapProtocolAspect.java @@ -25,7 +25,7 @@ import org.eclipse.tracecompass.tmf.core.event.aspect.ITmfEventAspect; * * @author Alexandre Montplaisir */ -public class PcapProtocolAspect implements ITmfEventAspect { +public final class PcapProtocolAspect implements ITmfEventAspect { /** Singleton instance */ public static final PcapProtocolAspect INSTANCE = new PcapProtocolAspect(); diff --git a/pcap/org.eclipse.tracecompass.tmf.pcap.core/src/org/eclipse/tracecompass/internal/tmf/pcap/core/event/aspect/PcapReferenceAspect.java b/pcap/org.eclipse.tracecompass.tmf.pcap.core/src/org/eclipse/tracecompass/internal/tmf/pcap/core/event/aspect/PcapReferenceAspect.java index 032c3f2711..93a400b9da 100644 --- a/pcap/org.eclipse.tracecompass.tmf.pcap.core/src/org/eclipse/tracecompass/internal/tmf/pcap/core/event/aspect/PcapReferenceAspect.java +++ b/pcap/org.eclipse.tracecompass.tmf.pcap.core/src/org/eclipse/tracecompass/internal/tmf/pcap/core/event/aspect/PcapReferenceAspect.java @@ -24,7 +24,7 @@ import org.eclipse.tracecompass.tmf.core.event.aspect.ITmfEventAspect; * * @author Alexandre Montplaisir */ -public class PcapReferenceAspect implements ITmfEventAspect { +public final class PcapReferenceAspect implements ITmfEventAspect { /** Singleton instance */ public static final PcapReferenceAspect INSTANCE = new PcapReferenceAspect(); diff --git a/pcap/org.eclipse.tracecompass.tmf.pcap.core/src/org/eclipse/tracecompass/internal/tmf/pcap/core/event/aspect/PcapSourceAspect.java b/pcap/org.eclipse.tracecompass.tmf.pcap.core/src/org/eclipse/tracecompass/internal/tmf/pcap/core/event/aspect/PcapSourceAspect.java index e43d116dbc..7b4eb48c0f 100644 --- a/pcap/org.eclipse.tracecompass.tmf.pcap.core/src/org/eclipse/tracecompass/internal/tmf/pcap/core/event/aspect/PcapSourceAspect.java +++ b/pcap/org.eclipse.tracecompass.tmf.pcap.core/src/org/eclipse/tracecompass/internal/tmf/pcap/core/event/aspect/PcapSourceAspect.java @@ -28,7 +28,7 @@ import org.eclipse.tracecompass.tmf.core.event.aspect.ITmfEventAspect; * * @author Alexandre Montplaisir */ -public class PcapSourceAspect implements ITmfEventAspect { +public final class PcapSourceAspect implements ITmfEventAspect { /** Singleton instance */ public static final PcapSourceAspect INSTANCE = new PcapSourceAspect(); diff --git a/pcap/org.eclipse.tracecompass.tmf.pcap.core/src/org/eclipse/tracecompass/internal/tmf/pcap/core/util/PcapEventFactory.java b/pcap/org.eclipse.tracecompass.tmf.pcap.core/src/org/eclipse/tracecompass/internal/tmf/pcap/core/util/PcapEventFactory.java index f5efb7c075..26077c5f95 100644 --- a/pcap/org.eclipse.tracecompass.tmf.pcap.core/src/org/eclipse/tracecompass/internal/tmf/pcap/core/util/PcapEventFactory.java +++ b/pcap/org.eclipse.tracecompass.tmf.pcap.core/src/org/eclipse/tracecompass/internal/tmf/pcap/core/util/PcapEventFactory.java @@ -44,7 +44,7 @@ import org.eclipse.tracecompass.tmf.core.timestamp.TmfTimestamp; * * @author Vincent Perot */ -public class PcapEventFactory { +public final class PcapEventFactory { private static final String EMPTY_STRING = ""; //$NON-NLS-1$ -- 2.34.1