From 516a0f0f213544918ace0b0b80b224c215abf95d Mon Sep 17 00:00:00 2001 From: Marc-Andre Laperle Date: Tue, 1 Nov 2016 09:23:12 -0400 Subject: [PATCH] analysis: Add additional assertion to troubleshoot test failure The axis range in the tested SWTChart doesn't have the correct range. It would be interesting to know if the window range of the trace is correct. Change-Id: I001787016a5b3d78b83b526175d8a1e9656e2790 Signed-off-by: Marc-Andre Laperle Reviewed-on: https://git.eclipse.org/r/84277 Reviewed-by: Matthew Khouzam Tested-by: Matthew Khouzam Reviewed-by: Hudson CI --- .../latency/SystemCallLatencyScatterChartViewTest.java | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/analysis/org.eclipse.tracecompass.analysis.os.linux.ui.swtbot.tests/src/org/eclipse/tracecompass/analysis/os/linux/ui/swtbot/tests/latency/SystemCallLatencyScatterChartViewTest.java b/analysis/org.eclipse.tracecompass.analysis.os.linux.ui.swtbot.tests/src/org/eclipse/tracecompass/analysis/os/linux/ui/swtbot/tests/latency/SystemCallLatencyScatterChartViewTest.java index d2940d3549..87c7fd642d 100644 --- a/analysis/org.eclipse.tracecompass.analysis.os.linux.ui.swtbot.tests/src/org/eclipse/tracecompass/analysis/os/linux/ui/swtbot/tests/latency/SystemCallLatencyScatterChartViewTest.java +++ b/analysis/org.eclipse.tracecompass.analysis.os.linux.ui.swtbot.tests/src/org/eclipse/tracecompass/analysis/os/linux/ui/swtbot/tests/latency/SystemCallLatencyScatterChartViewTest.java @@ -24,6 +24,7 @@ import org.apache.log4j.ConsoleAppender; import org.apache.log4j.Logger; import org.apache.log4j.SimpleLayout; import org.eclipse.core.runtime.FileLocator; +import org.eclipse.jdt.annotation.NonNull; import org.eclipse.swtbot.eclipse.finder.SWTWorkbenchBot; import org.eclipse.swtbot.eclipse.finder.widgets.SWTBotView; import org.eclipse.swtbot.swt.finder.exceptions.WidgetNotFoundException; @@ -39,6 +40,7 @@ import org.eclipse.tracecompass.tmf.core.signal.TmfSignalManager; import org.eclipse.tracecompass.tmf.core.signal.TmfWindowRangeUpdatedSignal; import org.eclipse.tracecompass.tmf.core.timestamp.TmfTimeRange; import org.eclipse.tracecompass.tmf.core.timestamp.TmfTimestamp; +import org.eclipse.tracecompass.tmf.core.trace.TmfTraceManager; import org.eclipse.tracecompass.tmf.ui.swtbot.tests.shared.ConditionHelpers; import org.eclipse.tracecompass.tmf.ui.swtbot.tests.shared.SWTBotUtils; import org.eclipse.tracecompass.tmf.ui.tests.shared.WaitUtils; @@ -179,8 +181,10 @@ public class SystemCallLatencyScatterChartViewTest { SWTBotChart chartBot = new SWTBotChart(scatterChart); assertVisible(chartBot); assertEquals("", chartBot.getToolTipText()); + @NonNull TmfTimeRange traceWindowRange = TmfTraceManager.getInstance().getCurrentTraceContext().getWindowRange(); + assertEquals("Unexpected trace window range", 100000000, traceWindowRange.getEndTime().getValue() - traceWindowRange.getStartTime().getValue()); Range range = scatterChart.getAxisSet().getXAxes()[0].getRange(); - assertEquals(100000000, range.upper - range.lower, 0); + assertEquals("Unexpected X-axis range", 100000000, range.upper - range.lower, 0); ISeriesSet seriesSet = fScatterChart.getSeriesSet(); assertNotNull(seriesSet); ISeries[] series = seriesSet.getSeries(); -- 2.34.1