From: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Date: Fri, 24 Nov 2023 22:40:32 +0000 (-0500)
Subject: Remove packed from visitor ABI
X-Git-Url: http://git.efficios.com/?p=libside.git;a=commitdiff_plain;h=9053485b439e5dc62d5529321ab3f663e951e96d

Remove packed from visitor ABI

The visitor ABI is a contract between instrumented applications and
userspace tracers only, and follows C calling convention, so packing
those data structures serve no purpose.

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
---

diff --git a/include/side/abi/visitor.h b/include/side/abi/visitor.h
index 10069ea..a0ce76e 100644
--- a/include/side/abi/visitor.h
+++ b/include/side/abi/visitor.h
@@ -28,7 +28,6 @@ struct side_arg_dynamic_field;
 struct side_tracer_visitor_ctx;
 struct side_tracer_dynamic_struct_visitor_ctx;
 
-
 typedef enum side_visitor_status (*side_write_elem_func)(
 		const struct side_tracer_visitor_ctx *tracer_ctx,
 		const struct side_arg *elem);
@@ -39,7 +38,7 @@ typedef enum side_visitor_status (*side_visitor_func)(
 struct side_tracer_visitor_ctx {
 	side_write_elem_func write_elem;
 	void *priv;		/* Private tracer context. */
-} SIDE_PACKED;
+};
 
 typedef enum side_visitor_status (*side_write_field_func)(
 		const struct side_tracer_dynamic_struct_visitor_ctx *tracer_ctx,
@@ -51,6 +50,6 @@ typedef enum side_visitor_status (*side_dynamic_struct_visitor_func)(
 struct side_tracer_dynamic_struct_visitor_ctx {
 	side_write_field_func write_field;
 	void *priv;		/* Private tracer context. */
-} SIDE_PACKED;
+};
 
 #endif /* SIDE_ABI_VISITOR_H */